Rewrite generate-xcfilelists in Python
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-15  Keith Rollin  <krollin@apple.com>
2
3         Rewrite generate-xcfilelists in Python
4         https://bugs.webkit.org/show_bug.cgi?id=197622
5         <rdar://problem/50508222>
6
7         Reviewed by Jonathan Bedard, Alex Christensen.
8
9         For a number of reasons, rewrite generate-xcfilelists in Python:
10
11         - The previous bash script was large and unmaintainable.
12         - We have more internal expertise with Python than with bash.
13         - The bash script used temporary files in /tmp that got stranded and
14           were owned by root, making them awkward to clear out.
15           <rdar://problem/49490262>
16         - We needed to complete support for engineers that built with Xcode
17           rather than the command line.
18         - There are some bugs leading to mildly corrupted .xcfilelist files.
19           It's not apparent the source of the bugs, but one general reason
20           might be due to approaches born of using bash. Rewriting in Python
21           may clear these up.
22
23         * Scripts/generate-xcfilelists:
24         * Scripts/webkitpy/common/attribute_saver.py: Added.
25         (AttributeSaver):
26         (AttributeSaver.__init__):
27         (AttributeSaver.__enter__):
28         (AttributeSaver.__exit__):
29         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
30         (AttributeSaverTest):
31         (AttributeSaverTest.SimpleTestClass):
32         (AttributeSaverTest.SimpleTestClass.__init__):
33         (AttributeSaverTest.test_class):
34         (AttributeSaverTest.test_normal_default):
35         (AttributeSaverTest.test_normal_value):
36         (AttributeSaverTest.test_normal_value_on_exception):
37         (AttributeSaverTest.test_normal_value_on_normal_exit):
38         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
39         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
40         (AttributeSaverTest.test_normal_value_with_else_on_exception):
41         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
42         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
43         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
44         (Application):
45         (Application.__init__):
46         (Application.run):
47         (Application._initialize):
48         (Application._initialize.collect_attributes):
49         (Application._create_parser):
50         (_validate_args):
51         (_cmd_generate):
52         (_cmd_check):
53         (_cmd_subgenerate):
54         (_cmd_help):
55         (_do_generate):
56         (_do_merge):
57         (_report_results):
58         (_report_merge_results):
59         (_report_remediation_steps):
60         (_report_remediation_steps.add_to_message):
61         (_any_have_errors):
62         (_any_have_actions):
63         (_log_progress):
64         (_log_results):
65         (get_generate_xcfilelists_script_path):
66         (_get_root_dir):
67         (get_opensource_dir):
68         (get_build_scripts_dir):
69         (get_extract_dependencies_from_makefile_script):
70         (get_xcode_built_products_dir):
71         (_getenv):
72         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
73         (BaseGenerator):
74         (BaseGenerator.__init__):
75         (BaseGenerator.__str__):
76         (BaseGenerator.generate):
77         (BaseGenerator._sublaunch_under_xcode):
78         (BaseGenerator.subgenerate):
79         (BaseGenerator.merge):
80         (BaseGenerator.pickle_to_file):
81         (BaseGenerator.has_action):
82         (BaseGenerator.has_error):
83         (BaseGenerator.is_valid):
84         (BaseGenerator.report_error):
85         (BaseGenerator._generate_derived):
86         (BaseGenerator._merge_derived):
87         (BaseGenerator._generate_unified):
88         (BaseGenerator._merge_unified):
89         (BaseGenerator._replace):
90         (BaseGenerator._unexpand):
91         (BaseGenerator._find_added_lines):
92         (BaseGenerator._merge_added_lines):
93         (BaseGenerator._get_file_lines):
94         (BaseGenerator._getenv):
95         (BaseGenerator._get_project_file_path):
96         (BaseGenerator._get_project_dir):
97         (BaseGenerator._get_project_file_name):
98         (BaseGenerator._get_project_name):
99         (BaseGenerator._get_sym_root):
100         (BaseGenerator._get_obj_root):
101         (BaseGenerator._get_shared_precomps_dir):
102         (BaseGenerator._get_build_dirs):
103         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
104         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
105         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
106         (BaseGenerator._get_derived_sources_dir):
107         (BaseGenerator._get_xcfilelist_dir):
108         (BaseGenerator._get_input_derived_xcfilelist_project_path):
109         (BaseGenerator._get_output_derived_xcfilelist_project_path):
110         (BaseGenerator._get_input_unified_xcfilelist_project_path):
111         (BaseGenerator._get_output_unified_xcfilelist_project_path):
112         (BaseGenerator._get_generate_derived_sources_script):
113         (BaseGenerator._get_generate_unified_sources_script):
114         (JavaScriptCoreGenerator):
115         (JavaScriptCoreGenerator._get_project_file_path):
116         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
117         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
118         (WebCoreGenerator):
119         (WebCoreGenerator._get_project_file_path):
120         (WebCoreGenerator._get_generate_derived_sources_script):
121         (WebCoreGenerator._get_generate_unified_sources_script):
122         (WebKitGenerator):
123         (WebKitGenerator._get_project_file_path):
124         (WebKitGenerator._get_derived_sources_dir):
125         (WebKitGenerator._get_generate_derived_sources_script):
126         (WebKitGenerator._get_generate_unified_sources_script):
127         (DumpRenderTreeGenerator):
128         (DumpRenderTreeGenerator._get_project_file_path):
129         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
130         (WebKitTestRunnerGenerator):
131         (WebKitTestRunnerGenerator._get_project_file_path):
132         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
133         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
134         (debug_log):
135         (LogEntryHelper):
136         (LogEntryHelper.__init__):
137         (LogEntryHelper.log_entry):
138         (LogEntryHelper.log_result):
139         (LogEntryHelper.log_exception):
140         (LogEntryHelper._print):
141         (LogEntryExit):
142         (LogEntryExit._show_debug_logging):
143         (LogEntryExitClass):
144         (LogEntryExitClass._show_debug_logging):
145         (LogEntryExitGlobal):
146         (LogEntryExitGlobal._show_debug_logging):
147         (subprocess_run):
148         (is_running_under_xcode):
149         (CheckValidItemAction):
150         (CheckValidItemAction.__init__):
151         (CheckValidItemAction.__call__):
152         (CheckValidItemAction.validate_item):
153         (CheckCommandAction):
154         (CheckCommandAction.__call__):
155         (InvalidCommandError):
156         (InvalidArgumentError):
157         (InvalidConfigurationError):
158         (CalledProcessError):
159         (CalledProcessError.__str__):
160         * Scripts/webkitpy/xcode/__init__.py:
161         (xcode_hash_for_path):
162         (xcode_hash_for_path.convert_to_string):
163         * Scripts/webkitpy/xcode/sdk.py: Added.
164         (SDK):
165         (SDK.__init__):
166         (SDK.__repr__):
167         (SDK.as_xcode_specification):
168         (SDK.get_preferred_sdk_for_platform):
169         (SDK._parse_sdk):
170         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
171         (SDKTest):
172
173 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
174
175         [ews-build] Enabling uploading EWS archives to S3
176         https://bugs.webkit.org/show_bug.cgi?id=197914
177
178         Reviewed by Jonathan Bedard.
179
180         * BuildSlaveSupport/Shared: Added.
181         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
182         (archiveExists): Replace tab with space.
183         (main): Added main method.
184         * BuildSlaveSupport/build.webkit.org-config/steps.py:
185         (TransferToS3): Updated path to the script.
186         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
187
188 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
189
190         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
191         https://bugs.webkit.org/show_bug.cgi?id=197916
192         <rdar://problem/50815427>
193
194         Reviewed by Timothy Hatcher.
195
196         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
197         inputmode="numeric".
198
199         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
200         (TestWebKitAPI::TEST):
201
202 2019-05-15  Youenn Fablet  <youenn@apple.com>
203
204         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
205         https://bugs.webkit.org/show_bug.cgi?id=197463
206         <rdar://problem/47403621>
207
208         Reviewed by Alex Christensen.
209
210         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
211         (-[QuotaDelegate init]):
212         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
213         (-[QuotaDelegate quotaDelegateCalled]):
214         (-[QuotaDelegate grantQuota]):
215         (-[StorageSchemes webView:startURLSchemeTask:]):
216         (-[StorageSchemes webView:stopURLSchemeTask:]):
217         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
218         (doTest):
219
220 2019-05-15  Youenn Fablet  <youenn@apple.com>
221
222         Constant crashes under WebPage::isThrottleable() after r245299
223         https://bugs.webkit.org/show_bug.cgi?id=197902
224         <rdar://problem/50793796>
225
226         Reviewed by Alex Christensen.
227
228         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
229
230 2019-05-15  Philippe Normand  <pnormand@igalia.com>
231
232         [GTK][jhbuild] misc cleanups and bumps
233         https://bugs.webkit.org/show_bug.cgi?id=197913
234
235         Reviewed by Xabier Rodriguez-Calvar.
236
237         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
238         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
239
240 2019-05-15  Chris Dumez  <cdumez@apple.com>
241
242         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
243         https://bugs.webkit.org/show_bug.cgi?id=195102
244         <rdar://problem/48456786>
245
246         Reviewed by Alex Christensen.
247
248         Try to wait longer for the number of processes to reach the expected number
249         and before failing.
250
251         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
252
253 2019-05-15  Alex Christensen  <achristensen@webkit.org>
254
255         Allow NSFileCoordinator to be called from WebContent process
256         https://bugs.webkit.org/show_bug.cgi?id=197895
257         <rdar://problem/50107679>
258
259         Reviewed by Brent Fulgham.
260
261         Add a unit test that verifies calling the block succeeds.
262
263         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
264         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
265
266 2019-05-14  Andy Estes  <aestes@apple.com>
267
268         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
269         https://bugs.webkit.org/show_bug.cgi?id=197751
270         <rdar://problem/50631563>
271
272         Reviewed by Alex Christensen.
273
274         Added new API tests.
275
276         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
277         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
278         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
279         (TestWebKitAPI::TEST):
280         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
281         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
282
283 2019-05-14  Youenn Fablet  <youenn@apple.com>
284
285         A service worker process should app nap when all its clients app nap
286         https://bugs.webkit.org/show_bug.cgi?id=185626
287         <rdar://problem/46785908>
288
289         Reviewed by Alex Christensen.
290
291         Allow to enable app nap through test header.
292
293         * WebKitTestRunner/TestController.cpp:
294         (WTR::TestController::resetPreferencesToConsistentValues):
295         (WTR::updateTestOptionsFromTestHeader):
296         * WebKitTestRunner/TestOptions.h:
297         (WTR::TestOptions::hasSameInitializationOptions const):
298
299 2019-05-14  Commit Queue  <commit-queue@webkit.org>
300
301         Unreviewed, rolling out r245281.
302         https://bugs.webkit.org/show_bug.cgi?id=197887
303
304         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
305         (Requested by aakashjain on #webkit).
306
307         Reverted changeset:
308
309         "Add a unit test for client certificate authentication"
310         https://bugs.webkit.org/show_bug.cgi?id=197800
311         https://trac.webkit.org/changeset/245281
312
313 2019-05-14  Youenn Fablet  <youenn@apple.com>
314
315         Add support for webkit-test-runner options to WPT importer
316         https://bugs.webkit.org/show_bug.cgi?id=197826
317
318         Reviewed by Alex Christensen.
319
320         In case of overwriting an existing test, check if the existing test
321         contains a <!-- webkit-test-runner --> comment and insert it back if
322         needed in the new test.
323
324         For exporter, forbid creating a WPT PR if there are changes containing
325         the webkit-test-runner string.
326
327         * Scripts/webkitpy/w3c/test_converter.py:
328         (convert_for_webkit):
329         (_W3CTestConverter.__init__):
330         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
331         (_W3CTestConverter.handle_starttag):
332         (_W3CTestConverter.handle_comment):
333         (_W3CTestConverter.handle_decl):
334         (_W3CTestConverter.handle_pi):
335         * Scripts/webkitpy/w3c/test_exporter.py:
336         (WebPlatformTestExporter.write_git_patch_file):
337         (WebPlatformTestExporter.make_pull_request):
338         * Scripts/webkitpy/w3c/test_importer.py:
339         (TestImporter.webkit_test_runner_options):
340         (TestImporter):
341         (TestImporter.add_webkit_test_runner_options_to_content):
342         (TestImporter.copy_html_file):
343         (TestImporter.write_html_template):
344         (TestImporter.write_html_files_for_templated_js_tests):
345         (TestImporter.import_tests):
346         * Scripts/webkitpy/w3c/test_importer_unittest.py:
347         (test_manual_slow_test):
348         (test_webkit_test_runner_options):
349
350 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
351
352         [ews-app] Status bubble should turn orange when any build step fails
353         https://bugs.webkit.org/show_bug.cgi?id=197812
354
355         Reviewed by Jonathan Bedard.
356
357         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
358         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
359         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
360
361 2019-05-14  Alex Christensen  <achristensen@webkit.org>
362
363         Add a unit test for client certificate authentication
364         https://bugs.webkit.org/show_bug.cgi?id=197800
365
366         Reviewed by Youenn Fablet.
367
368         Make better abstractions for reading and writing from/to TCPServer.
369         Add a unit test that causes a client certificate authentication challenge to happen.
370
371         * TestWebKitAPI/TCPServer.cpp:
372         (TestWebKitAPI::TCPServer::TCPServer):
373         (TestWebKitAPI::TCPServer::read):
374         (TestWebKitAPI::TCPServer::write):
375         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
376         (TestWebKitAPI::TCPServer::respondWithOK):
377         * TestWebKitAPI/TCPServer.h:
378         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
379         (credentialWithIdentity):
380         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
381         (TEST):
382         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
383         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
384         (-[ClientCertificateDelegate challengeCount]):
385         (TestWebKitAPI::TEST):
386         (respondWithChallengeThenOK): Deleted.
387         (credentialWithIdentityAndKeychainPath): Deleted.
388         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
389         (TEST):
390         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
393         (TEST):
394         (readRequest): Deleted.
395         (writeResponse): Deleted.
396         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
397         (TestWebKitAPI::TEST):
398         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
399
400 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
401
402         [CG] Adding support for HEIF-sequence ('public.heics') images
403         https://bugs.webkit.org/show_bug.cgi?id=197384
404
405         Reviewed by Simon Fraser.
406
407         * DumpRenderTree/TestOptions.cpp:
408         (TestOptions::TestOptions):
409         * DumpRenderTree/TestOptions.h:
410         * DumpRenderTree/mac/DumpRenderTree.mm:
411         (resetWebViewToConsistentStateBeforeTesting):
412         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
413         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
414         the test.
415
416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
417         (WTR::InjectedBundle::stringForKey):
418         (WTR::InjectedBundle::beginTesting):
419         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
420         * WebKitTestRunner/TestController.cpp:
421         (WTR::TestController::resetStateToConsistentValues):
422         (WTR::updateTestOptionsFromTestHeader):
423         * WebKitTestRunner/TestInvocation.cpp:
424         (WTR::TestInvocation::createTestSettingsDictionary):
425         * WebKitTestRunner/TestOptions.h:
426         (WTR::TestOptions::hasSameInitializationOptions const):
427         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
428         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
429         the test.
430
431 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
432
433         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
434         https://bugs.webkit.org/show_bug.cgi?id=197730
435
436         Reviewed by Filip Pizlo.
437
438         * TestWebKitAPI/CMakeLists.txt:
439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
440         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
443         (TestWebKitAPI::TEST):
444
445 2019-05-10  Chris Dumez  <cdumez@apple.com>
446
447         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
448
449         It became flaky after r245198.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
452
453 2019-05-10  Youenn Fablet  <youenn@apple.com>
454
455         A service worker instance should be terminated when its SWServer is destroyed
456         https://bugs.webkit.org/show_bug.cgi?id=197801
457         <rdar://problem/50587270>
458
459         Reviewed by Chris Dumez.
460
461         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
462
463 2019-05-10  Chris Dumez  <cdumez@apple.com>
464
465         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
466         https://bugs.webkit.org/show_bug.cgi?id=197750
467
468         Reviewed by Geoffrey Garen.
469
470         Add API test coverage.
471
472         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
473         (TEST):
474
475 2019-05-10  Keith Miller  <keith_miller@apple.com>
476
477         Remove legacy test262 import script
478         https://bugs.webkit.org/show_bug.cgi?id=197788
479
480         Reviewed by Yusuke Suzuki.
481
482         import-test262-tests doesn't work anymore. We should be using test262-import instead.
483
484         * Scripts/import-test262-tests: Removed.
485
486 2019-05-10  Charlie Turner  <cturner@igalia.com>
487
488         [WPE] Forward libepoxy cflags
489         https://bugs.webkit.org/show_bug.cgi?id=197784
490
491         Reviewed by Žan Doberšek.
492
493         Patch by Zan Dobersek.
494
495         * wpe/backends/CMakeLists.txt: This is required to keep
496         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
497         up trying to include X11 headers even when they're not present in the
498         environment.
499
500 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
501
502         Fix a bunch of compiler warnings
503         https://bugs.webkit.org/show_bug.cgi?id=197785
504
505         Reviewed by Don Olmstead.
506
507         Add preprocessor guards to avoid -Wunused-function warnings.
508
509         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
510         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
511         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
512
513 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
514
515         [WPE][GTK] Add webkit_frame_get_id() API
516         https://bugs.webkit.org/show_bug.cgi?id=197270
517
518         Reviewed by Carlos Garcia Campos.
519
520         This was hard, but I added a test to verify that two different WebKitFrames of the same
521         WebKitWebPage return two different frame IDs.
522
523         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
524         (WebKitFrameTest::willSubmitFormCallback):
525         (WebKitFrameTest::testSubframe):
526         (registerTests):
527         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
528         (testWebKitFrameSubframe):
529         (beforeAll):
530         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
531         (willSubmitFormCallback):
532         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
533         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
534
535 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
536
537         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
538         https://bugs.webkit.org/show_bug.cgi?id=197271
539
540         Reviewed by Youenn Fablet.
541
542         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
543         (formControlsAssociatedForFrameCallback):
544         (pageCreatedCallback):
545         (formControlsAssociatedCallback): Deleted.
546
547 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
548
549         [Flatpak] Use the safe PyYAML loader if available
550         https://bugs.webkit.org/show_bug.cgi?id=197771
551
552         Reviewed by Philippe Normand.
553
554         * flatpak/flatpakutils.py:
555         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
556         still used as fallback when the former is not provided by the module.
557
558 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
559
560         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
561         https://bugs.webkit.org/show_bug.cgi?id=197734
562
563         Reviewed by Don Olmstead.
564
565         * Scripts/webkitpy/port/win.py:
566         (WinCairoPort._search_paths): Add 'wk2' and
567         additional_platform_directory to paths as well as other ports do.
568
569 2019-05-09  Daniel Bates  <dabates@apple.com>
570
571         [iOS] Numpad comma key has incorrect keyIdentifier property
572         https://bugs.webkit.org/show_bug.cgi?id=197753
573         <rdar://problem/50636274>
574
575         Reviewed by Brent Fulgham.
576
577         Recognize "numpadComma" and return the appropriate HID usage code.
578
579         * WebKitTestRunner/ios/HIDEventGenerator.mm:
580         (hidUsageCodeForCharacter):
581
582 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
583
584         Refine AudioSession route sharing policy
585         https://bugs.webkit.org/show_bug.cgi?id=197742
586         <rdar://problem/50590818>
587
588         Reviewed by Darin Adler.
589
590         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
591         (TestWebKitAPI::TEST):
592
593 2019-05-09  Alex Christensen  <achristensen@webkit.org>
594
595         Remove unnecessary test SPI after r244883
596         https://bugs.webkit.org/show_bug.cgi?id=197575
597
598         Reviewed by Tim Horton.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
601         (TEST):
602         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
603         (TestWebKitAPI::TEST):
604
605 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
606
607         [ews-app] Add migrations file to repository
608         https://bugs.webkit.org/show_bug.cgi?id=197729
609
610         Reviewed by Jonathan Bedard.
611
612         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
613
614 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
615
616         [ews-build] Fix formatting issues and typos
617         https://bugs.webkit.org/show_bug.cgi?id=197737
618
619         Reviewed by Jonathan Bedard.
620
621         * BuildSlaveSupport/ews-build/steps.py:
622         (CompileWebKit.evaluateCommand): Removed extra empty line.
623         * BuildSlaveSupport/ews-build/steps_unittest.py:
624         (TestRunWebKitPerlTests): Fixed typo.
625         * BuildSlaveSupport/ews-app/ews/models/step.py:
626         (Step.save_step): Changed log level to info so that it is logged in production.
627
628 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
629
630         [ews-app] Production and Development env should configure DEBUG appropriately
631         https://bugs.webkit.org/show_bug.cgi?id=197700
632
633         Reviewed by Jonathan Bedard.
634
635         * BuildSlaveSupport/ews-app/ews-app/settings.py:
636
637 2019-05-09  Xan López  <xan@igalia.com>
638
639         [CMake] Detect SSE2 at compile time
640         https://bugs.webkit.org/show_bug.cgi?id=196488
641
642         Reviewed by Carlos Garcia Campos.
643
644         * Scripts/webkitdirs.pm:
645         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
646         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
647
648 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
649
650         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
651         https://bugs.webkit.org/show_bug.cgi?id=197697
652
653         Reviewed by Žan Doberšek.
654
655         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
656         * wpe/jhbuild.modules: Ditto.
657
658 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
659
660         Update ANGLE
661         https://bugs.webkit.org/show_bug.cgi?id=197676
662
663         Reviewed by Alex Christensen.
664
665         * TestWebKitAPI/PlatformWin.cmake:
666         Remove unnecessary library linkage.
667
668 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
669
670         [Win] build-webkit should be ready for Visual Studio 2019
671         https://bugs.webkit.org/show_bug.cgi?id=196622
672
673         Reviewed by Ross Kirsling.
674
675         1. Accommodated to the new msbuild.exe location of VS 2019.
676         2. Removed the hard coded "Visual Studio 15" generator.
677
678         build-webkit is going to choose a Visual Studio generator version
679         matching with the latest installed VS. If you invoke vcvars.bat
680         before build-webkit, it chooses the corresponding Visual Studio
681         generator version by cheking 'VisualStudioVersion' env var which
682         is set by vcvars.bat.
683
684         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
685         (msBuildPath): When looking for MSBuild, look in
686         "MSBuild\Current\bin" (the new expected location) and fallback
687         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
688         first location.
689         (msBuildInstallDir): Renamed to msBuildPath.
690         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
691         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
692
693 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
694
695         [PlayStation] Update port options
696         https://bugs.webkit.org/show_bug.cgi?id=197723
697
698         Reviewed by Ross Kirsling.
699
700         ICU headers were missing from TestWTF.
701
702         * TestWebKitAPI/PlatformPlayStation.cmake:
703
704 2019-05-08  Alex Christensen  <achristensen@webkit.org>
705
706         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
707         https://bugs.webkit.org/show_bug.cgi?id=197712
708         <rdar://problem/50429770>
709
710         Reviewed by Tim Horton.
711
712         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
713         (TestWebKitAPI::TEST):
714
715 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
716
717         Change my status to be a WebKit reviewer.
718
719         * Scripts/webkitpy/common/config/contributors.json:
720
721 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
722
723         Unreviewed, rolling out r244952.
724
725         Caused inspector to appear blank.
726
727         Reverted changeset:
728
729         "Web Inspector: Provide UIString descriptions to improve
730         localizations"
731         https://bugs.webkit.org/show_bug.cgi?id=195132
732         https://trac.webkit.org/changeset/244952
733
734 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
735
736         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
737         https://bugs.webkit.org/show_bug.cgi?id=197685
738
739         Reviewed by Alex Christensen.
740
741         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
742         completion. See LayoutTests/ChangeLog for more details.
743
744         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
745         (WTR::UIScriptController::platformClearAllCallbacks):
746
747 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
748
749         Unreviewed. Add myself as a committer.
750
751         * Scripts/webkitpy/common/config/contributors.json:
752
753 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
754
755         Unreviewed, rolling out r245038.
756
757         Breaks internal builds.
758
759         Reverted changeset:
760
761         "Add SPI to set a list of hosts to which to send custom header
762         fields cross-origin"
763         https://bugs.webkit.org/show_bug.cgi?id=197397
764         https://trac.webkit.org/changeset/245038
765
766 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
767
768         Unreviewed. Add myself as a committer.
769
770         * Scripts/webkitpy/common/config/contributors.json:
771
772 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
773
774         Define media buffering policy
775         https://bugs.webkit.org/show_bug.cgi?id=196979
776         <rdar://problem/28383861>
777
778         Reviewed by Jer Noble.
779
780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
781         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
782         (waitUntilBufferingPolicyIsEqualTo):
783         (TEST):
784
785 2019-05-07  Alex Christensen  <achristensen@webkit.org>
786
787         Add SPI to set a list of hosts to which to send custom header fields cross-origin
788         https://bugs.webkit.org/show_bug.cgi?id=197397
789
790         Reviewed by Geoff Garen.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
793         (TEST):
794         (expectLegacyHeaders):
795         (expectHeaders):
796         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
797         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
798         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
799
800 2019-05-07  Keith Rollin  <krollin@apple.com>
801
802         Add option to build-webkit to control whether or not XCBuild is used
803         https://bugs.webkit.org/show_bug.cgi?id=197668
804         <rdar://problem/50549728>
805
806         Reviewed by Tim Horton.
807
808         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
809         Also update build-webkit and the makefiles with the foundation for
810         automatically using XCBuild when the conditions allow it. This latter
811         facility is currently turned off until Xcode fully supports building
812         WebKit with XCBuild.
813
814         * Scripts/build-webkit:
815         * Scripts/webkitdirs.pm:
816         (XcodeOptions):
817         (canUseXCBuild):
818
819 2019-05-07  Andy Estes  <aestes@apple.com>
820
821         run-bindings-tests should test global scope constructor generation
822         https://bugs.webkit.org/show_bug.cgi?id=197669
823
824         Reviewed by Alex Christensen.
825
826         * Scripts/webkitpy/bindings/main.py:
827         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
828         invoking preprocess-idls.pl.
829
830 2019-05-07  Youenn Fablet  <youenn@apple.com>
831
832         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
833         https://bugs.webkit.org/show_bug.cgi?id=195997
834         <rdar://problem/50509884>
835
836         Reviewed by Chris Dumez.
837
838         Spin test until successful.
839
840         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
841
842 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
843
844         [Flatpak] webkit-build fails due to missing GTK2 in build environment
845         https://bugs.webkit.org/show_bug.cgi?id=197352
846
847         Reviewed by Philippe Normand.
848
849         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
850         to build it ourselves on top in order to be able to build the GTK 2.x plugin
851         process.
852
853         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
854
855 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
856
857         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
858         https://bugs.webkit.org/show_bug.cgi?id=197644
859         <rdar://problem/50526364>
860
861         Reviewed by Tim Horton.
862
863         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
866         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
867         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
868         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
869
870 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
871
872         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
873         https://bugs.webkit.org/show_bug.cgi?id=197651
874
875         Reviewed by Žan Doberšek.
876
877         This is required since the process creation was delayed until something is loaded in the view.
878
879         * MiniBrowser/gtk/BrowserWindow.c:
880         (browser_window_get_or_create_web_view_for_automation):
881         * MiniBrowser/wpe/main.cpp:
882         (main):
883
884 2019-05-06  Tim Horton  <timothy_horton@apple.com>
885
886         _overrideViewportWithArguments does not work when called before loading
887         https://bugs.webkit.org/show_bug.cgi?id=197638
888         <rdar://problem/50505111>
889
890         Reviewed by Wenson Hsieh.
891
892         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
893         (TEST):
894
895 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
896
897         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
898         https://bugs.webkit.org/show_bug.cgi?id=197510
899
900         Reviewed by Alex Christensen.
901
902         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
903         (TestWebKitAPI::TEST):
904
905 2019-05-06  Keith Rollin  <krollin@apple.com>
906
907         Temporarily disable generate-xcfilelists
908         https://bugs.webkit.org/show_bug.cgi?id=197619
909         <rdar://problem/50507392>
910
911         Reviewed by Alex Christensen.
912
913         We need to perform a significant update to the generate-xcfilelist
914         scripts. This work involves coordinated work with another facility. If
915         the work does not occur in tandem, the build will be broken. To avoid
916         this, disable the invoking of the scripts during the transition. The
917         checking will be restored once the new scripts are in place.
918
919         * DumpRenderTree/Scripts/check-xcfilelists.sh:
920         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
921
922 2019-05-04  Alex Christensen  <achristensen@webkit.org>
923
924         Revert r244953 and r244954 because they broke internal builds.
925         https://bugs.webkit.org/show_bug.cgi?id=197534
926
927         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
928         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
929         * DumpRenderTree/mac/DumpRenderTree.mm:
930         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
931         * DumpRenderTree/mac/TestRunnerMac.mm:
932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
933         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
934         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
935         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
936         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
937         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
938         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
939         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
940         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
941         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
942         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
943         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
944         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
945         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
946         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
947         * TestWebKitAPI/cocoa/TestWKWebView.mm:
948         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
949         * TestWebKitAPI/ios/UIKitSPI.h: Added.
950         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
951         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
952         * WebKitTestRunner/ios/HIDEventGenerator.h:
953         * WebKitTestRunner/ios/HIDEventGenerator.mm:
954         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
955         * WebKitTestRunner/ios/TestControllerIOS.mm:
956         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
957         * WebKitTestRunner/ios/mainIOS.mm:
958
959 2019-05-04  Alex Christensen  <achristensen@webkit.org>
960
961         Merge the three UIKitSPI.h files into a single one in PAL
962         https://bugs.webkit.org/show_bug.cgi?id=197534
963
964         Reviewed by Darin Adler.
965
966         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
967         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
968         * DumpRenderTree/mac/DumpRenderTree.mm:
969         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
970         * DumpRenderTree/mac/TestRunnerMac.mm:
971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
972         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
973         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
974         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
975         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
976         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
977         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
978         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
979         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
980         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
981         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
982         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
983         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
984         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
985         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
986         * TestWebKitAPI/cocoa/TestWKWebView.mm:
987         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
988         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
989         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
990         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
991         * WebKitTestRunner/ios/HIDEventGenerator.h:
992         * WebKitTestRunner/ios/HIDEventGenerator.mm:
993         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
994         * WebKitTestRunner/ios/TestControllerIOS.mm:
995         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
996         * WebKitTestRunner/ios/mainIOS.mm:
997
998 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
999
1000         Web Inspector: Provide UIString descriptions to improve localizations
1001         https://bugs.webkit.org/show_bug.cgi?id=195132
1002         <rdar://problem/48457817>
1003
1004         Reviewed by Devin Rousso.
1005
1006         Allow WI.UIString to take:
1007         - WI.UIString(string, key, comment)
1008         - WI.UIString(string, comment)
1009         - WI.UIString(string)
1010
1011         * Scripts/extract-localizable-js-strings:
1012
1013 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1014
1015         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
1016         https://bugs.webkit.org/show_bug.cgi?id=197579
1017
1018         Reviewed by Tim Horton.
1019
1020         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
1021         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
1022         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
1023         ensure that the the focused element has been blurred.
1024
1025         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1026
1027 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
1028
1029         Add a tool to block spammer accounts
1030         https://bugs.webkit.org/show_bug.cgi?id=197537
1031
1032         Reviewed by Darin Adler.
1033
1034         Usage: block-spammers email1 email2 ...
1035
1036         The tool finds and hides all bugs and comments from this account. Before any work
1037         is done, these bugs and comments are displayed for confirmation.
1038
1039         * Scripts/block-spammers: Added.
1040         (get_bugzilla_token):
1041         (invalidate_bugzilla_token):
1042         (get_user_info):
1043         (get_user_info_self):
1044         (can_use_this_tool):
1045         (disable_user):
1046         (get_bugs_created_by_user):
1047         (get_bugs_commented_on_by_user):
1048         (get_comments):
1049         (hide_bug):
1050         (hide_comments):
1051         (ask_yes_no):
1052         (sanitized_string):
1053         (main):
1054
1055 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
1056
1057         run-apit-tests: Add --iterations and --repeat-each
1058         https://bugs.webkit.org/show_bug.cgi?id=197563
1059
1060         Reviewed by Aakash Jain.
1061
1062         * Scripts/webkitpy/api_tests/manager.py:
1063         (Manager.run): Add --iterations and --repeat-each/
1064         * Scripts/webkitpy/api_tests/run_api_tests.py:
1065         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
1066
1067 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1068
1069         New EWS: Clicking on white bubble navigates to page with only bubbles
1070         https://bugs.webkit.org/show_bug.cgi?id=197520
1071
1072         Reviewed by Lucas Forschler.
1073
1074         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
1075
1076 2019-05-03  Daniel Bates  <dabates@apple.com>
1077
1078         [lldb-webkit] Support adding pretty-printing for qualified types
1079         https://bugs.webkit.org/show_bug.cgi?id=197518
1080
1081         Reviewed by Darin Adler.
1082
1083         Remove all "::"s from the name of the specified type when computing the name for the Python classes
1084         that will provide summary and synthetic details as LLDB is not happy about registering such classes
1085         when they contain :: in their name.
1086
1087         * lldb/lldb_webkit.py:
1088         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1089
1090 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1091
1092         New EWS: patches on recently added queues listed as #1 for older bugs
1093         https://bugs.webkit.org/show_bug.cgi?id=197496
1094
1095         Reviewed by Lucas Forschler.
1096
1097         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1098         (StatusBubble._build_bubble):
1099         (StatusBubble._queue_position):
1100
1101 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1102
1103         webkit-patch --no-review upload does not submit patch to New EWS
1104         https://bugs.webkit.org/show_bug.cgi?id=197519
1105         <rdar://problem/50424887>
1106
1107         Reviewed by Lucas Forschler.
1108
1109         * Scripts/webkitpy/tool/steps/submittoews.py:
1110         (SubmitToEWS.run): Submit to both old and new EWS.
1111         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
1112         * Scripts/webkitpy/common/net/ewsserver.py: Added.
1113         (EWSServer._server_url): Method to return server url.
1114         (EWSServer._post_patch_to_ews): Method to post patch to ews.
1115         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
1116         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
1117         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
1118         * Scripts/webkitpy/common/net/statusserver_mock.py:
1119         (MockStatusServer.submit_to_ews): Updated the log text.
1120         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
1121         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
1122         * Scripts/webkitpy/tool/main.py:
1123         (WebKitPatch.__init__): Initialize ews_server. 
1124         * Scripts/webkitpy/tool/mocktool.py:
1125         (MockTool.__init__): Ditto.
1126
1127 2019-05-03  Chris Dumez  <cdumez@apple.com>
1128
1129         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
1130         https://bugs.webkit.org/show_bug.cgi?id=197574
1131         <rdar://problem/50453181>
1132
1133         Reviewed by Tim Horton.
1134
1135         Add API test coverage.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1138         (TEST):
1139
1140 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
1141
1142         [JSC] Generator CodeBlock generation should be idempotent
1143         https://bugs.webkit.org/show_bug.cgi?id=197552
1144
1145         Reviewed by Keith Miller.
1146
1147         * Scripts/run-javascriptcore-tests:
1148         (runJSCStressTests):
1149         * Scripts/run-jsc-stress-tests:
1150
1151 2019-05-03  Commit Queue  <commit-queue@webkit.org>
1152
1153         Unreviewed, rolling out r244881.
1154         https://bugs.webkit.org/show_bug.cgi?id=197559
1155
1156         Breaks compilation of jsconly on linux, breaking compilation
1157         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
1158         guijemont on #webkit).
1159
1160         Reverted changeset:
1161
1162         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
1163         WEBKIT_COPY_FILES"
1164         https://bugs.webkit.org/show_bug.cgi?id=197174
1165         https://trac.webkit.org/changeset/244881
1166
1167 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
1168
1169         Unreviewed WPE build fix after r244898.
1170
1171         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
1172         (WTR::TestController::abortModal): Add the missing (no-op) definition.
1173
1174 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1175
1176         Mark U+01C0 as a homograph of U+006C
1177         https://bugs.webkit.org/show_bug.cgi?id=197526
1178         <rdar://problem/50301904>
1179
1180         Reviewed by Tim Horton.
1181
1182         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1183         (TestWebKitAPI::TEST):
1184
1185 2019-05-02  Chris Dumez  <cdumez@apple.com>
1186
1187         Add test coverage for <rdar://problem/49731231>
1188         https://bugs.webkit.org/show_bug.cgi?id=196730
1189         <rdar://problem/49731231>
1190
1191         Reviewed by Ryosuke Niwa.
1192
1193         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
1194         to match DumpRenderTree.
1195
1196         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1197         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1198         (WTR::TestRunner::abortModal):
1199         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1200         * WebKitTestRunner/TestController.cpp:
1201         (WTR::TestController::runModal):
1202         * WebKitTestRunner/TestController.h:
1203         * WebKitTestRunner/TestInvocation.cpp:
1204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1205         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1206         (WTR::TestController::abortModal):
1207         * WebKitTestRunner/ios/TestControllerIOS.mm:
1208         (WTR::TestController::abortModal):
1209         * WebKitTestRunner/mac/TestControllerMac.mm:
1210         (WTR::TestController::abortModal):
1211         * WebKitTestRunner/win/TestControllerWin.cpp:
1212         (WTR::TestController::abortModal):
1213
1214 2019-05-02  Christopher Reid  <chris.reid@sony.com>
1215
1216         [CMake] Add support for LTO builds
1217         https://bugs.webkit.org/show_bug.cgi?id=188986
1218
1219         Reviewed by Don Olmstead.
1220
1221         Add support to configure --lto-mode with cmake builds.
1222
1223         * Scripts/build-webkit:
1224         * Scripts/webkitdirs.pm:
1225         (generateBuildSystemFromCMakeProject):
1226
1227 2019-05-02  John Wilander  <wilander@apple.com>
1228
1229         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
1230         https://bugs.webkit.org/show_bug.cgi?id=197521
1231         <rdar://problem/49651503>
1232
1233         Reviewed by Brent Fulgham.
1234
1235         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1236         (TestWebKitAPI::TEST):
1237            Added a test for host strings with leading dots since they are
1238            often used for the domain attribute in cookies.
1239
1240 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
1241
1242         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1243         https://bugs.webkit.org/show_bug.cgi?id=197510
1244
1245         Reviewed by Alex Christensen.
1246
1247         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1248         (TestWebKitAPI::TEST):
1249
1250 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
1251
1252         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1253         https://bugs.webkit.org/show_bug.cgi?id=197174
1254
1255         Reviewed by Alex Christensen.
1256
1257         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1258
1259         * TestWebKitAPI/PlatformGTK.cmake:
1260         * TestWebKitAPI/PlatformWPE.cmake:
1261
1262 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1263
1264         Build fix for internal branch.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1267         RetainPtr.h was not explicitly included.
1268
1269 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1270
1271         webkitpy: Ignore errors when shutting down an already shutdown simulator
1272         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1273         <rdar://problem/50390247>
1274
1275         Reviewed by Lucas Forschler.
1276
1277         * Scripts/webkitpy/xcode/simulated_device.py:
1278         (SimulatedDevice._shut_down):
1279
1280 2019-05-02  Frederic Wang  <fwang@igalia.com>
1281
1282         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1283         https://bugs.webkit.org/show_bug.cgi?id=196142
1284
1285         This patch introduces some experimental runtime flag to let users
1286         disable MathML features that are removed from MathML Core [1]. For now,
1287         these features are only disabled on GTK and WPE ports.
1288
1289         [1] https://mathml-refresh.github.io/mathml-core/
1290
1291         Reviewed by Rob Buis.
1292
1293         * DumpRenderTree/TestOptions.cpp:
1294         (TestOptions::TestOptions):
1295         * DumpRenderTree/TestOptions.h:
1296         * DumpRenderTree/mac/DumpRenderTree.mm:
1297         (setWebPreferencesForTestOptions):
1298
1299 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1300
1301         TestWebKitAPI config.h should be aware of what suite is being built
1302         https://bugs.webkit.org/show_bug.cgi?id=196583
1303
1304         Reviewed by Konstantin Tokarev.
1305
1306         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1307         benefit the macro defines BUILDING_* for the executable which allows the includes
1308         of the config.h to be tailored to the test suite being built. Because of that the
1309         dependencies of the Test* executable are specific to the test suite which may
1310         speed up the build.
1311
1312         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1313         when "Utilities.h" is what was needed.
1314
1315         * TestWebKitAPI/CMakeLists.txt:
1316         * TestWebKitAPI/PlatformGTK.cmake:
1317         * TestWebKitAPI/PlatformJSCOnly.cmake:
1318         * TestWebKitAPI/PlatformMac.cmake:
1319         * TestWebKitAPI/PlatformPlayStation.cmake:
1320         * TestWebKitAPI/PlatformUtilities.h:
1321         * TestWebKitAPI/PlatformWPE.cmake:
1322         * TestWebKitAPI/PlatformWin.cmake:
1323         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1324         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1325         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1326         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1327         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1328         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1329         * TestWebKitAPI/config.h:
1330
1331 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1332
1333         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1334         https://bugs.webkit.org/show_bug.cgi?id=181950
1335         <rdar://problem/43357371>
1336
1337         Reviewed by Brent Fulgham.
1338
1339         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1340         (TestWebKitAPI::TEST_F):
1341
1342 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1343
1344         Remove webkitpy and bindings EWS queues from dashboard
1345         https://bugs.webkit.org/show_bug.cgi?id=197475
1346
1347         Reviewed by Alexey Proskuryakov.
1348
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1350
1351 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1352
1353         Remove webkitpy and bindings test queues from old EWS
1354         https://bugs.webkit.org/show_bug.cgi?id=197468
1355
1356         Reviewed by Alexey Proskuryakov.
1357
1358         * QueueStatusServer/config/queues.py:
1359
1360 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1361
1362         Fix the WebKitTestRunner build
1363         https://bugs.webkit.org/show_bug.cgi?id=197449
1364         <rdar://problem/50334169>
1365
1366         Reviewed by Alexey Proskuryakov.
1367
1368         * WebKitTestRunner/mac/EventSenderProxy.mm:
1369         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1370         (WTR::EventSenderProxy::mouseForceChanged):
1371         Use some SPI instead of IPI.
1372
1373 2019-04-30  Chris Dumez  <cdumez@apple.com>
1374
1375         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1376         https://bugs.webkit.org/show_bug.cgi?id=197426
1377         <rdar://problem/50256169>
1378
1379         Reviewed by Brady Eidson.
1380
1381         Add API test coverage.
1382
1383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1384         (-[PSONScheme setShouldRespondAsynchronously:]):
1385         (-[PSONScheme webView:startURLSchemeTask:]):
1386         (-[PSONScheme webView:stopURLSchemeTask:]):
1387
1388 2019-04-30  Chris Dumez  <cdumez@apple.com>
1389
1390         Unreviewed, rolling out r244802.
1391
1392         Caused an API test failure
1393
1394         Reverted changeset:
1395
1396         "Regression(PSON) URL scheme handlers can no longer respond
1397         asynchronously"
1398         https://bugs.webkit.org/show_bug.cgi?id=197426
1399         https://trac.webkit.org/changeset/244802
1400
1401 2019-04-30  Chris Dumez  <cdumez@apple.com>
1402
1403         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1404         https://bugs.webkit.org/show_bug.cgi?id=197426
1405         <rdar://problem/50256169>
1406
1407         Reviewed by Brady Eidson.
1408
1409         Add API test coverage.
1410
1411         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1412         (-[PSONScheme setShouldRespondAsynchronously:]):
1413         (-[PSONScheme webView:startURLSchemeTask:]):
1414         (-[PSONScheme webView:stopURLSchemeTask:]):
1415
1416 2019-04-30  Chris Dumez  <cdumez@apple.com>
1417
1418         Only use a related page's process if that page has not been closed yet
1419         https://bugs.webkit.org/show_bug.cgi?id=197393
1420         <rdar://problem/50302423>
1421
1422         Reviewed by Tim Horton.
1423
1424         Add API test coverage.
1425
1426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1427
1428 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1429
1430         [ews-build] Enable Bindings tests queue on new EWS
1431         https://bugs.webkit.org/show_bug.cgi?id=197424
1432
1433         Reviewed by Lucas Forschler.
1434
1435         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1436         (StatusBubble):
1437         * BuildSlaveSupport/ews-build/config.json:
1438
1439 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1440
1441         [ews-build] Configure ews151 for running various tests
1442         https://bugs.webkit.org/show_bug.cgi?id=197419
1443
1444         Reviewed by Lucas Forschler.
1445
1446         * BuildSlaveSupport/ews-build/config.json:
1447
1448 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1449
1450         [ews-build] Parse and display bindings test failures
1451         https://bugs.webkit.org/show_bug.cgi?id=197423
1452
1453         Reviewed by Lucas Forschler.
1454
1455         * BuildSlaveSupport/ews-build/steps.py:
1456         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1457         (RunBindingsTests.start): Initialize log_observer for json output.
1458         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1459         (RunBindingsTests._addToLog): Method to add message to log.
1460         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1461
1462 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1463
1464         Unreviewed. Add myself as a committer.
1465
1466         * Scripts/webkitpy/common/config/contributors.json:
1467
1468 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1469
1470         [ews-build] Enable webkitpy queue on new EWS
1471         https://bugs.webkit.org/show_bug.cgi?id=197396
1472
1473         Reviewed by Lucas Forschler.
1474
1475         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1476         (StatusBubble):
1477         * BuildSlaveSupport/ews-build/config.json:
1478
1479 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1480
1481         [ews-build] Parse and display webkitpy failures
1482         https://bugs.webkit.org/show_bug.cgi?id=197395
1483
1484         Reviewed by Lucas Forschler.
1485
1486         * BuildSlaveSupport/ews-build/steps.py:
1487         (RunWebKitPyTests.start): Initialize log_observer for json output.
1488         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1489         (RunWebKitPyTests._addToLog): Method to add message to log.
1490         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1491
1492 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1493
1494         <rdar://problem/50299396> Fix internal High Sierra build
1495         https://bugs.webkit.org/show_bug.cgi?id=197388
1496
1497         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1498         * MiniBrowser/Configurations/Base.xcconfig:
1499         * MobileMiniBrowser/Configurations/Base.xcconfig:
1500         * TestWebKitAPI/Configurations/Base.xcconfig:
1501         * WebKitTestRunner/Configurations/Base.xcconfig:
1502
1503 2019-04-29  Youenn Fablet  <youenn@apple.com>
1504
1505         Remove spurious GVA printf logging
1506         https://bugs.webkit.org/show_bug.cgi?id=197368
1507         <rdar://problem/35975256>
1508
1509         Reviewed by Alexey Proskuryakov.
1510
1511         * Scripts/webkitpy/port/mac.py:
1512         (MacPort.logging_patterns_to_strip):
1513
1514 2019-04-29  Youenn Fablet  <youenn@apple.com>
1515
1516         getDisplayMedia should be called on user gesture
1517         https://bugs.webkit.org/show_bug.cgi?id=197356
1518         <rdar://problem/50296074>
1519
1520         Reviewed by Eric Carlson.
1521
1522         Update test configuration to inject internals
1523         so that we can use it to simulate a user click to call getDisplayMedia.
1524
1525         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1526         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1527         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1528
1529 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1530
1531         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1532         https://bugs.webkit.org/show_bug.cgi?id=197339
1533
1534         Reviewed by Dewei Zhu.
1535
1536         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1537         test run for setup steps that are too expensive to do every iteration.
1538
1539         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1540         (BenchmarkRunner._run_benchmark):
1541         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1542         (BrowserDriver):
1543         (BrowserDriver.prepare_initial_env):
1544         (BrowserDriver.restore_env_after_all_testing):
1545         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1546         (LinuxBrowserDriver.prepare_initial_env):
1547         (LinuxBrowserDriver.restore_env_after_all_testing):
1548         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1549         (OSXBrowserDriver.prepare_initial_env):
1550         (OSXBrowserDriver.restore_env_after_all_testing):
1551
1552 2019-04-28  Andy Estes  <aestes@apple.com>
1553
1554         Fix the watchOS engineering build.
1555
1556         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1557         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1558
1559 2019-04-27  Chris Dumez  <cdumez@apple.com>
1560
1561         [WKTR] Move test timeout handling to the UIProcess
1562         https://bugs.webkit.org/show_bug.cgi?id=197333
1563
1564         Reviewed by Darin Adler.
1565
1566         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1567         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1568         every WebContent process in the case of swapping.
1569
1570         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1571         would lead to crashes when firing the timer.
1572
1573         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1574         (WTR::InjectedBundle::didReceiveMessageToPage):
1575         (WTR::InjectedBundle::done):
1576         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1577         (WTR::InjectedBundle::shouldDumpPixels const):
1578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1579         (WTR::TestRunner::TestRunner):
1580         (WTR::TestRunner::waitUntilDone):
1581         (WTR::TestRunner::setWaitUntilDone):
1582         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1583         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1584         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1585         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1586         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1587         * WebKitTestRunner/TestInvocation.cpp:
1588         (WTR::TestInvocation::TestInvocation):
1589         (WTR::TestInvocation::createTestSettingsDictionary):
1590         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1591         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1592         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1593         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1594         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1595         (WTR::TestInvocation::setWaitUntilDone):
1596         (WTR::TestInvocation::done):
1597         * WebKitTestRunner/TestInvocation.h:
1598
1599 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1600
1601         [JSC] linkPolymorphicCall now does GC
1602         https://bugs.webkit.org/show_bug.cgi?id=197306
1603
1604         Reviewed by Saam Barati.
1605
1606         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1607         To add this test, we add `runWithoutBaseOption`.
1608
1609         * Scripts/run-jsc-stress-tests:
1610
1611 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1612
1613         Update inactive reviewers' status to 'contributor'.
1614
1615         Accidentally skipped one at first.
1616
1617         * Scripts/webkitpy/common/config/contributors.json:
1618
1619 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1620
1621         Update inactive reviewers' status to 'contributor'.
1622
1623         * Scripts/webkitpy/common/config/contributors.json: The change.
1624
1625         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1626         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1627         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1628         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1629         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1630         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1631         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1632         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1633         Sadly, regression tests operate on a crazy mix of mock and live data for
1634         contributors.json. It would be a substantial project to mock all code paths,
1635         so changing the tests instead.
1636
1637 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1638
1639         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1640         https://bugs.webkit.org/show_bug.cgi?id=197171
1641         <rdar://problem/47454979>
1642
1643         Reviewed by Youenn Fablet.
1644
1645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1646         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1647         (TestWebKitAPI::TEST):
1648
1649 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1650
1651         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1652         <https://webkit.org/b/197314>
1653         <rdar://problem/50245252>
1654
1655         Reviewed by Simon Fraser.
1656
1657         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1658         (WTR::UIScriptController::lastUndoLabel const):
1659         (WTR::UIScriptController::firstRedoLabel const):
1660         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1661
1662         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1663         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1664         - Call -autorelease to fix leak of NSDictionary.
1665
1666         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1667         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1668         (WTR::UIScriptController::selectFormPopoverTitle const):
1669         (WTR::UIScriptController::textContentType const):
1670         (WTR::UIScriptController::formInputLabel const):
1671         (WTR::UIScriptController::scrollingTreeAsText const):
1672         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1673
1674 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1675
1676         webkitpy: Running a single test will always use the default device
1677         https://bugs.webkit.org/show_bug.cgi?id=195472
1678         <rdar://problem/48724825>
1679
1680         Reviewed by Lucas Forschler.
1681
1682         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1683         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1684         requested will be run regardless of what shard they are in.
1685
1686         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1687         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1688         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1689         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1690         on the default device type.
1691         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1692         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1693         (RunTest.test_run_part): Ditto.
1694
1695 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1696
1697         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1698         https://bugs.webkit.org/show_bug.cgi?id=197165
1699
1700         Reviewed by Youenn Fablet.
1701
1702         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1703
1704 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1705
1706         Replace iOS build queue hardware
1707         https://bugs.webkit.org/show_bug.cgi?id=197312
1708
1709         Reviewed by Aakash Jain.
1710
1711         * BuildSlaveSupport/build.webkit.org-config/config.json:
1712         Use newer hardware that supports macOS Mojave.
1713
1714 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1715
1716         check-webkit-style complains the first block in while loop.
1717         https://bugs.webkit.org/show_bug.cgi?id=197307
1718
1719         The style checker shouldn't complain about an open brace on
1720         its own line if the last non-whitespace character on the previous
1721         non-blank line is another open brace, because it's likely to
1722         indicate the begining of a nested code block.
1723
1724         Reviewed by Alex Christensen.
1725
1726         * Scripts/webkitpy/style/checkers/cpp.py:
1727         (check_braces):
1728         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1729         (WebKitStyleTest.test_braces):
1730
1731 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1732
1733         Stop IDB transactions to release locked database files when network process is ready to suspend
1734         https://bugs.webkit.org/show_bug.cgi?id=196372
1735         <rdar://problem/48930116>
1736
1737         Reviewed by Brady Eidson.
1738
1739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1740         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1742         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1743         (runTestAndCheckResult):
1744         (keepNetworkProcessActive):
1745         (TEST):
1746
1747 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1748
1749         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1750         https://bugs.webkit.org/show_bug.cgi?id=188357
1751         <rdar://problem/42986633>
1752
1753         Reviewed by Dean Jackson.
1754
1755         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1756         tests would fall into low memory mode and have different behavior.
1757         
1758         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1759         to Internals, so it's shared by DRT and WTR.
1760         
1761         We no longer need the WK2 C SPI glue.
1762
1763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1764         (WTR::InjectedBundlePage::prepare):
1765
1766 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1767
1768         webkitpy: Including skipped tests in the final count
1769         https://bugs.webkit.org/show_bug.cgi?id=197298
1770         <rdar://problem/49705424>
1771
1772         Reviewed by Lucas Forschler.
1773
1774         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1775         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1776
1777 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1778
1779         Disable date and time inputs on iOSMac.
1780         https://bugs.webkit.org/show_bug.cgi?id=197287
1781         rdar://problem/46794376
1782
1783         Reviewed by Wenson Hsieh.
1784
1785         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1786
1787 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1788
1789         Fix test-webkitpy after r244653
1790         https://bugs.webkit.org/show_bug.cgi?id=197131
1791
1792         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1793         Also use C++17.
1794
1795 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1796
1797         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1798         https://bugs.webkit.org/show_bug.cgi?id=196991
1799         <rdar://problem/45507423>
1800
1801         Reviewed by Alex Christensen.
1802
1803         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1804         (-[NavigationTestDelegate init]):
1805         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1806         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1807         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1808         (TestWebKitAPI::TEST):
1809         (TEST): Deleted.
1810
1811 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1812
1813         Revert some code accidentally committed with r244653
1814         https://bugs.webkit.org/show_bug.cgi?id=197131
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1817         (TestWebKitAPI::TEST):
1818
1819 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1820
1821         Start using C++17
1822         https://bugs.webkit.org/show_bug.cgi?id=197131
1823
1824         Reviewed by Darin Adler.
1825
1826         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1827         * MiniBrowser/Configurations/Base.xcconfig:
1828         * MobileMiniBrowser/Configurations/Base.xcconfig:
1829         * TestWebKitAPI/Configurations/Base.xcconfig:
1830         * WebKitTestRunner/Configurations/Base.xcconfig:
1831
1832 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1833
1834         Unreviewed, rolling out r244627.
1835         https://bugs.webkit.org/show_bug.cgi?id=197282
1836
1837         Causing internal build failures (Requested by ShawnRoberts on
1838         #webkit).
1839
1840         Reverted changeset:
1841
1842         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1843         https://bugs.webkit.org/show_bug.cgi?id=197171
1844         https://trac.webkit.org/changeset/244627
1845
1846 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1847
1848         [GTK] Hardcoded text color in input fields
1849         https://bugs.webkit.org/show_bug.cgi?id=126907
1850
1851         Reviewed by Michael Catanzaro.
1852
1853         Add dark-mode command line option to MiniBrowser.
1854
1855         * MiniBrowser/gtk/main.c:
1856         (main):
1857
1858 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1859
1860         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1861         https://bugs.webkit.org/show_bug.cgi?id=196948
1862         <rdar://problem/49927131>
1863
1864         Reviewed by Tim Horton.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1867         (TEST):
1868         The expected order of incoming events is
1869         1. didInvalidateIntrinsicContentSize
1870         2. didFirstLayout
1871         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1872         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1873         (and remember, all we care about is ordering).
1874
1875 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1876
1877         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1878         https://bugs.webkit.org/show_bug.cgi?id=197171
1879         <rdar://problem/47454979>
1880
1881         Reviewed by Youenn Fablet.
1882
1883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1884         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1885         (TestWebKitAPI::TEST):
1886
1887 2019-04-24  Brady Eidson  <beidson@apple.com>
1888
1889         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1890         https://bugs.webkit.org/show_bug.cgi?id=191362
1891
1892         Reviewed by Alex Christensen.
1893
1894         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1895           from an XHR to a custom protocol.
1896
1897 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1898
1899         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1900         https://bugs.webkit.org/show_bug.cgi?id=197273
1901
1902         Reviewed by Dean Jackson.
1903
1904         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1905         so that WebCoreTestSupport::resetInternalsObject() is always run.
1906
1907         * DumpRenderTree/mac/DumpRenderTree.mm:
1908         (resetWebViewToConsistentStateBeforeTesting):
1909         (runTest):
1910
1911 2019-04-24  John Wilander  <wilander@apple.com>
1912
1913         Age out unconverted Ad Click Attributions after one week.
1914         https://bugs.webkit.org/show_bug.cgi?id=197238
1915         <rdar://problem/50177349>
1916
1917         Reviewed by Chris Dumez.
1918
1919         This patch adds infrastructure to allow tests to expire all unconverted
1920         attributions early.
1921
1922         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1924         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1925         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1928         * WebKitTestRunner/TestController.h:
1929         * WebKitTestRunner/TestInvocation.cpp:
1930         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1931
1932 2019-04-24  Chris Dumez  <cdumez@apple.com>
1933
1934         Fix flaky crashes in a couple of PSON API tests
1935         https://bugs.webkit.org/show_bug.cgi?id=197239
1936
1937         Reviewed by Tim Horton.
1938
1939         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1940
1941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1942
1943 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1944
1945         Make it possible to control the renderTreeAsText output by setting options on testRunner
1946         https://bugs.webkit.org/show_bug.cgi?id=197133
1947
1948         Reviewed by Sam Weinig.
1949
1950         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1951         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1952         these flags through the various framework layers.
1953
1954         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1955
1956         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1957         and hand-code DumpRenderTree bindings.
1958
1959         Some cleanup of the TestRunners, using member initializers.
1960
1961         * DumpRenderTree/TestRunner.cpp:
1962         (TestRunner::TestRunner):
1963         (setRenderTreeDumpOptionsCallback):
1964         (TestRunner::staticFunctions):
1965         (TestRunner::setRenderTreeDumpOptions):
1966         * DumpRenderTree/TestRunner.h:
1967         (TestRunner::renderTreeDumpOptions const):
1968         * DumpRenderTree/mac/DumpRenderTree.mm:
1969         (dump):
1970         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1971         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1972         (WTR::InjectedBundlePage::dump):
1973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1974         (WTR::TestRunner::TestRunner):
1975         (WTR::TestRunner::setRenderTreeDumpOptions):
1976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1977         (WTR::TestRunner::renderTreeDumpOptions const):
1978
1979 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1980
1981         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1982         https://bugs.webkit.org/show_bug.cgi?id=197078
1983         <rdar://problem/49564348>
1984
1985         Reviewed by Geoff Garen.
1986
1987         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1988         (TEST_F):
1989         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1990         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1991         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1992
1993 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1994
1995         Add unit test for r239322
1996         https://bugs.webkit.org/show_bug.cgi?id=197236
1997
1998         Reviewed by Chris Dumez.
1999
2000         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
2001         May as well add the test infrastructure which was needed before and will be needed in the future.
2002
2003         * TestWebKitAPI/TCPServer.cpp:
2004         (TestWebKitAPI::TCPServer::TCPServer):
2005         * TestWebKitAPI/TCPServer.h:
2006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2007         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2010         (TestWebKitAPI::downloadAtRate):
2011         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2012         (TEST):
2013         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
2014         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2015         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2016         (TestWebKitAPI::TEST):
2017         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2018         (TEST):
2019
2020 2019-04-24  Chris Dumez  <cdumez@apple.com>
2021
2022         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
2023         https://bugs.webkit.org/show_bug.cgi?id=197214
2024         <rdar://problem/49237544>
2025
2026         Reviewed by Alex Christensen.
2027
2028         Extend API test coverage.
2029
2030         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2031         (TEST):
2032
2033 2019-04-24  Philippe Normand  <pnormand@igalia.com>
2034
2035         [Build][GStreamer] Update to 1.16.0
2036         https://bugs.webkit.org/show_bug.cgi?id=197157
2037
2038         Reviewed by Xabier Rodriguez-Calvar.
2039
2040         The upstreamed patches were removed and a new one was added for a
2041         regression detected in the scaletempo GStreamer element. The GNOME
2042         Flatpak was migrated to 3.32 and I switched a few modules to Meson
2043         on the way, as it is the preferred build system now in GStreamer
2044         1.16.
2045
2046         * flatpak/files/httpd-autogen.sh:
2047         * flatpak/flatpakutils.py:
2048         (FlatpakPackage.install):
2049         (WebkitFlatpak.run_in_sandbox):
2050         * flatpak/org.webkit.CommonModules.yaml:
2051         * flatpak/org.webkit.WebKit.yaml:
2052         * gstreamer/jhbuild.modules:
2053         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
2054         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
2055         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
2056         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
2057         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
2058         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
2059         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
2060         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
2061         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
2062         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
2063         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
2064         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
2065         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
2066         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
2067         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
2068         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
2069         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
2070         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
2071         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
2072         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
2073         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
2074         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
2075
2076 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2077
2078         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
2079         https://bugs.webkit.org/show_bug.cgi?id=197156
2080
2081         Reviewed by Michael Catanzaro.
2082
2083         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
2084         support was added.
2085
2086         * MiniBrowser/gtk/BrowserTab.c:
2087         (browser_tab_set_background_color): Set the passed in color as web view background color.
2088         * MiniBrowser/gtk/BrowserTab.h:
2089         * MiniBrowser/gtk/BrowserWindow.c:
2090         (browser_window_init): Initialize backgroundColor.
2091         (browser_window_append_view): Call browser_tab_set_background_color().
2092         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
2093         are added.
2094         * MiniBrowser/gtk/main.c:
2095         (main): Call browser_window_set_background_color() before creating the tabs.
2096
2097 2019-04-23  John Wilander  <wilander@apple.com>
2098
2099         Move Ad Click Attribution from internal feature to experimental feature
2100         https://bugs.webkit.org/show_bug.cgi?id=197218
2101         <rdar://problem/47651691>
2102
2103         Reviewed by Brent Fulgham.
2104
2105         * DumpRenderTree/TestOptions.cpp:
2106         (TestOptions::TestOptions):
2107
2108 2019-04-23  Andy Estes  <aestes@apple.com>
2109
2110         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
2111         https://bugs.webkit.org/show_bug.cgi?id=196749
2112         <rdar://problem/35773454>
2113
2114         Reviewed by Daniel Bates.
2115
2116         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
2117
2118         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2119         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
2120         (-[QuickLookDelegate webView:didFinishNavigation:]):
2121         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
2122         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2123         (runTest):
2124         (runTestDecideBeforeLoading):
2125         (runTestDecideAfterLoading):
2126         (TEST):
2127
2128 2019-04-23  John Wilander  <wilander@apple.com>
2129
2130         Remove Ad Click Attribution data when removing website data
2131         https://bugs.webkit.org/show_bug.cgi?id=197215
2132         <rdar://problem/47668988>
2133
2134         Reviewed by Chris Dumez.
2135
2136         This patch adds test infrastructure to delete Ad Click Attribution data
2137         through WebsiteDataStore::removeData().
2138
2139         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2141         (WTR::TestRunner::clearAdClickAttribution):
2142         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
2143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2144         * WebKitTestRunner/TestController.cpp:
2145         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2146         * WebKitTestRunner/TestController.h:
2147         * WebKitTestRunner/TestInvocation.cpp:
2148         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2149
2150 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
2151
2152         webkitpy: Kill unresponsive worker processes
2153         https://bugs.webkit.org/show_bug.cgi?id=197205
2154         <rdar://problem/50104388>
2155
2156         Reviewed by Lucas Forschler.
2157
2158         * Scripts/webkitpy/common/message_pool.py:
2159         (_MessagePool.__init__): Add close timeout.
2160         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
2161
2162 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2163
2164         Add unit tests for WKWebView.serverTrust
2165         https://bugs.webkit.org/show_bug.cgi?id=197202
2166
2167         Reviewed by Youenn Fablet
2168
2169         * TestWebKitAPI/TCPServer.cpp:
2170         (TestWebKitAPI::deleter<BIO>::operator()):
2171         (TestWebKitAPI::deleter<SSL>::operator()):
2172         (TestWebKitAPI::deleter<X509>::operator()):
2173         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
2174         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
2175         (TestWebKitAPI::TCPServer::TCPServer):
2176         (TestWebKitAPI::TCPServer::listenForConnections):
2177         * TestWebKitAPI/TCPServer.h:
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2180         (TestWebKitAPI::TEST):
2181         (verifyCertificateAndPublicKey):
2182         (-[ServerTrustDelegate webView:didFinishNavigation:]):
2183         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2184         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2185         (TestWebKitAPI::downloadAtRate):
2186         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2187         (TEST):
2188         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2189         (TEST):
2190
2191 2019-04-23  Commit Queue  <commit-queue@webkit.org>
2192
2193         Unreviewed, rolling out r244556.
2194         https://bugs.webkit.org/show_bug.cgi?id=197212
2195
2196         Causing build failures on multiple builders (Requested by
2197         ShawnRoberts on #webkit).
2198
2199         Reverted changeset:
2200
2201         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2202         https://bugs.webkit.org/show_bug.cgi?id=197171
2203         https://trac.webkit.org/changeset/244556
2204
2205 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2206
2207         Fix iOS build.
2208         https://bugs.webkit.org/show_bug.cgi?id=195537
2209
2210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2211         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2212         AdoptWK constructor is private now.  Use adoptWK instead.
2213
2214 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
2215
2216         Accessibility text search and selection API enhancements.
2217         https://bugs.webkit.org/show_bug.cgi?id=197095
2218         <rdar://problem/48181791>
2219
2220         Reviewed by Chris Fleizach.
2221
2222         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
2223
2224         * DumpRenderTree/AccessibilityTextMarker.h:
2225         * DumpRenderTree/AccessibilityUIElement.cpp:
2226         (searchTextWithCriteriaCallback):
2227         (AccessibilityUIElement::getJSClass):
2228         * DumpRenderTree/AccessibilityUIElement.h:
2229         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2230         (convertVectorToObjectArray):
2231         (convertNSArrayToVector):
2232         (searchTextParameterizedAttributeForCriteria):
2233         (AccessibilityUIElement::getLinkedUIElements):
2234         (AccessibilityUIElement::getDocumentLinks):
2235         (AccessibilityUIElement::getChildren):
2236         (AccessibilityUIElement::getChildrenWithRange):
2237         (AccessibilityUIElement::rowHeaders const):
2238         (AccessibilityUIElement::columnHeaders const):
2239         (AccessibilityUIElement::uiElementArrayAttributeValue const):
2240         (AccessibilityUIElement::searchTextWithCriteria):
2241         (AccessibilityUIElement::attributesOfColumnHeaders):
2242         (AccessibilityUIElement::attributesOfRowHeaders):
2243         (AccessibilityUIElement::attributesOfColumns):
2244         (AccessibilityUIElement::attributesOfRows):
2245         (AccessibilityUIElement::attributesOfVisibleCells):
2246         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2247         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2248         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2249         (WTR::convertVectorToObjectArray):
2250         (WTR::convertNSArrayToVector):
2251         (WTR::searchTextParameterizedAttributeForCriteria):
2252         (WTR::AccessibilityUIElement::getLinkedUIElements):
2253         (WTR::AccessibilityUIElement::getDocumentLinks):
2254         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2255         (WTR::AccessibilityUIElement::getChildren):
2256         (WTR::AccessibilityUIElement::getChildrenWithRange):
2257         (WTR::AccessibilityUIElement::rowHeaders const):
2258         (WTR::AccessibilityUIElement::columnHeaders const):
2259         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2260         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2261         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2262         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2263         (WTR::AccessibilityUIElement::attributesOfColumns):
2264         (WTR::AccessibilityUIElement::attributesOfRows):
2265         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2266         (WTR::convertElementsToObjectArray): Deleted.
2267
2268 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2269
2270         Multiple File Input Icon Set Regardless of File List
2271         https://bugs.webkit.org/show_bug.cgi?id=195537
2272
2273         Reviewed by Alexey Proskuryakov.
2274
2275         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2276         display string in iOS file inputs
2277
2278         * DumpRenderTree/TestRunner.cpp:
2279         (SetOpenPanelFilesMediaIconCallback):
2280         (TestRunner::staticFunctions):
2281         (TestRunner::setOpenPanelFilesMediaIcon):
2282         * DumpRenderTree/TestRunner.h:
2283         (TestRunner::openPanelFilesMediaIcon const):
2284         * DumpRenderTree/mac/UIDelegate.mm:
2285         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2287         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2288         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2290         * WebKitTestRunner/TestController.cpp:
2291         (WTR::runOpenPanel):
2292         (WTR::TestController::resetStateToConsistentValues):
2293         * WebKitTestRunner/TestController.h:
2294         (WTR::TestController::openPanelFileURLsMediaIcon const):
2295         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2296         * WebKitTestRunner/TestInvocation.cpp:
2297         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2298
2299 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2300
2301         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2302         https://bugs.webkit.org/show_bug.cgi?id=197171
2303         <rdar://problem/47454979>
2304
2305         Reviewed by Youenn Fablet.
2306
2307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2308         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2309         (TestWebKitAPI::TEST):
2310
2311 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2312
2313         [ews-build] Add unit tests for UnApplyPatchIfRequired
2314         https://bugs.webkit.org/show_bug.cgi?id=197197
2315
2316         Reviewed by Lucas Forschler.
2317
2318         * BuildSlaveSupport/ews-build/steps_unittest.py:
2319         (TestUnApplyPatchIfRequired):
2320         (TestUnApplyPatchIfRequired.test_success):
2321         (TestUnApplyPatchIfRequired.test_failure):
2322         (TestUnApplyPatchIfRequired.test_skip):
2323
2324 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2325
2326         [ews-build] Add unit tests for CleanWorkingDirectory
2327         https://bugs.webkit.org/show_bug.cgi?id=197195
2328
2329         Reviewed by Lucas Forschler.
2330
2331         * BuildSlaveSupport/ews-build/steps_unittest.py:
2332         (TestCleanWorkingDirectory):
2333         (TestCleanWorkingDirectory.test_success):
2334         (TestCleanWorkingDirectory.test_failure):
2335
2336 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2337
2338         [ews-build] Use explicit imports instead of wildcard imports
2339         https://bugs.webkit.org/show_bug.cgi?id=197194
2340
2341         Reviewed by Lucas Forschler.
2342
2343         * BuildSlaveSupport/ews-build/factories.py:
2344         * BuildSlaveSupport/ews-build/loadConfig.py:
2345         * BuildSlaveSupport/ews-build/steps_unittest.py:
2346
2347 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2348
2349         [ews-build] Add unit tests for DownloadBuiltProduct
2350         https://bugs.webkit.org/show_bug.cgi?id=197193
2351
2352         Reviewed by Lucas Forschler.
2353
2354         * BuildSlaveSupport/ews-build/steps_unittest.py:
2355         (TestDownloadBuiltProduct):
2356         (TestDownloadBuiltProduct.setUp):
2357         (TestDownloadBuiltProduct.tearDown):
2358         (TestDownloadBuiltProduct.test_success):
2359         (TestDownloadBuiltProduct.test_failure):
2360
2361 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2362
2363         [ews-app] Exception while loading status-bubble when no build step has started
2364         https://bugs.webkit.org/show_bug.cgi?id=196676
2365
2366         Reviewed by Lucas Forschler.
2367
2368         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2369         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2370
2371 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2372
2373         [PlayStation] Support running of JSC tests on remote playstation devices
2374         https://bugs.webkit.org/show_bug.cgi?id=197170
2375
2376         Reviewed by Ross Kirsling.
2377
2378         Script changes
2379
2380         * Scripts/run-javascriptcore-tests:
2381         (runJSCStressTests): Pass arguments for playstation to
2382         run-jsc-stress-tests
2383         * Scripts/run-jsc-stress-tests:
2384         Handle $hostOS=="playstation" for determineArchitecture, turning
2385         off $isFTLPlatform and runProfiler and defaulting test writer.
2386         * Scripts/webkitdirs.pm:
2387         (jscPath): PlayStation WebKit executables have .elf extension
2388         (executableProductDir): PlayStation builds on Windows hosts but
2389         uses bin directory rather than bin64/bin32 for executable output
2390         location.
2391         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2392
2393 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2394
2395         [CMake][Win] Use target oriented design for WebKit
2396         https://bugs.webkit.org/show_bug.cgi?id=197173
2397
2398         Reviewed by Alex Christensen.
2399
2400         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2401         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2402
2403 2019-04-23  Chris Dumez  <cdumez@apple.com>
2404
2405         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2406         https://bugs.webkit.org/show_bug.cgi?id=197097
2407         <rdar://problem/50048318>
2408
2409         Reviewed by Alex Christensen.
2410
2411         Add API test coverage.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2414         (-[PSONScheme webView:startURLSchemeTask:]):
2415
2416 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2417
2418         [ATK] Implement AtkComponentIface scroll_to methods
2419         https://bugs.webkit.org/show_bug.cgi?id=196856
2420
2421         Reviewed by Michael Catanzaro.
2422
2423         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2424         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2425         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2426         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2427
2428 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2429
2430         [ews-build] Improve summary for UploadBuiltProduct step
2431         https://bugs.webkit.org/show_bug.cgi?id=197182
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * BuildSlaveSupport/ews-build/steps.py:
2436         (UploadBuiltProduct): Added descriptionDone.
2437         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2438         * BuildSlaveSupport/ews-build/steps_unittest.py:
2439         (TestUploadBuiltProduct.test_success): Updated unit-test.
2440         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2441
2442 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2443
2444         [ews-build] Trigger queues only after uploading the archive
2445         https://bugs.webkit.org/show_bug.cgi?id=197180
2446
2447         Reviewed by Lucas Forschler.
2448
2449         * BuildSlaveSupport/ews-build/factories.py:
2450         (Factory.__init__):
2451         (BuildFactory.__init__): Remove trigger step from factories.
2452         (BuildFactory.propertiesToPassToTriggers): Deleted.
2453         * BuildSlaveSupport/ews-build/steps.py:
2454         (ConfigureBuild.__init__): Confiure triggers property.
2455         (Trigger): Step to trigger other queues.
2456         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2457         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2458
2459 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2460
2461         Deprecate WKContextCreateWithInjectedBundlePath
2462         https://bugs.webkit.org/show_bug.cgi?id=197169
2463
2464         Reviewed by Youenn Fablet.
2465
2466         * TestWebKitAPI/PlatformUtilities.cpp:
2467         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2468         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2469
2470 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2471
2472         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2473         https://bugs.webkit.org/show_bug.cgi?id=197093
2474         <rdar://problem/49708268>
2475
2476         Reviewed by Chris Dumez.
2477
2478         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2479         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2480         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2481         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2482         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2483
2484         * TestWebKitAPI/TCPServer.cpp:
2485         (TestWebKitAPI::TCPServer::TCPServer):
2486         (TestWebKitAPI::TCPServer::~TCPServer):
2487         (TestWebKitAPI::TCPServer::socketBindListen):
2488         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2489         * TestWebKitAPI/TCPServer.h:
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2492         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2493         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2494         (respondWithChallengeThenOK):
2495         (TestWebKitAPI::TEST):
2496         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2497         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2498         (TEST):
2499
2500 2019-04-22  Chris Dumez  <cdumez@apple.com>
2501
2502         Delayed WebProcessLaunch may break the _relatedWebView SPI
2503         https://bugs.webkit.org/show_bug.cgi?id=197160
2504
2505         Reviewed by Alex Christensen.
2506
2507         Add API test coverage.
2508
2509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2510
2511 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2512
2513         Use curl to download packages for webkitpy autoinstaller
2514         https://bugs.webkit.org/show_bug.cgi?id=197164
2515
2516         Reviewed by Darin Adler.
2517
2518         * Scripts/webkitpy/common/system/autoinstall.py:
2519         (AutoInstaller._download): Use curl(1) to download packages necessary for
2520         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2521         errors which are not present when using curl(1).
2522
2523 2019-04-22  Chris Dumez  <cdumez@apple.com>
2524
2525         Unreviewed, rolling out r244502.
2526
2527         Caused crashes on the bots
2528
2529         Reverted changeset:
2530
2531         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2532         https://bugs.webkit.org/show_bug.cgi?id=197160
2533         https://trac.webkit.org/changeset/244502
2534
2535 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2536
2537         Unreviewed, rolling out r244437.
2538
2539         Still breaks internal tests.
2540
2541         Reverted changeset:
2542
2543         "InjectedBundle parameters often need initialization function
2544         called before unarchiving"
2545         https://bugs.webkit.org/show_bug.cgi?id=189709
2546         https://trac.webkit.org/changeset/244437
2547
2548 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-build] Use singular verb in failure description in case of single api test failure
2551         https://bugs.webkit.org/show_bug.cgi?id=197013
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * BuildSlaveSupport/ews-build/steps.py:
2556         (AnalyzeAPITestsResults.analyzeResults):
2557
2558 2019-04-22  Chris Dumez  <cdumez@apple.com>
2559
2560         Delayed WebProcessLaunch may break the _relatedWebView SPI
2561         https://bugs.webkit.org/show_bug.cgi?id=197160
2562
2563         Reviewed by Alex Christensen.
2564
2565         Add API test coverage.
2566
2567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2568
2569 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2570
2571         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2572         https://bugs.webkit.org/show_bug.cgi?id=194630
2573
2574         Reviewed by Michael Catanzaro.
2575
2576         Return early from getAttributeSet() is passed in accessible is nullptr.
2577
2578         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2579
2580 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2581
2582         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2583         https://bugs.webkit.org/show_bug.cgi?id=197145
2584         <rdar://problem/50078170>
2585
2586         Reviewed by Darin Adler.
2587
2588         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2589         focus, or showing the font manager.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2592         (TestWebKitAPI::TEST):
2593         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2594         (TEST):
2595         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2596         (TestWebKitAPI::TEST):
2597
2598 2019-04-21  Brian Burg  <bburg@apple.com>
2599
2600         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2601         https://bugs.webkit.org/show_bug.cgi?id=197125
2602         <rdar://problem/50061468>
2603
2604         Reviewed by Darin Adler.
2605
2606         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2607         using this class rather than making our own ./wpt serve invocation.
2608
2609         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2610         (WebDriverW3CWebServer):
2611         (WebDriverW3CWebServer.document_root): Expose this to clients.
2612         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2613
2614         (WebDriverW3CWebServer.__enter__):
2615         (WebDriverW3CWebServer.__exit__):
2616         Make it possible to use the web server with a 'with' statement.
2617
2618 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2619
2620         [CMake][Win] Use target oriented design for WebKitLegacy
2621         https://bugs.webkit.org/show_bug.cgi?id=197112
2622
2623         Reviewed by Konstantin Tokarev.
2624
2625         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2626
2627         * DumpRenderTree/CMakeLists.txt:
2628         * DumpRenderTree/PlatformWin.cmake:
2629         * DumpRenderTree/win/EventSender.cpp:
2630
2631 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2632
2633         Update text for old EWS submit button
2634         https://bugs.webkit.org/show_bug.cgi?id=197140
2635
2636         Reviewed by Alexey Proskuryakov.
2637
2638         * QueueStatusServer/templates/statusbubble.html:
2639
2640 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2641
2642         [ews-app] New EWS should poll bugzilla more frequently
2643         https://bugs.webkit.org/show_bug.cgi?id=197138
2644
2645         Reviewed by Alexey Proskuryakov.
2646
2647         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2648         (FetchLoop.__init__):
2649
2650 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2651
2652         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2653         https://bugs.webkit.org/show_bug.cgi?id=197139
2654
2655         Reviewed by Alexey Proskuryakov.
2656
2657         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2658         * QueueStatusServer/templates/statusbubble.html:
2659
2660 2019-04-20  Chris Dumez  <cdumez@apple.com>
2661
2662         Unreviewed, fix iOS build with recent SDKs.
2663
2664         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2665
2666 2019-04-19  Keith Miller  <keith_miller@apple.com>
2667
2668         Add script to merge run_benchmark jsons
2669         https://bugs.webkit.org/show_bug.cgi?id=197107
2670
2671         Reviewed by Michael Saboff.
2672
2673         The script basically recursively decends through all json objects until it gets
2674         to an array or JSON primitive and concats or takes the first value, respectively.
2675
2676         This patch also adds +x bits to the compare-results script so it
2677         can be run directly from the command line. I had to add a new line so that svn
2678         will accept the change... yay svn!
2679
2680         * Scripts/compare-results:
2681         * Scripts/merge-result-jsons: Added.
2682         (readJSONFile):
2683         (deepAppend):
2684         (mergeJSONs):
2685         (main):
2686
2687 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2688
2689         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2690         https://bugs.webkit.org/show_bug.cgi?id=197079
2691
2692         Reviewed by Darin Adler.
2693
2694         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2695
2696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2697         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2698
2699 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2700
2701         Unreviewed, rolling out r244434.
2702         https://bugs.webkit.org/show_bug.cgi?id=197089
2703
2704         caused 1 API test failure (Requested by zalan on #webkit).
2705
2706         Reverted changeset:
2707
2708         "Regression (r244291): Broken API Test
2709         AutoLayoutRenderingProgressRelativeOrdering"
2710         https://bugs.webkit.org/show_bug.cgi?id=196948
2711         https://trac.webkit.org/changeset/244434
2712
2713 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2714
2715         Add new compatibility mode API on WKNavigation
2716         https://bugs.webkit.org/show_bug.cgi?id=197069
2717         <rdar://problem/50025800>
2718
2719         Reviewed by Tim Horton.
2720
2721         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2722
2723         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2724         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2725         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2726
2727 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2728
2729         [CMake] Make WebCore headers copies
2730         https://bugs.webkit.org/show_bug.cgi?id=182512
2731         <rdar://problem/37510435>
2732
2733         Reviewed by Alex Christensen.
2734
2735         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2736         ports.
2737
2738         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2739         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2740
2741         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2742         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2743         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2744         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2745         * TestWebKitAPI/CMakeLists.txt:
2746         * TestWebKitAPI/PlatformWin.cmake:
2747         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2748         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2749         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2750
2751 2019-04-18  Jer Noble  <jer.noble@apple.com>
2752
2753         Add support for parsing FairPlayStreaming PSSH boxes.
2754         https://bugs.webkit.org/show_bug.cgi?id=197064
2755
2756         Reviewed by Eric Carlson.
2757
2758         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2759         (TestWebKitAPI::TEST):
2760
2761 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2762
2763         InjectedBundle parameters often need initialization function called before unarchiving
2764         https://bugs.webkit.org/show_bug.cgi?id=189709
2765         <rdar://problem/44573653>
2766
2767         Reviewed by Ryosuke Niwa.
2768
2769         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2770         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2771
2772 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2773
2774         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2775         https://bugs.webkit.org/show_bug.cgi?id=196948
2776         <rdar://problem/49927131>
2777
2778         Reviewed by Tim Horton.
2779
2780         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2781         (TEST): 
2782         The expected order of incoming events is
2783         1. didInvalidateIntrinsicContentSize
2784         2. didFirstLayout
2785         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2786         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2787         (and remember, all we care about is ordering).
2788
2789 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2790
2791         Unreviewed, rolling out r244299.
2792
2793         Breaks internal tests.
2794
2795         Reverted changeset:
2796
2797         "InjectedBundle parameters often need initialization function
2798         called before unarchiving"
2799         https://bugs.webkit.org/show_bug.cgi?id=189709
2800         https://trac.webkit.org/changeset/244299
2801
2802 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2803
2804         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2805         https://bugs.webkit.org/show_bug.cgi?id=197053
2806
2807         Reviewed by Saam Barati.
2808
2809         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2810         (TestWebKitAPI::TEST):
2811
2812 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2813
2814         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2815         https://bugs.webkit.org/show_bug.cgi?id=197028
2816         <rdar://problem/49985290>
2817
2818         Reviewed by Wenson Hsieh.
2819
2820         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2821         (TEST):
2822         Liberal application of waitForNextPresentationUpdate works around a race
2823         where if the page rapidly changes its viewport arguments (or an API client
2824         rapidly changes its viewport arguments), we'd get stuck thinking that the
2825         user had intentionally zoomed the page, and stop resetting the initial scale.
2826         This deserves a separate bug, but no need to keep the test failing while
2827         we think about it.
2828
2829 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2830
2831         REGRESSION (r241988): Switching tabs is slow
2832         https://bugs.webkit.org/show_bug.cgi?id=197037
2833         <rdar://problem/49951473>
2834
2835         Reviewed by Simon Fraser.
2836
2837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2838         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2839         (TEST):
2840         * TestWebKitAPI/cocoa/TestWKWebView.h:
2841         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2842         (-[TestWKWebView addToTestWindow]):
2843         Add a test that hangs without this fix.
2844
2845 2019-04-17  Truitt Savell  <tsavell@apple.com>
2846
2847         Unreviewed, rolling out r244400.
2848
2849         Caused testing to exit early with assertionon Debug WK2
2850
2851         Reverted changeset:
2852
2853         "UI↔Web deadlock when printing with a JavaScript alert
2854         visible"
2855         https://bugs.webkit.org/show_bug.cgi?id=196839
2856         https://trac.webkit.org/changeset/244400
2857
2858 2019-04-17  Brady Eidson  <beidson@apple.com>
2859
2860         Link clicks in PDFs shouldn't send referrer headers.
2861         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2862
2863         Reviewed by Tim Horton.
2864
2865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2866         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2867         (putPDFBytesCallback):
2868         (emptyReleaseInfoCallback):
2869         (createPDFWithLinkToURL):
2870         (TEST):
2871
2872 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2873
2874         UI↔Web deadlock when printing with a JavaScript alert visible
2875         https://bugs.webkit.org/show_bug.cgi?id=196839
2876         <rdar://problem/49157642>
2877
2878         Reviewed by Andy Estes.
2879
2880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2881         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2882         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2883         (TEST):
2884
2885 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2886
2887         WKRetainPtr's adoption constructor should be private
2888         https://bugs.webkit.org/show_bug.cgi?id=197019
2889
2890         Reviewed by Tim Horton.
2891
2892         * DumpRenderTree/mac/DumpRenderTree.mm:
2893         (dumpFramesAsText):
2894         * TestWebKitAPI/InjectedBundleController.cpp:
2895         (TestWebKitAPI::InjectedBundleController::initialize):
2896         * TestWebKitAPI/PlatformUtilities.cpp:
2897         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2898         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2899         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2900         (TestWebKitAPI::Util::toWK):
2901         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2902         (TestWebKitAPI::TEST):
2903         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2904         (TestWebKitAPI::TEST):
2905         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2906         (TestWebKitAPI::TEST):
2907         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2908         (TestWebKitAPI::TEST):
2909         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2910         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2911         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2912         (TestWebKitAPI::TEST):
2913         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2914         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2915         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2916         (TestWebKitAPI::TEST):
2917         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2918         (TestWebKitAPI::TEST):
2919         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2920         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2921         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2922         (TestWebKitAPI::TEST):
2923         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2924         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2925         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2926         (TestWebKitAPI::TEST):
2927         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2928         (TestWebKitAPI::TEST):
2929         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2930         (TestWebKitAPI::TEST):
2931         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2932         (TestWebKitAPI::TEST):
2933         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2934         (TestWebKitAPI::TEST):
2935         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2936         (TestWebKitAPI::TEST):
2937         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2938         (TestWebKitAPI::TEST):
2939         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2940         (TestWebKitAPI::TEST):
2941         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2942         (TestWebKitAPI::TEST):
2943         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2944         (TestWebKitAPI::TEST):
2945         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2946         (TestWebKitAPI::TEST):
2947         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2948         (TestWebKitAPI::TEST):
2949         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2950         (TestWebKitAPI::TEST):
2951         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2952         (TestWebKitAPI::TEST):
2953         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2954         (TestWebKitAPI::TEST):
2955         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2956         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2957         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2958         (TestWebKitAPI::TEST):
2959         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2960         (TestWebKitAPI::TEST):
2961         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2962         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2963         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2964         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2965         (TestWebKitAPI::TEST):
2966         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2967         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2968         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2969         (TestWebKitAPI::TEST):
2970         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2973         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2974         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2975         (TestWebKitAPI::TEST):
2976         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2977         (TestWebKitAPI::loadAlternateHTMLString):
2978         (TestWebKitAPI::TEST):
2979         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2980         (TestWebKitAPI::TEST):
2981         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2982         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2983         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2984         (TestWebKitAPI::buildAndPerformTest):
2985         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2986         (TestWebKitAPI::TEST):
2987         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2988         (TestWebKitAPI::TEST):
2989         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2990         (TestWebKitAPI::TEST):
2991         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2992         (TestWebKitAPI::TEST):
2993         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2994         (TestWebKitAPI::TEST):
2995         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2996         (TestWebKitAPI::TEST):
2997         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2998         (TestWebKitAPI::TEST):
2999         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3000         (TestWebKitAPI::TEST):
3001         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
3002         (TestWebKitAPI::TEST):
3003         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3004         (TestWebKitAPI::TEST):
3005         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3006         (TestWebKitAPI::TEST):
3007         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3008         (TestWebKitAPI::TEST):
3009         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3010         (TestWebKitAPI::TEST):
3011         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3012         (TestWebKitAPI::TEST):
3013         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3014         (TestWebKitAPI::TEST):
3015         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3016         (TestWebKitAPI::TEST):
3017         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3018         (TestWebKitAPI::TEST):
3019         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3020         (TestWebKitAPI::TEST):
3021         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3022         (TestWebKitAPI::TEST):
3023         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3024         (TestWebKitAPI::TEST):
3025         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
3026         (TestWebKitAPI::TEST):
3027         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
3028         (TestWebKitAPI::TEST):
3029         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3030         (TestWebKitAPI::TEST):
3031         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3032         (TestWebKitAPI::TEST):
3033         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3034         (TestWebKitAPI::TEST):
3035         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3036         (TestWebKitAPI::TEST):
3037         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3038         (TestWebKitAPI::TEST):
3039         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3040         (TestWebKitAPI::TEST):
3041         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3042         (TestWebKitAPI::TEST):
3043         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
3044         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3045         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
3046         (TestWebKitAPI::TEST):
3047         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
3048         (TestWebKitAPI::TEST):
3049         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
3050         (TestWebKitAPI::TEST):
3051         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
3052         (TestWebKitAPI::TEST):
3053         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3054         (TestWebKitAPI::TEST):
3055         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3056         (TestWebKitAPI::TEST):
3057         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
3058         (TestWebKitAPI::TEST):
3059         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3060         (TestWebKitAPI::TEST):
3061         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3062         (TestWebKitAPI::TEST):
3063         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3064         (TestWebKitAPI::TEST):
3065         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
3066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
3067         (TEST):
3068         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3069         (TEST):
3070         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3071         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3072         (TEST):
3073         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
3074         (TestWebKitAPI::TEST):
3075         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3076         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3077         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3078         (WTR::getMenuItemTitleCallback):
3079         (WTR::createMouseMessageBody):
3080         (WTR::EventSendingController::mouseDown):
3081         (WTR::EventSendingController::mouseUp):
3082         (WTR::EventSendingController::mouseMoveTo):
3083         (WTR::EventSendingController::mouseForceClick):
3084         (WTR::EventSendingController::startAndCancelMouseForceClick):
3085         (WTR::EventSendingController::mouseForceDown):
3086         (WTR::EventSendingController::mouseForceUp):
3087         (WTR::EventSendingController::mouseForceChanged):
3088         (WTR::EventSendingController::leapForward):
3089         (WTR::EventSendingController::scheduleAsynchronousClick):
3090         (WTR::createKeyDownMessageBody):
3091         (WTR::EventSendingController::keyDown):
3092         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3093         (WTR::EventSendingController::mouseScrollBy):
3094         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3095         (WTR::EventSendingController::continuousMouseScrollBy):
3096         (WTR::EventSendingController::addTouchPoint):
3097         (WTR::EventSendingController::updateTouchPoint):
3098         (WTR::EventSendingController::setTouchModifier):
3099         (WTR::EventSendingController::setTouchPointRadius):
3100         (WTR::EventSendingController::touchStart):
3101         (WTR::EventSendingController::touchMove):
3102         (WTR::EventSendingController::touchEnd):
3103         (WTR::EventSendingController::touchCancel):
3104         (WTR::EventSendingController::clearTouchPoints):
3105         (WTR::EventSendingController::releaseTouchPoint):
3106         (WTR::EventSendingController::cancelTouchPoint):
3107         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3108         (WTR::InjectedBundle::didCreatePage):
3109         (WTR::InjectedBundle::didReceiveMessage):
3110         (WTR::InjectedBundle::didReceiveMessageToPage):
3111         (WTR::InjectedBundle::booleanForKey):
3112         (WTR::InjectedBundle::done):
3113         (WTR::InjectedBundle::dumpToStdErr):
3114         (WTR::InjectedBundle::outputText):
3115         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3116         (WTR::InjectedBundle::postAddChromeInputField):
3117         (WTR::InjectedBundle::postRemoveChromeInputField):
3118         (WTR::InjectedBundle::postFocusWebView):
3119         (WTR::InjectedBundle::postSetBackingScaleFactor):
3120         (WTR::InjectedBundle::postSetWindowIsKey):
3121         (WTR::InjectedBundle::postSetViewSize):
3122         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3123         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3124         (WTR::InjectedBundle::setGeolocationPermission):
3125         (WTR::InjectedBundle::setMockGeolocationPosition):
3126         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3127         (WTR::InjectedBundle::isGeolocationProviderActive const):
3128         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
3129         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3130         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
3131         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3132         (WTR::InjectedBundle::setCustomPolicyDelegate):
3133         (WTR::InjectedBundle::setHidden):
3134         (WTR::InjectedBundle::setCacheModel):
3135         (WTR::InjectedBundle::shouldProcessWorkQueue const):
3136         (WTR::InjectedBundle::processWorkQueue):
3137         (WTR::InjectedBundle::queueBackNavigation):
3138         (WTR::InjectedBundle::queueForwardNavigation):
3139         (WTR::InjectedBundle::queueLoad):
3140         (WTR::InjectedBundle::queueLoadHTMLString):
3141         (WTR::InjectedBundle::queueReload):
3142         (WTR::InjectedBundle::queueLoadingScript):
3143         (WTR::InjectedBundle::queueNonLoadingScript):
3144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3145         (WTR::frameToStr):
3146         (WTR::InjectedBundlePage::InjectedBundlePage):
3147         (WTR::dumpFrameDescriptionSuitableForTestResult):
3148         (WTR::dumpFrameScrollPosition):
3149         (WTR::dumpDescendantFrameScrollPositions):
3150         (WTR::dumpFrameText):
3151         (WTR::dumpDescendantFramesText):
3152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3153         (WTR::TestRunner::shouldDumpPixels const):
3154         (WTR::TestRunner::setDumpPixels):
3155         (WTR::TestRunner::whatToDump const):
3156         (WTR::TestRunner::setWhatToDump):
3157         (WTR::TestRunner::setWaitUntilDone):
3158         (WTR::TestRunner::shouldWaitUntilDone const):
3159         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
3160         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3161         (WTR::TestRunner::clearAllDatabases):
3162         (WTR::TestRunner::setIDBPerOriginQuota):
3163         (WTR::TestRunner::originsWithApplicationCache):
3164         (WTR::TestRunner::setCanOpenWindows):
3165         (WTR::TestRunner::setXSSAuditorEnabled):
3166         (WTR::TestRunner::setMediaDevicesEnabled):
3167         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
3168         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
3169         (WTR::TestRunner::setCustomUserAgent):
3170         (WTR::TestRunner::setWebAPIStatisticsEnabled):
3171         (WTR::TestRunner::setModernMediaControlsEnabled):
3172         (WTR::TestRunner::setWebGL2Enabled):
3173         (WTR::TestRunner::setWritableStreamAPIEnabled):
3174         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
3175         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
3176         (WTR::TestRunner::setAllowsAnySSLCertificate):
3177         (WTR::TestRunner::setPluginsEnabled):
3178         (WTR::TestRunner::setValueForUser):
3179         (WTR::TestRunner::setAudioResult):
3180         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3181         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3182         (WTR::TestRunner::setAlwaysAcceptCookies):
3183         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3184         (WTR::TestRunner::isDoingMediaCapture const):
3185         (WTR::TestRunner::queueLoad):
3186         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3187         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3188         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3189         (WTR::TestRunner::setShouldLogDownloadCallbacks):
3190         (WTR::TestRunner::setAuthenticationUsername):
3191         (WTR::TestRunner::setAuthenticationPassword):
3192         (WTR::TestRunner::secureEventInputIsEnabled const):
3193         (WTR::TestRunner::setBlockAllPlugins):
3194         (WTR::TestRunner::setPluginSupportedMode):
3195         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3196         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
3197         (WTR::TestRunner::setNavigationGesturesEnabled):
3198         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3199         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
3200         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3201         (WTR::TestRunner::terminateNetworkProcess):
3202         (WTR::TestRunner::terminateServiceWorkerProcess):
3203         (WTR::TestRunner::runUIScript):
3204         (WTR::TestRunner::setStatisticsDebugMode):
3205         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3206         (WTR::TestRunner::setStatisticsLastSeen):
3207         (WTR::TestRunner::setStatisticsPrevalentResource):
3208         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
3209         (WTR::TestRunner::dumpResourceLoadStatistics):
3210         (WTR::TestRunner::isStatisticsPrevalentResource):
3211         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3212         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3213         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3214         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3215         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
3216         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3217         (WTR::TestRunner::setStatisticsGrandfathered):
3218         (WTR::TestRunner::isStatisticsGrandfathered):
3219         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
3220         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
3221         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
3222         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
3223         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
3224         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
3225         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3226         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
3227         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3228         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3229         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3230         (WTR::TestRunner::statisticsSubmitTelemetry):
3231         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3232         (WTR::TestRunner::setStatisticsIsRunningTest):
3233         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3234         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3235         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3236         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3237         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3238         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3239         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3240         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3241         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3242         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3243         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3244         (WTR::TestRunner::statisticsResetToConsistentState):
3245         (WTR::TestRunner::setStorageAccessAPIEnabled):
3246         (WTR::TestRunner::getAllStorageAccessEntries):
3247         (WTR::TestRunner::addMockMediaDevice):
3248         (WTR::TestRunner::clearMockMediaDevices):
3249         (WTR::TestRunner::removeMockMediaDevice):
3250         (WTR::TestRunner::resetMockMediaDevices):
3251         (WTR::TestRunner::connectMockGamepad):
3252         (WTR::TestRunner::disconnectMockGamepad):
3253         (WTR::TestRunner::setMockGamepadDetails):
3254         (WTR::TestRunner::setMockGamepadAxisValue):
3255         (WTR::TestRunner::setMockGamepadButtonValue):
3256         (WTR::TestRunner::removeAllSessionCredentials):
3257         (WTR::TestRunner::clearDOMCache):
3258         (WTR::TestRunner::clearDOMCaches):
3259         (WTR::TestRunner::hasDOMCache):
3260         (WTR::TestRunner::domCacheSize):
3261         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3262         (WTR::TestRunner::getApplicationManifestThen):
3263         (WTR::TestRunner::injectUserScript):
3264         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3265         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3266         (WTR::TestRunner::addTestKeyToKeychain):
3267         (WTR::TestRunner::cleanUpKeychain):
3268         (WTR::TestRunner::keyExistsInKeychain):
3269         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3270         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3271         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3272         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3273         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3274         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3275         * WebKitTestRunner/TestController.cpp:
3276         (WTR::TestController::initialize):
3277         (WTR::parseStringTestHeaderValueAsRelativePath):
3278         (WTR::updateTestOptionsFromTestHeader):
3279         (WTR::TestController::runTest):
3280         (WTR::TestController::didReceiveLiveDocumentsList):
3281         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3282         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3283         (WTR::TestController::didFinishNavigation):
3284         (WTR::TestController::didReceiveAuthenticationChallenge):
3285         * WebKitTestRunner/TestInvocation.cpp:
3286         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3287         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3288         (WTR::TestInvocation::uiScriptDidComplete):
3289         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3290         * WebKitTestRunner/WebNotificationProvider.cpp:
3291         (WTR::WebNotificationProvider::closeWebNotification):
3292         * WebKitTestRunner/WorkQueueManager.cpp:
3293         (WTR::ScriptItem::ScriptItem):
3294         (WTR::WorkQueueManager::queueLoad):
3295         (WTR::WorkQueueManager::queueLoadHTMLString):
3296
3297 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3298
3299         Add a comment to make my test from r244139 less mysterious.
3300         https://bugs.webkit.org/show_bug.cgi?id=196744
3301
3302         As suggested by Darin Adler.
3303
3304         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3305         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3306
3307 2019-04-17  Chris Dumez  <cdumez@apple.com>
3308
3309         Remember device orientation permission for the duration of the browsing session
3310         https://bugs.webkit.org/show_bug.cgi?id=196992
3311         <rdar://problem/49946067>
3312
3313         Reviewed by Alex Christensen.
3314
3315         Add API test coverage.
3316
3317         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3318         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3319         (TEST):
3320
3321 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3322
3323         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3324         https://bugs.webkit.org/show_bug.cgi?id=196675
3325
3326         Reviewed by Lucas Forschler.
3327
3328         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3329         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3330
3331 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3332
3333         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3334         https://bugs.webkit.org/show_bug.cgi?id=196919
3335         <rdar://problem/41630459>
3336
3337         Reviewed by Tim Horton.
3338
3339         Add iOS support for several new testing hooks. See below for more detail.
3340
3341         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3342         (WTR::UIScriptController::isDismissingMenu const):
3343
3344         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3345         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3346         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3347
3348         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3349         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3350         (WTR::UIScriptController::isDismissingMenu const):
3351         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3353         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3354         (WTR::InjectedBundle::didReceiveMessageToPage):
3355         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3356         (WTR::TestRunner::setAllowedMenuActions):
3357
3358         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3359         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3360         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3361         against the name of the custom action.
3362
3363         (WTR::TestRunner::installCustomMenuAction):
3364
3365         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3366         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3367         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3368         triggered.
3369
3370         (WTR::TestRunner::performCustomMenuAction):
3371
3372         Invoked when the custom menu action is triggered.
3373
3374         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3375         * WebKitTestRunner/TestController.cpp:
3376         (WTR::TestController::installCustomMenuAction):
3377         (WTR::TestController::setAllowedMenuActions):
3378         * WebKitTestRunner/TestController.h:
3379         * WebKitTestRunner/TestInvocation.cpp:
3380         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3381         (WTR::TestInvocation::performCustomMenuAction):
3382
3383         Add plumbing to call back into the injected bundle when performing the custom action.
3384
3385         * WebKitTestRunner/TestInvocation.h:
3386         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3387         (WTR::TestController::installCustomMenuAction):
3388         (WTR::TestController::setAllowedMenuActions):
3389         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3390         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3391         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3392         (-[TestRunnerWKWebView becomeFirstResponder]):
3393         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3394
3395         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3396         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3397         in the Mail app on iOS.
3398
3399         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3400         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3401         (-[TestRunnerWKWebView resetCustomMenuAction]):
3402         (-[TestRunnerWKWebView performCustomAction:]):
3403         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3404         (-[TestRunnerWKWebView _willHideMenu]):
3405         (-[TestRunnerWKWebView _didHideMenu]):
3406         * WebKitTestRunner/ios/TestControllerIOS.mm:
3407         (WTR::TestController::platformResetStateToConsistentValues):
3408
3409         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3410         if specified.
3411
3412         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3413         (WTR::UIScriptController::isDismissingMenu const):
3414
3415 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3416
3417         Allow sharing from imageSheet on an image document
3418         https://bugs.webkit.org/show_bug.cgi?id=196891
3419         <rdar://problem/25377386>
3420
3421         Reviewed by Tim Horton.
3422
3423         Test to make sure that the correct imageURL is extracted from an image element.
3424
3425         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3426         (TestWebKitAPI::TEST):
3427
3428 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3429
3430         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3431         https://bugs.webkit.org/show_bug.cgi?id=196995
3432
3433         Reviewed by Brady Eidson.
3434
3435         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3436         (TEST):
3437
3438 2019-04-16  Chris Dumez  <cdumez@apple.com>
3439
3440         URL set by document.open() is not communicated to the UIProcess
3441         https://bugs.webkit.org/show_bug.cgi?id=196941
3442         <rdar://problem/49237544>
3443
3444         Reviewed by Geoff Garen.
3445
3446         Add API test coverage.
3447
3448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3449         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3450         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3451         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3452         (TEST):
3453
3454 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3455
3456         Unreviewed, rolling out r244321.
3457         https://bugs.webkit.org/show_bug.cgi?id=196968
3458
3459         Causing all WK2 Debug builds to exit early after Assertion
3460         failures. (Requested by ShawnRoberts on #webkit).
3461
3462         Reverted changeset:
3463
3464         "URL set by document.open() is not communicated to the
3465         UIProcess"
3466         https://bugs.webkit.org/show_bug.cgi?id=196941
3467         https://trac.webkit.org/changeset/244321
3468
3469 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3470
3471         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3472         https://bugs.webkit.org/show_bug.cgi?id=196948
3473
3474         Reviewed by Zalan Bujtas.
3475
3476         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3477         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3478
3479 2019-04-15  Chris Dumez  <cdumez@apple.com>
3480
3481         URL set by document.open() is not communicated to the UIProcess
3482         https://bugs.webkit.org/show_bug.cgi?id=196941
3483         <rdar://problem/49237544>
3484
3485         Reviewed by Geoffrey Garen.
3486
3487         Add API test coverage.
3488
3489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3490         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3491         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3492         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3493         (TEST):
3494
3495 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3496
3497         Using Tools/Scripts/clean-webkit should not install requests
3498         https://bugs.webkit.org/show_bug.cgi?id=196940
3499
3500         Reviewed by Lucas Forschler.
3501
3502         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3503         existing, depending on the path autoinstalled is run through.
3504         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3505         needed.
3506         (Port.configuration_for_upload):
3507         (Port.commits_for_upload):
3508
3509 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3510
3511         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3512         https://bugs.webkit.org/show_bug.cgi?id=196773
3513
3514         Reviewed by Jer Noble.
3515
3516         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3517         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3518         (TEST):
3519
3520 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3521
3522         ews-build should clearly indicate flaky test failures
3523         https://bugs.webkit.org/show_bug.cgi?id=196947
3524
3525         Reviewed by Lucas Forschler.
3526
3527         * BuildSlaveSupport/ews-build/steps.py:
3528         (AnalyzeAPITestsResults.analyzeResults):
3529
3530 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3531
3532         InjectedBundle parameters often need initialization function called before unarchiving
3533         https://bugs.webkit.org/show_bug.cgi?id=189709
3534         <rdar://problem/44573653>
3535
3536         Reviewed by Ryosuke Niwa.
3537
3538         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3539         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3540
3541 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3542
3543         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3544         https://bugs.webkit.org/show_bug.cgi?id=196681
3545
3546         Reviewed by Darin Adler.
3547
3548         Added tests.
3549
3550         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3551         (WTF_HashSet.RemoveIf):
3552         (WTF_HashSet.RemoveIfShrinkToBestSize):
3553
3554 2019-04-15  John Wilander  <wilander@apple.com>
3555
3556         Send delayed Ad Click Attribution conversion requests to the click source
3557         https://bugs.webkit.org/show_bug.cgi?id=196838
3558         <rdar://problem/47650157>
3559
3560         Reviewed by Chris Dumez and Youenn Fablet.
3561
3562         This patch adds test infrastructure to override the default behavior in
3563         WebKit::NetworkAdClickAttribution.
3564
3565         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3566         (TestWebKitAPI::TEST):
3567         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3568         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3569         (WTR::TestRunner::dumpAdClickAttribution):
3570         (WTR::TestRunner::clearAdClickAttribution):
3571         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3572         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3574         * WebKitTestRunner/TestController.cpp:
3575         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3576         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3577         * WebKitTestRunner/TestController.h:
3578         * WebKitTestRunner/TestInvocation.cpp:
3579         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3580
3581 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3582
3583         [ews-app] status-bubble should display position in queue
3584         https://bugs.webkit.org/show_bug.cgi?id=196607
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3589         (StatusBubble._build_bubble):
3590         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3591
3592 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3593
3594         [ews-build] Do not run clean build by default on EWS builders
3595         https://bugs.webkit.org/show_bug.cgi?id=196897
3596
3597         Reviewed by Lucas Forschler.
3598
3599         * BuildSlaveSupport/ews-build/steps.py:
3600         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3601         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3602         untracked directories like WebKitBuild).
3603         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3604         untracked files/directories (like WebKitBuild).
3605
3606 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3607
3608         TestRunner::notifyDone() should be safely reentrant
3609         https://bugs.webkit.org/show_bug.cgi?id=196898
3610
3611         Reviewed by Darin Adler.
3612
3613         It is currently possible that TestRunner::notifyDone() will call itself, since
3614         notifyDone() will force a repaint, which can start executing JavaScript, which
3615         may call notifyDone() again. This can lead to test failures and flakiness.
3616         Fix this by setting the m_waitToDump flag before calling the dump() method.
3617
3618         * DumpRenderTree/mac/TestRunnerMac.mm:
3619         (TestRunner::notifyDone):
3620         (TestRunner::forceImmediateCompletion):
3621         * DumpRenderTree/win/TestRunnerWin.cpp:
3622         (TestRunner::notifyDone):
3623         (TestRunner::forceImmediateCompletion):
3624
3625 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3626
3627         [GTK][WPE] Add enable-media websetting
3628         https://bugs.webkit.org/show_bug.cgi?id=196863
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3633         (testWebKitSettings): Add test for the enable-media web-setting.
3634
3635 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3636
3637         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3638         https://bugs.webkit.org/show_bug.cgi?id=196905
3639         <rdar://problem/49886096>
3640
3641         Reviewed by Tim Horton.
3642
3643         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3644         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3645         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3646         delay timer, we end up with this sequence of events in the problematic (failure) case:
3647
3648         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3649             ...IPC from UI to web process...
3650         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3651             ...IPC from web to UI process...
3652         (c) [UI]    Invoke completion handler for script #1
3653         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3654             ...IPC from UI to web process...