Remove more i386 specific configurations
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-31  Sam Weinig  <weinig@apple.com>
2
3         Remove more i386 specific configurations
4         https://bugs.webkit.org/show_bug.cgi?id=196430
5
6         Reviewed by Alexey Proskuryakov.
7
8         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
10
11 2019-03-31  Andy Estes  <aestes@apple.com>
12
13         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
14         https://bugs.webkit.org/show_bug.cgi?id=196433
15         <rdar://problem/49293305>
16
17         Reviewed by Tim Horton.
18
19         Enhanced API test coverage to include all navigation response policy decisions in both
20         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
21
22         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
26         (readFile):
27         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
28         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
29         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
30         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
31         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
32         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
33         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
34         (-[QuickLookDelegate _downloadDidStart:]):
35         (-[QuickLookDelegate _download:didReceiveResponse:]):
36         (-[QuickLookDelegate _download:didReceiveData:]):
37         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
38         (-[QuickLookDelegate _downloadDidFinish:]):
39         (-[QuickLookDelegate _download:didFailWithError:]):
40         (-[QuickLookDelegate _downloadDidCancel:]):
41         (-[QuickLookDelegate verifyDownload]):
42         (runTest):
43         (runTestDecideBeforeLoading):
44         (runTestDecideAfterLoading):
45         (TEST):
46         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
47         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
48         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
49         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
50         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
51         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
52         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
53         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
54         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
55         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
56         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
57         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
58         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
59         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
60
61 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
62
63         [CMake] add testdfg as target with build-jsc
64         https://bugs.webkit.org/show_bug.cgi?id=196393
65
66         Reviewed by Saam Barati.
67
68         Added testdfg as one of the targets to build when
69         using CMake.
70
71         * Scripts/build-jsc:
72
73 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
74
75         Delete WebMetal implementation in favor of WebGPU
76         https://bugs.webkit.org/show_bug.cgi?id=195418
77
78         Reviewed by Dean Jackson.
79
80         * DumpRenderTree/mac/DumpRenderTree.mm:
81         (enableExperimentalFeatures):
82         (resetWebPreferencesToConsistentValues):
83         * Scripts/webkitperl/FeatureList.pm:
84         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
87         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
88         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
89         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
90         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
91         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
92         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
93         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
94         (WTR::InjectedBundle::beginTesting):
95         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
96         (WTR::TestRunner::setWebMetalEnabled): Deleted.
97         * WebKitTestRunner/InjectedBundle/TestRunner.h:
98
99 2019-03-29  Chris Dumez  <cdumez@apple.com>
100
101         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
102         https://bugs.webkit.org/show_bug.cgi?id=196405
103         <rdar://problem/49428130>
104
105         Reviewed by Wenson Hsieh.
106
107         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
108         the popover presentation methods to be no-ops. Use this in the new test added in
109         r243523 so that we do not swizzle those methods for all tests. This is needed because
110         those WatchOS tests rely on the popover getting presented and interactive.
111
112         * WebKitTestRunner/TestController.cpp:
113         (WTR::updateTestOptionsFromTestHeader):
114         * WebKitTestRunner/TestController.h:
115         * WebKitTestRunner/TestOptions.h:
116         (WTR::TestOptions::hasSameInitializationOptions const):
117         * WebKitTestRunner/ios/TestControllerIOS.mm:
118         (WTR::TestController::platformInitialize):
119         (WTR::TestController::platformResetStateToConsistentValues):
120
121 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
122
123         [Curl] Add Server Trust Evaluation Support.
124         https://bugs.webkit.org/show_bug.cgi?id=191646
125
126         Reviewed by Fujii Hironori.
127
128         Implemented MiniBrowser UI for asking if user trusts the server.
129
130         * MiniBrowser/win/Common.cpp:
131         (askServerTrustEvaluation):
132         (replaceString):
133         * MiniBrowser/win/Common.h:
134         * MiniBrowser/win/MiniBrowserLib.rc:
135         * MiniBrowser/win/MiniBrowserLibResource.h:
136         * MiniBrowser/win/WebKitBrowserWindow.cpp:
137         (createPEMString):
138         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
139         (WebKitBrowserWindow::canTrustServerCertificate):
140         * MiniBrowser/win/WebKitBrowserWindow.h:
141
142 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
143
144         Implement ResizeObserver.
145         https://bugs.webkit.org/show_bug.cgi?id=157743
146
147         Reviewed by Simon Fraser.
148
149         Support resizeObserverEnabled webPreferences.
150
151         * DumpRenderTree/TestOptions.cpp:
152         (TestOptions::TestOptions):
153         * DumpRenderTree/TestOptions.h:
154         * DumpRenderTree/mac/DumpRenderTree.mm:
155         (setWebPreferencesForTestOptions):
156         * DumpRenderTree/win/DumpRenderTree.cpp:
157         (enableExperimentalFeatures):
158         * Scripts/webkitperl/FeatureList.pm:
159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
160
161 2019-03-28  John Wilander  <wilander@apple.com>
162
163         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
164         https://bugs.webkit.org/show_bug.cgi?id=196281
165         <rdar://problem/48938748>
166
167         Reviewed by Alex Christensen.
168
169         This patch adds the function isStatisticsHasLocalStorage() to the
170         TestRunner. With it, the page can query the WebsiteDataStore in the
171         UI process to make sure that it sees LocalStorage.
172
173         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
174         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
175         (WTR::TestRunner::isStatisticsHasLocalStorage):
176         * WebKitTestRunner/InjectedBundle/TestRunner.h:
177         * WebKitTestRunner/TestController.cpp:
178         (WTR::TestController::isStatisticsHasLocalStorage):
179         * WebKitTestRunner/TestController.h:
180         * WebKitTestRunner/TestInvocation.cpp:
181         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
182
183 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
184
185         API::Data::createWithoutCopying should do a null check before calling CFRelease
186         https://bugs.webkit.org/show_bug.cgi?id=196276
187         <rdar://problem/48059859>
188
189         Reviewed by Alex Christensen.
190
191         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
192
193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
194         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
195         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
196         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
197         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
198         (TestWebKitAPI::TEST):
199
200 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
201
202         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
203         https://bugs.webkit.org/show_bug.cgi?id=186276
204
205         Reviewed by Carlos Garcia Campos.
206
207         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
208         (webViewLoadChanged):
209         (testWebResourceGetDataError):
210         (testWebResourceGetDataEmpty):
211         (beforeAll):
212         (webViewloadChanged): Deleted.
213
214 2019-03-27  Andy Estes  <aestes@apple.com>
215
216         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
217         https://bugs.webkit.org/show_bug.cgi?id=196317
218
219         Reviewed by Dan Bernstein.
220
221         package-root copies built products into a staging directory using ditto(1), which does not
222         follow symbolic links as it traverses a directory. Now that the files in
223         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
224         itself, these become broken links when ditto'd into the staging directory.
225
226         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
227
228         * Scripts/package-root:
229
230 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
231
232         [ews-app] Update display text of Submit for ews analysis
233         https://bugs.webkit.org/show_bug.cgi?id=196309
234
235         Reviewed by Dewei Zhu.
236
237         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
238
239 2019-03-27  David Kilzer  <ddkilzer@apple.com>
240
241         run-webkit-tests should check for leaks in WebKit processes
242         <https://webkit.org/b/193772>
243         <rdar://problem/46526680>
244
245         Reviewed by Ryosuke Niwa.
246
247         This works by doing the following:
248         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
249           The list of child processes are returned one per line:
250           process.name: pid
251         - Run the "#LIST CHILD PROCESSES" command just before the
252           "#CHECK FOR WORLD LEAKS" command, and store the list of child
253           processes on the ServerProcess object.
254         - When the `--leaks` switch is handled, run check_for_leaks() on
255           each child process after the main test harness.
256
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (handleControlCommand):
259         - Use strncmp() instead of strcmp().
260         - Add support for handling "#LIST CHILD PROCESSES" command.
261
262         * Scripts/webkitpy/port/base.py:
263         (Port.check_for_leaks):
264         * Scripts/webkitpy/port/darwin.py:
265         (DarwinPort.check_for_leaks):
266         - Rename redundant 'process_pid' argument to 'process_id'.
267
268         * Scripts/webkitpy/port/driver.py:
269         (Driver.do_post_tests_work):
270         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
271           longer the only command this sends to WebKitTestRunner.
272         - If the `--leaks` switch is present, send the
273           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
274           result using Port.set_webkit_processes().
275         (Driver._parse_child_processes_output):
276         - Add helper method to parse list of child process names and
277           process IDs returned from WebKitTestRunner.
278
279         * Scripts/webkitpy/port/ios_device.py:
280         (IOSDevicePort.check_for_leaks):
281         - Rename redundant 'process_pid' argument to 'process_id'.
282
283         * Scripts/webkitpy/port/leakdetector.py:
284         (LeakDetector._parse_leaks_output):
285         - Return early if there is no leaks_output.
286         (LeakDetector.check_for_leaks):
287         - Rename redundant 'process_pid' argument to 'process_id'.
288
289         * Scripts/webkitpy/port/server_process.py:
290         (ServerProcess.__init__):
291         (ServerProcess.child_processes):
292         (ServerProcess.set_child_processes):
293         - Add instance variable to Port to store list of child process
294           names and process IDs returned from WebKitTestRunner.
295         (ServerProcess._start):
296         - Clear self._child_processes.
297         (ServerProcess.stop):
298         - If self._child_processes is set, call
299           self._port.check_for_leaks() for each child process.
300
301         * Scripts/webkitpy/port/server_process_unittest.py:
302         (TrivialMockPort.check_for_leaks):
303         - Rename redundant 'process_pid' argument to 'process_id'.
304
305         * Scripts/webkitpy/port/simulator_process.py:
306         (SimulatorProcess.stop):
307         - If self._child_processes is set, call
308           self._port.check_for_leaks() for each child process.
309
310         * Scripts/webkitpy/port/watch_device.py:
311         (WatchDevicePort.check_for_leaks):
312         - Rename redundant 'process_pid' argument to 'process_id'.
313
314         * WebKitTestRunner/TestController.cpp:
315         (WTR::TestController::dumpResponse):
316         - Extract method from findAndDumpWorldLeaks() so that it may be
317           reused by findAndDumpWebKitProcessIdentifiers().
318         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
319         - Add method to output process name and process ID of both the
320           WebContent and Networking processes.
321         (WTR::TestController::findAndDumpWorldLeaks):
322         - Fix missing newline in output when there were no abandoned
323           documents.
324         - Call dumpResponse() for extracted code.
325         (WTR::TestController::handleControlCommand):
326         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
327         - Use strncmp() instead of strcmp().
328         - Call findAndDumpWebKitProcessIdentifiers() when
329           "#LIST CHILD PROCESSES" command is sent.
330         * WebKitTestRunner/TestController.h:
331         (WTR::TestController::dumpResponse):
332         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
333         - Declare methods.
334
335 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
336
337         Unreviewed. Add GLib API test cases after r243434.
338
339         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
340         (testWebViewActiveURI):
341         (serverCallback):
342         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
343         (sendRequestCallback):
344
345 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
346
347         Geolocation request not complete when watch request was started in a different web process
348         https://bugs.webkit.org/show_bug.cgi?id=195996
349
350         Reviewed by Alex Christensen.
351
352         Add a test case.
353
354         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
355         (TestWebKitAPI::runJavaScriptAlert):
356         (TestWebKitAPI::TEST):
357
358 2019-03-26  Keith Rollin  <krollin@apple.com>
359
360         Update the way generate-xcfilelists returns strings from functions
361         https://bugs.webkit.org/show_bug.cgi?id=195975
362         <rdar://problem/49040807>
363
364         Reviewed by Dean Jackson.
365
366         There are places where generate-xcfilelists executes assignments with
367         statements like:
368
369             FOO=$(some_function)
370
371         where "some_function" return a string by echoing it. E.g.
372
373             some_function()
374             {
375                 echo "Hello, World"
376             }
377
378         This is a common idiom, but it has a problem if "some_function" needs
379         to call "exit" in an attempt to halt the entire script right then and
380         there. Since "some_function" is called inside of $(), it's being
381         executed in a sub-shell. Calling exit in that sub-shell simply exits
382         that shell; it doesn't not exit the outer shell in which the main part
383         of the script is still running. As such, the main script keeps
384         executing when the intent was for the script to halt.
385
386         The solution to this is to use a different idiom for returning
387         strings. The one we now is to pass in the name of the variable to
388         receive the string result:
389
390             some_function()
391             {
392                 variable_name=$1
393                 eval $variable_name ="Hello, World"
394             }
395
396         The call site now looks like
397
398             some_function FOO
399
400         Because there's no invocation of a sub-shell, some_function can now
401         call "exit" if it wants to, and the entire script will exit at that
402         point.
403
404         * Scripts/generate-xcfilelists:
405
406 2019-03-26  Chris Dumez  <cdumez@apple.com>
407
408         Add basic layout test coverage for File Picker on iOS
409         https://bugs.webkit.org/show_bug.cgi?id=196265
410
411         Reviewed by Wenson Hsieh.
412
413         Add layout test infrastructure to test the file picker on iOS.
414
415         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
416         (WTR::UIScriptController::dismissFilePicker):
417         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
418         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
419         (WTR::UIScriptController::dismissFilePicker):
420         * TestRunnerShared/UIScriptContext/UIScriptController.h:
421         * WebKitTestRunner/TestController.cpp:
422         (WTR::TestController::createWebViewWithOptions):
423         (WTR::updateTestOptionsFromTestHeader):
424         * WebKitTestRunner/TestOptions.h:
425         (WTR::TestOptions::hasSameInitializationOptions const):
426         * WebKitTestRunner/ios/TestControllerIOS.mm:
427         (overridePresentViewController):
428         (WTR::TestController::platformInitialize):
429         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
430         (WTR::UIScriptController::dismissFilePicker):
431
432 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
433
434         Implement async paste method on UIWKInteractionViewProtocol
435         https://bugs.webkit.org/show_bug.cgi?id=196267
436         <rdar://problem/49236346>
437
438         Reviewed by Tim Horton.
439
440         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
441         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
442         are now a part of all iOS 12 internal SDKs.
443
444         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
445
446         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
447         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
448
449         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
450         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
451         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
452         * TestWebKitAPI/ios/UIKitSPI.h:
453
454 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
455
456         [ews-build] Use PostgreSQL for ews.webkit.org database
457         https://bugs.webkit.org/show_bug.cgi?id=196270
458
459         Reviewed by Lucas Forschler.
460
461         * BuildSlaveSupport/ews-app/ews-app/settings.py:
462
463 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
464
465         [ews] Reset simctl states on reboot
466         https://bugs.webkit.org/show_bug.cgi?id=196260
467
468         Rubber-stamped by Aakash Jain.
469
470         * EWSTools/start-queue-mac.sh:
471
472 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
473
474         [ews-build] Use PostgreSQL for ews-build database
475         https://bugs.webkit.org/show_bug.cgi?id=196229
476
477         Reviewed by Lucas Forschler.
478
479         * BuildSlaveSupport/ews-build/master.cfg:
480
481 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
482
483         [ews-build] Get master_hostname dynamically in master.cfg
484         https://bugs.webkit.org/show_bug.cgi?id=196255
485
486         Reviewed by Lucas Forschler.
487
488         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
489         send events data in test mode.
490
491 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
492
493         [ews-app] Set db_constraint to False for Foreign Keys
494         https://bugs.webkit.org/show_bug.cgi?id=196252
495
496         Reviewed by Lucas Forschler.
497
498         * BuildSlaveSupport/ews-app/ews/models/build.py:
499         * BuildSlaveSupport/ews-app/ews/models/step.py:
500
501 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
502
503         [ews-build] is_test_mode_enabled should default to True
504         https://bugs.webkit.org/show_bug.cgi?id=196248
505
506         Reviewed by Lucas Forschler.
507
508         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
509
510 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
511
512         [ews-app] Add webkitperl to ENABLED_QUEUES
513         https://bugs.webkit.org/show_bug.cgi?id=196253
514
515         Reviewed by Lucas Forschler.
516
517         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
518
519 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
520
521         Address NSWindow sometimes using WebKitTestRunnerEvent too early
522         https://bugs.webkit.org/show_bug.cgi?id=196211
523         rdar://problem/49110552
524
525         Reviewed by Tim Horton.
526
527         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
528         Make sure that EventSenderProxy always exists when running tests. We used to create
529         it when resetting before the first test, which is a bit too late.
530
531         * WebKitTestRunner/TestController.h:
532         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
533         (WTR::TestController::platformCreateWebView):
534         (WTR::TestController::platformCreateOtherPage):
535         (WTR::TestController::finishCreatingPlatformWebView):
536         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
537         (WTR::PlatformWebView::PlatformWebView):
538         Moved some code that made NSWindow use NSEvent during web view creation. We may
539         need to move more if some other case us found, but this is enough for now.
540
541 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
542
543         Unreviewed. Fix typo in GLib geolocation API after r243285.
544
545         gelocation -> geolocation.
546
547         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
548         (testGeolocationManagerWatchPosition):
549
550 2019-03-25  Alex Christensen  <achristensen@webkit.org>
551
552         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
553         https://bugs.webkit.org/show_bug.cgi?id=196213
554
555         Reviewed by Geoff Garen.
556
557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
558         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
559         (credentialWithIdentityAndKeychainPath):
560         (-[ChallengeDelegate webView:didFinishNavigation:]):
561         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
562         (TestWebKitAPI::TEST):
563
564 2019-03-25  Alex Christensen  <achristensen@webkit.org>
565
566         Expected shouldn't assume its contained types are copyable
567         https://bugs.webkit.org/show_bug.cgi?id=195986
568
569         Reviewed by JF Bastien.
570
571         * TestWebKitAPI/Tests/WTF/Expected.cpp:
572         (TestWebKitAPI::NonCopyable::operator== const):
573         (TestWebKitAPI::NonCopyable::operator!= const):
574         (TestWebKitAPI::TEST):
575
576 2019-03-25  Tim Horton  <timothy_horton@apple.com>
577
578         Remove some now-unnecessary dynamic class lookup
579         https://bugs.webkit.org/show_bug.cgi?id=196237
580
581         Reviewed by Simon Fraser.
582
583         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
584         (makeRequest):
585         (TEST):
586
587 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
588
589         Unreviewed, rolling out r243450.
590
591         AppleWin and WinCairo port builds get broken.
592
593         Reverted changeset:
594
595         "Add test for fix of #196095"
596         https://bugs.webkit.org/show_bug.cgi?id=196097
597         https://trac.webkit.org/changeset/243450
598
599 2019-03-25  Commit Queue  <commit-queue@webkit.org>
600
601         Unreviewed, rolling out r243465.
602         https://bugs.webkit.org/show_bug.cgi?id=196226
603
604         the test doesn't build (Requested by thorton on #webkit).
605
606         Reverted changeset:
607
608         "Do not terminate the NetworkProcess if a third party
609         application sends a NSCredential with a SecIdentityRef"
610         https://bugs.webkit.org/show_bug.cgi?id=196213
611         https://trac.webkit.org/changeset/243465
612
613 2019-03-25  Alex Christensen  <achristensen@webkit.org>
614
615         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
616         https://bugs.webkit.org/show_bug.cgi?id=196213
617
618         Reviewed by Geoff Garen.
619
620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
621         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
622         (credentialWithIdentityAndKeychainPath):
623         (-[ChallengeDelegate webView:didFinishNavigation:]):
624         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
625         (TestWebKitAPI::TEST):
626
627 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
628
629         [ews-build] Gracefully handle missing patch_id in events
630         https://bugs.webkit.org/show_bug.cgi?id=196216
631
632         Reviewed by Lucas Forschler.
633
634         * BuildSlaveSupport/ews-build/events.py:
635
636 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
637
638         [ews-build] use lz4 compression for improving buildbot performance
639         https://bugs.webkit.org/show_bug.cgi?id=196155
640
641         Reviewed by Lucas Forschler.
642
643         * BuildSlaveSupport/ews-build/master.cfg:
644
645 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
646
647         Pull some API testing helper methods out of TestWKWebView
648         https://bugs.webkit.org/show_bug.cgi?id=196212
649
650         Reviewed by Tim Horton.
651
652         Refactor some more API testing utility methods, so that they can be used in
653         tests that do not use TestWKWebView.
654
655         * TestWebKitAPI/cocoa/TestWKWebView.h:
656         * TestWebKitAPI/cocoa/TestWKWebView.mm:
657         (-[WKWebView loadTestPageNamed:]):
658         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
659         (-[WKWebView synchronouslyLoadHTMLString:]):
660         (-[WKWebView synchronouslyLoadTestPageNamed:]):
661         (-[TestWKWebView loadTestPageNamed:]): Deleted.
662         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
663         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
664         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
665
666 2019-03-25  Jer Noble  <jer.noble@apple.com>
667
668         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
669         https://bugs.webkit.org/show_bug.cgi?id=196097
670
671         Reviewed by Eric Carlson.
672
673         Drive-by bug fix: allow tests to play audio without a user gesture by default.
674
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         (resetWebPreferencesToConsistentValues):
677         * WebKitTestRunner/TestController.cpp:
678         (WTR::TestController::resetPreferencesToConsistentValues):
679
680 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
681
682         Pull IPadUserInterfaceSwizzler out into a separate header file
683         https://bugs.webkit.org/show_bug.cgi?id=196193
684
685         Reviewed by Anders Carlsson.
686
687         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
688         be used in other API tests.
689
690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
691         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
692         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
693         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
694         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
695         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
696         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
697
698 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
699
700         Remove NavigatorContentUtils in WebCore/Modules
701         https://bugs.webkit.org/show_bug.cgi?id=196070
702
703         Reviewed by Alex Christensen.
704
705         NavigatorContentUtils was to support the custom scheme spec [1].
706         However, in WebKit side, no port has supported the feature in
707         WebKit layer after EFL port was removed. So there has been the
708         only IDL implementation of the NavigatorContentUtils in WebCore.
709         So we don't need to keep the implementation in WebCore anymore.
710
711         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
712
713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
714
715 2019-03-24  Andy Estes  <aestes@apple.com>
716
717         [watchOS] Remove unused Proximity Networking code
718         https://bugs.webkit.org/show_bug.cgi?id=196188
719
720         Reviewed by Tim Horton.
721
722         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
723         (TEST):
724
725 2019-03-23  Keith Miller  <keith_miller@apple.com>
726
727         Refactor clz/ctz and fix getLSBSet.
728         https://bugs.webkit.org/show_bug.cgi?id=196162
729
730         Reviewed by Saam Barati.
731
732         Add tests for clz, ctz, getLSBSet, and getMSBSet.
733
734         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
735         (TestWebKitAPI::TEST):
736
737 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
738
739         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
740         https://bugs.webkit.org/show_bug.cgi?id=196143
741
742         Reviewed by Michael Catanzaro.
743
744         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
745         directories.
746
747         * Scripts/webkitpy/style/checkers/cpp.py:
748         (check_identifier_name_in_declaration):
749         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
750         (WebKitStyleTest.test_names):
751
752 2019-03-22  Philippe Normand  <pnormand@igalia.com>
753
754         [Flatpak] Manifest expanding fails for qt WPE extension
755         https://bugs.webkit.org/show_bug.cgi?id=196148
756
757         Reviewed by Alex Christensen.
758
759         * flatpak/flatpakutils.py:
760         (expand_submodules_recurse): The last recurse manifest expand
761         iteration might lead to a single module so take it into account
762         and don't try to recurse further.
763
764 2019-03-22  Chris Dumez  <cdumez@apple.com>
765
766         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
767         https://bugs.webkit.org/show_bug.cgi?id=195348
768         <rdar://problem/48622090>
769
770         Reviewed by Alex Christensen.
771
772         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
773         to NO when test.options().shouldIgnoreMetaViewport is false.
774
775         * WebKitTestRunner/ios/TestControllerIOS.mm:
776         (WTR::TestController::platformConfigureViewForTest):
777
778 2019-03-22  Chris Dumez  <cdumez@apple.com>
779
780         Prewarmed processes should be usable with any website data store
781         https://bugs.webkit.org/show_bug.cgi?id=196104
782
783         Reviewed by Alex Christensen.
784
785         Add API test coverage.
786
787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
788         (runInitialWarmedProcessUsedTest):
789         (TEST):
790
791 2019-03-22  David Kilzer  <ddkilzer@apple.com>
792
793         Back out local changes to Alex's Subversion working directory
794
795         They were accidentally committed.
796
797         * Scripts/webkitpy/common/system/abstractexecutive.py:
798         (AbstractExecutive.wait_newest):
799         * Scripts/webkitpy/common/system/executive.py:
800         (Executive.running_pids):
801         * Scripts/webkitpy/common/system/executive_mock.py:
802         (MockExecutive.running_pids):
803         * Scripts/webkitpy/common/system/executive_unittest.py:
804         (ExecutiveTest.serial_test_running_pids):
805         * Scripts/webkitpy/port/darwin.py:
806         (DarwinPort.check_for_leaks):
807         * Scripts/webkitpy/port/leakdetector.py:
808         (LeakDetector.check_for_leaks):
809         - This was the hack attached to Bug 193772.
810
811         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
812         (+[WebKitTestRunnerEvent mouseLocation]):
813         - This works around a crash on an internal build.
814
815 2019-03-22  Tim Horton  <timothy_horton@apple.com>
816
817         Fix the build after r243354
818         https://bugs.webkit.org/show_bug.cgi?id=196138
819         <rdar://problem/49145951>
820
821         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
822         (TEST):
823         * TestWebKitAPI/ios/UIKitSPI.h:
824
825 2019-03-21  Tim Horton  <timothy_horton@apple.com>
826
827         Adopt UIWKDocumentContext
828         https://bugs.webkit.org/show_bug.cgi?id=196040
829         <rdar://problem/48642440>
830
831         Reviewed by Ryosuke Niwa.
832
833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
834         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
835         (makeRequest):
836         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
837         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
838         (applyStyle):
839         (TEST):
840         Add tests for UIWKDocumentContext.
841
842         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
843         (TEST):
844         (recursiveFindWKContentView): Deleted.
845         * TestWebKitAPI/cocoa/TestWKWebView.h:
846         * TestWebKitAPI/cocoa/TestWKWebView.mm:
847         (recursiveFindWKContentView):
848         (-[TestWKWebView wkContentView]):
849         * TestWebKitAPI/ios/UIKitSPI.h:
850         Share the WKContentView finding code between tests.
851
852 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
853
854         [iOS WK2] Turn on async overflow scrolling by default
855         https://bugs.webkit.org/show_bug.cgi?id=196011
856         rdar://problem/48453859
857
858         Reviewed by Antti Koivisto.
859         
860         Explicitly turn off the async overflow scrolling internal feature for tests by default,
861         since so many basic layout tests have different results when compositing is triggered for
862         overflow.
863         
864         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
865
866         * WebKitTestRunner/TestController.cpp:
867         (WTR::TestController::resetPreferencesToConsistentValues):
868
869 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
870
871         [ews-build] Retry API test in case of failures
872         https://bugs.webkit.org/show_bug.cgi?id=196004
873
874         Reviewed by Lucas Forschler.
875
876         * BuildSlaveSupport/ews-build/steps.py:
877         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
878         (CompileWebKitToT.doStepIf): Ditto.
879         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
880         (ReRunAPITests): Re-run API tests.
881         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
882         (RunAPITestsWithoutPatch): Run API tests without patch.
883         (RunAPITestsWithoutPatch.doStepIf):
884         (RunAPITestsWithoutPatch.hideStepIf):
885         (RunAPITestsWithoutPatch.evaluateCommand):
886         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
887         (AnalyzeAPITestsResults.start):
888         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
889         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
890         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
891         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
892
893 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
894
895         [ews-build] Update queues configurations
896         https://bugs.webkit.org/show_bug.cgi?id=196074
897
898         Reviewed by Dewei Zhu.
899
900         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
901         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
902
903 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
904
905         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
906         https://bugs.webkit.org/show_bug.cgi?id=195680
907         <rdar://problem/48903534>
908
909         Unreviewed infrastructure fix.
910
911         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
912         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
913
914 2019-03-21  Andy Estes  <aestes@apple.com>
915
916         [iOS] Apple Pay should be available in documents with no user agent scripts
917         https://bugs.webkit.org/show_bug.cgi?id=196061
918         <rdar://problem/48649391>
919
920         Reviewed by Brady Eidson.
921
922         Added API tests and related infrastructure.
923
924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
925         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
926         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
927         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
928         (TestWebKitAPI::TEST):
929         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
930         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
931         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
932         * TestWebKitAPI/cocoa/TestProtocol.mm:
933         (-[TestProtocol startLoading]):
934         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
935         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
936         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
937         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
938
939 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
940
941         REGRESSSION (r243297): webkitpy tests broken
942         https://bugs.webkit.org/show_bug.cgi?id=196108
943
944         Reviewed by Aakash Jain.
945
946         r243297 updated contributors.json, which broke a few unit tests.
947
948         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
949         (IRCCommandTest.test_whois):
950         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
951
952 2019-03-21  Chris Dumez  <cdumez@apple.com>
953
954         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
955         https://bugs.webkit.org/show_bug.cgi?id=196041
956         <rdar://problem/49083230>
957
958         Reviewed by Alex Christensen.
959
960         Add API test coverage.
961
962         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
963         (TEST):
964
965 2019-03-21  Alex Christensen  <achristensen@webkit.org>
966
967         Add SPI to inform applications of WKContentRuleList actions
968         https://bugs.webkit.org/show_bug.cgi?id=195965
969         <rdar://problem/42664365>
970
971         Reviewed by Geoff Garen.
972
973         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
974         (TestWebKitAPI::allActionsForResourceLoad):
975         (TestWebKitAPI::testRequest):
976         (TestWebKitAPI::TEST_F):
977         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
978         (Notification::description):
979         (Notification::operator== const):
980         (toVector):
981         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
982         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
983         (makeContentRuleList):
984         (TEST):
985         (makeWarnContentRuleList): Deleted.
986
987 2019-03-21  Timothy Hatcher  <timothy@apple.com>
988
989         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
990         https://bugs.webkit.org/show_bug.cgi?id=196088
991
992         Reviewed by Brian Burg.
993
994         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
995         Support checks when only one platform is specified. Also deprecate macosx() and
996         force the use of macos() instead.
997
998         * Scripts/webkitpy/style/checkers/cpp.py:
999         (check_min_versions_of_wk_api_available):
1000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1001         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1002
1003 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1004
1005         Update status inactive committers' status to 'contributor'.
1006
1007         * Scripts/webkitpy/common/config/contributors.json:
1008
1009 2019-03-21  Xan Lopez  <xan@igalia.com>
1010
1011         [JSC][x86] Drop support for x87 floating point
1012         https://bugs.webkit.org/show_bug.cgi?id=194853
1013
1014         Reviewed by Don Olmstead.
1015
1016         Force SSE2 on x86/32bit builds.
1017
1018         * Scripts/webkitdirs.pm:
1019         (generateBuildSystemFromCMakeProject):
1020
1021 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1022
1023         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1024         https://bugs.webkit.org/show_bug.cgi?id=196073
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         Add test cases to check functions and constructors with no arguments but receiving user data.
1029
1030         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1031         (checkUserData):
1032         (testJSCFunction):
1033         (fooCreateWithUserData):
1034         (testJSCClass):
1035
1036 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1037
1038         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1039
1040         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1041
1042         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1043
1044 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1045
1046         [GTK][WPE] Add API to provide geolocation information
1047         https://bugs.webkit.org/show_bug.cgi?id=195940
1048
1049         Reviewed by Michael Catanzaro.
1050
1051         Add a new test to check the new API.
1052
1053         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1054         (testGeolocationManagerCurrentPosition):
1055         (testGeolocationManagerWatchPosition):
1056         (beforeAll):
1057         (afterAll):
1058         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1059         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1060         (beforeAll): Ditto.
1061         * TestWebKitAPI/glib/CMakeLists.txt:
1062
1063 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1064
1065         [GLib] Returning G_TYPE_OBJECT from a method does not work
1066         https://bugs.webkit.org/show_bug.cgi?id=195574
1067
1068         Reviewed by Michael Catanzaro.
1069
1070         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1071
1072         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1073         (getGFile):
1074         (getParent):
1075         (createGString):
1076         (getGString):
1077         (getGStringCopyWillRaise):
1078         (getGStringCopy):
1079         (getGStringStr):
1080         (getGStringLen):
1081         (freeGString):
1082         (testJSCClass):
1083
1084 2019-03-20  Saam Barati  <sbarati@apple.com>
1085
1086         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1087         https://bugs.webkit.org/show_bug.cgi?id=195721
1088
1089         Reviewed by Filip Pizlo.
1090
1091         * Scripts/run-javascriptcore-tests:
1092
1093 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1094
1095         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1096         https://bugs.webkit.org/show_bug.cgi?id=196049
1097
1098         Reviewed by Tim Horton.
1099
1100         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1101         overflow scrolling in general, so rename it.
1102
1103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1104
1105 2019-03-20  Daniel Bates  <dabates@apple.com>
1106
1107         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1108         https://bugs.webkit.org/show_bug.cgi?id=196031
1109         <rdar://problem/49078172>
1110
1111         Reviewed by Tim Horton.
1112
1113         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1114         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1115         same code path used when the Done button is pressed to dismiss the <select> picker.
1116
1117         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1118         (TestWebKitAPI::TEST):
1119
1120 2019-03-20  Chris Dumez  <cdumez@apple.com>
1121
1122         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1123         https://bugs.webkit.org/show_bug.cgi?id=196029
1124         <rdar://problem/48954651>
1125
1126         Reviewed by Tim Horton.
1127
1128         Add API test coverage.
1129
1130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1131
1132 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1133
1134         [ews-build] Improve failure summary string for ApplyPatch step
1135         https://bugs.webkit.org/show_bug.cgi?id=195995
1136
1137         Reviewed by Alexey Proskuryakov.
1138
1139         * BuildSlaveSupport/ews-build/steps.py:
1140         (ApplyPatch.getResultSummary): Override getResultSummary.
1141
1142 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1143
1144         AX: Implement support for new meter ARIA role
1145         https://bugs.webkit.org/show_bug.cgi?id=195966
1146
1147         Reviewed by Chris Fleizach.
1148
1149         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1150         to AXLevelIndicator.
1151
1152         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1153
1154 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1155
1156         [WebAuthN] Implement FIDO AppID extension
1157         https://bugs.webkit.org/show_bug.cgi?id=143491
1158         <rdar://problem/48298273>
1159
1160         Reviewed by Brent Fulgham.
1161
1162         Add a test that covers the new flag of convertToU2fSignCommand.
1163
1164         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1165         (TestWebKitAPI::TEST):
1166         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1167         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1168         (TestWebKitAPI::TEST):
1169
1170 2019-03-19  Keith Rollin  <krollin@apple.com>
1171
1172         Add support for more platforms to generate-xcfilelists
1173         https://bugs.webkit.org/show_bug.cgi?id=195977
1174
1175         Reviewed by Alexey Proskuryakov.
1176
1177         generate-xcfilelists incorrectly complains when involved with building
1178         WebKit for iphonesimulator:
1179
1180             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1181             …
1182             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1183
1184         Address this by teaching generate-xcfilelists about more platforms.
1185
1186         * Scripts/generate-xcfilelists:
1187
1188 2019-03-19  John Wilander  <wilander@apple.com>
1189
1190         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1191         https://bugs.webkit.org/show_bug.cgi?id=195923
1192         <rdar://problem/49001272>
1193
1194         Reviewed by Alex Christensen.
1195
1196         This patch does the following to the TestRunner:
1197         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1198         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1199         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1200
1201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1203         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1204         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1205         * WebKitTestRunner/TestController.cpp:
1206         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1207         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1208         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1209         * WebKitTestRunner/TestController.h:
1210         * WebKitTestRunner/TestInvocation.cpp:
1211         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1212
1213 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1214
1215         [CMake] Support more clang and gcc sanitizers
1216         https://bugs.webkit.org/show_bug.cgi?id=195956
1217
1218         Reviewed by Michael Catanzaro.
1219
1220         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1221
1222 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1223
1224         [ews-build] Improve summary for PrintConfiguration step
1225         https://bugs.webkit.org/show_bug.cgi?id=195945
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * BuildSlaveSupport/ews-build/steps.py:
1230         (PrintConfiguration.getResultSummary): Override getResultSummary.
1231
1232 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1233
1234         [ews-build] Improve summary for CheckOutSource step
1235         https://bugs.webkit.org/show_bug.cgi?id=195963
1236
1237         Reviewed by Lucas Forschler.
1238
1239         * BuildSlaveSupport/ews-build/steps.py:
1240         (CheckOutSource.getResultSummary):
1241
1242 2019-03-19  Daniel Bates  <dabates@apple.com>
1243
1244         [iOS] Focus not preserved when switching between tabs
1245         https://bugs.webkit.org/show_bug.cgi?id=195820
1246         <rdar://problem/43614450>
1247
1248         Reviewed by Brent Fulgham.
1249
1250         Add tests to ensure that we restore focus when resigning and becoming first responder.
1251
1252         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1253         (TestWebKitAPI::TEST):
1254
1255 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1256
1257         Make WTFLogChannelState and WTFLogLevel enum classes
1258         https://bugs.webkit.org/show_bug.cgi?id=195904
1259
1260         Reviewed by Eric Carlson.
1261
1262         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1263         (TestWebKitAPI::TEST_F):
1264
1265 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1266
1267         [GStreamer][EME] Backported mssdemux protection data crash fix
1268         https://bugs.webkit.org/show_bug.cgi?id=195918
1269
1270         Reviewed by Philippe Normand.
1271
1272         * gstreamer/jhbuild.modules:
1273         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1274
1275 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1276
1277         Unreviewed, rolling out r243132.
1278
1279         Broke GTK build
1280
1281         Reverted changeset:
1282
1283         "Make WTFLogChannelState and WTFLogLevel enum classes"
1284         https://bugs.webkit.org/show_bug.cgi?id=195904
1285         https://trac.webkit.org/changeset/243132
1286
1287 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1288
1289         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1290
1291         * Scripts/webkitdirs.pm:
1292         (builtDylibPathForName): Adjust the shared library name that's changed
1293         with the API version bump in r243073.
1294
1295 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1296
1297         Make WTFLogChannelState and WTFLogLevel enum classes
1298         https://bugs.webkit.org/show_bug.cgi?id=195904
1299
1300         Reviewed by Eric Carlson.
1301
1302         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1303         (TestWebKitAPI::TEST_F):
1304
1305 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1306
1307         Disable flaky test added in r2431100
1308         https://webkit.org/b/195785
1309
1310         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1311         (TestWebKitAPI::TEST):
1312         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1313
1314 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1315
1316         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1317         https://bugs.webkit.org/show_bug.cgi?id=195916
1318
1319         Reviewed by Tim Horton.
1320
1321         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1322         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1323
1324 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1325
1326         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1327
1328         * Scripts/webkitpy/common/config/contributors.json:
1329
1330 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1331
1332         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1333         https://bugs.webkit.org/show_bug.cgi?id=195785
1334
1335         Reviewed by Geoffrey Garen.
1336
1337         * TestWebKitAPI/TCPServer.cpp: Added.
1338         (TestWebKitAPI::TCPServer::TCPServer):
1339         (TestWebKitAPI::TCPServer::~TCPServer):
1340         (TestWebKitAPI::TCPServer::socketBindListen):
1341         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1342         * TestWebKitAPI/TCPServer.h: Added.
1343         (TestWebKitAPI::TCPServer::port const):
1344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1345         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1346         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1347         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1348         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1349         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1350         (TestWebKitAPI::respondSlowly):
1351         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1352         (TestWebKitAPI::downloadAtRate):
1353         (TestWebKitAPI::TEST):
1354
1355 2019-03-18  Saam Barati  <sbarati@apple.com>
1356
1357         Add a plan file for JetStream 2
1358         https://bugs.webkit.org/show_bug.cgi?id=190734
1359
1360         Reviewed by Mark Lam.
1361
1362         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1363
1364 2019-03-18  Chris Dumez  <cdumez@apple.com>
1365
1366         Delay WebProcess launch until a load is triggered in a Web view
1367         https://bugs.webkit.org/show_bug.cgi?id=195758
1368         <rdar://problem/48126013>
1369
1370         Reviewed by Geoff Garen.
1371
1372         Add API test coverage. Also update some existing API tests to not expect
1373         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1374
1375         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1376         (TestWebKitAPI::TEST):
1377         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1378         (TestWebKitAPI::TEST):
1379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1380         (TEST):
1381         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1382         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1383         (TEST):
1384         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1385         (TEST):
1386         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1387
1388 2019-03-18  Xan Lopez  <xan@igalia.com>
1389
1390         [CMake] Prevent potential warning when determining $architecture
1391         https://bugs.webkit.org/show_bug.cgi?id=195891
1392
1393         Reviewed by Michael Catanzaro.
1394
1395         It's possible for generateBuildSystemForCMakeProject to be called
1396         before determineArchitecture() is ever called. This will make the
1397         first eq check with $architecture to be bogus (and print a
1398         warning). Change that to an eq check with architecture(), which
1399         implicitly calls determineArchitecture() if needed, and change all
1400         the other similar cases in the method in the same way to prevent
1401         future bugs like this one.
1402
1403         * Scripts/webkitdirs.pm:
1404         (generateBuildSystemFromCMakeProject):
1405
1406 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1407
1408         [WPE] Tarballs generated with “make dist” cannot build documentation
1409         https://bugs.webkit.org/show_bug.cgi?id=195885
1410
1411         Reviewed by Carlos Garcia Campos.
1412
1413         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1414
1415 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1416
1417         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1418         https://bugs.webkit.org/show_bug.cgi?id=195883
1419
1420         Reviewed by Carlos Garcia Campos.
1421
1422         * gtkdoc/gtkdoc.py:
1423         (GTKDoc._run_command): When commands fail to run, include the full command line for
1424         the program invocation and the output it has generated on the standard error stream.
1425
1426 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1427
1428         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1429         https://bugs.webkit.org/show_bug.cgi?id=195786
1430
1431         Reviewed by Philippe Normand.
1432
1433         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1434         * wpe/jhbuild.modules: Ditto.
1435
1436 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1437
1438         [ews-build] Don't run clean builds on EWS builders
1439         https://bugs.webkit.org/show_bug.cgi?id=195851
1440
1441         Reviewed by Geoffrey Garen.
1442
1443         * BuildSlaveSupport/ews-build/factories.py:
1444
1445 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1446
1447         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1448         https://bugs.webkit.org/show_bug.cgi?id=195849
1449
1450         Reviewed by Chris Dumez.
1451
1452         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1453
1454         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1455         (runWebsiteDataStoreCustomPaths):
1456
1457 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1458
1459         webkitpy: Upload test results
1460         https://bugs.webkit.org/show_bug.cgi?id=195755
1461         <rdar://problem/48896182>
1462
1463         Reviewed by Aakash Jain.
1464
1465         Establish a new format for uploading results that is not tied to layout tests, apply
1466         that format to webkitpy tests.
1467
1468         * Scripts/webkitpy/common/checkout/scm/git.py:
1469         (Git.native_branch): Return what branch the current checkout is on.
1470         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1471         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1472         * Scripts/webkitpy/common/checkout/scm/svn.py:
1473         (SVN.native_branch): Ditto.
1474         * Scripts/webkitpy/common/system/platforminfo.py:
1475         (PlatformInfo.build_version): Return a build version for Mac.
1476         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1477         (MockPlatformInfo.__init__):
1478         (MockPlatformInfo.build_version):
1479         * Scripts/webkitpy/results: Added.
1480         * Scripts/webkitpy/results/__init__.py: Added.
1481         * Scripts/webkitpy/results/options.py: Added.
1482         (upload_options): OptParse list for upload options.
1483         * Scripts/webkitpy/results/upload.py: Added.
1484         (Upload): Class which enforces the upload format expected by the results server.
1485         (Upload.Expectations):
1486         (Upload.create_configuration):
1487         (Upload.create_commit):
1488         (Upload.create_details):
1489         (Upload.create_run_stats):
1490         (Upload.create_test_result):
1491         (Upload.__init__):
1492         (Upload.Encoder): Encode Upload object as json.
1493         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1494         * Scripts/webkitpy/results/upload_unittest.py: Added.
1495         * Scripts/webkitpy/test/main.py:
1496         (Tester._parse_args): Add upload arguments.
1497         (Tester._run_tests): Allow results to be uploaded.
1498         * Scripts/webkitpy/test/runner.py:
1499         (Runner.__init__): Record which tests were run, rather than just counting them.
1500         (Runner.handle):
1501         * Scripts/webkitpy/test/runner_unittest.py:
1502         (RunnerTest.test_run):
1503         * Scripts/webkitpy/thirdparty/__init__.py:
1504         (AutoinstallImportHook.find_module): Add requests auto-install.
1505         (AutoinstallImportHook._install_requests):
1506         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1507         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1508
1509 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1510
1511         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1512         https://bugs.webkit.org/show_bug.cgi?id=195810
1513
1514         Reviewed by Tim Horton.
1515
1516         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1517         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1518         ending certain layout tests.
1519
1520         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1521         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1522         (-[TestRunnerWKWebView dealloc]):
1523         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1524
1525         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1526         helper method when destroying the web view, and when resetting state between tests.
1527
1528         * WebKitTestRunner/ios/TestControllerIOS.mm:
1529         (WTR::TestController::platformResetStateToConsistentValues):
1530
1531         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1532
1533 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1534
1535         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1536         https://bugs.webkit.org/show_bug.cgi?id=190350
1537         <rdar://problem/45089503>
1538
1539         Reviewed by Geoffrey Garen.
1540
1541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1542         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1543         (TEST):
1544         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1545         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1546         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1547         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1548         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1549         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1550         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1551         (runTest):
1552         (createDirectories):
1553         (TEST):
1554         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1555         (TEST):
1556         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1557         (TEST):
1558
1559 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1560
1561         Add support to WebPage for getting the contents as an attributed string.
1562         https://bugs.webkit.org/show_bug.cgi?id=195636
1563         rdar://problem/45055697
1564
1565         Reviewed by Tim Horton.
1566
1567         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1568         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1569
1570 2019-03-15  Chris Dumez  <cdumez@apple.com>
1571
1572         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1573         https://bugs.webkit.org/show_bug.cgi?id=195747
1574
1575         Reviewed by Geoff Garen.
1576
1577         Add API test coverage.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1580
1581 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1582
1583         Unreviewed, rolling out r242952.
1584
1585         Causing API failures on iOS Simulator
1586
1587         Reverted changeset:
1588
1589         "[PSON] Make sure the WebProcessCache is leverage when
1590         relaunching a process after termination"
1591         https://bugs.webkit.org/show_bug.cgi?id=195747
1592         https://trac.webkit.org/changeset/242952
1593
1594 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1595
1596         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1597         https://bugs.webkit.org/show_bug.cgi?id=195740
1598
1599         Reviewed by Ross Kirsling.
1600
1601         window.open doesn't work for WebKitBrowserWindow because it is not
1602         implemented yet.
1603
1604         1. Implemented createNewPage callback of WKPageUIClient.
1605         2. Changed MainWindow to take a BrowserWindow factory function
1606           instead of BrowserWindowType to be flexible to create
1607           BrowserWindow with extra settings.
1608         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1609           because it is not relevant with MainWindow anymore.
1610
1611         * MiniBrowser/win/Common.cpp:
1612         (parseCommandLine):
1613         * MiniBrowser/win/Common.h:
1614         (CommandLineOptions::CommandLineOptions):
1615         * MiniBrowser/win/MainWindow.cpp:
1616         (MainWindow::MainWindow):
1617         (MainWindow::create):
1618         (MainWindow::init):
1619         (MainWindow::WndProc):
1620         * MiniBrowser/win/MainWindow.h:
1621         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1622         (PrintWebUIDelegate::createWebViewWithRequest):
1623         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1624         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1625         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1626         (WebKitBrowserWindow::updateProxySettings):
1627         (WebKitBrowserWindow::createNewPage):
1628         * MiniBrowser/win/WebKitBrowserWindow.h:
1629         * MiniBrowser/win/WinMain.cpp:
1630         (wWinMain):
1631
1632 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1633
1634         Make it possible to test scrolling tree layer manipulation more easily
1635         https://bugs.webkit.org/show_bug.cgi?id=195780
1636
1637         Reviewed by Tim Horton.
1638         
1639         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1640         cuts off communication of scrolling tree scrolls back to the web process
1641         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1642         allows tests to trigger scrolls which run the scrolling tree layer positioning
1643         logic, but never get another commit from the web process that might mask
1644         scrolling tree bugs.
1645         
1646         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1647         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1648         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1649
1650         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1651         (WTR::UIScriptController::scrollUpdatesDisabled const):
1652         (WTR::UIScriptController::setScrollUpdatesDisabled):
1653         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1654         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1655         (WTR::UIScriptController::scrollUpdatesDisabled const):
1656         (WTR::UIScriptController::setScrollUpdatesDisabled):
1657         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1658         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1659         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1660         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1661         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1662         * WebKitTestRunner/ios/TestControllerIOS.mm:
1663         (WTR::TestController::platformResetStateToConsistentValues):
1664         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1665         (WTR::UIScriptController::scrollUpdatesDisabled const):
1666         (WTR::UIScriptController::setScrollUpdatesDisabled):
1667
1668 2019-03-14  Youenn Fablet  <youenn@apple.com>
1669
1670         Move IDB storage in private browsing mode to NetworkProcess
1671         https://bugs.webkit.org/show_bug.cgi?id=195602
1672
1673         Reviewed by Brady Eidson.
1674
1675         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1676         (TEST):
1677
1678 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1679
1680         [ews-build] Make descriptionDone messages more readable
1681         https://bugs.webkit.org/show_bug.cgi?id=195760
1682
1683         Reviewed by Lucas Forschler.
1684
1685         * BuildSlaveSupport/ews-build/steps.py:
1686         * BuildSlaveSupport/ews-build/steps_unittest.py:
1687
1688 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1689
1690         [ews-build] Generate status-bubble hover-over messages
1691         https://bugs.webkit.org/show_bug.cgi?id=195680
1692
1693         Reviewed by Lucas Forschler.
1694
1695         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1696         (StatusBubble):
1697         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1698         on hover-over.
1699         (StatusBubble._iso_time):
1700         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1701         hover-over message.
1702         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1703
1704 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-app] Gracefully handle the case when state_string is None
1707         https://bugs.webkit.org/show_bug.cgi?id=195753
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-app/ews/models/build.py:
1712         * BuildSlaveSupport/ews-app/ews/models/step.py:
1713
1714 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-app] Status bubble display pending for currently running build step
1717         https://bugs.webkit.org/show_bug.cgi?id=195744
1718
1719         Reviewed by Lucas Forschler.
1720
1721         * BuildSlaveSupport/ews-build/events.py:
1722         (Events.stepStarted): If state_string is pending, replace it with step name.
1723
1724 2019-03-14  Chris Dumez  <cdumez@apple.com>
1725
1726         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1727         https://bugs.webkit.org/show_bug.cgi?id=195750
1728
1729         Reviewed by Geoffrey Garen.
1730
1731         Add API test coverage.
1732
1733         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1734         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1735         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1736         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1737
1738 2019-03-14  Chris Dumez  <cdumez@apple.com>
1739
1740         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1741         https://bugs.webkit.org/show_bug.cgi?id=195747
1742
1743         Reviewed by Geoff Garen.
1744
1745         Add API test coverage.
1746
1747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1748
1749 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1750
1751         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1752         https://bugs.webkit.org/show_bug.cgi?id=195725
1753         <rdar://problem/48545062>
1754
1755         Reviewed by Tim Horton.
1756
1757         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1758         handler is nil.
1759
1760         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1761         (TestWebKitAPI::TEST):
1762
1763 2019-03-13  Sam Weinig  <sam@webkit.org>
1764
1765         Add utility function to allow easy reverse range-based iteration of a container
1766         https://bugs.webkit.org/show_bug.cgi?id=195542
1767
1768         Reviewed by Antti Koivisto.
1769
1770         * TestWebKitAPI/CMakeLists.txt:
1771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1772         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1773         (TestWebKitAPI::TEST):
1774         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1775
1776 2019-03-13  Chris Dumez  <cdumez@apple.com>
1777
1778         Use a ServiceWorker process per registrable domain
1779         https://bugs.webkit.org/show_bug.cgi?id=195649
1780
1781         Reviewed by Youenn Fablet.
1782
1783         Update API test coverage.
1784
1785         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1786
1787 2019-03-13  Chris Dumez  <cdumez@apple.com>
1788
1789         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1790         https://bugs.webkit.org/show_bug.cgi?id=195684
1791         <rdar://problem/48294714>
1792
1793         Reviewed by Antti Koivisto.
1794
1795         Add API test coverage.
1796
1797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1798
1799 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-app] Remove unused patch view
1802         https://bugs.webkit.org/show_bug.cgi?id=195669
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-app/ews/urls.py:
1807         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1808
1809 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1810
1811         [ews-app] Use Buildbot result code variables
1812         https://bugs.webkit.org/show_bug.cgi?id=195668
1813
1814         Reviewed by Alexey Proskuryakov.
1815
1816         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1817         (Buildbot): Added Buildbot result code variables.
1818         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1819         (StatusBubble._build_bubble): Used Buildbot result code variables.
1820
1821 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1822
1823         [Flatpak] Expand submodule recursively
1824         https://bugs.webkit.org/show_bug.cgi?id=195672
1825
1826         Building WPE with flatpak was impossible without that as it was raising an exception.
1827         Also update wpebackend-fdo to match what is built in jhbuild
1828
1829         Reviewed by Philippe Normand.
1830
1831         * flatpak/flatpakutils.py:
1832         (expand_submodules_recurse):
1833         (expand_manifest):
1834         * flatpak/org.webkit.WPEModules.yaml:
1835
1836 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1837
1838         [ews-app] status bubble should be hidden for certain builds
1839         https://bugs.webkit.org/show_bug.cgi?id=194597
1840
1841         Reviewed by Dewei Zhu.
1842
1843         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1844         (StatusBubble._build_bubble):
1845         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1846         because the patch didn't have relevant changes.
1847         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1848         in production yet.
1849
1850 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1851
1852         [Win] Fix a slew of simple clang-cl warnings.
1853         https://bugs.webkit.org/show_bug.cgi?id=195652
1854
1855         Reviewed by Don Olmstead.
1856
1857         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1858         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1859
1860 2019-03-12  Justin Fan  <justin_fan@apple.com>
1861
1862         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1863         https://bugs.webkit.org/show_bug.cgi?id=195518
1864         <rdar://problem/46322356>
1865
1866         Reviewed by Myles C. Maxfield.
1867
1868         * DumpRenderTree/DerivedSources-input.xcfilelist:
1869         * DumpRenderTree/DerivedSources-output.xcfilelist:
1870
1871 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1872
1873         Unreviewed, rolling out r242825.
1874         https://bugs.webkit.org/show_bug.cgi?id=195648
1875
1876         "Broke webkitpy tests with my change to
1877         lldb_dump_class_layout.py" (Requested by rmorisset on
1878         #webkit).
1879
1880         Reverted changeset:
1881
1882         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1883         classes with suspicious padding"
1884         https://bugs.webkit.org/show_bug.cgi?id=195573
1885         https://trac.webkit.org/changeset/242825
1886
1887 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1888
1889         [ews-build] Show status bubbles while the patch is waiting in queue
1890         https://bugs.webkit.org/show_bug.cgi?id=195618
1891
1892         Reviewed by Lucas Forschler.
1893
1894         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1895         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1896         enabled in initial deployment.
1897         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1898         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1899         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1900         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1901         (StatusBubble._build_bubbles_for_patch):
1902
1903 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1904
1905         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1906         https://bugs.webkit.org/show_bug.cgi?id=195573
1907
1908         Reviewed by Simon Fraser.
1909
1910         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1911
1912         * Scripts/dump-class-layout:
1913         (main):
1914         * lldb/lldb_dump_class_layout.py:
1915         (ClassLayout.__init__):
1916         (ClassLayout._compute_padding_recursive):
1917         (LLDBDebuggerInstance.dump_layout_for_classname):
1918         (LLDBDebuggerInstance):
1919         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1920         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1921
1922 2019-03-12  Chris Dumez  <cdumez@apple.com>
1923
1924         Device Orientation access permission should be denied unless explicitly granted by the client
1925         https://bugs.webkit.org/show_bug.cgi?id=195625
1926
1927         Reviewed by Youenn Fablet.
1928
1929         add API test coverage.
1930
1931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1932         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1933         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1934         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1935         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1936         (runDeviceOrientationTest):
1937         (TEST):
1938         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1939         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1940
1941 2019-03-12  Jer Noble  <jer.noble@apple.com>
1942
1943         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1944         https://bugs.webkit.org/show_bug.cgi?id=195137
1945         <rdar://problem/48810307>
1946
1947         Reviewed by Eric Carlson.
1948
1949         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1950         (TestWebKitAPI::TEST):
1951
1952 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1953
1954         [ews-build] Change urls from uat to production
1955         https://bugs.webkit.org/show_bug.cgi?id=195566
1956
1957         Reviewed by Lucas Forschler.
1958
1959         * BuildSlaveSupport/ews-app/ews/config.py:
1960         * BuildSlaveSupport/ews-build/events.py:
1961         * BuildSlaveSupport/ews-build/steps.py:
1962
1963 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [ews-build] change max_builds for local-worker to 1
1966         https://bugs.webkit.org/show_bug.cgi?id=195568
1967
1968         Reviewed by Lucas Forschler.
1969
1970         * BuildSlaveSupport/ews-build/loadConfig.py:
1971
1972 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1973
1974         Fix the build
1975
1976         * TestRunnerShared/spi/PencilKitTestSPI.h:
1977         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1978
1979 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1980
1981         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1982         https://bugs.webkit.org/show_bug.cgi?id=194131
1983
1984         Reviewed by Michael Catanzaro.
1985
1986         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1987         (uriChanged):
1988         (testUnfinishedSubresourceLoad):
1989         (serverCallback):
1990         (beforeAll):
1991
1992 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1993
1994         WTF::Expected should use std::addressof instead of operator&
1995         https://bugs.webkit.org/show_bug.cgi?id=195604
1996
1997         Reviewed by Myles Maxfield.
1998
1999         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2000         (TestWebKitAPI::Unique::Unique):
2001         (TestWebKitAPI::Unique::operator&):
2002         (TestWebKitAPI::TEST):
2003
2004 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2005
2006         Add Optional to Forward.h.
2007         https://bugs.webkit.org/show_bug.cgi?id=195586
2008
2009         Reviewed by Darin Adler.
2010
2011         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2012         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2013         Remove unnecessary includes from headers.
2014
2015 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2016
2017         Add testing API to hit-test and scroll overflow scrollers
2018         https://bugs.webkit.org/show_bug.cgi?id=195278
2019
2020         Reviewed by Antti Koivisto.
2021         
2022         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2023         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2024         
2025         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2026
2027         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2028         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2029         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2030         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2031         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2032         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2033         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2034         (WTR::enclosingScrollViewIncludingSelf):
2035         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2036
2037 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2038
2039         API test WebKit.RequestTextInputContext fails on iOS
2040         https://bugs.webkit.org/show_bug.cgi?id=195585
2041
2042         Reviewed by Wenson Hsieh and Simon Fraser.
2043
2044         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2045         (applyStyle):
2046         (TEST):
2047         Add a viewport, so that the coordinates match up on iOS.
2048         Scroll by moving the UIScrollView's contentOffset.
2049
2050 2019-03-11  Chris Dumez  <cdumez@apple.com>
2051
2052         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2053         https://bugs.webkit.org/show_bug.cgi?id=195506
2054         <rdar://problem/48733477>
2055
2056         Reviewed by Alex Christensen.
2057
2058         Add API test coverage.
2059
2060         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2061
2062 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2063
2064         Adding myself to contributors.json
2065
2066         Unreviewed, addming myself to contributors.json .
2067
2068         * Scripts/webkitpy/common/config/contributors.json:
2069
2070 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2071
2072         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2073         https://bugs.webkit.org/show_bug.cgi?id=195511
2074         <rdar://problem/44873269>
2075
2076         Reviewed by Darin Adler.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2079         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2080         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2081         (TEST_F):
2082
2083 2019-03-11  Chris Dumez  <cdumez@apple.com>
2084
2085         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2086         https://bugs.webkit.org/show_bug.cgi?id=195561
2087
2088         Reviewed by Youenn Fablet.
2089
2090         Make sure the JS in the test requests for permission to receive device orientation events.
2091
2092         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2093
2094 2019-03-11  Youenn Fablet  <youenn@apple.com>
2095
2096         Allow storage quota increase by default in WTR
2097         https://bugs.webkit.org/show_bug.cgi?id=195541
2098
2099         Reviewed by Geoffrey Garen.
2100
2101         Allow storage quota increase by default in WTR.
2102         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2103         Use this for tests that explicitly need cache increase.
2104
2105         Instead of increasing quota by 2, make sure the next request is
2106         granted by adding all given parameters.
2107
2108         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2110         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2111         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2112         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::TestController::setAllowStorageQuotaIncrease):
2115         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2116         * WebKitTestRunner/TestController.h:
2117         * WebKitTestRunner/TestInvocation.cpp:
2118         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2119         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2120         (WTR::TestController::cocoaResetStateToConsistentValues):
2121         (WTR::TestController::setAllowStorageQuotaIncrease):
2122         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2123         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2124         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2125
2126 2019-03-11  Xan Lopez  <xan@igalia.com>
2127
2128         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2129         https://bugs.webkit.org/show_bug.cgi?id=194147
2130
2131         Reviewed by Michael Saboff.
2132
2133         To make --32-bit work correctly on Linux/64bit we need to:
2134
2135         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2136         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2137         unfortunately CMake only allows us to do this during
2138         crosscompilation, which is overkill here.
2139         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2140         pkg-config detection module uses the x86 .pc files instead of the
2141         x86_64 ones.
2142         - Set the -m32 flags for the compiler.
2143
2144         * Scripts/webkitdirs.pm:
2145         (generateBuildSystemFromCMakeProject):
2146
2147 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2148
2149         Add MotionMark-1.1 plan file for run-benchmark script.
2150         https://bugs.webkit.org/show_bug.cgi?id=195481
2151
2152         Rubber-stamped by Darin Adler.
2153
2154         Run-benchmark script should support MontionMark-1.1.
2155
2156         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2157
2158 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2159
2160         [ews-app] Add support for submit-to-ews url
2161         https://bugs.webkit.org/show_bug.cgi?id=195477
2162
2163         Reviewed by Lucas Forschler.
2164
2165         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2166         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2167         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2168         * BuildSlaveSupport/ews-app/ews/urls.py:
2169         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2170
2171 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2172
2173         Unreviewed, rolling out r242688, r242643, r242624.
2174
2175         Caused multiple layout test failures and crashes on iOS and macOS.
2176
2177         Reverted changeset:
2178
2179         "requestAnimationFrame should execute before the next frame"
2180         https://bugs.webkit.org/show_bug.cgi?id=177484
2181         https://trac.webkit.org/changeset/242624/webkit
2182
2183         * Tracing/SystemTracePoints.plist:
2184
2185 2019-03-11  John Wilander  <wilander@apple.com>
2186
2187         Resource Load Statistics: Make it possible exclude localhost from classification
2188         https://bugs.webkit.org/show_bug.cgi?id=195474
2189         <rdar://problem/47520577>
2190
2191         Reviewed by Brent Fulgham.
2192
2193         This patch allows for localhost to be excluded from classification and
2194         treatment as a prevalent resource.
2195
2196         The WebKit Tools change adds a new function called
2197         testRunner.setStatisticsIsRunningTest() which can be used to control this
2198         behavior.
2199
2200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2202         (WTR::TestRunner::setStatisticsIsRunningTest):
2203         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2204         * WebKitTestRunner/TestController.cpp:
2205         (WTR::TestController::setStatisticsIsRunningTest):
2206         * WebKitTestRunner/TestController.h:
2207         * WebKitTestRunner/TestInvocation.cpp:
2208         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2209
2210 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2211
2212         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2213         https://bugs.webkit.org/show_bug.cgi?id=195560
2214
2215         Reviewed by Lucas Forschler.
2216
2217         * BuildSlaveSupport/ews-build/master.cfg:
2218
2219 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2220
2221         Unreviewed, rolling out r242698.
2222
2223         API test crashes on bots.
2224
2225         Reverted changeset:
2226
2227         "Add a WKContentRuleList variant that uses copied memory
2228         instead of mmap'd shared memory for class A containerized
2229         apps"
2230         https://bugs.webkit.org/show_bug.cgi?id=195511
2231         https://trac.webkit.org/changeset/242698
2232
2233 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2234
2235         [WPE] Enable web process sandbox
2236         https://bugs.webkit.org/show_bug.cgi?id=195169
2237
2238         Reviewed by Daniel Bates.
2239
2240         * wpe/install-dependencies:
2241         * wpe/jhbuild.modules:
2242
2243 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2244
2245         [ews-app] Use port 17000 for worker communication
2246         https://bugs.webkit.org/show_bug.cgi?id=195558
2247
2248         Reviewed by Lucas Forschler.
2249
2250         * BuildSlaveSupport/ews-build/master.cfg:
2251
2252 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2253
2254         [ews-build] unit-tests fail when passwords.json is missing
2255         https://bugs.webkit.org/show_bug.cgi?id=195557
2256
2257         Reviewed by Lucas Forschler.
2258
2259         * BuildSlaveSupport/ews-build/loadConfig.py:
2260         (loadBuilderConfig):
2261         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2262         (ConfigDotJSONTest.test_configuration):
2263         * BuildSlaveSupport/ews-build/master.cfg:
2264
2265 2019-03-11  Truitt Savell  <tsavell@apple.com>
2266
2267         Unreviewed, rolling out r242702.
2268
2269         Broke High Sierra builders.
2270
2271         Reverted changeset:
2272
2273         "Add utility function to allow easy reverse range-based
2274         iteration of a container"
2275         https://bugs.webkit.org/show_bug.cgi?id=195542
2276         https://trac.webkit.org/changeset/242702
2277
2278 2019-03-11  Sam Weinig  <sam@webkit.org>
2279
2280         Add utility function to allow easy reverse range-based iteration of a container
2281         https://bugs.webkit.org/show_bug.cgi?id=195542
2282
2283         Reviewed by Antti Koivisto.
2284
2285         * TestWebKitAPI/CMakeLists.txt:
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2288         (TestWebKitAPI::TEST):
2289         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2290
2291 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2292
2293         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2294         https://bugs.webkit.org/show_bug.cgi?id=195511
2295         <rdar://problem/44873269>
2296
2297         Reviewed by Darin Adler.
2298
2299         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2300         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2301         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2302         (TEST_F):
2303
2304 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2305
2306         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2307         https://bugs.webkit.org/show_bug.cgi?id=195499
2308
2309         Reviewed by Darin Adler.
2310
2311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2312         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2313         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2314         (-[WKWebView synchronouslyFocusTextInputContext:]):
2315         (applyStyle):
2316         (applyIframe):
2317         (TEST):
2318         Add some tests for this SPI.
2319
2320 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2321
2322         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2323         https://bugs.webkit.org/show_bug.cgi?id=181151
2324
2325         Reviewed by Don Olmstead.
2326
2327         * TestWebKitAPI/CMakeLists.txt:
2328         * TestWebKitAPI/PlatformWin.cmake:
2329         Enable TestWTF RunLoop tests in all platforms.
2330
2331         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2332         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2333         (TestWebKitAPI::DerivedOneShotTimer::fired):
2334         (TestWebKitAPI::TEST):
2335         Only a few platforms support nested RunLoop.
2336
2337         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2338         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2339
2340 2019-03-10  David Quesada  <david_quesada@apple.com>
2341
2342         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2343         https://bugs.webkit.org/show_bug.cgi?id=152480
2344
2345         Reviewed by Chris Dumez.
2346
2347         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2348         there are no additional references to the process pool besides the one held by
2349         the download, waits for the download to finish (in the sense that the
2350         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2351         measure, also check that the process pool has been deallocated at the end of the
2352         test. The test wouldn't be meaningful if the process pool were still alive.
2353
2354         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2355         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2356         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2357             The download will be canceled because the delegate does not implement the
2358             method to decide the download's destination, so this is where we know the
2359             DownloadProxyMap is done with the DownloadProxy.
2360         (TEST):
2361
2362 2019-03-08  Chris Dumez  <cdumez@apple.com>
2363
2364         Add support for Device Orientation / Motion permission API
2365         https://bugs.webkit.org/show_bug.cgi?id=195329
2366         <rdar://problem/47645367>
2367
2368         Reviewed by Geoffrey Garen.
2369
2370         Add test infrastructure to help test the Device Orientation / Motion permission API.
2371
2372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2374         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2375         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2376         * WebKitTestRunner/TestController.cpp:
2377         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2378         (WTR::TestController::createWebViewWithOptions):
2379         (WTR::TestController::resetStateToConsistentValues):
2380         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2381         * WebKitTestRunner/TestController.h:
2382         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2383         * WebKitTestRunner/TestInvocation.cpp:
2384         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2385
2386 2019-03-08  Saam barati  <sbarati@apple.com>
2387
2388         Add a compare-results script to compare benchmark results
2389         https://bugs.webkit.org/show_bug.cgi?id=195486
2390         <rdar://problem/48723397>
2391
2392         Reviewed by Geoffrey Garen.
2393
2394         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2395         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2396         to extend it to learn about our other benchmarks.
2397
2398         * Scripts/compare-results: Added.
2399         (readJSONFile):
2400         (detectJetStream2):
2401         (JetStream2Results):
2402         (detectSpeedometer2):
2403         (Speedometer2Results):
2404         (detectPLT5):
2405         (PLT5Results):
2406         (detectBenchmark):
2407         (biggerIsBetter):
2408         (ttest):
2409         (getOptions):
2410         (main):
2411
2412 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2413
2414         Ensure old tab state is cleared between iterations of run-benchmark
2415         https://bugs.webkit.org/show_bug.cgi?id=195393
2416         <rdar://problem/46885583>
2417
2418         Reviewed by Dewei Zhu.
2419
2420         a) ensure the default to restore state is not set
2421         b) terminate Safari correctly
2422         c) Set the system default to ignore Persistent State in Safari
2423
2424         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2425         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2426         (OSXBrowserDriver.prepare_env): 
2427         (OSXBrowserDriver.restore_env):
2428         (OSXBrowserDriver.close_browsers):
2429         (OSXBrowserDriver._terminate_processes):
2430         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2431         (OSXChromeDriver):
2432         (OSXChromeCanaryDriver):
2433         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2434         (OSXFirefoxDriver):
2435         (OSXFirefoxNightlyDriver):
2436         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2437         (OSXSafariDriver):
2438         (OSXSafariDriver.prepare_env):
2439
2440 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2441
2442         [GTK] Several InputMethodFilter tests are failing
2443         https://bugs.webkit.org/show_bug.cgi?id=195408
2444
2445         Reviewed by Carlos Garcia Campos.
2446
2447         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2448         Regressed in r241751.
2449         Hexadecimal values of keycodes are expressed now in upper letters.
2450         Composited characters should be cast to UTF8 strings.
2451
2452         (TestWebKitAPI::TEST):
2453
2454 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2455
2456         [GTK] Make Tools/gtkdoc python3 compatible
2457         https://bugs.webkit.org/show_bug.cgi?id=195359
2458
2459         Reviewed by Carlos Garcia Campos.
2460
2461         * gtkdoc/generate-gtkdoc:
2462         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2463         work with Python 2 and 3.
2464         (get_gtkdoc_module_paths):
2465         The iteritems() was removed in Python 3, so let's use items() that's
2466         available in Python 2 and 3.
2467         (get_generator_for_config):
2468         * gtkdoc/gtkdoc.py:
2469         (GTKDoc._run_command):
2470         The sys.stdout.write() is expecting str in Python 3 and not bytes
2471         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2472         for passing the bytes there.
2473
2474 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2475
2476         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2477         https://bugs.webkit.org/show_bug.cgi?id=195346
2478         <rdar://problem/48667048>
2479
2480         Unreviewed build fix for clang-cl.
2481
2482         * DumpRenderTree/win/DumpRenderTree.cpp:
2483         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2484
2485 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2486
2487         requestAnimationFrame should execute before the next frame
2488         https://bugs.webkit.org/show_bug.cgi?id=177484
2489
2490         Reviewed by Simon Fraser.
2491
2492         Add trace points for the page RenderingUpdate.
2493
2494         * Tracing/SystemTracePoints.plist:
2495
2496 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2497
2498         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2499         https://bugs.webkit.org/show_bug.cgi?id=195353
2500         <rdar://problem/48626394>
2501
2502         Reviewed by Simon Fraser.
2503
2504         * WebKitTestRunner/ios/TestControllerIOS.mm:
2505         (WTR::TestController::platformResetPreferencesToConsistentValues):
2506
2507 2019-03-07  John Wilander  <wilander@apple.com>
2508
2509         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2510         https://bugs.webkit.org/show_bug.cgi?id=195383
2511         <rdar://problem/48570136>
2512
2513         Reviewed by Brent Fulgham.
2514
2515         This patch adds test infrastructure to purge only script-accessible cookies,
2516         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2517
2518         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2520         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2521         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2522         * WebKitTestRunner/TestController.cpp:
2523         (WTR::TestController::statisticsDeleteCookiesForHost):
2524         * WebKitTestRunner/TestController.h:
2525         * WebKitTestRunner/TestInvocation.cpp:
2526         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2527
2528 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2529
2530         Unreviewed, rolling out r242354.
2531         https://bugs.webkit.org/show_bug.cgi?id=195402
2532
2533         breaks layout tests in all configurations (Requested by
2534         zdobersek on #webkit).
2535
2536         Reverted changeset:
2537
2538         "[WPE] Enable web process sandbox"
2539         https://bugs.webkit.org/show_bug.cgi?id=195169
2540         https://trac.webkit.org/changeset/242354
2541
2542 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2543
2544         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2545         https://bugs.webkit.org/show_bug.cgi?id=195346
2546
2547         Reviewed by Fujii Hironori.
2548
2549         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2550         (TestWebKitAPI::TEST):
2551         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2552
2553         * DumpRenderTree/win/DumpRenderTree.cpp:
2554         (findFontFallback):
2555         (addFontFallbackIfPresent):
2556         (removeFontFallbackIfPresent):
2557         (main):
2558         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2559         (TestWebKitAPI::Util::moduleDirectory):
2560         (TestWebKitAPI::Util::createInjectedBundlePath):
2561         Use wchar helpers as needed.
2562
2563 2019-03-06  Rob Buis  <rbuis@igalia.com>
2564
2565         Consider supporting the `referrerpolicy` attribute.
2566         https://bugs.webkit.org/show_bug.cgi?id=179053
2567
2568         Reviewed by Darin Adler.
2569
2570         Add a runtime flag for referrerpolicy attribute.
2571
2572         * DumpRenderTree/mac/DumpRenderTree.mm:
2573         (enableExperimentalFeatures):
2574
2575 2019-03-05  Daniel Bates  <dabates@apple.com>
2576
2577         Update expected API test result following r242379
2578         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2579
2580         Update expected x-coordinate of selection rect now that the left padding of
2581         a textarea is sized in ems (so dependent on the font size) just like the left
2582         padding of a text field.
2583
2584         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2585         (TestWebKitAPI::TEST):
2586
2587 2019-03-05  David Quesada  <david_quesada@apple.com>
2588
2589         [WK2] It should be possible to follow links with 'download' attributes
2590         https://bugs.webkit.org/show_bug.cgi?id=195145
2591         rdar://problem/48462642
2592
2593         Reviewed by Alex Christensen.
2594
2595         Add a unit test to verify that activating links with 'download' attributes now
2596         navigates to the linked resource, rather than starts downloading it. Add another
2597         to verify that it is still possible to explicitly download the link via the
2598         'Download' navigation action policy.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2601         (-[DownloadAttributeTestDelegate init]):
2602         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2603         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2604         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2605         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2606         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2607         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2608         (TEST):
2609         * WebKitTestRunner/TestController.cpp:
2610         (WTR::TestController::decidePolicyForNavigationAction):
2611         * WebKitTestRunner/TestController.h:
2612
2613 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2614
2615         [Curl] Implement Cookie Accept Policy.
2616         https://bugs.webkit.org/show_bug.cgi?id=191645
2617
2618         Reviewed by Fujii Hironori.
2619
2620         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2621         (TestWebKitAPI::Curl::TEST_F):
2622
2623 2019-03-05  Youenn Fablet  <youenn@apple.com>
2624
2625         Rename requestCacheStorageSpace to requestStorageSpace
2626         https://bugs.webkit.org/show_bug.cgi?id=195282
2627
2628         Reviewed by Chris Dumez.
2629
2630         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2631         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2632         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2633
2634 2019-03-05  Brady Eidson  <beidson@apple.com>
2635
2636         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2637         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2638
2639         Reviewed by Tim Horton.
2640
2641         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2642         different directory into that same WKWebView should work.
2643
2644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2645         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2646
2647 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2648
2649         Add WeakHashSet
2650         https://bugs.webkit.org/show_bug.cgi?id=195152
2651
2652         Reviewed by Antti Koivisto.
2653
2654         Added tests for WeakHashSet.
2655
2656         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2657         (TestWebKitAPI::Base::Base): Moved.
2658         (TestWebKitAPI::Derived::foo): Moved.
2659         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2660         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2661         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2662         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2663
2664 2019-03-04  Chris Dumez  <cdumez@apple.com>
2665
2666         Do not share WebProcesses between private and regular sessions
2667         https://bugs.webkit.org/show_bug.cgi?id=195189
2668         <rdar://problem/48421064>
2669
2670         Reviewed by Alex Christensen.
2671
2672         Add API test coverage.
2673
2674         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2675         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2676
2677 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2678
2679         [WPE] Enable web process sandbox
2680         https://bugs.webkit.org/show_bug.cgi?id=195169
2681
2682         Reviewed by Daniel Bates.
2683
2684         * wpe/install-dependencies:
2685         * wpe/jhbuild.modules:
2686
2687 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2688
2689         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2690         https://bugs.webkit.org/show_bug.cgi?id=195206
2691
2692         Reviewed by Žan Doberšek.
2693
2694         Add a new test case.
2695
2696         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2697         (testJSCClass):
2698
2699 2019-03-04  Charlie Turner  <cturner@igalia.com>
2700
2701         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2702         https://bugs.webkit.org/show_bug.cgi?id=194898
2703
2704         Reviewed by Žan Doberšek.
2705
2706         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2707         a GCC extension that permits arithmetic on void* pointer. Inline
2708         the macro until this issue is fixed upstream.
2709
2710 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2711
2712         Rid the world of WK_API_ENABLED
2713         https://bugs.webkit.org/show_bug.cgi?id=195263
2714
2715         Reviewed by Dan Bernstein.
2716
2717         List of changed files elided because it's useless.
2718
2719 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2720
2721         Unreviewed follow-up to r242292.
2722
2723         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2724
2725         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2726         (TestWebKitAPI::testStrip): Renamed from strip.
2727         (TestWebKitAPI::TEST):
2728
2729 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2730
2731         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2732
2733         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2734         and bug #194272 for details.
2735
2736         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2737
2738 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2739
2740         Remove some more unused 32-bit code
2741         https://bugs.webkit.org/show_bug.cgi?id=195255
2742
2743         Reviewed by Darin Adler.
2744
2745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2746         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2747         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2748         (NPP_New):
2749         (NPP_HandleEvent):
2750         (handleEventCarbon): Deleted.
2751
2752 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2753
2754         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2755
2756         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2757         (TestWebKitAPI::TEST):
2758
2759 2019-03-01  Darin Adler  <darin@apple.com>
2760
2761         Finish removing String::format
2762         https://bugs.webkit.org/show_bug.cgi?id=194893
2763
2764         Reviewed by Daniel Bates.
2765 '
2766         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2767
2768 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2769
2770         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2771         https://bugs.webkit.org/show_bug.cgi?id=195229
2772         <rdar://problem/48520362>
2773
2774         Reviewed by Chris Dumez.
2775
2776         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2777         (TEST):
2778
2779 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2780
2781         Add a system trace scope for event region building
2782         https://bugs.webkit.org/show_bug.cgi?id=195226
2783
2784         Reviewed by Jon Lee.
2785
2786         This trace scope measures the time spend converting element rects into Region objects,
2787         which can be large on some pages.
2788
2789         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2790
2791         * Tracing/SystemTracePoints.plist:
2792
2793 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2794
2795         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2796         https://bugs.webkit.org/show_bug.cgi?id=194612
2797
2798         Reviewed by Alex Christensen.
2799
2800         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2801         Just test the new string-processing function and don't touch the actual environment.
2802         (Test cases are all as before, but based on operator== instead of strcmp.)
2803
2804 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2805
2806         [ews-app] Update primary keys for handling multiple Buildbot instances
2807         https://bugs.webkit.org/show_bug.cgi?id=195120
2808
2809         Reviewed by Stephanie Lewis.
2810
2811         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2812         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2813         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2814
2815         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2816         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2817         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2818         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2819         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2820         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2821
2822 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2823
2824         [WinCairo] Enable service worker
2825         https://bugs.webkit.org/show_bug.cgi?id=188318
2826
2827         Reviewed by Youenn Fablet.
2828
2829         * DumpRenderTree/DumpRenderTreePrefix.h:
2830         * TestWebKitAPI/PlatformWin.cmake:
2831         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2832         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2833         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2834
2835 2019-03-01  Justin Fan  <justin_fan@apple.com>
2836
2837         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2838         https://bugs.webkit.org/show_bug.cgi?id=195191
2839
2840         Rubber-stamped by Dean Jackson.
2841
2842         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2843
2844         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2845
2846 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2847
2848         Unreviewed, fix lldb webkitpy tests
2849         https://bugs.webkit.org/show_bug.cgi?id=194375
2850
2851         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2852
2853         * lldb/lldb_webkit.py:
2854         (WTFStringImplProvider.is_8bit):
2855
2856 2019-02-28  David Quesada  <david_quesada@apple.com>
2857
2858         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2859         https://bugs.webkit.org/show_bug.cgi?id=195121
2860         rdar://problem/48450302
2861
2862         Reviewed by Alex Christensen.
2863
2864         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2865         configurations where the 'download' attribute is absent, blank, or populated
2866         with a filename, and where the anchor element is same-origin or cross-origin
2867         (meaning the 'download' attribute shouldn't be honored).
2868
2869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2870         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2871         (-[NavigationActionTestDelegate init]):
2872         (-[NavigationActionTestDelegate navigationAction]):
2873         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2874         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2875         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2876         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2877         (TEST):
2878
2879 2019-02-28  Antoine Quint  <graouts@apple.com>
2880
2881         Enable the Pointer Events runtime flag by default
2882         https://bugs.webkit.org/show_bug.cgi?id=195156
2883
2884         Reviewed by Dean Jackson.
2885
2886         * DumpRenderTree/mac/DumpRenderTree.mm:
2887         (enableExperimentalFeatures):
2888
2889 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2890
2891         Several PasteImage API tests are flaky
2892         https://bugs.webkit.org/show_bug.cgi?id=195160
2893
2894         Reviewed by Tim Horton.
2895
2896         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2897         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2898         listening for a "load" event after image load is already complete.
2899
2900         To address this, make these tests first register a "load" event handler, then run script to insert an image
2901         element into the document, and finally wait until the load event is observed before checking image size.
2902
2903         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2904
2905 2019-02-28  Chris Dumez  <cdumez@apple.com>
2906
2907         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2908         https://bugs.webkit.org/show_bug.cgi?id=195107
2909
2910         Reviewed by Alex Christensen.
2911
2912         Give some time for the zoom level to get restored.
2913
2914         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2915
2916 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2917
2918         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2919         https://bugs.webkit.org/show_bug.cgi?id=194958
2920
2921         Reviewed by Geoffrey Garen.
2922
2923         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2924         (TEST):
2925
2926 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2927
2928         [ews-app] Update method to save build to handle builder_display_name
2929         https://bugs.webkit.org/show_bug.cgi?id=195047
2930
2931         Reviewed by Dewei Zhu.
2932
2933         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2934         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2935
2936 2019-02-28  Justin Fan  <justin_fan@apple.com>
2937
2938         [Web GPU] Enable Web GPU only on 64-bit
2939         https://bugs.webkit.org/show_bug.cgi?id=195139
2940
2941         Because Metal is only supported on 64 bit apps.
2942
2943         Unreviewed build fix.
2944
2945         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2946
2947 2019-02-27  Youenn Fablet  <youenn@apple.com>
2948
2949         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2950         https://bugs.webkit.org/show_bug.cgi?id=194959
2951
2952         Reviewed by Chris Dumez.
2953
2954         Spin loop until getting the condition to remove flakiness.
2955
2956         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2957
2958 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2959
2960         [ews-build] Buildbot should include builder_display_name in the build events
2961         https://bugs.webkit.org/show_bug.cgi?id=195045
2962
2963         Reviewed by Dewei Zhu.
2964
2965         * BuildSlaveSupport/ews-build/events.py:
2966         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2967         buildername to builder_name to be consistent in naming style.
2968         (Events.buildFinished): Ditto.
2969
2970 2019-02-27  Chris Dumez  <cdumez@apple.com>
2971
2972         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2973         https://bugs.webkit.org/show_bug.cgi?id=194480
2974
2975         Reviewed by Brady Eidson.
2976
2977         Update existing API test to make it more likely to reproduce the issue.
2978
2979         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2980
2981 2019-02-27  Brady Eidson  <beidson@apple.com>
2982
2983         Universal links from Google search results pages don't open the app.
2984         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2985
2986         Reviewed by Geoffrey Garen.
2987
2988         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2989         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2990         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2991         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2992
2993 2019-02-27  Chris Dumez  <cdumez@apple.com>
2994
2995         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2996         https://bugs.webkit.org/show_bug.cgi?id=195102
2997
2998         Reviewed by Geoffrey Garen.
2999
3000         If the number of processes is not yet what we expect, wait a bit and check again to give
3001         processes some time to exit.
3002
3003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3004
3005 2019-02-27  Chris Dumez  <cdumez@apple.com>
3006
3007         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3008         https://bugs.webkit.org/show_bug.cgi?id=194545
3009
3010         Reviewed by Brady Eidson.
3011
3012         Make sure the test navigates forward and then back only once. Previously, navigating
3013         back would trigger a navigation again in a timer.
3014
3015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3016
3017 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3018
3019         High Sierra Debug JSC test queue should use faster hardware
3020         https://bugs.webkit.org/show_bug.cgi?id=194603
3021
3022         Rubber-stamped by Alexey Proskuryakov.
3023
3024         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3025
3026         * BuildSlaveSupport/build.webkit.org-config/config.json:
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3028         (BubbleQueueServer):
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3030         (WebKitBuildbot):
3031         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3032         * QueueStatusServer/config/queues.py:
3033         * Scripts/webkitpy/common/config/ews.json:
3034         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3035         (test_ews_name):
3036
3037 2019-02-27  John Wilander  <wilander@apple.com>
3038
3039         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3040         https://bugs.webkit.org/show_bug.cgi?id=195071
3041         <rdar://problem/48417690>
3042
3043         Reviewed by Alex Christensen and Brent Fulgham.
3044
3045         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3046         (TestWebKitAPI::createURL):
3047             Convenience function.
3048         (TestWebKitAPI::TEST):
3049             WebCore::AdClickAttribution now takes a URL when creating Source and
3050             Destination.
3051         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3052         (TestWebKitAPI::TEST):
3053             WebCore::AdClickAttribution now takes a URL when creating Source and
3054             Destination.
3055
3056 2019-02-27  Antoine Quint  <graouts@apple.com>
3057
3058         Support Pointer Events on macOS
3059         https://bugs.webkit.org/show_bug.cgi?id=195008
3060         <rdar://problem/47454419>
3061
3062         Reviewed by Dean Jackson.
3063
3064         * DumpRenderTree/mac/DumpRenderTree.mm:
3065         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3066         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3067
3068 2019-02-26  Mark Lam  <mark.lam@apple.com>
3069
3070         Remove remaining poisoning code.
3071         https://bugs.webkit.org/show_bug.cgi?id=194138
3072
3073         Reviewed by Saam Barati.
3074
3075         * TestWebKitAPI/CMakeLists.txt:
3076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3078         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3079         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3080         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3081         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3082         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3083
3084 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3085
3086         Move ephemeral local storage from WebProcess to UIProcess
3087         https://bugs.webkit.org/show_bug.cgi?id=195074
3088         <rdar://problem/47937975>
3089
3090         Reviewed by Geoff Garen.
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3093
3094 2019-02-20  Jer Noble  <jer.noble@apple.com>
3095
3096         [Cocoa] Media elements will restart network buffering just before suspending
3097         https://bugs.webkit.org/show_bug.cgi?id=193691
3098
3099         Reviewed by Eric Carlson.
3100
3101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3102         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3103         (TEST):
3104
3105 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3106
3107         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3108         https://bugs.webkit.org/show_bug.cgi?id=191652
3109
3110         Reviewed by Alex Christensen.
3111
3112         Fix WinCairo MiniBrowser behavior of authentication dialog.
3113
3114         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3115         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3116
3117 2019-02-26  Youenn Fablet  <youenn@apple.com>
3118
3119         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3120         https://bugs.webkit.org/show_bug.cgi?id=195028
3121         <rdar://problem/48243733>
3122
3123         Reviewed by Eric Carlson.
3124
3125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3126
3127 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3128
3129         [WPE] Add API for webview background color configuration
3130         https://bugs.webkit.org/show_bug.cgi?id=192305
3131
3132         Reviewed by Michael Catanzaro.
3133
3134         * MiniBrowser/wpe/main.cpp:
3135         (main): Add a new option to configure the webview background
3136         color. Example: --bg-color=transparent.
3137         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3138         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3139         (beforeAll): Ditto.
3140
3141 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3142
3143         scalableNativeWebpageParameters() is not preserved on new page navigation.
3144         https://bugs.webkit.org/show_bug.cgi?id=194892
3145         <rdar://problem/47538280>
3146
3147         Reviewed by Wenson Hsieh.
3148         
3149         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3150
3151         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3152         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3153         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3154         (WTR::UIScriptController::allowsViewportShrinkToFit):
3155         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3156         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3157         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3158         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3159         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3160         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3161
3162 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3163
3164         [ews-app] Add model for handling multiple Buildbot instances
3165         https://bugs.webkit.org/show_bug.cgi?id=194863
3166
3167         Reviewed by Stephanie Lewis.
3168
3169         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3170
3171 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3172
3173         [ews-app] Remove BuilderMapping table
3174         https://bugs.webkit.org/show_bug.cgi?id=194961
3175
3176         Reviewed by Stephanie Lewis.
3177
3178         Store builder name directly in build table, instead of having a separate
3179         table for it.
3180
3181         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3182         * BuildSlaveSupport/ews-app/ews/models/build.py:
3183         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3184         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3185
3186 2019-02-25  John Wilander  <wilander@apple.com>
3187
3188         Introduce and adopt new class RegistrableDomain for eTLD+1
3189         https://bugs.webkit.org/show_bug.cgi?id=194791
3190         <rdar://problem/48179240>
3191
3192         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3193
3194         This patch adds an API test and replaces two instances of
3195         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3196
3197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3198         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3199         (TestWebKitAPI::TEST):
3200             Changed two strings to make sure the registrable domains are still considered
3201             invalid and pass the test.
3202         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3203         (TestWebKitAPI::TEST):
3204         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3205         (WTR::InjectedBundle::didReceiveMessageToPage):
3206
3207 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3208
3209         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3210         https://bugs.webkit.org/show_bug.cgi?id=195001
3211
3212         Reviewed by Carlos Garcia Campos.
3213
3214         API version 1.0 always includes the functionality previously guarded with
3215         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3216         unconditionally.
3217
3218         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3219         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3220         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3221         (WebViewTest::showInWindow): Ditto.
3222         (WebViewTest::hideView): Ditto.
3223         * wpe/backends/HeadlessViewBackend.cpp:
3224         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3225         * wpe/backends/ViewBackend.cpp:
3226         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3227         * wpe/backends/WindowViewBackend.cpp:
3228         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3229         WPE_BACKEND_CHECK_VERSION().
3230         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3231
3232 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3233
3234         [Flatpak] Add support for flatpak > 1.1.2
3235         https://bugs.webkit.org/show_bug.cgi?id=194088
3236
3237         Flatpak 1.2 is now out so we need to support that
3238         version now.
3239
3240         Reviewed by Michael Catanzaro.
3241
3242         * flatpak/flatpakutils.py:
3243         (check_flatpak):
3244         (FlatpakPackages.__init__):
3245         (FlatpakPackages.__detect_packages):
3246         (FlatpakPackages.__detect_packages.in):
3247         (FlatpakRepos.update):
3248
3249 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3250
3251         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3252         https://bugs.webkit.org/show_bug.cgi?id=194998
3253
3254         Reviewed by Carlos Garcia Campos.
3255
3256         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3257         to a Git checkout and using the latest commit containing various fixes
3258         and improvements.
3259
3260 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3261
3262         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3263         https://bugs.webkit.org/show_bug.cgi?id=194981
3264
3265         Reviewed by Žan Doberšek.
3266
3267         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3268         (TestWebKitAPI::TEST):
3269
3270 2019-02-23  Keith Miller  <keith_miller@apple.com>
3271
3272         Add new mac target numbers
3273         https://bugs.webkit.org/show_bug.cgi?id=194955
3274
3275         Reviewed by Tim Horton.
3276
3277         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3278         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3279         * MiniBrowser/Configurations/Base.xcconfig:
3280         * TestWebKitAPI/Configurations/Base.xcconfig:
3281         * WebKitTestRunner/Configurations/Base.xcconfig:
3282
3283 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3284
3285         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3286         https://bugs.webkit.org/show_bug.cgi?id=194846
3287
3288         Reviewed by Don Olmstead.
3289
3290         Added _search_paths() and _port_specific_expectations_files() for
3291         WinCairoPort.
3292
3293         * Scripts/webkitpy/port/win.py:
3294         (WinCairoPort.default_baseline_search_path):
3295         (WinCairoPort):
3296         (WinCairoPort._port_specific_expectations_files):
3297         (WinCairoPort._search_paths):
3298
3299 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3300
3301         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3302         https://bugs.webkit.org/show_bug.cgi?id=194963
3303
3304         Reviewed by Dean Jackson.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3307         Do a `contains` check instead of `equals`, because in debug builds we
3308         put the GraphicsLayer pointer in a prefix.
3309
3310 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3311
3312         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3313         https://bugs.webkit.org/show_bug.cgi?id=194873
3314         <rdar://problem/46701974>
3315
3316         Reviewed by Tim Horton.
3317
3318         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3319
3320         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3321         (WTR::UIScriptController::menuRect const):
3322         (WTR::UIScriptController::isShowingMenu const):
3323         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3324         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3325         (WTR::UIScriptController::menuRect const):
3326
3327         Add a function to query the bounds of the callout menu in content coordinates.
3328
3329         (WTR::UIScriptController::isShowingMenu const):
3330
3331         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3332
3333         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3334         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3336         (WTR::UIScriptController::rectForMenuAction const):
3337         (WTR::UIScriptController::menuRect const):
3338         (WTR::UIScriptController::isShowingMenu const):
3339         (WTR::findViewInHierarchyOfType): Deleted.
3340
3341 2019-02-22  Chris Dumez  <cdumez@apple.com>
3342
3343         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3344         https://bugs.webkit.org/show_bug.cgi?id=194954
3345         <rdar://problem/48127957>
3346
3347         Reviewed by Alex Christensen.
3348
3349         Add API test coverage.
3350
3351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3352         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3353         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3354         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3355
3356 2019-02-22  Chris Dumez  <cdumez@apple.com>
3357
3358         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3359         https://bugs.webkit.org/show_bug.cgi?id=194924
3360         <rdar://problem/48216125>
3361
3362         Reviewed by Geoffrey Garen.
3363
3364         Add API test coverage.
3365
3366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3367
3368 2019-02-22  Chris Dumez  <cdumez@apple.com>
3369
3370         Unreviewed, disable API test added in r241928 on iOS.
3371
3372         The cache is not enabled on devices with less than 3GB of RAM.
3373
3374         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3375
3376 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3377
3378         Hardcode Visual Viewports on everywhere except iOS WK1
3379         https://bugs.webkit.org/show_bug.cgi?id=194928
3380
3381         Reviewed by Zalan Bujtas.
3382
3383         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3384         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3385         set it to false. The setting has shipped for several years and there's no need to turn
3386         it off now.
3387
3388         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3389         Visual Viewports are not enabled.
3390         
3391         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3392         that only runs in WK2
3393
3394         * MiniBrowser/mac/SettingsController.h:
3395         * MiniBrowser/mac/SettingsController.m:
3396         (-[SettingsController init]):
3397         (-[SettingsController _populateMenu]):
3398         (-[SettingsController validateMenuItem:]):
3399         (-[SettingsController visualViewportEnabled]): Deleted.
3400         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3401         * MiniBrowser/mac/WK1BrowserWindowController.m:
3402         (-[WK1BrowserWindowController didChangeSettings]):
3403         * MiniBrowser/mac/WK2BrowserWindowController.m:
3404         (-[WK2BrowserWindowController didChangeSettings]):
3405
3406 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3407
3408         Discard cached processes when clearing website data store
3409         https://bugs.webkit.org/show_bug.cgi?id=194894
3410
3411         Reviewed by Chris Dumez.
3412
3413         Added a test case.
3414
3415         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3416         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3417
3418 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3419
3420         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3421         https://bugs.webkit.org/show_bug.cgi?id=194914
3422         <rdar://problem/47586889>
3423
3424         Reviewed by Geoffrey Garen.
3425
3426         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3427         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3428         (TEST):
3429         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3430
3431 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3432
3433         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3434         <https://webkit.org/b/194761>
3435
3436         Reviewed by Myles Maxfield.
3437
3438         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3439         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3440         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3441         to use ARC-compliant cast.
3442         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3443         ARC-compliant cast.
3444         (WTR::installFakeHelvetica): Log `error` to console if
3445         CTFontManagerRegisterFontsForURL() fails, but only on supported
3446         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3447         Call CFRelease() on `error` to fix the leak.  Update to use
3448         ARC-compliant cast.
3449         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3450         cast.
3451
3452 2019-02-21  Chris Dumez  <cdumez@apple.com>
3453
3454         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3455         https://bugs.webkit.org/show_bug.cgi?id=194481
3456
3457         Reviewed by Alex Christensen.
3458
3459         Give the processes a chance to shutdown and wait until we reached the expected number
3460         of processes.
3461
3462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3463
3464 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3465
3466         Fix the macOS build
3467
3468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3469
3470 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3471
3472         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3473
3474         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3475         I am a backwards.
3476
3477 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3478
3479         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3482         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3483         We could force on UI-side compositing, but I feel like the test might be more
3484         valuable exercising the normal path on each platform (though the original
3485         bug was also UI-side specific). Though we can't validate that the overlay
3486         layer was installed successfully, there are layout tests that do that.
3487
3488 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3489
3490         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3491         https://bugs.webkit.org/show_bug.cgi?id=194845
3492         <rdar://problem/47944579>
3493
3494         Reviewed by Antti Koivisto.
3495
3496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3497         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3498
3499 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3500
3501         [LFC][Floats] Add support for placing formatting roots in-between floats.
3502         https://bugs.webkit.org/show_bug.cgi?id=194902
3503
3504         Reviewed by Antti Koivisto.
3505
3506         * LayoutReloaded/misc/LFC-passing-tests.txt:
3507
3508 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3509
3510         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3511         https://bugs.webkit.org/show_bug.cgi?id=194901
3512
3513         Unreviewed build fix.
3514
3515         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3516         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3517         WPEBackend-fdo-0.1 as library name.
3518
3519 2019-02-21  Rob Buis  <rbuis@igalia.com>
3520
3521         Update MIME type parser
3522         https://bugs.webkit.org/show_bug.cgi?id=180526
3523
3524         Reviewed by Darin Adler.
3525
3526         Add tests involving leading and trailing whitespace, non-token
3527         characters and quoted strings.
3528
3529         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3530         (TestWebKitAPI::TEST):
3531
3532 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3533
3534         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3535         https://bugs.webkit.org/show_bug.cgi?id=194884
3536
3537         Reviewed by Michael Catanzaro.
3538
3539         * PlatformWin.cmake:
3540
3541 2019-02-20  Chris Dumez  <cdumez@apple.com>
3542
3543         Add API test for <rdar://problem/47471222>
3544         https://bugs.webkit.org/show_bug.cgi?id=194847
3545
3546         Reviewed by Alex Christensen.
3547
3548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3549
3550 2019-02-20  Chris Dumez  <cdumez@apple.com>
3551
3552         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3553         https://bugs.webkit.org/show_bug.cgi?id=194872
3554         <rdar://problem/47924500>
3555
3556         Reviewed by Alex Christensen.
3557
3558         Add API test coverage.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3561
3562 2019-02-20  Jer Noble  <jer.noble@apple.com>
3563
3564         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3565         https://bugs.webkit.org/show_bug.cgi?id=191332
3566
3567         Reviewed by Dean Jackson.
3568
3569         * Scripts/git-is-in-range: Added.
3570
3571 2019-02-20  Andy Estes  <aestes@apple.com>
3572
3573         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3574         https://bugs.webkit.org/show_bug.cgi?id=194869
3575
3576         Rubber-stamped by Jer Noble.
3577
3578         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3579         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3580         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3581         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3583         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3584
3585 2019-02-20  Chris Dumez  <cdumez@apple.com>
3586
3587         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3588         https://bugs.webkit.org/show_bug.cgi?id=194857
3589         <rdar://problem/47759323>
3590
3591         Reviewed by Alex Christensen.
3592
3593         Add API test coverage.
3594
3595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3596
3597 2019-02-20  Chris Dumez  <cdumez@apple.com>
3598
3599         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3600         https://bugs.webkit.org/show_bug.cgi?id=194829
3601         <rdar://problem/47889906>
3602
3603         Reviewed by Alexey Proskuryakov.
3604
3605         Every time the TestOptions were changing we were creating both a new Web view and
3606         a new WKContext, which would start a new Network process. In most cases, we only
3607         need to contruct a new Web view and we do can keep reusing the same WKContext.
3608         This patch implements this optimization and thus avoids spinning a lot of new
3609         Network processes while running the layout tests.
3610
3611         * WebKitTestRunner/TestController.cpp:
3612         (WTR::TestController::generateContextConfiguration const):
3613         (WTR::TestController::generatePageConfiguration):
3614         (WTR::TestController::createWebViewWithOptions):
3615         (WTR::TestController::resetPreferencesToConsistentValues):
3616         (WTR::updateTestOptionsFromTestHeader):
3617         * WebKitTestRunner/TestController.h:
3618         * WebKitTestRunner/TestOptions.h:
3619         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3620         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3621         (WTR::TestOptions::hasSameInitializationOptions const):
3622         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3623         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3624         (WTR::TestController::platformAddTestOptions const):
3625
3626 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3627
3628         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3629         https://bugs.webkit.org/show_bug.cgi?id=167941
3630
3631         Reviewed by Carlos Garcia Campos.
3632
3633         * MiniBrowser/gtk/main.c:
3634         (filterSavedCallback): Added.
3635         (main): Support loading a JSON rule set file for content filtering.
3636         * MiniBrowser/wpe/main.cpp:
3637         (filterSavedCallback): Added.
3638         (main): Support loading a JSON rule set file for content filtering.
3639         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3640         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3641         (WTF::derefGPtr): Ditto.
3642         (testEmptyStore):
3643         (testSaveInvalidFilter):
3644         (testSaveLoadFilter):
3645         (testSavedFilterIdentifierMatch):
3646         (testRemoveFilter):
3647         (testSaveMultipleFilters):
3648         (testSaveFilterFromFile):
3649         (testFilterPersistence):
3650         (beforeAll):
3651         (afterAll):
3652         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3653         (removeOldInjectedContentAndResetLists): Also reset content filters.
3654         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3655         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3656         the element affected by the style sheet.
3657         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3658         and returns it to be used by tests.
3659         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3660         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3661         (serverCallback): Add support for serving a CSS style sheet for testing.
3662         (beforeAll): Add call to testUserContentManagerContentFilter().
3663         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3664
3665 2019-02-19  Keith Rollin  <krollin@apple.com>
3666
3667         Add timing information to build output
3668         https://bugs.webkit.org/show_bug.cgi?id=194839
3669         <rdar://problem/48219609>
3670
3671         Reviewed by Alexey Proskuryakov.
3672
3673         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3674         emit each project's build time to its output. E.g.,
3675
3676             ** BUILD SUCCEEDED ** [0.132 sec]
3677
3678         * Scripts/webkitdirs.pm:
3679         (XcodeOptions):
3680
3681 2019-02-19  Truitt Savell  <tsavell@apple.com>
3682
3683         Unreviewed, rolling out r241784.
3684
3685         Broke all OpenSource builds.
3686
3687         Reverted changeset:
3688
3689         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3690         instances view"