Add support for reporting "display composited video frames" through the VideoPlayback...
[WebKit-https.git] / Tools / ChangeLog
1 2018-10-04  Jer Noble  <jer.noble@apple.com>
2
3         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4         https://bugs.webkit.org/show_bug.cgi?id=190266
5
6         Reviewed by Eric Carlson.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
10         (TestWebKitAPI::TEST):
11
12 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
13
14         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
15         https://bugs.webkit.org/show_bug.cgi?id=190119
16         <rdar://problem/44767062>
17
18         Reviewed by Tim Horton.
19
20         Add a new API test that loads a document containing various rich text styles. This test moves the selection
21         around the document and checks the last set of font attributes received via the new UI delegate hook.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
25         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
26         (-[FontAttributesListener lastFontAttributes]):
27         (-[TestWKWebView selectElementWithIdentifier:]):
28         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
29         (ColorExpectation::ColorExpectation):
30         (ShadowExpectation::ShadowExpectation):
31         (checkColor):
32         (checkShadow):
33         (checkFont):
34         (webViewForTestingFontAttributes):
35         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
36
37 2018-10-04  Alan Coon  <alancoon@apple.com>
38
39         Unreviewed, add self as contributor.
40
41         * Scripts/webkitpy/common/config/contributors.json:
42
43 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
44
45         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
46         https://bugs.webkit.org/show_bug.cgi?id=190289
47         <rdar://problem/45020806>
48
49         Reviewed by Ryosuke Niwa.
50
51         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
52         attributes at the current selection.
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
56         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
57         (webViewForFontManagerTesting):
58         (TestWebKitAPI::TEST):
59         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
60         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
61
62         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
63         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
64         foreground colors, and background colors.
65
66         (sharedFontOptionsForTesting):
67         (+[TestFontOptions sharedInstance]):
68         (-[TestFontOptions initWithFontOptions:]):
69         (-[TestFontOptions selectedAttributes]):
70         (-[TestFontOptions fontOptions]):
71         (-[TestFontOptions shadowWidth]):
72         (-[TestFontOptions setShadowWidth:]):
73         (-[TestFontOptions shadowHeight]):
74         (-[TestFontOptions setShadowHeight:]):
75         (-[TestFontOptions setShadowBlurRadius:]):
76         (-[TestFontOptions setHasShadow:]):
77         (-[TestFontOptions foregroundColor]):
78         (-[TestFontOptions setForegroundColor:]):
79         (-[TestFontOptions backgroundColor]):
80         (-[TestFontOptions setBackgroundColor:]):
81         (-[TestFontOptions _dispatchFontAttributeChanges]):
82         (-[TestFontOptions convertAttributes:]):
83         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
84         (-[TestFontOptions forwardInvocation:]):
85
86 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
87
88         [WebAuthN] Move time out control from WebProcess to UIProcess
89         https://bugs.webkit.org/show_bug.cgi?id=189642
90         <rdar://problem/44476765>
91
92         Reviewed by Chris Dumez.
93
94         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
95         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
96
97 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
98
99         Runtime flag and IDL for MediaRecorder
100         https://bugs.webkit.org/show_bug.cgi?id=190018
101
102         Reviewed by Youenn Fablet and Chris Dumez.
103
104         * DumpRenderTree/mac/DumpRenderTree.mm:
105         (enableExperimentalFeatures):
106
107 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
108
109         [LayoutTests][Win] Stop wpt server correctly.
110         https://bugs.webkit.org/show_bug.cgi?id=190248
111
112         Reviewed by Fujii Hironori.
113
114         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
115         Also refactoring the detection of Windows and cygwin environment check.
116
117         * Scripts/webkitpy/common/system/executive.py:
118         (Executive.__init__): Check environment once.
119         (Executive._should_close_fds):
120         (Executive.kill_process):
121         (Executive.check_running_pid):
122         (Executive.running_pids):
123         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
124         (Executive.kill_all):
125         (Executive._child_process_encoding):
126         (Executive._should_encode_child_process_arguments):
127         (Executive.popen):
128         (Executive.run_in_parallel):
129
130 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
131
132         Convert tests to use navigation client
133         https://bugs.webkit.org/show_bug.cgi?id=190153
134
135         Reviewed by Alex Christensen.
136
137         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
138
139         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
140         (TestWebKitAPI::decidePolicyForNavigationAction):
141         (TestWebKitAPI::setPagePolicyClient):
142         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
143         (TestWebKitAPI::didCommitNavigationCallback):
144         (TestWebKitAPI::TEST):
145         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
146
147 2018-10-03  Dan Bernstein  <mitz@apple.com>
148
149         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
150         https://bugs.webkit.org/show_bug.cgi?id=190270
151
152         Reviewed by Wenson Hsieh.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
155         (TestWebKitAPI::TEST):
156
157 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
158
159         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
160         https://bugs.webkit.org/show_bug.cgi?id=190238
161
162         Reviewed by Antti Koivisto.
163
164         * DumpRenderTree/TestOptions.h:
165         * DumpRenderTree/mac/DumpRenderTree.mm:
166         (resetWebPreferencesToConsistentValues):
167
168 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
169
170         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
171         https://bugs.webkit.org/show_bug.cgi?id=179787
172         <rdar://problem/35593389>
173
174         Reviewed by Tim Horton.
175
176         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
177         menu items.
178
179         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
180         (webViewForFontManagerTesting):
181         (menuItemCellForFontAction):
182         (TestWebKitAPI::TEST):
183
184 2018-10-02  Chris Dumez  <cdumez@apple.com>
185
186         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
187         https://bugs.webkit.org/show_bug.cgi?id=190176
188         <rdar://problem/44925871>
189
190         Reviewed by Alex Christensen.
191
192         Use a URL that is truly recognized as invalid by WebCore's URL parser.
193
194         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
195         (TEST):
196
197 2018-10-02  Alex Christensen  <achristensen@webkit.org>
198
199         Remove ParsedURLString
200         https://bugs.webkit.org/show_bug.cgi?id=190154
201
202         Reviewed by Chris Dumez.
203
204         * TestWebKitAPI/Tests/WebCore/URL.cpp:
205         (TestWebKitAPI::TEST_F):
206         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
207         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
208         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
209         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
210         (TestWebKitAPI::TEST):
211
212 2018-10-02  Daniel Bates  <dabates@apple.com>
213
214         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
215         (https://bugs.webkit.org/show_bug.cgi?id=190017)
216
217         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
218             WKWebViewAutofillTests.AutofillRequiresInputSession
219             DragAndDropTests.ExternalSourceJPEGOnly
220             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
221
222         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
223         we will look to swizzle this method for all test by default.
224
225         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
226         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
227         (TestWebKitAPI::TEST):
228         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
229         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/ios/UIKitSPI.h:
232
233 2018-10-02  Dawei Fenton  <realdawei@apple.com>
234
235         Unreviewed, rolling out r236751.
236
237         broke the iOS Build
238
239         Reverted changeset:
240
241         "Fix iOS TestWebKitAPI failures following
242         <https://trac.webkit.org/changeset/236619>"
243         https://bugs.webkit.org/show_bug.cgi?id=190017
244         https://trac.webkit.org/changeset/236751
245
246 2018-10-02  Daniel Bates  <dabates@apple.com>
247
248         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
249         (https://bugs.webkit.org/show_bug.cgi?id=190017)
250
251         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
252             WKWebViewAutofillTests.AutofillRequiresInputSession
253             DragAndDropTests.ExternalSourceJPEGOnly
254             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
255
256         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
257         we will look to swizzle this method for all test by default.
258
259         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
260         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
263         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/ios/UIKitSPI.h:
266
267 2018-10-01  Dean Jackson  <dino@apple.com>
268
269         Remove CSS Animation Triggers
270         https://bugs.webkit.org/show_bug.cgi?id=190175
271         <rdar://problem/44925626>
272
273         Reviewed by Simon Fraser.
274
275         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
276
277 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
278
279         [Flatpak] Use our own check of flatpak repos
280         https://bugs.webkit.org/show_bug.cgi?id=190194
281
282         Allowing us to not mess up with user installation
283         and "--assumeyes" everywhere.
284
285         Reviewed by Michael Catanzaro.
286
287         * flatpak/flatpakutils.py:
288         (FlatpakPackage.__init__):
289         (FlatpakPackage.install):
290         (FlatpakPackage.update):
291         (WebkitFlatpak.load_from_args):
292         (WebkitFlatpak.__init__):
293         (WebkitFlatpak.clean_args):
294
295 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
296
297         [macOS] Implement a way for the UI process to request typing attributes at the current selection
298         https://bugs.webkit.org/show_bug.cgi?id=189983
299         <rdar://problem/44648705>
300
301         Reviewed by Ryosuke Niwa.
302
303         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
304
305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
306         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
307         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
308
309         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
310         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
311         additionally check that shadowed text and strike-through are reflected in typing attributes.
312
313         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
314         (-[TestWKWebView typingAttributes]):
315
316         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
317
318         (-[TestWKWebView collapseToStart]):
319         (webViewForFontManagerTesting):
320         (TestWebKitAPI::TEST):
321         * TestWebKitAPI/cocoa/TestWKWebView.h:
322         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
323         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
324
325         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
326
327         (-[TestInspectorBarItemController initWithInspectorBar:]):
328         (-[TestInspectorBarItemController inspectorBar]):
329         (-[TestInspectorBarItemController updateSelectedAttributes]):
330         (-[TestInspectorBar initWithWebView:]):
331         (+[TestInspectorBar standardItemControllerClass]):
332         (+[TestInspectorBar standardTextItemIdentifiers]):
333         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
334         (-[TestInspectorBar chooseFontSize:]):
335         (-[TestInspectorBar chooseFontFamily:]):
336         (-[TestInspectorBar _chooseColor:inColorWell:]):
337         (-[TestInspectorBar chooseForegroundColor:]):
338         (-[TestInspectorBar chooseBackgroundColor:]):
339         (-[TestInspectorBar formatBold:]):
340         (-[TestInspectorBar formatItalic:]):
341         (-[TestInspectorBar formatUnderline:]):
342
343         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
344         styling controls).
345
346         (-[TestInspectorBar itemController]):
347         (-[TestInspectorBar setItemController:]):
348
349 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
350
351         [Flatpak] Implement icecream and ccache support
352         https://bugs.webkit.org/show_bug.cgi?id=190146
353
354         Reviewed by Alejandro G. Castro.
355
356         * flatpak/flatpakutils.py:
357         (WebkitFlatpak.load_from_args):
358         (WebkitFlatpak.__init__):
359         (WebkitFlatpak.clean_args):
360         (WebkitFlatpak.run_in_sandbox):
361         (WebkitFlatpak.save_config):
362         (WebkitFlatpak):
363         (WebkitFlatpak.setup_ccache):
364         (WebkitFlatpak.setup_icecc):
365         (WebkitFlatpak.setup_dev_env):
366         * flatpak/org.webkit.WebKit.yaml:
367
368 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
369
370         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
371
372         * WebKitTestRunner/TestController.cpp:
373         (WTR::TestController::keyExistsInKeychain):
374
375 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
376
377         [WinCairo] Enable WPT tests environment.
378         https://bugs.webkit.org/show_bug.cgi?id=190128
379
380         Reviewed by Youenn Fablet.
381
382         Escaping backslash of the path not to confuse the JSON parser.
383
384         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
385         (WebPlatformTestServer._prepare_config):
386
387 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
388
389         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
390         https://bugs.webkit.org/show_bug.cgi?id=190150
391
392         Reviewed by Fujii Hironori.
393
394         * DumpRenderTree/win/DumpRenderTree.cpp:
395         (setWebPreferencesForTestOptions):
396         DRT has been recognizing this field, but not propagating its value to WebPreferences.
397
398 2018-10-01  Alex Christensen  <achristensen@webkit.org>
399
400         Unreviewed, rolling out r236551.
401
402         Fails URL validating too aggressively
403
404         Reverted changeset:
405
406         "URLWithUserTypedString should return nil for URLs deemed to
407         be invalid by WebCore::URL"
408         https://bugs.webkit.org/show_bug.cgi?id=189979
409         https://trac.webkit.org/changeset/236551
410
411 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
412
413         [iOS] Add SPI to customize the input accessory view when focusing an element
414         https://bugs.webkit.org/show_bug.cgi?id=190152
415         <rdar://problem/42754975>
416
417         Reviewed by Dan Bernstein.
418
419         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
420         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
421         `-inputAccessoryView`.
422
423         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
424         (webViewWithAutofocusedInput):
425         (TestWebKitAPI::TEST):
426         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
427         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
428         (-[TestInputDelegate setWillStartInputSessionHandler:]):
429         (-[TestInputDelegate willStartInputSessionHandler]):
430         (-[TestInputDelegate _webView:willStartInputSession:]):
431
432 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
433
434         Remove StorageProcess
435         https://bugs.webkit.org/show_bug.cgi?id=189975
436
437         Reviewed by Geoffrey Garen.
438
439         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
440         (TEST):
441         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
442         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
443         (TEST):
444         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
445         (TEST):
446         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
447         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
448         (WTR::TestRunner::terminateStorageProcess): Deleted.
449         * WebKitTestRunner/InjectedBundle/TestRunner.h:
450         * WebKitTestRunner/TestController.cpp:
451         (WTR::TestController::generatePageConfiguration):
452         (WTR::TestController::databaseProcessName): Deleted.
453         (WTR::TestController::databaseProcessDidCrash): Deleted.
454         (WTR::TestController::terminateStorageProcess): Deleted.
455         * WebKitTestRunner/TestController.h:
456         * WebKitTestRunner/TestInvocation.cpp:
457         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
458
459 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
460
461         [WebAuthN] Import a JS CBOR coder
462         https://bugs.webkit.org/show_bug.cgi?id=189877
463         <rdar://problem/44701124>
464
465         Reviewed by Chris Dumez.
466
467         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
468         only if acceptAttestation is true.
469
470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
471         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
472
473 2018-10-01  Chris Dumez  <cdumez@apple.com>
474
475         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
476         https://bugs.webkit.org/show_bug.cgi?id=190052
477
478         Reviewed by Ryosuke Niwa.
479
480         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
481         to log those events. It also uses console.log() before sending those events to indicate what the test is about
482         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
483         so that it can log the message.
484         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
485         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
486         handler to be transformed into synchronous IPC.
487         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
488         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
489         messages may end up being out of order, leading to flakiness.
490
491         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
492         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
493         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
494
495         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
496         (WTR::InjectedBundle::outputText):
497
498 2018-10-01  Daniel Bates  <dabates@apple.com>
499
500         [iOS] Special keys are misidentified in DOM keyboard events
501         https://bugs.webkit.org/show_bug.cgi?id=189974
502
503         Reviewed by Wenson Hsieh.
504
505         Add support for testing keys Forward Delete and Num Lock / Clear.
506
507         * WebKitTestRunner/ios/HIDEventGenerator.mm:
508         (hidUsageCodeForCharacter):
509
510 2018-10-01  Alex Christensen  <achristensen@webkit.org>
511
512         URL should not use TextEncoding internally
513         https://bugs.webkit.org/show_bug.cgi?id=190111
514
515         Reviewed by Andy Estes.
516
517         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
518         (TestWebKitAPI::testUserPass):
519         (TestWebKitAPI::TEST_F):
520
521 2018-10-01  Daniel Bates  <dabates@apple.com>
522
523         LLDB tests may use wrong configuration of lldbWebKitTester
524         https://bugs.webkit.org/show_bug.cgi?id=189011
525
526         Reviewed by Dean Jackson.
527
528         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
529         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
530
531         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
532         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
533         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
534         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
535         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
536         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
537         the Python unittest module, the Python multiprocessing module, and the general principle of unit
538         tests - to test code in isolation). The unit tests make use of the value of this environment
539         variable to launch lldbWebKitTester binary.
540
541         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
542         out if this script is invoked for a non-Mac platform.
543         * Scripts/webkitpy/test/main.py:
544         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
545         LLDB_WEBKIT_TESTER_EXECUTABLE.
546         (_build_lldb_webkit_tester): Deleted.
547         * lldb/dump_class_layout_unittest.py:
548         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
549         this is the only call site that needs the Host object now.
550         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
551         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
552         * lldb/lldbWebKitTester/main.cpp:
553         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
554         * lldb/lldb_webkit_unittest.py:
555         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
556         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
557         (TestSummaryProviders):
558         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
559         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
560         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
561         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
562         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
563         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
564         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
565
566 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
567
568         [WPE] Update install-dependencies
569         https://bugs.webkit.org/show_bug.cgi?id=190127
570
571         Reviewed by Michael Catanzaro.
572
573         * wpe/install-dependencies:
574         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
575         It is used by gstvaapidisplay_x11.c.
576         Add it only for Apt, already ok for Pacman and DNF.
577
578         Install libevent-dev for WebRTC (like GTK)
579
580         Install libasound2-dev for WebRTC.
581         Add it only for Apt, already ok for Pacam and DNF.
582
583         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
584
585 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
586
587         [Flatpak] Add libunwind in the sandbox
588         https://bugs.webkit.org/show_bug.cgi?id=190123
589
590         Allowing us to get proper traces in GStreamer trace grabing
591         debug functions.
592
593         Reviewed by Philippe Normand.
594
595         * flatpak/org.webkit.WebKit.yaml:
596
597 2018-09-29  Commit Queue  <commit-queue@webkit.org>
598
599         Unreviewed, rolling out r236631.
600         https://bugs.webkit.org/show_bug.cgi?id=190112
601
602         Caused various eventSender tests, including fast/css/pseudo-
603         active-style-sharing*, to fail (Requested by smfr on #webkit).
604
605         Reverted changeset:
606
607         "Regression(r236512): http/tests/navigation/keyboard-events-
608         during-provisional-navigation.html is flaky"
609         https://bugs.webkit.org/show_bug.cgi?id=190052
610         https://trac.webkit.org/changeset/236631
611
612 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
613
614         [WHLSL] Fix build after r236635
615         https://bugs.webkit.org/show_bug.cgi?id=189210
616
617         Unreviewed.
618
619         * WebGPUShadingLanguageRI/Intrinsics.js:
620         (Intrinsics.):
621         * WebGPUShadingLanguageRI/Test.js:
622         (tests.atomicsNull):
623         (tests.numThreads):
624         (tests.textureDimensionsNull):
625
626 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
627
628         [WHLSL] Allow uniform buffers to be used in the interpreter
629         https://bugs.webkit.org/show_bug.cgi?id=189210
630
631         Reviewed by Filip Pizlo.
632
633         Every lvalue is associated with an address space, and the propagation of these address spaces
634         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
635         of this, so this patch just goes the last few yards. It also updates the standard library to
636         allow for writing into all writable address spaces for out-params.
637
638         * WebGPUShadingLanguageRI/Checker.js:
639         (Checker.prototype.visitAssignment):
640         (Checker.prototype._finishVisitingPropertyAccess):
641         * WebGPUShadingLanguageRI/Intrinsics.js:
642         (Intrinsics.):
643         (Intrinsics.checkFalse):
644         (Intrinsics):
645         * WebGPUShadingLanguageRI/StandardLibrary.js:
646         (let.standardLibrary):
647         * WebGPUShadingLanguageRI/Test.js:
648         (tests.threadArrayRefLoad):
649         (tests.threadArrayRefLoadIntLiteral):
650         (tests.deviceArrayRefLoad):
651         (tests.threadArrayRefStore):
652         (tests.deviceArrayRefStore):
653         (tests.deviceArrayRefStoreIntLiteral):
654         (tests.threadPointerLoad):
655         (tests.threadPointerStore):
656         (tests.devicePointerLoad):
657         (tests.devicePointerStore):
658         (tests.arrayLoad):
659         (tests.constantAddressSpace):
660         (tests.standardLibraryDevicePointers):
661         (tests.threadArrayLoad): Deleted.
662         (tests.threadArrayLoadIntLiteral): Deleted.
663         (tests.deviceArrayLoad): Deleted.
664         (tests.threadArrayStore): Deleted.
665         (tests.deviceArrayStore): Deleted.
666         (tests.deviceArrayStoreIntLiteral): Deleted.
667
668 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
669
670         No DOM API to instantiate an attachment for an img element
671         https://bugs.webkit.org/show_bug.cgi?id=189934
672         <rdar://problem/44743222>
673
674         Reviewed by Ryosuke Niwa.
675
676         Adds 3 new API tests in WKAttachmentTests:
677
678         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
679         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
680
681         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
682         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
683
684         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
685         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
686         then result in an image element with the contents of the _WKAttachment's file wrapper.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
689         (-[TestWKWebView imageElementSize]):
690         (-[TestWKWebView waitForImageElementSizeToBecome:]):
691         (TestWebKitAPI::TEST):
692         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
693
694 2018-09-28  Chris Dumez  <cdumez@apple.com>
695
696         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
697         https://bugs.webkit.org/show_bug.cgi?id=190052
698
699         Reviewed by Ryosuke Niwa.
700
701         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
702         to log those events. It also uses console.log() before sending those events to indicate what the test is about
703         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
704         so that it can log the message.
705         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
706         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
707         handler to be transformed into synchronous IPC.
708         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
709         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
710         messages may end up being out of order, leading to flakiness.
711
712         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
713         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
714         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
715
716         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
717         (WTR::InjectedBundle::outputText):
718
719 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
720
721         [WHLSL] Pointers should have automatically-generated equality checks
722         https://bugs.webkit.org/show_bug.cgi?id=189986
723
724         Reviewed by Filip Pizlo.
725
726         C allows for pointer equality, and we need it so people can do null checks.
727         This is generated the same way all our other NativeFuncs are generated - by Checker
728         creating NativeFuncs inside CallExpression.resolve().
729
730         This patch also does some general cleanup.
731
732         * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
733         The last thing it was doing was making sure that only primitive types are in resources, but
734         it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
735         still have to add a check to make sure resources can't live within resources, but I expect
736         that will be done in the same place that semantics are checked.
737         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
738         (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
739         Name the global struct for debugging purposes.
740         * WebGPUShadingLanguageRI/CallExpression.js: 
741         (CallExpression.prototype._resolveByInstantiation): Cleanup
742         (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
743         (CallExpression.prototype._resolveWithOperatorLength): Ditto
744         (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
745         generate pointer equality NativeFuncs.
746         * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
747         * WebGPUShadingLanguageRI/LateChecker.js: Removed.
748         * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
749         (layoutBuffers):
750         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
751         * WebGPUShadingLanguageRI/NativeFunc.js:
752         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
753         (OperatorArrayRefLength.prototype.instantiateImplementation):
754         (OperatorArrayRefLength):
755         * WebGPUShadingLanguageRI/Prepare.js:
756         (let.prepare):
757         * WebGPUShadingLanguageRI/SPIRV.html:
758         * WebGPUShadingLanguageRI/Test.html:
759         * WebGPUShadingLanguageRI/Test.js:
760         (tests.ternaryExpression):
761         (tests.break): Speed up testing time
762         (tests.doWhile): Ditto
763         (tests.forLoop): Ditto
764         (tests.atomics): Ditto
765         (tests.atomicsNull): Ditto
766         (tests.pointerEquality): Test pointer equality
767         (tests.standardLibraryDevicePointers):
768         (tests.devicePtrPtr): Deleted.
769         (tests.threadgroupPtrPtr): Deleted.
770         (tests.constantPtrPtr): Deleted.
771         * WebGPUShadingLanguageRI/index.html:
772
773 2018-09-28  Jiewen Tan  <jiewen_tan@apple.com>
774
775         [WebAuthN] Polish WebAuthN auto-test environment
776         https://bugs.webkit.org/show_bug.cgi?id=189283
777         <rdar://problem/44117828>
778
779         Reviewed by Chris Dumez.
780
781         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
782         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
783
784 2018-09-28  Chris Dumez  <cdumez@apple.com>
785
786         Drop support for cross-origin-window-policy header
787         https://bugs.webkit.org/show_bug.cgi?id=190081
788
789         Reviewed by Ryosuke Niwa.
790
791         190081_DropCrossOriginWindowPolicy
792
793         * DumpRenderTree/mac/DumpRenderTree.mm:
794         (enableExperimentalFeatures):
795         * DumpRenderTree/win/DumpRenderTree.cpp:
796         (enableExperimentalFeatures):
797         * WebKitTestRunner/TestController.cpp:
798         (WTR::TestController::resetPreferencesToConsistentValues):
799
800 2018-09-28  Koby Boyango  <koby.b@mce.systems>
801
802         [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
803         https://bugs.webkit.org/show_bug.cgi?id=189991
804
805         Reviewed by Yusuke Suzuki.
806
807         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
808
809 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
810
811         Update flakiness dashboard configuration for Mojave queues
812         https://bugs.webkit.org/show_bug.cgi?id=190068
813
814         Reviewed by Alexey Proskuryakov.
815
816         * TestResultServer/static-dashboards/builders.jsonp:
817
818 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
819
820         Bring up queues for Mojave
821         https://bugs.webkit.org/show_bug.cgi?id=189935
822
823         Unreviewed infrastructure fix.
824
825         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
826
827 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
828
829         Bring up queues for Mojave
830         https://bugs.webkit.org/show_bug.cgi?id=189935
831
832         Reviewed by Alexey Proskuryakov.
833
834         * BuildSlaveSupport/build.webkit.org-config/config.json:
835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
836         (WebKitBuildbot):
837         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
838
839 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
840
841         Increase the timeout for iOS Simulator data migration
842         https://bugs.webkit.org/show_bug.cgi?id=190059
843
844         Reviewed by Aakash Jain.
845
846         3 minutes isn't always enough time for the data migrator to complete
847         when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
848
849         * Scripts/webkitpy/xcode/simulated_device.py:
850         (SimulatedDeviceManager): Create a constant for the default timeout.
851         (SimulatedDeviceManager.initialize_devices): Use new constant.
852         (SimulatedDeviceManager.swap): Ditto.
853         (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
854
855 2018-09-27  Alex Christensen  <achristensen@webkit.org>
856
857         URLParser should use TextEncoding through an abstract class
858         https://bugs.webkit.org/show_bug.cgi?id=190027
859
860         Reviewed by Andy Estes.
861
862         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
863         (TestWebKitAPI::checkURL):
864         (TestWebKitAPI::TEST_F):
865
866 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
867
868         iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
869         https://bugs.webkit.org/show_bug.cgi?id=190042
870
871         Reviewed by Aakash Jain.
872
873         To make iOS Simulator bots resilient to issues that can arise from reusing
874         existing simulators, ensure that dedicated simulators are created for each test run.
875
876         * Scripts/webkitpy/common/config/ports.py:
877         (IOSSimulatorWK2Port.run_webkit_tests_command):
878
879 2018-09-27  Alex Christensen  <achristensen@webkit.org>
880
881         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
882         https://bugs.webkit.org/show_bug.cgi?id=189979
883
884         Reviewed by Youenn Fablet.
885
886         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
887         (TestWebKitAPI::originalDataAsString):
888         (TestWebKitAPI::TEST):
889
890 2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
891
892         [Win][WebKit] Implement authentication dialog on MiniBrowser.
893         https://bugs.webkit.org/show_bug.cgi?id=189846
894
895         Reviewed by Fujii Hironori.
896
897         It was implemented for WebKitLegacy, but not for WebKit.
898         Also added text field to display Realm information.
899
900         * MiniBrowser/win/Common.cpp:
901         (authDialogProc):
902         (askCredential):
903         (displayAuthDialog): Deleted.
904         * MiniBrowser/win/Common.h:
905         * MiniBrowser/win/MiniBrowserLib.rc:
906         * MiniBrowser/win/MiniBrowserLibResource.h:
907         * MiniBrowser/win/ResourceLoadDelegate.cpp:
908         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
909         * MiniBrowser/win/WebKitBrowserWindow.cpp:
910         (createString):
911         (createUTF8String):
912         (createWKString):
913         (createWKURL):
914         (WebKitBrowserWindow::WebKitBrowserWindow):
915         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
916         (toNullTerminatedUTF8): Deleted.
917         * MiniBrowser/win/WebKitBrowserWindow.h:
918
919 2018-09-27  Youenn Fablet  <youenn@apple.com>
920
921         Enable getUserMedia in mini browser
922         https://bugs.webkit.org/show_bug.cgi?id=190012
923
924         Reviewed by Eric Carlson.
925
926         Enable MediaDevices and mock capture devices.
927         Grant mock devices access to any getUserMedia call.
928         Covered by manual testing.
929
930         * MiniBrowser/mac/AppDelegate.m:
931         (defaultConfiguration):
932         * MiniBrowser/mac/WK2BrowserWindowController.m:
933         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
934         (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
935
936 2018-09-27  Antoine Quint  <graouts@apple.com>
937
938         [Web Animations] Turn Web Animations with CSS integration on
939         https://bugs.webkit.org/show_bug.cgi?id=184819
940         <rdar://problem/39597337>
941
942         Reviewed by Dean Jackson.
943
944         * DumpRenderTree/TestOptions.h:
945
946 2018-09-26  Alex Christensen  <achristensen@webkit.org>
947
948         Unreviewed, rolling out r236524.
949
950         Broke API tests
951
952         Reverted changeset:
953
954         "URLWithUserTypedString should return nil for URLs deemed to
955         be invalid by WebCore::URL"
956         https://bugs.webkit.org/show_bug.cgi?id=189979
957         https://trac.webkit.org/changeset/236524
958
959 2018-09-26  James Savage  <james.savage@apple.com>
960
961         Allow override of viewport configuration.
962         https://bugs.webkit.org/show_bug.cgi?id=188772.
963         <rdar://problem/43538892>.
964
965         Reviewed by Simon Fraser.
966
967         * WebKitTestRunner/TestController.cpp:
968         (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
969         * WebKitTestRunner/TestOptions.h:
970         * WebKitTestRunner/ios/TestControllerIOS.mm:
971         (WTR::TestController::platformConfigureViewForTest): Handle new test option by
972         modifying the web view's preferences accordingly.
973
974 2018-09-26  Alex Christensen  <achristensen@webkit.org>
975
976         URLs with mismatched surrogate pairs in the host should fail to parse
977         https://bugs.webkit.org/show_bug.cgi?id=190005
978
979         Reviewed by Chris Dumez.
980
981         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
982         (TestWebKitAPI::TEST_F):
983
984 2018-09-26  Alex Christensen  <achristensen@webkit.org>
985
986         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
987         https://bugs.webkit.org/show_bug.cgi?id=189979
988         <rdar://problem/44119696>
989
990         Reviewed by Chris Dumez.
991
992         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
993         (TestWebKitAPI::TEST):
994
995 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
996
997         Selection should work across shadow boundary when initiated by a mouse drag
998         https://bugs.webkit.org/show_bug.cgi?id=151380
999         <rdar://problem/24363872>
1000
1001         Reviewed by Wenson Hsieh.
1002
1003         Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
1004
1005         * DumpRenderTree/TestOptions.cpp:
1006         (TestOptions::TestOptions):
1007         * DumpRenderTree/TestOptions.h:
1008         * DumpRenderTree/mac/DumpRenderTree.mm:
1009         (resetWebPreferencesToConsistentValues):
1010         (setWebPreferencesForTestOptions):
1011
1012 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1013
1014         MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
1015         https://bugs.webkit.org/show_bug.cgi?id=189989
1016
1017         Reviewed by Simon Fraser.
1018
1019         When the preference isn't found in user defaults, use the default value of each feature's enabledness.
1020
1021         * MiniBrowser/mac/AppDelegate.m:
1022         (defaultConfiguration):
1023
1024 2018-09-26  Philippe Normand  <pnormand@igalia.com>
1025
1026         [Flatpak] Bump to apr 1.6.5
1027
1028         Version 1.6.3 is no longer available on Apache's website.
1029
1030         Rubber-stamped by Michael Catanzaro.
1031
1032         * flatpak/org.webkit.WebKit.yaml:
1033
1034 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
1035
1036         [WebAuthN] Make AuthenticatorManager
1037         https://bugs.webkit.org/show_bug.cgi?id=189279
1038         <rdar://problem/44116792>
1039
1040         Reviewed by Chris Dumez.
1041
1042         Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
1043         added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
1044
1045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1046         * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
1047         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1048         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1049         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1050         (WTR::TestRunner::addTestKeyToKeychain):
1051         (WTR::TestRunner::cleanUpKeychain):
1052         (WTR::TestRunner::isKeyExisted):
1053         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1054         * WebKitTestRunner/TestController.cpp:
1055         (WTR::TestController::addTestKeyToKeychain):
1056         (WTR::TestController::cleanUpKeychain):
1057         (WTR::TestController::isKeyExisted):
1058         (WTR::TestController::setWebAuthenticationMockConfiguration):
1059         * WebKitTestRunner/TestController.h:
1060         * WebKitTestRunner/TestInvocation.cpp:
1061         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1062         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1063         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1064         (WTR::TestController::addTestKeyToKeychain):
1065         (WTR::TestController::cleanUpKeychain):
1066         (WTR::TestController::keyExistedInKeychain):
1067
1068 2018-09-25  Sihui Liu  <sihui_liu@apple.com>
1069
1070         Move Service Worker Management from Storage Process to Network Process
1071         https://bugs.webkit.org/show_bug.cgi?id=189422
1072
1073         Reviewed by Youenn Fablet.
1074
1075         Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
1076         launched during service worker operations now.
1077
1078         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1079
1080 2018-09-25  Eric Carlson  <eric.carlson@apple.com>
1081
1082         [MediaStream] Update constraints supported by getDisplayMedia
1083         https://bugs.webkit.org/show_bug.cgi?id=189930
1084         <rdar://problem/44740305>
1085
1086         Unreviewed, fix test broken by r236465.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1089         (TestWebKitAPI::TEST_F):
1090
1091 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
1092
1093         [WHSL] Implement semantics
1094         https://bugs.webkit.org/show_bug.cgi?id=189134
1095
1096         Reviewed by Filip Pizlo.
1097
1098         This patch adds parsing support and adds the checks required to support HLSL-style semantics.
1099
1100         There are 3 places where semantics are allowed:
1101
1102         1. In a field in a struct. E.g.
1103
1104         struct R {
1105             float4 position : SV_Position;
1106         }
1107         vertex R foo() {
1108             ...
1109         }
1110
1111         2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
1112
1113         compute void foo(device float[] data : buffer(u0)) {
1114             ...
1115         }
1116
1117         3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
1118
1119         vertex float4 foo() : SV_Position {
1120             ...
1121         }
1122
1123         The semantics are partitioned into 4 types:
1124
1125         1. Built-in variables. For example, : SV_Position.
1126         2. Resources. For example, : register(u0).
1127         3. Stage-in / stage-out variables. For example, : attribute(0).
1128         4. Specialization constants. For example, : specialized.
1129
1130         The semantics are validated according to a collection of rules:
1131
1132         - The same entry point can't list the same semantic twice
1133         - Each built-in type has an appropriate type that is listed in the spec. 
1134         - Each built-in is appropriate as either an input or an output of a particular shader stage
1135         - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
1136         - Resources can't be output from entry points
1137         - The resource semantic mode must match the address space of the resource
1138         - Stage-in and stage-out variables have to be POD
1139         - Specialization constants can't be output from entry points, and have to be numbers
1140
1141         * WebGPUShadingLanguageRI/All.js:
1142         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
1143         (BuiltInSemantic):
1144         (BuiltInSemantic.prototype.get name):
1145         (BuiltInSemantic.prototype.get extraArguments):
1146         (BuiltInSemantic.prototype.isAcceptableType):
1147         (BuiltInSemantic.prototype.isAcceptableForShaderType):
1148         (BuiltInSemantic.prototype.toString):
1149         * WebGPUShadingLanguageRI/CallExpression.js:
1150         (CallExpression.prototype._resolveWithOperatorAnderIndexer):
1151         (CallExpression.prototype._resolveWithOperatorLength):
1152         * WebGPUShadingLanguageRI/Checker.js:
1153         (Checker):
1154         (Checker.prototype.visitProgram):
1155         (Checker.prototype._checkSemantics.Item):
1156         (Checker.prototype._checkSemantics.Item.prototype.get type):
1157         (Checker.prototype._checkSemantics.Item.prototype.get semantic):
1158         (Checker.prototype._checkSemantics.Gatherer):
1159         (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
1160         (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
1161         (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
1162         (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
1163         (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
1164         (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
1165         (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
1166         (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
1167         (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
1168         (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
1169         (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
1170         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
1171         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
1172         (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
1173         (Checker.prototype._checkSemantics.checkDuplicateSemantics):
1174         (Checker.prototype._checkSemantics.checkSemanticTypes):
1175         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
1176         (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
1177         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
1178         (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
1179         (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
1180         (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
1181         (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
1182         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
1183         (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
1184         (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
1185         (Checker.prototype._checkSemantics.PODChecker):
1186         (Checker.prototype._checkSemantics.checkPODData):
1187         (Checker.prototype._checkSemantics):
1188         (Checker.prototype._checkShaderType):
1189         (Checker.prototype._checkOperatorOverload):
1190         (Checker.prototype.visitFuncDef):
1191         (Checker.prototype.visitEnumType):
1192         (Checker.prototype.visitArrayType):
1193         (Checker.prototype.visitMakePtrExpression):
1194         (Checker.prototype.visitMakeArrayRefExpression):
1195         (Checker.prototype._finishVisitingPropertyAccess):
1196         (Checker.prototype.visitIndexExpression):
1197         (Checker.prototype.visitReturn):
1198         (Checker.prototype.visitSwitchStatement):
1199         (Checker.prototype.visitTernaryExpression):
1200         (Checker.prototype.visitCallExpression):
1201         * WebGPUShadingLanguageRI/Field.js:
1202         (Field):
1203         (Field.prototype.get semantic):
1204         (Field.prototype.toString):
1205         * WebGPUShadingLanguageRI/Func.js:
1206         (Func):
1207         (Func.prototype.get semantic):
1208         (Func.prototype.toDeclString):
1209         * WebGPUShadingLanguageRI/FuncDef.js:
1210         (FuncDef):
1211         * WebGPUShadingLanguageRI/FuncParameter.js:
1212         (FuncParameter):
1213         (FuncParameter.prototype.get semantic):
1214         (FuncParameter.prototype.toString):
1215         * WebGPUShadingLanguageRI/Intrinsics.js:
1216         * WebGPUShadingLanguageRI/LateChecker.js:
1217         (LateChecker.prototype.visitReferenceType):
1218         (LateChecker):
1219         (LateChecker.prototype._checkShaderType): Deleted.
1220         (LateChecker.prototype.visitFuncDef): Deleted.
1221         * WebGPUShadingLanguageRI/NativeFunc.js:
1222         (NativeFunc):
1223         * WebGPUShadingLanguageRI/Parse.js:
1224         (parseParameter):
1225         (parseFuncDecl):
1226         (parseFuncDef):
1227         (parseStageInOutSemantic):
1228         (parseResourceSemantic):
1229         (parseSpecializationConstantSemantic):
1230         (parseBuiltInSemantic):
1231         (parseField):
1232         (parseNativeFunc):
1233         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
1234         (programWithUnnecessaryThingsRemoved):
1235         * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
1236         (ResourceSemantic):
1237         (ResourceSemantic.prototype.get resourceMode):
1238         (ResourceSemantic.prototype.get index):
1239         (ResourceSemantic.prototype.get space):
1240         (ResourceSemantic.prototype.isAcceptableType):
1241         (ResourceSemantic.prototype.isAcceptableForShaderType):
1242         (ResourceSemantic.prototype.toString):
1243         * WebGPUShadingLanguageRI/Rewriter.js:
1244         (Rewriter.prototype.visitFuncParameter):
1245         (Rewriter.prototype.visitField):
1246         (Rewriter.prototype.visitBuiltInSemantic):
1247         (Rewriter.prototype.visitResourceSemantic):
1248         (Rewriter.prototype.visitStageInOutSemantic):
1249         (Rewriter.prototype.visitSpecializationConstantSemantic):
1250         (Rewriter):
1251         * WebGPUShadingLanguageRI/SPIRV.html:
1252         * WebGPUShadingLanguageRI/Semantic.js: Added.
1253         (Semantic):
1254         (Semantic.prototype.get origin):
1255         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
1256         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
1257         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
1258         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
1259         (Semantic.prototype.equalToOtherSemantic.Comparer):
1260         (Semantic.prototype.equalToOtherSemantic):
1261         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
1262         (SpecializationConstantSemantic):
1263         (SpecializationConstantSemantic.prototype.isAcceptableType):
1264         (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
1265         (SpecializationConstantSemantic.prototype.toString):
1266         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1267         (StageInOutSemantic):
1268         (StageInOutSemantic.prototype.get index):
1269         (StageInOutSemantic.prototype.isAcceptableType):
1270         (StageInOutSemantic.prototype.isAcceptableForShaderType):
1271         (StageInOutSemantic.prototype.toString):
1272         * WebGPUShadingLanguageRI/StatementCloner.js:
1273         (StatementCloner.prototype.visitNativeFunc):
1274         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
1275         (synthesizeArrayOperatorLength):
1276         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
1277         (synthesizeCopyConstructorOperator):
1278         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
1279         (synthesizeDefaultConstructorOperator):
1280         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
1281         (synthesizeEnumFunctions):
1282         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1283         (setupAnder):
1284         (synthesizeStructAccessorsForStructType):
1285         * WebGPUShadingLanguageRI/Test.html:
1286         * WebGPUShadingLanguageRI/Test.js:
1287         (tests.shaderTypes):
1288         * WebGPUShadingLanguageRI/Visitor.js:
1289         (Visitor.prototype.visitFunc):
1290         (Visitor.prototype.visitFuncParameter):
1291         (Visitor.prototype.visitField):
1292         (Visitor.prototype.visitBuiltInSemantic):
1293         (Visitor.prototype.visitResourceSemantic):
1294         (Visitor.prototype.visitStageInOutSemantic):
1295         (Visitor.prototype.visitSpecializationConstantSemantic):
1296         (Visitor):
1297         * WebGPUShadingLanguageRI/index.html:
1298
1299 2018-09-25  Thomas Denney  <tdenney@apple.com>
1300
1301         [WHLSL] Test suite for Metal code generation
1302         https://bugs.webkit.org/show_bug.cgi?id=187738
1303
1304         Reviewed by Myles C. Maxfield.
1305
1306         This patch adds an Xcode project that contains a Cocoa app that can be
1307         used for running WHLSL shaders on the GPU. It also contains an Xcode
1308         test suite that runs all of the tests in Test.js on the GPU.
1309
1310         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
1311         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
1312         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
1313         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
1314         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
1315         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
1316         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
1317         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
1318         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
1319         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
1320         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
1321         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
1322         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
1323         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
1324         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
1325         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
1326         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
1327         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
1328         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
1329         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
1330         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
1331         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
1332         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
1333         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
1334         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
1335         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
1336         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
1337         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
1338         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
1339         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
1340         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
1341         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
1342         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
1343         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
1344         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
1345         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
1346         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
1347         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
1348         * WebGPUShadingLanguageRI/Test.js:
1349         (tests.lotsOfLocalVariables):
1350
1351 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
1352
1353         Unreviewed build fix after r236455
1354         https://bugs.webkit.org/show_bug.cgi?id=189121
1355
1356         * WebGPUShadingLanguageRI/Test.js:
1357         (tests.shaderStages):
1358
1359 2018-09-24  Myles C. Maxfield  <mmaxfield@apple.com>
1360
1361         [WHLSL] Not all functions should be able to run in all shader stages
1362         https://bugs.webkit.org/show_bug.cgi?id=189121
1363
1364         Reviewed by Filip Pizlo.
1365
1366         ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
1367         ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
1368         if/when we make them native.
1369
1370         The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
1371         0. Therefore, those functions are unchanged.
1372
1373         * WebGPUShadingLanguageRI/All.js:
1374         * WebGPUShadingLanguageRI/Intrinsics.js:
1375         * WebGPUShadingLanguageRI/LateChecker.js:
1376         (LateChecker.prototype._checkShaderType):
1377         * WebGPUShadingLanguageRI/NativeFunc.js:
1378         (NativeFunc):
1379         (NativeFunc.prototype.get stage):
1380         (NativeFunc.prototype.toDeclString):
1381         * WebGPUShadingLanguageRI/Parse.js:
1382         (parseFuncDecl):
1383         (parseNativeFunc):
1384         (parseNative):
1385         * WebGPUShadingLanguageRI/Prepare.js:
1386         (let.prepare):
1387         * WebGPUShadingLanguageRI/SPIRV.html:
1388         * WebGPUShadingLanguageRI/StandardLibrary.js:
1389         (let.standardLibrary):
1390         * WebGPUShadingLanguageRI/StatementCloner.js:
1391         (StatementCloner.prototype.visitNativeFunc):
1392         * WebGPUShadingLanguageRI/Test.html:
1393         * WebGPUShadingLanguageRI/Test.js:
1394         (tests.shaderStages):
1395         * WebGPUShadingLanguageRI/WSyntaxError.js:
1396         (WSyntaxError.prototype.toString):
1397         (WSyntaxError):
1398         * WebGPUShadingLanguageRI/index.html:
1399
1400 2018-09-24  Thomas Denney  <tdenney@apple.com>
1401
1402         [WHLSL] Implement trap statements in Metal code generation
1403         https://bugs.webkit.org/show_bug.cgi?id=189615
1404
1405         Reviewed by Myles C. Maxfield.
1406
1407         Each function called by an entry point now receives an additional
1408         boolean pointer parameter, which is set to false if the function traps.
1409         After each function call (to a non-native function) this trap parameter
1410         is checked. The behavior of the interpreter has also been updated so
1411         that a function entry point catches the trap and instead returns zero,
1412         matching the behavior of compiled code.
1413
1414         * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
1415         test suite to check for traps and also returns zero from entry points
1416         whose invocation trapped.
1417         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
1418         declarations.
1419         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
1420         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
1421         property.
1422         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
1423         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
1424         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
1425         new trapping behavior.
1426         * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
1427
1428 2018-09-24  Thomas Denney  <tdenney@apple.com>
1429
1430         [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
1431         https://bugs.webkit.org/show_bug.cgi?id=189290
1432
1433         Reviewed by Myles C. Maxfield.
1434
1435         It is no longer possible for a ternary expression to be treated as an
1436         l-value. This patch adds several test cases to verify that this is the
1437         case.
1438
1439         * WebGPUShadingLanguageRI/Checker.js:
1440         (Checker.prototype.visitTernaryExpression): No longer check isLValue.
1441         * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
1442         (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
1443         * WebGPUShadingLanguageRI/Rewriter.js:
1444         (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
1445         * WebGPUShadingLanguageRI/TernaryExpression.js:
1446         (TernaryExpression):
1447         (TernaryExpression.prototype.get elseExpression):
1448         (TernaryExpression.prototype.get isLValue): Deleted.
1449         (TernaryExpression.prototype.set isLValue): Deleted.
1450         * WebGPUShadingLanguageRI/Test.js:
1451         (tests.ternaryExpression): Add checks for failure if a failure is used
1452         as an l-value.
1453         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
1454         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
1455         (tests.ternaryExpressionIsLValue): Deleted.
1456
1457 2018-09-24  Jer Noble  <jer.noble@apple.com>
1458
1459         SharedBuffer should have an equality test
1460         https://bugs.webkit.org/show_bug.cgi?id=189919
1461
1462         Reviewed by Alex Christensen.
1463
1464         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1465         (TestWebKitAPI::TEST_F):
1466
1467 2018-09-24  Alex Christensen  <achristensen@webkit.org>
1468
1469         Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
1470         https://bugs.webkit.org/show_bug.cgi?id=189929
1471
1472         Reviewed by Andy Estes.
1473
1474         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
1475
1476 2018-09-24  Thomas Denney  <tdenney@apple.com>
1477
1478         [WHLSL] Casting user-created types to themselves should always work
1479         https://bugs.webkit.org/show_bug.cgi?id=189113
1480
1481         Reviewed by Myles C. Maxfield.
1482
1483         Casting user-defined types to themselves worked already, but we didn't
1484         test it anywhere.
1485
1486         * WebGPUShadingLanguageRI/Test.js:
1487         (tests.selfCasts):
1488
1489 2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
1490
1491         Unreviewed build fix for Jhbuild-using ports.
1492
1493         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
1494         Adjust the patch so it applies cleanly on the 1.14.3 version of the
1495         gst-plugins-good package.
1496
1497 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
1498
1499         Update flakiness dashboard configuration for iOS 12 queues
1500         https://bugs.webkit.org/show_bug.cgi?id=189688
1501
1502         Reviewed by Alexey Proskuryakov.
1503
1504         * TestResultServer/static-dashboards/builders.jsonp:
1505
1506 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1507
1508         [GStreamer] Unreviewed build fix.
1509
1510         A GStreamer patch was not applying cleanly on 1.14.3.
1511
1512         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
1513
1514 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1515
1516         [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
1517         https://bugs.webkit.org/show_bug.cgi?id=189868
1518
1519         Reviewed by Xabier Rodriguez-Calvar.
1520
1521         Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
1522
1523         * gstreamer/jhbuild.modules:
1524         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
1525
1526 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1527         [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
1528         https://bugs.webkit.org/show_bug.cgi?id=185731
1529
1530         Reviewed by Xabier Rodriguez-Calvar.
1531
1532         Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
1533
1534         This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
1535         case where two WebM initialization segments are appended on a row).
1536
1537         * gstreamer/jhbuild.modules:
1538         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
1539         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
1540         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
1541
1542 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1543
1544         [WHSL] Need grammar to specify kernel group size
1545         https://bugs.webkit.org/show_bug.cgi?id=189108
1546
1547         Reviewed by Dean Jackson.
1548
1549         In HLSL, compute functions are annotated with their workgroup size.
1550         For example,
1551
1552         [numthreads(3, 4, 5)] compute void foo(...) { ... }
1553
1554         * WebGPUShadingLanguageRI/All.js:
1555         * WebGPUShadingLanguageRI/Func.js:
1556         (Func):
1557         (Func.prototype.get attributeBlock):
1558         * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1559         (FuncAttribute):
1560         * WebGPUShadingLanguageRI/FuncDef.js:
1561         (FuncDef):
1562         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1563         (FuncNumThreadsAttribute):
1564         (FuncNumThreadsAttribute.prototype.get x):
1565         (FuncNumThreadsAttribute.prototype.get y):
1566         (FuncNumThreadsAttribute.prototype.get z):
1567         * WebGPUShadingLanguageRI/LateChecker.js:
1568         (LateChecker.prototype._checkShaderType):
1569         * WebGPUShadingLanguageRI/Parse.js:
1570         (parseAttributeBlock):
1571         (parseFuncDecl):
1572         (parseFuncDef):
1573         (parseNativeFunc):
1574         * WebGPUShadingLanguageRI/SPIRV.html:
1575         * WebGPUShadingLanguageRI/StatementCloner.js:
1576         (StatementCloner.prototype.visitFuncDef):
1577         (StatementCloner.prototype.visitFuncNumThreadsAttribute):
1578         (StatementCloner):
1579         * WebGPUShadingLanguageRI/Test.html:
1580         * WebGPUShadingLanguageRI/Test.js:
1581         (tests.numThreads):
1582         * WebGPUShadingLanguageRI/Visitor.js:
1583         (Visitor.prototype.visitFunc):
1584         (Visitor.prototype.visitFuncNumThreadsAttribute):
1585         (Visitor):
1586         * WebGPUShadingLanguageRI/index.html:
1587
1588 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1589
1590         Native functions which accept pointers need to do null checks
1591         https://bugs.webkit.org/show_bug.cgi?id=189883
1592
1593         Reviewed by Dean Jackson.
1594
1595         Simply guard all the places where we write through an author-provided pointer.
1596
1597         * WebGPUShadingLanguageRI/Intrinsics.js:
1598         (Intrinsics.):
1599         * WebGPUShadingLanguageRI/Test.js:
1600         (tests.textureDimensionsNull):
1601
1602 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1603
1604         [WHLSL] Implement atomic operations and barriers
1605         https://bugs.webkit.org/show_bug.cgi?id=189025
1606
1607         Reviewed by Dean Jackson.
1608
1609         In the interpreter, atomic operations don't need to be atomic.
1610
1611         * WebGPUShadingLanguageRI/Intrinsics.js:
1612         (Intrinsics.):
1613         * WebGPUShadingLanguageRI/StandardLibrary.js:
1614         (let.standardLibrary):
1615         * WebGPUShadingLanguageRI/Test.js:
1616         (tests.atomics):
1617
1618 2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
1619
1620         [WPE] Be very permissive in the MiniBrowser.
1621         https://bugs.webkit.org/show_bug.cgi?id=189800
1622
1623         This is just a test tool and we should make
1624         it just work, security and privacy is not really
1625         a primary focus here.
1626
1627         Reviewed by Žan Doberšek.
1628
1629         * MiniBrowser/wpe/main.cpp:
1630         (decidePermissionRequest):
1631         (main):
1632
1633 2018-09-21  Thomas Denney  <tdenney@apple.com>
1634
1635         [WHLSL] Local variables should be statically allocated
1636         https://bugs.webkit.org/show_bug.cgi?id=188402
1637
1638         Reviewed by Myles C. Maxfield.
1639
1640         An additional preparation stage is now performed so that all local
1641         variables and function parameters are allocated in a single struct at
1642         entry points. A pointer to this struct is then passed for function
1643         calls.
1644
1645         * WebGPUShadingLanguageRI/All.js: Update dependencies.
1646         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
1647         * WebGPUShadingLanguageRI/CallExpression.js:
1648         (CallExpression.prototype.set argumentList): Add setter because
1649         allocateAtEntryPoints needs to change this.
1650         * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
1651         constructor that wasn't used anywhere.
1652         * WebGPUShadingLanguageRI/Func.js:
1653         (Func.prototype.set parameters): Add setter.
1654         * WebGPUShadingLanguageRI/FuncDef.js:
1655         (FuncDef.prototype.set body): Ditto.
1656         * WebGPUShadingLanguageRI/Prepare.js:
1657         (let.prepare): Add call to allocateAtEntryPoints. This call cannot
1658         happen any earlier because it depends on having types for call
1659         arguments.
1660         * WebGPUShadingLanguageRI/Rewriter.js:
1661         (Rewriter.prototype.visitReturn): Resolve issue where the return
1662         statement's function wasn't copied. A null check is required as the
1663         Rewriter might be used before this property is set.
1664         * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
1665         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
1666         into a separate function so that allocateAtEntryPoints can create the
1667         accessors for the struct type it introduces.
1668         * WebGPUShadingLanguageRI/Test.html: Update dependencies.
1669         * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
1670         allocation transform works safely.
1671         * WebGPUShadingLanguageRI/index.html: Update dependencies.
1672
1673 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
1674
1675         Bring up queues for iOS 12 (Build fix)
1676         https://bugs.webkit.org/show_bug.cgi?id=189683
1677
1678         Unreviewed build fix.
1679
1680         We should not build ImageDiff as x86 by default since 32 bit projects are
1681         deprecated in Xcode. ImageDiff should only be built once.
1682
1683         * Scripts/build-webkit:
1684         * Scripts/webkitdirs.pm:
1685         (argumentsForConfiguration):
1686
1687 2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
1688
1689         [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
1690         https://bugs.webkit.org/show_bug.cgi?id=189797
1691
1692         Reviewed by Žan Doberšek.
1693
1694         * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
1695         the need for installing it. This works fine because the library only contains utility
1696         code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
1697
1698 2018-09-20  Daniel Bates  <dabates@apple.com>
1699
1700         Move IOKitSPI.h from TestRunnerShared to PAL
1701         https://bugs.webkit.org/show_bug.cgi?id=189804
1702
1703         Reviewed by Wenson Hsieh.
1704
1705         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
1706         declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
1707
1708         No functionality changed. So, no new tests.
1709
1710         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1711         * TestRunnerShared/spi/UIKitTestSPI.h:
1712         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1713         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1714
1715 2018-09-20  Thomas Denney  <tdenney@apple.com>
1716
1717         [WHLSL] Metal code generation
1718         https://bugs.webkit.org/show_bug.cgi?id=187735
1719
1720         Reviewed by Myles C. Maxfield.
1721
1722         Adds support for generating Metal Shading Language from WHLSL. Clients
1723         should include the file MetalCodegenAll.js and then call whlslToMsl
1724         with their program source code to compile to Metal.
1725
1726         * WebGPUShadingLanguageRI/ArrayType.js:
1727         (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
1728         all types to find the type of that expression when it is used in a
1729         MakeArrayRefExpression.
1730         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
1731         (MakeArrayRefExpression):
1732         (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
1733         getter on all types to find the type of the expression.
1734         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
1735         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
1736         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
1737         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
1738         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
1739         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
1740         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
1741         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
1742         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
1743         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
1744         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
1745         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
1746         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
1747         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
1748         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
1749         * WebGPUShadingLanguageRI/PropertyResolver.js:
1750         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1751         * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
1752         to generate code for.
1753         (tests.incrementAndDecrement):
1754         (tests.returnIntLiteralUint):
1755         (tests.returnIntLiteralFloat):
1756         (tests.nestedSubscriptWithArraysInStructs):
1757         (tests.nestedSubscript):
1758         (tests.lotsOfLocalVariables):
1759         * WebGPUShadingLanguageRI/Type.js:
1760         (Type.prototype.get arrayRefType): See above.
1761
1762 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1763
1764         Bring up queues for iOS 12
1765         https://bugs.webkit.org/show_bug.cgi?id=189683
1766
1767         Unreviewed infrastructure fix.
1768
1769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
1770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1771         (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
1772
1773 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1774
1775         Bring up queues for iOS 12
1776         https://bugs.webkit.org/show_bug.cgi?id=189683
1777
1778         Reviewed by Aakash Jain.
1779
1780         * BuildSlaveSupport/build.webkit.org-config/config.json:
1781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1787         (WebKitBuildbot):
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1789         (table.queue-grid tr.platform.ios-simulator-12 img.logo):
1790         (table.queue-grid tr.platform.ios-12 img.logo):
1791         (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
1792         (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
1793         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1794         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1795         (_should_file_trigger_build):
1796         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1797         (ShouldBuildTest):
1798         (ShouldBuildTest.test_should_build):
1799
1800 2018-09-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1801
1802         [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
1803         https://bugs.webkit.org/show_bug.cgi?id=189679
1804
1805         Reviewed by Fujii Hironori.
1806
1807         Replace the implementation with correct API call.
1808
1809         * DumpRenderTree/win/TestRunnerWin.cpp:
1810         (TestRunner::queueLoad): Call UrlCombineW.
1811
1812 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1813
1814         [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
1815         https://bugs.webkit.org/show_bug.cgi?id=189556
1816
1817         Reviewed by Konstantin Tokarev.
1818
1819         This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
1820         libepoxy.
1821
1822         * wpe/backends/CMakeLists.txt:
1823
1824 2018-09-20  Daniel Bates  <dabates@apple.com>
1825
1826         [iOS] Support testing more hardware special keys
1827         https://bugs.webkit.org/show_bug.cgi?id=189793
1828
1829         Reviewed by Simon Fraser.
1830
1831         * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
1832         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1833         (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
1834         key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
1835         F13, F14, ..., F24 keys.
1836         (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
1837
1838 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1839
1840         Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
1841
1842         Aaaaaah maybe this is why changes are supposed to be reviewed.
1843
1844         * flatpak/flatpakutils.py:
1845         (WebkitFlatpak.clean_args):
1846
1847 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1848
1849         Unreviewed, manually rollout our switch to master runtime
1850
1851         Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
1852         meantime, where we were already building GStreamer ourselves anyway. But use an updated
1853         SDK revision.
1854
1855         * flatpak/files/httpd-autogen.sh: Added.
1856         * flatpak/flatpakutils.py:
1857         (WebkitFlatpak.clean_args):
1858         * flatpak/org.webkit.GTK.yaml:
1859         * flatpak/org.webkit.WebKit.yaml:
1860         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
1861         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
1862
1863 2018-09-20  Thibault Saunier  <tsaunier@igalia.com>
1864
1865         [WPE][GTK] webkit-flatpak intercepts --help for other commands
1866         https://bugs.webkit.org/show_bug.cgi?id=189058
1867
1868         The approach of run_in_sandbox_if_available is that we basically have the
1869         same set of arguments to setup the sandbox (ie. port name, build type, etc...)
1870         and we can pass those args first to setup the flatpak launcher object
1871         and then to the underlying script. That doesn't work well with the `--help` argument
1872         as once processed it 1. prints the help (which make no sense to the user of the calling script)
1873         2. exits the app - The solution is to just make sure that `--help` is not used when using
1874         flatpakutils from any script that is not `webkit-flatpak` itself.
1875
1876         Reviewed by Michael Catanzaro.
1877
1878         * flatpak/flatpakutils.py:
1879         (WebkitFlatpak.load_from_args):
1880         (run_in_sandbox_if_available):
1881
1882 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1883
1884         Unreviewed. Add W3C imported tests to the MSEEME watchlist.
1885
1886         * Scripts/webkitpy/common/config/watchlist:
1887
1888 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1889
1890         Unreviewed. Fix the Streams API watchlist.
1891
1892         * Scripts/webkitpy/common/config/watchlist:
1893
1894 2018-09-19  Chris Dumez  <cdumez@apple.com>
1895
1896         Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
1897         https://bugs.webkit.org/show_bug.cgi?id=189721
1898         <rdar://problem/44359788>
1899
1900         Reviewed by Geoffrey Garen.
1901
1902         Add API test coverage.
1903
1904         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1905
1906 2018-09-19  Thomas Denney  <tdenney@apple.com>
1907
1908         [WHLSL] Improve test suite type safety
1909         https://bugs.webkit.org/show_bug.cgi?id=189502
1910
1911         Reviewed by Myles C. Maxfield.
1912
1913         Each of the 'makeT' functions now call the relevant cast function on the
1914         value before hand. The checkNumber function has also been removed and
1915         its uses have been replaced with functions that also check the type.
1916         Some of the arithmetic checks have been updated to reflect that the
1917         casts happen outside of WHLSL evaluation. Other tests have also been
1918         updated to reflect that some values cannot be precisely expressed in
1919         32-bit floating point.
1920
1921         * WebGPUShadingLanguageRI/Casts.js:
1922         (castToBool): Added.
1923         (castAndCheckValue): Added.
1924         (isBitwiseEquivalent): Moved from Intrinsics.js.
1925         * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
1926         * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
1927         * WebGPUShadingLanguageRI/Test.html: Ditto.
1928         * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
1929         and check the result. Some tests were also updated to reflect the change
1930         in the behavior of these functions.
1931         * WebGPUShadingLanguageRI/index.html: Update dependencies.
1932
1933 2018-09-19  John Wilander  <wilander@apple.com>
1934
1935         Resource Load Statistics: Add optional cap on partitioned cache max age
1936         https://bugs.webkit.org/show_bug.cgi?id=189711
1937         <rdar://problem/39246837>
1938
1939         Reviewed by Antti Koivisto and Chris Dumez.
1940
1941         This change adds infrastructure for layout tests of capped cache max age.
1942
1943         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1944         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1945         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1946         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1947         * WebKitTestRunner/TestController.cpp:
1948         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1949         * WebKitTestRunner/TestController.h:
1950         * WebKitTestRunner/TestInvocation.cpp:
1951         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1952
1953 2018-09-19  Dawei Fenton  <realdawei@apple.com>
1954
1955        Unreviewed. Update my email and alias in list of contributors.
1956
1957         * Scripts/webkitpy/common/config/contributors.json:
1958
1959 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1960
1961         [WPE][GTK] Unreviewed, try #3 to fix a typo
1962
1963         I feel like Charlie Brown, how hard this has been for me....
1964
1965         * Scripts/run-minibrowser:
1966         * Scripts/webkitdirs.pm:
1967         (runInFlatpakIfAvailable):
1968         (runInFlatpakIfAvailible): Deleted.
1969
1970 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1971
1972         [WPE][GTK] Unreviewed, fix that typo in more places
1973
1974         It got copied into webkitdirs.pm!
1975
1976         * Scripts/webkitdirs.pm:
1977         (runInFlatpakIfAvailible):
1978         (runInFlatpakIfAvalaible): Deleted.
1979
1980 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1981
1982         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
1983
1984         * flatpak/flatpakutils.py:
1985         (WebkitFlatpak.load_from_args):
1986         (WebkitFlatpak.__init__):
1987         (WebkitFlatpak.run):
1988
1989 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1990
1991         [WPE][GTK] Unreviewed, update to latest GNOME SDK
1992
1993         * flatpak/org.webkit.WebKit.yaml:
1994
1995 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1996
1997         Unreviewed, rolling out r235500.
1998
1999         Time to switch back to master runtime
2000
2001         Reverted changeset:
2002
2003         "Unreviewed, rolling out r235114."
2004         https://bugs.webkit.org/show_bug.cgi?id=188731
2005         https://trac.webkit.org/changeset/235500
2006
2007 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
2008
2009         Unreviewed. Add Pablo Saavedra to the list of contributors.
2010
2011         * Scripts/webkitpy/common/config/contributors.json:
2012
2013 2018-09-19  Philippe Normand  <pnormand@igalia.com>
2014
2015         [GStreamer] Add support for AV1 decoding
2016         https://bugs.webkit.org/show_bug.cgi?id=189647
2017
2018         Reviewed by Žan Doberšek.
2019
2020         Add patches required for AV1 decoding support. They're all
2021         upstream already and will be shipped in GStreamer 1.16. The aom
2022         GStreamer plugin depends on the aom library for which there's no
2023         official release yet.
2024
2025         * gstreamer/jhbuild.modules:
2026         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
2027         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
2028         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
2029         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
2030         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
2031         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
2032
2033 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
2034
2035         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
2036         https://bugs.webkit.org/show_bug.cgi?id=189702
2037         <rdar://problem/44541704>
2038
2039         Reviewed by Aakash Jain.
2040
2041         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2042         (Manager._set_up_run): Move build check and clobbering to run, since set up is
2043         run multiple times for iOS simulator.
2044         (Manager.run):
2045
2046 2018-09-18  Chris Dumez  <cdumez@apple.com>
2047
2048         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
2049         https://bugs.webkit.org/show_bug.cgi?id=189681
2050         <rdar://problem/44526171>
2051
2052         Reviewed by Alex Christensen and Zalan Bujtas.
2053
2054         Add API test coverage.
2055
2056         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2057         (TestWebKitAPI::didFinishNavigation):
2058         (TestWebKitAPI::TEST):
2059
2060 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
2061
2062         [WPE] Implement mouse event modifiers
2063         https://bugs.webkit.org/show_bug.cgi?id=189697
2064
2065         Reviewed by Carlos Garcia Campos.
2066
2067         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2068         (WTR::wkEventModifiersToWPE):
2069         (WTR::EventSenderProxy::mouseDown):
2070         (WTR::EventSenderProxy::mouseUp):
2071
2072 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2073
2074         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
2075         https://bugs.webkit.org/show_bug.cgi?id=185339
2076
2077         Reviewed by Mark Lam.
2078
2079         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
2080         (TestWebKitAPI::ToUpperConverter::stopProducing):
2081         (TestWebKitAPI::ToUpperConverter::stopConsuming):
2082
2083 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
2084
2085         Many modern media control tests leak documents in testing
2086         https://bugs.webkit.org/show_bug.cgi?id=189437
2087
2088         Reviewed by Darin Adler.
2089         
2090         In order to accurately detect leaks in media controls tests which use lots of
2091         SVGImages, we have to:
2092         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
2093           to clear references to elements.
2094         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
2095           to drop the last handle to the CachedResource for an SVGImage.
2096         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
2097           to run again after that timer has fired.
2098         
2099         This should fix most of the spurious leak reports involving SVGImage documents.
2100
2101         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2102         (WTR::InjectedBundle::reportLiveDocuments):
2103         (WTR::InjectedBundle::didReceiveMessageToPage):
2104
2105 2018-09-17  Chris Dumez  <cdumez@apple.com>
2106
2107         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
2108         https://bugs.webkit.org/show_bug.cgi?id=189602
2109         <rdar://problem/44430549>
2110
2111         Reviewed by Geoff Garen.
2112
2113         Add API test coverage.
2114
2115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2116
2117 2018-09-17  Philippe Normand  <pnormand@igalia.com>
2118
2119         [JHBuild] Update to GStreamer 1.14.3
2120         https://bugs.webkit.org/show_bug.cgi?id=189450
2121
2122         Reviewed by Xabier Rodriguez-Calvar.
2123
2124         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
2125
2126 2018-09-17  Philippe Normand  <pnormand@igalia.com>
2127
2128         [JHBuild] Doesn't check sha256 sums
2129         https://bugs.webkit.org/show_bug.cgi?id=189646
2130
2131         Reviewed by Michael Catanzaro.
2132
2133         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
2134
2135 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
2136
2137         Move IndexedDB to Network Process
2138         https://bugs.webkit.org/show_bug.cgi?id=189415
2139         <rdar://problem/44396973>
2140
2141         Reviewed by Chris Dumez.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2144         (TEST):
2145         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2146         (TEST):
2147         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
2148         (TEST):
2149         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
2150         (TEST):
2151         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2152         (TEST):
2153
2154 2018-09-08  Darin Adler  <darin@apple.com>
2155
2156         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
2157         https://bugs.webkit.org/show_bug.cgi?id=189455
2158
2159         Reviewed by Keith Miller.
2160
2161         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
2162         testing and even for macOS vs. iOS vs. Windows platform-specific code.
2163         For now, this patch just makes corresponding changes to the copied code.
2164         Later we might get better results by merging more code instead of having
2165         all these separate copies.
2166
2167         * DumpRenderTree/AccessibilityController.cpp:
2168         (AccessibilityController::makeWindowObject): Use the adopt function
2169         instead of the special Adopt constructor of JSRetainPtr.
2170
2171         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
2172
2173         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
2174         (allAttributesCallback): Don't adopt at this level; changed the
2175         underlying function to return a JSRetainPtr so the adopt is right next
2176         to the call to the create or copy function.
2177         (attributesOfLinkedUIElementsCallback): Ditto.
2178         (attributesOfDocumentLinksCallback): Ditto.
2179         (attributesOfChildrenCallback): Ditto.
2180         (parameterizedAttributeNamesCallback): Ditto.
2181         (attributesOfColumnHeadersCallback): Ditto.
2182         (attributesOfRowHeadersCallback): Ditto.
2183         (attributesOfColumnsCallback): Ditto.
2184         (attributesOfRowsCallback): Ditto.
2185         (attributesOfVisibleCellsCallback): Ditto.
2186         (attributesOfHeaderCallback): Ditto.
2187         (rowIndexRangeCallback): Ditto.
2188         (columnIndexRangeCallback): Ditto.
2189         (rangeForLineCallback): Ditto.
2190         (boundsForRangeCallback): Ditto.
2191         (rangeForPositionCallback): Ditto.
2192         (stringForRangeCallback): Ditto.
2193         (attributedStringForRangeCallback): Ditto.
2194         (uiElementCountForSearchPredicateCallback): Use the free adopt
2195         function instead of the adopt member function.
2196         (uiElementForSearchPredicateCallback): Ditto.
2197         (selectTextWithCriteriaCallback): Don't adopt at this level.
2198         (attributedStringForElementCallback): Ditto.
2199         (setValueCallback): Use free adopt.
2200         (stringAttributeValueCallback): Don't adopt at this level.
2201         (uiElementArrayAttributeValueCallback): Ditto.
2202         (uiElementAttributeValueCallback): Ditto.
2203         (stringForTextMarkerRangeCallback): Ditto.
2204         (attributedStringForTextMarkerRangeCallback): Ditto.
2205         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
2206         (getARIADropEffectsCallback): Ditto.
2207         (getClassListCallback): Ditto.
2208         (getRoleCallback): Ditto.
2209         (getSubroleCallback): Ditto.
2210         (getRoleDescriptionCallback): Ditto.
2211         (getComputedRoleStringCallback): Ditto.
2212         (getTitleCallback): Ditto.
2213         (getDescriptionCallback): Ditto.
2214         (getStringValueCallback): Ditto.
2215         (getLanguageCallback): Ditto.
2216         (getHelpTextCallback): Ditto.
2217         (getOrientationCallback): Ditto.
2218         (getPathDescriptionCallback): Ditto.
2219         (getSelectedTextRangeCallback): Ditto.
2220         (speakAsCallback): Ditto.
2221         (getValueDescriptionCallback): Ditto.
2222         (getAccessibilityValueCallback): Ditto.
2223         (getDocumentEncodingCallback): Ditto.
2224         (getDocumentURICallback): Ditto.
2225         (getURLCallback): Ditto.
2226         (characterAtOffsetCallback): Ditto.
2227         (wordAtOffsetCallback): Ditto.
2228         (lineAtOffsetCallback): Ditto.
2229         (sentenceAtOffsetCallback): Ditto.
2230         (stringForSelectionCallback): Ditto.
2231         (getIdentifierCallback): Ditto.
2232         (getTraitsCallback): Ditto.
2233         (supportedActionsCallback): Ditto.
2234         (mathPostscriptsDescriptionCallback): Ditto.
2235         (mathPrescriptsDescriptionCallback): Ditto.
2236         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
2237         (AccessibilityUIElement::rangeForPosition): Ditto.
2238         (AccessibilityUIElement::speakAs): Ditto.
2239         (AccessibilityUIElement::pathDescription const): Ditto.
2240         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2241         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2242         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2243
2244         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
2245         raw pointers for the results of the functions that create strings.
2246         The old way was difficult to get right; the functions didn't even follow
2247         the create/copy naming rule.
2248
2249         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2250         (_platformTypeConstructor): Use the adopt function instead of the
2251         JSRetainPtr adopt constructor. Also nullptr instead of 0.
2252
2253         * DumpRenderTree/GCController.cpp:
2254         (GCController::makeWindowObject): Use adopt function instead of constructor.
2255
2256         * DumpRenderTree/TestRunner.cpp:
2257         (pathToLocalResourceCallback): Use adopt function instead of constructor.
2258         (addDisallowedURLCallback): Ditto.
2259         (addURLToRedirectCallback): Ditto.
2260         (clearApplicationCacheForOriginCallback): Ditto.
2261         (applicationCacheDiskUsageForOriginCallback): Ditto.
2262         (decodeHostNameCallback): Don't adopt at this level.
2263         (encodeHostNameCallback): Ditto.
2264         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
2265         (findStringCallback): Use adopt function instead of constructor.
2266         (isCommandEnabledCallback): Ditto.
2267         (overridePreferenceCallback): Ditto.
2268         (queueLoadCallback): Ditto.
2269         (queueLoadHTMLStringCallback): Ditto.
2270         (queueLoadingScriptCallback): Ditto.
2271         (queueNonLoadingScriptCallback): Ditto.
2272         (setAuthenticationPasswordCallback): Ditto.
2273         (setAuthenticationUsernameCallback): Ditto.
2274         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
2275         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
2276         (setPOSIXLocaleCallback): Ditto.
2277         (setPersistentUserStyleSheetLocationCallback): Ditto.
2278         (setUserStyleSheetLocationCallback): Ditto.
2279         (setValueForUserCallback): Ditto.
2280         (setWillSendRequestClearHeaderCallback): Ditto.
2281         (setPageVisibilityCallback): Ditto.
2282         (evaluateInWebInspectorCallback): Ditto.
2283         (evaluateScriptInIsolatedWorldCallback): Ditto.
2284         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
2285         (addOriginAccessWhitelistEntryCallback): Ditto.
2286         (removeOriginAccessWhitelistEntryCallback): Ditto.
2287         (setScrollbarPolicyCallback): Ditto.
2288         (addUserScriptCallback): Ditto.
2289         (addUserStyleSheetCallback): Ditto.
2290         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
2291         (authenticateSessionCallback): Ditto.
2292         (getTitleTextDirectionCallback): Ditto.
2293         (getInspectorTestStubURLCallback): Ditto.
2294         (simulateLegacyWebNotificationClickCallback): Ditto.
2295         (setTextDirectionCallback): Ditto.
2296         (grantWebNotificationPermissionCallback): Ditto.
2297         (denyWebNotificationPermissionCallback): Ditto.
2298         (accummulateLogsForChannel): Ditto.
2299         (runUIScriptCallback): Ditto.
2300         (TestRunner::makeWindowObject): Ditto.
2301         (TestRunner::uiScriptDidComplete): Ditto.
2302         (TestRunner::setOpenPanelFiles): Ditto.
2303
2304         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
2305         raw pointers for the results of the functions that create strings.
2306
2307         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2308         (AccessibilityController::platformName const): Use the adopt
2309         function instead of the adopt constructor.
2310
2311         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2312         (createEmptyJSString): Added. This helper function makes reduces the
2313         repetitive code to create empty strings.
2314         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
2315         (AccessibilityUIElement::identifier): Ditto.
2316         (AccessibilityUIElement::traits): Ditto.
2317         (AccessibilityUIElement::url): Ditto.
2318         (AccessibilityUIElement::speakAs): Ditto.
2319         (AccessibilityUIElement::stringForSelection): Ditto.
2320         (AccessibilityUIElement::stringForRange): Ditto.
2321         (AccessibilityUIElement::attributedStringForRange): Ditto.
2322         (AccessibilityUIElement::attributedStringForElement): Ditto.
2323         (AccessibilityUIElement::pathDescription const): Ditto.
2324         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2325         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2326         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2327         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2328         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2329         (AccessibilityUIElement::attributesOfChildren): Ditto.
2330         (AccessibilityUIElement::allAttributes): Ditto.
2331         (AccessibilityUIElement::stringAttributeValue): Ditto.
2332         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2333         (AccessibilityUIElement::role): Ditto.
2334         (AccessibilityUIElement::subrole): Ditto.
2335         (AccessibilityUIElement::roleDescription): Ditto.
2336         (AccessibilityUIElement::computedRoleString): Ditto.
2337         (AccessibilityUIElement::title): Ditto.
2338         (AccessibilityUIElement::description): Ditto.
2339         (AccessibilityUIElement::orientation const): Ditto.
2340         (AccessibilityUIElement::stringValue): Ditto.
2341         (AccessibilityUIElement::language): Ditto.
2342         (AccessibilityUIElement::helpText const): Ditto.
2343         (AccessibilityUIElement::valueDescription): Ditto.
2344         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2345         (AccessibilityUIElement::boundsForRange): Ditto.
2346         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2347         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2348         (AccessibilityUIElement::attributesOfColumns): Ditto.
2349         (AccessibilityUIElement::attributesOfRows): Ditto.
2350         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2351         (AccessibilityUIElement::attributesOfHeader): Ditto.
2352         (AccessibilityUIElement::rowIndexRange): Ditto.
2353         (AccessibilityUIElement::columnIndexRange): Ditto.
2354         (AccessibilityUIElement::selectedTextRange): Ditto.
2355         (AccessibilityUIElement::accessibilityValue const): Ditto.
2356         (AccessibilityUIElement::documentEncoding): Ditto.
2357         (AccessibilityUIElement::documentURI): Ditto.
2358         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2359         (AccessibilityUIElement::classList const): Ditto.
2360
2361         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
2362         createJSStringRef method to return a JSRetainPtr.
2363         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2364         (-[NSString createJSStringRef]): Ditto.
2365         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
2366         adopt function instead of the adopt constructor.
2367         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2368         (AccessibilityController::platformName const): Ditto.
2369
2370         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2371         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2372         (makeValueRefForValue): Updated for the above, no adopt needed here now.
2373         (makeObjectRefForDictionary): Ditto.
2374         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
2375
2376         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2377         (createEmptyJSString): Added. This helper function makes reduces the
2378         repetitive code to create empty strings.
2379         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
2380         (descriptionOfElements): Ditto.
2381         (selectTextParameterizedAttributeForCriteria): Ditto.
2382         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2383         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2384         (AccessibilityUIElement::attributesOfChildren): Ditto.
2385         (AccessibilityUIElement::allAttributes): Ditto.
2386         (AccessibilityUIElement::stringAttributeValue): Ditto.
2387         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2388         (AccessibilityUIElement::role): Ditto.
2389         (AccessibilityUIElement::subrole): Ditto.
2390         (AccessibilityUIElement::roleDescription): Ditto.
2391         (AccessibilityUIElement::computedRoleString): Ditto.
2392         (AccessibilityUIElement::title): Ditto.
2393         (AccessibilityUIElement::description): Ditto.
2394         (AccessibilityUIElement::orientation const): Ditto.
2395         (AccessibilityUIElement::stringValue): Ditto.
2396         (AccessibilityUIElement::language): Ditto.
2397         (AccessibilityUIElement::helpText const): Ditto.
2398         (AccessibilityUIElement::valueDescription): Ditto.
2399         (AccessibilityUIElement::speakAs): Ditto.
2400         (AccessibilityUIElement::classList const): Ditto.
2401         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2402         (AccessibilityUIElement::rangeForLine): Ditto.
2403         (AccessibilityUIElement::rangeForPosition): Ditto.
2404         (AccessibilityUIElement::boundsForRange): Ditto.
2405         (AccessibilityUIElement::stringForRange): Ditto.
2406         (AccessibilityUIElement::attributedStringForRange): Ditto.
2407         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2408         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2409         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2410         (AccessibilityUIElement::attributesOfColumns): Ditto.
2411         (AccessibilityUIElement::attributesOfRows): Ditto.
2412         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2413         (AccessibilityUIElement::attributesOfHeader): Ditto.
2414         (AccessibilityUIElement::rowIndexRange): Ditto.
2415         (AccessibilityUIElement::columnIndexRange): Ditto.
2416         (AccessibilityUIElement::pathDescription const): Ditto.
2417         (AccessibilityUIElement::selectedTextRange): Ditto.
2418         (AccessibilityUIElement::accessibilityValue const): Ditto.
2419         (AccessibilityUIElement::documentEncoding): Ditto.
2420         (AccessibilityUIElement::documentURI): Ditto.
2421         (AccessibilityUIElement::url): Ditto.
2422         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2423         (createJSStringRef): Ditto.
2424         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2425         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2426         (AccessibilityUIElement::supportedActions): Ditto.
2427         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
2428         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
2429
2430         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2431         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2432         Use the adopt function instead of the adopt constructor.
2433         * DumpRenderTree/mac/TestRunnerMac.mm:
2434         (originsArrayToJS): Ditto.
2435         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
2436         (TestRunner::copyEncodedHostName): Ditto.
2437         (TestRunner::pathToLocalResource): Ditto.
2438         (TestRunner::queueLoad): Use adopt function instead of constructor.
2439         (TestRunner::findString): Ditto.
2440         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
2441
2442         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2443         (AccessibilityController::winNotificationReceived): Use adopt function
2444         instead of adopt constructor.
2445         (AccessibilityController::platformName const): Ditto.
2446
2447         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2448         (createEmptyJSString): Added. This helper function makes reduces the
2449         repetitive code to create empty strings.
2450         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
2451         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2452         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2453         (AccessibilityUIElement::attributesOfChildren): Ditto.
2454         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2455         (AccessibilityUIElement::role): Ditto.
2456         (AccessibilityUIElement::subrole): Ditto.
2457         (AccessibilityUIElement::roleDescription): Ditto.
2458         (AccessibilityUIElement::computedRoleString): Ditto.
2459         (AccessibilityUIElement::title): Ditto.
2460         (AccessibilityUIElement::description): Ditto.
2461         (AccessibilityUIElement::stringValue): Ditto.
2462         (AccessibilityUIElement::language): Ditto.
2463         (AccessibilityUIElement::helpText const): Ditto.
2464         (AccessibilityUIElement::valueDescription): Ditto.
2465         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2466         (AccessibilityUIElement::orientation const): Ditto.
2467         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2468         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2469         (AccessibilityUIElement::attributesOfColumns): Ditto.
2470         (AccessibilityUIElement::attributesOfRows): Ditto.
2471         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2472         (AccessibilityUIElement::attributesOfHeader): Ditto.
2473         (AccessibilityUIElement::rowIndexRange): Ditto.
2474         (AccessibilityUIElement::columnIndexRange): Ditto.
2475         (AccessibilityUIElement::boundsForRange): Ditto.
2476         (AccessibilityUIElement::stringForRange): Ditto.
2477         (AccessibilityUIElement::attributedStringForRange): Ditto.
2478         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2479         (AccessibilityUIElement::selectedTextRange): Ditto.
2480         (AccessibilityUIElement::stringAttributeValue): Ditto.
2481         (AccessibilityUIElement::accessibilityValue const): Ditto.
2482         (AccessibilityUIElement::documentEncoding): Ditto.
2483         (AccessibilityUIElement::documentURI): Ditto.
2484         (AccessibilityUIElement::url): Ditto.
2485         (AccessibilityUIElement::classList const): Ditto.
2486
2487         * DumpRenderTree/win/TestRunnerWin.cpp:
2488         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
2489         (TestRunner::copyEncodedHostName): Ditto.
2490         (TestRunner::pathToLocalResource): Ditto.
2491         (TestRunner::queueLoad): Ditto.
2492         (TestRunner::findString): Ditto.
2493         (TestRunner::inspectorTestStubURL): Ditto.
2494
2495         * TestRunnerShared/Bindings/JSWrapper.h:
2496         (WTR::setProperty): Use adopt function instead of constructor.
2497         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2498         (UIScriptContext::UIScriptContext): Ditto.
2499         (UIScriptContext::runUIScript): Ditto.
2500         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2501         (WTR::toDeviceOrientation): Ditto.
2502
2503         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2504         (nsTextCheckingType): Changed this function to not take an rvalue
2505         reference to a JSRetainPtr since it doesn't take ownership.
2506         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
2507         for the above change.
2508
2509         * TestWebKitAPI/JavaScriptTest.cpp:
2510         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
2511         adopt member function.
2512
2513         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
2514         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
2515         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
2516         adopt constructor.
2517         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
2518
2519         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2520         Removed unneeded includes.
2521         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
2522         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
2523         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
2524
2525         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2526         (_platformTypeConstructor): Use the adopt function instead of the
2527         JSRetainPtr adopt constructor. Also nullptr instead of 0.
2528
2529         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2530         (WTR::arrayLength): Use adopt function instead of constructor.
2531         (WTR::parseModifierArray): Ditto.
2532         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2533         (WTR::propertyValue): Ditto.
2534         (WTR::dumpPath): Ditto.
2535         (WTR::toJS): Ditto.
2536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2537         (WTR::TestRunner::findString): Ditto.
2538         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
2539         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
2540         (WTR::TestRunner::setOpenPanelFiles): Ditto.
2541         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2542         (WTR::AccessibilityController::platformName): Ditto.
2543
2544         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2545         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2546         This fixes storage leaks in many functions below, which were using
2547         the create function and putting the value right into a JSRetainPtr
2548         without adoption.
2549         (WTR::createEmptyJSString): Added. This helper function reduces the
2550         repetitive code to create empty strings.
2551         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
2552         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2553         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2554         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2555         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2556         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2557         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2558         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2559         (WTR::AccessibilityUIElement::role): Ditto.
2560         (WTR::AccessibilityUIElement::subrole): Ditto.
2561         (WTR::AccessibilityUIElement::roleDescription): Ditto.
2562         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
2563         (WTR::AccessibilityUIElement::title): Ditto.
2564         (WTR::AccessibilityUIElement::orientation const): Ditto.
2565         (WTR::AccessibilityUIElement::language): Ditto.
2566         (WTR::AccessibilityUIElement::valueDescription): Ditto.
2567         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
2568         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
2569         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
2570         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
2571         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2572         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2573         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2574         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
2575         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
2576         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2577         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
2578         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
2579         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
2580         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2581         (WTR::AccessibilityUIElement::documentURI): Ditto.
2582         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
2583         null check.
2584         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2585         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2586
2587         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2588         Use JSRetainPtr for the return value of createJSStringRef.
2589         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2590         (-[NSString createJSStringRef]): Ditto.
2591         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
2592         adopt function instead of the adopt constructor.
2593         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2594         (WTR::AccessibilityController::platformName): Ditto
2595
2596         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2597         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2598         (makeValueRefForValue): Updated for above by removing adopt.
2599         (makeObjectRefForDictionary): Ditto.
2600         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
2601
2602         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2603         (WTR::createEmptyJSString): Added. This helper function makes reduces the
2604         repetitive code to create empty strings.
2605         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
2606         (WTR::descriptionOfElements): Ditto.
2607         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
2608         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
2609         fixing a storage leak due to missing adoption.
2610         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2611         (WTR::AccessibilityUIElement::documentURI): Ditto.
2612         (WTR::createJSStringRef): Return a JSRetainPtr.
2613
2614         * WebKitTestRunner/StringFunctions.h:
2615         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
2616         (WTR::toJS): Use the adopt function instead of the constructor.
2617
2618 2018-09-14  Dean Jackson  <dino@grorg.org>
2619
2620         Add Justin Michaud.
2621
2622         * Scripts/webkitpy/common/config/contributors.json:
2623
2624 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
2625
2626         bots should pass --clobber-old-results to run-webkit-tests
2627         https://bugs.webkit.org/show_bug.cgi?id=189623
2628
2629         Reviewed by Aakash Jain.
2630
2631         In order to ensure that bots to not produce confusing results due to transient execptions,
2632         or run out of space if they continually hit an exception, old layout test results should be clobbered.
2633
2634         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2635         (RunWebKitTests):
2636
2637 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
2638
2639         Unreviewed, rolling out r235954.
2640
2641         Breaks the watchOS build.
2642
2643         Reverted changeset:
2644
2645         "Move IndexedDB to Network Process"
2646         https://bugs.webkit.org/show_bug.cgi?id=189415
2647         https://trac.webkit.org/changeset/235954
2648
2649 2018-09-13  Daniel Bates  <dabates@apple.com>
2650
2651         Add Copy WebKit Permalink plugin for Sublime Text
2652         https://bugs.webkit.org/show_bug.cgi?id=189589
2653
2654         Rubber-stamped by Joseph Pecoraro.
2655
2656         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
2657         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
2658         active document with or without blame annotations.
2659
2660         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
2661         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
2662         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
2663         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
2664         and Command + Shift + Control + Option + C, respectively.
2665
2666         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
2667         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
2668         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
2669         * CopyPermalink/Sublime Text/INSTALL: Added.
2670         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
2671         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
2672         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
2673
2674 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2675
2676         Unreviewed. Fix WebDriver tests after r235225.
2677
2678         Use wpt serve command to run the http server.
2679
2680         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2681         (WebDriverW3CWebServer.__init__):
2682         (WebDriverW3CWebServer.start):
2683         (WebDriverW3CWebServer.stop):
2684
2685 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2686
2687         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
2688         https://bugs.webkit.org/show_bug.cgi?id=189544
2689
2690         Reviewed by Michael Catanzaro.
2691
2692         Add test cases for the new API.
2693
2694         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2695         (testWebViewJavaScriptDialogs):
2696
2697 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2698
2699         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
2700         https://bugs.webkit.org/show_bug.cgi?id=189496
2701         <rdar://problem/44370981>
2702
2703         Unreviewed warning fix.
2704
2705         r235929 has introduced a new compilation warning:
2706         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
2707
2708         * ImageDiff/cairo/PlatformImageCairo.cpp:
2709         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
2710
2711 2018-09-12  Dan Bernstein  <mitz@apple.com>
2712
2713         [Cocoa] Complete support for Paste as Quotation
2714         https://bugs.webkit.org/show_bug.cgi?id=189504
2715
2716         Reviewed by Wenson Hsieh.
2717
2718         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
2719
2720 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
2721
2722         Move IndexedDB to Network Process
2723         https://bugs.webkit.org/show_bug.cgi?id=189415
2724
2725         Reviewed by Geoffrey Garen.
2726
2727         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2728         (TEST):
2729         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2730         (TEST):
2731         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
2732         (TEST):
2733         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
2734         (TEST):
2735         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2736         (TEST):
2737
2738 2018-09-12  Chris Dumez  <cdumez@apple.com>
2739
2740         PSON: No process swap on back navigation after URL bar navigation
2741         https://bugs.webkit.org/show_bug.cgi?id=189557
2742         <rdar://problem/44353108>
2743
2744         Reviewed by Alex Christensen.
2745
2746         Add API test coverage.
2747
2748         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2749
2750 2018-09-11  Dean Jackson  <dino@apple.com>
2751
2752         Header parsing for experimental and internal debug features
2753         https://bugs.webkit.org/show_bug.cgi?id=189486
2754         <rdar://problem/44320618>
2755
2756         Reviewed by Tim Horton.
2757
2758         Keep track of experimental and internal debug features in TestOptions, and
2759         allow webkit-test-runner headers to toggle them by name.
2760
2761         * DumpRenderTree/TestOptions.cpp:
2762         (TestOptions::TestOptions):
2763         * WebKitTestRunner/TestController.cpp:
2764         (WTR::TestController::resetPreferencesToConsistentValues):
2765         (WTR::updateTestOptionsFromTestHeader):
2766         * WebKitTestRunner/TestOptions.h:
2767         (WTR::TestOptions::hasSameInitializationOptions const):
2768
2769 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2770
2771         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
2772         https://bugs.webkit.org/show_bug.cgi?id=189492
2773
2774         Reviewed by Alex Christensen.
2775
2776         0 and nullptr can't be implicitly converted to
2777         AccessibilityUIElement because only Windows port typedefs
2778         PlatformUIElement as COMPtr<IAccessible> not a pointer.
2779
2780         Replaced "return 0" and "return nullptr" with "return { nullptr }".
2781
2782         * DumpRenderTree/AccessibilityUIElement.cpp:
2783         (AccessibilityUIElement::horizontalScrollbar const):
2784         (AccessibilityUIElement::verticalScrollbar const):
2785         (AccessibilityUIElement::uiElementAttributeValue const):
2786         (AccessibilityUIElement::accessibilityElementForTextMarker):
2787         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2788         (AccessibilityController::elementAtPoint):
2789         (AccessibilityController::accessibleElementById):
2790         (AccessibilityController::focusedElement):
2791         (AccessibilityController::rootElement):
2792         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2793         (AccessibilityUIElement::elementAtPoint):
2794         (AccessibilityUIElement::linkedUIElementAtIndex):
2795         (AccessibilityUIElement::getChildAtIndex):
2796         (AccessibilityUIElement::titleUIElement):
2797         (AccessibilityUIElement::parentElement):
2798         (AccessibilityUIElement::uiElementForSearchPredicate):
2799         (AccessibilityUIElement::cellForColumnAndRow):
2800         (AccessibilityUIElement::disclosedRowAtIndex):
2801         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2802         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2803         (AccessibilityUIElement::ariaControlsElementAtIndex):
2804         (AccessibilityUIElement::selectedRowAtIndex):
2805         (AccessibilityUIElement::rowAtIndex):
2806         (AccessibilityUIElement::disclosedByRow):
2807         (AccessibilityUIElement::selectedChildAtIndex const):
2808
2809 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2810
2811         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
2812         https://bugs.webkit.org/show_bug.cgi?id=189382
2813
2814         Reviewed by Ryosuke Niwa.
2815
2816         Fix the test by specifying colors in RGB colorspace.
2817
2818         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2819         (TestWebKitAPI::TEST):
2820
2821 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2822
2823         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
2824         https://bugs.webkit.org/show_bug.cgi?id=189496
2825
2826         Reviewed by Alex Christensen.
2827
2828         * ImageDiff/cairo/PlatformImageCairo.cpp:
2829         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
2830         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
2831
2832 2018-09-07  Dean Jackson  <dino@apple.com>
2833
2834         Add and expose Internal features from WebKit
2835         https://bugs.webkit.org/show_bug.cgi?id=189442
2836         <rdar://problem/44243404>
2837
2838         Reviewed by Simon Fraser.
2839
2840         Update MiniBrowser to expose an Internal feature menu.
2841
2842         * MiniBrowser/mac/AppDelegate.m:
2843         (defaultConfiguration):
2844         * MiniBrowser/mac/SettingsController.m:
2845         (-[SettingsController _populateMenu]):
2846         (-[SettingsController validateMenuItem:]):
2847         (-[SettingsController toggleExperimentalFeature:]):
2848         (-[SettingsController toggleInternalDebugFeature:]):
2849
2850 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2851
2852         [macOS] [WK2] Support changing foreground colors via color panel
2853         https://bugs.webkit.org/show_bug.cgi?id=189382
2854         <rdar://problem/44227311>
2855
2856         Reviewed by Ryosuke Niwa.
2857
2858         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
2859         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
2860         colors, as well as making different parts of a word different colors.
2861
2862         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2863         (-[TestWKWebView collapseToEnd]):
2864         (webViewForFontManagerTesting):
2865         (TestWebKitAPI::TEST):
2866         * TestWebKitAPI/cocoa/TestWKWebView.h:
2867
2868 == Rolled over to ChangeLog-2018-09-11 ==