c4f286cd87cc3fe4d5f04d82e1aa9ec9eaf8442e
[WebKit-https.git] / Tools / ChangeLog
1 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r87257.
4         http://trac.webkit.org/changeset/87257
5         https://bugs.webkit.org/show_bug.cgi?id=61457
6
7         This broke layout tests, see bug 61431. (Requested by
8         hwennborg on #webkit).
9
10         * DumpRenderTree/chromium/LayoutTestController.cpp:
11         (LayoutTestController::LayoutTestController):
12         (LayoutTestController::clearAllDatabases):
13         * DumpRenderTree/chromium/LayoutTestController.h:
14
15 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
16
17         Reviewed by Andreas Kling.
18
19         [Qt] fast/css/disabled-author-styles.html failed
20         https://bugs.webkit.org/show_bug.cgi?id=61438
21
22         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
23
24         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
25         (WebCore::WebPage::resetSettings):
26         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
27         (LayoutTestController::setAuthorAndUserStylesEnabled):
28         * DumpRenderTree/qt/LayoutTestControllerQt.h:
29
30 2011-05-25  Adam Roben  <aroben@apple.com>
31
32         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
33
34         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
35         started exiting early due to too many crashes, timeouts, or failures
36
37         Reviewed by David Kilzer.
38
39         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
40         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
41         run-webkit-tests exits early due to too many failures, pass that information in another
42         argument to the callback.
43         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
44         the new structure of the object passed to the callback.
45         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
46         getNumberOfFailingTests and to pass that along to our own callbacks.
47         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
48         from _getFailingTests and to store that value in the history object.
49
50         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
51         (.info): Added.
52
53         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
54         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
55         object and to add a note when run-webkit-tests exited early due to too many failures.
56         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
57         latestBuildInfos since each entry now contains more than just the tester and failure count.
58         Now displays a message for testers where the latest build exited early due to too many
59         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
60         store that value in latestBuildInfos.
61
62 2011-05-24  Keishi Hattori  <keishi@webkit.org>
63
64         Reviewed by Kent Tamura.
65
66         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
67         https://bugs.webkit.org/show_bug.cgi?id=61273
68
69         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
70
71 2011-05-24  Greg Simon  <gregsimon@chromium.org>
72
73         Reviewed by Dimitri Glazkov.
74
75         Control Indexeddb backends from LayoutTestController
76         https://bugs.webkit.org/show_bug.cgi?id=61000
77
78         * DumpRenderTree/chromium/LayoutTestController.cpp:
79         (LayoutTestController::LayoutTestController):
80         (LayoutTestController::setOverrideIndexedDBBackingStore):
81         (LayoutTestController::clearAllDatabases):
82         * DumpRenderTree/chromium/LayoutTestController.h:
83
84 2011-05-24  Robert Hogan  <robert@webkit.org>
85
86         Reviewed by Ryosuke Niwa.
87
88         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
89         https://bugs.webkit.org/show_bug.cgi?id=61393
90
91         * DumpRenderTree/qt/EventSenderQt.h:
92         * DumpRenderTree/qt/EventSenderQt.cpp:
93         (getModifiers): static function for interpreting modifiers
94         (EventSender::mouseDown): Respect keyboard modifiers
95         (EventSender::keyDown): use new static function
96         (EventSender::sendOrQueueEvent): whitespace fix
97
98 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
99
100         Reviewed by Adam Barth.
101
102         Adding MHTML reading support.
103         https://bugs.webkit.org/show_bug.cgi?id=7168
104
105         * Scripts/build-webkit:
106         * Scripts/old-run-webkit-tests:
107         * Scripts/webkitperl/features.pm:
108         * Scripts/webkitpy/layout_tests/port/test_files.py:
109         * Scripts/webkitpy/layout_tests/port/webkit.py:
110
111 2011-05-24  Stephen White  <senorblanco@chromium.org>
112
113         Reviewed by Kenneth Russell.
114
115         Remove most style checks on Source/ThirdParty/glu, since it doesn't
116         follow WebKit style.
117         https://bugs.webkit.org/show_bug.cgi?id=61365
118
119         * Scripts/webkitpy/style/checker.py:
120
121 2011-05-24  Adam Roben  <aroben@apple.com>
122
123         Don't allow forcing builds through the build.webkit.org web interface
124
125         Someone has been forcing bogus builds.
126
127         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
128
129 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
130
131         Reviewed by Adam Roben.
132
133         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
134         https://bugs.webkit.org/show_bug.cgi?id=42669
135
136         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
137         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
138         Because that case changed the setting.
139
140         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
141         (WTR::InjectedBundle::beginTesting):
142
143 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
144
145         Reviewed by Kenneth Rohde Christiansen.
146
147         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
148         https://bugs.webkit.org/show_bug.cgi?id=61052
149
150         * Scripts/old-run-webkit-tests:
151
152 2011-05-24  Adam Roben  <aroben@apple.com>
153
154         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
155
156         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
157         that don't have any failing tests, which isn't useful
158
159         Reviewed by David Kilzer.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
162         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
163         instead of name strings.
164         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
165         builder names into an array of builders.
166
167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
168         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
169         the most recently completed build, or -1 if there is no such build.
170         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
171         in the given build, or -1 if the number could not be determined. Some of this code came from
172         _getFailingTests.
173         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
174         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
175         getNumberOfFailingTests functions.
176
177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
178         (ViewController.prototype._displayTesters): Get the current number of test failures for each
179         tester and show it in the list. Omit testers that have no failures at all. We keep the
180         testers and failure counts in an array and sort it before displaying the current data, as
181         the order in which data will be fetched is unpredictable.
182
183 2011-05-23  Tony Chang  <tony@chromium.org>
184
185         Reviewed by Ojan Vafai.
186
187         [nrwt] don't use NetworkTranslation when uploading results
188         https://bugs.webkit.org/show_bug.cgi?id=61315
189
190         This avoids autoinstalling mechanize.  It didn't matter anyway
191         because test_results_uploader.py wasn't using mechanize to make the
192         request so NetworkTransaction::run wasn't doing anything extra
193         (it only matters if it catches mechanize.HTTPError).
194
195         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
196
197 2011-05-23  Tony Chang  <tony@chromium.org>
198
199         Reviewed by Dirk Pranke.
200
201         [chromium] fix the rebaseline tool to work with Linux GPU failures
202         https://bugs.webkit.org/show_bug.cgi?id=61312
203
204         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
205
206 2011-05-23  Darin Adler  <darin@apple.com>
207
208         Ignore generated .pyc files in a directory full of python code.
209
210         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
211
212 2011-05-23  Adam Barth  <abarth@webkit.org>
213
214         Reviewed by Eric Seidel.
215
216         sheriffbot should give more details about the failures in IRC
217         https://bugs.webkit.org/show_bug.cgi?id=61233
218
219         With this patch, sheriffbot will annonce the set of failing tests,
220         which might help folks triage the problem.
221
222         * Scripts/webkitpy/tool/commands/sheriffbot.py:
223         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
224
225 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
226
227         Unreviewed, rolling out r87078.
228         http://trac.webkit.org/changeset/87078
229         https://bugs.webkit.org/show_bug.cgi?id=61294
230
231         Patch contains errors and seems likely to break a bunch of
232         bots (Requested by abarth on #webkit).
233
234         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
235         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
236         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
237
238 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
239
240         Reviewed by Ojan Vafai.
241
242         Convert json_results_generator.py to output version 4 JSON.
243         https://bugs.webkit.org/show_bug.cgi?id=60869
244
245         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
246         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
247         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
248
249 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
250
251         Reviewed by Adam Barth.
252
253         Move generation of shell_command from port to executive
254         https://bugs.webkit.org/show_bug.cgi?id=61251
255
256         After move it's possible to use the code in other places too.
257
258         * Scripts/webkitpy/common/config/ports.py:
259         * Scripts/webkitpy/common/system/executive.py:
260
261 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
262
263         Reviewed by Darin Adler.
264
265         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
266         https://bugs.webkit.org/show_bug.cgi?id=42669
267
268         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
269
270         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
271         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
272         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
273         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
274
275 2011-05-22  Robert Hogan  <robert@webkit.org>
276
277         Reviewed by Kenneth Rohde Christiansen.
278
279         Fix policyDelegate in Qt DRT
280         https://bugs.webkit.org/show_bug.cgi?id=61247
281
282         Use the 'policy delegate' implemented in FrameLoaderClient
283         for layout tests. The partial implementation in DumpRenderTreeQt
284         is redundant, so remove it.
285
286         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
287         (WebCore::WebPage::acceptNavigationRequest):
288         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
289         (LayoutTestController::waitForPolicyDelegate):
290
291 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
292
293         Reviewed by Darin Adler.
294
295         Use double quotes for filename arguments
296         https://bugs.webkit.org/show_bug.cgi?id=61250
297
298         Windows does not support single quotes on the command line,
299         so replace them with double quotes.
300
301         * Scripts/prepare-ChangeLog:
302
303 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
304
305         Reviewed by Sam Weinig.
306
307         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
308         https://bugs.webkit.org/show_bug.cgi?id=42550
309         
310         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
311
312         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
313         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
314         Copy the code for pausing animations, FIXME comments and all.
315         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
316         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
317
318 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
319
320         Reviewed by Stephen White.
321
322         Adding myself to the committers list.
323
324         * Scripts/webkitpy/common/config/committers.py:
325
326 2011-05-19  Adam Roben  <aroben@apple.com>
327
328         Test that the WebKit2 UI process doesn't crash when starting a download
329
330         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
331         (preceded by assertion) in fastMalloc when downloading a file
332
333         Reviewed by Darin Adler.
334
335         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
336
337         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
338         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
339         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
340         started, cancel the download, and return a bogus string.
341
342         (TestWebKitAPI::setContextDownloadClient):
343         (TestWebKitAPI::setPagePolicyClient):
344         Simple helper functions.
345
346         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
347         our policy client, and run until we know that the download was started. If we haven't
348         crashed, we win!
349
350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
351         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
352         * TestWebKitAPI/win/copy-resources.cmd:
353         Added new files.
354
355 2011-05-20  Kent Tamura  <tkent@chromium.org>
356
357         Reviewed by Ryosuke Niwa.
358
359         Fix style errors in DumpRenderTree/chromium/.
360         https://bugs.webkit.org/show_bug.cgi?id=61172
361
362         * DumpRenderTree/chromium/CppBoundClass.cpp:
363         (CppBoundClass::getAsCppVariant):
364         (CppBoundClass::bindToJavascript):
365         * DumpRenderTree/chromium/CppBoundClass.h:
366         (CppBoundClass::GetterCallback::~GetterCallback):
367         (CppBoundClass::CppBoundClass):
368         (CppBoundClass::Callback::~Callback):
369         (CppBoundClass::MemberCallback::MemberCallback):
370         (CppBoundClass::MemberCallback::~MemberCallback):
371         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
372         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
373         * DumpRenderTree/chromium/CppVariant.h:
374         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
375         (DRTDevToolsAgent::~DRTDevToolsAgent):
376         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
377         (DRTDevToolsClient::sendFrontendLoaded):
378         * DumpRenderTree/chromium/DRTDevToolsClient.h:
379         * DumpRenderTree/chromium/DumpRenderTree.cpp:
380         (main):
381         * DumpRenderTree/chromium/EventSender.cpp:
382         (SavedEvent::SavedEvent):
383         (EventSender::EventSender):
384         (EventSender::keyDown):
385         * DumpRenderTree/chromium/EventSender.h:
386         * DumpRenderTree/chromium/ImageDiff.cpp:
387         (Image::Image):
388         * DumpRenderTree/chromium/LayoutTestController.cpp:
389         (LayoutTestController::LayoutTestController):
390         (LayoutTestController::WorkQueue::reset):
391         (WorkItemBackForward::WorkItemBackForward):
392         (WorkItemLoadingScript::WorkItemLoadingScript):
393         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
394         (WorkItemLoad::WorkItemLoad):
395         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
396         (LayoutTestController::pathToLocalResource):
397         * DumpRenderTree/chromium/LayoutTestController.h:
398         (LayoutTestController::WorkItem::~WorkItem):
399         (LayoutTestController::WorkQueue::WorkQueue):
400         * DumpRenderTree/chromium/MockSpellCheck.cpp:
401         (MockSpellCheck::MockSpellCheck):
402         (MockSpellCheck::~MockSpellCheck):
403         * DumpRenderTree/chromium/MockSpellCheck.h:
404         * DumpRenderTree/chromium/NotificationPresenter.h:
405         (NotificationPresenter::NotificationPresenter):
406         * DumpRenderTree/chromium/Task.cpp:
407         (WebTask::WebTask):
408         * DumpRenderTree/chromium/Task.h:
409         (TaskList::TaskList):
410         * DumpRenderTree/chromium/TestEventPrinter.cpp:
411         (DRTPrinter::DRTPrinter):
412         (TestShellPrinter::TestShellPrinter):
413         * DumpRenderTree/chromium/TestNavigationController.cpp:
414         (TestNavigationEntry::TestNavigationEntry):
415         (TestNavigationEntry::~TestNavigationEntry):
416         (TestNavigationController::TestNavigationController):
417         (TestNavigationController::reload):
418         (TestNavigationController::loadEntry):
419         (TestNavigationController::didNavigateToEntry):
420         * DumpRenderTree/chromium/TestNavigationController.h:
421         (TestShellExtraData::TestShellExtraData):
422         * DumpRenderTree/chromium/TestShell.cpp:
423         (dumpHistoryItem):
424         * DumpRenderTree/chromium/TestShell.h:
425         (TestParams::TestParams):
426         * DumpRenderTree/chromium/TestShellWin.cpp:
427         (TestShell::waitTestFinished):
428         * DumpRenderTree/chromium/TestWebWorker.h:
429         (TestWebWorker::startWorkerContext):
430         (TestWebWorker::terminateWorkerContext):
431         (TestWebWorker::postMessageToWorkerContext):
432         (TestWebWorker::clientDestroyed):
433         (TestWebWorker::postMessageToWorkerObject):
434         (TestWebWorker::postExceptionToWorkerObject):
435         (TestWebWorker::postConsoleMessageToWorkerObject):
436         (TestWebWorker::confirmMessageFromWorkerObject):
437         (TestWebWorker::reportPendingActivity):
438         (TestWebWorker::workerContextClosed):
439         (TestWebWorker::~TestWebWorker):
440         * DumpRenderTree/chromium/TextInputController.cpp:
441         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
442         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
443         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
444         (WebThemeEngineDRTWin::paintButton):
445         (WebThemeEngineDRTWin::paintMenuList):
446         (WebThemeEngineDRTWin::paintTrackbar):
447         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
448         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
449         * DumpRenderTree/chromium/WebViewHost.cpp:
450         (WebViewHost::navigate):
451         (WebViewHost::updateSessionHistory):
452         (WebViewHost::paintInvalidatedRegion):
453         * DumpRenderTree/chromium/WebViewHost.h:
454
455 2011-05-19  Dmitry Lomov  <dslomov@google.com>
456
457         Reviewed by Adam Roben.
458
459         Detect hangs in run-api-tests
460         https://bugs.webkit.org/show_bug.cgi?id=48043
461
462         * Scripts/run-api-tests: Added test timeouts
463
464 2011-05-19  Dmitry Lomov  <dslomov@google.com>
465
466         Reviewed by Adam Roben.
467
468         run-api-tests should run one test per process
469         https://bugs.webkit.org/show_bug.cgi?id=61088
470
471         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
472         return code, and parsing GTest output format.
473
474 2011-05-15  Robert Hogan  <robert@webkit.org>
475
476         Reviewed by Antonio Gomes.
477
478         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
479         https://bugs.webkit.org/show_bug.cgi?id=60834
480         Fix unix test plugin for plugins/get-url-with-javascript-url.html
481
482         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
483         (webkit_test_plugin_new_stream):
484         (webkit_test_plugin_write_ready):
485         (webkit_test_plugin_write):
486
487 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
488
489         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
490         http://trac.webkit.org/changeset/86869
491         http://trac.webkit.org/changeset/86873
492         http://trac.webkit.org/changeset/86875
493         http://trac.webkit.org/changeset/86877
494         https://bugs.webkit.org/show_bug.cgi?id=61139
495
496         broke builds and debug DRT (Requested by rniwa on #webkit).
497
498         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
499         * DumpRenderTree/chromium/TestShell.cpp:
500         (TestShell::bindJSObjectsToWindow):
501         * DumpRenderTree/mac/FrameLoadDelegate.mm:
502         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
503
504 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
505
506         Reviewed by Darin Adler.
507
508         Add build logistics and plumbing for window.internals object.
509         https://bugs.webkit.org/show_bug.cgi?id=60313
510
511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
512         * DumpRenderTree/chromium/TestShell.cpp:
513         (TestShell::bindJSObjectsToWindow): Added injection code.
514         * DumpRenderTree/mac/FrameLoadDelegate.mm:
515         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
516
517 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
518
519         Reviewed by Csaba Osztrogonác.
520
521         [Qt] Implement eventSender.scalePageBy
522         https://bugs.webkit.org/show_bug.cgi?id=60015
523
524         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
525         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
526         * DumpRenderTree/qt/EventSenderQt.cpp:
527         (EventSender::scalePageBy):
528         * DumpRenderTree/qt/EventSenderQt.h:
529
530 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
531
532         Reviewed by Kent Tamura.
533
534         [Chromium] IME candidate window appears wrong position in an iframe
535         https://bugs.webkit.org/show_bug.cgi?id=61023
536
537         Call the focused frame's firstRectForCharacterRange() instead of the
538         main frame so that DRT behaves as the same as Chromium.
539
540         * DumpRenderTree/chromium/TextInputController.cpp:
541         (TextInputController::firstRectForCharacterRange):
542
543 2011-05-18  Adam Roben  <aroben@apple.com>
544
545         Add a new page to build.webkit.org to help find when tests started failing
546
547         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
548         right now, but already shows some useful information. It's somewhat similar to webkit-patch
549         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
550         little more convenient than either of them, though, because it's all done in the browser
551         (and thus it's easy to go directly to the relevant test results).
552
553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
554         (Buildbot): This class represents a Buildbot server.
555         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
556         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
557         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
558         callback.
559         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
560         be implemented by a derived class that understands this server's build naming scheme.
561         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
562         particular build.
563
564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
565         (Builder): This class represents one builder on the buildbot.
566         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
567         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
568         information about a particular test failure.
569         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
570         information about when tests started failing.
571         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
572         particular build.
573         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
574         callback.
575         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
576         extracts all the failing tests listed in it, passing them to the callback.
577         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
578         build, merges them into the build history, and calls the callback telling it whether the
579         next build should be fetched to provide more information.
580
581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
582         Added. Just some simple styles.
583
584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
585         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
586         (getResource): Wrapper around XMLHttpRequest.
587         (Array.prototype.findFirst): Finds the first element matching the given predicate and
588         returns it.
589         (Array.prototype.last): Returns the last element of the array.
590
591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
592         (ViewController): This class contains the main logic for displaying the page.
593         (ViewController.loaded): Just calls through to parseHash.
594         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
595         shows the list of all testers so one can be chosen. This function is called when the page
596         loads and whenever we get a hashchange event.
597         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
598         as it is fetched. The display ends up grouping tests by when they started failing.
599         (ViewController._displayTesters): Gets the list of testers and displays it.
600
601         (ViewController._domForBuildName):
602         (ViewController._domForFailedTest):
603         Helper functions to create descriptions and links for a particular build or failed test.
604
605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
606         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
607         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
608
609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
610         loads all the files and sets up a ViewController, which does the rest.
611
612         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
613         page.
614
615 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
616
617         Reviewed by Csaba Osztrogonác.
618
619         [Qt] Implement layoutTestController.setValueForUser()
620         https://bugs.webkit.org/show_bug.cgi?id=60956
621
622         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
623         (LayoutTestController::setValueForUser):
624         * DumpRenderTree/qt/LayoutTestControllerQt.h:
625
626 2011-05-16  Robert Hogan  <robert@webkit.org>
627
628         Reviewed by Kenneth Rohde Christiansen.
629
630         plugins/invalidate_rect.html fails on linux ports
631
632         - Make the unix test netscape plugin recognize the onPaintEvent
633           and windowedPlugin parameters.
634
635         https://bugs.webkit.org/show_bug.cgi?id=54051
636
637         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
638         (handleEventX11):
639         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
640         (LayoutTestController::displayInvalidatedRegion):
641         * DumpRenderTree/qt/LayoutTestControllerQt.h:
642         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
643         (webkit_test_plugin_new_instance):
644         (webkit_test_plugin_handle_event):
645
646 2011-05-17  Tony Chang  <tony@chromium.org>
647
648         Reviewed by Ojan Vafai.
649
650         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
651         https://bugs.webkit.org/show_bug.cgi?id=60895
652
653         Update the tools to handle the move.  Lucid 32 results now go in
654         chromium-linux-x86 and the default platform on Linux is now x86_64.
655
656         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
657         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
658         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
659         * Scripts/webkitpy/layout_tests/port/base.py: ditto
660         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
661         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
662         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
663         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
664         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
665
666 2011-05-17  Adam Roben  <aroben@apple.com>
667
668         Make run-api-tests work on Windows when there are spaces in the path
669
670         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
671         spaces in the path to TestWebKitAPI.exe
672
673         Reviewed by David Levin.
674
675         * Scripts/run-api-tests:
676         (runTestTool): Use the "direct object" form of system() to avoid having the path to
677         TestWebKitAPI.exe be split by the shell.
678
679 2011-05-16  Ian Henderson  <ianh@apple.com>
680
681         Reviewed by Joseph Pecoraro.
682
683         Page::goToItem doesn't work while loading is deferred
684         https://bugs.webkit.org/show_bug.cgi?id=60412
685
686         Add setDefersLoading and goBack methods to LayoutTestController.  We
687         need to use goBack() instead of history.back() because the latter goes
688         through NavigationScheduler, hence doesn't exhibit the bug.
689
690         * DumpRenderTree/LayoutTestController.cpp:
691         (goBackCallback):
692         (setDefersLoadingCallback):
693         (LayoutTestController::staticFunctions):
694         * DumpRenderTree/LayoutTestController.h:
695         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
696         (LayoutTestController::goBack):
697         (LayoutTestController::setDefersLoading):
698         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
699         (LayoutTestController::goBack):
700         (LayoutTestController::setDefersLoading):
701         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
702         (LayoutTestController::goBack):
703         (LayoutTestController::setDefersLoading):
704         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
705         (LayoutTestController::goBack):
706         (LayoutTestController::setDefersLoading):
707
708 2011-05-16  Sam Weinig  <sam@webkit.org>
709
710         Reviewed by Anders Carlsson.
711
712         TestWebKitAPI should build with clang if it can
713         https://bugs.webkit.org/show_bug.cgi?id=60918
714
715         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
716         Update CompilerVersion.xcconfig to match others.
717
718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
719         Add CompilerVersion.xcconfig to the project.
720
721         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
722         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
723         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
724         (TestWebKitAPI::didSameDocumentNavigationForFrame):
725         Add some casts to quiet warnings from clang.
726
727 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
728
729         Reviewed by David Levin.
730
731         add dpranke as a reviewer
732         https://bugs.webkit.org/show_bug.cgi?id=60919
733
734         * Scripts/webkitpy/common/config/committers.py:
735
736 2011-05-16  Robert Hogan  <robert@webkit.org>
737
738         Reviewed by Anders Carlsson.
739
740         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
741
742         https://bugs.webkit.org/show_bug.cgi?id=60838
743
744         The unix test plugin needs to call the test's NPP_URLNotify
745         rather than the browsers.
746
747         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
748         (webkit_test_plugin_url_notify):
749
750 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
751
752         Rubber-stamped by Adam Roben.
753
754         Adding myself as a reviewer.
755         * Scripts/webkitpy/common/config/committers.py:
756
757 2011-05-16  Sam Weinig  <sam@webkit.org>
758
759         Fix typo pointed out by Dave Levin.
760
761         * TestWebKitAPI/PlatformUtilities.h:
762         (TestWebKitAPI::Util::assertWKStringEqual):
763         Strig -> String.
764
765 2011-05-16  Sam Weinig  <sam@webkit.org>
766
767         Reviewed by David Levin.
768
769         Convert api tester over to using gtest expectations directly
770         https://bugs.webkit.org/show_bug.cgi?id=60862
771
772         * TestWebKitAPI/PlatformUtilities.cpp:
773         (TestWebKitAPI::Util::toSTD):
774         * TestWebKitAPI/PlatformUtilities.h:
775         (TestWebKitAPI::Util::assertWKStrigEqual):
776         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
777         the implementation of the macro simpler.
778
779         * TestWebKitAPI/Test.h:
780         Remove TEST_ASSERT forwarder.
781
782         [Test changes elided]
783
784 2011-05-16  David Kilzer  <ddkilzer@apple.com>
785
786         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
787         <rdar://problem/9446430>
788
789         Reviewed by Mark Rowe.
790
791         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
792         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
793         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
794
795 2011-05-16  Jon Lee  <jonlee@apple.com>
796
797         Reviewed by Simon Fraser.
798
799         Can't horizontally scroll iframes and overflow because wheel events are always accepted
800         https://bugs.webkit.org/show_bug.cgi?id=60779
801
802         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
803         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
804
805 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
806
807         Reviewed by Csaba Osztrogonác.
808
809         [Qt] Tools.pro misses include(common.pri)
810         https://bugs.webkit.org/show_bug.cgi?id=60883
811
812         It includes features.pri, which depends on common.pri (the build is
813         not broken today with the default options, but this is the right
814         thing to do).
815
816         * Tools.pro:
817
818 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
819
820         Unreviewed: adding myself to committers.py.
821
822         * Scripts/webkitpy/common/config/committers.py:
823
824 2011-05-15  Daniel Bates  <dbates@webkit.org>
825
826         Reviewed by Chris Jerdonek.
827
828         svn-apply can't handle Git diff that only changes executable bit
829         https://bugs.webkit.org/show_bug.cgi?id=60848
830
831         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
832         that only has an executable bit change.
833
834         * Scripts/VCSUtils.pm:
835           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
836         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
837         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
838         * Scripts/svn-apply:
839         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
840         * Scripts/svn-unapply:
841         (patch): Ditto.
842         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
843           - Updated expected results for test cases to account for numTextChunks.
844           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
845           - Added test case "Git: file that only has an executable bit change".
846         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
847           - Updated expected results for test cases to account for numTextChunks.
848
849 2011-05-15  Sam Weinig  <sam@webkit.org>
850
851         Fix windows build.
852
853         * TestWebKitAPI/win/main.cpp:
854         (main):
855
856 2011-05-15  Sam Weinig  <sam@webkit.org>
857
858         Reviewed by David Levin.
859
860         Make API tester more gtest friendly
861         https://bugs.webkit.org/show_bug.cgi?id=60859
862
863         * Scripts/run-api-tests:
864         Numerous changes:
865         - Remove logic to run tests one at a time.
866         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
867           the test runner and allow gtest to print it for us.
868         - Forward stdout from the test tool to stdout, even in non-verbose runs.
869         - Run test tool from the current working directory instead of the root webkit
870           directory.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         Move plist to be with other bundle sources.
874
875         * TestWebKitAPI/TestsController.cpp:
876         (TestWebKitAPI::TestsController::TestsController):
877         (TestWebKitAPI::TestsController::run):
878         * TestWebKitAPI/TestsController.h:
879         * TestWebKitAPI/mac/main.mm:
880         Simplify TestController down to a single run function. We should consider removing the class
881         entirely at some point.
882
883 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
884
885         Unreviewed, rolling out r86504.
886         http://trac.webkit.org/changeset/86504
887         https://bugs.webkit.org/show_bug.cgi?id=60853
888
889         "Broke Qt EventSender in editing/selection tests" (Requested
890         by mwenge on #webkit).
891
892         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
893         (WebCore::WebPage::WebPage):
894         (WebCore::DumpRenderTree::DumpRenderTree):
895         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
896         (WebCore::DumpRenderTree::initJSObjects):
897         * DumpRenderTree/qt/DumpRenderTreeQt.h:
898         (WebCore::DumpRenderTree::eventSender):
899         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
900         (webkit_test_plugin_new_instance):
901         (webkit_test_plugin_set_window):
902         (webkit_test_plugin_handle_event):
903
904 2011-05-12  Robert Hogan  <robert@webkit.org>
905
906         Reviewed by Benjamin Poulain.
907
908         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
909
910         The support for this test added to the unix test plugin here
911         may allow other platforms to pass it (nearly everyone
912         skips it). On Qt it required a bit of trickiness with
913         the page's EventSender object to get it working fully though,
914         so only unskipping Qt here.
915
916         https://bugs.webkit.org/show_bug.cgi?id=60722
917
918         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
919         (WebCore::WebPage::WebPage):
920         (WebCore::WebPage::eventSender):
921         (WebCore::DumpRenderTree::DumpRenderTree):
922         (WebCore::DumpRenderTree::initJSObjects):
923         (WebCore::DumpRenderTree::createWindow):
924         * DumpRenderTree/qt/DumpRenderTreeQt.h:
925         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
926         (webkit_test_plugin_new_instance):
927         (webkit_test_plugin_set_window):
928         (webkit_test_plugin_handle_event):
929
930 2011-05-14  Arno Renevier  <arno@renevier.net>
931
932         Reviewed by Martin Robinson.
933
934         make run-gtk-tests executable
935         https://bugs.webkit.org/show_bug.cgi?id=59278
936
937         * Scripts/run-gtk-tests:
938
939 2011-05-14  Anders Carlsson  <andersca@apple.com>
940
941         Reviewed by Kevin Decker.
942
943         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
944         https://bugs.webkit.org/show_bug.cgi?id=60823
945         <rdar://problem/9430386>
946
947         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
948
949         * DumpRenderTree/DumpRenderTree.gypi:
950         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
951         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
952         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
953         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
954         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
955         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
956         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
957         * GNUmakefile.am:
958
959 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
960
961         Unreviewed, rolling out r86476.
962         http://trac.webkit.org/changeset/86476
963         https://bugs.webkit.org/show_bug.cgi?id=60832
964
965         It made plugins/get-url-notify-with-url-that-fails-to-
966         load.html crash on GTK (Requested by Ossy on #webkit).
967
968         * DumpRenderTree/DumpRenderTree.gypi:
969         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
970         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
971         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
972         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
973         * GNUmakefile.am:
974
975 2011-05-13  Anders Carlsson  <andersca@apple.com>
976
977         Reviewed by Sam Weinig.
978
979         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
980         https://bugs.webkit.org/show_bug.cgi?id=60823
981         <rdar://problem/9430386>
982
983         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
984
985         * DumpRenderTree/DumpRenderTree.gypi:
986         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
987         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
988         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
989         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
990         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
991         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
992         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
993         * GNUmakefile.am:
994
995 2011-05-13  Anders Carlsson  <andersca@apple.com>
996
997         Build fix.
998
999         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
1000
1001 2011-05-13  Anders Carlsson  <andersca@apple.com>
1002
1003         Reviewed by Sam Weinig.
1004
1005         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
1006         https://bugs.webkit.org/show_bug.cgi?id=60810
1007
1008         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
1009
1010         * DumpRenderTree/DumpRenderTree.gypi:
1011         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1012         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1013         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1014         * GNUmakefile.am:
1015         Add files.
1016
1017         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1018         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1019         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
1020
1021         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
1022         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
1023         (GetURLWithJavaScriptURL::NPP_New):
1024         (GetURLWithJavaScriptURL::NPP_NewStream):
1025         (GetURLWithJavaScriptURL::NPP_DestroyStream):
1026         (GetURLWithJavaScriptURL::NPP_WriteReady):
1027         (GetURLWithJavaScriptURL::NPP_Write):
1028         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1029         (NPP_NewStream):
1030         (NPP_WriteReady):
1031         (NPP_Write):
1032         (NPP_URLNotify):
1033         call the PluginTest NPP wrappers.
1034
1035 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1036
1037         Unreviewed, rolling out r86447.
1038         http://trac.webkit.org/changeset/86447
1039         https://bugs.webkit.org/show_bug.cgi?id=60809
1040
1041         "Broke some uses of EventSender object on Qt" (Requested by
1042         mwenge on #webkit).
1043
1044         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1045         (WebCore::WebPage::WebPage):
1046         (WebCore::DumpRenderTree::DumpRenderTree):
1047         (WebCore::DumpRenderTree::initJSObjects):
1048         (WebCore::DumpRenderTree::createWindow):
1049         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1050         (WebCore::DumpRenderTree::eventSender):
1051         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1052         (webkit_test_plugin_new_instance):
1053         (webkit_test_plugin_set_window):
1054         (webkit_test_plugin_handle_event):
1055
1056 2011-05-13  Robert Hogan  <robert@webkit.org>
1057
1058         Reviewed by Benjamin Poulain.
1059
1060         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1061
1062         The support for this test added to the unix test plugin here
1063         may allow other platforms to pass it (nearly everyone
1064         skips it). On Qt it required a bit of trickiness with
1065         the page's EventSender object to get it working fully though,
1066         so only unskipping Qt here.
1067
1068         https://bugs.webkit.org/show_bug.cgi?id=60722
1069
1070         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1071         (WebCore::WebPage::WebPage):
1072         (WebCore::WebPage::eventSender):
1073         (WebCore::DumpRenderTree::DumpRenderTree):
1074         (WebCore::DumpRenderTree::initJSObjects):
1075         (WebCore::DumpRenderTree::createWindow):
1076         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1077         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1078         (webkit_test_plugin_new_instance):
1079         (webkit_test_plugin_set_window):
1080         (webkit_test_plugin_handle_event):
1081
1082 2011-05-13  Adam Roben  <aroben@apple.com>
1083
1084         Exclude the Leopard NRWT bot from the core builder set
1085
1086         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
1087
1088         Reviewed by Darin Adler.
1089
1090         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1091         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
1092         in the core builder set.
1093
1094         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1095         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
1096         regexps.
1097
1098 2011-05-13  Adam Roben  <aroben@apple.com>
1099
1100         Group all the NRWT bots together
1101
1102         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
1103         bots are experimental, it seems best not to clutter up the non-experimental bots with
1104         experimental ones.
1105
1106         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
1107         on build.webkit.org
1108
1109         Reviewed by Dan Bernstein.
1110
1111         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
1112         Chromium testers, which also use new-run-webkit-tests.
1113
1114 2011-05-13  Adam Roben  <aroben@apple.com>
1115
1116         Add a plugin test that dumps the plugin window's rect
1117
1118         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
1119         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
1120
1121         Reviewed by Dan Bernstein.
1122
1123         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
1124         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
1125         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
1126         harness window and log it.
1127
1128         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
1129
1130 2011-05-13  Adam Roben  <aroben@apple.com>
1131
1132         Move code required for most tests of plugin window geometry into a base class
1133
1134         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
1135         having all the trickiness in a shared base class, writing new window geometry tests will be
1136         much easier.
1137
1138         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
1139
1140         Reviewed by Anders Carlsson.
1141
1142         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1143         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
1144         WindowGeometryTest base class. Most of the code from this class was moved to the new base
1145         class.
1146         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
1147         This is called by the base class when it is safe to check the window's geometry. Note that
1148         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
1149         just vestigial code from an earlier version of this test.
1150
1151         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
1152         WindowGeometryTest class.
1153
1154         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
1155         WindowRegionIsSetToClipRect.
1156         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
1157         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
1158         Subclasses can implement that function to perform their own tests.
1159
1160         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
1161
1162 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
1163
1164         Reviewed by Csaba Osztrogonác.
1165
1166         Missing 2nd #EOF if WebProcess is killed.
1167         https://bugs.webkit.org/show_bug.cgi?id=60761
1168
1169         If the WebProcess is killed, only one #EOF is yielded
1170         by WebKitTestRunner. However, run-webkit-test wait for
1171         a second #EOF, which signals the finishing of pixel dump.
1172         Since this never happens, run-webkit-test waits forever.
1173
1174         * WebKitTestRunner/TestInvocation.cpp:
1175         (WTR::TestInvocation::dump):
1176         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1177         * WebKitTestRunner/TestInvocation.h:
1178
1179 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1180
1181         Reviewed by Csaba Osztrogonác.
1182
1183         [NRWT] chromium-linux tests shouldn't run on other platforms
1184         https://bugs.webkit.org/show_bug.cgi?id=60162
1185
1186         Remove _tests_for_other_platforms defs because r82753
1187         implemented it properly in the baseclass in webkit.py.
1188
1189         * Scripts/webkitpy/layout_tests/port/gtk.py:
1190         * Scripts/webkitpy/layout_tests/port/qt.py:
1191         * Scripts/webkitpy/layout_tests/port/win.py:
1192
1193 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
1194
1195         Reviewed by Antonio Gomes.
1196
1197         [EFL] Remove unused option of EWeblauncher
1198         https://bugs.webkit.org/show_bug.cgi?id=60747
1199
1200         Remove sudo-workaround option.
1201         This option is not used and make other option wrong.
1202
1203         * EWebLauncher/main.c:
1204
1205 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1206
1207         Reviewed by Stephanie Lewis.
1208
1209         Fix config.json to address missing WK2 builder/tester config.
1210         Fix naming of machines (xserve not macpro)
1211
1212         * BuildSlaveSupport/build.webkit.org-config/config.json:
1213
1214 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1215
1216         Reviewed by Stephanie Lewis.
1217
1218         Add SnowLeopard Debug builder and Test bot.
1219         apple-xserve-8 = SL Debug Tester.
1220         apple-xserve-9 = SL Debug Builder.
1221         
1222         * BuildSlaveSupport/build.webkit.org-config/config.json:
1223
1224 2011-05-12  Adam Barth  <abarth@webkit.org>
1225
1226         This patch disables sheriffbot's bug postings.  He's just been way too
1227         spammy recently due to test flakiness.
1228
1229         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1230         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1231
1232 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1233
1234         Reviewed by Anders Carlsson.
1235
1236         After relaunching an unresponsive web process, web page stops responding to mouse movement
1237         https://bugs.webkit.org/show_bug.cgi?id=60669
1238         <rdar://problem/9409934>
1239         
1240         This test follows the steps needed to reproduce this bug:
1241         1) Hang the web process
1242         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
1243         3) Kill and restart the WebProcess
1244         4) Move the mouse
1245         
1246         We are testing that we receive mouse move events after the WebProcess has restarted.
1247
1248         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
1249         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
1250         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
1251         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
1252         (TestWebKitAPI::setPageLoaderClient):
1253         (TestWebKitAPI::TEST):
1254         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
1255         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
1256         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
1257         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
1258
1259         * TestWebKitAPI/PlatformWebView.h:
1260         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1261         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
1262         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1263         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
1264
1265         Add new files.
1266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1267         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1268         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1269         * TestWebKitAPI/win/copy-resources.cmd:
1270
1271 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
1272
1273         Reviewed by Antonio Gomes.
1274
1275         [EFL] Added initialization/shutdown for ecore_file library
1276         https://bugs.webkit.org/show_bug.cgi?id=60457
1277
1278         Added initialization and shuthown for ecore_file library and replaced
1279         realpath function to ecore_file_realpath.
1280
1281         * EWebLauncher/main.c:
1282         (quit):
1283         (findThemePath):
1284         (main):
1285
1286 2011-05-12  Young Han Lee  <joybro@company100.net>
1287
1288         Reviewed by Kenneth Rohde Christiansen.
1289
1290         [Qt] Implement layoutTestController.layerTreeAsText()
1291         https://bugs.webkit.org/show_bug.cgi?id=60367
1292
1293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1294         (LayoutTestController::layerTreeAsText):
1295         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1296
1297 2011-05-11  Eric Seidel  <eric@webkit.org>
1298
1299         Reviewed by David Levin.
1300
1301         Teach validate-committer-lists how to validate committers bugzilla_email()
1302         https://bugs.webkit.org/show_bug.cgi?id=60651
1303
1304         It turns out we currently have 9 committers with invalid values for their
1305         bugzilla_email field (meaning we don't know what email is their bugzilla account).
1306         "Alexander Kellett" <lypanov@mac.com>
1307         "Andre Boule" <aboule@apple.com>
1308         "Cameron McCormack" <cam@webkit.org>
1309         "Chris Petersen" <cpetersen@apple.com>
1310         "Eli Fidler" <eli@staikos.net>
1311         "Matt Lilek" <webkit@mattlilek.com>
1312         "Pierre d'Herbemont" <pdherbemont@free.fr>
1313         "Scott Violet" <sky@chromium.org>
1314         "Adam Treat" <treat@kde.org>
1315
1316         Most of those haven't committed in a very long time, so it's not suprising
1317         that we haven't noticed that their bugzilla emails are bogus.
1318
1319         * Scripts/validate-committer-lists:
1320         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1321         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1322
1323 2011-05-11  Dmitry Lomov  <dslomov@google.com>
1324
1325         Reviewed by David Levin.
1326
1327         https://bugs.webkit.org/show_bug.cgi?id=59561
1328         Switch TestWebKitAPI to GTest
1329
1330         Fixes Makefiles and WinCairo build as well
1331
1332         * Makefile:
1333         * Scripts/build-api-tests:
1334         * Scripts/run-api-tests:
1335         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1336         * TestWebKitAPI/Test.h:
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1339         (TestWebKitAPI::TEST):
1340         * TestWebKitAPI/TestsController.cpp:
1341         (TestWebKitAPI::TestsController::TestsController):
1342         (TestWebKitAPI::TestsController::dumpTestNames):
1343         (TestWebKitAPI::TestsController::runTestNamed):
1344         (TestWebKitAPI::TestsController::runAllTests):
1345         * TestWebKitAPI/TestsController.h:
1346         * TestWebKitAPI/mac/main.mm:
1347         (main):
1348
1349 2011-05-11  Eric Seidel  <eric@webkit.org>
1350
1351         Reviewed by Alexey Proskuryakov.
1352
1353         Add Luke Macpherson to committers.py as a Contributor
1354         https://bugs.webkit.org/show_bug.cgi?id=60639
1355
1356         * Scripts/webkitpy/common/config/committers.py:
1357
1358 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
1359
1360         Reviewed by Kenneth Rohde Christiansen.
1361
1362         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
1363         https://bugs.webkit.org/show_bug.cgi?id=60439
1364
1365         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
1366
1367         * Scripts/build-webkit:
1368
1369 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1370
1371         Reviewed by Adam Roben.
1372
1373         REGRESSION (r86161): WKPreferences API test failing on Windows
1374         https://bugs.webkit.org/show_bug.cgi?id=60658
1375
1376         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1377         (TestWebKitAPI::TEST):
1378
1379 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
1380
1381         Reviewed by Ojan Vafai.
1382
1383         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
1384         https://bugs.webkit.org/show_bug.cgi?id=60521
1385
1386         First steps towards making the results JSON all hierarchical.
1387
1388         * TestResultServer/model/jsonresults.py:
1389         * TestResultServer/model/jsonresults_unittest.py:
1390
1391 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
1392
1393         [wx] Build fix, adding new LayoutTestController method stubs.
1394
1395         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1396         (LayoutTestController::localStorageDiskUsageForOrigin):
1397         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1398
1399 2011-05-11  Jessie Berlin  <jberlin@apple.com>
1400
1401         Reviewed by Darin Adler.
1402
1403         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
1404         about the usage for both the origin overall and the database in question.
1405         https://bugs.webkit.org/show_bug.cgi?id=60573
1406
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::exceededDatabaseQuota):
1409
1410 2011-05-10  Stephen White  <senorblanco@chromium.org>
1411
1412         Reviewed by David Levin.
1413
1414         Adding myself as a reviewer.
1415         https://bugs.webkit.org/show_bug.cgi?id=60587
1416
1417         * Scripts/webkitpy/common/config/committers.py:
1418
1419 2011-05-11  Eric Seidel  <eric@webkit.org>
1420
1421         Reviewed by Csaba Osztrogonác.
1422
1423         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
1424         https://bugs.webkit.org/show_bug.cgi?id=60614
1425
1426         AppEngine has a result limit of 1000.  We hit that when trying
1427         to find out how many patches the style-queue (and other queues)
1428         have passed in the last 30 days.  So lets display 1000+ instead
1429         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
1430
1431         I also made the status pages show "never" instead of just "ago" when we
1432         haven't seen a pass or boot message in the last 1000 messages.
1433
1434         * QueueStatusServer/handlers/queuestatus.py:
1435         * QueueStatusServer/templates/queuestatus.html:
1436
1437 2011-05-11  Adam Barth  <abarth@webkit.org>
1438
1439         Reviewed by Eric Seidel.
1440
1441         sheriffbot shouldn't spam bugs when it can't figure out who to blame
1442         https://bugs.webkit.org/show_bug.cgi?id=60613
1443
1444         This patch limits the number of bugs sheriffbot will spam to three.
1445         Ideally, we'd come up with some smarter huerstics, but hopefully this
1446         will cut down on the bugmail spam for slow bots.
1447
1448         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1449
1450 2011-05-10  Eric Seidel  <eric@webkit.org>
1451
1452         Reviewed by Adam Barth.
1453
1454         EWS bots should be robust against test-webkitpy hangs
1455         https://bugs.webkit.org/show_bug.cgi?id=60579
1456
1457         Added a killAfterTimeout subroutine, which takes a child_pid
1458         and timeout, and will setup a watchdog process to kill that child
1459         after the timeout.  killAfterTimeout will waitpid on the child.
1460
1461         * EWSTools/start-queue.sh:
1462
1463 2011-05-10  MORITA Hajime  <morrita@google.com>
1464
1465         Unreviewed, moved myself to the reviewers list.
1466
1467         * Scripts/webkitpy/common/config/committers.py:
1468
1469 2011-05-10  Anton D'Auria  <adauria@apple.com>
1470
1471         Reviewed by David Levin.
1472
1473         StorageTracker should report actual local storage usage on disk
1474         https://bugs.webkit.org/show_bug.cgi?id=60558
1475
1476         * DumpRenderTree/LayoutTestController.cpp:
1477         (localStorageDiskUsageForOriginCallback):
1478         (LayoutTestController::staticFunctions):
1479         * DumpRenderTree/LayoutTestController.h:
1480         * DumpRenderTree/chromium/LayoutTestController.cpp:
1481         (LayoutTestController::LayoutTestController):
1482         (LayoutTestController::localStorageDiskUsageForOrigin):
1483         * DumpRenderTree/chromium/LayoutTestController.h:
1484         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1485         (LayoutTestController::localStorageDiskUsageForOrigin):
1486         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1487         (LayoutTestController::localStorageDiskUsageForOrigin):
1488         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1489         (LayoutTestController::localStorageDiskUsageForOrigin):
1490         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1491         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1492         (LayoutTestController::localStorageDiskUsageForOrigin):
1493
1494 2011-05-10  Anton D'Auria  <adauria@apple.com>
1495
1496         Reviewed by Alexey Proskuryakov.
1497
1498         Add ApplicationCache API to get disk usage per origin
1499         https://bugs.webkit.org/show_bug.cgi?id=57127
1500
1501         Added test that loads two frames with ~15Kb image, checks usage,
1502         deletes app cache, verifies usage is 0.
1503
1504         * DumpRenderTree/LayoutTestController.cpp:
1505         (applicationCacheDiskUsageForOriginCallback):
1506         (LayoutTestController::staticFunctions):
1507         * DumpRenderTree/LayoutTestController.h:
1508         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1509         (LayoutTestController::LayoutTestController):
1510         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1511         * DumpRenderTree/chromium/LayoutTestController.h:
1512         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1513         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1514         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1515         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1516         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1517         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1518         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1519         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1520         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1521
1522 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1523
1524         Unreviewed, adding Rafael Antognolli as a committer.
1525
1526         * Scripts/webkitpy/common/config/committers.py:
1527
1528 2011-05-10  Chris Evans  <cevans@chromium.org>
1529
1530         Reviewed by Adam Barth.
1531
1532         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
1533         https://bugs.webkit.org/show_bug.cgi?id=58378
1534
1535         * DumpRenderTree/chromium/LayoutTestController.cpp:
1536         (LayoutTestController::LayoutTestController):
1537         (LayoutTestController::setAllowDisplayOfInsecureContent):
1538         (LayoutTestController::setAllowRunningOfInsecureContent):
1539         * DumpRenderTree/chromium/LayoutTestController.h:
1540         * DumpRenderTree/chromium/WebPreferences.cpp:
1541         (WebPreferences::reset):
1542         (WebPreferences::applyTo):
1543         * DumpRenderTree/chromium/WebPreferences.h:
1544         Add plumbing for new settings to Chromium DRT.
1545
1546 2011-05-10  Enrica Casucci  <enrica@apple.com>
1547
1548         Reviewed by Beth Dakin.
1549
1550         Added my name to the reviewers list and removed my name from
1551         to committer-only list.
1552
1553         * Scripts/webkitpy/common/config/committers.py:
1554
1555 2011-05-10  David Levin  <levin@chromium.org>
1556
1557         Reviewed by Shinichiro Hamaji.
1558
1559         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
1560         https://bugs.webkit.org/show_bug.cgi?id=60466
1561
1562         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
1563         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
1564           that property was removed.
1565         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
1566           filtering for errors.
1567         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
1568           verify that the line filtering is turned off.
1569         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
1570           and remove the unused file_path parameter.
1571         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
1572           line filtering is turned off (and fix test_no_error).
1573         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
1574           of errors based on the lines changed in the patch.
1575         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
1576           the filtering.
1577
1578 2011-05-10  Adam Roben  <aroben@apple.com>
1579
1580         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
1581
1582         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
1583         platform/win/plugins/window-geometry-initialized-before-set-window.html and
1584         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
1585         (WebKit2 Tests)
1586
1587         Reviewed by Anders Carlsson.
1588
1589         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
1590         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
1591         WindowedPluginTest::testHarnessWindow function.
1592
1593         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1594         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
1595         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
1596         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
1597         created for.
1598
1599         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1600         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
1601         WindowedPluginTest, and initialized new members.
1602         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
1603         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
1604         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
1605         then clean up and tell the test harness we're done.
1606         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
1607         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
1608         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
1609         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
1610         window becomes visible.
1611         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
1612         if it was hidden at the start of the test.
1613         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
1614         This should cause our window to become visible and our window region to get set. When we get
1615         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
1616         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
1617         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
1618         "startTest".
1619         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
1620
1621         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1622         (WindowedPluginTest::testHarnessWindow):
1623         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
1624         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
1625
1626 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1627
1628         Reviewed by Kenneth Rohde Christiansen.
1629
1630         [Qt] Add new qt-4.8 platform for layout testing
1631         https://bugs.webkit.org/show_bug.cgi?id=60544
1632
1633         * Scripts/old-run-webkit-tests:
1634         * Scripts/webkitdirs.pm:
1635
1636 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1637
1638         Unreviewed, rolling out r86108.
1639         http://trac.webkit.org/changeset/86108
1640         https://bugs.webkit.org/show_bug.cgi?id=60533
1641
1642         Broke makefile based builds and Cairo (Requested by weinig on
1643         #webkit).
1644
1645         * Scripts/build-api-tests:
1646         * Scripts/run-api-tests:
1647         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1648         * TestWebKitAPI/Test.h:
1649         (TestWebKitAPI::Test::~Test):
1650         (TestWebKitAPI::Test::name):
1651         (TestWebKitAPI::Test::Register::Register):
1652         (TestWebKitAPI::Test::Register::create):
1653         (TestWebKitAPI::Test::Test):
1654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1655         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/TestsController.cpp:
1658         (TestWebKitAPI::TestsController::TestsController):
1659         (TestWebKitAPI::TestsController::dumpTestNames):
1660         (TestWebKitAPI::TestsController::runTestNamed):
1661         (TestWebKitAPI::TestsController::testFailed):
1662         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1663         * TestWebKitAPI/TestsController.h:
1664         * TestWebKitAPI/mac/main.mm:
1665         (main):
1666
1667 2011-05-09  Hayato Ito  <hayato@chromium.org>
1668
1669         Reviewed by Ojan Vafai.
1670
1671         Skip reftests if pixel tests are disabled.
1672
1673         https://bugs.webkit.org/show_bug.cgi?id=59078
1674
1675         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1676         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1677         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1678         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1679
1680 2011-05-09  Chang Shu  <cshu@webkit.org>
1681
1682         Reviewed by Kenneth Rohde Christiansen.
1683
1684         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
1685         https://bugs.webkit.org/show_bug.cgi?id=60499
1686
1687         The implementation is similar to gtk.
1688
1689         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1690         (TextInputController::unmarkText):
1691         * DumpRenderTree/qt/TextInputControllerQt.h:
1692
1693 2011-05-09  James Robinson  <jamesr@chromium.org>
1694
1695         Reviewed by Eric Seidel.
1696
1697         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
1698         https://bugs.webkit.org/show_bug.cgi?id=60520
1699
1700         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1701
1702 2011-05-09  Dmitry Lomov  <dslomov@google.com>
1703
1704         Reviewed by Sam Weinig.
1705
1706         Switch TestWebKitAPI to GTest
1707         https://bugs.webkit.org/show_bug.cgi?id=59561
1708
1709         * Scripts/build-api-tests:
1710         * Scripts/run-api-tests:
1711         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1712         * TestWebKitAPI/Test.h:
1713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1714         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1715         (TestWebKitAPI::TEST):
1716         * TestWebKitAPI/TestsController.cpp:
1717         (TestWebKitAPI::TestsController::TestsController):
1718         (TestWebKitAPI::TestsController::dumpTestNames):
1719         (TestWebKitAPI::TestsController::runTestNamed):
1720         (TestWebKitAPI::TestsController::runAllTests):
1721         * TestWebKitAPI/TestsController.h:
1722         * TestWebKitAPI/mac/main.mm:
1723         (main):
1724
1725 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
1726
1727         Reviewed by Andreas Kling.
1728
1729         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
1730         https://bugs.webkit.org/show_bug.cgi?id=60487
1731
1732         When adding a new touch point, the start position of this point needs to be set.
1733
1734         * DumpRenderTree/qt/EventSenderQt.cpp:
1735         (EventSender::addTouchPoint):
1736
1737 2011-05-09  Robert Hogan  <robert@webkit.org>
1738
1739         Reviewed by Adam Roben.
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=57137
1742
1743         Unskip plugins/embed-prefers-plugins-for-images.html
1744
1745         Add image/png mime-type to test netscape plugin on Unix.
1746
1747         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1748         (NP_GetMIMEDescription):
1749
1750 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
1751
1752         Reviewed by Ojan Vafai.
1753
1754         Pull jsonresults_unittest test cases out into separate test methods.
1755         https://bugs.webkit.org/show_bug.cgi?id=60418
1756
1757         * TestResultServer/model/jsonresults_unittest.py:
1758
1759 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1760
1761         Reviewed by Andreas Kling.
1762
1763         [Qt] fix fast/dom/Geolocation/window-close-crash.html
1764         https://bugs.webkit.org/show_bug.cgi?id=60458
1765
1766         Update all pages with Mock position/error/permission.
1767
1768         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1769         (LayoutTestController::setGeolocationPermission):
1770         (LayoutTestController::setMockGeolocationError):
1771         (LayoutTestController::setMockGeolocationPosition):
1772
1773 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
1774
1775         Reviewed by Tony Gentilcore.
1776
1777         Implement Page Visibility API.
1778         https://bugs.webkit.org/show_bug.cgi?id=54181
1779
1780         * DumpRenderTree/LayoutTestController.cpp:
1781         (setPageVisibilityCallback):
1782         (resetPageVisibilityCallback):
1783         (LayoutTestController::staticFunctions):
1784         * DumpRenderTree/LayoutTestController.h:
1785         (LayoutTestController::setPageVisibility):
1786         (LayoutTestController::resetPageVisibility):
1787         * DumpRenderTree/chromium/LayoutTestController.cpp:
1788         (LayoutTestController::LayoutTestController):
1789         (LayoutTestController::resetPageVisibility):
1790         (LayoutTestController::setPageVisibility):
1791         * DumpRenderTree/chromium/LayoutTestController.h:
1792
1793 2011-05-07  Adam Barth  <abarth@webkit.org>
1794
1795         Reviewed by Eric Seidel.
1796
1797         Testing EWS spins on patches with a large number of failures
1798         https://bugs.webkit.org/show_bug.cgi?id=60441
1799
1800         In cases where the tree has a small number of persistent failures but a
1801         patch has a large number of failures, we weren't believing any results.
1802         That lead to us retrying the patch forever while we waited for
1803         trustworthy results that would never come.
1804
1805         This patch loosens the semantics of unexpected_failures to return a
1806         subset (rather than the exact set) of unexpected failures.  In the case
1807         where the tree has a bounded number of failures and the patch has an
1808         unbounded number of failures, we can accurately compute such a subset
1809         and reject the patch.
1810
1811         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1812         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1813         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1814         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1815         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1816
1817 2011-05-07  Joe Mason  <jmason@rim.com>
1818
1819         Reviewed by Daniel Bates.
1820
1821         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
1822         https://bugs.webkit.org/show_bug.cgi?id=52211
1823
1824         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
1825         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
1826
1827         * DumpRenderTree/chromium/WebViewHost.cpp:
1828         (WebViewHost::willPerformClientRedirect):
1829         (WebViewHost::didStartProvisionalLoad):
1830         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1831         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1832
1833 2011-05-07  Daniel Bates  <dbates@webkit.org>
1834
1835         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
1836         <http://trac.webkit.org/changeset/86007> (bug #60438).
1837
1838         * Scripts/old-run-webkit-tests:
1839           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
1840             file local variable. 
1841
1842 2011-05-07  Pratik Solanki  <psolanki@apple.com>
1843
1844         Reviewed by Darin Adler.
1845
1846         Remove references to Tiger in scripts
1847         https://bugs.webkit.org/show_bug.cgi?id=60438
1848
1849         Remove isTiger() and all of the code that depends on it.
1850
1851         * Scripts/build-webkit:
1852         * Scripts/ensure-valid-python:
1853         * Scripts/gdb-safari:
1854         * Scripts/webkitdirs.pm:
1855
1856 2011-05-06  David Grogan  <dgrogan@chromium.org>
1857
1858         Reviewed by Eric Seidel.
1859
1860         update link to message about mac 64bit git binaries
1861         https://bugs.webkit.org/show_bug.cgi?id=60411
1862
1863         The original message implied (correctly, at-the-time) that
1864         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
1865         binaries. The new message notes that they do. This might prevent someone
1866         else from spending a few minutes confused.
1867
1868         * Scripts/webkitpy/common/checkout/scm/git.py:
1869
1870 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
1871
1872         Reviewed by Ojan Vafai.
1873
1874         new-run-webkit-tests: crashes in race with crashing DRT
1875         https://bugs.webkit.org/show_bug.cgi?id=60238
1876
1877         This fixes a race where if we wrote the URL to DRT and
1878         DRT crashed immediately, we could get a broken pipe
1879         error back during the write() and not handle it correctly,
1880         causing NRWT to also crash.
1881
1882         * Scripts/webkitpy/layout_tests/port/server_process.py:
1883         * Scripts/webkitpy/layout_tests/port/webkit.py:
1884
1885 2011-05-06  Adam Barth  <abarth@webkit.org>
1886
1887         Reviewed by Eric Seidel.
1888
1889         Add a --skip-integrationtests mode to test-webkitpy
1890         https://bugs.webkit.org/show_bug.cgi?id=60354
1891
1892         These two test suites account for 2/3 of test-webkitpy's running time
1893         because they're not actually unit tests.  They're integration tests.
1894         This patch adds the ability to skip integration tests by passing a
1895         command line argument to test-webkitpy.  The buildbots will continue to
1896         run these integration tests to make sure they don't regress.  This
1897         option is for use by developers when working on parts of the code that
1898         are well-covered by unit tests.
1899
1900         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
1901         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
1902         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
1903         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
1904         * Scripts/webkitpy/test/main.py:
1905
1906 2011-05-06  Adam Barth  <abarth@webkit.org>
1907
1908         Reviewed by Eric Seidel.
1909
1910         The results.zip generated by the Chromium EWS are too big
1911         https://bugs.webkit.org/show_bug.cgi?id=60352
1912
1913         Currently results.zip created by the Chromium EWS bot contain roughly
1914         1000 tests that we expect to fail.  These test results are not helpful
1915         to contributors.
1916
1917         There are several approaches to solving this problem:
1918
1919         1) We could be more selective about which files to include in the zip.
1920         2) We could ask new-run-webkit-tests not to generate results for
1921            expected failures.
1922         3) We could ask new-run-webkit-tests not to run tests that we expect to
1923            fail.
1924
1925         This patch takes approach (3).  Currently, we're ignoring the outcome
1926         of failing tests anyway, so there's not much point in actually running
1927         them.  As a side benefit, this will speed up the test run by about 6%.
1928         In the future, we might revisit this decision and choose another
1929         approach.
1930
1931         * Scripts/webkitpy/common/config/ports.py:
1932         * Scripts/webkitpy/common/config/ports_unittest.py:
1933
1934 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
1935
1936         Reviewed by Csaba Osztrogonác.
1937
1938         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
1939
1940         * Scripts/old-run-webkit-tests:
1941
1942 2011-05-06  Adam Barth  <abarth@webkit.org>
1943
1944         Reviewed by Ojan Vafai.
1945
1946         Add an option to NRWT to skip failing tests
1947         https://bugs.webkit.org/show_bug.cgi?id=60295
1948
1949         This option is similar to the way old-run-webkit-tests works.  We're
1950         planning to use this option on the testing EWS bots because they don't
1951         use information from failing tests yet.
1952
1953         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1955         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1956
1957 2011-05-04  Philippe Normand  <pnormand@igalia.com>
1958
1959         Reviewed by Dimitri Glazkov.
1960
1961         Implement LayoutTestController::pseudoShadowId()
1962         https://bugs.webkit.org/show_bug.cgi?id=60034
1963
1964         shadowPseudoId support in the various LayoutTestController
1965         implementations.
1966
1967         * DumpRenderTree/LayoutTestController.cpp:
1968         (shadowPseudoIdCallback):
1969         (LayoutTestController::staticFunctions):
1970         * DumpRenderTree/LayoutTestController.h:
1971         * DumpRenderTree/chromium/LayoutTestController.cpp:
1972         (LayoutTestController::LayoutTestController):
1973         (LayoutTestController::shadowPseudoId):
1974         * DumpRenderTree/chromium/LayoutTestController.h:
1975         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1976         (LayoutTestController::shadowPseudoId):
1977         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1978         (LayoutTestController::shadowPseudoId):
1979         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1980         (LayoutTestController::shadowPseudoId):
1981         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1982         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1983         (LayoutTestController::shadowPseudoId):
1984         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1985         (LayoutTestController::shadowPseudoId):
1986         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1987         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1988         (WTR::LayoutTestController::shadowPseudoId):
1989         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1990
1991 2011-05-06  Adam Barth  <abarth@webkit.org>
1992
1993         EWS can't reject patches
1994         https://bugs.webkit.org/show_bug.cgi?id=60345
1995
1996         We're supposed to use patch.id() for the attachment ID, silly.
1997
1998         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1999         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2000
2001 2011-05-05  Steve Lacey  <sjl@chromium.org>
2002
2003         Reviewed by Ojan Vafai.
2004
2005         Fix generation of results html file by passing relative path to scm
2006         methods.
2007         Generate diff images for results html file.
2008
2009         https://bugs.webkit.org/show_bug.cgi?id=60086
2010
2011         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2012         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2013
2014 2011-05-05  Andy Estes  <aestes@apple.com>
2015
2016         Reviewed by Daniel Bates.
2017
2018         update-webkit should handle Internal using a different VCS than OpenSource.
2019         https://bugs.webkit.org/show_bug.cgi?id=60310
2020
2021         isGit() and isSVN() cache their results, so Internal will always be
2022         updated using the VCS commands used for OpenSource. If Internal uses a
2023         different VCS, this will fail. Fix this by calling isGitDirectory() and
2024         isSVNDirectory() instead, which do not cache their results.
2025
2026         * Scripts/update-webkit:
2027
2028 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2029
2030         Reviewed by Ojan Vafai.
2031
2032         nrwt: revamp integration tests incl. tests for servers
2033         https://bugs.webkit.org/show_bug.cgi?id=59985
2034
2035         This change adds the ability to run "integration tests" that
2036         depend on (and affect) the local environment on your machine.
2037         These tests can be run manually by invoking python on the
2038         test file in question and passing the '-i' flag, but are
2039         not run automatically as part of test-webkitpy.
2040
2041         Integration tests are identified by being methods named as
2042         "integration_test_*" instead of "test_*", and we use a
2043         custom TestLoader instead of the default one provided by
2044         unittest.
2045
2046         This change also adds a protected "_default_to_apache" method
2047         to the port object so we can do the right thing when starting
2048         and stopping web servers with less mechanism.
2049
2050         * Scripts/webkitpy/layout_tests/port/base.py:
2051         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2052         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2053         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2054         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2055         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2056
2057 2011-05-05  Adam Roben  <aroben@apple.com>
2058
2059         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
2060
2061         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
2062         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
2063         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
2064         safeguard against this, we fill the alpha channel with constant full opacity after the
2065         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
2066         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
2067         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
2068         results need an alpha channel, too.)
2069
2070         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
2071         generated due to alpha channel weirdness
2072
2073         Reviewed by Sam Weinig.
2074
2075         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2076         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
2077         constant full opacity.
2078         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
2079         in a CGContext or cairo_surface.
2080
2081 2011-05-05  Adam Roben  <aroben@apple.com>
2082
2083         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
2084
2085         Passing true tells the test harness to dump pixels even though we're not dumping a render
2086         tree.
2087
2088         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
2089         WebKitTestRunner doesn't result in pixel results being generated
2090
2091         Reviewed by Sam Weinig.
2092
2093         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
2094         argument to dumpAsText.
2095
2096         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2097         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
2098
2099         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2100         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
2101
2102         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
2103
2104         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
2105         developers.
2106
2107 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2108
2109         Reviewed by Ojan Vafai.
2110
2111         new-run-webkit-tests: merge os, version fields in test config
2112         https://bugs.webkit.org/show_bug.cgi?id=60004
2113
2114         This change removes the 'o/s' field from the TestConfiguration
2115         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
2116         the expectations file to macros that expand to the version names
2117         for each platform.
2118
2119         This means that you can once again put any subset of the
2120         operating system versions on a single line, e.g.:
2121           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
2122
2123         This change will break any existing test_expectations.txt
2124         file that uses the "OS-VERSION" macros, which are no longer
2125         needed. It turns out they were never needed, as just VERSION
2126         by itself was sufficient. The test_expectations.txt file should
2127         be updated accordingly prior to landing this change.
2128
2129         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2130         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2131         * Scripts/webkitpy/layout_tests/port/base.py:
2132
2133 2011-05-05  Tony Chang  <tony@chromium.org>
2134
2135         Reviewed by Adam Barth.
2136
2137         [chromium] switch from Lucida to free fonts for Hindi and Thai
2138         https://bugs.webkit.org/show_bug.cgi?id=60287
2139
2140         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
2141         packages on Lucid. There are actually multiple Thai fonts in the
2142         package, so I just picked one.
2143
2144         * DumpRenderTree/chromium/TestShellGtk.cpp:
2145         (setupFontconfig):
2146
2147 2011-05-05  Tony Chang  <tony@chromium.org>
2148
2149         Reviewed by Ojan Vafai.
2150
2151         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
2152         https://bugs.webkit.org/show_bug.cgi?id=60290
2153
2154         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
2155         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
2156         lucid64.  Because of that, google-chrome-64 used to skip the
2157         chromium-linux-x86_64 results since they were more incorrect.
2158
2159         Now that we're switching to lucid for google-chrome, we want
2160         google-chrome-64 to fall back to chromium-linux-x86_64.
2161
2162         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2163
2164 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2165
2166         Reviewed by Ojan Vafai.
2167
2168         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
2169         https://bugs.webkit.org/show_bug.cgi?id=60002
2170
2171         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2172         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2173         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2174         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2175         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2176         * Scripts/webkitpy/style/checkers/test_expectations.py:
2177
2178 2011-05-05  Eric Seidel  <eric@webkit.org>
2179
2180         Reviewed by Adam Barth.
2181
2182         commit-queue should reject patches which fail ewses
2183         https://bugs.webkit.org/show_bug.cgi?id=47534
2184
2185         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2186         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2187         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2188
2189 2011-05-05  Chang Shu  <cshu@webkit.org>
2190
2191         Reviewed by Andreas Kling.
2192
2193         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
2194         https://bugs.webkit.org/show_bug.cgi?id=59638
2195
2196         1. Call QGraphicsWKView constructor with pageGroupRef.
2197         2. Disable setFontFamily calls as it breaks Qt test fonts.
2198
2199         * WebKitTestRunner/TestController.cpp:
2200         (WTR::TestController::resetStateToConsistentValues):
2201         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2202         (WTR::WebView::WebView):
2203         (WTR::PlatformWebView::PlatformWebView):
2204
2205 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
2206
2207         Reviewed by David Kilzer.
2208
2209         Add --only-webkit option to build-webkit
2210         https://bugs.webkit.org/show_bug.cgi?id=60245
2211
2212         * Scripts/build-webkit: If --only-webkit was specified
2213         just build the WebKit project, and not its dependencies.
2214
2215 2011-05-05  Jeff Miller  <jeffm@apple.com>
2216
2217         Reviewed by Darin Adler.
2218
2219         Add didNotHandleWheelEvent callback to WKPageUIClient
2220         https://bugs.webkit.org/show_bug.cgi?id=60203
2221
2222         * MiniBrowser/gtk/BrowserWindow.c:
2223         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
2224         * MiniBrowser/mac/BrowserWindowController.m:
2225         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
2226         * MiniBrowser/win/BrowserView.cpp:
2227         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
2228         * WebKitTestRunner/TestController.cpp:
2229         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
2230         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2231
2232 2011-05-04  Eric Seidel  <eric@webkit.org>
2233
2234         Reviewed by Adam Barth.
2235
2236         Add more missing imports from scm refactor
2237         https://bugs.webkit.org/show_bug.cgi?id=60239
2238
2239         * Scripts/webkitpy/common/checkout/scm/git.py:
2240         * Scripts/webkitpy/common/checkout/scm/svn.py:
2241
2242 2011-05-04  Eric Seidel  <eric@webkit.org>
2243
2244         Reviewed by Adam Barth.
2245
2246         sheriff-bot is having more exception trouble
2247         https://bugs.webkit.org/show_bug.cgi?id=60233
2248
2249         A webpage-forced build was causing SB to throw an exception.
2250         We've long had this bug, but we just didn't notice it until now.
2251
2252         In debugging this I found we fetch an absurd amount of data now
2253         that we use buildbot's json (instead of xmlrpc), so I added
2254         the filter=1 parameter to reduce it a little.  That required
2255         me to handle the case where filter=1 would strip
2256         result=0 in some cases (it's unclear why it does that).
2257
2258         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2259         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2260
2261 2011-05-04  Cris Neckar  <cdn@chromium.org>
2262
2263         Unreviewed, Adding Cris Neckar as a committer
2264
2265         * Scripts/webkitpy/common/config/committers.py:
2266
2267 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2268
2269         Reviewed by Laszlo Gombos.
2270
2271         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
2272         https://bugs.webkit.org/show_bug.cgi?id=59462
2273
2274         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
2275
2276 2011-05-04  Eric Seidel  <eric@webkit.org>
2277
2278         Reviewed by Adam Barth.
2279
2280         The testing EWS bots should upload layout-test-results.zip to bugs after failures
2281         https://bugs.webkit.org/show_bug.cgi?id=60223
2282
2283         This required sharing a bit of code between the commit-queue
2284         (which already knew how to do this) and the new EWS testing bots.
2285
2286         In the process I also cleaned up EWS testing a little and
2287         removed some dead code from the commit-queue.
2288
2289         * Scripts/webkitpy/common/config/committervalidator.py:
2290         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2291         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2292         * Scripts/webkitpy/tool/commands/queues.py:
2293         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2294
2295 2011-05-04  James Kozianski  <koz@chromium.org>
2296
2297         Reviewed by Eric Seidel.
2298
2299         Add method to make a Port able to retrieve TestOutputSets from its builders.
2300         https://bugs.webkit.org/show_bug.cgi?id=58211
2301
2302         This will be used in the new rebaseline script - TestOutputs are
2303         potential new baselines.
2304
2305         * Scripts/webkitpy/common/config/urls.py:
2306         * Scripts/webkitpy/layout_tests/port/base.py:
2307         * Scripts/webkitpy/layout_tests/port/chromium.py:
2308         * Scripts/webkitpy/layout_tests/port/factory.py:
2309         * Scripts/webkitpy/layout_tests/port/webkit.py:
2310
2311 2011-05-04  Eric Seidel  <eric@webkit.org>
2312
2313         Reviewed by Ojan Vafai.
2314
2315         sheriff-bot can't parse results.html
2316         https://bugs.webkit.org/show_bug.cgi?id=60196
2317
2318         The problem was that the NRWT bots are currently core
2319         and so sheriff-bot was trying to diagnose failures on
2320         them.  It was trying to parse their results.html file
2321         and BeautifulSoup was throwing an exception.
2322
2323         It seems our version of BeautifulSoup was quite old
2324         and unable to handle <script> tags correctly.
2325         This moves us to 3.2 which doesn't seem to have this bug.
2326
2327         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
2328
2329 2011-05-04  Adam Barth  <abarth@webkit.org>
2330
2331         Reviewed by Eric Seidel.
2332
2333         Make the EWS test logging less verbose
2334         https://bugs.webkit.org/show_bug.cgi?id=60201
2335
2336         This should help us generate less than a hundred MB of logs per hour.
2337
2338         * Scripts/webkitpy/common/config/ports.py:
2339         * Scripts/webkitpy/common/config/ports_unittest.py:
2340
2341 2011-05-04  Tao Bai  <michaelbai@chromium.org>
2342
2343         Reviewed by David Kilzer.
2344
2345         Populate touch-icon url to FrameLoaderClient
2346         https://bugs.webkit.org/show_bug.cgi?id=59143
2347
2348         Disable touch icon by default. 
2349
2350         * Scripts/build-webkit:
2351
2352 2011-05-04  Justin Novosad  <junov@chromium.org>
2353
2354         Reviewed by Kenneth Russell.
2355
2356         [Chromium] Add gpu acceleration flags to DumpRenderTree
2357         https://bugs.webkit.org/show_bug.cgi?id=60168
2358         Adding support for command line flags 
2359         enable-accelerated-2d-canvas an
2360         enable-accelerated-drawing in DumpRenderTree.
2361
2362         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2363         (main):
2364         * DumpRenderTree/chromium/TestShell.cpp:
2365         (TestShell::TestShell):
2366         (TestShell::resetWebSettings):
2367         * DumpRenderTree/chromium/TestShell.h:
2368         (TestShell::setLegacyAccelerated2dCanvasEnabled):
2369         (TestShell::setAcceleratedDrawingEnabled):
2370         * DumpRenderTree/chromium/WebPreferences.cpp:
2371         (WebPreferences::reset):
2372         (WebPreferences::applyTo):
2373         * DumpRenderTree/chromium/WebPreferences.h:
2374
2375 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2376
2377         Reviewed by Csaba Osztrogonác.
2378
2379         [Qt] run-qtwebkit-tests misses exec bit
2380         https://bugs.webkit.org/show_bug.cgi?id=60188
2381
2382         Also removing an unecessary import (mostly to let this bugfix goes
2383         through the system, as this is just a chmod).
2384
2385         * Scripts/run-qtwebkit-tests:
2386
2387 2011-05-04  Adam Barth  <abarth@webkit.org>
2388
2389         Fix import of ircproxy module to actually import the module.  I don't
2390         really understand how this code could have worked before.
2391
2392         * Scripts/webkitpy/common/host.py:
2393
2394 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2395
2396         Reviewed by Andreas Kling.
2397
2398         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
2399         https://bugs.webkit.org/show_bug.cgi?id=60172
2400
2401         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
2402         (BrowserWindow::BrowserWindow):
2403
2404 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
2405
2406         Reviewed by Ojan Vafai.
2407
2408         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
2409         https://bugs.webkit.org/show_bug.cgi?id=60088
2410         
2411         Makes --new-baseline put new baselines into the first entry in the
2412         baseline search path, including any additional directories passed in via
2413         --additional-platform-directory.
2414         
2415         Simplifies baseline_path() by making it return the first entry in the
2416         baseline search path instead of requiring each port to have an
2417         implementation (should not result in any behavior change).
2418
2419         * Scripts/webkitpy/layout_tests/port/base.py:
2420         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2421         * Scripts/webkitpy/layout_tests/port/chromium.py:
2422         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2423         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2424         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2425         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2426         * Scripts/webkitpy/layout_tests/port/mac.py:
2427         * Scripts/webkitpy/layout_tests/port/test.py:
2428         * Scripts/webkitpy/layout_tests/port/webkit.py:
2429
2430 2011-05-04  Adam Barth  <abarth@webkit.org>
2431
2432         Reviewed by Eric Seidel.
2433
2434         Fix circular dependency in webkitpy
2435         https://bugs.webkit.org/show_bug.cgi?id=60075
2436
2437         These functions don't belong in bugzilla.py.  They only exist there
2438         because they are old.  Really, these functions shouldn't be free
2439         functions at all, but that's a patch for another day.
2440
2441         * Scripts/webkitpy/common/checkout/changelog.py:
2442         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2443         * Scripts/webkitpy/common/checkout/checkout.py:
2444         * Scripts/webkitpy/common/config/urls.py:
2445         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2446         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2447         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2448         * Scripts/webkitpy/style/checkers/changelog.py:
2449         * Scripts/webkitpy/tool/bot/irc_command.py:
2450         * Scripts/webkitpy/tool/bot/sheriff.py:
2451         * Scripts/webkitpy/tool/commands/upload.py:
2452
2453 2011-05-03  Pratik Solanki  <psolanki@apple.com>
2454
2455         Reviewed by Dan Bernstein.
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=60141
2458         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
2459
2460         * Scripts/build-webkit:
2461
2462 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
2463
2464         Reviewed by Ojan Vafai.
2465
2466         Update rebaseline queue server to handle hierarchical test results
2467         https://bugs.webkit.org/show_bug.cgi?id=60063
2468         
2469         Update test result parsing done by the rebaseline queue server to handle
2470         the hierarchical test result output that is generated as of r85254.
2471
2472         * RebaselineQueueServer/templates/builder-queue-edit.html:
2473
2474 2011-05-03  Eric Seidel  <eric@webkit.org>
2475
2476         Reviewed by Adam Roben.
2477
2478         webkit-patch post-commits HEAD^.. throws an exception
2479         https://bugs.webkit.org/show_bug.cgi?id=60027
2480
2481         * Scripts/webkitpy/common/checkout/scm/git.py:
2482
2483 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
2484
2485         Reviewed by Kenneth Rohde Christiansen.
2486
2487         [Qt] Layout tests may timeout if loadFinished receives false
2488         https://bugs.webkit.org/show_bug.cgi?id=60064
2489
2490         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
2491         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
2492         a response is ignored, like it should be for 204 responses. It is a problem for creating
2493         tests for 204 responses for example.
2494
2495         This change has been tested and it causes no regressions in layout tests.
2496
2497         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2498         (LayoutTestController::maybeDump):
2499
2500 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2501
2502         Unreviewed, rolling out r85659.
2503         http://trac.webkit.org/changeset/85659
2504         https://bugs.webkit.org/show_bug.cgi?id=59977
2505
2506         restarting isn't working correctly
2507
2508         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2509         * Scripts/webkitpy/layout_tests/port/http_server.py:
2510         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2511         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2512
2513 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2514
2515         Reviewed by Ojan Vafai.
2516
2517         new-run-webkit-tests: fix http server startup/shutdown
2518
2519         Previous versions of the code had three problems that made startup
2520         and shutdown flaky. The first is that it would throw exceptions
2521         if it couldn't delete stale log files, which was overly
2522         paranoid. The second is that some of the exceptions weren't
2523         defined properly. The third, and most important, is that it was
2524         using urllib to check if ports were available, which was leaving
2525         sockets in a half-closed state, and keeping ports from being
2526         reused. By switching to raw sockets, we are able to now reliably
2527         restart.
2528
2529         This change also switches the code to using Executives to stop
2530         processes, which will let us delete a bunch of code in the
2531         port/* implementations and fix a weird layering problem in a
2532         subsequent patch.
2533
2534         https://bugs.webkit.org/show_bug.cgi?id=59977
2535
2536         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2537         * Scripts/webkitpy/layout_tests/port/http_server.py:
2538         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2539         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2540
2541 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2542
2543         Reviewed by Adam Barth.
2544
2545         fix failing printing_unittest on win32
2546         https://bugs.webkit.org/show_bug.cgi?id=59963
2547
2548         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2549
2550 2011-05-03  Adam Roben  <aroben@apple.com>
2551
2552         Fix most strict PassOwnPtr violations on Windows
2553
2554         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
2555         enabled
2556
2557         Reviewed by Anders Carlsson.
2558
2559         * WebKitAPITest/Test.h: Use adoptPtr.
2560
2561 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2562
2563         Reviewed by Andreas Kling.
2564
2565         Add myself to the committers list.
2566
2567         * Scripts/webkitpy/common/config/committers.py:
2568
2569 2011-05-03  James Robinson  <jamesr@chromium.org>
2570
2571         Reviewed by Kenneth Russell.
2572
2573         [chromium] Layout test animations/3d/replace-filling-transform.html failing
2574         https://bugs.webkit.org/show_bug.cgi?id=59839
2575
2576         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
2577
2578         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2579
2580 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2581
2582         Unreviewed, rolling out r85471.
2583         http://trac.webkit.org/changeset/85471
2584         https://bugs.webkit.org/show_bug.cgi?id=59922
2585
2586         The rule of thumb in EFL is that you init in all the places
2587         you use it. So, if in your application you call ecore_evas_*
2588         functions, you have to call ecore_evas_init() first.
2589
2590         * EWebLauncher/main.c: always call *_init() functions when you use
2591         that namespace.
2592         (quit):
2593         (main):
2594
2595 2011-05-02  Ojan Vafai  <ojan@chromium.org>
2596
2597         Reviewed by Tony Chang.
2598
2599         remove no longer used method
2600         https://bugs.webkit.org/show_bug.cgi?id=59981
2601
2602         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2603         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2604
2605 2011-05-02  Ojan Vafai  <ojan@chromium.org>
2606
2607         Reviewed by Tony Chang.
2608
2609         add image toggling behavior from old-run-webkit-tests
2610         https://bugs.webkit.org/show_bug.cgi?id=59978
2611
2612         Output -diffs.html files. This matches old-run-webkit-tests.
2613         In theory, we could use data urls in the results.html file, but
2614         data urls don't currently have access to local files.
2615
2616         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2617
2618 2011-05-02  Tony Chang  <tony@chromium.org>
2619
2620         Reviewed by Ojan Vafai.
2621
2622         [nrwt] remove some obsolete references to .checksum files
2623         https://bugs.webkit.org/show_bug.cgi?id=59971
2624
2625         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2626         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2627         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2628         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2629         * Scripts/webkitpy/layout_tests/port/test.py:
2630         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2631
2632 2011-05-02  Adam Roben  <aroben@apple.com>
2633
2634         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
2635
2636         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
2637         doesn't work, but should
2638
2639         Reviewed by Adam Barth.
2640
2641         * DumpRenderTree/chromium/CppBoundClass.h:
2642         * DumpRenderTree/chromium/WebViewHost.cpp:
2643
2644 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2645
2646         Reviewed by Xan Lopez.
2647
2648         [GTK] Compiler warning in Tools/MiniBrowser/main.c
2649         https://bugs.webkit.org/show_bug.cgi?id=59986
2650
2651         Remove a compiler warning.
2652
2653         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
2654         from complaining.
2655
2656 2011-05-02  Adam Barth  <abarth@webkit.org>
2657
2658         Reviewed by Eric Seidel.
2659
2660         Add runtests_unittest.py
2661         https://bugs.webkit.org/show_bug.cgi?id=59955
2662
2663         I forgot to add this file in a previous patch.
2664
2665         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
2666
2667 2011-05-02  Adam Barth  <abarth@webkit.org>
2668
2669         Change the testing EWS to log failures explicitly to avoid an infinite loop.
2670
2671         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2672
2673 2011-05-02  Adrienne Walker  <enne@google.com>
2674
2675         Unreviewed, fix misspelled contributor name.
2676
2677         * Scripts/webkitpy/common/config/committers.py:
2678
2679 2011-05-02  Adam Barth  <abarth@webkit.org>
2680
2681         Reviewed by Eric Seidel.
2682
2683         cr-linux-ews should run tests
2684         https://bugs.webkit.org/show_bug.cgi?id=59272
2685
2686         This patch turns on testing for the cr-linux-ews.  Yay!
2687
2688         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2689         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2690         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2691         * Scripts/webkitpy/tool/steps/runtests.py:
2692         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2693
2694 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2695
2696         Incorporate a review comment that I mistakenly omitted from my last commit.
2697
2698         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
2699
2700 2011-05-02  Adam Barth  <abarth@webkit.org>
2701
2702         Reviewed by Eric Seidel.
2703
2704         EWS should report the list of unexpected failures
2705         https://bugs.webkit.org/show_bug.cgi?id=59923
2706
2707         We cache the results of the first layout test results run on the task
2708         so the EWS can grab them later.  Another option is to include them in
2709         the exception that's thrown, but this approach seemed slightly more
2710         aesthetic.
2711
2712         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2713         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2714
2715 2011-05-02  Adam Barth  <abarth@webkit.org>
2716
2717         Reviewed by Eric Seidel.
2718
2719         Add base case for a test-running EWS
2720         https://bugs.webkit.org/show_bug.cgi?id=59920
2721
2722         Later I will subclass this to run the Chromium Linux EWS.
2723
2724         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
2725         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2726         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2727
2728 2011-05-02  Anders Carlsson  <andersca@apple.com>
2729
2730         Build fix.
2731
2732         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2733         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2734
2735 2011-05-02  Nico Weber  <thakis@chromium.org>
2736
2737         Reviewed by Mihai Parparita.
2738
2739         Add --no-webkit2 to the output of "build-webkit -h"
2740         https://bugs.webkit.org/show_bug.cgi?id=59942
2741
2742         * Scripts/build-webkit:
2743
2744 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2745
2746         Reviewed by Xan Lopez.
2747
2748         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
2749         https://bugs.webkit.org/show_bug.cgi?id=59943
2750
2751         Disable the Ubuntu overlay scrollbar while testing, by injecting the
2752         LIBOVERLAY_SCROLLBAR=0 environment variable.
2753
2754         * Scripts/old-run-webkit-tests:
2755
2756 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2757
2758         Reviewed by Eric Seidel.
2759
2760         [GTK] editing/selection/select-out-of-editable.html failing after r83967
2761         https://bugs.webkit.org/show_bug.cgi?id=58667
2762
2763         Do not trigger mouse down events when the EventSender knows that a mouse button is
2764         already down. These type of situations can confuse Xvfb and cause dragging failures.
2765
2766         * DumpRenderTree/gtk/EventSender.cpp:
2767         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
2768         is already down. This can interfere with drags in Xvfb.
2769
2770 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2771
2772         Reviewed by Csaba Osztrogonác.
2773
2774         DRT sideeffect revealed by r71268.
2775         https://bugs.webkit.org/show_bug.cgi?id=48958
2776
2777         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
2778
2779         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
2780         PageZoomFactor too. It should be done before resetsettings() 
2781         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
2782
2783         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2784         (WebCore::WebPage::resetSettings):
2785         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2786
2787 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2788
2789         Unreviewed, rolling out r85469.
2790         http://trac.webkit.org/changeset/85469
2791         https://bugs.webkit.org/show_bug.cgi?id=59928
2792
2793         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
2794         bbandix on #webkit).
2795
2796         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
2797         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2798         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2799
2800 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
2801
2802         Reviewed by Kenneth Rohde Christiansen.
2803
2804         Cleanup EFL initialization/shutdown in the EWebLauncher
2805         https://bugs.webkit.org/show_bug.cgi?id=59922
2806
2807         Removed ecore_evas_init and edje_init form main function due to they
2808         are also called in the ewk_init. Moved ewk_shutdown to quit function.
2809
2810         * EWebLauncher/main.c:
2811         (quit):
2812         (main):
2813
2814 2011-05-02  Adam Barth  <abarth@webkit.org>
2815
2816         Reviewed by Eric Seidel.
2817
2818         Add base case for a test-running EWS
2819         https://bugs.webkit.org/show_bug.cgi?id=59920
2820
2821         Later I will subclass this to run the Chromium Linux EWS.
2822
2823         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
2824         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2825         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2826
2827 2011-05-02  Adam Barth  <abarth@webkit.org>
2828
2829         Reviewed by Eric Seidel.
2830
2831         Add the ability to skip python and perl unit tests on EC2
2832         https://bugs.webkit.org/show_bug.cgi?id=59918
2833
2834         * Scripts/webkitpy/common/config/ports.py:
2835             - This is slightly ugly, but it's useful...
2836         * Scripts/webkitpy/common/config/ports_unittest.py:
2837         * Scripts/webkitpy/tool/mocktool.py:
2838         * Scripts/webkitpy/tool/steps/runtests.py:
2839
2840 2011-05-02  Adam Barth  <abarth@webkit.org>
2841
2842         Reviewed by Eric Seidel.
2843
2844         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
2845         https://bugs.webkit.org/show_bug.cgi?id=59919
2846
2847         new-run-webkit-tests doesn't support --wait-for-httpd (because it
2848         always waits for HTTPD, as I understand things).  It turns out we're
2849         not really using this flag for anything, so we should just remove it.
2850
2851         * Scripts/webkitpy/tool/steps/runtests.py:
2852         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2853
2854 2011-05-01  Eric Seidel  <eric@webkit.org>
2855
2856         Reviewed by Adam Barth.
2857
2858         The bots should learn from expected failures without having to retry
2859         https://bugs.webkit.org/show_bug.cgi?id=59279
2860
2861         Rather than re-trying the whole patch, we can just check whether we now
2862         expect the failures we see with the patch applied, saving a lot of time.
2863
2864         This patch also teaches the CommitQueue how to reject patches even
2865         when the tree is red using the new unexpected_failures() method on
2866         ExpectedFailures.
2867
2868         Finally in testing we found a bug in ExpectedFailures where it would
2869         "trust" results which had many many failures, due to using an
2870         equal sign instead of a less-than sign.
2871
2872         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
2873         * Scripts/webkitpy/tool/bot/expectedfailures.py
2874         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
2875         * Scripts/webkitpy/tool/bot/patchanalysistask.py
2876
2877
2878 2011-05-02  Adam Barth  <abarth@webkit.org>
2879
2880         Reviewed by Eric Seidel.
2881
2882         workspace.py fails to import ScriptError
2883         https://bugs.webkit.org/show_bug.cgi?id=59915
2884
2885         If the workspace fails to create a zip, webkitpy crashes instead of
2886         handling the error as expected.
2887
2888         * Scripts/webkitpy/common/system/workspace.py:
2889         * Scripts/webkitpy/common/system/workspace_unittest.py:
2890         * Scripts/webkitpy/tool/mocktool.py:
2891
2892 2011-05-01  Adam Barth  <abarth@webkit.org>
2893
2894         Remove unadvertantly added file.
2895
2896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2897
2898 2011-05-01  Adam Barth  <abarth@webkit.org>
2899
2900         Reviewed by Eric Seidel.
2901
2902         expectedfailures.py should report the unexpected failures when asked
2903         https://bugs.webkit.org/show_bug.cgi?id=59916
2904
2905         This information is useful when the EWS runs tests.
2906
2907         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2908         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2909
2910 2011-05-01  Adam Barth  <abarth@webkit.org>
2911
2912         Reviewed by Eric Seidel.
2913
2914         JSONTestResult needs to handle multiple results
2915         https://bugs.webkit.org/show_bug.cgi?id=59269
2916
2917         This case occurs when a test is flaky because NRWT will run the test
2918         twice and report both results as "actual."
2919
2920         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2921         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2922
2923 2011-05-01  Adam Barth  <abarth@webkit.org>
2924
2925         Reviewed by Eric Seidel.
2926
2927         Move checkout/api.py to checkout/checkout.py
2928         https://bugs.webkit.org/show_bug.cgi?id=59906
2929
2930         This is more consistent with Python style.
2931
2932         * Scripts/webkitpy/common/checkout/__init__.py:
2933         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2934         * Scripts/webkitpy/common/host.py:
2935         * Scripts/webkitpy/tool/main.py:
2936
2937 2011-05-01  Eric Seidel  <eric@webkit.org>
2938
2939         Reviewed by Adam Barth.
2940
2941         scm.py should be split into many pieces
2942         https://bugs.webkit.org/show_bug.cgi?id=59908
2943
2944         Forgot an AuthenticationError import.
2945
2946         * Scripts/webkitpy/common/checkout/scm/git.py:
2947         * Scripts/webkitpy/common/checkout/scm/svn.py:
2948
2949 2011-05-01  Arno Renevier  <arno@renevier.net>
2950
2951         Reviewed by Eric Seidel.
2952
2953         wrong exception raised in Lighttpd start method
2954         https://bugs.webkit.org/show_bug.cgi?id=59283
2955
2956         raise standard Exception instead of non existent
2957         google.httpd_utils.HttpdNotStarted
2958
2959         * Scripts/webkitpy/layout_tests/port/http_server.py:
2960
2961 2011-05-01  Eric Seidel  <eric@webkit.org>
2962
2963         Reviewed by Adam Barth.
2964
2965         scm.py should be split into many pieces
2966         https://bugs.webkit.org/show_bug.cgi?id=59908
2967
2968         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2969         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
2970         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
2971         * Scripts/webkitpy/common/checkout/scm/scm.py:
2972         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2973         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
2974
2975 2011-05-01  Eric Seidel  <eric@webkit.org>
2976
2977         Reviewed by Adam Barth.
2978
2979         Make most scm.py tests pass in preparation for splitting them up
2980         https://bugs.webkit.org/show_bug.cgi?id=59904
2981
2982         There is one remaining failure:
2983         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
2984         which identifies a difference between the SVN and Git versions of the
2985         SCM api.  I'm not going to bother fixing that until we split out all
2986         the tests.
2987
2988         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2989
2990 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
2991
2992         [WIN] Unreviewed buildfix after r85440.
2993
2994         * DumpRenderTree/win/UIDelegate.cpp:
2995         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
2996
2997 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
2998
2999         [WIN] Unreviewed buildfix after r85434.
3000
3001         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
3002         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
3003
3004 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3005
3006         [WIN] Unreviewed buildfix after r85434.
3007
3008         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3009         (FrameLoadDelegate::FrameLoadDelegate):
3010         * DumpRenderTree/win/UIDelegate.cpp:
3011         (DRTUndoManager::DRTUndoManager):
3012         (UIDelegate::UIDelegate):
3013         (UIDelegate::resetUndoManager):
3014
3015 2011-05-01  Eric Seidel  <eric@webkit.org>
3016
3017         Reviewed by Adam Barth.
3018
3019         Move scm.py into its own module in preparation for splitting it up
3020         https://bugs.webkit.org/show_bug.cgi?id=59884
3021
3022         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
3023         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
3024         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
3025         * Scripts/webkitpy/test/main.py:
3026
3027 2011-05-01  Adam Barth  <abarth@webkit.org>
3028
3029         Reviewed by Eric Seidel.
3030
3031         webkit-patch fails when not run from root
3032         https://bugs.webkit.org/show_bug.cgi?id=59882
3033
3034         We need to set the CWD when running svn so that svn interprets file
3035         paths relative to the root of the working copy.
3036
3037         * Scripts/webkitpy/common/checkout/scm.py:
3038
3039 2011-04-29  Eric Seidel  <eric@webkit.org>
3040
3041         Reviewed by Adam Barth.
3042
3043         land-safely patches should show show their place in the commit-queue
3044         https://bugs.webkit.org/show_bug.cgi?id=59853
3045
3046         This complicated the "should we show the bubbles or the submit-to-ews button"
3047         logic substantially. :(  But now we'll show both the commit-queue position
3048         as well as the submit-to-ews button for land-safely (cq+ only) patches.
3049         Previously we would only show the submit-to-ews button.
3050
3051         * QueueStatusServer/handlers/statusbubble.py:
3052         * QueueStatusServer/templates/statusbubble.html:
3053
3054 2011-04-29  Naoki Takano  <takano.naoki@gmail.com>
3055
3056         Reviewed by Adam Barth.
3057
3058         Add my name to contributers.
3059         https://bugs.webkit.org/show_bug.cgi?id=59854
3060
3061         * Scripts/webkitpy/common/config/committers.py:
3062
3063 2011-04-29  Keith Kyzivat  <keith.kyzivat@nokia.com>
3064
3065         Reviewed by Csaba Osztrogonác.
3066
3067         [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
3068         https://bugs.webkit.org/show_bug.cgi?id=59772
3069
3070         * Tools.pro:
3071
3072 2011-04-29  Stephanie Lewis  <slewis@apple.com>
3073
3074         Rubber-stamped by Adam Roben.   
3075
3076         Remove the production configuration guard since installs only happen in production anyway.  
3077         Works around a bug in Xcode
3078
3079         * DumpRenderTree/mac/PerlSupport/Makefile:
3080
3081 2011-04-29  Adam Roben  <aroben@apple.com>
3082
3083         Remove a PHP setting that is now provided by httpd.conf
3084
3085         r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
3086         isn't dependent on paths that could be different on each user's machine).
3087
3088         Reviewed by Sam Weinig.
3089
3090         * Scripts/webkitperl/httpd.pm:
3091         (getDefaultConfigForTestDirectory): Removed log_errors setting.
3092
3093 2011-04-29  Jon Lee  <jonlee@apple.com>
3094
3095         Unreviewed, Adding Jon Lee as a committer
3096
3097         * Scripts/webkitpy/common/config/committers.py:
3098
3099 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3100
3101         Reviewed by Tony Chang.
3102
3103         fix pretty_patch_available and wdiff_available
3104         https://bugs.webkit.org/show_bug.cgi?id=59761
3105
3106         These methods rely on the check_* method being called first.
3107         This would only happen when we actually tried to compute a diff,
3108         but computing the diff happens on a different process.
3109         
3110         Also fix setting _wdiff_avialable to True by default.
3111
3112         * Scripts/webkitpy/layout_tests/port/base.py:
3113         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3114         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3115
3116 2011-04-29  Ojan Vafai  <ojan@chromium.org>
3117
3118         Reviewed by Eric Seidel.
3119
3120         exclude skipped tests from the summarized results
3121         https://bugs.webkit.org/show_bug.cgi?id=59813
3122
3123         If we find a need fo skipped tests later, we should either create
3124         a skipped.json file or expose this some other way. As it is, the data
3125         is unused and is hugely bloating the size of full_results.json.
3126
3127         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3128
3129 2011-04-29  Adam Roben  <aroben@apple.com>
3130
3131         Make DumpRenderTreeSupport get installed when the default configuration is built
3132
3133         The default configuration is Production, but in that case the CONFIGURATION environment
3134         variable is set to the empty string.
3135
3136         Reviewed by Sam Weinig.
3137
3138         * DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't
3139         already set so that later logic that depends on CONFIGURATION having that value will work.
3140
3141 2011-04-29  Dean Jackson  <dino@apple.com>
3142
3143         Reviewed by Simon Fraser.
3144
3145         Add ENABLE macro for WebKitAnimation
3146         https://bugs.webkit.org/show_bug.cgi?id=59729
3147
3148         Add new feature to toggle WebKit Animation API.
3149
3150         * Scripts/build-webkit:
3151
3152 2011-04-29  Sam Weinig  <sam@webkit.org>
3153
3154         Reviewed by Adam Roben.
3155
3156         Make production the default build type for WebKitTestRunner, matching
3157         all other projects.
3158
3159         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3160
3161 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
3162
3163         [wx] Unreviewed build fix, add new directory to the build.
3164
3165         * waf/build/settings.py:
3166
3167 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3168
3169         Reviewed by Martin Robinson.
3170
3171         [GTK] Implement UI client in minibrowser
3172         https://bugs.webkit.org/show_bug.cgi?id=58416
3173
3174         It also allows to open more than one minibrowser window from the
3175         command line.
3176
3177         * MiniBrowser/gtk/BrowserWindow.c:
3178         (browserWindowFinalize):
3179         (browser_window_init):
3180         (browserWindowConstructed):
3181         (createNewPage):
3182         (showPage):
3183         (closePage):
3184         (runJavaScriptAlert):
3185         (browserWindowUIClientInit):
3186         * MiniBrowser/gtk/main.c:
3187         (loadURI):
3188         (main):
3189
3190 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3191
3192         Reviewed by Martin Robinson.
3193
3194         [GTK] Implement page loader client in MiniBrowser
3195         https://bugs.webkit.org/show_bug.cgi?id=58024
3196
3197         A new class BrowserWindow has been added to implement the page
3198         loader client. It makes supporting multiple windows easier. Window
3199         title and url entry are now updated during the loading process.
3200
3201         * MiniBrowser/gtk/BrowserWindow.c: Added.
3202         (activateUriEntryCallback):
3203         (goBackCallback):
3204         (goForwardCallback):
3205         (browserWindowFinalize):
3206         (browserWindowGetProperty):
3207         (browserWindowSetProperty):
3208         (browser_window_init):
3209         (browserWindowConstructed):
3210         (browser_window_class_init):
3211         (browserWindowUpdateTitle):
3212         (browserWindowSetTitle):
3213         (browserWindowSetLoadProgress):
3214         (browserWindowUpdateURL):
3215         (didStartProvisionalLoadForFrame):
3216         (didReceiveServerRedirectForProvisionalLoadForFrame):
3217         (didFailProvisionalLoadWithErrorForFrame):
3218         (didCommitLoadForFrame):
3219         (didFinishDocumentLoadForFrame):
3220         (didFinishLoadForFrame):
3221         (didFailLoadWithErrorForFrame):
3222         (didReceiveTitleForFrame):
3223         (didFirstLayoutForFrame):
3224         (didFirstVisuallyNonEmptyLayoutForFrame):
3225         (didRemoveFrameFromHierarchy):
3226         (didStartProgress):
3227         (didChangeProgress):
3228         (didFinishProgress):
3229         (didBecomeUnresponsive):
3230         (didBecomeResponsive):
3231         (browserWindowLoaderClientInit):
3232         (browser_window_new):
3233         (browser_window_get_view):
3234         * MiniBrowser/gtk/BrowserWindow.h: Added.
3235         * MiniBrowser/gtk/GNUmakefile.am:
3236         * MiniBrowser/gtk/main.c:
3237         (createWindow):
3238
3239 2011-04-28  Stephanie Lewis  <slewis@apple.com>
3240
3241         Reviewed by Mark Rowe.
3242
3243         http://bugs.webkit.org/show_bug.cgi?id=59743
3244         <rdar://problem/9040413> Add an install target for production builds.
3245
3246         * DumpRenderTree/mac/PerlSupport/Makefile:
3247
3248 2011-04-28  Adam Roben  <aroben@apple.com>
3249
3250         Stop and restart ATSServer before each test run on Leopard
3251
3252         This is to work around an ATSServer leak that eventually causes tests
3253         to fail.
3254
3255         Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
3256         fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
3257         (due to ATSServer leak)
3258
3259         Reviewed by Dan Bernstein.
3260
3261         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3262         (StopATSServer):
3263         (StartATSServer):
3264         Added these new commands to stop and start ATSServer.
3265
3266         (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
3267
3268 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3269
3270         Reviewed by Adam Roben.
3271
3272         add Leopard NRWT bot to the scheduler
3273         https://bugs.webkit.org/show_bug.cgi?id=59766
3274
3275         * BuildSlaveSupport/build.webkit.org-config/config.json:
3276
3277 2011-04-28  Sam Weinig  <sam@webkit.org>
3278
3279         Fix WebKitTestRunner build.
3280
3281         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3282         The Derived Sources target needs a product name.
3283
3284 2011-04-28  Sam Weinig  <sam@webkit.org>
3285
3286         Reviewed by Mark Rowe.
3287
3288         Add install support for WebKitTestRunner.
3289         <rdar://problem/9349055>
3290
3291         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3292         Add missing CompilerVersion.xcconfig.
3293
3294         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3295         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3296         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3297         Add install path and tell it not to skip installation.
3298
3299         Add missing CompilerVersion.xcconfig.
3300
3301 2011-04-28  David Levin  <levin@chromium.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         Remove IMAGE_RESIZER related code.
3306         https://bugs.webkit.org/show_bug.cgi?id=59735
3307
3308         * Scripts/build-webkit:
3309
3310 2011-04-28  Sam Weinig  <sam@webkit.org>
3311
3312         Reviewed by Adam Roben.
3313
3314         Make reading skipped files from additional platform
3315         directories work in WebKit2 mode.
3316
3317         * Scripts/old-run-webkit-tests:
3318         (buildPlatformTestHierarchy): Simplify logic to always use the first
3319         and last platforms in the build hierarchy as the test hierarchy, and to
3320         insert the WebKit2 platform in the middle if it exists. Yum.
3321
3322 2011-04-28  Adam Barth  <abarth@webkit.org>
3323
3324         Reviewed by Eric Seidel.
3325
3326         Remove WML
3327         https://bugs.webkit.org/show_bug.cgi?id=59678
3328
3329         Remove build system integration and test harness integration for WML.
3330
3331         * Scripts/build-webkit:
3332         * Scripts/old-run-webkit-tests:
3333         * Scripts/webkitperl/features.pm:
3334         * Scripts/webkitpy/layout_tests/port/webkit.py:
3335         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3336
3337 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3338
3339         Reviewed by Mihai Parparita.
3340
3341         use a hierarchical data structure to store results json
3342         https://bugs.webkit.org/show_bug.cgi?id=59736
3343
3344         Instead of a map from test name to results dict, we now store a hierarchical
3345         data structure.
3346
3347         Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
3348         New:
3349         { foo: {
3350             bar: {
3351               baz.html: results_dict,
3352               baz2.html: results_dict } } }
3353
3354         This cut ~52% of the size of times_ms.json. I expect it will cut
3355         30-40% of full_results.json and unexpected_results.json.
3356
3357         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3358         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3359         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3360         Using os.sep was just wrong since relative_test_filename canonicalizes separators.
3361         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3362         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3364         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3365         Instead of plumbing through the change to all of the rebaselineserver
3366         python and JS, just convert to the old format after reading in the json.
3367
3368 2011-04-28  Eric Seidel  <eric@webkit.org>
3369
3370         Reviewed by Adam Barth.
3371
3372         EWS Bubbles should show commit-queue position when patch is in the commit-queue
3373         https://bugs.webkit.org/show_bug.cgi?id=59744
3374
3375         Add target="_top" to the bubble links.  This was
3376         forgotten when I moved from using an onclick to a normal link.
3377
3378         * QueueStatusServer/templates/statusbubble.html:
3379
3380 2011-04-28  Eric Seidel  <eric@webkit.org>
3381
3382         Reviewed by Adam Barth.
3383
3384         EWS bubbles should show "submit to ews" button if they've not been processed
3385         https://bugs.webkit.org/show_bug.cgi?id=59751
3386
3387         * QueueStatusServer/handlers/statusbubble.py:
3388         * QueueStatusServer/handlers/submittoews.py:
3389         * QueueStatusServer/templates/statusbubble.html:
3390         * QueueStatusServer/templates/submittoews.html:
3391
3392 2011-04-28  Eric Seidel  <eric@webkit.org>
3393
3394         Reviewed by Adam Barth.
3395
3396         EWS Bubbles should show commit-queue position when patch is in the commit-queue
3397         https://bugs.webkit.org/show_bug.cgi?id=59744
3398
3399         This was actually just a 2 line change to statusbubble.py.
3400         I also cleaned up statusbubble.html a little while I was there
3401         (the links are now actual <a> tags and have hover).
3402
3403         * QueueStatusServer/handlers/statusbubble.py:
3404         * QueueStatusServer/templates/statusbubble.html:
3405
3406 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3407
3408         Reviewed by Eric Seidel.
3409
3410         add a mac leopard release NRWT bot
3411         https://bugs.webkit.org/show_bug.cgi?id=59733
3412
3413         * BuildSlaveSupport/build.webkit.org-config/config.json:
3414
3415 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3416
3417         Avoid crashing when running new-run-webkit-tests outside of
3418         version control.
3419
3420         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3421
3422 2011-04-28  Xan Lopez  <xlopez@igalia.com>
3423
3424         Unreviewed build fix.
3425
3426         * GNUmakefile.am:
3427
3428 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3429
3430         Reviewed by Eric Seidel.
3431
3432         fix python printing test
3433         https://bugs.webkit.org/show_bug.cgi?id=59719
3434
3435         Now that we run scm commands in summarize_results, --verbose prints
3436         debug logging to stderr.
3437
3438         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3439
3440 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3441
3442         Reviewed by Tony Chang.
3443
3444         link to tests at a specific revision in the results.html file
3445         https://bugs.webkit.org/show_bug.cgi?id=59711
3446
3447         * Scripts/webkitpy/common/checkout/scm.py:
3448         Add a method to get the head svn revision.
3449         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3450         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3451         Include the svn revision in the results json.
3452
3453 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3454
3455         Reviewed by Sam Weinig.
3456
3457         [GTK] Remove WKURLCreateWithURL()
3458         https://bugs.webkit.org/show_bug.cgi?id=59691
3459
3460         Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().
3461
3462         * MiniBrowser/gtk/main.c:
3463         (activateUriEntryCallback):
3464         (main):
3465
3466 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3467
3468         Reviewed by Martin Robinson.
3469
3470         [GTK] WKView should be a GtkWidget
3471         https://bugs.webkit.org/show_bug.cgi?id=59603
3472
3473         Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.
3474
3475         * MiniBrowser/gtk/main.c:
3476         (createWindow):
3477         (main):
3478
3479 2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>
3480
3481         Reviewed by Csaba Osztrogonác.
3482
3483         [Qt] Add ARM specific Skipped list
3484         https://bugs.webkit.org/show_bug.cgi?id=59680
3485
3486         * Scripts/old-run-webkit-tests:
3487         * Scripts/webkitdirs.pm:
3488
3489 2011-04-27  Eric Seidel  <eric@webkit.org>
3490
3491         Reviewed by Adam Barth.
3492
3493         error_log.txt should include PHP errors
3494         https://bugs.webkit.org/show_bug.cgi?id=59643
3495
3496         Turns out this was really easy after I finally learned
3497         enough about PHP to do it...
3498
3499         I'm adding this in hopes of better tracking down
3500         our random http failures.
3501
3502         * Scripts/webkitperl/httpd.pm:
3503
3504 2011-04-27  David Levin  <levin@chromium.org>
3505
3506         Reviewed by Adam Barth.
3507
3508         check-webkit-style should flags spacing errors for braces on the same line.
3509         https://bugs.webkit.org/show_bug.cgi?id=59665
3510
3511         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3512         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
3513           and fixed some test cases to not trigger this error since it isn't what they are verifying.
3514
3515 2011-04-27  David Levin  <levin@chromium.org>
3516
3517         Reviewed by Adam Barth.
3518
3519         check-webkit-style error for spaces after periods in a comment has a bad error
3520         message and warns about end of line spaces.
3521         https://bugs.webkit.org/show_bug.cgi?id=59663
3522
3523         * Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
3524         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
3525         and changed the error messages.
3526
3527 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3528
3529         remove assertion now that platform/mac-tiger no longer exists
3530         https://bugs.webkit.org/show_bug.cgi?id=59660
3531
3532         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3533
3534 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3535
3536         Reviewed by Eric Seidel.
3537
3538         remove test that didn't make sense
3539         https://bugs.webkit.org/show_bug.cgi?id=59658
3540
3541         It was artifically saying the test wasn't expected to pass,
3542         but the expectations string was empty. The case of unexpected
3543         passes with a real expectations string is tested later in the
3544         same test.
3545
3546         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3547
3548 2011-04-27  Sam Weinig  <sam@webkit.org>
3549
3550         Reviewed by Adam Roben.
3551
3552         WebKit2 needs to notify the client when a plugin fails to initialize
3553         https://bugs.webkit.org/show_bug.cgi?id=59657
3554
3555         * MiniBrowser/mac/BrowserWindowController.m:
3556         (-[BrowserWindowController awakeFromNib]):
3557         * WebKitTestRunner/TestController.cpp:
3558         (WTR::TestController::initialize):
3559         Add stubs.
3560
3561 2011-04-26  Sam Weinig  <sam@webkit.org>
3562
3563         Reviewed by David Levin.
3564
3565         Add a few more missing options to new-run-webkit-tests
3566         https://bugs.webkit.org/show_bug.cgi?id=59567
3567
3568         Add support for:
3569             --threaded
3570             --gc-between-tests
3571             --complex-text
3572
3573         * Scripts/webkitpy/layout_tests/port/webkit.py:
3574         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3575         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3576
3577 2011-04-27  Mark Rowe  <mrowe@apple.com>
3578
3579         Build fix.
3580
3581         Fix an OwnPtr-related issue that was missed before the strictness was turned on.
3582         
3583         * WebKitTestRunner/TestController.cpp:
3584         (WTR::TestController::runTest):
3585
3586 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3587
3588         Forgot to upload the new times_ms.json file after splitting
3589         it out from full_results.json.
3590
3591         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3592
3593 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3594
3595         Fix snafu in generating the JSON for the chromium tests.
3596
3597         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3598
3599 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3600
3601         Fix bad merge. This broke the chromium tests generating JSON files.
3602         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3603
3604 2011-04-27  Mark Rowe  <mrowe@apple.com>
3605
3606         Rubber-stamped by Geoff Garen.
3607
3608         Don't look for results in a location that no longer exists.
3609
3610         * Scripts/old-run-webkit-tests:
3611
3612 2011-04-27  Adrienne Walker  <enne@google.com>
3613
3614         Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
3615
3616         * Scripts/webkitpy/common/config/committers.py:
3617
3618 2011-04-22  Ojan Vafai  <ojan@chromium.org>
3619
3620         Reviewed by Tony Chang.
3621
3622         only include failures in full_results.json
3623         https://bugs.webkit.org/show_bug.cgi?id=59256
3624
3625         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3626
3627 2011-04-22  Ojan Vafai  <ojan@chromium.org>
3628
3629         Reviewed by Adam Roben.
3630
3631         move times into their own json file
3632         https://bugs.webkit.org/show_bug.cgi?id=59239
3633
3634         The test runtimes are the only case where we need an entry for
3635         every test that was run, including passing tests. Move them into
3636         their own json file so we can prune the other json files to only
3637         include failing tests.
3638
3639         Use a trie-like data structure to hold the tests to avoid including
3640         full test paths. This cuts 52% of the filesize. The end result is ~700k
3641         pre-gzip.
3642
3643         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3644         Exclude times from the parsed TestResults.
3645         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3646         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3647         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3648         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3649
3650 2011-04-27  Anders Carlsson  <andersca@apple.com>
3651
3652         More casts and more clang++ build fixes.
3653
3654         * DumpRenderTree/mac/DumpRenderTree.mm:
3655         (createWebViewAndOffscreenWindow):
3656         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3657         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3658         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3659         (WTR::PlatformWebView::PlatformWebView):
3660
3661 2011-04-27  Tony Chang  <tony@chromium.org>
3662
3663         Reviewed by Ojan Vafai.
3664
3665         lazily autoinstall thirdparty python libraries
3666         https://bugs.webkit.org/show_bug.cgi?id=55723
3667
3668         This helps by only having pywebsocket installed when the bots run.  It
3669         doesn't help much for devs since webkit-patch pulls in almost everything.
3670
3671         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3672         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3673         * Scripts/webkitpy/common/net/networktransaction.py:
3674         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3675         * Scripts/webkitpy/common/net/statusserver.py:
3676         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3677         * Scripts/webkitpy/thirdparty/__init__.py: Add an import hook so we can install based on
3678             the import command rather than just installing everything.
3679         * Scripts/webkitpy/thirdparty/__init___unittest.py: Added.
3680
3681 2011-04-27  Girish Ramakrishnan  <girish@forwardbias.in>
3682
3683         Add my IRC nick.
3684
3685         * Scripts/webkitpy/common/config/committers.py:
3686
3687 2011-04-27  Eric Seidel  <eric@webkit.org>
3688
3689         Reviewed by Mihai Parparita.
3690
3691         sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
3692         https://bugs.webkit.org/show_bug.cgi?id=59545
3693
3694         To do this, I needed a way to look up contributors by irc-name
3695         (since anyone in #webkit who might use this command may not be a committer).
3696         To lookup contributors, I had to make Contributor a real object.
3697         Which led me to redesign parts of committers.py...
3698         and finally fix one spot in changelog.py where we wanted to be
3699         looking up contributors and not committers.
3700
3701         Overall a pretty simple fix, once you wade through the yak-hair.
3702
3703         This may not prevent *all* possible ways that bugs would get assigned
3704         to webkit.review.bot.  If we don't recognize the requester we will
3705         go through the previous code path (which shouldn't change the assignee
3706         on the bug from the default as far as I can tell).
3707
3708         * Scripts/webkitpy/common/checkout/changelog.py:
3709         * Scripts/webkitpy/common/config/committers.py:
3710         * Scripts/webkitpy/common/config/committers_unittest.py:
3711         * Scripts/webkitpy/tool/bot/irc_command.py:
3712         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3713
3714 2011-04-27  Yi Shen  <yi.4.shen@nokia.com>
3715
3716         Reviewed by Kenneth Rohde Christiansen.
3717
3718         [Qt] Upstream Symbian platform plugin
3719         https://bugs.webkit.org/show_bug.cgi?id=58435
3720
3721         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
3722
3723         * Scripts/webkitpy/style/checker.py:
3724         * Scripts/webkitpy/style/checker_unittest.py:
3725
3726 2011-04-27  Jeff Miller  <jeffm@apple.com>
3727
3728         Correct my IRC nickname.
3729
3730         * Scripts/webkitpy/common/config/committers.py:
3731
3732 2011-04-27  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3733
3734         Reviewed by Darin Adler.
3735
3736         Change the email used on bugzilla
3737         https://bugs.webkit.org/show_bug.cgi?id=59582
3738
3739         * Scripts/webkitpy/common/config/committers.py:
3740
3741 2011-04-27  James Kozianski  <koz@chromium.org>
3742
3743         Reviewed by Ojan Vafai.
3744
3745         Extract map from port to builder name.
3746         https://bugs.webkit.org/show_bug.cgi?id=58301
3747
3748         * Scripts/webkitpy/layout_tests/port/__init__.py:
3749         * Scripts/webkitpy/layout_tests/port/builders.py: Added.
3750         * Scripts/webkitpy/layout_tests/port/builders_unittest.py: Added.
3751         * Scripts/webkitpy/layout_tests/port/factory.py:
3752
3753 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
3754
3755         Reviewed by Martin Robinson.
3756
3757         [GTK] Add proxy support to GtkLauncher
3758         https://bugs.webkit.org/show_bug.cgi?id=58852
3759
3760         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
3761
3762         * GNUmakefile.am:
3763         * GtkLauncher/main.c:
3764         (main):
3765
3766 2011-04-27  Annie Sullivan  <sullivan@chromium.org>
3767
3768         Reviewed by David Levin.
3769
3770         Adding myself as a Chromium contributor to committers.py.
3771
3772         https://bugs.webkit.org/show_bug.cgi?id=59576
3773
3774         * Scripts/webkitpy/common/config/committers.py:
3775
3776 2011-04-26  David Grogan  <dgrogan@chromium.org>
3777
3778         Reviewed by David Levin.
3779
3780         Adding myself to Chromium contributors list in committers.py
3781         https://bugs.webkit.org/show_bug.cgi?id=59565
3782
3783         * Scripts/webkitpy/common/config/committers.py:
3784
3785 2011-04-26  Chang Shu  <cshu@webkit.org>
3786
3787         Reviewed by Laszlo Gombos.
3788
3789         WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
3790         https://bugs.webkit.org/show_bug.cgi?id=42544
3791
3792         Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
3793
3794         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3795         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3796         (WTR::InjectedBundle::beginTesting):
3797         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3798         (WTR::LayoutTestController::addOriginAccessWhitelistEntry):
3799         (WTR::LayoutTestController::removeOriginAccessWhitelistEntry):
3800         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3801
3802 2011-04-26  Chris Fleizach  <cfleizach@apple.com>
3803
3804         Reviewed by Adele Peterson.
3805
3806         AX: Add more text marker routines to DRT
3807         https://bugs.webkit.org/show_bug.cgi?id=58949
3808
3809         Add a few more methods to help test the text marker system, including nextMarker, previousMarker and
3810         stringForMarkerRange.
3811
3812         * DumpRenderTree/AccessibilityUIElement.cpp:
3813         (nextTextMarkerCallback):
3814         (previousTextMarkerCallback):
3815         (stringForTextMarkerRangeCallback):
3816         (AccessibilityUIElement::previousTextMarker):
3817         (AccessibilityUIElement::nextTextMarker):
3818         (AccessibilityUIElement::stringForTextMarkerRange):
3819         (AccessibilityUIElement::getJSClass):
3820         * DumpRenderTree/AccessibilityUIElement.h:
3821         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3822         (AccessibilityUIElement::previousTextMarker):
3823         (AccessibilityUIElement::nextTextMarker):
3824         (AccessibilityUIElement::stringForTextMarkerRange):
3825
3826 2011-04-26  Dan Bernstein  <mitz@apple.com>
3827
3828         Build fix.
3829
3830         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3831         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3832         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3833
3834 2011-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3835
3836         Rubberstamped by Eric Seidel.
3837
3838         Enable waf to be used to build other ports
3839         https://bugs.webkit.org/show_bug.cgi?id=58213
3840
3841         * Scripts/build-webkit:
3842         * Scripts/webkitdirs.pm:
3843         * waf: Added.
3844         * waf/build: Added.
3845         * waf/build/build_utils.py: Added.
3846         * waf/build/settings.py: Added.
3847         * waf/build/waf_extensions.py: Added.
3848         * waf/build/wxpresets.py: Added.
3849
3850 2011-04-26  Sam Weinig  <sam@webkit.org>
3851
3852         Reviewed by David Hyatt.
3853
3854         Remove Datagrid from the tree
3855         https://bugs.webkit.org/show_bug.cgi?id=59543
3856
3857         * Scripts/build-webkit:
3858         Remove feature.
3859
3860         * iExploder/iexploder-1.3.2/htdocs/htmltags.in:
3861         * iExploder/iexploder-1.7.2/src/html-tags/webkit:
3862         Remove from fuzzer.
3863
3864 2011-04-26  Brent Fulgham  <bfulgham@webkit.org>
3865
3866         Reviewed by Adam Roben.
3867
3868         Update WinLauncher with command-line arguments to allow the
3869         transparency to be tested.  Use --transparent to create a
3870         transparent view.  Use --desktop to have the view fill the
3871         desktop area of the screen.
3872         https://bugs.webkit.org/show_bug.cgi?id=58300
3873
3874         * WinLauncher/WinLauncher.cpp:
3875         (usesLayeredWebView): New method to indicate that the
3876         program is running with layered windows (alpha-blended
3877         transparent windows).
3878         (shouldUseFullDesktop): New method to indicate that the
3879         program is running across the full desktop (less any
3880         task bars.)
3881         (resizeSubViews): Layered window mode doesn't have any
3882         winapi child windows, so this routine is exited early
3883         for that case.
3884         (subclassForLayeredWindow): Subclass the window so we can
3885         override its defaut message loop.
3886         (computeFullDesktopFrame): Convenience function to get the
3887         desktop region and update the frame dimensions appropriately.
3888         (_tWinMain): Updated to accept the new '--transparent' and
3889         '--desktop' arguments.
3890         (InitInstance): Modified to exit early for the transparent
3891         background case.  WebKit will construct our primary window (with
3892         appropriate settings) so we don't need to create one ourselves.
3893         (WndProc): 
3894         (TransparentWndProc): New message loop for transparent windows,
3895         since they need special handling to support dragging.
3896
3897 2011-04-26  Alexandre MAzari  <amazari@igalia.com>
3898
3899         Reviewed by Xan Lopez.
3900
3901         [Gtk] Implement LayoutTestController::setPluginsEnabled
3902         https://bugs.webkit.org/show_bug.cgi?id=59184
3903
3904         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3905         (LayoutTestController::setPluginsEnabled):
3906
3907 2011-04-26  Chang Shu  <cshu@webkit.org>
3908
3909         Reviewed by Laszlo Gombos.
3910
3911         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
3912         https://bugs.webkit.org/show_bug.cgi?id=57572
3913
3914         Remove the unnecessary code that updates preference.
3915
3916         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3917         (WTR::InjectedBundle::beginTesting):
3918         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3919         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
3920
3921 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
3922
3923         Reviewed by Eric Seidel.
3924
3925         [GTK] accessibility/aria-combobox-expected.txt
3926         https://bugs.webkit.org/show_bug.cgi?id=59399
3927
3928         Implement isExpanded(), as it's used in the layout test.
3929
3930         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3931         (AccessibilityUIElement::isExpanded): Implemented.
3932
3933 2011-04-26  Adrienne Walker  <enne@google.com>
3934
3935         Reviewed by Kent Tamura.
3936
3937         [chromium] Fix memory leak in DRT due to OwnPtr<T*>
3938         https://bugs.webkit.org/show_bug.cgi?id=59489
3939
3940         * DumpRenderTree/chromium/WebViewHost.h:
3941
3942 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
3943
3944         Reviewed by Eric Seidel.
3945
3946         [GTK] Implement isChecked in DRT
3947         https://bugs.webkit.org/show_bug.cgi?id=59385
3948
3949         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3950         (AccessibilityUIElement::isChecked): Implemented.
3951
3952 2011-04-26  Alejandro G. Castro  <alex@igalia.com>
3953
3954         Unreviewed, rolling out r84949.
3955         http://trac.webkit.org/changeset/84949
3956         https://bugs.webkit.org/show_bug.cgi?id=58852
3957
3958         Broke GTK+ compilation
3959
3960         * GtkLauncher/main.c:
3961         (main):
3962
3963 2011-04-26  Eric Seidel  <eric@webkit.org>
3964
3965         Reviewed by Mihai Parparita.
3966
3967         sheriff-bot should have a create-bug command
3968         https://bugs.webkit.org/show_bug.cgi?id=59491
3969
3970         This patch has some stderr unittest spew, but I will
3971         fix it after my live demo.
3972
3973         * Scripts/webkitpy/tool/bot/irc_command.py:
3974         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3975         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3976
3977 2011-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
3978
3979         Reviewed by Martin Robinson.
3980
3981         [GTK] Add proxy support to GtkLauncher
3982         https://bugs.webkit.org/show_bug.cgi?id=58852
3983
3984         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
3985
3986         * GtkLauncher/main.c:
3987         (main):
3988
3989 2011-04-26  Dan Bernstein  <mitz@apple.com>
3990
3991         Reviewed by Mark Rowe.
3992
3993         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3994
3995         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3996         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
3997         * MiniBrowser/Configurations/Base.xcconfig:
3998         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
3999         * TestWebKitAPI/Configurations/Base.xcconfig:
4000         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
4001         * WebKitTestRunner/Configurations/Base.xcconfig:
4002         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
4003
4004 2011-04-26  Finnur Thorarinsson  <finnur.webkit@gmail.com>
4005
4006         Reviewed by David Levin.
4007
4008         Adding myself as a Chromium contributors to committers.py.
4009
4010         https://bugs.webkit.org/show_bug.cgi?id=59444
4011
4012         * Scripts/webkitpy/common/config/committers.py:
4013
4014 2011-04-26  Adam Barth  <abarth@webkit.org>
4015
4016         Reviewed by Eric Seidel.
4017
4018         DumpRenderTree/chromium should play nice with strict OwnPtrs
4019         https://bugs.webkit.org/show_bug.cgi?id=59458
4020
4021         All these changes are pretty straight forward.
4022
4023         * DumpRenderTree/chromium/CppBoundClass.cpp:
4024         (GetterPropertyCallback::GetterPropertyCallback):
4025         (CppBoundClass::bindGetterCallback):
4026         * DumpRenderTree/chromium/CppBoundClass.h:
4027         (CppBoundClass::bindProperty):
4028         (CppBoundClass::bindFallbackCallback):
4029         (CppBoundClass::bindFallbackMethod):
4030         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
4031         (DRTDevToolsClient::DRTDevToolsClient):
4032         * DumpRenderTree/chromium/TestEventPrinter.cpp:
4033         (TestEventPrinter::createDRTPrinter):
4034         (TestEventPrinter::createTestShellPrinter):
4035         * DumpRenderTree/chromium/TestEventPrinter.h:
4036         * DumpRenderTree/chromium/TestShell.cpp:
4037         (TestShell::TestShell):
4038         (TestShell::createMainWindow):
4039         (TestShell::createDRTDevToolsClient):
4040         * DumpRenderTree/chromium/WebViewHost.cpp:
4041         (WebViewHost::geolocationClientMock):
4042         (WebViewHost::speechInputController):
4043         (WebViewHost::deviceOrientationClientMock):
4044         (WebViewHost::reset):
4045         (WebViewHost::navigate):
4046         (WebViewHost::setPendingExtraData):
4047         (WebViewHost::canvas):
4048         * DumpRenderTree/chromium/WebViewHost.h:
4049
4050 2011-04-26  Adam Roben  <aroben@apple.com>
4051
4052         Make DRT/win log loading errors the same way DRT/mac does
4053
4054         Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
4055         http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
4056
4057         Reviewed by Alexey Proskuryakov.
4058
4059         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4060         (ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
4061         <rdar://problem/5064234>, which has long since been fixed, and then made this function match
4062         -[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
4063
4064 2011-04-26  Dan Bernstein  <mitz@apple.com>
4065
4066         REGRESSION (84876): build-webkit produces an error message
4067         https://bugs.webkit.org/show_bug.cgi?id=59460
4068
4069         * Scripts/webkitdirs.pm:
4070
4071 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
4072
4073         Reviewed by Eric Seidel.
4074
4075         Fix timestamp comparison in check-for-weak-vtables-and-externals
4076         https://bugs.webkit.org/show_bug.cgi?id=59416
4077         
4078         We should only re-run the check-for-weak-vtables-and-externals script
4079         if the executable is more recent than the last run.
4080
4081         * Scripts/check-for-weak-vtables-and-externals:
4082
4083 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
4084
4085         Reviewed by Csaba Osztrogonác.
4086
4087         [Qt] Implement LayoutTestController::setAutofilled
4088         https://bugs.webkit.org/show_bug.cgi?id=59439
4089
4090         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4091         (LayoutTestController::setAutofilled):
4092         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4093
4094 2011-04-25  Dan Bernstein  <mitz@apple.com>
4095
4096         Reviewed by Mark Rowe.
4097
4098         Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
4099
4100         * Scripts/webkitdirs.pm:
4101
4102 2011-04-25  Sam Weinig  <sam@webkit.org>
4103
4104         Reviewed by Adam Roben.
4105
4106         Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
4107         https://bugs.webkit.org/show_bug.cgi?id=56090
4108
4109         Make LeaksViewer work with versions of browsers that don't support message
4110         passing of cyclic structures.
4111
4112         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
4113         (LeaksParser.this._worker.onmessage):
4114         (LeaksParser):
4115         (LeaksParser.prototype.addLeaksFile):
4116         Use LeaksParserImpl directly if we don't support passing cyclic structures.
4117
4118         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
4119         (LeaksParserImpl):
4120         (LeaksParserImpl.prototype.addLeaksFile):
4121         (LeaksParserImpl.prototype._incorporateLeaks):
4122         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
4123         (onmessage):
4124         Factor out LeaksParser implementation into LeaksParserImpl.js.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
4127         (workersSupportCyclicStructures):
4128         Add function to detect if workers support passing cyclic structures.
4129
4130         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
4131         Add LeaksParserImpl.js include.
4132
4133 2011-04-25  Jeff Miller  <jeffm@apple.com>
4134
4135         Reviewed by Timothy Hatcher.
4136
4137         Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
4138         https://bugs.webkit.org/show_bug.cgi?id=59373
4139
4140         * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
4141
4142 2011-04-25  Andrew Scherkus  <scherkus@chromium.org>
4143
4144         Reviewed by Dimitri Glazkov.
4145
4146         Adding a few Chromium contributors to committers.py.
4147
4148         https://bugs.webkit.org/show_bug.cgi?id=59327
4149
4150         * Scripts/webkitpy/common/config/committers.py:
4151
4152 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
4153
4154         Reviewed by Dimitri Glazkov.
4155
4156         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
4157         https://bugs.webkit.org/show_bug.cgi?id=59284
4158
4159         Chromium DRT over-refcounted the NPObject wrappers it used to
4160         marshal shadowRoot nodes back to tests (WebBindings::makeNode
4161         births NPObjects with referenceCount == 1). This masked the GC bug
4162         59284 in tests by making shadowRoot nodes live forever.
4163
4164         * DumpRenderTree/chromium/LayoutTestController.cpp:
4165         (LayoutTestController::shadowRoot):
4166         (LayoutTestController::ensureShadowRoot):
4167
4168 2011-04-23  Kevin Ollivier  <kevino@theolliviers.com>
4169
4170         [wx] Unreviewed build fixes. Add new methods to wx LayoutTestController,
4171         and update the URL for downloading waf.
4172         
4173         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4174         (LayoutTestController::ensureShadowRoot):
4175         (LayoutTestController::removeShadowRoot):
4176         * Scripts/webkitdirs.pm:
4177
4178 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
4179
4180         Unreviewed, rolling out r84627.
4181         http://trac.webkit.org/changeset/84627
4182         https://bugs.webkit.org/show_bug.cgi?id=59271
4183
4184         It broke Symbian build (Requested by Ossy on #webkit).
4185
4186         * Scripts/webkitpy/style/checker.py:
4187         * Scripts/webkitpy/style/checker_unittest.py:
4188
4189 2011-04-22  Dirk Pranke  <dpranke@chromium.org>
4190
4191         Reviewed by Adam Barth.
4192
4193         rebaseline-chromium-webkit-tests: clean up output
4194         https://bugs.webkit.org/show_bug.cgi?id=59240
4195
4196         This change dramatically changes the output the tool provides
4197         by default. The previous output (more or less) is still there
4198         in -v / verbose / debug mode, but the default output is
4199         way terser and more readable. It mostly says which files are
4200         updated, which are duplicates, and which are not found in an
4201         archive. Feedback desired :).
4202
4203         This change also adds a scm.exists() method to the SCM object
4204         so that we can cleanly figure out what we're doing while
4205         rebaselining.
4206
4207         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4208         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
4209         * Scripts/webkitpy/common/system/filesystem_mock.py:
4210         * Scripts/webkitpy/common/checkout/scm.py:
4211         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4212
4213 2011-04-22  Ilya Sherman  <isherman@chromium.org>
4214
4215         Reviewed by Alexey Proskuryakov.
4216
4217         Add Ilya Sherman (isherman@chromium.org) to the list of contributors
4218         https://bugs.webkit.org/show_bug.cgi?id=59231
4219
4220         * Scripts/webkitpy/common/config/committers.py:
4221
4222 2011-04-22  Yuta Kitamura  <yutak@chromium.org>
4223
4224         Reviewed by Ojan Vafai.
4225
4226         new-run-webkit-tests: Exception raised when stderr contains binary data
4227         https://bugs.webkit.org/show_bug.cgi?id=59083
4228
4229         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
4230         Use write_binary_file() instead of write_text_file().
4231
4232 2011-04-22  Chang Shu  <cshu@webkit.org>
4233
4234         Reviewed by Kenneth Rohde Christiansen.
4235
4236         WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
4237         https://bugs.webkit.org/show_bug.cgi?id=42536
4238
4239         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4240         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4241         (WTR::LayoutTestController::setFrameFlatteningEnabled):
4242         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4243
4244 2011-04-22  Adam Barth  <abarth@webkit.org>
4245
4246         Reviewed by Eric Seidel.
4247
4248         CommitQueue should remember the expected failures from patch to patch
4249         https://bugs.webkit.org/show_bug.cgi?id=59253
4250
4251         Previously, we stored the set of expected failures on the task object,
4252         which meant the commit-queue forgot about them after each patch.  This
4253         patch moves them to the CommitQueue object so they will have a longer
4254         lifetime.
4255
4256         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4257         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4258         * Scripts/webkitpy/tool/commands/queues.py:
4259
4260 2011-04-22  Sam Weinig  <sam@webkit.org>
4261
4262         Reviewed by Brian Weinstein.
4263
4264         WebKit2: Implement JavaScript unresponsiveness timer/callbacks
4265         https://bugs.webkit.org/show_bug.cgi?id=59248
4266
4267         Stub out shouldInterruptJavaScript callbacks.
4268
4269         * MiniBrowser/mac/BrowserWindowController.m:
4270         (-[BrowserWindowController awakeFromNib]):
4271         * MiniBrowser/win/BrowserView.cpp:
4272         (BrowserView::create):
4273         * WebKitTestRunner/TestController.cpp:
4274         (WTR::TestController::createOtherPage):
4275         (WTR::TestController::initialize):
4276
4277 2011-04-22  Daniel Bates  <dbates@webkit.org>
4278
4279         Reviewed by Csaba Osztrogonác.
4280
4281         webkit-patch land hangs if svn prompts for credentials
4282         https://bugs.webkit.org/show_bug.cgi?id=31500
4283
4284         Make has_authorization_for_realm() return True only if there exists a credentials file
4285         that contains either the word "password" or "passtype". We assume that these words don't
4286         coincide with the actual credential data (e.g. a person's username is "password").
4287
4288         * Scripts/webkitpy/common/checkout/scm.py:
4289         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4290           - Added test cases:
4291             test_has_authorization_for_realm_using_credentials_with_passtype(),
4292             test_has_authorization_for_realm_using_credentials_with_password(),
4293             test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
4294           - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
4295             to better describe what it's testing.
4296           - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
4297             and return the result of calling has_authorization_for_realm() so that the caller can
4298             assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
4299             better reflect its new purpose.
4300
4301 2011-04-22  Adam Barth  <abarth@webkit.org>
4302
4303         Remove double-negative.  (Sorry this was bugging me.)
4304
4305         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4306
4307 2011-04-22  Adam Barth  <abarth@webkit.org>
4308
4309         Reviewed by Eric Seidel.
4310
4311         Factor LayoutTestResultsReader out of CommitQueue
4312         https://bugs.webkit.org/show_bug.cgi?id=59244
4313
4314         This code will be shared with the EWS when they start running tests.
4315
4316         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
4317         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
4318         * Scripts/webkitpy/tool/commands/queues.py:
4319         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4320
4321 2011-04-22  Eric Seidel  <eric@webkit.org>
4322
4323         Reviewed by Dimitri Glazkov.
4324
4325         webkit-patch rebaseline is broken
4326         https://bugs.webkit.org/show_bug.cgi?id=59207
4327
4328         My recent changes to how LayoutTestResults.results_from_string
4329         uncovered a bug in our use of urllib2.
4330         We now are treating the return value from _fetch_results_html()
4331         (which returns urllib2.openurl()) as a string.  That's incorrect,
4332         the return value is a file-like object (which auto-converts to a
4333         string in most cases).
4334
4335         I've updated our urllib2-using code to correctly call .read() on the
4336         resulting object before treating it like a string.
4337         Unfortunately there is no easy way to test this mis-understanding
4338         of the openurl() semantics.
4339
4340         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4341
4342 2011-04-22  Adam Barth  <abarth@webkit.org>
4343
4344         Reviewed by Eric Seidel.
4345
4346         Factor PatchAnalysis task out of CommitQueueTask
4347         https://bugs.webkit.org/show_bug.cgi?id=59220
4348
4349         This is a first step towards teaching the EWS to run tests.
4350
4351         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4352         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4353         * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
4354
4355 2011-04-22  Philippe Normand  <pnormand@igalia.com>
4356
4357         Reviewed by Martin Robinson.
4358
4359         [GTK] DRT: implement eventSender.scalePageBy
4360         https://bugs.webkit.org/show_bug.cgi?id=59082
4361