Tools/ChangeLog

   1 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
   2
   3         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
   4         https://bugs.webkit.org/show_bug.cgi?id=143646
   5
   6         Reviewed by David Kilzer.
   7
   8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
   9         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
  10
  11 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
  12
  13         Use en_US spell checker for tests on Mac instead of Multilingual
  14         https://bugs.webkit.org/show_bug.cgi?id=143641
  15
  16         Reviewed by Dan Bernstein.
  17
  18         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
  19         While at it, override NSUserDictionaryReplacementItems, so that user replacements
  20         cannot affect tests.
  21
  22         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
  23         Made this more like WebKit1 version.
  24
  25 2015-04-10  Tim Horton  <timothy_horton@apple.com>
  26
  27         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
  28         https://bugs.webkit.org/show_bug.cgi?id=143576
  29
  30         Reviewed by Simon Fraser.
  31
  32         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
  33         (TEST):
  34         Adopt.
  35
  36 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
  37
  38         Update my email address and expertise.
  39         https://bugs.webkit.org/show_bug.cgi?id=143586
  40
  41         Unreviewed, just update my info.
  42
  43         * Scripts/webkitpy/common/config/contributors.json:
  44
  45 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
  46
  47         Flakiness Dashboard not loading insecure content if loaded with https URL
  48         https://bugs.webkit.org/show_bug.cgi?id=143570
  49
  50         Reviewed by Alexey Proskuryakov.
  51
  52         * TestResultServer/app.yaml:
  53         * TestResultServer/static-dashboards/loader.js:
  54         Switch to https scheme.
  55
  56 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
  57
  58         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
  59         https://bugs.webkit.org/show_bug.cgi?id=142907
  60
  61         Reviewed by Carlos Garcia Campos.
  62
  63         * TestWebKitAPI/PlatformEfl.cmake:
  64         * TestWebKitAPI/PlatformGTK.cmake:
  65         * WebKitTestRunner/PlatformEfl.cmake:
  66         * WebKitTestRunner/PlatformGTK.cmake:
  67
  68 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
  69
  70         [Mac] Unreviewed test fix after r182584
  71         https://bugs.webkit.org/show_bug.cgi?id=143452
  72
  73         Put both of these tests back to their original state now that the underlying
  74         problem is fixed.
  75
  76         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
  77         (TestWebKitAPI::TEST):
  78         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
  79         (TestWebKitAPI::TEST):
  80
  81 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
  82
  83         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
  84         https://bugs.webkit.org/show_bug.cgi?id=143553
  85
  86         Reviewed by Ryosuke Niwa.
  87
  88         Remove the spurious printVMs left over from an earlier change.
  89
  90         * Scripts/run-jsc-benchmarks:
  91
  92 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
  93
  94         [Mac] Unreviewed test fix after r182581
  95
  96         The behavior of control-left-click is controlled by a system preference.
  97         Our test bots have this turned off.
  98
  99         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
 100         (TestWebKitAPI::TEST):
 101         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
 102         (TestWebKitAPI::TEST):
 103
 104 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 105
 106         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
 107         https://bugs.webkit.org/show_bug.cgi?id=143452
 108         <rdar://problem/20437483>
 109
 110         Reviewed by Tim Horton.
 111
 112         Add a new API test to confirm that Cocoa mouse button press events are properly
 113         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
 114
 115         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
 116         some registered event handlers that the expected button press and context menu
 117         events are received.
 118
 119         The WK1 unit test creates an NSEvent with the desired button press state, and then
 120         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
 121         We check the resulting PlatformMouseEvent for proper state.
 122
 123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
 124         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
 125         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
 126         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
 127         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
 128         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
 129         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
 130         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 131         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
 132         mouse down events.
 133         * TestWebKitAPI/mac/PlatformWebViewMac.h:
 134
 135 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
 136
 137         [GTK] Add pango to jhbuild-optional.modules
 138         https://bugs.webkit.org/show_bug.cgi?id=143537
 139
 140         Reviewed by Martin Robinson.
 141
 142         * gtk/jhbuild-optional.modules: Add pango.
 143
 144 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 145
 146         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
 147         https://bugs.webkit.org/show_bug.cgi?id=143530
 148
 149         Reviewed by Žan Doberšek.
 150
 151         Assume that the default value for display (:0) is reserved and start checking on :1
 152         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
 153         and for X server named Xorg.bin (previous bug 1376599)
 154
 155         * Scripts/webkitpy/port/xvfbdriver.py:
 156         (XvfbDriver._next_free_display)
 157         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
 158         (XvfbDriverTest.test_start_no_pixel_tests):
 159         (XvfbDriverTest.test_start_pixel_tests):
 160         (XvfbDriverTest.test_start_arbitrary_worker_number):
 161         (XvfbDriverTest.test_next_free_display):
 162         (XvfbDriverTest.test_start_next_worker):
 163 2015-04-08  Alex Christensen  <achristensen@webkit.org>
 164
 165         Block popups from content extensions.
 166         https://bugs.webkit.org/show_bug.cgi?id=143497
 167
 168         Reviewed by Brady Eidson.
 169
 170         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 171         (TestWebKitAPI::TEST_F):
 172         Added popup test.
 173
 174 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
 175
 176         Add CMake build system for WinCairo port.
 177         https://bugs.webkit.org/show_bug.cgi?id=115944
 178
 179         Reviewed by Chris Dumez.
 180
 181         * CMakeLists.txt:
 182         * WinLauncher/CMakeLists.txt: Added.
 183
 184 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 185
 186         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
 187         https://bugs.webkit.org/show_bug.cgi?id=143521
 188
 189         Reviewed by Martin Robinson.
 190
 191         Add a way to detect unexpected web process crashes to WebViewTest,
 192         and a test case to testDOMCache to trigger the crash.
 193
 194         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
 195         (WebKitDOMNodeTest::testDOMCache):
 196         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
 197         (testWebKitWebViewProcessCrashed):
 198         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
 199         (WebViewTest::WebViewTest):
 200         (WebViewTest::webProcessCrashed):
 201         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
 202
 203 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
 204
 205         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
 206         rdar://problem/20461342
 207
 208         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 209
 210 2015-04-07  Commit Queue  <commit-queue@webkit.org>
 211
 212         Unreviewed, rolling out r182511.
 213         https://bugs.webkit.org/show_bug.cgi?id=143507
 214
 215         caused debug test failures (Requested by alexchristensen on
 216         #webkit).
 217
 218         Reverted changeset:
 219
 220         "Block popups from content extensions."
 221         https://bugs.webkit.org/show_bug.cgi?id=143497
 222         http://trac.webkit.org/changeset/182511
 223
 224 2015-04-07  Alex Christensen  <achristensen@webkit.org>
 225
 226         Block popups from content extensions.
 227         https://bugs.webkit.org/show_bug.cgi?id=143497
 228
 229         Reviewed by Brady Eidson.
 230
 231         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 232         (TestWebKitAPI::TEST_F):
 233         Added popup test.
 234
 235 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
 236
 237         Get the features.json files ready for open contributions
 238         https://bugs.webkit.org/show_bug.cgi?id=143436
 239
 240         Reviewed by Darin Adler.
 241
 242         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 243         (JSONFeaturesChecker.check):
 244         Extend the syntax checking a bit, but leave everything non-mandatory
 245         very loose until we figure what fields are important.
 246
 247 2015-04-07  Tim Horton  <timothy_horton@apple.com>
 248
 249         Expose and test fixedLayoutSize via modern WebKit SPI
 250         https://bugs.webkit.org/show_bug.cgi?id=143500
 251
 252         Reviewed by Simon Fraser.
 253
 254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 255         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
 256         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
 257         (TEST):
 258         Add a test that verifies that fixedLayoutSize works at all, that
 259         it persists through a navigation, and that turning it back off reverts to
 260         laying out at the size of the view.
 261
 262 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
 263
 264         Unreviewed. Add myself as a committer.
 265
 266         * Scripts/webkitpy/common/config/contributors.json:
 267
 268 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
 269
 270         [Win] Bots complain about missing /etc/catalog
 271         https://bugs.webkit.org/show_bug.cgi?id=143484
 272
 273         Reviewed by Chris Dumez.
 274
 275         The libxml2 build on Mac, iOS, and Windows does not provide the set
 276         of default catalog files. We do not actually need these for our
 277         purposes, but we get warnings and some bot flakiness because they
 278         are not present.
 279
 280         We can avoid both problems the same way the Mac and iOS ports do,
 281         by setting the XML_CATALOG_FILES environment variable to 'empty string',
 282         which avoid the warnings and bot problems.
 283
 284         * Scripts/webkitpy/port/win.py:
 285         (WinPort.setup_environ_for_server): Added.
 286
 287 2015-04-06  Sam Weinig  <sam@webkit.org>
 288
 289         Use content extensions in MiniBrowser.
 290         https://bugs.webkit.org/show_bug.cgi?id=143446
 291
 292         Reviewed by Alex Christensen.
 293
 294         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 295         * MiniBrowser/mac/AppDelegate.h:
 296         * MiniBrowser/mac/AppDelegate.m:
 297         (-[BrowserAppDelegate init]):
 298         (-[BrowserAppDelegate showExtensionsManager:]):
 299         (-[BrowserAppDelegate userContentContoller]):
 300         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 301         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 302         (-[ExtensionManagerWindowController init]):
 303         (-[ExtensionManagerWindowController windowDidLoad]):
 304         (-[ExtensionManagerWindowController add:]):
 305         (-[ExtensionManagerWindowController remove:]):
 306         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 307         * MiniBrowser/mac/MainMenu.xib:
 308
 309 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 310
 311         web-platform-tests server should retrieve the modules file relatively to its docroot path
 312         https://bugs.webkit.org/show_bug.cgi?id=142742
 313
 314         Reviewed by Darin Adler.
 315
 316         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 317         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
 318
 319 2015-04-06  Commit Queue  <commit-queue@webkit.org>
 320
 321         Unreviewed, rolling out r182445.
 322         https://bugs.webkit.org/show_bug.cgi?id=143459
 323
 324         broke 32 bit build (Requested by alexchristensen on #webkit).
 325
 326         Reverted changeset:
 327
 328         "Use content extensions in MiniBrowser."
 329         https://bugs.webkit.org/show_bug.cgi?id=143446
 330         http://trac.webkit.org/changeset/182445
 331
 332 2015-04-06  Sam Weinig  <sam@webkit.org>
 333
 334         Use content extensions in MiniBrowser.
 335         https://bugs.webkit.org/show_bug.cgi?id=143446
 336
 337         Reviewed by Alex Christensen.
 338
 339         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 340         * MiniBrowser/mac/AppDelegate.h:
 341         * MiniBrowser/mac/AppDelegate.m:
 342         (-[BrowserAppDelegate init]):
 343         (-[BrowserAppDelegate showExtensionsManager:]):
 344         (-[BrowserAppDelegate userContentContoller]):
 345         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 346         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 347         (-[ExtensionManagerWindowController init]):
 348         (-[ExtensionManagerWindowController windowDidLoad]):
 349         (-[ExtensionManagerWindowController add:]):
 350         (-[ExtensionManagerWindowController remove:]):
 351         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 352         * MiniBrowser/mac/MainMenu.xib:
 353
 354 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
 355
 356         [GTK] install-dependencies should prefer dnf to yum
 357         https://bugs.webkit.org/show_bug.cgi?id=143441
 358
 359         Reviewed by Martin Robinson.
 360
 361         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
 362
 363         * gtk/install-dependencies:
 364
 365 2015-04-06  Andy Estes  <aestes@apple.com>
 366
 367         [iOS] 'make clean' fails in Tools/WebKitTestRunner
 368         https://bugs.webkit.org/show_bug.cgi?id=143455
 369
 370         Reviewed by Dan Bernstein.
 371
 372         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
 373         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
 374
 375         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
 376
 377 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
 378
 379         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
 380         https://bugs.webkit.org/show_bug.cgi?id=143450
 381
 382         Reviewed by Anders Carlsson.
 383
 384         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
 385         Make sure that the view is actually closed, regardless of anything else that happens beneath.
 386         Also, removed unnecessary get() calls.
 387
 388 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
 389
 390         Reduce the dependency on Flash in regression tests
 391         https://bugs.webkit.org/show_bug.cgi?id=143391
 392
 393         Reviewed by Anders Carlsson.
 394
 395         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
 396         Only allow QuickTime and the test plug-in.
 397
 398 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 399
 400         W3C test importer should generate the modules installed dynamically to run wpt tests
 401         https://bugs.webkit.org/show_bug.cgi?id=142738
 402
 403         Reviewed by Ryosuke Niwa.
 404
 405         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
 406         The implementation is done within TestDownloader and it is activated for the WPT repository.
 407         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
 408
 409         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 410         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
 411         * Scripts/webkitpy/w3c/test_downloader.py:
 412         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
 413         (TestDownloader):
 414         (TestDownloader._git_submodules_description): Computes submodule description.
 415         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
 416         * Scripts/webkitpy/w3c/test_importer.py:
 417         (TestImporter.do_import): Added the possibility to post process the tests.
 418         (TestImporter):
 419         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
 420         (TestImporter.should_convert_test_harness_links): Updated according new options format.
 421         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 422         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
 423         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
 424         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
 425         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
 426         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
 427
 428 2015-04-05  Antti Koivisto  <antti@apple.com>
 429
 430         Bloom filter should support longer hashes
 431         https://bugs.webkit.org/show_bug.cgi?id=143419
 432
 433         Reviewed by Dan Bernstein.
 434
 435         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
 436         (TestWebKitAPI::generateRandomDigests):
 437         (TestWebKitAPI::TEST):
 438
 439 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 440
 441         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
 442         https://bugs.webkit.org/show_bug.cgi?id=143372
 443
 444         Reviewed by Darin Adler.
 445
 446         * Scripts/run-jsc-stress-tests:
 447
 448 2015-04-03  Antti Koivisto  <antti@apple.com>
 449
 450         Add non-counting bloom filter class
 451         https://bugs.webkit.org/show_bug.cgi?id=143366
 452
 453         Reviewed by Sam Weinig.
 454
 455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 456         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
 457         (TestWebKitAPI::generateRandomHashes):
 458         (TestWebKitAPI::TEST):
 459
 460 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 461
 462         FTL JIT tests should fail if LLVM library isn't available
 463         https://bugs.webkit.org/show_bug.cgi?id=143374
 464
 465         Reviewed by Mark Lam.
 466
 467         * Scripts/run-jsc-stress-tests:
 468
 469 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 470
 471         [EFL] Speedup jhbuild with disable running autogen.sh
 472         https://bugs.webkit.org/show_bug.cgi?id=143369
 473
 474         Reviewed by Gyuyoung Kim.
 475
 476         * efl/jhbuild.modules:
 477
 478 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 479
 480         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
 481         https://bugs.webkit.org/show_bug.cgi?id=143282
 482
 483         Reviewed by Daniel Bates.
 484
 485         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
 486
 487 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 488
 489         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
 490         https://bugs.webkit.org/show_bug.cgi?id=143240
 491         rdar://problem/19990425
 492
 493         Reviewed by Tim Horton.
 494
 495         * DumpRenderTree/mac/LayoutTestHelper.m:
 496         (colorProfileURLForDisplay):
 497         (saveDisplayColorProfiles):
 498         Gracefully handle it when the current profile cannot be retrieved, fixing at
 499         least one case when LayoutTestHelper couldn't start.
 500
 501         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 502         (Manager._set_up_run):
 503         (Manager._force_pixel_tests_if_needed):
 504         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
 505         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
 506         Return and check an error from start_helper().
 507
 508 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
 509
 510         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
 511         https://bugs.webkit.org/show_bug.cgi?id=143321
 512
 513         Reviewed by Alexey Proskuryakov.
 514
 515         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
 516
 517 2015-04-01  Enrica Casucci  <enrica@apple.com>
 518
 519         Injected bundle messages should be at the page level.
 520         https://bugs.webkit.org/show_bug.cgi?id=143283
 521
 522         Reviewed by Alexey Proskuryakov.
 523
 524         Updating WebKitTestRunner to use the new page level messaging.
 525         The author of this patch is Tim Horton, I just finished it.
 526
 527         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 528         (WTR::EventSendingController::mouseDown):
 529         (WTR::EventSendingController::mouseUp):
 530         (WTR::EventSendingController::mouseMoveTo):
 531         (WTR::EventSendingController::leapForward):
 532         (WTR::EventSendingController::scheduleAsynchronousClick):
 533         (WTR::EventSendingController::keyDown):
 534         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
 535         (WTR::EventSendingController::mouseScrollBy):
 536         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
 537         (WTR::EventSendingController::continuousMouseScrollBy):
 538         (WTR::EventSendingController::addTouchPoint):
 539         (WTR::EventSendingController::updateTouchPoint):
 540         (WTR::EventSendingController::setTouchModifier):
 541         (WTR::EventSendingController::setTouchPointRadius):
 542         (WTR::EventSendingController::touchStart):
 543         (WTR::EventSendingController::touchMove):
 544         (WTR::EventSendingController::touchEnd):
 545         (WTR::EventSendingController::touchCancel):
 546         (WTR::EventSendingController::clearTouchPoints):
 547         (WTR::EventSendingController::releaseTouchPoint):
 548         (WTR::EventSendingController::cancelTouchPoint):
 549         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 550         (WTR::InjectedBundle::didReceiveMessage):
 551         (WTR::InjectedBundle::didReceiveMessageToPage):
 552         (WTR::InjectedBundle::done):
 553         (WTR::InjectedBundle::outputText):
 554         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
 555         (WTR::InjectedBundle::postAddChromeInputField):
 556         (WTR::InjectedBundle::postRemoveChromeInputField):
 557         (WTR::InjectedBundle::postFocusWebView):
 558         (WTR::InjectedBundle::postSetBackingScaleFactor):
 559         (WTR::InjectedBundle::postSetWindowIsKey):
 560         (WTR::InjectedBundle::postSimulateWebNotificationClick):
 561         (WTR::InjectedBundle::postSetAddsVisitedLinks):
 562         (WTR::InjectedBundle::setGeolocationPermission):
 563         (WTR::InjectedBundle::setMockGeolocationPosition):
 564         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
 565         (WTR::InjectedBundle::setUserMediaPermission):
 566         (WTR::InjectedBundle::setCustomPolicyDelegate):
 567         (WTR::InjectedBundle::setHidden):
 568         (WTR::InjectedBundle::setCacheModel):
 569         (WTR::InjectedBundle::shouldProcessWorkQueue):
 570         (WTR::InjectedBundle::processWorkQueue):
 571         (WTR::InjectedBundle::queueBackNavigation):
 572         (WTR::InjectedBundle::queueForwardNavigation):
 573         (WTR::InjectedBundle::queueLoad):
 574         (WTR::InjectedBundle::queueLoadHTMLString):
 575         (WTR::InjectedBundle::queueReload):
 576         (WTR::InjectedBundle::queueLoadingScript):
 577         (WTR::InjectedBundle::queueNonLoadingScript):
 578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 579         (WTR::TestRunner::setHandlesAuthenticationChallenges):
 580         (WTR::TestRunner::setAuthenticationUsername):
 581         (WTR::TestRunner::setAuthenticationPassword):
 582         (WTR::TestRunner::secureEventInputIsEnabled):
 583         (WTR::TestRunner::setBlockAllPlugins):
 584         * WebKitTestRunner/TestController.cpp:
 585         (WTR::TestController::createWebViewWithOptions):
 586         (WTR::TestController::resetStateToConsistentValues):
 587         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
 588         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
 589         * WebKitTestRunner/TestController.h:
 590         * WebKitTestRunner/TestInvocation.cpp:
 591         (WTR::TestInvocation::invoke):
 592         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 593
 594 2015-04-01  Commit Queue  <commit-queue@webkit.org>
 595
 596         Unreviewed, rolling out r182174 and r182177.
 597         https://bugs.webkit.org/show_bug.cgi?id=143314
 598
 599         Try to correct EWS failures (Requested by bfulgham on
 600         #webkit).
 601
 602         Reverted changesets:
 603
 604         "Python SCM should be able to retrieve untracked files"
 605         https://bugs.webkit.org/show_bug.cgi?id=143135
 606         http://trac.webkit.org/changeset/182174
 607
 608         "[buildbot] clean-build script should remove untracked files
 609         and revert local changes too"
 610         https://bugs.webkit.org/show_bug.cgi?id=142400
 611         http://trac.webkit.org/changeset/182177
 612
 613 2015-04-01  Alex Christensen  <achristensen@webkit.org>
 614
 615         [Content Extensions] Properly handle regexes that match everything.
 616         https://bugs.webkit.org/show_bug.cgi?id=143281
 617
 618         Reviewed by Benjamin Poulain.
 619
 620         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 621         (TestWebKitAPI::testRequest):
 622         (TestWebKitAPI::makeBackend):
 623         (TestWebKitAPI::TEST_F):
 624         Removed duplicate code and added test.
 625
 626 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
 627
 628         Content Extensions: split the state machines to minimize prefix states
 629         https://bugs.webkit.org/show_bug.cgi?id=143253
 630
 631         Reviewed by Alex Christensen.
 632
 633         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 634         (TestWebKitAPI::TEST_F):
 635         (TestWebKitAPI::testPatternStatus):
 636
 637 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
 638
 639         Clean up Identifier factories to clarify the meaning of StringImpl*
 640         https://bugs.webkit.org/show_bug.cgi?id=143146
 641
 642         Reviewed by Filip Pizlo.
 643
 644         Simple API tests for StringImpl are added.
 645
 646         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 647         (TestWebKitAPI::TEST):
 648
 649 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
 650
 651         [EFL] Add AArch64 builder and tester bot to build.webkit.org
 652         https://bugs.webkit.org/show_bug.cgi?id=143092
 653
 654         Reviewed by Gyuyoung Kim.
 655
 656         * BuildSlaveSupport/build.webkit.org-config/config.json:
 657         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 658         (Factory.__init__):
 659         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 660
 661 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 662
 663         [buildbot] clean-build script should remove untracked files and revert local changes too
 664         https://bugs.webkit.org/show_bug.cgi?id=142400
 665
 666         Reviewed by Ryosuke Niwa.
 667
 668         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 669         A helper routine SCM.discard_untracked_files is added for that purpose.
 670
 671         * BuildSlaveSupport/clean-build:
 672         (main): Making call to Scripts/clean-webkit
 673         * Scripts/clean-webkit: Added.
 674         (main): Revert changes and delete untracked files.
 675         * Scripts/webkitpy/common/checkout/scm/scm.py:
 676         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 677         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 678         (SCMTest._shared_test_discard_untracked_files):
 679         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 680
 681 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 682
 683         Python SCM should be able to retrieve untracked files
 684         https://bugs.webkit.org/show_bug.cgi?id=143135
 685
 686         Reviewed by Ryosuke Niwa.
 687
 688         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
 689         Ignored files may be included or not in this list according boolean passed to the function.
 690
 691         * Scripts/webkitpy/common/checkout/scm/git.py:
 692         (Git.untracked_files):
 693         * Scripts/webkitpy/common/checkout/scm/scm.py:
 694         (SCM.untracked_files):
 695         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 696         (SCMTest._shared_test_untracked_files):
 697         (test_untracked_files):
 698         (GitSVNTest.test_untracked_files):
 699         * Scripts/webkitpy/common/checkout/scm/svn.py:
 700         (SVN.untracked_files):
 701
 702 2015-03-30  Alex Christensen  <achristensen@webkit.org>
 703
 704         [Content Extensions] Correctly handle regular expressions matching everything
 705         https://bugs.webkit.org/show_bug.cgi?id=143235
 706
 707         Reviewed by Benjamin Poulain.
 708
 709         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 710         (TestWebKitAPI::checkCompilerError):
 711         (TestWebKitAPI::TEST_F):
 712         Test ContentExtensionErrors.
 713
 714 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
 715
 716         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
 717         https://bugs.webkit.org/show_bug.cgi?id=143241
 718         rdar://problem/20351297
 719
 720         Reviewed by Mark Lam.
 721
 722         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
 723
 724 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 725
 726         [CMake][EFL] Remove redundant library link and include path
 727         https://bugs.webkit.org/show_bug.cgi?id=143221
 728
 729         Reviewed by Csaba Osztrogonác.
 730
 731         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
 732
 733 2015-03-30  Sam Weinig  <sam@webkit.org>
 734
 735         [Content Extensions] Flesh out the UserContentExtensionStore
 736         https://bugs.webkit.org/show_bug.cgi?id=143123
 737
 738         Reviewed by Benjamin Poulain.
 739
 740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 741         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
 742         Add tests for _WKUserContentExtensionStore.
 743
 744 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
 745
 746         Update install-dependencies Fedora packages after r181624
 747         https://bugs.webkit.org/show_bug.cgi?id=143215
 748
 749         Add json-glib, libv4l, openssl and pulseaudio development packages to
 750         the Fedora list providing we need them to build WebKit dependencies
 751         for this distribution.
 752
 753         Reviewed by Philippe Normand.
 754
 755         * gtk/install-dependencies:
 756
 757 2015-03-30  Commit Queue  <commit-queue@webkit.org>
 758
 759         Unreviewed, rolling out r182119.
 760         https://bugs.webkit.org/show_bug.cgi?id=143196
 761
 762         problem with syntax (Requested by youenn on #webkit).
 763
 764         Reverted changeset:
 765
 766         "[buildbot] clean-build script should remove untracked files
 767         and revert local changes too"
 768         https://bugs.webkit.org/show_bug.cgi?id=142400
 769         http://trac.webkit.org/changeset/182119
 770
 771 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
 772
 773         Start the features.json files
 774         https://bugs.webkit.org/show_bug.cgi?id=143207
 775
 776         Reviewed by Darin Adler.
 777
 778         I kept the style checking light. We'll have to figure
 779         what is the best format for each field.
 780
 781         * Scripts/webkitpy/style/checker.py:
 782         (CheckerDispatcher._create_checker):
 783         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 784         (JSONContributorsChecker.check):
 785         (JSONFeaturesChecker):
 786         (JSONFeaturesChecker.check):
 787
 788 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 789
 790         [buildbot] clean-build script should remove untracked files and revert local changes too
 791         https://bugs.webkit.org/show_bug.cgi?id=142400
 792
 793         Reviewed by Ryosuke Niwa.
 794
 795         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
 796
 797         * BuildSlaveSupport/clean-build:
 798         (main): Adding call to Tools/Scripts/clean-webkit.
 799         * Scripts/clean-webkit: Added.
 800         (main): Removes untracked and changed files.
 801         * Scripts/webkitpy/common/checkout/scm/git.py:
 802         (Git.untracked_files): Retrieves GIT untracked files.
 803         * Scripts/webkitpy/common/checkout/scm/scm.py:
 804         (SCM.untracked_files): Retrieves SVN untracked files.
 805         (SCM):
 806         (SCM.discard_untracked_files): Deletes untracked files/folders.
 807         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 808         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
 809         (test_untracked_files):
 810         (GitSVNTest.test_untracked_files):
 811         * Scripts/webkitpy/common/checkout/scm/svn.py:
 812         (SVN.untracked_files):
 813
 814 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 815
 816         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
 817         https://bugs.webkit.org/show_bug.cgi?id=143138
 818
 819         Reviewed by Csaba Osztrogonác.
 820
 821         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
 822         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
 823
 824         * ImageDiff/CMakeLists.txt:
 825         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
 826         * WebKitTestRunner/CMakeLists.txt: ditto.
 827
 828 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
 829
 830         Support building WTF on Windows without Cygwin
 831         https://bugs.webkit.org/show_bug.cgi?id=143084
 832
 833         Reviewed by Brent Fulgham.
 834
 835         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
 836         This patch also migrates to using File::Spec->catfile() for directory separators.
 837
 838         * Scripts/update-webkit-dependency:
 839         (wanted):
 840         * Scripts/update-webkit-support-libs:
 841         (wanted):
 842         (downloadExpectedVersionNumber):
 843         (zipFileVersion):
 844         (toUnixPath): Deleted.
 845         * Scripts/webkitdirs.pm:
 846         (determineSourceDir):
 847         (windowsSourceSourceDir):
 848         (windowsLibrariesDir):
 849         (windowsOutputDir):
 850         (checkInstalledTools):
 851         (buildVisualStudioProject):
 852
 853 2015-03-27  Alex Christensen  <achristensen@webkit.org>
 854
 855         Fix WinCairo bot.
 856         https://bugs.webkit.org/show_bug.cgi?id=143086
 857
 858         Reviewed by Brent Fulgham.
 859
 860         * Scripts/webkitdirs.pm:
 861         (buildVisualStudioProject):
 862         (runSvnUpdateAndResolveChangeLogs):
 863         Use ActivePerl-friendly perl.
 864
 865 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
 866
 867         URTBF after r182059 to fix the EFL build.
 868
 869         * TestWebKitAPI/CMakeLists.txt:
 870
 871 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
 872
 873         Layout test results URL loads in WK1 but not WK2 minibrowser
 874         https://bugs.webkit.org/show_bug.cgi?id=143117
 875
 876         Reviewed by Tim Horton.
 877
 878         * MiniBrowser/mac/WK2BrowserWindowController.m:
 879         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
 880         everything.
 881         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
 882
 883 2015-03-26  Jer Noble  <jer.noble@apple.com>
 884
 885         Add --allowed-host support to run-webkit-tests
 886         https://bugs.webkit.org/show_bug.cgi?id=142938
 887
 888         Reviewed by Brent Fulgham.
 889
 890         Accept --allowed-host arguments from run-webkit-tests and pass them through to
 891         DumpRenderTree and WebKitTestRunner.
 892
 893         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
 894         are placed in the wrong location. The argument is compared with each tests's path, and if a
 895         relative path or a path with '..' was used, results are placed alongside the test. Take the
 896         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
 897
 898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 899         (parse_args):
 900         * Scripts/webkitpy/port/base.py:
 901         (Port.__init__):
 902         (Port.allowed_hosts):
 903         * Scripts/webkitpy/port/driver.py:
 904         (Driver.cmd_line):
 905
 906 2015-03-26  Jer Noble  <jer.noble@apple.com>
 907
 908         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
 909         https://bugs.webkit.org/show_bug.cgi?id=142931
 910
 911         Reviewed by Brent Fulgham.
 912
 913         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
 914         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
 915         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
 916         runtime.
 917
 918         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
 919         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
 920
 921         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
 922         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
 923         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
 924         the top loading frame from the page, as we do elsewhere in this class.
 925
 926         * DumpRenderTree/TestRunner.h:
 927         (TestRunner::allowedHosts):
 928         (TestRunner::setAllowedHosts):
 929         * DumpRenderTree/mac/DumpRenderTree.mm:
 930         (initializeGlobalsFromCommandLineOptions):
 931         (runTest):
 932         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 933         (isAllowedHost):
 934         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 935         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 936         (WTR::InjectedBundle::didReceiveMessage):
 937         (WTR::InjectedBundle::isAllowedHost):
 938         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 939         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 940         (WTR::isAllowedHost):
 941         (WTR::InjectedBundlePage::willSendRequestForFrame):
 942         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 943         * WebKitTestRunner/Options.cpp:
 944         (WTR::handleOptionAllowedHost):
 945         (WTR::OptionsHandler::OptionsHandler):
 946         * WebKitTestRunner/Options.h:
 947         * WebKitTestRunner/TestController.cpp:
 948         (WTR::TestController::initialize):
 949         (WTR::TestController::resetStateToConsistentValues):
 950         * WebKitTestRunner/TestController.h:
 951
 952 2015-03-26  Brady Eidson  <beidson@apple.com>
 953
 954         Apply ContentExtension actions after redirects.
 955         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
 956
 957         Reviewed by Alex Christensen.
 958
 959         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 960         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
 961           which is specifically interesting to a new test.
 962
 963 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 964
 965         [EFL] Disable building libseccomp on AArch64
 966         https://bugs.webkit.org/show_bug.cgi?id=143094
 967
 968         Reviewed by Gyuyoung Kim.
 969
 970         * efl/jhbuildrc:
 971
 972 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 973
 974         [jhbuild] git should use only 1 thread for cloning jhbuild
 975         https://bugs.webkit.org/show_bug.cgi?id=143095
 976
 977         Reviewed by Gyuyoung Kim.
 978
 979         * jhbuild/jhbuild-wrapper:
 980         (clone_jhbuild):
 981
 982 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
 983
 984         Update prepare-ChangeLog to work with ES6 Class syntax
 985         https://bugs.webkit.org/show_bug.cgi?id=143069
 986
 987         Reviewed by Timothy Hatcher.
 988
 989         * Scripts/prepare-ChangeLog:
 990         (get_function_line_ranges_for_javascript):
 991         Better handle ES6 Class syntax.
 992
 993         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
 994         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
 995         (BaseClass):
 996         (DerivedClass):
 997         (DerivedClass.staticMethod):
 998         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
 999         (DerivedClass.prototype.method):
1000         (DerivedClass.prototype.get getter):
1001         (namespace.MyClass):
1002         (namespace.MyClass.staticMethod):
1003         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1004         (namespace.MyClass.prototype.method):
1005         (namespace.MyClass.prototype.get getter):
1006         Proof!
1007
1008 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1009
1010         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1011         https://bugs.webkit.org/show_bug.cgi?id=142993
1012
1013         Reviewed by Mark Lam.
1014
1015         Bunch of support for testing executable allocation failure.
1016
1017         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1018         (fail):
1019         * Scripts/run-javascriptcore-tests:
1020         (runJSCStressTests):
1021         * Scripts/run-jsc-stress-tests:
1022
1023 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1024
1025         Fix Windows build from r181977.
1026
1027         Unreviewed.
1028
1029         * Scripts/update-webkit-dependency:
1030
1031 2015-03-25  Sam Weinig  <sam@webkit.org>
1032
1033         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1034
1035         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1036         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1037
1038 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1039
1040         Migrate update-webkit for Windows to not require Cygwin
1041         https://bugs.webkit.org/show_bug.cgi?id=143040
1042
1043         Reviewed by Brent Fulgham.
1044
1045         * Scripts/update-webkit-dependency:
1046         (wanted):
1047         (toUnixPath): Deleted.
1048         * Scripts/webkitdirs.pm:
1049         (fontExists):
1050         (checkInstalledTools):
1051         (setupAppleWinEnv):
1052
1053 2015-03-25  Sam Weinig  <sam@webkit.org>
1054
1055         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1056         https://bugs.webkit.org/show_bug.cgi?id=143059
1057
1058         Reviewed by Alex Christensen.
1059
1060         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1061         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1062         Update for new interface of compileRuleList().
1063
1064 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1065
1066         [Content Extensions] Add multi-DFA compiling and interpreting.
1067         https://bugs.webkit.org/show_bug.cgi?id=143010
1068
1069         Reviewed by Benjamin Poulain.
1070
1071         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1072         (TestWebKitAPI::testRequest):
1073         (TestWebKitAPI::TEST_F):
1074         Add some tests for ignore-previous-rules and large rulesets.
1075
1076 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1077
1078         Mavericks WK1 still runs JSC tests
1079         https://bugs.webkit.org/show_bug.cgi?id=143035
1080
1081         Reviewed by Csaba Osztrogonác.
1082
1083         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1084         with other bots.
1085
1086         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1087         accordingly.
1088
1089 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1090
1091         Unreviewed, rolling out r181932.
1092         https://bugs.webkit.org/show_bug.cgi?id=143041
1093
1094         The test fails most of the time on bots (Requested by ap on
1095         #webkit).
1096
1097         Reverted changeset:
1098
1099         "[Content Extensions] Add multi-DFA compiling and
1100         interpreting."
1101         https://bugs.webkit.org/show_bug.cgi?id=143010
1102         http://trac.webkit.org/changeset/181932
1103
1104 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1105
1106         [Content Extensions] Add multi-DFA compiling and interpreting.
1107         https://bugs.webkit.org/show_bug.cgi?id=143010
1108
1109         Reviewed by Benjamin Poulain.
1110
1111         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1112         (TestWebKitAPI::testRequest):
1113         (TestWebKitAPI::TEST_F):
1114         Add some tests for ignore-previous-rules and large rulesets.
1115
1116 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1117
1118         Make URL filter patterns matching consistent and add a simple canonicalization step
1119         https://bugs.webkit.org/show_bug.cgi?id=142998
1120
1121         Reviewed by Alex Christensen.
1122
1123         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1124
1125 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1126
1127         [EFL] Add OpenWebRTC in jhbuild
1128         https://bugs.webkit.org/show_bug.cgi?id=142778
1129
1130         Reviewed by Gyuyoung Kim.
1131
1132         Original patch by Philippe Normand <pnormand@igalia.com>
1133
1134         * efl/install-dependencies: Dependencies for OpenWebRTC.
1135         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1136         the openwebrtc gst plugins.
1137
1138 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1139
1140         Regression(r181257): WTF_WorkQueue.Simple is flaky
1141         https://bugs.webkit.org/show_bug.cgi?id=142560
1142
1143         Remove the check that the refCount has returned to one after the
1144         individual tasks have completed. It's too nondeterministic when
1145         the reference count will be reduced.
1146
1147         Reviewed by Alexey Proskuryakov
1148
1149         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1150         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1151
1152 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1153
1154         [CMake][EFL] Put failure API test excutables into failure directory
1155         https://bugs.webkit.org/show_bug.cgi?id=142965
1156
1157         Reviewed by Csaba Osztrogonác.
1158
1159         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1160
1161         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1162         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1163
1164 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1165
1166         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1167         https://bugs.webkit.org/show_bug.cgi?id=142932
1168
1169         Reviewed by Darin Adler.
1170
1171         Add tests for the new features and fix some existing tests using the
1172         stringFromUTF8() utility recently added by Dhi.
1173
1174         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1175         (TestWebKitAPI::stringFromUTF8):
1176         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1177
1178 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1179
1180         [GTK] install-dependencies should install orc
1181         https://bugs.webkit.org/show_bug.cgi?id=142955
1182
1183         Reviewed by Martin Robinson.
1184
1185         Install orc, needed by openwebrtc
1186
1187         * gtk/install-dependencies:
1188
1189 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1190
1191         Detect when url filter pattern with groups match the empty string
1192         https://bugs.webkit.org/show_bug.cgi?id=142930
1193
1194         Reviewed by Sam Weinig.
1195
1196         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1197
1198 2015-03-22  Anders Carlsson  <andersca@apple.com>
1199
1200         _WKWebsiteDataStore should clear WebSQL databases
1201         https://bugs.webkit.org/show_bug.cgi?id=142947
1202
1203         Reviewed by Sam Weinig.
1204
1205         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1206
1207         * MiniBrowser/mac/WK2BrowserWindowController.m:
1208         (-[WK2BrowserWindowController fetchWebsiteData:]):
1209         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1210         (-[WK2BrowserWindowController clearWebsiteData:]):
1211
1212 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1213
1214         GCTimer should know keep track of nested GC phases
1215         https://bugs.webkit.org/show_bug.cgi?id=142675
1216
1217         Reviewed by Darin Adler.
1218
1219         Adds a tool to aid in parsing the GC phase timing output into a
1220         tree-like structure based on the parent-child relationships
1221         of nested GC phases.
1222
1223         * Scripts/parse-gc-phase-timings: Added.
1224         (Timing):
1225         (Timing.__init__):
1226         (Timing.__unicode__):
1227         (Timing.__str__):
1228         (Timing.__repr__):
1229         (parse_input):
1230         (print_timing_node):
1231         (print_timing_tree):
1232         (link_parents):
1233         (main):
1234
1235 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1236
1237         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1238
1239         * Scripts/webkitpy/common/config/ews.json:
1240
1241 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1242
1243         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1244         https://bugs.webkit.org/show_bug.cgi?id=142867
1245
1246         Rubber-stamped by Csaba Osztrogon.
1247
1248         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1249         a fixed revision for the openwebrtc-gst-plugins.
1250
1251 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1252
1253         Unreviewed build fix. Don't try to report stats for all benchmarks.
1254         Just report the geometric mean of preferred means.
1255
1256         * Scripts/run-jsc-benchmarks:
1257
1258 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1259
1260         run-jsc-benchmarks should only report preferred mean
1261         https://bugs.webkit.org/show_bug.cgi?id=142874
1262
1263         Reviewed by Geoffrey Garen.
1264
1265         Just collect statistics for the preferred mean.
1266
1267         * Scripts/run-jsc-benchmarks:
1268
1269 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1270
1271         [Content Extensions] Test regular expression parse failures.
1272         https://bugs.webkit.org/show_bug.cgi?id=142872
1273
1274         Reviewed by Benjamin Poulain.
1275
1276         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1277         (TestWebKitAPI::testPatternStatus):
1278         (TestWebKitAPI::TEST_F):
1279         Added tests for each parsing status.
1280
1281 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1282
1283         Fix API tests after r181754.
1284
1285         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1286         (TestWebKitAPI::testRequest):
1287
1288 2015-03-19  Brady Eidson  <beidson@apple.com>
1289
1290         Part of content extensions should apply css selectors
1291         https://bugs.webkit.org/show_bug.cgi?id=142604
1292
1293         Reviewed by Alex Christensen.
1294
1295         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1296         (WebCore::ContentExtensions::operator<<):
1297
1298 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1299
1300         [Win] Activate tests on EWS
1301         https://bugs.webkit.org/show_bug.cgi?id=142850
1302
1303         Reviewed by Alexey Proskuryakov.
1304
1305         * Scripts/webkitpy/common/config/ews.json: Add me as
1306         the EWS bot watcher, and activate tests.
1307
1308 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1309
1310         [GTK] Fix inspector userinterface related incremental build issue
1311         https://bugs.webkit.org/show_bug.cgi?id=142849
1312
1313         Reviewed by Carlos Garcia Campos.
1314
1315         * Scripts/webkitdirs.pm:
1316         (shouldRemoveCMakeCache):
1317
1318 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1319
1320         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1321         https://bugs.webkit.org/show_bug.cgi?id=142799
1322
1323         Reviewed by Brady Eidson.
1324
1325         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1326         (TestWebKitAPI::testPattern):
1327         (TestWebKitAPI::TEST_F):
1328         Start testing regex failures.
1329
1330 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1331
1332         Fix StringView typos after r181525 and r181558
1333         https://bugs.webkit.org/show_bug.cgi?id=142772
1334
1335         Reviewed by Darin Adler.
1336
1337         Add some tests in [1] to cover the StringView::startsWith,
1338         StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1339         StringView::endsWithIgnoringASCIICase implementations.
1340
1341         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1342         (TestWebKitAPI::TEST):
1343
1344 2015-03-18  Dana Burkart  <dburkart@apple.com>
1345
1346         Remove extraneous import to fix the build.
1347
1348         Unreviewed.
1349
1350         * Scripts/webkitpy/port/driver.py:
1351
1352 2015-03-18  Dana Burkart  <dburkart@apple.com>
1353
1354         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1355         https://bugs.webkit.org/show_bug.cgi?id=142547
1356
1357         Reviewed by Alexey Proskuryakov.
1358
1359         * Scripts/webkitpy/port/driver.py:
1360         (Driver._setup_environ_for_driver):
1361
1362 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1363
1364         Tweak how AppleSystemFontOSSubversion default is added
1365         https://bugs.webkit.org/show_bug.cgi?id=142835
1366
1367         Reviewed by Dan Bernstein.
1368
1369         * DumpRenderTree/mac/DumpRenderTree.mm:
1370         (setDefaultsToConsistentValuesForTesting):
1371
1372 2015-03-18  Dan Bernstein  <mitz@apple.com>
1373
1374         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1375         https://bugs.webkit.org/show_bug.cgi?id=142815
1376
1377         Reviewed by Darin Adler.
1378
1379         * Scripts/prepare-ChangeLog:
1380         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1381         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1382         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1383         warning only if a line ends without a backslash before the matching quotation mark was found.
1384
1385 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1386
1387         Remove unused "preprocessor" parameter to sub-CodeGenerators
1388         https://bugs.webkit.org/show_bug.cgi?id=142793
1389
1390         Reviewed by Darin Adler.
1391
1392         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1393         (new):
1394
1395 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1396
1397         [EFL] Bump gstreamer version to 1.4.4
1398         https://bugs.webkit.org/show_bug.cgi?id=142782
1399
1400         Reviewed by Philippe Normand.
1401
1402         * efl/jhbuild.modules:
1403         * efl/patches/gst-libav.patch:
1404         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1405         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1406
1407 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1408
1409         Fix the iOS build.
1410
1411         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1412         (WTR::InjectedBundle::platformInitialize):
1413
1414 2015-03-17  Dean Jackson  <dino@apple.com>
1415
1416         check-webkit-style should allow "bool a : 1"
1417         https://bugs.webkit.org/show_bug.cgi?id=142794
1418
1419         Reviewed by Brent Fulgham.
1420
1421         We should allow member bitfields of the form:
1422
1423         bool m_var : 1;
1424
1425         It seems that Visual Studio 8 was the last compiler that
1426         wasn't happy about not using unsigned here. We already have
1427         about 500 cases (in WebCore) where people were ignoring this rule.
1428
1429         * Scripts/webkitpy/style/checkers/cpp.py:
1430         (check_language): Allow "bool".
1431         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1432         (CppStyleTest.test_enum_bitfields):
1433         (CppStyleTest.test_plain_integral_bitfields):
1434
1435 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1436
1437         Compile character ranges targeting the same state as range check in the bytecode
1438         https://bugs.webkit.org/show_bug.cgi?id=142759
1439
1440         Reviewed by Alex Christensen.
1441
1442         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1443         (TestWebKitAPI::TEST_F):
1444
1445 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1446
1447         W3C test parser and converter should use test importer host
1448         https://bugs.webkit.org/show_bug.cgi?id=142729
1449
1450         Reviewed by Bem Jones-Bey.
1451
1452         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1453         This enables adding more TestImporter unit testing.
1454         This patch also ensures that the git object instantiated by TestDownloader is using the
1455         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1456
1457         * Scripts/webkitpy/common/system/filesystem_mock.py:
1458         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1459         * Scripts/webkitpy/w3c/test_downloader.py:
1460         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1461         (TestDownloader.checkout_test_repository): Making use of the new git function.
1462         * Scripts/webkitpy/w3c/test_importer.py:
1463         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1464         (TestImporter.import_tests): Adding host as parameter to the converter.
1465         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1466         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1467         (TestImporterTest):
1468         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1469         * Scripts/webkitpy/w3c/test_parser.py:
1470         (TestParser.__init__): Adding host as parameter constructor.
1471
1472 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1473
1474         [GTK] WebKitDOM objects leaking
1475         https://bugs.webkit.org/show_bug.cgi?id=118788
1476
1477         Reviewed by Darin Adler and Sergio Villar Senin.
1478
1479         Update DOMObjectCache unit test to check that DOM objects are also
1480         released when new contents are loaded in the web view, and the old
1481         document is detached from the frame.
1482
1483         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1484         (testWebKitDOMObjectCache):
1485         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1486         (runTest):
1487
1488 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1489
1490         W3C test importer default import folder should be LayoutTests/imported/w3c
1491         https://bugs.webkit.org/show_bug.cgi?id=142728
1492
1493         Reviewed by Bem Jones-Bey.
1494
1495         * Scripts/webkitpy/w3c/test_importer.py:
1496         (parse_args): Updating the default destination option value to 'imported/w3c'.
1497
1498 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1499
1500         [GTK] basic OpenWebRTC build support
1501         https://bugs.webkit.org/show_bug.cgi?id=142393
1502
1503         Reviewed by Carlos Garcia Campos.
1504
1505         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1506         is not the upstream OpenWebRTC repository. This temporary fork
1507         contains a few patches needed by WebKit for audio/video rendering.
1508
1509 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1510
1511         [CMake][EFL] Build test tools only for developer mode
1512         https://bugs.webkit.org/show_bug.cgi?id=142761
1513
1514         Reviewed by Csaba Osztrogonác.
1515
1516         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1517
1518         * CMakeLists.txt:
1519
1520 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1521
1522         Remove never used "useLayerOnTop" bindings generator argument
1523         https://bugs.webkit.org/show_bug.cgi?id=142773
1524
1525         Reviewed by Darin Adler.
1526
1527         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1528         (new):
1529
1530 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1531
1532         Enable ES6 classes by default
1533         https://bugs.webkit.org/show_bug.cgi?id=142774
1534
1535         Reviewed by Gavin Barraclough.
1536
1537         * Scripts/webkitperl/FeatureList.pm:
1538
1539 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1540
1541         Fix webkitpy tests after r181585.
1542
1543         Looks like "me" cannot be anyone's email, it's a special case.
1544
1545         * Scripts/webkitpy/common/config/contributors.json:
1546
1547 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1548
1549         Add tolerance to WebAudio tests
1550         https://bugs.webkit.org/show_bug.cgi?id=142676
1551
1552         Reviewed by Tim Horton.
1553
1554         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1555
1556         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1557         (TestResultWriter.create_audio_diff_and_write_result):
1558         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1559         (FailureAudio.write_failure):
1560         * Scripts/webkitpy/port/base.py:
1561         (Port.do_audio_results_differ):
1562         Diff audio failures.
1563
1564         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1565         tests to use real parseable WAV data, and got rid of base64, which there didn't
1566         seem to have been any reason for.
1567
1568 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1569
1570         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1571         https://bugs.webkit.org/show_bug.cgi?id=142720
1572
1573         Reviewed by Myles C. Maxfield.
1574
1575         Activate system copies of Microsoft fonts for the current process, thus overriding
1576         any other ones that could be preferred by the system otherwise.
1577
1578         * DumpRenderTree/mac/DumpRenderTree.mm:
1579         (activateSystemCoreWebFonts):
1580         (adjustFonts):
1581         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1582         (WTR::activateSystemCoreWebFonts):
1583         (WTR::activateFonts):
1584
1585 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1586
1587         Created Streams API watchlist
1588         https://bugs.webkit.org/show_bug.cgi?id=142684
1589
1590         Reviewed by Benjamin Poulain.
1591
1592         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1593         watchlist and added Benjamin, Youenn and me to it.
1594
1595 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1596
1597         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1598         https://bugs.webkit.org/show_bug.cgi?id=142715
1599
1600         Reviewed by Brent Fulgham.
1601
1602         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1603         (TestWebKitAPI::TEST):
1604
1605 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1606
1607         Change the exact attribute matching to be ASCII case-insensitive
1608         https://bugs.webkit.org/show_bug.cgi?id=142609
1609
1610         Reviewed by Darin Adler.
1611
1612         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1613         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1614
1615 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1616
1617         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1618         https://bugs.webkit.org/show_bug.cgi?id=134764
1619
1620         Reviewed by Ryosuke Niwa.
1621
1622         TestDownloader is introduced to download W3C tests from the official
1623         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1624         and https://github.com/w3c/csswg-test.git).
1625         TestDownloader clones the repositories and checkouts revisions of the tests
1626         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1627
1628         Similarly to https://codereview.chromium.org/148173016,
1629         TestDownloader copies part of the files based on the rules
1630         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1631
1632         TestDownloader is used by TestImporter when no source directory is provided.
1633
1634         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1635         (TestDownloader):
1636         (TestDownloader.default_options):
1637         (TestDownloader.load_test_repositories):
1638         (TestDownloader.__init__):
1639         (TestDownloader.checkout_test_repository):
1640         (TestDownloader._init_paths_from_expectations):
1641         (TestDownloader._add_test_suite_paths):
1642         (TestDownloader._empty_directory):
1643         (TestDownloader.copy_tests):
1644         (TestDownloader.download_tests):
1645         * Scripts/webkitpy/w3c/test_importer.py:
1646         (main):
1647         (parse_args):
1648         (TestImporter.__init__):
1649         (TestImporter.do_import):
1650         (TestImporter.test_downloader):
1651         (TestImporter.find_importable_tests.should_keep_subdir):
1652         (TestImporter.should_convert_test_harness_links):
1653         (TestImporter.import_tests):
1654         (TestImporter.write_import_log):
1655
1656 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1657
1658         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1659         https://bugs.webkit.org/show_bug.cgi?id=142630
1660
1661         Reviewed by Tim Horton.
1662
1663         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1664         Removed an ifdef that disabled the fix on Mavericks.
1665
1666 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1667
1668         Remove isWK2 cruft from webkitdirs.pm after r170426
1669         https://bugs.webkit.org/show_bug.cgi?id=142618
1670
1671         Reviewed by Daniel Bates.
1672
1673         * Scripts/webkitdirs.pm:
1674         (isWK2): Deleted.
1675
1676 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1677
1678         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1679         https://bugs.webkit.org/show_bug.cgi?id=138687
1680
1681         Reviewed by Carlos Garcia Campos.
1682
1683         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1684         affect other processes.
1685
1686         The implementation is imperfect, because the change happens asynchronously, but I
1687         don't expect it to be a problem in practice.
1688
1689         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1690         (WTR::InjectedBundle::beginTesting):
1691         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1692         (WTR::TestRunner::setAlwaysAcceptCookies):
1693         * WebKitTestRunner/TestInvocation.cpp:
1694         (WTR::TestInvocation::invoke):
1695         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1696
1697 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1698
1699         [EFL] Enable building EFL 1.13 with NEON support
1700         https://bugs.webkit.org/show_bug.cgi?id=142619
1701
1702         Reviewed by Gyuyoung Kim.
1703
1704         * efl/jhbuild.modules:
1705
1706 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1707
1708         [Content Extensions] Add resource type and load type triggers.
1709         https://bugs.webkit.org/show_bug.cgi?id=142422
1710
1711         Reviewed by Benjamin Poulain.
1712
1713         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1714         (TestWebKitAPI::testRequest):
1715         (TestWebKitAPI::mainDocumentRequest):
1716         (TestWebKitAPI::TEST_F):
1717         (TestWebKitAPI::testURL): Deleted.
1718
1719 2015-03-10  Sam Weinig  <sam@webkit.org>
1720
1721         Allow adding a button in input elements for auto fill related functionality
1722         <rdar://problem/19782066>
1723         https://bugs.webkit.org/show_bug.cgi?id=142564
1724
1725         Reviewed by Anders Carlsson.
1726
1727         * WebKitTestRunner/TestController.cpp:
1728         (WTR::TestController::createOtherPage):
1729         (WTR::TestController::createWebViewWithOptions):
1730         Update for new callback.
1731
1732 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1733
1734         Add basic support for BOL and EOL assertions to the URL Filter parser
1735         https://bugs.webkit.org/show_bug.cgi?id=142568
1736
1737         Reviewed by Alex Christensen.
1738
1739         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1740         (TestWebKitAPI::TEST_F):
1741
1742 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1743
1744         [GTK] Add support for handling TLS errors to MiniBrowser
1745         https://bugs.webkit.org/show_bug.cgi?id=142576
1746
1747         Reviewed by Sergio Villar Senin.
1748
1749         It's useful for testing TLS errors handling itself, but also to
1750         allow ignoring TLS errors when testing.
1751
1752         * MiniBrowser/gtk/BrowserWindow.c:
1753         (webViewLoadFailedWithTLSerrors):
1754         (browserWindowConstructed):
1755
1756 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1757
1758         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1759         https://bugs.webkit.org/show_bug.cgi?id=142569
1760
1761         Reviewed by David Hyatt.
1762
1763         Test Optional::valueOrCompute().
1764
1765         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1766         (TestWebKitAPI::TEST):
1767
1768 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1771         https://bugs.webkit.org/show_bug.cgi?id=126688
1772
1773         Reviewed by Gustavo Noronha Silva.
1774
1775         * CMakeLists.txt: Build testing tools only for developer builds,
1776         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1777         * MiniBrowser/gtk/CMakeLists.txt: Only add
1778         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1779         and add a rule to install the MiniBrowser.
1780         * MiniBrowser/gtk/main.c:
1781         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1782         builds.
1783
1784 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1785
1786         Add some DateMath tests to TestWebKitAPI
1787         https://bugs.webkit.org/show_bug.cgi?id=142565
1788
1789         Reviewed by Alexey Proskuryakov.
1790
1791         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1792         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1793         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1795         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1796
1797 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1798
1799         Regression(r181257): WTF_WorkQueue.Simple is flaky
1800         https://bugs.webkit.org/show_bug.cgi?id=142560
1801
1802         Unreviewed attempt to improve test stability.
1803
1804         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1805         the WorkQueue a little later to redue flakiness.
1806
1807 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1808
1809         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1810         https://bugs.webkit.org/show_bug.cgi?id=142555
1811
1812         Reviewed by Simon Fraser.
1813
1814         * DumpRenderTree/mac/DumpRenderTree.mm:
1815         (setDefaultsToConsistentValuesForTesting):
1816         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1817         (WTR::InjectedBundle::platformInitialize):
1818
1819 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1820
1821         Use unsigned for HashSet size.
1822         https://bugs.webkit.org/show_bug.cgi?id=142518
1823
1824         Reviewed by Benjamin Poulain.
1825
1826         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1827         (TestWebKitAPI::TEST):
1828         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1829         (TestWebKitAPI::testInitialCapacity):
1830         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1831         (TestWebKitAPI::TEST):
1832
1833 2015-03-10  Daniel Bates  <dabates@apple.com>
1834
1835         [iOS] Add WebKitSystemInterface for iOS 8.2
1836         https://bugs.webkit.org/show_bug.cgi?id=142505
1837
1838         Rubber-stamped by Anders Carlsson.
1839
1840         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1841         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1842         copy-webkitlibraries-to-product-directory in r181286.
1843
1844         * Scripts/copy-webkitlibraries-to-product-directory:
1845
1846 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1847
1848         Extend URL filter's Term definition to support groups/subpatterns
1849         https://bugs.webkit.org/show_bug.cgi?id=142519
1850
1851         Reviewed by Alex Christensen.
1852
1853         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1854         (TestWebKitAPI::testURL):
1855
1856 2015-03-06  Jer Noble  <jer.noble@apple.com>
1857
1858         Add an option to run-webkit-tests to override the LayoutTests/ directory
1859         https://bugs.webkit.org/show_bug.cgi?id=142418
1860
1861         Reviewed by David Kilzer.
1862
1863         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1864         directory. The base port will parse the options during initialization and store the override
1865         location if present. layout_tests_dir() will return this overridden location if set.
1866
1867         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1868         (parse_args):
1869         * Scripts/webkitpy/port/base.py:
1870         (Port.__init__):
1871         (Port.layout_tests_dir):
1872
1873 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1874
1875         [CMake] Enable WorkQueue tests for CMake ports
1876         https://bugs.webkit.org/show_bug.cgi?id=142473
1877
1878         Reviewed by Darin Adler.
1879
1880         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1881         the list of source files.
1882         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1883         to the list of include directories for EFL.
1884
1885 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1886
1887         Attempt to fix timeouts on iOS Simulator layout tests
1888
1889         * Scripts/webkitpy/port/ios.py:
1890         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1891         Simulator end after the first 50 tests time out.  Some analysis
1892         this past weekend shows that the 'Booted' status in the output
1893         of `xcrun simctl list` is not sufficient (and watching the test
1894         run shows that SpringBoard hasn't fully started to the point
1895         where it's displaying icons on the home screen).  The workaround
1896         until we have a better fix is to add an arbitrary timeout to let
1897         SpringBoard finish launching.  In practice, 15 seconds is
1898         probably enough, but 30 seconds should nearly always work.
1899
1900 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1901
1902         Unreviewed. Add myself as a committer.
1903
1904         * Scripts/webkitpy/common/config/contributors.json:
1905
1906 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1907
1908         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1909
1910         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1911         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1912         an expectation that will fail if we hit the race condition.
1913         This test is inherently racy and will deadlock if the first job
1914         for queue2 takes the mutex lock before the second job for
1915         queue1.
1916
1917 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1918
1919         [Win] WTF::WorkQueue does not balance ref/deref properly
1920         https://bugs.webkit.org/show_bug.cgi?id=142471
1921
1922         Reviewed by Antti Koivisto.
1923
1924         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1925         (TestWebKitAPI::TEST): Check that the refcount is correct.
1926
1927 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1928
1929         Do not show passing test result on output of EFL layout test
1930         https://bugs.webkit.org/show_bug.cgi?id=142380
1931
1932         Reviewed by Darin Adler.
1933
1934         To show passing tests has caused inconvenience when we detect problem tests
1935         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1936         in order not to show passing tests in the output of EFL layout test.
1937
1938         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1939         (RunWebKitTests.start):
1940
1941 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1942
1943         Unreviewed build fix.
1944
1945         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1946         (TestWebKitAPI::TEST): Remove two unused variables.
1947
1948 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1949
1950         Add some WorkQueue tests to TestWebKitAPI
1951         https://bugs.webkit.org/show_bug.cgi?id=142447
1952
1953         Reviewed by Sam Weinig.
1954
1955         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1956         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1958         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1959         (TestWebKitAPI::simpleTest):
1960         (TestWebKitAPI::longTest):
1961         (TestWebKitAPI::thirdTest):
1962         (TestWebKitAPI::finishedTests):
1963         (TestWebKitAPI::TEST):
1964         (TestWebKitAPI::longTest2):
1965
1966 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1967
1968         Remove willDestroyFrame in WKBundlePageLoaderClient
1969         https://bugs.webkit.org/show_bug.cgi?id=142389
1970
1971         Reviewed by Anders Carlsson.
1972
1973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1974         (WTR::InjectedBundlePage::InjectedBundlePage):
1975
1976 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1977
1978         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1979         https://bugs.webkit.org/show_bug.cgi?id=142433
1980
1981         Reviewed by Darin Adler.
1982
1983         Include more TestWebKitAPI tests when building for Windows. Also
1984         fix a build error in MetaAllocator.cpp caused by one of the
1985         Microsoft headers #defining 'small'.
1986
1987         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1988         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1989         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1990
1991 2015-03-06  Sam Weinig  <sam@webkit.org>
1992
1993         [Content Extensions] Move compiling of content extensions to the UIProcess
1994         https://bugs.webkit.org/show_bug.cgi?id=142402
1995
1996         Reviewed by Benjamin Poulain.
1997
1998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1999         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2000         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2001         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2002         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2003         (TestWebKitAPI::TEST_F):
2004         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2005         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2006         is now abstract).
2007
2008 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2009
2010         [Win] Correct Windows build.
2011
2012         Rubberstamped by Michael Saboff
2013
2014         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2015         in the GOTO labels.
2016
2017 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2020         https://bugs.webkit.org/show_bug.cgi?id=142385
2021
2022         Reviewed by Sergio Villar Senin.
2023
2024         Use stack allocated GMainLoopSources to make sure they are
2025         cancelled automatically if the test finishes before they have
2026         been processed.
2027
2028         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2029         (testWebViewSyncRequestOnMaxConns):
2030
2031 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2032
2033         Remove Mountain Lion libraries since ML isn't supported
2034         https://bugs.webkit.org/show_bug.cgi?id=142332
2035
2036         Reviewed by Darin Adler.
2037
2038         * Scripts/copy-webkitlibraries-to-product-directory:
2039
2040 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2041
2042         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2043         https://bugs.webkit.org/show_bug.cgi?id=142083
2044
2045         Reviewed by Simon Fraser.
2046
2047         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2048
2049         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2050         (WebPlatformTestServer._copy_webkit_test_files):
2051
2052 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2053
2054         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2055         https://bugs.webkit.org/show_bug.cgi?id=141946
2056
2057         Reviewed by Ryosuke Niwa.
2058
2059         Check in ircbot.py and irclib.py to avoid network problems in the future.
2060
2061         * Scripts/webkitpy/common/net/irc/ircbot.py:
2062         * Scripts/webkitpy/thirdparty/__init__.py:
2063         (AutoinstallImportHook.find_module):
2064         (AutoinstallImportHook._install_irc): Deleted.
2065         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2066         (ThirdpartyTest.test_imports):
2067         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2068         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2069         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2070
2071 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2072
2073         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2074
2075         See also fix to config.json in r181097.
2076
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2078         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2079         bots.
2080
2081 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2082
2083         run-jsc-stress-tests should determine the architecture from ELF binaries
2084         https://bugs.webkit.org/show_bug.cgi?id=142335
2085
2086         Reviewed by Darin Adler.
2087
2088         * Scripts/run-jsc-stress-tests:
2089
2090 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2091
2092         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2093         <http://webkit.org/b/142226>
2094
2095         Reviewed by Darin Adler.
2096
2097         * Scripts/webkitpy/port/ios.py:
2098         (IOSSimulatorPort.default_baseline_search_path): Switch the
2099         TestExpectations order of ios-simulator-wk2 from this:
2100           ios-simulator-wk2, wk2, ios-simulator
2101         To this:
2102           ios-simulator-wk2, ios-simualtor, wk2
2103
2104 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2105
2106         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2107         https://bugs.webkit.org/show_bug.cgi?id=142370
2108
2109         Reviewed by Dean Jackson.
2110
2111         * Scripts/webkitdirs.pm:
2112         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2113         logs, one for warnings, the other for errors.
2114         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2115         into the standard BuildOutput.htm document.
2116
2117 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2118
2119         Dashboard has trouble parsing iOS test output
2120         <http://webkit.org/b/142364>
2121
2122         Reviewed by Alex Christensen.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2125         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2126         Add fallback path to build a regex using 'matchString' so that
2127         it matches anywhere in the line.  In practice, 'matchString' is
2128         a prefix for the label following the number.
2129
2130 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2131
2132         Fix linker warnings in TestWebKitAPI.
2133         https://bugs.webkit.org/show_bug.cgi?id=141912
2134
2135         Reviewed by David Kilzer.
2136
2137         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2138         Do not export TearDownTestCase or SetUpTestCase symbols.
2139
2140 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2141
2142         [Win] Unreviewed EWS fix.
2143
2144         * Scripts/webkitdirs.pm:
2145         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2146         the EWS output more usable.
2147
2148 2015-03-05  Chris Dumez  <cdumez@apple.com>
2149
2150         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2151         https://bugs.webkit.org/show_bug.cgi?id=142350
2152
2153         Reviewed by Michael Saboff and Benjamin Poulain.
2154
2155         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2156         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2157
2158         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2159         (TestWebKitAPI::TEST):
2160
2161 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2162
2163         [Win] Ensure build target directory exists when launching MSBuild
2164         https://bugs.webkit.org/show_bug.cgi?id=142360
2165
2166         Reviewed by Dean Jackson.
2167
2168         Create the build output directory (if it doesn't exist) before
2169         launching MSBuild so that it can immediately begin writing logs.
2170
2171         * Scripts/webkitdirs.pm:
2172         (buildVisualStudioProject):
2173
2174 2015-03-05  Chris Dumez  <cdumez@apple.com>
2175
2176         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2177         https://bugs.webkit.org/show_bug.cgi?id=142325
2178
2179         Reviewed by Csaba Osztrogonác.
2180
2181         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2182         As a result, "--webkit-test-runner / -2" parameters are replaced by
2183         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2184         than WebKitTestRunner.
2185
2186         * BuildSlaveSupport/build.webkit.org-config/config.json:
2187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2188         (RunWebKit1Tests):
2189         (RunWebKit1Tests.start):
2190         (RunWebKit1LeakTests):
2191         (RunWebKit1LeakTests.start):
2192         (RunAndUploadPerfTestsWebKit1):
2193         (RunAndUploadPerfTestsWebKit1.start):
2194         (TestFactory):
2195         (TestWebKit1LeaksFactory):
2196         (TestWebKit1LeaksFactory.__init__):
2197         (TestWebKit1Factory):
2198         (TestWebKit1AllButJSCFactory):
2199         (TestAllButJSCFactory):
2200         (BuildAndPerfTestWebKit1Factory):
2201         (BuildAndPerfTestWebKit1Factory.__init__):
2202         (BuildAndPerfTestFactory):
2203         (BuildAndPerfTestFactory.__init__):
2204         (DownloadAndPerfTestWebKit1Factory):
2205         (DownloadAndPerfTestWebKit1Factory.__init__):
2206         (DownloadAndPerfTestFactory):
2207         (DownloadAndPerfTestFactory.__init__):
2208         (RunWebKitLeakTests): Deleted.
2209         (RunWebKitLeakTests.start): Deleted.
2210         (RunWebKit2Tests): Deleted.
2211         (RunWebKit2Tests.start): Deleted.
2212         (RunAndUploadPerfTestsWebKit2): Deleted.
2213         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2214         (TestLeaksFactory): Deleted.
2215         (TestLeaksFactory.__init__): Deleted.
2216         (TestWebKit2Factory): Deleted.
2217         (TestWebKit2AndJSCFactory): Deleted.
2218         (BuildAndPerfTestWebKit2Factory): Deleted.
2219         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2220         (DownloadAndPerfTestWebKit2Factory): Deleted.
2221         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2222         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2223         (parse_args):
2224         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2225         (PerfTestsRunner._parse_args):
2226         * Scripts/webkitpy/port/port_testcase.py:
2227         (PortTestCase.test_build_driver):
2228
2229 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2230
2231         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2232         https://bugs.webkit.org/show_bug.cgi?id=140845
2233
2234         Reviewed by David Kilzer.
2235
2236         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2237         and generate suitable build commands to drive a full build from our
2238         existing solution files.
2239
2240         * Scripts/webkitdirs.pm:
2241         (msBuildInstallDir): Added.
2242         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2243         line arguments to drive the build.
2244         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2245         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2246         to specify build architecture.
2247         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2248         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2249         bother looking for CoreUI or SafariTheme build logs.
2250
2251 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2252
2253         [buildbot] mastercfg_unittest.py should be runnable easily
2254         https://bugs.webkit.org/show_bug.cgi?id=142219
2255
2256         Reviewed by Chris Dumez.
2257
2258         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2259         the last Twisted version works together with this buildbot version.
2260
2261         * Scripts/webkitpy/common/system/autoinstall.py:
2262         (AutoInstaller): Added prepend_to_search_path argument to be able
2263         to prefer autoinstalled package to system package.
2264         (AutoInstaller.__init__):
2265         (AutoInstaller._set_up_target_dir):
2266         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2267         (AutoInstaller._prepare_package):
2268         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2269         * Scripts/webkitpy/thirdparty/__init__.py:
2270         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2271
2272 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2273
2274         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2275         https://bugs.webkit.org/show_bug.cgi?id=131162
2276
2277         Reviewed by Gyuyoung Kim.
2278
2279         * MiniBrowser/efl/main.c:
2280         (on_download_request):
2281         (on_download_finished):
2282         (on_download_failed):
2283         (window_create):
2284         Adapt download callbacks to new callback mechanism
2285
2286 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2287
2288         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2289
2290         In r180927 we updated the libsoup version used by the jhbuild. In
2291         this new version the sniffer uses image/x-icon instead of
2292         image/vnd.microsoft.icon for blank.ico resource.
2293
2294         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2295         (testWebResourceMimeType):
2296
2297 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2298
2299         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2300         https://bugs.webkit.org/show_bug.cgi?id=142244
2301
2302         Reviewed by Sergio Villar Senin.
2303
2304         Check that the SSL server doesn't process any request in case of
2305         TLS errors when the policy is set to FAIL.
2306
2307         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2308         (testTLSErrorsPolicy):
2309         (testTLSErrorsRedirect):
2310         (testTLSErrorsHTTPAuth):
2311         (testLoadFailedWithTLSErrors):
2312         (testSubresourceLoadFailedWithTLSErrors):
2313         (httpsServerCallback):
2314
2315 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2316
2317         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2318         https://bugs.webkit.org/show_bug.cgi?id=141154
2319
2320         Reviewed by Jer Noble.
2321
2322         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2323
2324         For the sake of completeness WebKitTestRunner should specify temporary
2325         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2326
2327         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2328         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2329         to get data storage paths. Only Mac port has an actual implementation of it.
2330         However, WebKitTestRunner overrides them in favour of unique temporary dir
2331         which is taken from libraryPathForTesting().
2332
2333         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2334         is not implemented for EFL and GTK ports it returns an empty string.
2335         All default data folders besides MediaKeys are overridden in TestRunner
2336         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2337         env variable.
2338
2339         GTK port does not enable encrypted keys by default so
2340         WebMediaKeyStorageManager::initialize() code path is never triggered.
2341
2342         * WebKitTestRunner/TestController.cpp:
2343         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2344         WebKit ports.
2345
2346 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2347
2348         [buildbot] Add regression test to check which builder runs which tests
2349         https://bugs.webkit.org/show_bug.cgi?id=142166
2350
2351         Reviewed by Alexey Proskuryakov.
2352
2353         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2354         (BuildStepsConstructorTest.createTest):
2355         (BuildStepsTest):
2356         (BuildStepsTest.generateTests):
2357         (BuildStepsTest.createTest):
2358         (BuildStepsTest.createTest.doTest):
2359         (BuildStepsTest.test_unnecessary_expected_results):
2360
2361 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2362
2363         Unreviewed, rolling out r181054.
2364         https://bugs.webkit.org/show_bug.cgi?id=142320
2365
2366         Broke the api tests (Requested by sundiamonde on #webkit).
2367
2368         Reverted changeset:
2369
2370         "Fix linker warnings in TestWebKitAPI."
2371         https://bugs.webkit.org/show_bug.cgi?id=141912
2372         http://trac.webkit.org/changeset/181054
2373
2374 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2375
2376         Fix linker warnings in TestWebKitAPI.
2377         https://bugs.webkit.org/show_bug.cgi?id=141912
2378
2379         Reviewed by David Kilzer.
2380
2381         * TestWebKitAPI/Configurations/Base.xcconfig:
2382         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2383
2384 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2385
2386         [Mac] Set SystemUIFontSelect in DRT and WKTR
2387         https://bugs.webkit.org/show_bug.cgi?id=142303
2388
2389         Reviewed by Myles C. Maxfield.
2390
2391         * DumpRenderTree/mac/DumpRenderTree.mm:
2392         (setDefaultsToConsistentValuesForTesting):
2393         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2394         (WTR::InjectedBundle::platformInitialize):
2395
2396 2015-03-04  Chris Dumez  <cdumez@apple.com>
2397
2398         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2399         https://bugs.webkit.org/show_bug.cgi?id=142314
2400         <rdar://problem/20046835>
2401
2402         Reviewed by Ryosuke Niwa.
2403
2404         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2405         to get WK2 code coverage.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/config.json:
2408
2409 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2410
2411         Move content extensions test to properly named directory.
2412         https://bugs.webkit.org/show_bug.cgi?id=142299
2413
2414         Reviewed by Tim Horton.
2415
2416         * WebKitTestRunner/mac/TestControllerMac.mm:
2417         (WTR::TestController::platformConfigureViewForTest):
2418
2419 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2420
2421         W3C test importer should use filesystem instead of os.walk
2422         https://bugs.webkit.org/show_bug.cgi?id=142085
2423
2424         Reviewed by Bem Jones-Bey.
2425
2426         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2427         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2428         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2429
2430         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2431         Added a unit test to check that test importer is now black-box testable using a Mock system.
2432
2433         * Scripts/webkitpy/common/system/filesystem.py:
2434         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2435         (FileSystem.dirs_under.filter_all):
2436         * Scripts/webkitpy/common/system/filesystem_mock.py:
2437         (MockFileSystem.dirs_under):
2438         (MockFileSystem.dirs_under.filter_all):
2439         (MockFileSystem.getsize):
2440         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2441         (MockFileSystemTest.test_dirs_under):
2442         (MockFileSystemTest.test_dirs_under.filter_dir):
2443         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2444         (RealFileSystemTest.test_sep):
2445         (RealFileSystemTest):
2446         (RealFileSystemTest.test_dirs_under):
2447         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2448         * Scripts/webkitpy/w3c/test_importer.py:
2449         (TestImporter.do_import):
2450         (TestImporter.find_importable_tests.should_keep_subdir):
2451         (TestImporter.find_importable_tests):
2452         (TestImporter.should_keep_subdir): Deleted.
2453         (TestImporter.should_skip_file): Deleted.
2454         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2455         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2456
2457 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2458
2459         [WebEditingTester] Add support for the find and replace bar
2460         https://bugs.webkit.org/show_bug.cgi?id=142247
2461
2462         Reviewed by Enrica Casucci.
2463
2464         While it's not hooked up yet in WKWebView, adding support for the
2465         find bar to WebEditingTester will help us implement that functionality.
2466
2467         * WebEditingTester/AppDelegate.h:
2468         * WebEditingTester/AppDelegate.m:
2469         (-[WebEditingAppDelegate performTextFinderAction:]):
2470         * WebEditingTester/MainMenu.xib:
2471         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2472
2473         * WebEditingTester/WK2WebDocumentController.m:
2474         (-[WK2WebDocumentController awakeFromNib]):
2475         (-[WK2WebDocumentController performTextFinderAction:]):
2476         (-[WK2WebDocumentController findBarView]):
2477         (-[WK2WebDocumentController setFindBarView:]):
2478         (-[WK2WebDocumentController isFindBarVisible]):
2479         (-[WK2WebDocumentController setFindBarVisible:]):
2480         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2481         (-[WK2WebDocumentController layout]):
2482         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2483         pointing at the WKWebView (currently nothing will work, but the bar will
2484         show up). Install and uninstall the bar as needed.
2485
2486         * WebEditingTester/WebDocument.xib:
2487         Don't use a full-size content view. There's no need, and it makes find
2488         bar layout harder.
2489
2490         * WebEditingTester/WebDocumentController.h:
2491         * WebEditingTester/WebDocumentController.m:
2492         (-[WebDocumentController performTextFinderAction:]):
2493
2494 2015-03-03  Sam Weinig  <sam@webkit.org>
2495
2496         [Content Extensions] Split parsing and compiling of content extensions into their own files
2497         https://bugs.webkit.org/show_bug.cgi?id=142259
2498
2499         Reviewed by Anders Carlsson.
2500
2501         Add basic unit test for the content filter compiler.
2502
2503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2504         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2505         (WebCore::ContentExtensions::operator<<):
2506         (TestWebKitAPI::ContentFilterTest::SetUp):
2507         (TestWebKitAPI::TEST_F):
2508
2509 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2510
2511         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2512         https://bugs.webkit.org/show_bug.cgi?id=142230
2513
2514         Reviewed by Csaba Osztrogonác.
2515
2516         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2517         (TestFactory):
2518         (TestFactory.getProduct): Added
2519         (TestFactory.__init__): moved downloader to getProduct
2520         (BuildAndTestFactory):
2521         (BuildAndTestFactory.getProduct): Added
2522         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2523         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2524
2525 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2526
2527         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2528         https://bugs.webkit.org/show_bug.cgi?id=142225
2529
2530         Reviewed by Carlos Garcia Campos.
2531
2532         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2533         (testWebViewWebContextLifetime):
2534         (beforeAll):
2535
2536 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2537
2538         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2539         <http://webkit.org/b/142243>
2540
2541         Reviewed by Alexey Proskuryakov.
2542
2543         * WebKitTestRunner/TestController.cpp:
2544         (WTR::TestController::webProcessName):
2545         (WTR::TestController::networkProcessName):
2546         - Return the same process name on iOS and Mac because they both
2547           use the same process name for local engineering builds.
2548
2549 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2550
2551         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2552         <http://webkit.org/b/141872>
2553
2554         Reviewed by Alex Christensen.
2555
2556         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2557         semi-colons in various places and fix whitespace.
2558         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2559         constants.
2560         (_IncludeState.__init__): Add self._visited_soft_link_section
2561         boolean state variable.
2562         (_IncludeState.visited_soft_link_section): Getter for
2563         self._visited_soft_link_section.
2564         (_IncludeState.check_next_include_order): Update state machine
2565         for soft-link headers.  Add check that soft-link headers always
2566         appear last.
2567         (_classify_include): Add check for soft-link header type.
2568         (check_include_line): Return early if there is a soft-link
2569         header error.
2570
2571         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2572         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2573         including soft-link headers.
2574         (OrderOfIncludesTest.test_classify_include): Add test for
2575         _SOFT_LINK_HEADER type.
2576
2577 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2578
2579         build.webkit.org/dashboard: Don't repeatedly handle each test type
2580         https://bugs.webkit.org/show_bug.cgi?id=142211
2581
2582         Reviewed by Tim Horton and Matt Hanson.
2583
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2585         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2586         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2587         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2588         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2589         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2590         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2591         Removed functions that build a link to test step results. The buildbot provides
2592         these links in JSON.
2593
2594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2595         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2596         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2597         We can easily add them to the map as needed.
2598         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2599         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2600         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2601         and then build a BuildbotTestResults object, which was strange.
2602         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2603
2604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2605         Corrected an unrelated assertion that was buggy, and kept firing.
2606
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2608         (BuildbotTestResults):
2609         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2610         (BuildbotTestResults.prototype._parseResults):
2611         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2612         Moved the code for parsing JSON results for a single step here.
2613
2614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2615         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2616         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2617         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2618         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2619         (BuildbotTesterQueueView.prototype.update): Deleted.
2620         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2621         Updated for the new data structures. One behavior change is that we now display individual
2622         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2623         test failures, 3 platform api test failures".
2624
2625 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2626
2627         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2628         https://bugs.webkit.org/show_bug.cgi?id=142094
2629
2630         Reviewed by Csaba Osztrogonác.
2631
2632         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2634         (TestFactory):
2635         (TestFactory.__init__): Made running of JSC tests conditional.
2636         (TestAllButJSCFactory):
2637         (TestJSCFactory): Added.
2638         (TestJSCFactory.__init__):
2639         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2640
2641 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2642
2643         `build-webkit --help` is wrong about how to build for the iOS simulator
2644         <http://webkit.org/b/142223>
2645
2646         Reviewed by Csaba Osztrogonác.
2647
2648         * Scripts/build-webkit: Fix help.
2649
2650 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2651
2652         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2653
2654         * gtk/jhbuild.modules:
2655
2656 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2657
2658         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2659         https://bugs.webkit.org/show_bug.cgi?id=141508
2660
2661         Reviewed by Sergio Villar Senin.
2662
2663         Add a unit test to check that synchronous XHRs load even if the
2664         maximum connection limits are reached.
2665
2666         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2667         (testWebViewSyncRequestOnMaxConns):
2668         (serverCallback):
2669         (beforeAll):
2670         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2671
2672 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2673
2674         Update the name of ASan build step.
2675
2676         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2677
2678 2015-03-02  Jer Noble  <jer.noble@apple.com>
2679
2680         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2681         https://bugs.webkit.org/show_bug.cgi?id=142121
2682
2683         Reviewed by Simon Fraser.
2684
2685         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2686         that the initial and final screen rects for the web content are as expected.
2687
2688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2689         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2690         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2691         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2692         (runJavaScriptAlert):
2693         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2694         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2695         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2696         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2697         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2698         (TestWebKitAPI::TEST_F):
2699
2700 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2701
2702         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2703
2704         Follow-up fix for:
2705
2706         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2707         <http://webkit.org/b/142145>
2708
2709         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2710         (-[LTRelayController _environmentVariables]): Fix think-o.
2711
2712 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2713
2714         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2715         <http://webkit.org/b/142145>
2716
2717         Reviewed by Simon Fraser.
2718
2719         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2720         (-[LTRelayController _environmentVariables]): Add.
2721         (-[LTRelayController launchApp]): Use -_environmentVariables.
2722
2723 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2724
2725         [iOS] Stop running webkit-build-directory on every layout test
2726
2727         This was originally fixed by David Farler for Bug 135409 in
2728         r172602.
2729
2730         * Scripts/webkitpy/port/ios.py:
2731         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2732         run webkit-build-directory every time it's called.
2733
2734 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2735
2736         W3C importer should use filesystem instead of shutil/host
2737         https://bugs.webkit.org/show_bug.cgi?id=142012
2738
2739         Reviewed by Bem Jones-Bey.
2740
2741         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2742
2743         * Scripts/webkitpy/w3c/test_importer.py:
2744         (main):
2745         (TestImporter.do_import):
2746         (TestImporter.find_importable_tests):
2747         (TestImporter.import_tests):
2748         (TestImporter.remove_deleted_files):
2749         (TestImporter.write_import_log):
2750
2751 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2752
2753         W3C test importer should use filesystem to read and write files
2754         https://bugs.webkit.org/show_bug.cgi?id=142084
2755
2756         Reviewed by Bem Jones-Bey.
2757
2758         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2759
2760         * Scripts/webkitpy/w3c/test_importer.py:
2761         (TestImporter.import_tests):
2762         (TestImporter.remove_deleted_files):
2763         (TestImporter.write_import_log):
2764
2765 2015-02-27  Sam Weinig  <sam@webkit.org>
2766
2767         Add WebKit2 SPI to create a DOM File object
2768         https://bugs.webkit.org/show_bug.cgi?id=142109
2769
2770         Reviewed by Tim Horton.
2771
2772         Add a test for WKBundleFileHandleRef.
2773
2774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2775         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2776         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2777         (TestWebKitAPI::didFinishLoadForFrame):
2778         (TestWebKitAPI::TEST):
2779         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2780         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2781         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2782
2783 2015-02-27  Michael Saboff  <msaboff@apple.com>
2784
2785         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2786         https://bugs.webkit.org/show_bug.cgi?id=142112
2787
2788         Reviewed by Filip Pizlo.
2789
2790         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2791         <someDir> as the library path.
2792
2793         * Scripts/run-jsc-benchmarks:
2794
2795 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2796
2797         [WinCairo] Unreviewed build fix.
2798
2799         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2800         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2801
2802 2015-02-27  Anders Carlsson  <andersca@apple.com>
2803
2804         Add infrastructure for handling website data in the network process
2805         https://bugs.webkit.org/show_bug.cgi?id=142092
2806
2807         Reviewed by Andreas Kling.
2808
2809         Add a menu item that will fetch all website data, delete the returned data records, and
2810         fetch all website data again so we can confirm that it's all empty.
2811
2812         * MiniBrowser/mac/WK2BrowserWindowController.m:
2813         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2814
2815 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2816
2817         [Win] Remove remaining SafariTheme cruft
2818         https://bugs.webkit.org/show_bug.cgi?id=142075
2819
2820         Reviewed by Anders Carlsson.
2821
2822         Remove reference to SafariTheme-switching preference.
2823
2824         * DumpRenderTree/win/DumpRenderTree.cpp:
2825         (resetWebPreferencesToConsistentValues):
2826         (prepareConsistentTestingEnvironment):
2827
2828 2015-02-26  Doug Russell  <d_russell@apple.com>
2829
2830         AX: Expose caret browsing preference to accessibility API
2831         https://bugs.webkit.org/show_bug.cgi?id=141862
2832
2833         Reviewed by Chris Fleizach.
2834
2835         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2836         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2837
2838         * DumpRenderTree/AccessibilityUIElement.cpp:
2839         (setBoolAttributeValueCallback):
2840         (selectedTextMarkerRangeCallback):
2841         (resetSelectedTextMarkerRangeCallback):
2842         (AccessibilityUIElement::setBoolAttributeValue):
2843         (AccessibilityUIElement::selectedTextMarkerRange):
2844         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2845         (AccessibilityUIElement::getJSClass):
2846         * DumpRenderTree/AccessibilityUIElement.h:
2847         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2848         (AccessibilityUIElement::setBoolAttributeValue):
2849         (AccessibilityUIElement::selectedTextMarkerRange):
2850         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2851         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2852         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2853         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2854         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2855         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2856         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2857         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2858         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2859         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2860         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2861
2862 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2863
2864         [Win] Remove WebKitExportGenerator project (and related)
2865         https://bugs.webkit.org/show_bug.cgi?id=142035
2866
2867         Reviewed by Dean Jackson.
2868
2869         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2870         build log from WebKitExportGenerator.
2871
2872 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2873
2874         [EFL] Bump EFL version to 1.13.0
2875         https://bugs.webkit.org/show_bug.cgi?id=141708
2876
2877         Reviewed by Gyuyoung Kim.
2878
2879         * efl/jhbuild.modules:
2880
2881 2015-02-26  Sam Weinig  <sam@webkit.org>
2882
2883         Check in missing WebEditingTester.xcconfig file.
2884
2885         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2886
2887 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2888
2889         [webkitpy] Remove skipped file related crufts
2890         https://bugs.webkit.org/show_bug.cgi?id=142046
2891
2892         Reviewed by Ryosuke Niwa.
2893
2894         * Scripts/webkitpy/port/base.py:
2895         (Port.skipped_layout_tests):
2896         (Port._tests_from_skipped_file_contents): Deleted.
2897         (Port): Deleted.
2898         (Port._expectations_from_skipped_files): Deleted.
2899         * Scripts/webkitpy/port/mac_unittest.py:
2900         (MacTest.test_default_timeout_ms):
2901         (MacTest): Deleted.
2902         (test_tests_from_skipped_file_contents): Deleted.
2903
2904 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2905
2906         [Win] Unreviewed WinCairo build fix after r180653.
2907
2908         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2909
2910         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2911         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2912         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2913         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2914         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2915
2916 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2917
2918         [Win] Use WEBCORE_EXPORT instead of Definition file
2919         https://bugs.webkit.org/show_bug.cgi?id=141734
2920
2921         Reviewed by Alex Christensen.
2922
2923         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2924         Use a precompiled header so we can define our export macros properly.
2925         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2926         Visual studio automatic update stuff.
2927         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2928         Set up Precompiled Header use for project..
2929         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2930         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2931         declarations for building DumpRenderTree as a client of
2932         WebCore/WebKit.
2933
2934 2015-02-25  Mark Lam  <mark.lam@apple.com>
2935
2936         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2937         <https://webkit.org/b/141672>
2938
2939         Reviewed by Alexey Proskuryakov.
2940
2941         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2942         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2943         implementation that we can tell ASan to ignore.
2944
2945         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2946         which isn't effective for working around this issue.
2947
2948         * asan/webkit-asan-ignore.txt:
2949
2950 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2951
2952         CodeBlock crashes when dumping op_push_name_scope
2953         https://bugs.webkit.org/show_bug.cgi?id=141953
2954
2955         Reviewed by Filip Pizlo.
2956
2957         * Scripts/run-jsc-stress-tests:
2958
2959 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2960
2961         W3C test importer should use argparse instead of optparse
2962         https://bugs.webkit.org/show_bug.cgi?id=142013
2963
2964         Reviewed by Bem Jones-Bey.
2965
2966         * Scripts/webkitpy/w3c/test_importer.py:
2967         (main): Updating according argparse.
2968         (parse_args): Moving from optparse to argparse.
2969
2970 2015-02-25  Brady Eidson  <beidson@apple.com>
2971
2972         Get rid of TestInvocation::pathOrURL
2973         https://bugs.webkit.org/show_bug.cgi?id=142021
2974
2975         Reviewed by Tim Horton.
2976
2977         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2978         but most code that uses it expected an absolute path.
2979
2980         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2981
2982         * WebKitTestRunner/TestController.cpp:
2983         (WTR::TestController::updateWebViewSizeForTest):
2984         (WTR::TestController::updateWindowScaleForTest):
2985         (WTR::shouldUseFixedLayout):
2986         (WTR::TestController::updateLayoutTypeForTest):
2987
2988         * WebKitTestRunner/TestInvocation.cpp:
2989         (WTR::TestInvocation::TestInvocation):
2990         (WTR::TestInvocation::urlContains):
2991         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2992         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2993         (WTR::TestInvocation::invoke):
2994         (WTR::shouldLogFrameLoadDelegates): Deleted.
2995         (WTR::shouldLogHistoryClientCallbacks): Deleted.
2996         * WebKitTestRunner/TestInvocation.h:
2997         (WTR::TestInvocation::pathOrURL): Deleted.
2998
2999         * WebKitTestRunner/ios/TestControllerIOS.mm:
3000         (WTR::shouldMakeViewportFlexible):
3001         (WTR::TestController::platformConfigureViewForTest):
3002
3003         * WebKitTestRunner/mac/TestControllerMac.mm:
3004         (WTR::shouldUseThreadedScrolling):
3005         (WTR::TestController::platformConfigureViewForTest):
3006
3007 2015-02-25  Brady Eidson  <beidson@apple.com>
3008
3009         Layout test support for user content filters
3010         https://bugs.webkit.org/show_bug.cgi?id=142018
3011
3012         Reviewed by Tim Horton.
3013
3014         * WebKitTestRunner/TestController.cpp:
3015         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
3016
3017         * WebKitTestRunner/mac/TestControllerMac.mm:
3018         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
3019           file before loading the test itself.
3020
3021 2015-02-24  Sam Weinig  <sam@webkit.org>
3022
3023         Convert WebEditingTester to use xcconfig files
3024         https://bugs.webkit.org/show_bug.cgi?id=141879
3025
3026         Reviewed by Darin Adler.
3027
3028         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
3029
3030         * WebEditingTester/Configurations: Added.
3031         * WebEditingTester/Configurations/Base.xcconfig: Added.
3032         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
3033         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3034
3035 2015-02-24  Andy Estes  <aestes@apple.com>
3036
3037         Teach MiniBrowser how to disable per-window web processes
3038         https://bugs.webkit.org/show_bug.cgi?id=141988
3039
3040         Reviewed by Darin Adler.
3041
3042         * MiniBrowser/mac/AppDelegate.m:
3043         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3044         * MiniBrowser/mac/SettingsController.h:
3045         * MiniBrowser/mac/SettingsController.m:
3046         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3047         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3048         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3049         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3050
3051 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3052
3053         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3054         https://bugs.webkit.org/show_bug.cgi?id=141889
3055
3056         Reviewed by Darin Adler.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3059
3060 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3061
3062         REGRESSION(r179429): Can't type comments in Facebook
3063         https://bugs.webkit.org/show_bug.cgi?id=141859
3064
3065         Reviewed by Brent Fulgham.
3066
3067         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3068
3069         * DumpRenderTree/mac/DumpRenderTree.mm:
3070         (resetWebPreferencesToConsistentValues):
3071         * DumpRenderTree/win/DumpRenderTree.cpp:
3072         (resetWebPreferencesToConsistentValues):
3073         * WebKitTestRunner/TestController.cpp:
3074         (WTR::TestController::resetPreferencesToConsistentValues):
3075
3076 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3077
3078         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3079         https://bugs.webkit.org/show_bug.cgi?id=141867
3080
3081         Reviewed by Anders Carlsson.
3082
3083         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3084         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3085         be shared with the new test.
3086         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3087         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3088         (testLoadAlternateHTMLForLocalPage):
3089         (beforeAll):
3090
3091 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3092
3093         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3094         <http://webkit.org/b/141900>
3095
3096         Reviewed by Myles C. Maxfield.
3097
3098         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3099         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3100         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3101         - Rename to share code with iOS.
3102         - Add USE(APPKIT) around AppKit-specific headers and code.
3103         - Fix a check-webkit-style warning.
3104         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3105         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3106         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3107         - Remove ios/ActivateFontsIOS.mm.
3108         - Fix InjectedBundle/cocoa group to represent the directory on
3109           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3110
3111 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3112
3113         Unreviewed, rolling out r180547 and r180550.
3114         https://bugs.webkit.org/show_bug.cgi?id=141957
3115
3116         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3117
3118         Reverted changesets:
3119
3120         "REGRESSION(r179429): Can't type comments in Facebook"
3121         https://bugs.webkit.org/show_bug.cgi?id=141859
3122         http://trac.webkit.org/changeset/180547
3123
3124         "Constructor returning null should construct an object instead
3125         of null"
3126         https://bugs.webkit.org/show_bug.cgi?id=141640
3127         http://trac.webkit.org/changeset/180550
3128
3129 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3130
3131         REGRESSION(r179429): Can't type comments in Facebook
3132         https://bugs.webkit.org/show_bug.cgi?id=141859
3133
3134         Reviewed by Geoffrey Garen.
3135
3136         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3137
3138         * DumpRenderTree/mac/DumpRenderTree.mm:
3139         (resetWebPreferencesToConsistentValues):
3140         * WebKitTestRunner/TestController.cpp:
3141         (WTR::TestController::resetPreferencesToConsistentValues):
3142
3143 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3144
3145         [EFL] fix eo errors
3146         https://bugs.webkit.org/show_bug.cgi?id=141909
3147
3148         Reviewed by Gyuyoung Kim.
3149
3150         Fix eo errors that occur whenever minibrowser is launched.
3151         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3152         - elm_obj_win_resize_object_add's first parameter should be elm_win
3153
3154         * MiniBrowser/efl/main.c:
3155         (window_create):
3156
3157 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3158
3159         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3160
3161         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3162         (TestWebKitAPI::TEST):
3163
3164 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3165
3166         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3167         https://bugs.webkit.org/show_bug.cgi?id=141935
3168
3169         Reviewed by Myles C. Maxfield.
3170
3171         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3172         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3173         tests for assigning from nullptr.
3174
3175 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3176
3177         WTF::WeakPtr should have a 'forget' method.
3178         https://bugs.webkit.org/show_bug.cgi?id=141923
3179
3180         Reviewed by Myles C. Maxfield.
3181
3182         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3183         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3184
3185 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3186
3187         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3188         https://bugs.webkit.org/show_bug.cgi?id=141920
3189
3190         Reviewed by Tim Horton.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3193         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3194         Do the same thing as we do for regular green bubbles.
3195
3196 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3197
3198         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3199         https://bugs.webkit.org/show_bug.cgi?id=141925
3200
3201         Reviewed by Tim Horton.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3204         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3205
3206 2015-02-23  Anders Carlsson  <andersca@apple.com>
3207
3208         Add API for fetching website data records to _WKWebsiteDataStore
3209         https://bugs.webkit.org/show_bug.cgi?id=141926
3210
3211         Reviewed by Beth Dakin.
3212
3213         * MiniBrowser/mac/MainMenu.xib:
3214         * MiniBrowser/mac/WK2BrowserWindowController.m:
3215         (-[WK2BrowserWindowController fetchWebsiteData:]):
3216         Add menu item to fetch and dump website data.
3217
3218 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3219
3220         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3221         <http://webkit.org/b/141884>
3222
3223         Reviewed by Alexey Proskuryakov.
3224
3225         * Scripts/webkitpy/port/leakdetector.py:
3226         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3227         snowleopard, lion and older leaks.  Add known leak for
3228         mavericks, but check Port.operating_system before calling
3229         Port.is_mavericks.
3230         * Scripts/webkitpy/port/mac.py:
3231         (MacPort.is_snowleopard): Delete.
3232         (MacPort.is_lion): Delete.
3233         (MacPort.is_mavericks): Add.
3234
3235 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3236
3237         build.webkit.org/dashboard should filter out commits to other branches
3238         https://bugs.webkit.org/show_bug.cgi?id=140362
3239
3240         Reviewed by Tim Horton.
3241
3242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3243         (BuildbotQueue):
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3245         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3246         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3247         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3248         (BuildbotQueueView.prototype.revisionContentForIteration):
3249         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3250         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3251         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3253         (Trac.prototype.get oldestRecordedRevisionNumber):
3254         (Trac.prototype.commitsOnBranch):
3255         (Trac.prototype._xmlTimelineURL):
3256         (Trac.prototype._convertCommitInfoElementToObject):
3257         (Trac.prototype._update):
3258         (Trac.prototype.startPeriodicUpdates):
3259         (Trac.prototype.loadMoreHistoricalData):
3260         (Trac.prototype.update): Deleted.
3261
3262 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3263
3264         Tests don't work on some bots: Failed to stop wptwk
3265         https://bugs.webkit.org/show_bug.cgi?id=141235
3266
3267         Reviewed by Ryosuke Niwa.
3268
3269         Logging of server subprocesses in launcher script.
3270         Killing of server subprocesses when stopping/before starting.
3271         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3272
3273         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3274         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3275         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3276         (WebPlatformTestServer.__init__):
3277         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3278         (WebPlatformTestServer):
3279         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3280         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3281         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3282         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3283         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3284         (TestWebPlatformTestServer):
3285         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3286
3287 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3288
3289         [WebEditingTester] Allow dropping HTML files on the app
3290         https://bugs.webkit.org/show_bug.cgi?id=141834
3291
3292         Reviewed by Simon Fraser.
3293
3294         * WebEditingTester/AppDelegate.m:
3295         (-[WebEditingAppDelegate openDocument:]):
3296         (-[WebEditingAppDelegate application:openFile:]):
3297         Implement application:openFile:, factoring file loading code out of openDocument.
3298
3299         * WebEditingTester/Info.plist:
3300         Register as an editor for HTML files.
3301
3302         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3303         Enrica is not an organization.
3304
3305 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3306
3307         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3308         https://bugs.webkit.org/show_bug.cgi?id=141833
3309
3310         Reviewed by Anders Carlsson.
3311
3312         * WebEditingTester/AppDelegate.h:
3313         * WebEditingTester/AppDelegate.m:
3314         (-[WebEditingAppDelegate newEditor:]):
3315         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3316         (-[WebEditingAppDelegate validateMenuItem:]):
3317         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3318         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3319         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3320         (-[WebEditingAppDelegate showOperations:]): Deleted.
3321         * WebEditingTester/MainMenu.xib:
3322         The WK abbreviation is unnaturally grating in menu items for some reason.
3323
3324 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3325
3326         [WebEditingTester] Add a custom protocol for loading canned content
3327         https://bugs.webkit.org/show_bug.cgi?id=141830
3328
3329         Reviewed by Enrica Casucci.
3330
3331         Add a canned:// protocol handler, which can be used to emulate behaviors
3332         in WebKit client apps (like Mail) that use custom protocol handlers,
3333         which can have important effects on editing (mostly, the URLs are only
3334         valid inside of the client application, but not when copied/dragged out).
3335
3336         For now, we only support two canned files:
3337
3338             canned://dice is a PNG of dice (stolen from LayoutTests/)
3339             canned://text is the string "canned text" served as text/html
3340
3341         In the future we could support things like very large (generated) files,
3342         progressive loading, etc. to further simulate conditions in other apps.
3343
3344         * WebEditingTester/AppDelegate.m:
3345         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3346         Register the protocol with CFNetwork, and the scheme with WebKit2.
3347
3348         * WebEditingTester/Canned Content/dice.png: Added.
3349         * WebEditingTester/CannedContent.h: Added.
3350         * WebEditingTester/CannedContent.m: Added.
3351         (-[CannedContent initWithRequest:cachedResponse:client:]):
3352         (+[CannedContent canonicalRequestForRequest:]):
3353         (+[CannedContent canInitWithRequest:]):
3354         We only want to handle canned:// URLs.
3355
3356         (-[CannedContent startLoading]):
3357         For now, immediately load the two files we know about.
3358         Otherwise, immediately fail the load.
3359
3360         (-[CannedContent stopLoading]):
3361         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3362
3363 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3364
3365         [WebEditingTester] Implement an open panel
3366         https://bugs.webkit.org/show_bug.cgi?id=141829
3367
3368         Reviewed by Simon Fraser.
3369
3370         * WebEditingTester/AppDelegate.m:
3371         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3372         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3373         (-[WebEditingAppDelegate openDocument:]):
3374         Add an open panel (with radio buttons to pick which WebKit to open with).
3375         Loads the file as an HTML string.
3376
3377 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3378
3379         [WebEditingTester] @properties, dot syntax, and remember the window position
3380         https://bugs.webkit.org/show_bug.cgi?id=141843
3381
3382         Reviewed by Tim Horton.
3383
3384         Modernize a bit with more dot syntax, use @property for the web views,
3385         and give the main window an Autosave name so it remembers the widow position.
3386
3387         * WebEditingTester/WK1WebDocumentController.m:
3388         (-[WK1WebDocumentController awakeFromNib]):
3389         (-[WK1WebDocumentController loadHTMLString:]):
3390         * WebEditingTester/WK2WebDocumentController.m:
3391         (-[WK2WebDocumentController awakeFromNib]):
3392         * WebEditingTester/WebDocument.xib:
3393
3394 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3395
3396         [WebEditingTester] Hook up key equivalents for new window action
3397         https://bugs.webkit.org/show_bug.cgi?id=141828
3398
3399         Reviewed by Enrica Casucci.
3400
3401         * WebEditingTester/AppDelegate.h:
3402         * WebEditingTester/AppDelegate.m:
3403         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3404         (-[WebEditingAppDelegate newEditor:]):
3405         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3406         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3407         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3408         (defaultConfiguration): Deleted.
3409         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3410         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3411         Remove unused application termination code.
3412         Update new-window menu item key equivalents when launching and when
3413         changing the use-WebKit2-by-default setting.
3414         Make WebDocumentController subclasses all initialized the same way,
3415         and use that to factor out alloc/init.
3416         Rename loadContent to loadHTMLString for future use.
3417
3418         * WebEditingTester/MainMenu.xib:
3419         Add default key equivalents.
3420         Cmd-N will always make the default kind of window (controlled by the pref).
3421         Cmd-Opt-N will always make the other kind.
3422         The menu items are configured as alternates so they only show up if you
3423         press alt (just like in MiniBrowser).
3424
3425         * WebEditingTester/WK1WebDocumentController.m:
3426         (-[WK1WebDocumentController loadHTMLString:]):
3427         (-[WK1WebDocumentController loadContent]): Deleted.
3428         * WebEditingTester/WK2WebDocumentController.h:
3429         * WebEditingTester/WK2WebDocumentController.m:
3430         (defaultConfiguration):
3431         (-[WK2WebDocumentController awakeFromNib]):
3432         (-[WK2WebDocumentController loadHTMLString:]):
3433         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3434         (-[WK2WebDocumentController dealloc]): Deleted.
3435         * WebEditingTester/WebDocumentController.h:
3436         * WebEditingTester/WebDocumentController.m:
3437         (-[WebDocumentController init]):
3438         (-[WebDocumentController initWithWindow:]):
3439         (+[WebDocumentController defaultEditingSource]):
3440         (-[WebDocumentController loadHTMLString:]):
3441         (-[WebDocumentController windowDidLoad]): Deleted.
3442         (-[WebDocumentController defaultEditingSource]): Deleted.
3443         (-[WebDocumentController applicationTerminating]): Deleted.
3444         (-[WebDocumentController loadContent]): Deleted.
3445
3446 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3447
3448         [WebEditingTester] ARC-ify WebEditingTester
3449         https://bugs.webkit.org/show_bug.cgi?id=141827
3450
3451         Reviewed by Sam Weinig.
3452
3453         * WebEditingTester/AppDelegate.m:
3454         (-[WebEditingAppDelegate showOperations:]):
3455         * WebEditingTester/EditingOperations.m:
3456         (editingOperations):
3457         * WebEditingTester/WK1WebDocumentController.m:
3458         (-[WK1WebDocumentController dealloc]): Deleted.
3459         * WebEditingTester/WK2WebDocumentController.m:
3460         (-[WK2WebDocumentController dealloc]): Deleted.
3461         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3462         Turn on ARC and remove a few retain/release/autorelease calls.
3463         We don't need to implement dealloc in either document controller
3464         because WebView and WKWebView's UIDelegate property does not hold a
3465         strong reference.
3466
3467 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3468
3469         [WebEditingTester] Factor out list of editing operations
3470         https://bugs.webkit.org/show_bug.cgi?id=141826
3471
3472         Reviewed by Sam Weinig.
3473
3474         * WebEditingTester/AppDelegate.m:
3475         (-[WebEditingAppDelegate showOperations:]):
3476         * WebEditingTester/EditingOperations.h: Added.
3477         * WebEditingTester/EditingOperations.m: Added.
3478         (editingOperations):
3479         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3480         Move EditingOperations array to its own file, and make it an NSArray
3481         instead of a C array. Adjust accordingly in showOperations:.
3482
3483 2015-02-20  Michael Saboff  <msaboff@apple.com>
3484
3485         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3486         https://bugs.webkit.org/show_bug.cgi?id=141676
3487
3488         Reviewed by Filip Pizlo.
3489
3490         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3491         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3492         large string expression that we want to eval.
3493
3494         * Scripts/run-jsc-stress-tests:
3495
3496 2015-02-19  Daniel Bates  <dabates@apple.com>
3497
3498         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3499         https://bugs.webkit.org/show_bug.cgi?id=141815
3500         <rdar://problem/19893933>
3501
3502         Reviewed by Simon Fraser.
3503
3504         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3505         was booted by iOS Simulator in a previous run of run-webkit-test.
3506
3507         * Scripts/webkitpy/port/ios.py:
3508         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3509         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3510         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3511
3512 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3513
3514         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3515         <http://webkit.org/b/141799>
3516
3517         Reviewed by Alex Christensen.
3518
3519         * Scripts/webkitpy/style/checkers/cpp.py:
3520         (_IncludeState.check_next_include_order): Don't emit a warning
3521         if the primary header exists and the source file name ends with
3522         "SoftLink.cpp".  Add 'filename' argument to method.
3523         (check_include_line): Pass in 'filename'.
3524
3525         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3526         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3527         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3528         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3529         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3530         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3531         - Add test filename arguments for calls to
3532           check_next_include_order().
3533         (OrderOfIncludesTest.test_primary_header): Add test for a file
3534         name ending in "SoftLink.cpp".
3535
3536 2015-02-18  Enrica Casucci  <enrica@apple.com>
3537
3538         Add new tool to test editable Webviews.
3539         https://bugs.webkit.org/show_bug.cgi?id=141772
3540
3541         Reviewed by Tim Horton.
3542
3543         Adding WebEditingTester, a Cocoa application to
3544         test WK1 and Wk2 views in editable mode.
3545
3546         * WebEditingTester: Added.
3547         * WebEditingTester/AppDelegate.h: Added.
3548         * WebEditingTester/AppDelegate.m: Added.
3549         (-[WebEditingAppDelegate init]):
3550         (defaultConfiguration):
3551         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3552         (-[WebEditingAppDelegate applicationWillTerminate:]):
3553         (-[WebEditingAppDelegate newEditor:]):
3554         (-[WebEditingAppDelegate showOperations:]):
3555         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3556         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3557         (-[WebEditingAppDelegate validateMenuItem:]):
3558         * WebEditingTester/Info.plist: Added.
3559         * WebEditingTester/MainMenu.xib: Added.
3560         * WebEditingTester/WK1WebDocumentController.h: Added.
3561         * WebEditingTester/WK1WebDocumentController.m: Added.
3562         (-[WK1WebDocumentController awakeFromNib]):
3563         (-[WK1WebDocumentController loadContent]):
3564         (-[WK1WebDocumentController dealloc]):
3565         (-[WK1WebDocumentController pasteAsMarkup:]):
3566         * WebEditingTester/WK2WebDocumentController.h: Added.
3567         * WebEditingTester/WK2WebDocumentController.m: Added.
3568         (-[WK2WebDocumentController initWithConfiguration:]):
3569         (-[WK2WebDocumentController pasteAsMarkup:]):
3570         (-[WK2WebDocumentController awakeFromNib]):
3571         (-[WK2WebDocumentController dealloc]):
3572         (-[WK2WebDocumentController loadContent]):
3573         * WebEditingTester/WebDocument.xib: Added.
3574         * WebEditingTester/WebDocumentController.h: Added.
3575         * WebEditingTester/WebDocumentController.m: Added.
3576         (-[WebDocumentController initWithWindow:]):
3577         (-[WebDocumentController windowDidLoad]):
3578         (-[WebDocumentController defaultEditingSource]):
3579         (-[WebDocumentController applicationTerminating]):
3580         (-[WebDocumentController loadContent]):
3581         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3582         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3583         * WebEditingTester/main.m: Added.
3584         (main):
3585
3586 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3587
3588         Run JSC tests on ARM EFL bots
3589         https://bugs.webkit.org/show_bug.cgi?id=141165
3590
3591         Reviewed by Alexey Proskuryakov.
3592
3593         * BuildSlaveSupport/build.webkit.org-config/config.json:
3594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3595         (RunJavaScriptCoreTests.countFailures):
3596         (RunRemoteJavaScriptCoreTests):
3597         (RunRemoteJavaScriptCoreTests.start):
3598         (BuildAndRemoteJSCTestsFactory):
3599         (BuildAndRemoteJSCTestsFactory.__init__):
3600
3601 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3602
3603         Streamline unexported function build fixes
3604         https://bugs.webkit.org/show_bug.cgi?id=141761
3605
3606         Reviewed by Alex Christensen.
3607
3608         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3609         We don't need to ignore symbols that are not exported due to the .unexp file.
3610
3611 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3612
3613         Remove more references to WebCore.exp.in
3614         https://bugs.webkit.org/show_bug.cgi?id=141747
3615
3616         Reviewed by Alexey Proskuryakov.
3617
3618         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3619         (ShouldBuildTest):
3620
3621 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3622
3623         Windows test results should not fall back to mac-mountainlion after r180176
3624         https://bugs.webkit.org/show_bug.cgi?id=141719
3625
3626         Reviewed by Brent Fulgham.
3627
3628         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3629         (_should_file_trigger_build):
3630         * Scripts/webkitpy/port/win.py:
3631         (WinPort.default_baseline_search_path):
3632         * Scripts/webkitpy/port/win_unittest.py:
3633         (WinPortTest.test_baseline_search_path):
3634
3635 2015-02-17  Daniel Bates  <dabates@apple.com>
3636
3637         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3638         https://bugs.webkit.org/show_bug.cgi?id=141718
3639
3640         Reviewed by Alex Christensen.
3641
3642         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3643
3644         * Scripts/webkitpy/port/ios.py:
3645         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3646         Log a error and return False if we are unable to boot the simulator device so that the caller can take
3647         appropriate action, say exit(3) before running any layout tests.
3648         * Scripts/webkitpy/xcode/simulator.py:
3649         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3650         with the specified UDID.
3651         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3652         with the specified UDID can successfully boot and shut down. We make at most two attempts to
3653         boot and shut down the device, erasing the device between tries so as to restore the device
3654         to a known good state.
3655
3656 2015-02-17  Daniel Bates  <dabates@apple.com>
3657
3658         run_webkit_tests.py should not know about iOS Simulator details
3659         https://bugs.webkit.org/show_bug.cgi?id=141711
3660
3661         Reviewed by Alex Christensen.
3662
3663         Run_webkit_tests.py should only parse the iOS-specific command
3664         line options --runtime and --device-type. Let the port-specific
3665         logic in ios.py validate the parsed options and instantiate
3666         internal data structures.
3667
3668         Currently run_webkit_tests.py parses the iOS-specific command
3669         line options --runtime and --device-type, validates them, and
3670         instantiates internal data structures from the parsed strings.
3671         Instead the validation logic and instantiation of internal
3672         data structures should be handled by the iOS port object.
3673
3674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3675         (_set_up_derived_options): Remove logic to validate --runtime and -