2011-01-13 Mikhail Naganov <mnaganov@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2
3         Reviewed by Timothy Hatcher.
4
5         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
6         to be passed directly to WebInspector.UIString
7
8         https://bugs.webkit.org/show_bug.cgi?id=52365
9
10         * Scripts/check-inspector-strings:
11
12 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
13
14         Unreviewed, rolling out r74881.
15         http://trac.webkit.org/changeset/74881
16         https://bugs.webkit.org/show_bug.cgi?id=52357
17
18         The EFL builder has been red for days (Requested by abarth on
19         #webkit).
20
21         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
22         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
23
24 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
25
26         Reviewed by David Levin.
27
28         Add beforeunload support to WebKitTestRunner
29         https://bugs.webkit.org/show_bug.cgi?id=52353
30         
31         This makes a number of currently failing tests pass.
32
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::runBeforeUnloadConfirmPanel):
35         (WTR::createOtherPage):
36         (WTR::TestController::initialize):
37
38 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
39
40         Reviewed by Sam Weinig.
41
42         Detect, identify and recover from WebProcess crashes in run-webkit-tests
43         https://bugs.webkit.org/show_bug.cgi?id=52330
44
45         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
46         a web process crash.
47         * WebKitTestRunner/TestController.cpp:
48         (WTR::TestController::initialize): Set up a processDidCrash
49         callback.
50         (WTR::TestController::processDidCrash): Report that the Web process
51         crashed.
52         * WebKitTestRunner/TestController.h:
53
54 2011-01-12  David Levin  <levin@chromium.org>
55
56         Reviewed by Shinichiro Hamaji.
57
58         check-webkit-style -- close_expression function doesn't work correctly.
59         https://bugs.webkit.org/show_bug.cgi?id=52272
60
61         * Scripts/webkitpy/style/checkers/cpp.py:
62         (Position.__str__): Added a way to convert it to a string which is useful in tests.
63         (Position.__cmp__): Added a way to compare Position which is useful in tests and
64         generally useful (for upcoming code changes).
65         (close_expression): Changed to use Position for input and output.
66         Also, fixed many bugs such as only working correctly for parenthesis,
67         not working correctly if given an offset in a line and not finding
68         the real closing element if there were multiple closing elements in
69         the same line.
70         (detect_functions): Adjusted due to the change in arguments for
71         close_expression.
72         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
73         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
74         two positions are the same.
75         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
76         (CppStyleTest.test_close_expression): Added tests to catch the issues
77         that were fixed.
78
79 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
80
81         Unreviewed, rolling out r75576.
82         http://trac.webkit.org/changeset/75576
83         https://bugs.webkit.org/show_bug.cgi?id=52304
84
85         broke rebaseline-chromium-webkit-test (Requested by thakis on
86         #webkit).
87
88         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
89         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
90         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
91         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
92         * Scripts/webkitpy/layout_tests/port/base.py:
93         * Scripts/webkitpy/layout_tests/port/chromium.py:
94         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
95         * Scripts/webkitpy/layout_tests/port/test.py:
96         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
97         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
98         * Scripts/webkitpy/style/checkers/test_expectations.py:
99         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
100
101 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
102
103         Reviewed by Darin Adler.
104
105         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
106         https://bugs.webkit.org/show_bug.cgi?id=52307
107
108         * Scripts/old-run-webkit-tests:
109
110 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
111
112         Reviewed by Martin Robinson.
113
114         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
115         https://bugs.webkit.org/show_bug.cgi?id=50867
116
117         Fixed library extention for Mac in webkitdirs.pm and type conflict in
118         TestNetscapePlugin.cpp 
119
120         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
121         * Scripts/webkitdirs.pm:
122
123 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
124
125         Reviewed by Pavel Feldman.
126
127         Add check-inspector-strings script.
128
129         https://bugs.webkit.org/show_bug.cgi?id=52295
130
131         * Scripts/check-inspector-strings: Added.
132
133 2011-01-12  Adam Roben  <aroben@apple.com>
134
135         Advertise the .testnetscape file extension on Windows
136
137         Fixes <http://webkit.org/b/52298>
138         plugins/no-mime-with-valid-extension.html fails on Windows
139
140         Reviewed by Dan Bernstein.
141
142         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
143         FileExtents field to map the .testnetscape file extension to the
144         application/x-webkit-test-netscape MIME type, just as we do on Mac.
145
146 2011-01-12  Adam Barth  <abarth@webkit.org>
147
148         Reviewed by Eric Seidel.
149
150         Make webkit-patch support subdirectories for SVN checkouts
151         https://bugs.webkit.org/show_bug.cgi?id=52261
152
153         os.relpath does not exist on Python 2.5, so we need to call our version
154         of the API.
155
156         * Scripts/webkitpy/common/checkout/scm.py:
157
158 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
159
160         Reviewed by Eric Seidel.
161
162         Close additional pages opened during a test once the test completes.
163         https://bugs.webkit.org/show_bug.cgi?id=52276
164
165         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
166         (WTR::InjectedBundle::done):
167
168 2011-01-11  David Levin  <levin@chromium.org>
169
170         Reviewed by Eric Seidel.
171
172         Errors should be separated from the command line in bot messages.
173         https://bugs.webkit.org/show_bug.cgi?id=52275
174
175         * Scripts/webkitpy/common/system/executive.py:
176         (ScriptError.message_with_output): Added a newline to separate the command
177         line from the errors.
178         * Scripts/webkitpy/common/system/executive_unittest.py:
179         (ScriptErrorTest.test_message_with_output): Added tests for the various code
180         paths in message_with_output.
181
182 2011-01-11  Eric Seidel  <eric@webkit.org>
183
184         Unreviewed.
185
186         commit-queue should know how to upload archived results (for test flakes or general failures)
187         https://bugs.webkit.org/show_bug.cgi?id=52048
188
189         The zips are mostly empty due to forgetting -r.
190         Expected diffs were not being pulled from the archive due
191         to the archive having longer paths than I realized.
192
193         * Scripts/webkitpy/common/system/workspace.py:
194         * Scripts/webkitpy/common/system/workspace_unittest.py:
195         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
196         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
197
198 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
199
200         Reviewed by Ojan Vafai.
201
202         The current modifier parsing code in test_expectations is
203         fragile and hard-coded, so it's not easy to understand the logic
204         or easily add new types of modifiers (like GPU vs. CPU testing
205         for graphics tests, or 32-bit vs. 64-bit differences).
206
207         This is the first of two patches that will add in more generic
208         support and then eliminate the GPU-specific test expectations
209         files for Chromium.
210
211         This patch adds two standalone objects for handling modifiers. The
212         rules for interpreting modifiers, precedence, and conflicts are
213         given in the docstring to the ModifierMatcher class, which
214         returns ModifierMatchResult objects.
215         
216         This patch also adds routines to the Port interface and a
217         default set of values in the base object, in order to obtain the
218         values needed on a given test run. These values are then passed
219         to the expectation parser. This also allows us to clean up the
220         logic used to lint all of the different configurations in a
221         single test_expectations.txt file.
222
223         The next patch will merge in the separate GPU expectations file.
224
225         https://bugs.webkit.org/show_bug.cgi?id=51222
226
227         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
228         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
229         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
230         * Scripts/webkitpy/layout_tests/port/base.py:
231         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
232         * Scripts/webkitpy/layout_tests/port/chromium.py:
233         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
234         * Scripts/webkitpy/layout_tests/port/test.py:
235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
236         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
237
238 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
239
240         Reviewed by Adam Barth.
241
242         Make webkit-patch support subdirectories for SVN checkouts
243         https://bugs.webkit.org/show_bug.cgi?id=52261
244
245         * Scripts/webkitpy/common/checkout/scm.py:
246         * Scripts/webkitpy/style_references.py:
247         * Scripts/webkitpy/tool/main.py:
248         * Scripts/webkitpy/tool/steps/preparechangelog.py:
249
250 2011-01-11  Eric Seidel  <eric@webkit.org>
251
252         Unreviewed.
253
254         commit-queue should know how to upload archived results (for test flakes or general failures)
255         https://bugs.webkit.org/show_bug.cgi?id=52048
256
257         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
258         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
259
260         * Scripts/webkitpy/common/system/workspace.py:
261         * Scripts/webkitpy/common/system/workspace_unittest.py:
262         * Scripts/webkitpy/tool/commands/queues.py:
263
264 2011-01-11  Sam Weinig  <sam@webkit.org>
265
266         Roll r75474 back in.
267
268 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
269
270         Reviewed by Kenneth Rohde Christiansen.
271
272         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
273         https://bugs.webkit.org/show_bug.cgi?id=51204
274
275         * QtTestBrowser/webpage.h:
276         (QtNAMThread::QtNAMThread):
277         (QtNAMThread::networkAccessManager):
278         (QtNAMThread::run):
279
280 2011-01-11  Peter Varga  <pvarga@webkit.org>
281
282         Unreviewed.
283
284         Add myself to committers' list.
285
286         * Scripts/webkitpy/common/config/committers.py:
287
288 2011-01-11  Eric Seidel  <eric@webkit.org>
289
290         Reviewed by Adam Barth.
291
292         commit-queue should know how to upload archived results (for test flakes or general failures)
293         https://bugs.webkit.org/show_bug.cgi?id=52048
294
295         Now the queue will always upload results.  Either the entire zip, or just
296         the diffs.txt in the case of text failures.
297
298         This should make understanding flakes much easier, and paves the way
299         for having the EWS run layout tests (and upload failures).
300
301         In order to upload .zip files I had to teach bugzilla.py to autodetect
302         mime types from the filename.  Since mimetypes.py doesn't include a mapping
303         for .patch files, I have it add one before calling guess_type.
304
305         We may find that always uploading the whole zip instead of just the -diffs.txt
306         file is preferable, but for now I'm keeping the old behavior because it makes
307         quickly understanding text failures easy.
308
309         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
310         * Scripts/webkitpy/common/system/workspace.py: Added.
311         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
312         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
313         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
314         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
315         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
316         * Scripts/webkitpy/tool/commands/queues.py:
317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
318
319 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
320
321         Unreviewed, rolling out r75464.
322         http://trac.webkit.org/changeset/75464
323         https://bugs.webkit.org/show_bug.cgi?id=52193
324
325         Followup rollout for 75474 (Requested by Ossy on #webkit).
326
327         * MiniBrowser/mac/BrowserWindowController.m:
328         (-[BrowserWindowController awakeFromNib]):
329         * MiniBrowser/win/BrowserView.cpp:
330         (BrowserView::create):
331         * WebKitTestRunner/TestController.cpp:
332         (WTR::createOtherPage):
333         (WTR::TestController::initialize):
334
335 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
336
337         Reviewed by Csaba Osztrogonác.
338
339         [Qt] Baseline qt_minimal configuration
340         https://bugs.webkit.org/show_bug.cgi?id=51313
341
342         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
343         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
344         QT_NO_UNDOSTACK guard.
345
346         * QtTestBrowser/launcherwindow.cpp:
347         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
348         guards.
349         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
350         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
351         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
352         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
353
354         * QtTestBrowser/launcherwindow.h:
355         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
356         * QtTestBrowser/locationedit.h: Ditto.
357
358         * QtTestBrowser/mainwindow.cpp:
359         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
360         QT_NO_UNDOSTACK guards.
361         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
362         (MainWindow::changeLocation): Ditto.
363         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
364         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
365
366         * QtTestBrowser/webpage.cpp:
367         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
368         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
369
370         * QtTestBrowser/webview.cpp:
371         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
372         (WebViewGraphicsBased::animatedYFlip): Ditto.
373
374 2011-01-10  Sam Weinig  <sam@webkit.org>
375
376         Fix build.
377
378         * MiniBrowser/mac/BrowserWindowController.m:
379         (-[BrowserWindowController awakeFromNib]):
380         * MiniBrowser/win/BrowserView.cpp:
381         (BrowserView::create):
382         * WebKitTestRunner/TestController.cpp:
383         (WTR::createOtherPage):
384         (WTR::TestController::initialize):
385
386 2011-01-10  Eric Seidel  <eric@webkit.org>
387
388         Reviewed by Ojan Vafai.
389
390         style-queue messages are way too long for big patches
391         https://bugs.webkit.org/show_bug.cgi?id=52161
392
393         We definitely could build much fancier list-to-string-with-limit functions
394         but this should be sufficient for our needs at the moment.
395
396         * Scripts/webkitpy/common/system/executive.py:
397         * Scripts/webkitpy/common/system/executive_unittest.py:
398
399 2011-01-10  Tony Chang  <tony@chromium.org>
400
401         Unreviewed, rolling out r75398.
402         http://trac.webkit.org/changeset/75398
403         https://bugs.webkit.org/show_bug.cgi?id=52008
404
405         Some layout tests are crashing on Chromium Win.
406
407         * DumpRenderTree/chromium/WebViewHost.cpp:
408         (WebViewHost::updatePaintRect):
409         * DumpRenderTree/chromium/WebViewHost.h:
410
411 2011-01-10  Adam Roben  <aroben@apple.com>
412
413         Roll out r75392
414
415         It isn't needed now that r75289 has been rolled out.
416
417         * Scripts/run-javascriptcore-tests:
418
419 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
420
421         Reviewed by Anders Carlsson.
422
423         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
424         https://bugs.webkit.org/show_bug.cgi?id=52160
425
426         * WebKitTestRunner/mac/TestControllerMac.mm:
427         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
428         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
429         anyway.
430
431 2011-01-10  Tony Chang  <tony@chromium.org>
432
433         Reviewed by Mihai Parparita.
434
435         [chromium] fix for animated gif layout tests
436         https://bugs.webkit.org/show_bug.cgi?id=52008
437
438         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
439             to trigger gif animations.
440         (WebViewHostPaintTask::WebViewHostPaintTask):
441         (WebViewHostPaintTask::runIfValid):
442         (WebViewHost::updatePaintRect):
443         * DumpRenderTree/chromium/WebViewHost.h:
444         (WebViewHost::taskList):
445
446 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
447
448         Reviewed by Xan Lopez.
449
450         [GTK] Fix gtk2 compilation for master
451         https://bugs.webkit.org/show_bug.cgi?id=51885
452
453         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
454         (createBitmapContextFromWebView): Replaced the old
455         gdk_drawable_get_size with gdk_pixmap_get_size.
456
457 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
458
459         Reviewed by Laszlo Gombos.
460
461         [WINCE] Reenable NPAPI after r75203
462         https://bugs.webkit.org/show_bug.cgi?id=52109
463
464         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
465         it with !isEfl(), because EFL port does not support NPAPI (yet).
466
467         * Scripts/build-webkit:
468
469 2011-01-10  Adam Roben  <aroben@apple.com>
470
471         Skip some asserting JS tests
472
473         See <http://webkit.org/b/52156>.
474
475         * Scripts/run-javascriptcore-tests:
476
477 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
478
479         Reviewed by Xan Lopez.
480
481         [GTK] build-webkit disable Blob support via arguments passed to automake
482         https://bugs.webkit.org/show_bug.cgi?id=52097
483
484         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
485         build-webkit.
486
487 2011-01-10  Adam Roben  <aroben@apple.com>
488
489         Use the same name and description for TestNetscapePlugin on Windows and
490         Mac
491
492         Fixes <http://webkit.org/b/52151>
493         fast/frames/iframe-reparenting-plugins.html fails on Windows
494
495         Reviewed by Steve Falkenburg.
496
497         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
498         the name and description from Mac's Info.plist.
499
500 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
501
502         Reviewed by Laszlo Gombos.
503
504         [Qt][WK2] Guard gcc-specific syntax
505
506         Non-gcc based compliers choke on the "-include"
507         syntax for preinclude, place guard around it.
508
509         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
510         * WebKitTestRunner/qt/WebKitTestRunner.pro:
511
512 2011-01-10  Andreas Kling  <kling@webkit.org>
513
514         Reviewed by Simon Hausmann.
515
516         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
517         https://bugs.webkit.org/show_bug.cgi?id=52111
518
519         When getting a createNewPage() callback from QWKPage, create the
520         new page with the same QWKContext as the page that is passed to
521         the callback.
522
523         * MiniBrowser/qt/BrowserView.h:
524         * MiniBrowser/qt/BrowserWindow.cpp:
525         (newPageFunction):
526         (BrowserWindow::BrowserWindow):
527         * MiniBrowser/qt/BrowserWindow.h:
528
529 2011-01-10  Andreas Kling  <kling@webkit.org>
530
531         Reviewed by Kenneth Rohde Christiansen.
532
533         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
534
535         BrowserView set its own useless createNewPage() callback on QWKPage.
536         This was immediately overridden by BrowserWindow anyway, so remove
537         the BrowserView one.
538
539         * MiniBrowser/qt/BrowserView.cpp:
540         (BrowserView::BrowserView):
541
542 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
543
544         Reviewed by Jeremy Orlow.
545
546         [Chromium] Remove non-client-based Geolocation code
547         https://bugs.webkit.org/show_bug.cgi?id=50921
548
549         * DumpRenderTree/chromium/LayoutTestController.cpp:
550         (LayoutTestController::setGeolocationPermission):
551         (LayoutTestController::setMockGeolocationPosition):
552         (LayoutTestController::setMockGeolocationError):
553         * DumpRenderTree/chromium/WebViewHost.cpp:
554         (WebViewHost::geolocationClientMock):
555         (WebViewHost::reset):
556         * DumpRenderTree/chromium/WebViewHost.h:
557
558 2011-01-10  Eric Seidel  <eric@webkit.org>
559
560         Reviewed by Adam Barth.
561
562         Commit bot tried to land r? cq+ patch
563         https://bugs.webkit.org/show_bug.cgi?id=36638
564
565         It should now be possible to post a patch with r? and cq+ and the
566         commit-queue will correctly wait for the r+ before attempting to land the patch.
567         (This was a feature requested by several users.)
568
569         One caveat: We don't actually reject r-, cq+ patches from the queue
570         (we just ignore them), but I think that's OK for now.
571
572         I also noticed that setting r- once a commit-queue node had grabbed
573         a patch would not properly cancel the landing.  That's fixed and
574         tested in this patch.
575
576         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
577         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
578         * Scripts/webkitpy/tool/bot/feeders.py:
579         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
580
581 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
582
583         Reviewed by Kenneth Rohde Christiansen.
584
585         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
586         https://bugs.webkit.org/show_bug.cgi?id=51934
587
588         When accessing the network from the destructor of QWebPage, the network access manager
589         was already deleted because the object WebPage was already destructed.
590
591         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
592         The object is now destructed in the destructor of QObject.
593
594         * QtTestBrowser/webpage.cpp:
595         (WebPage::WebPage):
596         (WebPage::setQnamThreaded):
597         * QtTestBrowser/webpage.h:
598         (QtNAMThread::QtNAMThread):
599
600 2011-01-08  Eric Seidel  <eric@webkit.org>
601
602         Reviewed by Ojan Vafai.
603
604         test_failures.py should not mention TestShell (long live DumpRenderTree!)
605         https://bugs.webkit.org/show_bug.cgi?id=52067
606
607         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
608         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
609
610         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
611
612 2011-01-08  Eric Seidel  <eric@webkit.org>
613
614         Reviewed by Mihai Parparita.
615
616         commit-queue hangs when the ChangeLog diff is bad
617         https://bugs.webkit.org/show_bug.cgi?id=52072
618
619         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
620         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
621
622 2011-01-08  Adam Barth  <abarth@webkit.org>
623
624         Teach svn-apply how to re-write WebCore to Source/WebCore.
625
626         * Scripts/VCSUtils.pm:
627
628 2011-01-07  Adam Barth  <abarth@webkit.org>
629
630         Rubber-stamped by Eric Seidel.
631
632         Move WebCore to Source
633         https://bugs.webkit.org/show_bug.cgi?id=52050
634
635         Update the tools to understand WebCore's new location.
636
637         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
638         * DumpRenderTree/wscript:
639         * GNUmakefile.am:
640         * Scripts/build-webkit:
641         * Scripts/do-file-rename:
642         * Scripts/do-webcore-rename:
643         * Scripts/generate-qt-inspector-resource:
644         * Scripts/prepare-ChangeLog:
645         * Scripts/run-bindings-tests:
646         * Scripts/update-iexploder-cssproperties:
647         * Scripts/update-sources-list.py:
648         * Scripts/update-webkit-localizable-strings:
649         * Scripts/webkitdirs.pm:
650         * Scripts/webkitpy/common/config/build.py:
651         * Scripts/webkitpy/common/config/build_unittest.py:
652         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
653         * Scripts/webkitpy/style/checker.py:
654         * Scripts/webkitpy/style/checker_unittest.py:
655         * WebKitTestRunner/DerivedSources.pro:
656         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
657         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
658         * wx/browser/wscript:
659         * wx/build/settings.py:
660
661 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
662
663         Reviewed by Sam Weinig.
664
665         Make WebKitTestRunner rest between loads more robust to avoid test crashes
666         https://bugs.webkit.org/show_bug.cgi?id=52086
667
668         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
669         (WTR::InjectedBundle::didReceiveMessage):
670         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
671         (WTR::LayoutTestController::notifyDone):
672         * WebKitTestRunner/TestController.cpp:
673         (WTR::TestController::resetStateToConsistentValues):
674         (WTR::TestController::run):
675
676 2011-01-07  James Robinson  <jamesr@chromium.org>
677
678         Revert "Implement mozilla's animationTime property"
679         https://bugs.webkit.org/show_bug.cgi?id=51952
680
681         This approach isn't quite right.
682
683         * DumpRenderTree/chromium/WebViewHost.cpp:
684         (WebViewHost::paintInvalidatedRegion):
685
686 2011-01-07  Adam Roben  <aroben@apple.com>
687
688         Build master fix
689
690         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
691         (RunWebKitTests.start): Don't try to concatenate a list and a string.
692
693 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
694
695         Reviewed by Csaba Osztrogonác.
696
697         run-qtwebkit-tests should be able to kill a testsuite.
698
699         Add new option in the script that can setup a timeout for a test.
700         If the test execution takes more then specified time then the test
701         would be terminated.
702
703         [Qt] run-qtwebkit-tests needs timeout
704         https://bugs.webkit.org/show_bug.cgi?id=51894
705
706         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
707         * Scripts/run-qtwebkit-tests:
708
709 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
710
711         Unreviewed fix after r75233.
712
713         Based on idea from Eric Seidel.
714
715         Add remote zip file handling to webkitpy.
716         https://bugs.webkit.org/show_bug.cgi?id=50901
717
718         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
719
720 2011-01-07  Shane Stephens  <shanestephens@google.com>
721
722         Reviewed by Eric Seidel.
723
724         svn-apply: should support git binary delta diffs
725         https://bugs.webkit.org/show_bug.cgi?id=38864
726
727         * Scripts/VCSUtils.pm:
728         * Scripts/svn-apply:
729
730 2011-01-06  Julie Parent  <jparent@chromium.org>
731
732         Reviewed by Eric Seidel.
733
734         Test Result Server not removing old results.
735         https://bugs.webkit.org/show_bug.cgi?id=52012
736
737         * TestResultServer/model/jsonresults.py:
738         Fix off-by-one: Truncate if >= num_runs, not just >.
739         * TestResultServer/model/jsonresults_unittest.py:
740         Add unit test to test that merging in a new result with the same value
741         as the last result causes previous result to fall off.
742
743 2011-01-06  James Kozianski  <koz@chromium.org>
744
745         Reviewed by Mihai Parparita.
746
747         Add classes to provide a consistent interface to a set of files.
748         https://bugs.webkit.org/show_bug.cgi?id=50901
749
750         These classes allow us to write code that is agnostic to whether a
751         particular set of files resides in a local directory or in a zip file
752         on a remote machine.
753
754         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
755         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
756         * Scripts/webkitpy/common/system/fileset.py: Added.
757         * Scripts/webkitpy/common/system/filesystem.py:
758         * Scripts/webkitpy/common/system/filesystem_mock.py:
759         * Scripts/webkitpy/common/system/zipfileset.py: Added.
760         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
761
762 2011-01-06  Eric Seidel  <eric@webkit.org>
763
764         Reviewed by Adam Barth.
765
766         NetworkTransaction should log the url it is retrying
767         https://bugs.webkit.org/show_bug.cgi?id=52043
768
769         * Scripts/webkitpy/common/net/networktransaction.py:
770         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
771
772 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
773
774         Windows build fix.
775         Import os before using it.
776
777         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
778
779 2011-01-06  Eric Seidel  <eric@webkit.org>
780
781         Reviewed by Adam Barth.
782
783         StyleQueue fails to report errors when patches have many files
784         https://bugs.webkit.org/show_bug.cgi?id=52042
785
786         This is one of at least two errors preventing style error reporting at the moment.
787         When we moved to passing the list of files to check explicitly,
788         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
789         We could change the type of the QueueStatus.message type, or we could
790         just teach statusserver.py how to clamp values (and warn when it does).
791         I chose the latter path.
792
793         * Scripts/webkitpy/common/net/statusserver.py:
794
795 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
796
797         Reviewed by Stephanie Lewis.
798         
799         Fix syntax error in script.
800
801         Windows bots need to archive/unarchive builds to/from configuration-specific directories
802         https://bugs.webkit.org/show_bug.cgi?id=51996
803
804         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
805
806 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
807
808         Unreviewed, fixing WinCE build after r75196.
809
810         WinCE port does not (yet) support NPAPI.
811
812         * Scripts/build-webkit:
813
814 2011-01-06  Xan Lopez  <xlopez@igalia.com>
815
816         Reviewed by Darin Adler.
817
818         File::Spec->rel2abs in sunspider-compare-results mangles parameters
819         https://bugs.webkit.org/show_bug.cgi?id=52015
820
821         * Scripts/sunspider-compare-results: call rel2abs on our arguments
822         after the platform has been detected, otherwise the script will
823         mangle things like '--gtk' into '/a/path/--gtk', breaking the
824         detection.
825
826 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
827
828         Reviewed by Eric Seidel.
829
830         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
831         https://bugs.webkit.org/show_bug.cgi?id=51346
832
833         * Scripts/build-webkit:
834
835 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
836
837         Reviewed by Adam Roben.
838
839         Windows bots need to archive/unarchive builds to/from configuration-specific directories
840         https://bugs.webkit.org/show_bug.cgi?id=51996
841         
842         After the configuration directory change, we were archiving the incorrect directory for
843         build product, so we were running tests on the wrong binaries.
844         
845         This change archives the correct directory, and also unarchives it into a configuration-
846         specific directory.
847
848         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
849         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
850
851 2011-01-06  Eric Seidel  <eric@webkit.org>
852
853         Reviewed by Mihai Parparita.
854
855         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
856         https://bugs.webkit.org/show_bug.cgi?id=52002
857
858         See an example of this here:
859         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
860
861         It's due to the fact that we pass around TestFailure() instance
862         objects and yet expect them to all compare to be the same.
863
864         This is bad.  We should either have shared instances of these values
865         or we should just pass around the class names.  There are already hacks
866         in place to make TestFailure objects pass equality tests, I just added
867         a __hash__ implementation so they can be used in sets as expected.
868
869         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
870         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
871
872 2011-01-06  Evan Martin  <evan@chromium.org>
873
874         Reviewed by Tony Chang.
875
876         [gdb] handle inaccessible memory and UChar*
877         https://bugs.webkit.org/show_bug.cgi?id=52003
878
879         To pretty-print a UChar*, we just grope around in the memory
880         looking for a terminating NUL.  We need to handle the exception
881         that can occur when we poke into an invalid location.
882
883         Additionally, the logic for choosing which pretty-printer would
884         early return before hitting the point where we'd use the UChar*
885         printer.  (Did this ever work?  How did it regress?)
886
887         * gdb/webkit.py:
888
889 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
890
891         Reviewed by Ada Chan.
892
893         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
894         https://bugs.webkit.org/show_bug.cgi?id=51969
895         
896         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
897
898         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
899         (WTR::InjectedBundlePage::InjectedBundlePage):
900         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
901         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
902
903 2011-01-06  James Robinson  <jamesr@chromium.org>
904
905         Reviewed by Simon Fraser.
906
907         Implement mozilla's animationTime property
908         https://bugs.webkit.org/show_bug.cgi?id=51952
909
910         Chromium DRT support for webkitAnimationTime.
911
912         * DumpRenderTree/chromium/WebViewHost.cpp:
913         (WebViewHost::paintInvalidatedRegion):
914
915 2011-01-06  Julie Parent  <jparent@chromium.org>
916
917         Reviewed by Tony Chang.
918
919         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
920         https://bugs.webkit.org/show_bug.cgi?id=51217
921
922         * TestResultServer/model/jsonresults.py:
923         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
924         Adds missing documentation.
925         * TestResultServer/model/jsonresults_unittest.py:
926         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
927         Update test_merge to take a number of builds to truncate at.
928
929 2011-01-06  Adam Barth  <abarth@webkit.org>
930
931         Reviewed by Eric Seidel.
932
933         The EWS should log outside of the working directory
934         https://bugs.webkit.org/show_bug.cgi?id=51986
935
936         This patch prepare us for using git clean -x -d -f in the EWS wrapper
937         script, which will actually clean the working copy back to a pristine
938         state instead of leaving untracked directories and ignored files.
939
940         * Scripts/webkitpy/tool/commands/queues.py:
941         * Scripts/webkitpy/tool/commands/queues_unittest.py:
942
943 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
944
945         Windows build fix.
946         Back out attempted change to built-product-archive.
947
948         * BuildSlaveSupport/built-product-archive:
949
950 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
951
952         Windows build fix.
953         Include configuration name when unpacking a build archive.
954
955         Needed, since we split Windows build results into configuration-specific directories
956         under WebKitOutputDir.
957
958         * BuildSlaveSupport/built-product-archive:
959
960 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
961
962         Reviewed by Darin Adler.
963
964         Debug and Release builds on Windows clobber each other
965         https://bugs.webkit.org/show_bug.cgi?id=49185
966
967         Changes the structure of WebKitBuild build products directory so we
968         completely separate each build configuration into independent directories.
969         
970         Although we previously had per-configuration directories for obj, this change adds
971         per-configuration directories for bin, lib, obj, and include. Each configuration's
972         build products are stored within a directory inside of WebKitBuild.
973         
974         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
975         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
976
977         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
978         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
979         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
980         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
981         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
982         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
983         * DumpRenderTree/win/ImageDiffCommon.vsprops:
984         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
985         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
986         * FindSafari/FindSafari.vcproj:
987         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
988         * MiniBrowser/MiniBrowserPostBuild.cmd:
989         * MiniBrowser/MiniBrowserPreBuild.cmd:
990         * Scripts/webkitdirs.pm:
991         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
992         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
993         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
994         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
995         * TestWebKitAPI/win/copy-resources.cmd:
996         * WebKitAPITest/WebKitAPITestCommon.vsprops:
997         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
998         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
999         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1000         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1001         * WebKitTestRunner/win/InjectedBundle.vcproj:
1002         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1003         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1004         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1005         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1006         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1007         * WinLauncher/WinLauncherCommon.vsprops:
1008         * WinLauncher/WinLauncherPostBuild.cmd:
1009         * WinLauncher/WinLauncherPreBuild.cmd:
1010
1011 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1012
1013         Reviewed by Ariya Hidayat.
1014
1015         [Qt] TestNetscapePlugin doesn't link on OS X
1016         https://bugs.webkit.org/show_bug.cgi?id=51948
1017
1018         Only add a dependency on libX11 on X11 systems
1019
1020         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1021
1022 2011-01-05  Jeff Miller  <jeffm@apple.com>
1023
1024         Reviewed by Adam Roben.
1025
1026         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1027         https://bugs.webkit.org/show_bug.cgi?id=51970
1028
1029         * Scripts/webkitpy/style/checker.py:
1030         Add -readability/naming for WebKit2 C API directories.
1031
1032 2011-01-05  Eric Seidel  <eric@webkit.org>
1033
1034         Unreviewed, just fixing one more log error from my previous python patch.
1035
1036         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1037         https://bugs.webkit.org/show_bug.cgi?id=51802
1038
1039         webkit-patch failure-reason was logging about parsing errors
1040         due to my misunderstanding of how BeautifulSoup.findAll worked.
1041
1042         Fixed, and added a unit test.
1043
1044         * Scripts/webkitpy/common/net/layouttestresults.py:
1045         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1046
1047 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1048
1049         Reviewed by Kenneth Rohde Christiansen.
1050
1051         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1052         https://bugs.webkit.org/show_bug.cgi?id=51951
1053
1054         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1055         to create new window from WebKit.
1056
1057         * MiniBrowser/qt/BrowserWindow.cpp:
1058         (newPageFunction):
1059         (BrowserWindow::BrowserWindow):
1060         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1061         (BrowserWindow::newWindow):
1062         (BrowserWindow::updateUserAgentList):
1063         (BrowserWindow::showUserAgentDialog):
1064         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1065         define the type of the backing store used for new windows.
1066         * MiniBrowser/qt/main.cpp:
1067         (main):
1068
1069 2011-01-05  Eric Seidel  <eric@webkit.org>
1070
1071         Reviewed by Ojan Vafai.
1072
1073         commit-queue should report failure type when reporting flaky tests
1074         https://bugs.webkit.org/show_bug.cgi?id=51900
1075
1076         This patch was a ridiculous amount of plumbing.  In the end I like
1077         the NRWT-style TestResult class even less.  But now we're passing
1078         a list of TestResult objects from the queue to the FlakyTestReporter.
1079         Thus the FlakyTestReporter can more easily report what type of failure
1080         occurred.
1081
1082         In the process, I found that I was not alone in finding TestResult
1083         cumbersome to use.  A bunch of code was trying to create a TestResult
1084         object with default values.  However since the constructor didn't make
1085         this easy, some places were getting it wrong (including the TestResult unit test)!
1086         I've fixed the TestResult constructor to have default values for non-essential
1087         arguments.
1088
1089         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1090         * Scripts/webkitpy/common/net/layouttestresults.py:
1091         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1092         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1093         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1094         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1095         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1096         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1097         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1098         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1099         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1100         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1101         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1102         * Scripts/webkitpy/tool/commands/queues.py:
1103         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1104
1105 2011-01-05  Eric Seidel  <eric@webkit.org>
1106
1107         Unreviewed.
1108
1109         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1110         https://bugs.webkit.org/show_bug.cgi?id=51802
1111
1112         Add another unit test to cover a previously missing import.
1113
1114         * Scripts/webkitpy/common/net/layouttestresults.py:
1115         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1116
1117 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1118
1119         Reviewed by David Levin.
1120
1121         Add mihaip@chromium.org as a reviewer
1122         https://bugs.webkit.org/show_bug.cgi?id=51966
1123         
1124         Add myself as a reviewer.
1125
1126         * Scripts/webkitpy/common/config/committers.py:
1127
1128 2011-01-05  James Simonsen  <simonjam@chromium.org>
1129
1130         Unreviewed. Adding myself to the list of committers.
1131
1132         * Scripts/webkitpy/common/config/committers.py:
1133
1134 2011-01-05  Eric Seidel  <eric@webkit.org>
1135
1136         Unreviewed.
1137
1138         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1139         https://bugs.webkit.org/show_bug.cgi?id=51802
1140
1141         Fix two exceptions seen on the bots after my original commit.
1142
1143         * Scripts/webkitpy/common/net/layouttestresults.py:
1144         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1145
1146 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1147
1148         Reviewed by Andreas Kling.
1149
1150         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1151         https://bugs.webkit.org/show_bug.cgi?id=51750
1152
1153         * QtTestBrowser/main.cpp:
1154         (LauncherApplication::handleUserOptions):
1155          Local storage settings can be enable form command line arguments for
1156          QtTestBrowser.
1157
1158 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1159
1160         Reviewed by Martin Robinson.
1161
1162         GTK: AX: DRT needs to use correct root object method.
1163         https://bugs.webkit.org/show_bug.cgi?id=51911
1164
1165         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1166         (AccessibilityController::rootElement):
1167
1168 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1169
1170         Rubber-stamped by Csaba Osztrogonác.
1171
1172         Based on idea from Péter Gál.
1173
1174         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1175
1176 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1177
1178         Reviewed by Adam Barth.
1179
1180         sheriff-bot should be able to do multi-revision rollouts
1181         https://bugs.webkit.org/show_bug.cgi?id=51176
1182
1183         * Scripts/webkitpy/tool/bot/irc_command.py:
1184         * Scripts/webkitpy/tool/bot/sheriff.py:
1185         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1186
1187 2011-01-05  Eric Seidel  <eric@webkit.org>
1188
1189         Reviewed by Adam Barth.
1190
1191         queues.webkit.org should have per-bot status pages
1192         https://bugs.webkit.org/show_bug.cgi?id=51906
1193
1194         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1195         statuses from a single queue.  Now that we have many bots servicing
1196         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1197         you care about scroll off the end of the 15-message limit on the main page.
1198
1199         Eventually we should probably rename /queue-status to /queue or /queues,
1200         but that's fodder for another patch.
1201
1202         * QueueStatusServer/handlers/queuestatus.py:
1203         * QueueStatusServer/index.yaml:
1204         * QueueStatusServer/main.py:
1205         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1206          - This probably should use a custom filter instead of hard-coding
1207            the URL scheme here, but I couldn't figure out how to easily
1208            create such a filter.  Most filters work with "strings" so we can't
1209            pass the status object.  We could add a method to the status
1210            object and call that, but that seemed a bit strange too.
1211         * QueueStatusServer/templates/queuestatus.html:
1212
1213 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         Unreviewed. Adding myself to the list of committers.
1216
1217         * Scripts/webkitpy/common/config/committers.py:
1218
1219 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1220
1221         Reviewed by David Levin.
1222
1223         check-webkit-style treated some macros with parentheses after #elif as function calls
1224         https://bugs.webkit.org/show_bug.cgi?id=51695
1225
1226         Ingore function call space checking in any preprocessor directives
1227         (things starting with #). Change search() to match() because 
1228         preprocessor directives are supposed to be in the beginning of lines.
1229
1230         * Scripts/webkitpy/style/checkers/cpp.py:
1231         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1232
1233 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1234
1235         Reviewed by Tony Chang.
1236
1237         Change the --multi-load test option to --stress-opt
1238         https://bugs.webkit.org/show_bug.cgi?id=50751
1239
1240         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1241         (runTest):
1242         (main):
1243         * DumpRenderTree/chromium/TestShell.cpp:
1244         (TestShell::TestShell):
1245         * DumpRenderTree/chromium/TestShell.h:
1246         (TestShell::stressOpt):
1247         (TestShell::setStressOpt):
1248         (TestShell::stressDeopt):
1249         (TestShell::setStressDeopt):
1250         (TestShell::javaScriptFlags):
1251         (TestShell::setJavaScriptFlags):
1252         * Scripts/webkitpy/layout_tests/port/chromium.py:
1253         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1254
1255 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1256
1257         Reviewed by Sam Weinig.
1258
1259         WK2: Support Accessibility
1260         https://bugs.webkit.org/show_bug.cgi?id=51859
1261
1262         Use rootObject() method to get top of accessibility tree.
1263
1264         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1265         (AccessibilityController::focusedElement):
1266         (AccessibilityController::rootElement):
1267
1268 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1269
1270         Reviewed by Darin Adler.
1271
1272         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1273         https://bugs.webkit.org/show_bug.cgi?id=51846
1274
1275         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1276         back to GRefPtr.
1277
1278 2011-01-04  Zhe Su  <suzhe@chromium.org>
1279
1280         Reviewed by Kenneth Russell.
1281
1282         Fix insertText, setMarkedText and unmarkText methods of
1283         TextInputController to call corresponding methods of WebKit::WebView
1284         rather than WebKit::WebFrame. This change matches the behavior of
1285         chromium browser.
1286         insertText corresponds to WebView::confirmComposition(text)
1287         setMarkedText corresponds to WebView::setComposition(...)
1288         unmarkText corresponds to WebView::confirmComposition()
1289         https://bugs.webkit.org/show_bug.cgi?id=51693
1290
1291         * DumpRenderTree/chromium/TextInputController.cpp:
1292         (TextInputController::insertText):
1293         (TextInputController::setMarkedText):
1294         (TextInputController::unmarkText):
1295
1296 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1297
1298         Reviewed by Laszlo Gombos.
1299
1300         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1301
1302         On Symbian productDir points to the source directory. Removing all the
1303         empty files from the productDir directory corrupts the svn repository.
1304
1305         * Scripts/build-webkit:
1306
1307 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1308
1309         Reviewed by Adam Barth.
1310
1311         [Qt] Add SelectAll option to the context menu for the editor
1312         https://bugs.webkit.org/show_bug.cgi?id=50049
1313
1314         Set shortcut for the SelectAll action.
1315
1316         * QtTestBrowser/mainwindow.cpp:
1317         (MainWindow::buildUI):
1318
1319 2011-01-03  David Levin  <levin@chromium.org>
1320
1321         Reviewed by Eric Seidel.
1322
1323         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1324         https://bugs.webkit.org/show_bug.cgi?id=51842
1325
1326         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1327         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1328
1329 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1330
1331         Reviewed by David Kilzer.
1332
1333         [WINCE] Adds a build slave.
1334         https://bugs.webkit.org/show_bug.cgi?id=50523
1335
1336         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1337         entry for a release build of the WinCE port.
1338         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1339         flag to build the WinCE port.
1340
1341 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1342
1343         Reviewed by David Kilzer.
1344
1345         Add WinCE support to build-webkit
1346         https://bugs.webkit.org/show_bug.cgi?id=51642
1347
1348         * Scripts/build-webkit:
1349         * Scripts/webkitdirs.pm:
1350
1351 2011-01-03  Eric Seidel  <eric@webkit.org>
1352
1353         Reviewed by Adam Barth.
1354
1355         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1356         https://bugs.webkit.org/show_bug.cgi?id=51802
1357
1358         I'm not the biggest fan of the test_failures or test_results classes,
1359         but it's better to have one shared set of classes, than separate ones
1360         for new vs. old run-webkit-test result handling.
1361
1362         This moves the ORWT results class "LayoutTestResults" over to using
1363         TestResult and TestFailure classes, making it easy for us to
1364         make all our sheriff-bot and other webkitpy code NRWT ready.
1365
1366         This also makes it a trivial patch to generate results.json information
1367         from ORWT results.html files (for flaky test analysis, etc.) as well
1368         as making it a one-liner to report test failure types when the
1369         commit-queue sees flaky tests.
1370
1371         This patch tried not to add new functionality, but only to replace
1372         the guts of LayoutTestResults, while adding unit tests and hoping
1373         not to break anything.
1374
1375         I also moved callers which assumed User.prompt* were static/class methods
1376         to using them as instance methods (since we'll eventually want to make them such).
1377
1378         In the process of re-writing things, I broke the rebaseline command, so I wrote
1379         a unit test to catch my breakage were I do do so again in the future.
1380
1381         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1382         * Scripts/webkitpy/common/net/layouttestresults.py:
1383         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1384         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1385         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1386         * Scripts/webkitpy/tool/commands/queries.py:
1387         * Scripts/webkitpy/tool/commands/rebaseline.py:
1388         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1389         * Scripts/webkitpy/tool/mocktool.py:
1390
1391 2011-01-03  Adam Barth  <abarth@webkit.org>
1392
1393         Reviewed by Simon Fraser.
1394
1395         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1396         https://bugs.webkit.org/show_bug.cgi?id=51840
1397
1398         * Scripts/webkitpy/common/checkout/scm.py:
1399
1400 2011-01-03  Adam Barth  <abarth@webkit.org>
1401
1402         Reviewed by Simon Fraser.
1403
1404         webkit-patch should only hide update output if --quiet
1405         https://bugs.webkit.org/show_bug.cgi?id=51838
1406
1407         As requested by smfr.
1408
1409         * Scripts/webkitpy/tool/steps/update.py:
1410
1411 2011-01-03  Adam Barth  <abarth@webkit.org>
1412
1413         Reviewed by David Levin.
1414
1415         commit-queue shouldn't reject patches twice if two bots process the same patch
1416         https://bugs.webkit.org/show_bug.cgi?id=51805
1417
1418         Before raising an error, we first check whether the patch is still in
1419         the commit-queue.  This check is still racy, of course, but the time
1420         window is much smaller.
1421
1422         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1423
1424 2011-01-03  Sam Weinig  <sam@webkit.org>
1425
1426         Reviewed by Anders Carlsson.
1427
1428         Make run-api-tests less chatty.
1429         https://bugs.webkit.org/show_bug.cgi?id=51831
1430
1431         - Make script quiet by default and add --verbose option (replacing --quiet).
1432         - When not verbose, pipe stdout and stderr to devnull.
1433
1434         * Scripts/run-api-tests:
1435
1436 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1437
1438         Unreviewed. Adding myself to committers.py.
1439
1440         * Scripts/webkitpy/common/config/committers.py:
1441
1442 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1443
1444         Reviewed by Xan Lopez.
1445
1446         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1447         https://bugs.webkit.org/show_bug.cgi?id=51806
1448
1449         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1450         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1451         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1452         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1453         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1454         so make it 'WebKitBuild/Release/.libs'
1455
1456         * Scripts/webkitdirs.pm: 
1457
1458 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1459
1460         Reviewed by Adam Barth.
1461
1462         Make EFL a core builder
1463         https://bugs.webkit.org/show_bug.cgi?id=51804
1464
1465         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1466         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1467
1468 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1469
1470         [Qt] Unreviewed fix after r74855 and r74875.
1471
1472         * BuildSlaveSupport/built-product-archive:
1473          - Create directories explicitly.
1474          - Pass shell=True to subprocess.call().
1475
1476 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1477
1478         [Qt] Unreviewed fix after r74855.
1479
1480         Move JavaScriptCore to Source
1481         https://bugs.webkit.org/show_bug.cgi?id=51604
1482
1483         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1484
1485 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1486
1487         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1488
1489         Move JavaScriptCore to Source
1490         https://bugs.webkit.org/show_bug.cgi?id=51604
1491
1492         * Scripts/webkitdirs.pm:
1493
1494 2011-01-02  Robert Hogan  <robert@webkit.org>
1495
1496         Unreviewed, build fix.
1497
1498         [Qt] Fix DRT build after 74855
1499
1500         * DumpRenderTree/qt/DumpRenderTree.pro:
1501
1502 2011-01-01  Adam Barth  <abarth@webkit.org>
1503
1504         Remove the assumption from the Qt and Gtk builds that every project is
1505         in the root directory.
1506
1507         * Scripts/build-webkit:
1508
1509 2011-01-01  Adam Barth  <abarth@webkit.org>
1510
1511         Reviewed by Eric Seidel.
1512
1513         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1514         https://bugs.webkit.org/show_bug.cgi?id=51796
1515
1516         After this change, svn-apply will magically apply patches to
1517         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1518
1519         * Scripts/VCSUtils.pm:
1520
1521 2011-01-01  Adam Barth  <abarth@webkit.org>
1522
1523         Reviewed by Eric Seidel.
1524
1525         Move JavaScriptCore to Source
1526         https://bugs.webkit.org/show_bug.cgi?id=51604
1527
1528         Update references to JavaScriptCore to point to the new location.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1531         * DumpRenderTree/qt/DumpRenderTree.pro:
1532         * DumpRenderTree/qt/ImageDiff.pro:
1533         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1534         * DumpRenderTree/wscript:
1535         * Scripts/build-jsc:
1536         * Scripts/build-webkit:
1537         * Scripts/do-file-rename:
1538         * Scripts/do-webcore-rename:
1539         * Scripts/run-javascriptcore-tests:
1540         * Scripts/update-javascriptcore-test-results:
1541         * Scripts/webkitdirs.pm:
1542         * Scripts/webkitpy/common/config/build_unittest.py:
1543         * Scripts/webkitpy/style/checker.py:
1544         * Scripts/webkitpy/style/checker_unittest.py:
1545         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1546         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1547         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1548         * wx/build/settings.py:
1549
1550 2011-01-01  Adam Barth  <abarth@webkit.org>
1551
1552         Reviewed by Eric Seidel.
1553
1554         Move Sources to Source
1555         https://bugs.webkit.org/show_bug.cgi?id=51794
1556
1557         Update scripts to point to the new location.
1558
1559         * Scripts/build-webkit:
1560         * Scripts/do-file-rename:
1561         * Scripts/do-webcore-rename:
1562         * Scripts/webkitpy/common/config/build.py:
1563         * Scripts/webkitpy/common/config/build_unittest.py:
1564
1565 2010-12-31  Kent Tamura  <tkent@chromium.org>
1566
1567         Reviewed by Eric Seidel.
1568
1569         [DRT/Chromium] Enable mock spell checker on non-OSX
1570         https://bugs.webkit.org/show_bug.cgi?id=51401
1571
1572         * DumpRenderTree/chromium/WebViewHost.cpp:
1573         (WebViewHost::spellCheck):
1574
1575 2010-12-31  Adam Barth  <abarth@webkit.org>
1576
1577         Reviewed by Ariya Hidayat.
1578
1579         Remove Tools/Scripts/wkstyle
1580         https://bugs.webkit.org/show_bug.cgi?id=51774
1581
1582         This script appears to not have been touched in a while and seems to
1583         have been replaced by check-webkit-style.
1584
1585         * Scripts/wkstyle: Removed.
1586
1587 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1588
1589         Unreviewed. Coding style fix.
1590
1591         * DumpRenderTree/chromium/TestShell.h:
1592
1593 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1594
1595         Reviewed by Pavel Feldman.
1596
1597         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1598
1599         It was a problem with Chromium DRT. DevToolsAgent object instance was
1600         attached not only to the inspected page but to the DevTools window too.
1601         As result all the inspector files were interpreted as a content of inspected page
1602         and were transfered to the DevTools scripts panel for debugging etc.
1603
1604         https://bugs.webkit.org/show_bug.cgi?id=51735
1605
1606         * DumpRenderTree/chromium/TestShell.cpp:
1607         (TestShell::TestShell):
1608         (TestShell::bindJSObjectsToWindow):
1609         (TestShell::createNewWindow):
1610         * DumpRenderTree/chromium/TestShell.h:
1611
1612 2010-12-31  Adam Barth  <abarth@webkit.org>
1613
1614         Rubber-stamped by Eric Seidel.
1615
1616         Move PageLoadTests to PerformanceTests/PageLoad
1617         https://bugs.webkit.org/show_bug.cgi?id=51771
1618
1619         Update references to PageLoadTests to point to the new location.
1620
1621         * Scripts/run-pageloadtest:
1622         * Scripts/webkitpy/common/config/build.py:
1623
1624 2010-12-31  Adam Barth  <abarth@webkit.org>
1625
1626         Rubber-stamped by Eric Seidel.
1627
1628         Move SunSpider into PerformanceTests
1629         https://bugs.webkit.org/show_bug.cgi?id=51769
1630
1631         Update these scripts to point to the new location.
1632
1633         * Scripts/run-sunspider:
1634         * Scripts/sunspider-compare-results:
1635
1636 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1637
1638         Reviewed by Kent Tamura.
1639
1640         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1641         https://bugs.webkit.org/show_bug.cgi?id=51728
1642         
1643         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1644         to render top-level scrollbars. This makes them match the Mac port's
1645         use of an NSScrollView, which means that we'll be able to share more
1646         pixel baselines.
1647         
1648         The new rendering code will not be activated until the 
1649         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1650         ScrollbarThemeChromiumMac.
1651
1652         * DumpRenderTree/DumpRenderTree.gypi:
1653         * DumpRenderTree/chromium/TestShellMac.mm:
1654         (platformInit):
1655         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1656         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1657         (+[FakeActiveWindow alwaysActiveWindow]):
1658         (+[FakeActiveWindow alwaysInactiveWindow]):
1659         (-[FakeActiveWindow initWithActiveControls:]):
1660         (-[FakeActiveWindow _hasActiveControls]):
1661         (WebThemeEngineDRTMac::paintScrollbarThumb):
1662         (stateToHIEnableState):
1663         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1664         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1665
1666 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1667
1668         Reviewed by David Kilzer.
1669
1670         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1671         used
1672         https://bugs.webkit.org/show_bug.cgi?id=51672
1673
1674         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1675         with USE_SYSTEM_MALLOC=1
1676         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1677         with USE_SYSTEM_MALLOC=1
1678
1679 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1680
1681         Reviewed by David Kilzer.
1682
1683         [Qt] [Symbian] Fix build-webkit script for Symbian
1684         https://bugs.webkit.org/show_bug.cgi?id=51509
1685
1686         Set the OUTPUT_DIR for Symbian to be the same as the source
1687         directory.
1688
1689         * Scripts/webkitdirs.pm:
1690
1691 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1692
1693         Reviewed by Darin Adler.
1694
1695         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1696         https://bugs.webkit.org/show_bug.cgi?id=51758
1697
1698         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1699
1700         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1701         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1702
1703 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1704
1705         Unreviewed WinCE buildfix.
1706
1707         * WinCELauncher/main.cpp: Add missing include.
1708
1709 2010-12-29  Daniel Bates  <dbates@rim.com>
1710
1711         Reviewed by Darin Adler.
1712
1713         svn-apply updates date of wrong change log entry for a change log diff that
1714         contains two consecutive entries with the same author and date
1715         https://bugs.webkit.org/show_bug.cgi?id=46061
1716
1717         Fixes an issue where the date of the wrong change log entry may be modified.
1718         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1719         in a ChangeLog file to the top of the file.
1720
1721         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1722         diff when it detects that the diff inserts a change log entry earlier in a
1723         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1724         change. With the advent of the commit-queue this functionality of bailing out
1725         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1726         Instead, we should always move the change log entry to the top of the ChangeLog file.
1727
1728         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1729         the date line of the correct change log entry in a ChangeLog diff.
1730
1731         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1732
1733         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1734           Updated the following unit tests now that we move entries inserted earlier to the top:
1735           - "fixChangeLogPatch: New entry inserted in middle."
1736             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1737
1738           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1739             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1740
1741         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1742
1743 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1744
1745         Reviewed by Eric Seidel.
1746
1747         [Qt] Fixed compatibility with gold linker on X11 platforms
1748         https://bugs.webkit.org/show_bug.cgi?id=51700
1749
1750         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1751         Linked TestNetscapePlugin with libX11 on Unix platforms
1752
1753 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1754
1755         Reviewed by Darin Adler.
1756
1757         Circular dependency in webkitpy.common.checkout.changelog module
1758         https://bugs.webkit.org/show_bug.cgi?id=50475
1759
1760         Remove automatic import of api.Checkout module when any checkout/
1761         submodule is imported (e.g.: when checkout.scm.Git is imported).
1762
1763         * Scripts/webkitpy/common/checkout/__init__.py:
1764
1765 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1766
1767         Reviewed by Ojan Vafai.
1768
1769         prepare-ChangeLog should support the -g option for specifying the git-commit
1770         https://bugs.webkit.org/show_bug.cgi?id=51708
1771
1772         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1773         webkit-patch, though the exact meaning of the two options remain different.
1774
1775         * Scripts/prepare-ChangeLog: Add -g.
1776
1777 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1778
1779         Reviewed by Simon Hausmann.
1780
1781         [Qt] Fix compilation with Qt in namespace
1782         https://bugs.webkit.org/show_bug.cgi?id=51701
1783
1784         * QtTestBrowser/webview.h:
1785
1786 2010-12-28  Daniel Bates  <dbates@rim.com>
1787
1788         Reviewed by Sam Weinig.
1789
1790         Substitute // MARK: for compiler-specific #pragma mark
1791         https://bugs.webkit.org/show_bug.cgi?id=51657
1792
1793         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1794         substituting  "// MARK:" for "#pragma mark", which provides
1795         analogous code-bookmarking functionality under Xcode.
1796
1797         Also, for consistency, we should substitute "// MARK:" for compiler-
1798         specific "#pragma mark" in the source files for the Mac port.
1799
1800         * DumpRenderTree/AccessibilityTextMarker.cpp:
1801         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1802         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1803         * DumpRenderTree/mac/ObjCController.m:
1804         * MiniBrowser/mac/AppDelegate.m:
1805         * MiniBrowser/mac/BrowserWindowController.m:
1806
1807 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1808
1809         Reviewed by Eric Seidel.
1810
1811         Add --no-build option to run-sunspider
1812         https://bugs.webkit.org/show_bug.cgi?id=51658
1813
1814         * Scripts/run-sunspider: add --no-build flag to skip building
1815         phase.
1816
1817 2010-12-27  Daniel Bates  <dbates@rim.com>
1818
1819         Rubber-stamped by Martin Robinson.
1820
1821         Append the directory Tools/DumpRenderTree to the list of directories that
1822         do-webcore-rename should search so that it can rename DRT files and
1823         source code.
1824
1825         * Scripts/do-webcore-rename:
1826
1827 2010-12-27  Eric Seidel  <eric@webkit.org>
1828
1829         Reviewed by Adam Barth.
1830
1831         build-webkit should detect missing Java SDK and explain how to install it
1832         https://bugs.webkit.org/show_bug.cgi?id=51651
1833
1834         * Scripts/build-webkit:
1835
1836 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1837
1838         Reviewed by Daniel Bates.
1839
1840         [GTK] Add support for build-jsc
1841         https://bugs.webkit.org/show_bug.cgi?id=51625
1842
1843         Add GTK+ support to build-jsc now that building the jsc executable as
1844         a standalone target is easy.
1845
1846         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1847         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1848         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1849         and pass it along to buildAutotoolsProject.
1850
1851 2010-12-27  David Levin  <levin@chromium.org>
1852
1853         Reviewed by Eric Seidel.
1854
1855         check-webkit-style check for meaningless variable names in function declarations.
1856         https://bugs.webkit.org/show_bug.cgi?id=51523
1857
1858         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1859         from the new check and whitespace/parens because the syntax is unusual and
1860         produced a fair number of positives for these checks.
1861         * Scripts/webkitpy/style/checkers/cpp.py:
1862         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1863         and parameter names when determining if the parameter name is useless.
1864         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1865         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1866         format.
1867         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1868         text or an acronym of it.
1869         (check_function_definition): Checks function definitions for meaningless variable names.
1870         (process_line): Added call to check_function_definition.
1871         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1872         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1873         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1874         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1875         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1876         because when only checking a snippet, there are a lot of bogus functions.
1877         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1878         that I put there previously and just noticed.
1879         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1880         check_function_definition and process_line.
1881
1882 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1883
1884         Reviewed by Martin Robinson.
1885
1886         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1887         https://bugs.webkit.org/show_bug.cgi?id=51591
1888
1889         Flash plugin uses gtk2 that is incompatible with gtk3 making
1890         webkit crash when it's built with gtk3.
1891
1892         * GtkLauncher/main.c:
1893         (main):
1894
1895 2010-12-25  Adam Barth  <abarth@webkit.org>
1896
1897         Reviewed by Eric Seidel.
1898
1899         Move ANGLE to Sources/ThirdParty
1900         https://bugs.webkit.org/show_bug.cgi?id=51605
1901
1902         * Scripts/build-webkit:
1903           - Point to the new ANGLE location.
1904
1905 2010-12-26  David Levin  <levin@chromium.org>
1906
1907         Reviewed by Eric Seidel.
1908
1909         check-webkit-style should be able to parse function declaration parameters.
1910         https://bugs.webkit.org/show_bug.cgi?id=51451
1911
1912         * Scripts/webkitpy/style/checkers/cpp.py:
1913         (Position.__init__): Holds simple position information (row, column).
1914         (Parameter.__init__): Holds information about a parameter.
1915         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1916         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1917         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1918         (find_parameter_name_index): Finds where the parameter name is.
1919         (parameter_list): Generates the list of parameters for a function.
1920         (_FunctionState.begin): Added information to allow determining the parameters
1921         on demand.
1922         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1923         (detect_functions): Improve function detection for operator functions and
1924         determine where the parameters end and pass that to _FunctionState.begin.
1925         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1926         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1927         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1928         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1929         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1930         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1931         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1932         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1933         the parameters found.
1934         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1935         detection test to verify that we catch the operator functions.
1936         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1937         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1938         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1939         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1940         test_function_length_check_definition_severity1_for_test.
1941
1942 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1943
1944         Unreviewed WinCE buildfix after r74334.
1945
1946         * CMakeListsWinCE.txt:
1947
1948 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1949
1950         Unreviewed, rolling out r74632.
1951         http://trac.webkit.org/changeset/74632
1952         https://bugs.webkit.org/show_bug.cgi?id=51600
1953
1954         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1955         on #webkit).
1956
1957         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1958         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1959
1960 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1961
1962         Reviewed by Kenneth Rohde Christiansen.
1963
1964         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1965         https://bugs.webkit.org/show_bug.cgi?id=43528
1966
1967         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1968         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1969         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1970         called.
1971
1972         * EWebLauncher/main.c:
1973         (browserCreate):
1974
1975 2010-12-24  Eric Seidel  <eric@webkit.org>
1976
1977         Reviewed by Adam Barth.
1978
1979         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1980         https://bugs.webkit.org/show_bug.cgi?id=28291
1981
1982         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1983         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1984         to strings with find in the diff.
1985         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1986
1987         * Scripts/webkitpy/common/checkout/api.py:
1988         * Scripts/webkitpy/common/checkout/diff_parser.py:
1989         * Scripts/webkitpy/tool/steps/abstractstep.py:
1990         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1991         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1992         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1993         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1994
1995 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1996
1997         Reviewed by Kenneth Russell.
1998
1999         Modify new-run-webkit-tests to shut up and exit when all the threads
2000         are wedged so that test runs complete faster and we don't end up
2001         w/ enormous log files.
2002
2003         https://bugs.webkit.org/show_bug.cgi?id=51572
2004
2005         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2006         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2007
2008 2010-12-24  Eric Seidel  <eric@webkit.org>
2009
2010         Reviewed by David Levin.
2011
2012         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2013         https://bugs.webkit.org/show_bug.cgi?id=51549
2014
2015         I've had multiple people ask me about the commit-queue's behavior
2016         regarding reporting flaky tests.  I figured it would be best to just
2017         have the queue explain itself in the bugs it files.
2018
2019         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2020         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2021
2022 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2023
2024         Reviewed by Eric Seidel.
2025
2026         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2027         https://bugs.webkit.org/show_bug.cgi?id=51467
2028
2029         * Scripts/webkitpy/style/checker.py:
2030         * Scripts/webkitpy/style/checker_unittest.py:
2031
2032 2010-12-23  Adam Barth  <abarth@webkit.org>
2033
2034         Rubber-stamped by Eric Seidel.
2035
2036         Move JavaScriptGlue into Sources
2037         https://bugs.webkit.org/show_bug.cgi?id=51583
2038
2039         These tools refer to JavaScriptGlue and need to be updated to its new
2040         location.
2041
2042         * Scripts/build-webkit:
2043         * Scripts/do-file-rename:
2044         * Scripts/do-webcore-rename:
2045         * Scripts/webkitpy/common/config/build.py:
2046         * Scripts/webkitpy/common/config/build_unittest.py:
2047
2048 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2049
2050         Reviewed by Eric Seidel.
2051
2052         Bug 51539 - update iexploder scripts to point to new location
2053
2054         * Scripts/run-iexploder-tests:
2055         * Scripts/update-iexploder-cssproperties:
2056
2057 2010-12-23  Evan Martin  <evan@chromium.org>
2058
2059         Reviewed by Ryosuke Niwa.
2060
2061         [chromium] LayoutTestController warning in float->int conversion
2062         https://bugs.webkit.org/show_bug.cgi?id=51553
2063
2064         Rather than reading an int, converting to a float, then getting a compiler
2065         warning on passing the float to something that expects an int, instead
2066         just pass around ints.
2067
2068         No tests, fixes a compiler warning.
2069
2070         * DumpRenderTree/chromium/LayoutTestController.cpp:
2071         (parsePageSizeParameters):
2072         (LayoutTestController::pageNumberForElementById):
2073         (LayoutTestController::numberOfPages):
2074
2075 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2076
2077         Reviewed by Darin Adler.
2078
2079         Bug 51537 - iexploder needs cleanup
2080         
2081         * iExploder/htdocs: Removed.
2082         * iExploder/htdocs/config.rb: Removed.
2083         * iExploder/htdocs/cssproperties.in: Removed.
2084         * iExploder/htdocs/cssvalues.in: Removed.
2085         * iExploder/htdocs/htmlattrs.in: Removed.
2086         * iExploder/htdocs/htmltags.in: Removed.
2087         * iExploder/htdocs/htmlvalues.in: Removed.
2088         * iExploder/htdocs/iexploder.cgi: Removed.
2089         * iExploder/htdocs/iexploder.rb: Removed.
2090         * iExploder/htdocs/index.html: Removed.
2091         * iExploder/htdocs/webserver.rb: Removed.
2092         * iExploder/iexploder-1.7.2/output: Removed.
2093         * iExploder/tools: Removed.
2094         * iExploder/tools/lasthit.rb: Removed.
2095         * iExploder/tools/osx_last_crash.rb: Removed.
2096         * iExploder/tools/showtest.rb: Removed.
2097
2098 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2099
2100         Reviewed by Kenneth Rohde Christiansen.
2101
2102         [EFL] Make 'single' the default backing store in EWebLauncher
2103         https://bugs.webkit.org/show_bug.cgi?id=51534
2104
2105         'single' is the simplest backing store and the one intended to be the
2106         default in the test browser. By mistake the tiled backing store was
2107         left as default in r72617.
2108
2109         * EWebLauncher/main.c:
2110         (browserCreate): ditto.
2111
2112 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2113
2114         Reviewed by Kenneth Rohde Christiansen.
2115
2116         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2117         https://bugs.webkit.org/show_bug.cgi?id=51533
2118
2119         There's no point in concatenating env("HOME") with "blah", so remove
2120         option from EWebLauncher.
2121
2122         * EWebLauncher/main.c:
2123         (main): ditto.
2124
2125 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2126
2127         Reviewed by Eric Seidel.
2128
2129         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2130
2131         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2132         I just discovered that we have two additional GC runs per each WebViewHost.
2133         Test_shell had no such calls.
2134         These gc runs eat 15% of cpu time.
2135
2136         https://bugs.webkit.org/show_bug.cgi?id=51479
2137
2138         * DumpRenderTree/chromium/WebViewHost.cpp:
2139         (WebViewHost::~WebViewHost):
2140
2141 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2142
2143         Reviewed by Ojan Vafai.
2144
2145         This change splits out the TestRunner class into its own file.
2146         When we fork the code for message passing, we will create a new
2147         TestRunner, and this change will allow that to be more modular.
2148
2149         While we're at it, split out TestInput and ResultSummary into
2150         their own files, to reduce the size of run_webkit_tests to
2151         something more managable.
2152
2153         https://bugs.webkit.org/show_bug.cgi?id=51092
2154
2155         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2156         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2157         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2158         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2159         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2160         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2161         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2162
2163  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2164
2165         Reviewed by Ojan Vafai.
2166
2167         nrwt multiprocessing - start over, prepare to fork the code
2168  
2169         This code cleans up the signatures and implementation of the
2170         TestRunner class so we can easily fork it to run either the
2171         stable implementation or the new, unstable message-passing
2172         implementation. The two variants will have different
2173         implementations of the run_tests() method. We will switch
2174         between the two based on the setting for the '--worker-model'
2175         switch. We rename the two currently valid values to 'old-inline'
2176         and 'old-threads'.
2177
2178         https://bugs.webkit.org/show_bug.cgi?id=51081
2179
2180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2181         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2182
2183 2010-12-22  Victor Wang  <victorw@chromium.org>
2184
2185         Reviewed by Darin Fisher.
2186
2187         [Chromium] Update chromium archive test result url in rebaseline script.
2188
2189         https://bugs.webkit.org/show_bug.cgi?id=51503
2190
2191         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2192
2193 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2194
2195         Reviewed by Alice Liu.
2196
2197         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2198         Verified on Chrome, Safari, and IE.
2199         With this change, we will record memory from a parent browser window and all child processes.
2200
2201         * record-memory-win/main.cpp:
2202         (ProcessArgs):
2203         (PrintUsage):
2204         (getMemoryInfo):
2205         (printProcessInfo):
2206         (evalProcesses):
2207         (UseImage):
2208         (QueryContinuously):
2209         (ElapsedTime):
2210
2211 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2212
2213         Unreviewed rollout r74489, because it was missing changelog.
2214
2215         * record-memory-win/main.cpp:
2216         
2217 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2218
2219         Adding myself as a reviewer.
2220
2221         * Scripts/webkitpy/common/config/committers.py:
2222
2223 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2224
2225         Unreviewed.  Adding myself to committers.py.
2226
2227         * Scripts/webkitpy/common/config/committers.py:
2228
2229 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2230
2231         Reviewed by Kenneth Rohde Christiansen.
2232
2233         TestNetscapePlugIn should use #if defined
2234         https://bugs.webkit.org/show_bug.cgi?id=51471
2235
2236         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2237         (NP_Initialize):
2238         (NPP_New):
2239
2240 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2241
2242         Reviewed by Yury Semikhatsky.
2243
2244         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2245
2246         DevTools window should be closed explicitly because it has custom deinitialization code.
2247
2248         https://bugs.webkit.org/show_bug.cgi?id=50722
2249
2250         * DumpRenderTree/chromium/TestShell.cpp:
2251         (TestShell::closeRemainingWindows):
2252
2253 2010-12-22  David Levin  <levin@chromium.org>
2254
2255         Reviewed by Shinichiro Hamaji.
2256
2257         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2258         https://bugs.webkit.org/show_bug.cgi?id=51452
2259
2260         * Scripts/webkitpy/style/checkers/cpp.py:
2261         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2262         Using the file extension if possible but falling back to the file contents if we have a header file.
2263         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2264         (_FileState.is_c_or_objective_c):
2265         (check_using_std): Changed to using _FileState to determine the file type.
2266         (check_max_min_macros): Ditto.
2267         (check_for_null): Ditto.
2268         (check_style): Changed the parameters to various calls since they now need _FileState
2269         to determine the file type.
2270         (check_language): Added the file_state parameter so it could be passed
2271         to check_identifier_name_in_declaration.
2272         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2273         this is an Objective C file.
2274         (_process_lines): Added information for the _FileState constructor (and moved the
2275         call to a place that had the information).
2276         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2277         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2278         its functionality.
2279         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2280
2281 2010-12-21  Andy Estes  <aestes@apple.com>
2282
2283         Reviewed by Mark Rowe.
2284
2285         Do not build non-Intel architectures for WebKit2-related projects.
2286         https://bugs.webkit.org/show_bug.cgi?id=51440
2287
2288         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2289         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2290         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2291
2292 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2293
2294         Reviewed by Darin Fisher.
2295
2296         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2297         https://bugs.webkit.org/show_bug.cgi?id=51406 
2298         
2299         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2300         to WebThemeEngineDRTWin and update references everywhere.
2301
2302         * DumpRenderTree/DumpRenderTree.gypi:
2303         * DumpRenderTree/chromium/TestShellWin.cpp:
2304         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2305         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2306         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2307         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2308
2309 2010-12-21  Anders Carlsson  <andersca@apple.com>
2310
2311         Reviewed by John Sullivan.
2312
2313         Clicking missing plug-in text does not show a sheet
2314         https://bugs.webkit.org/show_bug.cgi?id=51403
2315
2316         Update for changes to the WebPageUIClient.
2317
2318         * MiniBrowser/mac/BrowserWindowController.m:
2319         (-[BrowserWindowController awakeFromNib]):
2320         * WebKitTestRunner/TestController.cpp:
2321         (WTR::createOtherPage):
2322         (WTR::TestController::initialize):
2323
2324 2010-12-21  Eric Seidel  <eric@webkit.org>
2325
2326         Reviewed by Adam Barth.
2327
2328         commit-queue will report constant failures as flaky if other tests flake
2329         https://bugs.webkit.org/show_bug.cgi?id=51272
2330
2331         This patch just removes functionality and adds testing.
2332         Previously we attempted to report flaky tests when we had
2333         two different tests fail in a row.  However, since we stop
2334         running the tests at the first failure, our code was wrong in
2335         trying to determine flakiness from the incomplete runs.
2336
2337         Originally I posted an alternate patch:
2338         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2339         which fixed our flaky logic in this case, however it was decided
2340         that that patch would be too difficult to maintain, so now
2341         I'm just removing the broken logic.
2342
2343         This will dramatically cut-down on our flaky-test false positives
2344         at the (small) cost of the queues being unable to report
2345         any flakiness if the tree is very flaky.  (With at least one test
2346         flaking on every run, we'll never report failures anymore.)  I think
2347         this is a tradeoff worth making.
2348
2349         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2350         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2351
2352 2010-12-20  Eric Seidel  <eric@webkit.org>
2353
2354         Reviewed by Adam Barth.
2355
2356         commit-queue wrongly rejects patches when it can't update itself
2357         https://bugs.webkit.org/show_bug.cgi?id=46636
2358
2359         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2360         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2361         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2362
2363 2010-12-20  Adam Barth  <abarth@webkit.org>
2364
2365         Move web sites to Websites directory
2366         https://bugs.webkit.org/show_bug.cgi?id=51323
2367
2368         Update references to BugsSite to point to the new location.
2369
2370         This patch was never officially reviewed (because it was too large to
2371         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2372         Rowe gave me the green light.
2373
2374         * Scripts/old-run-webkit-tests:
2375         * Scripts/webkitpy/common/config/build.py:
2376         * Scripts/webkitpy/common/config/build_unittest.py:
2377         * Scripts/webkitpy/common/prettypatch.py:
2378         * Scripts/webkitpy/layout_tests/port/base.py:
2379         * Scripts/webkitpy/style/main.py:
2380
2381 2010-12-20  Adrienne Walker  <enne@google.com>
2382
2383         Unreviewed. Adding myself to the list of committers.
2384
2385         * webkitpy/common/config/committers.py:
2386
2387 2010-12-20  Mark Rowe  <mrowe@apple.com>
2388
2389         Reviewed by Dan Bernstein.
2390
2391         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2392
2393         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2394         Resources directory.
2395
2396 2010-12-20  Eric Seidel  <eric@webkit.org>
2397
2398         Reviewed by Adam Barth.
2399
2400         commit-queue should include bot id when attaching failure diffs
2401         https://bugs.webkit.org/show_bug.cgi?id=51280
2402
2403         This is a tiny change to include the bot id in the name of the attachment.
2404         Most of this diff is just changing the unit test expectations
2405         now that I hid the comment printing when the comment is None.
2406
2407         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2408         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2409         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2410         * Scripts/webkitpy/tool/mocktool.py:
2411
2412 2010-12-20  Jeff Miller  <jeffm@apple.com>
2413
2414         Reviewed by Dan Bernstein.
2415
2416         Tools/vcbin/midl.exe needs to be rebuilt
2417         https://bugs.webkit.org/show_bug.cgi?id=51347
2418
2419         * vcbin/midl.exe: Rebuilt.
2420
2421 2010-12-20  David Levin  <levin@chromium.org>
2422
2423         Reviewed by Ariya Hidayat.
2424
2425         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2426         https://bugs.webkit.org/show_bug.cgi?id=51343
2427
2428         Follow up from the WebKitTools -> Tools rename.
2429
2430         * Scripts/webkit-tools-completion.sh:
2431
2432 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2433
2434         Reviewed by James Robinson.
2435
2436         new-run-webkit-tests ignores trailing EOL differences in text tests
2437         https://bugs.webkit.org/show_bug.cgi?id=36983
2438
2439         Changed the handling of new-line characters within new-run-webkit-tests
2440         to match old-run-webkit-tests.  Differences in leading and trailing empty
2441         lines in text expectation files are no longer ignored.
2442
2443         * Scripts/webkitpy/layout_tests/port/base.py:
2444         * Scripts/webkitpy/layout_tests/port/test.py:
2445         Added unit tests.  Removed old duplicate unit test entries.
2446         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2447
2448 2010-12-20  David Levin  <levin@chromium.org>
2449
2450         Reviewed by Shinichiro Hamaji.
2451
2452         check-webkit-style should detect function declarations (and trivial functions).
2453         https://bugs.webkit.org/show_bug.cgi?id=51303
2454
2455         * Scripts/webkitpy/style/checkers/cpp.py:
2456         (_FunctionState.begin): Add is_declaration and changed the line count
2457         start to begin at -1 (which will keep the results consistent, since
2458         the starting line number passed in is one less in this change).
2459         (detect_functions): changed function detection to now catch trivial
2460         functions and declarations.
2461         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2462         of the function as this may look at return values (when processing
2463         a declaration).
2464         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2465         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2466         of testing the function detection.
2467         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2468         function.
2469         (FunctionDetectionTest.test_function_declaration_detection): Test a
2470         declaration.
2471         (FunctionDetectionTest.test_non_functions): A test case for a case
2472         that caused the code to fail due to the { being in quotes.
2473         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2474         cases to help catch false alarms for return values.
2475         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2476         we don't get false alarms for member variables either.
2477
2478 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2479
2480         Reviewed by Antonio Gomes.
2481
2482         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2483         https://bugs.webkit.org/show_bug.cgi?id=51319
2484
2485         * CMakeListsEfl.txt:
2486
2487 2010-12-18  Adam Barth  <abarth@webkit.org>
2488
2489         Reviewed by Sam Weinig.
2490
2491         Move WebKitExamplePlugins to Examples
2492         https://bugs.webkit.org/show_bug.cgi?id=51291
2493
2494         * Scripts/webkitpy/common/config/build.py:
2495
2496 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2497
2498         Unreviewed Qt buildfix after r74301.
2499
2500         Rename WebKitTools to Tools
2501         https://bugs.webkit.org/show_bug.cgi?id=49861
2502
2503         * MiniBrowser/DerivedSources.pro:
2504         * MiniBrowser/qt/MiniBrowser.pro:
2505
2506 2010-12-17  Dan Bernstein  <mitz@apple.com>
2507
2508         Reviewed by Simon Fraser.
2509
2510         Rename WebKitTools to Tools
2511         https://bugs.webkit.org/show_bug.cgi?id=49861
2512
2513         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2514         * CodeCoverage/README:
2515         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2516         (WebCore::DumpRenderTree::initializeFonts):
2517         * EWSTools/start-commit-queue.sh:
2518         * EWSTools/start-queue.sh:
2519         * GNUmakefile.am:
2520         * MIDLWrapper/MIDLWrapper.cpp:
2521         (wmain):
2522         * MiniBrowser/qt/MiniBrowser.pro:
2523         * Scripts/build-api-tests:
2524         * Scripts/build-dumprendertree:
2525         * Scripts/build-webkit:
2526         * Scripts/build-webkittestrunner:
2527         * Scripts/generate-coverage-data:
2528         * Scripts/old-run-webkit-tests:
2529         * Scripts/run-api-tests:
2530         * Scripts/run-iexploder-tests:
2531         * Scripts/run-javascriptcore-tests:
2532         * Scripts/run-mangleme-tests:
2533         * Scripts/run-sunspider:
2534         * Scripts/run-webkit-websocketserver:
2535         * Scripts/sunspider-compare-results:
2536         * Scripts/test-webkitperl:
2537         * Scripts/test-webkitpy:
2538         * Scripts/update-iexploder-cssproperties:
2539         * Scripts/update-webkit:
2540         * Scripts/update-webkit-localizable-strings:
2541         * Scripts/webkitdirs.pm:
2542         * Scripts/webkitpy/common/checkout/scm.py:
2543         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2544         * Scripts/webkitpy/common/config/committervalidator.py:
2545         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2546         * Scripts/webkitpy/common/config/ports.py:
2547         * Scripts/webkitpy/common/config/ports_unittest.py:
2548         * Scripts/webkitpy/common/system/logutils_unittest.py:
2549         * Scripts/webkitpy/common/system/ospath_unittest.py:
2550         * Scripts/webkitpy/layout_tests/port/chromium.py:
2551         * Scripts/webkitpy/layout_tests/port/config.py:
2552         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2553         * Scripts/webkitpy/layout_tests/port/http_server.py:
2554         * Scripts/webkitpy/layout_tests/port/test.py:
2555         * Scripts/webkitpy/style/checker.py:
2556         * Scripts/webkitpy/style/checker_unittest.py:
2557         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2558         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2559         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2560         * WebKitTestRunner/DerivedSources.pro:
2561         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2562         (WTR::activateFonts):
2563         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2564         * wx/build/build_utils.py:
2565
2566 2010-12-16  Antonio Gomes  <agomes@rim.com>
2567
2568         Reviewed by Martin Robinson.
2569
2570         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2571         https://bugs.webkit.org/show_bug.cgi?id=51163
2572
2573         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2574         GTK+'s DRT should also reset to UNIX after each test execution.
2575
2576         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2577         (resetDefaultsToConsistentValues):
2578
2579 2010-12-17  David Levin  <levin@chromium.org>
2580
2581         Reviewed by Eric Seidel.
2582
2583         check-webkit-style should understand WTF #include guards
2584         https://bugs.webkit.org/show_bug.cgi?id=44911
2585
2586         * Scripts/webkitpy/style/checkers/cpp.py:
2587         (get_header_guard_cpp_variable): modify to suggest the WTF style
2588         of header guard when appropriate.
2589         (check_for_header_guard): handle multiple return values from
2590         get_header_guard_cpp_variable
2591         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2592         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2593         header style.
2594
2595 2010-12-16  David Levin  <levin@chromium.org>
2596
2597         Reviewed by Eric Seidel.
2598
2599         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2600         https://bugs.webkit.org/show_bug.cgi?id=51210
2601
2602         The error only shows up when using python 2.6 or later.
2603
2604         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2605         the decprecated field error,message with something equivalent.
2606
2607 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2608
2609         Reviewed by Eric Seidel.
2610
2611         Add --exit-after-n-failures/crashes to NRWT
2612         https://bugs.webkit.org/show_bug.cgi?id=51160
2613         
2614         Abort test run (in a similar way to how control-C is handled) when
2615         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2616         that number of unexpected failures/crashes/timeouts.
2617
2618         * Scripts/webkitpy/layout_tests/port/test.py:
2619         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2620         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2621
2622 2010-12-16  David Levin  <levin@chromium.org>
2623
2624         Reviewed by Shinichiro Hamaji.
2625
2626         check-webkit-style unit tests has some duplicate boilerplate code.
2627         https://bugs.webkit.org/show_bug.cgi?id=49519
2628
2629         * Scripts/webkitpy/style/checkers/cpp.py:
2630         (update_include_state): Replaced the "io" parameter with the global
2631         configuration _unit_test_config. This allowed not calling into
2632         functions at a low level and also not plumbing through the injection
2633         information through many levels of code.
2634         (check_for_include_what_you_use): Ditto.
2635         (process_file_data): Added the ability to set up the unit test config
2636         to allow for injection.
2637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2638         (ErrorCollector.__init__): Added support for having a filter for errors.
2639         (ErrorCollector.__call__): Ditto.
2640         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2641         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2642         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2643         functions in the cpp.py with generic processing and a filter that
2644         indicates what errors should be kept.
2645         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2646         (CppStyleTestBase.perform_language_rules_check): Ditto.
2647         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2648         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2649         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2650         (CppStyleTest.test_multi_line_comments): Added another
2651         error message which applies to the test case.
2652         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2653         to not have config.h, since it is processed as a header file.
2654         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2655         style and indentation in checked code.
2656         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2657         Fixed line number.
2658         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2659         Ditto.
2660
2661 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2662
2663         Unreviewed, rolling out r74136.
2664         http://trac.webkit.org/changeset/74136
2665         https://bugs.webkit.org/show_bug.cgi?id=51135
2666
2667         r74136 breaks chromium canary bots because some tests are not
2668         rebaselined correctly to resolve EOL differences (Requested by
2669         jianli on #webkit).
2670
2671         * Scripts/webkitpy/layout_tests/port/base.py:
2672         * Scripts/webkitpy/layout_tests/port/test.py:
2673         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2674
2675 2010-12-15  Adam Roben  <aroben@apple.com>
2676
2677         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2678         syntax errors
2679
2680         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2681         XML syntax errors in .vcproj/.vsprops files
2682
2683         Reviewed by Dave Levin.
2684
2685         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2686         that should be treated as XML and that should be allowed to contain
2687         carriage returns. (These lists happen to be identical currently.)
2688         (FileType): Added a new XML type.
2689         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2690         Just does a simple file extension check.
2691         (CheckerDispatcher._file_type): Added a case for XML files.
2692         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2693         files (surprise!).
2694         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2695         lines through the carriage checker.
2696
2697         * Scripts/webkitpy/style/checker_unittest.py:
2698         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2699         Added. Checks a few file names to see if carriage returns are allowed
2700         or not.
2701         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2702         other assert_checker_* functions.
2703         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2704         test_*_paths functions.
2705         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2706         test_*_paths functions.
2707         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2708         file from this test case, as vcproj files now have a type.
2709         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2710         Added. Similar to the other should_* functions.
2711         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2712         Added. Checks that carriage returns aren't checked for or stripped for
2713         allowed files.
2714
2715         * Scripts/webkitpy/style/checkers/xml.py: Added.
2716         (XMLChecker.__init__): Simple init method.
2717         (XMLChecker.check): Pass each line through the expat parser, and record
2718         a style error for any errors thrown by the parser.
2719
2720         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2721         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2722         produce a style error.
2723         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2724         error of the given category on the given line.
2725         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2726         checking that the XMLChecker constructor works properly.
2727         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2728         cause a style error (see, e.g., r73887).
2729         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2730         cause a style error (see, e.g., r73773).
2731         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2732         properly.
2733         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2734         tags cause a style error (see, e.g., r72795).
2735         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2736         style error.
2737
2738 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2739
2740         Reviewed by Stephanie Lewis.
2741
2742         https://bugs.webkit.org/show_bug.cgi?id=51117
2743         Add a new leopard test bot
2744         really really commit to trunk this time.
2745
2746         * BuildSlaveSupport/build.webkit.org-config/config.json:
2747
2748 2010-12-15  Sam Weinig  <sam@webkit.org>
2749
2750         Reviewed by Anders Carlsson.
2751
2752         WebKit2: Can't add files to an <input type=file>
2753         https://bugs.webkit.org/show_bug.cgi?id=51087
2754
2755         * MiniBrowser/mac/BrowserWindowController.m:
2756         (runOpenPanel):
2757         (-[BrowserWindowController awakeFromNib]):
2758         Add simple implementation of runOpenPanel callback.
2759
2760         * MiniBrowser/win/BrowserView.cpp:
2761         (BrowserView::create):
2762         * WebKitTestRunner/TestController.cpp:
2763         (WTR::createOtherPage):
2764         (WTR::TestController::initialize):
2765         Stub out runOpenPanel callback. 
2766
2767 2010-12-14  Eric Seidel  <eric@webkit.org>
2768
2769         Reviewed by Adam Barth.
2770
2771         commit-queue should upload failure diffs when tests flake
2772         https://bugs.webkit.org/show_bug.cgi?id=51051
2773
2774         To make this testable I needed to pipe FileSystem down onto tool.
2775         We've wanted it there for a long time anyway.
2776
2777         This patch is kinda a big hack.  But we don't have a nice
2778         way to read results.html files.  I think this will need further
2779         revision before this code actually feels clean.
2780
2781         As part of testing this change, I had to make MockBugzilla.create_bug
2782         actually return an id (like it should) which required updating
2783         a few other unit test results (for the better).
2784
2785         The results_matching_keys change in layouttestresults/rebasline
2786         was an alternate path which I decided not to use in the end, but
2787         I left the change as it seemed an improvement.
2788
2789         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2790         * Scripts/webkitpy/common/net/layouttestresults.py:
2791         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2792         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2793         * Scripts/webkitpy/tool/commands/queues.py:
2794         * Scripts/webkitpy/tool/commands/rebaseline.py:
2795         * Scripts/webkitpy/tool/main.py:
2796         * Scripts/webkitpy/tool/mocktool.py:
2797
2798 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2799
2800         Reviewed by James Robinson.
2801
2802         new-run-webkit-tests ignores trailing EOL differences in text tests
2803         https://bugs.webkit.org/show_bug.cgi?id=36983
2804
2805         Changed the handling of new-line characters within new-run-webkit-tests
2806         to match old-run-webkit-tests.  Differences in leading and trailing empty
2807         lines in text expectation files are no longer ignored.
2808
2809         * Scripts/webkitpy/layout_tests/port/base.py:
2810         * Scripts/webkitpy/layout_tests/port/test.py:
2811         Added unit tests.  Removed old duplicate unit test entries.
2812         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2813
2814 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2815
2816         Reviewed by Adam Barth.
2817
2818         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2819         https://bugs.webkit.org/show_bug.cgi?id=51149
2820
2821         * QueueStatusServer/templates/statusbubble.html:
2822
2823 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2824
2825         Reviewed by Adam Barth.
2826
2827         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2828         https://bugs.webkit.org/show_bug.cgi?id=51125
2829
2830         * QueueStatusServer/templates/statusbubble.html:
2831
2832 2010-12-15  Darin Adler  <darin@apple.com>
2833
2834         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2835
2836 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2837
2838         Unreviewed, rolling out r74117.
2839         http://trac.webkit.org/changeset/74117
2840         https://bugs.webkit.org/show_bug.cgi?id=51113
2841
2842         This broke the GTK1 build. (Requested by mrobinson on
2843         #webkit).
2844
2845         * Scripts/webkitdirs.pm:
2846
2847 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2848
2849         Reviewed by Martin Robinson.
2850
2851         Change generate-forwarding-headers.pl for GTK port usage 
2852         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2853
2854         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2855
2856 2010-12-14  Kent Tamura  <tkent@chromium.org>
2857
2858         Reviewed by Jian Li.
2859
2860         [DRT/Chromium] Remove another unnecessary error message
2861         https://bugs.webkit.org/show_bug.cgi?id=51083
2862
2863         * DumpRenderTree/chromium/WebViewHost.cpp:
2864         (WebViewHost::didInvalidateRect):
2865
2866 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2867
2868         Reviewed by Stephanie Lewis.
2869
2870         Add a new Leopard Debug Test WK2 Bot
2871
2872         * BuildSlaveSupport/build.webkit.org-config/config.json:
2873
2874 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2875
2876         Fix python unittests after http://trac.webkit.org/changeset/74070.
2877
2878         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2879
2880 2010-12-14  Kent Tamura  <tkent@chromium.org>
2881
2882         Reviewed by Jian Li.
2883
2884         [DRT/Chromium] Remove a unnecessary error message
2885         https://bugs.webkit.org/show_bug.cgi?id=51069
2886
2887         * DumpRenderTree/chromium/WebViewHost.cpp:
2888         (WebViewHost::paintInvalidatedRegion):
2889
2890 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2891
2892         Reviewed by Ojan Vafai.
2893
2894         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2895         https://bugs.webkit.org/show_bug.cgi?id=48926
2896
2897         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2898         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2899
2900 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2901
2902         Reviewed by Eric Seidel.
2903
2904         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2905         https://bugs.webkit.org/show_bug.cgi?id=50231
2906
2907         Guard CONFIG+=link_pkgconfig with !symbian.
2908
2909         * DumpRenderTree/qt/DumpRenderTree.pro:
2910         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2911         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2912
2913 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2914
2915         Reviewed by Ojan Vafai.
2916
2917         [new-run-webkit-tests] expectations parsing is slow
2918         https://bugs.webkit.org/show_bug.cgi?id=50635
2919
2920         Avoid expensive iteration of all the tests when checking if a test
2921         file is to be skipped or not.
2922
2923         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2924         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2925         * Scripts/webkitpy/layout_tests/port/test.py:
2926
2927 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2928
2929         Reviewed by Xan Lopez.
2930
2931         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2932         https://bugs.webkit.org/show_bug.cgi?id=27048
2933
2934         Add support in DRT for checking whether an accessibility UI
2935         element is focusable and/or focused. Implemented for GTK.
2936
2937         * DumpRenderTree/AccessibilityUIElement.cpp:
2938         (getIsFocusedCallback): New.
2939         (getIsFocusableCallback): New.
2940         (AccessibilityUIElement::getJSClass): Add the new available
2941         callbacks for isFocused and isFocusable.
2942         * DumpRenderTree/AccessibilityUIElement.h:
2943         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2944         (AccessibilityUIElement::isFocused): New, implemented by checking
2945         whether the related AtkState value is in the object's state set.
2946         (AccessibilityUIElement::isFocusable): Ditto.
2947         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2948         (AccessibilityUIElement::isFocused): New, dummy implementation.
2949         (AccessibilityUIElement::isFocusable): Ditto.
2950         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2951         (AccessibilityUIElement::isFocused): Ditto.
2952         (AccessibilityUIElement::isFocusable): Ditto.
2953
2954 2010-12-14  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Ojan Vafai.
2957
2958         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2959         https://bugs.webkit.org/show_bug.cgi?id=50715
2960
2961         This patch makes webkit-patch print the following:
2962
2963         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2964         Install a 64-bit git for better performance, see:
2965         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2966
2967         I wrote this mostly because I have approximately 8 machines that I use
2968         and making sure each one is using a good Git install seemed folly.
2969         webkit-patch makes a lot of git calls, so using a fast git can shave
2970         several seconds in every invocation.  See the webkit-dev thread for more info.
2971
2972         This message will print twice during 'webkit-patch upload',
2973         once from webkit-patch and once from check-webkit-style.
2974
2975         Unfortunately there is no good way to test this due to how machine-dependent
2976         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2977
2978         * Scripts/webkitpy/common/checkout/scm.py:
2979
2980 2010-12-13  Eric Seidel  <eric@webkit.org>
2981
2982         Reviewed by Adam Barth.
2983
2984         FlakyTestReporter doesn't understand bots running from multiple email addresses
2985         https://bugs.webkit.org/show_bug.cgi?id=50960
2986
2987         This explains at least one of the dupes of:
2988         https://bugs.webkit.org/show_bug.cgi?id=50863
2989         that we saw filed by the commit-queue this morning.
2990         I think the other one was explained by my previous fix to result counting code.
2991
2992         Since this is really hard to test with a unit test, instead I
2993         create a new (possibly useful in the future) command
2994         which given a layout test path will return you
2995         the one bug which our tools would assume it the flaky test bug.
2996         If some other script wants to use bug-for-test we'll
2997         need to extend it with some options like --create-if-missing or similar.
2998
2999         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3000         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3001         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3002         * Scripts/webkitpy/tool/commands/__init__.py:
3003         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3004
3005 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3006
3007         Reviewed by James Robinson.
3008
3009         Add option to build-webkit to not build WebKit2
3010         https://bugs.webkit.org/show_bug.cgi?id=50988
3011         
3012         Add support for a --no-webkit2 option to build-webkit. It seems to save
3013         ~1 minute from clean builds and ~10 seconds from no-op builds.
3014
3015         * Scripts/build-webkit:
3016
3017 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3018
3019         Reviewed by Dave Kilzer.
3020
3021         Update iexploder from 1.3.2 to 1.7.2
3022         Move 1.3.2 into its own subdir
3023         Add 1.7.2 into its own subdir
3024         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3025
3026         * Scripts/run-iexploder-tests:
3027         * Scripts/update-iexploder-cssproperties:
3028         * iExploder/CHANGELOG.txt: Removed.
3029         * iExploder/LICENSE.txt: Removed.
3030         * iExploder/README.txt: Removed.
3031         * iExploder/htdocs: Removed.
3032         * iExploder/iexploder-1.3.2: Added.
3033         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3034         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3035         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3036         * iExploder/iexploder-1.3.2/htdocs: Added.
3037         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3038         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3039         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3040         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3041         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3042         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3043         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3044         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3045         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3046         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3047         * iExploder/iexploder-1.3.2/tools: Added.
3048         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3049         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3050         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3051         * iExploder/iexploder-1.7.2: Added.
3052         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3053         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3054         * iExploder/iexploder-1.7.2/README.txt: Added.
3055         * iExploder/iexploder-1.7.2/output: Added.
3056         * iExploder/iexploder-1.7.2/src: Added.
3057         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3058         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3059         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3060         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3061         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3062         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3063         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3064         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3065         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3066         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3067         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3068         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3069         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3070         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3071         * iExploder/iexploder-1.7.2/src/css-values: Added.
3072         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3073         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3074         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3075         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3076         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3077         * iExploder/iexploder-1.7.2/src/headers: Added.
3078         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3079         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3080         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3081         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3082         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3083         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3084         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3085         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3086         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3087         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3088         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3089         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3090         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3091         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3092         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3093         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3094         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3095         * iExploder/iexploder-1.7.2/src/html-values: Added.
3096         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3097         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3098         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3099         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3100         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3101         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3102         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3103         * iExploder/iexploder-1.7.2/src/index.html: Added.
3104         * iExploder/iexploder-1.7.2/src/media: Added.
3105         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3106         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3107         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3108         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3109         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3110         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3111         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3112         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3113         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3114         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3115         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3116         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3117         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3118         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3119         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3120         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3121         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3122         * iExploder/iexploder-1.7.2/src/protocols: Added.
3123         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3124         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3125         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3126         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3127         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3128         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3129         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3130         * iExploder/iexploder-1.7.2/testcases: Added.
3131         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3132         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3133         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3134         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3135         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3136         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3137         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3138         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3139         * iExploder/iexploder-1.7.2/tools: Added.
3140         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3141         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3142         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3143         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3144         * iExploder/tools: Removed.
3145
3146 2010-12-13  Sam Weinig  <sam@webkit.org>
3147
3148         Reviewed by Anders Carlsson.
3149
3150         Remove associated page concept from WKView constructor
3151         https://bugs.webkit.org/show_bug.cgi?id=50983
3152
3153         Step 1: Remove associate page constructors from WKView and make
3154         all views use the shared namespace for the context.
3155
3156         * TestWebKitAPI/PlatformWebView.h:
3157         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3158         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3159         * WebKitTestRunner/PlatformWebView.h:
3160         * WebKitTestRunner/TestController.cpp:
3161         (WTR::createOtherPage):
3162         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3163         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3164         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3165
3166 2010-12-13  Sam Weinig  <sam@webkit.org>
3167
3168         Reviewed by Anders Carlsson.
3169
3170         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3171         https://bugs.webkit.org/show_bug.cgi?id=50898
3172
3173         * MiniBrowser/mac/AppDelegate.h:
3174         * MiniBrowser/mac/AppDelegate.m:
3175         * MiniBrowser/mac/BrowserWindowController.h:
3176         * MiniBrowser/mac/BrowserWindowController.m:
3177         * MiniBrowser/win/BrowserView.cpp:
3178         Convert MiniBrowser to not use PageNamespaces.
3179
3180         * TestWebKitAPI/PlatformWebView.h:
3181         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3182         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3183         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3184         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3185         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3186         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3187         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3188         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3189         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3190         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3191         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3192         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3193         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3194         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3195         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3196         Convert TestWebKitAPI to not use PageNamespaces.
3197
3198         * WebKitTestRunner/PlatformWebView.h:
3199         * WebKitTestRunner/TestController.cpp:
3200         * WebKitTestRunner/TestController.h:
3201         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3202         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3203         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3204         Convert WebKitTestRunner to not use PageNamespaces.
3205
3206 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3207
3208         Reviewed by Eric Seidel.
3209
3210         webkit-patch rollout should be able to do multi-revision rollouts
3211         https://bugs.webkit.org/show_bug.cgi?id=33336
3212
3213         Make it possible to pass more than one revision to webkit-patch.
3214
3215         * Scripts/webkitpy/common/checkout/api.py:
3216         * Scripts/webkitpy/common/checkout/changelog.py:
3217         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3218         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3219         * Scripts/webkitpy/tool/commands/download.py:
3220         * Scripts/webkitpy/tool/commands/download_unittest.py:
3221         * Scripts/webkitpy/tool/mocktool.py:
3222         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3223         * Scripts/webkitpy/tool/steps/revertrevision.py:
3224
3225 2010-12-13  Eric Seidel  <eric@webkit.org>
3226
3227         Unreviewed.
3228
3229         Teach webkit-patch how to search bugzilla
3230         https://bugs.webkit.org/show_bug.cgi?id=50500
3231
3232         webkit-patch bug-search fails when there is only one result.
3233         Turns out we needed a bit more logic in our result count parsing code.
3234
3235         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3236         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3237
3238 2010-12-13  Antti Koivisto  <antti@apple.com>
3239
3240         Reviewed by Alexey Proskuryakov.
3241
3242         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3243         https://bugs.webkit.org/show_bug.cgi?id=50758
3244
3245         * DumpRenderTree/LayoutTestController.cpp:
3246         (setSerializeHTTPLoadsCallback):
3247         (LayoutTestController::staticFunctions):
3248         * DumpRenderTree/LayoutTestController.h:
3249         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3250         (LayoutTestController::setSerializeHTTPLoads):
3251         * DumpRenderTree/mac/DumpRenderTree.mm:
3252         (resetDefaultsToConsistentValues):
3253         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3254         (LayoutTestController::setSerializeHTTPLoads):
3255         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3256         (LayoutTestController::setSerializeHTTPLoads):
3257
3258 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3259
3260         Reviewed by Ojan Vafai.
3261
3262         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3263         https://bugs.webkit.org/show_bug.cgi?id=50936
3264
3265         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3266
3267 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3268
3269         Reviewed by Csaba Osztrogonác.
3270
3271         Add revlink to BuildBot status
3272         https://bugs.webkit.org/show_bug.cgi?id=50914
3273
3274         This adds a hyperlink to trac changeset on the revision numbers. 
3275
3276         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3277
3278 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3279
3280         Reviewed by Csaba Osztrogonác.
3281
3282         [Qt][WK2] Fix build if WebKitTools are not available
3283         https://bugs.webkit.org/show_bug.cgi?id=50242
3284
3285         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3286         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3287         * MiniBrowser/DerivedSources.pro: Added.
3288
3289 2010-12-13  Eric Seidel  <eric@webkit.org>
3290
3291         Reviewed by Adam Barth.
3292
3293         EWS Queues should remove orpahned pyc files before starting
3294         https://bugs.webkit.org/show_bug.cgi?id=50904
3295
3296         A previous check added a platform.py which caused
3297         EWS bots on some platforms to hit an import exception.
3298         The platform.py file was removed in a subsequent commit, but
3299         the EWS bots in question stayed stuck.  This change will
3300         fix those bots once restarted (and prevent this in the future).
3301
3302         I also went ahead and unified start-queue and start-commit-queue
3303         since they were nearly identical.  I also added bot_id support
3304         to both force all EWSes to have bot ids as well as get rid of the one
3305         remaining reason why I had my own copies of these scripts.
3306         Hopefully this will be enough to get all the other bot admins
3307         (ahem, Adam, ahem) to move to using these checked in copies as well.
3308
3309         * EWSTools/start-commit-queue.sh: Removed.
3310         * EWSTools/start-queue.sh:
3311
3312 2010-10-28  MORITA Hajime  <morrita@google.com>
3313
3314         Reviewed by Ojan Vafai.
3315
3316         spellcheck does not check pasted text
3317         https://bugs.webkit.org/show_bug.cgi?id=40092
3318
3319         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3320         to control the setting.
3321
3322         * DumpRenderTree/LayoutTestController.cpp:
3323         (setAsynchronousSpellCheckingEnabledCallback):
3324         (LayoutTestController::staticFunctions):
3325         * DumpRenderTree/LayoutTestController.h:
3326         * DumpRenderTree/chromium/LayoutTestController.h:
3327         * DumpRenderTree/chromium/LayoutTestController.cpp:
3328         (LayoutTestController::LayoutTestController):
3329         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3330         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3331         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3332         * DumpRenderTree/mac/DumpRenderTree.mm:
3333         (resetDefaultsToConsistentValues):
3334         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3335         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3336         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3337         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3338         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3339         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3340         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3341         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3342         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3343
3344 2010-12-12  Sam Weinig  <sam@webkit.org>
3345
3346         Reviewed by Anders Carlsson.
3347
3348         Fix failing API test. It turns out that a pop-state event
3349         is sent before every fragment navigation, so we have to test
3350         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3351
3352         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3353         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3354
3355 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3356
3357         Reviewed by Eric Seidel.
3358
3359         [GTK] Add new-run-webkit-tests support to gtk
3360         https://bugs.webkit.org/show_bug.cgi?id=50681
3361
3362         Adding the basic support to run the new-run-webkit-tests.
3363
3364         * Scripts/webkitpy/layout_tests/port/gtk.py:
3365
3366 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3367
3368         Reviewed by Kenneth Rohde Christiansen.
3369
3370         [Qt] Mock DeviceOrientation client for DRT
3371         https://bugs.webkit.org/show_bug.cgi?id=47490
3372
3373         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3374         (WebCore::DumpRenderTree::DumpRenderTree):
3375         (WebCore::DumpRenderTree::~DumpRenderTree):
3376         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3377         (LayoutTestController::setMockDeviceOrientation):
3378
3379 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3380
3381         Reviewed by Gustavo Noronha Silva.
3382
3383         [GTK] launcher: disable the Mozilla-style fullscreen API
3384         https://bugs.webkit.org/show_bug.cgi?id=50874
3385
3386         Disabling the fullscreen API until its implementation for GTK is
3387         mature enough. The webview setting for it is already FALSE by
3388         default.
3389
3390         * GtkLauncher/main.c:
3391         (createWindow):
3392
3393 2010-12-10  Eric Seidel  <eric@webkit.org>
3394
3395         Reviewed by Adam Barth.
3396
3397         commit-queue flaky test messages show cryptic version information for mac os x
3398         https://bugs.webkit.org/show_bug.cgi?id=50864
3399
3400         Turns out platform.platform() returns kernel version information
3401         which isn't helpful, and just plain confusing on Mac
3402         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3403
3404         So I've updated PlatformInfo.display_name() to special case
3405         mac.  I also found a bad use of sys.platform in the process
3406         and fixed that.  (sys.platform always returns 'darwin' on mac).
3407
3408         * Scripts/webkitpy/common/system/platforminfo.py:
3409         * Scripts/webkitpy/common/system/user.py:
3410         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3411         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3412         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3413
3414 2010-12-10  Eric Seidel  <eric@webkit.org>
3415
3416         Unreviewed.
3417
3418         Exception seen while reporting flaky test with commit-queue.
3419         Just a missing include.
3420
3421         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3422         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3423
3424 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3425
3426         Reviewed by Eric Seidel.
3427
3428         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3429         https://bugs.webkit.org/show_bug.cgi?id=50796
3430
3431         Also updating the test code to use JSONResultsGeneratorBase and
3432         to improve test coverage for incremental cases.
3433
3434         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3435         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3436
3437 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3438
3439         Reviewed by Darin Adler.
3440
3441         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3442         https://bugs.webkit.org/show_bug.cgi?id=50835
3443
3444         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3445
3446 2010-12-10  Eric Seidel  <eric@webkit.org>
3447
3448         Reviewed by Adam Barth.
3449
3450         Bugs created by the commit-queue should all block on a master bug
3451         https://bugs.webkit.org/show_bug.cgi?id=50857
3452
3453         This makes all bugs created by the commit-queue block on:
3454         https://bugs.webkit.org/show_bug.cgi?id=50856
3455
3456         In the process of testing this, I found that the existing
3457         create_bug code was wrong.  I also found that existing
3458         unit tests for create-rollout used invalid values
3459         for options.blocks.  I fixed both issues and tested.
3460
3461         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3462         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3463         * Scripts/webkitpy/tool/commands/commandtest.py:
3464         * Scripts/webkitpy/tool/commands/download_unittest.py:
3465         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3466         * Scripts/webkitpy/tool/mocktool.py:
3467         * Scripts/webkitpy/tool/steps/options.py:
3468
3469 2010-12-10  Eric Seidel  <eric@webkit.org>
3470
3471         Reviewed by Adam Barth.
3472
3473         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3474         https://bugs.webkit.org/show_bug.cgi?id=50853
3475
3476         I also discovered when doing this that the code was posting
3477         the comment on the wrong bug, but that's fixed here too.
3478
3479         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3480         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3481         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3482         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3483         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3484         * Scripts/webkitpy/tool/mocktool.py:
3485
3486 2010-12-10  Anders Carlsson  <andersca@apple.com>
3487
3488         Reviewed by John Sullivan.
3489
3490         Make WKContextGetStatistics gather global statistics
3491         https://bugs.webkit.org/show_bug.cgi?id=50850
3492
3493         Remove the code that gets the statistics and fills in the per context
3494         statistics information for now.
3495
3496         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3497         (-[BrowserStatisticsWindowController refreshStatistics:]):
3498
3499 2010-12-10  Eric Seidel  <eric@webkit.org>
3500
3501         Unreviewed.
3502
3503         commit-queue should report port/platform information when commenting on flaky test bugs
3504         https://bugs.webkit.org/show_bug.cgi?id=50839
3505
3506         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3507         which was only used by new run webkit tests (and clearly not unit tested).
3508
3509         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3510         * Scripts/webkitpy/tool/main.py:
3511         * Scripts/webkitpy/tool/mocktool.py:
3512
3513 2010-12-10  Eric Seidel  <eric@webkit.org>
3514
3515         Reviewed by Tony Chang.
3516
3517         commit-queue should report port/platform information when commenting on flaky test bugs
3518         https://bugs.webkit.org/show_bug.cgi?id=50839
3519
3520         This was a suggestion from Tony Chang this morning.
3521         I added a platform.py class so I could easily mock the platform call,
3522         but that may not be the final solution for this mocking.
3523         We'll try it and see.
3524
3525         * Scripts/webkitpy/common/system/platform.py: Added.
3526         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3527         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3528         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3529         * Scripts/webkitpy/tool/main.py:
3530         * Scripts/webkitpy/tool/mocktool.py:
3531
3532 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3533
3534         Reviewed by Joseph Pecoraro.
3535
3536         Bug 43455 - [Qt]: Implement Application Cache Quotas
3537         https://bugs.webkit.org/show_bug.cgi?id=43455
3538
3539         Introduce functions to allow new appcache layout test origin-quota.html
3540         to work correctly under Qt.
3541
3542         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3543         (WebCore::DumpRenderTree::DumpRenderTree):
3544         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3545         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3546
3547         Introduce functions to allow new appcache layout test origin-quota.html
3548         to be successful under qt. Changes required because LayoutTestControllerQt
3549         does not inherit from LayoutController.
3550
3551         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3552         (LayoutTestController::reset):
3553         (LayoutTestController::clearAllApplicationCaches):
3554         (LayoutTestController::setApplicationCacheOriginQuota):
3555         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3556         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3557         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3558
3559 2010-12-10  Eric Seidel  <eric@webkit.org>
3560
3561         Reviewed by Adam Barth.
3562
3563         Move buildbot.py into its own module so we can split it out into one-file-per-class
3564         https://bugs.webkit.org/show_bug.cgi?id=50806
3565
3566         We're adding more buildbot logic these days, so it makes sense
3567         to give buildbot its own module.
3568
3569         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3570         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3571         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3572         * Scripts/webkitpy/common/net/failuremap.py:
3573         * Scripts/webkitpy/common/net/regressionwindow.py:
3574         * Scripts/webkitpy/tool/commands/rebaseline.py:
3575
3576 2010-12-10  Tony Chang  <tony@chromium.org>
3577
3578         Reviewed by Eric Seidel.
3579
3580         Use FileSystem::remove when cleaning up http lock files
3581         https://bugs.webkit.org/show_bug.cgi?id=50830
3582
3583         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3584
3585 2010-12-10  Joone Hur  <joone@kldp.org>
3586
3587         Reviewed by Martin Robinson.
3588
3589         [GTK] DRT needs layoutTestController.setCacheModel
3590         https://bugs.webkit.org/show_bug.cgi?id=50705
3591         
3592         webkit_set_cache_mode() is called to set the cache model.
3593         
3594         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3595         (LayoutTestController::setCacheModel): Set the cache model. 
3596
3597 2010-12-10  Tony Chang  <tony@chromium.org>
3598
3599         Reviewed by Ojan Vafai.
3600
3601         [chromium] remove --use-drt and add --use-test-shell
3602         https://bugs.webkit.org/show_bug.cgi?id=50701
3603
3604         * Scripts/webkitpy/common/config/ports.py:
3605         * Scripts/webkitpy/common/config/ports_unittest.py:
3606         * Scripts/webkitpy/layout_tests/port/chromium.py:
3607         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3608         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3609         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3610         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3611         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3612         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3613         * Scripts/webkitpy/layout_tests/port/webkit.py:
3614         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3615         * Scripts/webkitpy/style/checkers/test_expectations.py:
3616         * Scripts/webkitpy/tool/commands/queries.py:
3617
3618 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3619
3620         Reviewed by Steve Block.
3621
3622         [Chromium] Implement mocks for client-based geolocation
3623         https://bugs.webkit.org/show_bug.cgi?id=46895
3624
3625         * DumpRenderTree/chromium/LayoutTestController.cpp:
3626         (LayoutTestController::setGeolocationPermission):
3627         (LayoutTestController::setMockGeolocationPosition):
3628         (LayoutTestController::setMockGeolocationError):
3629         * DumpRenderTree/chromium/LayoutTestController.h:
3630         * DumpRenderTree/chromium/WebViewHost.cpp:
3631         (WebViewHost::geolocationClient):
3632         (WebViewHost::geolocationClientMock):
3633         (WebViewHost::reset):
3634         * DumpRenderTree/chromium/WebViewHost.h:
3635
3636 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3637
3638         Reviewed by Martin Robinson.
3639
3640         [GTK] Add hasSpellingMarker support to the DRT
3641         https://bugs.webkit.org/show_bug.cgi?id=50739
3642
3643         Implemented the hasSpellingMarker to support spelling tests.
3644
3645         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3646         (LayoutTestController::hasSpellingMarker):