[WPE] Enable web process sandbox
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [WPE] Enable web process sandbox
4         https://bugs.webkit.org/show_bug.cgi?id=195169
5
6         Reviewed by Daniel Bates.
7
8         * wpe/install-dependencies:
9         * wpe/jhbuild.modules:
10
11 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-app] Use port 17000 for worker communication
14         https://bugs.webkit.org/show_bug.cgi?id=195558
15
16         Reviewed by Lucas Forschler.
17
18         * BuildSlaveSupport/ews-build/master.cfg:
19
20 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
21
22         [ews-build] unit-tests fail when passwords.json is missing
23         https://bugs.webkit.org/show_bug.cgi?id=195557
24
25         Reviewed by Lucas Forschler.
26
27         * BuildSlaveSupport/ews-build/loadConfig.py:
28         (loadBuilderConfig):
29         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
30         (ConfigDotJSONTest.test_configuration):
31         * BuildSlaveSupport/ews-build/master.cfg:
32
33 2019-03-11  Truitt Savell  <tsavell@apple.com>
34
35         Unreviewed, rolling out r242702.
36
37         Broke High Sierra builders.
38
39         Reverted changeset:
40
41         "Add utility function to allow easy reverse range-based
42         iteration of a container"
43         https://bugs.webkit.org/show_bug.cgi?id=195542
44         https://trac.webkit.org/changeset/242702
45
46 2019-03-11  Sam Weinig  <sam@webkit.org>
47
48         Add utility function to allow easy reverse range-based iteration of a container
49         https://bugs.webkit.org/show_bug.cgi?id=195542
50
51         Reviewed by Antti Koivisto.
52
53         * TestWebKitAPI/CMakeLists.txt:
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
56         (TestWebKitAPI::TEST):
57         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
58
59 2019-03-10  Alex Christensen  <achristensen@webkit.org>
60
61         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
62         https://bugs.webkit.org/show_bug.cgi?id=195511
63         <rdar://problem/44873269>
64
65         Reviewed by Darin Adler.
66
67         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
68         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
69         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
70         (TEST_F):
71
72 2019-03-10  Tim Horton  <timothy_horton@apple.com>
73
74         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
75         https://bugs.webkit.org/show_bug.cgi?id=195499
76
77         Reviewed by Darin Adler.
78
79         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
80         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
81         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
82         (-[WKWebView synchronouslyFocusTextInputContext:]):
83         (applyStyle):
84         (applyIframe):
85         (TEST):
86         Add some tests for this SPI.
87
88 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
89
90         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
91         https://bugs.webkit.org/show_bug.cgi?id=181151
92
93         Reviewed by Don Olmstead.
94
95         * TestWebKitAPI/CMakeLists.txt:
96         * TestWebKitAPI/PlatformWin.cmake:
97         Enable TestWTF RunLoop tests in all platforms.
98
99         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
100         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
101         (TestWebKitAPI::DerivedOneShotTimer::fired):
102         (TestWebKitAPI::TEST):
103         Only a few platforms support nested RunLoop.
104
105         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
106         (TestWebKitAPI::DerivedRepeatingTimer::fired):
107
108 2019-03-10  David Quesada  <david_quesada@apple.com>
109
110         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
111         https://bugs.webkit.org/show_bug.cgi?id=152480
112
113         Reviewed by Chris Dumez.
114
115         Add a unit test based on Daniel Bates's test case that starts a download, ensures
116         there are no additional references to the process pool besides the one held by
117         the download, waits for the download to finish (in the sense that the
118         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
119         measure, also check that the process pool has been deallocated at the end of the
120         test. The test wouldn't be meaningful if the process pool were still alive.
121
122         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
123         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
124         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
125             The download will be canceled because the delegate does not implement the
126             method to decide the download's destination, so this is where we know the
127             DownloadProxyMap is done with the DownloadProxy.
128         (TEST):
129
130 2019-03-08  Chris Dumez  <cdumez@apple.com>
131
132         Add support for Device Orientation / Motion permission API
133         https://bugs.webkit.org/show_bug.cgi?id=195329
134         <rdar://problem/47645367>
135
136         Reviewed by Geoffrey Garen.
137
138         Add test infrastructure to help test the Device Orientation / Motion permission API.
139
140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
141         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
142         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
144         * WebKitTestRunner/TestController.cpp:
145         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
146         (WTR::TestController::createWebViewWithOptions):
147         (WTR::TestController::resetStateToConsistentValues):
148         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
149         * WebKitTestRunner/TestController.h:
150         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
151         * WebKitTestRunner/TestInvocation.cpp:
152         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
153
154 2019-03-08  Saam barati  <sbarati@apple.com>
155
156         Add a compare-results script to compare benchmark results
157         https://bugs.webkit.org/show_bug.cgi?id=195486
158         <rdar://problem/48723397>
159
160         Reviewed by Geoffrey Garen.
161
162         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
163         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
164         to extend it to learn about our other benchmarks.
165
166         * Scripts/compare-results: Added.
167         (readJSONFile):
168         (detectJetStream2):
169         (JetStream2Results):
170         (detectSpeedometer2):
171         (Speedometer2Results):
172         (detectPLT5):
173         (PLT5Results):
174         (detectBenchmark):
175         (biggerIsBetter):
176         (ttest):
177         (getOptions):
178         (main):
179
180 2019-03-08  Stephanie Lewis  <slewis@apple.com>
181
182         Ensure old tab state is cleared between iterations of run-benchmark
183         https://bugs.webkit.org/show_bug.cgi?id=195393
184         <rdar://problem/46885583>
185
186         Reviewed by Dewei Zhu.
187
188         a) ensure the default to restore state is not set
189         b) terminate Safari correctly
190         c) Set the system default to ignore Persistent State in Safari
191
192         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
193         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
194         (OSXBrowserDriver.prepare_env): 
195         (OSXBrowserDriver.restore_env):
196         (OSXBrowserDriver.close_browsers):
197         (OSXBrowserDriver._terminate_processes):
198         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
199         (OSXChromeDriver):
200         (OSXChromeCanaryDriver):
201         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
202         (OSXFirefoxDriver):
203         (OSXFirefoxNightlyDriver):
204         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
205         (OSXSafariDriver):
206         (OSXSafariDriver.prepare_env):
207
208 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
209
210         [GTK] Several InputMethodFilter tests are failing
211         https://bugs.webkit.org/show_bug.cgi?id=195408
212
213         Reviewed by Carlos Garcia Campos.
214
215         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
216         Regressed in r241751.
217         Hexadecimal values of keycodes are expressed now in upper letters.
218         Composited characters should be cast to UTF8 strings.
219
220         (TestWebKitAPI::TEST):
221
222 2019-03-07  Tomas Popela  <tpopela@redhat.com>
223
224         [GTK] Make Tools/gtkdoc python3 compatible
225         https://bugs.webkit.org/show_bug.cgi?id=195359
226
227         Reviewed by Carlos Garcia Campos.
228
229         * gtkdoc/generate-gtkdoc:
230         ConfigParser was reworked in Python 3.2 so we have adapt the code to
231         work with Python 2 and 3.
232         (get_gtkdoc_module_paths):
233         The iteritems() was removed in Python 3, so let's use items() that's
234         available in Python 2 and 3.
235         (get_generator_for_config):
236         * gtkdoc/gtkdoc.py:
237         (GTKDoc._run_command):
238         The sys.stdout.write() is expecting str in Python 3 and not bytes
239         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
240         for passing the bytes there.
241
242 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
243
244         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
245         https://bugs.webkit.org/show_bug.cgi?id=195346
246         <rdar://problem/48667048>
247
248         Unreviewed build fix for clang-cl.
249
250         * DumpRenderTree/win/DumpRenderTree.cpp:
251         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
252
253 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
254
255         requestAnimationFrame should execute before the next frame
256         https://bugs.webkit.org/show_bug.cgi?id=177484
257
258         Reviewed by Simon Fraser.
259
260         Add trace points for the page RenderingUpdate.
261
262         * Tracing/SystemTracePoints.plist:
263
264 2019-03-07  Zalan Bujtas  <zalan@apple.com>
265
266         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
267         https://bugs.webkit.org/show_bug.cgi?id=195353
268         <rdar://problem/48626394>
269
270         Reviewed by Simon Fraser.
271
272         * WebKitTestRunner/ios/TestControllerIOS.mm:
273         (WTR::TestController::platformResetPreferencesToConsistentValues):
274
275 2019-03-07  John Wilander  <wilander@apple.com>
276
277         Resource Load Statistics: Make it possible to purge only script-accessible cookies
278         https://bugs.webkit.org/show_bug.cgi?id=195383
279         <rdar://problem/48570136>
280
281         Reviewed by Brent Fulgham.
282
283         This patch adds test infrastructure to purge only script-accessible cookies,
284         including a new testRunner function called statisticsDeleteCookiesForHost().git a
285
286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
287         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
288         (WTR::TestRunner::statisticsDeleteCookiesForHost):
289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
290         * WebKitTestRunner/TestController.cpp:
291         (WTR::TestController::statisticsDeleteCookiesForHost):
292         * WebKitTestRunner/TestController.h:
293         * WebKitTestRunner/TestInvocation.cpp:
294         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
295
296 2019-03-07  Commit Queue  <commit-queue@webkit.org>
297
298         Unreviewed, rolling out r242354.
299         https://bugs.webkit.org/show_bug.cgi?id=195402
300
301         breaks layout tests in all configurations (Requested by
302         zdobersek on #webkit).
303
304         Reverted changeset:
305
306         "[WPE] Enable web process sandbox"
307         https://bugs.webkit.org/show_bug.cgi?id=195169
308         https://trac.webkit.org/changeset/242354
309
310 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
311
312         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
313         https://bugs.webkit.org/show_bug.cgi?id=195346
314
315         Reviewed by Fujii Hironori.
316
317         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
318         (TestWebKitAPI::TEST):
319         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
320
321         * DumpRenderTree/win/DumpRenderTree.cpp:
322         (findFontFallback):
323         (addFontFallbackIfPresent):
324         (removeFontFallbackIfPresent):
325         (main):
326         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
327         (TestWebKitAPI::Util::moduleDirectory):
328         (TestWebKitAPI::Util::createInjectedBundlePath):
329         Use wchar helpers as needed.
330
331 2019-03-06  Rob Buis  <rbuis@igalia.com>
332
333         Consider supporting the `referrerpolicy` attribute.
334         https://bugs.webkit.org/show_bug.cgi?id=179053
335
336         Reviewed by Darin Adler.
337
338         Add a runtime flag for referrerpolicy attribute.
339
340         * DumpRenderTree/mac/DumpRenderTree.mm:
341         (enableExperimentalFeatures):
342
343 2019-03-05  Daniel Bates  <dabates@apple.com>
344
345         Update expected API test result following r242379
346         (https://bugs.webkit.org/show_bug.cgi?id=195125)
347
348         Update expected x-coordinate of selection rect now that the left padding of
349         a textarea is sized in ems (so dependent on the font size) just like the left
350         padding of a text field.
351
352         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
353         (TestWebKitAPI::TEST):
354
355 2019-03-05  David Quesada  <david_quesada@apple.com>
356
357         [WK2] It should be possible to follow links with 'download' attributes
358         https://bugs.webkit.org/show_bug.cgi?id=195145
359         rdar://problem/48462642
360
361         Reviewed by Alex Christensen.
362
363         Add a unit test to verify that activating links with 'download' attributes now
364         navigates to the linked resource, rather than starts downloading it. Add another
365         to verify that it is still possible to explicitly download the link via the
366         'Download' navigation action policy.
367
368         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
369         (-[DownloadAttributeTestDelegate init]):
370         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
371         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
372         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
373         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
374         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
375         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
376         (TEST):
377         * WebKitTestRunner/TestController.cpp:
378         (WTR::TestController::decidePolicyForNavigationAction):
379         * WebKitTestRunner/TestController.h:
380
381 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
382
383         [Curl] Implement Cookie Accept Policy.
384         https://bugs.webkit.org/show_bug.cgi?id=191645
385
386         Reviewed by Fujii Hironori.
387
388         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
389         (TestWebKitAPI::Curl::TEST_F):
390
391 2019-03-05  Youenn Fablet  <youenn@apple.com>
392
393         Rename requestCacheStorageSpace to requestStorageSpace
394         https://bugs.webkit.org/show_bug.cgi?id=195282
395
396         Reviewed by Chris Dumez.
397
398         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
399         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
400         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
401
402 2019-03-05  Brady Eidson  <beidson@apple.com>
403
404         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
405         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
406
407         Reviewed by Tim Horton.
408
409         Loading a file: URL into a WKWebView and then loading another file: url from a completely
410         different directory into that same WKWebView should work.
411
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
413         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
414
415 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
416
417         Add WeakHashSet
418         https://bugs.webkit.org/show_bug.cgi?id=195152
419
420         Reviewed by Antti Koivisto.
421
422         Added tests for WeakHashSet.
423
424         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
425         (TestWebKitAPI::Base::Base): Moved.
426         (TestWebKitAPI::Derived::foo): Moved.
427         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
428         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
429         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
430         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
431
432 2019-03-04  Chris Dumez  <cdumez@apple.com>
433
434         Do not share WebProcesses between private and regular sessions
435         https://bugs.webkit.org/show_bug.cgi?id=195189
436         <rdar://problem/48421064>
437
438         Reviewed by Alex Christensen.
439
440         Add API test coverage.
441
442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
443         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
444
445 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
446
447         [WPE] Enable web process sandbox
448         https://bugs.webkit.org/show_bug.cgi?id=195169
449
450         Reviewed by Daniel Bates.
451
452         * wpe/install-dependencies:
453         * wpe/jhbuild.modules:
454
455 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
456
457         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
458         https://bugs.webkit.org/show_bug.cgi?id=195206
459
460         Reviewed by Žan Doberšek.
461
462         Add a new test case.
463
464         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
465         (testJSCClass):
466
467 2019-03-04  Charlie Turner  <cturner@igalia.com>
468
469         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
470         https://bugs.webkit.org/show_bug.cgi?id=194898
471
472         Reviewed by Žan Doberšek.
473
474         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
475         a GCC extension that permits arithmetic on void* pointer. Inline
476         the macro until this issue is fixed upstream.
477
478 2019-03-03  Tim Horton  <timothy_horton@apple.com>
479
480         Rid the world of WK_API_ENABLED
481         https://bugs.webkit.org/show_bug.cgi?id=195263
482
483         Reviewed by Dan Bernstein.
484
485         List of changed files elided because it's useless.
486
487 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
488
489         Unreviewed follow-up to r242292.
490
491         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
492
493         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
494         (TestWebKitAPI::testStrip): Renamed from strip.
495         (TestWebKitAPI::TEST):
496
497 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
498
499         Unreviewed, remove accidentally-committed URLHelpers.cpp test
500
501         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
502         and bug #194272 for details.
503
504         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
505
506 2019-03-03  Tim Horton  <timothy_horton@apple.com>
507
508         Remove some more unused 32-bit code
509         https://bugs.webkit.org/show_bug.cgi?id=195255
510
511         Reviewed by Darin Adler.
512
513         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
514         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
515         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
516         (NPP_New):
517         (NPP_HandleEvent):
518         (handleEventCarbon): Deleted.
519
520 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
521
522         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
523
524         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
525         (TestWebKitAPI::TEST):
526
527 2019-03-01  Darin Adler  <darin@apple.com>
528
529         Finish removing String::format
530         https://bugs.webkit.org/show_bug.cgi?id=194893
531
532         Reviewed by Daniel Bates.
533 '
534         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
535
536 2019-03-01  Alex Christensen  <achristensen@webkit.org>
537
538         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
539         https://bugs.webkit.org/show_bug.cgi?id=195229
540         <rdar://problem/48520362>
541
542         Reviewed by Chris Dumez.
543
544         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
545         (TEST):
546
547 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
548
549         Add a system trace scope for event region building
550         https://bugs.webkit.org/show_bug.cgi?id=195226
551
552         Reviewed by Jon Lee.
553
554         This trace scope measures the time spend converting element rects into Region objects,
555         which can be large on some pages.
556
557         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
558
559         * Tracing/SystemTracePoints.plist:
560
561 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
562
563         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
564         https://bugs.webkit.org/show_bug.cgi?id=194612
565
566         Reviewed by Alex Christensen.
567
568         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
569         Just test the new string-processing function and don't touch the actual environment.
570         (Test cases are all as before, but based on operator== instead of strcmp.)
571
572 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
573
574         [ews-app] Update primary keys for handling multiple Buildbot instances
575         https://bugs.webkit.org/show_bug.cgi?id=195120
576
577         Reviewed by Stephanie Lewis.
578
579         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
580         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
581         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
582
583         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
584         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
585         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
586         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
587         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
588         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
589
590 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
591
592         [WinCairo] Enable service worker
593         https://bugs.webkit.org/show_bug.cgi?id=188318
594
595         Reviewed by Youenn Fablet.
596
597         * DumpRenderTree/DumpRenderTreePrefix.h:
598         * TestWebKitAPI/PlatformWin.cmake:
599         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
600         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
601         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
602
603 2019-03-01  Justin Fan  <justin_fan@apple.com>
604
605         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
606         https://bugs.webkit.org/show_bug.cgi?id=195191
607
608         Rubber-stamped by Dean Jackson.
609
610         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
611
612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
613
614 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
615
616         Unreviewed, fix lldb webkitpy tests
617         https://bugs.webkit.org/show_bug.cgi?id=194375
618
619         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
620
621         * lldb/lldb_webkit.py:
622         (WTFStringImplProvider.is_8bit):
623
624 2019-02-28  David Quesada  <david_quesada@apple.com>
625
626         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
627         https://bugs.webkit.org/show_bug.cgi?id=195121
628         rdar://problem/48450302
629
630         Reviewed by Alex Christensen.
631
632         Add API tests for -WKNavigationAction._shouldPerformDownload in various
633         configurations where the 'download' attribute is absent, blank, or populated
634         with a filename, and where the anchor element is same-origin or cross-origin
635         (meaning the 'download' attribute shouldn't be honored).
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
639         (-[NavigationActionTestDelegate init]):
640         (-[NavigationActionTestDelegate navigationAction]):
641         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
642         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
643         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
644         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
645         (TEST):
646
647 2019-02-28  Antoine Quint  <graouts@apple.com>
648
649         Enable the Pointer Events runtime flag by default
650         https://bugs.webkit.org/show_bug.cgi?id=195156
651
652         Reviewed by Dean Jackson.
653
654         * DumpRenderTree/mac/DumpRenderTree.mm:
655         (enableExperimentalFeatures):
656
657 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
658
659         Several PasteImage API tests are flaky
660         https://bugs.webkit.org/show_bug.cgi?id=195160
661
662         Reviewed by Tim Horton.
663
664         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
665         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
666         listening for a "load" event after image load is already complete.
667
668         To address this, make these tests first register a "load" event handler, then run script to insert an image
669         element into the document, and finally wait until the load event is observed before checking image size.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
672
673 2019-02-28  Chris Dumez  <cdumez@apple.com>
674
675         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
676         https://bugs.webkit.org/show_bug.cgi?id=195107
677
678         Reviewed by Alex Christensen.
679
680         Give some time for the zoom level to get restored.
681
682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
683
684 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
685
686         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
687         https://bugs.webkit.org/show_bug.cgi?id=194958
688
689         Reviewed by Geoffrey Garen.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
692         (TEST):
693
694 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
695
696         [ews-app] Update method to save build to handle builder_display_name
697         https://bugs.webkit.org/show_bug.cgi?id=195047
698
699         Reviewed by Dewei Zhu.
700
701         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
702         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
703
704 2019-02-28  Justin Fan  <justin_fan@apple.com>
705
706         [Web GPU] Enable Web GPU only on 64-bit
707         https://bugs.webkit.org/show_bug.cgi?id=195139
708
709         Because Metal is only supported on 64 bit apps.
710
711         Unreviewed build fix.
712
713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
714
715 2019-02-27  Youenn Fablet  <youenn@apple.com>
716
717         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
718         https://bugs.webkit.org/show_bug.cgi?id=194959
719
720         Reviewed by Chris Dumez.
721
722         Spin loop until getting the condition to remove flakiness.
723
724         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
725
726 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-build] Buildbot should include builder_display_name in the build events
729         https://bugs.webkit.org/show_bug.cgi?id=195045
730
731         Reviewed by Dewei Zhu.
732
733         * BuildSlaveSupport/ews-build/events.py:
734         (Events.buildStarted): Included builder_display_name in event data. Also renamed
735         buildername to builder_name to be consistent in naming style.
736         (Events.buildFinished): Ditto.
737
738 2019-02-27  Chris Dumez  <cdumez@apple.com>
739
740         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
741         https://bugs.webkit.org/show_bug.cgi?id=194480
742
743         Reviewed by Brady Eidson.
744
745         Update existing API test to make it more likely to reproduce the issue.
746
747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
748
749 2019-02-27  Brady Eidson  <beidson@apple.com>
750
751         Universal links from Google search results pages don't open the app.
752         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
753
754         Reviewed by Geoffrey Garen.
755
756         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
757         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
758         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
759         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
760
761 2019-02-27  Chris Dumez  <cdumez@apple.com>
762
763         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
764         https://bugs.webkit.org/show_bug.cgi?id=195102
765
766         Reviewed by Geoffrey Garen.
767
768         If the number of processes is not yet what we expect, wait a bit and check again to give
769         processes some time to exit.
770
771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
772
773 2019-02-27  Chris Dumez  <cdumez@apple.com>
774
775         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
776         https://bugs.webkit.org/show_bug.cgi?id=194545
777
778         Reviewed by Brady Eidson.
779
780         Make sure the test navigates forward and then back only once. Previously, navigating
781         back would trigger a navigation again in a timer.
782
783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
784
785 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
786
787         High Sierra Debug JSC test queue should use faster hardware
788         https://bugs.webkit.org/show_bug.cgi?id=194603
789
790         Rubber-stamped by Alexey Proskuryakov.
791
792         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
793
794         * BuildSlaveSupport/build.webkit.org-config/config.json:
795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
796         (BubbleQueueServer):
797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
798         (WebKitBuildbot):
799         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
800         * QueueStatusServer/config/queues.py:
801         * Scripts/webkitpy/common/config/ews.json:
802         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
803         (test_ews_name):
804
805 2019-02-27  John Wilander  <wilander@apple.com>
806
807         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
808         https://bugs.webkit.org/show_bug.cgi?id=195071
809         <rdar://problem/48417690>
810
811         Reviewed by Alex Christensen and Brent Fulgham.
812
813         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
814         (TestWebKitAPI::createURL):
815             Convenience function.
816         (TestWebKitAPI::TEST):
817             WebCore::AdClickAttribution now takes a URL when creating Source and
818             Destination.
819         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
820         (TestWebKitAPI::TEST):
821             WebCore::AdClickAttribution now takes a URL when creating Source and
822             Destination.
823
824 2019-02-27  Antoine Quint  <graouts@apple.com>
825
826         Support Pointer Events on macOS
827         https://bugs.webkit.org/show_bug.cgi?id=195008
828         <rdar://problem/47454419>
829
830         Reviewed by Dean Jackson.
831
832         * DumpRenderTree/mac/DumpRenderTree.mm:
833         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
834         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
835
836 2019-02-26  Mark Lam  <mark.lam@apple.com>
837
838         Remove remaining poisoning code.
839         https://bugs.webkit.org/show_bug.cgi?id=194138
840
841         Reviewed by Saam Barati.
842
843         * TestWebKitAPI/CMakeLists.txt:
844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
845         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
846         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
847         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
848         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
849         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
850         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
851
852 2019-02-26  Alex Christensen  <achristensen@webkit.org>
853
854         Move ephemeral local storage from WebProcess to UIProcess
855         https://bugs.webkit.org/show_bug.cgi?id=195074
856         <rdar://problem/47937975>
857
858         Reviewed by Geoff Garen.
859
860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
861
862 2019-02-20  Jer Noble  <jer.noble@apple.com>
863
864         [Cocoa] Media elements will restart network buffering just before suspending
865         https://bugs.webkit.org/show_bug.cgi?id=193691
866
867         Reviewed by Eric Carlson.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
871         (TEST):
872
873 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
874
875         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
876         https://bugs.webkit.org/show_bug.cgi?id=191652
877
878         Reviewed by Alex Christensen.
879
880         Fix WinCairo MiniBrowser behavior of authentication dialog.
881
882         * MiniBrowser/win/WebKitBrowserWindow.cpp:
883         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
884
885 2019-02-26  Youenn Fablet  <youenn@apple.com>
886
887         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
888         https://bugs.webkit.org/show_bug.cgi?id=195028
889         <rdar://problem/48243733>
890
891         Reviewed by Eric Carlson.
892
893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
894
895 2019-02-26  Philippe Normand  <pnormand@igalia.com>
896
897         [WPE] Add API for webview background color configuration
898         https://bugs.webkit.org/show_bug.cgi?id=192305
899
900         Reviewed by Michael Catanzaro.
901
902         * MiniBrowser/wpe/main.cpp:
903         (main): Add a new option to configure the webview background
904         color. Example: --bg-color=transparent.
905         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
906         (testWebViewBackgroundColor): Enable background color API tests for WPE.
907         (beforeAll): Ditto.
908
909 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
910
911         scalableNativeWebpageParameters() is not preserved on new page navigation.
912         https://bugs.webkit.org/show_bug.cgi?id=194892
913         <rdar://problem/47538280>
914
915         Reviewed by Wenson Hsieh.
916         
917         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
918
919         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
920         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
921         * DumpRenderTree/mac/UIScriptControllerMac.mm:
922         (WTR::UIScriptController::allowsViewportShrinkToFit):
923         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
924         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
925         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
926         * TestRunnerShared/UIScriptContext/UIScriptController.h:
927         * WebKitTestRunner/UIScriptControllerCocoa.mm:
928         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
929
930 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
931
932         [ews-app] Add model for handling multiple Buildbot instances
933         https://bugs.webkit.org/show_bug.cgi?id=194863
934
935         Reviewed by Stephanie Lewis.
936
937         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
938
939 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-app] Remove BuilderMapping table
942         https://bugs.webkit.org/show_bug.cgi?id=194961
943
944         Reviewed by Stephanie Lewis.
945
946         Store builder name directly in build table, instead of having a separate
947         table for it.
948
949         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
950         * BuildSlaveSupport/ews-app/ews/models/build.py:
951         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
952         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
953
954 2019-02-25  John Wilander  <wilander@apple.com>
955
956         Introduce and adopt new class RegistrableDomain for eTLD+1
957         https://bugs.webkit.org/show_bug.cgi?id=194791
958         <rdar://problem/48179240>
959
960         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
961
962         This patch adds an API test and replaces two instances of
963         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
964
965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
966         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
967         (TestWebKitAPI::TEST):
968             Changed two strings to make sure the registrable domains are still considered
969             invalid and pass the test.
970         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
971         (TestWebKitAPI::TEST):
972         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
973         (WTR::InjectedBundle::didReceiveMessageToPage):
974
975 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
976
977         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
978         https://bugs.webkit.org/show_bug.cgi?id=195001
979
980         Reviewed by Carlos Garcia Campos.
981
982         API version 1.0 always includes the functionality previously guarded with
983         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
984         unconditionally.
985
986         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
987         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
988         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
989         (WebViewTest::showInWindow): Ditto.
990         (WebViewTest::hideView): Ditto.
991         * wpe/backends/HeadlessViewBackend.cpp:
992         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
993         * wpe/backends/ViewBackend.cpp:
994         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
995         * wpe/backends/WindowViewBackend.cpp:
996         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
997         WPE_BACKEND_CHECK_VERSION().
998         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
999
1000 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1001
1002         [Flatpak] Add support for flatpak > 1.1.2
1003         https://bugs.webkit.org/show_bug.cgi?id=194088
1004
1005         Flatpak 1.2 is now out so we need to support that
1006         version now.
1007
1008         Reviewed by Michael Catanzaro.
1009
1010         * flatpak/flatpakutils.py:
1011         (check_flatpak):
1012         (FlatpakPackages.__init__):
1013         (FlatpakPackages.__detect_packages):
1014         (FlatpakPackages.__detect_packages.in):
1015         (FlatpakRepos.update):
1016
1017 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1018
1019         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1020         https://bugs.webkit.org/show_bug.cgi?id=194998
1021
1022         Reviewed by Carlos Garcia Campos.
1023
1024         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1025         to a Git checkout and using the latest commit containing various fixes
1026         and improvements.
1027
1028 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1029
1030         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1031         https://bugs.webkit.org/show_bug.cgi?id=194981
1032
1033         Reviewed by Žan Doberšek.
1034
1035         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1036         (TestWebKitAPI::TEST):
1037
1038 2019-02-23  Keith Miller  <keith_miller@apple.com>
1039
1040         Add new mac target numbers
1041         https://bugs.webkit.org/show_bug.cgi?id=194955
1042
1043         Reviewed by Tim Horton.
1044
1045         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1046         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1047         * MiniBrowser/Configurations/Base.xcconfig:
1048         * TestWebKitAPI/Configurations/Base.xcconfig:
1049         * WebKitTestRunner/Configurations/Base.xcconfig:
1050
1051 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1052
1053         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1054         https://bugs.webkit.org/show_bug.cgi?id=194846
1055
1056         Reviewed by Don Olmstead.
1057
1058         Added _search_paths() and _port_specific_expectations_files() for
1059         WinCairoPort.
1060
1061         * Scripts/webkitpy/port/win.py:
1062         (WinCairoPort.default_baseline_search_path):
1063         (WinCairoPort):
1064         (WinCairoPort._port_specific_expectations_files):
1065         (WinCairoPort._search_paths):
1066
1067 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1068
1069         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1070         https://bugs.webkit.org/show_bug.cgi?id=194963
1071
1072         Reviewed by Dean Jackson.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1075         Do a `contains` check instead of `equals`, because in debug builds we
1076         put the GraphicsLayer pointer in a prefix.
1077
1078 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1081         https://bugs.webkit.org/show_bug.cgi?id=194873
1082         <rdar://problem/46701974>
1083
1084         Reviewed by Tim Horton.
1085
1086         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1087
1088         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1089         (WTR::UIScriptController::menuRect const):
1090         (WTR::UIScriptController::isShowingMenu const):
1091         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1092         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1093         (WTR::UIScriptController::menuRect const):
1094
1095         Add a function to query the bounds of the callout menu in content coordinates.
1096
1097         (WTR::UIScriptController::isShowingMenu const):
1098
1099         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1100
1101         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1102         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1103         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1104         (WTR::UIScriptController::rectForMenuAction const):
1105         (WTR::UIScriptController::menuRect const):
1106         (WTR::UIScriptController::isShowingMenu const):
1107         (WTR::findViewInHierarchyOfType): Deleted.
1108
1109 2019-02-22  Chris Dumez  <cdumez@apple.com>
1110
1111         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1112         https://bugs.webkit.org/show_bug.cgi?id=194954
1113         <rdar://problem/48127957>
1114
1115         Reviewed by Alex Christensen.
1116
1117         Add API test coverage.
1118
1119         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1120         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1121         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1122         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1123
1124 2019-02-22  Chris Dumez  <cdumez@apple.com>
1125
1126         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1127         https://bugs.webkit.org/show_bug.cgi?id=194924
1128         <rdar://problem/48216125>
1129
1130         Reviewed by Geoffrey Garen.
1131
1132         Add API test coverage.
1133
1134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1135
1136 2019-02-22  Chris Dumez  <cdumez@apple.com>
1137
1138         Unreviewed, disable API test added in r241928 on iOS.
1139
1140         The cache is not enabled on devices with less than 3GB of RAM.
1141
1142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1143
1144 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1145
1146         Hardcode Visual Viewports on everywhere except iOS WK1
1147         https://bugs.webkit.org/show_bug.cgi?id=194928
1148
1149         Reviewed by Zalan Bujtas.
1150
1151         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1152         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1153         set it to false. The setting has shipped for several years and there's no need to turn
1154         it off now.
1155
1156         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1157         Visual Viewports are not enabled.
1158         
1159         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1160         that only runs in WK2
1161
1162         * MiniBrowser/mac/SettingsController.h:
1163         * MiniBrowser/mac/SettingsController.m:
1164         (-[SettingsController init]):
1165         (-[SettingsController _populateMenu]):
1166         (-[SettingsController validateMenuItem:]):
1167         (-[SettingsController visualViewportEnabled]): Deleted.
1168         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1169         * MiniBrowser/mac/WK1BrowserWindowController.m:
1170         (-[WK1BrowserWindowController didChangeSettings]):
1171         * MiniBrowser/mac/WK2BrowserWindowController.m:
1172         (-[WK2BrowserWindowController didChangeSettings]):
1173
1174 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1175
1176         Discard cached processes when clearing website data store
1177         https://bugs.webkit.org/show_bug.cgi?id=194894
1178
1179         Reviewed by Chris Dumez.
1180
1181         Added a test case.
1182
1183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1184         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1185
1186 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1187
1188         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1189         https://bugs.webkit.org/show_bug.cgi?id=194914
1190         <rdar://problem/47586889>
1191
1192         Reviewed by Geoffrey Garen.
1193
1194         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1195         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1196         (TEST):
1197         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1198
1199 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1200
1201         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1202         <https://webkit.org/b/194761>
1203
1204         Reviewed by Myles Maxfield.
1205
1206         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1207         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1208         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1209         to use ARC-compliant cast.
1210         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1211         ARC-compliant cast.
1212         (WTR::installFakeHelvetica): Log `error` to console if
1213         CTFontManagerRegisterFontsForURL() fails, but only on supported
1214         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1215         Call CFRelease() on `error` to fix the leak.  Update to use
1216         ARC-compliant cast.
1217         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1218         cast.
1219
1220 2019-02-21  Chris Dumez  <cdumez@apple.com>
1221
1222         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1223         https://bugs.webkit.org/show_bug.cgi?id=194481
1224
1225         Reviewed by Alex Christensen.
1226
1227         Give the processes a chance to shutdown and wait until we reached the expected number
1228         of processes.
1229
1230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1231
1232 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1233
1234         Fix the macOS build
1235
1236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1237
1238 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1239
1240         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1243         I am a backwards.
1244
1245 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1246
1247         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1248
1249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1250         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1251         We could force on UI-side compositing, but I feel like the test might be more
1252         valuable exercising the normal path on each platform (though the original
1253         bug was also UI-side specific). Though we can't validate that the overlay
1254         layer was installed successfully, there are layout tests that do that.
1255
1256 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1257
1258         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1259         https://bugs.webkit.org/show_bug.cgi?id=194845
1260         <rdar://problem/47944579>
1261
1262         Reviewed by Antti Koivisto.
1263
1264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1266
1267 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1268
1269         [LFC][Floats] Add support for placing formatting roots in-between floats.
1270         https://bugs.webkit.org/show_bug.cgi?id=194902
1271
1272         Reviewed by Antti Koivisto.
1273
1274         * LayoutReloaded/misc/LFC-passing-tests.txt:
1275
1276 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1277
1278         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1279         https://bugs.webkit.org/show_bug.cgi?id=194901
1280
1281         Unreviewed build fix.
1282
1283         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1284         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1285         WPEBackend-fdo-0.1 as library name.
1286
1287 2019-02-21  Rob Buis  <rbuis@igalia.com>
1288
1289         Update MIME type parser
1290         https://bugs.webkit.org/show_bug.cgi?id=180526
1291
1292         Reviewed by Darin Adler.
1293
1294         Add tests involving leading and trailing whitespace, non-token
1295         characters and quoted strings.
1296
1297         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1298         (TestWebKitAPI::TEST):
1299
1300 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1301
1302         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1303         https://bugs.webkit.org/show_bug.cgi?id=194884
1304
1305         Reviewed by Michael Catanzaro.
1306
1307         * PlatformWin.cmake:
1308
1309 2019-02-20  Chris Dumez  <cdumez@apple.com>
1310
1311         Add API test for <rdar://problem/47471222>
1312         https://bugs.webkit.org/show_bug.cgi?id=194847
1313
1314         Reviewed by Alex Christensen.
1315
1316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1317
1318 2019-02-20  Chris Dumez  <cdumez@apple.com>
1319
1320         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1321         https://bugs.webkit.org/show_bug.cgi?id=194872
1322         <rdar://problem/47924500>
1323
1324         Reviewed by Alex Christensen.
1325
1326         Add API test coverage.
1327
1328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1329
1330 2019-02-20  Jer Noble  <jer.noble@apple.com>
1331
1332         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1333         https://bugs.webkit.org/show_bug.cgi?id=191332
1334
1335         Reviewed by Dean Jackson.
1336
1337         * Scripts/git-is-in-range: Added.
1338
1339 2019-02-20  Andy Estes  <aestes@apple.com>
1340
1341         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1342         https://bugs.webkit.org/show_bug.cgi?id=194869
1343
1344         Rubber-stamped by Jer Noble.
1345
1346         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1347         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1348         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1349         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1351         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1352
1353 2019-02-20  Chris Dumez  <cdumez@apple.com>
1354
1355         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1356         https://bugs.webkit.org/show_bug.cgi?id=194857
1357         <rdar://problem/47759323>
1358
1359         Reviewed by Alex Christensen.
1360
1361         Add API test coverage.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1364
1365 2019-02-20  Chris Dumez  <cdumez@apple.com>
1366
1367         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1368         https://bugs.webkit.org/show_bug.cgi?id=194829
1369         <rdar://problem/47889906>
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         Every time the TestOptions were changing we were creating both a new Web view and
1374         a new WKContext, which would start a new Network process. In most cases, we only
1375         need to contruct a new Web view and we do can keep reusing the same WKContext.
1376         This patch implements this optimization and thus avoids spinning a lot of new
1377         Network processes while running the layout tests.
1378
1379         * WebKitTestRunner/TestController.cpp:
1380         (WTR::TestController::generateContextConfiguration const):
1381         (WTR::TestController::generatePageConfiguration):
1382         (WTR::TestController::createWebViewWithOptions):
1383         (WTR::TestController::resetPreferencesToConsistentValues):
1384         (WTR::updateTestOptionsFromTestHeader):
1385         * WebKitTestRunner/TestController.h:
1386         * WebKitTestRunner/TestOptions.h:
1387         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1388         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1389         (WTR::TestOptions::hasSameInitializationOptions const):
1390         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1391         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1392         (WTR::TestController::platformAddTestOptions const):
1393
1394 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1395
1396         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1397         https://bugs.webkit.org/show_bug.cgi?id=167941
1398
1399         Reviewed by Carlos Garcia Campos.
1400
1401         * MiniBrowser/gtk/main.c:
1402         (filterSavedCallback): Added.
1403         (main): Support loading a JSON rule set file for content filtering.
1404         * MiniBrowser/wpe/main.cpp:
1405         (filterSavedCallback): Added.
1406         (main): Support loading a JSON rule set file for content filtering.
1407         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1408         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1409         (WTF::derefGPtr): Ditto.
1410         (testEmptyStore):
1411         (testSaveInvalidFilter):
1412         (testSaveLoadFilter):
1413         (testSavedFilterIdentifierMatch):
1414         (testRemoveFilter):
1415         (testSaveMultipleFilters):
1416         (testSaveFilterFromFile):
1417         (testFilterPersistence):
1418         (beforeAll):
1419         (afterAll):
1420         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1421         (removeOldInjectedContentAndResetLists): Also reset content filters.
1422         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1423         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1424         the element affected by the style sheet.
1425         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1426         and returns it to be used by tests.
1427         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1428         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1429         (serverCallback): Add support for serving a CSS style sheet for testing.
1430         (beforeAll): Add call to testUserContentManagerContentFilter().
1431         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1432
1433 2019-02-19  Keith Rollin  <krollin@apple.com>
1434
1435         Add timing information to build output
1436         https://bugs.webkit.org/show_bug.cgi?id=194839
1437         <rdar://problem/48219609>
1438
1439         Reviewed by Alexey Proskuryakov.
1440
1441         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1442         emit each project's build time to its output. E.g.,
1443
1444             ** BUILD SUCCEEDED ** [0.132 sec]
1445
1446         * Scripts/webkitdirs.pm:
1447         (XcodeOptions):
1448
1449 2019-02-19  Truitt Savell  <tsavell@apple.com>
1450
1451         Unreviewed, rolling out r241784.
1452
1453         Broke all OpenSource builds.
1454
1455         Reverted changeset:
1456
1457         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1458         instances view"
1459         https://bugs.webkit.org/show_bug.cgi?id=172848
1460         https://trac.webkit.org/changeset/241784
1461
1462 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1463
1464         [LFC][Floats] Remove redundant intersecting logic
1465         https://bugs.webkit.org/show_bug.cgi?id=194804
1466
1467         Reviewed by Antti Koivisto.
1468
1469         * LayoutReloaded/misc/LFC-passing-tests.txt:
1470
1471 2019-02-19  Dean Jackson  <dino@apple.com>
1472
1473         Clean-up output from generate-xcfilelists so it can be filtered
1474         https://bugs.webkit.org/show_bug.cgi?id=194795
1475
1476         Reviewed by Joseph Pecoraro (and Keith Rollin).
1477
1478         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1479         make a slight tweak to filter-build-webkit so such lines are marked
1480         as plain.
1481
1482         * Scripts/filter-build-webkit:
1483         * Scripts/generate-xcfilelists:
1484
1485 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1486
1487         pytest is not correctly auto-installed
1488         https://bugs.webkit.org/show_bug.cgi?id=194707
1489
1490         Reviewed by Carlos Garcia Campos.
1491
1492         * Scripts/webkitpy/thirdparty/__init__.py:
1493         (AutoinstallImportHook._install_pytest):
1494
1495 2019-02-18  Chris Dumez  <cdumez@apple.com>
1496
1497         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1498         https://bugs.webkit.org/show_bug.cgi?id=194797
1499         <rdar://problem/48055151>
1500
1501         Reviewed by Geoffrey Garen.
1502
1503         Add API test coverage.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1506
1507 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1508
1509         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1510         https://bugs.webkit.org/show_bug.cgi?id=194670
1511         <rdar://problem/39066529>
1512
1513         Reviewed by Tim Horton.
1514
1515         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1516         pasted in an editable area as attachment elements.
1517
1518         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1519         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1520         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1521         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1522         (TestWebKitAPI::TEST):
1523         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1524         (WTR::InjectedBundlePage::InjectedBundlePage):
1525
1526 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1527
1528         Fix API test after r241728
1529        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1532         (TEST):
1533         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1534
1535 2019-02-18  Daniel Bates  <dabates@apple.com>
1536
1537         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1538         https://bugs.webkit.org/show_bug.cgi?id=192824
1539         <rdar://problem/47100332>
1540
1541         Reviewed by Wenson Hsieh.
1542
1543         Fix a bug where the wrong usage code was used for F13 thru F24.
1544
1545         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1546         (keyCodeForDOMFunctionKey):
1547
1548 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1549
1550         Bytecode cache should a have a boot-specific validation
1551         https://bugs.webkit.org/show_bug.cgi?id=194769
1552         <rdar://problem/48149509>
1553
1554         Reviewed by Keith Miller.
1555
1556         Add test for WTF::bootSessionUUIDString()
1557
1558         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1559         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1560         (TEST):
1561
1562 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1563
1564         Disable safe browsing in WKWebView and remove its WKPreferences API
1565         https://bugs.webkit.org/show_bug.cgi?id=194723
1566         <rdar://problem/48122993>
1567
1568         Reviewed by Geoffrey Garen.
1569
1570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1571         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1572         (TEST):
1573         (safeBrowsingView):
1574         Make tests use SPI instead of API.
1575
1576 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1577
1578         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1579         https://bugs.webkit.org/show_bug.cgi?id=194586
1580
1581         Reviewed by Ross Kirsling.
1582
1583         * DumpRenderTree/win/DumpRenderTree.cpp:
1584         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1585         * Scripts/webkitpy/port/driver.py:
1586         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1587
1588 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1589
1590         Unreviewed, rolling out r241620.
1591
1592         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1593         (Requested by ddkilzer on #webkit.)
1594
1595         Reverted changeset:
1596
1597         "[WTF] Add environment variable helpers"
1598         https://bugs.webkit.org/show_bug.cgi?id=192405
1599         https://trac.webkit.org/changeset/241620
1600
1601 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1602
1603         [LFC] RenderImage's default intrinsic size is 0.
1604         https://bugs.webkit.org/show_bug.cgi?id=194745
1605
1606         Reviewed by Antti Koivisto.
1607
1608         * LayoutReloaded/misc/LFC-passing-tests.txt:
1609
1610 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1611
1612         [LFC][BFC] Add support for block replaced intrinsic width.
1613         https://bugs.webkit.org/show_bug.cgi?id=194705
1614
1615         Reviewed by Simon Fraser.
1616
1617         * LayoutReloaded/misc/LFC-passing-tests.txt:
1618
1619 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1620
1621         [LFC] Apply min/max width constraints to preferred width computation
1622         https://bugs.webkit.org/show_bug.cgi?id=194739
1623
1624         Reviewed by Simon Fraser.
1625
1626         * LayoutReloaded/misc/LFC-passing-tests.txt:
1627
1628 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1629
1630         [WTF] Add environment variable helpers
1631         https://bugs.webkit.org/show_bug.cgi?id=192405
1632
1633         Reviewed by Michael Catanzaro.
1634
1635         * DumpRenderTree/mac/DumpRenderTree.mm:
1636         (libraryPathForDumpRenderTree):
1637         * DumpRenderTree/win/DumpRenderTree.cpp:
1638         (libraryPathForDumpRenderTree):
1639         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1640         (setUpIOSLayoutTestCommunication):
1641         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1642         (beforeAll):
1643         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1644         (main):
1645         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1646         (WebKitTestBus::run):
1647         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1648         (WTR::getOutputDir):
1649         (WTR::initializeFontConfigSetting):
1650         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1651         (WTR::InjectedBundle::platformInitialize):
1652         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1653         (WTR::topLevelPath):
1654         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1655         (WTR::topLevelPath):
1656         (WTR::getOutputDir):
1657         (WTR::activateFonts):
1658         * WebKitTestRunner/TestController.cpp:
1659         (WTR::TestController::libraryPathForTesting):
1660         (WTR::TestController::generateContextConfiguration const):
1661         (WTR::TestController::generatePageConfiguration):
1662         (WTR::TestController::decideDestinationWithSuggestedFilename):
1663         (WTR::TestController::platformAdjustContext):
1664         * WebKitTestRunner/TestController.h:
1665         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1666         (WTR::TestController::cocoaPlatformInitialize):
1667         (WTR::TestController::platformAdjustContext):
1668         * WebKitTestRunner/gtk/main.cpp:
1669         (main):
1670         * WebKitTestRunner/mac/TestControllerMac.mm:
1671         (WTR::TestController::configureContentExtensionForTest):
1672         * WebKitTestRunner/wpe/main.cpp:
1673         (main):
1674         Utilize WTF::Environment where possible.
1675
1676 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1677
1678         [iOS] WKWebView callout bar is missing Change Writing Direction item
1679         https://bugs.webkit.org/show_bug.cgi?id=190015
1680         <rdar://problem/44810366>
1681
1682         Reviewed by Tim Horton.
1683
1684         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1685         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1686
1687         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1688         (TestWebKitAPI::TEST):
1689
1690 2019-02-15  Chris Dumez  <cdumez@apple.com>
1691
1692         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1693         https://bugs.webkit.org/show_bug.cgi?id=194717
1694         <rdar://problem/47884404>
1695
1696         Reviewed by Brady Eidson.
1697
1698         Add API test coverage.
1699
1700         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1701
1702 2019-02-15  Youenn Fablet  <youenn@apple.com>
1703
1704         Make navigator.mediaDevices SecureContext
1705         https://bugs.webkit.org/show_bug.cgi?id=194666
1706
1707         Reviewed by Eric Carlson.
1708
1709         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1710         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1711         (TEST_F):
1712
1713 2019-02-15  Brian Burg  <bburg@apple.com>
1714
1715         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1716         https://bugs.webkit.org/show_bug.cgi?id=194411
1717         <rdar://problem/47787614>
1718
1719         Reviewed by Joseph Pecoraro.
1720
1721         Remove unnecessary soft linking macro usage.
1722
1723         * DumpRenderTree/mac/TestRunnerMac.mm:
1724         (TestRunner::inspectorTestStubURL):
1725         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1726         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1727         (WTR::TestRunner::inspectorTestStubURL):
1728
1729 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1730
1731         Unreviewed, rolling out r241559 and r241566.
1732         https://bugs.webkit.org/show_bug.cgi?id=194710
1733
1734         Causes layout test crashes under GuardMalloc (Requested by
1735         ryanhaddad on #webkit).
1736
1737         Reverted changesets:
1738
1739         "[WTF] Add environment variable helpers"
1740         https://bugs.webkit.org/show_bug.cgi?id=192405
1741         https://trac.webkit.org/changeset/241559
1742
1743         "Unreviewed build fix for WinCairo Debug after r241559."
1744         https://trac.webkit.org/changeset/241566
1745
1746 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1747
1748         [LFC] Out-of-flow box is never a float box
1749         https://bugs.webkit.org/show_bug.cgi?id=194704
1750
1751         Reviewed by Antti Koivisto.
1752
1753         * LayoutReloaded/misc/LFC-passing-tests.txt:
1754
1755 2019-02-10  Darin Adler  <darin@apple.com>
1756
1757         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1758         https://bugs.webkit.org/show_bug.cgi?id=194487
1759
1760         Reviewed by Daniel Bates.
1761
1762         * DumpRenderTree/win/DumpRenderTree.cpp:
1763         (applicationId): Use makeString instead of String::format.
1764         (main): Ditto.
1765         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1766         (TestWebKitAPI::Util::createURLForResource): Ditto.
1767         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1768         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1769
1770         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1771         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1772         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1773         (WTR::createStringWithAttributes): Use appendLiteral.
1774         (WTR::AccessibilityUIElement::helpText const): Ditto.
1775         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1776         directly instead of using String::format.
1777         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1778         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1779
1780 2019-02-15  Truitt Savell  <tsavell@apple.com>
1781
1782         Unreviewed, rolling out r241564.
1783
1784         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1785
1786         Reverted changeset:
1787
1788         "[Mac] WebInspectorUI.framework does not need to be soft-
1789         linked anymore"
1790         https://bugs.webkit.org/show_bug.cgi?id=194411
1791         https://trac.webkit.org/changeset/241564
1792
1793 2019-02-15  Saam barati  <sbarati@apple.com>
1794
1795         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1796         https://bugs.webkit.org/show_bug.cgi?id=194036
1797
1798         Reviewed by Yusuke Suzuki.
1799
1800         * Scripts/run-jsc-stress-tests:
1801
1802 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1803
1804         Fix the build.
1805
1806         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1807         (WTR::UIScriptController::drawSquareInEditableImage):
1808         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1809         (TestWebKitAPI::drawSquareInEditableImage):
1810
1811 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1812
1813         Fix the build.
1814
1815         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1816         (WTR::UIScriptController::drawSquareInEditableImage):
1817         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1818         (TestWebKitAPI::drawSquareInEditableImage):
1819
1820 2019-02-14  Brian Burg  <bburg@apple.com>
1821
1822         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1823         https://bugs.webkit.org/show_bug.cgi?id=194411
1824         <rdar://problem/47787614>
1825
1826         Reviewed by Joseph Pecoraro.
1827
1828         Remove unnecessary soft linking macro usage.
1829
1830         * DumpRenderTree/mac/TestRunnerMac.mm:
1831         (TestRunner::inspectorTestStubURL):
1832         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1833         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1834         (WTR::TestRunner::inspectorTestStubURL):
1835
1836 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1837
1838         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1839         https://bugs.webkit.org/show_bug.cgi?id=194599
1840
1841         Reviewed by Lucas Forschler.
1842
1843         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1844         (StatusBubble._build_bubble):
1845
1846 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1847
1848         [ews-app] Set Foreign Key in Django build model
1849         https://bugs.webkit.org/show_bug.cgi?id=194667
1850
1851         Reviewed by Lucas Forschler.
1852
1853         * BuildSlaveSupport/ews-app/ews/models/build.py:
1854         (Build):
1855
1856 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1857
1858         [WTF] Add environment variable helpers
1859         https://bugs.webkit.org/show_bug.cgi?id=192405
1860
1861         Reviewed by Michael Catanzaro.
1862
1863         * DumpRenderTree/mac/DumpRenderTree.mm:
1864         (libraryPathForDumpRenderTree):
1865         * DumpRenderTree/win/DumpRenderTree.cpp:
1866         (libraryPathForDumpRenderTree):
1867         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1868         (setUpIOSLayoutTestCommunication):
1869         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1870         (TestWebKitAPI::strip):
1871         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1872         (beforeAll):
1873         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1874         (main):
1875         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1876         (WebKitTestBus::run):
1877         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1878         (WTR::getOutputDir):
1879         (WTR::initializeFontConfigSetting):
1880         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1881         (WTR::InjectedBundle::platformInitialize):
1882         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1883         (WTR::topLevelPath):
1884         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1885         (WTR::topLevelPath):
1886         (WTR::getOutputDir):
1887         (WTR::activateFonts):
1888         * WebKitTestRunner/TestController.cpp:
1889         (WTR::TestController::libraryPathForTesting):
1890         (WTR::TestController::generateContextConfiguration const):
1891         (WTR::TestController::generatePageConfiguration):
1892         (WTR::TestController::decideDestinationWithSuggestedFilename):
1893         (WTR::TestController::platformAdjustContext):
1894         * WebKitTestRunner/TestController.h:
1895         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1896         (WTR::TestController::cocoaPlatformInitialize):
1897         (WTR::TestController::platformAdjustContext):
1898         * WebKitTestRunner/gtk/main.cpp:
1899         (main):
1900         * WebKitTestRunner/mac/TestControllerMac.mm:
1901         (WTR::TestController::configureContentExtensionForTest):
1902         * WebKitTestRunner/wpe/main.cpp:
1903         (main):
1904         Utilize WTF::Environment where possible.
1905
1906 2019-02-14  Chris Dumez  <cdumez@apple.com>
1907
1908         [PSON] Introduce a WebContent Process cache
1909         https://bugs.webkit.org/show_bug.cgi?id=194594
1910         <rdar://problem/46793397>
1911
1912         Reviewed by Geoff Garen.
1913
1914         Update API tests to turn on the WebContent Process cache.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1917
1918 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1919
1920         Unreviewed, build fix after r241480
1921
1922         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1923         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1924         (-[DragAndDropSimulator initWithWebView:]):
1925
1926 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1927
1928         AX: ARIA Reflection was disabled in error
1929         https://bugs.webkit.org/show_bug.cgi?id=194647
1930         <rdar://problem/48068336>
1931
1932         Reviewed by Ryosuke Niwa.
1933
1934         Remove test override now that this feature should be enabled by default.
1935
1936         * WebKitTestRunner/TestController.cpp:
1937         (WTR::TestController::resetPreferencesToConsistentValues):
1938
1939 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1940
1941         Unreviewed, rolling out r241486.
1942         https://bugs.webkit.org/show_bug.cgi?id=194655
1943
1944         causing API failures in builds (Requested by ShawnRoberts on
1945         #webkit).
1946
1947         Reverted changeset:
1948
1949         "[Cocoa] Media elements will restart network buffering just
1950         before suspending"
1951         https://bugs.webkit.org/show_bug.cgi?id=193691
1952         https://trac.webkit.org/changeset/241486
1953
1954 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1955
1956         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1957         https://bugs.webkit.org/show_bug.cgi?id=194622
1958
1959         Reviewed by Antti Koivisto.
1960
1961         * LayoutReloaded/misc/LFC-passing-tests.txt:
1962
1963 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1964
1965         [LFC] Shrink-to-fit-width should be constrained by min/max width
1966         https://bugs.webkit.org/show_bug.cgi?id=194653
1967
1968         Reviewed by Antti Koivisto.
1969
1970         * LayoutReloaded/misc/LFC-passing-tests.txt:
1971
1972 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1973
1974         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1975         https://bugs.webkit.org/show_bug.cgi?id=194641
1976
1977         Reviewed by Geoffrey Garen.
1978
1979         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1980         so that the test would fail without this fix.
1981
1982         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1983         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1984
1985 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1986
1987         [ews-app] Change log level for a log statement
1988
1989         Unreviewed minor fix.
1990
1991         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1992         (Patch.save_patch):
1993
1994 2019-02-13  Jer Noble  <jer.noble@apple.com>
1995
1996         [Cocoa] Media elements will restart network buffering just before suspending
1997         https://bugs.webkit.org/show_bug.cgi?id=193691
1998
1999         Reviewed by Eric Carlson.
2000
2001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2002         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2003         (TEST):
2004
2005 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2006
2007         [ews-app] Fetch builder id to name mapping
2008         https://bugs.webkit.org/show_bug.cgi?id=194355
2009
2010         Reviewed by Lucas Forschler.
2011
2012         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2013         (Buildbot.get_builder_id_to_name_mapping):
2014         (Buildbot._get_display_name_from_builder_name):
2015
2016 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2017
2018         Further restricting webarchive loads
2019         https://bugs.webkit.org/show_bug.cgi?id=194567
2020         <rdar://problem/47610130>
2021
2022         Reviewed by Youenn Fablet.
2023
2024         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2025         navigations on drop.
2026
2027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2028         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2029         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2030         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2031         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2032         (TestWebKitAPI::TEST):
2033         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2034         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2035         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2036         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2037         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2038         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2039         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2040
2041 2019-02-13  John Wilander  <wilander@apple.com>
2042
2043         Store Ad Click Attribution requests in the network process
2044         https://bugs.webkit.org/show_bug.cgi?id=194510
2045         <rdar://problem/47650118>
2046
2047         Reviewed by Alex Christensen and Daniel Bates.
2048
2049         This patch adds two TestRunner functions:
2050         - dumpAdClickAttribution()
2051         - clearAdClickAttribution()
2052
2053         They call into the network process to dump and clear Ad Click
2054         Attribution state, respectively.
2055
2056         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2057         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2058         (WTR::TestRunner::dumpAdClickAttribution):
2059         (WTR::TestRunner::clearAdClickAttribution):
2060         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2061         * WebKitTestRunner/TestController.cpp:
2062         (WTR::TestController::resetStateToConsistentValues):
2063         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2064         (WTR::adClickAttributionStringResultCallback):
2065         (WTR::TestController::dumpAdClickAttribution):
2066         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2067         (WTR::adClickAttributionVoidCallback):
2068         (WTR::TestController::clearAdClickAttribution):
2069         * WebKitTestRunner/TestController.h:
2070         * WebKitTestRunner/TestInvocation.cpp:
2071         (WTR::TestInvocation::dumpResults):
2072         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2073         (WTR::TestInvocation::dumpAdClickAttribution):
2074         * WebKitTestRunner/TestInvocation.h:
2075
2076 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2077
2078         [ews-app] Generate status-bubble
2079         https://bugs.webkit.org/show_bug.cgi?id=194572
2080
2081         Reviewed by Lucas Forschler.
2082
2083         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2084         (StatusBubble._build_bubble):
2085         (StatusBubble._should_show_bubble_for):
2086         (StatusBubble._build_bubbles_for_patch):
2087
2088 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2089
2090         [ews-app] Add status bubble html template
2091         https://bugs.webkit.org/show_bug.cgi?id=194571
2092
2093         Reviewed by Lucas Forschler.
2094
2095         * BuildSlaveSupport/ews-app/ews/templates: Added.
2096         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2097
2098 2019-02-12  Chris Dumez  <cdumez@apple.com>
2099
2100         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2101         https://bugs.webkit.org/show_bug.cgi?id=194568
2102         <rdar://problem/47944490>
2103
2104         Reviewed by Ryosuke Niwa.
2105
2106         Add API test coverage.
2107
2108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2109         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2110
2111 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2112
2113         webkitpy: Remove bug_dummy from parsed test expectations
2114         https://bugs.webkit.org/show_bug.cgi?id=194562
2115         <rdar://problem/47853999>
2116
2117         Reviewed by Lucas Forschler.
2118
2119         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2120         (TestExpectationParser):
2121         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2122         skipped tests.
2123         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2124
2125 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2126
2127         [ews-app] Add method to fetch patch
2128         https://bugs.webkit.org/show_bug.cgi?id=194518
2129
2130         Reviewed by Lucas Forschler.
2131
2132         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2133         (Patch.get_patch):
2134
2135 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2136
2137         [LFC] Expand tests coverage (60 new tests -> 860)
2138
2139         Unreviewed test gardening (run-singly, --child-processes=1).
2140
2141         * LayoutReloaded/misc/LFC-passing-tests.txt:
2142
2143 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2144
2145         Allow pages to trigger programmatic paste from script on iOS
2146         https://bugs.webkit.org/show_bug.cgi?id=194271
2147         <rdar://problem/47808810>
2148
2149         Reviewed by Tim Horton.
2150
2151         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2152
2153         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2154         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2155         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2156         (WTR::UIScriptController::rectForMenuAction const):
2157
2158         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2159         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2160         for when the menu is shown or hidden.
2161
2162         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2163         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2164         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2165         (WTR::UIScriptController::setDidShowMenuCallback):
2166         (WTR::UIScriptController::didShowMenuCallback const):
2167         (WTR::UIScriptController::setDidHideMenuCallback):
2168         (WTR::UIScriptController::didHideMenuCallback const):
2169         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2170         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2171         (WTR::UIScriptController::rectForMenuAction const):
2172         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::TestController::resetPreferencesToConsistentValues):
2175         (WTR::updateTestOptionsFromTestHeader):
2176         * WebKitTestRunner/TestOptions.h:
2177
2178         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2179         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2180
2181         (WTR::TestOptions::hasSameInitializationOptions const):
2182         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2183         (WTR::UIScriptController::calendarType const):
2184         (WTR::UIScriptController::platformUndoManager const):
2185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2186         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2187         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2188         (-[TestRunnerWKWebView dealloc]):
2189         (-[TestRunnerWKWebView _didShowMenu]):
2190         (-[TestRunnerWKWebView _didHideMenu]):
2191
2192         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2193
2194         * WebKitTestRunner/ios/TestControllerIOS.mm:
2195         (WTR::handleMenuWillHideNotification):
2196         (WTR::handleMenuDidHideNotification):
2197         (WTR::TestController::platformInitialize):
2198         (WTR::TestController::platformDestroy):
2199         (WTR::TestController::platformResetStateToConsistentValues):
2200
2201         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2202         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2203
2204         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2205         (WTR::forEachViewInHierarchy):
2206         (WTR::findViewInHierarchyOfType):
2207
2208         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2209         functions that dig through a given view's hierarchy in search of a view of a given class.
2210
2211         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2212         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2213         (WTR::UIScriptController::selectionCaretViewRect const):
2214         (WTR::UIScriptController::selectionRangeViewRects const):
2215         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2216         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2217
2218         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2219
2220         (WTR::UIScriptController::rectForMenuAction const):
2221
2222         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2223         callout bar) whose label matches the given string.
2224
2225         (WTR::UIScriptController::platformContentView const):
2226
2227         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2228         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2229         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2230
2231         (WTR::UIScriptController::platformUndoManager const): Deleted.
2232         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2233         (WTR::UIScriptController::platformContentView const):
2234         (WTR::UIScriptController::platformUndoManager const): Deleted.
2235
2236 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2237
2238         webkitpy: No option to only show unexpected failures in results.html for iPad
2239         https://bugs.webkit.org/show_bug.cgi?id=194554
2240         <rdar://problem/47922442>
2241
2242         Rubber-stamped by Aakash Jain.
2243
2244         Just because a TestExpecations file does not exist for a specific platform does not mean that
2245         TestExpecations are not being used, given that platforms inherit test expectations.
2246
2247         * Scripts/webkitpy/port/base.py:
2248         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2249         * Scripts/webkitpy/port/base_unittest.py:
2250         (PortTest.test_uses_test_expectations_file):
2251
2252 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2253
2254         Remove setDefersLoading infrastructure from WebKit2
2255         https://bugs.webkit.org/show_bug.cgi?id=194506
2256
2257         Reviewed by Brady Eidson.
2258
2259         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2261         (WTR::TestRunner::setDefersLoading): Deleted.
2262         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2263
2264 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2265
2266         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2267         https://bugs.webkit.org/show_bug.cgi?id=194522
2268         <rdar://problem/47789393>
2269
2270         Reviewed by Chris Dumez.
2271
2272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2273         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2274         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2276
2277 2019-02-12  Andy Estes  <aestes@apple.com>
2278
2279         [iOSMac] Enable Parental Controls Content Filtering
2280         https://bugs.webkit.org/show_bug.cgi?id=194521
2281         <rdar://39732376>
2282
2283         Reviewed by Tim Horton.
2284
2285         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2286
2287 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2288
2289         [LFC][IFC] Add intrinsic width support for float boxes.
2290         https://bugs.webkit.org/show_bug.cgi?id=194528
2291
2292         Reviewed by Antti Koivisto.
2293
2294         Expand tests coverage (2 new tests -> 800).
2295         (This is the correct test ordering --runs-singly --child-processes=1)
2296
2297         * LayoutReloaded/misc/LFC-passing-tests.txt:
2298
2299 2019-02-12  Rob Buis  <rbuis@igalia.com>
2300
2301         Implement serializing in MIME type parser
2302         https://bugs.webkit.org/show_bug.cgi?id=193909
2303
2304         Reviewed by Darin Adler.
2305
2306         Add various tests involving upper case, non-ASCII, control/null characters,
2307         various HTTP whitespace, single quotes and an unpaired surrogate.
2308
2309         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2310         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2311         (TestWebKitAPI::serializeIfValid):
2312         (TestWebKitAPI::TEST):
2313
2314 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2315
2316         [Cocoa] Ask platform for generic font family mappings
2317         https://bugs.webkit.org/show_bug.cgi?id=187723
2318         <rdar://problem/41892438>
2319
2320         Reviewed by Brent Fulgham.
2321
2322         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2323
2324         * DumpRenderTree/mac/DumpRenderTree.mm:
2325         (allowedFontFamilySet):
2326         * WebKitTestRunner/mac/TestControllerMac.mm:
2327         (WTR::allowedFontFamilySet):
2328
2329 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2330
2331         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2332         https://bugs.webkit.org/show_bug.cgi?id=193622
2333
2334         Reviewed by Michael Catanzaro.
2335
2336         This adds support for loading content extension rule sets from the JSON files which
2337         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2338         of WKTR for this could be removed, but that is left for a follow-up patch with
2339         cleanups.
2340
2341         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2342         * WebKitTestRunner/TestController.cpp:
2343         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2344         avoid having the null-terminator copied into the result.
2345         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2346         part of the preparations to run a test.
2347         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2348         (WTR::contentExtensionStoreCallback): Added.
2349         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2350         used for content extensions test.
2351         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2352         extensions and compiling the JSON rule set for tests involving content extensions.
2353         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2354         testing and disables content extensions.
2355         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2356         resetContentExtensions().
2357         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2358         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2359         configureContentExtensionForTest(), and userContentController().
2360
2361 2019-02-11  Daniel Bates  <dabates@apple.com>
2362
2363         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2364         https://bugs.webkit.org/show_bug.cgi?id=191446
2365         <rdar://problem/45929460>
2366
2367         Reviewed by Tim Horton.
2368
2369         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2370
2371         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2372         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2373         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2374         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2375         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2376         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2377         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2378         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2379         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2380         (WTR::arrayLength):
2381         (WTR::parseModifierArray):
2382         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2383         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2384         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2385         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2386
2387 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2388
2389         Unreviewed, rolling out r241272 and r241276.
2390         https://bugs.webkit.org/show_bug.cgi?id=194514
2391
2392         Broke the Apple Internal build and the fix requires human
2393         intervention :( (Requested by dydz on #webkit).
2394
2395         Reverted changesets:
2396
2397         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2398         https://bugs.webkit.org/show_bug.cgi?id=191446
2399         https://trac.webkit.org/changeset/241272
2400
2401         "Fix internal iOS build after r241272"
2402         https://bugs.webkit.org/show_bug.cgi?id=191446
2403         https://trac.webkit.org/changeset/241276
2404
2405 2019-02-11  Truitt Savell  <tsavell@apple.com>
2406
2407         Unreviewed, rolling out r241269.
2408
2409         Caused 5 layout tests crashes on Mac WK1
2410
2411         Reverted changeset:
2412
2413         "DumpRenderTree should report unknown options"
2414         https://bugs.webkit.org/show_bug.cgi?id=191303
2415         https://trac.webkit.org/changeset/241269
2416
2417 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2418
2419         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2420         https://bugs.webkit.org/show_bug.cgi?id=194313
2421
2422         Reviewed by Tim Horton.
2423
2424         Add a helper to determine whether the web view is presenting modal UI.
2425
2426         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2427         (WTR::UIScriptController::isPresentingModally const):
2428         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2429         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2430         (WTR::UIScriptController::isPresentingModally const):
2431         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2432         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2433         (WTR::UIScriptController::calendarType const): Deleted.
2434         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2435         (WTR::UIScriptController::isPresentingModally const):
2436         (WTR::UIScriptController::calendarType const):
2437         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2438         (WTR::UIScriptController::calendarType const):
2439
2440 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2441
2442         GCHeapInspector: Show the retained sizes in more places
2443         https://bugs.webkit.org/show_bug.cgi?id=194464
2444
2445         Reviewed by Simon Fraser.
2446
2447         * GCHeapInspector/gc-heap-inspector.html:
2448         * GCHeapInspector/script/interface.js:
2449         (HeapInspectorUtils.humanReadableSize):
2450         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2451         (HeapInspectorUtils.spanForNode.span.span):
2452         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2453         (HeapSnapshotInspector.prototype.buildRoots):
2454
2455 2019-02-11  Daniel Bates  <dabates@apple.com>
2456
2457         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2458         https://bugs.webkit.org/show_bug.cgi?id=191446
2459         <rdar://problem/45929460>
2460
2461         Reviewed by Tim Horton.
2462
2463         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2464
2465         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2466         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2467         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2468         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2469         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2470         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2471         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2472         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2473         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2474         (WTR::arrayLength):
2475         (WTR::parseModifierArray):
2476         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2477         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2478         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2479         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2480
2481 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2482
2483         DumpRenderTree should report unknown options
2484         https://bugs.webkit.org/show_bug.cgi?id=191303
2485
2486         Reviewed by Frédéric Wang.
2487
2488         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2489         to report unknown options.
2490         Added and assigned test options which are currently used in tests.
2491
2492         * DumpRenderTree/TestOptions.cpp:
2493         (TestOptions::TestOptions):
2494
2495 2019-02-11  Truitt Savell  <tsavell@apple.com>
2496
2497         Unreviewed, rolling out r241229.
2498
2499         Revision broke internal builds for watchOS.
2500
2501         Reverted changeset:
2502
2503         "[Cocoa] Ask platform for generic font family mappings"
2504         https://bugs.webkit.org/show_bug.cgi?id=187723
2505         https://trac.webkit.org/changeset/241229
2506
2507 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2508
2509         [WinCairo][MiniBrowser] Basic authentication always fails.
2510         https://bugs.webkit.org/show_bug.cgi?id=194496
2511
2512         Reviewed by Don Olmstead.
2513
2514         * MiniBrowser/win/DialogHelper.h:
2515         (Dialog::getText):
2516
2517 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2518
2519         [GStreamer] GstMappedBuffer testsuite build fails
2520         https://bugs.webkit.org/show_bug.cgi?id=194495
2521
2522         Reviewed by Carlos Garcia Campos.
2523
2524         Fix the build by explicitely adding the gstreamer1.0-audio include
2525         directories to the include path.
2526
2527         * TestWebKitAPI/PlatformGTK.cmake:
2528         * TestWebKitAPI/PlatformWPE.cmake:
2529
2530 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2531
2532         [GTK][WPE] Add enable-javascript-markup setting
2533         https://bugs.webkit.org/show_bug.cgi?id=193439
2534
2535         Reviewed by Michael Catanzaro.
2536
2537         Add test cases to check the new setting.
2538
2539         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2540         (testWebKitSettings):
2541         (testWebKitSettingsJavaScriptMarkup):
2542         (beforeAll):
2543
2544 2019-02-10  Darin Adler  <darin@apple.com>
2545
2546         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2547         https://bugs.webkit.org/show_bug.cgi?id=194485
2548
2549         Reviewed by Daniel Bates.
2550
2551         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2552
2553 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2554
2555         Add more tests for clampTo<>()
2556         https://bugs.webkit.org/show_bug.cgi?id=194462
2557
2558         Reviewed by Geoffrey Garen.
2559
2560         Darin suggested to test the very last floating point number
2561         at the boundaries when truncating to integer.
2562         I added test for max/min and max-1/min-1.
2563
2564         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2565         (TestWebKitAPI::TEST):
2566
2567 2019-02-09  Darin Adler  <darin@apple.com>
2568
2569         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2570         https://bugs.webkit.org/show_bug.cgi?id=194021
2571
2572         Reviewed by Geoffrey Garen.
2573
2574         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2575         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2576         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2577
2578 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2579
2580         [LFC][IFC] Add intrinsic width support for basic inline containers
2581         https://bugs.webkit.org/show_bug.cgi?id=194473
2582
2583         Reviewed by Antti Koivisto.
2584
2585         Expand tests coverage (11 new tests -> 798)
2586
2587         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2588
2589 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2590
2591         Fix MiniBrowser's entitlements
2592         https://bugs.webkit.org/show_bug.cgi?id=192431
2593
2594         Reviewed by Joseph Pecoraro.
2595
2596         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2597         files, making it impossible to load any extension.
2598
2599         * MiniBrowser/MiniBrowser.entitlements:
2600
2601 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2602
2603         [Cocoa] Ask platform for generic font family mappings
2604         https://bugs.webkit.org/show_bug.cgi?id=187723
2605         <rdar://problem/41892438>
2606
2607         Reviewed by Brent Fulgham.
2608
2609         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2610
2611         * DumpRenderTree/mac/DumpRenderTree.mm:
2612         (allowedFontFamilySet):
2613         * WebKitTestRunner/mac/TestControllerMac.mm:
2614         (WTR::allowedFontFamilySet):
2615
2616 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2617
2618         [GTK] Implement back/forward touchpad gesture
2619         https://bugs.webkit.org/show_bug.cgi?id=193919
2620
2621         Reviewed by Michael Catanzaro.
2622
2623         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2624         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2625
2626 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2627
2628         Add SPI to use networking daemon instead of XPC service
2629         https://bugs.webkit.org/show_bug.cgi?id=194427
2630
2631         Reviewed by Geoffrey Garen
2632
2633         * MiniBrowser/MiniBrowser.entitlements:
2634
2635 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2636
2637         [ews-build] Ensure that every builder in config.json has short name
2638         https://bugs.webkit.org/show_bug.cgi?id=194461
2639
2640         Reviewed by Lucas Forschler.
2641
2642         * BuildSlaveSupport/ews-build/loadConfig.py:
2643         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2644
2645 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2646
2647         [ews-build] Add short name to config.json
2648         https://bugs.webkit.org/show_bug.cgi?id=194456
2649
2650         Reviewed by Lucas Forschler.
2651
2652         * BuildSlaveSupport/ews-build/config.json: Added short name.
2653         * BuildSlaveSupport/ews-build/loadConfig.py:
2654         (loadBuilderConfig): Set the short name as the builder description.
2655
2656 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2657
2658         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2659         https://bugs.webkit.org/show_bug.cgi?id=194418
2660
2661         Reviewed by Lucas Forschler.
2662
2663         Do not include errors trying when finding crashlogs at the end of
2664         a run-webkit-tests run since we don't process those errors.
2665
2666         * Scripts/webkitpy/port/darwin.py:
2667         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2668         * Scripts/webkitpy/port/ios_device.py:
2669         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2670         * Scripts/webkitpy/port/watch_device.py:
2671         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2672
2673 2019-02-08  Beth Dakin  <bdakin@apple.com>
2674
2675         Add afterScreenUpdates to WKSnapshotConfiguration
2676         https://bugs.webkit.org/show_bug.cgi?id=194362
2677         -and corresponding-
2678         <rdar://problem/40655528> Please add an "after screen updates" property to 
2679         WKSnapshotConfiguration (to solve blank snapshots)
2680
2681         Reviewed by Tim Horton.
2682
2683         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2684         (TEST):
2685
2686 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2687
2688         clampTo(): do not convert the input to double when dealing with integers
2689         https://bugs.webkit.org/show_bug.cgi?id=194263
2690         <rdar://problem/47692312>
2691
2692         Reviewed by Darin Adler.
2693
2694         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2695         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2696         (TestWebKitAPI::testClampFloatingPointToInteger):
2697         (TestWebKitAPI::testClampSameSignIntegers):
2698         (TestWebKitAPI::testClampUnsignedToSigned):
2699         (TestWebKitAPI::testClampSignedToUnsigned):
2700
2701 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2702
2703         webkitpy: Respect --dedicated-simulators flag
2704         https://bugs.webkit.org/show_bug.cgi?id=194416
2705         <rdar://problem/47894722>
2706
2707         Reviewed by Lucas Forschler.
2708
2709         * Scripts/webkitpy/port/device_port.py:
2710         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2711         available devices can be safely ignored.
2712
2713 2019-02-07  Keith Rollin  <krollin@apple.com>
2714
2715         Remove extra copy of 100x100-red.tga
2716         https://bugs.webkit.org/show_bug.cgi?id=194371
2717         <rdar://problem/47873465>
2718
2719         Reviewed by Said Abou-Hallawa.
2720
2721         In order to help it pass its tests, Bug 194190 added a second copy of
2722         the file 100x100-red.tga. However, it turns out that this additional
2723         file wasn't actually needed, and that that sole previous copy was
2724         sufficient. At the same time, this second copy -- which was copied to
2725         the same location in the build output as the first copy -- now caused
2726         XCBuild to complain because there were two production rules for the
2727         same output file. Address this by removing the newly-added extra copy.
2728
2729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2730         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2731
2732 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2733
2734         Deprecate WKBundlePageSetDefersLoading
2735         https://bugs.webkit.org/show_bug.cgi?id=191394
2736
2737         Reviewed by Dean Jackson.
2738
2739         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2740         (WTR::TestRunner::setDefersLoading):
2741
2742 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2743
2744         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2745         https://bugs.webkit.org/show_bug.cgi?id=194391
2746
2747         Reviewed by Antti Koivisto.
2748
2749         * LayoutReloaded/misc/LFC-passing-tests.txt:
2750
2751 2019-02-06  Keith Rollin  <krollin@apple.com>
2752
2753         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2754         https://bugs.webkit.org/show_bug.cgi?id=193975
2755         <rdar://problem/47643306>
2756
2757         Reviewed by Tim Horton.
2758
2759         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2760         the Info.plist file into the bundle. This step is not necessary as the
2761         implicit "bundle up all the build products into a framework" build
2762         phase does this already. Having the Copy Bundle Resources phase do
2763         this causes a conflict under XCBuild, which objects to two build
2764         phases producing the same file (Info.plist). Address this by removing
2765         Info.plist from the Copy Bundle Resources phase.
2766
2767         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2768
2769 2019-02-06  Keith Rollin  <krollin@apple.com>
2770
2771         Really enable the automatic checking and regenerations of .xcfilelists during builds
2772         https://bugs.webkit.org/show_bug.cgi?id=194357
2773         <rdar://problem/47861231>
2774
2775         Reviewed by Chris Dumez.
2776
2777         Bug 194124 was supposed to enable the automatic checking and
2778         regenerating of .xcfilelist files during the build. While related
2779         changes were included in that patch, the change to actually enable the
2780         operation somehow was omitted. This patch actually enables the
2781         operation. The check-xcfilelist.sh scripts now check
2782         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2783         from the checking.
2784
2785         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2786         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2787
2788 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2789
2790         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2791         <https://webkit.org/b/194286>
2792         <rdar://problem/47815558>
2793
2794         Reviewed by Alexey Proskuryakov.
2795
2796         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2797         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2798         WKRetainPtr<> to avoid leaking the WKDataRef.
2799
2800 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2801
2802         Unreviewed, fix a typo
2803
2804         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2805
2806 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2807
2808         [GTK][WPE] force libpsl build to use ICU in jhbuild
2809         https://bugs.webkit.org/show_bug.cgi?id=194288
2810
2811         Reviewed by Carlos Garcia Campos.
2812
2813         * gtk/jhbuild.modules:
2814         Require ICU for libpsl build in jhbuild, like done in WPE.
2815
2816 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2817
2818         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2819         https://bugs.webkit.org/show_bug.cgi?id=194209
2820
2821         Reviewed by Carlos Garcia Campos.
2822
2823         Enhance TestCookieManager to ensure this doesn't happen again.
2824
2825         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2826         (testCookieManagerPersistentStorage):
2827         (beforeAll):
2828
2829 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2830
2831         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2832         https://bugs.webkit.org/show_bug.cgi?id=194324
2833
2834         Reviewed by Andy Estes.
2835
2836         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2837         part of the name is already implicit, since this is in testing code in TestOptions.
2838
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::generateContextConfiguration const):
2841         (WTR::updateTestOptionsFromTestHeader):
2842         * WebKitTestRunner/TestOptions.h:
2843         (WTR::TestOptions::hasSameInitializationOptions const):
2844
2845 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2846
2847         [ews-build] Allow * as platform for builders and workers
2848         https://bugs.webkit.org/show_bug.cgi?id=188533
2849
2850         Reviewed by Lucas Forschler.
2851
2852         * BuildSlaveSupport/ews-build/loadConfig.py:
2853         (checkWorkersAndBuildersForConsistency):
2854
2855 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2856
2857         [ews-build] Add few bots to config.json
2858         https://bugs.webkit.org/show_bug.cgi?id=194304
2859
2860         Reviewed by Lucas Forschler.
2861
2862         * BuildSlaveSupport/ews-build/config.json:
2863
2864 2019-02-05  Keith Rollin  <krollin@apple.com>
2865
2866         Enable the automatic checking and regenerations of .xcfilelists during builds
2867         https://bugs.webkit.org/show_bug.cgi?id=194124
2868         <rdar://problem/47721277>
2869
2870         Reviewed by Tim Horton.
2871
2872         Bug 193790 add a facility for checking -- during build time -- that
2873         any needed .xcfilelist files are up-to-date and for updating them if
2874         they are not. This facility was initially opt-in by setting
2875         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2876         the process seemed robust. Its now time to enable this facility and
2877         make it opt-out. If there is a need to disable this facility, set and
2878         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2879         running `make` or `build-webkit`, or before running Xcode from the
2880         command line.
2881
2882         Additionally, remove the step that generates a list of source files
2883         going into the UnifiedSources build step. It's only necessarily to
2884         specify Sources.txt and SourcesCocoa.txt as inputs.
2885
2886         * Scripts/generate-xcfilelists:
2887
2888 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2889
2890         [GTK][WPE] force libpsl build to use ICU in jhbuild
2891         https://bugs.webkit.org/show_bug.cgi?id=194288
2892
2893         Reviewed by Philippe Normand.
2894
2895         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2896         This can cause build failures if libidn is detected but libunistring is not available.
2897
2898         Make sure that ICU is used for runtime and builtin PSL data.
2899
2900         * gtk/jhbuild.modules:
2901         * wpe/jhbuild.modules:
2902
2903 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2904
2905         [ews-app] Modified timestamp should be updated on updating data
2906         https://bugs.webkit.org/show_bug.cgi?id=194295
2907
2908         Reviewed by Lucas Forschler.
2909
2910         * BuildSlaveSupport/ews-app/ews/models/build.py:
2911         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2912         * BuildSlaveSupport/ews-app/ews/models/step.py:
2913
2914 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2915
2916         Unreviewed, rolling out r240742.
2917
2918         Causes crashes on iOS simulator.
2919
2920         Reverted changeset:
2921
2922         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2923         not focused in a content-editable element"
2924         https://bugs.webkit.org/show_bug.cgi?id=192824
2925         https://trac.webkit.org/changeset/240742
2926
2927 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2928
2929         run-webkit-tests emits message "...running None" when running tests
2930         https://bugs.webkit.org/show_bug.cgi?id=194133
2931         <rdar://problem/47724738>
2932
2933         Reviewed by Lucas Forschler.
2934
2935         * Scripts/webkitpy/xcode/device_type.py:
2936         (DeviceType.__str__): Use both version mapping tables and use just the variant
2937         name if no version name is available.
2938         * Scripts/webkitpy/xcode/device_type_unittest.py:
2939         (DeviceTypeTest):
2940         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2941         an associated named.
2942
2943 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2944
2945         [WPE] require python3-setuptools for meson build in jhbuild
2946         https://bugs.webkit.org/show_bug.cgi?id=194287
2947
2948         Reviewed by Philippe Normand.
2949
2950         python3-setuptools is needed to build meson in jhbuild.
2951         It is already required by the GTK port.
2952
2953         * wpe/install-dependencies:
2954
2955 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2956
2957         [ews-app] Add method to save BuilderMapping to database
2958         https://bugs.webkit.org/show_bug.cgi?id=194264
2959
2960         Reviewed by Lucas Forschler.
2961
2962         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2963         (BuilderMapping.__str__):
2964         (BuilderMapping):
2965         (BuilderMapping.save_mapping):
2966         (BuilderMapping.update_mapping):
2967         (BuilderMapping.get_existing_mapping):
2968         (BuilderMapping.is_valid_mapping):
2969
2970 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2971
2972         [ews-app] Add timestamp fields for BuilderMappings
2973         https://bugs.webkit.org/show_bug.cgi?id=194266
2974
2975         Reviewed by Lucas Forschler.
2976
2977         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2978         (BuilderMapping):
2979
2980 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2981
2982         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2983         https://bugs.webkit.org/show_bug.cgi?id=174816
2984
2985         Reviewed by Michael Catanzaro.
2986
2987         Add tests for webkit_uri_for_display().
2988
2989         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2990         (testURIForDisplayUnaffected):
2991         (testURIForDisplayAffected):
2992         (beforeAll):
2993         (afterAll):
2994         * TestWebKitAPI/glib/CMakeLists.txt:
2995
2996 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2997
2998         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2999         https://bugs.webkit.org/show_bug.cgi?id=194158
3000         <rdar://problem/47737268>
3001
3002         Rubber-stamped by Aakash Jain.
3003
3004         * Scripts/webkitpy/port/device_port.py:
3005         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3006
3007 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3008
3009         [CG] Enable setAdditionalSupportedImageTypes for WK1
3010         https://bugs.webkit.org/show_bug.cgi?id=194190
3011
3012         Reviewed by Tim Horton.
3013
3014         Add a test similar to the one under WebKit Cocoa but make it create a
3015         WebView instead of a WKWebView.
3016
3017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3019         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3020         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3021         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3022         (TestWebKitAPI::runTest):
3023         (TestWebKitAPI::TEST):
3024
3025 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3026
3027         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3028         https://bugs.webkit.org/show_bug.cgi?id=194168
3029
3030         Reviewed by Simon Fraser.
3031
3032         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3033
3034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3035         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3036         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3037         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3038         (TEST):
3039         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3040         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3041
3042 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3043
3044         REGRESSION (r237269): webkit-patch what-broke is broken 
3045         https://bugs.webkit.org/show_bug.cgi?id=193025
3046
3047         Reviewed by Aakash Jain.
3048
3049         * Scripts/webkitpy/common/host.py:
3050         (Host.buildbot):
3051         (Host.bugzilla): Renamed to 'buildbot'.
3052
3053 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3054
3055         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3056         https://bugs.webkit.org/show_bug.cgi?id=194207
3057
3058         Reviewed by Tim Horton.
3059
3060         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3061         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3062         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3063         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3064         start and delete forwards to remove the original attachment.
3065
3066         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3067         (TestWebKitAPI::TEST):
3068
3069 2019-02-04  Youenn Fablet  <youenn@apple.com>
3070
3071         Capture state should be managed consistently when doing process swapping
3072         https://bugs.webkit.org/show_bug.cgi?id=194122
3073         <rdar://problem/47609293>
3074
3075         Reviewed by Eric Carlson.
3076
3077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3078         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3079         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3080         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3082         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3083         (WTR::TestRunner::isDoingMediaCapture const):
3084         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3085         * WebKitTestRunner/TestController.cpp:
3086         (WTR::TestController::isDoingMediaCapture const):
3087         * WebKitTestRunner/TestController.h:
3088         * WebKitTestRunner/TestInvocation.cpp:
3089         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3090         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3091         (WTR::TestController::isDoingMediaCapture const):
3092
3093 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3094
3095         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3096         https://bugs.webkit.org/show_bug.cgi?id=194142
3097
3098         Reviewed by Ross Kirsling.
3099
3100         There three 'separator' variables in TestController.cpp. Renamed
3101         it 'pathSeparator', and unified them.
3102
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::generateContextConfiguration const):
3105         (WTR::createTestURL):
3106         (WTR::TestController::platformAdjustContext):
3107
3108 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3109
3110         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3111         https://bugs.webkit.org/show_bug.cgi?id=194198
3112
3113         Reviewed by Antti Koivisto.
3114
3115         No need to set the banner heights on navigation now, since Page stores them.
3116
3117         * MiniBrowser/mac/WK2BrowserWindowController.m:
3118         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3119
3120 2019-02-03  John Wilander  <wilander@apple.com>
3121
3122         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3123         https://bugs.webkit.org/show_bug.cgi?id=194104
3124         <rdar://problem/47649991>
3125
3126         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3127
3128         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3129         (TestWebKitAPI::TEST):
3130             Changed numeric types from unsigned short to uint32_t.
3131
3132 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3133
3134         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3135         <https://webkit.org/b/194178>
3136         <rdar://problem/47753473>
3137
3138         Reviewed by Alexey Proskuryakov.
3139
3140         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3141         (WTR::uninstallFakeHelvetica): Pass nullptr into
3142         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3143
3144 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3145
3146         [LFC] Initialize ICB's style with fixed width/height.
3147         https://bugs.webkit.org/show_bug.cgi?id=194188
3148
3149         Reviewed by Antti Koivisto.
3150
3151         * LayoutReloaded/misc/LFC-passing-tests.txt:
3152
3153 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3154
3155         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3156         https://bugs.webkit.org/show_bug.cgi?id=194185
3157
3158         Reviewed by Antti Koivisto.
3159
3160         * LayoutReloaded/misc/LFC-passing-tests.txt:
3161
3162 2018-12-16  Darin Adler  <darin@apple.com>
3163
3164         Convert additional String::format clients to alternative approaches
3165         https://bugs.webkit.org/show_bug.cgi?id=192746
3166
3167         Reviewed by Alexey Proskuryakov.
3168
3169         * WebKitTestRunner/TestController.cpp:
3170         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3171         as an intermediate in code that ultimately constructs a WTF::String.
3172         (WTR::userMediaOriginHash): Use makeString.
3173         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3174         (WTR::TestController::didPerformClientRedirect): Ditto.
3175         (WTR::TestController::didPerformServerRedirect): Ditto.
3176         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3177
3178 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3179
3180         [ews-build] Add unit test to verify builder keys
3181         https://bugs.webkit.org/show_bug.cgi?id=194152
3182
3183         Reviewed by Lucas Forschler.
3184
3185         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3186         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3187
3188 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3189
3190         [LFC] Expand tests coverage (12 new tests -> 787)
3191
3192         Unreviewed test gardening.
3193
3194         * LayoutReloaded/misc/LFC-passing-tests.txt:
3195
3196 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3197
3198         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3199         https://bugs.webkit.org/show_bug.cgi?id=194163
3200
3201         Reviewed by Simon Fraser.
3202
3203         775
3204
3205         * LayoutReloaded/misc/LFC-passing-tests.txt:
3206
3207 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3208
3209         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3210         https://bugs.webkit.org/show_bug.cgi?id=194140
3211         <rdar://problem/47728098>
3212
3213         Reviewed by Tim Horton.
3214
3215         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3217         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3218
3219         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3220         test to induce an IPC deadlock when presenting a modal alert during touch start.
3221
3222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3223         * WebKitTestRunner/TestController.cpp:
3224         (WTR::runJavaScriptAlert):
3225
3226         Add a client callback function for running JavaScript alerts.
3227
3228         (WTR::TestController::createOtherPage):
3229         (WTR::TestController::generateContextConfiguration const):
3230
3231         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3232         the fix in this patch.
3233
3234         (WTR::TestController::createWebViewWithOptions):
3235
3236         Plumb TestOptions to generateContextConfiguration.
3237
3238         (WTR::TestController::resetPreferencesToConsistentValues):
3239         (WTR::TestController::resetStateToConsistentValues):
3240         (WTR::updateTestOptionsFromTestHeader):
3241         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3242         (WTR::TestController::handleJavaScriptAlert):
3243         * WebKitTestRunner/TestController.h:
3244         * WebKitTestRunner/TestInvocation.cpp:
3245         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3246         * WebKitTestRunner/TestOptions.h:
3247         (WTR::TestOptions::hasSameInitializationOptions const):
3248
3249 2019-02-01  Chris Dumez  <cdumez@apple.com>
3250
3251         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3252         https://bugs.webkit.org/show_bug.cgi?id=193740
3253         <rdar://problem/47527267>
3254
3255         Reviewed by Alex Christensen.
3256
3257         Add API test coverage.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3260
3261 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3262
3263         [ews-app] Add display name field to BuilderMapping model
3264         https://bugs.webkit.org/show_bug.cgi?id=194153
3265
3266         Reviewed by Lucas Forschler.
3267
3268         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3269         (BuilderMapping):
3270
3271 2019-02-01  Youenn Fablet  <youenn@apple.com>
3272
3273         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3274         https://bugs.webkit.org/show_bug.cgi?id=194155
3275
3276         Reviewed by Eric Carlson.
3277
3278         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3279         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3280         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3281
3282 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3283
3284         [LFC] Adjust replaced element's intrinsic ratio
3285         https://bugs.webkit.org/show_bug.cgi?id=194154
3286
3287         Reviewed by Antti Koivisto.
3288
3289         761
3290
3291         * LayoutReloaded/misc/LFC-passing-tests.txt:
3292
3293 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3294
3295         [WPE] Show test results in minibrowser
3296         https://bugs.webkit.org/show_bug.cgi?id=194150
3297
3298         Reviewed by Žan Doberšek.
3299
3300         * Scripts/webkitpy/port/wpe.py:
3301         (WPEPort.show_results_html_file):
3302
3303 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3304
3305         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3306         https://bugs.webkit.org/show_bug.cgi?id=194151
3307
3308         Reviewed by Žan Doberšek.
3309
3310         ALT + <- go back
3311         ALT + -> go forward
3312
3313         * MiniBrowser/wpe/main.cpp:
3314         (main):
3315
3316 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3317
3318         [LFC] Set intrinsic size on Layout::Replaced
3319         https://bugs.webkit.org/show_bug.cgi?id=194139
3320
3321         Reviewed by Antti Koivisto.
3322
3323         744
3324
3325         * LayoutReloaded/misc/LFC-passing-tests.txt:
3326
3327 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3328
3329         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3330         https://bugs.webkit.org/show_bug.cgi?id=194146
3331
3332         Reviewed by Xabier Rodriguez-Calvar.
3333
3334         It allows to open relative paths.
3335
3336         * MiniBrowser/wpe/main.cpp:
3337         (main):
3338
3339 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3340
3341         Update flakiness dashboard configuration after recent queue changes
3342         https://bugs.webkit.org/show_bug.cgi?id=194127
3343
3344         Rubber-stamped by Aakash Jain.
3345
3346         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3347
3348         * TestResultServer/static-dashboards/builders.jsonp:
3349
3350 2019-01-31  Youenn Fablet  <youenn@apple.com>
3351
3352         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3353         https://bugs.webkit.org/show_bug.cgi?id=194106
3354         <rdar://problem/47676333>
3355
3356         Reviewed by Ryosuke Niwa.
3357
3358         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3359         (TestWebKitAPI::didFinishNavigation):
3360         (TestWebKitAPI::TEST):
3361         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3362
3363 2019-01-31  Chris Dumez  <cdumez@apple.com>
3364
3365         Page zoom level is lost after a process swap or a crash
3366         https://bugs.webkit.org/show_bug.cgi?id=194105
3367         <rdar://problem/47610781>
3368
3369         Reviewed by Alex Christensen.
3370
3371         Add API test coverage.
3372
3373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3374         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3375
3376 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3377
3378         Revert r238819 which is unneeded and caused a performance regression.
3379         https://bugs.webkit.org/show_bug.cgi?id=192272
3380         <rdar://problem/46664625>
3381
3382         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3383         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3384         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3385
3386 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3387
3388         Formalize WebKitAdditions mechanism of LoadOptimizer
3389         https://bugs.webkit.org/show_bug.cgi?id=193886
3390         <rdar://problem/47696809>
3391
3392         Reviewed by Brent Fulgham.
3393
3394         * MiniBrowser/MiniBrowser.entitlements:
3395         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3396
3397 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3398
3399         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3400         https://bugs.webkit.org/show_bug.cgi?id=194090
3401
3402         Reviewed by Antti Koivisto.
3403
3404         * LayoutReloaded/misc/LFC-passing-tests.txt:
3405
3406 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3407
3408         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3409         https://bugs.webkit.org/show_bug.cgi?id=194074
3410
3411         Reviewed by Antti Koivisto.
3412
3413         * LayoutReloaded/misc/LFC-passing-tests.txt:
3414
3415 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3416
3417         [LFC][BFC] Add support for block level replaced box.
3418         https://bugs.webkit.org/show_bug.cgi?id=194071
3419
3420         Reviewed by Antti Koivisto.
3421
3422         * LayoutReloaded/misc/LFC-passing-tests.txt:
3423
3424 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3425
3426         Fix WebKitTestRunner's testPath with Windows full paths
3427         https://bugs.webkit.org/show_bug.cgi?id=194012
3428
3429         Reviewed by Alex Christensen.
3430
3431         updateTestOptionsFromTestHeader failed to open test files because
3432         testPath returned wrong file paths. It returned a path "/C:/..."
3433         if a URL "file:///C:/..." was given.
3434
3435         * WebKitTestRunner/TestController.cpp:
3436         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3437
3438 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3439
3440         [WPE] Bump font related dependencies to match the GTK+ port
3441         https://bugs.webkit.org/show_bug.cgi?id=194017
3442
3443         Reviewed by Žan Doberšek.
3444
3445         * wpe/jhbuild.modules:
3446         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3447         * wpe/patches/icudata-stdlibs.patch: Added.
3448
3449 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3450
3451         Enable swipe tests on iOS
3452         https://bugs.webkit.org/show_bug.cgi?id=194076
3453
3454         Reviewed by Geoffrey Garen.
3455
3456         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3457         it causes a debug assertion failure in runUIScript.
3458
3459         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3460         (WTR::UIScriptController::beginBackSwipe):
3461         (WTR::UIScriptController::completeBackSwipe):
3462
3463 2019-01-30  Keith Rollin  <krollin@apple.com>
3464
3465         Use correct printf format specifier
3466         https://bugs.webkit.org/show_bug.cgi?id=194062
3467         <rdar://problem/47686167>
3468
3469         Reviewed by Alexey Proskuryakov.
3470
3471         LayoutTestSpellChecker.mm is trying to format a variable of type
3472         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3473         actually an unsigned long long. Fix this by formatting with %llu.
3474
3475         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3476         (-[LayoutTestTextCheckingResult description]):
3477
3478 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3479
3480         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3481         https://bugs.webkit.org/show_bug.cgi?id=193979
3482
3483         Reviewed by Wenson Hsieh.
3484
3485         Fix the test for iOS. Make the test work with iOS UA string.
3486
3487         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3488
3489 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3490
3491         Replace High Sierra LLINT CLoop bot due to hardware failure
3492         https://bugs.webkit.org/show_bug.cgi?id=194066
3493
3494         Reviewed by Aakash Jain.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/config.json:
3497
3498 2019-01-30  Keith Rollin  <krollin@apple.com>
3499
3500         [NSDragItem init] is unavailable
3501         https://bugs.webkit.org/show_bug.cgi?id=194059
3502         <rdar://problem/47685715>
3503
3504         Reviewed by Wenson Hsieh.
3505
3506         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3507         DumpRenderTree and TestWebKitAPI, which both try to create an
3508         NSDragItem in a manner that invokes this method. Address this by using
3509         -initWithPasteboardWriter instead.
3510
3511         Note that the parameter passed to initWithPasteboardWriter is likely
3512         incorrect. In both cases, the object passed does not conform to
3513         NSPasteboardWriting. However, with this fix, we're no worse off than
3514         before, and can now perform builds with newer compilers and SDKs until
3515         a real fix can be crafted. That work is tracked in
3516         https://bugs.webkit.org/show_bug.cgi?id=194060
3517
3518         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3519         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3520         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3521         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3522
3523 2019-01-30  Daniel Bates  <dabates@apple.com>
3524
3525         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3526         https://bugs.webkit.org/show_bug.cgi?id=192824
3527         <rdar://problem/47100332>
3528
3529         Reviewed by Wenson Hsieh.
3530
3531         Fix a bug where the wrong usage code was used for F13 thru F24.
3532
3533         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3534         (keyCodeForDOMFunctionKey):
3535
3536 2019-01-30  Chris Dumez  <cdumez@apple.com>
3537
3538         Regression(PSON) Load hang can occur on history navigation
3539         https://bugs.webkit.org/show_bug.cgi?id=194030
3540         <rdar://problem/47656939>
3541
3542         Reviewed by Antti Koivisto.
3543
3544         Add API test coverage.
3545
3546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3547
3548 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3549
3550         [LFC] Expand tests coverage.
3551
3552         Unreviewed test gardening.
3553
3554         * LayoutReloaded/misc/LFC-passing-tests.txt:
3555
3556 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3557
3558         [Flatpak] Add openjpeg support
3559         https://bugs.webkit.org/show_bug.cgi?id=194019
3560
3561         Reviewed by Michael Catanzaro.
3562
3563         * flatpak/org.webkit.CommonModules.yaml:
3564
3565 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3566
3567         Unreviewed, rolling out r240708.
3568         https://bugs.webkit.org/show_bug.cgi?id=194022
3569
3570         It broke WPE build (Requested by KaL on #webkit).
3571
3572         Reverted changeset:
3573
3574         "[WPE] Bump font related dependencies to match the GTK+ port"
3575         https://bugs.webkit.org/show_bug.cgi?id=194017
3576         https://trac.webkit.org/changeset/240708
3577
3578 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3579
3580         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3581         https://bugs.webkit.org/show_bug.cgi?id=194001
3582
3583         Reviewed by Antti Koivisto.
3584
3585         * LayoutReloaded/misc/LFC-passing-tests.txt:
3586
3587 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3588
3589         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3590         https://bugs.webkit.org/show_bug.cgi?id=194020
3591
3592         Reviewed by Antti Koivisto.
3593
3594         * LayoutReloaded/misc/LFC-passing-tests.txt:
3595
3596 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3597
3598         AX: Support color well on iOS
3599         https://bugs.webkit.org/show_bug.cgi?id=194010
3600
3601         Reviewed by Joanmarie Diggs.
3602
3603         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3604         (WTR::AccessibilityUIElement::stringAttributeValue):
3605
3606 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3607
3608         [WPE] Bump font related dependencies to match the GTK+ port
3609         https://bugs.webkit.org/show_bug.cgi?id=194017
3610
3611         Reviewed by Žan Doberšek.
3612
3613         * wpe/jhbuild.modules:
3614         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3615         * wpe/patches/icudata-stdlibs.patch: Added.
3616
3617 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3618
3619         [Mac] Update window scale API usage
3620         https://bugs.webkit.org/show_bug.cgi?id=193991
3621         rdar://problem/47614795
3622
3623         Reviewed by Tim Horton.
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (changeWindowScaleIfNeeded):
3627         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3628         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3629         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3630
3631 2019-01-29  Chris Dumez  <cdumez@apple.com>
3632
3633         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3634         https://bugs.webkit.org/show_bug.cgi?id=193977
3635         <rdar://problem/47643716>
3636
3637         Reviewed by Geoff Garen.
3638
3639         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3640         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3641         to the previous provisional committing *before* we make the last load. 
3642
3643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3644
3645 2019-01-29  Youenn Fablet  <youenn@apple.com>
3646
3647         Adopt new SPI to evaluate server certificate trust
3648         https://bugs.webkit.org/show_bug.cgi?id=193355
3649
3650         Reviewed by Alex Christensen.
3651
3652         Add infrastructure to handle HTTPS server trust evaluation testing.
3653
3654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3655         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3656         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3657         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3658         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3660         * WebKitTestRunner/TestController.cpp:
3661         (WTR::TestController::resetPreferencesToConsistentValues):
3662         (WTR::TestController::didReceiveAuthenticationChallenge):
3663         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3664         * WebKitTestRunner/TestController.h:
3665         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3666         * WebKitTestRunner/TestInvocation.cpp:
3667         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3668         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3669         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3670
3671 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3672
3673         [ews-build] Add build step to print bot Configuration
3674         https://bugs.webkit.org/show_bug.cgi?id=193887
3675
3676         Reviewed by Lucas Forschler.
3677
3678         * BuildSlaveSupport/ews-build/steps.py:
3679         (PrintConfiguration): Build step to print configuration.
3680         * BuildSlaveSupport/ews-build/factories.py:
3681
3682 2019-01-29  Chris Dumez  <cdumez@apple.com>
3683
3684         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3685         https://bugs.webkit.org/show_bug.cgi?id=193967
3686         <rdar://problem/47635348>
3687
3688         Reviewed by Alex Christensen.
3689
3690         Add API test coverage.
3691
3692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3693         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3694
3695 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3696
3697         [ews-app] Handle incoming results data
3698         https://bugs.webkit.org/show_bug.cgi?id=193973
3699
3700         Reviewed by Lucas Forschler.
3701
3702         * BuildSlaveSupport/ews-app/ews/views/results.py:
3703
3704 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3705
3706         [ews-app] Make the results url generic
3707         https://bugs.webkit.org/show_bug.cgi?id=193928
3708
3709         Reviewed by Lucas Forschler.
3710
3711         * BuildSlaveSupport/ews-app/ews/urls.py:
3712
3713 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3714
3715         [ews-build] Configure buildbot to send events to ews-app
3716         https://bugs.webkit.org/show_bug.cgi?id=193968