Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-22  Roy Reapor  <rreapor@apple.com>
2
3         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
4         https://bugs.webkit.org/show_bug.cgi?id=185788
5
6         Reviewed by Aakash Jain.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
9         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
10         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
11         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
12         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
13         * TestResultServer/static-dashboards/run-embedded-unittests.html:
14         * TestResultServer/static-dashboards/run-unittests.html:
15
16 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
17
18         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
19         https://bugs.webkit.org/show_bug.cgi?id=185831
20
21         Reviewed by Chris Dumez.
22
23         Updated the test to prevent crash after assertion fails.
24
25         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
26         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
27
28 2018-05-22  Chris Dumez  <cdumez@apple.com>
29
30         Regression(AsyncPolicyDelegates): Box.app login Window is blank
31         https://bugs.webkit.org/show_bug.cgi?id=185832
32         <rdar://problem/40307871>
33
34         Reviewed by Geoffrey Garen.
35
36         Add API test coverage.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
40         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
41         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
42         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
43         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
44         (TestWebKitAPI::TEST):
45         * TestWebKitAPI/cocoa/TestWKWebView.mm:
46         (-[WKWebView _isBackground]):
47
48 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
49
50         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
51         https://bugs.webkit.org/show_bug.cgi?id=185715
52
53         Reviewed by Geoffrey Garen.
54
55         Add API test coverage.
56
57         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
59         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
60         (TEST):
61
62 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
63
64         Unreviewed, added myself as a WebKit committer.
65
66         * Scripts/webkitpy/common/config/contributors.json:
67
68 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
69
70         Unreviewed, rolling out r232052.
71
72         Breaks internal builds.
73
74         Reverted changeset:
75
76         "Use more C++17"
77         https://bugs.webkit.org/show_bug.cgi?id=185176
78         https://trac.webkit.org/changeset/232052
79
80 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
81
82         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
83         https://bugs.webkit.org/show_bug.cgi?id=185689
84
85         Reviewed by Philippe Normand.
86
87         And update the patches, removing the ones that have been merged upstream.
88
89         * gstreamer/jhbuild.modules:
90         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
91         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
92         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
93         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
94         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
95         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
96         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
97         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
98
99 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
100
101         Use more C++17
102         https://bugs.webkit.org/show_bug.cgi?id=185176
103
104         Reviewed by JF Bastien.
105
106         * DumpRenderTree/mac/Configurations/Base.xcconfig:
107         * ImageDiff/cg/Configurations/Base.xcconfig:
108         * MiniBrowser/Configurations/Base.xcconfig:
109         * MobileMiniBrowser/Configurations/Base.xcconfig:
110         * TestWebKitAPI/Configurations/Base.xcconfig:
111         * WebKitTestRunner/Configurations/Base.xcconfig:
112
113 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
114
115         [WinCairo] Enable WebKit build by default
116         https://bugs.webkit.org/show_bug.cgi?id=185141
117
118         Reviewed by Per Arne Vollan.
119
120         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
121         WebKitForwardingHeaders because config.h includes a header of WK2.
122
123         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
124         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
125
126 2018-05-21  Jer Noble  <jer.noble@apple.com>
127
128         Complete fix for enabling modern EME by default
129         https://bugs.webkit.org/show_bug.cgi?id=185770
130         <rdar://problem/40368220>
131
132         Reviewed by Eric Carlson.
133
134         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
135
136 2018-05-18  Christopher Reid  <chris.reid@sony.com>
137
138         Unreviewed, add myself as a WebKit committer.
139
140         * Scripts/webkitpy/common/config/contributors.json:
141
142 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
143
144         Unreviewed, rolling out r222967.
145
146         It's not ready yet
147
148         Reverted changeset:
149
150         "[GTK][WPE] Add API to configure and enable resource load
151         statistics"
152         https://bugs.webkit.org/show_bug.cgi?id=177943
153         https://trac.webkit.org/changeset/222967
154
155 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
156
157         [GTK] MiniBrowser crashes when loading twice quickly
158         https://bugs.webkit.org/show_bug.cgi?id=185763
159
160         Reviewed by Michael Catanzaro.
161
162         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
163         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
164         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
165         leaked, it will crash when scheduled if the window has already been destroyed.
166
167         * MiniBrowser/gtk/BrowserWindow.c:
168         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
169
170 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
171
172         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
173         https://bugs.webkit.org/show_bug.cgi?id=185624
174         <rdar://problem/39111626>
175
176         Reviewed by Chris Dumez.
177
178         Modified expectation to make test more robust as cookies can be returned in different orders.
179
180         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
181         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
182         (TEST):
183
184 2018-05-18  Commit Queue  <commit-queue@webkit.org>
185
186         Unreviewed, rolling out r231982.
187         https://bugs.webkit.org/show_bug.cgi?id=185793
188
189         Caused layout test failures (Requested by realdawei on
190         #webkit).
191
192         Reverted changeset:
193
194         "Complete fix for enabling modern EME by default"
195         https://bugs.webkit.org/show_bug.cgi?id=185770
196         https://trac.webkit.org/changeset/231982
197
198 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
199
200         Handle failure to extend sandbox gracefully
201         https://bugs.webkit.org/show_bug.cgi?id=185779
202         <rdar://problem/40316349>
203
204         Unreviewed, fix test results.
205
206         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
207         (TEST_F):
208
209 2018-05-18  Jer Noble  <jer.noble@apple.com>
210
211         Complete fix for enabling modern EME by default
212         https://bugs.webkit.org/show_bug.cgi?id=185770
213         <rdar://problem/40368220>
214
215         Reviewed by Eric Carlson.
216
217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
218
219 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
220
221         Handle failure to extend sandbox gracefully
222         https://bugs.webkit.org/show_bug.cgi?id=185779
223         <rdar://problem/40316349>
224
225         Reviewed by Brent Fulgham.
226
227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
228         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
229         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
230         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
231         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
232         (MediaCaptureSimulateFailedSandbox::SetUp):
233         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
234         (TEST_F):
235         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
236
237 2018-05-18  Daniel Bates  <dabates@apple.com>
238
239         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
240         https://bugs.webkit.org/show_bug.cgi?id=185774
241
242         Reviewed by Andy Estes.
243
244         For now, the script debug-safari is not supported for WebKit for iOS. To
245         fix this we differentiate between the Apple Mac port and Apple embedded
246         ports.
247
248         * Scripts/webkitdirs.pm:
249         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
250         (isAppleMacWebKit): Added.
251         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
252         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
253         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
254         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
255         (runSafari): Ditto.
256         (runMiniBrowser): Ditto.
257         (debugMiniBrowser): Ditto.
258         (runWebKitTestRunner): Ditto.
259         (debugWebKitTestRunner): Ditto.
260
261 2018-05-18  Antoine Quint  <graouts@apple.com>
262
263         [Web Animations] Turn Web Animations with CSS integration on for test runners
264         https://bugs.webkit.org/show_bug.cgi?id=184819
265         <rdar://problem/39597337>
266
267         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
268
269         * DumpRenderTree/TestOptions.cpp:
270         (TestOptions::TestOptions):
271         * DumpRenderTree/TestOptions.h:
272         * DumpRenderTree/mac/DumpRenderTree.mm:
273         (runTest):
274         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
275         * WebKitTestRunner/TestController.cpp:
276         (WTR::TestController::resetPreferencesToConsistentValues):
277         (WTR::updateTestOptionsFromTestHeader):
278         * WebKitTestRunner/TestOptions.cpp:
279         (WTR::TestOptions::TestOptions):
280         (WTR::isLegacyAnimationEngineTestPath): Deleted.
281         * WebKitTestRunner/TestOptions.h:
282
283 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
284
285         [Win][MiniBrowser] Create MainWindow even in transparent mode
286         https://bugs.webkit.org/show_bug.cgi?id=185597
287
288         Reviewed by Per Arne Vollan.
289
290         The current implementations doesn't create the MainWindow in
291         transparent mode. The screenshot is in Bug 58300.
292
293         There were three problems:
294         - Can't control the WebView. ie. going backward and forward.
295         - Can't quit the program.
296         - It makes implementation complicated.
297
298         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
299         even in the transparent mode.
300         * MiniBrowser/win/WinMain.cpp:
301         (wWinMain): Create the main window even in the transparent mode.
302
303 2018-05-18  Antoine Quint  <graouts@apple.com>
304
305         [Web Animations] Turn Web Animations with CSS integration on for test runners
306         https://bugs.webkit.org/show_bug.cgi?id=184819
307         <rdar://problem/39597337>
308
309         Reviewed by Jon Lee.
310
311         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
312         integration flag on.
313
314         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
315         comment directly at the top of the file since test runners now set the flag on by default
316         and a dedicated directory exists for tests that need to run with this flag off.
317
318         * DumpRenderTree/TestOptions.cpp:
319         (TestOptions::TestOptions):
320         * DumpRenderTree/TestOptions.h:
321         * DumpRenderTree/mac/DumpRenderTree.mm:
322         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
323         (runTest):
324         * WebKitTestRunner/TestController.cpp:
325         (WTR::TestController::resetPreferencesToConsistentValues):
326         (WTR::updateTestOptionsFromTestHeader):
327         * WebKitTestRunner/TestOptions.cpp:
328         (WTR::isLegacyAnimationEngineTestPath):
329         (WTR::TestOptions::TestOptions):
330         * WebKitTestRunner/TestOptions.h:
331
332 2018-05-17  Nan Wang  <n_wang@apple.com>
333
334         AX: [macOS] Expose the primary screen height through AX API
335         https://bugs.webkit.org/show_bug.cgi?id=185742
336
337         Reviewed by Chris Fleizach.
338
339         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
340         (attributesOfElement):
341         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
342         (WTR::attributesOfElement):
343
344 2018-05-17  Commit Queue  <commit-queue@webkit.org>
345
346         Unreviewed, rolling out r231912.
347         https://bugs.webkit.org/show_bug.cgi?id=185750
348
349         It is prompting the user when there is no WPT changes
350         (Requested by bmac on #webkit).
351
352         Reverted changeset:
353
354         "Export changes to web-platform-test as part of the webkit-
355         patch upload workflow"
356         https://bugs.webkit.org/show_bug.cgi?id=184914
357         https://trac.webkit.org/changeset/231912
358
359 2018-05-17  Valerie R Young  <valerie@bocoup.com>
360
361         test262/Runner.pm: expand $INC to find webkitdirs.pm
362         https://bugs.webkit.org/show_bug.cgi?id=185739
363
364         Reviewed by Michael Saboff.
365
366         * Scripts/test262/Runner.pm:
367         (getBuildPath):
368
369 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
370
371         [WPE] Implement and enable FULLSCREEN_API
372         https://bugs.webkit.org/show_bug.cgi?id=185676
373
374         Reviewed by Žan Doberšek.
375
376         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
377         (testWebViewFullScreen):
378
379 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
380
381         Export changes to web-platform-test as part of the webkit-patch upload workflow
382         https://bugs.webkit.org/show_bug.cgi?id=184914
383
384         Reviewed by Youenn Fablet.
385
386         * Scripts/webkitpy/tool/commands/upload.py:
387         (Upload):
388         (CreateBug.execute):
389         (WPTChangeExport):
390         * Scripts/webkitpy/tool/steps/__init__.py:
391         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
392         (WPTChangeExport):
393         (WPTChangeExport.options):
394         (WPTChangeExport.run):
395         * Scripts/webkitpy/w3c/common.py:
396         * Scripts/webkitpy/w3c/test_exporter.py:
397         (WebPlatformTestExporter):
398         (WebPlatformTestExporter.__init__):
399         (WebPlatformTestExporter.username):
400         (WebPlatformTestExporter.token):
401         (WebPlatformTestExporter._github):
402         (WebPlatformTestExporter._wpt_fork_branch_github_url):
403         (WebPlatformTestExporter._wpt_fork_remote):
404         (WebPlatformTestExporter._wpt_fork_push_url):
405         (WebPlatformTestExporter._git):
406         (WebPlatformTestExporter._branch_name):
407         (WebPlatformTestExporter._public_branch_name):
408         (WebPlatformTestExporter.has_wpt_changes):
409         (WebPlatformTestExporter._create_patch):
410         (WebPlatformTestExporter.create_git_patch):
411         (WebPlatformTestExporter._prompt_for_token):
412         (WebPlatformTestExporter._prompt_for_username):
413         (WebPlatformTestExporter._ensure_username_and_token):
414         (WebPlatformTestExporter._validate_and_save_token):
415         (WebPlatformTestExporter.push_to_wpt_fork):
416         (WebPlatformTestExporter.make_pull_request):
417         (WebPlatformTestExporter.delete_local_branch):
418         (parse_args):
419         (TestExporter): Deleted.
420         (TestExporter.__init__): Deleted.
421         (TestExporter._ensure_wpt_repository): Deleted.
422         (TestExporter._fetch_wpt_repository): Deleted.
423         (TestExporter._ensure_new_branch_name): Deleted.
424         (TestExporter.download_and_commit_patch): Deleted.
425         (TestExporter.clean): Deleted.
426         (TestExporter.create_branch_with_patch): Deleted.
427         (TestExporter.push_to_wpt_fork): Deleted.
428         (TestExporter.make_pull_request): Deleted.
429         (TestExporter.create_wpt_pull_request): Deleted.
430         (TestExporter.delete_local_branch): Deleted.
431         (TestExporter.create_git_patch): Deleted.
432         (TestExporter.create_upload_remote_if_needed): Deleted.
433         (TestExporter.do_export): Deleted.
434         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
435         (TestExporterTest.test_export):
436         (TestExporterTest.test_export_with_specific_branch):
437         (TestExporterTest):
438         (TestExporterTest.test_export_interactive_mode):
439         (TestExporterTest.test_export_invalid_token):
440         (TestExporterTest.test_export_wrong_token):
441
442 2018-05-17  Valerie R Young  <valerie@bocoup.com>
443
444         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
445         https://bugs.webkit.org/show_bug.cgi?id=185650
446
447         Reviewed by Michael Saboff.
448
449         First, use jsc from CLI arg, then try to use webkit-build-directory,
450         if that doesn't work, look for jsc in the $PATH
451
452         * Scripts/test262/Runner.pm:
453         (processCLI):
454         (getBuildPath):
455         (runTest):
456
457 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
458
459         Test262-Runner: Adds a --timeout option
460         https://bugs.webkit.org/show_bug.cgi?id=185696
461
462         Reviewed by Michael Saboff.
463
464         The timeout option is used to set a timeout execution in ms for each test run in JSC.
465         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
466         * Scripts/test262/Runner.pm:
467         (processCLI):
468         (runTest):
469
470 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
471
472         Test262-Runner: Set timer for each test run
473         https://bugs.webkit.org/show_bug.cgi?id=185692
474
475         Reviewed by Michael Saboff.
476
477         Sets a high resolution timer for each execution call of JSC, reporting
478         the time in the results report to allow identifying slow tests.
479         * Scripts/test262/Runner.pm:
480         (main):
481         (processFile):
482         (runTest):
483         (processResult):
484
485 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
486
487         Add support for Intl NumberFormat formatToParts
488         https://bugs.webkit.org/show_bug.cgi?id=185375
489
490         Reviewed by Yusuke Suzuki.
491
492         Add flag for NumberFormat formatToParts.
493
494         * Scripts/webkitperl/FeatureList.pm:
495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
496
497 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
498
499         [Win] Use C++17 in MSVC
500         https://bugs.webkit.org/show_bug.cgi?id=185232
501
502         Reviewed by Alex Christensen.
503
504         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
505         conflicts with ::byte defined in Windows' header.
506
507         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
508         (WindowedPluginTest::WindowedPluginTest):
509         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
510         (logEventProc):
511         (stringEvent):
512         (AccessibilityController::winNotificationReceived):
513         * DumpRenderTree/win/TextInputController.cpp:
514         (markedRangeCallback):
515         (firstRectForCharacterRangeCallback):
516         (selectedRangeCallback):
517         * DumpRenderTree/win/TextInputController.h:
518         * DumpRenderTree/win/TextInputControllerWin.cpp:
519         (TextInputController::markedRange):
520         (TextInputController::firstRectForCharacterRange):
521         (TextInputController::selectedRange):
522
523 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
524
525         Session cookies aren't reliably set when using default WKWebSiteDataStore
526         https://bugs.webkit.org/show_bug.cgi?id=185624
527         <rdar://problem/39111626>
528
529         Reviewed by Geoffrey Garen.
530
531         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
534         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
535         (TEST):
536
537 2018-05-16  Valerie R Young  <valerie@bocoup.com>
538
539         test262/Runner.pm: save to supplied expectation file if supplied
540         https://bugs.webkit.org/show_bug.cgi?id=185660
541
542         Reviewed by Michael Saboff.
543
544         * Scripts/test262/Runner.pm:
545         (processCLI):
546         (main):
547
548 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
549
550         Unreviewed, rolling out r231763.
551
552         The test added with this change is failing an assertion.
553
554         Reverted changeset:
555
556         "NSEvent event trackers don't work from WebKitTestRunner"
557         https://bugs.webkit.org/show_bug.cgi?id=185383
558         https://trac.webkit.org/changeset/231763
559
560 2018-05-15  David Kilzer  <ddkilzer@apple.com>
561
562         TestWebKitAPI: Fix warnings found by new clang compiler
563         <https://webkit.org/b/185631>
564
565         Reviewed by Michael Catanzaro.
566
567         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
568         (TestWebKitAPI::TEST):
569         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
570         (TestWebKitAPI::TEST):
571         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
572         (TestWebKitAPI::TEST):
573         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
574         (TestWebKitAPI::TEST):
575         - Add #pragma statements to ignore the new
576           -Wself-assign-overloaded warning and to ignore
577           this as an unknown warning on older clang versions.  We want
578           to keep these self assigments as this code is designed to test
579           that use case.
580
581         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
582         (TestWebKitAPI::didFindStringMatches):
583         - Replace the "rect = rect;" statement that was used to avoid an
584           unused variable warning with two expectations.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
587         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
588         - Switch from -integerValue to -unsignedIntegerValue when
589           comparing against _WKRectEdgeAll since it's an enum declared
590           as an NSUInteger.
591
592 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
593
594         Unreviewed, rolling out r230749
595
596         This did not work as desired.
597
598         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
599         (TestWebKitAPI::TEST):
600
601 2018-05-15  Antoine Quint  <graouts@apple.com>
602
603         [Web Animations] Expose Web Animations CSS integration as an experimental feature
604         https://bugs.webkit.org/show_bug.cgi?id=185647
605
606         Reviewed by Dean Jackson.
607
608         Rename the Web Animations CSS integration flag.
609
610         * DumpRenderTree/TestOptions.cpp:
611         (TestOptions::TestOptions):
612         * DumpRenderTree/TestOptions.h:
613         * DumpRenderTree/mac/DumpRenderTree.mm:
614         (setWebPreferencesForTestOptions):
615         * WebKitTestRunner/TestController.cpp:
616         (WTR::TestController::resetPreferencesToConsistentValues):
617         (WTR::updateTestOptionsFromTestHeader):
618         * WebKitTestRunner/TestOptions.h:
619         (WTR::TestOptions::hasSameInitializationOptions const):
620
621 2018-05-14  Brady Eidson  <beidson@apple.com>
622
623         Add an API test to guard against regressions while re-entering setDefersLoading:.
624         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
625
626         Reviewed by Chris Dumez.
627
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
629         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
630         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
631         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
632         (-[DefersScheme initWithBytes:]):
633         (-[DefersScheme webView:startURLSchemeTask:]):
634         (-[DefersScheme webView:stopURLSchemeTask:]):
635         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
636         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
637         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
638         (-[DoubleDefersLoadingPlugIn dealloc]):
639
640 2018-05-14  Daniel Bates  <dabates@apple.com>
641
642         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
643         https://bugs.webkit.org/show_bug.cgi?id=185599
644         <rdar://problem/22493890>
645
646         Reviewed by Simon Fraser.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
650         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
651         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
652         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
653         (TestWebKitAPI::TEST):
654         * TestWebKitAPI/ios/set-timeout-function.html: Added.
655
656 2018-05-14  Valerie R Young  <valerie@bocoup.com>
657
658         test262/Runner.pm: small bugs in CLI and error codes
659         https://bugs.webkit.org/show_bug.cgi?id=185629
660
661         Reviewed by Michael Saboff.
662
663         Fix two commandline args with use '-f', correct
664         error code of failures.
665
666         * Scripts/test262/Runner.pm:
667         (processCLI):
668         (main):
669
670 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
671
672         Disable API tests that time out after pointer poisioning was disabled.
673         https://bugs.webkit.org/show_bug.cgi?id=185586
674
675         Unreviewed test gardening.
676
677         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
678         (TestWebKitAPI::TEST):
679         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
680         (TestWebKitAPI::TEST):
681         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
682         (TestWebKitAPI::TEST):
683         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
684         (TestWebKitAPI::TEST):
685
686 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
687
688         Test262-Runner: Fix RegExp for capturing tests metadata"
689         https://bugs.webkit.org/show_bug.cgi?id=185622
690
691         Reviewed by Michael Saboff.
692
693         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
694         both LF and CRLF forms.
695
696         The fix also allows the runner to capture the proper results from two specific files using CR and
697         CRLF line terminators. They are updated in the expectations file.
698         * Scripts/test262/Runner.pm:
699         (parseData):
700
701 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
702
703         NSEvent event trackers don't work from WebKitTestRunner
704         https://bugs.webkit.org/show_bug.cgi?id=185383
705         rdar://problem/40025045
706
707         Reviewed by Simon Fraser.
708
709         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
710         NSEvent swipe tracking is used for webkit swipe navigation.
711
712         * WebKitTestRunner/mac/EventSenderProxy.mm:
713         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
714
715 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
716
717         Test262 Runner should search for the Debug JSC by default
718         https://bugs.webkit.org/show_bug.cgi?id=185562
719
720         Reviewed by Michael Saboff.
721
722         The Test262 Runner is now searching for the Debug build of JSC by
723         default, not the Release build.
724
725         This fix allows a similar call from the previous runner, making
726         it compatible with the current build bot configuration parameters.
727
728         This patch also adds some minor improvements the verbose mode output.
729
730         * Scripts/test262/Runner.pm:
731         (processCLI):
732         (main):
733         (getBuildPath):
734         (processResult):
735
736 2018-05-11  Charles Vazac  <cvazac@gmail.com>
737
738         Runtime feature flag for Server-Timing
739         https://bugs.webkit.org/show_bug.cgi?id=184758
740
741         Reviewed by Youenn Fablet.
742
743         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
744         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
745
746 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
747
748         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
749         https://bugs.webkit.org/show_bug.cgi?id=185418
750
751         Reviewed by Alex Christensen.
752
753         All WK1 related code should be moved into MiniBrowser for the preparation
754         of Bug 184770.
755
756         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
757
758         * MiniBrowser/win/Common.cpp:
759         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
760         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
761         * MiniBrowser/win/Common.h: Added.
762         * MiniBrowser/win/MiniBrowser.cpp:
763         (MiniBrowser::init): Moved the initilization code from wWinMain.
764         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
765         * MiniBrowser/win/MiniBrowser.h:
766         (MiniBrowser::setCacheFolder): Changed to a private method.
767         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
768         * MiniBrowser/win/WinMain.cpp:
769         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
770
771 2018-05-11  Brady Eidson  <beidson@apple.com>
772
773         Make sure history navigations reuse the existing process when necessary.
774         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
775
776         Reviewed by Ryosuke Niwa.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
779
780 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
781
782         [JSC][GLIB] Add introspectable alternatives to functions using vargars
783         https://bugs.webkit.org/show_bug.cgi?id=185508
784
785         Reviewed by Michael Catanzaro.
786
787         Add test cases for the new API.
788
789         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
790         (testJSCFunction):
791         (testJSCObject):
792
793 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
794
795         [Build Bot] Restore configuration options to the Test262 Runner
796
797         During the switch from the previous Test262 runner to the new one,
798         a call for an extra configurations options got removed.
799
800         This call is important to inform the script to find the debug or
801         release build of JSC. It's being restored in this patch.
802
803         https://bugs.webkit.org/show_bug.cgi?id=185513
804
805         Reviewed by Yusuke Suzuki.
806
807         * BuildSlaveSupport/build.webkit.org-config/steps.py:
808         (RunTest262Tests):
809
810 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
811
812         REGRESSION (r230998): Cannot stream API test output
813         https://bugs.webkit.org/show_bug.cgi?id=185090
814
815         Reviewed by Ryosuke Niwa.
816
817         Change run-api-tests so that the stdout and stderr of a test will be printed
818         before it's result. If -v is passed, the output of single test runs will be
819         streamed. 
820
821         * Scripts/webkitpy/api_tests/run_api_tests.py:
822         (run): Use print_timestamps flag.
823         (parse_args): Add timestamps option to print timestamps in the log.
824         * Scripts/webkitpy/api_tests/runner.py:
825         (Runner): Add running status.
826         (Runner.__init__): Add number of workers and a flag to detect if a newline
827         is needed at the beginning of a log line.
828         (Runner.run): Turn off most logging coming from server process since it is
829         not constructive for API tests.
830         (Runner.handle): Add new log message to stream stdout and stderr instead of
831         caching values until the test run finished.
832         (_Worker._run_single_test): Log stdout and stderr in real time.
833         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
834         the test.
835         (_Worker.post): Provide a post with explicitly enumerated argument names.
836         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
837         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
838         (MeteredStream.write): Allow for verbose logging without timestamps.
839         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
840         (RegularTest): Add print_timestamps flag.
841         (RegularTest.setUp):
842         (RegularTest.test_logging_not_included):
843         (VerboseTest.test_log_args):
844         (VerboseWithOutTimestamp):
845         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
846
847 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
848
849         build-webkit can erroneously warn about Xcode being too old
850         https://bugs.webkit.org/show_bug.cgi?id=185533
851
852         Reviewed by Dan Bernstein.
853
854         Don't assume the version number is always a single digit.
855
856         * Scripts/webkitdirs.pm:
857         (determineXcodeVersion):
858
859 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
860
861         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
862         https://bugs.webkit.org/show_bug.cgi?id=185528
863
864         Reviewed by Lucas Forschler.
865
866         * BuildSlaveSupport/build.webkit.org-config/factories.py:
867         (TestFactory.__init__):
868         * BuildSlaveSupport/build.webkit.org-config/steps.py:
869         (InstallWinCairoDependencies):
870
871 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
872
873         Fix some -Wstring-op-truncation warnings
874         https://bugs.webkit.org/show_bug.cgi?id=185496
875
876         Reviewed by Alex Christensen.
877
878         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
879         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
880         set the last bucket to NUL.
881
882         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
883         (TestWebKitAPI::testAtomicStringNumber):
884         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
885         (TestWebKitAPI::testStringNumberFixedPrecision):
886         (TestWebKitAPI::testStringNumberFixedWidth):
887         (TestWebKitAPI::testStringNumber):
888
889 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
890
891         [Win][MiniBrowser] Add a separate WndProc for the layered window
892         https://bugs.webkit.org/show_bug.cgi?id=185460
893
894         Reviewed by Brent Fulgham.
895
896         All WK1 related code should be moved into MiniBrowser for the
897         preparation of Bug 184770.
898
899         The layered window was using WndProc of the main window. The
900         layered window is specific only for WK1. the main window will be
901         shared among WK1 and WK2.
902
903         This change add a new WndProc for the layer window.
904
905         * MiniBrowser/win/Common.cpp:
906         (WndProc): Removed code for the layered windows.
907         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
908         * MiniBrowser/win/MiniBrowser.cpp:
909         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
910         (viewWndProc): New WndProc for the layered windows.
911         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
912         * MiniBrowser/win/MiniBrowser.h:
913         (MiniBrowser::hwnd):
914         * MiniBrowser/win/WinMain.cpp:
915         (wWinMain): Added m_viewWnd.
916
917 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
918
919         Support --verbose in run-javascriptcore-tests
920         https://bugs.webkit.org/show_bug.cgi?id=185492
921
922         Reviewed by Daniel Bates.
923
924         * Scripts/run-javascriptcore-tests:
925         (runJSCStressTests):
926
927 2018-05-10  Valerie R Young  <valerie@bocoup.com>
928
929         test262/Runner.pm: --failing-files uses results file not expectations
930         https://bugs.webkit.org/show_bug.cgi?id=185395
931
932         Reviewed by Michael Saboff.
933
934         --failing-files arg now uses results file to find failing tests
935         to rerun. It will look in the test262-results directory from whereever
936         the script is run, or a results.yaml file can be supplied via command
937         line argument.
938         --expectations arg added for suppling expectation file.
939
940         * Scripts/test262/Runner.pm:
941         (processCLI):
942         (main):
943         (loadImportFile):
944         (findAllFailing):
945
946 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
947
948         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
949         https://bugs.webkit.org/show_bug.cgi?id=185506
950
951         Reviewed by Philippe Normand.
952
953         Useful for testing and debugging.
954
955         * MiniBrowser/gtk/main.c:
956         (main):
957
958 2018-05-09  Chris Dumez  <cdumez@apple.com>
959
960         Unreviewed Windows build fix after r231622.
961
962         * DumpRenderTree/win/DumpRenderTree.cpp:
963         (enableExperimentalFeatures):
964
965 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
966
967         Update WebKit.WebsiteDataStoreCustomPaths after r231536
968         https://bugs.webkit.org/show_bug.cgi?id=185486
969         <rdar://problem/37214391>
970
971         Reviewed by Chris Dumez.
972
973         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
974
975         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
976         (TEST):
977
978 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
979
980         Test262-Runner: Improve the verbose output
981         https://bugs.webkit.org/show_bug.cgi?id=185491
982
983         Reviewed by Michael Saboff.
984
985         * Scripts/test262/Import.pm:
986         (transferFiles):
987         * Scripts/test262/Runner.pm:
988         (processResult):
989
990 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
991
992         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
993         https://bugs.webkit.org/show_bug.cgi?id=185488
994
995         Reviewed by Michael Saboff.
996
997         * Scripts/test262/Runner.pm:
998         (processCLI):
999         (getBuildPath):
1000         (runTest):
1001
1002 2018-05-09  Richard Houle  <rhoule@apple.com>
1003
1004         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
1005         https://bugs.webkit.org/show_bug.cgi?id=185260
1006         <rdar://problem/39290394>
1007
1008         Reviewed by Tim Horton.
1009
1010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1011         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
1012         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
1013         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
1014         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1015         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1016
1017 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
1018
1019         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1020         https://bugs.webkit.org/show_bug.cgi?id=185481
1021
1022         Reviewed by Philippe Normand.
1023
1024         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1025
1026         * Scripts/webkitpy/port/gtk.py:
1027         (GtkPort.setup_environ_for_server):
1028
1029 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1030
1031         Set build.webkit.org to use the new Test262-runner
1032         https://bugs.webkit.org/show_bug.cgi?id=184933
1033
1034         Reviewed by Aakash Jain.
1035
1036         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1037         (RunTest262Tests):
1038         (RunTest262Tests.countFailures):
1039         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1040
1041 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1042
1043         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
1044         https://bugs.webkit.org/show_bug.cgi?id=185461
1045
1046         Reviewed by Michael Catanzaro.
1047
1048         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
1049
1050         * gtk/jhbuild.modules:
1051
1052 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1053
1054         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
1055
1056         * wpe/manifest.txt.in: Distribute the NEWS.
1057
1058 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1059
1060         [WPE] Build cleanly with GCC 8 and ICU 60
1061         https://bugs.webkit.org/show_bug.cgi?id=185462
1062
1063         Reviewed by Carlos Alberto Lopez Perez.
1064
1065         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
1066         sure why this was never noticed until now or why the bots are OK.
1067         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1068         * gtk/patches/glib-cast-function-type.patch: Added.
1069         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1070         * wpe/patches/glib-cast-function-type.patch: Added.
1071
1072 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1073
1074         [JSC][GTK][JSCONLY] Use capstone disassembler
1075         https://bugs.webkit.org/show_bug.cgi?id=185283
1076
1077         Reviewed by Michael Catanzaro.
1078
1079         * gtk/manifest.txt.in:
1080         * wpe/manifest.txt.in:
1081
1082 2018-05-09  Antti Koivisto  <antti@apple.com>
1083
1084         Add OptionSet::operator& and operator bool
1085         https://bugs.webkit.org/show_bug.cgi?id=185306
1086
1087         Reviewed by Anders Carlsson.
1088
1089         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1090         (TestWebKitAPI::TEST):
1091
1092 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1093
1094         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
1095         https://bugs.webkit.org/show_bug.cgi?id=185340
1096
1097         Reviewed by Tim Horton.
1098
1099         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
1100         non-empty text in a contenteditable.
1101
1102         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1103         (TestWebKitAPI::TEST):
1104
1105 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1106
1107         test262/Runner.pm: create results dir for results of test262 run
1108         https://bugs.webkit.org/show_bug.cgi?id=185392
1109
1110         Reviewed by Michael Saboff.
1111
1112         New directory test262-results created from where ever script is
1113         called.
1114
1115         * Scripts/test262/Runner.pm:
1116         (processCLI):
1117
1118 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1119
1120         test262/Runner.pm: lower number of processes per core
1121         https://bugs.webkit.org/show_bug.cgi?id=185426
1122
1123         Reviewed by Michael Saboff.
1124
1125         * Scripts/test262/Runner.pm:
1126         (getProcesses):
1127
1128 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
1129
1130         Test262-Runner: Add base Perl UnicodeData
1131         https://bugs.webkit.org/show_bug.cgi?id=185444
1132
1133         Reviewed by Michael Saboff.
1134
1135         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
1136         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
1137
1138 2018-05-08  Daniel Bates  <dabates@apple.com>
1139
1140         Add tests to ensure that the Strong Password appearance is removed on form reset
1141         https://bugs.webkit.org/show_bug.cgi?id=185440
1142
1143         Reviewed by Ryosuke Niwa.
1144
1145         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
1146         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
1147         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1148         (TEST):
1149
1150 2018-05-08  Daniel Bates  <dabates@apple.com>
1151
1152         Resign Strong Password appearance when text field value changes
1153         https://bugs.webkit.org/show_bug.cgi?id=185433
1154         <rdar://problem/39958508>
1155
1156         Reviewed by Ryosuke Niwa.
1157
1158         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
1159         when the field has the Strong Password button and its value changes.
1160
1161         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1162         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1163         (TEST):
1164
1165 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1166
1167         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1168         https://bugs.webkit.org/show_bug.cgi?id=185365
1169
1170         Reviewed by Saam Barati.
1171         
1172         Make it possible to measure compile times.
1173         
1174         Rolling back in after fixing cloop builds.
1175
1176         * Scripts/run-jsc-benchmarks:
1177
1178 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1179
1180         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
1181         https://bugs.webkit.org/show_bug.cgi?id=185414
1182
1183         Reviewed by Tim Horton.
1184
1185         Adjust a test expectation to check that the resulting DOM contains an attachment element,
1186         anchor element, and another attachment element in that order. This ensures that the test
1187         still passes, even after the anchor element is followed by a line break.
1188
1189         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1190         (TestWebKitAPI::TEST):
1191
1192 2018-05-08  Commit Queue  <commit-queue@webkit.org>
1193
1194         Unreviewed, rolling out r231491.
1195         https://bugs.webkit.org/show_bug.cgi?id=185434
1196
1197         Setting the Created key on a cookie does not work yet, due a
1198         bug in CFNetwork (Requested by ggaren on #webkit).
1199
1200         Reverted changeset:
1201
1202         "[WKHTTPCookieStore getAllCookies] returns inconsistent
1203         creation time"
1204         https://bugs.webkit.org/show_bug.cgi?id=185041
1205         https://trac.webkit.org/changeset/231491
1206
1207 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1208
1209         test262/Runner.pm: move input files to JSTests/test262
1210         https://bugs.webkit.org/show_bug.cgi?id=185389
1211
1212         Reviewed by Michael Saboff.
1213
1214         * Scripts/test262/Runner.pm:
1215         (processCLI):
1216
1217 2018-05-08  Chris Dumez  <cdumez@apple.com>
1218
1219         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
1220
1221         * Scripts/webkitpy/performance_tests/perftest.py:
1222         (PerfTest):
1223
1224 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1225
1226         Unreviewed, rolling out r231468.
1227
1228         Broke the CLoop build
1229
1230         Reverted changeset:
1231
1232         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
1233         any abstract values"
1234         https://bugs.webkit.org/show_bug.cgi?id=185365
1235         https://trac.webkit.org/changeset/231468
1236
1237 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
1238
1239         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1240         https://bugs.webkit.org/show_bug.cgi?id=185041
1241         <rdar://problem/34684214>
1242
1243         Reviewed by Geoffrey Garen.
1244
1245         Add API test Coverage.
1246
1247         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1248         (TEST):
1249
1250 2018-05-08  Chris Dumez  <cdumez@apple.com>
1251
1252         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1253
1254         * Scripts/webkitpy/performance_tests/perftest.py:
1255         (PerfTest):
1256
1257 2018-05-08  Chris Dumez  <cdumez@apple.com>
1258
1259         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1260
1261         * Scripts/webkitpy/performance_tests/perftest.py:
1262         (PerfTest):
1263
1264 2018-05-07  Chris Dumez  <cdumez@apple.com>
1265
1266         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1267
1268         * Scripts/webkitpy/performance_tests/perftest.py:
1269         (PerfTest):
1270
1271 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1272
1273         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1274         https://bugs.webkit.org/show_bug.cgi?id=185365
1275
1276         Reviewed by Saam Barati.
1277         
1278         Make it possible to measure compile times.
1279
1280         * Scripts/run-jsc-benchmarks:
1281
1282 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
1283
1284         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
1285         https://bugs.webkit.org/show_bug.cgi?id=185390
1286
1287         Reviewed by Michael Saboff.
1288
1289         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
1290
1291 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
1292
1293         Check for com.apple.datamigrator before declaring simulators booted
1294         https://bugs.webkit.org/show_bug.cgi?id=185315
1295         <rdar://problem/39986261>
1296
1297         Reviewed by David Kilzer.
1298
1299         * Scripts/webkitdirs.pm:
1300         (waitUntilProcessNotRunning): Wait until a process is not found.
1301         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
1302         a simulator booted.
1303         * Scripts/webkitpy/common/system/executive_mock.py:
1304         (MockExecutive2.__init__): Define _running_pids.
1305         * Scripts/webkitpy/xcode/simulated_device.py:
1306         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
1307         declaring that devices have been booted, increase the timeout since data migration will frequently
1308         take longer than 60 seconds, especially with multiple simulators booting.
1309         (SimulatedDeviceManager.swap): Ditto.
1310         (SimulatedDeviceManager):
1311         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
1312         processes running.
1313
1314 2018-05-07  Daniel Bates  <dabates@apple.com>
1315
1316         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
1317         https://bugs.webkit.org/show_bug.cgi?id=185054
1318         <rdar://problem/39773209>
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
1323
1324         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
1325         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
1326         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
1327         tests for the port.
1328
1329         * Scripts/webkitpy/port/mac.py:
1330         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
1331         have Apple Additions.
1332         * Scripts/webkitpy/port/mac_unittest.py:
1333         (MacTest.test_factory_with_future_version): Added.
1334         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
1335         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
1336         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
1337         is absent.
1338
1339 2018-05-07  Brian Burg  <bburg@apple.com>
1340
1341         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1342         https://bugs.webkit.org/show_bug.cgi?id=184861
1343         <rdar://problem/39153768>
1344
1345         Reviewed by Timothy Hatcher.
1346
1347         Add a new test that checks whether a new process is used for navigation when
1348         an Inspector is shown. Also check that the behavior reverts to normal after
1349         the Inspector has been closed.
1350
1351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1352
1353 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1354
1355         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
1356         https://bugs.webkit.org/show_bug.cgi?id=185289
1357         <rdar://problem/35756912>
1358
1359         Reviewed by Tim Horton and Darin Adler.
1360
1361         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
1362         sessions.
1363
1364         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1365         (TestWebKitAPI::TEST):
1366
1367 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1368
1369         Deprecate legacy WebView and friends
1370         https://bugs.webkit.org/show_bug.cgi?id=185279
1371         rdar://problem/33268700
1372
1373         Reviewed by Tim Horton.
1374
1375         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
1376         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
1377
1378 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1379
1380         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
1381         https://bugs.webkit.org/show_bug.cgi?id=185314
1382
1383         Reviewed by Michael Saboff.
1384
1385         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
1386
1387 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
1388
1389         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
1390         https://bugs.webkit.org/show_bug.cgi?id=184196
1391         <rdar://problem/39054481>
1392
1393         Reviewed by Tim Horton.
1394
1395         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
1396         earlier than 11.3. Also re-enables these tests.
1397
1398         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1399         (TestWebKitAPI::TEST):
1400         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
1401         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
1402
1403 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
1404
1405         Text shaping in the simple path is flipped in the y direction
1406         https://bugs.webkit.org/show_bug.cgi?id=185062
1407         <rdar://problem/39778678>
1408
1409         Reviewed by Simon Fraser.
1410
1411         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
1412
1413         * Scripts/webkitpy/common/config/contributors.json:
1414
1415 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1416
1417         Test262-Runner: place the processCLI inside the main call
1418         https://bugs.webkit.org/show_bug.cgi?id=185304
1419
1420         Reviewed by Michael Saboff.
1421
1422         * Scripts/test262/Runner.pm:
1423         (main):
1424
1425 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1426
1427         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
1428         https://bugs.webkit.org/show_bug.cgi?id=174730
1429
1430         Reviewed by Michael Catanzaro.
1431
1432         Update unit tests to check that User-Agent header is included in HTTP download requests.
1433
1434         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1435         (testDownloadRemoteFile):
1436         (testWebViewDownloadURI):
1437         (testPolicyResponseDownload):
1438         (testPolicyResponseDownloadCancel):
1439         (testDownloadMIMEType):
1440         (testContextMenuDownloadActions):
1441
1442 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
1443
1444         [WinCairo] Test archive must use Python zipfile, just like build product.
1445         https://bugs.webkit.org/show_bug.cgi?id=185265
1446
1447         Reviewed by Per Arne Vollan.
1448
1449         * BuildSlaveSupport/test-result-archive:
1450         (archive_test_results):
1451         Copy over Win32-oriented archiving logic from built-product-archive.
1452
1453 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
1454
1455         cleanup modules usage for the Test262-Runner
1456         https://bugs.webkit.org/show_bug.cgi?id=185263
1457
1458         Reviewed by Michael Saboff.
1459
1460         * Scripts/test262-runner:
1461         * Scripts/test262/Runner.pm:
1462         (processCLI):
1463
1464 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1465
1466         test262/Runner.pm: minor fixes
1467         https://bugs.webkit.org/show_bug.cgi?id=185250
1468
1469         Reviewed by Michael Saboff.
1470
1471         Add comments, change output and fix bug: unintended interpolation
1472         of filename when running jsc.
1473
1474         * Scripts/test262/Runner.pm:
1475         (processCLI):
1476         (main):
1477         (runTest):
1478
1479 2018-05-03  Chris Dumez  <cdumez@apple.com>
1480
1481         Load hangs if the WebProcess fails to launch
1482         https://bugs.webkit.org/show_bug.cgi?id=185225
1483         <rdar://problem/38249058>
1484
1485         Reviewed by Geoff Garen.
1486
1487         Add API test coverage.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
1491         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
1492         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
1493         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1494         (TEST):
1495
1496 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
1497
1498         [WinCairo] Add JSC test bots
1499         https://bugs.webkit.org/show_bug.cgi?id=185234
1500
1501         Reviewed by Per Arne Vollan.
1502
1503         * BuildSlaveSupport/build.webkit.org-config/config.json:
1504         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1505         (RunJavaScriptCoreTests.start):
1506
1507 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1508
1509         WebKit should send fake macOS user agent to docs.google.com
1510         https://bugs.webkit.org/show_bug.cgi?id=185165
1511
1512         Reviewed by Carlos Garcia Campos.
1513
1514         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1515         (TestWebKitAPI::TEST):
1516
1517 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1518
1519         test262/Runner.pm: performance improvements
1520         https://bugs.webkit.org/show_bug.cgi?id=185202
1521
1522         Reviewed by Michael Saboff.
1523
1524         Batch the tests by the number of processes, and give each process
1525         a file to save results to to avoid threading. Do not parallelize
1526         when running small sets of tests.
1527
1528         * Scripts/test262/Runner.pm:
1529         (processCLI):
1530         (main):
1531         (processFile):
1532         (processResult):
1533
1534 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
1535
1536         Unreviewed, rolling out r231253.
1537
1538         The API test added with this change is crashing on the bots.
1539
1540         Reverted changeset:
1541
1542         "Web Inspector: opt out of process swap on navigation if a Web
1543         Inspector frontend is connected"
1544         https://bugs.webkit.org/show_bug.cgi?id=184861
1545         https://trac.webkit.org/changeset/231253
1546
1547 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1548
1549         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
1550         https://bugs.webkit.org/show_bug.cgi?id=183348
1551
1552         Reviewed by Michael Catanzaro.
1553
1554         Add a test case to reproduce the crash.
1555
1556         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1557         (testWebViewCloseQuickly):
1558         (beforeAll):
1559
1560 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
1561
1562         Can't copy and paste URLs that have no title into Mail (macOS)
1563         https://bugs.webkit.org/show_bug.cgi?id=185205
1564         <rdar://problem/36352406>
1565
1566         Reviewed by Tim Horton.
1567
1568         Added test to verify behavior when copying and pasting a URL without a title.
1569
1570         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1571         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1572         (TestWebKitAPI::TEST):
1573
1574 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1575
1576         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
1577         https://bugs.webkit.org/show_bug.cgi?id=184699
1578
1579         Unreviewed follow-up fix after r231230.
1580
1581         * Scripts/generate-jsc-bundle:
1582         (generate_wrapper_script): Quote the arguments passed to jsc.
1583
1584 2018-05-02  Brian Burg  <bburg@apple.com>
1585
1586         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1587         https://bugs.webkit.org/show_bug.cgi?id=184861
1588         <rdar://problem/39153768>
1589
1590         Reviewed by Ryosuke Niwa.
1591
1592         Add a new test that checks whether a new process is used for navigation when
1593         an Inspector is shown. Also check that the behavior reverts to normal after
1594         the Inspector has been closed.
1595
1596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1597
1598 2018-05-02  Valerie R Young  <valerie@bocoup.com>
1599
1600         test262/Runner.pm: save summary to file
1601         https://bugs.webkit.org/show_bug.cgi?id=185200
1602
1603         Reviewed by Michael Saboff.
1604
1605         * Scripts/test262/Runner.pm:
1606         (processCLI):
1607         (main):
1608         (summarizeResults):
1609
1610 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1611
1612         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1613         https://bugs.webkit.org/show_bug.cgi?id=184699
1614
1615         Reviewed by Gustavo Noronha Silva.
1616
1617         This adds a new step for the GTK 64-bit release build bot and the
1618         GTK 32-bit release build&test bot.
1619
1620         This step will be run as one of the lasts ones (after the product
1621         is built) and will execute the script generate-jsc-bundle.
1622         This script will take care of creating a JSC bundle and uploading
1623         it to a server defined on a configuration file that has to be
1624         deployed on the bots with the required server data and credentials
1625         for this upload.
1626
1627         In this case, the built products should then be accessible at
1628         <https://webkitgtk.org/jsc-built-products>. But the implementation
1629         is not tied to any specific server. All the details about where
1630         to upload the file is done in configuration file that is kept
1631         private on each bot outside of the WebKit source tree.
1632
1633         The script also supports generating a JSC bundle locally and not
1634         uploading it anywhere. This is the default mode of running.
1635         The remote upload will only be activated if a --remote-config-file
1636         parameter is passed (which is done from the buildbot config)
1637
1638         * BuildSlaveSupport/build.webkit.org-config/config.json:
1639         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1640         (BuildFactory):
1641         (BuildFactory.__init__):
1642         (TestFactory):
1643         (TestFactory.__init__):
1644         (BuildAndGenerateJSCBundleFactory):
1645         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1646         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1647         (GenerateJSCBundle):
1648         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1649         * Scripts/generate-jsc-bundle: Added.
1650         (ldd_get_libs_and_interpreter):
1651         (generate_readme):
1652         (generate_wrapper_script):
1653         (copy_and_remove_rpath):
1654         (createJSCBundle):
1655         (sha256sum):
1656         (uploadJSCBundle):
1657         (main):
1658
1659 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1660
1661         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1662         https://bugs.webkit.org/show_bug.cgi?id=185111
1663
1664         Reviewed by Chris Dumez.
1665
1666         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1667
1668         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1669         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1670
1671         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1672         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1673         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1674         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1675
1676         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1677         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1678         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1679         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1680         beginTesting with BegingTestingMode::Resume when this boolean is set.
1681         (WTR::InjectedBundle::didReceiveMessageToPage):
1682         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1683         bundle after a process swap on navigation.
1684         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1686         (WTR::InjectedBundlePage::dump):
1687         (WTR::InjectedBundlePage::frameDidChangeLocation):
1688         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1689         (WTR::TestRunner::TestRunner):
1690         (WTR::TestRunner::shouldDumpPixels const): Added.
1691         (WTR::TestRunner::setDumpPixels): Added.
1692         (WTR::TestRunner::dumpAsText):
1693         (WTR::TestRunner::whatToDump const): Added.
1694         (WTR::TestRunner::setWhatToDump): Added.
1695         (WTR::TestRunner::waitUntilDone):
1696         (WTR::TestRunner::setWaitUntilDone): Added.
1697         (WTR::TestRunner::shouldWaitUntilDone): Added.
1698         (WTR::TestRunner::notifyDone):
1699         (WTR::TestRunner::forceImmediateCompletion):
1700         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1701         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1702         (WTR::TestRunner::setAudioResult):
1703         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1704         (WTR::TestRunner::dumpChildFramesAsText):
1705         (WTR::TestRunner::dumpDOMAsWebArchive):
1706         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1707         (WTR::TestRunner::whatToDump const): Moved to cpp.
1708         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1709         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1710         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1711         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1712         * WebKitTestRunner/TestInvocation.cpp:
1713         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1714         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1715         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1716         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1717         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1718         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1719         started as a result of a process swap on navigation (m_startedTesting is true).
1720         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1721         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1722         the states which must persist across process swaps within a test.
1723         * WebKitTestRunner/TestInvocation.h:
1724         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1725         * Tools/WebKitTestRunner/WhatToDump.h:
1726         (WTR::WhatToDump): Added.
1727
1728 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1729
1730         Auto save the results for Test262
1731         https://bugs.webkit.org/show_bug.cgi?id=184926
1732
1733         Reviewed by Michael Saboff.
1734
1735         * Scripts/test262/Runner.pm:
1736         (processCLI):
1737         (main):
1738         (parseError):
1739         (processResult):
1740         (summarizeResults):
1741         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1742
1743 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1744
1745         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1746         https://bugs.webkit.org/show_bug.cgi?id=185164
1747
1748         Reviewed by David Kilzer.
1749
1750         * Scripts/webkitpy/common/system/executive.py:
1751         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1752         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1753
1754 2018-05-01  Chris Dumez  <cdumez@apple.com>
1755
1756         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1757         https://bugs.webkit.org/show_bug.cgi?id=184918
1758         <rdar://problem/39705516>
1759
1760         Reviewed by Wenson Hsieh.
1761
1762         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1763         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1764         asynchronously because we ask the client if it is OK to do the load and the policy
1765         delegates are asynchronous nowadays.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1768         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1769         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1770         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1771         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1772         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1773         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1774
1775 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1776
1777         [WinCairo] Align buildbot test stages with AppleWin.
1778         https://bugs.webkit.org/show_bug.cgi?id=185094
1779
1780         Reviewed by Brent Fulgham.
1781
1782         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1783         (TestFactory.__init__):
1784         Do run API tests, don't run dashboard tests.
1785
1786         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1787         (RunUnitTests):
1788         Call run-api-tests with Python, not Perl (bugfix for r230998).
1789
1790         * Scripts/webkitpy/port/win.py:
1791         (WinPort.environment_for_api_tests):
1792         Retrieve necessary Windows environment variables.
1793
1794 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1795
1796         [MediaStream] remove WK1 support
1797         https://bugs.webkit.org/show_bug.cgi?id=185136
1798
1799         Reviewed by Youenn Fablet.
1800
1801         * DumpRenderTree/mac/UIDelegate.mm:
1802         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1803
1804 2018-05-01  Chris Dumez  <cdumez@apple.com>
1805
1806         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1807         https://bugs.webkit.org/show_bug.cgi?id=185157
1808
1809         Reviewed by Geoffrey Garen.
1810
1811         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1812         common configuration and should therefore be the configuration we test by default.
1813
1814         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1815         (WTR::InjectedBundlePage::decidePolicyForResponse):
1816
1817 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1818
1819         WebAssembly: add support for stream APIs - JavaScript API
1820         https://bugs.webkit.org/show_bug.cgi?id=183442
1821
1822         Reviewed by Yusuke Suzuki and JF Bastien.
1823
1824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1825
1826 2018-04-30  Mark Lam  <mark.lam@apple.com>
1827
1828         Apply PtrTags to the MetaAllocator and friends.
1829         https://bugs.webkit.org/show_bug.cgi?id=185110
1830         <rdar://problem/39533895>
1831
1832         Reviewed by Saam Barati.
1833
1834         Update the test to match MetaAllocator changes in WTF.
1835
1836         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1837         (TestWebKitAPI::TEST_F):
1838         (WTF::tagForPtr):
1839         (WTF::ptrTagName):
1840
1841 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1842
1843         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1844         https://bugs.webkit.org/show_bug.cgi?id=180955
1845
1846         Reviewed by Andy Estes.
1847
1848         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1849         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1850         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1851
1852 2018-04-30  JF Bastien  <jfbastien@apple.com>
1853
1854         Use some C++17 features
1855         https://bugs.webkit.org/show_bug.cgi?id=185135
1856
1857         Reviewed by Alex Christensen.
1858
1859         * DumpRenderTree/PlatformMac.cmake:
1860         * gtk/ycm_extra_conf.py:
1861         (FlagsForFile):
1862
1863 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1864
1865         Use WordLock instead of std::mutex for Threading
1866         https://bugs.webkit.org/show_bug.cgi?id=185121
1867
1868         Reviewed by Geoffrey Garen.
1869
1870         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1871         (TEST):
1872
1873 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1874
1875         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1876         https://bugs.webkit.org/show_bug.cgi?id=185103
1877
1878         Reviewed by Carlos Garcia Campos.
1879
1880         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1881         (TestWebKitAPI::TEST):
1882
1883 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1884
1885         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1886         https://bugs.webkit.org/show_bug.cgi?id=185052
1887
1888         Reviewed by Geoffrey Garen.
1889
1890         Modified API test to provide correct test cases for HTTPOnly flag.
1891
1892         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1893         (TEST):
1894
1895 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1896
1897         Token misspelled "tocken" in error message string
1898         https://bugs.webkit.org/show_bug.cgi?id=185030
1899
1900         Reviewed by Saam Barati.
1901
1902         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1903
1904 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1905
1906         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1907         https://bugs.webkit.org/show_bug.cgi?id=185049
1908
1909         Reviewed by Keith Miller.
1910
1911         * Scripts/run-javascriptcore-tests:
1912         (runJSCStressTests):
1913         * Scripts/run-jsc-stress-tests:
1914
1915 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1916
1917         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1918         https://bugs.webkit.org/show_bug.cgi?id=185066
1919
1920         Reviewed by Youenn Fablet.
1921
1922         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1923         WebKit should not swap WebContent process in this case.
1924
1925         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1926         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1927         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1928
1929 2018-04-27  Nan Wang  <n_wang@apple.com>
1930
1931         AX: Accessibility needs to know which part of the content view is visible on iOS
1932         https://bugs.webkit.org/show_bug.cgi?id=185085
1933         <rdar://problem/39801363>
1934
1935         Reviewed by Chris Fleizach.
1936
1937         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1938         (WTR::AccessibilityUIElement::stringAttributeValue):
1939
1940 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1941
1942         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1943         https://bugs.webkit.org/show_bug.cgi?id=185050
1944         <rdar://problem/39624038>
1945
1946         Reviewed by Tim Horton.
1947
1948         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1949         tested by the layout test added in this patch.
1950
1951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1952         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1953
1954 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1955
1956         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1957         https://bugs.webkit.org/show_bug.cgi?id=185061
1958
1959         Reviewed by Aakash Jain.
1960
1961         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1962         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1963         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1964
1965 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1966
1967         Add release bots for WinCairo.
1968         https://bugs.webkit.org/show_bug.cgi?id=185042
1969
1970         Reviewed by Lucas Forschler.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/config.json:
1973         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1974
1975 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1976
1977         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1978         https://bugs.webkit.org/show_bug.cgi?id=184938
1979         <rdar://problem/34737395>
1980
1981         Reviewed by Geoffrey Garen.
1982
1983         Add API test coverage.
1984
1985         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1986         (TEST):
1987
1988 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1989
1990         WinCairo test bots should run JSC tests with options for Windows command prompt.
1991         https://bugs.webkit.org/show_bug.cgi?id=185019
1992
1993         Reviewed by Per Arne Vollan.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1996         (RunJavaScriptCoreTests.start):
1997
1998 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1999
2000         WinCairo WKL Debug Test bot is not using DRT.
2001         https://bugs.webkit.org/show_bug.cgi?id=185009
2002
2003         Reviewed by Per Arne Vollan.
2004
2005         * BuildSlaveSupport/build.webkit.org-config/config.json:
2006
2007 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2008
2009         Disable content filtering in minimal simulator mode
2010         https://bugs.webkit.org/show_bug.cgi?id=185027
2011         <rdar://problem/39736091>
2012
2013         Reviewed by Jer Noble.
2014
2015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2016
2017 2018-04-26  Brady Eidson  <beidson@apple.com>
2018
2019         Add a setting for keeping around all processes and always reusing them per-origin.
2020         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
2021
2022         Reviewed by Andy Estes.
2023
2024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2025
2026 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2027
2028         [INTL] Implement Intl.PluralRules
2029         https://bugs.webkit.org/show_bug.cgi?id=184312
2030
2031         Reviewed by JF Bastien.
2032
2033         Added Intl.PluralRules feature flag.
2034
2035         * Scripts/webkitperl/FeatureList.pm:
2036         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2037
2038 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2039
2040         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
2041         https://bugs.webkit.org/show_bug.cgi?id=184643
2042
2043         Reviewed by Žan Doberšek.
2044
2045         Add missing INCLUDE_DIRS in many places.
2046
2047         Adapt to single-header WPE includes.
2048
2049         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
2050
2051         * TestWebKitAPI/PlatformWPE.cmake:
2052         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2053         (testWebViewWebBackend):
2054         * TestWebKitAPI/glib/PlatformWPE.cmake:
2055         * WebKitTestRunner/EventSenderProxy.h:
2056         * WebKitTestRunner/PlatformWPE.cmake:
2057         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2058         * wpe/HeadlessViewBackend/CMakeLists.txt:
2059         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
2060         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
2061         * wpe/jhbuild.modules:
2062
2063 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2064
2065         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
2066         https://bugs.webkit.org/show_bug.cgi?id=184982
2067
2068         Rubber-stamped by Aakash Jain.
2069
2070         Correctly count the number of API test failures.
2071
2072         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2073         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
2074         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2075         * Scripts/webkitpy/api_tests/manager.py:
2076         (Manager.run): Disabled tests are not run.
2077
2078 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2079
2080         Remove access to keychain from the WebContent process
2081         https://bugs.webkit.org/show_bug.cgi?id=184428
2082         <rdar://problem/13150903>
2083
2084         Reviewed by Brent Fulgham.
2085
2086         This patch does the followings:
2087         1. Added an API test for this patch.
2088         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
2089
2090         * DumpRenderTree/mac/UIDelegate.mm:
2091         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
2092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2093         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
2094         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
2095         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
2096         (TestWebKitAPI::TEST_F):
2097         * WebKitTestRunner/TestController.cpp:
2098         (WTR::copySignedPublicKeyAndChallengeString):
2099         (WTR::TestController::createOtherPage):
2100         (WTR::TestController::createWebViewWithOptions):
2101
2102 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2103
2104         [Extra zoom mode] The search field on www.bing.com is missing label text
2105         https://bugs.webkit.org/show_bug.cgi?id=184975
2106         <rdar://problem/39723081>
2107
2108         Reviewed by Tim Horton.
2109
2110         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
2111         focused element in extra zoom mode.
2112
2113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2114         (WTR::UIScriptController::formInputLabel const):
2115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2117         (WTR::UIScriptController::formInputLabel const):
2118         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2119         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2120         (WTR::UIScriptController::formInputLabel const):
2121
2122 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2123
2124         [WPE] Should load injected bundle from builddir in developer builds
2125         https://bugs.webkit.org/show_bug.cgi?id=184983
2126
2127         Reviewed by Carlos Alberto Lopez Perez.
2128
2129         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
2130
2131         * Scripts/run-minibrowser:
2132
2133 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2134
2135         [WPE] libgstggtk.so broken in jhbuild environment
2136         https://bugs.webkit.org/show_bug.cgi?id=184984
2137
2138         Reviewed by Carlos Alberto Lopez Perez.
2139
2140         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
2141         gst-plugins-good.
2142
2143         * wpe/jhbuild.modules:
2144
2145 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2146
2147         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
2148         https://bugs.webkit.org/show_bug.cgi?id=184962
2149
2150         Reviewed by Youenn Fablet.
2151
2152         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
2153
2154         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2155         (ProcessSwap.SameOriginBlobNavigation): Added.
2156         (ProcessSwap.CrossOriginBlobNavigation): Added.
2157         (ProcessSwap.NavigateToAboutBlank): Added.
2158         (ProcessSwap.NavigateToDataURL): Added.
2159
2160 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2161
2162         [WPE] Remove deprecated functions and properties from the API
2163         https://bugs.webkit.org/show_bug.cgi?id=179295
2164
2165         Reviewed by Žan Doberšek.
2166
2167         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2168         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
2169         to rewrite LoadTrackingTest to not require the web view at construction time.
2170         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2171         (testWebKitSettings): Don't test private browsing setting, which is gone.
2172         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
2173
2174 2018-04-25  Andy Estes  <aestes@apple.com>
2175
2176         [Mac] Number of drop items is always 0 when performing a DHTML drag
2177         https://bugs.webkit.org/show_bug.cgi?id=184943
2178
2179         Reviewed by Ryosuke Niwa.
2180
2181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2182         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2183         (-[DragInfo numberOfValidItemsForDrop]):
2184         (-[DragInfo setNumberOfValidItemsForDrop:]):
2185         (TestWebKitAPI::TEST):
2186         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
2187
2188 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2189
2190         API test harness should be Python
2191         https://bugs.webkit.org/show_bug.cgi?id=181043
2192         <rdar://problem/36164410>
2193
2194         Reviewed by David Kilzer.
2195
2196         Run API tests from a Python script rather than Perl. The Python API tests have
2197         the same structure as the layout tests.
2198
2199         * Scripts/run-api-tests: Changed from Perl to Python.
2200         * Scripts/webkitpy/api_tests: Added.
2201         * Scripts/webkitpy/api_tests/__init__.py: Added.
2202         * Scripts/webkitpy/api_tests/manager.py: Added.
2203         (Manager):
2204         (Manager.__init__):
2205         (Manager._test_list_from_output): Construct a list of tests from the output of
2206         TestWTF and TestWebKitAPI.
2207         (Manager._find_test_subset): Given a list of all possible tests and command line
2208         arguments, return a list of tests which match the provided arguments.
2209         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
2210         to determine which tests will be run.
2211         (Manager._print_test_result): Formatted print of a test with it's output.
2212         (Manager._print_tests_result_with_status): Print all tests and output for tests
2213         which ran with a specified exit status.
2214         (Manager.run): Collect all tests, run them and then print results from the run.
2215         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
2216         (main): Parse arguments, construct a port, early exit for illegal ports and
2217         then run tests.
2218         (run): Setup logging and printing before using the Manager to run tests.
2219         (parse_args): Use argparse to define all options used by run-api-tests.
2220         * Scripts/webkitpy/api_tests/runner.py: Added.
2221         (Runner):
2222         (Runner.__init__):
2223         (Runner._shard_tests): Split tests so that each suite runs together.
2224         (Runner.command_for_port): Run a command on the device specified by the given
2225         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
2226         this function would be entirely replaced by the server_process factory owned
2227         by the port object.
2228         (Runner.run): Run all shards in the message_pool.
2229         (Runner.handle): Handle reports from child processes.
2230         (Runner.result_map_by_status): Return a mapping of tests to output for tests
2231         which exit with a specific status.
2232         (_Worker):
2233         (_Worker.__init__):
2234         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
2235         (_Worker._run_single_test): Runs a single test in a single child process.
2236         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
2237         child process. If this technique fails, the remaining tests are run singly.
2238         (_Worker.handle): Run the specified shard.
2239         * Scripts/webkitpy/port/base.py:
2240         (Port):
2241         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
2242         (Port.environment_for_api_tests): Return the environment needed to run
2243         the TestWebKitAPI binary.
2244         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
2245         used when running API tests.
2246         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
2247         * Scripts/webkitpy/port/mac.py:
2248         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
2249         * Scripts/webkitpy/port/server_process.py: 
2250         (ServerProcess.pop_all_buffered_stdout):
2251
2252 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2253
2254         Incorrect number of WebDriver test failures shown in the bots
2255         https://bugs.webkit.org/show_bug.cgi?id=184959
2256
2257         Reviewed by Michael Catanzaro.
2258
2259         The regular expression we are using to get the number of failures from the log is matching a particular test
2260         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
2261         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
2262
2263         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2264         (RunWebDriverTests.commandComplete):
2265
2266 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2267
2268         [GTK] Implement MouseEvent.buttons
2269         https://bugs.webkit.org/show_bug.cgi?id=184913
2270
2271         Reviewed by Žan Doberšek.
2272
2273         Include the mouse buttons state in WTR synthesized events.
2274
2275         * WebKitTestRunner/EventSenderProxy.h:
2276         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2277         (WTR::EventSenderProxy::EventSenderProxy):
2278         (WTR::EventSenderProxy::createMouseButtonEvent):
2279         (WTR::EventSenderProxy::mouseDown):
2280         (WTR::EventSenderProxy::mouseUp):
2281         (WTR::EventSenderProxy::mouseMoveTo):
2282
2283 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
2284
2285         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
2286         https://bugs.webkit.org/show_bug.cgi?id=184954
2287
2288         Reviewed by Michael Catanzaro.
2289
2290         * BuildSlaveSupport/build.webkit.org-config/config.json:
2291
2292 2018-04-24  Saam Barati  <sbarati@apple.com>
2293
2294         Keep around a pre-warmed process when doing process swap on navigation
2295         https://bugs.webkit.org/show_bug.cgi?id=184765
2296         <rdar://problem/39685099>
2297
2298         Reviewed by Ryosuke Niwa and Brady Eidson.
2299
2300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2301
2302 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
2303
2304         [build.webkit.org] unit-tests fail when passwords.json is missing
2305         https://bugs.webkit.org/show_bug.cgi?id=180390
2306
2307         Reviewed by Carlos Alberto Lopez Perez.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2310         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
2311         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2312         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
2313         (BuildBotConfigLoader._mock_open): Deleted.
2314         (BuildBotConfigLoader.load_config): Deleted.
2315
2316 2018-04-24  John Wilander  <wilander@apple.com>
2317
2318         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
2319         https://bugs.webkit.org/show_bug.cgi?id=184560
2320         <rdar://problem/38901344>
2321
2322         Reviewed by Youenn Fablet and Daniel Bates.
2323
2324         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
2325         We consume the From-Origin response header and only load the resource if:
2326         - The header is non-existent, empty, or invalid.
2327         - The header specifies 'same' and the resource's origin matches the originating
2328           document's origin and the origins up the frame tree.
2329         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
2330           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
2331
2332         This feature is experimental and off by default.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
2336         (TestWebKitAPI::TEST):
2337             Tests for From-Origin header parsing.
2338
2339 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2340
2341         Unreviewed. Update W3C WebDriver imported tests.
2342
2343         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2344         (WebDriverW3CExecutor.__init__):
2345
2346 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
2347
2348         [WPE] Remove libgbm dependency
2349         https://bugs.webkit.org/show_bug.cgi?id=184906
2350
2351         Reviewed by Carlos Garcia Campos.
2352
2353         Stop searching for libgbm, using its compiler flags for the
2354         HeadlessViewBackend compilation and linking against the .so object.
2355         This is not necessary anymore after r230562 switched to a different
2356         backend implementation for testing.
2357
2358         * wpe/HeadlessViewBackend/CMakeLists.txt:
2359         * wpe/install-dependencies:
2360
2361 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2362
2363         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
2364         https://bugs.webkit.org/show_bug.cgi?id=184816
2365
2366         Reviewed by Michael Catanzaro.
2367
2368         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
2369         timeout.
2370
2371         * TestWebKitAPI/glib/TestExpectations.json:
2372         * glib/api_test_runner.py:
2373         (TestRunner._run_test_glib.is_slow_test):
2374         (TestRunner._run_test_glib):
2375         * glib/glib_test_runner.py:
2376         (GLibTestRunner.__init__):
2377         (GLibTestRunner._stop_timeout):
2378         (GLibTestRunner._subtest_start):
2379         (GLibTestRunner._subtest_end):
2380
2381 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2382
2383         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
2384         https://bugs.webkit.org/show_bug.cgi?id=184901
2385         <rdar://problem/39664797>
2386
2387         Reviewed by Tim Horton.
2388
2389         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
2390         interacting with the UI. See WebKit ChangeLogs for more detail.
2391
2392         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2393         (WTR::UIScriptController::setTimePickerValue):
2394         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2395         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2396         (WTR::UIScriptController::setTimePickerValue):
2397         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2398         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2399         (WTR::UIScriptController::setTimePickerValue):
2400
2401 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2402
2403         [LayoutFormattingContext] Initial commit.
2404         https://bugs.webkit.org/show_bug.cgi?id=184896
2405
2406         Reviewed by Antti Koivisto.
2407
2408         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2409
2410 2018-04-23  Chris Dumez  <cdumez@apple.com>
2411
2412         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
2413         https://bugs.webkit.org/show_bug.cgi?id=184801
2414
2415         Reviewed by Geoffrey Garen.
2416
2417         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
2418         This is a more common configuration and therefore should be the default testing configuration.
2419
2420         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2421         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2422         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
2423         is now asked for the policy decision.
2424
2425 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
2426
2427         [GTK][WPE] Add Debug bots (build and tests) for WPE
2428         https://bugs.webkit.org/show_bug.cgi?id=184887
2429
2430         Reviewed by Carlos Alberto Lopez Perez.
2431
2432         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
2433         wpe-linux-bot-4
2434
2435         Both bots have already the credentials ready to authenticated against
2436         build.webkit.org. They provides the bots for the "debug" configuration over
2437         the "WPE" platform and building for the "x86_64" architecture:
2438         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
2439
2440         * BuildSlaveSupport/build.webkit.org-config/config.json:
2441         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2442
2443 2018-04-23  Chris Dumez  <cdumez@apple.com>
2444
2445         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
2446         https://bugs.webkit.org/show_bug.cgi?id=184848
2447         <rdar://problem/39145306>
2448
2449         Reviewed by Brady Eidson.
2450
2451         Add API test coverage.
2452
2453         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2454         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2455         (TEST):
2456
2457 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2458
2459         [GTK][WPE] TestSSL fails due to additional TLS errors returned
2460         https://bugs.webkit.org/show_bug.cgi?id=184860
2461
2462         Reviewed by Carlos Garcia Campos.
2463
2464         Add script and config file for regenerating the test certificate.
2465         Regenerate it. TestSSL no longer fails on my machine.
2466
2467         I do see a ton of network process crashes and JavaScript errors, none of
2468         which prevent the test from passing, but this commit only claims to fix
2469         the certificate validation portion of the test.
2470
2471         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
2472         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
2473         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
2474
2475 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2476
2477         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
2478         https://bugs.webkit.org/show_bug.cgi?id=184815
2479
2480         Reviewed by Michael Catanzaro.
2481
2482         This is because in the test we are calling both join and detach. We should only call join.
2483
2484         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2485         (testsJSCVirtualMachine):
2486
2487 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2488
2489         [GLIB] Test /jsc/prototypes crashes in debug
2490         https://bugs.webkit.org/show_bug.cgi?id=184814
2491
2492         Reviewed by Michael Catanzaro.
2493
2494         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
2495
2496         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2497         (barCreate):
2498         (barFree):
2499
2500 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2501
2502         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
2503         https://bugs.webkit.org/show_bug.cgi?id=184804
2504
2505         Reviewed by Carlos Garcia Campos.
2506
2507         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2508         (WebSocketTest::WebSocketTest):
2509         (WebSocketTest::~WebSocketTest):
2510         (WebSocketTest::serverWebSocketCallback):
2511         (WebSocketTest::webSocketTestResultCallback):
2512         (WebSocketTest::connectToServerAndWaitForEvents):
2513         (testWebSocketTLSErrors):
2514         (beforeAll):
2515
2516 2018-04-20  Chris Dumez  <cdumez@apple.com>
2517
2518         Unreviewed, update 2 more API tests after r230876.
2519
2520         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2521         (TEST):
2522         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2523         (TestWebKitAPI::TEST):
2524
2525 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2526
2527         Adjust geolocation feature flag
2528         https://bugs.webkit.org/show_bug.cgi?id=184856
2529
2530         Reviewed by Wenson Hsieh.
2531
2532         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2533
2534 2018-04-20  Chris Dumez  <cdumez@apple.com>
2535
2536         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
2537         https://bugs.webkit.org/show_bug.cgi?id=184210
2538         <rdar://problem/39072354>
2539
2540         Reviewed by Wenson Hsieh.
2541
2542         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
2543         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
2544         Add viewport meta tags.
2545
2546         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2547         (-[WKWebView _test_waitForDidFinishNavigation]):
2548         Update _test_waitForDidFinishNavigation to wait for the next presentation update
2549         to make iOS API tests happy without having to modify each of them.
2550
2551 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2552
2553         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
2554
2555         https://bugs.webkit.org/show_bug.cgi?id=184849
2556         rdar://problem/39386405
2557
2558         Reviewed by Brian Burg.
2559
2560         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
2561         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
2562         CGColor pointer from NSColor each time.
2563
2564 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2565
2566         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
2567         https://bugs.webkit.org/show_bug.cgi?id=184822
2568         <rdar://problem/38807319>
2569
2570         Reviewed by Tim Horton.
2571
2572         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
2573         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
2574         SPI. See other ChangeLogs for more detail.
2575
2576         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2577         (WTR::UIScriptController::enterText):
2578         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2579
2580         Add UIScriptController support for simulating text entry in the currently focused element.
2581
2582         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2583         (WTR::UIScriptController::enterText):
2584         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2585         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2586
2587         Add TestRunner bindings for registering injected bundle form client callbacks.
2588
2589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2590         (WTR::handleTextDidChangeInTextField):
2591         (WTR::handleTextFieldDidBeginEditing):
2592         (WTR::handleTextFieldDidEndEditing):
2593         (WTR::InjectedBundle::didCreatePage):
2594
2595         Set the injected bundle form editor client.
2596
2597         (WTR::InjectedBundle::setUpInjectedBundleClients):
2598         (WTR::InjectedBundle::textDidChangeInTextField):
2599         (WTR::InjectedBundle::textFieldDidBeginEditing):
2600         (WTR::InjectedBundle::textFieldDidEndEditing):
2601         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2602         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2603         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2604         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2605         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2606         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2607         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2608         (WTR::TestRunner::textFieldDidEndEditingCallback):
2609         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2610         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2611         (WTR::UIScriptController::enterText):
2612
2613 2018-04-20  Youenn Fablet  <youenn@apple.com>
2614
2615         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2616         https://bugs.webkit.org/show_bug.cgi?id=184369
2617
2618         Reviewed by Chris Dumez.
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2621         (TEST):
2622
2623 2018-04-20  Daniel Bates  <dabates@apple.com>
2624
2625         Remove Strong Password decoration when text field type changes
2626         https://bugs.webkit.org/show_bug.cgi?id=184795
2627         <rdar://problem/38325108>
2628
2629         Reviewed by Antti Koivisto.
2630
2631         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2632         when the field has the Strong Password button and its type changes.
2633
2634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2635         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2636         (didResignInputElementStrongPasswordAppearance):
2637         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2638         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2639         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2640         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2641         (TEST):
2642
2643 2018-04-20  Brady Eidson  <beidson@apple.com>
2644
2645         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2646         https://bugs.webkit.org/show_bug.cgi?id=184807
2647
2648         Reviewed by Chris Dumez.
2649
2650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2651         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2652
2653 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2654
2655         Unreviewed. Mark TestJSC as slow in debug.
2656
2657         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2658
2659         * TestWebKitAPI/glib/TestExpectations.json:
2660
2661 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2662
2663         [GTK] Local cross references are broken in API documentation
2664         https://bugs.webkit.org/show_bug.cgi?id=184771
2665
2666         Reviewed by Michael Catanzaro.
2667
2668         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2669         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2670         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2671         the cases.
2672
2673         * gtk/gtkdoc.py:
2674         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2675         anything here.
2676         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2677         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2678         which gtkdoc-fixxref always uses absolute paths.
2679         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2680
2681 2018-04-19  Brady Eidson  <beidson@apple.com>
2682
2683         Make back forward cache work with process swapping.
2684         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2685
2686         Reviewed by Chris Dumez.
2687
2688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2689
2690 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2691
2692         Enable Objective-C weak references
2693         <https://webkit.org/b/184789>
2694         <rdar://problem/39571716>
2695
2696         Reviewed by Dan Bernstein.
2697
2698         * ContentExtensionTester/Configurations/Base.xcconfig:
2699         (CLANG_ENABLE_OBJC_WEAK): Enable.
2700         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2701         (CLANG_ENABLE_OBJC_WEAK): Enable.
2702         * ImageDiff/cg/Configurations/Base.xcconfig:
2703         (CLANG_ENABLE_OBJC_WEAK): Enable.
2704         * MiniBrowser/Configurations/Base.xcconfig:
2705         (CLANG_ENABLE_OBJC_WEAK): Enable.
2706         * TestWebKitAPI/Configurations/Base.xcconfig:
2707         (CLANG_ENABLE_OBJC_WEAK): Enable.
2708         * WebEditingTester/Configurations/Base.xcconfig:
2709         (CLANG_ENABLE_OBJC_ARC): Re-order.
2710         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2711         end of file.
2712         (CLANG_ENABLE_OBJC_WEAK): Enable.
2713         * WebKitTestRunner/Configurations/Base.xcconfig:
2714         (CLANG_ENABLE_OBJC_WEAK): Enable.
2715
2716 2018-04-19  Chris Dumez  <cdumez@apple.com>
2717
2718         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2719         https://bugs.webkit.org/show_bug.cgi?id=184209
2720         <rdar://problem/39145306>
2721
2722         Reviewed by Ryosuke Niwa.
2723
2724         Add API test coverage.
2725
2726         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2727         (TEST):
2728
2729 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2730
2731         [WinCairo][EWS] Build bot should clean user temp directory each time.
2732         https://bugs.webkit.org/show_bug.cgi?id=184761
2733
2734         Reviewed by Lucas Forschler.
2735
2736         * EWSTools/Start-Queue.ps1:
2737         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2738
2739 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2740
2741         Buildbots using Python zipfile should enable compression
2742         https://bugs.webkit.org/show_bug.cgi?id=184759
2743
2744         Reviewed by Lucas Forschler.
2745
2746         * BuildSlaveSupport/built-product-archive:
2747         (createZipManually):
2748         Default is to archive without compressing, so tell it to compress as well. 
2749
2750 2018-04-18  Nan Wang  <n_wang@apple.com>
2751
2752         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2753         https://bugs.webkit.org/show_bug.cgi?id=184742
2754
2755         Reviewed by Chris Fleizach.
2756
2757         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2758         (AccessibilityUIElement::increment):
2759         (AccessibilityUIElement::decrement):
2760         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2761         (WTR::AccessibilityUIElement::asyncIncrement):
2762         (WTR::AccessibilityUIElement::asyncDecrement):
2763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2764         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2765         (WTR::AccessibilityUIElement::increment):
2766         (WTR::AccessibilityUIElement::decrement):
2767         (WTR::AccessibilityUIElement::asyncIncrement):
2768         (WTR::AccessibilityUIElement::asyncDecrement):
2769
2770 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2771
2772         Fix archive step for WinCairo build bot.
2773         https://bugs.webkit.org/show_bug.cgi?id=184715
2774
2775         Reviewed by Lucas Forschler.
2776
2777         * BuildSlaveSupport/built-product-archive:
2778         (archiveBuiltProduct):
2779         (extractBuiltProduct):
2780
2781 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2782
2783         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2784         https://bugs.webkit.org/show_bug.cgi?id=184570
2785         <rdar://problem/34807323>
2786
2787         Reviewed by Chris Dumez.
2788
2789         Add API test coverage.
2790
2791         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2792         (TEST):
2793
2794 2018-04-18  Chris Dumez  <cdumez@apple.com>
2795
2796         Add support for converting a local window to a remote window
2797         https://bugs.webkit.org/show_bug.cgi?id=184515
2798         <rdar://problem/39011318>
2799
2800         Reviewed by Ryosuke Niwa.
2801
2802         * MiniBrowser/mac/AppDelegate.m:
2803         (defaultConfiguration):
2804         * MiniBrowser/mac/SettingsController.h:
2805         * MiniBrowser/mac/SettingsController.m:
2806         (-[SettingsController _populateMenu]):
2807         (-[SettingsController validateMenuItem:]):
2808         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2809         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2810         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2813         Turn on process swap on cross-origin window.open() for corresponding test and update
2814         test to expect that a new WebProcess is created.
2815
2816         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2817         (WTR::InjectedBundlePage::decidePolicyForResponse):
2818         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2819         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2820         In this new process, we have constructed a InjectedBundlePage for the page but we
2821         have not initialized the InjectedBundle members such as testRunner.
2822
2823         * WebKitTestRunner/TestController.cpp:
2824         (WTR::TestController::createWebViewWithOptions):
2825         (WTR::updateTestOptionsFromTestHeader):
2826         * WebKitTestRunner/TestOptions.h:
2827         (WTR::TestOptions::hasSameInitializationOptions const):
2828         Add a way for layout tests to turn on process swap on navigation via a test header.
2829
2830 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2831
2832         Unreviewed, reland r230697, r230720, and r230724.
2833         https://bugs.webkit.org/show_bug.cgi?id=184600
2834
2835         * Scripts/run-jsc-stress-tests:
2836
2837 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2838
2839         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2840         https://bugs.webkit.org/show_bug.cgi?id=184687
2841
2842         Reviewed by Michael Catanzaro.
2843
2844         Add test cases for the new API.
2845
2846         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2847         (fooCreate):
2848         (fooFree):
2849         (fooGetProperty):
2850         (fooSetProperty):
2851         (testJSCPromises):
2852         (testJSCGarbageCollector):
2853         (testsJSCVirtualMachine):
2854         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2855         (windowObjectClearedCallback):
2856
2857 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2858
2859         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2860         https://bugs.webkit.org/show_bug.cgi?id=184635
2861         <rdar://problem/39440642>
2862
2863         Reviewed by Tim Horton.
2864
2865         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2866         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2867
2868         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2869         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2870         (-[TestRunnerWKWebView dealloc]):
2871         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2872         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2873         (-[TestRunnerWKWebView _keyboardDidShow:]):
2874         (-[TestRunnerWKWebView _keyboardDidHide:]):
2875         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2876         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2877
2878 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2879
2880         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2881         https://bugs.webkit.org/show_bug.cgi?id=184573
2882
2883         Reviewed by Carlos Alberto Lopez Perez.
2884
2885         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2886         (TestWebKitAPI::TEST):
2887
2888 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2889
2890         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2891         https://bugs.webkit.org/show_bug.cgi?id=184524
2892
2893         Reviewed by Alex Christensen.
2894
2895         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2896
2897         * TestWebKitAPI/PlatformWebView.h:
2898         * TestWebKitAPI/PlatformWin.cmake:
2899         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2900         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2901         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2902         (TestWebKitAPI::Util::moduleDirectory):
2903         (TestWebKitAPI::Util::createInjectedBundlePath):
2904         (TestWebKitAPI::Util::createURLForResource):
2905         (TestWebKitAPI::Util::URLForNonExistentResource):
2906         (TestWebKitAPI::Util::isKeyDown):
2907         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2908         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2909         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2910         (TestWebKitAPI::PlatformWebView::initialize):
2911         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2912         (TestWebKitAPI::PlatformWebView::page const):
2913         (TestWebKitAPI::PlatformWebView::resizeTo):
2914         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2915         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2916         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2917         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2918         (TestWebKitAPI::PlatformWebView::wndProc):
2919         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2920         (TestWebKitAPI::Util::run):
2921         (TestWebKitAPI::Util::spinRunLoop):
2922         (TestWebKitAPI::Util::sleep):
2923
2924 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2925
2926         Fix hasher tests for system with 32 bit longs
2927         https://bugs.webkit.org/show_bug.cgi?id=184708
2928         <rdar://problem/39459977>
2929
2930         Reviewed by Mark Lam.
2931
2932         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2933
2934         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2935         (TestWebKitAPI::TEST):
2936
2937 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2938
2939         Unreviewed, rolling out r230697, r230720, and r230724.
2940         https://bugs.webkit.org/show_bug.cgi?id=184717
2941
2942         These caused multiple failures on the Test262 testers.
2943         (Requested by mlewis13 on #webkit).
2944
2945         Reverted changesets:
2946
2947         "[WebAssembly][Modules] Prototype wasm import"
2948         https://bugs.webkit.org/show_bug.cgi?id=184600
2949         https://trac.webkit.org/changeset/230697
2950
2951         "[WebAssembly][Modules] Implement function import from wasm
2952         modules"
2953         https://bugs.webkit.org/show_bug.cgi?id=184689
2954         https://trac.webkit.org/changeset/230720
2955
2956         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2957         https://bugs.webkit.org/show_bug.cgi?id=184703
2958         https://trac.webkit.org/changeset/230724
2959
2960 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2961
2962         Unreviewed rollout of r230632. Regression in memory usage.
2963
2964         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2965
2966         * DumpRenderTree/TestOptions.h:
2967         * DumpRenderTree/mac/DumpRenderTree.mm:
2968         (runTest):
2969         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2970         * WebKitTestRunner/TestController.cpp:
2971         (WTR::TestController::resetPreferencesToConsistentValues):
2972         * WebKitTestRunner/TestOptions.cpp:
2973         (WTR::TestOptions::TestOptions):
2974         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2975         * WebKitTestRunner/TestOptions.h:
2976
2977 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2978
2979         [JSC] Rename runWebAssembly to runWebAssemblySuite
2980         https://bugs.webkit.org/show_bug.cgi?id=184703
2981
2982         Reviewed by JF Bastien.
2983
2984         * Scripts/run-jsc-stress-tests:
2985
2986 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2987
2988         [WebAssembly][Modules] Implement function import from wasm modules
2989         https://bugs.webkit.org/show_bug.cgi?id=184689
2990
2991         Reviewed by JF Bastien.
2992
2993         Add runWebAssemblyDirect, which runs wasm file directly.
2994
2995         * Scripts/run-jsc-stress-tests:
2996
2997 2018-04-17  Saam Barati  <sbarati@apple.com>
2998
2999         Add system trace points for process launch and for initializeWebProcess
3000         https://bugs.webkit.org/show_bug.cgi?id=184669
3001
3002         Reviewed by Simon Fraser.
3003
3004         * Tracing/SystemTracePoints.plist:
3005
3006 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
3007
3008         Add debug bots for WinCairo.
3009         https://bugs.webkit.org/show_bug.cgi?id=184663
3010
3011         Reviewed by Lucas Forschler.
3012
3013         * BuildSlaveSupport/build.webkit.org-config/config.json:
3014         Add a debug build bot and two debug test bots.
3015
3016         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3017         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3018         Add a WinCairo category to build.webkit.org.
3019
3020 2018-04-17  Zalan Bujtas  <zalan@apple.com>
3021
3022         [LayoutReloaded] Set inline-block box position.
3023         https://bugs.webkit.org/show_bug.cgi?id=184690
3024
3025         Reviewed by Antti Koivisto.
3026
3027         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3028         (InlineFormattingContext.prototype._handleInlineBlock):
3029         * LayoutReloaded/Utils.js:
3030         (Utils._dumpBox):
3031         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
3032
3033 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3034
3035         [GLIB] Add API to clear JSCContext uncaught exception
3036         https://bugs.webkit.org/show_bug.cgi?id=184685
3037
3038         Reviewed by Žan Doberšek.
3039
3040         Add test cases for the new API.
3041
3042         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3043         (testJSCExceptions):
3044
3045 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3046
3047         [GLIB] Add API to query, delete and enumerate properties
3048         https://bugs.webkit.org/show_bug.cgi?id=184647
3049
3050         Reviewed by Michael Catanzaro.
3051
3052         Add test cases for the new API.
3053
3054         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3055         (testJSCObject):
3056         (testJSCClass):
3057         (testJSCPrototypes):
3058
3059 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3060
3061         [LayoutReloaded] Add support for replaced box.
3062         https://bugs.webkit.org/show_bug.cgi?id=184680
3063
3064         Reviewed by Antti Koivisto.
3065
3066         Basic support for inline replaced.
3067
3068         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3069         (InlineFormattingContext.prototype._handleInlineBox):
3070         (InlineFormattingContext.prototype._handleInlineBlock):
3071         (InlineFormattingContext.prototype._handleReplaced):
3072         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3073         (Line.prototype.lastLineBox):
3074         (Line.prototype.addInlineBox):
3075         (Line.prototype.addInlineContainerBox): Deleted.
3076         * LayoutReloaded/TreeBuilder.js:
3077         (TreeBuilder.prototype._createAndAttachBox):
3078         * LayoutReloaded/Utils.js:
3079         (Utils._dumpBox):
3080         * LayoutReloaded/test/index.html:
3081         * LayoutReloaded/test/inline-simple-replaced.html: Added.
3082
3083 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3084
3085         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
3086         https://bugs.webkit.org/show_bug.cgi?id=184679
3087
3088         Reviewed by Antti Koivisto.
3089
3090         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3091         (InlineFormattingContext):
3092         (InlineFormattingContext.prototype.layout):
3093         (InlineFormattingContext.prototype._handleInlineContainer):
3094         (InlineFormattingContext.prototype._handleInlineContent):
3095         (InlineFormattingContext.prototype._handleInlineBlock):
3096         (InlineFormattingContext.prototype._handleReplacedBox):
3097         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
3098         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
3099         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
3100
3101 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3102
3103         [LayoutReloaded] Introduce fragmentation state/context.
3104         https://bugs.webkit.org/show_bug.cgi?id=184677
3105
3106         Reviewed by Antti Koivisto.
3107
3108         State/context for fragmented content (multicol, regions, pagination etc).
3109
3110         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
3111         (FragmentationContext):
3112         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
3113         (FragmentationState):
3114         (FragmentationState.prototype.formattingState):
3115
3116 2018-04-16  Andy Estes  <aestes@apple.com>
3117
3118         [iOS] Enable WKPDFView by default
3119         https://bugs.webkit.org/show_bug.cgi?id=184675
3120         <rdar://problem/27885452>
3121
3122         Reviewed by Darin Adler.
3123
3124         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3125
3126 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
3127
3128         Perl-based Test262 runner
3129         https://bugs.webkit.org/show_bug.cgi?id=183343
3130
3131         Reviewed by Michael Saboff.
3132
3133         * Scripts/test262-helpers/README.md: Added.
3134         * Scripts/test262-helpers/agent.js: Added.
3135         (262.getGlobal):
3136         (262.setGlobal):
3137         (262.destroy):
3138         (262.IsHTMLDDA):
3139         * Scripts/test262-helpers/cpanfile: Added.
3140         * Scripts/test262-helpers/cpanfile.snapshot: Added.
3141         * Scripts/test262-helpers/test262-runner.pl: Added.
3142         (main):
3143         (processFile):
3144         (getScenarios):
3145         (addScenario):
3146         (compileTest):
3147         (runTest):
3148         (processResult):
3149         (getTempFile):
3150         (getContents):
3151         (parseData):
3152         (getHarness):
3153         * Scripts/test262-helpers/tests.log: Added.
3154
3155 2018-04-15  Andy Estes  <aestes@apple.com>
3156
3157         [iOS] Add API tests for PDF find-in-page
3158         https://bugs.webkit.org/show_bug.cgi?id=184634
3159
3160         Reviewed by Dan Bernstein.
3161
3162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3163         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
3164         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3165         (-[TestFindDelegate findString]):
3166         (-[TestFindDelegate _webView:didCountMatches:forString:]):
3167         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
3168         (-[TestFindDelegate _webView:didFailToFindString:]):
3169         (loadWebView):
3170         (TEST):
3171
3172 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3173
3174         [LayoutReloaded] Update class documentation
3175         https://bugs.webkit.org/show_bug.cgi?id=184625
3176
3177         Reviewed by Antti Koivisto.
3178
3179         * LayoutReloaded/DisplayTree/Box.js:
3180         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3181         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
3182         * LayoutReloaded/FormattingContext/FloatingContext.js:
3183         * LayoutReloaded/FormattingContext/FormattingContext.js:
3184         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3185         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3186         * LayoutReloaded/FormattingState/BlockFormattingState.js:
3187         * LayoutReloaded/FormattingState/FloatingState.js:
3188         * LayoutReloaded/FormattingState/FormattingState.js:
3189         * LayoutReloaded/FormattingState/InlineFormattingState.js:
3190         * LayoutReloaded/LayoutState.js:
3191         * LayoutReloaded/LayoutTree/BlockContainer.js:
3192         * LayoutReloaded/LayoutTree/Box.js:
3193         * LayoutReloaded/LayoutTree/Container.js:
3194         * LayoutReloaded/LayoutTree/InlineBox.js:
3195         * LayoutReloaded/LayoutTree/InlineContainer.js:
3196         * LayoutReloaded/LayoutTree/Text.js:
3197         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
3198         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
3199         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
3200         * LayoutReloaded/misc/headers/Box.h: Removed.
3201         * LayoutReloaded/misc/headers/Container.h: Removed.
3202         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
3203         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
3204         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
3205         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
3206         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
3207         * LayoutReloaded/misc/headers/Line.h: Removed.
3208         * LayoutReloaded/misc/headers/Text.h: Removed.
3209
3210 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3211
3212         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
3213         https://bugs.webkit.org/show_bug.cgi?id=184621
3214
3215         Reviewed by Antti Koivisto.
3216
3217         This is just a simple, mark ancestors dirty implementation.
3218
3219         * LayoutReloaded/FormattingState/FormattingState.js:
3220         (FormattingState.prototype.markNeedsLayout):
3221         * LayoutReloaded/LayoutState.js:
3222         (LayoutState.prototype.markNeedsLayout):
3223         (LayoutState.prototype.setNeedsLayoutById): Deleted.
3224         (LayoutState.prototype.setNeedsLayout): Deleted.
3225         * LayoutReloaded/TreeBuilder.js:
3226         (TreeBuilder.prototype._createAndAttachBox):
3227         (TreeBuilder.prototype._findBox): Deleted.
3228         * LayoutReloaded/Utils.js:
3229         (Utils.layoutBoxById):
3230         * LayoutReloaded/test/index.html:
3231         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
3232
3233 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3234
3235         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
3236         https://bugs.webkit.org/show_bug.cgi?id=184595
3237
3238         Reviewed by Michael Catanzaro.
3239
3240         Ensure Driver.check_driver() is checked at check_sys_deps() time.
3241
3242         * Scripts/webkitpy/port/wpe.py:
3243         (WPEPort.check_sys_deps):
3244
3245 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3246
3247         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
3248
3249         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3250
3251 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
3252
3253         Boot fewer simulators in CI/EWS machines
3254         https://bugs.webkit.org/show_bug.cgi?id=184594
3255         <rdar://problem/39188082>
3256
3257         Reviewed by Alexey Proskuryakov.
3258
3259         This is a temporary workaround fro <rdar://problem/39393590>.
3260
3261         * Scripts/webkitpy/xcode/simulated_device.py:
3262         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
3263
3264 2018-04-13  Brady Eidson  <beidson@apple.com>
3265
3266         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
3267         https://bugs.webkit.org/show_bug.cgi?id=184559
3268
3269         Reviewed by Alex Christensen.
3270
3271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3272
3273 2018-04-13  Chris Dumez  <cdumez@apple.com>
3274
3275         input.webkitEntries does not work as expected when folder contains accented chars
3276         https://bugs.webkit.org/show_bug.cgi?id=184517
3277         <rdar://problem/39265537>
3278
3279         Reviewed by Alex Christensen.
3280
3281         Add API test coverage.
3282
3283         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3284         (TestWebKitAPI::TEST_F):
3285
3286 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
3287
3288         Update my emails ordering in contributors.json
3289         https://bugs.webkit.org/show_bug.cgi?id=184587
3290
3291         Rubber-stamped by Philippe Normand.
3292
3293         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
3294
3295         * Scripts/webkitpy/common/config/contributors.json:
3296
3297 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3298
3299         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
3300         https://bugs.webkit.org/show_bug.cgi?id=184388
3301
3302         Reviewed by Carlos Alberto Lopez Perez.
3303
3304         Remove libxkbcommon from the JHBuild environment. We could alternatively add
3305         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
3306         not believe it depends on anything else in the JHBuild environment.
3307
3308         * wpe/install-dependencies:
3309         * wpe/jhbuild.modules:
3310
3311 2018-04-12  Antoine Quint  <graouts@apple.com>
3312
3313         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3314         https://bugs.webkit.org/show_bug.cgi?id=184569
3315         <rdar://problem/38671301>
3316
3317         Reviewed by Jon Lee.
3318
3319         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
3320         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
3321
3322         * DumpRenderTree/TestOptions.h:
3323         * DumpRenderTree/mac/DumpRenderTree.mm:
3324         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
3325         (runTest):
3326         * WebKitTestRunner/TestController.cpp:
3327         (WTR::TestController::resetPreferencesToConsistentValues):
3328         * WebKitTestRunner/TestOptions.cpp:
3329         (WTR::isLegacyAnimationEngineTestPath):
3330         (WTR::TestOptions::TestOptions):
3331         * WebKitTestRunner/TestOptions.h:
3332
3333 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3334
3335         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
3336         https://bugs.webkit.org/show_bug.cgi?id=184531
3337
3338         Reviewed by Michael Catanzaro.
3339
3340         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
3341         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
3342         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
3343         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
3344         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
3345
3346         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3347         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
3348         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
3349         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
3350         (TestWebKitAPI::Util::sleep): Ditto.
3351
3352 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3353
3354         [LayoutReloaded] Add support for incremental layout
3355         https://bugs.webkit.org/show_bug.cgi?id=184578
3356
3357         Reviewed by Antti Koivisto.
3358
3359         * LayoutReloaded/Layout.js:
3360         (layout):
3361         * LayoutReloaded/LayoutState.js:
3362         (LayoutState.prototype.rootContainer):
3363         (LayoutState.prototype.setNeedsLayoutById):
3364         * LayoutReloaded/Utils.js:
3365         (Utils.layoutTreeDump):
3366         * LayoutReloaded/test/TestHarness.js:
3367         (verifyLayout):
3368         (runLayout):
3369         (verifyLayoutTreeDump): Deleted.
3370         * LayoutReloaded/test/index.html:
3371         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
3372
3373 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3374
3375         [LayoutReloaded] Move root container ownership to layout state
3376         https://bugs.webkit.org/show_bug.cgi?id=184575
3377
3378         Reviewed by Antti Koivisto.
3379
3380         Now the root container is on the associated layout state (ICB only at this point though).
3381
3382         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3383         (BlockFormattingContext.prototype.layout):
3384         * LayoutReloaded/FormattingContext/FormattingContext.js:
3385         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3386         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3387         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3388         (InlineFormattingContext.prototype._handleFloatingBox):
3389         * LayoutReloaded/Layout.js:
3390         (layout):
3391         * LayoutReloaded/LayoutState.js:
3392         (LayoutState):
3393         (LayoutState.prototype.formattingContext):
3394         (LayoutState.prototype.establishedFormattingState):
3395         (LayoutState.prototype.formattingStateForBox):
3396         (LayoutState.prototype.needsLayout):
3397         (LayoutState.prototype.displayBox):
3398         (LayoutState.prototype._formattingContext):
3399         (LayoutState.prototype.layout): Deleted.
3400         (LayoutState.prototype.formattingStates): Deleted.
3401         (LayoutState.prototype.initialDisplayBox): Deleted.
3402         * LayoutReloaded/Utils.js:
3403         (Utils._dumpBox):
3404         (Utils._findDisplayBox): Deleted.
3405
3406 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
3407
3408         Fix --build-directory flag for run-webkit-tests
3409         https://bugs.webkit.org/show_bug.cgi?id=184545
3410         <rdar://problem/39385080>
3411
3412         Rubber-stamped by Aakash Jain.
3413
3414         The --build-directory path does not work with iOS-Simulator.
3415
3416         * Scripts/webkitpy/port/base.py:
3417         (Port._build_path): Use the port configuration to calculate the root directory.
3418         * Scripts/webkitpy/port/base_unittest.py:
3419         (PortTest.test_build_path): Test build directories for embedded configurations.
3420
3421 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
3422
3423         pemfile.py should not assume POSIX line endings
3424         https://bugs.webkit.org/show_bug.cgi?id=184507
3425
3426         Reviewed by Daniel Bates.
3427
3428         * Scripts/webkitpy/common/system/pemfile.py:
3429         (_parse_pem_format):
3430         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3431         (PemFileTest.test_parse_crlf):
3432         (PemFileTest.test_parse_cr):
3433
3434 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3435
3436         [LayoutReloaded] Minor cleanup in LayoutSate
3437         https://bugs.webkit.org/show_bug.cgi?id=184546
3438
3439         Reviewed by Antti Koivisto.
3440
3441         * LayoutReloaded/FormattingContext/FormattingContext.js:
3442         (FormattingContext.isInFormattingContext):
3443         * LayoutReloaded/FormattingState/FormattingState.js:
3444         (FormattingState.prototype.displayBoxes):
3445         (FormattingState.prototype.displayBox):
3446         (FormattingState.prototype._markSubTreeNeedsLayout):
3447         (FormattingState):
3448         (FormattingState.prototype.displayBoxMap): Deleted.
3449         * LayoutReloaded/LayoutState.js:
3450         (LayoutState.prototype.formattingStateForBox):
3451         (LayoutState.prototype.needsLayout):
3452         (LayoutState.prototype.displayBox):
3453         (LayoutState.prototype._createFormattingState):
3454         (LayoutState):
3455         * LayoutReloaded/LayoutTree/Box.js:
3456         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
3457         * LayoutReloaded/LayoutTree/Container.js:
3458         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
3459         * LayoutReloaded/Utils.js:
3460         (Utils._findDisplayBox):
3461
3462 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3463
3464         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
3465         https://bugs.webkit.org/show_bug.cgi?id=184538
3466
3467         Reviewed by Antti Koivisto.
3468
3469         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3470         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3471         (BlockFormattingContext):
3472         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
3473         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
3474         * LayoutReloaded/FormattingContext/FormattingContext.js:
3475         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3476         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3477         (FormattingContext):
3478         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3479         (InlineFormattingContext.prototype.layout):
3480         (InlineFormattingContext.prototype._handleInlineContainer):
3481         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3482         (InlineFormattingContext.prototype._handleInlineContent):
3483         (InlineFormattingContext.prototype._clearAndMoveToNext):
3484         (InlineFormattingContext):
3485
3486 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3487
3488         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
3489         https://bugs.webkit.org/show_bug.cgi?id=184528
3490
3491         Reviewed by Philippe Normand.
3492
3493         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
3494
3495 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
3496
3497         [WPE] Switch testing process to using WPEBackend-fdo
3498         https://bugs.webkit.org/show_bug.cgi?id=184357
3499
3500         Reviewed by Carlos Alberto Lopez Perez.
3501
3502         Switch WPE testing to using the WPEBackend-fdo implementation that
3503         depends on the WL_bind_wayland_display EGL extension, as defined under
3504         the freedesktop.org project.
3505         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
3506
3507         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
3508         otherwise is not changed in functionality.
3509
3510         Unit tests now have to unconditionally use HeadlessViewBackend as a
3511         wpe_view_backend provider, since WPEBackend-fdo does not provide a
3512         default wpe_view_backend implementation. Unit tests covering that are
3513         adjusted to instead use a mock wpe_view_backend interface.
3514
3515         * Scripts/webkitdirs.pm:
3516         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
3517         the API version that was added in r230449.
3518         * Scripts/webkitpy/port/waylanddriver.py:
3519         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
3520         * Scripts/webkitpy/port/wpe.py:
3521         (WPEPort._driver_class): Use WaylandDriver by default.
3522         * TestWebKitAPI/PlatformWebView.h:
3523         (): Deleted.
3524         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3525         (testWebViewWebBackend):
3526         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3527         (Test::createWebViewBackend):
3528         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
3529         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3530         (TestWebKitAPI::PlatformWebView::initialize):
3531         * wpe/HeadlessViewBackend/CMakeLists.txt:
3532         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3533         (getEGLDisplay):
3534         (HeadlessViewBackend::HeadlessViewBackend):
3535         (HeadlessViewBackend::~HeadlessViewBackend):
3536         (HeadlessViewBackend::backend const):
3537         (HeadlessViewBackend::createSnapshot):
3538         (HeadlessViewBackend::performUpdate):
3539         (HeadlessViewBackend::makeCurrent): Deleted.
3540         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3541         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
3542
3543 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3544
3545         [GTK] Switch to use always complex text code path
3546         https://bugs.webkit.org/show_bug.cgi?id=183285
3547
3548         Reviewed by Michael Catanzaro.
3549
3550         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
3551
3552         * WebKitTestRunner/gtk/main.cpp:
3553         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
3554
3555 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3556
3557         [GLIB] Handle strings containing null characters
3558         https://bugs.webkit.org/show_bug.cgi?id=184450
3559
3560         Reviewed by Michael Catanzaro.
3561
3562         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
3563
3564         * TestWebKitAPI/PlatformGTK.cmake:
3565         * TestWebKitAPI/PlatformWPE.cmake:
3566         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3567         (testJSCBasic):
3568         (testJSCFunction):
3569         (testJSCObject):
3570         (testJSCClass):
3571         (testJSCPrototypes):
3572         (testJSCExceptions):
3573         (testJSCPromises):
3574         (testJSCGarbageCollector):
3575         (testJSCWeakValue):
3576         (testsJSCVirtualMachine):
3577         (testsJSCAutocleanups):
3578         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
3579         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
3580         (DOMElementTest::testAutoFill):
3581         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3582         (WebKitWebEditorTest::testSelectionChanged):
3583         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3584         (WebKitFrameTest::testJavaScriptValues):
3585         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3586         (consoleMessageSentCallback):
3587         (methodCallCallback):
3588
3589 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
3590
3591         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
3592         https://bugs.webkit.org/show_bug.cgi?id=184513
3593
3594         Reviewed by Michael Catanzaro.
3595
3596         Update the WPE-specific testWebViewWebBackend() test case, removing the
3597         test that passes a null WebKitWebViewBackend object to the
3598         webkit_web_view_new() call.
3599
3600         Helper createWebViewBackend() that's called via Test::createWebView()
3601         variations is updated to, in case of not using the headless backend,
3602         return a WebKitWebViewBackend instance that wraps around a
3603         default wpe_view_backend object.
3604
3605         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3606         (testWebViewWebBackend):
3607         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3608         (Test::createWebViewBackend):
3609
3610 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3611
3612         [LayoutReloaded] Introduce needsLayout flag
3613         https://bugs.webkit.org/show_bug.cgi?id=184527
3614
3615         Reviewed by Antti Koivisto.
3616
3617         Use the formatting state to mark boxes dirty.
3618
3619         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3620         (BlockFormattingContext.prototype.layout):
3621         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3622         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3623         (BlockFormattingContext):
3624         * LayoutReloaded/FormattingContext/FormattingContext.js:
3625         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3626         * LayoutReloaded/FormattingState/FormattingState.js:
3627         (FormattingState):
3628         (FormattingState.prototype.markNeedsLayout):
3629         (FormattingState.prototype.clearNeedsLayout):
3630         (FormattingState.prototype.needsLayout):
3631         (FormattingState.prototype.layoutNeeded):
3632         (FormattingState.prototype._markSubTreeNeedsLayout):
3633         * LayoutReloaded/LayoutState.js:
3634         (LayoutState.prototype.formattingStateForBox):
3635         (LayoutState.prototype.setNeedsLayout):
3636         (LayoutState.prototype.needsLayout):
3637         * LayoutReloaded/LayoutTree/Box.js:
3638         (Layout.Box.prototype.isFormattingContextDescendant):
3639         * LayoutReloaded/LayoutTree/Container.js:
3640         (Layout.Container.prototype.isContainingBlockDescendant):
3641
3642 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3643
3644         Fix TestInvocation class for newer versions of clang.
3645         https://bugs.webkit.org/show_bug.cgi?id=184508
3646         <rdar://problem/39328648>
3647
3648         Reviewed by Alexey Proskuryakov.
3649
3650         Declare TestInvocation to be final so it does not require a virtual destructor.
3651
3652         * WebKitTestRunner/TestInvocation.h:
3653
3654 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3655
3656         IDN spoofing with Hebrew combining characters
3657         https://bugs.webkit.org/show_bug.cgi?id=184472
3658         <rdar://problem/39148687>
3659
3660         Reviewed by Brent Fulgham.
3661
3662         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3663         (TestWebKitAPI::TEST):
3664
3665 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3666
3667         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3668         https://bugs.webkit.org/show_bug.cgi?id=184352
3669         <rdar://problem/39237683>
3670
3671         Reviewed by Andy Estes.
3672
3673         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3674         popover's UITableViewController (for testing purposes).
3675
3676         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3677         (WTR::UIScriptController::selectFormPopoverTitle const):