c1dae08db554bf9e34dd68c13b0c57ce1939db5a
[WebKit-https.git] / Tools / ChangeLog
1 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2
3         Improve HTTP test names in WebKitTestRunner's crash report information
4         https://bugs.webkit.org/show_bug.cgi?id=157389
5
6         Reviewed by Alex Christensen.
7
8         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
9         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
10
11         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
12         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
13         use other port numbers too. For http tests, return the complete URL string, not
14         just the path.
15
16 2016-05-04  Alex Christensen  <achristensen@webkit.org>
17
18         Blocked redirected main resource requests need descriptive errors
19         https://bugs.webkit.org/show_bug.cgi?id=156828
20         rdar://problem/25711316
21
22         Reviewed by Daniel Bates.
23
24         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
25         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
26         Print out the error type to make sure we have the most descriptive error type.
27
28 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
29
30         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
31         https://bugs.webkit.org/show_bug.cgi?id=157341
32
33         Reviewed by Xabier Rodriguez-Calvar.
34
35         * gtk/jhbuild.modules:
36         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
37         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
38
39 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
40
41         Add JSC test results in JSON format to a Buildbot log
42         https://bugs.webkit.org/show_bug.cgi?id=156920
43
44         Reviewed by Daniel Bates.
45
46         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
47         (RunJavaScriptCoreTests): Move command-line option for output file out
48         of WithProperties.
49
50 2016-05-04  Dean Jackson  <dino@apple.com>
51
52         TestRunner should always enable all the experimental features
53         https://bugs.webkit.org/show_bug.cgi?id=157360
54         <rdar://problem/26099748>
55
56         Reviewed by Anders Carlsson.
57
58         Call the new SPI that enables all the experimental features.
59
60         * WebKitTestRunner/TestController.cpp:
61         (WTR::TestController::resetPreferencesToConsistentValues):
62
63 2016-05-04  Mark Lam  <mark.lam@apple.com>
64
65         ES6 Function.name inferred from property names of literal objects can break some websites.
66         https://bugs.webkit.org/show_bug.cgi?id=157246
67
68         Reviewed by Geoffrey Garen.
69
70         * WebKitTestRunner/TestController.cpp:
71         (WTR::TestController::resetPreferencesToConsistentValues):
72         (WTR::updateTestOptionsFromTestHeader):
73         * WebKitTestRunner/TestOptions.h:
74
75         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
76         (WTR::PlatformWebView::viewSupportsOptions):
77         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
78         (WTR::PlatformWebView::viewSupportsOptions):
79         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
80
81 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
82
83         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
84         https://bugs.webkit.org/show_bug.cgi?id=157331
85
86         Reviewed by Chris Fleizach.
87
88         Add AXLandmarkRegion to the landmark strings handled by roleToString
89         for objects with ATK_ROLE_LANDMARK.
90
91         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
92
93 2016-05-03  Beth Dakin  <bdakin@apple.com>
94
95         Add VideoControlsManager tests
96         https://bugs.webkit.org/show_bug.cgi?id=157332
97         -and corresponding-
98         rdar://problem/24358431
99
100         Reviewed by Sam Weinig.
101
102         This patch adds three VideoControlsManager tests.
103
104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
105         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
106         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
107         (-[DidPlayMessageHandler initWithWKWebView:]):
108         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
109         (TestWebKitAPI::TEST):
110         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
111         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
112         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
113
114 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
115
116         [ATK] accessibility/document-attributes.html is failing
117         https://bugs.webkit.org/show_bug.cgi?id=125348
118
119         Reviewed by Chris Fleizach.
120
121         The test was failing because the WebArea is now being exposed with the role of
122         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
123         change was made, documentEncoding() and documentURI() were not updated accordingly.
124
125         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
126         (WTR::AccessibilityUIElement::documentEncoding):
127         (WTR::AccessibilityUIElement::documentURI):
128
129 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
130
131         [Win] Unreviewed build fix.
132
133         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
134         environment at start of queue run.
135
136 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
137
138         [ATK] accessibility/content-editable-as-textarea.html fails
139         https://bugs.webkit.org/show_bug.cgi?id=155353
140
141         Reviewed by Darin Adler.
142
143         The test was timing out because it expected an AXValueChanged notification.
144         In ATK, AXValueChanged notifications are made for widgets which implement
145         the AtkValue interface (sliders, progress bars, etc.). We should be listening
146         for AXTextChanged instead. AtkText's text-insert and text-remove have been
147         added to the AccessibilityNotificationHandler.
148
149         Also, ATK's AccessibilityUIElement support had a number of unimplemented
150         methods that are being used as part of the previously-failing test. Those
151         methods are now implemented so that the ATK results are much more similar
152         to those on the Mac.
153
154         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
155         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
156         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
157         (WTR::AccessibilityUIElement::stringAttributeValue):
158         (WTR::AccessibilityUIElement::rangeForLine):
159         (WTR::AccessibilityUIElement::boundsForRange):
160         (WTR::AccessibilityUIElement::attributedStringForRange):
161
162 2016-05-02  Brady Eidson  <beidson@apple.com>
163
164         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
165         https://bugs.webkit.org/show_bug.cgi?id=157274
166
167         Reviewed by Alex Christensen.
168
169         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
170         and reset them in between tests:
171         * DumpRenderTree/TestRunner.cpp:
172         (accummulateLogsForChannel):
173         (TestRunner::staticFunctions):
174         (TestRunner::waitToDumpWatchdogTimerFired):
175         (TestRunner::setAccummulateLogsForChannel):
176         * DumpRenderTree/TestRunner.h:
177         * DumpRenderTree/mac/DumpRenderTree.mm:
178         (resetWebViewToConsistentStateBeforeTesting):
179
180         Also add the new method to WKTR's TestRunner, but just stubbed for now:
181         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
183         (WTR::TestRunner::accummulateLogsForChannel):
184         * WebKitTestRunner/InjectedBundle/TestRunner.h:
185
186 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
187
188         Add fail-fast option to run-javascriptcore-tests
189         https://bugs.webkit.org/show_bug.cgi?id=157270
190
191         Reviewed by Geoffrey Garen.
192
193         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
194         Defaults to yes, which is the current behavior.
195
196 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
197
198         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
199         https://bugs.webkit.org/show_bug.cgi?id=157268
200
201         Reviewed by Michael Catanzaro.
202
203         * MiniBrowser/gtk/CMakeLists.txt:
204
205 2016-04-30  Darin Adler  <darin@apple.com>
206
207         Streamline and remove unused bindings generation code
208         https://bugs.webkit.org/show_bug.cgi?id=157237
209
210         Reviewed by Chris Dumez.
211
212         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
213         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
214         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
215         Replace non-standard "int" with standard "long", which means the same thing.
216
217 2016-04-30  Darin Adler  <darin@apple.com>
218
219         Next batch of conversions to use C++ enum class instead of strings for enumerations
220         https://bugs.webkit.org/show_bug.cgi?id=157232
221
222         Reviewed by Chris Dumez.
223
224         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
225         checking. We don't want to waste time trying to make our generated code match our style.
226
227 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
228
229         Add JSC test results in JSON format to a Buildbot log.
230         https://bugs.webkit.org/show_bug.cgi?id=156920
231
232         Reviewed by Daniel Bates.
233
234         Generate JSON results for JSC tests and upload them to the master
235         using Buildbot's logfiles machinery.
236
237         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
238         (RunJavaScriptCoreTests): Use --json-output option when invoking the
239         run-javascriptcore-tests Perl script, and expose this JSON output as a 
240         Buildbot log.
241         * Scripts/run-javascriptcore-tests:
242         (runJSCStressTests): Change key names and remove redundant count key.
243
244 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
245
246         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
247         https://bugs.webkit.org/show_bug.cgi?id=146719
248
249         Reviewed by Chris Fleizach.
250
251         Implement roleDescription() so that the implementation can be tested.
252
253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
254         (WTR::AccessibilityUIElement::roleDescription):
255
256 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
257
258         Don't throttle GuardMalloc on 8-core Macs
259         https://bugs.webkit.org/show_bug.cgi?id=157108
260
261         Reviewed by Alex Christensen.
262
263         This was making them slower unnecessarily.
264
265         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
266
267 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
268
269         Unreviewed: add myself to the committers list.
270
271         * Scripts/webkitpy/common/config/contributors.json:
272
273 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
274
275         Fix text in log files autogenerated by import-w3c-tests
276         https://bugs.webkit.org/show_bug.cgi?id=157021
277
278         Unreviewed. Fixing the second typo.
279
280         * Scripts/webkitpy/w3c/test_importer.py:
281         (TestImporter.write_import_log):
282
283 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
284
285         WebCore on Mac ignores the user's preferred region (country) while getting the language
286         https://bugs.webkit.org/show_bug.cgi?id=156993
287
288         Reviewed by Geoffrey Garen.
289
290         Change the test expectations for this test. If the variant is not explicitly specified in
291         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
292
293         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
294         (TestWebKitAPI::languageForSystemLanguage):
295         (TestWebKitAPI::TEST):
296
297 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
298
299         Remove the build flag for template elements
300         https://bugs.webkit.org/show_bug.cgi?id=157022
301
302         Reviewed by Daniel Bates.
303
304         Removed the build option.
305
306         * Scripts/webkitperl/FeatureList.pm:
307
308 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
309
310         Fix text in log files autogenerated by import-w3c-tests
311         https://bugs.webkit.org/show_bug.cgi?id=157021
312
313         Reviewed by Chris Dumez.
314
315         s/Webkit/WebKit/ and end each sentence with a period.
316
317         * Scripts/webkitpy/w3c/test_importer.py:
318         (TestImporter.write_import_log):
319
320 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
321
322         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
323         https://bugs.webkit.org/show_bug.cgi?id=156929
324
325         Reviewed by Darin Adler.
326
327         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
328         (TestWebKitAPI::TEST):
329
330 2016-04-25  Caitlin Potter  <caitp@igalia.com>
331
332         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
333         https://bugs.webkit.org/show_bug.cgi?id=156976
334
335         Reviewed by Darin Adler.
336
337         Mitigate style-checker spam on bugs which introduce new JavaScript
338         token types.
339
340         * Scripts/webkitpy/style/checkers/cpp.py:
341         (_EnumState.__init__):
342         (_EnumState.process_clean_line):
343         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
344         (NoNonVirtualDestructorsTest.test_enum_casing):
345
346 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
347
348         Fix issues with content-animation performance tests
349         https://bugs.webkit.org/show_bug.cgi?id=157001
350
351         Reviewed by Sam Weinig.
352
353         Add patch content for svg-animation.html, and fix the paths in the patch so
354         it applies correctly.
355
356         Add the patch file to the .plan file.
357
358         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
359         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
360
361 2016-04-25  Brady Eidson  <beidson@apple.com>
362
363         Tweaking IndexedDB watchlist and adding myself to it.
364
365         * Scripts/webkitpy/common/config/watchlist:
366
367 2016-04-25  Commit Queue  <commit-queue@webkit.org>
368
369         Unreviewed, rolling out r199916.
370         https://bugs.webkit.org/show_bug.cgi?id=156989
371
372         Might break buildbot when master is restarted (Requested by
373         Srinivasan Vijayaraghava, Guest100, on #webkit).
374
375         Reverted changeset:
376
377         "Add JSC test results in json format to a buildbot log"
378         https://bugs.webkit.org/show_bug.cgi?id=156920
379         http://trac.webkit.org/changeset/199916
380
381 2016-04-23  Chris Dumez  <cdumez@apple.com>
382
383         [WebIDL] Drop [Default] WebKit-IDL extended attribute
384         https://bugs.webkit.org/show_bug.cgi?id=156955
385
386         Reviewed by Darin Adler.
387
388         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
389
390 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
391
392         Really enable INDEXED_DATABASE on Apple Mac cmake build
393         https://bugs.webkit.org/show_bug.cgi?id=156902
394
395         Reviewed by Michael Catanzaro.
396
397         * Scripts/webkitperl/FeatureList.pm:
398
399 2016-04-23  Andy Estes  <aestes@apple.com>
400
401         check-webkit-style: fix false-positive warnings about @synchronized
402         https://bugs.webkit.org/show_bug.cgi?id=156957
403
404         Reviewed by Dan Bernstein.
405
406         * Scripts/webkitpy/style/checkers/cpp.py:
407         (check_spacing_for_function_call): Ignore @synchronized lines.
408         (check_braces): Ditto.
409         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
410         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
411
412 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
413
414         Add JSC test results in json format to a buildbot log
415         https://bugs.webkit.org/show_bug.cgi?id=156920
416
417         Reviewed by Alexey Proskuryakov.
418
419         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
420         (RunJavaScriptCoreTests):
421         Add runtime flag to output json into buildbot
422         * Scripts/run-javascriptcore-tests:
423         (runJSCStressTests):
424         Change key names and remove redundant count key
425
426 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
427
428         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
429
430         Unreviewed test gardening.
431
432         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
433         (TestWebKitAPI::TEST):
434
435 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
436
437         [GTK] Enable the download attribute support
438         https://bugs.webkit.org/show_bug.cgi?id=99025
439
440         Reviewed by Žan Doberšek.
441
442         * Scripts/webkitperl/FeatureList.pm:
443
444 2016-04-21  Keith Miller  <keith_miller@apple.com>
445
446         WebScriptObject description swizzler should work in a multi-threaded world
447         https://bugs.webkit.org/show_bug.cgi?id=156808
448
449         Add a test for our NSObject swizzling TLS implementation. The test runs on
450         two threads. One in JS and another in Objective-C. We expect the JS thread
451         to use our NSObject description override and the Objective-C thread to act
452         as though it was using the original NSObject description method.
453
454         Reviewed by Geoffrey Garen.
455
456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
457         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
458         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
459         (nsObjectDescriptionTest):
460         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
461         (TestWebKitAPI::TEST):
462
463 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
464
465         [GTK] WebKitWebView should claim the contents size as its natural size
466         https://bugs.webkit.org/show_bug.cgi?id=156835
467
468         Reviewed by Žan Doberšek.
469
470         Add test case to check the WebKitWebView preferred size.
471
472         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
473         (testWebViewPreferredSize):
474         (beforeAll):
475
476 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
477
478         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
479         https://bugs.webkit.org/show_bug.cgi?id=156827
480         
481         Update the .plan file now that the files are present in SVN.
482
483         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
484
485 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
486
487         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
488         https://bugs.webkit.org/show_bug.cgi?id=156827
489         rdar://problem/24358135
490
491         Reviewed by Stephanie Lewis.
492
493         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
494         and collate results across them. Also add the ability for the browser_driver to supply
495         additional results, allowing for tests that collect results data in native code, rather
496         than generating it in the web page.
497
498         Add a set of "content animation" tests that use this new functionality, which test
499         CSS animation and requestAnimationFrame performance.
500
501         'plan' files have two new optional keys:
502             'test_files': a list of files to run as a suite
503             'options': optional parameters. Currently supports one new option,
504                 'animation_command', which affects the way that iOS tests are run,
505                 and is passed to MobileSafari as a parameter on launch.
506
507         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
508         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
509         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
510         (BenchmarkRunner):
511         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
512         running a single test. It starts and stops the http_server_driver.
513         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
514         key, otherwise look for the new 'test_files' and load each in a loop.
515         (BenchmarkRunner._dump):
516         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
517         (BrowserDriver.launch_url): Pass options.
518         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
519         (BrowserDriver):
520         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
521         (GTKMiniBrowserDriver.launch_url):
522         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
523         (OSXBrowserDriver.close_browsers):
524         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
525         (OSXBrowserDriver._terminiate_processes): Deleted.
526         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
527         (OSXChromeDriver.launch_url):
528         (OSXChromeCanaryDriver.launch_url):
529         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
530         (OSXFirefoxDriver.launch_url):
531         (OSXFirefoxNightlyDriver.launch_url):
532         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
533         (OSXSafariDriver.launch_url):
534         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
535         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
536
537 2016-04-20  Dustin Falgout  <dustin@falgout.us>
538
539         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
540         https://bugs.webkit.org/show_bug.cgi?id=156651
541
542         Reviewed by Michael Catanzaro.
543
544         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
545         (testWebKitSettings):
546
547 2016-04-20  Brady Eidson  <beidson@apple.com>
548
549         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
550         https://bugs.webkit.org/show_bug.cgi?id=156782
551
552         Reviewed by Alex Christensen.
553
554         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
555
556 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
557
558         Unreviewed build fix after r199752.
559
560         * DumpRenderTree/win/FrameLoadDelegate.cpp:
561         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
562
563 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
564
565         Remove remaining bits of dynamic <link> rel='icon' loading
566         https://bugs.webkit.org/show_bug.cgi?id=156727
567
568         Reviewed by Darin Adler.
569
570         Remove unused test infrastructure. This code never existed in WebKit2
571         testing since was only used on Windows.
572
573         * DumpRenderTree/TestRunner.cpp:
574         (dumpIconChangesCallback): Deleted.
575         * DumpRenderTree/TestRunner.h:
576         (TestRunner::dumpIconChanges): Deleted.
577         (TestRunner::setDumpIconChanges): Deleted.
578
579 2016-04-19  Keith Miller  <keith_miller@apple.com>
580
581         ObjcInstance::stringValue should not call NSObject's description method
582         https://bugs.webkit.org/show_bug.cgi?id=156758
583
584         Reviewed by Geoffrey Garen.
585
586         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
587         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
588         call the NSObjects description method without first swizzling it.
589
590         * DumpRenderTree/mac/ObjCController.m:
591         (+[ObjCController isSelectorExcludedFromWebScript:]):
592         (+[ObjCController webScriptNameForSelector:]):
593         (-[ObjCController testArrayOfObjects]):
594         (-[ObjCController testObject]):
595
596 2016-04-18  Dan Bernstein  <mitz@apple.com>
597
598         Fixed building with old Xcode.
599
600         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
601         (TEST):
602
603 2016-04-18  Dean Jackson  <dino@apple.com>
604
605         New SPI to export a dictionary of runtime features
606         https://bugs.webkit.org/show_bug.cgi?id=156645
607         <rdar://problem/23621666>
608
609         Reviewed by Darin Adler.
610
611         Test the experimental features SPI on WKPreferences.
612
613         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
614
615 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
616
617         [JSCOnly] Implement RunLoop and remove glib dependency
618         https://bugs.webkit.org/show_bug.cgi?id=155706
619
620         Reviewed by Michael Catanzaro.
621
622         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
623         Platform specific ones locate under jsconly directory since
624         it is not `generic` (Since it includes the GLIB event loop case).
625
626         * CMakeLists.txt:
627         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
628         * TestWebKitAPI/PlatformUtilities.h:
629         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
630         (TestWebKitAPI::TEST):
631         * TestWebKitAPI/config.h:
632         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
633         (TestWebKitAPI::Util::run):
634         (TestWebKitAPI::Util::sleep):
635         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
636         (main):
637
638 2016-04-18  Jon Lee  <jonlee@apple.com>
639
640         Update Animometer plan.
641         https://bugs.webkit.org/show_bug.cgi?id=156652
642
643         Reviewed by Darin Adler.
644
645         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
646
647 2016-04-18  Dana Burkart  <dburkart@apple.com>
648
649         svn-apply: add option for ignoring changes to ChangeLog files
650         https://bugs.webkit.org/show_bug.cgi?id=156618
651
652         Reviewed by Darin Adler.
653
654         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
655         patch() if the file in question is a ChangeLog.
656
657         * Scripts/svn-apply:
658         (patch):
659
660 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
661
662         Pending API Request URL is wrong after reloading
663         https://bugs.webkit.org/show_bug.cgi?id=139342
664
665         Reviewed by Darin Adler.
666
667         Update test case to check that the active URL should remain the
668         same after a reload.
669
670         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
671         (TestWebKitAPI::TEST):
672
673 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
674
675         Pending API request URL no set when loading Data, Alternate HTML or plain text
676         https://bugs.webkit.org/show_bug.cgi?id=136916
677
678         Reviewed by Darin Adler.
679
680         Add new test to check that active URL is the requested one right
681         after calling WKPage load methods.
682
683         * TestWebKitAPI/PlatformEfl.cmake:
684         * TestWebKitAPI/PlatformGTK.cmake:
685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
686         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
687         (TestWebKitAPI::TEST):
688         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
689         (WebViewTest::loadPlainText): Remove FIXME.
690         (WebViewTest::loadBytes): Ditto.
691         (WebViewTest::loadAlternateHTML): Ditto.
692
693 2016-04-18  Commit Queue  <commit-queue@webkit.org>
694
695         Unreviewed, rolling out r199660.
696         https://bugs.webkit.org/show_bug.cgi?id=156691
697
698         It broke the iOS build (Requested by KaL on #webkit).
699
700         Reverted changeset:
701
702         "Pending API request URL no set when loading Data, Alternate
703         HTML or plain text"
704         https://bugs.webkit.org/show_bug.cgi?id=136916
705         http://trac.webkit.org/changeset/199660
706
707 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
708
709         Pending API request URL no set when loading Data, Alternate HTML or plain text
710         https://bugs.webkit.org/show_bug.cgi?id=136916
711
712         Reviewed by Darin Adler.
713
714         Add new test to check that active URL is the requested one right
715         after calling WKPage load methods.
716
717         * TestWebKitAPI/PlatformEfl.cmake:
718         * TestWebKitAPI/PlatformGTK.cmake:
719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
720         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
721         (TestWebKitAPI::TEST):
722         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
723         (WebViewTest::loadPlainText): Remove FIXME.
724         (WebViewTest::loadBytes): Ditto.
725         (WebViewTest::loadAlternateHTML): Ditto.
726
727 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
728
729         Fix incorrect assumption that APPLE implies Mac.
730         https://bugs.webkit.org/show_bug.cgi?id=156679
731
732         Addresses build failure introduced in r198947
733
734         Reviewed by Alex Christensen.
735
736         * CMakeLists.txt:
737
738 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
741         https://bugs.webkit.org/show_bug.cgi?id=156621
742
743         Reviewed by Martin Robinson.
744
745         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
746         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
747         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
748
749         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
750         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
751
752 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
753
754         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
755         https://bugs.webkit.org/show_bug.cgi?id=156655
756
757         Reviewed by Antonio Gomes.
758
759         To support html5 video feature, we should bump gstreamer version.
760
761         * efl/jhbuild.modules:
762         * efl/patches/gst-libav.patch: Update against newer version.
763         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
764
765 2016-04-16  Sam Weinig  <sam@webkit.org>
766
767         More build fixing.
768
769         * MiniBrowser/mac/BrowserWindowController.m:
770         (-[BrowserWindowController share:]):
771
772 2016-04-16  Sam Weinig  <sam@webkit.org>
773
774         Another build fix.
775
776         * MiniBrowser/mac/BrowserWindowController.m:
777         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
778
779 2016-04-16  Sam Weinig  <sam@webkit.org>
780
781         Fix 32-bit build.
782
783         * MiniBrowser/mac/BrowserWindowController.m:
784         (-[BrowserWindowController share:]):
785         (-[BrowserWindowController fetch:]):
786         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
787
788 2016-04-15  Sam Weinig  <sam@webkit.org>
789
790         Add support for NSSharingService to MiniBrowser, for no great reasons
791         https://bugs.webkit.org/show_bug.cgi?id=156658
792
793         Reviewed by Darin Adler.
794
795         * MiniBrowser/mac/BrowserWindow.xib:
796         * MiniBrowser/mac/BrowserWindowController.h:
797         Add the share button.
798
799         * MiniBrowser/mac/BrowserWindowController.m:
800         (-[BrowserWindowController windowDidLoad]):
801         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
802
803         (-[BrowserWindowController share:]):
804         Show the picker when the button is pressed.
805         (-[BrowserWindowController mainContentView]):
806         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
807
808         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
809         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
810         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
811         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
812         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
813         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
814         Add delegate methods.
815
816         * MiniBrowser/mac/WK1BrowserWindowController.m:
817         (-[WK1BrowserWindowController mainContentView]):
818         * MiniBrowser/mac/WK2BrowserWindowController.m:
819         (-[WK2BrowserWindowController mainContentView]):
820         Implement to return the web view.
821
822 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
823
824         Build fix.
825
826         Temporary workaround for rdar://problem/25754945.
827
828         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
829
830 2016-04-15  Commit Queue  <commit-queue@webkit.org>
831
832         Unreviewed, rolling out r199600.
833         https://bugs.webkit.org/show_bug.cgi?id=156642
834
835         It didn't help (Requested by ap_ on #webkit).
836
837         Reverted changeset:
838
839         "Build fix."
840         http://trac.webkit.org/changeset/199600
841
842 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
843
844         Build fix.
845
846         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
847
848 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
849
850         Some GuardMalloc bots are not happy when running many parallel processes
851         https://bugs.webkit.org/show_bug.cgi?id=156614
852         rdar://problem/24711525
853
854         Reviewed by David Kilzer.
855
856         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
857
858 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
859
860         Make <a download> a runtime enabled option
861         https://bugs.webkit.org/show_bug.cgi?id=156583
862         <rdar://problem/25733449>
863
864         Reviewed by Alex Christensen.
865
866         * DumpRenderTree/mac/DumpRenderTree.mm:
867         (resetWebPreferencesToConsistentValues):
868         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
869         (WTR::InjectedBundle::beginTesting):
870         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
871         (WTR::TestRunner::setDownloadAttributeEnabled):
872         * WebKitTestRunner/InjectedBundle/TestRunner.h:
873
874 2016-04-14  Anders Carlsson  <andersca@apple.com>
875
876         Another build fix attempt.
877
878         * MiniBrowser/mac/WK2BrowserWindowController.m:
879
880 2016-04-14  Anders Carlsson  <andersca@apple.com>
881
882         Fix build.
883
884         * MiniBrowser/mac/WK2BrowserWindowController.m:
885         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
886
887 2016-04-14  Anders Carlsson  <andersca@apple.com>
888
889         [Mac] Add API for open panel handling to WKWebView
890         https://bugs.webkit.org/show_bug.cgi?id=137759
891         rdar://problem/23278623
892
893         Reviewed by Tim Horton.
894
895         Have MiniBrowser implement the new delegate method.
896
897         * MiniBrowser/mac/WK2BrowserWindowController.m:
898         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
899
900 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
901
902         Unreviewed, rolling out r199554.
903
904         The change breaks Yosemite Release/Debug build
905
906         Reverted changeset:
907
908         "[Mac] Add API for open panel handling to WKWebView"
909         https://bugs.webkit.org/show_bug.cgi?id=137759
910         http://trac.webkit.org/changeset/199554
911
912 2016-04-14  Anders Carlsson  <andersca@apple.com>
913
914         [Mac] Add API for open panel handling to WKWebView
915         https://bugs.webkit.org/show_bug.cgi?id=137759
916         rdar://problem/23278623
917
918         Reviewed by Tim Horton.
919
920         Have MiniBrowser implement the new delegate method.
921
922         * MiniBrowser/mac/WK2BrowserWindowController.m:
923         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
924
925 2016-04-14  Jon Lee  <jonlee@apple.com>
926
927         Update Animometer plan
928         https://bugs.webkit.org/show_bug.cgi?id=156569
929
930         Reviewed by Alex Christensen.
931
932         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
933         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
934
935 2016-04-13  Alex Christensen  <achristensen@webkit.org>
936
937         CMake MiniBrowser should be an app bundle
938         https://bugs.webkit.org/show_bug.cgi?id=156521
939
940         Reviewed by Brent Fulgham.
941
942         * MiniBrowser/mac/CMakeLists.txt:
943         Make an app bundle and compile nibs.
944         * MiniBrowser/mac/Info.plist:
945         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
946
947 2016-04-13  Chris Dumez  <cdumez@apple.com>
948
949         We should not speculatively revalidate cached redirects
950         https://bugs.webkit.org/show_bug.cgi?id=156548
951         <rdar://problem/25583886>
952
953         Reviewed by Darin Adler.
954
955         Re-enable speculative loading in the context of layout tests. This was
956         turned off by mistake when speculative loading was turned into a
957         setting recently.
958
959         * WebKitTestRunner/TestController.cpp:
960         (WTR::TestController::generatePageConfiguration):
961
962 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
963
964         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
965         https://bugs.webkit.org/show_bug.cgi?id=155367
966
967         Reviewed by Darin Adler.
968
969         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
970         Don't flakily consume the return code with waitpid, callers need to do waitpid on
971         their own. Not sure if this line of code was even intentional.
972
973 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
974
975         [OS X] Flakey crash after ScrollAnimatorMac destruction
976         https://bugs.webkit.org/show_bug.cgi?id=156372
977
978         Reviewed by Darin Adler.
979
980         Implement the new <!-- webkit-test-runner --> flag.
981
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::createWebViewWithOptions):
984         (WTR::TestController::ensureViewSupportsOptionsForTest):
985         (WTR::TestController::resetPreferencesToConsistentValues):
986         (WTR::TestController::resetStateToConsistentValues):
987         (WTR::updateTestOptionsFromTestHeader):
988         * WebKitTestRunner/TestController.h:
989         * WebKitTestRunner/TestInvocation.cpp:
990         (WTR::TestInvocation::invoke):
991         * WebKitTestRunner/TestOptions.h:
992         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
993         (WKR::PlatformWebView::viewSupportsOptions):
994
995 2016-04-12  Tomas Popela  <tpopela@redhat.com>
996
997         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
998         https://bugs.webkit.org/show_bug.cgi?id=156338
999
1000         Reviewed by Michael Catanzaro.
1001
1002         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
1003         for the i686 where it is supported and not for other architectures
1004         (such as s390(x) and ppc(64)) where the build will fail with these
1005         CXXFLAGS.
1006
1007         * Scripts/webkitdirs.pm:
1008         (generateBuildSystemFromCMakeProject):
1009
1010 2016-04-11  Alex Christensen  <achristensen@webkit.org>
1011
1012         Build MiniBrowser with CMake on Mac
1013         https://bugs.webkit.org/show_bug.cgi?id=156471
1014
1015         Reviewed by Daniel Bates.
1016
1017         * CMakeLists.txt:
1018         * DumpRenderTree/CMakeLists.txt:
1019         * DumpRenderTree/PlatformWin.cmake:
1020         * MiniBrowser/mac/CMakeLists.txt: Added.
1021
1022 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
1023
1024         [EFL] Do not pass context to EwkViewCreate
1025         https://bugs.webkit.org/show_bug.cgi?id=156461
1026
1027         Reviewed by Darin Adler.
1028
1029         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1030         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
1031         * TestWebKitAPI/efl/PlatformWebView.cpp:
1032         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
1033         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1034         (WTR::PlatformWebView::PlatformWebView): Ditto.
1035
1036 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
1037
1038         [CMake] Make FOLDER property INHERITED
1039         https://bugs.webkit.org/show_bug.cgi?id=156460
1040
1041         Reviewed by Brent Fulgham.
1042
1043         * CMakeLists.txt:
1044         * DumpRenderTree/CMakeLists.txt:
1045         * DumpRenderTree/PlatformWin.cmake:
1046         * ImageDiff/CMakeLists.txt:
1047         * MiniBrowser/efl/CMakeLists.txt:
1048         * MiniBrowser/gtk/CMakeLists.txt:
1049         * MiniBrowser/win/CMakeLists.txt:
1050         Set FOLDER property as a directory property not a target property
1051
1052 2016-04-10  Caitlin Potter  <caitp@igalia.com>
1053
1054         [Tools] correctly check for braces in multiline branches in macro definition
1055         https://bugs.webkit.org/show_bug.cgi?id=156441
1056
1057         Reviewed by Darin Adler.
1058
1059         Prevents emitting whitespace/braces warning for code like the
1060         following:
1061
1062         ```
1063         #define MACRO(x) \
1064             if (x) { \
1065                 doTheThing(); \
1066                 continue; \
1067             }
1068         ```
1069
1070         * Scripts/webkitpy/style/checkers/cpp.py:
1071         (check_braces):
1072         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1073         (WebKitStyleTest.test_line_breaking):
1074
1075 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1076
1077         Testharness-based tests that time out should be able to produce a detailed output
1078         https://bugs.webkit.org/show_bug.cgi?id=145313
1079
1080         Reviewed by Xabier Rodriguez-Calvar.
1081
1082         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
1083
1084         * DumpRenderTree/TestRunner.cpp:
1085         (getTimeoutCallback): The js "timeout" property getter.
1086         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
1087         * DumpRenderTree/TestRunner.h:
1088         (TestRunner::timeout): Adding access to DRT m_timeout private value.
1089         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
1090         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
1091         (WTR::TestRunner::timeout):
1092
1093 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1094
1095         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
1096         https://bugs.webkit.org/show_bug.cgi?id=156387
1097
1098         Rubber-stamped by Dan Bernstein.
1099
1100         * Scripts/webkitpy/style/checkers/featuredefines.py:
1101         (FeatureDefinesChecker.check):
1102
1103 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1104
1105         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
1106         https://bugs.webkit.org/show_bug.cgi?id=156384
1107
1108         Reviewed by Ryosuke Niwa.
1109
1110         * Scripts/webkitperl/FeatureList.pm:
1111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1112
1113 2016-04-06  Dean Jackson  <dino@apple.com>
1114
1115         Watchlist modifications:
1116         - remove roger_fong
1117         - add myself to a few areas
1118         - remove graouts from WebInspectorAPI
1119
1120         * Scripts/webkitpy/common/config/watchlist:
1121
1122 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
1123
1124         Make it possible to test effect of view exposed rect on tiled backing
1125         https://bugs.webkit.org/show_bug.cgi?id=156365
1126
1127         Reviewed by Tim Horton.
1128
1129         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
1130         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
1131
1132         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
1133         can't easily resize a window to larger than the screen being tested on.
1134
1135         * DumpRenderTree/TestRunner.cpp:
1136         (setViewSizeCallback):
1137         (TestRunner::staticFunctions):
1138         * DumpRenderTree/TestRunner.h:
1139         * DumpRenderTree/mac/TestRunnerMac.mm:
1140         (TestRunner::setViewSize):
1141         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1142         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1143         (WTR::InjectedBundle::postSetViewSize):
1144         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1145         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1146         (WTR::TestRunner::setViewSize):
1147         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1148         * WebKitTestRunner/TestInvocation.cpp:
1149         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1150
1151 2016-04-07  Jason Marcell  <jmarcell@apple.com>
1152
1153         Adding layout tests for the bot watcher's dashboard QUnit tests.
1154         https://bugs.webkit.org/show_bug.cgi?id=155272
1155
1156         Reviewed by Daniel Bates.
1157
1158         Moved supporting resources into a resources folder and updated index.html accordingly
1159         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
1163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
1164         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
1165         (MockBuildbotQueue):
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
1167         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
1168         (MockBuildbotQueueView):
1169         (MockBuildbotQueueView.prototype._latestProductiveIteration):
1170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
1171         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
1172         (MockTrac):
1173         (MockTrac.prototype.get oldestRecordedRevisionNumber):
1174         (MockTrac.prototype.get latestRecordedRevisionNumber):
1175         (MockTrac.prototype.loadMoreHistoricalData):
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
1177         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
1178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
1179         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
1181         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
1182         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
1183         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
1184         * Scripts/run-dashboard-tests: Added.
1185
1186 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
1187
1188         Unreviewed, Update my primary email address and expertise.
1189
1190         * Scripts/webkitpy/common/config/contributors.json:
1191
1192 2016-04-06  Jon Lee  <jonlee@apple.com>
1193
1194         Update the Animometer patch and plan files
1195         https://bugs.webkit.org/show_bug.cgi?id=156263
1196
1197         Reviewed by Ryosuke Niwa.
1198
1199         Measure the latest set of tests by updating the plan revision to r199134.
1200
1201         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
1202         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
1203         of the developer page.
1204
1205 2016-04-06  Saam barati  <sbarati@apple.com>
1206
1207         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
1208         https://bugs.webkit.org/show_bug.cgi?id=156187
1209
1210         Reviewed by Keith Miller.
1211
1212         * Scripts/run-jsc-stress-tests:
1213
1214 2016-04-06  Alex Christensen  <achristensen@webkit.org>
1215
1216         Compile WebKitTestRunner with CMake on Mac
1217         https://bugs.webkit.org/show_bug.cgi?id=156310
1218
1219         Reviewed by Daniel Bates.
1220
1221         * CMakeLists.txt:
1222         * WebKitTestRunner/CMakeLists.txt:
1223         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1224         * WebKitTestRunner/PlatformEfl.cmake:
1225         * WebKitTestRunner/PlatformGTK.cmake:
1226         * WebKitTestRunner/PlatformMac.cmake: Added.
1227
1228 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
1229
1230         Implement operator== and operator!= for Optional<>
1231         https://bugs.webkit.org/show_bug.cgi?id=156266
1232
1233         Reviewed by Anders Carlsson.
1234
1235         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1236         (TestWebKitAPI::TEST):
1237
1238 2016-04-05  Alex Christensen  <achristensen@webkit.org>
1239
1240         Make CMake-generated binaries on Mac able to run
1241         https://bugs.webkit.org/show_bug.cgi?id=156268
1242
1243         Reviewed by Daniel Bates.
1244
1245         * DumpRenderTree/CMakeLists.txt:
1246         * DumpRenderTree/PlatformMac.cmake:
1247         * DumpRenderTree/PlatformWin.cmake:
1248         * TestWebKitAPI/PlatformMac.cmake:
1249
1250 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1251
1252         [Fetch API] Add a runtime flag to fetch API and related constructs
1253         https://bugs.webkit.org/show_bug.cgi?id=156113
1254  
1255         Reviewed by Alex Christensen.
1256
1257         * DumpRenderTree/TestRunner.h:
1258         * DumpRenderTree/mac/DumpRenderTree.mm:
1259         (resetWebPreferencesToConsistentValues):
1260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1261         (WTR::InjectedBundle::beginTesting):
1262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1263         (WTR::TestRunner::setWebGL2Enabled):
1264         (WTR::TestRunner::setFetchAPIEnabled):
1265         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
1266         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1267
1268 2016-04-05  Keith Miller  <keith_miller@apple.com>
1269
1270         Make Keith a reviewer!
1271         https://bugs.webkit.org/show_bug.cgi?id=156246
1272
1273         Reviewed by Mark Lam.
1274
1275         * Scripts/webkitpy/common/config/contributors.json:
1276
1277 2016-04-05  Antoine Quint  <graouts@apple.com>
1278
1279         [WebGL2] Allow enabling WebGL2 with a runtime flag
1280         https://bugs.webkit.org/show_bug.cgi?id=156166
1281         <rdar://problem/25526929>
1282
1283         Always enable WebGL2 during testing.
1284
1285         Reviewed by Dean Jackson.
1286
1287         * DumpRenderTree/mac/DumpRenderTree.mm:
1288         (resetWebPreferencesToConsistentValues):
1289         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1290         (WTR::InjectedBundle::beginTesting):
1291         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1292         (WTR::TestRunner::setWebGL2Enabled):
1293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1294
1295 2016-04-04  Bill Ming  <mbbill@gmail.com>
1296
1297         [win] run-webkit-tests failed to launch DumpRenderTree
1298         https://bugs.webkit.org/show_bug.cgi?id=156150
1299
1300         Reviewed by Alex Christensen.
1301
1302         * Tools/Scripts/webkitpy/port/base.py:
1303
1304 2016-04-04  Bill Ming  <mbbill@gmail.com>
1305
1306         prepare-ChangeLog set endl incorrectly.
1307         https://bugs.webkit.org/show_bug.cgi?id=156151
1308
1309         Reviewed by Alex Christensen.
1310
1311         * Tools/Scripts/prepare-ChangeLog:
1312
1313 2016-04-03  Sam Weinig  <sam@webkit.org>
1314
1315         Add SPI to allow install script message handlers in isolated worlds
1316         https://bugs.webkit.org/show_bug.cgi?id=156153
1317
1318         Reviewed by Anders Carlsson.
1319
1320         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1321         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
1322
1323 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
1324
1325         Build fix for r198956.
1326
1327         Unreviewed.
1328
1329         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
1330         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1331         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1332         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1333
1334 2016-04-04  Bill Ming  <mbbill@gmail.com>
1335
1336         [win] prepare-ChangeLog should treat windows path differently.
1337         https://bugs.webkit.org/show_bug.cgi?id=156120
1338
1339         Reviewed by Brent Fulgham.
1340
1341         * Scripts/prepare-ChangeLog:
1342
1343 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
1344
1345         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
1346         https://bugs.webkit.org/show_bug.cgi?id=156164
1347
1348         Reviewed by Philippe Normand.
1349
1350         Enable the new WEB_RTC option by default for Gtk+.
1351
1352         * Scripts/webkitperl/FeatureList.pm:
1353
1354 2016-04-03  Dan Bernstein  <mitz@apple.com>
1355
1356         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
1357
1358         * Scripts/bisect-builds:
1359         (makeNightlyList):
1360
1361 2016-04-03  Dan Bernstein  <mitz@apple.com>
1362
1363         Made bisect-builds work again.
1364
1365         Rubber-stamped by Sam Weinig.
1366
1367         * Scripts/bisect-builds:
1368         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
1369
1370 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
1371
1372         Build fix for r198956.
1373
1374         Unreviewed.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1377         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
1378         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
1379         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
1380         (TEST):
1381         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1382         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1383         (TestWebKitAPI::TEST):
1384
1385 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
1386
1387         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
1388         https://bugs.webkit.org/show_bug.cgi?id=155995
1389         <rdar://problem/14967004>
1390
1391         Reviewed by Andy Estes.
1392
1393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1394         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
1395         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
1396         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
1397         (TEST):
1398         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
1399         (literalURL):
1400         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
1401         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
1404         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
1405         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
1406         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1407         (TestWebKitAPI::TEST):
1408
1409 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
1410
1411         Confirm <a download> satisfies specification criteria
1412         https://bugs.webkit.org/show_bug.cgi?id=156057
1413
1414         Reviewed by Andy Estes.
1415
1416         Revise WebKitTestRunner:
1417         (1) Provide a download client delegate.
1418         (2) Teach WKTR to wait to finish a test until a download finishes.
1419         (3) Allow WKTR to notify the current TestRunner that it can finish.
1420
1421         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1422         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1423         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
1424         message "NotifyDownloadDone".
1425         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1426         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
1427         attribute case.
1428         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1429         (WTR::TestRunner::waitUntilDownload): Added.
1430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1431         (WTR::TestRunner::shouldFinishAfterDownload): Added.
1432         * WebKitTestRunner/TestController.cpp:
1433         (WTR::TestController::createWebViewWithOptions): Set up the download client.
1434         (WTR::TestController::downloadDidStart): Added.
1435         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
1436         (WTR::TestController::downloadDidFinish): Added.
1437         (WTR::TestController::downloadDidFail): Added.
1438         (WTR::TestController::downloadDidCancel): Added.
1439         * WebKitTestRunner/TestController.h:
1440         * WebKitTestRunner/TestInvocation.cpp:
1441         (WTR::TestInvocation::notifyDownloadDone): Added.
1442         * WebKitTestRunner/TestInvocation.h:
1443
1444 2016-04-01  Alex Christensen  <achristensen@webkit.org>
1445
1446         Compile DumpRenderTree with CMake on Mac
1447         https://bugs.webkit.org/show_bug.cgi?id=156088
1448
1449         Reviewed by Brent Fulgham.
1450
1451         * CMakeLists.txt:
1452         * DumpRenderTree/CMakeLists.txt:
1453         * DumpRenderTree/DefaultPolicyDelegate.m:
1454         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1455         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
1456         * DumpRenderTree/PlatformMac.cmake: Added.
1457         * DumpRenderTree/PlatformWin.cmake:
1458         * DumpRenderTree/mac/AppleScriptController.m:
1459         (convertAEDescToObject):
1460         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1461         * DumpRenderTree/mac/LayoutTestHelper.m:
1462
1463 2016-03-31  Bill Ming  <mbbill@gmail.com>
1464
1465         https://bugs.webkit.org/show_bug.cgi?id=156094
1466         [Win] TestWebCore target build sometimes fail.
1467
1468         Reviewed by Alex Christensen.
1469
1470         * Tools/TestWebKitAPI/PlatformWin.cmake:
1471
1472 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1473
1474         [EFL] Bump EFL version to 1.17.0
1475         https://bugs.webkit.org/show_bug.cgi?id=153008
1476
1477         Reviewed by Michael Catanzaro.
1478
1479         Original author is Csaba Osztrogonác  <ossy@webkit.org>
1480
1481         * efl/jhbuild.modules:
1482
1483 2016-03-31  Daniel Bates  <dabates@apple.com>
1484
1485         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
1486         https://bugs.webkit.org/show_bug.cgi?id=156071
1487         <rdar://problem/25467827>
1488
1489         Reviewed by Brent Fulgham.
1490
1491         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
1492         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
1493         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
1494         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
1495         systems that have System Integrity Protection enabled we compute the path to the suffixed
1496         user's cache directory by hand.
1497
1498         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
1499         never deleted on cessation of the test run.
1500
1501         * Scripts/webkitpy/port/driver.py:
1502         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
1503         so that we can delete this directory on cessation of the test run.
1504         * Scripts/webkitpy/port/mac.py:
1505         (MacPort):
1506         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
1507         query the OS for the path to the user's cache directory and concatenate this path with the
1508         specified suffix.
1509
1510 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
1511
1512         WebKit should set Original URL of a download request correctly
1513         https://bugs.webkit.org/show_bug.cgi?id=155914
1514         <rdar://problem/10473811>
1515
1516         Reviewed by Anders Carlsson.
1517
1518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1519         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1520         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
1521         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
1522         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1523         (TEST):
1524         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
1525         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
1526         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
1527
1528 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
1529
1530         Extend animometer timeout for slow CPUs.
1531         https://bugs.webkit.org/show_bug.cgi?id=156047
1532
1533         Reviewed by Ryosuke Niwa.
1534
1535         Extend animometer timeout to 30 minutes for slow device.
1536
1537         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
1538
1539 2016-03-30  Daniel Bates  <dabates@apple.com>
1540
1541         run-webkit-tests must create parent directory of user's cache directory before running tests
1542         https://bugs.webkit.org/show_bug.cgi?id=156009
1543         <rdar://problem/25442682>
1544
1545         Reviewed by Alexey Proskuryakov.
1546
1547         The script run-webkit-tests must create the parent directory of the user's cache directory
1548         before running tests because a WebKit2 child process expects that this directory exists
1549         when it starts.
1550
1551         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
1552         user's temporary directory and user's cache directory via the environment variable
1553         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
1554         as part of setting up the test environment. But run-webkit-tests does not create the user's
1555         cache directory. Therefore there is race between the time AppKit creates it and when the
1556         launched WebContent and Network processes query for the path to the user's cache directory
1557         such that the OS may return the empty string to the WebContent and Network processes if
1558         queried for this directory before AppKit creates it.
1559
1560         * Scripts/webkitpy/port/base.py:
1561         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
1562         empty string. We will override this method for the OS X port to return the path to the
1563         user's cache directory with the specified suffix.
1564         (Port.remove_cache_directory): Deleted.
1565         * Scripts/webkitpy/port/driver.py:
1566         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
1567         to the suffix to use for the user's temporary and cache directories and the path to the
1568         user's cache directory, respectively.
1569         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
1570         to self._driver_user_directory_suffix.
1571         (Driver._start): Compute the user directory suffix and the path to the user's cache
1572         directory. Create the user's cache directory (if applicable).
1573         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
1574         * Scripts/webkitpy/port/mac.py:
1575         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
1576         (MacPort.remove_cache_directory): Deleted.
1577
1578 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
1579
1580         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
1581         https://bugs.webkit.org/show_bug.cgi?id=155676
1582
1583         Reviewed by Darin Adler.
1584
1585         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1586         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1587
1588 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1589
1590         Add machine-readable results for JSC stress tests
1591         https://bugs.webkit.org/show_bug.cgi?id=155771
1592
1593         Reviewed by Darin Adler and Dean Johnson
1594
1595         Add an option to output JSC stress test results to a user-specified file in JSON format.
1596
1597         * Scripts/run-javascriptcore-tests:
1598         (runJSCStressTests): Add JSON output support
1599         (readAllLines): Remove trailing newline from the end of each item
1600
1601 2016-03-29  Alex Christensen  <achristensen@webkit.org>
1602
1603         Fix Windows build.
1604
1605         * TestWebKitAPI/PlatformWin.cmake:
1606
1607 2016-03-29  Timothy Hatcher  <timothy@apple.com>
1608
1609         Update WebKit nightly to have a red needle to better match Safari
1610
1611         https://bugs.webkit.org/show_bug.cgi?id=155983
1612
1613         Reviewed by Joseph Pecoraro.
1614
1615         * WebKitLauncher/webkit.icns:
1616
1617 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
1618
1619         Adding myself as a reviewer.
1620
1621         Unreviewed.
1622
1623         * Scripts/webkitpy/common/config/contributors.json:
1624
1625 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
1626
1627         Dromaeo patch used by run-benchmark should not include an invalid address.
1628         https://bugs.webkit.org/show_bug.cgi?id=155910
1629
1630         Reviewed by Ryosuke Niwa.
1631
1632         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
1633         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1634
1635 2016-03-25  Daniel Bates  <dabates@apple.com>
1636
1637         Add WebKitSystemInterface for iOS 9.3
1638         https://bugs.webkit.org/show_bug.cgi?id=155893
1639
1640         Rubber-stamped by Alexey Proskuryakov.
1641
1642         * Scripts/copy-webkitlibraries-to-product-directory:
1643
1644 2016-03-25  Daniel Bates  <dabates@apple.com>
1645
1646         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
1647         in copy-webkitlibraries-to-product-directory
1648         https://bugs.webkit.org/show_bug.cgi?id=155869
1649
1650         Reviewed by Alexey Proskuryakov.
1651
1652         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
1653         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
1654         line argument.
1655
1656         * Scripts/copy-webkitlibraries-to-product-directory:
1657
1658 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
1659
1660         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
1661         https://bugs.webkit.org/show_bug.cgi?id=155882
1662
1663         Reviewed by Michael Catanzaro.
1664
1665         It was already enabled in all trunk ports, and is required for
1666         WebInspectorUI to work.
1667
1668         * Scripts/webkitperl/FeatureList.pm:
1669
1670 2016-03-24  Jeremy Zerfas  <WebKit@JeremyZerfas.com>
1671
1672         Improve update-webkit-dependency script.
1673         https://bugs.webkit.org/show_bug.cgi?id=155576
1674
1675         Reviewed by Brent Fulgham.
1676
1677         * Scripts/update-webkit-dependency:
1678         -Updated script to also use ETags for helping to determine whether dependency is up to date.
1679         -Updated script so it usually won't need to download the entire dependency each time it is
1680          ran.
1681         -Updated script to ensure zip file contains expected directories before trying to install.
1682         -Added some more error checking and improved error messages.
1683         (lastModifiedToUnixTime): Deleted.
1684
1685         * Scripts/update-webkit-wincairo-libs:
1686         -Corrected comment about what script does.
1687
1688 2016-03-24 Bill Ming <mbbill@gmail.com>
1689
1690         Fix webkitpy tests after r198617
1691         https://bugs.webkit.org/show_bug.cgi?id=155827
1692
1693         Reviewed by Alex Christensen.
1694
1695         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1696         (ConfirmDiff._show_pretty_diff):
1697
1698 2016-03-23  Bill Ming  <mbbill@gmail.com>
1699
1700         webkit-patch failed to open pretty diff on Windows
1701         https://bugs.webkit.org/show_bug.cgi?id=155827
1702
1703         Reviewed by Alex Christensen.
1704
1705         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1706         (ConfirmDiff._show_pretty_diff):
1707
1708 2016-03-23  Jer Noble  <jer.noble@apple.com>
1709
1710         [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
1711         https://bugs.webkit.org/show_bug.cgi?id=155764
1712
1713         Reviewed by Eric Carlson.
1714
1715         Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
1716
1717         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1718         (RequiresUserActionForPlaybackTest::SetUp):
1719
1720 2016-03-23  Anders Carlsson  <andersca@apple.com>
1721
1722         Crash when using KVO from within -[WebView initWithCoder:]
1723         https://bugs.webkit.org/show_bug.cgi?id=155816
1724         rdar://problem/17073265
1725
1726         Reviewed by Dan Bernstein.
1727
1728         Add test.
1729
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1731         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
1732         (-[EarlyKVOCrashResponder initWithWebView:]):
1733         (-[EarlyKVOCrashResponder initWithCoder:]):
1734         (-[EarlyKVOCrashResponder dealloc]):
1735         (-[EarlyKVOCrashResponder encodeWithCoder:]):
1736         (TestWebKitAPI::TEST):
1737
1738 2016-03-23  Lucas Forschler  <lforschler@apple.com>
1739
1740         Teach kill-old-processes about perl 5.18.
1741         
1742         Reviewed by Alexey Proskuryakov
1743
1744         * BuildSlaveSupport/kill-old-processes:
1745         (main):
1746
1747 2016-03-22  Keith Rollin  <krollin@apple.com>
1748
1749         Unreviewed: add Keith Rollin to the committers list.
1750
1751         * Scripts/webkitpy/common/config/contributors.json:
1752
1753 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
1754
1755         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
1756         https://bugs.webkit.org/show_bug.cgi?id=141499
1757
1758         Reviewed by Brent Fulgham.
1759
1760         As we have moved on to VS2015, this workaround is no longer needed.
1761
1762         * DumpRenderTree/cg/ImageDiffCG.cpp:
1763         (main):
1764         * DumpRenderTree/win/DumpRenderTree.cpp:
1765         (main):
1766         * DumpRenderTree/win/ImageDiffCairo.cpp:
1767         (main):
1768         * MiniBrowser/win/Common.cpp:
1769         (DllMain):
1770         * TestWebKitAPI/win/main.cpp:
1771         (main):
1772         * win/DLLLauncher/DLLLauncherMain.cpp:
1773         (wWinMain):
1774
1775 2016-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1776
1777         [JSC] ASMBench cannot be run without JSBENCH_PATH
1778         https://bugs.webkit.org/show_bug.cgi?id=155751
1779
1780         Reviewed by Saam Barati.
1781
1782         Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
1783
1784         * Scripts/run-jsc-benchmarks:
1785
1786 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
1787
1788         [Win] SharedBuffer::copy() can cause a segmentation fault.
1789         https://bugs.webkit.org/show_bug.cgi?id=155739
1790
1791         Reviewed by Ryosuke Niwa.
1792
1793         * TestWebKitAPI/PlatformWin.cmake: Build and run the
1794         SharedBuffer tests.
1795
1796 2016-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1797
1798         [buildbot] Move ARM Linux bots to JSCOnly port
1799         https://bugs.webkit.org/show_bug.cgi?id=155655
1800
1801         Reviewed by Lucas Forschler.
1802
1803         * BuildSlaveSupport/build.webkit.org-config/config.json:
1804         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1805         (ConfigureBuild.__init__):
1806         (appendCustomBuildFlags):
1807         (CompileJSCOnly):
1808         (Factory.__init__):
1809         (BuildAndRemoteJSCTestsFactory):
1810         (BuildAndRemoteJSCTestsFactory.__init__):
1811         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1812         * BuildSlaveSupport/clean-build:
1813         (main):
1814
1815 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
1816
1817         Improve SharedBuffer testing
1818         https://bugs.webkit.org/show_bug.cgi?id=93078
1819         <rdar://problem/25277829>
1820
1821         Reviewed by Ryosuke Niwa.
1822
1823         Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
1824         <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
1825         and a Blink patch by <tyoshino@chromium.org>
1826         <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
1827
1828         Add three test cases from the Blink project that cover various append,
1829         copy, and createArrayBuffer calls.
1830
1831         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1832         (TestWebKitAPI::TEST_F):
1833
1834 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1835
1836         [Win] Connect layoutTestController.findString() to support testing
1837         https://bugs.webkit.org/show_bug.cgi?id=50234
1838
1839         Reviewed by Alex Christensen.
1840
1841         Implement TestRunner::findString().
1842
1843         * DumpRenderTree/win/TestRunnerWin.cpp:
1844         (TestRunner::findString):
1845
1846 2016-03-20  Dan Bernstein  <mitz@apple.com>
1847
1848         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
1849         https://bugs.webkit.org/show_bug.cgi?id=155707
1850         <rdar://problem/24980691>
1851
1852         Reviewed by Darin Adler.
1853
1854         * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
1855           based on the last component of MACOSX_DEPLOYMENT_TARGET.
1856         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
1857           preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
1858
1859         Similarly for these projects:
1860
1861         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1862         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1863         * LayoutTestRelay/Configurations/Base.xcconfig:
1864         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1865         * MiniBrowser/Configurations/Base.xcconfig:
1866         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1867         * TestWebKitAPI/Configurations/Base.xcconfig:
1868         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1869         * WebEditingTester/Configurations/Base.xcconfig:
1870         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1871         * WebKitTestRunner/Configurations/Base.xcconfig:
1872         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1873
1874 2016-03-20  Dan Bernstein  <mitz@apple.com>
1875
1876         Update build settings
1877
1878         Rubber-stamped by Andy Estes.
1879
1880         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1881         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1882         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1883         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1884         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1885         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
1886         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1887         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1888         * asan/asan.xcconfig:
1889
1890 2016-03-18  Sam Weinig  <sam@webkit.org>
1891
1892         Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
1893         https://bugs.webkit.org/show_bug.cgi?id=155621
1894
1895         Reviewed by Alex Christensen.
1896
1897         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1898         (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
1899         (TestWebKitAPI::testMovingUsingEnsure):
1900         (TestWebKitAPI::testMovingUsingAdd):
1901         Add tests ensuring that objects moved into a map using ensure don't
1902         have extra ref-churn.
1903
1904 2016-03-17  Tim Horton  <timothy_horton@apple.com>
1905
1906         Fix some deprecation warnings in WebEditingTester
1907         https://bugs.webkit.org/show_bug.cgi?id=155601
1908
1909         Reviewed by Simon Fraser.
1910
1911         * WebEditingTester/AppDelegate.m:
1912         (-[WebEditingAppDelegate showOperations:]):
1913         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1914
1915 2016-03-17  Tim Horton  <timothy_horton@apple.com>
1916
1917         Find-in-page indicator in Mail viewer is the wrong scale and cut off
1918         https://bugs.webkit.org/show_bug.cgi?id=155605
1919         <rdar://problem/23948165>
1920
1921         Reviewed by Simon Fraser.
1922
1923         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
1924         (TEST):
1925         Add a test that ensures that the find result image is correctly @2x.
1926         The NSImage size should be in points.
1927
1928 2016-03-16  Commit Queue  <commit-queue@webkit.org>
1929
1930         Unreviewed, rolling out r198187.
1931         https://bugs.webkit.org/show_bug.cgi?id=155564
1932
1933         Potentially break testing on iOS (Requested by Guest23 on
1934         #webkit).
1935
1936         Reverted changeset:
1937
1938         "Add twisted-15.5.0 module to
1939         webkitpy.thirdparty.autoinstalled."
1940         https://bugs.webkit.org/show_bug.cgi?id=154667
1941         http://trac.webkit.org/changeset/198187
1942
1943 2016-03-16  David Kilzer  <ddkilzer@apple.com>
1944
1945         check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
1946         <http://webkit.org/b/155445>
1947
1948         Reviewed by Darin Adler.
1949
1950         * Scripts/webkitpy/style/checker.py:
1951         (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
1952         on TestWebKitAPI since this project uses a config.h header as of
1953         r95188.  Also remove references to WebKitAPITest, which ceased
1954         to exist in r95944.
1955
1956         * Scripts/webkitpy/style/checker_unittest.py:
1957         (GlobalVariablesTest.test_path_rules_specifier): Add tests.
1958         Remove reference to WebKitAPITest project.
1959
1960 2016-03-16  Tim Horton  <timothy_horton@apple.com>
1961
1962         [mac] Printing test snapshots are upside-down after r198242
1963         https://bugs.webkit.org/show_bug.cgi?id=155543
1964
1965         Reviewed by Simon Fraser.
1966
1967         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1968         (createPagedBitmapContext):
1969         Flip printing snapshots in DRT so that everything is right-side-up.
1970
1971 2016-03-16  Alexey Proskuryakov  <ap@apple.com>
1972
1973         Update unit test for iOS debug queues.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1976
1977 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
1978
1979         URL Parsing should signal failure for illegal IDN
1980         https://bugs.webkit.org/show_bug.cgi?id=154945
1981         <rdar://problem/8014795>
1982
1983         Reviewed by Brent Fulgham.
1984
1985         * MiniBrowser/mac/WK2BrowserWindowController.m:
1986         (-[WK2BrowserWindowController fetch:]):
1987         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
1988         (TestWebKitAPI::TEST):
1989
1990 2016-03-15  Tim Horton  <timothy_horton@apple.com>
1991
1992         [iOS Simulator] Test result snapshots are upside down
1993         https://bugs.webkit.org/show_bug.cgi?id=154761
1994
1995         Reviewed by Simon Fraser.
1996
1997         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1998         (WTR::createCGContextFromImage):
1999         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2000         In r97104, Simon added code to take WindowServer snapshots, which came
2001         in flipped, and added code to flip them back. At this point, WindowServer
2002         snapshots got flipped, and software snapshots did not.
2003
2004         In r140067, Simon noticed that WindowServer ref test images were upside-down
2005         on Mac (not sure why this changed), so turned off the flipping code (but
2006         didn't delete it!). Now, WindowServer snapshots and software snapshots both
2007         are not flipped.
2008
2009         In r190304, Carlos added an enum for the source of the snapshot ("WebView"
2010         for window server snapshots, and "WebContent" for software snapshots),
2011         and - critically - changed the flipping logic to flip software snapshots!
2012
2013         We didn't notice this on Mac because at this point we've made it so that
2014         we *always* have WindowServer snapshots, but on iOS we still don't have
2015         WindowServer snapshots, so now they're flipped.
2016
2017         And that's how we got here.
2018
2019         To restore the behavior from r140067, and correctly unflip snapshots on
2020         iOS, just delete this code.
2021
2022 2016-03-15  Alexey Proskuryakov  <ap@apple.com>
2023
2024         run-api-tests doesn't print test name when the test crashes
2025         https://bugs.webkit.org/show_bug.cgi?id=155476
2026
2027         Reviewed by Daniel Bates.
2028
2029         * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
2030         doesn't contain the test name yet. Changed test name output to always be before raw
2031         stdout for clarity.
2032
2033 2016-03-15  Chris Dumez  <cdumez@apple.com>
2034
2035         Unreviewed, rolling out r198203.
2036
2037         Favorites view is no longer loading on iOS
2038
2039         Reverted changeset:
2040
2041         "URL Parsing should signal failure for illegal IDN"
2042         https://bugs.webkit.org/show_bug.cgi?id=154945
2043         http://trac.webkit.org/changeset/198203
2044
2045 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
2046
2047         URL Parsing should signal failure for illegal IDN
2048         https://bugs.webkit.org/show_bug.cgi?id=154945
2049         <rdar://problem/8014795>
2050
2051         Reviewed by Brent Fulgham.
2052
2053         * MiniBrowser/mac/WK2BrowserWindowController.m:
2054         (-[WK2BrowserWindowController fetch:]):
2055         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
2056         (TestWebKitAPI::TEST):
2057
2058 2016-03-14  Chris Dumez  <cdumez@apple.com>
2059
2060         Unreviewed, rolling out r197981.
2061
2062         Caused a massive PLT regression on Mac.
2063
2064         Reverted changeset:
2065
2066         "Font antialiasing (smoothing) changes when elements are
2067         rendered into compositing layers"
2068         https://bugs.webkit.org/show_bug.cgi?id=23364
2069         http://trac.webkit.org/changeset/197981
2070
2071 2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
2072
2073         Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
2074         https://bugs.webkit.org/show_bug.cgi?id=154667
2075
2076         Reviewed by Ryosuke Niwa and Simon Fraser.
2077
2078         Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
2079         Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
2080
2081         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2082         (ServerControl.render_POST): Deleted.
2083         * Scripts/webkitpy/thirdparty/__init__.py:
2084         (AutoinstallImportHook.find_module):
2085         (AutoinstallImportHook._install_twisted_15_5_0):
2086         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2087         (ThirdpartyTest.test_imports):
2088
2089 2016-03-14  Mark Lam  <mark.lam@apple.com>
2090
2091         Need to distinguish between Symbol() and Symbol("").
2092         https://bugs.webkit.org/show_bug.cgi?id=155438
2093
2094         Reviewed by Saam Barati.
2095
2096         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2097         (TestWebKitAPI::TEST):
2098         - Test that the a symbol with an empty string is not equivalent to a null symbol. 
2099
2100 2016-03-14  David Kilzer  <ddkilzer@apple.com>
2101
2102         Remove blank lines after #include "config.h"
2103
2104         Follow-up fix from review comments on Bug 155394.
2105
2106         * TestWebKitAPI/PlatformUtilities.cpp:
2107         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
2108
2109 2016-03-14  Frederic Wang  <fred.wang@free.fr>
2110
2111         Unreviewed: Add my professional email address.
2112
2113         * Scripts/webkitpy/common/config/contributors.json:
2114
2115 2016-03-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2116
2117         Web platform test server should not try to launch servers on already bound sockets
2118         https://bugs.webkit.org/show_bug.cgi?id=141157
2119
2120         Reviewed by Darin Adler.
2121
2122         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2123         (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
2124         (base_url): Refactored to use wpt_config_json routine.
2125         (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
2126
2127 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
2128
2129         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
2130         https://bugs.webkit.org/show_bug.cgi?id=155417
2131
2132         Reviewed by Yusuke Suzuki.
2133
2134         * Scripts/webkitperl/FeatureList.pm:
2135         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2136
2137 2016-03-13  Dean Jackson  <dino@apple.com>
2138
2139         DRT should enable WebGL by default on Mac
2140         https://bugs.webkit.org/show_bug.cgi?id=155419
2141         <rdar://problem/25136981>
2142
2143         Reviewed by Sam Weinig.
2144
2145         For some reason, lost in time, WebGL was enabled
2146         by default on trunk, but disabled by default
2147         in DumpRenderTree when using WebKit 1. This
2148         was very annoying, because each test had
2149         an explicit command to enable it.
2150
2151         * DumpRenderTree/mac/DumpRenderTree.mm:
2152         (resetWebPreferencesToConsistentValues): Deleted WebGL line.
2153
2154 2016-03-13  Konstantin Tokarev  <annulen@yandex.ru>
2155
2156         Added new port JSCOnly.
2157         https://bugs.webkit.org/show_bug.cgi?id=154512
2158
2159         Reviewed by Michael Catanzaro.
2160
2161         This port allows to build JavaScriptCore engine with minimal
2162         dependencies.
2163
2164         * Scripts/build-jsc:
2165         * Scripts/webkitdirs.pm:
2166         (argumentsForConfiguration):
2167         (executableProductDir):
2168         (determinePortName):
2169         (isJSCOnly):
2170         (wrapperPrefixIfNeeded):
2171         (generateBuildSystemFromCMakeProject):
2172         (buildCMakeGeneratedProject):
2173
2174 2016-03-13  David Kilzer  <ddkilzer@apple.com>
2175
2176         TestWebKitAPI: fix linker warnings
2177         <http://webkit.org/b/155394>
2178
2179         Reviewed by Darin Adler.
2180
2181         * TestWebKitAPI/CMakeLists.txt:
2182         - Add RefLogger.cpp source file.
2183         - Add other missing cross-platform source files.
2184         - Add FIXMEs about RunLoop.cpp and about missing
2185           platform-specific source files.
2186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2187         - Add RefLogger.cpp source file.
2188
2189         * TestWebKitAPI/Counters.cpp:
2190         (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
2191         Move specific declaration here to fix linker warning.
2192         * TestWebKitAPI/Counters.h:
2193         (DeleterCounter<T>::deleterCount): Remove declaration of global
2194         template variable.
2195
2196         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
2197         (TestWebKitAPI::log): Added.  Move inline definition in
2198         RefLogger.h to here to fix linker warning.
2199
2200         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2201         (TestWebKitAPI::log): Replace inline function with declaration.
2202
2203 2016-03-12  David Kilzer  <ddkilzer@apple.com>
2204
2205         REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
2206
2207         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
2208         "Test.h" to fix incorrect case.  This was discovered when adding
2209         WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
2210
2211 2016-03-12  David Kilzer  <ddkilzer@apple.com>
2212
2213         run-webkit-tests: handle Darwin framework/library environment variables more consistently
2214         <http://webkit.org/b/155392>
2215
2216         Reviewed by Daniel Bates.
2217
2218         These changes will make it possible to pass through environment
2219         variables from the run-webkit-tests command-line.
2220
2221         * Scripts/webkitpy/port/base.py:
2222         (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
2223         __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
2224         list of variables to keep from the run-webkit-test environment.
2225
2226         * Scripts/webkitpy/port/driver.py:
2227         (Driver._append_environment_variable_path): Add method to append
2228         a path to an environment variable, or set the path if the
2229         variable doesn't exist.
2230         (Driver._setup_environ_for_driver): Extract build_root_path into
2231         a local variable.  Use Driver._append_environment_variable_path
2232         to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
2233         DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
2234         overwriting them.
2235
2236         * Scripts/webkitpy/port/driver_unittest.py:
2237         (DriverTest.test__append_environment_variable_path): Add test
2238         method to test Driver._append_environment_variable_path.
2239
2240 2016-03-11  Alexey Proskuryakov  <ap@apple.com>
2241
2242         [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
2243         https://bugs.webkit.org/show_bug.cgi?id=155276
2244
2245         [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
2246         https://bugs.webkit.org/show_bug.cgi?id=155345
2247
2248         [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
2249         https://bugs.webkit.org/show_bug.cgi?id=153997
2250         <rdar://problem/23580034>
2251
2252         <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
2253
2254         Rubber-stamped by Filip Pizlo.
2255
2256         * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
2257
2258         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
2259         on iOS again.
2260
2261 2016-03-11  Jer Noble  <jer.noble@apple.com>
2262
2263         [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
2264         https://bugs.webkit.org/show_bug.cgi?id=155365
2265
2266         Reviewed by Darin Adler.
2267
2268         Allow tests running on iOS simulator to play video inline, avoiding this assert.
2269
2270         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2271         (RequiresUserActionForPlaybackTest::SetUp):
2272
2273 2016-03-11  Frederic Wang  <fwang@igalia.com>
2274
2275         [jhbuild] Disable LLVM OCaml bindings.
2276         https://bugs.webkit.org/show_bug.cgi?id=153274
2277
2278         Reviewed by Michael Catanzaro.
2279
2280         * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
2281
2282 2016-03-11  Commit Queue  <commit-queue@webkit.org>
2283
2284         Unreviewed, rolling out r197495.
2285         https://bugs.webkit.org/show_bug.cgi?id=155369
2286
2287         LLVM is needed to run update-webkitgtk-libs reliably
2288         (Requested by mcatanzaro on #webkit).
2289
2290         Reverted changeset:
2291
2292         "[jhbuild] Remove LLVM dependency."
2293         https://bugs.webkit.org/show_bug.cgi?id=153274
2294         http://trac.webkit.org/changeset/197495
2295
2296 2016-03-11  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2297
2298         WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
2299         https://bugs.webkit.org/show_bug.cgi?id=153419
2300
2301         Reviewed by Darin Adler.
2302
2303         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2304         (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
2305
2306
2307 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
2308
2309         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
2310         https://bugs.webkit.org/show_bug.cgi?id=23364
2311
2312         Reviewed by Tim Horton.
2313
2314         Turn off smoothed layer text because it affects many layout test results.
2315
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (resetWebViewToConsistentStateBeforeTesting):
2318         * WebKitTestRunner/TestController.cpp:
2319         (WTR::TestController::resetStateToConsistentValues):
2320
2321 2016-03-10  Jer Noble  <jer.noble@apple.com>
2322
2323         Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
2324
2325         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2326         (TEST): Deleted.
2327
2328 2016-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2329
2330         [OS X] Main frame scrollbars should appear on the left on RTL systems
2331         https://bugs.webkit.org/show_bug.cgi?id=155149
2332
2333         Reviewed by Simon Fraser.
2334
2335         Setting the volatile default needs to be done early, so it is
2336         plumbed through the injected bundle's initialization routine.
2337
2338         Control of RTL scrollbars is handled by putting the string
2339         <!-- webkit-test-runner [ rtlScrollbars=true ] -->
2340         on the first line of a test.
2341
2342         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2343         (WTR::shouldUseRTLScrollbars):
2344         (WTR::InjectedBundle::platformInitialize):
2345         * WebKitTestRunner/TestController.cpp:
2346         (WTR::TestController::generatePageConfiguration):
2347         (WTR::updateTestOptionsFromTestHeader):
2348         (WTR::TestController::getInjectedBundleInitializationUserData):
2349         * WebKitTestRunner/TestController.h:
2350         * WebKitTestRunner/TestOptions.h:
2351         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2352         (WTR::PlatformWebView::viewSupportsOptions):
2353
2354 2016-03-08  Jer Noble  <jer.noble@apple.com>
2355
2356         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
2357         https://bugs.webkit.org/show_bug.cgi?id=155141
2358
2359         Reviewed by Beth Dakin.
2360
2361         Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
2362         to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
2363
2364         Add a new test of WK2 user gesture requirement preferences.
2365
2366         * DumpRenderTree/mac/DumpRenderTree.mm:
2367         (resetWebPreferencesToConsistentValues):
2368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2369         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2370         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
2372         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
2373         (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2374         (RequiresUserActionForPlaybackTest::SetUp):
2375         (RequiresUserActionForPlaybackTest::createWebView):
2376         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
2377         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
2378         (RequiresUserActionForPlaybackTest::testAudioOnly):
2379         (TEST_F):
2380         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2381         (TEST):
2382
2383 2016-03-10  Brian Burg  <bburg@apple.com>
2384
2385         Web Inspector: should be able to run protocol and input generator scripts from any directory
2386         https://bugs.webkit.org/show_bug.cgi?id=155307
2387
2388         Reviewed by Joseph Pecoraro.
2389
2390         * Scripts/webkitpy/inspector/main.py:
2391         (InspectorGeneratorTests.main):
2392         * Scripts/webkitpy/replay/main.py:
2393         (InputGeneratorTests.main):
2394         Compute the current SCM based on the location of the script being executed, not
2395         the $CWD which could be anything. There's rarely a good reason to use $CWD.
2396
2397 2016-03-10  David Kilzer  <ddkilzer@apple.com>
2398
2399         [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
2400         <http://webkit.org/b/155295>
2401
2402         Reviewed by Brent Fulgham.
2403
2404         * DumpRenderTree/mac/TestRunnerMac.mm:
2405         (TestRunner::inspectorTestStubURL): Always return nullptr for
2406         PLATFORM(IOS).  This matches what we did in r192604 for
2407         WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
2408
2409 2016-03-10  Frederic Wang  <fwang@igalia.com>
2410
2411         [GTK] Add support for WOFF2
2412         https://bugs.webkit.org/show_bug.cgi?id=152616
2413
2414         Reviewed by Carlos Garcia Campos.
2415
2416         * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
2417
2418 2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>
2419
2420         Add runtime flags for shadow DOM and custom elements
2421         https://bugs.webkit.org/show_bug.cgi?id=155213
2422
2423         Reviewed by Dean Jackson.
2424
2425         Always enable shadow DOM and custom elements during testing.
2426
2427         * DumpRenderTree/mac/DumpRenderTree.mm:
2428         (resetWebPreferencesToConsistentValues):
2429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2430         (WTR::InjectedBundle::beginTesting):
2431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2432         (WTR::TestRunner::setShadowDOMEnabled): Added.
2433         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2434
2435 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
2436
2437         Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
2438         https://bugs.webkit.org/show_bug.cgi?id=155265
2439         <rdar://problem/11101440>
2440
2441         Reviewed by Andy Estes.
2442
2443         WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
2444         Tests that confirm blocking localStorage manually set the flag to "False" in the test.
2445
2446         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2447         (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
2448
2449 2016-03-09  David Kilzer  <ddkilzer@apple.com>
2450
2451         check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
2452         <http://webkit.org/b/155273>
2453
2454         Reviewed by Andy Estes.
2455
2456         * Scripts/webkitpy/style/checkers/cpp.py:
2457         (check_spacing_for_function_call): Ignore @catch lines.
2458         (check_braces): Ditto.
2459         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2460         (CppStyleTest.test_brace_at_begin_of_line): Add test case.
2461
2462 2016-03-09  Jason Marcell  <jmarcell@apple.com>
2463
2464         Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
2465         https://bugs.webkit.org/show_bug.cgi?id=155274
2466
2467         Reviewed by Alexey Proskuryakov.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
2470         (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
2471         error in the unit tests.
2472
2473 2016-03-09  Aakash Jain  <aakash_jain@apple.com>
2474
2475         use ulimit command to check process limit in webkitpy
2476         https://bugs.webkit.org/show_bug.cgi?id=155260
2477
2478         Reviewed by Alexey Proskuryakov.
2479
2480         * Scripts/webkitpy/port/ios.py:
2481         (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of 
2482         launchctl limit maxproc command.
2483
2484 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
2485
2486         Stop building armv7 on iOS device builders
2487         https://bugs.webkit.org/show_bug.cgi?id=155246
2488
2489         Reviewed by David Kilzer.
2490
2491         * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
2492         armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
2493         elsewhere.
2494
2495         * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
2496         EWS configuration to be verified by buildbot queues.
2497
2498         * Scripts/webkitdirs.pm:
2499         * Scripts/webkitpy/port/ios.py:
2500         Changed default to arm64. I think that the default is probably not used in any
2501         practical scenarios, but it's nice to make it more sensible.
2502
2503 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
2504
2505         Add iOS Simulator EWS to bot watcher's dashboard
2506         https://bugs.webkit.org/show_bug.cgi?id=155220
2507
2508         Reviewed by Lucas Forschler.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2511
2512 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
2513
2514         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
2515         https://bugs.webkit.org/show_bug.cgi?id=155185
2516         <rdar://problem/11101440>
2517
2518         Reviewed by Anders Carlsson.
2519
2520         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2521         (TestWebKitAPI::TEST): Allow local file accesss to run test.
2522         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2523         (TEST): Ditto.
2524         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2525         (TEST): Ditto.
2526
2527 2016-03-09  Tim Horton  <timothy_horton@apple.com>
2528
2529         Removing and re-adding a script message handler with the same name results in an unusable message handler
2530         https://bugs.webkit.org/show_bug.cgi?id=155223
2531
2532         Reviewed by Sam Weinig.
2533
2534         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2535         (TEST):
2536         Add a test ensuring that it is possible to remove and re-add a script message handler
2537         with the same name and still dispatch messages to it.
2538
2539 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2540
2541         Fix iOS Simulator EWS.
2542
2543         Unreviewed build fix.
2544
2545         * Scripts/webkitpy/common/config/ports.py:
2546
2547 2016-03-08  Aakash Jain  <aakash_jain@apple.com>
2548
2549         Booting multiple iOS simulator parallely fails sometimes
2550         https://bugs.webkit.org/show_bug.cgi?id=155208
2551         <rdar://problem/25019651>
2552
2553         Reviewed by Darin Adler.
2554
2555         * Scripts/webkitpy/port/ios.py:
2556         (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
2557         simulator boot.
2558
2559 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2560
2561         Add iOS debug testers to flakiness dashboard
2562         https://bugs.webkit.org/show_bug.cgi?id=155206
2563
2564         Reviewed by Darin Adler.
2565
2566         * TestResultServer/static-dashboards/builders.jsonp:
2567
2568 2016-03-08  Oliver Hunt  <oliver@apple.com>
2569
2570         Start moving to separated writable and executable mappings in the JIT
2571         https://bugs.webkit.org/show_bug.cgi?id=155178
2572
2573         Reviewed by Fil Pizlo.
2574
2575         Making run-jsc-benchmarks slightly happier on my machine.
2576
2577         * Scripts/run-jsc-benchmarks:
2578
2579 2016-03-08  Anders Carlsson  <andersca@apple.com>
2580
2581         Use NSUInteger instead of NSWindowStyleMask.
2582
2583         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2584
2585 2016-03-08  Anders Carlsson  <andersca@apple.com>
2586
2587         Fix build.
2588
2589         We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
2590         MiniBrowser to build without WTF.
2591
2592         * MiniBrowser/mac/AppDelegate.m:
2593         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2594         * MiniBrowser/mac/BrowserWindowController.m:
2595         (-[BrowserWindowController windowDidLoad]):
2596         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2597
2598 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2599
2600         Add iOS simulator EWS that runs tests
2601         https://bugs.webkit.org/show_bug.cgi?id=155175
2602
2603         Reviewed by Lucas Forschler.
2604
2605         * QueueStatusServer/config/queues.py:
2606         * Scripts/webkitpy/common/config/ews.json:
2607         * Scripts/webkitpy/common/config/ports.py:
2608
2609 2016-03-08  Commit Queue  <commit-queue@webkit.org>
2610
2611         Unreviewed, rolling out r197793 and r197799.
2612         https://bugs.webkit.org/show_bug.cgi?id=155195
2613
2614         something weird happened while landing this and everything
2615         broke (Requested by olliej on #webkit).
2616
2617         Reverted changesets:
2618
2619         "Start moving to separated writable and executable mappings in
2620         the JIT"
2621         https://bugs.webkit.org/show_bug.cgi?id=155178
2622         http://trac.webkit.org/changeset/197793
2623
2624         "arm64 build fix after r197793."
2625         http://trac.webkit.org/changeset/197799
2626
2627 2016-03-08  Oliver Hunt  <oliver@apple.com>
2628
2629         Start moving to separated writable and executable mappings in the JIT
2630         https://bugs.webkit.org/show_bug.cgi?id=155178
2631
2632         Reviewed by Filip Pizlo.
2633
2634         Making run-jsc-benchmarks slightly happier on my machine.
2635
2636         * Scripts/run-jsc-benchmarks:
2637
2638 2016-03-08  Daniel Bates  <dabates@apple.com>
2639
2640         Support iterating over an OptionSet and checking if it is empty
2641         https://bugs.webkit.org/show_bug.cgi?id=154941
2642         <rdar://problem/24964187>
2643
2644         Reviewed by Darin Adler.
2645
2646         Add tests to ensure that we do not regression both iteration of an OptionSet and
2647         determining whether an OptionSet is empty.
2648
2649         * TestWebKitAPI/Test.h:
2650         (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
2651         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2652         (TestWebKitAPI::TEST):
2653
2654 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2655
2656         Add debug iOS Simulator bots to the dashboard
2657         https://bugs.webkit.org/show_bug.cgi?id=155157
2658
2659         Reviewed by Darin Adler.
2660
2661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2662
2663 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
2664
2665         Unreviewed EFL build fix after r197752.
2666
2667         * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
2668         compilation by default until EFL bumps gstreamer to 1.6.
2669
2670 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
2671
2672         [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
2673         https://bugs.webkit.org/show_bug.cgi?id=153540
2674
2675         Reviewed by Philippe Normand.
2676
2677         After bumping gstreamer to 1.6.3 in r196804 we can enable again
2678         compilation of mediastream and running the tests.
2679
2680         * Scripts/run-gtk-tests:
2681         (TestRunner): Enable again the UserMedia API test.
2682         * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
2683         mediastream by default.
2684         * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
2685         file.
2686         * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
2687         are currently using.
2688
2689 2016-03-07  Jon Lee  <jonlee@apple.com>
2690
2691         Update perf bot configuration for Animometer
2692         https://bugs.webkit.org/show_bug.cgi?id=155134
2693
2694         Reviewed by Ryosuke Niwa.
2695
2696         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
2697         to work with the latest version of the harness.
2698         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
2699         and use the latest version of the harness.
2700
2701 2016-03-07  Joanmarie Diggs  <jdiggs@igalia.com>
2702
2703         [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
2704         https://bugs.webkit.org/show_bug.cgi?id=154839
2705
2706         Reviewed by Michael Catanzaro.
2707
2708         Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
2709
2710         * gtk/jhbuild-webrtc.modules:
2711         * gtk/jhbuild.modules:
2712         * gtk/jhbuildrc:
2713
2714 2016-03-07  Aakash Jain  <aakash_jain@apple.com>
2715
2716         webkitpy should verify timestamp from CrashLogs while collecting all crash logs
2717         https://bugs.webkit.org/show_bug.cgi?id=155000
2718         <rdar://problem/24860219>
2719
2720         Reviewed by Alexey Proskuryakov.
2721
2722         * Scripts/webkitpy/common/system/crashlogs.py:
2723         (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected 
2724         time range, because file modification time is not always accurate.
2725         (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
2726         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2727         (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
2728
2729 2016-03-06  Alexey Proskuryakov  <ap@apple.com>
2730
2731         build-webkit prints an error on iOS simulator bots
2732         https://bugs.webkit.org/show_bug.cgi?id=155078
2733
2734         Reviewed by Dan Bernstein.
2735
2736         This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
2737
2738         * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
2739         XcodeOptions() already passes SDKROOT as appropriate.
2740
2741         * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
2742         any other configuration variables that were derived from its initial value, like $portName.
2743
2744 2016-03-05  Tim Horton  <timothy_horton@apple.com>
2745
2746         Create a DOMHTMLVideoElement when wrapping <video> elements
2747         https://bugs.webkit.org/show_bug.cgi?id=155084
2748         <rdar://problem/24997193>
2749
2750         Reviewed by Dan Bernstein.
2751
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
2754         (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
2755         (TestWebKitAPI::TEST):
2756         Add an API test for this behavior.
2757
2758 2016-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2759
2760         [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
2761         https://bugs.webkit.org/show_bug.cgi?id=154595
2762
2763         Unreviewed.
2764
2765         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2766         (start): Use logging.exception when a test fails in order to get the details about the error.
2767
2768 2016-03-04  Alexey Proskuryakov  <ap@apple.com>
2769
2770         Add iOS simulator debug bots
2771         https://bugs.webkit.org/show_bug.cgi?id=155053
2772
2773         Reviewed by Lucas Forschler.
2774
2775         * BuildSlaveSupport/build.webkit.org-config/config.json:
2776
2777 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
2778
2779         [WK2] Gather resource load statistics
2780         https://bugs.webkit.org/show_bug.cgi?id=154278
2781         <rdar://problem/24702892>
2782
2783         Reviewed by Andy Estes.
2784
2785         * MiniBrowser/mac/AppDelegate.m:
2786         (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
2787         * MiniBrowser/mac/SettingsController.m:
2788         (-[SettingsController _populateMenu]): Move setting from WK1-only to be
2789         universally applicable.
2790         * MiniBrowser/mac/WK2BrowserWindowController.m:
2791         (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
2792         Resource Load Statistics flag has changed.
2793
2794 2016-03-04  Alex Christensen  <achristensen@webkit.org>
2795
2796         Remove vcxproj build system
2797         https://bugs.webkit.org/show_bug.cgi?id=154388
2798
2799         Rubber-stamped by Brent Fulgham.
2800
2801         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
2802         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
2803         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
2804         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
2805         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
2806         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
2807         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
2808         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
2809         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
2810         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
2811         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
2812         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
2813         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
2814         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
2815         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
2816         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
2817         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
2818         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
2819         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
2820         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
2821         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
2822         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
2823         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
2824         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
2825         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
2826         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
2827         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
2828         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
2829         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
2830         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
2831         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
2832         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
2833         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
2834         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
2835         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
2836         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
2837         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
2838         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
2839         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
2840         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
2841         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
2842         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
2843         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
2844         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
2845         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
2846         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
2847         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
2848         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
2849         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
2850         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
2851         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
2852         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
2853         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
2854         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
2855         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
2856         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
2857         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
2858         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
2859         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
2860         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
2861         * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
2862         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
2863         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
2864         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
2865         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
2866         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
2867         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
2868         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
2869         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
2870         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
2871         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
2872         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
2873         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
2874         * win/AssembleBuildLogs: Removed.
2875         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
2876         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
2877         * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
2878         * win/AssembleBuildLogs/README: Removed.
2879
2880 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
2881
2882         Whitespace causes font-variant: all-small-caps to synthesize
2883         https://bugs.webkit.org/show_bug.cgi?id=155004
2884         <rdar://problem/24630796>
2885
2886         Reviewed by Darin Adler.
2887
2888         * DumpRenderTree/mac/DumpRenderTree.mm:
2889         (allowedFontFamilySet):
2890         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2891         (WTR::allowedFontFamilySet):
2892         * WebKitTestRunner/mac/TestControllerMac.mm:
2893         (WTR::allowedFontFamilySet):
2894
2895 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
2896
2897         [iOS] Crash during font loading when injected bundle cancels load
2898         https://bugs.webkit.org/show_bug.cgi?id=155001
2899
2900         Reviewed by Tim Horton.
2901
2902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2903         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
2904         * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
2905         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
2906         (-[Myles webView:didFinishNavigation:]):
2907         (TEST):
2908         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
2909         (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2910         (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
2911
2912 2016-03-04  Konstantin Tokarev  <annulen@yandex.ru>
2913
2914         [check-webkit-style] Added checks for redundant virtual specifiers.
2915         https://bugs.webkit.org/show_bug.cgi?id=155017
2916
2917         Reviewed by Darin Adler.
2918
2919         Added 3 new checks related to virtual, override, and final specifiers:
2920
2921         1. When "override" is present, "virtual" is redundant.
2922         2. When "final" is present, "virtual" is redundant.
2923         3. When "final" is present, "override" is redundant.
2924
2925         * Scripts/webkitpy/style/checkers/cpp.py:
2926         (_FunctionState.begin):
2927         (_FunctionState.is_virtual):
2928         (_check_parameter_name_against_text):
2929         (_error_redundant_specifier):
2930         (check_function_definition):
2931         (CppChecker):
2932         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2933         (FunctionDetectionTest.perform_function_detection):
2934         (FunctionDetectionTest.test_basic_function_detection):
2935         (FunctionDetectionTest.test_function_declaration_detection):
2936         (FunctionDetectionTest.test_pure_function_detection):
2937         (FunctionDetectionTest.test_override_and_final_function_detection):
2938         (FunctionDetectionTest.test_non_functions):
2939         (FunctionDetectionTest.test_parameter_list):
2940
2941 2016-03-03  Darin Adler  <darin@apple.com>
2942
2943         Followup to:
2944         Remove "virtual" from all lines that have both "virtual" and "override".
2945         https://bugs.webkit.org/show_bug.cgi?id=155005
2946
2947         Reviewed by Geoffrey Garen.
2948
2949         * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
2950         use either override or final, not both, and to remove virtual from all lines that
2951         have both virtual and final.
2952
2953 2016-03-03  Darin Adler  <darin@apple.com>
2954
2955         Remove "virtual" from all lines that have both "virtual" and "override".
2956         https://bugs.webkit.org/show_bug.cgi?id=155005
2957
2958         Reviewed by Geoffrey Garen.
2959
2960         * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
2961
2962 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2963
2964         [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
2965         https://bugs.webkit.org/show_bug.cgi?id=154595
2966
2967         Unreviewed fix after r197505.
2968
2969         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2970         (RunBenchmarkTests.start):
2971
2972 2016-03-03  Daniel Bates  <dabates@apple.com>
2973
2974         Add unit tests for WTF::OptionSet
2975         https://bugs.webkit.org/show_bug.cgi?id=154925
2976         <rdar://problem/24964211>
2977
2978         Reviewed by Darin Adler.
2979
2980         Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
2981
2982         * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
2983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2984         * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
2985         (TestWebKitAPI::TEST):
2986
2987 2016-03-03  Commit Queue  <commit-queue@webkit.org>
2988
2989         Unreviewed, rolling out r197442.
2990         https://bugs.webkit.org/show_bug.cgi?id=154967
2991
2992         Broke tests, and also uses a wrong approach (Requested by ap
2993         on #webkit).
2994
2995         Reverted changeset:
2996
2997         "Disable FTL JIT testing on 32-bit JSC tester bots"
2998         https://bugs.webkit.org/show_bug.cgi?id=154858
2999         http://trac.webkit.org/changeset/197442
3000
3001 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3002
3003         [GTK] Run the run-benchmark script on the performance bot.
3004         https://bugs.webkit.org/show_bug.cgi?id=154595
3005
3006         Reviewed by Carlos Garcia Campos.
3007
3008         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
3009         (RunBenchmarkTests):
3010         (RunBenchmarkTests.start):
3011         (RunBenchmarkTests.getText):
3012         (RunBenchmarkTests.getText2):
3013         (BuildAndPerfTestFactory.__init__):
3014         (DownloadAndPerfTestFactory.__init__):
3015         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
3016         (RunBenchmarkTest):
3017         (RunBenchmarkTest.assertResults):
3018         (RunBenchmarkTest.test_success):
3019         (RunBenchmarkTest.test_tests_failed):
3020         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
3021         (BenchmarkRunner._run_benchmark):
3022         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
3023         (GTKMiniBrowserDriver.close_browsers):
3024         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
3025         (parse_args):
3026         (start):
3027         (main):
3028
3029 2016-03-03  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3030
3031         [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
3032         https://bugs.webkit.org/show_bug.cgi?id=154960
3033
3034         Reviewed by Csaba Osztrogonác.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
3037         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3038
3039 2016-03-03  Frederic Wang  <fwang@igalia.com>
3040
3041         [jhbuild] Remove LLVM dependency.
3042         https://bugs.webkit.org/show_bug.cgi?id=153274
3043
3044         Reviewed by Carlos Garcia Campos.
3045
3046         * gtk/jhbuild.modules:
3047
3048 2016-03-02  Alejandro G. Castro  <alex@igalia.com>
3049
3050         Unreviewed build fix for media-stream after r197114.
3051
3052         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3053         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3054
3055 2016-03-01  Csaba Osztrogonác  <ossy@webkit.org>
3056
3057         Disable FTL JIT testing on 32-bit JSC tester bots
3058         https://bugs.webkit.org/show_bug.cgi?id=154858
3059
3060         Reviewed by Saam Barati.
3061
3062         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3063         (Run32bitJSCTests):
3064
3065 2016-03-01  Dean Johnson  <dean_johnson@apple.com>
3066
3067         Fix iOS EWS.
3068         https://bugs.webkit.org/show_bug.cgi?id=154880
3069
3070         Reviewed by Alexey Proskuryakov.
3071
3072         * Scripts/copy-webkitlibraries-to-product-directory:
3073
3074 2016-02-29  Chris Dumez  <cdumez@apple.com>
3075
3076         Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
3077         https://bugs.webkit.org/show_bug.cgi?id=154845
3078
3079         Reviewed by Ryosuke Niwa.
3080
3081         Update API tests accordingly.
3082
3083         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3084         (TestWebKitAPI::testParseHTMLInteger):
3085         (TestWebKitAPI::parseHTMLIntegerFails):
3086         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
3087         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
3088         (TestWebKitAPI::TEST): Deleted.
3089
3090 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
3091
3092         Remove the experimental feature of antialiased font dilation
3093         https://bugs.webkit.org/show_bug.cgi?id=154843
3094
3095         Reviewed by Zalan Bujtas.
3096
3097         Remove the "antialiased font dilation" code path, and related prefs.
3098
3099         * DumpRenderTree/mac/DumpRenderTree.mm:
3100         (resetWebPreferencesToConsistentValues): Deleted.
3101         * WebKitTestRunner/TestController.cpp:
3102         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3103
3104 2016-02-29  Brady Eidson  <beidson@apple.com>
3105
3106         Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
3107
3108         Unreviewed.
3109
3110         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3112         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3113         (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
3114           so we should always wait for it and make sure we got it.
3115
3116 2016-02-29  Brady Eidson  <beidson@apple.com>
3117
3118         Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
3119         https://bugs.webkit.org/show_bug.cgi?id=154837
3120
3121         Reviewed by Alex Christensen.
3122
3123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3124         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
3125         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
3126         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
3127
3128 2016-02-29  Joanmarie Diggs  <jdiggs@igalia.com>
3129
3130         [GTK][jhbuild] GLib build fails with GCC 6.0
3131         https://bugs.webkit.org/show_bug.cgi?id=154825
3132
3133         Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
3134
3135         Reviewed by Csaba Osztrogonác.
3136
3137         * gtk/jhbuild.modules: Apply upstream path.
3138         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
3139
3140 2016-02-29  Filip Pizlo  <fpizlo@apple.com>
3141
3142         We've been running Octane/regexp all wrong in run-jsc-benchmarks
3143         https://bugs.webkit.org/show_bug.cgi?id=154827
3144
3145         Reviewed by Andreas Kling.
3146
3147         Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
3148         it without warmup. This patches fixes this by making this script run it with warmup.
3149
3150         This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
3151         speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
3152
3153         It discovered this bug because for each Octane test that I want to debug, I usually make
3154         a standalone .js file that contains the whole test along with a miniharness - usually
3155         a plain loop - that runs it almost like it would for real but with whatever hacks I'm
3156         using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
3157         to match the one second of warmup that this benchmark gets in Octane. To my surprise,
3158         this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
3159         saw. That's when I found out that run-jsc-benchmarks was running it wrong.
3160
3161         The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
3162         run on some of these very large functions in the regexp benchmark. I don't think we can
3163         do anything about that, and I'd argue that the speed-up we see after the compilation is
3164         done suggests that it was worth it.
3165
3166         * Scripts/run-jsc-benchmarks:
3167
3168 2016-02-29  Gavin Barraclough  <barraclough@apple.com>
3169
3170         RefCounter<T>::Event -> RefCounterEvent
3171         https://bugs.webkit.org/show_bug.cgi?id=154767
3172
3173         Reviewed by Darin Adler.
3174
3175         RefCounter<T>::Event is kinda verbose to use, and there is no need for this
3176         to be specific to a particular typeof RefCounter. Move the enum class up to
3177         the top level & rename to RefCounterEvent.
3178
3179         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3180         (TestWebKitAPI::TEST):
3181
3182 2016-02-29  Csaba Osztrogonác  <ossy@webkit.org>
3183
3184         Remove more LLVM related cruft
3185         https://bugs.webkit.org/show_bug.cgi?id=154821
3186
3187         Reviewed by Darin Adler.
3188
3189         * Scripts/build-jsc:
3190         * Scripts/build-webkit:
3191         * Scripts/copy-webkitlibraries-to-product-directory:
3192         * Scripts/export-llvm-build: Removed.
3193         * Scripts/run-jsc-stress-tests:
3194
3195 2016-02-28  Sam Weinig  <sam@webkit.org>
3196
3197         Reimplement WKPageGroup in terms of WKUserContentController
3198         https://bugs.webkit.org/show_bug.cgi?id=154804
3199
3200         Reviewed by Dan Bernstein.
3201
3202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3203         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
3204
3205 2016-02-28  Sam Weinig  <sam@webkit.org>
3206
3207         Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
3208         https://bugs.webkit.org/show_bug.cgi?id=154798
3209
3210         Reviewed by Dan Bernstein.
3211
3212         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3213         Add tests for removing _WKUserStyleSheets and WKUserScripts
3214
3215 2016-02-27  Alexey Proskuryakov  <ap@apple.com>
3216
3217         Silence leaks under TextCodecICU::registerCodecs
3218         https://bugs.webkit.org/show_bug.cgi?id=154737
3219
3220         Reviewed by Darin Adler.
3221
3222         * Scripts/webkitpy/port/leakdetector.py:
3223         (LeakDetector._callstacks_to_exclude_from_leaks):
3224
3225 2016-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
3226
3227         [GTK] Fix incorrect cast
3228
3229         Unreviewed.
3230
3231         * MiniBrowser/gtk/main.c:
3232         (createBrowserWindow):
3233
3234 2016-02-26  Chris Dumez  <cdumez@apple.com>
3235
3236         Fix the behavior of reflecting IDL attributes of type unsigned long
3237         https://bugs.webkit.org/show_bug.cgi?id=154771
3238
3239         Reviewed by Ryosuke Niwa.
3240
3241         Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
3242         implementation:
3243         - "-0" is parsed as 0.
3244         - Range boundaries are now [0; 2147483647].
3245
3246         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3247         (TestWebKitAPI::TEST):
3248
3249 2016-02-26  Brady Eidson  <beidson@apple.com>
3250
3251         Modern IDB: New database versions are never committed to SQLite.
3252         <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
3253         
3254         Modern IDB: If a database handle is not open, files are not actually deleted from disk
3255         https://bugs.webkit.org/show_bug.cgi?id=154756
3256
3257         Reviewed by Alex Christensen.
3258
3259         This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
3260
3261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3262         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
3263         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
3264         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
3265         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
3266         (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
3267         (TEST):
3268
3269 2016-02-26  Commit Queue  <commit-queue@webkit.org>
3270
3271         Unreviewed, rolling out r197216.
3272         https://bugs.webkit.org/show_bug.cgi?id=154766
3273
3274         Test simply needs updated result (Requested by litherum on
3275         #webkit).
3276
3277         Reverted changeset:
3278
3279         "Unreviewed, rolling out r197158."
3280         https://bugs.webkit.org/show_bug.cgi?id=154758
3281         http://trac.webkit.org/changeset/197216
3282
3283 2016-02-26  Alexey Proskuryakov  <ap@apple.com>
3284
3285         [iOS Simulator] Reftests don't work
3286         https://bugs.webkit.org/show_bug.cgi?id=154764
3287
3288         Reviewed by Daniel Bates.
3289
3290         * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
3291         Use simctl instead of sim.
3292
3293 2016-02-26  Chris Dumez  <cdumez@apple.com>
3294
3295         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
3296         https://bugs.webkit.org/show_bug.cgi?id=154714
3297
3298         Reviewed by Darin Adler.
3299
3300         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
3301         - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
3302         - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
3303
3304         * TestWebKitAPI/PlatformEfl.cmake:
3305         * TestWebKitAPI/PlatformGTK.cmake:
3306         * TestWebKitAPI/PlatformWin.cmake:
3307         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3308         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3310         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
3311         (TestWebKitAPI::testParseHTMLInteger):
3312         (TestWebKitAPI::parseHTMLIntegerFails):
3313         (TestWebKitAPI::TEST):
3314         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
3315         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
3316
3317 2016-02-26  Commit Queue  <commit-queue@webkit.org>
3318
3319         Unreviewed, rolling out r197158.
3320         https://bugs.webkit.org/show_bug.cgi?id=154758
3321
3322         This change did not fix the failing test (Requested by
3323         ryanhaddad on #webkit).
3324
3325         Reverted changeset:
3326
3327         "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
3328         surrogate.html is flakey"
3329         https://bugs.webkit.org/show_bug.cgi?id=154709
3330         http://trac.webkit.org/changeset/197158
3331
3332 2016-02-26  Anders Carlsson  <andersca@apple.com>
3333
3334         WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
3335         https://bugs.webkit.org/show_bug.cgi?id=154750
3336         rdar://problem/23861395
3337
3338         Reviewed by Tim Horton.
3339
3340         * MiniBrowser/mac/WK2BrowserWindowController.m:
3341         (-[WK2BrowserWindowController fetchWebsiteData:]):
3342         Use the new WKWebsiteDataStore SPI to compute data sizes.
3343
3344 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
3345
3346         RefCounter value changed callback should be called on all changes (not just zero edge).
3347         https://bugs.webkit.org/show_bug.cgi?id=154699
3348
3349         Reviewed by Geoff Garen.
3350
3351         RefCounter currently only triggers a callback when the count goes from zero
3352         to non-zero and vice-versa. Change that, to be useful to more clients.
3353
3354         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3355         (TestWebKitAPI::TEST):
3356             - Updated for change in RefCounter callback siganture & behaviour.
3357
3358 2016-02-25  Sam Weinig  <sam@webkit.org>
3359
3360         Allow WKUserScripts to be run in isolated worlds
3361         https://bugs.webkit.org/show_bug.cgi?id=154701
3362
3363         Reviewed by Anders Carlsson.
3364
3365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3366         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
3367         (-[SimpleDelegate webView:didFinishNavigation:]):
3368         (-[UserContentWorldRemoteObject didObserveNormalWorld]):
3369         (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
3370         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
3371         (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3372         (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
3373         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
3374
3375 2016-02-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3376
3377         W3C test importer should have an option to clean the destination directory
3378         https://bugs.webkit.org/show_bug.cgi?id=152685
3379
3380         Reviewed by Darin Adler.
3381
3382         Adding --clean-dest-dir option to W3C test importer.
3383         When this option is set, all files in the destination directory will be deleted
3384         except for WebKit specific files (test expectations, .gitignore...) before new tests import.
3385         Dangling test expectations are removed after tests import.'
3386
3387         Adding unit test and minor refactoring for the other tests.
3388
3389         * Scripts/webkitpy/w3c/test_importer.py:
3390         (parse_args): Add '--clean-dest-dir' option.
3391         (TestImporter.do_import):
3392         (TestImporter._is_baseline): helper routine to capture -expected.txt files.
3393         (TestImporter):
3394         (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
3395         (TestImporter.clean_destination_directory):
3396         (TestImporter.remove_dangling_expectations):
3397         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3398         (TestImporterTest._parse_options):
3399         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3400         (TestImporterTest.test_import_dir_with_no_tests):
3401         (TestImporterTest.test_import_dir_with_empty_init_py):
3402         (test_clean_directory_option):
3403
3404 2016-02-25  Myles C. Maxfield  <mmaxfield@apple.com>
3405
3406         REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
3407         https://bugs.webkit.org/show_bug.cgi?id=154709
3408         <rdar://problem/24483596>
3409
3410         Reviewed by Dan Bernstein.
3411
3412         Force auto-activation rules to a consistent state.
3413
3414         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3415         (WTR::InjectedBundle::platformInitialize):
3416
3417 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
3418
3419         Unreivewed build fix for r197150.
3420
3421         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
3422
3423 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
3424
3425         Restrict information passed with navigation action which is triggered by untrusted event
3426         https://bugs.webkit.org/show_bug.cgi?id=154571
3427         <rdar://problem/15967937>
3428
3429         Reviewed by Andy Estes.
3430
3431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3432         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
3433         (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3434         (TestWebKitAPI::TEST):
3435         (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3436         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
3437
3438 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
3439
3440         Should template RefCounter instead of RefCounter::Token
3441         https://bugs.webkit.org/show_bug.cgi?id=154691
3442
3443         Reviewed by Anders Carlsson.
3444
3445         Mechanical update per RefCounter interface change.
3446
3447         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3448         (TestWebKitAPI::TEST):
3449
3450 2016-02-25  Skachkov Aleksandr  <gskachkov@gmail.com>
3451
3452         Unreviewed: Add Aleksandr Skachkov as a commiter
3453
3454         * Scripts/webkitpy/common/config/contributors.json:
3455
3456 2016-02-25  Sam Weinig  <sam@webkit.org>
3457
3458         HashMap::ensure() should return an AddResult like all the other add-like functions
3459         https://bugs.webkit.org/show_bug.cgi?id=154680
3460
3461         Reviewed by Anders Carlsson.
3462
3463         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3464         (TestWebKitAPI::TEST):
3465         Update tests to use/test the new AddResult result.
3466
3467 2016-02-25  Alexey Proskuryakov  <ap@apple.com>
3468
3469         Enable MallocScribble when detecting leaks
3470         https://bugs.webkit.org/show_bug.cgi?id=154679
3471
3472         Reviewed by Geoffrey Garen.
3473
3474         * Scripts/webkitpy/port/ios.py:
3475         (IOSSimulatorPort.setup_environ_for_server):
3476         * Scripts/webkitpy/port/mac.py:
3477         (MacPort.setup_environ_for_server):
3478         * Scripts/webkitpy/port/mac_unittest.py:
3479         (MacTest.test_setup_environ_for_server):
3480
3481 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
3482
3483         Unreviewed, fix iOS builds after r197114.
3484
3485         * WebKitTestRunner/TestController.cpp:
3486         (WTR::createCanonicalUUIDString):
3487         (WTR::TestController::saltForOrigin):
3488
3489 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
3490
3491         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
3492         https://bugs.webkit.org/show_bug.cgi?id=153163
3493         <rdar://problem/24334526>
3494
3495         Reviewed by Tim Horton.
3496
3497         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3498         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
3499         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3500
3501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3502         (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
3503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3504
3505         * WebKitTestRunner/TestController.cpp:
3506         (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
3507         (WTR::checkUserMediaPermissionForOrigin): Ditto.
3508         (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
3509         (WTR::originUserVisibleName): Return a String.
3510         (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
3511         (WTR::TestController::saltForOrigin): Return salt for an origin.
3512         (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
3513         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
3514         (WTR::TestController::handleUserMediaPermissionRequest):
3515         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
3516         (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
3517         (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
3518         (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
3519         (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
3520         (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
3521         (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
3522         * WebKitTestRunner/TestController.h:
3523
3524         * WebKitTestRunner/TestInvocation.cpp:
3525         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3526
3527 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
3528
3529         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
3530         https://bugs.webkit.org/show_bug.cgi?id=151688
3531
3532         Reviewed by Dean Jackson.
3533
3534         Enables the WEB_ANIMATIONS compiler switch by default.
3535
3536         * Scripts/webkitperl/FeatureList.pm:
3537
3538 2016-02-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3539
3540         W3C importer should generate all web-platform-tests submodules descriptions
3541         https://bugs.webkit.org/show_bug.cgi?id=154587
3542
3543         Reviewed by Darin Adler.
3544
3545         Updated submodules description format (removing submodule name as it is the last string of the path really).
3546         Added git subroutines.
3547
3548         * Scripts/webkitpy/common/checkout/scm/git.py:
3549         (Git.origin_url):
3550         (Git):
3551         (Git.init_submodules):
3552         (Git.submodules_status):
3553         (Git.deinit_submodules):
3554         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3555         (WebPlatformTestServer._install_modules): Updated to submodule name removal.
3556         * Scripts/webkitpy/w3c/test_downloader.py:
3557         (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
3558         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3559         (TestImporterTest.test_submodules_generation): Reactivated partially this test.
3560
3561 2016-02-23  Dan Bernstein  <mitz@apple.com>
3562
3563         [Xcode] Linker errors display mangled names, but no longer should
3564         https://bugs.webkit.org/show_bug.cgi?id=154632
3565
3566         Reviewed by Sam Weinig.
3567
3568         * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
3569         * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
3570         * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
3571         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3572         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3573         * WebEditingTester/Configurations/Base.xcconfig: Ditto.
3574         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3575
3576 2016-02-23  Anders Carlsson  <andersca@apple.com>
3577
3578         WKWebView should implement NSCoding
3579         https://bugs.webkit.org/show_bug.cgi?id=137160
3580
3581         Reviewed by Dan Bernstein.
3582
3583         Add tests.
3584
3585         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3586         (TEST):
3587
3588 2016-02-23  Anders Carlsson  <andersca@apple.com>
3589
3590         WKProcessPool should conform to NSCoding
3591         https://bugs.webkit.org/show_bug.cgi?id=154608
3592
3593         Reviewed by Sam Weinig.
3594
3595         Add tests.
3596
3597         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3598         (TEST):
3599
3600 2016-02-23  Anders Carlsson  <andersca@apple.com>
3601
3602         WKWebsiteDataStore should conform to NSCoding
3603         https://bugs.webkit.org/show_bug.cgi?id=154605
3604
3605         Reviewed by Dan Bernstein.
3606
3607         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3608         (TEST):
3609
3610 2016-02-23  Anders Carlsson  <andersca@apple.com>
3611
3612         WKWebViewConfiguration should conform to NSCoding
3613         https://bugs.webkit.org/show_bug.cgi?id=154602
3614
3615         Reviewed by Beth Dakin.
3616
3617         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3618         (TEST):
3619
3620 2016-02-23  Anders Carlsson  <andersca@apple.com>
3621
3622         WKPreferences should conform to NSCoding
3623         https://bugs.webkit.org/show_bug.cgi?id=154597
3624
3625         Reviewed by Sam Weinig.
3626
3627         Test encoding and decoding WKPreferences.
3628
3629         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3630         (encodeAndDecode):
3631         (TEST):
3632
3633 2016-02-23  Anders Carlsson  <andersca@apple.com>
3634
3635         Fix build.
3636
3637         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
3638         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
3639
3640 2016-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3641
3642         [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
3643         https://bugs.webkit.org/show_bug.cgi?id=153993
3644
3645         Reviewed by Carlos Garcia Campos.
3646
3647         * MiniBrowser/gtk/main.c:
3648         (createBrowserWindow): Support --geometry argument for MiniBrowser.
3649         We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
3650         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
3651         The base class has to be loaded first, otherwise any subclase referencing it will give import error.
3652         In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
3653         By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
3654         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3655         (BrowserDriverFactory.create):
3656         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
3657         (GTKBrowserDriver):
3658         (GTKBrowserDriver.prepare_env):
3659         (GTKBrowserDriver.restore_env):
3660         (GTKBrowserDriver.close_browsers):
3661         (GTKBrowserDriver._launch_process):
3662         (GTKBrowserDriver._terminate_processes):
3663         (GTKBrowserDriver._screen_size):
3664         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
3665         (GTKMiniBrowserDriver):
3666         (GTKMiniBrowserDriver.prepare_env):
3667         (GTKMiniBrowserDriver.launch_url):
3668         (GTKMiniBrowserDriver.close_browsers):
3669         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
3670         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3671         (SimpleHTTPServerDriver):
3672         (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
3673         Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
3674         * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
3675         (load_subclasses):
3676
3677 2016-02-23  Alejandro G. Castro  <alex@igalia.com>
3678
3679         [GTK] Missing configuration patch for openh264 compilation
3680         https://bugs.webkit.org/show_bug.cgi?id=154455
3681
3682         This patch is required for the openh264 compilation with the
3683         jhbuild-webrtc.modules. The code was implemented by Alessandro
3684         Decina.
3685
3686         Reviewed by Philippe Normand.
3687
3688         * gtk/patches/openh264-configure.patch: Added.
3689
3690 2016-02-20  Olivier Blin  <olivier.blin@softathome.com>
3691
3692         [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
3693         https://bugs.webkit.org/show_bug.cgi?id=154479
3694
3695         Reviewed by Michael Catanzaro.
3696
3697         * WebKitTestRunner/CMakeLists.txt:
3698
3699 2016-02-19  Konstantin Tokarev  <annulen@yandex.ru>
3700
3701         [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
3702         https://bugs.webkit.org/show_bug.cgi?id=154467
3703
3704         Reviewed by Michael Catanzaro.
3705
3706         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
3707         (beforeAll):
3708         (afterAll):
3709
3710 2016-02-19  Brady Eidson  <beidson@apple.com>
3711
3712         Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
3713         https://bugs.webkit.org/show_bug.cgi?id=154428
3714
3715         Reviewed by Jer Noble.
3716
3717         * WebKitTestRunner/TestController.cpp:
3718         (WTR::TestController::generatePageConfiguration):
3719         (WTR::TestController::databaseProcessName):
3720         (WTR::TestController::databaseProcessDidCrash):
3721         * WebKitTestRunner/TestController.h:
3722
3723 2016-02-18  Philippe Normand  <pnormand@igalia.com>
3724
3725         [GStreamer] Bump internal jhbuild versions to 1.6.3
3726         https://bugs.webkit.org/show_bug.cgi?id=149594
3727
3728         Reviewed by Michael Catanzaro.
3729
3730         * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
3731         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
3732         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
3733         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
3734
3735 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
3736
3737         Extend HashCountedSet with a method to efficiently set the count of an entry
3738         https://bugs.webkit.org/show_bug.cgi?id=154352
3739
3740         Reviewed by Geoffrey Garen.
3741
3742         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
3743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3744         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
3745
3746 2016-02-18  Commit Queue  <commit-queue@webkit.org>
3747
3748         Unreviewed, rolling out r196791.
3749         https://bugs.webkit.org/show_bug.cgi?id=154438
3750
3751         broke windows build (Requested by alexchristensen on #webkit).
3752
3753         Reverted changeset:
3754
3755         "Extend HashCountedSet with a method to efficiently set the
3756         count of an entry"
3757         https://bugs.webkit.org/show_bug.cgi?id=154352
3758         http://trac.webkit.org/changeset/196791
3759
3760 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
3761
3762         Extend HashCountedSet with a method to efficiently set the count of an entry
3763         https://bugs.webkit.org/show_bug.cgi?id=154352
3764
3765         Reviewed by Geoffrey Garen.
3766
3767         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
3768         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3769         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
3770
3771 2016-02-18  Anders Carlsson  <andersca@apple.com>
3772
3773         Get rid of the --target-web-process and --use-web-process-xpc-service options.
3774
3775         Rubber-stamped by Dan Bernstein.
3776
3777         We now always use XPC, and --target-web-process is no longer supported.
3778
3779         * Scripts/webkitdirs.pm:
3780         (execMacWebKitAppForDebugging):
3781         (shouldTargetWebProcess): Deleted.
3782         (determineShouldTargetWebProcess): Deleted.
3783         (shouldUseXPCServiceForWebProcess): Deleted.
3784         (determineShouldUseXPCServiceForWebProcess): Deleted.
3785         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
3786         (argumentsForRunAndDebugMacWebKitApp): Deleted.
3787
3788 2016-02-18  Ryan Haddad  <ryanhaddad@apple.com>
3789
3790         Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
3791         https://bugs.webkit.org/show_bug.cgi?id=153997
3792
3793         Reviewed by Filip Pizlo.
3794
3795         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3796
3797 2016-02-18  Jer Noble  <jer.noble@apple.com>
3798
3799         run-webkit-httpd should use webkitpy to run httpd.
3800         https://bugs.webkit.org/show_bug.cgi?id=154271
3801
3802         Reviewed by Alexey Proskuryakov.
3803
3804         Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
3805         options to match the current run-webkit-httpd (optional) behavior.
3806
3807         * Scripts/run-webkit-httpd:
3808         (parse_args):
3809         (main):
3810         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3811         (LayoutTestApacheHttpd.__init__):
3812         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3813         (Lighttpd._prepare_config):
3814         * Scripts/webkitpy/port/base.py:
3815         (Port.to.start_http_server):
3816
3817 2016-02-18  Filip Pizlo  <fpizlo@apple.com>
3818
3819         Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
3820         https://bugs.webkit.org/show_bug.cgi?id=154383
3821
3822         Reviewed by Saam Barati.
3823
3824         * Scripts/run-jsc-stress-tests:
3825
3826 2016-02-17  Filip Pizlo  <fpizlo@apple.com>
3827
3828         Remove LLVM dependencies from WebKit
3829         https://bugs.webkit.org/show_bug.cgi?id=154323
3830
3831         Reviewed by Antti Koivisto and Benjamin Poulain.
3832
3833         * Scripts/copy-webkitlibraries-to-product-directory:
3834         (isContentOfFileEqualToString):
3835         (fileContains): Deleted.
3836         (buildLLVM): Deleted.
3837         (symlinkLLVMLibrariesIfNeeded): Deleted.
3838
3839 2016-02-16  Sam Weinig  <sam@webkit.org>
3840
3841         Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
3842         https://bugs.webkit.org/show_bug.cgi?id=134857
3843
3844         Reviewed by Geoffrey Garen.
3845
3846         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3847         Add tests for HashMap::ensure.
3848
3849 2016-02-17  Nan Wang  <n_wang@apple.com>
3850
3851         AX: Implement sentence related text marker functions using TextIterator
3852         https://bugs.webkit.org/show_bug.cgi?id=154312
3853
3854         Reviewed by Chris Fleizach.
3855
3856         * DumpRenderTree/AccessibilityUIElement.cpp:
3857         (nextParagraphEndTextMarkerForTextMarkerCallback):
3858         (sentenceTextMarkerRangeForTextMarkerCallback):
3859         (previousSentenceStartTextMarkerForTextMarkerCallback):
3860         (nextSentenceEndTextMarkerForTextMarkerCallback):
3861         (setSelectedVisibleTextRangeCallback):
3862         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3863         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3864         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3865         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3866         (AccessibilityUIElement::getJSClass):
3867         * DumpRenderTree/AccessibilityUIElement.h:
3868         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3869         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3870         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3871         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3872         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3873         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3874         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3875         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3876         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3877         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3878         (AccessibilityUIElement::supportedActions):
3879         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3880         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3881         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3882         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3883         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3884         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3885         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3886         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3887         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3888         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3889         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3890         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3891         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3892         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3893         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3894         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3895         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3896         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3897         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3898         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3899         (WTR::_convertMathMultiscriptPairsToString):
3900
3901 2016-02-15  Brent Fulgham  <bfulgham@apple.com>
3902
3903         [Mac] Gather some rudimentary statistics during resource load 
3904         https://bugs.webkit.org/show_bug.cgi?id=153575
3905         <rdar://problem/24075254>
3906
3907         Reviewed by Brady Eidson.
3908
3909         * MiniBrowser/mac/SettingsController.h:
3910         * MiniBrowser/mac/SettingsController.m:
3911         (-[SettingsController _populateMenu]): Add menu item for new debug flag.
3912         (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
3913         (-[SettingsController resourceLoadStatisticsEnabled]): Added.
3914         * MiniBrowser/mac/WK1BrowserWindowController.m:
3915         (-[WK1BrowserWindowController didChangeSettings]): React to changes in
3916         users's desire to track resource load statistics.
3917
3918 2016-02-15  Csaba Osztrogonác  <ossy@webkit.org>
3919
3920         [EFL] Update Tools/efl/install-dependencies
3921         https://bugs.webkit.org/show_bug.cgi?id=154239
3922
3923         Reviewed by Michael Catanzaro.
3924
3925         * efl/install-dependencies:
3926
3927 2016-02-15  Alex Christensen  <achristensen@webkit.org>
3928
3929         Fix internal Windows build of projects built after WebKit
3930         https://bugs.webkit.org/show_bug.cgi?id=154249
3931         rdar://problem/24644805
3932
3933         Reviewed by Chris Dumez.
3934
3935         * DumpRenderTree/PlatformWin.cmake:
3936         * MiniBrowser/win/CMakeLists.txt:
3937         Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
3938         more like projects built internally after WebKit.  They should only need to use what
3939         is in ForwardingHeaders/WebKit.
3940
3941 2016-02-12  Nan Wang  <n_wang@apple.com>
3942
3943         AX: Implement paragraph related text marker functions using TextIterator
3944         https://bugs.webkit.org/show_bug.cgi?id=154098
3945         <rdar://problem/24269675>
3946
3947         Reviewed by Chris Fleizach.
3948
3949         * DumpRenderTree/AccessibilityUIElement.cpp:
3950         (nextWordEndTextMarkerForTextMarkerCallback):
3951         (paragraphTextMarkerRangeForTextMarkerCallback):
3952         (previousParagraphStartTextMarkerForTextMarkerCallback):
3953         (nextParagraphEndTextMarkerForTextMarkerCallback):
3954         (setSelectedVisibleTextRangeCallback):
3955         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3956         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3957         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3958         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3959         (AccessibilityUIElement::getJSClass):
3960         * DumpRenderTree/AccessibilityUIElement.h:
3961         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3962         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3963         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3964         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3965         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3966         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3967         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3968         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3969         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3970         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3971         (AccessibilityUIElement::supportedActions):
3972         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3973         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
3974         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
3975         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3976         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3977         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3978         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3979         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3980         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3981         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3982         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3983         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3984         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3985         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3986         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3987         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3988         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3989         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3990         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3991         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3992         (WTR::_convertMathMultiscriptPairsToString):
3993
3994 2016-02-12  Jason Marcell  <jmarcell@apple.com>
3995
3996         Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
3997         https://bugs.webkit.org/show_bug.cgi?id=154180
3998
3999         Reviewed by Alexey Proskuryakov.
4000
4001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
4002         repository.
4003
4004 2016-02-12  Jer Noble  <jer.noble@apple.com>
4005
4006         [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
4007         https://bugs.webkit.org/show_bug.cgi?id=154136
4008
4009         Reviewed by Alex Christensen.
4010
4011         Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
4012
4013         Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
4014         to GCC_PREPROCESSOR_DEFINES.
4015
4016         * TestWebKitAPI/Configurations/Base.xcconfig:
4017         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4018         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
4019         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
4020         (TestWebKitAPI::TEST_F):
4021
4022 2016-02-11  Dana Burkart  <dburkart@apple.com>
4023
4024         Large logs can bring down the webkit master
4025         https://bugs.webkit.org/show_bug.cgi?id=122112
4026
4027         Reviewed by Lucas Forschler.
4028
4029         Implement the suggested fix of throwing away stdout / stderr.
4030
4031         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4032         (RunWebKit1LeakTests):
4033
4034 2016-02-10  Jason Marcell  <jmarcell@apple.com>
4035
4036         Remove calls to parseInt in order to work with non-integer revisions
4037         https://bugs.webkit.org/show_bug.cgi?id=153820
4038
4039         Reviewed by Daniel Bates.
4040
4041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4042         (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
4043         revisions.
4044         (BuildbotIteration.prototype._parseData): Ditto.
4045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4046         (BuildbotQueue.prototype.update): Ditto.
4047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
4048         (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
4049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
4050         (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
4051         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
4052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
4053
4054 2016-02-10  Jason Marcell  <jmarcell@apple.com>
4055
4056         Teach dashboard code to compare non-integer revisions
4057         https://bugs.webkit.org/show_bug.cgi?id=152345
4058
4059         Reviewed by Daniel Bates.
4060
4061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4062         (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
4063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4064         (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
4065         revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
4066         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
4067         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
4068         revisions. Also uses new Trac.nextRevision method to calculate a revision range.
4069         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
4070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
4071         (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
4072         methods.
4073         (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
4074         (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
4075         (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
4076         (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
4077         (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
4078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
4079
4080 2016-02-09  Nan Wang  <n_wang@apple.com>
4081
4082         AX: Implement word related text marker functions using TextIterator
4083         https://bugs.webkit.org/show_bug.cgi?id=153939
4084         <rdar://problem/24269605>
4085
4086         Reviewed by Chris Fleizach.
4087
4088         * DumpRenderTree/AccessibilityUIElement.cpp:
4089         (endTextMarkerCallback):
4090         (leftWordTextMarkerRangeForTextMarkerCallback):
4091         (rightWordTextMarkerRangeForTextMarkerCallback):
4092         (previousWordStartTextMarkerForTextMarkerCallback):
4093         (nextWordEndTextMarkerForTextMarkerCallback):
4094         (setSelectedVisibleTextRangeCallback):
4095         (AccessibilityUIElement::setSelectedVisibleTextRange):
4096         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
4097         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
4098         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
4099         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
4100         (AccessibilityUIElement::getJSClass):
4101         * DumpRenderTree/AccessibilityUIElement.h:
4102         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4103         (AccessibilityUIElement::setSelectedVisibleTextRange):
4104         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
4105         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
4106         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
4107         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
4108         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4109         (AccessibilityUIElement::setSelectedVisibleTextRange):
4110         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
4111         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
4112         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
4113         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
4114         (AccessibilityUIElement::supportedActions):
4115         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4116         (WTR::AccessibilityUIElement::setBoolAttributeValue):
4117         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
4118         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
4119         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
4120         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
4121         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4122         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4123         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4124         (WTR::AccessibilityUIElement::endTextMarker):
4125         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
4126         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
4127         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
4128         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
4129         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
4130         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4131         (WTR::AccessibilityUIElement::endTextMarker):
4132         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
4133         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
4134         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
4135         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
4136         (WTR::_convertMathMultiscriptPairsToString):
4137
4138 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
4139
4140         [EFL] Remove eail related cruft after r195725
4141         https://bugs.webkit.org/show_bug.cgi?id=154030
4142
4143         Reviewed by Alex Christensen.
4144
4145         * efl/jhbuildrc:
4146
4147 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
4148
4149         [EFL] Remove LLVM related cruft after r196077
4150         https://bugs.webkit.org/show_bug.cgi?id=154031
4151
4152         Reviewed by Alex Christensen.
4153
4154         * efl/jhbuild.modules:
4155         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
4156         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
4157         * efl/patches/llvm-version-arm64.patch: Removed.
4158
4159 2016-02-05  Aakash Jain  <aakash_jain@apple.com>
4160
4161         tests fail if display sleeps while run-webkit-tests is running
4162         https://bugs.webkit.org/show_bug.cgi?id=153919
4163
4164         Reviewed by Alexey Proskuryakov.
4165
4166         * DumpRenderTree/mac/LayoutTestHelper.m:
4167         (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
4168         (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
4169         (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
4170
4171 2016-02-05  Alex Christensen  <achristensen@webkit.org>
4172
4173         Fix iOS API tests after r196082
4174         https://bugs.webkit.org/show_bug.cgi?id=153900
4175
4176         Reviewed by Jer Noble.
4177
4178         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4179         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
4180         [WebView initialize] doesn't call JSC::initializeThreading on iOS.
4181
4182 2016-02-04  Jason Marcell  <jmarcell@apple.com>
4183
4184         The status message for passing combined builder queues should say "all builds succeeded" when expanded.
4185         https://bugs.webkit.org/show_bug.cgi?id=153882
4186
4187         Reviewed by Alexey Proskuryakov.
4188
4189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4190         (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
4191         when expanded.
4192
4193 2016-02-03  Filip Pizlo  <fpizlo@apple.com>
4194
4195         run-jsc-stress-tests should be better at telling you details about test failures
4196         https://bugs.webkit.org/show_bug.cgi?id=153845
4197
4198         Reviewed by Geoffrey Garen.
4199
4200         Here's an example of the contents of results/resultsByFamily, one of the new files that this
4201         generates, for some local testing I'm doing.  Notice how it groups families of tests together.
4202
4203         You won't see this unless you cat results/resultsByFamily.
4204
4205         regress.yaml/Regress/radar-24289839.js:
4206             regress.yaml/Regress/radar-24289839.js.default: PASS
4207             regress.yaml/Regress/radar-24289839.js.ftl: PASS
4208             regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
4209             regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
4210         
4211         regress.yaml/Regress/radar-24290639.js:
4212             regress.yaml/Regress/radar-24290639.js.default: PASS
4213             regress.yaml/Regress/radar-24290639.js.ftl: PASS
4214             regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
4215             regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
4216         
4217         regress.yaml/Regress/radar-24290670.js: FAILED
4218         
4219         * Scripts/run-jsc-stress-tests:
4220
4221 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4222
4223         [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
4224         https://bugs.webkit.org/show_bug.cgi?id=153835
4225
4226         Reviewed by Martin Robinson.
4227
4228         WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
4229         the context menu event is not handled, but we are using the
4230         returned value without null checking it.
4231
4232         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4233         (WTR::EventSendingController::contextClick):
4234
4235 2016-02-03  Jason Marcell  <jmarcell@apple.com>
4236
4237         Format revisions for display according to repository type
4238         https://bugs.webkit.org/show_bug.cgi?id=153818
4239
4240         Reviewed by Alexey Proskuryakov.
4241
4242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4243         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
4244         to repository type.
4245         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
4246         (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
4247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
4248         _formatRevisionForDisplay function.
4249
4250 2016-02-03  Aakash Jain  <aakash_jain@apple.com>
4251
4252         Logs/CoreSimulator filling up OS disk on WebKit testers
4253         https://bugs.webkit.org/show_bug.cgi?id=153853
4254         <rdar://problem/24496003>
4255
4256         Reviewed by Alexey Proskuryakov.
4257
4258         * Scripts/webkitpy/port/ios.py:
4259         (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
4260
4261 2016-02-03  Brian Burg  <bburg@apple.com>
4262
4263         git-add-reviewer should work when run from a subdirectory within the repository
4264         https://bugs.webkit.org/show_bug.cgi?id=153842
4265
4266         Reviewed by David Kilzer.
4267
4268         There are two problems that needed to be fixed:
4269
4270          - We can't assume .git is in $PWD/.git
4271          - We can't specify absolute paths to `git commit`
4272
4273         Fix these problems using the helpers in VCSUtils that were added to
4274         fix this same issue for prepare-changeCogs.
4275
4276         * Scripts/VCSUtils.pm: Export gitDirectory()
4277         * Scripts/git-add-reviewer:
4278         (nonInteractive): Cache gitDirectory() result.
4279         (addReviewer):
4280         (commit):
4281         (changeLogsForCommit): Make paths relative.
4282
4283 2016-02-03  Jer Noble  <jer.noble@apple.com>
4284
4285         Yet another Yosemite build fix.
4286
4287         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4288
4289 2016-02-03  Jer Noble  <jer.noble@apple.com>
4290
4291         iOS build fix after Yosemite build fix broke iOS build.
4292
4293         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4294
4295 2016-02-03  Jer Noble  <jer.noble@apple.com>
4296
4297         Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
4298
4299         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4300
4301 2016-02-03  Joonghun Park  <jh718.park@samsung.com>
4302
4303         [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
4304         https://bugs.webkit.org/show_bug.cgi?id=153827
4305
4306         Reviewed by Michael Catanzaro.
4307
4308         When an array is passed to subroutines as argument in perl,
4309         a list containing its element is returned from the array.
4310         Currently @$ arguments are being passed, then it is going to be one list
4311         including all the elements not only from @ but also from $.
4312         As a result, --cmakeargs option's value is included in @cmakeArgs
4313         at generateBuildSystemFromCMakeProject subroutine,
4314         so $additionalCMakeArgs doesn't needed anymore.
4315
4316         * Scripts/webkitdirs.pm:
4317         (generateBuildSystemFromCMakeProject):
4318
4319 2016-02-03  Jer Noble  <jer.noble@apple.com>
4320
4321         [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
4322         https://bugs.webkit.org/show_bug.cgi?id=153669
4323
4324         Reviewed by Alex Christensen.
4325
4326         Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
4327         calling appropriate NSURLSessionDelegate callbacks.
4328
4329         Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI.  Without this, the ENABLE macros in WebCore
4330         header files will not match the one used when compiling WebCore, leading to strange crashes and weird
4331         inconsistencies when calling, e.g., inline methods.
4332
4333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
4334         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4336         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
4337         (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
4338         (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):