c1865841211e72df720efb45a99299af13f6caee
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Remove Vibration API
4         https://bugs.webkit.org/show_bug.cgi?id=171766
5
6         Rubber-stamped by Alexey Proskuryakov.
7
8         * Scripts/webkitperl/FeatureList.pm:
9
10 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
11
12         Add WPE release bots
13         https://bugs.webkit.org/show_bug.cgi?id=171973
14
15         Reviewed by Žan Doberšek.
16
17         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
18         It also adds a new WPE buildbot category.
19
20         * BuildSlaveSupport/build.webkit.org-config/config.json:
21         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22         (InstallWpeDependencies):
23         (appendCustomBuildFlags):
24         (Factory.__init__):
25         (loadBuilderConfig):
26         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
27         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
28
29 2017-05-09  Sam Weinig  <sam@webkit.org>
30
31         Remove support for legacy Notifications
32         https://bugs.webkit.org/show_bug.cgi?id=171487
33
34         Reviewed by Jon Lee.
35
36         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
37         (DRTDesktopNotificationPresenter::checkNotificationPermission):
38         * Scripts/webkitperl/FeatureList.pm:
39         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
40         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
41
42 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
43
44         Remove user agent quirk for Slack
45         https://bugs.webkit.org/show_bug.cgi?id=171869
46
47         Reviewed by Carlos Garcia Campos.
48
49         Remove the corresponding test.
50
51         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
52         (TestWebKitAPI::TEST):
53
54 2017-05-10  Commit Queue  <commit-queue@webkit.org>
55
56         Unreviewed, rolling out r216578.
57         https://bugs.webkit.org/show_bug.cgi?id=171920
58
59         Broke the GTK+ build with Wayland enabled (Requested by KaL on
60         #webkit).
61
62         Reverted changeset:
63
64         "[GTK] Bump GTK+ and its dependencies in jhbuild"
65         https://bugs.webkit.org/show_bug.cgi?id=171918
66         http://trac.webkit.org/changeset/216578
67
68 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
69
70         [GTK] Bump GTK+ and its dependencies in jhbuild
71         https://bugs.webkit.org/show_bug.cgi?id=171918
72
73         Reviewed by Carlos Alberto Lopez Perez.
74
75         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
76         (WTR::initializeGtkSettings):
77         * gtk/jhbuild.modules:
78         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
79         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
80
81 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
82
83         [Win] Set CMake args in build-webkit
84         https://bugs.webkit.org/show_bug.cgi?id=171436
85
86         Reviewed by Per Arne Vollan.
87
88         * Scripts/build-webkit:
89
90 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
91
92         ImageDiff: Add CG implementation for new ImageDiff
93         https://bugs.webkit.org/show_bug.cgi?id=170608
94
95         Reviewed Alex Christensen.
96
97         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
98         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
99         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
100         * ImageDiff/CMakeLists.txt:
101         * ImageDiff/Cairo.cmake:
102         * ImageDiff/ImageDiff.cpp:
103         (main):
104         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
105         * ImageDiff/PlatformImage.cpp:
106         * ImageDiff/PlatformImage.h:
107         * ImageDiff/cairo/PlatformImageCairo.cpp:
108         * ImageDiff/cg/ImageDiff.cpp: Removed.
109         * ImageDiff/cg/PlatformImageCG.cpp: Added.
110         (ImageDiff::PlatformImage::createFromStdin):
111         (ImageDiff::PlatformImage::createFromDiffData):
112         (ImageDiff::PlatformImage::PlatformImage):
113         (ImageDiff::PlatformImage::~PlatformImage):
114         (ImageDiff::PlatformImage::width):
115         (ImageDiff::PlatformImage::height):
116         (ImageDiff::PlatformImage::rowBytes):
117         (ImageDiff::PlatformImage::hasAlpha):
118         (ImageDiff::PlatformImage::pixels):
119         (ImageDiff::PlatformImage::writeAsPNGToStdout):
120
121 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
122
123         Enable FTL JIT by default on AArch64
124         https://bugs.webkit.org/show_bug.cgi?id=144039
125
126         Reviewed by Yusuke Suzuki.
127
128         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
129         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
130         as an unsupported FTL platform.
131         * Scripts/webkitdirs.pm:
132         (isARM64): Returns 1 if the determined architecture is 'arm64'.
133         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
134
135 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
136
137         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
138         https://bugs.webkit.org/show_bug.cgi?id=170857
139         <rdar://problem/31635373>
140
141         Reviewed by Aakash Jain.
142
143         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
144         code to search for crash logs.
145
146         * Scripts/webkitpy/port/darwin.py:
147         (DarwinPort._get_crash_log): Moved from MacPort.
148         * Scripts/webkitpy/port/darwin_testcase.py:
149         (DarwinTest.test_get_crash_log): Moved from MacTest.
150         * Scripts/webkitpy/port/ios_device.py:
151         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
152         devices must search for crash-logs remotely.
153         * Scripts/webkitpy/port/ios_simulator.py:
154         (IOSSimulatorPort._get_crash_log): Deleted.
155         * Scripts/webkitpy/port/ios_simulator_unittest.py:
156         (IOSSimulatorTest.test_get_crash_log): Deleted.
157         * Scripts/webkitpy/port/mac.py:
158         (MacPort._get_crash_log): Moved to DarwinPort
159         * Scripts/webkitpy/port/mac_unittest.py:
160         (MacTest.test_get_crash_log): Moved to DarwinTest.
161
162 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
163
164         build ImageDiff with host SDK from Make
165         https://bugs.webkit.org/show_bug.cgi?id=171835
166
167         Reviewed by Alexey Proskuryakov.
168
169         ImageDiff should be built for the default SDK and default architecture when
170         the SDKROOT is set to either iOS device or iOS simulator. Check the
171         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
172
173         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
174         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
175
176 2017-05-09  Matt Lewis  <jlewis3@apple.com>
177
178         Unreviewed, adding myself to contributors.json
179
180         * Scripts/webkitpy/common/config/contributors.json:
181
182 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
183
184         REGRESSION: ImageDiff not building with make
185         https://bugs.webkit.org/show_bug.cgi?id=171788
186
187         Reviewed by Alex Christensen.
188
189         * Makefile: Build ImageDiff for all platforms.
190
191 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
192
193         [Win] ImageDiff isn't built since Bug 168945
194         https://bugs.webkit.org/show_bug.cgi?id=171847
195
196         Reviewed by Alex Christensen.
197
198         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
199         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
200         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
201
202 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
203
204         Upstream the WPE port
205         https://bugs.webkit.org/show_bug.cgi?id=171110
206
207         Reviewed by Alex Christensen.
208
209         webkit-dev thread:
210         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
211
212         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
213         In-file changes removed from this ChangeLog entry for brevity.
214
215         * BuildSlaveSupport/built-product-archive:
216         * BuildSlaveSupport/test-result-archive:
217         * CMakeLists.txt:
218         * ImageDiff/PlatformWPE.cmake: Added.
219         * Scripts/build-dumprendertree:
220         * Scripts/build-webkit:
221         * Scripts/build-webkittestrunner:
222         * Scripts/update-webkit-libs-jhbuild:
223         * Scripts/update-webkitwpe-libs: Added.
224         * Scripts/webkitdirs.pm:
225         * Scripts/webkitperl/FeatureList.pm:
226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
227         * Scripts/webkitpy/port/factory.py:
228         * Scripts/webkitpy/port/wpe.py: Added.
229         * TestWebKitAPI/PlatformWPE.cmake: Added.
230         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
231         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
232         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
233         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
234         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
235         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
236         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
238         * WebKitTestRunner/InjectedBundle/TestRunner.h:
239         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
240         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
241         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
242         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
243         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
244         * WebKitTestRunner/PlatformWPE.cmake: Added.
245         * WebKitTestRunner/PlatformWebView.h:
246         * WebKitTestRunner/TestController.cpp:
247         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
248         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
249         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
250         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
251         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
252         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
253         * jhbuild/jhbuild-wrapper:
254         * wpe/generate-inspector-gresource-manifest.py: Added.
255         * wpe/jhbuild.modules: Added.
256         * wpe/jhbuildrc: Added.
257         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
258         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
259         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
260         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
261         * wpe/patches/glib-warning-fix.patch: Added.
262         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
263         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
264         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
265         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
266         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
267
268 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
269
270         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
271         https://bugs.webkit.org/show_bug.cgi?id=169421
272         <rdar://problem/30950171>
273
274         Reviewed by Tim Horton.
275
276         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
277         (createBitmapContextFromWebView): Implement for IOSurface.
278         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
279         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
280
281 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
282
283         buildbot: Cleanup simulators after running tests
284         https://bugs.webkit.org/show_bug.cgi?id=171679
285
286         Reviewed by Aakash Jain.
287
288         simctl is partitioned for each user. Since kill-old-processes
289         is run as root, we need to specify the buildbot user when tearing
290         down simulators between steps.
291
292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
293         (KillOldProcesses): Pass buildbot user to kill-old-processes.
294         * BuildSlaveSupport/kill-old-processes:
295         (main): Specify the user for simctl if one has been provided.
296
297 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
298
299         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
300         https://bugs.webkit.org/show_bug.cgi?id=171681
301
302         Reviewed by Carlos Garcia Campos.
303
304         * gtk/install-dependencies:
305
306 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
307
308         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
309
310         Glib uses now Unicode quotes in error messages.
311
312         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
313         (testWebKitConsoleMessageNetworkError):
314
315 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
316
317         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
318
319         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
320         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
321         characters to the input. Also fix typo in the function name.
322
323         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
324         (testWebViewJavaScriptDialogs):
325
326 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
327
328         [GTK] Cannot sign in with new Google sign-in page
329         https://bugs.webkit.org/show_bug.cgi?id=171770
330
331         Unreviewed. This just adds a test.
332
333         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
334         (TestWebKitAPI::TEST):
335
336 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
337
338         [iOS WK2] Make rotation tests more reliable
339         https://bugs.webkit.org/show_bug.cgi?id=171778
340
341         Reviewed by Tim Horton.
342
343         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
344         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
345         with override layout parameters, and an override orientation, and these caused viewport
346         size to leak into later tests, and WebCore orientation to not get reset correctly.
347
348         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
349         an override orientation was set, and would never re-register, causing lost orientationchanged
350         events.
351
352         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
353         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
354
355         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
356         the WebProcess is caught up before proceeding with the test.
357
358         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
359         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
360         * WebKitTestRunner/ios/TestControllerIOS.mm:
361         (WTR::TestController::platformResetStateToConsistentValues):
362         (WTR::TestController::platformConfigureViewForTest):
363
364 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
365
366         [Mac][cmake] Buildfix after r216047
367         https://bugs.webkit.org/show_bug.cgi?id=171769
368
369         Unreviewed buildfix.
370
371         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
372
373 2017-05-05  Brady Eidson  <beidson@apple.com>
374
375         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
376         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
377
378         Reviewed by Andy Estes.
379
380         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
381         (TEST):
382
383 2017-05-05  Brian Burg  <bburg@apple.com>
384
385         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
386         https://bugs.webkit.org/show_bug.cgi?id=171748
387         <rdar://problem/32027327>
388
389         Reviewed by Michael Catanzaro.
390
391         Remove temporary workaround now that the assertion failure is fixed.
392
393         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
394         (TEST):
395
396 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
397
398         Make it possible to test rotation in iOS WebKitTestRunner
399         https://bugs.webkit.org/show_bug.cgi?id=171755
400
401         Reviewed by Tim Horton.
402
403         Add to UIScriptController:
404             void simulateRotation(DeviceOrientation orientation, object callback);
405             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
406
407         The former just does a view resize, as a simple WKWebView app would do. The second does
408         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
409         layout size and interface orientation. The two behaviors produce different resize and
410         orientationchange events and sizes, and both need to be tested.
411
412         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
413         which is now a custom subclass (PlatformWebViewController).
414
415         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
416         (WTR::UIScriptController::simulateRotation):
417         (WTR::UIScriptController::simulateRotationLikeSafari):
418         * DumpRenderTree/mac/UIScriptControllerMac.mm:
419         (WTR::UIScriptController::simulateRotation):
420         (WTR::UIScriptController::simulateRotationLikeSafari):
421         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
422         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
423         (WTR::toDeviceOrientation):
424         (WTR::UIScriptController::simulateRotation):
425         (WTR::UIScriptController::simulateRotationLikeSafari):
426         * TestRunnerShared/UIScriptContext/UIScriptController.h:
427         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
428         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
429         (-[TestRunnerWKWebView dealloc]):
430         (-[TestRunnerWKWebView _didEndRotation]):
431         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
432         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
433         (WTR::PlatformWebView::PlatformWebView):
434         * WebKitTestRunner/ios/TestControllerIOS.mm:
435         (WTR::TestController::platformResetStateToConsistentValues):
436         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
437         (WTR::toUIDeviceOrientation):
438         (WTR::UIScriptController::simulateRotation):
439         (WTR::UIScriptController::simulateRotationLikeSafari):
440         (WTR::UIScriptController::platformClearAllCallbacks):
441         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
442         (WTR::UIScriptController::simulateRotation):
443         (WTR::UIScriptController::simulateRotationLikeSafari):
444
445 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
446
447         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
448         https://bugs.webkit.org/show_bug.cgi?id=168945
449         <rdar://problem/30745695>
450
451         Reviewed by David Kilzer.
452
453         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
454         target SDK. These two changes must happen simultaneously because some archives will
455         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
456
457         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
458         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
459         tools directory still includes ImageDiff.
460         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
461         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
462         * Scripts/webkitpy/port/darwin.py: 
463         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
464         locally or when running archives.
465         * Scripts/webkitpy/port/image_diff.py:
466         (IOSSimulatorImageDiffer): Deleted.
467         * Scripts/webkitpy/port/ios_simulator.py:
468         (IOSSimulatorPort.diff_image): Deleted.
469
470 2017-05-05  Brian Burg  <bburg@apple.com>
471
472         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
473         https://bugs.webkit.org/show_bug.cgi?id=171748
474
475         Unreviewed test gardening.
476
477         The assertion failure will be investigated separately in order to avoid rolling out
478         the fix for "secure" cookies. This assertion fails even without r216258 applied.
479
480         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
481         (TEST):
482
483 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
484
485         Unreviewed, rolling out r216260.
486
487         Breaks internal iOS testers
488
489         Reverted changeset:
490
491         "Use ImageDiff built by host SDK and remove ImageDiff from
492         DumpRenderTree"
493         https://bugs.webkit.org/show_bug.cgi?id=168945
494         http://trac.webkit.org/changeset/216260
495
496 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
497
498         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
499         https://bugs.webkit.org/show_bug.cgi?id=168945
500         <rdar://problem/30745695>
501
502         Reviewed by David Kilzer.
503
504         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
505         target SDK. These two changes must happen simultaneously because some archives will
506         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
507
508         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
509         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
510         tools directory still includes ImageDiff.
511         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
512         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
513         * Scripts/webkitpy/port/darwin.py: 
514         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
515         locally or when running archives.
516         * Scripts/webkitpy/port/image_diff.py:
517         (IOSSimulatorImageDiffer): Deleted.
518         * Scripts/webkitpy/port/ios_simulator.py:
519         (IOSSimulatorPort.diff_image): Deleted.
520
521 2017-05-05  Brian Burg  <bburg@apple.com>
522
523         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
524         https://bugs.webkit.org/show_bug.cgi?id=171700
525         <rdar://problem/32017975>
526
527         Reviewed by Brady Eidson.
528
529         Fix a mistake in the test that should have caught this bug.
530
531         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
532         (TEST):
533         The assertions that were meant to check round-tripping were actually checking
534         the properties of the original cookie objects, not the round-tripped ones.
535         This test now fails without the bugfix and passes when it is applied.
536
537 2017-05-05  Daniel Bates  <dabates@apple.com>
538
539         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
540         https://bugs.webkit.org/show_bug.cgi?id=171698
541
542         Reviewed by Darin Adler.
543
544         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
545         so that we get pretty diff output when the actual string differs from the expected
546         string as opposed to seeing a boolean result. The former makes makes it straightforward
547         to diagnose a regression without reading the code for the test or instrumenting it to
548         determine the actual string that was compared.
549
550         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
551         (TestWebKitAPI::TEST):
552         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
553         (TestWebKitAPI::TEST_F):
554         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
555         (TestWebKitAPI::TEST_F):
556
557 2017-05-05  Chris Dumez  <cdumez@apple.com>
558
559         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
560         https://bugs.webkit.org/show_bug.cgi?id=171624
561
562         Reviewed by Dan Bernstein.
563
564         Extend API test coverage to cover crashes in addition to terminations requested by the client.
565
566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
567         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
568         (TestWebKitAPI::webProcessWasTerminatedByClient):
569         (TestWebKitAPI::webProcessCrashed):
570         (TestWebKitAPI::TEST):
571
572 2017-05-04  Mark Lam  <mark.lam@apple.com>
573
574         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
575         https://bugs.webkit.org/show_bug.cgi?id=171716
576         <rdar://problem/30878027>
577
578         Reviewed by Saam Barati.
579
580         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
581         does JS conversion and therefore, potentially JS allocations) and accessing
582         methods of internal JS data structures (which may do JS invocation, etc).
583
584         * DumpRenderTree/TestRunner.cpp:
585         (setAudioResultCallback):
586
587 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
588
589         buildbot: Cleanup simulators after running tests
590         https://bugs.webkit.org/show_bug.cgi?id=171679
591         <rdar://problem/31994361>
592
593         Reviewed by Aakash Jain.
594
595         We shutdown the simulator process between tests, but in some cases, this is not
596         sufficient. Explicitly shutdown every booted simulator.
597
598         * BuildSlaveSupport/kill-old-processes:
599         (main): Shutdown all booted simulators.
600
601 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
602
603         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
604         https://bugs.webkit.org/show_bug.cgi?id=171644
605
606         Reviewed by Michael Catanzaro.
607
608         Check that only one WebKitWebContext can have automation enabled.
609
610         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
611         (testAutomationSessionRequestSession):
612
613 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
616         https://bugs.webkit.org/show_bug.cgi?id=171724
617
618         Reviewed by Michael Catanzaro.
619
620         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
621
622         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
623         (WTR::timeoutSource):
624
625 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
626
627         Unreviewed. Fix wrong assert after r215176.
628
629         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
630         could also be RGB24 when created from a web view snapshot.
631
632         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
633         (WTR::computeMD5HashStringForCairoSurface):
634
635 2017-05-04  Brian Burg  <bburg@apple.com>
636
637         lldb_webkit.py should provide a type summary for WebCore::URL
638         https://bugs.webkit.org/show_bug.cgi?id=171670
639
640         Reviewed by Jer Noble.
641
642         Just print out the underlying string using the WTFString provider.
643
644         * lldb/lldb_webkit.py:
645         (__lldb_init_module):
646         (WebCoreURL_SummaryProvider):
647         (WebCoreURLProvider):
648         (WebCoreURLProvider.__init__):
649         (WebCoreURLProvider.to_string):
650
651 2017-05-04  Commit Queue  <commit-queue@webkit.org>
652
653         Unreviewed, rolling out r216206.
654         https://bugs.webkit.org/show_bug.cgi?id=171714
655
656         Multiple LayoutTests crashing in Document::page() (Requested
657         by ap on #webkit).
658
659         Reverted changeset:
660
661         "Remove support for legacy Notifications"
662         https://bugs.webkit.org/show_bug.cgi?id=171487
663         http://trac.webkit.org/changeset/216206
664
665 2017-05-04  Mark Lam  <mark.lam@apple.com>
666
667         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
668         https://bugs.webkit.org/show_bug.cgi?id=171702
669
670         Reviewed by Filip Pizlo.
671
672         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
673         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
674         confirm that the test will detect a regression.  Unfortunately, I forgot to
675         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
676         This patch fixes that.
677
678         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
679         (TestWebKitAPI::neverDestroyedString):
680
681 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
682
683         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
684         https://bugs.webkit.org/show_bug.cgi?id=170195
685
686         Unreviewed test gardening.
687
688         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
689         (TEST):
690
691 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
692
693         [Win] Remove redundant macros that are set in the CMake config
694         https://bugs.webkit.org/show_bug.cgi?id=171571
695
696         Reviewed by Brent Fulgham.
697
698         * DumpRenderTree/config.h:
699         * MiniBrowser/win/stdafx.h:
700         * TestWebKitAPI/config.h:
701
702 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
703
704         Add testRunner.display() to force displaying the web page for testing
705         https://bugs.webkit.org/show_bug.cgi?id=171694
706
707         Reviewed by Simon Fraser.
708
709         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
710         drawing the web page but without track repaints.
711
712         * DumpRenderTree/TestRunner.cpp:
713         (displayCallback):
714         (TestRunner::staticFunctions):
715         * DumpRenderTree/TestRunner.h:
716         * DumpRenderTree/mac/TestRunnerMac.mm:
717         (TestRunner::display):
718         * DumpRenderTree/win/TestRunnerWin.cpp:
719         (TestRunner::display):
720         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
722         (WTR::TestRunner::display):
723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
724
725 2017-05-04  Mark Lam  <mark.lam@apple.com>
726
727         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
728         https://bugs.webkit.org/show_bug.cgi?id=171586
729         <rdar://problem/31873190>
730
731         Reviewed by Yusuke Suzuki.
732
733         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
734
735         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
736         (TestWebKitAPI::neverDestroyedString):
737         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
738         (TestWebKitAPI::TEST):
739
740 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
741
742         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
743         https://bugs.webkit.org/show_bug.cgi?id=171585
744         <rdar://problem/31544320>
745
746         Reviewed by Beth Dakin and Zalan Bujtas.
747
748         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
749         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
750         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
751         operation rather than a copy.
752
753         See WebCore ChangeLog for more details.
754
755         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
756                 DataInteractionSimulator.ContentEditableToTextarea
757                 DataInteractionSimulator.ContentEditableMoveParagraphs
758                 DataInteractionSimulator.TextAreaToInput
759
760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
761         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
762         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
763         (TestWebKitAPI::TEST):
764         * TestWebKitAPI/ios/DataInteractionSimulator.h:
765         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
766         (-[DataInteractionSimulator initWithWebView:]):
767         (-[DataInteractionSimulator dealloc]):
768         (-[DataInteractionSimulator _advanceProgress]):
769         (-[DataInteractionSimulator waitForInputSession]):
770         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
771         (-[DataInteractionSimulator _webView:didStartInputSession:]):
772
773 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
774
775         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
776         https://bugs.webkit.org/show_bug.cgi?id=171641
777
778         Reviewed by Simon Fraser.
779
780         The plan is to add back the TestRunner.display() which does the display
781         only without track repaints.
782
783         * DumpRenderTree/DumpRenderTree.h:
784         * DumpRenderTree/TestRunner.cpp:
785         (displayAndTrackRepaintsCallback):
786         (TestRunner::staticFunctions):
787         (displayCallback): Deleted.
788         (displayInvalidatedRegionCallback): Deleted.
789         * DumpRenderTree/TestRunner.h:
790         * DumpRenderTree/mac/DumpRenderTree.mm:
791         (displayWebView):
792         (displayAndTrackRepaintsWebView):
793         * DumpRenderTree/mac/TestRunnerMac.mm:
794         (TestRunner::displayAndTrackRepaints):
795         (TestRunner::display): Deleted.
796         * DumpRenderTree/win/TestRunnerWin.cpp:
797         (TestRunner::displayAndTrackRepaints):
798         (TestRunner::display): Deleted.
799         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
801         (WTR::TestRunner::displayAndTrackRepaints):
802         (WTR::TestRunner::display): Deleted.
803         * WebKitTestRunner/InjectedBundle/TestRunner.h:
804
805 2017-05-04  Brady Eidson  <beidson@apple.com>
806
807         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
808         https://bugs.webkit.org/show_bug.cgi?id=171513
809
810         Unreviewed gardening.
811
812         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
813         (TEST): Skip the failing parts of the test on iOS for now.
814
815 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
816
817         Make ImageDiff stand-alone
818         https://bugs.webkit.org/show_bug.cgi?id=168939
819
820         Reviewed by David Kilzer.
821
822         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
823         stand-alone project. Note that this change does not eliminate the ImageDiff inside
824         the DumpRenderTree project.
825
826         * ImageDiff/ImageDiff.xcodeproj: Added.
827         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
828         * ImageDiff/Makefile: Use ImageDiff project.
829         * ImageDiff/PlatformMac.cmake: Added.
830         * ImageDiff/PlatformWin.cmake: Added.
831         * ImageDiff/cg: Added.
832         * ImageDiff/cg/Configurations: Added.
833         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
834         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
835         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
836         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
837         (createImageFromStdin): Stop using RetainPtr.
838         (createDifferenceImage): Ditto.
839         (main): Ditto.
840         * Scripts/build-imagediff: Stop building WTF and bmalloc.
841
842 2017-05-04  Sam Weinig  <sam@webkit.org>
843
844         Remove support for legacy Notifications
845         https://bugs.webkit.org/show_bug.cgi?id=171487
846
847         Reviewed by Jon Lee.
848
849         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
850         (DRTDesktopNotificationPresenter::checkNotificationPermission):
851         * Scripts/webkitperl/FeatureList.pm:
852         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
853         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
854
855 2017-05-04  Andy Estes  <aestes@apple.com>
856
857         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
858         https://bugs.webkit.org/show_bug.cgi?id=171673
859
860         Reviewed by Dan Bernstein.
861
862         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
863         (TEST):
864         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
865         (TEST):
866         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
867         (TEST):
868         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
869         (TEST):
870         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
871         (TEST):
872         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
873         (configurationWithContentFilterSettings):
874         (-[LazilyLoadPlatformFrameworksController init]):
875         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
876         (TEST):
877         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
878         (runTestWithWidth):
879         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
880         (TEST):
881         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
882         (TestWebKitAPI::TEST):
883         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
884         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
885         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
886         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
887         +_test_configurationWithTestPlugInClassName:
888
889 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
890
891         [MediaStream] Allow host application to enable/disable media capture
892         https://bugs.webkit.org/show_bug.cgi?id=171292
893         <rdar://problem/31821492>
894
895         Reviewed by Jer Noble.
896
897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
898         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
899         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
900         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
901         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
902         (MediaCaptureDisabledTest::SetUp):
903         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
904         (TEST_F):
905         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
906
907 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
908
909         Unreviewed, Adding self to contributors.json
910
911         * Scripts/webkitpy/common/config/contributors.json: Added name.
912
913 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
914
915         Fix compilation with ICU 59.1
916         https://bugs.webkit.org/show_bug.cgi?id=171612
917
918         Reviewed by Mark Lam.
919
920         ICU 59.1 has broken source compatibility. Now it defines UChar as
921         char16_t, which does not allow automatic type conversion from unsigned
922         short in C++ code.
923
924         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
925         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
926
927 2017-05-04  Andy Estes  <aestes@apple.com>
928
929         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
930         https://bugs.webkit.org/show_bug.cgi?id=171646
931         <rdar://problem/30306321>
932
933         Reviewed by Tim Horton.
934
935         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
936         (runTestWithWidth):
937         (TEST):
938         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
939         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
940         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
941         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
942         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
943         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
944
945 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
946
947         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
948         https://bugs.webkit.org/show_bug.cgi?id=171649
949
950         Reviewed by Carlos Garcia Campos.
951
952         Add two patches picked from the upstream repository to fix building of
953         the Fontconfig module in JHBuild. Additionally, this needed a patch to
954         add "autogen.sh" as it is not included in release tarballs. Also:
955         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
956         being regenerated (which is needed) so this is disabled for the
957         Fontconfig module.
958
959         * gtk/jhbuild.modules:
960         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
961         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
962         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
963
964 2017-05-04  Commit Queue  <commit-queue@webkit.org>
965
966         Unreviewed, rolling out r216172.
967         https://bugs.webkit.org/show_bug.cgi?id=171654
968
969         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
970         implementation. (Requested by ddkilzer on #webkit).
971
972         Reverted changeset:
973
974         "[MediaStream] Allow host application to enable/disable media
975         capture"
976         https://bugs.webkit.org/show_bug.cgi?id=171292
977         http://trac.webkit.org/changeset/216172
978
979 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
980
981         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
982         https://bugs.webkit.org/show_bug.cgi?id=171595
983
984         Reviewed by Xabier Rodriguez-Calvar.
985
986         * gtk/jhbuild.modules:
987         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
988         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
989         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
990         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
991         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
992         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
993         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
994
995 2017-05-03  Saam Barati  <sbarati@apple.com>
996
997         How we build polymorphic cases is wrong when making a call from Wasm
998         https://bugs.webkit.org/show_bug.cgi?id=171527
999
1000         Reviewed by JF Bastien.
1001
1002         * Scripts/run-jsc-stress-tests:
1003
1004 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1005
1006         [MediaStream] Allow host application to enable/disable media capture
1007         https://bugs.webkit.org/show_bug.cgi?id=171292
1008         <rdar://problem/31821492>
1009
1010         Reviewed by Jer Noble.
1011
1012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1013         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1014         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1015         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1016         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1017         (MediaCaptureDisabledTest::SetUp):
1018         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1019         (TEST_F):
1020         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1021
1022 2017-05-03  John Wilander  <wilander@apple.com>
1023
1024         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
1025         https://bugs.webkit.org/show_bug.cgi?id=171584
1026         <rdar://problem/24702576>
1027
1028         Reviewed by Brent Fulgham.
1029
1030         New function to call the clear function that takes a modifiedSince parameter.
1031
1032         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1033         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1034         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1035         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1036         * WebKitTestRunner/TestController.cpp:
1037         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1038         * WebKitTestRunner/TestController.h:
1039         * WebKitTestRunner/TestInvocation.cpp:
1040         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1041
1042 2017-05-03  Commit Queue  <commit-queue@webkit.org>
1043
1044         Unreviewed, rolling out r216160 and r216161.
1045         https://bugs.webkit.org/show_bug.cgi?id=171640
1046
1047         These changes broke the iOS build. (Requested by mlewis13 on
1048         #webkit).
1049
1050         Reverted changesets:
1051
1052         "[MediaStream] Allow host application to enable/disable media
1053         capture"
1054         https://bugs.webkit.org/show_bug.cgi?id=171292
1055         http://trac.webkit.org/changeset/216160
1056
1057         "[MediaStream] Allow host application to enable/disable media
1058         capture"
1059         https://bugs.webkit.org/show_bug.cgi?id=171292
1060         http://trac.webkit.org/changeset/216161
1061
1062 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1063
1064         [MediaStream] Allow host application to enable/disable media capture
1065         https://bugs.webkit.org/show_bug.cgi?id=171292
1066         <rdar://problem/31821492>
1067
1068         Reviewed by Jer Noble.
1069
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1072         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1073         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1074         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1075         (MediaCaptureDisabledTest::SetUp):
1076         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1077         (TEST_F):
1078         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1079
1080 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
1081
1082         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
1083         https://bugs.webkit.org/show_bug.cgi?id=171350
1084         <rdar://problem/28600836>
1085
1086         Patched by Brady Eidson.
1087
1088         Reviewed by Brent Fulgham.
1089
1090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1091         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
1092         (TestWebKitAPI::runJavaScriptAlert):
1093         (TestWebKitAPI::decidePolicyForNavigationAction):
1094         (TestWebKitAPI::decidePolicyForNavigationResponse):
1095         (TestWebKitAPI::TEST):
1096         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
1097
1098 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
1099
1100         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
1101         https://bugs.webkit.org/show_bug.cgi?id=171619
1102         https://bugs.webkit.org/show_bug.cgi?id=170195
1103
1104         Reviewed by Tim Horton.
1105
1106         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
1107
1108         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1109         (TEST):
1110
1111 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1112
1113         YouTube user agent quirk breaks new YouTube
1114         https://bugs.webkit.org/show_bug.cgi?id=171603
1115
1116         Reviewed by Carlos Garcia Campos.
1117
1118         Remove the YouTube quirk test.
1119
1120         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1121         (TestWebKitAPI::TEST):
1122
1123 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1124
1125         Async image decoding should be disabled for snapshots, printing and preview
1126         https://bugs.webkit.org/show_bug.cgi?id=171467
1127
1128         Reviewed by Simon Fraser.
1129
1130         Add a API test for snapshotting with large images. Ensure the images are
1131         drawn correctly which implies they should have been synchronously decoded.
1132
1133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1134         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
1135         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
1136         (TEST):
1137
1138 2017-05-03  Chris Dumez  <cdumez@apple.com>
1139
1140         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
1141         https://bugs.webkit.org/show_bug.cgi?id=171565
1142         <rdar://problem/31204417>
1143
1144         Reviewed by Sam Weinig.
1145
1146         Add API test coverage.
1147
1148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1149         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
1150         (TestWebKitAPI::didFinishNavigation):
1151         (TestWebKitAPI::didCrashWithReason):
1152         (TestWebKitAPI::TEST):
1153
1154 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1155
1156         check-webkit-style should also keep js-test-post[-async].js in sync
1157         <https://webkit.org/b/171568>
1158
1159         Reviewed by Joseph Pecoraro.
1160
1161         * Scripts/webkitpy/style/checker.py:
1162         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
1163         JavaScript files not to be skipped.
1164         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
1165         (CheckerDispatcher._create_checker): Update to use
1166         _NEVER_SKIPPED_JS_FILES.
1167
1168         * Scripts/webkitpy/style/checkers/jstest.py:
1169         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
1170         This is the list of files containing functions that need to be
1171         kept in sync.
1172         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
1173         we can keep more sets of files in sync between
1174         LayoutTests/resources and LayoutTests/http/tests/resources.
1175         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
1176         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
1177         (JSTestChecker.check_js_test_files): Add 'file_group' argument
1178         for list of files to check instead of using
1179         KEEP_JS_TEST_FILES_IN_SYNC.
1180         (JSTestChecker.check_js_test_functions): Update for
1181         ALL_JS_TEST_FUNCTION_FILES rename.
1182
1183         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
1184         (JSTestCheckerTestCase):
1185         (JSTestCheckerTestCase.test_map_functions_to_dict):
1186         - Add test case for map_functions_to_dict() in jstest.py.
1187
1188 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
1189
1190         ews should indicate in logs when it fails to fetch the attachment
1191         https://bugs.webkit.org/show_bug.cgi?id=171583
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1196         (Bugzilla.fetch_attachment): Added log statement.
1197
1198 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1199
1200         Rolling out jstest_unittest.py so it can be reviewed
1201
1202         Follow-up fix for:
1203         check-webkit-style should keep JavaScript test functions in sync
1204         <https://webkit.org/b/171424>
1205
1206         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
1207
1208 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1209
1210         check-webkit-style should keep JavaScript test functions in sync
1211         <https://webkit.org/b/171424>
1212
1213         Reviewed by Joseph Pecoraro.
1214
1215         Add a new JSTestChecker for check-webkit-style that keeps these
1216         two files in sync:
1217
1218             LayoutTests/http/tests/resources/js-test-pre.js
1219             LayoutTests/resources/js-test-pre.js
1220
1221         And keeps implementations of shouldBe(), shouldNotBe(),
1222         shouldNotThrow(), and shouldThrow() in sync across multiple
1223         files (with the ability to add more functions later):
1224
1225             JSTests/stress/resources/standalone-pre.js
1226             LayoutTests/http/tests/resources/js-test-pre.js
1227             LayoutTests/resources/js-test-pre.js
1228             LayoutTests/resources/js-test.js
1229             LayoutTests/resources/standalone-pre.js
1230
1231         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
1232         import for JSTestChecker.
1233         (_NEVER_SKIPPED_FILES): Add array of file names that are never
1234         skipped regardless of other rules.
1235         (_all_categories): Add JSTestChecker categories.
1236         (CheckerDispatcher.should_skip_without_warning): Use
1237         _NEVER_SKIPPED_FILES.
1238         (CheckerDispatcher._create_checker): Return JSTestChecker for
1239         the files to check.
1240
1241         * Scripts/webkitpy/style/checkers/jstest.py: Add.
1242         (map_functions_to_dict): Parse JavaScript source by splitting on
1243         /^function\s+/ regex.  This is good enough for the sanity checks
1244         to keep function implementations in sync.
1245         (strip_blank_lines_and_comments): Strips blank lines and lines
1246         with comments from the end of a chunk of text representing a
1247         function.
1248         (JSTestChecker): New checker.
1249         (JSTestChecker.__init__):
1250         (JSTestChecker.check):
1251         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
1252         (JSTestChecker.check_js_test_functions): Keeps individual
1253         functions in sync.
1254
1255         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
1256         case.
1257         (JSTestTestCase):
1258         (JSTestTestCase.test_map_functions_to_dict):
1259
1260 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
1261
1262         AX: Update implementation of aria-orientation
1263         https://bugs.webkit.org/show_bug.cgi?id=171166
1264
1265         Reviewed by Chris Fleizach.
1266
1267         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
1268         are both absent from the state set. Before we were returning an empty string
1269         which was not consistent with what the Mac port does, thus making shared tests
1270         harder.
1271
1272         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1273         (WTR::AccessibilityUIElement::orientation):
1274
1275 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1276
1277         Stop using sprintf() in JavaScriptCore debugger
1278         <https://webkit.org/b/171512>
1279
1280         Reviewed by Keith Miller.
1281
1282         * Scripts/webkitpy/style/checker.py:
1283         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
1284         Source/JavaScriptCore/disassembler/udis86/ is generated code.
1285
1286 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
1287
1288         Expose viewport-fit instead of clip-to-safe-area
1289         https://bugs.webkit.org/show_bug.cgi?id=171503
1290         <rdar://problem/31918249>
1291
1292         Reviewed by Simon Fraser.
1293
1294         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1295         (WTR::UIScriptController::setSafeAreaInsets):
1296         (WTR::UIScriptController::setObscuredInsets): Deleted.
1297         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1298         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1299         (WTR::UIScriptController::setSafeAreaInsets):
1300         (WTR::UIScriptController::setObscuredInsets): Deleted.
1301         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1302         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1303         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1304         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
1305         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
1306         * WebKitTestRunner/ios/TestControllerIOS.mm:
1307         (WTR::TestController::platformResetStateToConsistentValues):
1308         * WebKitTestRunner/ios/UIKitSPI.h:
1309         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1310         (WTR::UIScriptController::setSafeAreaInsets):
1311         (WTR::UIScriptController::setObscuredInsets): Deleted.
1312         Expose a safe area inset setter instead of obscured insets.
1313
1314 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1315
1316         Unreviewed, fix the build on a new internal SDK
1317
1318         Replace usages of NSItemProviderRepresentationVisibilityAll with
1319         UIItemProviderRepresentationOptionsVisibilityAll.
1320
1321         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1322         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1323         (TestWebKitAPI::TEST):
1324
1325 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1326
1327         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
1328         <https://webkit.org/b/171493>
1329
1330         Reviewed by Dan Bernstein.
1331
1332         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1333         Remove UIKit soft-link since TestWebKitAPI links to
1334         UIKit.framework.
1335         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
1336         UIWindow and UIWebView classes directly.
1337         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1338         Remove UIKit soft-link since TestWebKitAPI links to
1339         UIKit.framework.
1340         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
1341         class directly.
1342
1343 2017-05-01  Brady Eidson  <beidson@apple.com>
1344
1345         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
1346         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
1347
1348         Reviewed by Andy Estes.
1349
1350         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1351         (-[SchemeHandler webView:startURLSchemeTask:]):
1352         (-[SchemeHandler webView:stopURLSchemeTask:]):
1353         (-[SchemeHandler webView:startTask:]): Deleted.
1354         (-[SchemeHandler webView:stopTask:]): Deleted.
1355
1356 2017-05-01  Jason Marcell  <jmarcell@apple.com>
1357
1358         Add a new function for getting the Git hash for a pure git directory.
1359         https://bugs.webkit.org/show_bug.cgi?id=171450
1360
1361         Reviewed by David Kilzer.
1362
1363         * Scripts/VCSUtils.pm:
1364         (gitHashForDirectory):
1365
1366 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
1367
1368         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
1369         https://bugs.webkit.org/show_bug.cgi?id=171496
1370
1371         Reviewed by Chris Fleizach.
1372
1373         Add new attribute names so that the values of the object attributes can be tested.
1374
1375         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1376         (WTR::AccessibilityUIElement::numberAttributeValue):
1377
1378 2017-05-01  Beth Dakin  <bdakin@apple.com>
1379
1380         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1381         start of a paragraph
1382         https://bugs.webkit.org/show_bug.cgi?id=171453
1383         -and corresponding-
1384         rdar://problem/29779764
1385
1386         Reviewed by Tim Horton.
1387
1388         This test hard-codes the y-coordinate for the expected candidateRect. 
1389         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1390         (TEST):
1391
1392 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1393
1394         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
1395         <https://webkit.org/b/171494>
1396
1397         Reviewed by Brent Fulgham.
1398
1399         * Scripts/webkitpy/style/checkers/cpp.py:
1400         (check_language): Change categories for certain checkers from
1401         'runtime/printf' to 'security/printf' so they are no longer
1402         filtered.
1403         (CppChecker.categories): Add 'security/printf'.
1404         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1405         (CppStyleTest.test_insecure_string_operations): Add new test for
1406         sprintf(), strcat() and strcpy().
1407         (CppStyleTest.test_format_strings): Update test results for new
1408         'security/printf' category use.
1409
1410 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
1411
1412         AX: [GTK] Add support to query for aria-current
1413         https://bugs.webkit.org/show_bug.cgi?id=149016
1414
1415         Reviewed by Chris Fleizach.
1416
1417         Implement support for "AXARIACurrent" string attribute value.
1418
1419         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1420
1421 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1422
1423         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
1424
1425         Unreviewed.
1426
1427         Follow-up fix for:
1428         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
1429         https://bugs.webkit.org/show_bug.cgi?id=171486
1430
1431         * Scripts/webkitpy/style/checkers/cpp.py:
1432         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
1433         match and capture the function name.  The latter also mistakenly
1434         matches C-preprocessor directives.
1435         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
1436         is a requirement for the CppChecker class.
1437
1438 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1439
1440         [GTK] Add automation session API
1441         https://bugs.webkit.org/show_bug.cgi?id=171428
1442
1443         Reviewed by Carlos Alberto Lopez Perez.
1444
1445         Add an automation mode to MiniBrowser using the new API and add a unit test too.
1446
1447         * MiniBrowser/gtk/BrowserWindow.c:
1448         (webViewTitleChanged):
1449         (webViewDecidePolicy):
1450         (newTabCallback):
1451         (openPrivateWindow):
1452         (browserWindowFinalize):
1453         (browser_window_init):
1454         (browser_window_get_or_create_web_view_for_automation):
1455         * MiniBrowser/gtk/BrowserWindow.h:
1456         * MiniBrowser/gtk/main.c:
1457         (createBrowserTab):
1458         (createWebViewForAutomationCallback):
1459         (automationStartedCallback):
1460         (main):
1461         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1462         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
1463         (testAutomationSessionRequestSession):
1464         (beforeAll):
1465         (afterAll):
1466
1467 2017-04-30  Dan Bernstein  <mitz@apple.com>
1468
1469         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
1470         https://bugs.webkit.org/show_bug.cgi?id=171486
1471
1472         Reviewed by Sam Weinig.
1473
1474         * Scripts/webkitpy/style/checkers/cpp.py:
1475         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
1476           alloc…Instance() instead.
1477         (check_style): Invoke new check.
1478
1479 2017-04-30  Brady Eidson  <beidson@apple.com>
1480
1481         More fixing after r215991
1482         https://bugs.webkit.org/show_bug.cgi?id=171483
1483
1484         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1485         (TEST):
1486
1487 2017-04-30  Brady Eidson  <beidson@apple.com>
1488
1489         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
1490         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
1491
1492         Reviewed by Geoff Garen (and kind of Andy Estes).
1493
1494         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1495         (TEST):
1496
1497 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1498
1499         [ATK] Implement support for aria-autocomplete
1500         https://bugs.webkit.org/show_bug.cgi?id=171167
1501
1502         Reviewed by Chris Fleizach.
1503
1504         Add "AXSupportsAutoCompletion" attribute so the presence of
1505         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
1506
1507         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1508         (WTR::AccessibilityUIElement::boolAttributeValue):
1509
1510 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1511
1512         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
1513         https://bugs.webkit.org/show_bug.cgi?id=171170
1514
1515         Reviewed by Chris Fleizach.
1516
1517         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
1518
1519         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1520         (WTR::AccessibilityUIElement::boolAttributeValue):
1521
1522 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1523
1524         [ATK] Emit object:state-changed:busy event when aria-busy value changes
1525         https://bugs.webkit.org/show_bug.cgi?id=171181
1526
1527         Reviewed by Chris Fleizach.
1528
1529         Add handler for AXElementBusyChanged notifications.
1530
1531         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1532
1533 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
1534
1535         Use PEP8 style guide for raising exceptions in webkitpy.
1536         https://bugs.webkit.org/show_bug.cgi?id=171439
1537
1538         Reviewed by Daniel Bates.
1539
1540         As per https://www.python.org/dev/peps/pep-0008/
1541         "When raising an exception in Python 2, use raise ValueError('message') 
1542         instead of the older form raise ValueError, 'message'"
1543
1544         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
1545         * Scripts/webkitpy/common/thread/messagepump.py: Same.
1546         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
1547         * Scripts/webkitpy/tool/commands/queues.py: Same.
1548         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
1549         * Scripts/webkitpy/tool/multicommandtool.py: Same.
1550         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
1551
1552 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
1553
1554         Add system trace points for Document::updateTouchEventRegions()
1555         https://bugs.webkit.org/show_bug.cgi?id=171470
1556         rdar://problem/31901239
1557
1558         Reviewed by Tim Horton.
1559
1560         Add trace markers for updateTouchEventRegions.
1561
1562         * Tracing/SystemTracePoints.plist:
1563
1564 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1565
1566         webkitpy: Add apple_additions to webkitpy to insert Internal tools
1567         https://bugs.webkit.org/show_bug.cgi?id=170461
1568         <rdar://problem/31433077>
1569
1570         Reviewed by Daniel Bates.
1571
1572         Allow a package to be pulled in by run-webkit-tests which provides an interface to
1573         run layout tests on an iOS device.  If this package is not available, throw an
1574         exception when attempting to run layout tests on an iOS device.
1575
1576         * Scripts/webkitpy/port/config.py:
1577         (apple_additions): Import apple_additions package.
1578         * Scripts/webkitpy/port/device.py:
1579         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
1580         installed on a device.
1581         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
1582         host, the bundle id of the app to be used for testing and a path to the layout test
1583         directory to be mounted on the device.
1584         (Device.finished_testing):
1585         * Scripts/webkitpy/port/factory.py:
1586         (platform_options): Add apple_additions platform options if apple_additions exists.
1587         * Scripts/webkitpy/port/ios.py:
1588         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
1589         to forward, the bundle ID of the testing app and the layout tests directory to
1590         each device.
1591         * Scripts/webkitpy/port/ios_device.py:
1592         (IOSDevicePort):
1593         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
1594         processes to be run.
1595         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
1596         a single device is used, it is still accessed through an array.
1597         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
1598         for worker number map.
1599         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
1600         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
1601         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
1602         (IOSDevicePort.look_for_new_crash_logs): Ditto.
1603         (IOSDevicePort.look_for_new_samples): Ditto.
1604         (IOSDevicePort.sample_process): Ditto.
1605         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
1606         (IOSDevicePort._create_devices): Check that devices are available for testing and check
1607         that we have enough devices for each child process.
1608         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
1609         * Scripts/webkitpy/port/ios_device_unittest.py:
1610         (IOSDeviceTest.test_operating_system):
1611         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
1612         (IOSDeviceTest.test_sample_process): Ditto.
1613         (IOSDeviceTest.test_sample_process_exception): Ditto.
1614
1615 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1616
1617         Fix and re-enable data interaction unit tests
1618         https://bugs.webkit.org/show_bug.cgi?id=171446
1619         <rdar://problem/31820646>
1620
1621         Reviewed by Tim Horton.
1622
1623         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
1624         registering with the UIItemProvider, and instead just register data directly via
1625         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
1626
1627         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1628         (TestWebKitAPI::TEST):
1629         (temporaryURLForDataInteractionFileLoad): Deleted.
1630         (cleanUpDataInteractionTemporaryPath): Deleted.
1631         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
1632         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1633         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1634
1635 2017-04-28  Brady Eidson  <beidson@apple.com>
1636
1637         Teach the DatabaseProcess to be fully SessionID aware
1638         https://bugs.webkit.org/show_bug.cgi?id=171451
1639
1640         Reviewed by Geoffrey Garen.
1641
1642         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1643
1644 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1645
1646         Unreviewed follow-up to r214705.
1647
1648         shut.copytree will fail if given a file as an argument instead of a directory.
1649
1650         * Scripts/webkitpy/common/system/filesystem.py:
1651         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
1652         when source is a file.
1653         (FileSystem.copy_from_base_host): Ditto.
1654
1655 2017-04-28  Chris Dumez  <cdumez@apple.com>
1656
1657         Update DOMTokenList.replace() to match the latest DOM specification
1658         https://bugs.webkit.org/show_bug.cgi?id=171388
1659
1660         Reviewed by Alex Christensen.
1661
1662         Add API test coverage for new Vector API.
1663
1664         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1665         (TestWebKitAPI::TEST):
1666
1667 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1668
1669         WebKitTestRunner/DumpRenderTree prevent device from sleeping
1670         https://bugs.webkit.org/show_bug.cgi?id=170731
1671
1672         Reviewed by Alex Christensen.
1673
1674         While running layout tests on a device, the device should not be put asleep.
1675
1676         * DumpRenderTree/mac/DumpRenderTree.mm:
1677         (dumpRenderTree): Disable idle timer.
1678         * WebKitTestRunner/ios/TestControllerIOS.mm:
1679         (WTR::TestController::platformInitialize): Ditto.
1680
1681 2017-04-28  Brady Eidson  <beidson@apple.com>
1682
1683         Start of support for multiple WebsiteDataStore/SessionIDs per process
1684         https://bugs.webkit.org/show_bug.cgi?id=171422
1685
1686         Reviewed by Geoffrey Garen.
1687
1688         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1689         (TEST):
1690
1691 2017-04-28  Youenn Fablet  <youenn@apple.com>
1692
1693         Adding a runtime flag specific to MediaDevices
1694         https://bugs.webkit.org/show_bug.cgi?id=171433
1695
1696         Reviewed by Geoffrey Garen.
1697
1698         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
1699         Setting media devices runtime flag to true for WTR and DRT.
1700
1701         * DumpRenderTree/mac/DumpRenderTree.mm:
1702         (enableExperimentalFeatures):
1703         (resetWebPreferencesToConsistentValues):
1704         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
1705         (TestWebKitAPI::TEST):
1706         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1707         (TestWebKitAPI::TEST):
1708         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1709         (WTR::InjectedBundle::beginTesting):
1710         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1711         (WTR::TestRunner::setMediaDevicesEnabled):
1712         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
1713         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
1714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1715         * WebKitTestRunner/TestController.cpp:
1716         (WTR::TestController::resetPreferencesToConsistentValues):
1717
1718 2017-04-28  Dean Jackson  <dino@apple.com>
1719
1720         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
1721         https://bugs.webkit.org/show_bug.cgi?id=171441
1722         <rdar://problem/31826915>
1723
1724         Reviewed by Tim Horton.
1725
1726         Add an API test for GPUCommandQueue, exercising creation
1727         and setting the label.
1728
1729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1730         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
1731         (TestWebKitAPI::TEST_F):
1732
1733 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1734
1735         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
1736         https://bugs.webkit.org/show_bug.cgi?id=171188
1737
1738         Reviewed by Chris Fleizach.
1739
1740         Add "AXModal" attribute string so that we can test the state's exposure.
1741
1742         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1743         (WTR::AccessibilityUIElement::boolAttributeValue):
1744
1745 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1746
1747         [ATK] GridCellRole should implement AtkTableCell (regression?)
1748         https://bugs.webkit.org/show_bug.cgi?id=171179
1749
1750         Reviewed by Chris Fleizach.
1751
1752         Add new "AXInterfaceTableCell" attribute so that we can test whether or
1753         not there is an implementation of AtkTableCell (i.e. without risking false
1754         negatives from bugs in the interface's implementation).
1755
1756         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1757         (WTR::AccessibilityUIElement::boolAttributeValue):
1758
1759 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1760
1761         Move UUID from WebCore/platform to WTF
1762         https://bugs.webkit.org/show_bug.cgi?id=171372
1763
1764         Reviewed by Michael Catanzaro.
1765
1766         * WebKitTestRunner/TestController.cpp:
1767
1768 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1769
1770         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
1771         https://bugs.webkit.org/show_bug.cgi?id=171399
1772
1773         Reviewed by Brady Eidson.
1774
1775         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
1776         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1777         (TEST):
1778
1779 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
1780
1781         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
1782         https://bugs.webkit.org/show_bug.cgi?id=167914
1783
1784         Unreviewed test gardening.
1785
1786         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
1787         (TEST):
1788
1789 2017-04-26  Saam Barati  <sbarati@apple.com>
1790
1791         Add some more testing modes for Wasm tests now that we have tier up
1792         https://bugs.webkit.org/show_bug.cgi?id=171360
1793
1794         Reviewed by Keith Miller.
1795
1796         Lets enable the FTL on all Wasm tests. Let's also run each
1797         test with and without CJIT.
1798
1799         * Scripts/run-jsc-stress-tests:
1800
1801 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
1802
1803         JSC EWS Patch Relevance skips few JSC scripts
1804         https://bugs.webkit.org/show_bug.cgi?id=171351
1805
1806         Reviewed by Alexey Proskuryakov.
1807
1808         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1809         (CheckPatchRelevance): Added few jsc related scripts.
1810
1811 2017-04-26  Youenn Fablet  <youenn@apple.com>
1812
1813         Test importer should delete obsolete files based on w3c-import.log
1814         https://bugs.webkit.org/show_bug.cgi?id=171348
1815
1816         Reviewed by Chris Dumez.
1817
1818         * Scripts/webkitpy/w3c/test_importer.py:
1819         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
1820         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
1821         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1822         (test_remove_obsolete_content):
1823
1824 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1825
1826         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
1827         <rdar://problem/31816459>
1828
1829         Unreviewed infrastructure fix.
1830
1831         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
1832         DYLD_FRAMEWORK_PATH when installing an app.
1833
1834         * Scripts/webkitpy/port/ios.py:
1835         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
1836
1837 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1838
1839         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
1840         https://bugs.webkit.org/show_bug.cgi?id=171163
1841
1842         Reviewed by Chris Fleizach.
1843
1844         Add support for state-change notifications for ATK_STATE_ACTIVE.
1845
1846         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1847
1848 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1849
1850         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
1851         https://bugs.webkit.org/show_bug.cgi?id=171293
1852
1853         Reviewed by Aakash Jain.
1854
1855         We should make an effort to teardown simulators which we booted even when an exception is
1856         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
1857         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
1858         torn down.
1859
1860         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1861         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
1862         * Scripts/webkitpy/port/ios_simulator.py:
1863         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
1864         iOS simulators and teardown and managed devices.
1865         (IOSSimulatorPort._create_simulators): Register teardown function.
1866         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
1867         (IOSSimulatorPort._remove_device): Deleted.
1868
1869 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1870
1871         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
1872         https://bugs.webkit.org/show_bug.cgi?id=171164
1873
1874         Reviewed by Chris Fleizach.
1875
1876         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
1877         AtkStateSet; not what is found in the AtkObject's attributes.
1878
1879         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1880         (WTR::AccessibilityUIElement::hasPopup):
1881
1882 2017-04-25  Alex Christensen  <achristensen@webkit.org>
1883
1884         Encoded filename should be decoded for WKContentExtension.identifier
1885         https://bugs.webkit.org/show_bug.cgi?id=171316
1886
1887         Reviewed by Andy Estes.
1888
1889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1890         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
1891         (TEST_F):
1892         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
1893
1894 2017-04-25  Alex Christensen  <achristensen@webkit.org>
1895
1896         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
1897         https://bugs.webkit.org/show_bug.cgi?id=171297
1898         <rdar://problem/31530719>
1899
1900         Reviewed by Geoffrey Garen.
1901
1902         * TestWebKitAPI/PlatformWebView.h:
1903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1904         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
1905         (TestWebKitAPI::didFinishLoadForFrame):
1906         (TestWebKitAPI::mouseDidMoveOverElement):
1907         (TestWebKitAPI::setClients):
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1910         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1911         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1912
1913 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1914
1915         Unreviewed, temporarily disable the data interaction unit tests.
1916
1917         The API around data interaction will change significantly in the near future, and
1918         these tests will begin to fail. These will be reenabled once the bots are on an SDK
1919         that supports the updated data interaction API.
1920
1921         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1922         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1923         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1924
1925 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1926
1927         Limit allowed size of document.title to avoid locking WebKit clients
1928         https://bugs.webkit.org/show_bug.cgi?id=165113
1929         <rdar://problem/28324389>
1930
1931         Reviewed by Darin Adler.
1932
1933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1934         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
1935         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
1936         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
1937
1938 2017-04-25  John Wilander  <wilander@apple.com>
1939
1940         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
1941         https://bugs.webkit.org/show_bug.cgi?id=171295
1942         <rdar://problem/31823818>
1943
1944         Reviewed by Brent Fulgham.
1945
1946         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1947         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1948         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
1949         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
1950         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1951         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1952         * WebKitTestRunner/TestController.cpp:
1953         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
1954         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
1955         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1956         * WebKitTestRunner/TestController.h:
1957         * WebKitTestRunner/TestInvocation.cpp:
1958         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1959
1960 2017-04-25  Tim Horton  <timothy_horton@apple.com>
1961
1962         Try to fix the WKTR build after r215758
1963
1964         * Scripts/build-webkittestrunner:
1965
1966 2017-04-25  Daniel Bates  <dabates@apple.com>
1967
1968         Remove more EFL code
1969         https://bugs.webkit.org/show_bug.cgi?id=171288
1970
1971         Rubber-stamped by Simon Fraser.
1972
1973         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
1974         that was part of the EFL port.
1975
1976         * CMakeLists.txt:
1977         * DumpRenderTree/AccessibilityController.h:
1978         * DumpRenderTree/AccessibilityUIElement.cpp:
1979         (AccessibilityUIElement::getJSClass):
1980         * DumpRenderTree/AccessibilityUIElement.h:
1981         * DumpRenderTree/DumpRenderTree.h:
1982         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1983         * ImageDiff/efl/ImageDiff.cpp: Removed.
1984         * MiniBrowser/efl/CMakeLists.txt: Removed.
1985         * MiniBrowser/efl/main.c: Removed.
1986         * Scripts/build-dumprendertree:
1987         * Scripts/build-jsc:
1988         * Scripts/build-webkit:
1989         * Scripts/build-webkittestrunner:
1990         * Scripts/run-minibrowser:
1991         * Scripts/update-webkit-libs-jhbuild:
1992         * Scripts/update-webkitefl-libs: Removed.
1993         * Scripts/webkitdirs.pm:
1994         (argumentsForConfiguration):
1995         (extractNonMacOSHostConfiguration):
1996         (executableProductDir):
1997         (builtDylibPathForName):
1998         (determinePortName):
1999         (launcherPath):
2000         (launcherName):
2001         (getJhbuildPath):
2002         (wrapperPrefixIfNeeded):
2003         (generateBuildSystemFromCMakeProject):
2004         (buildCMakeProjectOrExit):
2005         (isEfl): Deleted.
2006         * Scripts/webkitperl/FeatureList.pm:
2007         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2008         * Scripts/webkitpy/common/config/ports.py:
2009         (DeprecatedPort.port):
2010         (GtkWK2Port.run_webkit_tests_command):
2011         (EflWK2Port): Deleted.
2012         (EflWK2Port.build_webkit_command): Deleted.
2013         * Scripts/webkitpy/port/builders.py:
2014         * Scripts/webkitpy/port/efl.py: Removed.
2015         * Scripts/webkitpy/port/efl_unittest.py: Removed.
2016         * Scripts/webkitpy/port/factory.py:
2017         (platform_options):
2018         (PortFactory):
2019         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2020         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2021         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2022         (TestRebaselineTest.test_baseline_directory):
2023         (TestRebaselineExpectations.test_rebaseline_expectations):
2024         * TestWebKitAPI/PlatformEfl.cmake: Removed.
2025         * TestWebKitAPI/PlatformWebView.h:
2026         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2027         (TestWebKitAPI::TEST):
2028         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
2029         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
2030         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
2031         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
2032         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
2033         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
2034         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
2035         * TestWebKitAPI/efl/main.cpp: Removed.
2036         * WebKitTestRunner/EventSenderProxy.h:
2037         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2038         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2039         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2040         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2041         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2042         (WTR::EventSendingController::contextClick):
2043         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2044         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2045         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2046         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2047         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
2048         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
2049         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
2050         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
2051         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
2052         * WebKitTestRunner/PlatformEfl.cmake: Removed.
2053         * WebKitTestRunner/PlatformWebView.h:
2054         * WebKitTestRunner/TestController.cpp:
2055         (WTR::TestController::resetStateToConsistentValues):
2056         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
2057         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
2058         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
2059         * WebKitTestRunner/efl/main.cpp: Removed.
2060         * efl/install-dependencies: Removed.
2061         * efl/jhbuild-optional.modules: Removed.
2062         * efl/jhbuild.modules: Removed.
2063         * efl/jhbuildrc: Removed.
2064         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
2065         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
2066         * efl/patches/gst-libav.patch: Removed.
2067         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2068         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2069         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2070         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
2071         * gtk/manifest.txt.in:
2072
2073 2017-04-25  Daniel Bates  <dabates@apple.com>
2074
2075         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2076         https://bugs.webkit.org/show_bug.cgi?id=136452
2077         <rdar://problem/23412620>
2078
2079         Reviewed by Brent Fulgham.
2080
2081         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2082
2083         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
2084         as the EFL port is no longer in the WebKit OpenSource repository.
2085         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2086
2087 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2088
2089         Unreviewed follow-up to r215739 and r215740.
2090
2091         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
2092         This (and r215740) was supposed to land in r215739, but I managed to
2093         specify the previous version of the patch.
2094
2095 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2096
2097         Unreviewed follow-up to r215739.
2098
2099         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
2100         libgcrypt patch that enforces the use of /dev/urandom.
2101
2102 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2103
2104         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
2105         https://bugs.webkit.org/show_bug.cgi?id=171270
2106
2107         Reviewed by Michael Catanzaro.
2108
2109         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
2110         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
2111         that use systems that don't yet provide libgcrypt >= 1.7.0.
2112
2113 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2114
2115         [GTK] Improve an unit test for the JHBuild wrapper.
2116         https://bugs.webkit.org/show_bug.cgi?id=168036
2117
2118         Unreviewed follow-up patch after r215727
2119
2120         * Scripts/webkitpy/port/base_unittest.py:
2121         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
2122         wasn't there before calling MockFileSystem.maybe_make_directory(), and
2123         also that it exists after calling it.
2124
2125 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2126
2127         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
2128         https://bugs.webkit.org/show_bug.cgi?id=168036
2129
2130         Reviewed by Michael Catanzaro.
2131
2132         Call ImageDiff with the JHBuild wrapper if we should use it.
2133         Also add some unit tests for the JHBuild wrapper feature.
2134
2135         * Scripts/webkitpy/port/base.py:
2136         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
2137         * Scripts/webkitpy/port/base_unittest.py:
2138         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
2139         * Scripts/webkitpy/port/image_diff.py:
2140         (ImageDiffer._start): The actual fix, use the wrapper if we should.
2141         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
2142         * Scripts/webkitpy/port/port_testcase.py:
2143         (PortTestCase):
2144         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
2145         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
2146         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
2147
2148 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2149
2150         Support reading NSURL titles from the pasteboard when performing data interaction
2151         https://bugs.webkit.org/show_bug.cgi?id=171156
2152         <rdar://problem/31356937>
2153
2154         Reviewed by Tim Horton.
2155
2156         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
2157
2158         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2159         (TestWebKitAPI::TEST):
2160
2161 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2162
2163         Respect fidelity order when reading web content from item providers
2164         https://bugs.webkit.org/show_bug.cgi?id=171155
2165         <rdar://problem/31356937>
2166
2167         Reviewed by Tim Horton.
2168
2169         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
2170         more details.
2171
2172         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2173         (TestWebKitAPI::TEST):
2174
2175 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2176
2177         SyntaxError fix after r215702.
2178         https://bugs.webkit.org/show_bug.cgi?id=168944
2179
2180         Unreviewed "build" fix.
2181
2182         * BuildSlaveSupport/built-product-archive:
2183         (archiveBuiltProduct):
2184
2185 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
2186
2187         Package ImageDiff built with host SDK
2188         https://bugs.webkit.org/show_bug.cgi?id=168944
2189         <rdar://problem/30745642>
2190
2191         Reviewed by David Kilzer.
2192
2193         iOS Simulator and iOS device should archive the ImageDiff built for the host
2194         machine.
2195
2196         * BuildSlaveSupport/built-product-archive:
2197         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
2198         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
2199
2200 2017-04-24  Keith Miller  <keith_miller@apple.com>
2201
2202         ThreadMessage API tests failing on release bots
2203         https://bugs.webkit.org/show_bug.cgi?id=171246
2204
2205         Reviewed by Saam Barati.
2206
2207         Need to make sure that C++ doesn't optimize away our spin loop.
2208
2209         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2210         (runThreadMessageTest):
2211         (TEST):
2212
2213 2017-04-24  Alex Christensen  <achristensen@webkit.org>
2214
2215         Reduce copies and allocations in SharedBuffer::append
2216         https://bugs.webkit.org/show_bug.cgi?id=170956
2217
2218         Reviewed by Andreas Kling.
2219
2220         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2221         (TestWebKitAPI::TEST_F):
2222
2223 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2224
2225         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
2226         https://bugs.webkit.org/show_bug.cgi?id=166680
2227
2228         Reviewed by Michael Catanzaro.
2229
2230         Update remote inspector unit tests.
2231
2232         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
2233         (main):
2234         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2235         (connectToInspectorServer):
2236         (waitUntilInspectorServerIsReady):
2237         (startTestServer):
2238         (testInspectorServerPageList):
2239         (beforeAll):
2240
2241 2017-04-23  Youenn Fablet  <youenn@apple.com>
2242
2243         Add a tool to update expected.txt files from EWS bot results
2244         https://bugs.webkit.org/show_bug.cgi?id=169538
2245
2246         Reviewed by Ryosuke Niwa.
2247
2248         This script updates expected-txt files from bugzilla posted EWS results.
2249         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
2250         have results different from the generic baseline.
2251
2252         * Scripts/update-test-expectations-from-bugzilla: Added.
2253         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
2254         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
2255         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
2256
2257 2017-04-22  Youenn Fablet  <youenn@apple.com>
2258
2259         Add an option to import tip-of-tree WPT tests
2260         https://bugs.webkit.org/show_bug.cgi?id=171152
2261
2262         Reviewed by Joseph Pecoraro.
2263
2264         Adding a '-t' option to import tip of tree WPT tests.
2265         Updating importer based on the fact that csswg-test is no longer a thing. 
2266
2267         * Scripts/webkitpy/w3c/test_downloader.py:
2268         (TestDownloader.download_tests):
2269         * Scripts/webkitpy/w3c/test_importer.py:
2270         (configure_logging):
2271         (TestImporter.do_import):
2272         (TestImporter.write_import_log):
2273
2274 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2275
2276         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
2277         https://bugs.webkit.org/show_bug.cgi?id=171177
2278         <rdar://problem/31765379>
2279
2280         Reviewed by Andy Estes.
2281
2282         Tests uploading a JSON file to a file input.
2283
2284         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2285         (TestWebKitAPI::TEST):
2286
2287 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2288
2289         Support writing link titles to the pasteboard when beginning data interaction on a link
2290         https://bugs.webkit.org/show_bug.cgi?id=171154
2291         <rdar://problem/31356937>
2292
2293         Reviewed by Andy Estes.
2294
2295         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
2296         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
2297         matching the title of the link.
2298
2299         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2300         (TestWebKitAPI::TEST):
2301
2302 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2303
2304         Unreviewed, rolling out r215608.
2305
2306         Hundreds of test failures on GTK bot
2307
2308         Reverted changeset:
2309
2310         "Reduce copies and allocations in SharedBuffer::append"
2311         https://bugs.webkit.org/show_bug.cgi?id=170956
2312         http://trac.webkit.org/changeset/215608
2313
2314 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2315
2316         [WK2] Add delegate hooks for overriding unhanded data interaction operations
2317         https://bugs.webkit.org/show_bug.cgi?id=171005
2318         <rdar://problem/31669646>
2319
2320         Reviewed by Tim Horton.
2321
2322         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
2323         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
2324         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
2325
2326         New API test:
2327         DataInteractionTests.OverrideDataInteractionOperation
2328
2329         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2330         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2331         (TestWebKitAPI::TEST):
2332         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2333         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2334         (-[DataInteractionSimulator initWithWebView:]):
2335         (-[DataInteractionSimulator dealloc]):
2336         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
2337         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
2338         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
2339
2340 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
2341
2342         Temporarily disable two flaky API tests.
2343
2344         Unreviewed test gardening.
2345
2346         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2347         (TEST):
2348         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2349         (TEST):
2350
2351 2017-04-21  Keith Miller  <keith_miller@apple.com>
2352
2353         Unreviewed, rolling out r215634.
2354
2355         underlying build issues should have been fixed
2356
2357         Reverted changeset:
2358
2359         "Unreviewed, rolling out r215620 and r215623."
2360         https://bugs.webkit.org/show_bug.cgi?id=171139
2361         http://trac.webkit.org/changeset/215634
2362
2363 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
2364
2365         Bubbles on dashboard doesn't turn red for test262 failures
2366         https://bugs.webkit.org/show_bug.cgi?id=171129
2367
2368         Reviewed by Alexey Proskuryakov.
2369
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
2371
2372 2017-04-21  Commit Queue  <commit-queue@webkit.org>
2373
2374         Unreviewed, rolling out r215620 and r215623.
2375         https://bugs.webkit.org/show_bug.cgi?id=171139
2376
2377         broke arm64 build (Requested by keith_miller on #webkit).
2378
2379         Reverted changesets:
2380
2381         "Add signaling API"
2382         https://bugs.webkit.org/show_bug.cgi?id=170976
2383         http://trac.webkit.org/changeset/215620
2384
2385         "Unreviewed, fix Cloop build."
2386         http://trac.webkit.org/changeset/215623
2387
2388 2017-04-20  Keith Miller  <keith_miller@apple.com>
2389
2390         Add signaling API
2391         https://bugs.webkit.org/show_bug.cgi?id=170976
2392
2393         Reviewed by Filip Pizlo.
2394
2395         Add tests for ThreadMessages.
2396
2397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2398         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
2399         (runThreadMessageTest):
2400         (TEST):
2401
2402 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
2403
2404         commit-log-editor should respect the git editor if one is set
2405         https://bugs.webkit.org/show_bug.cgi?id=171085
2406         <rdar://problem/31745506>
2407
2408         Reviewed by Daniel Bates.
2409
2410         * Scripts/commit-log-editor:
2411         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
2412         deciding which editor to present. We examine the global editor preference since that may be
2413         set automatically by installers or third-party tools.
2414
2415 2017-04-21  Alex Christensen  <achristensen@webkit.org>
2416
2417         Reduce copies and allocations in SharedBuffer::append
2418         https://bugs.webkit.org/show_bug.cgi?id=170956
2419
2420         Reviewed by Andreas Kling.
2421
2422         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2423         (TestWebKitAPI::TEST_F):
2424
2425 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
2426
2427         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
2428         https://bugs.webkit.org/show_bug.cgi?id=171071
2429
2430         Reviewed by Michael Catanzaro.
2431
2432         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
2433         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
2434         be available for all ports.
2435
2436         * DumpRenderTree/PlatformMac.cmake:
2437         * MiniBrowser/mac/CMakeLists.txt:
2438         * MiniBrowser/win/CMakeLists.txt:
2439         * TestWebKitAPI/PlatformJSCOnly.cmake:
2440         * TestWebKitAPI/PlatformMac.cmake:
2441         * TestWebKitAPI/PlatformWin.cmake:
2442         * WebKitTestRunner/PlatformMac.cmake:
2443
2444 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
2445
2446         Test262 bot does not go red with failures
2447         https://bugs.webkit.org/show_bug.cgi?id=171044
2448
2449         Reviewed by Aakash Jain.
2450
2451         The piped output of run-jsc-stress-tests is different from
2452         its non-piped output. Switch to parsing the correct output.
2453
2454         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2455         (RunTest262Tests.countFailures):
2456         Just count the number of lines that start with "FAIL:".
2457
2458         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2459         (RunTest262TestsTest.test_no_regressions_output):
2460         (test_failure_output):
2461         (test_failures_output):
2462         Updated tests with new sample output produced partially from bots and
2463         locally. In cases of failure the return code of run-jsc-stress-tests
2464         is still 0 so update the expected return code in the tests.
2465
2466 2017-04-20  Brady Eidson  <beidson@apple.com>
2467
2468         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
2469         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
2470
2471         Reviewed by Andy Estes.
2472
2473         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
2474         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2475         (resetToConsistentState):
2476         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
2477         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2478         (TEST):
2479         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2480
2481 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2482
2483         [ios-simulator] PositionInformationTests API tests are timing out
2484         https://bugs.webkit.org/show_bug.cgi?id=171089
2485
2486         Rubber-stamped by Tim Horton.
2487
2488         Addresses failures observed in the new position information tests added in r215573 by only running them if the
2489         DATA_INTERACTION feature flag is enabled.
2490
2491         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2492
2493 2017-04-20  Brady Eidson  <beidson@apple.com>
2494
2495         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
2496         https://bugs.webkit.org/show_bug.cgi?id=171083
2497
2498         Unreviewed.
2499
2500         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2501
2502 2017-04-20  Brady Eidson  <beidson@apple.com>
2503
2504         Add CompletionHandlerCallChecker to SPI added in r215545.
2505         https://bugs.webkit.org/show_bug.cgi?id=171067
2506
2507         Reviewed by Dan Bernstein.
2508
2509         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2510         (TEST):
2511         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2512
2513 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2514
2515         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
2516         https://bugs.webkit.org/show_bug.cgi?id=170922
2517         <rdar://problem/31634990>
2518
2519         Reviewed by Tim Horton.
2520
2521         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
2522         WebKit2 ChangeLog for more details.
2523
2524         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2525         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
2526         (TestWebKitAPI::TEST):
2527         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
2528
2529 2017-04-20  Xan Lopez  <xlopez@igalia.com>
2530
2531         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
2532         https://bugs.webkit.org/show_bug.cgi?id=170942
2533
2534         Reviewed by Carlos Garcia Campos.
2535
2536         Update glib and glib-networking to the last stable releases. This
2537         is needed to get working TLS certificate verification at all at
2538         least in Fedora.
2539
2540         * gtk/install-dependencies: add libmount, needed for newer glib.
2541         * gtk/jhbuild.modules: update glib and glib-networking to last
2542         stable releases.
2543
2544 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
2545
2546         [ATK] Implement support for DPub ARIA roles
2547         https://bugs.webkit.org/show_bug.cgi?id=170679
2548
2549         Reviewed by Chris Fleizach.
2550
2551         Add DPub ARIA landmark roles to roleToString().
2552
2553         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2554
2555 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
2556
2557         Remove WebKitTestRunner code for enabling features that are already enabled by default
2558         https://bugs.webkit.org/show_bug.cgi?id=171033
2559
2560         Reviewed by Ryosuke Niwa.
2561
2562         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2563         (WTR::InjectedBundle::beginTesting):
2564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2565         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
2566         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
2567         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
2568         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
2569         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2570
2571 2017-04-19  Youenn Fablet  <youenn@apple.com>
2572
2573         [Mac] Allow customizing H264 encoder
2574         https://bugs.webkit.org/show_bug.cgi?id=170829
2575
2576         Reviewed by Alex Christensen.
2577
2578         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2579
2580 2017-04-19  Brady Eidson  <beidson@apple.com>
2581
2582         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
2583         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
2584
2585         Reviewed by Tim Horton.
2586
2587         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2588         (TEST):
2589         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2590         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2591
2592 2017-04-19  Brady Eidson  <beidson@apple.com>
2593
2594         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
2595         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
2596
2597         Reviewed by Alex Christensen.
2598
2599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2600         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
2601
2602 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
2603
2604         [WK2] Run tests with ResourceLoadStatistics enabled
2605         https://bugs.webkit.org/show_bug.cgi?id=170952
2606
2607         Reviewed by Andy Estes.
2608
2609         Excercise the load statistics code during tests.
2610
2611         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2612         (WTR::initializeWebViewConfiguration):
2613
2614 2017-04-19  Bill Ming  <mbbill@gmail.com>
2615
2616         close_fds should be set to False on Windows.
2617         https://bugs.webkit.org/show_bug.cgi?id=170838
2618
2619         Reviewed by Brent Fulgham.
2620
2621         * Scripts/webkitpy/common/system/executive.py:
2622         (Executive._should_close_fds):
2623
2624 2017-04-19  David Kilzer  <ddkilzer@apple.com>
2625
2626         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
2627         <https://webkit.org/b/170994>
2628         <rdar://problem/29889932>
2629
2630         Reviewed by Brent Fulgham.
2631
2632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2633         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
2634         target.
2635         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
2636         (TestWebKitAPI::strip): Helper method to set/get environment
2637         variable for testing.
2638         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
2639         tests.
2640
2641 2017-04-19  JF Bastien  <jfbastien@apple.com>
2642
2643         WebAssembly: add script which can import GCC torture tests
2644         https://bugs.webkit.org/show_bug.cgi?id=170740
2645
2646         Reviewed by Saam Barati.
2647
2648         Add a script which can import the GCC torture tests and create a
2649         yaml file to run them as part of jsc's WebAssembly regression
2650         tests.
2651
2652         This patch doesn't commit the tests themselves because they're
2653         licensed differently.
2654
2655         * Scripts/run-jsc-stress-tests: learn how to run
2656         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
2657         the options because WebAssembly is enabled by default.
2658         * Scripts/update-wasm-gcc-torture.py: Added.
2659         (parse_args):
2660         (update_lkgr):
2661         (untar_torture):
2662         (list_js_files):
2663         (waterfall_known_failures):
2664         (create_yaml):
2665         (main):
2666
2667 2017-04-19  Youenn Fablet  <youenn@apple.com>
2668
2669         Import web-platform-tests/tools
2670         https://bugs.webkit.org/show_bug.cgi?id=170718
2671
2672         Reviewed by Alex Christensen.
2673
2674         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2675         (main):
2676         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2677         (WebPlatformTestServer.ports_to_forward):
2678         (WebPlatformTestServer._prepare_config):
2679         (WebPlatformTestServer._install_modules): Deleted.
2680         * Scripts/webkitpy/w3c/test_importer.py:
2681         (TestImporter.write_html_files_for_templated_js_tests):
2682
2683 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2684
2685         [WK2] Add infrastructure and unit tests for file uploads using data interaction
2686         https://bugs.webkit.org/show_bug.cgi?id=170903
2687         <rdar://problem/31314689>
2688
2689         Reviewed by Tim Horton.
2690
2691         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
2692         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
2693         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
2694         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
2695
2696         New tests:
2697         DataInteractionTests.ExternalSourceImageToFileInput
2698         DataInteractionTests.ExternalSourceHTMLToUploadArea
2699         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
2700         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
2701         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
2702
2703         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2704         (testIconImage):
2705         (temporaryURLForDataInteractionFileLoad):
2706         (cleanUpDataInteractionTemporaryPath):
2707
2708         Creates and tears down temporary file directories for testing data interaction.
2709
2710         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2713         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2714
2715         Make necessary changes to be able to test what happens when data interaction ends over an element with no
2716         operation. Previously, we would always simulate performing a data interaction operation when ending the
2717         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
2718         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
2719         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
2720         the phase to Cancelled and end the run.
2721
2722         (-[DataInteractionSimulator _resetSimulatedState]):
2723         (-[DataInteractionSimulator runFrom:to:]):
2724         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2725         (-[DataInteractionSimulator _advanceProgress]):
2726         (-[DataInteractionSimulator externalItemProviders]):
2727         (-[DataInteractionSimulator setExternalItemProviders:]):
2728
2729         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
2730         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
2731         take multiple item providers.
2732
2733         (-[DataInteractionSimulator externalItemProvider]): Deleted.
2734         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
2735
2736 2017-04-18  John Wilander  <wilander@apple.com>
2737
2738         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
2739         https://bugs.webkit.org/show_bug.cgi?id=170798
2740         <rdar://problem/31595108>
2741
2742         Reviewed by Alex Christensen.
2743
2744         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2745         (TestWebKitAPI::TEST_F):
2746             Added two negative test cases for WebCore::isPublicSuffix().
2747             Added test cases with mixed case domains, localhost, and
2748             non-ASCII for WebCore::topPrivatelyControlledDomain().
2749
2750 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
2751
2752         Unreviewed, rolling out r215346 and 215361.
2753
2754         The problem these changes were fixing was addressed in
2755         <https://trac.webkit.org/changeset/215416/webkit>.
2756
2757         Reverted changesets:
2758
2759         "webkitpy: Ignore previously launched pid when system is under
2760         stress"
2761         https://bugs.webkit.org/show_bug.cgi?id=170741
2762         http://trac.webkit.org/changeset/215346
2763         http://trac.webkit.org/changeset/215361
2764
2765 2017-04-17  Alex Christensen  <achristensen@webkit.org>
2766
2767         Allow Variants of RetainPtrs
2768         https://bugs.webkit.org/show_bug.cgi?id=170923
2769
2770         Reviewed by Tim Horton and Sam Weinig.
2771
2772         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2773         (TestWebKitAPI::TEST):
2774         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
2775         work in Variants.
2776
2777 2017-04-17  Brady Eidson  <beidson@apple.com>
2778
2779         Make WKHTTPCookieStore public.
2780         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
2781
2782         Reviewed by Geoffrey Garen.
2783
2784         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2785         (TEST):
2786
2787 2017-04-17  Youenn Fablet  <youenn@apple.com>
2788
2789         Disable outdated WritableStream API
2790         https://bugs.webkit.org/show_bug.cgi?id=170749
2791         <rdar://problem/31446233>
2792
2793         Reviewed by Alex Christensen.
2794
2795         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2796         - A STREAMS_API compilation flag.
2797         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2798
2799         * DumpRenderTree/mac/DumpRenderTree.mm:
2800         (enableExperimentalFeatures):
2801         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2802         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2803         (WTR::InjectedBundle::beginTesting):
2804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2805         (WTR::TestRunner::setFetchAPIEnabled):
2806         (WTR::TestRunner::setWritableStreamAPIEnabled):
2807         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2809
2810 2017-04-17  Tim Horton  <timothy_horton@apple.com>
2811
2812         Provide a viewport parameter to disable clipping to the safe area
2813         https://bugs.webkit.org/show_bug.cgi?id=170766
2814         <rdar://problem/31564634>
2815
2816         Reviewed by Beth Dakin.
2817
2818         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2819         (WTR::UIScriptController::setObscuredInsets):
2820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2821         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2822         (WTR::UIScriptController::setObscuredInsets):
2823         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2824         * WebKitTestRunner/ios/TestControllerIOS.mm:
2825         (WTR::TestController::platformResetStateToConsistentValues):
2826         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2827         (WTR::UIScriptController::setObscuredInsets):
2828         Add a UIScriptController mechanism to install obscured insets
2829         on the web view.
2830
2831 2017-04-17  Dan Bernstein  <mitz@apple.com>
2832
2833         [Cocoa] Move isNullFunctionPointer down into WTF
2834         https://bugs.webkit.org/show_bug.cgi?id=170892
2835
2836         Reviewed by Sam Weinig.
2837
2838         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
2839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2840         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
2841         (TestWebKitAPI::TEST):
2842         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
2843         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
2844         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
2845         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
2846
2847 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
2848
2849         webkitpy: Correct poll when killing ServerProcess
2850
2851         Unreviewed infrastructure fix.
2852
2853         * Scripts/webkitpy/port/server_process.py:
2854         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
2855
2856 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
2857
2858         [MediaStream] Enable getUserMedia API test
2859         https://bugs.webkit.org/show_bug.cgi?id=170901
2860         <rdar://problem/31656594>
2861
2862         Reviewed by Youenn Fablet.
2863
2864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
2865
2866         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2867         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2868         (TestWebKitAPI::TEST): Enable capture with mock devices.
2869         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
2870
2871 2017-04-17  Xan Lopez  <xan@igalia.com>
2872
2873         [GTK] Update the Fedora dependencies for WebKitGTK+
2874         https://bugs.webkit.org/show_bug.cgi?id=170590
2875
2876         Reviewed by Carlos Alberto Lopez Perez.
2877
2878         * gtk/install-dependencies: add a bunch of modules necessary to
2879         get a proper set of GStreamer codecs for WebRTC.
2880
2881 2017-04-16  Sam Weinig  <sam@webkit.org>
2882
2883         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
2884         https://bugs.webkit.org/show_bug.cgi?id=170843
2885
2886         Reviewed by Chris Dumez.
2887
2888         * DumpRenderTree/DerivedSources.make:
2889         * WebKitTestRunner/DerivedSources.make:
2890         * Scripts/webkitpy/bindings/main.py:
2891         (BindingsTests.generate_from_idl):
2892         Pass IDLAttributes.json, as it is now mandatory to have one.
2893
2894 2017-04-14  Mark Lam  <mark.lam@apple.com>
2895
2896         Update architectures in xcconfig files.
2897         https://bugs.webkit.org/show_bug.cgi?id=170867
2898         <rdar://problem/31628104>
2899
2900         Reviewed by Joseph Pecoraro.
2901
2902         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2903         * MobileMiniBrowser/Configurations/Base.xcconfig:
2904         * TestWebKitAPI/Configurations/Base.xcconfig:
2905         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2906         * WebKitTestRunner/Configurations/Base.xcconfig:
2907
2908 2017-04-14  Brady Eidson  <beidson@apple.com>
2909
2910         Fix basic WKURLSchemeHandler bugs.
2911         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
2912
2913         Reviewed by Andy Estes.
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
2917         (-[SchemeHandler initWithData:mimeType:]):
2918         (-[SchemeHandler dealloc]):
2919         (-[SchemeHandler webView:startTask:]):
2920         (-[SchemeHandler webView:stopTask:]):
2921         (TEST):
2922
2923 2017-04-14  Bill Ming  <mbbill@gmail.com>
2924
2925         webkit-patch failed to detect git repository
2926         https://bugs.webkit.org/show_bug.cgi?id=170859
2927
2928         Reviewed by Daniel Bates.
2929
2930         Windows cmd does not accept single quoted path. So, using
2931         double quotes here will provide better platform compatibility.
2932
2933         * Scripts/VCSUtils.pm:
2934         (isGitDirectory):
2935         (isGitSVNDirectory):
2936         (svnRevisionForDirectory):
2937         (svnInfoForPath):
2938
2939 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2940
2941         Unreviewed, rolling out r215374.
2942
2943         This change causes LayoutTests to exit early with crashes on
2944         Sierra.
2945
2946         Reverted changeset:
2947
2948         "webkitpy: Ignore previously launched pid when system is under
2949         stress"
2950         https://bugs.webkit.org/show_bug.cgi?id=170741
2951         http://trac.webkit.org/changeset/215374
2952
2953 2017-04-14  Dan Bernstein  <mitz@apple.com>
2954
2955         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
2956         https://bugs.webkit.org/show_bug.cgi?id=170856
2957
2958         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
2959
2960         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2961
2962 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2963
2964         webkitpy: Ignore previously launched pid when system is under stress
2965         https://bugs.webkit.org/show_bug.cgi?id=170741
2966
2967         Unreviewed infrastructure fix.
2968
2969         Drivers are destroyed between failing layout tests, which is not necessary and
2970         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2971
2972         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2973         (Worker._kill_driver): Do not destroy drivers when they are stopped.
2974         * Scripts/webkitpy/port/driver.py:
2975         (Driver.stop): Reset driver values set in initializer.
2976
2977 2017-04-14  Andy Estes  <aestes@apple.com>
2978
2979         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2980         https://bugs.webkit.org/show_bug.cgi?id=167594
2981
2982         Re-enabled this API test now that webkit.org/b/161967 is fixed.
2983
2984         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2985         (TEST):
2986
2987 2017-04-14  Andy Estes  <aestes@apple.com>
2988
2989         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
2990         https://bugs.webkit.org/show_bug.cgi?id=161967
2991
2992         Reviewed by Alexey Proskuryakov.
2993
2994         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2995         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
2996
2997 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2998
2999         Unreviewed, rolling out r215363.
3000
3001         This change causes LayoutTests to exit early with crashes.
3002
3003         Reverted changeset:
3004
3005         "webkitpy: Ignore previously launched pid when system is under
3006         stress"
3007         https://bugs.webkit.org/show_bug.cgi?id=170741
3008         http://trac.webkit.org/changeset/215363
3009
3010 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3011
3012         webkitpy: Ignore previously launched pid when system is under stress
3013         https://bugs.webkit.org/show_bug.cgi?id=170741
3014
3015         Unreviewed infrastructure fix.
3016
3017         Drivers are destroyed between failing layout tests, which is not necessary and
3018         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3019
3020         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3021         (Worker._kill_driver): Do not destroy drivers when they are stopped.
3022
3023 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3024
3025         webkitpy: Ignore previously launched pid when system is under stress
3026         https://bugs.webkit.org/show_bug.cgi?id=170741
3027
3028         Unreviewed infrastructure fix.
3029
3030         Server processes are destroyed in the driver, which is not necessary and prevents
3031         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3032
3033         * Scripts/webkitpy/port/driver.py:
3034         (Driver.run_test): Do not destroy server process.
3035         (Driver._start): Only create the server process if it is None.
3036         (Driver.stop): Do not destroy server process.
3037
3038 2017-04-13  Dan Bernstein  <mitz@apple.com>
3039
3040         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
3041         https://bugs.webkit.org/show_bug.cgi?id=170387
3042
3043         Reviewed by Sam Weinig.
3044
3045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3046         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
3047         (TEST):
3048         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
3049         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3050         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
3051         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
3052         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
3053
3054 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
3055
3056         webkitpy: Ignore previously launched pid when system is under stress
3057         https://bugs.webkit.org/show_bug.cgi?id=170741
3058
3059         Reviewed by David Kilzer.
3060
3061         We have seen cases where xcrun simctl launch will return a pid of a previous
3062         process and the process will appear to be running even though it is crashing.
3063         Ensure that the PID that simulator_process is receiving is not the pid of the
3064         previously run process.
3065
3066         * Scripts/webkitpy/port/simulator_process.py:
3067         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
3068
3069 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
3070
3071         Build ImageDiff with host SDK
3072         https://bugs.webkit.org/show_bug.cgi?id=168531
3073
3074         Reviewed by David Kilzer.
3075
3076         ImageDiff should be built and run with the host SDK, not the target SDK.
3077         Build ImageDiff twice, once for the target SDK and once for the host
3078         as an intermediate step towards building for only the host SDK.
3079
3080         * ImageDiff/Makefile: Added.
3081         * Makefile: Add ImageDiff to list of targets.
3082         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
3083         * Scripts/build-webkit: Build ImageDiff for host.
3084         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
3085         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
3086         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
3087         * Scripts/webkitpy/port/base.py:
3088         (Port.check_build): Attempt to build image diff if not found.
3089         (Port.check_image_diff): Enable logging flag.
3090         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
3091
3092 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3093
3094         Clean up SharedBuffer public functions
3095         https://bugs.webkit.org/show_bug.cgi?id=170795
3096
3097         Reviewed by Andreas Kling.
3098
3099         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3100         (TestWebKitAPI::TEST_F):
3101
3102 2017-04-12  Dan Bernstein  <mitz@apple.com>
3103
3104         [Mac] Future-proof .xcconfig files
3105         https://bugs.webkit.org/show_bug.cgi?id=170802
3106
3107         Reviewed by Tim Horton.
3108
3109         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3110         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3111         * MiniBrowser/Configurations/Base.xcconfig:
3112         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3113         * TestWebKitAPI/Configurations/Base.xcconfig:
3114         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3116         * WebKitTestRunner/Configurations/Base.xcconfig:
3117         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3118
3119 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3120
3121         Remove unused SharedBuffer::wrapCFDataArray
3122         https://bugs.webkit.org/show_bug.cgi?id=170794
3123
3124         Reviewed by Brady Eidson.
3125
3126         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3127         (TestWebKitAPI::TEST_F):
3128
3129 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3130
3131         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
3132         https://bugs.webkit.org/show_bug.cgi?id=170502
3133
3134         Reviewed by Mark Lam.
3135
3136         Mechanical change. Use Thread:: APIs.
3137
3138         * DumpRenderTree/JavaScriptThreading.cpp:
3139         (runJavaScriptThread):
3140         (startJavaScriptThreads):
3141         (stopJavaScriptThreads):
3142         * DumpRenderTree/mac/DumpRenderTree.mm:
3143         (testThreadIdentifierMap):
3144         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3145         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3146         (TestWebKitAPI::runLockTest):
3147         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3148
3149 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3150
3151         Modernize vector adoption
3152         https://bugs.webkit.org/show_bug.cgi?id=170758
3153
3154         Reviewed by Geoffrey Garen.
3155
3156         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3157         (TestWebKitAPI::TEST_F):
3158
3159 2017-04-11  Dean Jackson  <dino@apple.com>
3160
3161         Disable outdated WritableStream API
3162         https://bugs.webkit.org/show_bug.cgi?id=170749
3163         <rdar://problem/31446233>
3164
3165         Reviewed by Tim Horton.
3166
3167         The API we implement is no longer accurate. Disable it until we
3168         are compatible with the new specification
3169
3170         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3171
3172 2017-04-11  David Quesada  <david_quesada@apple.com>
3173
3174         Add SPI for handling geolocation authorization requests
3175         https://bugs.webkit.org/show_bug.cgi?id=170362
3176         rdar://problem/17508627
3177
3178         Reviewed by Alex Christensen.
3179
3180         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
3181         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
3182         provide a stub object to simulate the various configurations of geolocation permissions:
3183         1. The app doesn't have permission to use geolocation.
3184         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
3185         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
3186
3187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3188         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
3189         (-[TestCoreLocationProvider setListener:]):
3190         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
3191         (-[TestCoreLocationProvider start]):
3192         (-[TestCoreLocationProvider stop]):
3193         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
3194         (expectException):
3195         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
3196         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3197         (TestWebKitAPI::TEST):
3198         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
3199
3200 2017-04-10  Matt Rajca  <mrajca@apple.com>
3201
3202         Change autoplay state to "prevented" when media is paused due to restrictions.
3203         https://bugs.webkit.org/show_bug.cgi?id=170686
3204
3205         Reviewed by Alex Christensen.
3206
3207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3208         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
3209         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3210         (TEST):
3211
3212 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
3213
3214         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
3215         https://bugs.webkit.org/show_bug.cgi?id=170725
3216
3217         Reviewed by Sam Weinig.
3218
3219         * TestWebKitAPI/Tests/WTF/Time.cpp:
3220         (TestWebKitAPI::TEST):
3221
3222 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3223
3224         Revert r215217
3225         https://bugs.webkit.org/show_bug.cgi?id=170703
3226
3227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3228
3229 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3230
3231         Continue enabling WebRTC
3232         https://bugs.webkit.org/show_bug.cgi?id=170703
3233
3234         Reviewed by Youenn Fablet.
3235
3236         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3237
3238 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
3239
3240         Have parseRevisionProperty use default repo name as the Buildbot key.
3241         https://bugs.webkit.org/show_bug.cgi?id=170696
3242
3243         Reviewed by Daniel Bates.
3244
3245         Previously, we needed to set a key and a fallbackKey when addressing
3246         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
3247         that the repo name maps exactly to that key for every repository other
3248         than WebKit.
3249
3250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3251         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
3252
3253 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
3254
3255         Add test262 JavaScriptCore tests to dashboard
3256         https://bugs.webkit.org/show_bug.cgi?id=170711
3257
3258         Rubber-stamped by Joseph Pecoraro.
3259
3260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3261         (WebKitBuildbot): Added test262 JSC tests to dashboard.
3262
3263 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3264
3265         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
3266         https://bugs.webkit.org/show_bug.cgi?id=170707
3267         <rdar://problem/27788755>
3268
3269         Reviewed by Tim Horton.
3270
3271         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
3272         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3273         (TEST_F):
3274         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3275         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3276         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3277         (TEST):
3278
3279 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3280
3281         Add API to get available content extension identifiers in a WKContentExtensionStore
3282         https://bugs.webkit.org/show_bug.cgi?id=170093
3283
3284         Reviewed by Geoffrey Garen.
3285
3286         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
3287         (TEST_F):
3288
3289 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3290
3291         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
3292         https://bugs.webkit.org/show_bug.cgi?id=170658
3293
3294         Reviewed by Tim Horton.
3295
3296         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
3297         preparation is synchronous, or passes if it is asynchronous.
3298
3299         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3300         (TestWebKitAPI::TEST):
3301         * TestWebKitAPI/cocoa/TestWKWebView.h:
3302         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3303         (-[TestWKWebView initWithFrame:]):
3304         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
3305         (-[TestWKWebView _setUpTestWindow:]):
3306
3307 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
3308
3309         [WK2][macOS] Block access to Apple Events before launch.
3310         https://bugs.webkit.org/show_bug.cgi?id=170626
3311         <rdar://problem/16079334>
3312
3313         Reviewed by Alexey Proskuryakov.
3314
3315         Add a new TestWebKitAPI test that fails if Apple Events are sent.
3316
3317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3318         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
3319         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3320         (TestWebKitAPI::didFinishLoadForFrame):
3321         (TestWebKitAPI::TEST):
3322         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
3323         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
3324         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
3325
3326 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
3327
3328         [JSC] Do not run FTL stress tests on MIPS
3329         https://bugs.webkit.org/show_bug.cgi?id=170684
3330
3331         Reviewed by Carlos Alberto Lopez Perez.
3332
3333         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
3334         logic to detect if the platform supports FTL ignores that MIPS does
3335         not support FTL. This adds detection of MIPS (with the magic number
3336         determined empirically) and fixes the determination of whether we
3337         support FTL.
3338
3339         * Scripts/run-jsc-stress-tests:
3340
3341 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
3342
3343         webkitpy: Increase estimate for processes run by iOS Simulators
3344         https://bugs.webkit.org/show_bug.cgi?id=170678
3345         <rdar://problem/31534061>
3346
3347         Reviewed by Aakash Jain.
3348
3349         Previously, it was estimated that each simulated iOS device would run about 100
3350         processes.  With newer versions of iOS, this is closer to 125.
3351
3352         * Scripts/webkitpy/port/ios_simulator.py:
3353         (IOSSimulatorPort): Increase process estimate from 100 to 125.
3354
3355 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
3356
3357         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
3358         https://bugs.webkit.org/show_bug.cgi?id=170553
3359
3360         Reviewed by Michael Catanzaro.
3361
3362         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
3363         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
3364         to properly position popup menus, and also avoids using functions
3365         which were deprecated starting at that GTK+ release.
3366
3367         * MiniBrowser/gtk/BrowserSearchBar.c:
3368         (searchEntryMenuIconPressedCallback):
3369         Update MiniBrowser to use gtk_menu_popup_at_pointer().
3370
3371 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3372
3373         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
3374         https://bugs.webkit.org/show_bug.cgi?id=170677
3375         <rdar://problem/31512633>
3376
3377         Reviewed by Tim Horton.
3378
3379         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
3380         to allow dropping URLs to trigger page navigation.
3381
3382         * DumpRenderTree/TestOptions.h:
3383         * DumpRenderTree/TestOptions.mm:
3384         (TestOptions::TestOptions):
3385         * DumpRenderTree/mac/DumpRenderTree.mm:
3386         (resetWebViewToConsistentStateBeforeTesting):
3387         * DumpRenderTree/mac/UIDelegate.h:
3388         * DumpRenderTree/mac/UIDelegate.mm:
3389         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
3390         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
3391
3392 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3393
3394         update-webkit-dependency should report $response->message for diagnose
3395         https://bugs.webkit.org/show_bug.cgi?id=170666
3396
3397         Reviewed by Alex Christensen.
3398
3399         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
3400
3401 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3402
3403         Data interaction on an image enclosed by an anchor should vend the anchor's URL
3404         https://bugs.webkit.org/show_bug.cgi?id=170660
3405         <rdar://problem/31043220>
3406
3407         Reviewed by Tim Horton.
3408
3409         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
3410         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
3411         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
3412         rects, but should not be.
3413
3414         See WebCore ChangeLog for more details.
3415
3416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3417         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
3418         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3419         (TestWebKitAPI::TEST):
3420
3421 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3422
3423         [GTK] Remove the GDK dependency from ImageDiff
3424         https://bugs.webkit.org/show_bug.cgi?id=85299
3425
3426         Reviewed by Žan Doberšek.
3427
3428         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
3429         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
3430         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
3431         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
3432         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
3433         and also add CG implementation.
3434
3435         * ImageDiff/CMakeLists.txt:
3436         * ImageDiff/Cairo.cmake: Added.
3437         * ImageDiff/ImageDiff.cpp: Added.
3438         (main):
3439         * ImageDiff/PlatformGTK.cmake:
3440         * ImageDiff/PlatformImage.cpp: Added.
3441         (ImageDiff::PlatformImage::isCompatible):
3442         (ImageDiff::PlatformImage::difference):
3443         * ImageDiff/PlatformImage.h: Added.
3444         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
3445         (ImageDiff::PlatformImage::createFromStdin):
3446         (ImageDiff::PlatformImage::createFromDiffData):
3447         (ImageDiff::PlatformImage::PlatformImage):
3448         (ImageDiff::PlatformImage::~PlatformImage):
3449         (ImageDiff::PlatformImage::width):
3450         (ImageDiff::PlatformImage::height):
3451         (ImageDiff::PlatformImage::rowBytes):
3452         (ImageDiff::PlatformImage::hasAlpha):
3453         (ImageDiff::PlatformImage::pixels):
3454         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3455         * ImageDiff/gtk/ImageDiff.cpp: Removed.
3456
3457 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3458
3459         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
3460         https://bugs.webkit.org/show_bug.cgi?id=170667
3461
3462         Reviewed by Žan Doberšek.
3463
3464         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
3465         that value.
3466
3467         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3468         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
3469
3470 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3471
3472         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
3473         https://bugs.webkit.org/show_bug.cgi?id=170653
3474
3475         Reviewed by Tim Horton.
3476
3477         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
3478         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
3479         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
3480         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
3481
3482         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
3483         * WebKitTestRunner/TestInvocation.cpp:
3484         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
3485         results were created in the web process.
3486         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
3487         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3488         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
3489         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
3490         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3491         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
3492         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
3493         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
3494         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
3495         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
3496         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3497         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
3498         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
3499         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3500         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
3501         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3502         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3503
3504 2017-04-10  Chris Dumez  <cdumez@apple.com>
3505
3506         Drop Timer::startOneShot() overload taking a double
3507         https://bugs.webkit.org/show_bug.cgi?id=170659
3508
3509         Reviewed by Yusuke Suzuki.
3510
3511         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
3512
3513         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3514         (TestWebKitAPI::TEST):
3515         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3516         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3517
3518 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3519
3520         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
3521         https://bugs.webkit.org/show_bug.cgi?id=170658
3522         <rdar://problem/31431450>
3523
3524         Reviewed by Tim Horton.
3525
3526         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
3527         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
3528         should complete before the unresponsiveness timeout is triggered.
3529
3530         See WebKit2 ChangeLog for more details.
3531
3532         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3533         (TestWebKitAPI::TEST):
3534
3535 2017-04-09  Chris Dumez  <cdumez@apple.com>
3536
3537         Drop Timer::startRepeating() overload taking a double
3538         https://bugs.webkit.org/show_bug.cgi?id=170656
3539
3540         Reviewed by Yusuke Suzuki.
3541
3542         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
3543
3544         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3545         (TestWebKitAPI::TEST):
3546
3547 2017-04-09  Youenn Fablet  <youenn@apple.com>
3548
3549         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
3550         https://bugs.webkit.org/show_bug.cgi?id=170647
3551
3552         Reviewed by Sam Weinig.
3553
3554         * Scripts/webkitpy/common/checkout/scm/git.py:
3555         (Git.fetch): Fetching origin remote in case there is more than one.
3556
3557 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
3558
3559         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
3560         https://bugs.webkit.org/show_bug.cgi?id=170643
3561
3562         Reviewed by Chris Dumez.
3563         
3564         Update the CSSProperties.json style checker to allow:
3565             - comments in codegen_properties
3566             - obsolete-category and obsolete-url in specification blocks
3567             - renamed "done" to "supported"
3568             
3569         Fix some references to codegen_properties to be codegen-properties.
3570
3571         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3572         (JSONCSSPropertiesChecker.validate_status_type):
3573         (JSONCSSPropertiesChecker.validate_property_specification):
3574         (JSONCSSPropertiesChecker.check_codegen_properties):
3575
3576 2017-04-08  Youenn Fablet  <youenn@apple.com>
3577
3578         WebRTC tests gardening
3579         https://bugs.webkit.org/show_bug.cgi?id=170508
3580
3581         Reviewed by Eric Carlson.
3582
3583         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3584
3585 2017-04-07  Keith Miller  <keith_miller@apple.com>
3586
3587         Add a PriorityQueue class
3588         https://bugs.webkit.org/show_bug.cgi?id=170579
3589
3590         Reviewed by Saam Barati.
3591
3592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3593         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
3594         (operator  _z ):
3595         (enqueue):
3596         (dequeue):
3597         (TEST):
3598         (compareMove):
3599
3600 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
3601
3602         Replace ES6SampleBench by ARES-6 in run-benchmark
3603         https://bugs.webkit.org/show_bug.cgi?id=170585
3604
3605         Reviewed by Saam Barati.
3606
3607         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
3608         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
3609
3610         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
3611         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
3612
3613 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
3614
3615         REGRESSION(r211382): Complex text with justification erroneously overflows containers
3616         https://bugs.webkit.org/show_bug.cgi?id=170399
3617         <rdar://problem/31442008>
3618
3619         Reviewed by Simon Fraser.
3620
3621         Check for the invariant that the sum of the advances is equal to m_totalWidth.
3622
3623         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3624         (TestWebKitAPI::TEST_F):
3625
3626 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
3627
3628         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
3629         https://bugs.webkit.org/show_bug.cgi?id=167594
3630
3631         Unreviewed test gardening.
3632
3633         Disable this test because it is still timing out on the bots.
3634
3635         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
3636         (TEST):
3637
3638 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
3639
3640         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
3641         https://bugs.webkit.org/show_bug.cgi?id=170601
3642         <rdar://problem/31492696>
3643
3644         Reviewed by Simon Fraser.
3645
3646         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3647         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
3648         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
3649
3650 2017-04-07  Aakash Jain  <aakash_jain@apple.com>