c183b0d4344b56d640b8739bcd945b0a01a1647a
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-10  Zoltan Nyul  <zoltan.nyul@intel.com>
2
3         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
4         https://bugs.webkit.org/show_bug.cgi?id=103886
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
9         This API is required by layout tests.
10
11         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
13         (WTR::TestRunner::setViewModeMediaFeature):
14         (WTR):
15         * WebKitTestRunner/InjectedBundle/TestRunner.h:
16         (TestRunner):
17
18 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
19
20         [GTK] Bring Harfbuzz-ng support to Gtk
21         https://bugs.webkit.org/show_bug.cgi?id=92098
22
23         Reviewed by Gustavo Noronha Silva.
24
25         Add HarfBuzz dependency.
26
27         * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
28         * gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
29         should no longer affect layout test results.
30
31 2012-12-10  Simon Hausmann  <simon.hausmann@digia.com>
32
33         [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
34         https://bugs.webkit.org/show_bug.cgi?id=104541
35
36         Reviewed by Jocelyn Turcotte.
37
38         We now depend on a Qt 5 version that is guaranteed to have this API, so we
39         can remove the configure checks for it.
40
41         * qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
42         * qmake/config.tests/libexecdir/libexecdir.pro: Removed.
43         * qmake/mkspecs/features/features.prf:
44
45 2012-12-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
46
47         REGRESSION(r135863): GtkLauncher --help no longer displays all help options
48         https://bugs.webkit.org/show_bug.cgi?id=104382
49
50         Reviewed by Philippe Normand.
51
52         Remove gst_init() because it steals the GOptionContext.
53         gst_init_get_option_group() already does the initialization job.
54
55         * GtkLauncher/main.c:
56         (main):
57
58 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
59
60         [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
61         https://bugs.webkit.org/show_bug.cgi?id=102953
62
63         Reviewed by Martin Robinson.
64
65         Implement AccessibilityUIElement::titleUIElement in the ATK backend
66         in the same manner it is implemented in DumpRenderTree. Both implementations
67         are updated to unref the relation set before the final function return
68         rather than at the end of each loop through the relations held in the said
69         relation set.
70
71         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
72         (AccessibilityUIElement::titleUIElement):
73         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
74         (WTR::AccessibilityUIElement::titleUIElement):
75
76 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
77
78         Fix the WebKit2 debug build
79
80         * WebKitTestRunner/TestInvocation.cpp:
81         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().
82
83 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
84
85         [WTR] Move text output accumulation to the UIProcess
86         https://bugs.webkit.org/show_bug.cgi?id=104214
87
88         Reviewed by Darin Adler.
89
90         Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess 
91         once a test is finished, immediately send any text output to the UIProcess. This will allow
92         WebKitTestRunner to output text from the UIProcess as well.
93
94         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output
95         StringBuilder. Add a method to send output to the UIProcess.
96         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
97         (InjectedBundle):
98         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder
99         to use the new outputText method.
100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
101         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
102         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
103         * WebKitTestRunner/TestInvocation.cpp:
104         (WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
105         (WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
106         (WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
107         method of printing the text is slightly different.
108         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
109         message by appending the results to the StringBuilder.
110         * WebKitTestRunner/TestInvocation.h:
111         (TestInvocation): Switch the type of m_textOutput.
112
113 2012-12-10  Mihnea Ovidenie  <mihnea@adobe.com>
114
115         Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.
116
117         * Scripts/webkitpy/common/config/committers.py:
118
119 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
120
121         [GTK] accessibility/language-attribute.html is failing
122         https://bugs.webkit.org/show_bug.cgi?id=98369
123
124         Reviewed by Chris Fleizach.
125
126         The test is failing for two reasons: Not exposing the language
127         for accessible objects and AccessibilityUIElement::language() not
128         being implemented.
129
130         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
131         (AccessibilityUIElement::language): Implemented.
132
133 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
134
135         [GTK] accessibility/editable-webarea-context-menu-point.html is failing
136         https://bugs.webkit.org/show_bug.cgi?id=98364
137
138         Reviewed by Chris Fleizach.
139
140         The test is failing because the clickPoint values remain unchanged. The
141         values remain unchanged because ATK lacks a means to keep track of this
142         information.
143
144         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
145         (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
146         (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
147
148 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
149
150         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
151         https://bugs.webkit.org/show_bug.cgi?id=104481
152
153         Reviewed by Martin Robinson.
154
155         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
156         (AccessibilityUIElement::isSelectable): Implement this by checking
157         the current state of the AtkObject.
158         (AccessibilityUIElement::isMultiSelectable): Implement this by
159         checking the current state of the AtkObject.
160
161 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
162
163         [GTK] accessibility/placeholder.html is failing
164         https://bugs.webkit.org/show_bug.cgi?id=98373
165
166         Reviewed by Martin Robinson.
167
168         The test was failing because the placeholder text was not supported and
169         AccessibilityUIElement::stringAttributeValue() was not implemented.
170
171         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
172         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
173         names into AtkObject attribute names
174         (AccessibilityUIElement::stringAttributeValue): implemented
175
176 2012-12-09  Dan Winship  <danw@gnome.org>
177
178         [GTK] Bump libxml2 requirement in jhbuild.modules
179         https://bugs.webkit.org/show_bug.cgi?id=104477
180
181         Reviewed by Martin Robinson.
182
183         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
184         tests won't run if we only have libxml2 2.8.0 installed in the
185         jhbuild root.
186
187         * gtk/jhbuild.modules:
188
189 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
190
191         Remove testRunner.disableImageLoading()
192         https://bugs.webkit.org/show_bug.cgi?id=98083
193
194         Reviewed by Gustavo Noronha Silva.
195
196         Remove the disableImageLoading methods and callback.
197         No tests use the method anymore and all ports except Wx
198         now support this behavior through overriding the
199         WebKitDisplayImagesKey preference.
200
201         * DumpRenderTree/TestRunner.cpp:
202         (TestRunner::staticFunctions):
203         * DumpRenderTree/TestRunner.h:
204         (TestRunner):
205         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
206         (TestRunner::overridePreference): Add support for overriding the
207         WebKitDisplayImagesKey preference which is now the preferred way
208         of disabling image loading.
209         * DumpRenderTree/efl/TestRunnerEfl.cpp:
210         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
211         * DumpRenderTree/mac/TestRunnerMac.mm:
212         * DumpRenderTree/qt/TestRunnerQt.cpp:
213         * DumpRenderTree/qt/TestRunnerQt.h:
214         (TestRunner):
215         * DumpRenderTree/win/TestRunnerWin.cpp:
216         * DumpRenderTree/wx/TestRunnerWx.cpp:
217
218 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
219
220         [GTK] accessibility/label-for-control-hittest.html is failing
221         https://bugs.webkit.org/show_bug.cgi?id=98368
222
223         Reviewed by Martin Robinson.
224
225         The test was failing because AccessibilityUIElement::elementAtPoint was
226         not implemented.
227
228         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
229         (AccessibilityUIElement::elementAtPoint): implemented
230
231 2012-12-09  Jon Lee  <jonlee@apple.com>
232
233         [WK2] Move button image to injected bundle
234         https://bugs.webkit.org/show_bug.cgi?id=104107
235         <rdar://problem/12813842>
236
237         Reviewed by Simon Fraser.
238
239         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
240         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
241
242 2012-12-08  Halton Huo  <halton.huo@intel.com>
243
244         [CMake] Add CMake style checker
245         https://bugs.webkit.org/show_bug.cgi?id=104240
246
247         Reviewed by Eric Seidel.
248
249         The CMake style checker is followed by existing style checkers like cpp, python.
250         Unit test is added as well.
251
252         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
253         (FileType):
254         (CheckerDispatcher._file_type):
255         (CheckerDispatcher._create_checker):
256         * Scripts/webkitpy/style/checkers/cmake.py: Added.
257         (CMakeChecker):
258         (CMakeChecker.__init__): 
259         (CMakeChecker.check):
260         (CMakeChecker._process_line):
261         (CMakeChecker._check_trailing_whitespace):
262         (CMakeChecker._check_no_space_cmds):
263         (CMakeChecker._check_one_space_cmds):
264         (CMakeChecker._check_non_lowercase_cmd):
265         (CMakeChecker._check_indent):
266         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
267         (CMakeCheckerTest):
268         (CMakeCheckerTest.test_init):
269         (CMakeCheckerTest.test_init._mock_handle_style_error):
270         (CMakeCheckerTest.test_check):
271         (CMakeCheckerTest.test_check._mock_handle_style_error):
272
273 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
274
275         [EFL] Enable WebGL by default.
276         https://bugs.webkit.org/show_bug.cgi?id=102991.
277
278         Reviewed by Kenneth Rohde Christiansen.
279
280         Enable WebGL by default.
281
282         * Scripts/webkitperl/FeatureList.pm:
283
284 2012-12-07  Scott Violet  <sky@chromium.org>
285
286         [chromium] Remove linux theme related files and switch to default
287         https://bugs.webkit.org/show_bug.cgi?id=103897
288
289         Reviewed by Dimitri Glazkov.
290
291         * Scripts/webkitpy/common/config/build_unittest.py:
292         (ShouldBuildTest): linux->default
293
294 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
295
296         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
297         https://bugs.webkit.org/show_bug.cgi?id=104121
298
299         Reviewed by Rob Buis.
300
301         Update createBuffer call to reflect new BufferType enum.
302         Internal PR 254649
303         Internal Review: Jakob Petsovits
304
305         DRT is always backed for maximum compatibility.
306
307         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
308         (createBitmapContextFromWebView):
309
310 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
311
312         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
313         https://bugs.webkit.org/show_bug.cgi?id=104355
314
315         Reviewed by Dirk Pranke.
316
317         This enables chromium's content_shell driver to run with the full SUID
318         sandbox.
319
320         * Scripts/webkitpy/layout_tests/port/base.py:
321         (Port.to.setup_environ_for_server):
322
323 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
324
325         [EFL] Fix tools for WebKit2-only builds
326         https://bugs.webkit.org/show_bug.cgi?id=103904
327
328         Reviewed by Laszlo Gombos.
329
330         The libewebkit2.so should be used for library path for EFL WebKit2.
331
332         * Scripts/webkitdirs.pm:
333         (builtDylibPathForName):
334
335 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
336
337         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
338         https://bugs.webkit.org/show_bug.cgi?id=104243
339
340         RIM PR 259337
341
342         Reviewed by Rob Buis.
343
344         1. Implement calculation of navigation originating in
345         didDecidePolicyForNavigationAction().
346         2. Implement policy delegate for resource response.
347         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
348         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
349
350         The patch fixed the following tests:
351         - http/tests/download
352         - fast/forms/mailto/formenctype-attribute-button-html.html
353         - fast/forms/mailto/formenctype-attribute-input-html.html
354         - fast/encoding/mailto-always-utf-8.html
355
356         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
357         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
358         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
359         (BlackBerry::WebKit::DumpRenderTree::dump):
360         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
361         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
362         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
363         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
364         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
365         (DumpRenderTree):
366         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
367         (TestRunner::setCustomPolicyDelegate):
368         (TestRunner::waitForPolicyDelegate):
369         (TestRunner::overridePreference):
370
371 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
372
373         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
374         https://bugs.webkit.org/show_bug.cgi?id=104348
375
376         Reviewed by Csaba Osztrogonác.
377
378         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
379         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
380
381         * Scripts/webkitpy/layout_tests/port/qt.py:
382         (QtPort._path_to_webcore_library):
383
384 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
385
386         Unreviewed fix, unbreak run-launcher after library renaming.
387
388         * Scripts/webkitdirs.pm:
389         (builtDylibPathForName):
390
391 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
392
393         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
394         https://bugs.webkit.org/show_bug.cgi?id=104296
395
396         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
397         (main):
398
399 2012-12-06  Rick Byers  <rbyers@chromium.org>
400
401         CSS cursor property should support webkit-image-set
402         https://bugs.webkit.org/show_bug.cgi?id=99493
403
404         Reviewed by Beth Dakin.
405
406         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
407
408         * Scripts/webkitperl/FeatureList.pm:
409         * qmake/mkspecs/features/features.pri:
410
411 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
412
413         Unreviewed. Fixing the email address order to work correctly with bugzilla.
414
415         * Scripts/webkitpy/common/config/committers.py:
416
417 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
418
419         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
420         https://bugs.webkit.org/show_bug.cgi?id=104306
421
422         Reviewed by Dimitri Glazkov.
423
424         * DumpRenderTree/chromium/TestWebPlugin.cpp:
425         (TestWebPlugin::TestWebPlugin):
426         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
427         * DumpRenderTree/chromium/TestWebPlugin.h:
428         (TestWebPlugin):
429
430 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
431
432         new-run-webkit-tests --lint-test-files seems to be broken
433         https://bugs.webkit.org/show_bug.cgi?id=104296
434
435         Unreviewed, build fix.
436
437         My recent refactoring caused me to not initialize the printer
438         before calling lint(); this patch restructures the code to make
439         the lint routine self-contained and do all the work necessary.
440         This will also make it easier to move this code out into a standalone
441         file.
442
443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
444         (lint):
445         (main):
446         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
447         (LintTest.test_all_configurations):
448         (LintTest.test_lint_test_files):
449         (LintTest.test_lint_test_files__errors):
450
451 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
452
453         DFG profiler should be helpful about gem installation
454         https://bugs.webkit.org/show_bug.cgi?id=104217
455
456         Reviewed by Oliver Hunt.
457         
458         'json' and 'highline' are not installed by default on the ruby distributions with
459         which I am familiar, and the default error messages don't make me happy. This makes
460         display-profiler-output print a helpful message if those gems are not found.
461
462         * Scripts/display-profiler-output:
463
464 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
465
466         Profiler should print a helpful message if you pass the wrong arguments
467         https://bugs.webkit.org/show_bug.cgi?id=104222
468
469         Reviewed by Oliver Hunt.
470
471         * Scripts/display-profiler-output:
472
473 2012-12-06  Ojan Vafai  <ojan@chromium.org>
474
475         Allow for CCing a secondary email address from watchlists
476         https://bugs.webkit.org/show_bug.cgi?id=104286
477
478         Reviewed by Dirk Pranke.
479
480         Change my watchlist CC address so I can filter these separately from
481         when people explicitly CC me and update the watchlist parser to allow that.
482
483         * Scripts/webkitpy/common/config/committers.py:
484         * Scripts/webkitpy/common/config/watchlist:
485         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
486         (WatchListParser._validate):
487         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
488         (WatchListParserTest.test_cc_rule_with_invalid_email):
489         (WatchListParserTest.test_cc_rule_with_secondary_email):
490
491 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
492
493         Unreviewed. Add myself to committers.py.
494
495         * Scripts/webkitpy/common/config/committers.py:
496
497 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
498
499         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
500         https://bugs.webkit.org/show_bug.cgi?id=104139
501
502         Reviewed by Kenneth Rohde Christiansen.
503
504         Resize the window back to 800x600 between tests.
505         This should be a no-op if the test did not resize the window.
506
507         * WebKitTestRunner/TestController.cpp:
508         (WTR::TestController::resetStateToConsistentValues):
509
510 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
511
512         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
513         https://bugs.webkit.org/show_bug.cgi?id=104254
514
515         Reviewed by Adam Barth.
516
517         Changes the mock error function to take a string instead of an int.
518
519         * DumpRenderTree/chromium/DRTTestRunner.cpp:
520         (DRTTestRunner::setMockSpeechRecognitionError):
521         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
522         (WebTestRunner::ErrorTask::ErrorTask):
523         (MockWebSpeechRecognizer::setError):
524         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
525         (MockWebSpeechRecognizer):
526
527 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
528
529         [Qt][Mac] Fix libxslt and libxml2 config tests
530         https://bugs.webkit.org/show_bug.cgi?id=104164
531
532         Reviewed by Simon Hausmann.
533
534         We should not use pkg-config on Mac instead use direct include
535         paths and add needed libraries to the linker options to detect
536         libxslt and libxml2 provided by the system.
537         Previously we would always fall back to qtxmlpatterns.
538
539         * qmake/config.tests/libxml2/libxml2.pro:
540         * qmake/config.tests/libxslt/libxslt.pro:
541
542 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
543
544         [Qt] Fix the build if the path contains "+" character
545         https://bugs.webkit.org/show_bug.cgi?id=104120
546
547         Reviewed by Tor Arne Vestbø.
548
549         The second parameter of qmake's replace() is regular expression, so
550         we have to escape special characters in paths passed to replace().
551
552         * qmake/mkspecs/features/default_post.prf:
553         * qmake/mkspecs/features/default_pre.prf:
554         * qmake/mkspecs/features/functions.prf:
555
556 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
557
558         Unreviewed, rolling out r136825.
559         http://trac.webkit.org/changeset/136825
560         https://bugs.webkit.org/show_bug.cgi?id=104251
561
562         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
563         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
564
565         * WebKitTestRunner/TestController.cpp:
566         (WTR::TestController::resetStateToConsistentValues):
567
568 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
569
570         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
571         https://bugs.webkit.org/show_bug.cgi?id=104139
572
573         Reviewed by Kenneth Rohde Christiansen.
574
575         Resize the window back to 800x600 between tests.
576         This should be a no-op if the test did not resize the window.
577
578         * WebKitTestRunner/TestController.cpp:
579         (WTR::TestController::resetStateToConsistentValues):
580
581 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
582
583         Unreviewed, rolling out r136784 and r136802.
584         http://trac.webkit.org/changeset/136784
585         http://trac.webkit.org/changeset/136802
586         https://bugs.webkit.org/show_bug.cgi?id=104231
587
588         breaks chromium canary (Requested by morrita on #webkit).
589
590         * Scripts/webkitpy/common/config/build_unittest.py:
591         (ShouldBuildTest):
592
593 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
594
595         Add myself to watch changes in PerformanceTests/*.
596
597         * Scripts/webkitpy/common/config/watchlist:
598
599 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
600
601         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
602         https://bugs.webkit.org/show_bug.cgi?id=102459
603
604         Reviewed by Dimitri Glazkov.
605
606         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
607
608         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
609         (WebThemeControlDRTWin::markState):
610
611 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
612
613         DFG profiler should be able to display where a code block was inlined into, and what it inlined
614         https://bugs.webkit.org/show_bug.cgi?id=104216
615
616         Reviewed by Oliver Hunt.
617
618         Added an "inlines" command that shows the inline stacks that a code block participated
619         in. Also cleaned up some of the ways we print compilation units.
620
621         * Scripts/display-profiler-output:
622
623 2012-12-05  Halton Huo  <halton.huo@intel.com>
624
625         [CMake] Unify coding style for CMake files
626         https://bugs.webkit.org/show_bug.cgi?id=103605
627
628         Reviewed by Laszlo Gombos.
629
630         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
631         1. Indentation
632         1.1 Use spaces, not tabs.
633         1.2 Four spaces as indent.
634         2. Spacing
635         2.1 Place one space between control statements and their parentheses.
636             For eg, if (), else (), elseif (), endif (), foreach (),
637             endforeach (), while (), endwhile (), break ().
638         2.2 Do not place spaces between function and macro statements and
639             their parentheses. For eg, macro(), endmacro(), function(),
640             endfunction().
641         2.3 Do not place spaces between a command or function or macro and its
642             parentheses, or between a parenthesis and its content. For eg,
643             message("testing") not message( "testing") or message ("testing" )
644         2.4 No space at line ending.
645         3. Lowercase when call commands macros and functions. For eg,
646            add_executable() not ADD_EXECUTABLE(), set() not SET().
647
648         * CMakeLists.txt:
649         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
650         * DumpRenderTree/efl/CMakeLists.txt:
651         * EWebLauncher/CMakeLists.txt:
652         * EWebLauncher/ControlTheme/CMakeLists.txt:
653         * MiniBrowser/efl/CMakeLists.txt:
654         * TestWebKitAPI/CMakeLists.txt:
655         * TestWebKitAPI/PlatformEfl.cmake:
656         * WebKitTestRunner/CMakeLists.txt:
657         * WebKitTestRunner/PlatformEfl.cmake:
658         * WinCELauncher/CMakeLists.txt:
659         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
660
661 2012-12-05  Scott Violet  <sky@chromium.org>
662
663         [chromium] Remove linux theme related files and switch to default
664         https://bugs.webkit.org/show_bug.cgi?id=103897
665
666         Reviewed by Tony Chang.
667
668         * Scripts/webkitpy/common/config/build_unittest.py:
669         (ShouldBuildTest): linux->default
670
671 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
672
673         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
674         https://bugs.webkit.org/show_bug.cgi?id=78168
675
676         Reviewed by Ojan Vafai.
677
678         This patch adds a single ordered list to ResultSummary that contains
679         the results of every test run in order of result received, and
680         modifies the TestResults class to contain the list of references used
681         for each test as well as the pid of the driver; this allows us to stop
682         having to override the test drivers to record the tests, and makes the
683         integration tests that test rdering, retries, restarts, etc. black-box
684         tests.
685
686         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
687         (SingleTestRunner._run_rebaseline):
688         (SingleTestRunner._compare_output):
689         (SingleTestRunner._run_reftest):
690         (SingleTestRunner._compare_output_with_reference):
691         * Scripts/webkitpy/layout_tests/models/result_summary.py:
692         (ResultSummary.__init__):
693         (ResultSummary.add):
694         * Scripts/webkitpy/layout_tests/models/test_results.py:
695         (TestResult.__init__):
696         * Scripts/webkitpy/layout_tests/port/driver.py:
697         (DriverOutput.__init__):
698         (Driver.run_test):
699         * Scripts/webkitpy/layout_tests/port/test.py:
700         (TestDriver):
701         (TestDriver.__init__):
702         (TestDriver.run_test):
703         (TestDriver.stop):
704         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
705         (get_tests_run):
706         (get_test_batches):
707         (get_test_results):
708         (MainTest.test_batch_size):
709         (MainTest.test_dryrun):
710         (MainTest.test_natural_order):
711         (MainTest.test_natural_order_test_specified_multiple_times):
712         (MainTest.test_random_order):
713         (MainTest.test_random_order_test_specified_multiple_times):
714         (MainTest.test_no_order):
715         (MainTest.test_no_order_test_specified_multiple_times):
716         (MainTest.test_no_order_with_directory_entries_in_natural_order):
717         (MainTest.test_repeat_each):
718         (MainTest.test_ignore_flag):
719         (MainTest.test_skipped_flag):
720         (MainTest.test_iterations):
721         (MainTest.test_run_chunk):
722         (MainTest.test_run_part):
723         (MainTest.test_run_singly):
724         (MainTest.test_skip_failing_tests):
725         (MainTest.test_single_file):
726         (MainTest.test_single_file_with_prefix):
727         (MainTest.test_single_skipped_file):
728         (MainTest.test_test_list):
729         (MainTest.test_test_list_with_prefix):
730         (MainTest.test_exit_after_n_failures):
731         (MainTest.test_exit_after_n_crashes):
732         (MainTest.test_run_order__inline):
733         (MainTest.test_reftest_run):
734         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
735         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
736         (MainTest.test_reftest_expected_html_should_be_ignored):
737         (MainTest.test_reftest_driver_should_run_expected_html):
738         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
739         (MainTest.test_no_http_tests):
740         (MainTest.test_platform_tests_are_found):
741
742 2012-12-05  Dana Jansens  <danakj@chromium.org>
743
744         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
745         https://bugs.webkit.org/show_bug.cgi?id=103967
746
747         Reviewed by James Robinson.
748
749         Use the WebCompositorSupport methods to create an OutputSurface. If they
750         fail, then fall back to the WebViewHost methods.
751
752         Once the chromium side lands, the WebCompositorSupport methods will stop
753         failing, and will replace the WebViewHost ones.
754
755         * DumpRenderTree/chromium/WebViewHost.cpp:
756         (WebViewHost::createOutputSurface):
757
758 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
759
760         nrwt: split all of the buildbot-specific output into its own file
761         https://bugs.webkit.org/show_bug.cgi?id=104165
762
763         Reviewed by Ojan Vafai.
764
765         Now that we have the RunDetails object we can move all of the
766         buildbot-specific knowledge out of the core test-running code
767         and into the outermost run_webkit_tests layer.
768
769         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
770         (run):
771         (main):
772         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
773         (passing_run):
774         (logging_run):
775         (run_and_capture):
776         (MainTest.test_all):
777         (MainTest.test_max_locked_shards):
778         (MainTest.test_child_processes_2):
779         (MainTest.test_child_processes_min):
780         (MainTest.test_full_results_html):
781         (MainTest.test_hung_thread):
782         (MainTest.test_keyboard_interrupt):
783         (MainTest.test_no_tests_found):
784         (MainTest.test_no_tests_found_2):
785         (MainTest.test_repeat_each_iterations_num_tests):
786         (MainTest.test_run_singly_actually_runs_tests):
787         (MainTest.test_test_list):
788         (MainTest.test_unexpected_failures):
789         (MainTest.test_missing_and_unexpected_results):
790         (MainTest.test_pixel_test_directories):
791         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
792         (MainTest.test_crash_with_stderr):
793         (MainTest.test_no_image_failure_with_image_diff):
794         (MainTest.test_crash_log):
795         (MainTest.test_web_process_crash_log):
796         (MainTest.test_exit_after_n_failures_upload):
797         (MainTest.test_results_directory_absolute):
798         (MainTest.test_results_directory_default):
799         (MainTest.test_results_directory_relative):
800         (MainTest.test_retrying_and_flaky_tests):
801         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
802         (MainTest.test_output_diffs):
803         (MainTest.test_unsupported_platform):
804         (MainTest.test_verbose_in_child_processes):
805         (EndToEndTest.test_end_to_end):
806         (EndToEndTest.test_reftest_with_two_notrefs):
807         (RebaselineTest.test_reset_results):
808         (RebaselineTest.test_missing_results):
809         (RebaselineTest.test_new_baseline):
810         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
811         (BuildBotPrinter):
812         (BuildBotPrinter.__init__):
813         (BuildBotPrinter.print_results):
814         (BuildBotPrinter._print):
815         (BuildBotPrinter.print_result_summary):
816         (BuildBotPrinter._print_result_summary_entry):
817         (BuildBotPrinter.print_unexpected_results):
818         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
819         (BuildBotPrinter.print_unexpected_results.add_result):
820         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
821         (BuildBotPrinterTests):
822         (BuildBotPrinterTests.assertEmpty):
823         (BuildBotPrinterTests.assertNotEmpty):
824         (BuildBotPrinterTests.get_printer):
825         (BuildBotPrinterTests.get_result):
826         (BuildBotPrinterTests.get_result_summary):
827         (BuildBotPrinterTests.test_print_unexpected_results):
828         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
829         * Scripts/webkitpy/layout_tests/views/printing.py:
830         (Printer):
831         (Printer.__init__):
832         (Printer.print_results):
833         (Printer._print_statistics_for_test_timings):
834         (Printer._print_baseline):
835         (Printer._print_debug):
836         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
837         (Testprinter.get_printer):
838         (Testprinter.get_result):
839         (Testprinter.test_configure_and_cleanup):
840         (Testprinter.test_print_config):
841         (Testprinter.test_print_one_line_summary):
842         (Testprinter.test_test_status_line):
843         (Testprinter.test_details):
844
845 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
846
847         nrwt: collect all of the information about a run into a new RunDetails class
848         https://bugs.webkit.org/show_bug.cgi?id=104158
849
850         Reviewed by Ojan Vafai.
851
852         This patch collects the information from both test passes (the
853         main one and the retries) as well as the summarized results and
854         the exit code into a RunDetails class, so that the integration
855         tests can more easily tell what happened.
856
857         Also, change the way the --lint-test-files works slightly so that
858         we don't need to create a printer object (and hence we need to
859         rework the tests that are testing logging).
860
861         * Scripts/webkitpy/layout_tests/controllers/manager.py:
862         (RunDetails):
863         (RunDetails.__init__):
864         (Manager.run):
865         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
866         (run):
867         (main):
868         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
869         (passing_run):
870         (run_and_capture):
871         (LintTest.test_lint_test_files):
872         (LintTest.test_lint_test_files__errors):
873         (MainTest.test_verbose_in_child_processes):
874
875 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
876
877         nrwt: remove --no-record-results
878         https://bugs.webkit.org/show_bug.cgi?id=104072
879
880         Reviewed by Ojan Vafai.
881
882         The command line flag was only being used in the unit tests and
883         wasn't really needed once we started using a mock filesystem.
884
885         Also, reformat a bunch of long lines ...
886
887         * Scripts/webkitpy/layout_tests/controllers/manager.py:
888         (Manager.run):
889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
890         (parse_args):
891         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
892         (parse_args):
893         (passing_run):
894         (logging_run):
895         (MainTest.test_repeat_each_iterations_num_tests):
896         (MainTest.test_test_list):
897         (MainTest.test_missing_and_unexpected_results):
898         (MainTest.test_pixel_test_directories):
899         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
900         (MainTest.test_crash_with_stderr):
901         (MainTest.test_no_image_failure_with_image_diff):
902         (MainTest.test_crash_log):
903         (MainTest.test_web_process_crash_log):
904         (MainTest.test_exit_after_n_failures_upload):
905         (MainTest.test_results_directory_absolute):
906         (MainTest.test_results_directory_relative):
907         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
908         (MainTest.test_additional_expectations):
909         (MainTest.test_output_diffs):
910         (EndToEndTest.test_end_to_end):
911         (EndToEndTest.test_reftest_with_two_notrefs):
912         (RebaselineTest.test_reset_results):
913         (RebaselineTest.test_missing_results):
914         (RebaselineTest.test_new_baseline):
915
916 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
917
918         nrwt: only summarize the results one way
919         https://bugs.webkit.org/show_bug.cgi?id=104064
920
921         Reviewed by Ojan Vafai.
922
923         Change manager.summarize_results so that we always (and only)
924         include both expected and unexpected results. Previously we
925         would summarize the results twice, once with expected results
926         and once without. This made the code much more confusing than
927         it needed to be.
928
929         * Scripts/webkitpy/layout_tests/controllers/manager.py:
930         (summarize_results):
931         (Manager.run):
932         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
933         (ResultSummaryTest.summarized_results):
934         (ResultSummaryTest.test_no_svn_revision):
935         (ResultSummaryTest.test_svn_revision):
936         (ResultSummaryTest.test_summarized_results_wontfix):
937         * Scripts/webkitpy/layout_tests/views/printing.py:
938         (Printer.print_results):
939         (Printer._print_unexpected_results):
940         (Printer._print_unexpected_results.add_result):
941         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
942         (Testprinter.test_print_unexpected_results.get_unexpected_results):
943         (Testprinter):
944
945 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
946
947         DFG profiler should display more information
948         https://bugs.webkit.org/show_bug.cgi?id=104163
949
950         Reviewed by Gavin Barraclough.
951
952         Added the following:
953         
954         - Distinguish between source counts and bytecode counts.
955         
956         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
957         
958         - Add a "source" command to see the source.
959         
960         - Add a "bytecode" command to see the bytecode and counts.
961
962         * Scripts/display-profiler-output:
963
964 2012-12-05  Yong Li  <yoli@rim.com>
965
966         [BlackBerry] Build with libjpegturbo
967         https://bugs.webkit.org/show_bug.cgi?id=104152
968
969         Reviewed by Rob Buis.
970
971         RIM PR# 196975.
972         Make sure the right include path for libjpeg is included.
973
974         * Scripts/webkitdirs.pm:
975         (blackberryCMakeArguments):
976
977 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
978
979         Remove stale check in check-for-webkit-framework-include-consistency
980         https://bugs.webkit.org/show_bug.cgi?id=103775
981
982         Reviewed by David Kilzer.
983
984         The underlying issue was fixed in r81173.
985
986         * Scripts/check-for-webkit-framework-include-consistency:
987
988 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
989
990         nrwt: simplify the finding of tests to retry
991         https://bugs.webkit.org/show_bug.cgi?id=104067
992
993         Reviewed by Ryosuke Niwa.
994
995         I think this makes the code a little clearer; note that
996         we were no longer using the include_missing flag.
997
998         * Scripts/webkitpy/layout_tests/controllers/manager.py:
999         (Manager.run):
1000         (Manager._failed_test_names):
1001
1002 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1003
1004         nrwt: remove two unused parameters from a function
1005         https://bugs.webkit.org/show_bug.cgi?id=104059
1006
1007         Reviewed by Ryosuke Niwa.
1008
1009         Also remove an old, stale FIXME.
1010
1011         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1012         (interpret_test_failures):
1013         (summarize_results):
1014         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1015         (ResultSummaryTest.test_interpret_test_failures):
1016
1017 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1018
1019         nrwt: return result_summaries from LayoutTestRunner.run_tests()
1020         https://bugs.webkit.org/show_bug.cgi?id=104051
1021
1022         Reviewed by Ojan Vafai.
1023
1024         This patch completes the refactoring that makes the result summary      
1025         an object returned from the layout test runner, rather than having      
1026         it passed in and modified. This makes the split of duties between       
1027         the manager and runner clearer and makes the data flow more             
1028         functionally.                                                           
1029
1030         Also clean up some minor lint issues.
1031
1032         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1033         (LayoutTestRunner.__init__):
1034         (LayoutTestRunner.run_tests):
1035         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1036         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1037         (FakePrinter.print_expected):
1038         (LockCheckingRunner.__init__):
1039         (LayoutTestRunnerTests._runner):
1040         (LayoutTestRunnerTests._run_tests):
1041         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1042         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1043         (Manager.__init__):
1044         (Manager.run):
1045         (Manager._run_tests):
1046
1047 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1048
1049         nrwt: move creation of the resultsummary objects into Manager._run_tests()
1050         https://bugs.webkit.org/show_bug.cgi?id=104048
1051
1052         Reviewed by Ojan Vafai.
1053
1054         This is a preparatory step to making the resultsummary just get
1055         returned from the layout_test_runner; this does most of manager-side
1056         changes.
1057
1058         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1059         (Manager._prepare_lists):
1060         (Manager.run):
1061         (Manager._run_tests):
1062
1063 2012-12-05  Leo Yang  <leoyang@rim.com>
1064
1065         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
1066         https://bugs.webkit.org/show_bug.cgi?id=104132
1067
1068         Reviewed by Yong Li.
1069
1070         * Scripts/webkitperl/FeatureList.pm:
1071
1072 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1073
1074         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
1075         https://bugs.webkit.org/show_bug.cgi?id=104102
1076
1077         Reviewed by Oliver Hunt.
1078
1079         Modify the profiler to not output counts for op_call_put_result, since there
1080         won't be any. Also fix a few weird bugs, like providing better error reporting
1081         when you type something incorrectly and not reporting counts for slow paths
1082         in the old JIT since those counts are actually not what you think they are
1083         (we don't actually count slow path executions separately).
1084
1085         * Scripts/display-profiler-output:
1086
1087 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
1088
1089         Fix compilation for Qt5.0.0 stable branch.
1090         https://bugs.webkit.org/show_bug.cgi?id=103870
1091
1092         Reviewed by Simon Hausmann.
1093
1094         Fix the use of renamed QWindow functions.
1095         Patch by Andras Becsi <andras.becsi@digia.com>
1096
1097         * MiniBrowser/qt/BrowserWindow.cpp:
1098         (BrowserWindow::BrowserWindow):
1099         (BrowserWindow::onTitleChanged):
1100         * MiniBrowser/qt/raw/View.cpp:
1101         (View::View):
1102
1103 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1104
1105         [WK2] InjectedBundle should check Intent url for null
1106         https://bugs.webkit.org/show_bug.cgi?id=104117
1107
1108         Reviewed by Kenneth Rohde Christiansen.
1109
1110         WKIntentServiceInfoCopyHref() can return null, we need to check
1111         for that in InjectedBundlePage::registerIntentServiceForFrame()
1112         to avoid crashing.
1113
1114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1115         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1116
1117 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1118
1119         Change email address of Jonathan Dong
1120         https://bugs.webkit.org/show_bug.cgi?id=103976
1121
1122         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
1123         to jonathan.dong.webkit@gmail.com in committers list.
1124
1125         * Scripts/webkitpy/common/config/committers.py:
1126
1127 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1128
1129         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
1130         https://bugs.webkit.org/show_bug.cgi?id=103986
1131
1132         Reviewed by Rob Buis.
1133
1134         Also move declaration of webSettingTransaction to before any WebSettings
1135         ::setXXX() calls so that it works as expected (commit only once in the
1136         function scope).
1137
1138         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1139         (shouldDumpAsText):
1140         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1141
1142 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1143
1144         display-profiler-output should be able to show source code
1145         https://bugs.webkit.org/show_bug.cgi?id=104073
1146
1147         Reviewed by Oliver Hunt.
1148
1149         Display source code in the summary, using a one-line shortening.
1150
1151         * Scripts/display-profiler-output:
1152
1153 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1154
1155         display-profiler-output should not use reflective infocation to resolve command names
1156
1157         Rubber stamped by Mark Hahnenberg.
1158
1159         Reflection is amazing, but here it was just kind of a bit much.
1160
1161         * Scripts/display-profiler-output:
1162
1163 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1164
1165         JSC should be able to report profiling data associated with the IR dumps and disassembly
1166         https://bugs.webkit.org/show_bug.cgi?id=102999
1167
1168         Reviewed by Gavin Barraclough.
1169
1170         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1171         this still gets confused a bit about the execution counts of a method running
1172         standalone versus a method running inlined, but other than that, it's pretty cool.
1173         See the attached "sampling profiling session" attached to the bug to see it in
1174         action.
1175         
1176         Also had to feed EFL's build system.
1177
1178         * DumpRenderTree/efl/CMakeLists.txt:
1179         * Scripts/display-profiler-output: Added.
1180
1181 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1182
1183         nrwt: fix total number of tests computed in the result summary
1184         https://bugs.webkit.org/show_bug.cgi?id=104061
1185
1186         Unreviewed, build fix.
1187
1188         One of the recent changes to the resultsummary refactoring caused
1189         us to not include the number of skipped tests in the total number
1190         of tests, throwing off the totals printed in print_one_line_summary().
1191
1192         Unfortunately, given the current state of the code it is difficult
1193         to construct an accurate unit test for this. I have verified the
1194         fix by hand, and will write a test once the remaining refactoring
1195         patches land, at which point it will be trivial to test it.
1196
1197         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1198         (Manager._prepare_lists):
1199
1200 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1201
1202         nrwt is not returning the exit status properly
1203         https://bugs.webkit.org/show_bug.cgi?id=103830
1204
1205         Unreviewed, build fix.
1206
1207         The fix in r136474 wasn't quite right either, and would return
1208         the correct exceptional status, but not the correct failing status.
1209
1210         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1211
1212 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1213
1214         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1215         https://bugs.webkit.org/show_bug.cgi?id=104047
1216
1217         Reviewed by Eric Seidel.
1218
1219         The code becomes cleaner if we are just passing values around rather
1220         than hanging them off the manager object, helps move _prepare_lists()
1221         to a pure function, and is needed to eventually make the
1222         result_summary object something returned from runner.run_tests()
1223         (note that two more patches are needed for that to happen).
1224
1225         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1226         (Manager.__init__):
1227         (Manager._http_tests):
1228         (Manager._prepare_lists):
1229         (Manager.needs_servers):
1230         (Manager._set_up_run):
1231         (Manager.run):
1232         (Manager._run_tests):
1233         (Manager._upload_json_files):
1234         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1235         (ManagerTest.test_needs_servers.get_manager):
1236         (ManagerTest.test_needs_servers):
1237         (ManagerTest.integration_test_needs_servers.get_manager):
1238         (ManagerTest.integration_test_needs_servers):
1239         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1240         (ManagerTest):
1241         (ManagerTest.test_look_for_new_crash_logs):
1242         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1243         (JSONLayoutResultsGenerator.__init__):
1244         (JSONLayoutResultsGenerator._get_modifier_char):
1245
1246 2012-12-04  Adam Barth  <abarth@webkit.org>
1247
1248         commit-queue can get stuck with a local commit
1249         https://bugs.webkit.org/show_bug.cgi?id=104032
1250
1251         Reviewed by Dirk Pranke.
1252
1253         Previously the commit-queue would only clean down to HEAD. If the
1254         commit-queue gets interrupted in the middle of a commit (e.g., after
1255         the local commit but before the dcommit), then it can end up with a
1256         patch locally committed. That patch will then prevent the commit-queue
1257         from functioning.
1258
1259         This patch teaches the commit-queue to clean down to the merge base,
1260         which will remove any local commits.
1261
1262         * Scripts/webkitpy/common/checkout/scm/git.py:
1263         (Git.working_directory_is_clean):
1264         (Git.clean_working_directory):
1265         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1266         * Scripts/webkitpy/tool/steps/commit.py:
1267         (Commit._commit_warning):
1268         (Commit.run):
1269
1270 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1271
1272         nrwt: store only the total number of tests in the result summary
1273         https://bugs.webkit.org/show_bug.cgi?id=103963
1274
1275         Reviewed by Ryosuke Niwa.
1276
1277         The result summary only needs the total number of tests that will
1278         be run (including repetitions) in order to provide the correct stats;
1279         it doesn't actually need to know how many unique tests there are, or
1280         or how many repetitions there are.
1281
1282         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1283         (LayoutTestRunnerTests._result_summary):
1284         (LayoutTestRunnerTests.test_update_summary_with_result):
1285         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1286         (Manager._prepare_lists):
1287         (Manager.run):
1288         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1289         (ManagerTest.test_look_for_new_crash_logs):
1290         (ResultSummaryTest.get_result_summary):
1291         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1292         (ResultSummary.__init__):
1293         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1294         (Testprinter.get_result_summary):
1295
1296 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1297
1298         nrwt: do less work when ctrl-c'ed
1299         https://bugs.webkit.org/show_bug.cgi?id=103961
1300
1301         Reviewed by Ryosuke Niwa.
1302
1303         Do less work when we are ctrl-c'ed, because the statistics aren't
1304         that useful anyway. While we're at it, modify summarize_results
1305         to be aware that we don't always retry results (instead of pretending
1306         that the retry produced the same results the initial run did).
1307
1308         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1309         (summarize_results):
1310         (Manager.run):
1311
1312 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1313
1314         nrwt: result summaries should not require a list of tests to skip
1315         https://bugs.webkit.org/show_bug.cgi?id=103951
1316
1317         Reviewed by Ryosuke Niwa.
1318
1319         We shouldn't really be passing a list of tests to skip to the
1320         ResultSummary objects; they should be handled like any other
1321         test result as much as possible.
1322
1323         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1324         (LayoutTestRunnerTests._result_summary):
1325         (LayoutTestRunnerTests.test_update_summary_with_result):
1326         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1327         (Manager._prepare_lists):
1328         (Manager.run):
1329         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1330         (ManagerTest.test_look_for_new_crash_logs):
1331         (ResultSummaryTest.get_result_summary):
1332         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1333         (ResultSummary.__init__):
1334         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1335         (TestExpectations):
1336         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1337         (Testprinter.get_result_summary):
1338
1339 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1340
1341         nrwt: derive per-thread, per-worker stats from result summaries
1342         https://bugs.webkit.org/show_bug.cgi?id=103943
1343
1344         Reviewed by Ojan Vafai.
1345
1346         This patch changes the manager and printing code to pull more           
1347         information from the ResultSummary object rather than tracking          
1348         additional statistics on the side. This allows us to consolidate        
1349         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1350         of values. We add the shard_name and worker_name to each TestResult,    
1351         and then modify print_timing_statistics() and upload_json_files()       
1352         to just need the result summaries.                                      
1353
1354         Note that this patch also changes the timing statistics slightly
1355         so that the individual test times are the times to run just the
1356         tests themselves (TestResult.test_run_time) and do not include the
1357         times taken to run the ref tests, compute diffs, etc. The aggregated
1358         per-worker and per-shard statistics still use the total time to
1359         process each test (TestResult.total_run_time).
1360
1361         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1362         (LayoutTestRunner.__init__):
1363         (LayoutTestRunner.run_tests):
1364         (LayoutTestRunner._handle_finished_test_list):
1365         (LayoutTestRunner._handle_finished_test):
1366         (Worker.handle):
1367         (Worker._run_test):
1368         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1369         (summarize_results):
1370         (Manager.run):
1371         (Manager._upload_json_files):
1372         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1373         (ResultSummaryTest.summarized_results):
1374         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1375         (JSONLayoutResultsGenerator.__init__):
1376         (JSONLayoutResultsGenerator._get_test_timing):
1377         * Scripts/webkitpy/layout_tests/models/test_results.py:
1378         (TestResult.__init__):
1379         * Scripts/webkitpy/layout_tests/views/printing.py:
1380         (Printer.print_results):
1381         (Printer._print_timing_statistics):
1382         (Printer):
1383         (Printer._print_worker_statistics):
1384         (Printer._print_aggregate_test_statistics):
1385         (Printer._print_individual_test_times):
1386         (Printer._print_directory_timings):
1387         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1388         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1389         (Testprinter):
1390
1391 2012-12-04  Adam Barth  <abarth@webkit.org>
1392
1393         Remove obsolete code from webkitpy
1394         https://bugs.webkit.org/show_bug.cgi?id=104029
1395
1396         Reviewed by Eric Seidel.
1397
1398         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1399         (CommitQueueTask.run):
1400         * Scripts/webkitpy/tool/steps/commit.py:
1401         (Commit.options):
1402         * Scripts/webkitpy/tool/steps/options.py:
1403         (Options):
1404
1405 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
1406
1407         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
1408         https://bugs.webkit.org/show_bug.cgi?id=103841
1409
1410         Reviewed by Darin Fisher.
1411
1412         * DumpRenderTree/DumpRenderTree.gypi:
1413         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1414         (DRTTestRunner::DRTTestRunner):
1415         (DRTTestRunner::reset):
1416         * DumpRenderTree/chromium/DRTTestRunner.h:
1417         (DRTTestRunner):
1418         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
1419         (WebKit):
1420         (WebTestRunner):
1421         (WebPreferences):
1422         (WebTestRunner::WebPreferences::WebPreferences):
1423         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1424         (WebTestRunner):
1425         (WebTestDelegate):
1426         (WebTestRunner::WebTestDelegate::localFileToDataURL):
1427         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
1428         (WebTestRunner::WebTestDelegate::preferences):
1429         (WebTestRunner::WebTestDelegate::applyPreferences):
1430         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1431         (WebTestRunner::TestRunner::TestRunner):
1432         (WebTestRunner::TestRunner::reset):
1433         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
1434         (WebTestRunner):
1435         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
1436         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
1437         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
1438         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
1439         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
1440         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
1441         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
1442         (WebTestRunner::TestRunner::overridePreference):
1443         (WebTestRunner::TestRunner::setPluginsEnabled):
1444         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1445         (TestRunner):
1446         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
1447         (WebTestRunner::WebPreferences::reset):
1448         (WebTestRunner):
1449         (WebTestRunner::WebPreferences::applyTo):
1450         * DumpRenderTree/chromium/TestShell.h:
1451         (TestShell::preferences):
1452         (TestShell):
1453         * DumpRenderTree/chromium/WebViewHost.cpp:
1454         (WebViewHost::localFileToDataURL):
1455         (WebViewHost::rewriteLayoutTestsURL):
1456         (WebViewHost::preferences):
1457         (WebViewHost::applyPreferences):
1458         * DumpRenderTree/chromium/WebViewHost.h:
1459         (WebViewHost):
1460
1461 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1462
1463         Many webkitpy unit tests can be run standalone, are executable
1464         https://bugs.webkit.org/show_bug.cgi?id=103900
1465
1466         Reviewed by Eric Seidel.
1467
1468         There's no need anymore to run unit tests in standalone mode as they
1469         are now handled by test-webkitpy in a formidable fashion. This makes
1470         it possible for this patch to remove the following unnecessary bits:
1471         - remove shebang lines from unit test files,
1472         - remove calls to unittest.main(),
1473         - make unit test files non-executable.
1474
1475         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1476         (DiffParserTest.test_git_mnemonicprefix):
1477         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1478         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
1479         * Scripts/webkitpy/common/config/build_unittest.py:
1480         (ShouldBuildTest.test_should_build):
1481         * Scripts/webkitpy/common/config/ports_unittest.py:
1482         (DeprecatedPortTest.test_chromium_xvfb_port):
1483         * Scripts/webkitpy/common/find_files_unittest.py:
1484         (TestWinNormalize.test_win):
1485         * Scripts/webkitpy/common/lru_cache_unittest.py:
1486         (LRUCacheTest.test_set_again):
1487         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1488         (test_results_zip_url):
1489         * Scripts/webkitpy/common/net/credentials_unittest.py:
1490         (test_keyring_without_git_repo_nor_keychain):
1491         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1492         (OmahaProxyTest.test_get_revisions):
1493         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1494         * Scripts/webkitpy/common/newstringio_unittest.py:
1495         (NewStringIOTest.test_with):
1496         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1497         (ReadChecksumFromPngTest.test_read_checksum):
1498         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1499         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1500         (MockFileSystemTest.test_normpath):
1501         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1502         (RealFileSystemTest.test_sep):
1503         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1504         (TestPlatformInfo.test_total_bytes_memory):
1505         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1506         (ZipFileSetTest.test_namelist):
1507         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1508         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1509         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1510         (TestResultWriterTest.test_reftest_diff_image):
1511         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1512         (JSONGeneratorTest.test_test_timings_trie):
1513         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1514         (TestExpectationSerializationTests.test_string_whitespace_stripping):
1515         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1516         (KeyCompareTest.test_test_key):
1517         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1518         (BuildersTest.test_path_from_name):
1519         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1520         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1521         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1522         (ChromiumLinuxPortTest.test_path_to_image_diff):
1523         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1524         (ChromiumMacPortTest.test_path_to_image_diff):
1525         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1526         (ChromiumPortLoggingTest.test_check_sys_deps):
1527         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1528         (ChromiumPortLoggingTest.test_check_sys_deps):
1529         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1530         (ConfigTest.test_default_configuration__scripterror):
1531         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1532         (DriverTest.test_start_actually_starts):
1533         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1534         (FactoryTest.test_get_from_builder_name):
1535         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1536         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1537         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1538         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
1539         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1540         (PortTest.disabled_test_mac_lion):
1541         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1542         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1543         (VerboseTest.test_log_args):
1544         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1545         (test_details):
1546         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1547         (TestPerfTestFactory.test_inspector_test):
1548         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1549         (test_parse_args):
1550         * Scripts/webkitpy/style/checker_unittest.py:
1551         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1552         (ChangeLogCheckerTest.test_no_error):
1553         * Scripts/webkitpy/style/checkers/common_unittest.py:
1554         (TabCheckerTest.test_tab):
1555         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1556         (CppCheckerTest.test_ne):
1557         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1558         * Scripts/webkitpy/style/checkers/png_unittest.py:
1559         (PNGCheckerTest.test_check):
1560         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1561         * Scripts/webkitpy/style/checkers/text_unittest.py:
1562         (TextCheckerTest.test_init):
1563         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1564         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1565         (XcodeProjectFileCheckerTest.test_detect_development_region):
1566         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1567         (XMLCheckerTest.test_no_error):
1568         * Scripts/webkitpy/style/patchreader_unittest.py:
1569         * Scripts/webkitpy/test/finder_unittest.py:
1570         (FinderTest.test_paths):
1571         * Scripts/webkitpy/test/runner_unittest.py:
1572         (RunnerTest.test_run):
1573         * Scripts/webkitpy/test/skip_unittest.py:
1574         (SkipTest.test_skip_if_true):
1575         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1576         (ThirdpartyTest.test_imports):
1577         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1578         (TestTranslation.test_include_rewriting):
1579         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1580         (QueueEngineTest.tearDown):
1581         * Scripts/webkitpy/tool/grammar_unittest.py:
1582         (GrammarTest.test_join_with_separators):
1583         * Scripts/webkitpy/tool/mocktool_unittest.py:
1584         (MockOptionsTest.test_kwarg__set):
1585         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1586         (test_command_help):
1587
1588 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1589
1590         Many webkitpy module files are executable, have shebang line
1591         https://bugs.webkit.org/show_bug.cgi?id=103985
1592
1593         Reviewed by Dirk Pranke.
1594
1595         Remove the executable bit from webkitpy module files that are
1596         unnecessarily executable. Remove the shebang line from webkitpy
1597         module files, they are of no use. Only non-third-party files are
1598         changed.
1599
1600         * Scripts/webkitpy/bindings/main.py:
1601         * Scripts/webkitpy/common/config/watchlist:
1602         * Scripts/webkitpy/common/find_files.py:
1603         * Scripts/webkitpy/common/lru_cache.py:
1604         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1605         * Scripts/webkitpy/common/net/file_uploader.py:
1606         * Scripts/webkitpy/common/newstringio.py:
1607         * Scripts/webkitpy/common/read_checksum_from_png.py:
1608         * Scripts/webkitpy/common/system/autoinstall.py:
1609         * Scripts/webkitpy/common/system/file_lock.py:
1610         * Scripts/webkitpy/common/system/file_lock_mock.py:
1611         * Scripts/webkitpy/common/version_check.py:
1612         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1613         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1614         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1615         * Scripts/webkitpy/layout_tests/models/test_input.py:
1616         * Scripts/webkitpy/layout_tests/port/__init__.py:
1617         * Scripts/webkitpy/layout_tests/port/base.py:
1618         * Scripts/webkitpy/layout_tests/port/builders.py:
1619         * Scripts/webkitpy/layout_tests/port/chromium.py:
1620         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1621         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1622         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1623         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1624         * Scripts/webkitpy/layout_tests/port/config.py:
1625         * Scripts/webkitpy/layout_tests/port/factory.py:
1626         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1627         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1628         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1629         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1630         * Scripts/webkitpy/layout_tests/port/server_process.py:
1631         * Scripts/webkitpy/layout_tests/port/test.py:
1632         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1633         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1634         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1635         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1636         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1637         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1638         * Scripts/webkitpy/layout_tests/views/printing.py:
1639         * Scripts/webkitpy/performance_tests/perftest.py:
1640         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1641         * Scripts/webkitpy/style/checkers/changelog.py:
1642         * Scripts/webkitpy/style/checkers/cpp.py:
1643         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1644         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1645         (main): There's no need to run this module in standalone because
1646         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1647         * Scripts/webkitpy/tool/commands/upload.py:
1648         * Scripts/webkitpy/tool/comments.py:
1649         * Scripts/webkitpy/tool/main.py:
1650
1651 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1652
1653         Add a Chromium Android Release (Perf) to the list of perf. bots.
1654
1655         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1656
1657 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1658
1659         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1660         https://bugs.webkit.org/show_bug.cgi?id=103991
1661
1662         Reviewed by Martin Robinson.
1663
1664         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1665         command that's being formed in multiprocessing bootstrap. The wrapper is
1666         an executable Python script while the command being wrapped perhaps isn't
1667         and therefore requires the Python interpreter to be listed at the beginning
1668         of the command sublist that is then executed by the wrapper.
1669
1670         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1671         is about to lose the executable bit and the Python-signaling shebang line.
1672         The Jhbuild wrapper simply executes the command that's passed, but that errs
1673         in this case unless the Python executable is executed and the module file
1674         is passed to it as an argument.
1675
1676         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1677         (run):
1678
1679 2012-12-04  Peter Beverloo  <peter@chromium.org>
1680
1681         Add the Chromium Android Release (Perf) bot
1682         https://bugs.webkit.org/show_bug.cgi?id=103891
1683
1684         Reviewed by Eric Seidel.
1685
1686         Add configuration for the bot itself. It will be triggered by the Chromium
1687         Android Release builder. When running for Android, the DownloadAndPerfTest
1688         factory will also add the OutputAndroidDeviceStatus step.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/config.json:
1691         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1692         (DownloadAndPerfTestFactory.__init__):
1693
1694 2012-12-04  Peter Beverloo  <peter@chromium.org>
1695
1696         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1697         https://bugs.webkit.org/show_bug.cgi?id=103758
1698
1699         Reviewed by Eric Seidel.
1700
1701         Lazily initialize the adb command parameters rather than initializing it in the
1702         constructor now that there is an assert if adb is not available on the system and
1703         we're not in a Chromium Android checkout.
1704
1705         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1706         (ChromiumAndroidDriver.__init__):
1707         (ChromiumAndroidDriver._push_file_if_needed):
1708         (ChromiumAndroidDriver._run_adb_command):
1709         (ChromiumAndroidDriver.cmd_line):
1710         (ChromiumAndroidDriver._start_once):
1711         (ChromiumAndroidDriver._read_prompt):
1712         (ChromiumAndroidDriver):
1713         (ChromiumAndroidDriver._adb_command):
1714
1715 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1716
1717         Dromaeo should report individual test result
1718         https://bugs.webkit.org/show_bug.cgi?id=99800
1719
1720         Reviewed by Eric Seidel.
1721
1722         Ignore subtest results spit out by Dromaeo tests.
1723
1724         * Scripts/webkitpy/performance_tests/perftest.py:
1725         (PerfTest): Added a line to ignore.
1726         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1727         (MainTest.test_parse_output_with_subtests): Added.
1728
1729 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1730
1731         Unreviewed, functionality fix after r136437.
1732
1733         Calling sys.exit actually raises a SystemExit exception that
1734         is then handled in the second block and causes the script to
1735         return an 'exceptional' exit code rather than the code presenting
1736         the number of failed tests.
1737
1738         This is just a temporary fix to get the faultless bots green while
1739         they are unnecessarily red at the moment. The problem and a proper
1740         fix will be properly addressed.
1741
1742         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1743
1744 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1745
1746         Unreviewed, rolling out r136460.
1747         http://trac.webkit.org/changeset/136460
1748         https://bugs.webkit.org/show_bug.cgi?id=103958
1749
1750         This patch caused compile error when building DumpRenderTree
1751         (Requested by tasak on #webkit).
1752
1753         * Scripts/webkitpy/common/config/build_unittest.py:
1754         (ShouldBuildTest):
1755
1756 2012-12-03  Scott Violet  <sky@chromium.org>
1757
1758         [chromium] Remove linux theme related files and switch to default
1759         https://bugs.webkit.org/show_bug.cgi?id=103897
1760
1761         Reviewed by Darin Fisher.
1762
1763         * Scripts/webkitpy/common/config/build_unittest.py:
1764         (ShouldBuildTest): linux->default
1765
1766 2012-12-03  Roger Fong  <roger_fong@apple.com>
1767
1768         Disable WebKit2 API tests on Apple Windows port.
1769         https://bugs.webkit.org/show_bug.cgi?id=103929.
1770
1771         Reviewed by Timothy Horton.
1772
1773         * Scripts/run-api-tests:
1774         (runTestsBySuite):
1775
1776 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1777
1778         webkitpy's run_webkit_tests should initialize the printer earlier on
1779         https://bugs.webkit.org/show_bug.cgi?id=103661
1780
1781         Reviewed by Eric Seidel.
1782
1783         Initialize the printer before computing the derived options
1784         from the command line arguments, so that we can safely log from
1785         port methods.
1786
1787         Also clean up a few miscellaneous lint warnings.
1788
1789         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1790         (ChromiumAndroidPort.path_to_adb):
1791         * Scripts/webkitpy/layout_tests/port/mac.py:
1792         (MacPort.default_child_processes):
1793         (MacPort.sample_process):
1794         (MacPort.start_helper):
1795         (MacPort.stop_helper):
1796         (MacPort.nm_command):
1797         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1798         (test_default_child_processes):
1799         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1800         (run):
1801         (_set_up_derived_options):
1802
1803 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1804
1805         webkitpy: autoinstaller is failing on windows
1806         https://bugs.webkit.org/show_bug.cgi?id=103699
1807
1808         Reviewed by Tony Chang.
1809
1810         Attempt to fix the python autoinstaller to work for pylint on win32
1811         again ... it turns out one of the dependent packages contains
1812         a write-protected test file and windows will choke when it tries to move
1813         it into place. Fortunately we can just delete the file prior to
1814         installing it in the final location, but we have to jump through
1815         a couple of hoops to do so.
1816
1817         Also, make sure that we're flattening nested module names like
1818         "logilab/common" into either safe basenames (logilab_common) or
1819         host-specific subdirs (logilab\common) as needed.
1820
1821         * Scripts/webkitpy/common/system/autoinstall.py:
1822         (AutoInstaller._url_downloaded_path):
1823         (AutoInstaller._install):
1824         (AutoInstaller.install):
1825         * Scripts/webkitpy/thirdparty/__init__.py:
1826         (AutoinstallImportHook._install_pylint):
1827
1828 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1829
1830         nrwt: clean up exception propagation / handling for interrupts and early exits
1831         https://bugs.webkit.org/show_bug.cgi?id=103830
1832
1833         Reviewed by Ojan Vafai.
1834
1835         The code for propagating early exits out of the test run was
1836         convoluted and hard to follow. By adjusting the WorkerException to
1837         derive from BaseException rather than Exception (which is a fair
1838         way of representing an error that was really unexpected/unrecoverable
1839         anyway) and pushing the TestRunInterruptedException into the
1840         ResultSummary (which is also fair since it was more of a result
1841         than an exception) this allows us to consolidate and clean up
1842         a bunch of the try/catch logic and pass fewer state flags around.
1843
1844         There are no real functional changes to this patch; there's an
1845         API change in that we stop exporting TestRunInterruptedException
1846         and WorkerException out of the Manager, and the existence of the
1847         MessagePool is now completely hidden.
1848
1849         * Scripts/webkitpy/common/message_pool.py:
1850         (WorkerException):
1851         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1852         (LayoutTestRunner.run_tests):
1853         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1854         (summarize_results):
1855         (Manager.run):
1856         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1857         (ResultSummaryTest.summarized_results):
1858         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1859         (ResultSummary.__init__):
1860         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1861         (run):
1862         (main):
1863         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1864         (MainTest.test_exception_raised.of):
1865         (MainTest.test_exception_raised):
1866         (MainTest.test_run_force):
1867         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1868         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1869         (Testprinter):
1870
1871 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1872
1873         Add Qt/SH4 build slave to build.webkit.org
1874         https://bugs.webkit.org/show_bug.cgi?id=103384
1875
1876         Reviewed by Csaba Osztrogonác.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/config.json:
1879
1880 2012-12-03  Alexis Menard  <alexis@webkit.org>
1881
1882         Enable CSS3 background-position offset by default
1883         https://bugs.webkit.org/show_bug.cgi?id=103917
1884
1885         Reviewed by Benjamin Poulain.
1886
1887         Even though each port may enable or not the feature we still need
1888         to pass it at configure time otherwise it will be disabled.
1889
1890         * Scripts/webkitperl/FeatureList.pm:
1891
1892 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1893
1894         Unreviewed. Adding myself to committers.py.
1895
1896         * Scripts/webkitpy/common/config/committers.py:
1897
1898 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1899
1900         [CMake] Enable building WebKit2-only build for the EFL port
1901         https://bugs.webkit.org/show_bug.cgi?id=103820
1902
1903         Reviewed by Gyuyoung Kim.
1904
1905         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1906         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1907         cmake directly. Initialize $cmakeArgs to avoid potential
1908         warnings when running the script.
1909
1910         * Scripts/build-webkit:
1911
1912 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1913
1914         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1915         https://bugs.webkit.org/show_bug.cgi?id=103407
1916
1917         Reviewed by Kentaro Hara.
1918
1919         Changing the mock to use the new results delivery API.
1920
1921         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1922
1923 2012-12-03  Alexis Menard  <alexis@webkit.org>
1924
1925         [Qt] Enable CSS3 background-position offsets by default.
1926         https://bugs.webkit.org/show_bug.cgi?id=103877
1927
1928         Reviewed by Tor Arne Vestbø.
1929
1930         Enable by default CSS3 background-position offsets.
1931
1932         * qmake/mkspecs/features/features.pri:
1933
1934 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1935
1936         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1937         https://bugs.webkit.org/show_bug.cgi?id=103863
1938
1939         Reviewed by Gyuyoung Kim.
1940
1941         Use float instead of int for zoomLevels variables for a clearer expression
1942
1943         * MiniBrowser/efl/main.c:
1944         (on_key_down):
1945
1946 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1947
1948         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1949         https://bugs.webkit.org/show_bug.cgi?id=99285
1950
1951         Reviewed by Gyuyoung Kim.
1952
1953          Add support for a zoom level setting to MiniBrowser.
1954          Shortcuts for setting operations are same as common browsers:
1955          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
1956
1957         * MiniBrowser/efl/main.c:
1958         (on_key_down):
1959
1960 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1961
1962         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
1963         https://bugs.webkit.org/show_bug.cgi?id=103835
1964
1965         Reviewed by Kentaro Hara.
1966
1967         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
1968
1969         * MiniBrowser/efl/main.c:
1970         (elm_main):
1971
1972 2012-12-02  Mike West  <mkwst@chromium.org>
1973
1974         Garden-o-matic shouldn't die when blank JSON results are received.
1975         https://bugs.webkit.org/show_bug.cgi?id=103838
1976
1977         Reviewed by Adam Barth.
1978
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1980             If the JSONP string doesn't contain '(' or ')', return an empty object.
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1982             Check that this behavior stays in place.
1983
1984 2012-12-02  Eric Seidel  <eric@webkit.org>
1985
1986         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1987         https://bugs.webkit.org/show_bug.cgi?id=103765
1988
1989         Unreviewed.  Updating the unittests after my previous change.
1990
1991         * Scripts/webkitpy/common/system/profiler_unittest.py:
1992         (ProfilerFactoryTest.test_basic):
1993
1994 2012-12-02  Julie Parent  <jparent@chromium.org>
1995
1996         Remove dead code in flakiness dashboard for obsolete buildDir option
1997         https://bugs.webkit.org/show_bug.cgi?id=103792
1998
1999         Reviewed by Dirk Pranke.
2000
2001         * TestResultServer/static-dashboards/dashboard_base.js:
2002         (initBuilders):
2003
2004 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2005
2006         nrwt: clean up logic for retrying failed tests a bit
2007         https://bugs.webkit.org/show_bug.cgi?id=103829
2008
2009         Reviewed by Ojan Vafai.
2010
2011         The code for determining when to retry test failures and
2012         show the results.html file was awkward and could stand some
2013         cleaning up. This patch should have no functional changes.
2014
2015         The routine called _get_failures() returned a dict of test names
2016         to failure types, but we only ever used the names, so I've converted
2017         it to return a list (and renamed it); also, the show_results_html()
2018         file was calling that routine to figure out if anything failed, when
2019         the information was already in the result_summary (as either
2020         unexpected_results or total_failures), so we were doing unnecessary work.
2021
2022         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2023         (Manager.__init__):
2024         (Manager.run):
2025         (Manager._run_tests):
2026         (Manager._failed_test_names):
2027         (Manager._copy_results_html_file):
2028
2029 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2030
2031         nrwt: remove unused methods in manager.py
2032         https://bugs.webkit.org/show_bug.cgi?id=103828
2033
2034         Reviewed by Eric Seidel.
2035
2036         These two methods weren't being called by anything and were no
2037         longer needed.
2038
2039         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2040         (Manager._get_failures):
2041         (Manager._upload_json_files):
2042
2043 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
2044
2045         Correct the spelling of the cmakeargs argument
2046         https://bugs.webkit.org/show_bug.cgi?id=103814
2047
2048         Reviewed by Darin Adler.
2049
2050         The script expects cmakeargs (plural), so lets get the
2051         documentation of the script report the same.
2052
2053         * Scripts/build-webkit:
2054
2055 2012-12-02  Mike West  <mkwst@chromium.org>
2056
2057         [gtk] Enable the CSP_NEXT runtime flag.
2058         https://bugs.webkit.org/show_bug.cgi?id=103810
2059
2060         Reviewed by Adam Barth.
2061
2062         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2063         (resetDefaultsToConsistentValues):
2064             Turn on the CSP_NEXT runtime flag when running tests under GTK.
2065
2066 2012-12-02  Eric Seidel  <eric@webkit.org>
2067
2068         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2069         https://bugs.webkit.org/show_bug.cgi?id=103765
2070
2071         Reviewed by Ryosuke Niwa.
2072
2073         Stephanie pointed out that iprofiler is the newer command-line interface
2074         to replace /usr/bin/instruments in Instruments 4 (which according to the
2075         interblags is supported on everything since 10.6.6), so I've moved --profile
2076         to use iprofiler on Mac.
2077
2078         I also made the IProfiler class wait for iprofiler to complete so that
2079         iprofiler won't continue running after run-perf-tests is complete (and
2080         spam over the top of your shell output).
2081
2082         There are a couple of "got-chas" to this approach:
2083         1.  iprofiler will ask for your password the first time you run it, which may
2084             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
2085         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
2086             directory and basename arguments, making IProfiler a somewhat awkward
2087             baseclass of SingleFileOutputProfiler
2088
2089         I suspect we'll iterate from here.  It does seem slightly faster than
2090         /usr/bin/instruments was.
2091
2092         * Scripts/webkitpy/common/system/profiler.py:
2093         (ProfilerFactory.create_profiler):
2094         (IProfiler):
2095         (IProfiler.__init__):
2096         (IProfiler.attach_to_pid):
2097
2098 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2099
2100         Need a method to close all idle localstorage databases immediately.
2101         https://bugs.webkit.org/show_bug.cgi?id=103469
2102
2103         Reviewed by David Kilzer.
2104
2105         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
2106         DumpRenderTree layout tests.
2107
2108         * DumpRenderTree/TestRunner.cpp:
2109         (closeIdleLocalStorageDatabasesCallback):
2110         (TestRunner::staticFunctions):
2111         * DumpRenderTree/TestRunner.h:
2112         (TestRunner):
2113         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2114         (TestRunner::closeIdleLocalStorageDatabases):
2115         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2116         (TestRunner::closeIdleLocalStorageDatabases):
2117         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2118         (TestRunner::closeIdleLocalStorageDatabases):
2119         * DumpRenderTree/mac/TestRunnerMac.mm:
2120         (TestRunner::closeIdleLocalStorageDatabases):
2121         * DumpRenderTree/win/TestRunnerWin.cpp:
2122         (TestRunner::closeIdleLocalStorageDatabases):
2123         * DumpRenderTree/wx/TestRunnerWx.cpp:
2124         (TestRunner::closeIdleLocalStorageDatabases):
2125
2126 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
2127
2128         [EFL][WK2] MiniBrowser should have a legacy mode
2129         https://bugs.webkit.org/show_bug.cgi?id=103679
2130
2131         Reviewed by Kenneth Rohde Christiansen.
2132
2133         Add an option to start MiniBrowser in legacy mode.
2134
2135         * MiniBrowser/efl/main.c:
2136         (window_create):
2137         (elm_main):
2138
2139 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2140
2141         Unreviewed, rolling out r136236.
2142         http://trac.webkit.org/changeset/136236
2143         https://bugs.webkit.org/show_bug.cgi?id=103833
2144
2145         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
2146         during GC. (Requested by mkwst on #webkit).
2147
2148         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2149
2150 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2151
2152         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2153         https://bugs.webkit.org/show_bug.cgi?id=103806
2154
2155         Reviewed by Dirk Pranke.
2156
2157         There are occasional mishaps on builders where XvfbDriver doesn't properly
2158         clean up the Xvfb instance it was managing so the related guard lock files
2159         are still existing when the webkitpy unit tests are run. This can cause failures
2160         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2161         with a specific number but is unable to due to the stale locks.
2162
2163         The solution to this is to use MockFileLock when inside unit test. This is achievable
2164         by creating a file lock through the SystemHost instance connected to the Port object,
2165         the latter available to the Driver.
2166
2167         * Scripts/webkitpy/common/system/file_lock_mock.py:
2168         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2169         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2170         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2171         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2172         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2173         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2174
2175 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2176
2177         [GTK] A11y tests in WK2 report badly-formatted AX roles
2178         https://bugs.webkit.org/show_bug.cgi?id=102947
2179
2180         Reviewed by Xan Lopez.
2181
2182         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2183         These are expected in both tests and their baselines.
2184
2185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2186         (WTR::roleToString):
2187         (WTR):
2188         (WTR::AccessibilityUIElement::role):
2189
2190 2012-11-30  Mike West  <mkwst@chromium.org>
2191
2192         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2193         https://bugs.webkit.org/show_bug.cgi?id=103652
2194
2195         Reviewed by Adam Barth.
2196
2197         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2198
2199         * DumpRenderTree/chromium/TestShell.cpp:
2200         (TestShell::TestShell):
2201
2202 2012-11-30  Roger Fong  <roger_fong@apple.com>
2203
2204         Unreviewed. Removed temporary debugging change from DRT (r136300).
2205
2206         * DumpRenderTree/win/DumpRenderTree.cpp:
2207         (dump):
2208
2209 2012-11-30  Roger Fong  <roger_fong@apple.com>
2210
2211         Unreviewed. Temporary change to DRT for debugging purposes.
2212
2213         * DumpRenderTree/win/DumpRenderTree.cpp:
2214         (dump):
2215
2216 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2217
2218         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2219         https://bugs.webkit.org/show_bug.cgi?id=103407
2220
2221         Reviewed by Adam Barth.
2222
2223         Changing the mock to use the new results delivery API.
2224
2225         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2226
2227 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2228
2229         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2230         https://bugs.webkit.org/show_bug.cgi?id=99314
2231
2232         Reviewed by Tor Arne Vestbø.
2233
2234         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2235         shared libraries.
2236
2237         It's a big refactoring that mostly involves moving WebCore dependent
2238         code into QtWebKit and accessing it through exported QWebFrameAdapter
2239         and QWebPageAdapter classes.
2240
2241         * DumpRenderTree/qt/DumpRenderTree.pro:
2242         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2243         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2244         * MiniBrowser/qt/MiniBrowser.pro:
2245         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2246         * Scripts/webkitpy/style/checker_unittest.py:
2247         (GlobalVariablesTest.test_path_rules_specifier):
2248         * WebKitTestRunner/InjectedBundle/Target.pri:
2249         * qmake/mkspecs/features/default_post.prf:
2250         * qmake/mkspecs/features/webkit_modules.prf:
2251         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2252
2253 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2254
2255         [Qt] Unreviewed trivial fix.
2256
2257         Add empty.cpp back, it was removed accidentally by r129092.
2258
2259         * qmake/config.tests/gccdepends/empty.cpp: Added.
2260
2261 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2262
2263         [Qt] Add support for prepare_docs and generate_docs
2264
2265         Follow-up to changes in Qt in how documentation is built.
2266
2267         Reviewed by Simon Hausmann.
2268
2269         * qmake/mkspecs/features/default_post.prf:
2270
2271 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2272
2273         Finally remove webkitpy.common.system.deprecated_logging
2274         https://bugs.webkit.org/show_bug.cgi?id=103624
2275
2276         Reviewed by Adam Barth.
2277
2278         Remove the deprecated logging module and its unit tests now that such logging is not
2279         used anymore in webkitpy.
2280
2281         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2282         The tee class is renamed to Tee to conform with the usual guidelines.
2283
2284         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2285         using the webkitpy Filesystem abstraction that would make its functionality testable.
2286
2287         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2288         (Executive.run_and_throw_if_fail):
2289         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2290         (Tee):
2291         (Tee.__init__):
2292         (Tee.write):
2293         (OutputTee):
2294         (OutputTee.__init__):
2295         (OutputTee.add_log):
2296         (OutputTee.remove_log):
2297         (OutputTee._open_log_file):
2298         (OutputTee._tee_outputs_to_files):
2299         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2300         (SimpleTeeTest):
2301         (SimpleTeeTest.test_simple_tee):
2302         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2303         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2304
2305 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2306
2307         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2308         https://bugs.webkit.org/show_bug.cgi?id=103634
2309
2310         Reviewed by Gyuyoung Kim.
2311
2312         Add support for PlatformWebView::simulateRightClick() and enable
2313         WebKit2 API test HitTestResultNodeHandle.
2314
2315         * TestWebKitAPI/PlatformEfl.cmake:
2316         * TestWebKitAPI/efl/PlatformWebView.cpp:
2317         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2318         (TestWebKitAPI):
2319
2320 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2321
2322         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2323         https://bugs.webkit.org/show_bug.cgi?id=101192
2324
2325         Reviewed by Hajime Morita.
2326
2327         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2328
2329         Tests: No new tests because there is no functional change.
2330
2331         * DumpRenderTree/chromium/WebPreferences.cpp:
2332         (WebPreferences::applyTo):
2333
2334 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2335
2336         [HTMLTemplateElement] Add feature flag
2337         https://bugs.webkit.org/show_bug.cgi?id=103694
2338
2339         Reviewed by Adam Barth.
2340
2341         This flag will guard the implementation of the HTMLTemplateElement.
2342         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2343
2344         * Scripts/webkitperl/FeatureList.pm:
2345
2346 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2347
2348         Ignore errors when removing directories on win32 during autoinstall
2349         https://bugs.webkit.org/show_bug.cgi?id=103699
2350
2351         Unreviewed, build fix.
2352
2353         I think this will work on win32; if not, I'll have to actually
2354         reproduce this :). The problem is that the logilab files
2355         appear to contain a write-protected file, and deleting those
2356         is problematic on windows.
2357
2358         * Scripts/webkitpy/common/system/autoinstall.py:
2359         (AutoInstaller._install):
2360         (AutoInstaller.install):
2361
2362 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2363
2364         webkitpy: autoinstaller is failing on windows
2365         https://bugs.webkit.org/show_bug.cgi?id=103699
2366
2367         Unreviewed, build fix.
2368
2369         We're attempting to create directories with forward slashes in them;
2370         this is a no-no on windows.
2371
2372         * Scripts/webkitpy/common/system/autoinstall.py:
2373         (AutoInstaller._create_scratch_directory_inner):
2374
2375 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2376
2377         Fix python unit tests after r136158 (android port tests failing)
2378         https://bugs.webkit.org/show_bug.cgi?id=103581
2379
2380         Unreviewed, build fix.
2381
2382         The unit tests apparently weren't ran for this patch; we failed
2383         to update the mock executive calls out to adb to determine various
2384         aspects of the environment, and were failing to create drivers.
2385
2386         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2387         (MockRunCommand.mock_run_command_fn):
2388
2389 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2390
2391         Unreviewed, rolling out r136175 and r136177.
2392         http://trac.webkit.org/changeset/136175
2393         http://trac.webkit.org/changeset/136177
2394         https://bugs.webkit.org/show_bug.cgi?id=103683
2395
2396         Changes did not correct Windows build. (Requested by bfulgham
2397         on #webkit).
2398
2399         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2400
2401 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2402
2403         [Windows, WinCairo] Unreviewed build correction. Correct debug
2404         build case on build machine.
2405
2406         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2407
2408 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2409
2410         [Windows, WinCairo] Unreviewed build correction. Hide the
2411         unexported 'notSolidColor' symbol when testing against
2412         the BitmapImage class to avoid having to deal with a
2413         debug-only symbol in the Windows export definition file.
2414
2415         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
2416
2417 2012-11-29  Peter Beverloo  <peter@chromium.org>
2418
2419         run-perf-tests --chromium-android should not require adb in my path
2420         https://bugs.webkit.org/show_bug.cgi?id=103581
2421
2422         Reviewed by Eric Seidel.
2423
2424         Remove the need to have "adb" available in the path for Layout and Performance
2425         tests. We'll determine the versions of the "adb" version in path (if any) and
2426         the one provided in the Chromium Android checkout. Unless the "adb" available
2427         in the path is newer, the provided version will be used.
2428
2429         Some other minor nits addressed:
2430         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
2431           section, as they're not overriding anything and are used by the driver.
2432         - Make _restart_adb_as_root slightly more robust by waiting for the device
2433           to come back online regardless of the output.
2434
2435         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2436         (ChromiumAndroidPort.__init__):
2437         (ChromiumAndroidPort.check_build):
2438         (ChromiumAndroidPort.path_to_adb):
2439         (ChromiumAndroidPort):
2440         (ChromiumAndroidPort.path_to_forwarder):
2441         (ChromiumAndroidPort.path_to_md5sum):
2442         (ChromiumAndroidPort._path_to_helper):
2443         (ChromiumAndroidPort._determine_adb_version):
2444         (ChromiumAndroidPort._get_devices):
2445         (ChromiumAndroidDriver.__init__):
2446         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2447         (ChromiumAndroidDriver._push_executable):
2448         (ChromiumAndroidDriver._restart_adb_as_root):
2449
2450 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
2451
2452         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
2453         https://bugs.webkit.org/show_bug.cgi?id=103277
2454
2455         Reviewed by Carlos Garcia Campos.
2456
2457         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
2458         during gtkdoc generation.
2459
2460         * gtk/generate-gtkdoc:
2461         (get_webkit2_options):
2462
2463 2012-11-29  Eric Seidel  <eric@webkit.org>
2464
2465         run-perf-tests --chromium-android fails due to Skia INFO logging
2466         https://bugs.webkit.org/show_bug.cgi?id=103585
2467
2468         Reviewed by Adam Barth.
2469
2470         Ignore all INFO logging from Chromium code.
2471         Also added some basic testing of the ignored-stderr lines code.
2472
2473         * Scripts/webkitpy/performance_tests/perftest.py:
2474         (PerfTest):
2475         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2476         (MainTest.test_ignored_stderr_lines):
2477
2478 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2479
2480         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
2481         https://bugs.webkit.org/show_bug.cgi?id=103252
2482
2483         Reviewed by Kenneth Rohde Christiansen.
2484
2485         Add support for PlatformWebView::simulateMouseMove() and enable
2486         WebKit2 API test MouseMoveAfterCrash.
2487
2488         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
2489         test.
2490         * TestWebKitAPI/efl/PlatformWebView.cpp:
2491         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
2492         to prevent loading an error page since the test case is reloading actual
2493         page after web process has terminated and recovered.
2494         (TestWebKitAPI):
2495         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2496         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
2497
2498 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
2499
2500         [Qt] Fix installation of QtWebProcess binary
2501         https://bugs.webkit.org/show_bug.cgi?id=101735
2502
2503         Reviewed by Simon Hausmann.
2504
2505         Add config test to detect the availability of support
2506         for "program executables" in Qt (libexec).
2507
2508         This test can be removed after the Qt5 release.
2509
2510         * Tools.pro:
2511         * qmake/mkspecs/features/features.prf:
2512         * qmake/config.tests/libexecdir/libexecdir.cpp:
2513         * qmake/config.tests/libexecdir/libexecdir.pro:
2514
2515 2012-11-29  Eric Seidel  <eric@webkit.org>
2516
2517         run-perf-tests does not work when the layout test directory does not exist
2518         https://bugs.webkit.org/show_bug.cgi?id=103572
2519
2520         Reviewed by Ryosuke Niwa.
2521
2522         Make sure that Profiler() calls maybe_make_directory for the output_dir
2523         before ever using it.  It's a little awkward to create the directory
2524         from the constructor, but its simplest that way as the various subclasses
2525         all use the directory at different times.
2526
2527         Since this required having a filesystem in Profiler (and I didn't want
2528         to grab inside Workspace to get one), I just made Profiler expect a
2529         SystemHost instead of a separate filesystem, executive and workspace.
2530
2531         * Scripts/webkitpy/common/system/profiler.py:
2532         (ProfilerFactory.create_profiler):
2533         (Profiler.__init__):
2534         (SingleFileOutputProfiler.__init__):
2535         (GooglePProf.__init__):
2536         (GooglePProf.profile_after_exit):
2537         (Instruments.__init__):
2538         (Instruments.attach_to_pid):
2539         * Scripts/webkitpy/common/system/profiler_unittest.py:
2540         (ProfilerFactoryTest.test_basic):
2541
2542 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
2543
2544         Adding secondary email id
2545         https://bugs.webkit.org/show_bug.cgi?id=103594
2546
2547         Unreviewed. Adding secondary email.
2548
2549         * Scripts/webkitpy/common/config/committers.py:
2550
2551 2012-11-28  Kent Tamura  <tkent@chromium.org>
2552
2553         garden-o-matic: Use indeterminate <progress> in the status area
2554         https://bugs.webkit.org/show_bug.cgi?id=103494
2555
2556         Reviewed by Adam Barth.
2557
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2559         Wrap the "Processing..." message with an indeterminate progress bar.
2560         We keep the message as a fallback content.
2561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2562         Follow the above change.
2563
2564 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
2565
2566         Adding Nima Ghanavatian to committers.py
2567         https://bugs.webkit.org/show_bug.cgi?id=103533
2568
2569         Reviewed by Rob Buis.
2570
2571         Adding myself to committers.py as a Committer.
2572
2573         * Scripts/webkitpy/common/config/committers.py:
2574
2575 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
2576
2577         [WinCairo] Crash when requesting favicon.
2578         https://bugs.webkit.org/show_bug.cgi?id=102689
2579
2580         Reviewed by Brent Fulgham.
2581
2582         * TestWebKitAPI/Tests/WebCore/win: Added.
2583         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2584         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2585         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2586         (TestWebKitAPI::TEST): Added new test.
2587         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2588        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2589
2590 2012-11-28  Eric Seidel  <eric@webkit.org>
2591
2592         run-perf-tests should have a --profile option for easy profiling
2593         https://bugs.webkit.org/show_bug.cgi?id=99517
2594
2595         Reviewed by Adam Barth.
2596
2597         This is a very basic implementation which works on Mac and Linux
2598         and makes it trivial for anyone to profile a PerformanceTest.
2599
2600         Currently it's not "hard" to profile a PerformanceTest
2601         but lowering the barriers to entry here allows all of us to focus
2602         less on the tools and more on the code.
2603
2604         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2605         which is actually "hard", and this option will make much easier.
2606
2607         * Scripts/webkitpy/common/system/profiler.py: Added.
2608         (ProfilerFactory):
2609         (ProfilerFactory.create_profiler):
2610         (Profiler):
2611         (Profiler.__init__):
2612         (Profiler.adjusted_environment):
2613         (Profiler.attach_to_pid):
2614         (Profiler.did_stop):
2615         (SingleFileOutputProfiler):
2616         (SingleFileOutputProfiler.__init__):
2617         (GooglePProf):
2618         (GooglePProf.__init__):
2619         (GooglePProf.adjusted_environment):
2620         (GooglePProf.did_stop):
2621         (Instruments):
2622         (Instruments.__init__):
2623         (Instruments.attach_to_pid):
2624         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2625         (ProfilerFactoryTest):
2626         (ProfilerFactoryTest.test_basic):
2627         * Scripts/webkitpy/layout_tests/port/driver.py:
2628         (Driver.__init__):
2629         (Driver._start):
2630         (Driver.stop):
2631         (Driver.cmd_line):
2632         * Scripts/webkitpy/performance_tests/perftest.py:
2633         (PerfTest.parse_output):
2634         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2635         (MainTest.test_parse_output):
2636         (MainTest.test_parse_output_with_failing_line):
2637         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2638         (PerfTestsRunner._parse_args):
2639         (PerfTestsRunner.run):
2640
2641 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2642
2643         Remove deprecated logging usage from QueueEngine
2644         https://bugs.webkit.org/show_bug.cgi?id=103532
2645
2646         Reviewed by Dirk Pranke.
2647
2648         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2649         logging through the Logger object. The unit test is modified to reflect
2650         these changes.
2651
2652         After these changes the deprecated logging (i.e. logging to stderr) is not
2653         used anymore through webkitpy and can be removed.
2654
2655         * Scripts/webkitpy/tool/bot/queueengine.py:
2656         (QueueEngine.exit_after_handled_error):
2657         (QueueEngine.run):
2658         (QueueEngine._stopping):
2659         (QueueEngine._sleep):
2660         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2661         (QueueEngineTest._run_engine):
2662
2663 2012-11-28  Nate Chapin  <japhet@chromium.org>
2664
2665         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2666         https://bugs.webkit.org/show_bug.cgi?id=101512
2667
2668         Reviewed by Adam Barth.
2669
2670         * DumpRenderTree/chromium/WebViewHost.cpp:
2671         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2672             interprets them as a non-empty load. This change is required for
2673              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2674         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2675              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2676         (TestWebKitAPI::didFinishLoadForFrame):
2677         (TestWebKitAPI::TEST):
2678
2679 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2680
2681         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2682         https://bugs.webkit.org/show_bug.cgi?id=103092
2683
2684         Reviewed by Tony Chang.
2685
2686         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2687         from touch events.
2688
2689         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2690         (parseTouchEventRequestType):
2691         (TestWebPlugin::TestWebPlugin):
2692         (TestWebPlugin::initialize):
2693         * DumpRenderTree/chromium/TestWebPlugin.h:
2694         (TestWebPlugin):
2695
2696 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2697
2698         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2699         https://bugs.webkit.org/show_bug.cgi?id=103123
2700
2701         Reviewed by Laszlo Gombos.
2702
2703         Add support for PlatformWebView::simulateSpacebarKeyPress().
2704         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2705         which is going to be unskipped in bug #103252.
2706
2707         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2708         (TestWebKitAPI::Util::sleep):
2709         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2710         sleep().
2711         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2712         (TestWebKitAPI):
2713
2714 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2715
2716         Minor cleanup in TestInvocation
2717         https://bugs.webkit.org/show_bug.cgi?id=103512
2718
2719         Reviewed by Kenneth Rohde Christiansen.
2720
2721         Remove a function declaration that is not defined and not used.
2722         Fix spelling error in m_webProcessIsUnresponsive.
2723
2724         * WebKitTestRunner/TestInvocation.cpp:
2725         (WTR::TestInvocation::TestInvocation):
2726         (WTR::TestInvocation::invoke):
2727         * WebKitTestRunner/TestInvocation.h:
2728         (TestInvocation):
2729         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2730         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2731         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2732         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2733
2734 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2735
2736         Unreviewed. Use my personal email as bugzilla email.
2737
2738         * Scripts/webkitpy/common/config/committers.py:
2739
2740 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2741
2742         Unreviewed. Adding myself to committers.py.
2743
2744         * Scripts/webkitpy/common/config/committers.py:
2745
2746 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2747
2748         Unreviewed. Adding myself to committers.py.
2749
2750         * Scripts/webkitpy/common/config/committers.py:
2751
2752 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2753
2754         Add basic implementation for MediaStreamAudioDestinationNode
2755         https://bugs.webkit.org/show_bug.cgi?id=101815
2756
2757         Reviewed by Chris Rogers.
2758
2759         Adds a bit of code that exercises the WebKit API.
2760
2761         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2762         (MockWebMediaStreamSourceConsumer):
2763         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2764         (MockWebMediaStreamCenter::didCreateMediaStream):
2765
2766 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2767
2768         Unreviewed. Adding myself to committers list.
2769
2770         * Scripts/webkitpy/common/config/committers.py:
2771
2772 2012-11-27  Li Yin  <li.yin@intel.com>
2773
2774         Unreviewed. Adding myself to committers list.
2775
2776         * Scripts/webkitpy/common/config/committers.py:
2777
2778 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2779
2780         Unreviewed. Adding myself to committers.py.
2781
2782         * Scripts/webkitpy/common/config/committers.py:
2783
2784 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2785
2786         Unreviewd. Adding myself to committers list.
2787
2788         * Scripts/webkitpy/common/config/committers.py:
2789
2790 2012-11-27  Tony Chang  <tony@chromium.org>
2791
2792         Bring back partytime!
2793         https://bugs.webkit.org/show_bug.cgi?id=103466
2794
2795         Reviewed by Adam Barth.
2796
2797         "code 404, message Unknown function images/partytime_gif" since we didn't
2798         allow .gif or .png files to be served.
2799
2800         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2801         (GardeningHTTPRequestHandler):
2802
2803 2012-11-27  Adam Barth  <abarth@webkit.org>
2804
2805         run-perf-tests fails on Android because of stderr output
2806         https://bugs.webkit.org/show_bug.cgi?id=103462
2807
2808         Reviewed by Ryosuke Niwa.
2809
2810         The chromium-android port produces some stderr output that causes
2811         run-perf-tests to get sad and not record the results of the performance
2812         test. This patch teaches run-perf-test to ignore this output much in
2813         the same way that it currently ignores some stdout messages.
2814
2815         * Scripts/webkitpy/performance_tests/perftest.py:
2816         (PerfTest.run):
2817         (PerfTest._should_ignore_line):
2818         (PerfTest):
2819         (PerfTest._should_ignore_line_in_stderr):
2820         (PerfTest._filter_stderr):
2821         (PerfTest._should_ignore_line_in_parser_test_result):
2822
2823 2012-11-27  Tony Chang  <tony@chromium.org>
2824
2825         Fix garden-o-matic for non-chromium ports
2826         https://bugs.webkit.org/show_bug.cgi?id=103458
2827
2828         Reviewed by Adam Barth.
2829
2830         I was getting a 403 error when trying to select any non-chromium port.
2831
2832         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2833         (ReflectionHandler._handle_request): Use the path without query params.
2834
2835 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2836
2837         [EFL][WK2] 3D pixel tests are failing
2838         https://bugs.webkit.org/show_bug.cgi?id=102833
2839
2840         Reviewed by Kenneth Rohde Christiansen.
2841
2842         Generate a snapshot of the view in the UI process instead of the web process.
2843         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2844
2845         * WebKitTestRunner/TestInvocation.h:
2846         (TestInvocation):
2847         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2848         (WTR::writeFunction):
2849         (WTR::paintRepaintRectOverlay):
2850         (WTR):
2851         (WTR::TestInvocation::forceRepaintDoneCallback):
2852         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2853         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2854         (WTR::PlatformWebView::windowSnapshotImage):
2855
2856 2012-11-27  Adam Barth  <abarth@webkit.org>
2857
2858         Make it possible to run performance tests on Chromium Android
2859         https://bugs.webkit.org/show_bug.cgi?id=103268
2860
2861         Reviewed by Ryosuke Niwa.
2862
2863         Based on a patch by Peter Beverloo.
2864
2865         This patch (almost) makes it possible to run WebKit performance tests
2866         on the Chromium port for Android. There are a few things I had to do
2867         in order to make this happen:
2868
2869         1) The worker number when creating a driver for a port is zero-based
2870            for layout tests and elsewhere. Android uses this to determine
2871            which device it has to run on, so make it zero based for performance
2872            tests as well.
2873
2874         2) Tests aren't available on the Android device, so we start an HTTP
2875            server that serves the tests to the device or emulator.
2876
2877         The one shortcoming of this patch is that chromium-android produces
2878         some stderr output that confuses run-perf-tests. I'll address that
2879         issue in a subsequent CL. This patch also depends on
2880         https://codereview.chromium.org/11416182 in order to work.
2881
2882         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2883         (ChromiumAndroidPort.start_http_server):
2884         (ChromiumAndroidDriver._command_from_driver_input):
2885         * Scripts/webkitpy/performance_tests/perftest.py:
2886         (ReplayPerfTest.prepare):
2887         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2888         (PerfTestsRunner.__init__):
2889         (PerfTestsRunner._parse_args):
2890         (PerfTestsRunner._start_servers):
2891         (PerfTestsRunner):
2892         (PerfTestsRunner._stop_servers):
2893         (PerfTestsRunner.run):
2894         (PerfTestsRunner._run_tests_set):
2895
2896 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2897
2898         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2899         https://bugs.webkit.org/show_bug.cgi?id=103408
2900
2901         Reviewed by Dirk Pranke.
2902
2903         Remove the use of the deprecated log and error methods by replacing them with
2904         logging through Python's logging.Logger objects.
2905
2906         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2907         updates any affected unit test.
2908
2909         * Scripts/webkitpy/common/checkout/changelog.py:
2910         (ChangeLogEntry._parse_entry):
2911         * Scripts/webkitpy/common/checkout/checkout.py:
2912         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2913         (CheckoutTest.test_apply_patch):
2914         * Scripts/webkitpy/common/checkout/deps_mock.py:
2915         (MockDEPS.write_variable):
2916         * Scripts/webkitpy/common/checkout/scm/detection.py:
2917         (SCMDetector.default_scm):
2918         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2919         (SCMDetectorTest.test_detect_scm_system):
2920         * Scripts/webkitpy/common/checkout/scm/git.py:
2921         (Git._check_git_architecture):
2922         (Git._commit_on_branch):
2923         * Scripts/webkitpy/common/checkout/scm/scm.py:
2924         (SCM.ensure_clean_working_directory):
2925         (SCM.ensure_no_local_commits):
2926         (SCM.will.commit_locally_with_message):
2927         * Scripts/webkitpy/common/checkout/scm/svn.py:
2928         (SVN.apply_reverse_diff):
2929         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2930         (Attachment._validate_flag_value):
2931         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2932         (Bugzilla._fetch_bug_page):
2933         (Bugzilla.bug_id_for_attachment_id):
2934         (Bugzilla.authenticate):
2935         (Bugzilla._commit_queue_flag):
2936         (Bugzilla.add_attachment_to_bug):
2937         (Bugzilla.add_patch_to_bug):
2938         (Bugzilla.create_bug):
2939         (Bugzilla.clear_attachment_flags):
2940         (Bugzilla.set_flag_on_attachment):
2941         (Bugzilla.obsolete_attachment):
2942         (Bugzilla.add_cc_to_bug):
2943         (Bugzilla.post_comment_to_bug):
2944         (Bugzilla.close_bug_as_fixed):
2945         (Bugzilla.reassign_bug):
2946         (reopen_bug):
2947         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2948         (MockBugzilla.create_bug):
2949         (MockBugzilla.reassign_bug):
2950         (MockBugzilla.set_flag_on_attachment):
2951         (MockBugzilla.post_comment_to_bug):
2952         (MockBugzilla.add_attachment_to_bug):
2953         (MockBugzilla.add_patch_to_bug):
2954         (MockBugzilla.reopen_bug):
2955         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2956         (test_add_cc_to_bug):
2957         (_assert_reopen):
2958         (test_reopen_bug):
2959         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2960         (MockBuilder.force_build):
2961         * Scripts/webkitpy/common/net/credentials.py:
2962         (Credentials._run_security_tool):
2963         * Scripts/webkitpy/common/net/credentials_unittest.py:
2964         (_assert_security_call):
2965         * Scripts/webkitpy/common/net/irc/irc_mock.py:
2966         (MockIRC.post):
2967         (MockIRC.disconnect):
2968         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2969         (IRCProxy.__init__):
2970         (IRCProxy.disconnect):
2971         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2972         (IRCProxyTest.test_trivial):
2973         * Scripts/webkitpy/common/net/layouttestresults.py:
2974         (ORWTResultsHTMLParser._failures_from_fail_row):
2975         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2976         (test_failures_from_fail_row):
2977         * Scripts/webkitpy/common/net/networktransaction.py:
2978         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2979         (JSONTestResult._tokenize):
2980         (JSONTestResult._failure_types_from_actual_result):
2981         * Scripts/webkitpy/common/net/statusserver.py:
2982         (StatusServer.update_status):
2983         (StatusServer.update_svn_revision):
2984         * Scripts/webkitpy/common/net/statusserver_mock.py:
2985         (MockStatusServer.release_work_item):
2986         (MockStatusServer.update_work_items):
2987         (MockStatusServer.submit_to_ews):
2988         (MockStatusServer.update_status):
2989         * Scripts/webkitpy/common/net/unittestresults.py:
2990         (UnitTestResults.results_from_string):
2991         * Scripts/webkitpy/common/system/executive_mock.py:
2992         (MockExecutive.running_pids):
2993         (MockExecutive.run_and_throw_if_fail):
2994         (MockExecutive.run_command):
2995         (MockExecutive.popen):
2996         * Scripts/webkitpy/common/system/user_mock.py:
2997         (MockUser.confirm):
2998         (MockUser.open_url):
2999         * Scripts/webkitpy/common/system/workspace_unittest.py:
3000         (WorkspaceTest.test_create_zip):
3001         (WorkspaceTest.test_create_zip_exception):
3002         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
3003         (MockWatchList.determine_cc_and_messages):
3004         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3005         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3006         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3007         (EflPortTest.test_show_results_html_file):
3008         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3009         (GtkPortTest.test_show_results_html_file):
3010         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3011         (test_show_results_html_file):
3012         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3013         (test_build_driver):
3014         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3015         (QtPortTest.test_show_results_html_file):
3016         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3017         (WinPortTest.test_show_results_html_file):
3018         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3019         (XvfbDriverTest.assertDriverStartSuccessful):
3020         (XvfbDriverTest.test_start_no_pixel_tests):
3021         (XvfbDriverTest.test_start_pixel_tests):
3022         (XvfbDriverTest.test_start_arbitrary_worker_number):
3023         (XvfbDriverTest.test_start_next_worker):
3024         (XvfbDriverTest.test_stop):
3025         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3026         (TestLayoutTestApacheHttpd.test_start_cmd):
3027         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3028         (test_run_test_pause_before_testing):
3029         (test_run_memory_test):
3030         (_test_run_with_json_output):
3031         (test_run_respects_no_results):
3032         (test_run_generates_and_show_results_page):
3033         (test_run_respects_no_show_results):
3034         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3035         (FeedersTest.test_commit_queue_feeder):
3036         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3037         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
3038         (test_report_flaky_tests_creating_bug):
3039         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3040         (IRCCommandTest.test_rollout_updates_working_copy):
3041         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3042         (IRCBotTest.test_exception_during_command):
3043         (IRCBotTest.test_hi):
3044         (IRCBotTest.test_help):
3045         (IRCBotTest.test_restart):
3046         (IRCBotTest.test_rollout):
3047         (IRCBotTest.test_revert):
3048         (IRCBotTest.test_roll_chromium_deps):
3049         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3050         (IRCBotTest.test_multi_rollout):
3051         (IRCBotTest.test_rollout_with_r_in_svn_revision):
3052         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
3053         (IRCBotTest.test_rollout_bananas):
3054         (IRCBotTest.test_rollout_invalidate_revision):
3055         (IRCBotTest.test_rollout_invalidate_reason):
3056         (test_multi_rollout_invalidate_reason):
3057         (test_rollout_no_reason):
3058         (test_multi_rollout_no_reason):
3059         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3060         (SheriffTest.test_post_blame_comment_on_bug):
3061         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3062         (ApplyWatchListLocalTest.test_args_parsing):
3063         (test_args_parsing_with_bug):
3064         * Scripts/webkitpy/tool/commands/download_unittest.py:
3065         (test_land_cowboy):
3066         (test_check_style):
3067         (test_create_rollout):
3068         (test_create_rollout_resolved):
3069         (test_rollout):
3070         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3071         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3072         (EarlyWarningSytemTest._default_expected_logs):
3073         (EarlyWarningSytemTest._test_builder_ews):
3074         (EarlyWarningSytemTest._test_testing_ews):
3075         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3076         (OpenBugsTest.test_args_parsing):
3077         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3078         (QueryCommandsTest.test_bugs_to_commit):
3079         (QueryCommandsTest.test_patches_in_commit_queue):
3080         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3081         (FeederQueueTest.test_feeder_queue):
3082         (AbstractPatchQueueTest.test_next_patch):
3083         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
3084         (CommitQueueTest.test_commit_queue):
3085         (test_commit_queue_failure):
3086         (test_commit_queue_failure_with_failing_tests):
3087         (test_rollout):
3088         (test_rollout_lands):
3089         (test_auto_retry):
3090         (test_manual_reject_during_processing):
3091         (test_report_flaky_tests):
3092         (StyleQueueTest.test_style_queue_with_style_exception):
3093         (test_style_queue_with_watch_list_exception):
3094         * Scripts/webkitpy/tool/commands/queuestest.py:
3095         (QueuesTest._default_begin_work_queue_logs):
3096         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3097         (RollCommandsTest.test_update_chromium_deps):
3098         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3099         (UploadCommandsTest.test_assign_to_committer):
3100         (test_post):
3101         (test_attach_to_bug):
3102         (test_attach_to_bug_no_description_or_comment):
3103         (test_land_safely):
3104         (test_prepare):
3105         (test_upload):
3106         (test_mark_bug_fixed):
3107         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3108         (ApplyWatchListTest.test_apply_watch_list_local):
3109         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3110         (CommitTest._test_check_test_expectations):
3111         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3112         (RunTestsTest.test_webkit_run_unit_tests):
3113         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3114         (StepsTest._assert_step_output_with_bug):
3115         (StepsTest._assert_post_diff_output_for_bug):
3116         (StepsTest.test_post_diff):
3117         (StepsTest.test_post_diff_for_commit):
3118         (StepsTest.test_ensure_bug_is_open_and_assigned):
3119         (StepsTest.test_runtests_args):
3120         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3121         (SuggestReviewersTest.test_basic):
3122         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3123         (ValidateChangeLogsTest._assert_start_line_produces_output):
3124
3125 2012-11-27  Pratik Solanki  <psolanki@apple.com>
3126
3127         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
3128         https://bugs.webkit.org/show_bug.cgi?id=101780
3129
3130         Reviewed by Brent Fulgham.
3131
3132         Clean up header includes so we don't include objc/objc-runtime.h.
3133
3134         * DumpRenderTree/mac/DumpRenderTree.mm:
3135         * DumpRenderTree/mac/ObjCPlugin.m:
3136         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
3137         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3138
3139 2012-11-27  Marja Hölttä  <marja@chromium.org>
3140
3141         Add callbacks to the FrameLoaderClient when a resource is requested
3142         https://bugs.webkit.org/show_bug.cgi?id=92761
3143
3144         Reviewed by Adam Barth.
3145
3146         In Chromium, when an extension script cancels a network
3147         request (which happens out of process), we'd like to
3148         notify content scripts running on the current page about
3149         which elements failed to load because the requests were
3150         cancelled (as opposed to e.g. the network request just
3151         didn't work). Since the resource request itself does not
3152         carry any information what DOM element is was made for,
3153         currently a content script has to search the DOM tree and
3154         guess which requests will be cancelled by its counter
3155         part. By adding these callbacks, the embedder can make
3156         this connection explictly.
3157
3158         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3159         (DRTTestRunner::DRTTestRunner):
3160         (DRTTestRunner::dumpResourceRequestCallbacks):
3161         (DRTTestRunner::reset):
3162         * DumpRenderTree/chromium/DRTTestRunner.h:
3163         (DRTTestRunner):
3164         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
3165         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
3166         * DumpRenderTree/chromium/TestShell.h:
3167         (TestShell::shouldDumpResourceRequestCallbacks):
3168         * DumpRenderTree/chromium/WebViewHost.cpp:
3169         (WebViewHost::willRequestResource):
3170         * DumpRenderTree/chromium/WebViewHost.h:
3171         (WebViewHost):
3172
3173 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3174
3175         [GStreamer] Verify if GStreamer was previously initialized
3176         https://bugs.webkit.org/show_bug.cgi?id=103151
3177
3178         Reviewed by Philippe Normand.
3179
3180         This patch adds the gst_init() in GtkLauncher, so we can add the
3181         GStreamer options in the command line through
3182         gst_init_get_option_group().
3183
3184         This approach is not valid for MiniBrowser because it uses WebKit2,
3185         where the GStreamer backend lives in the web process, which is
3186         different from the UI process.
3187
3188         * GNUmakefile.am:
3189         * GtkLauncher/main.c:
3190         (main):
3191
3192 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
3193
3194         [Qt] Fix the build with new Qt5 hash
3195         https://bugs.webkit.org/show_bug.cgi?id=103406
3196
3197         Reviewed by Csaba Osztrogonác.
3198
3199         Remove references to deprecated QApplication::GuiServer which
3200         has been removed, and use QStyleFactory::create instead of
3201         instantiating a QWindowsStyle directly since it is about to
3202         become an internal class.
3203
3204         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3205         (main):
3206         * QtTestBrowser/qttestbrowser.cpp:
3207         (LauncherApplication::LauncherApplication):
3208         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3209         (WTR::InjectedBundle::platformInitialize):
3210
3211 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3212
3213         [style] Add a style-check for enum-member names
3214         https://bugs.webkit.org/show_bug.cgi?id=103157
3215
3216         Reviewed by Daniel Bates.
3217
3218         * Scripts/webkitpy/style/checkers/cpp.py:
3219         (_EnumState):
3220         (_EnumState.__init__):
3221         (_EnumState.process_clean_line):
3222         (check_enum_casing):
3223         (check_style):
3224         (process_line):
3225         (_process_lines):
3226         (CppChecker):
3227         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3228         (NoNonVirtualDestructorsTest.test_enum_casing):
3229         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
3230
3231 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
3232
3233         [EFL][jhbuild] Disable unnecessary options of elementary module
3234         https://bugs.webkit.org/show_bug.cgi?id=103360
3235
3236         Reviewed by Gyuyoung Kim.
3237
3238         When jhbuild configures elementary, unnecessary options may be enabled by
3239         user installed modules and it causes build break.
3240
3241         * efl/jhbuild.modules:
3242         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
3243
3244 2012-11-26  Varun Jain  <varunjain@chromium.org>
3245
3246         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
3247         https://bugs.webkit.org/show_bug.cgi?id=101545
3248
3249         Reviewed by Antonio Gomes.
3250
3251         For LongPress, we simulate drag by sending a mouse down and mouse drag
3252         events. If a drag is not started (because maybe there is no draggable
3253         element), then we show context menu instead (which is the current
3254         behavior for LongPress). For LongTap, we use the existing functions that
3255         LongPress uses to summon the context menu. LongPress initiated drag and
3256         drop can be enabled/disabled by the platform using the Setting
3257         touchDragDropEnabled which is disabled by default.
3258
3259         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3260         (WebTestRunner):
3261         (WebTestRunner::EventSender::EventSender):
3262         (WebTestRunner::EventSender::gestureLongTap):
3263         (WebTestRunner::EventSender::gestureEvent):
3264         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3265         (EventSender):
3266         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3267         (WebTestRunner::TestRunner::TestRunner):
3268         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3269         (WebTestRunner):
3270         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3271         (TestRunner):
3272
3273 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
3274
3275         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
3276         https://bugs.webkit.org/show_bug.cgi?id=103224
3277
3278         Reviewed by Laszlo Gombos.
3279
3280         Add --local-storage command line argument to MiniBrowser to
3281         explicitely disable HTML5 local storage functionality. This
3282         is useful for testing purposes.
3283
3284         * MiniBrowser/efl/main.c:
3285         (window_create):
3286         (elm_main):
3287
3288 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3289
3290         Remove use of deprecated logging from most of webkitpy.tool
3291         https://bugs.webkit.org/show_bug.cgi?id=103180
3292
3293         Reviewed by Dirk Pranke.
3294
3295         Remove calls to log and error methods of the deprecated_logging module, replacing them
3296         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
3297         except the QueueEngine.
3298
3299         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
3300
3301         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3302         (MockCommitQueue.run_command):
3303         (MockCommitQueue.command_passed):
3304         (MockCommitQueue.command_failed):
3305         (MockCommitQueue.report_flaky_tests):
3306         (MockCommitQueue.archive_last_test_results):
3307         (CommitQueueTaskTest._run_through_task):
3308         (CommitQueueTaskTest.test_success_case):
3309         (test_fast_success_case):
3310         (test_clean_failure):
3311         (test_update_failure):
3312         (test_apply_failure):
3313         (test_validate_changelog_failure):
3314         (test_build_failure):
3315         (test_red_build_failure):
3316         (test_flaky_test_failure):
3317         (test_failed_archive):
3318         (test_double_flaky_test_failure):
3319         (test_test_failure):
3320         (test_red_test_failure):
3321         (test_very_red_tree_retry):
3322         (test_red_tree_patch_rejection):
3323         (test_land_failure):
3324         * Scripts/webkitpy/tool/bot/feeders.py:
3325         (CommitQueueFeeder._update_work_items):
3326         (EWSFeeder.feed):
3327         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3328         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3329         (LayoutTestResultsReader.archive):
3330         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3331         (test_archive_last_layout_test_results):
3332         * Scripts/webkitpy/tool/bot/sheriff.py:
3333         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3334         (AbstractSequencedCommand.execute):
3335         * Scripts/webkitpy/tool/commands/commandtest.py:
3336         (CommandsTest.assert_execute_outputs):
3337         * Scripts/webkitpy/tool/commands/download.py:
3338         (AbstractPatchProcessingCommand._process_patch.execute):
3339         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3340         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3341         (AbstractRolloutPrepCommand._commit_info):
3342         * Scripts/webkitpy/tool/commands/download_unittest.py:
3343         (AbstractRolloutPrepCommandTest.test_commit_info):
3344         (DownloadCommandsTest.test_build):
3345         (DownloadCommandsTest.test_build_and_test):
3346         (test_apply_attachment):
3347         (test_apply_from_bug):
3348         (test_apply_watch_list):
3349         (test_land):
3350         (test_land_red_builders):
3351         (test_check_style):
3352         (test_build_attachment):
3353         (test_land_attachment):
3354         (test_land_from_bug):
3355         (test_land_from_url):
3356         (test_prepare_rollout):
3357         (test_create_rollout):
3358         (test_create_rollout_resolved):
3359         (test_rollout):
3360         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3361         (AbstractEarlyWarningSystem.handle_script_error.does):
3362         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3363         (EarlyWarningSytemTest._default_expected_stderr):
3364         (EarlyWarningSytemTest._default_expected_logs):
3365         (EarlyWarningSytemTest._test_testing_ews):
3366         * Scripts/webkitpy/tool/commands/openbugs.py:
3367         (OpenBugs.execute):
3368         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3369         (OpenBugsTest.test_args_parsing):
3370         * Scripts/webkitpy/tool/commands/perfalizer.py:
3371         (Perfalizer.handle_unexpected_error):
3372         * Scripts/webkitpy/tool/commands/queries.py:
3373         (PatchesInCommitQueue.execute):
3374         (PatchesToCommitQueue._needs_commit_queue):
3375         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3376         (QueryCommandsTest.test_bugs_to_commit):
3377         (QueryCommandsTest.test_patches_in_commit_queue):
3378         (QueryCommandsTest.test_patches_to_commit_queue):
3379         * Scripts/webkitpy/tool/commands/queues.py:
3380         (AbstractQueue._cc_watchers):
3381         (AbstractQueue.begin_work_queue):
3382         (FeederQueue.handle_unexpected_error):
3383         (CommitQueue.handle_script_error):
3384         (AbstractReviewQueue.handle_unexpected_error):
3385         (AbstractReviewQueue.handle_script_error):
3386         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3387         (test_auto_retry):
3388         * Scripts/webkitpy/tool/commands/queuestest.py:
3389         (QueuesTest.assert_outputs):
3390         (QueuesTest._default_begin_work_queue_stderr):
3391         (QueuesTest):
3392         (QueuesTest._default_begin_work_queue_logs):
3393         (QueuesTest.assert_queue_outputs):
3394         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3395         (RollCommandsTest.test_update_chromium_deps):
3396         (test_update_chromium_deps_older_revision):
3397         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3398         (SheriffBot.handle_unexpected_error):
3399         * Scripts/webkitpy/tool/commands/stepsequence.py:
3400         (StepSequence.run_and_handle_errors):
3401         * Scripts/webkitpy/tool/commands/upload.py:
3402         (AssignToCommitter._assign_bug_to_last_patch_attacher):
3403         (AbstractPatchUploadingCommand._prepare_state):
3404         (PostCommits.execute):
3405         (MarkBugFixed._determine_bug_id_and_svn_revision):
3406         (MarkBugFixed.execute):
3407         (CreateBug.create_bug_from_commit):
3408         (CreateBug.execute):
3409         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3410         (test_obsolete_attachments):
3411         (test_land_safely):
3412         (test_mark_bug_fixed):
3413         * Scripts/webkitpy/tool/multicommandtool.py:
3414         (Command.check_arguments_and_execute):
3415         (MultiCommandTool.main):
3416         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3417         (CommandTest.test_required_arguments):
3418         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
3419         (AddSvnMimetypeForPng.run):
3420         * Scripts/webkitpy/tool/steps/applypatch.py:
3421         (ApplyPatch.run):
3422         * Scripts/webkitpy/tool/steps/build.py:
3423         (Build.run):
3424         * Scripts/webkitpy/tool/steps/checkstyle.py:
3425         * Scripts/webkitpy/tool/steps/closebug.py:
3426         (CloseBug.run):
3427         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3428         (CloseBugForLandDiff.run):
3429         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3430         (CloseBugForLandDiffTest.test_empty_state):
3431         * Scripts/webkitpy/tool/steps/commit.py:
3432         (Commit.run):
3433         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3434         (CommitTest._test_check_test_expectations):
3435         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3436         (EnsureLocalCommitIfNeeded.run):
3437         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3438         (ObsoletePatches.run):
3439         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3440         (PrepareChangeLog.run):
3441         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3442         (ReopenBugAfterRollout.run):
3443         * Scripts/webkitpy/tool/steps/runtests.py:
3444         (RunTests.run):
3445         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3446         (RunTestsTest.test_webkit_run_unit_tests):
3447         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3448         (StepsTest.test_update_step):
3449         (StepsTest.test_runtests_args):
3450         * Scripts/webkitpy/tool/steps/update.py:
3451         (Update.run):
3452         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3453         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3454         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
3455         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3456         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
3457         (UpdateChangeLogsWithReviewer.run):
3458         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
3459         (UpdateChromiumDEPS._validate_revisions):
3460         (UpdateChromiumDEPS.run):
3461         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3462         (ValidateChangeLogs._check_changelog_diff):
3463         (ValidateChangeLogs.run):
3464         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3465         (ValidateChangeLogsTest._assert_start_line_produces_output):
3466         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3467         (ValidateReviewer.run):
3468
3469 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3470
3471         Coverage testing in webkitpy should omit some paths
3472         https://bugs.webkit.org/show_bug.cgi?id=103267
3473
3474         Reviewed by Dirk Pranke.
3475
3476         Omit testing coverage of any file under /usr directory and any file
3477         that is of third party origin and was autoinstalled.
3478
3479         * Scripts/webkitpy/test/main.py:
3480         (Tester._run_tests):
3481
3482 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
3483
3484         Text Autosizing: Add Text Autosizing APIs for WK2
3485         https://bugs.webkit.org/show_bug.cgi?id=100633
3486
3487         Reviewed by Sam Weinig.
3488
3489         Add test cases for Text Autosizing in WKPreferences.
3490
3491         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3492         (TestWebKitAPI::TEST):
3493
3494 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
3495
3496         [Qt] REGRESSION(r135575): It made all tests assert
3497         https://bugs.webkit.org/show_bug.cgi?id=103169
3498
3499         Reviewed by Simon Hausmann.
3500
3501         This fixes another regression introduced in r135515:
3502         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
3503         since it can be called from WebKit2 to initialize QStyle for testing.
3504         This would then lead to things such as PlatformStrategies being
3505         initialized twice.
3506
3507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
3508         (WebCore::DumpRenderTree::DumpRenderTree):
3509
3510 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
3511
3512         Add the --order option to NRWT
3513         https://bugs.webkit.org/show_bug.cgi?id=102229
3514
3515         Reviewed by Dirk Pranke.
3516
3517         The --order option controls in what order the gathered tests will be run.
3518         There are 3 options:
3519         - natural, the tests are sorted in natural order,
3520         - random, the tests are sorted in random order,
3521         - none, the tests are kept in the order in which they were specified through
3522         arguments or the test list.
3523
3524         The natural option is the default one and maintains the current behavior.
3525
3526         The none option is primarily intended to be used with the --test-list option,
3527         with the test list file expected to list specific test names.
3528         When a directory is specified as one of the paths from under which tests should
3529         be gathered and the none option is used, that path will expand to all the tests
3530         under it, with these tests sorted in the natural order.
3531
3532         Using --order=random duplicated the behavior of the --randomize-order option, so
3533         the latter is removed.
3534
3535         This patch also incorporates the change with which makes it is possible to specify
3536         a test via arguments or the test list multiple tests and then have the test run
3537         that many times.
3538
3539         * Scripts/webkitpy/common/find_files.py:
3540         (find): Accept an optional sorting key that is used to sort files found in the directories
3541         that the given paths specify.
3542         (_normalized_find): Both paths that are then searched for the tests and the tests that
3543         were found are now kept in lists. This makes it possible to run a test multiple times
3544         by specifying it multiple times through arguments or the test list file.
3545         (_normalized_find.sort_by_directory_key):
3546         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3547         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
3548         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
3549         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3550         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
3551         (Sharder.__init__): Ditto.
3552         (Sharder._resize_shards):
3553         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3554         (SharderTests.get_shards): Modify the Shader initializing as required.
3555         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
3556         are now moved to the base Port unit tests.
3557         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3558         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
3559         the new --order option.
3560         * Scripts/webkitpy/layout_tests/port/base.py:
3561         (Port.tests): This method should now return a list of all the tests found in the specified
3562         paths.
3563         (Port._real_tests): A list is required, so no conversion to a set is made.
3564         (Port):
3565         (Port.test_key): Place this method here for now, but it should really move into a separate
3566         module.
3567         (Port._natural_sort_key): Ditto.
3568         (Port._natural_sort_key.tryint):
3569         (Port._virtual_tests): A list is required, so the function now operates on that rather than
3570         on a set.
3571         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3572         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
3573         list rather than an empty set.
3574         (PortTest.test_dont_require_http_server):
3575         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
3576         (NaturalCompareTest.assert_cmp):
3577         (NaturalCompareTest.test_natural_compare):
3578         (KeyCompareTest): The test name key unit tests are placed here for now.
3579         (KeyCompareTest.assert_cmp):
3580         (KeyCompareTest.test_test_key):
3581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3582         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
3583         by using --order=random.
3584         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
3585         various aspects of this change.
3586         (MainTest.test_natural_order):
3587         (MainTest):
3588         (MainTest.test_natural_order_test_specified_multiple_times):
3589         (MainTest.test_random_order):
3590         (MainTest.test_random_order_test_specified_multiple_times):
3591         (MainTest.test_no_order):
3592         (MainTest.test_no_order_test_specified_multiple_times):
3593         (MainTest.test_no_order_with_directory_entries_in_natural_order):
3594         * Scripts/webkitpy/tool/commands/queries.py:
3595         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
3596
3597 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3598
3599         Unreviewed, rolling out r135600.
3600         http://trac.webkit.org/changeset/135600
3601         https://bugs.webkit.org/show_bug.cgi?id=103173
3602
3603         It made EFL API test is failed (Requested by gyuyoung_mbp on
3604         #webkit).
3605
3606         * TestWebKitAPI/PlatformEfl.cmake:
3607         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3608         (TestWebKitAPI::Util::sleep):
3609         * TestWebKitAPI/efl/PlatformWebView.cpp:
3610
3611 2012-11-23  Alexis Menard  <alexis@webkit.org>
3612
3613         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
3614         https://bugs.webkit.org/show_bug.cgi?id=102104
3615
3616         Reviewed by Julien Chaffraix.
3617
3618         Protect the new feature behind a feature flag.
3619
3620         * Scripts/webkitperl/FeatureList.pm:
3621         * qmake/mkspecs/features/features.pri:
3622
3623 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
3624
3625         Unreviewed. Update my e-mail address.
3626
3627         * Scripts/webkitpy/common/config/committers.py:
3628
3629 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
3630
3631         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
3632         https://bugs.webkit.org/show_bug.cgi?id=100757
3633
3634         Reviewed by Laszlo Gombos.
3635
3636         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
3637         Updating CMake files due to changes from Bug 99011.
3638
3639         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3640         (WTR::AccessibilityController::AccessibilityController):
3641         (WTR):
3642         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3643         (AccessibilityController):
3644         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3645         (WTR):
3646         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3647         (AccessibilityUIElement):
3648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
3649         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
3650
3651 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
3652
3653         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
3654         https://bugs.webkit.org/show_bug.cgi?id=102510
3655
3656         Reviewed by Pavel Feldman.
3657
3658         Added missing includes.
3659
3660         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3661
3662 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3663
3664         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3665         https://bugs.webkit.org/show_bug.cgi?id=103123
3666
3667         Reviewed by Kenneth Rohde Christiansen.
3668
3669         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
3670         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
3671
3672         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
3673         test.
3674         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3675         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
3676         test case is passing 0.5 seconds to sleep.
3677         * TestWebKitAPI/efl/PlatformWebView.cpp:
3678         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
3679         (TestWebKitAPI):
3680
3681 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
3682
3683         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
3684         https://bugs.webkit.org/show_bug.cgi?id=86881
3685
3686         Reviewed by Kenneth Rohde Christiansen.
3687
3688         eventSender object extended with contextClick() method in WebKitTestRunner.
3689         contextClick() method returns an array of menu items objects with field 'title' containing title of single
3690         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
3691         delivered in this patch.
3692
3693         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3694         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3695         (WTR::EventSendingController::contextClick):
3696         (WTR):
3697         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3698         (EventSendingController):
3699
3700 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3701
3702         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
3703         https://bugs.webkit.org/show_bug.cgi?id=102942
3704
3705         Reviewed by Tor Arne Vestbø.
3706
3707         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
3708         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
3709         to follow the same rules as other Qt 5 modules, with the exception that instead of
3710         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
3711         in other cross-platform header files to determine the correct meaning of export
3712         macros.
3713
3714         * qmake/mkspecs/features/default_post.prf:
3715         * qmake/mkspecs/features/win32/default_post.prf:
3716
3717 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3718
3719         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
3720         https://bugs.webkit.org/show_bug.cgi?id=103111
3721
3722         Reviewed by Kenneth Rohde Christiansen.
3723
3724         This function was added as a slot during Qt 4.x times because adding
3725         virtual functions breaks binary compatibility. This constraint is gone
3726         with the initial release of WebKit with Qt 5, and therefore we can
3727         make it virtual now.
3728
3729         The change is fully source compatible as existing "re-implementations"
3730         as slots will now be called through it being a virtual function. They
3731         become unused slots.
3732
3733         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3734         (WebCore::WebPage::shouldInterruptJavaScript):
3735         (WebPage):
3736         * QtTestBrowser/webpage.h:
3737         (WebPage):
3738
3739 2012-11-22  Peter Beverloo  <peter@chromium.org>
3740
3741         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
3742         https://bugs.webkit.org/show_bug.cgi?id=103065
3743
3744         Reviewed by Dirk Pranke.
3745
3746         This addresses two further reliability issues in the Android test running
3747         scripts. Firstly, the run_tests.py script needs to have the --exit_code
3748         argument passed in order to return non-zero codes, which we need for the
3749         build master to distinguish failures from successful runs.
3750
3751         Secondly, it modifies the layout test runner to briefly wait (through
3752         the wait-for-device command) after requesting a device to switch to root
3753         mode. Without this waiting period, commands might get lost and thereby
3754         unexpectedly fail.
3755
3756         * Scripts/run-api-tests:
3757         * Scripts/run-chromium-webkit-unit-tests:
3758         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3759         (ChromiumAndroidDriver._setup_test):
3760         (ChromiumAndroidDriver._restart_adb_as_root):
3761
3762 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
3763
3764         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
3765         https://bugs.webkit.org/show_bug.cgi?id=102800
3766
3767         Reviewed by Tor Arne Vestbø.
3768
3769         This patch separates code that needs to use QWidget related APIs in
3770         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
3771         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
3772         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
3773         static library. WebKit1 is compiled without QT += widgets and therefore
3774         any widget related dependency has been moved "up" and out of WebKit1 into
3775         the WebKitWidgets library.
3776
3777         Between the code in WebKit.a and WebKitWidgets.a new adapters and
3778         interfaces have been introduced, such as QWebPageAdapter and
3779         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
3780         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
3781         The other way around if QWebPage wants to access WebCore or
3782         WebCoreSupport related functionality, it will go through
3783         QWebPageAdapater (as base class). The separation in the direction up
3784         into the API layer is complete with this patch, no code in WebKit1
3785         depends on QtWidgets. The separation the other way around, code in the
3786         API layer not using any WebCore types, is not complete yet.
3787
3788         Some classes such as QWebSettings, QWebElement or
3789         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
3790         they do not depend on widget related Qt APIs and they make much more
3791         use of WebCore internal APIs and therefore are easier to keep in
3792         WebKit1.
3793
3794         In the future we plan to place a real shared library boundary between
3795         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
3796         part of the QtWebKit shared library and by turning the WebKitWidgets
3797         static library into a shared one.
3798
3799         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3800         (WebCore::WebPage::resetSettings):
3801         (WebCore::WebPage::createWindow):
3802         (WebCore::DumpRenderTree::DumpRenderTree):
3803         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3804         (WebCore::DumpRenderTree::initJSObjects):
3805         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
3806         (WebCore::DumpRenderTree::dumpFramesAsText):
3807         (WebCore::DumpRenderTree::dump):
3808         (WebCore::DumpRenderTree::createWindow):
3809         (WebCore::DumpRenderTree::pageAdapter):
3810         (WebCore):
3811         (WebCore::DumpRenderTree::mainFrameAdapter):
3812         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3813         (DumpRenderTree):
3814         * DumpRenderTree/qt/EventSenderQt.cpp:
3815         (EventSender::contextClick):
3816         (EventSender::scalePageBy):
3817         * DumpRenderTree/qt/TestRunnerQt.cpp:
3818         (TestRunner::reset):
3819         (TestRunner::display):
3820         (TestRunner::closeWebInspector):
3821         (TestRunner::showWebInspector):
3822         (TestRunner::evaluateInWebInspector):
3823         (TestRunner::setFrameFlatteningEnabled):
3824         (TestRunner::goBack):
3825         (TestRunner::setDefersLoading):
3826         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3827         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3828         (TestRunner::numberOfActiveAnimations):
3829         (TestRunner::setCaretBrowsingEnabled):
3830         (TestRunner::setAuthorAndUserStylesEnabled):
3831         (TestRunner::callShouldCloseOnWebView):
3832         (TestRunner::setSmartInsertDeleteEnabled):
3833         (TestRunner::setSelectTrailingWhitespaceEnabled):
3834         (TestRunner::execCommand):
3835         (TestRunner::isCommandEnabled):
3836         (TestRunner::findString):
3837         (TestRunner::elementDoesAutoCompleteForElementWithId):
3838         (TestRunner::setMockDeviceOrientation):
3839         (TestRunner::setGeolocationPermission):
3840         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3841         (TestRunner::setMockGeolocationPositionUnavailableError):
3842         (TestRunner::setMockGeolocationPosition):
3843         (TestRunner::evaluateScriptInIsolatedWorld):
3844         (TestRunner::addUserStyleSheet):
3845         (TestRunner::setMinimumTimerInterval):
3846         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3847         (TextInputController::selectedRange):
3848         (TextInputController::firstRectForCharacterRange):
3849         (TextInputController::unmarkText):
3850         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3851         (LoadAlternateHTMLStringItem::invoke):
3852         * qmake/mkspecs/features/default_post.prf:
3853         * qmake/mkspecs/features/production_build.prf:
3854         * qmake/mkspecs/features/webkit_modules.prf:
3855         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
3856
3857 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
3858
3859         WebKitTestRunner needs layoutTestController.setCacheModel
3860         https://bugs.webkit.org/show_bug.cgi?id=42684
3861
3862         Reviewed by Kenneth Rohde Christiansen.
3863
3864         Add support for testRunner.setCacheModel to WebKitTestRunner.
3865
3866         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3867         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3868         (WTR::InjectedBundle::beginTesting):
3869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3870         (WTR::TestRunner::setCacheModel):
3871         (WTR):
3872         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3873         (TestRunner):
3874
3875 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
3876
3877         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
3878         https://bugs.webkit.org/show_bug.cgi?id=101327
3879
3880         Reviewed by Simon Hausmann.
3881
3882         Avoid busy waiting for events in platformRunUntil while making
3883         sure we don't change the behavior of modal event loops.
3884
3885         * WebKitTestRunner/TestController.cpp:
3886         (WTR::TestController::~TestController):
3887         * WebKitTestRunner/TestController.h:
3888         (TestController):
3889         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3890         (WTR::TestController::platformDestroy):
3891         (WTR):
3892         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3893         (WTR::TestController::platformDestroy):
3894         (WTR):
3895         * WebKitTestRunner/mac/TestControllerMac.mm:
3896         (WTR::TestController::platformDestroy):
3897         (WTR):
3898         * WebKitTestRunner/qt/TestControllerQt.cpp:
3899         (TestController::RunLoop): Helper class to handle
3900         the event loop logic
3901         (WTR):
3902         (WTR::TestController::RunLoop::RunLoop):
3903         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
3904         the run loop. This is the appropriate API to push the WaitForMoreEvents
3905         flag to QCoreApplication::processEvents and also being able to exit the
3906         loop if we have timed out.
3907         (WTR::TestController::RunLoop::notifyDone):
3908         (WTR::TestController::RunLoop::timerFired):
3909         (WTR::TestController::RunLoop::runModal):
3910         (WTR::TestController::notifyDone):
3911         (WTR::TestController::platformInitialize):
3912         (WTR::TestController::platformDestroy):
3913         (WTR::TestController::platformRunUntil):
3914         (WTR::TestController::runModal):
3915         * WebKitTestRunner/win/TestControllerWin.cpp:
3916         (WTR::TestController::platformDestroy):
3917         (WTR):
3918
3919 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3920
3921         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
3922         https://bugs.webkit.org/show_bug.cgi?id=102926
3923
3924         Reviewed by Kenneth Rohde Christiansen.
3925
3926         Add missing bits needed by WKPreferences and AboutBlankLoad API
3927         tests in the test harness and enable these tests on EFL port.
3928
3929         * TestWebKitAPI/PlatformEfl.cmake:
3930         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3931         (TestWebKitAPI::TEST):
3932         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3933         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3934         (Util):
3935
3936 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
3937
3938         [GTK][WTR] Implement AccessibilityUIElement::stringValue
3939         https://bugs.webkit.org/show_bug.cgi?id=102951
3940
3941         Reviewed by Martin Robinson.
3942
3943         Implement AccessibilityUIElement::stringValue in the ATK backend
3944         in the same manner it is implemented in DumpRenderTree.
3945
3946         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3947         (WTR::replaceCharactersForResults):
3948         (WTR):
3949         (WTR::AccessibilityUIElement::stringValue):
3950
3951 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
3952
3953         Unreviewed. Adding myself to committers.py.
3954
3955         * Scripts/webkitpy/common/config/committers.py:
3956
3957 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
3958
3959         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
3960         https://bugs.webkit.org/show_bug.cgi?id=100061
3961
3962         Reviewed by Adam Barth.
3963
3964         On Android we're using a different pixel scaling implementation
3965         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
3966         platforms. In this mode, we don't make use of device-independent pixels. Device
3967         scale factor is provided to WebKit and get merged into page scale factor. Other
3968         than that device scale factor should have no effects on rendering.
3969
3970         * DumpRenderTree/chromium/WebPreferences.cpp:
3971         (WebPreferences::applyTo):
3972
3973 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
3974
3975         Clear MousePressed state on context menu to avoid initiating a drag
3976         https://bugs.webkit.org/show_bug.cgi?id=101786
3977
3978         Reviewed by Ojan Vafai.
3979
3980         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3981         (WebTestRunner):
3982         (WebTestRunner::EventSender::EventSender):
3983         (WebTestRunner::EventSender::contextClick):
3984         Only send a MouseUp on Windows. Keep the current mouse pressed state when
3985         calling up a context menu.
3986
3987 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3988
3989         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
3990         https://bugs.webkit.org/show_bug.cgi?id=102895
3991
3992         Reviewed by Gyuyoung Kim.
3993
3994         Change the link order so it wont override the new operator on gtest.
3995         Looks like it was crashing because an allocator mismatch (using libc's
3996         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
3997         the fastMalloc issue.
3998
3999         * TestWebKitAPI/CMakeLists.txt:
4000
4001 2012-11-21  Kentaro Hara  <haraken@chromium.org>
4002
4003         Unreviewed, rolling out r135340.
4004         http://trac.webkit.org/changeset/135340
4005         https://bugs.webkit.org/show_bug.cgi?id=102492
4006
4007         It broke Safari's internal build
4008
4009         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
4010         (new):
4011         (GenerateModule):
4012         (GenerateInterface):
4013         (finish):
4014
4015 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
4016
4017         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
4018         https://bugs.webkit.org/show_bug.cgi?id=101526
4019
4020         Reviewed by Kenneth Rohde Christiansen.
4021
4022         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
4023
4024         * Scripts/webkitperl/FeatureList.pm:
4025         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
4026
4027 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
4028
4029         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
4030         https://bugs.webkit.org/show_bug.cgi?id=102867
4031
4032         Reviewed by Gyuyoung Kim.
4033
4034         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
4035
4036         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
4037         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
4038         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
4039
4040         * MiniBrowser/efl/main.c:
4041         (on_key_down):
4042
4043 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
4044
4045         Unreviewed, rolling out r133859.
4046         http://trac.webkit.org/changeset/133859
4047         https://bugs.webkit.org/show_bug.cgi?id=102875
4048
4049         This patch makes API test broken (Requested by gyuyoung on
4050         #webkit).
4051
4052         * Scripts/webkitperl/FeatureList.pm:
4053
4054 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
4055
4056         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
4057         https://bugs.webkit.org/show_bug.cgi?id=99114
4058
4059         Reviewed by Gyuyoung Kim.
4060
4061         Implemented window_create and window_close smartcallback functions.
4062
4063         * MiniBrowser/efl/main.c:
4064         (on_window_create):
4065         (on_window_close):
4066         (window_create):
4067
4068 2012-11-20  Ojan Vafai  <ojan@chromium.org>
4069
4070         Simplify builder filters now that we have lists of which builders run which tests
4071         https://bugs.webkit.org/show_bug.cgi?id=102849
4072
4073         Reviewed by Dirk Pranke.
4074
4075         We only need filters when we load the same master for multiple groups in the
4076         same test type, i.e. when we need to only include some of the builders that run
4077         a given test suite on a given master.
4078
4079         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
4080         Now just make it a method on BuilderGroup.
4081
4082         * TestResultServer/static-dashboards/builders.js:
4083         (BuilderGroup.prototype.append):
4084         (BuilderGroup.prototype.setup):
4085         (BuilderGroup.prototype._defaultBuilder):
4086         (BuilderGroup.prototype.master):
4087         (requestBuilderList):
4088         (isChromiumWebkitTipOfTreeTestRunner):
4089         (isChromiumWebkitDepsTestRunner):
4090         (loadBuildersList):
4091         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4092         (test):
4093
4094 2012-11-20  Ojan Vafai  <ojan@chromium.org>
4095
4096         Remove perfav master for webkit_unit_tests and test_shell_tests.
4097         There are no bots on this master that run these tests.
4098         * TestResultServer/static-dashboards/builders.js:
4099
4100 2012-11-20  Ojan Vafai  <ojan@chromium.org>
4101
4102         Remove special case for layout tests when builders fail to load
4103         https://bugs.webkit.org/show_bug.cgi?id=102842
4104
4105         Reviewed by Tony Chang.
4106
4107         Now that we load only builders that actually run the given test
4108         type, we can reliably show errors to the users because it
4109         represents a broken bot.
4110         * TestResultServer/static-dashboards/loader.js:
4111
4112 2012-11-15  Ojan Vafai  <ojan@chromium.org>
4113
4114         Generate a list of builders/test suites from the buildbot json
4115         https://bugs.webkit.org/show_bug.cgi?id=102443
4116
4117         Reviewed by Dirk Pranke.
4118
4119         Instead of the cludgy things we do now to track which bots run which tests,
4120         we generate all that data from the buildbots' json files.
4121         This is the minimal amount to keep everything working. Once this lands,
4122         we can also do a bunch of followup cleanup.
4123
4124         For now we commit the generated data. In theory, in the future, we could
4125         have the test results server generate the data on the fly.
4126
4127         For the sake of easily understanding what changes when we run the generate script,
4128         also checkin a pretty printed version of the output. The pretty printed version
4129         is too large to serve as part of the flakiness dashboard though.
4130
4131         This also has the benefit of making the dashboard load much faster since
4132         we no longer ever need to block on requests to buildbot.
4133
4134         * TestResultServer/generate_builders_json.py: Added.
4135         (master_json_url):
4136         (builder_json_url):
4137         (cached_build_json_url):
4138         (fetch_json):
4139         (insert_builder_and_test_data):
4140         (main):
4141         * TestResultServer/generate_builders_json_unittest.py: Added.
4142         (GenerateBuildersJsonTest):
4143         (GenerateBuildersJsonTest.test_master_json_url):
4144         (GenerateBuildersJsonTest.test_builder_json_url):
4145         (GenerateBuildersJsonTest.test_cached_build_json_url):
4146         (GenerateBuildersJsonTest.test_generate_json_data):
4147         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
4148         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
4149         * TestResultServer/static-dashboards/builders.js:
4150         (LOAD_BUILDBOT_DATA):
4151         (BuilderGroup):
4152         (BuilderGroup.prototype.append):
4153         (BuilderGroup.prototype.master):
4154         (requestBuilderList):
4155         * TestResultServer/static-dashboards/builders.jsonp: Added.
4156         * TestResultServer/static-dashboards/builders_unittests.js: Added.
4157         * TestResultServer/static-dashboards/dashboard_base.js:
4158         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4159         (showPopupForBuild):
4160         (htmlForTestResults):
4161         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
4162         (loadExpectationsLayoutTests):
4163         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4164         (resetGlobals):
4165         (test):
4166         * TestResultServer/static-dashboards/loader.js:
4167         * TestResultServer/static-dashboards/loader_unittests.js:
4168         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4169         * TestResultServer/static-dashboards/run-unittests.html:
4170         * TestResultServer/static-dashboards/timeline_explorer.html:
4171
4172 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4173
4174         [WTR][Qt] Enable fixedLayout when needed by the test
4175         https://bugs.webkit.org/show_bug.cgi?id=102811
4176
4177         Reviewed by Kenneth Rohde Christiansen.
4178
4179         Create a flickable view for CSS Device Adaptation tests. This is
4180         crucial for testing them since they will change the size of the
4181         viewport.
4182
4183         * WebKitTestRunner/PlatformWebView.h:
4184         (PlatformWebView):
4185         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4186         (WTR::PlatformWebView::PlatformWebView):
4187         (WTR::PlatformWebView::viewSupportsOptions):
4188         (WTR):
4189         * WebKitTestRunner/qt/main.cpp:
4190         (main):
4191
4192 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4193
4194         [WTR] WebKitTestRunner should be able to run tests using fixed layout
4195         https://bugs.webkit.org/show_bug.cgi?id=102517
4196
4197         Reviewed by Kenneth Rohde Christiansen.
4198
4199         WTR will now request the creation of a view that has a page using
4200         fixed layout for CSS Device Adaptation tests, but this feature might
4201         be used in the future by any other test that requires a mobile-like type
4202         of viewport (i.e. Viewport META tests should be ported).
4203
4204         The viewport type of the other tests remains unchanged and is restored
4205         when the runner leaves the device-adapt/ folder.
4206
4207         * WebKitTestRunner/PlatformWebView.h:
4208         (PlatformWebView):
4209         * WebKitTestRunner/TestInvocation.cpp:
4210         (WTR):
4211         (WTR::shouldUseFixedLayout):
4212         (WTR::updateLayoutType):
4213         (WTR::TestInvocation::invoke):
4214         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4215         (WTR::PlatformWebView::PlatformWebView):
4216         (WTR::PlatformWebView::viewSupportsOptions):
4217         (WTR):
4218
4219 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
4220
4221         [Qt] REGRESSION(r128174): Fast build path doesn't work now
4222         https://bugs.webkit.org/show_bug.cgi?id=100360
4223
4224         Reviewed by Tor Arne Vestbø.
4225
4226         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
4227
4228         * Scripts/webkitdirs.pm:
4229         (buildQMakeProjects):
4230
4231 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
4232
4233         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
4234         https://bugs.webkit.org/show_bug.cgi?id=99011
4235
4236         Reviewed by Martin Robinson.
4237
4238         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
4239
4240         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
4241         (WTR::AccessibilityController::logAccessibilityEvents):
4242         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
4243
4244 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
4245
4246         webkitpy unit tests should run serially when checking code coverage
4247         https://bugs.webkit.org/show_bug.cgi?id=102693
4248
4249         Reviewed by Dirk Pranke.
4250
4251         When checking code coverage, the unit tests should not be run in parallel
4252         as this causes the tracing functions (set via sys.settrace in the coverage
4253         module) being overriden, resulting in incorrect coverage reports.
4254
4255         * Scripts/webkitpy/test/main.py:
4256         (Tester._run_tests):
4257
4258 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
4259
4260         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
4261         https://bugs.webkit.org/show_bug.cgi?id=102704
4262
4263         Reviewed by Laszlo Gombos.
4264
4265         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
4266
4267         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4268         (WTR::initEcoreEvas):
4269
4270 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
4271
4272         [garden-o-matic] Switch frontend to use the gardeningserver.
4273         https://bugs.webkit.org/show_bug.cgi?id=102712
4274
4275         Reviewed by Dirk Pranke.
4276
4277         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables