WebSocket: Connecting to localhost:8880 takes one second on Windows
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
2
3         WebSocket: Connecting to localhost:8880 takes one second on Windows
4         https://bugs.webkit.org/show_bug.cgi?id=64788
5
6         Reviewed by Dirk Pranke.
7
8         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
9         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
10         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
11         from timing out on Windows, because this test tries to open a lot of
12         connections to localhost and each attempt takes one second to fall back from
13         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
14
15 2011-10-27  Adam Barth  <abarth@webkit.org>
16
17         Dis-integrate run-bindings-tests with webkitpy
18         https://bugs.webkit.org/show_bug.cgi?id=71092
19
20         Reviewed by Ryosuke Niwa.
21
22         These tests aren't really adding any value.
23
24         * Scripts/webkitpy/common/config/ports.py:
25         * Scripts/webkitpy/tool/commands/download_unittest.py:
26         * Scripts/webkitpy/tool/mocktool.py:
27         * Scripts/webkitpy/tool/steps/runtests.py:
28         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
29         * Scripts/webkitpy/tool/steps/steps_unittest.py:
30
31 2011-10-27  Eric Seidel  <eric@webkit.org>
32
33         REGRESSION (r98639): NRWT crashes when parsing leaks output
34         https://bugs.webkit.org/show_bug.cgi?id=71087
35
36         Unreviewed.  Sadly we have no good way to test logging.
37
38         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
39
40 2011-10-27  David Levin  <levin@chromium.org>
41
42         Test expectation errors should include the file name and platform in both the log and exception info.
43         https://bugs.webkit.org/show_bug.cgi?id=71067
44
45         Reviewed by Ojan Vafai.
46
47         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
48         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
49
50 2011-10-27  Eric Seidel  <eric@webkit.org>
51
52         new-run-webkit-tests doesn't understand --qt or --gtk
53         https://bugs.webkit.org/show_bug.cgi?id=63970
54
55         Reviewed by Ojan Vafai.
56
57         Add support for --qt and --gtk to NRWT.
58         I also removed some incorrect comments in the option parsing
59         code (options which we already implement, but said we didn't)
60         as well as moved --platform parsing out of the "results_options"
61         section into the top configuration section.
62
63         Now run-webkit-tests no longer needs NRWT-specific code for passing
64         --platform=qt, etc.
65
66         * Scripts/run-webkit-tests:
67         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
68
69 2011-10-27  Eric Seidel  <eric@webkit.org>
70
71         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
72         https://bugs.webkit.org/show_bug.cgi?id=66227
73
74         Reviewed by Adam Roben.
75
76         I believe this should fix the bug.
77
78         * Scripts/run-webkit-tests: make NRWT default for --leaks
79         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
80         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
81         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
82         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
83         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
84         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
85         * Scripts/webkitpy/layout_tests/port/mac.py:
86         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
87
88 2011-10-27  Stephen Chenney  <schenney@chromium.org>
89
90         [Chromium] Need setPrinting
91         https://bugs.webkit.org/show_bug.cgi?id=46152
92
93         Reviewed by Hajime Morita.
94
95         * DumpRenderTree/chromium/LayoutTestController.cpp:
96         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
97         (LayoutTestController::reset): Clearing flags for setPrinting.
98         (LayoutTestController::setPrinting): Set flags for setPrinting.
99         * DumpRenderTree/chromium/LayoutTestController.h:
100         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
101         (LayoutTestController::isPrinting): Method to return the setPrinting status.
102         * DumpRenderTree/chromium/TestShell.cpp:
103         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
104         (TestShell::dump): Modified to dump setPrinting-specific output.
105         * DumpRenderTree/chromium/WebViewHost.cpp:
106         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
107         active.
108         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
109
110 2011-10-27  Sam Weinig  <sam@webkit.org>
111
112         Add allowsPlugIns property to WKBrowsingContextGroup
113         https://bugs.webkit.org/show_bug.cgi?id=70987
114
115         Reviewed by Anders Carlsson.
116
117         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
118         Add basic test for WKBrowsingContextGroup.allowsPlugIns. 
119
120 2011-10-27  Adam Roben  <aroben@apple.com>
121
122         Test WKBundlePageGetBackingScaleFactor
123
124         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
125         can't reliably determine the scale factor of snapshots returned via
126         WKBundlePageCreateSnapshot* API
127
128         Reviewed by Sam Weinig.
129
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
131
132         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
133         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
134         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
135         (TestWebKitAPI::createWindow): Conjure up a window.
136         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
137         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
138         factors and when using a custom scale factor, and check that we get those same scale factors
139         back.
140
141         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
142         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
143         members.
144         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
145         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
146         from the page using the new API and send it back.
147
148 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
149
150         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
151
152         Rubber-stamped by Simon Hausmann.
153
154         * MiniBrowser/qt/MiniBrowserApplication.cpp:
155         (MiniBrowserApplication::handleUserOptions):
156         Fix typo error.
157
158 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
159
160         [WebSocket] update pywebsocket to 0.7.
161         https://bugs.webkit.org/show_bug.cgi?id=70992
162
163         Reviewed by Kent Tamura.
164
165         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
166
167         * Scripts/webkitpy/thirdparty/__init__.py:
168
169 2011-10-27  Elliot Poger  <epoger@google.com>
170
171         make lion observe MAC lines in test_expectations.txt
172         https://bugs.webkit.org/show_bug.cgi?id=70941
173
174         Reviewed by Ojan Vafai.
175
176         * Scripts/webkitpy/layout_tests/port/chromium.py:
177         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
178
179 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
180
181         [Chromium] Allow DRT to be built without notifications enabled.
182         https://bugs.webkit.org/show_bug.cgi?id=70919
183
184         Reviewed by Tony Gentilcore.
185
186         * DumpRenderTree/chromium/LayoutTestController.cpp:
187         (LayoutTestController::grantDesktopNotificationPermission):
188         (LayoutTestController::simulateDesktopNotificationClick):
189         * DumpRenderTree/chromium/NotificationPresenter.cpp:
190         * DumpRenderTree/chromium/TestShell.cpp:
191         (TestShell::TestShell):
192         (TestShell::resetTestController):
193
194 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
195
196         [Qt] Improve command line arguments handling for MiniBrowser.
197         https://bugs.webkit.org/show_bug.cgi?id=70616
198
199         Reviewed by Kenneth Rohde Christiansen.
200
201         - Use two dashes for word arguments.
202         - Return with an error when an unsupported argument is given.
203         - Allow the URL to be placed before option arguments.
204
205         * MiniBrowser/qt/MiniBrowserApplication.cpp:
206         (printHelp):
207         (MiniBrowserApplication::handleUserOptions):
208         * MiniBrowser/qt/utils.cpp:
209         (takeOptionFlag):
210         (takeOptionValue):
211         * MiniBrowser/qt/utils.h:
212
213 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
214
215         [Qt] NRWT doesn't work on qt-mac platform
216         https://bugs.webkit.org/show_bug.cgi?id=64445
217
218         Reviewed by Adam Barth.
219
220         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
221         (useNewRunWebKitTests):
222         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
223
224 2011-10-26  Sam Weinig  <sam@webkit.org>
225
226         Add initial setting to WKBrowsingContextGroup
227         https://bugs.webkit.org/show_bug.cgi?id=70942
228
229         Reviewed by Anders Carlsson.
230
231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
232         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
233         Add basic test that setting the javaScriptEnabled setting takes. It is not
234         possible to test its effect quite yet.
235
236 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
237
238         [GTK] [WK2] Add WebKit2 distcheck support
239         https://bugs.webkit.org/show_bug.cgi?id=70933
240
241         Reviewed by Martin Robinson.
242
243         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
244         sources and EXTRA_DIST.
245
246 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
247
248         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
249
250         Reviewed by Tor Arne Vestbø.
251
252         We're using QScroller since r98460, which requires QWidget/QApplication. So
253         use QApplication and QtWidgets for the time being.
254
255         * MiniBrowser/qt/MiniBrowser.pro:
256         * MiniBrowser/qt/MiniBrowserApplication.cpp:
257         (MiniBrowserApplication::MiniBrowserApplication):
258         (MiniBrowserApplication::notify):
259         * MiniBrowser/qt/MiniBrowserApplication.h:
260
261 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
262
263         [Qt][WK2] Rewrite MiniBrowser in QML
264         https://bugs.webkit.org/show_bug.cgi?id=70315
265
266         Add the first QML based implementation of MiniBrowser.
267
268         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
269                  Zeno Albisser <zeno.albisser@nokia.com>
270
271         Reviewed by Tor Arne Vestbø.
272
273         * MiniBrowser/qt/BrowserWindow.cpp:
274         (BrowserWindow::BrowserWindow):
275         (BrowserWindow::webView):
276         (BrowserWindow::load):
277         (BrowserWindow::keyPressEvent):
278         (BrowserWindow::~BrowserWindow):
279         * MiniBrowser/qt/BrowserWindow.h:
280         * MiniBrowser/qt/MiniBrowser.pro:
281         * MiniBrowser/qt/MiniBrowser.qrc:
282         * MiniBrowser/qt/MiniBrowserApplication.cpp:
283         (MiniBrowserApplication::MiniBrowserApplication):
284         (MiniBrowserApplication::handleUserOptions):
285         * MiniBrowser/qt/MiniBrowserApplication.h:
286         (WindowOptions::WindowOptions):
287         * MiniBrowser/qt/UrlLoader.cpp:
288         (UrlLoader::UrlLoader):
289         * MiniBrowser/qt/icons/next.png: Added.
290         * MiniBrowser/qt/icons/previous.png: Added.
291         * MiniBrowser/qt/icons/refresh.png: Added.
292         * MiniBrowser/qt/icons/stop.png: Added.
293         * MiniBrowser/qt/main.cpp:
294         (main):
295         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
296
297 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
298
299         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
300         https://bugs.webkit.org/show_bug.cgi?id=70529
301
302         Remove obsolete code for a new QML based implementation
303         of MiniBrowser.
304         Change BrowserWindow to derive from QSGView instead of
305         QMainWindow. QSGView is used as a top level window that
306         provides the container for placing QML content.
307         Make MiniBrowserApplication derive from QGuiApplication
308         instead of QApplication.
309
310         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
311                  Zeno Albisser <zeno.albisser@nokia.com>
312
313         Reviewed by Simon Hausmann.
314
315         * MiniBrowser/qt/BrowserView.cpp: Removed.
316         * MiniBrowser/qt/BrowserView.h: Removed.
317         * MiniBrowser/qt/BrowserWindow.cpp:
318         (BrowserWindow::BrowserWindow):
319         (BrowserWindow::load):
320         (BrowserWindow::screenshot):
321         (BrowserWindow::loadURLListFromFile):
322         (BrowserWindow::updateUserAgentList):
323         (BrowserWindow::~BrowserWindow):
324         * MiniBrowser/qt/BrowserWindow.h:
325         * MiniBrowser/qt/MiniBrowser.pro:
326         * MiniBrowser/qt/MiniBrowserApplication.cpp:
327         (MiniBrowserApplication::MiniBrowserApplication):
328         (MiniBrowserApplication::notify):
329         * MiniBrowser/qt/MiniBrowserApplication.h:
330         * MiniBrowser/qt/UrlLoader.cpp:
331         (UrlLoader::UrlLoader):
332         * MiniBrowser/qt/main.cpp:
333
334 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
335
336         [Qt][WK2] Remove QAction from MiniBrowser
337         https://bugs.webkit.org/show_bug.cgi?id=70525
338
339         In order to rewrite MiniBrowser in QML we need a suitable
340         mechanism for triggering navigation actions.
341         Due to the QtWidgets dependency of QAction the current
342         solution is not suitable anymore. Therefore we introduce
343         invokable methods and export properties in QWebNavigationController.
344
345         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
346                  Zeno Albisser <zeno.albisser@nokia.com>
347
348         Reviewed by Simon Hausmann.
349
350         * MiniBrowser/qt/BrowserView.cpp:
351         * MiniBrowser/qt/BrowserView.h:
352         * MiniBrowser/qt/BrowserWindow.cpp:
353         (BrowserWindow::BrowserWindow):
354
355 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
356
357         [EFL] Unregister viewport,changed signal in EWebLauncher.
358         https://bugs.webkit.org/show_bug.cgi?id=70478
359
360         Reviewed by Eric Seidel.
361
362         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
363         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
364         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
365         This signal is for mobile device.
366
367         * EWebLauncher/main.c:
368         (browserCreate):
369
370 2011-10-25  Anders Carlsson  <andersca@apple.com>
371
372         Plug-ins have no way to find out when the device scale factor changes
373         https://bugs.webkit.org/show_bug.cgi?id=67226
374         <rdar://problem/10048276>
375
376         Reviewed by Sam Weinig.
377
378         Keep a cached copy of the contents scale and update it when it changes.
379
380         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
381         (ContentsScaleFactor::ContentsScaleFactor):
382         (ContentsScaleFactor::cachedContentsScaleFactor):
383         (ContentsScaleFactor::ScriptableObject::hasProperty):
384         (ContentsScaleFactor::ScriptableObject::getProperty):
385         (ContentsScaleFactor::NPP_New):
386         (ContentsScaleFactor::NPP_SetValue):
387
388 2011-10-25  Sam Weinig  <sam@webkit.org>
389
390         Add WKBrowsingContextLoadDelegateTest test for a failed load
391         https://bugs.webkit.org/show_bug.cgi?id=70859
392
393         Reviewed by Anders Carlsson.
394
395         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
396         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
397  
398         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
399         Test that we are getting the correct NSError code and domain.
400
401 2011-10-25  Erik Arvidsson  <arv@chromium.org>
402
403         JS Test Harness: Make successfullyParsed optional
404         https://bugs.webkit.org/show_bug.cgi?id=70784
405
406         Reviewed by Ojan Vafai.
407
408         * Scripts/make-new-script-test:
409         (writeTestFile): Update the template for script tests.
410
411 2011-10-25  Anders Carlsson  <andersca@apple.com>
412
413         Plug-ins have to use JavaScript to find out the current device scale factor
414         https://bugs.webkit.org/show_bug.cgi?id=67225
415         <rdar://problem/10048258>
416
417         Reviewed by Darin Adler.
418
419         Add a plug-in test for getting the contents scale factor.
420
421         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
422         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
423         (ContentsScaleFactor::ContentsScaleFactor):
424         (ContentsScaleFactor::contentsScaleFactor):
425         (ContentsScaleFactor::ScriptableObject::hasProperty):
426         (ContentsScaleFactor::ScriptableObject::getProperty):
427         (ContentsScaleFactor::ScriptableObject::pluginTest):
428         (ContentsScaleFactor::NPP_GetValue):
429
430 2011-10-25  Sam Weinig  <sam@webkit.org>
431
432         Flesh out WKBrowsingContextLoadDelegate a bit
433         https://bugs.webkit.org/show_bug.cgi?id=70846
434
435         Reviewed by Anders Carlsson.
436
437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
438         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
439         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
440         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
441         (WKBrowsingContextLoadDelegateTest::SetUp):
442         (WKBrowsingContextLoadDelegateTest::TearDown):
443         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
444         (TEST_F):
445         Add basic testing for WKBrowsingContextLoadDelegate.
446
447 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
448
449         make-script-test-wrappers should not look outside fast/js
450         https://bugs.webkit.org/show_bug.cgi?id=66357
451
452         Reviewed by Maciej Stachowiak.
453
454         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
455         fast/js.
456
457 2011-10-25  Adam Barth  <abarth@webkit.org>
458
459         Add a --make option to update-webkit to engage the Makefile-based build system
460         https://bugs.webkit.org/show_bug.cgi?id=70847
461
462         Reviewed by Dimitri Glazkov.
463
464         I can never remember what crazy environment variables I'm supposed to
465         set to tell GYP what to do.
466
467         * Scripts/update-webkit:
468
469 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
470
471         [EFL] DRT: Force layout when sending events.
472         https://bugs.webkit.org/show_bug.cgi?id=70357
473
474         Reviewed by Antonio Gomes.
475
476         Some tests such as editing/input/page-up-down-scrolls.html rely on the
477         scrollbars being properly set up during the onload events.
478         Document::implicitClose(), however, dispatches the onload events before
479         calling FrameView::layout(), so these tests usually fail.
480
481         We now do the same as the GTK+ and Chromium ports and manually force the
482         layout when dispatching events.
483
484         * DumpRenderTree/efl/EventSender.cpp:
485         (sendMouseEvent):
486         (keyDownCallback):
487
488 2011-10-25  Daniel Bates  <dbates@rim.com>
489
490         build-webkit --clean should only clean build directory for CMake-based ports
491         https://bugs.webkit.org/show_bug.cgi?id=70834
492
493         Reviewed by Antonio Gomes.
494
495         Currently build-webkit --clean both cleans the build directory and builds WebKit for
496         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
497         as per its description in the usage message of build-webkit.
498
499         * Scripts/webkitdirs.pm:
500         (buildCMakeProjectOrExit):
501
502 2011-10-25  Anna Cavender  <annacc@chromium.org>
503
504         Enable running of track layout tests for Chromium
505         https://bugs.webkit.org/show_bug.cgi?id=70803
506
507         Reviewed by Adam Barth.
508         
509         Make DumpRenderTree/TestShell always run with track enabled
510         (equivalent of --enable-video-track).
511
512         * DumpRenderTree/chromium/TestShell.cpp:
513         (TestShell::TestShell):
514
515 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
516
517         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
518         https://bugs.webkit.org/show_bug.cgi?id=70603
519
520         Reviewed by Gustavo Noronha Silva.
521
522         * MiniBrowser/gtk/BrowserWindow.c:
523         (focus):
524         (unFocus):
525         (browserWindowUIClientInit):
526
527 2011-10-25  Dan Bernstein  <mitz@apple.com>
528
529         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
530
531         Reviewed by Adam Roben.
532
533         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
534         (TestWebKitAPI::TEST):
535
536 2011-10-25  Eric Seidel  <eric@webkit.org>
537
538         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
539         https://bugs.webkit.org/show_bug.cgi?id=64471
540
541         Reviewed by Adam Roben.
542
543         Speculative fix.
544
545         * Scripts/webkitpy/layout_tests/port/win.py:
546         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
547
548 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
549
550         Fix bug summary when rolling Chromium DEPS to LKGR.
551         https://bugs.webkit.org/show_bug.cgi?id=69917
552
553         Reviewed by Adam Barth.
554
555         * Scripts/webkitpy/tool/bot/irc_command.py:
556         * Scripts/webkitpy/tool/bot/sheriff.py:
557         * Scripts/webkitpy/tool/commands/roll.py:
558         * Scripts/webkitpy/tool/commands/roll_unittest.py:
559
560 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
561
562         [EFL] Build fix. Add include path to find npapi.h
563         https://bugs.webkit.org/show_bug.cgi?id=70730
564
565         Unreviewed build fix.
566
567         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
568
569 2011-10-24  Eric Seidel  <eric@webkit.org>
570
571         Plugin tests are failing after switching WK2 to NRWT
572         https://bugs.webkit.org/show_bug.cgi?id=70760
573
574         Reviewed by Simon Fraser.
575
576         Perpetuate this horrible hack.
577
578         * Scripts/webkitpy/layout_tests/port/webkit.py:
579
580 2011-10-24  Eric Seidel  <eric@webkit.org>
581
582         NRWT doesn't support ORWT's --root option, but should
583         https://bugs.webkit.org/show_bug.cgi?id=70416
584
585         Reviewed by Dirk Pranke.
586
587         Add support for ORWT's --root option which is used for
588         running tests with a nightly build of WebKit.
589
590         * Scripts/old-run-webkit-tests:
591         * Scripts/webkitpy/layout_tests/port/base.py:
592          - webkit_build_path was never called by any code, removed.
593         * Scripts/webkitpy/layout_tests/port/webkit.py:
594         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
595
596 2011-10-24  David Levin  <levin@chromium.org>
597
598         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
599         https://bugs.webkit.org/show_bug.cgi?id=70747
600
601         Reviewed by Tony Chang.
602
603         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
604         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
605
606 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
607
608         [Qt][WK2] Crash when running pixel tests
609         https://bugs.webkit.org/show_bug.cgi?id=70725
610
611         Reviewed by Chang Shu.
612
613         * WebKitTestRunner/qt/TestInvocationQt.cpp:
614         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
615
616 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
617
618         [GTK] Remove g_thread_init() calls
619         https://bugs.webkit.org/show_bug.cgi?id=70717
620
621         Reviewed by Xan Lopez.
622
623         With newer glib it's not needed anymore and with previous versions
624         it was already called by g_type_init().
625
626         * DumpRenderTree/gtk/DumpRenderTree.cpp:
627         (main):
628         * GtkLauncher/main.c:
629         (main):
630         * MiniBrowser/gtk/main.c:
631         (main):
632
633 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
634
635         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
636         https://bugs.webkit.org/show_bug.cgi?id=69403
637
638         We did not added autotoolsconfig.h to the config.h file and we
639         were adding Platform.h without the config.h in the
640         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
641         the Prefix file.
642
643         Reviewed by Martin Robinson.
644
645         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
646
647 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
648
649         [EFL] Remove unused code from EWebLauncher
650         https://bugs.webkit.org/show_bug.cgi?id=70590
651
652         Reviewed by Andreas Kling.
653
654         Removed unused function on_closeWindow from EWebLauncher
655
656         * EWebLauncher/main.c:
657
658 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
659
660         Add watchlist for WebCore/css and put myself on it.
661         https://bugs.webkit.org/show_bug.cgi?id=70701
662
663         Reviewed by Adam Barth.
664
665         * Scripts/webkitpy/common/config/watchlist:
666         Add watchlist for WebCore/css and put myself on it.
667
668 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
669
670         [GTK] Implement KeyDown function for WebKit2 EventSender.
671         https://bugs.webkit.org/show_bug.cgi?id=69410
672
673         Reviewed by Martin Robinson.
674
675         Implement the KeyDown function on Gtk platform.
676
677         * WebKitTestRunner/GNUmakefile.am:
678         * WebKitTestRunner/TestController.cpp:
679         (WTR::TestController::TestController):
680         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
681         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
682         (WTR::EventSenderProxy::EventSenderProxy):
683         (WTR::dispatchEvent):
684         (WTR::getModifiers):
685         (WTR::getGDKKeySymForKeyRef):
686         (WTR::EventSenderProxy::keyDown):
687
688 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
689
690         [WK2][GTK] run-launcher script fails after testing WK2 tests
691         https://bugs.webkit.org/show_bug.cgi?id=70676
692
693         Reviewed by Andreas Kling.
694
695         Pass the '-2' flag instead of '--webkit-test-runner' when executing
696         run-launcher script after testing with WebKitTestRunner.
697
698         * Scripts/webkitpy/layout_tests/port/gtk.py:
699
700 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
701
702         [WK2][GTK] Missing env variables cause WKTR to crash
703         https://bugs.webkit.org/show_bug.cgi?id=70674
704
705         Reviewed by Martin Robinson.
706
707         Set two environment variables that the Gtk's port of WebKitTestRunner
708         depends on and crashes if they're not explicitly set by the user.
709         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
710         properly uses the _build_path method.
711
712         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
713         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
714         environment variables.
715
716 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
717
718         Bencher script doesn't measure GC times accurately
719         https://bugs.webkit.org/show_bug.cgi?id=70588
720
721         Reviewed by Geoff Garen.
722         
723         Added two new options which allow different ways of measuring GC times:
724         
725         --measure-gc, which omits calls to gc() between benchmark invocations.
726         This option takes an optional argument, which is the name of the
727         VM in which to enable this feature. This allows comparing a single VM
728         against itself, with and without GC.
729         
730         --rerun <N>, which causes each sample measurement to include N invocations
731         which do not have gc() calls between them. The default is N = 1, which
732         results in the same behavior as before.
733         
734         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
735         N >= 3) to get more of a contribution from GC to the measured times.
736         --rerun results in tighter confidence intervals than --measure-gc, since
737         it amortizes GC effects in each sample, while with --measure-gc some
738         samples will see GC and some won't leading to a higher standard devation
739         and thus requiring more samples to reduce confidence intervals to
740         managable levels.
741
742         * Scripts/bencher:
743
744 2011-10-21  Sam Weinig  <sam@webkit.org>
745
746         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
747         https://bugs.webkit.org/show_bug.cgi?id=70653
748
749         Reviewed by Simon Fraser.
750
751         * MiniBrowser/mac/AppDelegate.h:
752         * MiniBrowser/mac/AppDelegate.m:
753         (-[BrowserAppDelegate init]):
754         (-[BrowserAppDelegate newWindow:]):
755         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
756         * MiniBrowser/mac/BrowserWindowController.h:
757         * MiniBrowser/mac/BrowserWindowController.m:
758         (-[BrowserWindowController initWithContext:pageGroup:]):
759         (-[BrowserWindowController windowWillClose:]):
760         (createNewPage):
761         (-[BrowserWindowController awakeFromNib]):
762         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
763         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
764         Update testing code to pass a PageGroup as necessary.
765
766 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
767
768         webkitpy: Teach NRWT about the EFL port
769         https://bugs.webkit.org/show_bug.cgi?id=70637
770
771         Allows using ``efl'' as a platform when executing NRWT.
772
773         Reviewed by Eric Seidel.
774
775         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
776         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
777         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
778         when using PortFactory.get(port_name='efl').
779
780 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
781
782         [Gtk] mousemove event always has metaKey == true
783         https://bugs.webkit.org/show_bug.cgi?id=35299
784
785         Reviewed by Martin Robinson.
786
787         * DumpRenderTree/gtk/EventSender.cpp:
788         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
789         keyboard events. So making it in sync with WebCore files.
790         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
791
792 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
793
794         watchlist: Add a new entry for WebKit2 GTK+ public API
795         https://bugs.webkit.org/show_bug.cgi?id=70601
796
797         Reviewed by Philippe Normand.
798
799         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
800         for patches that might include new API that points to the WebKit2
801         GTK+ API guidelines.
802
803         * Scripts/webkitpy/common/config/watchlist:
804
805 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
806
807         Remove QtScript source code from WebKit.
808         https://bugs.webkit.org/show_bug.cgi?id=64088
809
810         Reviewed by Tor Arne Vestbø.
811
812         Removed dead code that isn't developed anymore.
813
814         * Scripts/webkitpy/style/checker_unittest.py:
815
816 2011-10-20  Eric Seidel  <eric@webkit.org>
817
818         Switch webkit2 bot to NRWT
819         https://bugs.webkit.org/show_bug.cgi?id=56729
820
821         Reviewed by Adam Barth.
822
823         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
824         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
825
826         * Scripts/run-webkit-tests:
827         (runningOnBuildBot):
828         (useNewRunWebKitTests):
829
830 2011-10-20  Eric Seidel  <eric@webkit.org>
831
832         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
833         https://bugs.webkit.org/show_bug.cgi?id=70585
834
835         Reviewed by Adam Barth.
836
837         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
838         However since DRT was functioning fine before in Qt, we'll make this an error log for now
839         and once we find the root cause flip this back to an assert.
840
841         * Scripts/webkitpy/layout_tests/port/webkit.py:
842
843 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
844
845         Unreviewed, rolling out r98064.
846         http://trac.webkit.org/changeset/98064
847         https://bugs.webkit.org/show_bug.cgi?id=64788
848
849         Broke Mac bots.
850
851         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
852
853 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
854
855         WebSocket: Connecting to localhost:8880 takes one second on Windows
856         https://bugs.webkit.org/show_bug.cgi?id=64788
857
858         Reviewed by Dirk Pranke.
859
860         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
861         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
862         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
863         from timing out on Windows, because this test tries to open a lot of
864         connections to localhost and each attempt takes one second to fall back from
865         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
866
867 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
868
869         nrwt: newly generated results are put in cross-platform directory
870         https://bugs.webkit.org/show_bug.cgi?id=68931
871
872         Reviewed by Dirk Pranke.
873
874         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
875         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
876         (because png images are typically different on each platform), and passing True when .txt file is missing
877         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
878
879         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
880         * Scripts/webkitpy/layout_tests/port/test.py:
881         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
882         and added a test case.
883
884 2011-10-20  Kent Tamura  <tkent@chromium.org>
885
886         Unreviewed. Adding myself to watchlist.
887
888         * Scripts/webkitpy/common/config/watchlist:
889         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
890
891 2011-10-20  Nico Weber  <thakis@chromium.org>
892
893         [chromium/mac] Add support for building with make
894         https://bugs.webkit.org/show_bug.cgi?id=70455
895
896         Reviewed by Adam Barth.
897
898         Depends on http://codereview.chromium.org/8352029/
899         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
900         create a toplevel Makefile.chromium.
901
902         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
903         `Tools/Scripts/build-webkit --chromium` will build with make instead of
904         xcodebuild.
905
906         Also let nrwt use a binary from out/ if it exists.
907
908         * Scripts/webkitdirs.pm:
909         (determineBaseProductDir):
910         (isChromiumMacMake):
911         (determineIsChromiumMacMake):
912         (buildChromium):
913
914 2011-10-20  Eric Seidel  <eric@webkit.org>
915
916         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
917         https://bugs.webkit.org/show_bug.cgi?id=70524
918
919         Reviewed by Adam Barth.
920
921         This is a speculative fix, since I do not use a platform
922         which outputs crashlogs over stderr.
923
924         * Scripts/webkitpy/layout_tests/port/server_process.py:
925         * Scripts/webkitpy/layout_tests/port/webkit.py:
926
927 2011-10-20  Eric Seidel  <eric@webkit.org>
928
929         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
930         https://bugs.webkit.org/show_bug.cgi?id=70492
931
932         Reviewed by Adam Barth.
933
934         The bug turned out to be that I was assuming the block.content
935         would be empty before the binary content following Content-Length
936         was read inside _read_block.  Turns out its not, due to extra newlines
937         and "ExpectedHash" header.
938
939         In the process of trying to figure out what was going wrong I ended up
940         cleaning up our newline usage in DumpRenderTree a little.  Moved
941         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
942
943         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
944         per Adam's request in the original bug.
945
946         * DumpRenderTree/PixelDumpSupport.cpp:
947         (dumpWebViewAsPixelsAndCompareWithExpected):
948         * DumpRenderTree/cg/ImageDiffCG.cpp:
949         (main):
950         * DumpRenderTree/mac/DumpRenderTree.mm:
951         (dump):
952         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
953         (restoreMainDisplayColorProfile):
954         (setupMainDisplayColorProfile):
955         * Scripts/webkitpy/layout_tests/port/server_process.py:
956         * Scripts/webkitpy/layout_tests/port/webkit.py:
957         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
958
959 2011-10-20  Tony Chang  <tony@chromium.org>
960
961         [chromium] Remove <stdint.h> from ImageDiff and use
962         unsigned int instead of uint32_t.
963
964         Unreviewed, fixing the chromium win build.
965
966         * DumpRenderTree/chromium/ImageDiff.cpp:
967         (Image::pixelAt):
968         (Image::setPixelAt):
969         (maxOf3):
970         (getRedComponent):
971         (getGreenComponent):
972         (getBlueComponent):
973         (weightedPercentageDifferent):
974         (createImageDiff):
975
976 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
977
978         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
979         https://bugs.webkit.org/show_bug.cgi?id=69997
980
981         Reviewed by Tony Chang.
982
983         This change is required to make ImageDiff for Android, and can benefit
984         other platforms, too. On Android, most targets are built as
985         toolsets:target. while ImageDiff needs to be built as toolsets:host.
986         Currently, building the standalone target of ImageDiff depends on about
987         85 other targets (try  make ImageDiff'), which is inefficient. After the
988         change, ImageDiff only depends on webkit_support_gfx, which in turn
989         depends on libpng and zlib.
990
991         * DumpRenderTree/chromium/ImageDiff.cpp:
992         (main):
993
994 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
995
996         [EFL] Unreviewed DumpRenderTree build fix.
997
998         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
999         (LayoutTestController::addChromeInputField): Add stub.
1000         (LayoutTestController::removeChromeInputField): Ditto.
1001         (LayoutTestController::focusWebView): Ditto.
1002         (LayoutTestController::setBackingScaleFactor): Ditto.
1003
1004 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
1005
1006         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
1007         https://bugs.webkit.org/show_bug.cgi?id=70142
1008
1009         Reviewed by Gustavo Noronha Silva.
1010
1011         * CMakeListsEfl.txt: Include DRT CMakeLists.
1012         * DumpRenderTree/efl/CMakeLists.txt: Added.
1013
1014 2011-10-20  Philippe Normand  <pnormand@igalia.com>
1015
1016         [style] Allow usage of NULL in gst_*
1017         https://bugs.webkit.org/show_bug.cgi?id=70498
1018
1019         Reviewed by David Levin.
1020
1021         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
1022         of gst_ calls. Now just ignore NULL in all of them.
1023         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
1024
1025 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
1026
1027         [EFL] Unreviewed. Build fix after r97043.
1028
1029         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1030         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
1031         * DumpRenderTree/efl/EventSender.cpp:
1032         (scalePageByCallback): Ditto.
1033
1034 2011-10-20  Philippe Normand  <pnormand@igalia.com>
1035
1036         Unreviewed. Adding myself to watchlists.
1037         * Scripts/webkitpy/common/config/watchlist:
1038
1039 2011-10-19  Eric Seidel  <eric@webkit.org>
1040
1041         Reviewed by Adam Barth.
1042
1043         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
1044         https://bugs.webkit.org/show_bug.cgi?id=63683
1045
1046         * Scripts/webkitpy/common/net/layouttestresults.py:
1047         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1048         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1049         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1050         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1051         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1052         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1053         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1054         * Scripts/webkitpy/layout_tests/port/base.py:
1055         * Scripts/webkitpy/layout_tests/port/server_process.py:
1056         * Scripts/webkitpy/layout_tests/port/webkit.py:
1057         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1058
1059 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
1060
1061         Chromium doesn't support git branch builds, so don't add the branch to the product dir
1062         https://bugs.webkit.org/show_bug.cgi?id=70449
1063
1064         Reviewed by Eric Seidel.
1065
1066         * Scripts/webkitdirs.pm:
1067         (determineBaseProductDir):
1068
1069 2011-10-19  Ojan Vafai  <ojan@chromium.org>
1070
1071         Unreviewed. Adding myself to watchlists.
1072         * Scripts/webkitpy/common/config/watchlist:
1073
1074 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
1075
1076         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
1077         https://bugs.webkit.org/show_bug.cgi?id=62166
1078
1079         Reviewed by Eric Seidel.
1080
1081         Included options to control committer/reviewer patch count requirements,
1082         an age-limit on patches, and verbose output for more in-depth analysis.
1083
1084         * Scripts/webkitpy/common/checkout/changelog.py:
1085         * Scripts/webkitpy/tool/commands/__init__.py:
1086         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
1087         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
1088
1089 2011-10-19  Eric Seidel  <eric@webkit.org>
1090
1091         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
1092         Make NRWT normalize directory names in Skipped files during parsing.
1093
1094         Unreviewed.  Very simple (tested) change.
1095
1096         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1097         * Scripts/webkitpy/layout_tests/port/webkit.py:
1098
1099 2011-10-19  David Levin  <levin@chromium.org>
1100
1101         watchlist: Should be more robust to bad regex.
1102         https://bugs.webkit.org/show_bug.cgi?id=69486
1103
1104         Reviewed by Adam Barth.
1105
1106         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
1107           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
1108           patterns since they are no longer anchored on the right hand side.
1109         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
1110         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
1111         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
1112         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
1113         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
1114         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
1115         filenames are no longer anchored on the right hand side.
1116         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
1117         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
1118         don't kill everything.
1119
1120 2011-10-19  David Levin  <levin@chromium.org>
1121
1122         watchlist: Add a stylecheck to do validity checks for the watchlist config.
1123         https://bugs.webkit.org/show_bug.cgi?id=69487
1124
1125         Reviewed by Adam Barth.
1126
1127         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
1128         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
1129         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
1130
1131 2011-10-19  Eric Seidel  <eric@webkit.org>
1132
1133         NRWT ServerProcess can't read lines from stderr and stdio separately
1134         https://bugs.webkit.org/show_bug.cgi?id=70435
1135
1136         Reviewed by Adam Barth.
1137
1138         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
1139         DRT expects RWT to read one line at a time from stderr and stdout independently.
1140         This allows DRT to communicate errors over stderr and have them responded to immediately
1141         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
1142         class only exposed a read_line function which would read a line from stdout
1143         and batch all output from stderr into an error buffer.  Callers would only be able
1144         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
1145
1146         * Scripts/webkitpy/layout_tests/port/server_process.py:
1147         * Scripts/webkitpy/layout_tests/port/webkit.py:
1148
1149 2011-10-19  Chang Shu  <cshu@webkit.org>
1150
1151         [Qt] Support WK1-only Skipped list
1152         https://bugs.webkit.org/show_bug.cgi?id=70254
1153
1154         Reviewed by Csaba Osztrogonác.
1155
1156         Added a new search path qt-wk1 for skipping WK1-only tests.
1157
1158         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
1159         * Scripts/old-run-webkit-tests: ORWT
1160
1161 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
1162
1163         [GTK] Enable to use built-product-archive on GTK platform
1164         https://bugs.webkit.org/show_bug.cgi?id=70319
1165
1166         Reviewed by Csaba Osztrogonác.
1167
1168         * BuildSlaveSupport/built-product-archive:
1169
1170 2011-10-18  David Levin  <levin@chromium.org>
1171
1172         watchlist: Should try to run if it can and not throw on mistakes.
1173         https://bugs.webkit.org/show_bug.cgi?id=70358
1174
1175         Reviewed by Adam Barth.
1176
1177         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
1178         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
1179         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
1180         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
1181         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
1182         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
1183
1184 2011-10-18  Sam Weinig  <sam@webkit.org>
1185
1186         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
1187         https://bugs.webkit.org/show_bug.cgi?id=70387
1188
1189         Reviewed by Dan Bernstein.
1190
1191         * MiniBrowser/mac/BrowserWindowController.m:
1192         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1193         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1194         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1195         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1196         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1197         Update to include WKViewPrivate.h where necessary.
1198
1199 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
1200
1201         Web Inspector: Some localizedStrings.js Updates
1202         https://bugs.webkit.org/show_bug.cgi?id=70365
1203
1204         Reviewed by Darin Adler.
1205
1206         * Scripts/check-inspector-strings:
1207         Updated to the new webkitpy way to determine checkout root.
1208
1209         * Scripts/webkitdirs.pm:
1210         (copyInspectorFrontendFiles):
1211         Made it so build-webkit --inspector-frontend copies over
1212         the localizedStrings.js file as well as the frontend files.
1213
1214 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
1215
1216         [EFL] DRT: Clear list of visited pages before each test.
1217         https://bugs.webkit.org/show_bug.cgi?id=70355
1218
1219         Reviewed by Antonio Gomes.
1220
1221         r97596 uncovered a bug in the implementation: the list of visited
1222         links was not cleared between tests, which caused tests such as
1223         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
1224         changed depending on whether fast/repaint/border-repaint-glitch.html
1225         was visited before or not).
1226
1227         Call ewk_history_clear to make sure the visited links list does not
1228         persist between tests.
1229
1230         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1231         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1232
1233 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1234
1235         Split TestExpectationsEditor into its own file.
1236         https://bugs.webkit.org/show_bug.cgi?id=70348
1237
1238         Reviewed by Adam Barth.
1239
1240         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
1241         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
1242         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
1243         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1244         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
1245
1246 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
1247
1248         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
1249         https://bugs.webkit.org/show_bug.cgi?id=70313
1250
1251         Reviewed by Adam Barth.
1252
1253         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
1254         this parameter because build-webkit and other scripts don't accept it.
1255
1256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1257
1258 2011-10-18  Adam Barth  <abarth@webkit.org>
1259
1260         Subscribe myself to WebIDL changes
1261         https://bugs.webkit.org/show_bug.cgi?id=70341
1262
1263         Reviewed by David Levin.
1264
1265         I've also added some documentation and refactored my previous
1266         subscriptions to make it eaiser for others to subscribe as well.
1267
1268         * Scripts/webkitpy/common/config/watchlist:
1269
1270 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1271
1272         Add myself to the newfangled watchlist plumbing.
1273         https://bugs.webkit.org/show_bug.cgi?id=70338
1274
1275         Reviewed by David Levin.
1276
1277         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
1278
1279 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1280
1281         Fix a unit test in TestFailures.
1282         https://bugs.webkit.org/show_bug.cgi?id=70337
1283
1284         Reviewed by Adam Barth.
1285
1286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
1287             the value of a method property should always be lowercase.
1288
1289 2011-10-18  Adam Barth  <abarth@webkit.org>
1290
1291         Always enable ENABLE(XPATH)
1292         https://bugs.webkit.org/show_bug.cgi?id=70217
1293
1294         Reviewed by Eric Seidel.
1295
1296         * Scripts/build-webkit:
1297
1298 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1299
1300         garden-o-matic should not report flaking in expected failures as failures.
1301         https://bugs.webkit.org/show_bug.cgi?id=70279
1302
1303         Reviewed by Adam Barth.
1304
1305         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
1306         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
1307         same for garden-o-matic.
1308
1309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
1310             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
1311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
1312
1313 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
1314
1315         [Gtk] Support for client-based geolocation
1316         https://bugs.webkit.org/show_bug.cgi?id=64970
1317
1318         Reviewed by Martin Robinson.
1319
1320         Add support for testing client-based geolocation tests in DumpRenderTree.
1321
1322         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1323         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
1324         (createWebView): Create web view after declaring DumpRenderTree mode.
1325         That way a mock client for geolocation is used instead of a GeoClue
1326         client if a web view is created when testing.
1327         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
1328         geolocation layout tests.
1329         (LayoutTestController::setMockGeolocationPosition):
1330         (LayoutTestController::setMockGeolocationError):
1331         (LayoutTestController::setGeolocationPermission):
1332         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1333         * Scripts/build-webkit: Note that the Gtk port is using client-based
1334         geolocation, even though changing this flag has no effect on compilation.
1335
1336 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
1337
1338         [Chromium] suppress console output from DevTools window
1339         https://bugs.webkit.org/show_bug.cgi?id=69632
1340
1341         Reviewed by Pavel Feldman.
1342
1343         * DumpRenderTree/chromium/TestShell.cpp:
1344         (TestShell::showDevTools):
1345         * DumpRenderTree/chromium/WebViewHost.cpp:
1346         (WebViewHost::didAddMessageToConsole):
1347         (WebViewHost::reset):
1348         (WebViewHost::setLogConsoleOutput):
1349         * DumpRenderTree/chromium/WebViewHost.h:
1350
1351 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1352
1353         Unreviewed, rolling out r97735.
1354         http://trac.webkit.org/changeset/97735
1355         https://bugs.webkit.org/show_bug.cgi?id=70317
1356
1357         some people apparently use build-jsc with the qt port without
1358         building webkit first (Requested by torarne on #webkit).
1359
1360         * Scripts/build-webkit:
1361         * Scripts/webkitdirs.pm:
1362         (buildQMakeProject):
1363         (buildQMakeQtProject):
1364
1365 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1366
1367         [Qt] Remove dead code in build-webkit
1368
1369         build-webkit will iterate over a list of subdirectories to build,
1370         but this feature is only used by the Apple ports. For QtWebKit we
1371         always pass an empty directory to buildQMakeProject, which makes
1372         the logic for dealing with sub-projects in buildQMakeProject just
1373         added noise.
1374
1375         If we do want this feature at some point, we should redo it in
1376         the context of the upcoming build system changes for Qt.
1377
1378         Reviewed by Simon Hausmann.
1379
1380         * Scripts/build-webkit:
1381         * Scripts/webkitdirs.pm:
1382         (buildQt):
1383
1384 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1385
1386         Remove traces of Symbian support from the build scripts
1387
1388         Reviewed by Simon Hausmann.
1389
1390         * Scripts/build-webkit:
1391         * Scripts/webkitdirs.pm:
1392         (determineBaseProductDir):
1393         (argumentsForConfiguration):
1394         (usesPerConfigurationBuildDirectory):
1395         (buildQMakeProject):
1396
1397 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
1398
1399         Build fix after r97672.
1400
1401         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1402
1403 2011-10-17  Kent Tamura  <tkent@chromium.org>
1404
1405         A follow-up of r97716.
1406         https://bugs.webkit.org/show_bug.cgi?id=68803
1407
1408         * DumpRenderTree/chromium/LayoutTestController.cpp:
1409         (LayoutTestController::reset): Initialize m_dumpCreateView.
1410
1411 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
1412
1413         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
1414         https://bugs.webkit.org/show_bug.cgi?id=68803
1415
1416         Reviewed by Nate Chapin.
1417
1418         * DumpRenderTree/chromium/LayoutTestController.cpp:
1419         (LayoutTestController::LayoutTestController):
1420         (LayoutTestController::dumpCreateView):
1421         * DumpRenderTree/chromium/LayoutTestController.h:
1422         (LayoutTestController::shouldDumpCreateView):
1423         * DumpRenderTree/chromium/WebViewHost.cpp:
1424         (WebViewHost::createView):
1425
1426 2011-10-17  Nate Chapin  <japhet@chromium.org>
1427
1428         Add myself to watchlists, and add a watch
1429         for Source/WebCore/loader/.
1430         https://bugs.webkit.org/show_bug.cgi?id=70263
1431
1432         Reviewed by David Levin.
1433
1434         * Scripts/webkitpy/common/config/watchlist:
1435
1436 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1437
1438         [EFL] DRT: Make non-recognized keys work in events as well.
1439         https://bugs.webkit.org/show_bug.cgi?id=69860
1440
1441         Reviewed by Antonio Gomes.
1442
1443         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
1444         here: it has a select box with a few non-latin options, and one of them
1445         is selected via the keyboard.
1446
1447         In this specific case, we need to make EventHandler::keyEvent send a
1448         keyPressEvent to SelectElement, so that
1449         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
1450         only when PlatformKeyEvent::text() is not empty, which was not the case
1451         so far.
1452
1453         * DumpRenderTree/efl/EventSender.cpp:
1454         (keyDownCallback):
1455
1456 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
1457
1458         Add layout tests for WebPlugin compositor path
1459         https://bugs.webkit.org/show_bug.cgi?id=69027
1460
1461         Reviewed by James Robinson.
1462
1463         * DumpRenderTree/DumpRenderTree.gypi:
1464         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
1465         (premultiplyAlpha):
1466         (TestWebPlugin::TestWebPlugin):
1467         (TestWebPlugin::~TestWebPlugin):
1468         (TestWebPlugin::mimeType):
1469         (TestWebPlugin::initialize):
1470         (TestWebPlugin::destroy):
1471         (TestWebPlugin::updateGeometry):
1472         (TestWebPlugin::parsePrimitive):
1473         (TestWebPlugin::parseColor):
1474         (TestWebPlugin::parseOpacity):
1475         (TestWebPlugin::initScene):
1476         (TestWebPlugin::drawScene):
1477         (TestWebPlugin::destroyScene):
1478         (TestWebPlugin::initProgram):
1479         (TestWebPlugin::initPrimitive):
1480         (TestWebPlugin::drawPrimitive):
1481         (TestWebPlugin::loadShader):
1482         (TestWebPlugin::loadProgram):
1483         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
1484         (TestWebPlugin::scriptableObject):
1485         (TestWebPlugin::paint):
1486         (TestWebPlugin::updateFocus):
1487         (TestWebPlugin::updateVisibility):
1488         (TestWebPlugin::acceptsInputEvents):
1489         (TestWebPlugin::handleInputEvent):
1490         (TestWebPlugin::didReceiveResponse):
1491         (TestWebPlugin::didReceiveData):
1492         (TestWebPlugin::didFinishLoading):
1493         (TestWebPlugin::didFailLoading):
1494         (TestWebPlugin::didFinishLoadingFrameRequest):
1495         (TestWebPlugin::didFailLoadingFrameRequest):
1496         (TestWebPlugin::Scene::Scene):
1497         * DumpRenderTree/chromium/WebViewHost.cpp:
1498         (WebViewHost::createPlugin):
1499
1500 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
1501
1502         [nrwt] Add new category for MISSING
1503         https://bugs.webkit.org/show_bug.cgi?id=69990
1504
1505         Reviewed by Dirk Pranke.
1506
1507         Treat missing results as a new category in summerize_results.
1508
1509         Because Chromium port wants to turn bots red when there are tests with missing results,
1510         extracted the logic to compute the exit code as exit_code_from_summarized_results in
1511         base and chromium ports.
1512
1513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1514         * Scripts/webkitpy/layout_tests/port/base.py:
1515         * Scripts/webkitpy/layout_tests/port/chromium.py:
1516         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1517
1518 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
1519
1520         garden-o-matic operations fail because of CSP.
1521         https://bugs.webkit.org/show_bug.cgi?id=70249
1522
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
1524
1525 2011-10-17  Ada Chan  <adachan@apple.com>
1526
1527         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
1528         https://bugs.webkit.org/show_bug.cgi?id=70168
1529
1530         Reviewed by Alexey Proskuryakov.
1531
1532         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
1533         (TestWebKitAPI::didFinishLoadForFrame):
1534         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
1535
1536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1537         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1538         Add the new file.
1539
1540 2011-10-17  Darin Adler  <darin@apple.com>
1541
1542         Add some more *.pyc ignores in directories with Python scripts.
1543
1544         * QueueStatusServer: Added property svn:ignore.
1545         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
1546         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
1547         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
1548
1549 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
1550
1551         [Qt][WK2][meta] Fix failing API tests
1552         https://bugs.webkit.org/show_bug.cgi?id=70236
1553
1554         Reviewed by Csaba Osztrogonác.
1555
1556         In order to run WebKit2 API tests we need the WebProcess to be in
1557         the path so let's add the bin directory when running the API tests of Qt.
1558
1559         * Scripts/run-qtwebkit-tests:
1560
1561 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1562
1563         [Qt][WK2] Build dependency problems
1564         https://bugs.webkit.org/show_bug.cgi?id=68456
1565
1566         Reviewed by Csaba Osztrogonác.
1567
1568         * Scripts/webkitdirs.pm:
1569         (buildQMakeProject):
1570
1571 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1572
1573         [build] Introduce Qt/SH4 buildbot
1574         https://bugs.webkit.org/show_bug.cgi?id=70227
1575
1576         Reviewed by Adam Roben.
1577
1578         Add buildslave for Linux/Qt/SH4.
1579
1580         * BuildSlaveSupport/build.webkit.org-config/config.json:
1581
1582 2011-10-16  Adam Barth  <abarth@webkit.org>
1583
1584         Always enable ENABLE(DOM_STORAGE)
1585         https://bugs.webkit.org/show_bug.cgi?id=70189
1586
1587         Reviewed by Eric Seidel.
1588
1589         * Scripts/build-webkit:
1590         * waf/build/settings.py:
1591
1592 2011-10-15  Adam Barth  <abarth@webkit.org>
1593
1594         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
1595         https://bugs.webkit.org/show_bug.cgi?id=70194
1596
1597         Reviewed by Daniel Bates.
1598
1599         * Scripts/build-webkit:
1600
1601 2011-10-15  Ojan Vafai  <ojan@chromium.org>
1602
1603         run-webkit-tests should accept --child-processes
1604         https://bugs.webkit.org/show_bug.cgi?id=69713
1605
1606         Reviewed by Adam Barth.
1607
1608         Only set --child-processes=1 if --child-processes it not
1609         passed on the commandline.
1610
1611         * Scripts/run-webkit-tests:
1612
1613 2011-10-15  Daniel Bates  <dbates@webkit.org>
1614
1615         Extract common gdb code into its own function; Remove script gdb-safari
1616         https://bugs.webkit.org/show_bug.cgi?id=68499
1617
1618         Reviewed by David Kilzer.
1619
1620         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
1621         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
1622         We should extract the common parts into a function that can be shared by all callers
1623         so as to remove duplicate code.
1624
1625         As a side effect of removing duplicate code we can remove the script gdb-safari since
1626         its code has been incorporated into webkitdirs::debugSafari() which is called by the
1627         script debug-safari.
1628
1629         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
1630         * Scripts/gdb-safari: Removed.
1631         * Scripts/webkitdirs.pm:
1632         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
1633         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
1634         script gdb-safari to here.
1635         (debugSafari): Added.
1636         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
1637         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
1638         runSafari() always returns 1 on Windows and the script run-safari exits using this
1639         value as its exit status. Hence, the script run-safari always exits with a nonzero
1640         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
1641         exit status of the WebKit launcher application.
1642         (debugMiniBrowser): Modified to call debugMacWebKitApp().
1643         (debugWebKitTestRunner): Ditto.
1644
1645 2011-10-15  Robert Hogan  <robert@webkit.org>
1646
1647         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
1648         https://bugs.webkit.org/show_bug.cgi?id=70056
1649
1650         Reviewed by Adam Barth.
1651
1652         The preferred file-order for patches is LayoutTests at the end and
1653         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
1654         it when creating patches for review and landing.
1655
1656         * Scripts/webkitpy/common/checkout/scm/git.py:
1657         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1658         * Scripts/webkitpy/common/config/orderfile: Added.
1659
1660 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1661
1662         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
1663         https://bugs.webkit.org/show_bug.cgi?id=69920
1664
1665         Reviewed by Kenneth Rohde Christiansen.
1666
1667         * DumpRenderTree/qt/DumpRenderTree.pro:
1668         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1669         (WebCore::DumpRenderTree::open):
1670         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1671         * QtTestBrowser/QtTestBrowser.pro:
1672         * QtTestBrowser/launcherwindow.cpp:
1673         (LauncherWindow::screenshot):
1674         (LauncherWindow::showFPS):
1675         (LauncherWindow::updateFPS):
1676         * QtTestBrowser/launcherwindow.h:
1677         (WindowOptions::WindowOptions):
1678         * QtTestBrowser/mainwindow.cpp:
1679         (MainWindow::buildUI):
1680         * Scripts/webkitpy/style/checker.py: Remove rules for the
1681         WebKit/qt/symbian/platformplugin directory.
1682         * Scripts/webkitpy/style/checker_unittest.py:
1683         * Tools.pro:
1684         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1685         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1686         (WTR::LayoutTestController::platformInitialize):
1687         * WebKitTestRunner/qt/TestControllerQt.cpp:
1688         (WTR::isExistingLibrary):
1689         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1690
1691 2011-10-15  Adam Barth  <abarth@webkit.org>
1692
1693         Fix typo in webkitpy help
1694         https://bugs.webkit.org/show_bug.cgi?id=70169
1695
1696         Reviewed by Eric Seidel.
1697
1698         * Scripts/webkitpy/tool/commands/upload.py:
1699
1700 2011-10-15  Tony Chang  <tony@chromium.org>
1701
1702         fix another typo in treemap.html
1703         https://bugs.webkit.org/show_bug.cgi?id=70149
1704
1705         Reviewed by Ojan Vafai.
1706
1707         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
1708
1709         * TestResultServer/static-dashboards/treemap.html:
1710
1711 2011-10-14  Adam Barth  <abarth@webkit.org>
1712
1713         Hide status bubbles from queues which are very far behind
1714         https://bugs.webkit.org/show_bug.cgi?id=70133
1715
1716         Reviewed by Eric Seidel.
1717
1718         The mac-ews is so far behind that we shouldn't show its status bubble.
1719         The status bubble just makes contributors sad.
1720
1721         * QueueStatusServer/handlers/statusbubble.py:
1722
1723 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
1724
1725         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
1726         https://bugs.webkit.org/show_bug.cgi?id=70143
1727
1728         Reviewed by Adam Barth.
1729
1730         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
1731         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
1732
1733 2011-10-14  David Levin  <levin@chromium.org>
1734
1735         watchlist: Add a validation check for the email names in the list.
1736         https://bugs.webkit.org/show_bug.cgi?id=70154
1737
1738         Reviewed by Adam Barth.
1739
1740         If an email is listed which doesn't have a bugzilla log in, then any emails
1741         added to the bug along with that email will fail to happen, so try to prevent this
1742         from happening by validating that emails added to the watchlist are known to be
1743         contributors.
1744
1745         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
1746         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
1747         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
1748
1749 2011-10-14  David Levin  <levin@chromium.org>
1750
1751         watchlist: If the style check fails, then the watchlist will not be run.
1752         https://bugs.webkit.org/show_bug.cgi?id=69484
1753
1754         Reviewed by Adam Barth.
1755
1756         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
1757         if the style part fails and don't allow watch list failures turn the
1758         bot run red.
1759         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
1760         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
1761
1762 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
1763
1764         Plumb style-checker filter up to command options and make land-cowboy use it.
1765         https://bugs.webkit.org/show_bug.cgi?id=70119
1766
1767         Reviewed by Adam Barth.
1768
1769         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
1770         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
1771         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
1772         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
1773         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
1774         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
1775         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
1776
1777 2011-10-14  Sam Weinig  <sam@webkit.org>
1778
1779         Remove the Leopard slaves.
1780
1781         Reviewed by Adam Roben.
1782
1783         * BuildSlaveSupport/build.webkit.org-config/config.json:
1784
1785 2011-10-14  Peter Beverloo  <peter@chromium.org>
1786
1787         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
1788         https://bugs.webkit.org/show_bug.cgi?id=70028
1789
1790         Reviewed by Adam Barth.
1791
1792         * Scripts/update-webkit-chromium:
1793         * Scripts/webkitdirs.pm:
1794         (buildChromiumMakefile):
1795         (buildChromium):
1796
1797 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
1798
1799         Unreviewed; add missing #includes.
1800
1801         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1802         * DumpRenderTree/efl/EventSender.cpp:
1803
1804 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1805
1806         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
1807         https://bugs.webkit.org/show_bug.cgi?id=69770
1808
1809         Reviewed by Antonio Gomes.
1810
1811         We were just appending the given URL to the absolute URI of the main
1812         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
1813         instead of "file:///foo/bar/theother/url.html".
1814
1815         This should make fast/dom/navigation-type-navigate.html behave
1816         better (it still fails, but later).
1817
1818         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1819         (LayoutTestController::queueLoad):
1820
1821 2011-10-13  Arko Saha  <arko@motorola.com>
1822
1823         Microdata: Basic implementation of document.getItems() method.
1824         https://bugs.webkit.org/show_bug.cgi?id=68610
1825
1826         Reviewed by Ryosuke Niwa.
1827
1828         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
1829         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
1830
1831         * Scripts/build-webkit:
1832
1833 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1834
1835         new-run-webkit-tests does not support qt-4.8 results
1836         https://bugs.webkit.org/show_bug.cgi?id=64071
1837
1838         Roll-back second part of r97252. :)
1839
1840         * Scripts/webkitpy/layout_tests/port/qt.py:
1841
1842 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1843
1844         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
1845         https://bugs.webkit.org/show_bug.cgi?id=70106
1846
1847         Reviewed by Antonio Gomes.
1848
1849         OwnFastMallocPtr was being used as a smart pointer that automatically called
1850         free() on the strings returned by the EFL or by ewk.
1851
1852         However, when WTF is built in release mode, it uses its own memory management
1853         code instead of using the system malloc(), free() and friends. This means bad
1854         things will happen when one uses WTF's free() on memory allocated with system
1855         malloc() by the EFL or ewk.
1856
1857         The easiest way to solve this is to call free() ourselves.
1858
1859         * DumpRenderTree/efl/DumpRenderTree.cpp:
1860         (dumpFramesAsText):
1861         (getFinalTestURL):
1862
1863 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1864
1865         [EFL] Add DumpRenderTreeSupportEfl
1866         https://bugs.webkit.org/show_bug.cgi?id=68458
1867
1868         Reviewed by Kenneth Rohde Christiansen.
1869
1870         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
1871
1872         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1873         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
1874         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1875         (DumpRenderTreeChrome::onWindowObjectCleared):
1876         (DumpRenderTreeChrome::onDocumentLoadFinished):
1877         * DumpRenderTree/efl/GCControllerEfl.cpp:
1878         (GCController::collect):
1879         (GCController::collectOnAlternateThread):
1880         (GCController::getJSObjectCount):
1881         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1882         (LayoutTestController::counterValueForElementById):
1883         (LayoutTestController::pageNumberForElementById):
1884         (LayoutTestController::numberOfPages):
1885         (LayoutTestController::workerThreadCount):
1886         (LayoutTestController::findString):
1887         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1888         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1889         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1890         (LayoutTestController::numberOfActiveAnimations):
1891         (LayoutTestController::suspendAnimations):
1892         (LayoutTestController::resumeAnimations):
1893         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1894         (createBitmapContextFromWebView):
1895
1896 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1897
1898         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
1899
1900         Unreviewed.
1901
1902         * Scripts/run-webkit-tests:
1903         (useNewRunWebKitTests):
1904
1905 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1906
1907         new-run-webkit-tests does not support qt-4.8 results
1908         https://bugs.webkit.org/show_bug.cgi?id=64071
1909
1910         Roll-back r97252 with unit test fix.
1911
1912         Reviewed by Csaba Osztrogonác.
1913
1914         * Scripts/webkitpy/layout_tests/port/qt.py:
1915         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1916
1917 2011-10-13  Ojan Vafai  <ojan@chromium.org>
1918
1919         Make filter-build-webkit exit 1 if the build fails.
1920         https://bugs.webkit.org/show_bug.cgi?id=70080
1921
1922         Reviewed by Eric Seidel.
1923
1924         This only works if you redirect stderr to stdout, but it at least makes it possible.
1925         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
1926         only if the build succeeds.
1927
1928         * Scripts/filter-build-webkit:
1929
1930 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
1931
1932         land-cowboy should at least check style.
1933         https://bugs.webkit.org/show_bug.cgi?id=70073
1934
1935         Reviewed by Adam Barth.
1936
1937         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
1938
1939 2011-10-13  Tony Chang  <tony@chromium.org>
1940
1941         fix regex in layout test times dashboard
1942         https://bugs.webkit.org/show_bug.cgi?id=70059
1943
1944         This fixes the treemapfocus query param.
1945
1946         Reviewed by Ojan Vafai.
1947
1948         * TestResultServer/static-dashboards/treemap.html:
1949
1950 2011-10-13  Beth Dakin  <bdakin@apple.com>
1951
1952         https://bugs.webkit.org/show_bug.cgi?id=70050
1953         DRT and WRT should have HiDPI testing capabilities
1954
1955         Reviewed by Darin Adler.
1956
1957         New layoutTestController function setBackingScaleFactor takes a double for a scale 
1958         factor and a callback function to call once the backing scale factor has 
1959         successfully been set for the view.
1960         * DumpRenderTree/LayoutTestController.cpp:
1961         (setBackingScaleFactorCallback):
1962         (LayoutTestController::staticFunctions):
1963
1964         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
1965         platforms do nothing.
1966         * DumpRenderTree/LayoutTestController.h:
1967         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1968         (LayoutTestController::setBackingScaleFactor):
1969         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1970         (LayoutTestController::setBackingScaleFactor):
1971         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1972         (LayoutTestController::setBackingScaleFactor):
1973
1974         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
1975         value of 0, which resets to the system default.
1976         * DumpRenderTree/mac/DumpRenderTree.mm:
1977         (resetWebViewToConsistentStateBeforeTesting):
1978
1979         When generating the pixel dump, create a Bitmap of the appropriate size based on 
1980         the backing scale factor. If it is a HiDPI view, paint into the context using 
1981         displayRectIgnoringOpacity.
1982         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1983         (createBitmapContextFromWebView):
1984
1985         And now the same stuff for WK2. Again, new layoutTestController function 
1986         setBackingScaleFactor takes a double for a scale factor and a callback function. 
1987         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1988         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1989         (WTR::LayoutTestController::setBackingScaleFactor):
1990         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
1991         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1992
1993         The InjectedBundle sends a message to the UI process to set the backing scale 
1994         factor. It also processes a message the UI process will send back once it 
1995         completes this task, and at that time, the InjectedBundle calls the callback.
1996         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1997         (WTR::InjectedBundle::didReceiveMessage):
1998         (WTR::InjectedBundle::postSetBackingScaleFactor):
1999         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2000
2001         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
2002         with a value of 0, which resets to the system default.
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::resetStateToConsistentValues):
2005
2006         Upon receiving the SetBackingScaleFactor message, call 
2007         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
2008         back to InjectedBundle to say it has been done.
2009         * WebKitTestRunner/TestInvocation.cpp:
2010         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2011         
2012         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
2013         window's scale factor so we have to avoid that.
2014         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2015         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2016
2017 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
2018
2019         [Chromium] Allow building without speech input enabled.
2020         https://bugs.webkit.org/show_bug.cgi?id=69867
2021
2022         Reviewed by Darin Fisher.
2023
2024         * DumpRenderTree/chromium/LayoutTestController.cpp:
2025         (LayoutTestController::addMockSpeechInputResult):
2026
2027 2011-10-13  Kent Tamura  <tkent@chromium.org>
2028
2029         [Chromium] A DRT fix for r97348.
2030
2031         * DumpRenderTree/chromium/LayoutTestController.cpp:
2032         (LayoutTestController::overridePreference):
2033         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
2034         print an error message.
2035
2036 2011-10-12  Lucas Forschler  <lforschler@apple.com>
2037
2038         Update kill-old-processes logic.
2039         https://bugs.webkit.org/show_bug.cgi?id=63651
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         Remove unused mac platform specific folder.
2044         Update master.config to use new kill-old-processes.
2045
2046         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2047         * BuildSlaveSupport/kill-old-processes:
2048         * BuildSlaveSupport/mac: Removed.
2049
2050 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
2051
2052         [NRWT] New tests without expected files are reported as flakey tests
2053         https://bugs.webkit.org/show_bug.cgi?id=67268
2054
2055         Reviewed by Dirk Pranke.
2056
2057         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
2058         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
2059         for missing results in retry_summary.
2060
2061         Fixed the bug by treating missing results separately.
2062
2063         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2064         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2065
2066 2011-10-12  Adam Barth  <abarth@webkit.org>
2067
2068         Remove ENABLE(XHTMLMP) and associated code
2069         https://bugs.webkit.org/show_bug.cgi?id=69729
2070
2071         Reviewed by David Levin.
2072
2073         * Scripts/build-webkit:
2074         * Scripts/old-run-webkit-tests:
2075         * Scripts/webkitperl/features.pm:
2076         * Scripts/webkitpy/layout_tests/port/webkit.py:
2077         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2078
2079 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
2080
2081         Kill old run-webkit-tests processes in kill-process on Mac
2082         https://bugs.webkit.org/show_bug.cgi?id=69976
2083
2084         Reviewed by Dirk Pranke.
2085
2086         Add a system call to remove all python processes running run-webkit-tests.
2087
2088         * BuildSlaveSupport/kill-old-processes:
2089         * BuildSlaveSupport/mac: Removed.
2090
2091 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
2092
2093         Many WK2 snapshots are blank
2094         https://bugs.webkit.org/show_bug.cgi?id=69953
2095
2096         Reviewed by Beth Dakin.
2097         
2098         Two fixes:
2099         1. negating a size_t in CGContextTranslateCTM() fails, because
2100         size_t is unsigned. Fix by casing to CGFloat before negation.
2101         
2102         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
2103         Autodisplay is necessary to kick off Core Animation rendering.
2104
2105         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2106         (WTR::createCGContextFromImage):
2107         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2108         (WTR::PlatformWebView::PlatformWebView):
2109
2110 2011-10-12  Adam Barth  <abarth@webkit.org>
2111
2112         commit-queue doesn't have a friendly error message when the reviewer line is messed up
2113         https://bugs.webkit.org/show_bug.cgi?id=69979
2114
2115         Reviewed by Eric Seidel.
2116
2117         Rather than combining the ChangeLog validation with a more complicated
2118         command, this patch has the commit-queue run it as a separate command,
2119         which will give us more control over the error message.
2120
2121         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2122         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2123         * Scripts/webkitpy/tool/commands/download.py:
2124         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2125         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2126         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2127
2128 2011-10-12  Eric Seidel  <eric@webkit.org>
2129
2130         Layout tests asserting in LayoutTestController::pathToLocalResource()
2131         https://bugs.webkit.org/show_bug.cgi?id=69898
2132
2133         Reviewed by Simon Fraser.
2134
2135         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
2136
2137         * Scripts/old-run-webkit-tests:
2138         (openDumpTool):
2139
2140 2011-10-12  Adam Barth  <abarth@webkit.org>
2141
2142         The commit-queue doesn't tell me which tests my patch broke
2143         https://bugs.webkit.org/show_bug.cgi?id=69975
2144
2145         Reviewed by Eric Seidel.
2146
2147         We now print the list of newly failing tests, like we do for the EWS.
2148
2149         * Scripts/webkitpy/tool/commands/queues.py:
2150         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2151
2152 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
2153
2154         Added myself as a committer.
2155
2156         * Scripts/webkitpy/common/config/committers.py:
2157
2158 2011-10-12  Adam Barth  <abarth@webkit.org>
2159
2160         _run_tests is a confusing variable name in webkitpy
2161         https://bugs.webkit.org/show_bug.cgi?id=69971
2162
2163         Reviewed by Eric Seidel.
2164
2165         Eric and I thought this was a function.
2166
2167         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2168
2169 2011-10-12  Tony Chang  <tony@chromium.org>
2170
2171         Fix test-webkitpy after r97307 and r97293.
2172
2173         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
2174           is None during tests so add back the check.
2175         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
2176           output directory is now build/Debug.
2177
2178 2011-10-12  Tony Chang  <tony@chromium.org>
2179
2180         [chromium] remove old build dirs on chromium-win
2181         https://bugs.webkit.org/show_bug.cgi?id=69961
2182
2183         Reviewed by Adam Barth.
2184
2185         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
2186           always in build and never in chrome or webkit.
2187
2188 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
2189
2190         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
2191         https://bugs.webkit.org/show_bug.cgi?id=69954
2192
2193         Also renamed the action and associated event name to address an FIXME.
2194
2195         Reviewed by Adam Barth.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
2200
2201 2011-10-12  Tony Chang  <tony@chromium.org>
2202
2203         stop spamming 'stopping test driver timed out, killing it' when running rwt
2204         https://bugs.webkit.org/show_bug.cgi?id=69938
2205
2206         Reviewed by Adam Barth.
2207
2208         In http://trac.webkit.org/changeset/95875 , we made the timeout for
2209         stopping the driver based on time_out_ms, but we based it on the wrong
2210         default times.
2211
2212         * Scripts/webkitpy/layout_tests/port/chromium.py:
2213
2214 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
2215
2216         3D transforms are flattened in WebKit2 snapshots
2217         https://bugs.webkit.org/show_bug.cgi?id=68276
2218
2219         Reviewed by Adam Roben.
2220         
2221         Fix WKImage leak noticed by Adam.
2222
2223         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2224         (WTR::PlatformWebView::windowSnapshotImage):
2225
2226 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
2227
2228         garden-o-matic should color-code test failure types.
2229         https://bugs.webkit.org/show_bug.cgi?id=69945
2230
2231         Reviewed by Adam Barth.
2232
2233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
2236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
2237
2238 2011-10-12  Adam Barth  <abarth@webkit.org>
2239
2240         webkitpy tests are failing on Mac bots
2241         https://bugs.webkit.org/show_bug.cgi?id=69929
2242
2243         Reviewed by Simon Fraser.
2244
2245         Admit that Lion exists.
2246
2247         * Scripts/webkitpy/layout_tests/port/chromium.py:
2248         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2249
2250 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
2251
2252         Improve output of run-api-tests to make time-outs more obvious
2253         https://bugs.webkit.org/show_bug.cgi?id=69788
2254
2255         Reviewed by Adam Roben.
2256         
2257         List the tests that failed and timed out at the bottom of the output,
2258         if run with --verbose.
2259
2260         * Scripts/run-api-tests:
2261         (runAllTests):
2262         (runTest):
2263
2264 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2265
2266         Unreviewed, rolling out r97252.
2267         http://trac.webkit.org/changeset/97252
2268         https://bugs.webkit.org/show_bug.cgi?id=69944
2269
2270         Broke test-webkpy (Requested by abarth on #webkit).
2271
2272         * Scripts/webkitpy/layout_tests/port/qt.py:
2273         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2274
2275 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2276
2277         new-run-webkit-tests does not support qt-4.8 results
2278         https://bugs.webkit.org/show_bug.cgi?id=64071
2279
2280         Reviewed by Csaba Osztrogonác.
2281
2282         * Scripts/webkitpy/layout_tests/port/qt.py:
2283         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2284
2285 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
2286
2287         [GTK] [WebKit2] Make adding another unit test easier
2288         https://bugs.webkit.org/show_bug.cgi?id=69409
2289
2290         Reviewed by Gustavo Noronha Silva.
2291
2292         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
2293         new WebKit2 tests.
2294
2295 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
2296
2297         [WebSocket] update pywebsocket to 0.6b6.
2298         https://bugs.webkit.org/show_bug.cgi?id=69824
2299
2300         Reviewed by Kent Tamura.
2301
2302         WebKit supports WebSocket with version 8 based protocol for now.
2303         We should update its protocol to version 13 based one like hybi-17.
2304         pywebsocket 0.6b6 supports both of version 8 and 13.
2305
2306         * Scripts/webkitpy/thirdparty/__init__.py:
2307
2308 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
2309
2310         WebKitTestRunner needs to link with WebKit for NSURL category methods
2311         https://bugs.webkit.org/show_bug.cgi?id=69892
2312
2313         Reviewed by Sam Weinig.
2314         
2315         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
2316         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
2317         WebKit.framework to fix this.
2318
2319         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2320
2321 2011-10-11  Adam Barth  <abarth@webkit.org>
2322
2323         sheriffbot takes too long to acknowledge rollout commands
2324         https://bugs.webkit.org/show_bug.cgi?id=69871
2325
2326         Reviewed by Eric Seidel.
2327
2328         We used to update the working copy before acknowledging the command
2329         because we wanted to ping all the relevant IRC nicks.  That's caused a
2330         bunch of frustration because folks don't know whether the bot has heard
2331         their commands.
2332
2333         This patch makes the bot reply immediately before updating the working
2334         copy.  All the relevenat folks are still pinged when the bot finishes
2335         preparing the rollout.
2336
2337         * Scripts/webkitpy/tool/bot/irc_command.py:
2338         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2339
2340 2011-10-11  Adam Barth  <abarth@webkit.org>
2341
2342         test-webkitpy fails on Lion
2343         https://bugs.webkit.org/show_bug.cgi?id=69873
2344
2345         Reviewed by Eric Seidel.
2346
2347         This patch fixes one of the two failures.  I'll need to track down the
2348         other failure another time.
2349
2350         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2351
2352 2011-10-11  Adam Barth  <abarth@webkit.org>
2353
2354         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
2355         https://bugs.webkit.org/show_bug.cgi?id=65230
2356
2357         Reviewed by Dimitri Glazkov.
2358
2359         This patch causes us to treat crashed or hung run-webkit-tests runs
2360         similarly to how we treat compile failures.  In some sense, they're
2361         similar because they prevent us from getting test coverage.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2365
2366 2011-10-11  Adam Barth  <abarth@webkit.org>
2367
2368         Failing builder display in garden-o-matic should have the same visual style as the failure grid
2369         https://bugs.webkit.org/show_bug.cgi?id=69876
2370
2371         Reviewed by Dimitri Glazkov.
2372
2373         This patch generalizes the view we use for failing builders in the
2374         FailureGrid so that we can use it for the list of builders that aren't
2375         compiling.
2376
2377         One downside of this patch is that it makes it harder to tell when
2378         debug builders are failing (as opposed to release builders) because
2379         that information isn't presented in this view.  A future patch will
2380         improve this aspect.
2381
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2388
2389 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
2390
2391         Some API tests are timing out in Release
2392         https://bugs.webkit.org/show_bug.cgi?id=69787
2393
2394         Reviewed by Mark Rowe.
2395         
2396         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
2397         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
2398
2399         * TestWebKitAPI/Configurations/Base.xcconfig:
2400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2401         * TestWebKitAPI/config.h:
2402
2403 2011-10-11  Adam Barth  <abarth@webkit.org>
2404
2405         garden-o-matic links to flakiness dashboard should open in a new tab
2406         https://bugs.webkit.org/show_bug.cgi?id=69864
2407
2408         Reviewed by Dimitri Glazkov.
2409
2410         This bug was obvious in the first five minutes of using this new
2411         feature.  :)
2412
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2415
2416 2011-10-11  Adam Barth  <abarth@webkit.org>
2417
2418         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
2419         that * doesn't really mean "all".  I've emailed the W3C working group
2420         about changing the spec.
2421
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2423
2424 2011-10-11  Adam Barth  <abarth@webkit.org>
2425
2426         garden-o-matic should link to the flakiness dashboard
2427         https://bugs.webkit.org/show_bug.cgi?id=69862
2428
2429         Reviewed by Dimitri Glazkov.
2430
2431         The flakiness dashboard has lots of great information about the failure
2432         history of each test.  This patch adds a link from garden-o-matic to
2433         the flakiness dashboard so the gardener can look at this information.
2434
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2438
2439 2011-10-11  David Levin  <levin@chromium.org>
2440
2441         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
2442         https://bugs.webkit.org/show_bug.cgi?id=69789
2443
2444         Reviewed by Eric Seidel.
2445
2446         Made the signature of _assertRaisesRegexp match that of Python 2.7.
2447
2448         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
2449         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
2450         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
2451         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
2452
2453 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
2454
2455         [EFL] DRT: Do not abort() when an unknown key is pressed.
2456         https://bugs.webkit.org/show_bug.cgi?id=69856
2457
2458         Reviewed by Antonio Gomes.
2459
2460         A lot of tests crash due to the previous behaviour. Just using the
2461         received name of the pressed key works most of the time, and when it
2462         does not the failing tests should tell us.
2463
2464         * DumpRenderTree/efl/EventSender.cpp:
2465         (keyPadNameFromJSValue):
2466         (keyNameFromJSValue):
2467         (keyDownCallback):
2468
2469 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2470
2471         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
2472         https://bugs.webkit.org/show_bug.cgi?id=68016
2473
2474         Reviewed by Chang Shu.
2475
2476         * Scripts/webkitpy/layout_tests/port/qt.py:
2477
2478 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
2479
2480         [EFL] DRT: Return the right window count in LayoutTestController.
2481         https://bugs.webkit.org/show_bug.cgi?id=69764
2482
2483         Reviewed by Antonio Gomes.
2484
2485         Follow-up to r96943: now that we have DumpRenderTreeChrome and
2486         DumpRenderTreeView in the tree, we can correctly count the number of
2487         open windows in DRT.
2488
2489         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2490         (LayoutTestController::windowCount):
2491
2492 2011-10-11  Jer Noble  <jer.noble@apple.com>
2493
2494         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
2495         https://bugs.webkit.org/show_bug.cgi?id=69800
2496
2497         Reviewed by Csaba Osztrogonác.
2498
2499         Enable WEB_AUDIO at runtime.
2500
2501         * DumpRenderTree/mac/DumpRenderTree.mm:
2502         (resetDefaultsToConsistentValues):
2503
2504 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
2505
2506         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
2507         https://bugs.webkit.org/show_bug.cgi?id=69769
2508
2509         Reviewed by Antonio Gomes.
2510
2511         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2512         (LayoutTestController::setIconDatabaseEnabled):
2513
2514 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2515
2516         [Qt] Remove all references to QTDIR_build and standalone_package
2517
2518         Qt is now modularized, which means we no longer import WebKit into
2519         the Qt source tree. Instead we use git submodules, and building
2520         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
2521
2522         To decrease the number of buildsystem configurations we also remove
2523         the standalone_package code-path used when we were providing tarballs
2524         with the derived sources pre-generated.
2525
2526         Reviewed by Simon Hausmann.
2527
2528         * MiniBrowser/qt/MiniBrowser.pro:
2529         * QtTestBrowser/QtTestBrowser.pro:
2530         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2531
2532 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
2533
2534         Update Chromium accessibility support in DRT.
2535         https://bugs.webkit.org/show_bug.cgi?id=69676
2536
2537         Reviewed by Chris Fleizach.
2538
2539         Adds several missing properties and methods to enable more
2540         tests to pass, and in particular adds support for notification
2541         callbacks.
2542
2543         * DumpRenderTree/chromium/AccessibilityController.cpp:
2544         (AccessibilityController::AccessibilityController):
2545         (AccessibilityController::reset):
2546         (AccessibilityController::getFocusedElement):
2547         (AccessibilityController::shouldLogAccessibilityEvents):
2548         (AccessibilityController::notificationReceived):
2549         (AccessibilityController::logAccessibilityEventsCallback):
2550         * DumpRenderTree/chromium/AccessibilityController.h:
2551         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2552         (getHelpText):
2553         (getStringValue):
2554         (getOrientation):
2555         (AccessibilityUIElement::AccessibilityUIElement):
2556         (AccessibilityUIElement::getChildAtIndex):
2557         (AccessibilityUIElement::isEqual):
2558         (AccessibilityUIElement::notificationReceived):
2559         (AccessibilityUIElement::roleGetterCallback):
2560         (AccessibilityUIElement::titleGetterCallback):
2561         (AccessibilityUIElement::descriptionGetterCallback):
2562         (AccessibilityUIElement::helpTextGetterCallback):
2563         (AccessibilityUIElement::stringValueGetterCallback):
2564         (AccessibilityUIElement::xGetterCallback):
2565         (AccessibilityUIElement::yGetterCallback):
2566         (AccessibilityUIElement::widthGetterCallback):
2567         (AccessibilityUIElement::heightGetterCallback):
2568         (AccessibilityUIElement::intValueGetterCallback):
2569         (AccessibilityUIElement::minValueGetterCallback):
2570         (AccessibilityUIElement::maxValueGetterCallback):
2571         (AccessibilityUIElement::childrenCountGetterCallback):
2572         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2573         (AccessibilityUIElement::selectedTextRangeGetterCallback):
2574         (AccessibilityUIElement::isEnabledGetterCallback):
2575         (AccessibilityUIElement::isRequiredGetterCallback):
2576         (AccessibilityUIElement::isFocusedGetterCallback):
2577         (AccessibilityUIElement::isFocusableGetterCallback):
2578         (AccessibilityUIElement::isSelectedGetterCallback):
2579         (AccessibilityUIElement::isSelectableGetterCallback):
2580         (AccessibilityUIElement::isMultiSelectableGetterCallback):
2581         (AccessibilityUIElement::isExpandedGetterCallback):
2582         (AccessibilityUIElement::isCheckedGetterCallback):
2583         (AccessibilityUIElement::isVisibleGetterCallback):
2584         (AccessibilityUIElement::isOffScreenGetterCallback):
2585         (AccessibilityUIElement::isCollapsedGetterCallback):
2586         (AccessibilityUIElement::hasPopupGetterCallback):
2587         (AccessibilityUIElement::isValidGetterCallback):
2588         (AccessibilityUIElement::orientationGetterCallback):
2589         (AccessibilityUIElement::showMenuCallback):
2590         (AccessibilityUIElement::pressCallback):
2591         (AccessibilityUIElement::isEqualCallback):
2592         (AccessibilityUIElement::addNotificationListenerCallback):
2593         (AccessibilityUIElement::removeNotificationListenerCallback):
2594         (AccessibilityUIElement::takeFocusCallback):
2595         (AccessibilityUIElement::fallbackCallback):
2596         (RootAccessibilityUIElement::getChildAtIndex):
2597         (AccessibilityUIElementList::getOrCreate):
2598         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2599         * DumpRenderTree/chromium/CppVariant.cpp:
2600         (CppVariant::invokeDefault):
2601         * DumpRenderTree/chromium/CppVariant.h:
2602         * DumpRenderTree/chromium/LayoutTestController.cpp:
2603         (LayoutTestController::LayoutTestController):
2604         (LayoutTestController::reset):
2605         * DumpRenderTree/chromium/LayoutTestController.h:
2606         * DumpRenderTree/chromium/WebViewHost.cpp:
2607         (WebViewHost::postAccessibilityNotification):
2608
2609 2011-10-10  Adam Klein  <adamk@chromium.org>
2610
2611         Support Distributed-CompileC as an action name in filter-build-webkit
2612         https://bugs.webkit.org/show_bug.cgi?id=69783
2613
2614         Reviewed by Ojan Vafai.
2615
2616         * Scripts/filter-build-webkit:
2617
2618 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
2619
2620         3D transforms are flattened in WebKit2 snapshots
2621         https://bugs.webkit.org/show_bug.cgi?id=68276
2622
2623         Reviewed by Anders Carlsson.
2624         
2625         Use a snapshot of the window, rather than an image from the web process
2626         for pixel testing in WebKitTestRunner. This correctly captures compositing
2627         layers, so works for 3D transform tests.
2628
2629         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
2630         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2631         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
2632         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
2633         use that instead of the image we get from the web process.
2634         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2635         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
2636         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2637         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2638         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2639         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2640         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2641         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2642
2643 2011-10-10  David Levin  <levin@chromium.org>
2644
2645         Quick fix for watchlist unit test failures when using Python 2.7+
2646         Reviewed by Adam Barth.
2647
2648         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
2649         better fix.
2650
2651         * Scripts/webkitpy/common/webkitunittest.py: Always use our
2652         version of assertRaisesRegexp.
2653
2654 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2655
2656         Unreviewed, rolling out r97082.
2657         http://trac.webkit.org/changeset/97082
2658         https://bugs.webkit.org/show_bug.cgi?id=69784
2659
2660         broke Windows build (Requested by smfr on #webkit).
2661
2662         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2663         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
2664         (WTR::createCGContextFromImage):
2665         (WTR::computeMD5HashStringForContext):
2666         (WTR::dumpBitmap):
2667         (WTR::paintRepaintRectOverlay):
2668         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2669         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2670         (WTR::PlatformWebView::PlatformWebView):
2671
2672 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
2673
2674         3D transforms are flattened in WebKit2 snapshots
2675         https://bugs.webkit.org/show_bug.cgi?id=68276
2676
2677         Reviewed by Anders Carlsson.
2678         
2679         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
2680         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
2681         the window when doing pixel tests.
2682         
2683         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
2684
2685         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
2686         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
2687         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
2688         (WTR::computeMD5HashStringForContext):
2689         (WTR::dumpBitmap):
2690         (WTR::paintRepaintRectOverlay):
2691         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
2692         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
2693         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2694         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
2695         We need the window to autodisplay for Core Animation to render layers and start animations.
2696
2697 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
2698
2699         WebKitTestRunner needs layoutTestController.setWindowIsKey
2700         https://bugs.webkit.org/show_bug.cgi?id=42688
2701
2702         Reviewed by Anders Carlsson.
2703
2704         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
2705         This sets a flag that the platform layer uses to indicate that
2706         the window is the key window, which fixes focus ring drawing
2707         in pixel results.
2708         
2709         Also focus the web view when we get a 'didCommitLoad' for the main
2710         frame, as DumpRenderTree does.
2711
2712         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2713         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2714         (WTR::InjectedBundle::postSetWindowIsKey):
2715         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2716         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2717         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
2718         (WTR::LayoutTestController::addChromeInputField):
2719         (WTR::LayoutTestController::removeChromeInputField):
2720         (WTR::LayoutTestController::focusWebView):
2721         (WTR::LayoutTestController::setWindowIsKey):
2722         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
2723         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
2724         (WTR::LayoutTestController::callFocusWebViewCallback):
2725         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2726         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
2727         so that we can override -isKeyWindow. Use a boolean member variable
2728         to track window key status.
2729         (WTR::PlatformWebView::setWindowIsKey):
2730         (WTR::PlatformWebView::windowIsKey):
2731         * WebKitTestRunner/TestController.cpp:
2732         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
2733         (WTR::closeOtherPage): Use the same cast as other functions.
2734         (WTR::focus): Implement to call setWindowIsKey(true)
2735         (WTR::unfocus): Implement to call setWindowIsKey(false)
2736         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
2737         (WTR::TestController::initialize):
2738         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
2739         * WebKitTestRunner/TestController.h:
2740         * WebKitTestRunner/TestInvocation.cpp:
2741         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2742         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2743         (WTR::PlatformWebView::PlatformWebView):
2744         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2745         (-[WebKitTestRunnerWindow isKeyWindow]):
2746         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
2747         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
2748         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
2749         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2750         (WTR::PlatformWebView::PlatformWebView):
2751         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2752         (WTR::PlatformWebView::PlatformWebView):
2753
2754 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
2755
2756         check-webkit-style: Add readability exception for Ewk_* data types.
2757         https://bugs.webkit.org/show_bug.cgi?id=69763
2758
2759         Reviewed by David Levin.
2760
2761         Many EFL-related files (such as EditorClientEfl.h or
2762         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
2763         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
2764         check-webkit-style.
2765
2766         Add an exception for them, just like there are exceptions for
2767         Evas_*, Ecore_* and others.
2768
2769         * Scripts/webkitpy/style/checkers/cpp.py:
2770         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2771
2772 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
2773
2774         [Chromium] Get rid of WebAccessibilityCache.
2775         https://bugs.webkit.org/show_bug.cgi?id=68224
2776
2777         Reviewed by Dimitri Glazkov.
2778
2779         * DumpRenderTree/chromium/AccessibilityController.cpp:
2780         (AccessibilityController::bindToJavascript):
2781
2782 2011-10-09  Adam Barth  <abarth@webkit.org>
2783
2784         Remove "near miss" XSS vulnerabilities in garden-o-matic
2785         https://bugs.webkit.org/show_bug.cgi?id=69708
2786
2787         Reviewed by David Levin.
2788
2789         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
2790         any actual vulnerabilities yet, but he did identify a couple "near
2791         misses" where a slight change in garden-o-matic could lead to a
2792         vulnerability.  This patch removes those potential issues.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
2795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2796
2797 2011-10-07  Adam Barth  <abarth@webkit.org>
2798
2799         Add a Content-Security-Policy to garden-o-matic
2800         https://bugs.webkit.org/show_bug.cgi?id=69668
2801
2802         Reviewed by David Levin.
2803
2804         This will help mitigate cross-site script and will also help us dogfood CSP.
2805
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2807
2808 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
2809
2810         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
2811         https://bugs.webkit.org/show_bug.cgi?id=66380
2812
2813         Reviewed by Antonio Gomes.
2814
2815         This encapsulates EWebKit into an object that manages multiple windows
2816         and provides a cleaner interface to EFL's DumpRenderTree.
2817
2818         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
2819         (DumpRenderTreeChrome::create):
2820         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2821         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
2822         (DumpRenderTreeChrome::createNewWindow):
2823         (DumpRenderTreeChrome::createView):
2824         (DumpRenderTreeChrome::removeWindow):
2825         (DumpRenderTreeChrome::initialize):
2826         (DumpRenderTreeChrome::extraViews):
2827         (DumpRenderTreeChrome::mainFrame):
2828         (DumpRenderTreeChrome::mainView):
2829         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2830         (DumpRenderTreeChrome::onWindowObjectCleared):
2831         (DumpRenderTreeChrome::onLoadStarted):
2832         (DumpRenderTreeChrome::processWork):
2833         (DumpRenderTreeChrome::onLoadFinished):
2834         (DumpRenderTreeChrome::onStatusbarTextSet):
2835         (DumpRenderTreeChrome::onTitleChanged):
2836         (DumpRenderTreeChrome::onDocumentLoadFinished):
2837         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
2838         * DumpRenderTree/efl/EventSender.cpp:
2839         (sendClick): Use browser->mainFrame() instead of mainFrame.
2840         (mouseDownCallback): Ditto.
2841         (mouseUpCallback): Ditto.
2842         (mouseMoveToCallback): Ditto.
2843         (mouseScrollByCallback): Ditto.
2844         (keyDownCallback): Ditto.
2845         (scalePageByCallback): Ditto.
2846         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2847         (LayoutTestController::counterValueForElementById): Use
2848         browser->mainFrame() instead of mainFrame.
2849         (LayoutTestController::pageNumberForElementById): Ditto.
2850         (LayoutTestController::numberOfPages): Ditto.
2851         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2852         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
2853         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
2854         (LayoutTestController::numberOfActiveAnimations): Ditto.
2855         (LayoutTestController::suspendAnimations): Ditto.
2856         (LayoutTestController::resumeAnimations): Ditto.
2857         (LayoutTestController::setWebViewEditable): Ditto.
2858         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
2859         instead of browser.
2860         (LayoutTestController::queueLoad): Ditto.
2861         (LayoutTestController::setAcceptsEditing): Ditto.
2862         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
2863         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
2864         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
2865         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
2866         (LayoutTestController::setPluginsEnabled): Ditto.
2867         (LayoutTestController::findString): Ditto.
2868         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
2869         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2870         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
2871         mainFrame.
2872         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2873         (LoadItem::invoke): Ditto.
2874         (LoadHTMLStringItem::invoke): Ditto.
2875         (ScriptItem::invoke): Ditto.
2876         (ReloadItem::invoke): Use browser->mainView() instead of browser.
2877
2878 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
2879
2880         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
2881         https://bugs.webkit.org/show_bug.cgi?id=69617
2882
2883         Reviewed by Andreas Kling.
2884
2885         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
2886         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
2887         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
2888         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
2889         logic.
2890
2891         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2892         (MiniBrowserApplication::MiniBrowserApplication):
2893         (MiniBrowserApplication::notify):
2894         * MiniBrowser/qt/MiniBrowserApplication.h:
2895
2896 2011-10-06  Adam Barth  <abarth@webkit.org>
2897
2898         Port PixelZoomer to work in garden-o-matic
2899         https://bugs.webkit.org/show_bug.cgi?id=69577
2900
2901         Reviewed by David Levin.
2902
2903         This implementation of PixelZoomer is basically a fork of the
2904         implementation used by results.html.  These two apps have different
2905         requirements on where this code lives.  results.html wants to be
2906         self-contained whereas garden-o-matic wants to live in the public_html
2907         folder of the buildbot.  We could do something fancy here to share the
2908         code, but that's not likely to be of much benefit.
2909
2910         I had to change a few things about pixelzoomer to accounter for the
2911         differences in DOM between results.html and garden-o-matic, but
2912         surprisingly little.  I also moved all the code into an anonymous
2913         function, which is the style we're suing for module separation in
2914         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
2915         want to drag along too many extra functions from results.html.
2916
2917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
2920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
2922         (.pixel-zoom-container):
2923         (.pixel-zoom-container > *):
2924         (.pixel-zoom-container .scaled-image-container):
2925         (.scaled-image-container > img):
2926
2927 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2928
2929         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
2930         https://bugs.webkit.org/show_bug.cgi?id=69505
2931
2932         Reviewed by Andreas Kling.
2933
2934         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
2935         (on_viewport_changed):
2936
2937 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2938
2939         [WinCairo] Unreviewed test correction.
2940
2941         * Scripts/webkitdirs.pm:
2942         (argumentsForConfiguration): Add 'wincairo' option to the set of
2943         configuration flags used by run-javascript-core tests, so that it
2944         does not attempt to run Apple's release version.
2945
2946 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2947
2948         [WinCairo] Unreviewed test correction.
2949
2950         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
2951          of known build slave types so that test-result-archive won't fail
2952          when running tests.
2953
2954 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
2955
2956         The GTK+ WebKit2 headers produce a lot of style warnings
2957         https://bugs.webkit.org/show_bug.cgi?id=69481
2958
2959         Reviewed by David Levin.
2960
2961         Prevent emitting so many style warnings for GTK+ API. We skip header
2962         files in the WebKit2 GTK+ API directory and also avoid warnings about
2963         identifier names that begin with "webkit_" in files that contain the
2964         string "gtk".
2965
2966         * Scripts/webkitpy/style/checker.py: Do not check header files in
2967         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
2968         adding the ability to specify a regular expression in the skip list. Remove
2969         a few files from the skipped list that no longer exist.
2970         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
2971         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
2972         about identifiers that begin with "webkit_".
2973         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
2974
2975 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2976
2977         [WinCairo] Correct config.json for WinCairo Test builds.
2978         https://bugs.webkit.org/show_bug.cgi?id=69272
2979
2980         Reviewed by Ryosuke Niwa.
2981
2982         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
2983          old 'WinCairo Debug (Build)' label and replace with correct
2984          'WinCairo Release' label.
2985
2986 2011-10-06  David Levin  <levin@chromium.org>
2987
2988         Add a style checker watchlist definition and add myself to it.
2989         https://bugs.webkit.org/show_bug.cgi?id=69564
2990
2991         Reviewed by Daniel Bates.
2992
2993         * Scripts/webkitpy/common/config/watchlist:
2994
2995 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2996
2997         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
2998         https://bugs.webkit.org/show_bug.cgi?id=69450
2999
3000         Reviewed by Ryosuke Niwa.
3001
3002         This should avoid stderr messages when running
3003         webarchive/test-link-rel-icon.html.
3004
3005         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3006         (LayoutTestController::setIconDatabaseEnabled):
3007
3008 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
3009
3010         [WK2] [GTK] Add Skipped file for Webkit2 test runner
3011         https://bugs.webkit.org/show_bug.cgi?id=69517
3012
3013         Use the shared WK2 skipped file also in GTK port.
3014
3015         Reviewed by Martin Robinson.
3016
3017         * Scripts/old-run-webkit-tests:
3018         (readSkippedFiles):
3019
3020 2011-10-06  Elliot Poger  <epoger@google.com>
3021
3022         allow new-run-webkit-tests to run on Lion
3023         https://bugs.webkit.org/show_bug.cgi?id=69429
3024
3025         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
3026         directory to fallback lists (even though that directory doesn't exist yet)
3027
3028         Reviewed by Adam Barth.
3029
3030         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3031         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3032
3033 2011-10-03  Hans Wennborg  <hans@chromium.org>
3034
3035         IndexedDB: Remove SQLite-LevelDB migration code
3036         https://bugs.webkit.org/show_bug.cgi?id=69264
3037
3038         Reviewed by Tony Chang.
3039
3040         Remove setOverrideIndexedDBBackingStore. It was used in the layout
3041         test for migration.
3042
3043         * DumpRenderTree/chromium/LayoutTestController.cpp:
3044         (LayoutTestController::LayoutTestController):
3045         * DumpRenderTree/chromium/LayoutTestController.h:
3046
3047 2011-10-05  James Robinson  <jamesr@chromium.org>
3048
3049         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
3050         https://bugs.webkit.org/show_bug.cgi?id=69498
3051
3052         Reviewed by Adam Barth.
3053
3054         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3055         (main):
3056         * DumpRenderTree/chromium/TestShell.cpp:
3057         (TestShell::TestShell):
3058         (TestShell::resetWebSettings):
3059         * DumpRenderTree/chromium/TestShell.h:
3060         (TestShell::setThreadedCompositingEnabled):
3061         * DumpRenderTree/chromium/WebPreferences.cpp:
3062         (WebPreferences::reset):
3063         (WebPreferences::applyTo):
3064         * DumpRenderTree/chromium/WebPreferences.h:
3065         * Scripts/webkitpy/layout_tests/port/chromium.py:
3066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3067
3068 2011-10-05  Erik Arvidsson  <arv@chromium.org>
3069
3070         [QT] Fix DRT after r96779
3071
3072         unreviewed.
3073
3074         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3075         (WebCore::dumpHistoryItem):
3076
3077 2011-10-05  Erik Arvidsson  <arv@chromium.org>
3078
3079         window.location.href and others needlessly decodes URI-encoded characters
3080         https://bugs.webkit.org/show_bug.cgi?id=30225
3081
3082         Reviewed by Darin Adler.
3083
3084         * DumpRenderTree/chromium/TestShell.cpp:
3085         (normalizeLayoutTestURLInternal): Remove extra encode.
3086
3087 2011-10-05  Darin Adler  <darin@apple.com>
3088
3089         Fix build.
3090
3091         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3092         (TestWebKitAPI::TEST): Remove underscore prefix from call to
3093         WKContextRegisterURLSchemeAsEmptyDocument.
3094
3095 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
3096
3097         [WinCairo] Switch to building Release target, and activate tests.
3098         https://bugs.webkit.org/show_bug.cgi?id=69272
3099
3100         Reviewed by Adam Barth.
3101
3102         * BuildSlaveSupport/build.webkit.org-config/config.json:
3103         Change from debug to release target. Switch from "Build" to
3104         "BuildAndTest"
3105
3106 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
3107
3108         In WebKitTestRunner, text has font smoothing in pixel snapshots
3109         https://bugs.webkit.org/show_bug.cgi?id=69396
3110
3111         Reviewed by Darin Adler.
3112         
3113         Call the new WKContext method that disables font smoothing in
3114         WebKitTestRunner, so that pixel snapshots don't have font smoothing
3115         enabled. Remove leading underscore from a WKContext function call.
3116
3117         * WebKitTestRunner/TestController.cpp:
3118         (WTR::TestController::resetStateToConsistentValues):
3119
3120 2011-10-05  David Levin  <levin@chromium.org>
3121
3122         Improve the watchlist for threading entries.
3123         https://bugs.webkit.org/show_bug.cgi?id=69463
3124
3125         Reviewed by Adam Barth.
3126
3127         * Scripts/webkitpy/common/config/watchlist:
3128
3129 2011-10-05  Adam Roben  <aroben@apple.com>
3130
3131         Add tests for using RetainPtrs inside HashMap and HashSet
3132
3133         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
3134         in HashMap/HashSet fails to compile
3135
3136         Reviewed by John Sullivan.
3137
3138         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
3139         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
3140         and value type of HashMap.
3141
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3144         Added new file.
3145
3146 2011-10-05  Adam Barth  <abarth@webkit.org>
3147
3148         Mark as Expected in garden-o-matic is confusing
3149         https://bugs.webkit.org/show_bug.cgi?id=69452
3150
3151         Reviewed by David Levin.
3152
3153         krit didn't understand the difference between this button and the
3154         Rebaseline button because both of them seem to indicate that the new
3155         behavior is expected.  This patch renames "Mark as Expected" to "Expect
3156         Failure" to make it clear that we're just expecting the test to fail
3157         rather than accepting the new results as passing.  We might need to
3158         iterate on these names a bit more if folks continue to find them
3159         confusing.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3162
3163 2011-10-05  Adam Barth  <abarth@webkit.org>
3164
3165         Add watchlist entries for abarth
3166         https://bugs.webkit.org/show_bug.cgi?id=69461
3167
3168         Reviewed by David Levin.
3169
3170         I might have gone a bit overboard.  We'll see if this is too much spam
3171         for me.
3172
3173         * Scripts/webkitpy/common/config/watchlist:
3174
3175 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
3176
3177         [WinCairo] Teach old-run-webkit-tests about wincairo.
3178         https://bugs.webkit.org/show_bug.cgi?id=69280
3179
3180         Reviewed by Adam Roben.
3181
3182         * Scripts/old-run-webkit-tests: Handle wincairo case.
3183         (buildPlatformResultHierarchy):
3184         (readSkippedFiles): Ditto
3185         * Scripts/webkitdirs.pm: Deal with wincairo build case.
3186         (determineConfiguration):
3187
3188 2011-10-05  Chang Shu  <cshu@webkit.org>
3189
3190         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
3191         https://bugs.webkit.org/show_bug.cgi?id=68924
3192
3193         Added TextInputController files and JS interfaces for the above functions.
3194
3195         Reviewed by Darin Adler.
3196
3197         * WebKitTestRunner/DerivedSources.make:
3198         * WebKitTestRunner/DerivedSources.pro:
3199         * WebKitTestRunner/GNUmakefile.am:
3200         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
3201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3202         (WTR::InjectedBundle::beginTesting):
3203         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3204         (WTR::InjectedBundle::textInputController):
3205         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3206         (WTR::InjectedBundlePage::didClearWindowForFrame):
3207         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
3208         (WTR::TextInputController::create):
3209         (WTR::TextInputController::TextInputController):
3210         (WTR::TextInputController::~TextInputController):
3211         (WTR::TextInputController::wrapperClass):
3212         (WTR::TextInputController::makeWindowObject):
3213         (WTR::TextInputController::setMarkedText):
3214         (WTR::TextInputController::hasMarkedText):
3215         (WTR::TextInputController::unmarkText):
3216         (WTR::TextInputController::insertText):
3217         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
3218         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3219         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3220         * WebKitTestRunner/win/InjectedBundle.vcproj:
3221
3222 2011-10-04  Oliver Hunt  <oliver@apple.com>
3223
3224         Add rudimentary filtering to write barriers
3225         https://bugs.webkit.org/show_bug.cgi?id=69392
3226
3227         Reviewed by Filip Pizlo.
3228
3229         When we're recording gc phase times Heap.o picks up
3230         some exit time destructors, so we'll just ignore Heap.o
3231         in this check.
3232
3233         * Scripts/check-for-exit-time-destructors:
3234
3235 2011-10-05  Chang Shu  <cshu@webkit.org>
3236
3237         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
3238         https://bugs.webkit.org/show_bug.cgi?id=69365
3239
3240         Reviewed by Darin Adler.
3241
3242         Added js API in WTR LayoutTestController.
3243
3244         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3245         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3246         (WTR::LayoutTestController::dumpConfigurationForViewport):
3247         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3248
3249 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3250
3251         [EFL] ImageDiff: Do not clear the image before it is processed and compared
3252         https://bugs.webkit.org/show_bug.cgi?id=69378
3253
3254         Reviewed by Antonio Gomes.
3255
3256         Commit 61836 to Evas added a few cleanup calls to some
3257         evas_object_image functions which effectively made ImageDiff consider
3258         all images to be equal.
3259
3260         It turns out that now evas_object_image_colorspace_set clears any
3261         data set, so the call to evas_object_image_data_set was not having any
3262         effect.
3263
3264         * DumpRenderTree/efl/ImageDiff.cpp:
3265         (readImageFromStdin): Call evas_object_image_data_set after
3266         evas_object_image_colorspace_set.
3267
3268 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3269
3270         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
3271         https://bugs.webkit.org/show_bug.cgi?id=68449
3272
3273         Reviewed by Antonio Gomes.
3274
3275         evas_render() must be called to close up temporary files and unmap unused
3276         resources. evas_object_image_data_set() must be called after an
3277         evas_object_image_data_get() to balance an internal reference count.
3278
3279         * DumpRenderTree/efl/ImageDiff.cpp:
3280         (differenceImageFromDifferenceBuffer):
3281         (calculateDifference):
3282         (printImage):
3283         (printImageDifferences):
3284
3285 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
3286
3287         [Qt][WK2] Unreviewed build fix.
3288
3289         Don't use WebCore directly in WTR.
3290
3291         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3292         (WTR::PlatformWebView::addChromeInputField):
3293         (WTR::PlatformWebView::removeChromeInputField):
3294         (WTR::PlatformWebView::makeWebViewFirstResponder):
3295
3296 2011-10-05  David Levin  <levin@chromium.org>
3297
3298         watchlist: Add more rules for chromium public api and sort the file.
3299         https://bugs.webkit.org/show_bug.cgi?id=69323
3300
3301         Reviewed by Adam Barth.
3302
3303         * Scripts/webkitpy/common/config/watchlist:
3304
3305 2011-10-05  David Levin  <levin@chromium.org>
3306
3307         watchlist: Don't add the same message to a bug more than once.
3308         https://bugs.webkit.org/show_bug.cgi?id=69303
3309
3310         Reviewed by Adam Barth.
3311
3312         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
3313         if a message is in the comments already.
3314         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
3315         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3316         Pick a bug supplied by the mock. Change the test due to different output
3317         from the mock watch list tool.
3318         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
3319         another email so it will be filtered out, fix bugs to have the cc and comment fields,
3320         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
3321         to debug).
3322         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
3323         and/or cc's that are already in the bug.
3324         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
3325         and remove a comment that is filtered out.
3326
3327 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
3328
3329         [Qt][WK2] Unreviewed build fix after r96643.
3330
3331         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3332         (WTR::PlatformWebView::addChromeInputField):
3333         (WTR::PlatformWebView::removeChromeInputField):
3334         (WTR::PlatformWebView::makeWebViewFirstResponder):
3335
3336 2011-10-04  Kent Tamura  <tkent@chromium.org>
3337
3338         Introduce feature flags for incomplete input types
3339         https://bugs.webkit.org/show_bug.cgi?id=68971
3340
3341         Reviewed by Hajime Morita.
3342
3343         * Scripts/build-webkit:
3344         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
3345         They are disabled by default.
3346
3347 2011-10-04  Adam Barth  <abarth@webkit.org>
3348
3349         garden-o-matic doesn't launch it's UI on Lion
3350         https://bugs.webkit.org/show_bug.cgi?id=69349
3351
3352         Reviewed by Darin Adler.
3353
3354         It turns out that Lion is a bit more picky about file URLs.  This patch
3355         switches us from using a path to using an actual file URL, silencing
3356         the warning and making the tool actually launch on Lion.
3357
3358         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3359
3360 2011-10-04  Daniel Bates  <dbates@rim.com>
3361
3362         Fix Perl undefined variable warning when using run-safari after
3363         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
3364
3365         Rubber-stamped by Alexey Proskuryakov.
3366
3367         * Scripts/webkitdirs.pm:
3368         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
3369         is defined before using it in a comparison operation.
3370
3371 2011-10-04  Scott Graham  <scottmg@chromium.org>
3372
3373         Add GAMEPAD feature flag
3374         https://bugs.webkit.org/show_bug.cgi?id=66859
3375
3376         Reviewed by Darin Fisher.
3377
3378         * Scripts/build-webkit:
3379
3380 2011-10-04  Jon Lee  <jonlee@apple.com>
3381
3382         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
3383         https://bugs.webkit.org/show_bug.cgi?id=68412
3384         <rdar://problem/9988252>
3385
3386         Reviewed by Darin Adler.
3387
3388         In order to create a test for the bug, I had to update DRT and WKTR to create some
3389         widget that allows first responder status to move away from the main web view.
3390
3391         Three methods were added to layoutTestController: addChromeInputField,
3392         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
3393         that is a sibling to the web view, and sets up the key event loop between the two.
3394         removeChromeInputField removes that field. focusWebView moves first responder
3395         status to the web view.
3396
3397         The test makes the call via layoutTestController and passes a callback that it
3398         assumes will be executed once the task is completed. In DRT the callback is called
3399         synchronously. In WKTR this is handled with message passing between the two
3400         processes.
3401
3402         * DumpRenderTree/LayoutTestController.cpp:
3403         (addChromeInputFieldCallback):
3404         (removeChromeInputFieldCallback):
3405         (focusWebViewCallback):
3406         (LayoutTestController::staticFunctions):
3407         * DumpRenderTree/LayoutTestController.h:
3408         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3409         (LayoutTestController::addChromeInputField):
3410         (LayoutTestController::removeChromeInputField):
3411         (LayoutTestController::focusWebView):
3412         * DumpRenderTree/mac/DumpRenderTree.mm:
3413         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
3414         make sure to remove the chrome input field.
3415         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3416         (LayoutTestController::addChromeInputField):
3417         (LayoutTestController::removeChromeInputField):
3418         (LayoutTestController::focusWebView):
3419         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3420         (LayoutTestController::addChromeInputField):
3421         (LayoutTestController::removeChromeInputField):
3422         (LayoutTestController::focusWebView):
3423         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3424         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3425         (WTR::InjectedBundle::didReceiveMessage):
3426         (WTR::InjectedBundle::postAddChromeInputField):
3427         (WTR::InjectedBundle::postRemoveChromeInputField):
3428         (WTR::InjectedBundle::postFocusWebView):
3429         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3430         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3431         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
3432         through JS.
3433         (WTR::cacheLayoutTestControllerCallback):
3434         (WTR::callLayoutTestControllerCallback):
3435         (WTR::LayoutTestController::addChromeInputField):
3436         (WTR::LayoutTestController::removeChromeInputField):
3437         (WTR::LayoutTestController::focusWebView):
3438         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
3439         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
3440         (WTR::LayoutTestController::callFocusWebViewCallback):
3441         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3442         * WebKitTestRunner/PlatformWebView.h:
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::resetStateToConsistentValues):
3445         * WebKitTestRunner/TestInvocation.cpp:
3446         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3447         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3448         (WTR::PlatformWebView::addChromeInputField):
3449         (WTR::PlatformWebView::removeChromeInputField):
3450         (WTR::PlatformWebView::makeWebViewFirstResponder):
3451         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3452         (WTR::PlatformWebView::addChromeInputField):
3453         (WTR::PlatformWebView::removeChromeInputField):
3454         (WTR::PlatformWebView::makeWebViewFirstResponder):
3455         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3456         (WTR::PlatformWebView::addChromeInputField):
3457         (WTR::PlatformWebView::removeChromeInputField):
3458         (WTR::PlatformWebView::makeWebViewFirstResponder):
3459
3460         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
3461         with the patch-- just cleaning up style.
3462         (LayoutTestController::addDisallowedURL):
3463         (originsArrayToJS):
3464         (LayoutTestController::queueLoad):
3465         (LayoutTestController::setMockDeviceOrientation):
3466         (LayoutTestController::setIconDatabaseEnabled):
3467         (LayoutTestController::setEditingBehavior):
3468
3469 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
3470
3471         Move font-fixup code in WebKitTestRunner to a better place
3472         https://bugs.webkit.org/show_bug.cgi?id=69356
3473
3474         Reviewed by Sam Weinig.
3475         
3476         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
3477         already contains font-related code.
3478
3479         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3480         (WTR::InjectedBundle::initialize):
3481         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3482         (WTR::allowedFontFamilySet):
3483         (WTR::drt_NSFontManager_availableFontFamilies):
3484         (WTR::drt_NSFontManager_availableFonts):
3485         (WTR::swizzleNSFontManagerMethods):
3486         (WTR::activateFonts):
3487         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3488         (WTR::InjectedBundle::platformInitialize):
3489
3490 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3491
3492         [EFL] DRT: Add DumpRenderTree.cpp
3493         https://bugs.webkit.org/show_bug.cgi?id=62034
3494
3495         Reviewed by Antonio Gomes.
3496
3497         This is the main implementation file for EFL's DumpRenderTree.
3498
3499         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
3500         (dumpFramesAsText):
3501         (dumpFrameScrollPosition):
3502         (shouldLogFrameLoadDelegates):
3503         (shouldDumpAsText):
3504         (sendPixelResultsEOF):
3505         (invalidateAnyPreviousWaitToDumpWatchdog):
3506         (onEcoreEvasResize):
3507         (onCloseWindow):
3508         (useLongRunningServerMode):
3509         (parseCommandLineOptions):
3510         (getFinalTestURL):
3511         (getExpectedPixelHash):
3512         (createLayoutTestController):
3513         (runTest):
3514         (runTestingServerLoop):
3515         (adjustOutputTypeByMimeType):
3516         (dumpFrameContentsAsText):
3517         (shouldDumpFrameScrollPosition):
3518         (shouldDumpPixelsAndCompareWithExpected):
3519         (shouldDumpBackForwardList):
3520         (initEfl):
3521         (shutdownEfl):
3522         (displayWebView):
3523         (dump):
3524         (initEcoreEvas):
3525         (main):
3526
3527 2011-10-03  Adam Barth  <abarth@webkit.org>
3528
3529         garden-o-matic should remove builders from the failure grid once they start to pass
3530         https://bugs.webkit.org/show_bug.cgi?id=69309
3531
3532         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
3533         in reviewing these patches.
3534
3535         This patch follows the update/purge model from UpdateTracker.  This
3536         patch is less awesome than it could be because it causes the UI to
3537         flash slightly.  In a future patch, we'll want to use these
3538         update/purge notifications to update the UI without flashing.  However,
3539         that's not such a big deal because this UI is hidden in the default
3540         view.
3541
3542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3546
3547 2011-10-03  David Levin  <levin@chromium.org>
3548
3549         webkitpy: Expose cc_emails and comments from bug.py
3550         https://bugs.webkit.org/show_bug.cgi?id=69308
3551
3552         Reviewed by Adam Barth.
3553
3554         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
3555         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
3556         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
3557         to comments being exposed.
3558
3559 2011-10-03  James Robinson  <jamesr@chromium.org>
3560
3561         Add myself to the watchlist for platform/graphics/chromium
3562         https://bugs.webkit.org/show_bug.cgi?id=69297
3563
3564         Reviewed by David Levin.
3565
3566         * Scripts/webkitpy/common/config/watchlist:
3567
3568 2011-10-03  Anders Carlsson  <andersca@apple.com>
3569
3570         Remove custom scrollbar painting hooks
3571         https://bugs.webkit.org/show_bug.cgi?id=69163
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         * DumpRenderTree/chromium/WebPreferences.cpp:
3576         (WebPreferences::applyTo):
3577         No need to enable custom scrollbar painting.
3578
3579 2011-10-03  David Levin  <levin@chromium.org>
3580
3581         watchlist: Make watchlist run on a bot.
3582         https://bugs.webkit.org/show_bug.cgi?id=68974
3583
3584         Reviewed by Adam Barth.
3585
3586         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
3587         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3588         Change to log what is run so that we can see the style command
3589         and the watchlist command being run.
3590
3591 2011-10-03  David Levin  <levin@chromium.org>
3592
3593         watchlist: Allow specified a bug to attach the watchlist info to.
3594         https://bugs.webkit.org/show_bug.cgi?id=69288
3595
3596         Reviewed by Eric Seidel.
3597
3598         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
3599         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3600         Add tests and fix an existing test because the unit tests do not go through the
3601         normal command line processing (so the -g argument remained when we determined bug ids).
3602         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
3603         get the assert raises regex method.
3604         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
3605
3606 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
3607
3608         [EFL] DRT: Add JSStringUtils.{cpp,h}
3609         https://bugs.webkit.org/show_bug.cgi?id=66397
3610
3611         Reviewed by Ryosuke Niwa.
3612         
3613         Adds helper functions to compare the equality of C-style strings and
3614         JSStringRef objects.
3615
3616         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
3617         (equals):
3618         * DumpRenderTree/efl/JSStringUtils.h: Added.
3619
3620 2011-10-03  Adam Barth  <abarth@webkit.org>
3621
3622         garden-o-matic should work in Safari 5.1
3623         https://bugs.webkit.org/show_bug.cgi?id=69290
3624
3625         Reviewed by Sam Weinig.
3626
3627         My old implementation of bind was too clever by half.  This one seems
3628         to work better, at least according to this test.
3629
3630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3632
3633 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3634
3635         Unreviewed: change my e-mail in commiters.py
3636
3637         (I'm leaving the company and my @openbossa.org will be no more)
3638
3639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3640
3641 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
3642
3643         Correct post-build step for WinCairo test runs.
3644         https://bugs.webkit.org/show_bug.cgi?id=69191 
3645
3646         Reviewed by Brian Weinstein.
3647
3648         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
3649         shell case to handle the CFLite build.
3650
3651 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
3652
3653         Added myself to reviewers, because I'm now a reviewer.