Tools/ChangeLog

   1 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
   2
   3         [EFL] Enable Media Source
   4         https://bugs.webkit.org/show_bug.cgi?id=143635
   5
   6         Reviewed by Csaba Osztrogonác.
   7
   8         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
   9
  10 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
  11
  12         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
  13         https://bugs.webkit.org/show_bug.cgi?id=143646
  14
  15         Reviewed by David Kilzer.
  16
  17         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
  18         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
  19
  20 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
  21
  22         Use en_US spell checker for tests on Mac instead of Multilingual
  23         https://bugs.webkit.org/show_bug.cgi?id=143641
  24
  25         Reviewed by Dan Bernstein.
  26
  27         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
  28         While at it, override NSUserDictionaryReplacementItems, so that user replacements
  29         cannot affect tests.
  30
  31         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
  32         Made this more like WebKit1 version.
  33
  34 2015-04-10  Tim Horton  <timothy_horton@apple.com>
  35
  36         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
  37         https://bugs.webkit.org/show_bug.cgi?id=143576
  38
  39         Reviewed by Simon Fraser.
  40
  41         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
  42         (TEST):
  43         Adopt.
  44
  45 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
  46
  47         Update my email address and expertise.
  48         https://bugs.webkit.org/show_bug.cgi?id=143586
  49
  50         Unreviewed, just update my info.
  51
  52         * Scripts/webkitpy/common/config/contributors.json:
  53
  54 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
  55
  56         Flakiness Dashboard not loading insecure content if loaded with https URL
  57         https://bugs.webkit.org/show_bug.cgi?id=143570
  58
  59         Reviewed by Alexey Proskuryakov.
  60
  61         * TestResultServer/app.yaml:
  62         * TestResultServer/static-dashboards/loader.js:
  63         Switch to https scheme.
  64
  65 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
  66
  67         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
  68         https://bugs.webkit.org/show_bug.cgi?id=142907
  69
  70         Reviewed by Carlos Garcia Campos.
  71
  72         * TestWebKitAPI/PlatformEfl.cmake:
  73         * TestWebKitAPI/PlatformGTK.cmake:
  74         * WebKitTestRunner/PlatformEfl.cmake:
  75         * WebKitTestRunner/PlatformGTK.cmake:
  76
  77 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
  78
  79         [Mac] Unreviewed test fix after r182584
  80         https://bugs.webkit.org/show_bug.cgi?id=143452
  81
  82         Put both of these tests back to their original state now that the underlying
  83         problem is fixed.
  84
  85         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
  86         (TestWebKitAPI::TEST):
  87         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
  88         (TestWebKitAPI::TEST):
  89
  90 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
  91
  92         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
  93         https://bugs.webkit.org/show_bug.cgi?id=143553
  94
  95         Reviewed by Ryosuke Niwa.
  96
  97         Remove the spurious printVMs left over from an earlier change.
  98
  99         * Scripts/run-jsc-benchmarks:
 100
 101 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 102
 103         [Mac] Unreviewed test fix after r182581
 104
 105         The behavior of control-left-click is controlled by a system preference.
 106         Our test bots have this turned off.
 107
 108         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
 109         (TestWebKitAPI::TEST):
 110         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
 111         (TestWebKitAPI::TEST):
 112
 113 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 114
 115         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
 116         https://bugs.webkit.org/show_bug.cgi?id=143452
 117         <rdar://problem/20437483>
 118
 119         Reviewed by Tim Horton.
 120
 121         Add a new API test to confirm that Cocoa mouse button press events are properly
 122         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
 123
 124         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
 125         some registered event handlers that the expected button press and context menu
 126         events are received.
 127
 128         The WK1 unit test creates an NSEvent with the desired button press state, and then
 129         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
 130         We check the resulting PlatformMouseEvent for proper state.
 131
 132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
 133         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
 134         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
 135         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
 136         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
 137         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
 138         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
 139         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 140         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
 141         mouse down events.
 142         * TestWebKitAPI/mac/PlatformWebViewMac.h:
 143
 144 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
 145
 146         [GTK] Add pango to jhbuild-optional.modules
 147         https://bugs.webkit.org/show_bug.cgi?id=143537
 148
 149         Reviewed by Martin Robinson.
 150
 151         * gtk/jhbuild-optional.modules: Add pango.
 152
 153 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 154
 155         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
 156         https://bugs.webkit.org/show_bug.cgi?id=143530
 157
 158         Reviewed by Žan Doberšek.
 159
 160         Assume that the default value for display (:0) is reserved and start checking on :1
 161         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
 162         and for X server named Xorg.bin (previous bug 1376599)
 163
 164         * Scripts/webkitpy/port/xvfbdriver.py:
 165         (XvfbDriver._next_free_display)
 166         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
 167         (XvfbDriverTest.test_start_no_pixel_tests):
 168         (XvfbDriverTest.test_start_pixel_tests):
 169         (XvfbDriverTest.test_start_arbitrary_worker_number):
 170         (XvfbDriverTest.test_next_free_display):
 171         (XvfbDriverTest.test_start_next_worker):
 172 2015-04-08  Alex Christensen  <achristensen@webkit.org>
 173
 174         Block popups from content extensions.
 175         https://bugs.webkit.org/show_bug.cgi?id=143497
 176
 177         Reviewed by Brady Eidson.
 178
 179         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 180         (TestWebKitAPI::TEST_F):
 181         Added popup test.
 182
 183 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
 184
 185         Add CMake build system for WinCairo port.
 186         https://bugs.webkit.org/show_bug.cgi?id=115944
 187
 188         Reviewed by Chris Dumez.
 189
 190         * CMakeLists.txt:
 191         * WinLauncher/CMakeLists.txt: Added.
 192
 193 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 194
 195         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
 196         https://bugs.webkit.org/show_bug.cgi?id=143521
 197
 198         Reviewed by Martin Robinson.
 199
 200         Add a way to detect unexpected web process crashes to WebViewTest,
 201         and a test case to testDOMCache to trigger the crash.
 202
 203         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
 204         (WebKitDOMNodeTest::testDOMCache):
 205         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
 206         (testWebKitWebViewProcessCrashed):
 207         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
 208         (WebViewTest::WebViewTest):
 209         (WebViewTest::webProcessCrashed):
 210         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
 211
 212 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
 213
 214         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
 215         rdar://problem/20461342
 216
 217         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 218
 219 2015-04-07  Commit Queue  <commit-queue@webkit.org>
 220
 221         Unreviewed, rolling out r182511.
 222         https://bugs.webkit.org/show_bug.cgi?id=143507
 223
 224         caused debug test failures (Requested by alexchristensen on
 225         #webkit).
 226
 227         Reverted changeset:
 228
 229         "Block popups from content extensions."
 230         https://bugs.webkit.org/show_bug.cgi?id=143497
 231         http://trac.webkit.org/changeset/182511
 232
 233 2015-04-07  Alex Christensen  <achristensen@webkit.org>
 234
 235         Block popups from content extensions.
 236         https://bugs.webkit.org/show_bug.cgi?id=143497
 237
 238         Reviewed by Brady Eidson.
 239
 240         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 241         (TestWebKitAPI::TEST_F):
 242         Added popup test.
 243
 244 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
 245
 246         Get the features.json files ready for open contributions
 247         https://bugs.webkit.org/show_bug.cgi?id=143436
 248
 249         Reviewed by Darin Adler.
 250
 251         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 252         (JSONFeaturesChecker.check):
 253         Extend the syntax checking a bit, but leave everything non-mandatory
 254         very loose until we figure what fields are important.
 255
 256 2015-04-07  Tim Horton  <timothy_horton@apple.com>
 257
 258         Expose and test fixedLayoutSize via modern WebKit SPI
 259         https://bugs.webkit.org/show_bug.cgi?id=143500
 260
 261         Reviewed by Simon Fraser.
 262
 263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 264         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
 265         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
 266         (TEST):
 267         Add a test that verifies that fixedLayoutSize works at all, that
 268         it persists through a navigation, and that turning it back off reverts to
 269         laying out at the size of the view.
 270
 271 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
 272
 273         Unreviewed. Add myself as a committer.
 274
 275         * Scripts/webkitpy/common/config/contributors.json:
 276
 277 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
 278
 279         [Win] Bots complain about missing /etc/catalog
 280         https://bugs.webkit.org/show_bug.cgi?id=143484
 281
 282         Reviewed by Chris Dumez.
 283
 284         The libxml2 build on Mac, iOS, and Windows does not provide the set
 285         of default catalog files. We do not actually need these for our
 286         purposes, but we get warnings and some bot flakiness because they
 287         are not present.
 288
 289         We can avoid both problems the same way the Mac and iOS ports do,
 290         by setting the XML_CATALOG_FILES environment variable to 'empty string',
 291         which avoid the warnings and bot problems.
 292
 293         * Scripts/webkitpy/port/win.py:
 294         (WinPort.setup_environ_for_server): Added.
 295
 296 2015-04-06  Sam Weinig  <sam@webkit.org>
 297
 298         Use content extensions in MiniBrowser.
 299         https://bugs.webkit.org/show_bug.cgi?id=143446
 300
 301         Reviewed by Alex Christensen.
 302
 303         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 304         * MiniBrowser/mac/AppDelegate.h:
 305         * MiniBrowser/mac/AppDelegate.m:
 306         (-[BrowserAppDelegate init]):
 307         (-[BrowserAppDelegate showExtensionsManager:]):
 308         (-[BrowserAppDelegate userContentContoller]):
 309         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 310         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 311         (-[ExtensionManagerWindowController init]):
 312         (-[ExtensionManagerWindowController windowDidLoad]):
 313         (-[ExtensionManagerWindowController add:]):
 314         (-[ExtensionManagerWindowController remove:]):
 315         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 316         * MiniBrowser/mac/MainMenu.xib:
 317
 318 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 319
 320         web-platform-tests server should retrieve the modules file relatively to its docroot path
 321         https://bugs.webkit.org/show_bug.cgi?id=142742
 322
 323         Reviewed by Darin Adler.
 324
 325         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 326         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
 327
 328 2015-04-06  Commit Queue  <commit-queue@webkit.org>
 329
 330         Unreviewed, rolling out r182445.
 331         https://bugs.webkit.org/show_bug.cgi?id=143459
 332
 333         broke 32 bit build (Requested by alexchristensen on #webkit).
 334
 335         Reverted changeset:
 336
 337         "Use content extensions in MiniBrowser."
 338         https://bugs.webkit.org/show_bug.cgi?id=143446
 339         http://trac.webkit.org/changeset/182445
 340
 341 2015-04-06  Sam Weinig  <sam@webkit.org>
 342
 343         Use content extensions in MiniBrowser.
 344         https://bugs.webkit.org/show_bug.cgi?id=143446
 345
 346         Reviewed by Alex Christensen.
 347
 348         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 349         * MiniBrowser/mac/AppDelegate.h:
 350         * MiniBrowser/mac/AppDelegate.m:
 351         (-[BrowserAppDelegate init]):
 352         (-[BrowserAppDelegate showExtensionsManager:]):
 353         (-[BrowserAppDelegate userContentContoller]):
 354         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 355         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 356         (-[ExtensionManagerWindowController init]):
 357         (-[ExtensionManagerWindowController windowDidLoad]):
 358         (-[ExtensionManagerWindowController add:]):
 359         (-[ExtensionManagerWindowController remove:]):
 360         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 361         * MiniBrowser/mac/MainMenu.xib:
 362
 363 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
 364
 365         [GTK] install-dependencies should prefer dnf to yum
 366         https://bugs.webkit.org/show_bug.cgi?id=143441
 367
 368         Reviewed by Martin Robinson.
 369
 370         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
 371
 372         * gtk/install-dependencies:
 373
 374 2015-04-06  Andy Estes  <aestes@apple.com>
 375
 376         [iOS] 'make clean' fails in Tools/WebKitTestRunner
 377         https://bugs.webkit.org/show_bug.cgi?id=143455
 378
 379         Reviewed by Dan Bernstein.
 380
 381         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
 382         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
 383
 384         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
 385
 386 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
 387
 388         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
 389         https://bugs.webkit.org/show_bug.cgi?id=143450
 390
 391         Reviewed by Anders Carlsson.
 392
 393         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
 394         Make sure that the view is actually closed, regardless of anything else that happens beneath.
 395         Also, removed unnecessary get() calls.
 396
 397 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
 398
 399         Reduce the dependency on Flash in regression tests
 400         https://bugs.webkit.org/show_bug.cgi?id=143391
 401
 402         Reviewed by Anders Carlsson.
 403
 404         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
 405         Only allow QuickTime and the test plug-in.
 406
 407 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 408
 409         W3C test importer should generate the modules installed dynamically to run wpt tests
 410         https://bugs.webkit.org/show_bug.cgi?id=142738
 411
 412         Reviewed by Ryosuke Niwa.
 413
 414         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
 415         The implementation is done within TestDownloader and it is activated for the WPT repository.
 416         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
 417
 418         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 419         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
 420         * Scripts/webkitpy/w3c/test_downloader.py:
 421         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
 422         (TestDownloader):
 423         (TestDownloader._git_submodules_description): Computes submodule description.
 424         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
 425         * Scripts/webkitpy/w3c/test_importer.py:
 426         (TestImporter.do_import): Added the possibility to post process the tests.
 427         (TestImporter):
 428         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
 429         (TestImporter.should_convert_test_harness_links): Updated according new options format.
 430         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 431         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
 432         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
 433         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
 434         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
 435         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
 436
 437 2015-04-05  Antti Koivisto  <antti@apple.com>
 438
 439         Bloom filter should support longer hashes
 440         https://bugs.webkit.org/show_bug.cgi?id=143419
 441
 442         Reviewed by Dan Bernstein.
 443
 444         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
 445         (TestWebKitAPI::generateRandomDigests):
 446         (TestWebKitAPI::TEST):
 447
 448 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 449
 450         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
 451         https://bugs.webkit.org/show_bug.cgi?id=143372
 452
 453         Reviewed by Darin Adler.
 454
 455         * Scripts/run-jsc-stress-tests:
 456
 457 2015-04-03  Antti Koivisto  <antti@apple.com>
 458
 459         Add non-counting bloom filter class
 460         https://bugs.webkit.org/show_bug.cgi?id=143366
 461
 462         Reviewed by Sam Weinig.
 463
 464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 465         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
 466         (TestWebKitAPI::generateRandomHashes):
 467         (TestWebKitAPI::TEST):
 468
 469 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 470
 471         FTL JIT tests should fail if LLVM library isn't available
 472         https://bugs.webkit.org/show_bug.cgi?id=143374
 473
 474         Reviewed by Mark Lam.
 475
 476         * Scripts/run-jsc-stress-tests:
 477
 478 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 479
 480         [EFL] Speedup jhbuild with disable running autogen.sh
 481         https://bugs.webkit.org/show_bug.cgi?id=143369
 482
 483         Reviewed by Gyuyoung Kim.
 484
 485         * efl/jhbuild.modules:
 486
 487 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 488
 489         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
 490         https://bugs.webkit.org/show_bug.cgi?id=143282
 491
 492         Reviewed by Daniel Bates.
 493
 494         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
 495
 496 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 497
 498         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
 499         https://bugs.webkit.org/show_bug.cgi?id=143240
 500         rdar://problem/19990425
 501
 502         Reviewed by Tim Horton.
 503
 504         * DumpRenderTree/mac/LayoutTestHelper.m:
 505         (colorProfileURLForDisplay):
 506         (saveDisplayColorProfiles):
 507         Gracefully handle it when the current profile cannot be retrieved, fixing at
 508         least one case when LayoutTestHelper couldn't start.
 509
 510         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 511         (Manager._set_up_run):
 512         (Manager._force_pixel_tests_if_needed):
 513         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
 514         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
 515         Return and check an error from start_helper().
 516
 517 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
 518
 519         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
 520         https://bugs.webkit.org/show_bug.cgi?id=143321
 521
 522         Reviewed by Alexey Proskuryakov.
 523
 524         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
 525
 526 2015-04-01  Enrica Casucci  <enrica@apple.com>
 527
 528         Injected bundle messages should be at the page level.
 529         https://bugs.webkit.org/show_bug.cgi?id=143283
 530
 531         Reviewed by Alexey Proskuryakov.
 532
 533         Updating WebKitTestRunner to use the new page level messaging.
 534         The author of this patch is Tim Horton, I just finished it.
 535
 536         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 537         (WTR::EventSendingController::mouseDown):
 538         (WTR::EventSendingController::mouseUp):
 539         (WTR::EventSendingController::mouseMoveTo):
 540         (WTR::EventSendingController::leapForward):
 541         (WTR::EventSendingController::scheduleAsynchronousClick):
 542         (WTR::EventSendingController::keyDown):
 543         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
 544         (WTR::EventSendingController::mouseScrollBy):
 545         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
 546         (WTR::EventSendingController::continuousMouseScrollBy):
 547         (WTR::EventSendingController::addTouchPoint):
 548         (WTR::EventSendingController::updateTouchPoint):
 549         (WTR::EventSendingController::setTouchModifier):
 550         (WTR::EventSendingController::setTouchPointRadius):
 551         (WTR::EventSendingController::touchStart):
 552         (WTR::EventSendingController::touchMove):
 553         (WTR::EventSendingController::touchEnd):
 554         (WTR::EventSendingController::touchCancel):
 555         (WTR::EventSendingController::clearTouchPoints):
 556         (WTR::EventSendingController::releaseTouchPoint):
 557         (WTR::EventSendingController::cancelTouchPoint):
 558         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 559         (WTR::InjectedBundle::didReceiveMessage):
 560         (WTR::InjectedBundle::didReceiveMessageToPage):
 561         (WTR::InjectedBundle::done):
 562         (WTR::InjectedBundle::outputText):
 563         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
 564         (WTR::InjectedBundle::postAddChromeInputField):
 565         (WTR::InjectedBundle::postRemoveChromeInputField):
 566         (WTR::InjectedBundle::postFocusWebView):
 567         (WTR::InjectedBundle::postSetBackingScaleFactor):
 568         (WTR::InjectedBundle::postSetWindowIsKey):
 569         (WTR::InjectedBundle::postSimulateWebNotificationClick):
 570         (WTR::InjectedBundle::postSetAddsVisitedLinks):
 571         (WTR::InjectedBundle::setGeolocationPermission):
 572         (WTR::InjectedBundle::setMockGeolocationPosition):
 573         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
 574         (WTR::InjectedBundle::setUserMediaPermission):
 575         (WTR::InjectedBundle::setCustomPolicyDelegate):
 576         (WTR::InjectedBundle::setHidden):
 577         (WTR::InjectedBundle::setCacheModel):
 578         (WTR::InjectedBundle::shouldProcessWorkQueue):
 579         (WTR::InjectedBundle::processWorkQueue):
 580         (WTR::InjectedBundle::queueBackNavigation):
 581         (WTR::InjectedBundle::queueForwardNavigation):
 582         (WTR::InjectedBundle::queueLoad):
 583         (WTR::InjectedBundle::queueLoadHTMLString):
 584         (WTR::InjectedBundle::queueReload):
 585         (WTR::InjectedBundle::queueLoadingScript):
 586         (WTR::InjectedBundle::queueNonLoadingScript):
 587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 588         (WTR::TestRunner::setHandlesAuthenticationChallenges):
 589         (WTR::TestRunner::setAuthenticationUsername):
 590         (WTR::TestRunner::setAuthenticationPassword):
 591         (WTR::TestRunner::secureEventInputIsEnabled):
 592         (WTR::TestRunner::setBlockAllPlugins):
 593         * WebKitTestRunner/TestController.cpp:
 594         (WTR::TestController::createWebViewWithOptions):
 595         (WTR::TestController::resetStateToConsistentValues):
 596         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
 597         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
 598         * WebKitTestRunner/TestController.h:
 599         * WebKitTestRunner/TestInvocation.cpp:
 600         (WTR::TestInvocation::invoke):
 601         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 602
 603 2015-04-01  Commit Queue  <commit-queue@webkit.org>
 604
 605         Unreviewed, rolling out r182174 and r182177.
 606         https://bugs.webkit.org/show_bug.cgi?id=143314
 607
 608         Try to correct EWS failures (Requested by bfulgham on
 609         #webkit).
 610
 611         Reverted changesets:
 612
 613         "Python SCM should be able to retrieve untracked files"
 614         https://bugs.webkit.org/show_bug.cgi?id=143135
 615         http://trac.webkit.org/changeset/182174
 616
 617         "[buildbot] clean-build script should remove untracked files
 618         and revert local changes too"
 619         https://bugs.webkit.org/show_bug.cgi?id=142400
 620         http://trac.webkit.org/changeset/182177
 621
 622 2015-04-01  Alex Christensen  <achristensen@webkit.org>
 623
 624         [Content Extensions] Properly handle regexes that match everything.
 625         https://bugs.webkit.org/show_bug.cgi?id=143281
 626
 627         Reviewed by Benjamin Poulain.
 628
 629         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 630         (TestWebKitAPI::testRequest):
 631         (TestWebKitAPI::makeBackend):
 632         (TestWebKitAPI::TEST_F):
 633         Removed duplicate code and added test.
 634
 635 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
 636
 637         Content Extensions: split the state machines to minimize prefix states
 638         https://bugs.webkit.org/show_bug.cgi?id=143253
 639
 640         Reviewed by Alex Christensen.
 641
 642         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 643         (TestWebKitAPI::TEST_F):
 644         (TestWebKitAPI::testPatternStatus):
 645
 646 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
 647
 648         Clean up Identifier factories to clarify the meaning of StringImpl*
 649         https://bugs.webkit.org/show_bug.cgi?id=143146
 650
 651         Reviewed by Filip Pizlo.
 652
 653         Simple API tests for StringImpl are added.
 654
 655         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 656         (TestWebKitAPI::TEST):
 657
 658 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
 659
 660         [EFL] Add AArch64 builder and tester bot to build.webkit.org
 661         https://bugs.webkit.org/show_bug.cgi?id=143092
 662
 663         Reviewed by Gyuyoung Kim.
 664
 665         * BuildSlaveSupport/build.webkit.org-config/config.json:
 666         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 667         (Factory.__init__):
 668         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 669
 670 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 671
 672         [buildbot] clean-build script should remove untracked files and revert local changes too
 673         https://bugs.webkit.org/show_bug.cgi?id=142400
 674
 675         Reviewed by Ryosuke Niwa.
 676
 677         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 678         A helper routine SCM.discard_untracked_files is added for that purpose.
 679
 680         * BuildSlaveSupport/clean-build:
 681         (main): Making call to Scripts/clean-webkit
 682         * Scripts/clean-webkit: Added.
 683         (main): Revert changes and delete untracked files.
 684         * Scripts/webkitpy/common/checkout/scm/scm.py:
 685         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 686         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 687         (SCMTest._shared_test_discard_untracked_files):
 688         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 689
 690 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 691
 692         Python SCM should be able to retrieve untracked files
 693         https://bugs.webkit.org/show_bug.cgi?id=143135
 694
 695         Reviewed by Ryosuke Niwa.
 696
 697         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
 698         Ignored files may be included or not in this list according boolean passed to the function.
 699
 700         * Scripts/webkitpy/common/checkout/scm/git.py:
 701         (Git.untracked_files):
 702         * Scripts/webkitpy/common/checkout/scm/scm.py:
 703         (SCM.untracked_files):
 704         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 705         (SCMTest._shared_test_untracked_files):
 706         (test_untracked_files):
 707         (GitSVNTest.test_untracked_files):
 708         * Scripts/webkitpy/common/checkout/scm/svn.py:
 709         (SVN.untracked_files):
 710
 711 2015-03-30  Alex Christensen  <achristensen@webkit.org>
 712
 713         [Content Extensions] Correctly handle regular expressions matching everything
 714         https://bugs.webkit.org/show_bug.cgi?id=143235
 715
 716         Reviewed by Benjamin Poulain.
 717
 718         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 719         (TestWebKitAPI::checkCompilerError):
 720         (TestWebKitAPI::TEST_F):
 721         Test ContentExtensionErrors.
 722
 723 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
 724
 725         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
 726         https://bugs.webkit.org/show_bug.cgi?id=143241
 727         rdar://problem/20351297
 728
 729         Reviewed by Mark Lam.
 730
 731         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
 732
 733 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 734
 735         [CMake][EFL] Remove redundant library link and include path
 736         https://bugs.webkit.org/show_bug.cgi?id=143221
 737
 738         Reviewed by Csaba Osztrogonác.
 739
 740         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
 741
 742 2015-03-30  Sam Weinig  <sam@webkit.org>
 743
 744         [Content Extensions] Flesh out the UserContentExtensionStore
 745         https://bugs.webkit.org/show_bug.cgi?id=143123
 746
 747         Reviewed by Benjamin Poulain.
 748
 749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 750         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
 751         Add tests for _WKUserContentExtensionStore.
 752
 753 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
 754
 755         Update install-dependencies Fedora packages after r181624
 756         https://bugs.webkit.org/show_bug.cgi?id=143215
 757
 758         Add json-glib, libv4l, openssl and pulseaudio development packages to
 759         the Fedora list providing we need them to build WebKit dependencies
 760         for this distribution.
 761
 762         Reviewed by Philippe Normand.
 763
 764         * gtk/install-dependencies:
 765
 766 2015-03-30  Commit Queue  <commit-queue@webkit.org>
 767
 768         Unreviewed, rolling out r182119.
 769         https://bugs.webkit.org/show_bug.cgi?id=143196
 770
 771         problem with syntax (Requested by youenn on #webkit).
 772
 773         Reverted changeset:
 774
 775         "[buildbot] clean-build script should remove untracked files
 776         and revert local changes too"
 777         https://bugs.webkit.org/show_bug.cgi?id=142400
 778         http://trac.webkit.org/changeset/182119
 779
 780 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
 781
 782         Start the features.json files
 783         https://bugs.webkit.org/show_bug.cgi?id=143207
 784
 785         Reviewed by Darin Adler.
 786
 787         I kept the style checking light. We'll have to figure
 788         what is the best format for each field.
 789
 790         * Scripts/webkitpy/style/checker.py:
 791         (CheckerDispatcher._create_checker):
 792         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 793         (JSONContributorsChecker.check):
 794         (JSONFeaturesChecker):
 795         (JSONFeaturesChecker.check):
 796
 797 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 798
 799         [buildbot] clean-build script should remove untracked files and revert local changes too
 800         https://bugs.webkit.org/show_bug.cgi?id=142400
 801
 802         Reviewed by Ryosuke Niwa.
 803
 804         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
 805
 806         * BuildSlaveSupport/clean-build:
 807         (main): Adding call to Tools/Scripts/clean-webkit.
 808         * Scripts/clean-webkit: Added.
 809         (main): Removes untracked and changed files.
 810         * Scripts/webkitpy/common/checkout/scm/git.py:
 811         (Git.untracked_files): Retrieves GIT untracked files.
 812         * Scripts/webkitpy/common/checkout/scm/scm.py:
 813         (SCM.untracked_files): Retrieves SVN untracked files.
 814         (SCM):
 815         (SCM.discard_untracked_files): Deletes untracked files/folders.
 816         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 817         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
 818         (test_untracked_files):
 819         (GitSVNTest.test_untracked_files):
 820         * Scripts/webkitpy/common/checkout/scm/svn.py:
 821         (SVN.untracked_files):
 822
 823 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 824
 825         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
 826         https://bugs.webkit.org/show_bug.cgi?id=143138
 827
 828         Reviewed by Csaba Osztrogonác.
 829
 830         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
 831         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
 832
 833         * ImageDiff/CMakeLists.txt:
 834         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
 835         * WebKitTestRunner/CMakeLists.txt: ditto.
 836
 837 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
 838
 839         Support building WTF on Windows without Cygwin
 840         https://bugs.webkit.org/show_bug.cgi?id=143084
 841
 842         Reviewed by Brent Fulgham.
 843
 844         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
 845         This patch also migrates to using File::Spec->catfile() for directory separators.
 846
 847         * Scripts/update-webkit-dependency:
 848         (wanted):
 849         * Scripts/update-webkit-support-libs:
 850         (wanted):
 851         (downloadExpectedVersionNumber):
 852         (zipFileVersion):
 853         (toUnixPath): Deleted.
 854         * Scripts/webkitdirs.pm:
 855         (determineSourceDir):
 856         (windowsSourceSourceDir):
 857         (windowsLibrariesDir):
 858         (windowsOutputDir):
 859         (checkInstalledTools):
 860         (buildVisualStudioProject):
 861
 862 2015-03-27  Alex Christensen  <achristensen@webkit.org>
 863
 864         Fix WinCairo bot.
 865         https://bugs.webkit.org/show_bug.cgi?id=143086
 866
 867         Reviewed by Brent Fulgham.
 868
 869         * Scripts/webkitdirs.pm:
 870         (buildVisualStudioProject):
 871         (runSvnUpdateAndResolveChangeLogs):
 872         Use ActivePerl-friendly perl.
 873
 874 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
 875
 876         URTBF after r182059 to fix the EFL build.
 877
 878         * TestWebKitAPI/CMakeLists.txt:
 879
 880 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
 881
 882         Layout test results URL loads in WK1 but not WK2 minibrowser
 883         https://bugs.webkit.org/show_bug.cgi?id=143117
 884
 885         Reviewed by Tim Horton.
 886
 887         * MiniBrowser/mac/WK2BrowserWindowController.m:
 888         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
 889         everything.
 890         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
 891
 892 2015-03-26  Jer Noble  <jer.noble@apple.com>
 893
 894         Add --allowed-host support to run-webkit-tests
 895         https://bugs.webkit.org/show_bug.cgi?id=142938
 896
 897         Reviewed by Brent Fulgham.
 898
 899         Accept --allowed-host arguments from run-webkit-tests and pass them through to
 900         DumpRenderTree and WebKitTestRunner.
 901
 902         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
 903         are placed in the wrong location. The argument is compared with each tests's path, and if a
 904         relative path or a path with '..' was used, results are placed alongside the test. Take the
 905         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
 906
 907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 908         (parse_args):
 909         * Scripts/webkitpy/port/base.py:
 910         (Port.__init__):
 911         (Port.allowed_hosts):
 912         * Scripts/webkitpy/port/driver.py:
 913         (Driver.cmd_line):
 914
 915 2015-03-26  Jer Noble  <jer.noble@apple.com>
 916
 917         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
 918         https://bugs.webkit.org/show_bug.cgi?id=142931
 919
 920         Reviewed by Brent Fulgham.
 921
 922         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
 923         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
 924         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
 925         runtime.
 926
 927         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
 928         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
 929
 930         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
 931         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
 932         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
 933         the top loading frame from the page, as we do elsewhere in this class.
 934
 935         * DumpRenderTree/TestRunner.h:
 936         (TestRunner::allowedHosts):
 937         (TestRunner::setAllowedHosts):
 938         * DumpRenderTree/mac/DumpRenderTree.mm:
 939         (initializeGlobalsFromCommandLineOptions):
 940         (runTest):
 941         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 942         (isAllowedHost):
 943         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 944         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 945         (WTR::InjectedBundle::didReceiveMessage):
 946         (WTR::InjectedBundle::isAllowedHost):
 947         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 948         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 949         (WTR::isAllowedHost):
 950         (WTR::InjectedBundlePage::willSendRequestForFrame):
 951         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 952         * WebKitTestRunner/Options.cpp:
 953         (WTR::handleOptionAllowedHost):
 954         (WTR::OptionsHandler::OptionsHandler):
 955         * WebKitTestRunner/Options.h:
 956         * WebKitTestRunner/TestController.cpp:
 957         (WTR::TestController::initialize):
 958         (WTR::TestController::resetStateToConsistentValues):
 959         * WebKitTestRunner/TestController.h:
 960
 961 2015-03-26  Brady Eidson  <beidson@apple.com>
 962
 963         Apply ContentExtension actions after redirects.
 964         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
 965
 966         Reviewed by Alex Christensen.
 967
 968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 969         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
 970           which is specifically interesting to a new test.
 971
 972 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 973
 974         [EFL] Disable building libseccomp on AArch64
 975         https://bugs.webkit.org/show_bug.cgi?id=143094
 976
 977         Reviewed by Gyuyoung Kim.
 978
 979         * efl/jhbuildrc:
 980
 981 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 982
 983         [jhbuild] git should use only 1 thread for cloning jhbuild
 984         https://bugs.webkit.org/show_bug.cgi?id=143095
 985
 986         Reviewed by Gyuyoung Kim.
 987
 988         * jhbuild/jhbuild-wrapper:
 989         (clone_jhbuild):
 990
 991 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
 992
 993         Update prepare-ChangeLog to work with ES6 Class syntax
 994         https://bugs.webkit.org/show_bug.cgi?id=143069
 995
 996         Reviewed by Timothy Hatcher.
 997
 998         * Scripts/prepare-ChangeLog:
 999         (get_function_line_ranges_for_javascript):
1000         Better handle ES6 Class syntax.
1001
1002         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1003         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1004         (BaseClass):
1005         (DerivedClass):
1006         (DerivedClass.staticMethod):
1007         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1008         (DerivedClass.prototype.method):
1009         (DerivedClass.prototype.get getter):
1010         (namespace.MyClass):
1011         (namespace.MyClass.staticMethod):
1012         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1013         (namespace.MyClass.prototype.method):
1014         (namespace.MyClass.prototype.get getter):
1015         Proof!
1016
1017 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1018
1019         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1020         https://bugs.webkit.org/show_bug.cgi?id=142993
1021
1022         Reviewed by Mark Lam.
1023
1024         Bunch of support for testing executable allocation failure.
1025
1026         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1027         (fail):
1028         * Scripts/run-javascriptcore-tests:
1029         (runJSCStressTests):
1030         * Scripts/run-jsc-stress-tests:
1031
1032 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1033
1034         Fix Windows build from r181977.
1035
1036         Unreviewed.
1037
1038         * Scripts/update-webkit-dependency:
1039
1040 2015-03-25  Sam Weinig  <sam@webkit.org>
1041
1042         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1043
1044         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1045         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1046
1047 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1048
1049         Migrate update-webkit for Windows to not require Cygwin
1050         https://bugs.webkit.org/show_bug.cgi?id=143040
1051
1052         Reviewed by Brent Fulgham.
1053
1054         * Scripts/update-webkit-dependency:
1055         (wanted):
1056         (toUnixPath): Deleted.
1057         * Scripts/webkitdirs.pm:
1058         (fontExists):
1059         (checkInstalledTools):
1060         (setupAppleWinEnv):
1061
1062 2015-03-25  Sam Weinig  <sam@webkit.org>
1063
1064         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1065         https://bugs.webkit.org/show_bug.cgi?id=143059
1066
1067         Reviewed by Alex Christensen.
1068
1069         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1070         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1071         Update for new interface of compileRuleList().
1072
1073 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1074
1075         [Content Extensions] Add multi-DFA compiling and interpreting.
1076         https://bugs.webkit.org/show_bug.cgi?id=143010
1077
1078         Reviewed by Benjamin Poulain.
1079
1080         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1081         (TestWebKitAPI::testRequest):
1082         (TestWebKitAPI::TEST_F):
1083         Add some tests for ignore-previous-rules and large rulesets.
1084
1085 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1086
1087         Mavericks WK1 still runs JSC tests
1088         https://bugs.webkit.org/show_bug.cgi?id=143035
1089
1090         Reviewed by Csaba Osztrogonác.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1093         with other bots.
1094
1095         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1096         accordingly.
1097
1098 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1099
1100         Unreviewed, rolling out r181932.
1101         https://bugs.webkit.org/show_bug.cgi?id=143041
1102
1103         The test fails most of the time on bots (Requested by ap on
1104         #webkit).
1105
1106         Reverted changeset:
1107
1108         "[Content Extensions] Add multi-DFA compiling and
1109         interpreting."
1110         https://bugs.webkit.org/show_bug.cgi?id=143010
1111         http://trac.webkit.org/changeset/181932
1112
1113 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1114
1115         [Content Extensions] Add multi-DFA compiling and interpreting.
1116         https://bugs.webkit.org/show_bug.cgi?id=143010
1117
1118         Reviewed by Benjamin Poulain.
1119
1120         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1121         (TestWebKitAPI::testRequest):
1122         (TestWebKitAPI::TEST_F):
1123         Add some tests for ignore-previous-rules and large rulesets.
1124
1125 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1126
1127         Make URL filter patterns matching consistent and add a simple canonicalization step
1128         https://bugs.webkit.org/show_bug.cgi?id=142998
1129
1130         Reviewed by Alex Christensen.
1131
1132         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1133
1134 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1135
1136         [EFL] Add OpenWebRTC in jhbuild
1137         https://bugs.webkit.org/show_bug.cgi?id=142778
1138
1139         Reviewed by Gyuyoung Kim.
1140
1141         Original patch by Philippe Normand <pnormand@igalia.com>
1142
1143         * efl/install-dependencies: Dependencies for OpenWebRTC.
1144         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1145         the openwebrtc gst plugins.
1146
1147 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1148
1149         Regression(r181257): WTF_WorkQueue.Simple is flaky
1150         https://bugs.webkit.org/show_bug.cgi?id=142560
1151
1152         Remove the check that the refCount has returned to one after the
1153         individual tasks have completed. It's too nondeterministic when
1154         the reference count will be reduced.
1155
1156         Reviewed by Alexey Proskuryakov
1157
1158         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1159         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1160
1161 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1162
1163         [CMake][EFL] Put failure API test excutables into failure directory
1164         https://bugs.webkit.org/show_bug.cgi?id=142965
1165
1166         Reviewed by Csaba Osztrogonác.
1167
1168         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1169
1170         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1171         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1172
1173 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1174
1175         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1176         https://bugs.webkit.org/show_bug.cgi?id=142932
1177
1178         Reviewed by Darin Adler.
1179
1180         Add tests for the new features and fix some existing tests using the
1181         stringFromUTF8() utility recently added by Dhi.
1182
1183         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1184         (TestWebKitAPI::stringFromUTF8):
1185         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1186
1187 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1188
1189         [GTK] install-dependencies should install orc
1190         https://bugs.webkit.org/show_bug.cgi?id=142955
1191
1192         Reviewed by Martin Robinson.
1193
1194         Install orc, needed by openwebrtc
1195
1196         * gtk/install-dependencies:
1197
1198 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1199
1200         Detect when url filter pattern with groups match the empty string
1201         https://bugs.webkit.org/show_bug.cgi?id=142930
1202
1203         Reviewed by Sam Weinig.
1204
1205         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1206
1207 2015-03-22  Anders Carlsson  <andersca@apple.com>
1208
1209         _WKWebsiteDataStore should clear WebSQL databases
1210         https://bugs.webkit.org/show_bug.cgi?id=142947
1211
1212         Reviewed by Sam Weinig.
1213
1214         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1215
1216         * MiniBrowser/mac/WK2BrowserWindowController.m:
1217         (-[WK2BrowserWindowController fetchWebsiteData:]):
1218         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1219         (-[WK2BrowserWindowController clearWebsiteData:]):
1220
1221 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1222
1223         GCTimer should know keep track of nested GC phases
1224         https://bugs.webkit.org/show_bug.cgi?id=142675
1225
1226         Reviewed by Darin Adler.
1227
1228         Adds a tool to aid in parsing the GC phase timing output into a
1229         tree-like structure based on the parent-child relationships
1230         of nested GC phases.
1231
1232         * Scripts/parse-gc-phase-timings: Added.
1233         (Timing):
1234         (Timing.__init__):
1235         (Timing.__unicode__):
1236         (Timing.__str__):
1237         (Timing.__repr__):
1238         (parse_input):
1239         (print_timing_node):
1240         (print_timing_tree):
1241         (link_parents):
1242         (main):
1243
1244 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1245
1246         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1247
1248         * Scripts/webkitpy/common/config/ews.json:
1249
1250 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1251
1252         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1253         https://bugs.webkit.org/show_bug.cgi?id=142867
1254
1255         Rubber-stamped by Csaba Osztrogon.
1256
1257         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1258         a fixed revision for the openwebrtc-gst-plugins.
1259
1260 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1261
1262         Unreviewed build fix. Don't try to report stats for all benchmarks.
1263         Just report the geometric mean of preferred means.
1264
1265         * Scripts/run-jsc-benchmarks:
1266
1267 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1268
1269         run-jsc-benchmarks should only report preferred mean
1270         https://bugs.webkit.org/show_bug.cgi?id=142874
1271
1272         Reviewed by Geoffrey Garen.
1273
1274         Just collect statistics for the preferred mean.
1275
1276         * Scripts/run-jsc-benchmarks:
1277
1278 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1279
1280         [Content Extensions] Test regular expression parse failures.
1281         https://bugs.webkit.org/show_bug.cgi?id=142872
1282
1283         Reviewed by Benjamin Poulain.
1284
1285         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1286         (TestWebKitAPI::testPatternStatus):
1287         (TestWebKitAPI::TEST_F):
1288         Added tests for each parsing status.
1289
1290 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1291
1292         Fix API tests after r181754.
1293
1294         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1295         (TestWebKitAPI::testRequest):
1296
1297 2015-03-19  Brady Eidson  <beidson@apple.com>
1298
1299         Part of content extensions should apply css selectors
1300         https://bugs.webkit.org/show_bug.cgi?id=142604
1301
1302         Reviewed by Alex Christensen.
1303
1304         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1305         (WebCore::ContentExtensions::operator<<):
1306
1307 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1308
1309         [Win] Activate tests on EWS
1310         https://bugs.webkit.org/show_bug.cgi?id=142850
1311
1312         Reviewed by Alexey Proskuryakov.
1313
1314         * Scripts/webkitpy/common/config/ews.json: Add me as
1315         the EWS bot watcher, and activate tests.
1316
1317 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1318
1319         [GTK] Fix inspector userinterface related incremental build issue
1320         https://bugs.webkit.org/show_bug.cgi?id=142849
1321
1322         Reviewed by Carlos Garcia Campos.
1323
1324         * Scripts/webkitdirs.pm:
1325         (shouldRemoveCMakeCache):
1326
1327 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1328
1329         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1330         https://bugs.webkit.org/show_bug.cgi?id=142799
1331
1332         Reviewed by Brady Eidson.
1333
1334         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1335         (TestWebKitAPI::testPattern):
1336         (TestWebKitAPI::TEST_F):
1337         Start testing regex failures.
1338
1339 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1340
1341         Fix StringView typos after r181525 and r181558
1342         https://bugs.webkit.org/show_bug.cgi?id=142772
1343
1344         Reviewed by Darin Adler.
1345
1346         Add some tests in [1] to cover the StringView::startsWith,
1347         StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1348         StringView::endsWithIgnoringASCIICase implementations.
1349
1350         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1351         (TestWebKitAPI::TEST):
1352
1353 2015-03-18  Dana Burkart  <dburkart@apple.com>
1354
1355         Remove extraneous import to fix the build.
1356
1357         Unreviewed.
1358
1359         * Scripts/webkitpy/port/driver.py:
1360
1361 2015-03-18  Dana Burkart  <dburkart@apple.com>
1362
1363         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1364         https://bugs.webkit.org/show_bug.cgi?id=142547
1365
1366         Reviewed by Alexey Proskuryakov.
1367
1368         * Scripts/webkitpy/port/driver.py:
1369         (Driver._setup_environ_for_driver):
1370
1371 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1372
1373         Tweak how AppleSystemFontOSSubversion default is added
1374         https://bugs.webkit.org/show_bug.cgi?id=142835
1375
1376         Reviewed by Dan Bernstein.
1377
1378         * DumpRenderTree/mac/DumpRenderTree.mm:
1379         (setDefaultsToConsistentValuesForTesting):
1380
1381 2015-03-18  Dan Bernstein  <mitz@apple.com>
1382
1383         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1384         https://bugs.webkit.org/show_bug.cgi?id=142815
1385
1386         Reviewed by Darin Adler.
1387
1388         * Scripts/prepare-ChangeLog:
1389         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1390         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1391         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1392         warning only if a line ends without a backslash before the matching quotation mark was found.
1393
1394 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1395
1396         Remove unused "preprocessor" parameter to sub-CodeGenerators
1397         https://bugs.webkit.org/show_bug.cgi?id=142793
1398
1399         Reviewed by Darin Adler.
1400
1401         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1402         (new):
1403
1404 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1405
1406         [EFL] Bump gstreamer version to 1.4.4
1407         https://bugs.webkit.org/show_bug.cgi?id=142782
1408
1409         Reviewed by Philippe Normand.
1410
1411         * efl/jhbuild.modules:
1412         * efl/patches/gst-libav.patch:
1413         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1414         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1415
1416 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1417
1418         Fix the iOS build.
1419
1420         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1421         (WTR::InjectedBundle::platformInitialize):
1422
1423 2015-03-17  Dean Jackson  <dino@apple.com>
1424
1425         check-webkit-style should allow "bool a : 1"
1426         https://bugs.webkit.org/show_bug.cgi?id=142794
1427
1428         Reviewed by Brent Fulgham.
1429
1430         We should allow member bitfields of the form:
1431
1432         bool m_var : 1;
1433
1434         It seems that Visual Studio 8 was the last compiler that
1435         wasn't happy about not using unsigned here. We already have
1436         about 500 cases (in WebCore) where people were ignoring this rule.
1437
1438         * Scripts/webkitpy/style/checkers/cpp.py:
1439         (check_language): Allow "bool".
1440         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1441         (CppStyleTest.test_enum_bitfields):
1442         (CppStyleTest.test_plain_integral_bitfields):
1443
1444 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1445
1446         Compile character ranges targeting the same state as range check in the bytecode
1447         https://bugs.webkit.org/show_bug.cgi?id=142759
1448
1449         Reviewed by Alex Christensen.
1450
1451         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1452         (TestWebKitAPI::TEST_F):
1453
1454 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1455
1456         W3C test parser and converter should use test importer host
1457         https://bugs.webkit.org/show_bug.cgi?id=142729
1458
1459         Reviewed by Bem Jones-Bey.
1460
1461         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1462         This enables adding more TestImporter unit testing.
1463         This patch also ensures that the git object instantiated by TestDownloader is using the
1464         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1465
1466         * Scripts/webkitpy/common/system/filesystem_mock.py:
1467         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1468         * Scripts/webkitpy/w3c/test_downloader.py:
1469         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1470         (TestDownloader.checkout_test_repository): Making use of the new git function.
1471         * Scripts/webkitpy/w3c/test_importer.py:
1472         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1473         (TestImporter.import_tests): Adding host as parameter to the converter.
1474         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1475         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1476         (TestImporterTest):
1477         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1478         * Scripts/webkitpy/w3c/test_parser.py:
1479         (TestParser.__init__): Adding host as parameter constructor.
1480
1481 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1482
1483         [GTK] WebKitDOM objects leaking
1484         https://bugs.webkit.org/show_bug.cgi?id=118788
1485
1486         Reviewed by Darin Adler and Sergio Villar Senin.
1487
1488         Update DOMObjectCache unit test to check that DOM objects are also
1489         released when new contents are loaded in the web view, and the old
1490         document is detached from the frame.
1491
1492         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1493         (testWebKitDOMObjectCache):
1494         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1495         (runTest):
1496
1497 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1498
1499         W3C test importer default import folder should be LayoutTests/imported/w3c
1500         https://bugs.webkit.org/show_bug.cgi?id=142728
1501
1502         Reviewed by Bem Jones-Bey.
1503
1504         * Scripts/webkitpy/w3c/test_importer.py:
1505         (parse_args): Updating the default destination option value to 'imported/w3c'.
1506
1507 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1508
1509         [GTK] basic OpenWebRTC build support
1510         https://bugs.webkit.org/show_bug.cgi?id=142393
1511
1512         Reviewed by Carlos Garcia Campos.
1513
1514         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1515         is not the upstream OpenWebRTC repository. This temporary fork
1516         contains a few patches needed by WebKit for audio/video rendering.
1517
1518 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1519
1520         [CMake][EFL] Build test tools only for developer mode
1521         https://bugs.webkit.org/show_bug.cgi?id=142761
1522
1523         Reviewed by Csaba Osztrogonác.
1524
1525         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1526
1527         * CMakeLists.txt:
1528
1529 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1530
1531         Remove never used "useLayerOnTop" bindings generator argument
1532         https://bugs.webkit.org/show_bug.cgi?id=142773
1533
1534         Reviewed by Darin Adler.
1535
1536         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1537         (new):
1538
1539 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1540
1541         Enable ES6 classes by default
1542         https://bugs.webkit.org/show_bug.cgi?id=142774
1543
1544         Reviewed by Gavin Barraclough.
1545
1546         * Scripts/webkitperl/FeatureList.pm:
1547
1548 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1549
1550         Fix webkitpy tests after r181585.
1551
1552         Looks like "me" cannot be anyone's email, it's a special case.
1553
1554         * Scripts/webkitpy/common/config/contributors.json:
1555
1556 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1557
1558         Add tolerance to WebAudio tests
1559         https://bugs.webkit.org/show_bug.cgi?id=142676
1560
1561         Reviewed by Tim Horton.
1562
1563         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1564
1565         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1566         (TestResultWriter.create_audio_diff_and_write_result):
1567         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1568         (FailureAudio.write_failure):
1569         * Scripts/webkitpy/port/base.py:
1570         (Port.do_audio_results_differ):
1571         Diff audio failures.
1572
1573         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1574         tests to use real parseable WAV data, and got rid of base64, which there didn't
1575         seem to have been any reason for.
1576
1577 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1578
1579         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1580         https://bugs.webkit.org/show_bug.cgi?id=142720
1581
1582         Reviewed by Myles C. Maxfield.
1583
1584         Activate system copies of Microsoft fonts for the current process, thus overriding
1585         any other ones that could be preferred by the system otherwise.
1586
1587         * DumpRenderTree/mac/DumpRenderTree.mm:
1588         (activateSystemCoreWebFonts):
1589         (adjustFonts):
1590         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1591         (WTR::activateSystemCoreWebFonts):
1592         (WTR::activateFonts):
1593
1594 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1595
1596         Created Streams API watchlist
1597         https://bugs.webkit.org/show_bug.cgi?id=142684
1598
1599         Reviewed by Benjamin Poulain.
1600
1601         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1602         watchlist and added Benjamin, Youenn and me to it.
1603
1604 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1605
1606         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1607         https://bugs.webkit.org/show_bug.cgi?id=142715
1608
1609         Reviewed by Brent Fulgham.
1610
1611         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1612         (TestWebKitAPI::TEST):
1613
1614 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1615
1616         Change the exact attribute matching to be ASCII case-insensitive
1617         https://bugs.webkit.org/show_bug.cgi?id=142609
1618
1619         Reviewed by Darin Adler.
1620
1621         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1622         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1623
1624 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1625
1626         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1627         https://bugs.webkit.org/show_bug.cgi?id=134764
1628
1629         Reviewed by Ryosuke Niwa.
1630
1631         TestDownloader is introduced to download W3C tests from the official
1632         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1633         and https://github.com/w3c/csswg-test.git).
1634         TestDownloader clones the repositories and checkouts revisions of the tests
1635         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1636
1637         Similarly to https://codereview.chromium.org/148173016,
1638         TestDownloader copies part of the files based on the rules
1639         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1640
1641         TestDownloader is used by TestImporter when no source directory is provided.
1642
1643         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1644         (TestDownloader):
1645         (TestDownloader.default_options):
1646         (TestDownloader.load_test_repositories):
1647         (TestDownloader.__init__):
1648         (TestDownloader.checkout_test_repository):
1649         (TestDownloader._init_paths_from_expectations):
1650         (TestDownloader._add_test_suite_paths):
1651         (TestDownloader._empty_directory):
1652         (TestDownloader.copy_tests):
1653         (TestDownloader.download_tests):
1654         * Scripts/webkitpy/w3c/test_importer.py:
1655         (main):
1656         (parse_args):
1657         (TestImporter.__init__):
1658         (TestImporter.do_import):
1659         (TestImporter.test_downloader):
1660         (TestImporter.find_importable_tests.should_keep_subdir):
1661         (TestImporter.should_convert_test_harness_links):
1662         (TestImporter.import_tests):
1663         (TestImporter.write_import_log):
1664
1665 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1666
1667         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1668         https://bugs.webkit.org/show_bug.cgi?id=142630
1669
1670         Reviewed by Tim Horton.
1671
1672         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1673         Removed an ifdef that disabled the fix on Mavericks.
1674
1675 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1676
1677         Remove isWK2 cruft from webkitdirs.pm after r170426
1678         https://bugs.webkit.org/show_bug.cgi?id=142618
1679
1680         Reviewed by Daniel Bates.
1681
1682         * Scripts/webkitdirs.pm:
1683         (isWK2): Deleted.
1684
1685 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1686
1687         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1688         https://bugs.webkit.org/show_bug.cgi?id=138687
1689
1690         Reviewed by Carlos Garcia Campos.
1691
1692         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1693         affect other processes.
1694
1695         The implementation is imperfect, because the change happens asynchronously, but I
1696         don't expect it to be a problem in practice.
1697
1698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1699         (WTR::InjectedBundle::beginTesting):
1700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1701         (WTR::TestRunner::setAlwaysAcceptCookies):
1702         * WebKitTestRunner/TestInvocation.cpp:
1703         (WTR::TestInvocation::invoke):
1704         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1705
1706 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1707
1708         [EFL] Enable building EFL 1.13 with NEON support
1709         https://bugs.webkit.org/show_bug.cgi?id=142619
1710
1711         Reviewed by Gyuyoung Kim.
1712
1713         * efl/jhbuild.modules:
1714
1715 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1716
1717         [Content Extensions] Add resource type and load type triggers.
1718         https://bugs.webkit.org/show_bug.cgi?id=142422
1719
1720         Reviewed by Benjamin Poulain.
1721
1722         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1723         (TestWebKitAPI::testRequest):
1724         (TestWebKitAPI::mainDocumentRequest):
1725         (TestWebKitAPI::TEST_F):
1726         (TestWebKitAPI::testURL): Deleted.
1727
1728 2015-03-10  Sam Weinig  <sam@webkit.org>
1729
1730         Allow adding a button in input elements for auto fill related functionality
1731         <rdar://problem/19782066>
1732         https://bugs.webkit.org/show_bug.cgi?id=142564
1733
1734         Reviewed by Anders Carlsson.
1735
1736         * WebKitTestRunner/TestController.cpp:
1737         (WTR::TestController::createOtherPage):
1738         (WTR::TestController::createWebViewWithOptions):
1739         Update for new callback.
1740
1741 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1742
1743         Add basic support for BOL and EOL assertions to the URL Filter parser
1744         https://bugs.webkit.org/show_bug.cgi?id=142568
1745
1746         Reviewed by Alex Christensen.
1747
1748         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1749         (TestWebKitAPI::TEST_F):
1750
1751 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1752
1753         [GTK] Add support for handling TLS errors to MiniBrowser
1754         https://bugs.webkit.org/show_bug.cgi?id=142576
1755
1756         Reviewed by Sergio Villar Senin.
1757
1758         It's useful for testing TLS errors handling itself, but also to
1759         allow ignoring TLS errors when testing.
1760
1761         * MiniBrowser/gtk/BrowserWindow.c:
1762         (webViewLoadFailedWithTLSerrors):
1763         (browserWindowConstructed):
1764
1765 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1766
1767         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1768         https://bugs.webkit.org/show_bug.cgi?id=142569
1769
1770         Reviewed by David Hyatt.
1771
1772         Test Optional::valueOrCompute().
1773
1774         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1775         (TestWebKitAPI::TEST):
1776
1777 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1778
1779         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1780         https://bugs.webkit.org/show_bug.cgi?id=126688
1781
1782         Reviewed by Gustavo Noronha Silva.
1783
1784         * CMakeLists.txt: Build testing tools only for developer builds,
1785         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1786         * MiniBrowser/gtk/CMakeLists.txt: Only add
1787         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1788         and add a rule to install the MiniBrowser.
1789         * MiniBrowser/gtk/main.c:
1790         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1791         builds.
1792
1793 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1794
1795         Add some DateMath tests to TestWebKitAPI
1796         https://bugs.webkit.org/show_bug.cgi?id=142565
1797
1798         Reviewed by Alexey Proskuryakov.
1799
1800         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1801         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1802         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1804         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1805
1806 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1807
1808         Regression(r181257): WTF_WorkQueue.Simple is flaky
1809         https://bugs.webkit.org/show_bug.cgi?id=142560
1810
1811         Unreviewed attempt to improve test stability.
1812
1813         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1814         the WorkQueue a little later to redue flakiness.
1815
1816 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1817
1818         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1819         https://bugs.webkit.org/show_bug.cgi?id=142555
1820
1821         Reviewed by Simon Fraser.
1822
1823         * DumpRenderTree/mac/DumpRenderTree.mm:
1824         (setDefaultsToConsistentValuesForTesting):
1825         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1826         (WTR::InjectedBundle::platformInitialize):
1827
1828 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1829
1830         Use unsigned for HashSet size.
1831         https://bugs.webkit.org/show_bug.cgi?id=142518
1832
1833         Reviewed by Benjamin Poulain.
1834
1835         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1836         (TestWebKitAPI::TEST):
1837         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1838         (TestWebKitAPI::testInitialCapacity):
1839         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1840         (TestWebKitAPI::TEST):
1841
1842 2015-03-10  Daniel Bates  <dabates@apple.com>
1843
1844         [iOS] Add WebKitSystemInterface for iOS 8.2
1845         https://bugs.webkit.org/show_bug.cgi?id=142505
1846
1847         Rubber-stamped by Anders Carlsson.
1848
1849         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1850         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1851         copy-webkitlibraries-to-product-directory in r181286.
1852
1853         * Scripts/copy-webkitlibraries-to-product-directory:
1854
1855 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1856
1857         Extend URL filter's Term definition to support groups/subpatterns
1858         https://bugs.webkit.org/show_bug.cgi?id=142519
1859
1860         Reviewed by Alex Christensen.
1861
1862         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1863         (TestWebKitAPI::testURL):
1864
1865 2015-03-06  Jer Noble  <jer.noble@apple.com>
1866
1867         Add an option to run-webkit-tests to override the LayoutTests/ directory
1868         https://bugs.webkit.org/show_bug.cgi?id=142418
1869
1870         Reviewed by David Kilzer.
1871
1872         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1873         directory. The base port will parse the options during initialization and store the override
1874         location if present. layout_tests_dir() will return this overridden location if set.
1875
1876         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1877         (parse_args):
1878         * Scripts/webkitpy/port/base.py:
1879         (Port.__init__):
1880         (Port.layout_tests_dir):
1881
1882 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1883
1884         [CMake] Enable WorkQueue tests for CMake ports
1885         https://bugs.webkit.org/show_bug.cgi?id=142473
1886
1887         Reviewed by Darin Adler.
1888
1889         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1890         the list of source files.
1891         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1892         to the list of include directories for EFL.
1893
1894 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1895
1896         Attempt to fix timeouts on iOS Simulator layout tests
1897
1898         * Scripts/webkitpy/port/ios.py:
1899         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1900         Simulator end after the first 50 tests time out.  Some analysis
1901         this past weekend shows that the 'Booted' status in the output
1902         of `xcrun simctl list` is not sufficient (and watching the test
1903         run shows that SpringBoard hasn't fully started to the point
1904         where it's displaying icons on the home screen).  The workaround
1905         until we have a better fix is to add an arbitrary timeout to let
1906         SpringBoard finish launching.  In practice, 15 seconds is
1907         probably enough, but 30 seconds should nearly always work.
1908
1909 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1910
1911         Unreviewed. Add myself as a committer.
1912
1913         * Scripts/webkitpy/common/config/contributors.json:
1914
1915 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1916
1917         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1918
1919         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1920         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1921         an expectation that will fail if we hit the race condition.
1922         This test is inherently racy and will deadlock if the first job
1923         for queue2 takes the mutex lock before the second job for
1924         queue1.
1925
1926 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1927
1928         [Win] WTF::WorkQueue does not balance ref/deref properly
1929         https://bugs.webkit.org/show_bug.cgi?id=142471
1930
1931         Reviewed by Antti Koivisto.
1932
1933         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1934         (TestWebKitAPI::TEST): Check that the refcount is correct.
1935
1936 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1937
1938         Do not show passing test result on output of EFL layout test
1939         https://bugs.webkit.org/show_bug.cgi?id=142380
1940
1941         Reviewed by Darin Adler.
1942
1943         To show passing tests has caused inconvenience when we detect problem tests
1944         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1945         in order not to show passing tests in the output of EFL layout test.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1948         (RunWebKitTests.start):
1949
1950 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1951
1952         Unreviewed build fix.
1953
1954         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1955         (TestWebKitAPI::TEST): Remove two unused variables.
1956
1957 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1958
1959         Add some WorkQueue tests to TestWebKitAPI
1960         https://bugs.webkit.org/show_bug.cgi?id=142447
1961
1962         Reviewed by Sam Weinig.
1963
1964         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1965         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1967         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1968         (TestWebKitAPI::simpleTest):
1969         (TestWebKitAPI::longTest):
1970         (TestWebKitAPI::thirdTest):
1971         (TestWebKitAPI::finishedTests):
1972         (TestWebKitAPI::TEST):
1973         (TestWebKitAPI::longTest2):
1974
1975 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1976
1977         Remove willDestroyFrame in WKBundlePageLoaderClient
1978         https://bugs.webkit.org/show_bug.cgi?id=142389
1979
1980         Reviewed by Anders Carlsson.
1981
1982         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1983         (WTR::InjectedBundlePage::InjectedBundlePage):
1984
1985 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1986
1987         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1988         https://bugs.webkit.org/show_bug.cgi?id=142433
1989
1990         Reviewed by Darin Adler.
1991
1992         Include more TestWebKitAPI tests when building for Windows. Also
1993         fix a build error in MetaAllocator.cpp caused by one of the
1994         Microsoft headers #defining 'small'.
1995
1996         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1997         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1998         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1999
2000 2015-03-06  Sam Weinig  <sam@webkit.org>
2001
2002         [Content Extensions] Move compiling of content extensions to the UIProcess
2003         https://bugs.webkit.org/show_bug.cgi?id=142402
2004
2005         Reviewed by Benjamin Poulain.
2006
2007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2008         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2009         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2010         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2011         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2012         (TestWebKitAPI::TEST_F):
2013         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2014         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2015         is now abstract).
2016
2017 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2018
2019         [Win] Correct Windows build.
2020
2021         Rubberstamped by Michael Saboff
2022
2023         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2024         in the GOTO labels.
2025
2026 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2027
2028         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2029         https://bugs.webkit.org/show_bug.cgi?id=142385
2030
2031         Reviewed by Sergio Villar Senin.
2032
2033         Use stack allocated GMainLoopSources to make sure they are
2034         cancelled automatically if the test finishes before they have
2035         been processed.
2036
2037         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2038         (testWebViewSyncRequestOnMaxConns):
2039
2040 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2041
2042         Remove Mountain Lion libraries since ML isn't supported
2043         https://bugs.webkit.org/show_bug.cgi?id=142332
2044
2045         Reviewed by Darin Adler.
2046
2047         * Scripts/copy-webkitlibraries-to-product-directory:
2048
2049 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2050
2051         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2052         https://bugs.webkit.org/show_bug.cgi?id=142083
2053
2054         Reviewed by Simon Fraser.
2055
2056         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2057
2058         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2059         (WebPlatformTestServer._copy_webkit_test_files):
2060
2061 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2062
2063         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2064         https://bugs.webkit.org/show_bug.cgi?id=141946
2065
2066         Reviewed by Ryosuke Niwa.
2067
2068         Check in ircbot.py and irclib.py to avoid network problems in the future.
2069
2070         * Scripts/webkitpy/common/net/irc/ircbot.py:
2071         * Scripts/webkitpy/thirdparty/__init__.py:
2072         (AutoinstallImportHook.find_module):
2073         (AutoinstallImportHook._install_irc): Deleted.
2074         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2075         (ThirdpartyTest.test_imports):
2076         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2077         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2078         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2079
2080 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2081
2082         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2083
2084         See also fix to config.json in r181097.
2085
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2087         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2088         bots.
2089
2090 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2091
2092         run-jsc-stress-tests should determine the architecture from ELF binaries
2093         https://bugs.webkit.org/show_bug.cgi?id=142335
2094
2095         Reviewed by Darin Adler.
2096
2097         * Scripts/run-jsc-stress-tests:
2098
2099 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2100
2101         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2102         <http://webkit.org/b/142226>
2103
2104         Reviewed by Darin Adler.
2105
2106         * Scripts/webkitpy/port/ios.py:
2107         (IOSSimulatorPort.default_baseline_search_path): Switch the
2108         TestExpectations order of ios-simulator-wk2 from this:
2109           ios-simulator-wk2, wk2, ios-simulator
2110         To this:
2111           ios-simulator-wk2, ios-simualtor, wk2
2112
2113 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2114
2115         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2116         https://bugs.webkit.org/show_bug.cgi?id=142370
2117
2118         Reviewed by Dean Jackson.
2119
2120         * Scripts/webkitdirs.pm:
2121         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2122         logs, one for warnings, the other for errors.
2123         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2124         into the standard BuildOutput.htm document.
2125
2126 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2127
2128         Dashboard has trouble parsing iOS test output
2129         <http://webkit.org/b/142364>
2130
2131         Reviewed by Alex Christensen.
2132
2133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2134         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2135         Add fallback path to build a regex using 'matchString' so that
2136         it matches anywhere in the line.  In practice, 'matchString' is
2137         a prefix for the label following the number.
2138
2139 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2140
2141         Fix linker warnings in TestWebKitAPI.
2142         https://bugs.webkit.org/show_bug.cgi?id=141912
2143
2144         Reviewed by David Kilzer.
2145
2146         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2147         Do not export TearDownTestCase or SetUpTestCase symbols.
2148
2149 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2150
2151         [Win] Unreviewed EWS fix.
2152
2153         * Scripts/webkitdirs.pm:
2154         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2155         the EWS output more usable.
2156
2157 2015-03-05  Chris Dumez  <cdumez@apple.com>
2158
2159         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2160         https://bugs.webkit.org/show_bug.cgi?id=142350
2161
2162         Reviewed by Michael Saboff and Benjamin Poulain.
2163
2164         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2165         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2166
2167         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2168         (TestWebKitAPI::TEST):
2169
2170 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2171
2172         [Win] Ensure build target directory exists when launching MSBuild
2173         https://bugs.webkit.org/show_bug.cgi?id=142360
2174
2175         Reviewed by Dean Jackson.
2176
2177         Create the build output directory (if it doesn't exist) before
2178         launching MSBuild so that it can immediately begin writing logs.
2179
2180         * Scripts/webkitdirs.pm:
2181         (buildVisualStudioProject):
2182
2183 2015-03-05  Chris Dumez  <cdumez@apple.com>
2184
2185         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2186         https://bugs.webkit.org/show_bug.cgi?id=142325
2187
2188         Reviewed by Csaba Osztrogonác.
2189
2190         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2191         As a result, "--webkit-test-runner / -2" parameters are replaced by
2192         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2193         than WebKitTestRunner.
2194
2195         * BuildSlaveSupport/build.webkit.org-config/config.json:
2196         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2197         (RunWebKit1Tests):
2198         (RunWebKit1Tests.start):
2199         (RunWebKit1LeakTests):
2200         (RunWebKit1LeakTests.start):
2201         (RunAndUploadPerfTestsWebKit1):
2202         (RunAndUploadPerfTestsWebKit1.start):
2203         (TestFactory):
2204         (TestWebKit1LeaksFactory):
2205         (TestWebKit1LeaksFactory.__init__):
2206         (TestWebKit1Factory):
2207         (TestWebKit1AllButJSCFactory):
2208         (TestAllButJSCFactory):
2209         (BuildAndPerfTestWebKit1Factory):
2210         (BuildAndPerfTestWebKit1Factory.__init__):
2211         (BuildAndPerfTestFactory):
2212         (BuildAndPerfTestFactory.__init__):
2213         (DownloadAndPerfTestWebKit1Factory):
2214         (DownloadAndPerfTestWebKit1Factory.__init__):
2215         (DownloadAndPerfTestFactory):
2216         (DownloadAndPerfTestFactory.__init__):
2217         (RunWebKitLeakTests): Deleted.
2218         (RunWebKitLeakTests.start): Deleted.
2219         (RunWebKit2Tests): Deleted.
2220         (RunWebKit2Tests.start): Deleted.
2221         (RunAndUploadPerfTestsWebKit2): Deleted.
2222         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2223         (TestLeaksFactory): Deleted.
2224         (TestLeaksFactory.__init__): Deleted.
2225         (TestWebKit2Factory): Deleted.
2226         (TestWebKit2AndJSCFactory): Deleted.
2227         (BuildAndPerfTestWebKit2Factory): Deleted.
2228         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2229         (DownloadAndPerfTestWebKit2Factory): Deleted.
2230         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2231         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2232         (parse_args):
2233         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2234         (PerfTestsRunner._parse_args):
2235         * Scripts/webkitpy/port/port_testcase.py:
2236         (PortTestCase.test_build_driver):
2237
2238 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2239
2240         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2241         https://bugs.webkit.org/show_bug.cgi?id=140845
2242
2243         Reviewed by David Kilzer.
2244
2245         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2246         and generate suitable build commands to drive a full build from our
2247         existing solution files.
2248
2249         * Scripts/webkitdirs.pm:
2250         (msBuildInstallDir): Added.
2251         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2252         line arguments to drive the build.
2253         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2254         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2255         to specify build architecture.
2256         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2257         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2258         bother looking for CoreUI or SafariTheme build logs.
2259
2260 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2261
2262         [buildbot] mastercfg_unittest.py should be runnable easily
2263         https://bugs.webkit.org/show_bug.cgi?id=142219
2264
2265         Reviewed by Chris Dumez.
2266
2267         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2268         the last Twisted version works together with this buildbot version.
2269
2270         * Scripts/webkitpy/common/system/autoinstall.py:
2271         (AutoInstaller): Added prepend_to_search_path argument to be able
2272         to prefer autoinstalled package to system package.
2273         (AutoInstaller.__init__):
2274         (AutoInstaller._set_up_target_dir):
2275         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2276         (AutoInstaller._prepare_package):
2277         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2278         * Scripts/webkitpy/thirdparty/__init__.py:
2279         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2280
2281 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2282
2283         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2284         https://bugs.webkit.org/show_bug.cgi?id=131162
2285
2286         Reviewed by Gyuyoung Kim.
2287
2288         * MiniBrowser/efl/main.c:
2289         (on_download_request):
2290         (on_download_finished):
2291         (on_download_failed):
2292         (window_create):
2293         Adapt download callbacks to new callback mechanism
2294
2295 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2296
2297         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2298
2299         In r180927 we updated the libsoup version used by the jhbuild. In
2300         this new version the sniffer uses image/x-icon instead of
2301         image/vnd.microsoft.icon for blank.ico resource.
2302
2303         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2304         (testWebResourceMimeType):
2305
2306 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2307
2308         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2309         https://bugs.webkit.org/show_bug.cgi?id=142244
2310
2311         Reviewed by Sergio Villar Senin.
2312
2313         Check that the SSL server doesn't process any request in case of
2314         TLS errors when the policy is set to FAIL.
2315
2316         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2317         (testTLSErrorsPolicy):
2318         (testTLSErrorsRedirect):
2319         (testTLSErrorsHTTPAuth):
2320         (testLoadFailedWithTLSErrors):
2321         (testSubresourceLoadFailedWithTLSErrors):
2322         (httpsServerCallback):
2323
2324 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2325
2326         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2327         https://bugs.webkit.org/show_bug.cgi?id=141154
2328
2329         Reviewed by Jer Noble.
2330
2331         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2332
2333         For the sake of completeness WebKitTestRunner should specify temporary
2334         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2335
2336         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2337         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2338         to get data storage paths. Only Mac port has an actual implementation of it.
2339         However, WebKitTestRunner overrides them in favour of unique temporary dir
2340         which is taken from libraryPathForTesting().
2341
2342         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2343         is not implemented for EFL and GTK ports it returns an empty string.
2344         All default data folders besides MediaKeys are overridden in TestRunner
2345         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2346         env variable.
2347
2348         GTK port does not enable encrypted keys by default so
2349         WebMediaKeyStorageManager::initialize() code path is never triggered.
2350
2351         * WebKitTestRunner/TestController.cpp:
2352         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2353         WebKit ports.
2354
2355 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2356
2357         [buildbot] Add regression test to check which builder runs which tests
2358         https://bugs.webkit.org/show_bug.cgi?id=142166
2359
2360         Reviewed by Alexey Proskuryakov.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2363         (BuildStepsConstructorTest.createTest):
2364         (BuildStepsTest):
2365         (BuildStepsTest.generateTests):
2366         (BuildStepsTest.createTest):
2367         (BuildStepsTest.createTest.doTest):
2368         (BuildStepsTest.test_unnecessary_expected_results):
2369
2370 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2371
2372         Unreviewed, rolling out r181054.
2373         https://bugs.webkit.org/show_bug.cgi?id=142320
2374
2375         Broke the api tests (Requested by sundiamonde on #webkit).
2376
2377         Reverted changeset:
2378
2379         "Fix linker warnings in TestWebKitAPI."
2380         https://bugs.webkit.org/show_bug.cgi?id=141912
2381         http://trac.webkit.org/changeset/181054
2382
2383 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2384
2385         Fix linker warnings in TestWebKitAPI.
2386         https://bugs.webkit.org/show_bug.cgi?id=141912
2387
2388         Reviewed by David Kilzer.
2389
2390         * TestWebKitAPI/Configurations/Base.xcconfig:
2391         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2392
2393 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2394
2395         [Mac] Set SystemUIFontSelect in DRT and WKTR
2396         https://bugs.webkit.org/show_bug.cgi?id=142303
2397
2398         Reviewed by Myles C. Maxfield.
2399
2400         * DumpRenderTree/mac/DumpRenderTree.mm:
2401         (setDefaultsToConsistentValuesForTesting):
2402         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2403         (WTR::InjectedBundle::platformInitialize):
2404
2405 2015-03-04  Chris Dumez  <cdumez@apple.com>
2406
2407         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2408         https://bugs.webkit.org/show_bug.cgi?id=142314
2409         <rdar://problem/20046835>
2410
2411         Reviewed by Ryosuke Niwa.
2412
2413         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2414         to get WK2 code coverage.
2415
2416         * BuildSlaveSupport/build.webkit.org-config/config.json:
2417
2418 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2419
2420         Move content extensions test to properly named directory.
2421         https://bugs.webkit.org/show_bug.cgi?id=142299
2422
2423         Reviewed by Tim Horton.
2424
2425         * WebKitTestRunner/mac/TestControllerMac.mm:
2426         (WTR::TestController::platformConfigureViewForTest):
2427
2428 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2429
2430         W3C test importer should use filesystem instead of os.walk
2431         https://bugs.webkit.org/show_bug.cgi?id=142085
2432
2433         Reviewed by Bem Jones-Bey.
2434
2435         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2436         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2437         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2438
2439         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2440         Added a unit test to check that test importer is now black-box testable using a Mock system.
2441
2442         * Scripts/webkitpy/common/system/filesystem.py:
2443         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2444         (FileSystem.dirs_under.filter_all):
2445         * Scripts/webkitpy/common/system/filesystem_mock.py:
2446         (MockFileSystem.dirs_under):
2447         (MockFileSystem.dirs_under.filter_all):
2448         (MockFileSystem.getsize):
2449         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2450         (MockFileSystemTest.test_dirs_under):
2451         (MockFileSystemTest.test_dirs_under.filter_dir):
2452         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2453         (RealFileSystemTest.test_sep):
2454         (RealFileSystemTest):
2455         (RealFileSystemTest.test_dirs_under):
2456         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2457         * Scripts/webkitpy/w3c/test_importer.py:
2458         (TestImporter.do_import):
2459         (TestImporter.find_importable_tests.should_keep_subdir):
2460         (TestImporter.find_importable_tests):
2461         (TestImporter.should_keep_subdir): Deleted.
2462         (TestImporter.should_skip_file): Deleted.
2463         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2464         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2465
2466 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2467
2468         [WebEditingTester] Add support for the find and replace bar
2469         https://bugs.webkit.org/show_bug.cgi?id=142247
2470
2471         Reviewed by Enrica Casucci.
2472
2473         While it's not hooked up yet in WKWebView, adding support for the
2474         find bar to WebEditingTester will help us implement that functionality.
2475
2476         * WebEditingTester/AppDelegate.h:
2477         * WebEditingTester/AppDelegate.m:
2478         (-[WebEditingAppDelegate performTextFinderAction:]):
2479         * WebEditingTester/MainMenu.xib:
2480         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2481
2482         * WebEditingTester/WK2WebDocumentController.m:
2483         (-[WK2WebDocumentController awakeFromNib]):
2484         (-[WK2WebDocumentController performTextFinderAction:]):
2485         (-[WK2WebDocumentController findBarView]):
2486         (-[WK2WebDocumentController setFindBarView:]):
2487         (-[WK2WebDocumentController isFindBarVisible]):
2488         (-[WK2WebDocumentController setFindBarVisible:]):
2489         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2490         (-[WK2WebDocumentController layout]):
2491         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2492         pointing at the WKWebView (currently nothing will work, but the bar will
2493         show up). Install and uninstall the bar as needed.
2494
2495         * WebEditingTester/WebDocument.xib:
2496         Don't use a full-size content view. There's no need, and it makes find
2497         bar layout harder.
2498
2499         * WebEditingTester/WebDocumentController.h:
2500         * WebEditingTester/WebDocumentController.m:
2501         (-[WebDocumentController performTextFinderAction:]):
2502
2503 2015-03-03  Sam Weinig  <sam@webkit.org>
2504
2505         [Content Extensions] Split parsing and compiling of content extensions into their own files
2506         https://bugs.webkit.org/show_bug.cgi?id=142259
2507
2508         Reviewed by Anders Carlsson.
2509
2510         Add basic unit test for the content filter compiler.
2511
2512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2513         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2514         (WebCore::ContentExtensions::operator<<):
2515         (TestWebKitAPI::ContentFilterTest::SetUp):
2516         (TestWebKitAPI::TEST_F):
2517
2518 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2519
2520         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2521         https://bugs.webkit.org/show_bug.cgi?id=142230
2522
2523         Reviewed by Csaba Osztrogonác.
2524
2525         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2526         (TestFactory):
2527         (TestFactory.getProduct): Added
2528         (TestFactory.__init__): moved downloader to getProduct
2529         (BuildAndTestFactory):
2530         (BuildAndTestFactory.getProduct): Added
2531         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2532         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2533
2534 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2535
2536         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2537         https://bugs.webkit.org/show_bug.cgi?id=142225
2538
2539         Reviewed by Carlos Garcia Campos.
2540
2541         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2542         (testWebViewWebContextLifetime):
2543         (beforeAll):
2544
2545 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2546
2547         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2548         <http://webkit.org/b/142243>
2549
2550         Reviewed by Alexey Proskuryakov.
2551
2552         * WebKitTestRunner/TestController.cpp:
2553         (WTR::TestController::webProcessName):
2554         (WTR::TestController::networkProcessName):
2555         - Return the same process name on iOS and Mac because they both
2556           use the same process name for local engineering builds.
2557
2558 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2559
2560         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2561         <http://webkit.org/b/141872>
2562
2563         Reviewed by Alex Christensen.
2564
2565         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2566         semi-colons in various places and fix whitespace.
2567         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2568         constants.
2569         (_IncludeState.__init__): Add self._visited_soft_link_section
2570         boolean state variable.
2571         (_IncludeState.visited_soft_link_section): Getter for
2572         self._visited_soft_link_section.
2573         (_IncludeState.check_next_include_order): Update state machine
2574         for soft-link headers.  Add check that soft-link headers always
2575         appear last.
2576         (_classify_include): Add check for soft-link header type.
2577         (check_include_line): Return early if there is a soft-link
2578         header error.
2579
2580         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2581         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2582         including soft-link headers.
2583         (OrderOfIncludesTest.test_classify_include): Add test for
2584         _SOFT_LINK_HEADER type.
2585
2586 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2587
2588         build.webkit.org/dashboard: Don't repeatedly handle each test type
2589         https://bugs.webkit.org/show_bug.cgi?id=142211
2590
2591         Reviewed by Tim Horton and Matt Hanson.
2592
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2594         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2595         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2596         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2597         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2598         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2599         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2600         Removed functions that build a link to test step results. The buildbot provides
2601         these links in JSON.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2604         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2605         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2606         We can easily add them to the map as needed.
2607         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2608         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2609         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2610         and then build a BuildbotTestResults object, which was strange.
2611         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2612
2613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2614         Corrected an unrelated assertion that was buggy, and kept firing.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2617         (BuildbotTestResults):
2618         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2619         (BuildbotTestResults.prototype._parseResults):
2620         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2621         Moved the code for parsing JSON results for a single step here.
2622
2623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2624         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2625         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2626         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2627         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2628         (BuildbotTesterQueueView.prototype.update): Deleted.
2629         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2630         Updated for the new data structures. One behavior change is that we now display individual
2631         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2632         test failures, 3 platform api test failures".
2633
2634 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2635
2636         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2637         https://bugs.webkit.org/show_bug.cgi?id=142094
2638
2639         Reviewed by Csaba Osztrogonác.
2640
2641         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2643         (TestFactory):
2644         (TestFactory.__init__): Made running of JSC tests conditional.
2645         (TestAllButJSCFactory):
2646         (TestJSCFactory): Added.
2647         (TestJSCFactory.__init__):
2648         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2649
2650 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2651
2652         `build-webkit --help` is wrong about how to build for the iOS simulator
2653         <http://webkit.org/b/142223>
2654
2655         Reviewed by Csaba Osztrogonác.
2656
2657         * Scripts/build-webkit: Fix help.
2658
2659 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2660
2661         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2662
2663         * gtk/jhbuild.modules:
2664
2665 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2666
2667         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2668         https://bugs.webkit.org/show_bug.cgi?id=141508
2669
2670         Reviewed by Sergio Villar Senin.
2671
2672         Add a unit test to check that synchronous XHRs load even if the
2673         maximum connection limits are reached.
2674
2675         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2676         (testWebViewSyncRequestOnMaxConns):
2677         (serverCallback):
2678         (beforeAll):
2679         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2680
2681 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2682
2683         Update the name of ASan build step.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2686
2687 2015-03-02  Jer Noble  <jer.noble@apple.com>
2688
2689         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2690         https://bugs.webkit.org/show_bug.cgi?id=142121
2691
2692         Reviewed by Simon Fraser.
2693
2694         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2695         that the initial and final screen rects for the web content are as expected.
2696
2697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2698         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2699         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2700         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2701         (runJavaScriptAlert):
2702         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2703         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2704         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2705         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2706         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2707         (TestWebKitAPI::TEST_F):
2708
2709 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2710
2711         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2712
2713         Follow-up fix for:
2714
2715         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2716         <http://webkit.org/b/142145>
2717
2718         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2719         (-[LTRelayController _environmentVariables]): Fix think-o.
2720
2721 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2722
2723         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2724         <http://webkit.org/b/142145>
2725
2726         Reviewed by Simon Fraser.
2727
2728         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2729         (-[LTRelayController _environmentVariables]): Add.
2730         (-[LTRelayController launchApp]): Use -_environmentVariables.
2731
2732 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2733
2734         [iOS] Stop running webkit-build-directory on every layout test
2735
2736         This was originally fixed by David Farler for Bug 135409 in
2737         r172602.
2738
2739         * Scripts/webkitpy/port/ios.py:
2740         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2741         run webkit-build-directory every time it's called.
2742
2743 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2744
2745         W3C importer should use filesystem instead of shutil/host
2746         https://bugs.webkit.org/show_bug.cgi?id=142012
2747
2748         Reviewed by Bem Jones-Bey.
2749
2750         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2751
2752         * Scripts/webkitpy/w3c/test_importer.py:
2753         (main):
2754         (TestImporter.do_import):
2755         (TestImporter.find_importable_tests):
2756         (TestImporter.import_tests):
2757         (TestImporter.remove_deleted_files):
2758         (TestImporter.write_import_log):
2759
2760 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2761
2762         W3C test importer should use filesystem to read and write files
2763         https://bugs.webkit.org/show_bug.cgi?id=142084
2764
2765         Reviewed by Bem Jones-Bey.
2766
2767         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2768
2769         * Scripts/webkitpy/w3c/test_importer.py:
2770         (TestImporter.import_tests):
2771         (TestImporter.remove_deleted_files):
2772         (TestImporter.write_import_log):
2773
2774 2015-02-27  Sam Weinig  <sam@webkit.org>
2775
2776         Add WebKit2 SPI to create a DOM File object
2777         https://bugs.webkit.org/show_bug.cgi?id=142109
2778
2779         Reviewed by Tim Horton.
2780
2781         Add a test for WKBundleFileHandleRef.
2782
2783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2784         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2785         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2786         (TestWebKitAPI::didFinishLoadForFrame):
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2789         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2790         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2791
2792 2015-02-27  Michael Saboff  <msaboff@apple.com>
2793
2794         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2795         https://bugs.webkit.org/show_bug.cgi?id=142112
2796
2797         Reviewed by Filip Pizlo.
2798
2799         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2800         <someDir> as the library path.
2801
2802         * Scripts/run-jsc-benchmarks:
2803
2804 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2805
2806         [WinCairo] Unreviewed build fix.
2807
2808         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2809         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2810
2811 2015-02-27  Anders Carlsson  <andersca@apple.com>
2812
2813         Add infrastructure for handling website data in the network process
2814         https://bugs.webkit.org/show_bug.cgi?id=142092
2815
2816         Reviewed by Andreas Kling.
2817
2818         Add a menu item that will fetch all website data, delete the returned data records, and
2819         fetch all website data again so we can confirm that it's all empty.
2820
2821         * MiniBrowser/mac/WK2BrowserWindowController.m:
2822         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2823
2824 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2825
2826         [Win] Remove remaining SafariTheme cruft
2827         https://bugs.webkit.org/show_bug.cgi?id=142075
2828
2829         Reviewed by Anders Carlsson.
2830
2831         Remove reference to SafariTheme-switching preference.
2832
2833         * DumpRenderTree/win/DumpRenderTree.cpp:
2834         (resetWebPreferencesToConsistentValues):
2835         (prepareConsistentTestingEnvironment):
2836
2837 2015-02-26  Doug Russell  <d_russell@apple.com>
2838
2839         AX: Expose caret browsing preference to accessibility API
2840         https://bugs.webkit.org/show_bug.cgi?id=141862
2841
2842         Reviewed by Chris Fleizach.
2843
2844         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2845         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2846
2847         * DumpRenderTree/AccessibilityUIElement.cpp:
2848         (setBoolAttributeValueCallback):
2849         (selectedTextMarkerRangeCallback):
2850         (resetSelectedTextMarkerRangeCallback):
2851         (AccessibilityUIElement::setBoolAttributeValue):
2852         (AccessibilityUIElement::selectedTextMarkerRange):
2853         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2854         (AccessibilityUIElement::getJSClass):
2855         * DumpRenderTree/AccessibilityUIElement.h:
2856         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2857         (AccessibilityUIElement::setBoolAttributeValue):
2858         (AccessibilityUIElement::selectedTextMarkerRange):
2859         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2860         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2861         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2862         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2863         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2864         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2865         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2866         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2867         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2868         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2869         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2870
2871 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2872
2873         [Win] Remove WebKitExportGenerator project (and related)
2874         https://bugs.webkit.org/show_bug.cgi?id=142035
2875
2876         Reviewed by Dean Jackson.
2877
2878         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2879         build log from WebKitExportGenerator.
2880
2881 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2882
2883         [EFL] Bump EFL version to 1.13.0
2884         https://bugs.webkit.org/show_bug.cgi?id=141708
2885
2886         Reviewed by Gyuyoung Kim.
2887
2888         * efl/jhbuild.modules:
2889
2890 2015-02-26  Sam Weinig  <sam@webkit.org>
2891
2892         Check in missing WebEditingTester.xcconfig file.
2893
2894         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2895
2896 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2897
2898         [webkitpy] Remove skipped file related crufts
2899         https://bugs.webkit.org/show_bug.cgi?id=142046
2900
2901         Reviewed by Ryosuke Niwa.
2902
2903         * Scripts/webkitpy/port/base.py:
2904         (Port.skipped_layout_tests):
2905         (Port._tests_from_skipped_file_contents): Deleted.
2906         (Port): Deleted.
2907         (Port._expectations_from_skipped_files): Deleted.
2908         * Scripts/webkitpy/port/mac_unittest.py:
2909         (MacTest.test_default_timeout_ms):
2910         (MacTest): Deleted.
2911         (test_tests_from_skipped_file_contents): Deleted.
2912
2913 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2914
2915         [Win] Unreviewed WinCairo build fix after r180653.
2916
2917         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2918
2919         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2920         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2921         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2922         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2923         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2924
2925 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2926
2927         [Win] Use WEBCORE_EXPORT instead of Definition file
2928         https://bugs.webkit.org/show_bug.cgi?id=141734
2929
2930         Reviewed by Alex Christensen.
2931
2932         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2933         Use a precompiled header so we can define our export macros properly.
2934         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2935         Visual studio automatic update stuff.
2936         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2937         Set up Precompiled Header use for project..
2938         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2939         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2940         declarations for building DumpRenderTree as a client of
2941         WebCore/WebKit.
2942
2943 2015-02-25  Mark Lam  <mark.lam@apple.com>
2944
2945         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2946         <https://webkit.org/b/141672>
2947
2948         Reviewed by Alexey Proskuryakov.
2949
2950         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2951         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2952         implementation that we can tell ASan to ignore.
2953
2954         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2955         which isn't effective for working around this issue.
2956
2957         * asan/webkit-asan-ignore.txt:
2958
2959 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2960
2961         CodeBlock crashes when dumping op_push_name_scope
2962         https://bugs.webkit.org/show_bug.cgi?id=141953
2963
2964         Reviewed by Filip Pizlo.
2965
2966         * Scripts/run-jsc-stress-tests:
2967
2968 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2969
2970         W3C test importer should use argparse instead of optparse
2971         https://bugs.webkit.org/show_bug.cgi?id=142013
2972
2973         Reviewed by Bem Jones-Bey.
2974
2975         * Scripts/webkitpy/w3c/test_importer.py:
2976         (main): Updating according argparse.
2977         (parse_args): Moving from optparse to argparse.
2978
2979 2015-02-25  Brady Eidson  <beidson@apple.com>
2980
2981         Get rid of TestInvocation::pathOrURL
2982         https://bugs.webkit.org/show_bug.cgi?id=142021
2983
2984         Reviewed by Tim Horton.
2985
2986         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2987         but most code that uses it expected an absolute path.
2988
2989         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2990
2991         * WebKitTestRunner/TestController.cpp:
2992         (WTR::TestController::updateWebViewSizeForTest):
2993         (WTR::TestController::updateWindowScaleForTest):
2994         (WTR::shouldUseFixedLayout):
2995         (WTR::TestController::updateLayoutTypeForTest):
2996
2997         * WebKitTestRunner/TestInvocation.cpp:
2998         (WTR::TestInvocation::TestInvocation):
2999         (WTR::TestInvocation::urlContains):
3000         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3001         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3002         (WTR::TestInvocation::invoke):
3003         (WTR::shouldLogFrameLoadDelegates): Deleted.
3004         (WTR::shouldLogHistoryClientCallbacks): Deleted.
3005         * WebKitTestRunner/TestInvocation.h:
3006         (WTR::TestInvocation::pathOrURL): Deleted.
3007
3008         * WebKitTestRunner/ios/TestControllerIOS.mm:
3009         (WTR::shouldMakeViewportFlexible):
3010         (WTR::TestController::platformConfigureViewForTest):
3011
3012         * WebKitTestRunner/mac/TestControllerMac.mm:
3013         (WTR::shouldUseThreadedScrolling):
3014         (WTR::TestController::platformConfigureViewForTest):
3015
3016 2015-02-25  Brady Eidson  <beidson@apple.com>
3017
3018         Layout test support for user content filters
3019         https://bugs.webkit.org/show_bug.cgi?id=142018
3020
3021         Reviewed by Tim Horton.
3022
3023         * WebKitTestRunner/TestController.cpp:
3024         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
3025
3026         * WebKitTestRunner/mac/TestControllerMac.mm:
3027         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
3028           file before loading the test itself.
3029
3030 2015-02-24  Sam Weinig  <sam@webkit.org>
3031
3032         Convert WebEditingTester to use xcconfig files
3033         https://bugs.webkit.org/show_bug.cgi?id=141879
3034
3035         Reviewed by Darin Adler.
3036
3037         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
3038
3039         * WebEditingTester/Configurations: Added.
3040         * WebEditingTester/Configurations/Base.xcconfig: Added.
3041         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
3042         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3043
3044 2015-02-24  Andy Estes  <aestes@apple.com>
3045
3046         Teach MiniBrowser how to disable per-window web processes
3047         https://bugs.webkit.org/show_bug.cgi?id=141988
3048
3049         Reviewed by Darin Adler.
3050
3051         * MiniBrowser/mac/AppDelegate.m:
3052         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3053         * MiniBrowser/mac/SettingsController.h:
3054         * MiniBrowser/mac/SettingsController.m:
3055         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3056         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3057         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3058         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3059
3060 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3061
3062         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3063         https://bugs.webkit.org/show_bug.cgi?id=141889
3064
3065         Reviewed by Darin Adler.
3066
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3068
3069 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3070
3071         REGRESSION(r179429): Can't type comments in Facebook
3072         https://bugs.webkit.org/show_bug.cgi?id=141859
3073
3074         Reviewed by Brent Fulgham.
3075
3076         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3077
3078         * DumpRenderTree/mac/DumpRenderTree.mm:
3079         (resetWebPreferencesToConsistentValues):
3080         * DumpRenderTree/win/DumpRenderTree.cpp:
3081         (resetWebPreferencesToConsistentValues):
3082         * WebKitTestRunner/TestController.cpp:
3083         (WTR::TestController::resetPreferencesToConsistentValues):
3084
3085 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3086
3087         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3088         https://bugs.webkit.org/show_bug.cgi?id=141867
3089
3090         Reviewed by Anders Carlsson.
3091
3092         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3093         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3094         be shared with the new test.
3095         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3096         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3097         (testLoadAlternateHTMLForLocalPage):
3098         (beforeAll):
3099
3100 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3101
3102         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3103         <http://webkit.org/b/141900>
3104
3105         Reviewed by Myles C. Maxfield.
3106
3107         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3108         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3109         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3110         - Rename to share code with iOS.
3111         - Add USE(APPKIT) around AppKit-specific headers and code.
3112         - Fix a check-webkit-style warning.
3113         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3114         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3115         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3116         - Remove ios/ActivateFontsIOS.mm.
3117         - Fix InjectedBundle/cocoa group to represent the directory on
3118           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3119
3120 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3121
3122         Unreviewed, rolling out r180547 and r180550.
3123         https://bugs.webkit.org/show_bug.cgi?id=141957
3124
3125         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3126
3127         Reverted changesets:
3128
3129         "REGRESSION(r179429): Can't type comments in Facebook"
3130         https://bugs.webkit.org/show_bug.cgi?id=141859
3131         http://trac.webkit.org/changeset/180547
3132
3133         "Constructor returning null should construct an object instead
3134         of null"
3135         https://bugs.webkit.org/show_bug.cgi?id=141640
3136         http://trac.webkit.org/changeset/180550
3137
3138 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3139
3140         REGRESSION(r179429): Can't type comments in Facebook
3141         https://bugs.webkit.org/show_bug.cgi?id=141859
3142
3143         Reviewed by Geoffrey Garen.
3144
3145         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3146
3147         * DumpRenderTree/mac/DumpRenderTree.mm:
3148         (resetWebPreferencesToConsistentValues):
3149         * WebKitTestRunner/TestController.cpp:
3150         (WTR::TestController::resetPreferencesToConsistentValues):
3151
3152 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3153
3154         [EFL] fix eo errors
3155         https://bugs.webkit.org/show_bug.cgi?id=141909
3156
3157         Reviewed by Gyuyoung Kim.
3158
3159         Fix eo errors that occur whenever minibrowser is launched.
3160         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3161         - elm_obj_win_resize_object_add's first parameter should be elm_win
3162
3163         * MiniBrowser/efl/main.c:
3164         (window_create):
3165
3166 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3167
3168         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3169
3170         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3171         (TestWebKitAPI::TEST):
3172
3173 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3174
3175         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3176         https://bugs.webkit.org/show_bug.cgi?id=141935
3177
3178         Reviewed by Myles C. Maxfield.
3179
3180         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3181         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3182         tests for assigning from nullptr.
3183
3184 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3185
3186         WTF::WeakPtr should have a 'forget' method.
3187         https://bugs.webkit.org/show_bug.cgi?id=141923
3188
3189         Reviewed by Myles C. Maxfield.
3190
3191         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3192         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3193
3194 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3195
3196         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3197         https://bugs.webkit.org/show_bug.cgi?id=141920
3198
3199         Reviewed by Tim Horton.
3200
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3202         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3203         Do the same thing as we do for regular green bubbles.
3204
3205 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3206
3207         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3208         https://bugs.webkit.org/show_bug.cgi?id=141925
3209
3210         Reviewed by Tim Horton.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3213         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3214
3215 2015-02-23  Anders Carlsson  <andersca@apple.com>
3216
3217         Add API for fetching website data records to _WKWebsiteDataStore
3218         https://bugs.webkit.org/show_bug.cgi?id=141926
3219
3220         Reviewed by Beth Dakin.
3221
3222         * MiniBrowser/mac/MainMenu.xib:
3223         * MiniBrowser/mac/WK2BrowserWindowController.m:
3224         (-[WK2BrowserWindowController fetchWebsiteData:]):
3225         Add menu item to fetch and dump website data.
3226
3227 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3228
3229         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3230         <http://webkit.org/b/141884>
3231
3232         Reviewed by Alexey Proskuryakov.
3233
3234         * Scripts/webkitpy/port/leakdetector.py:
3235         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3236         snowleopard, lion and older leaks.  Add known leak for
3237         mavericks, but check Port.operating_system before calling
3238         Port.is_mavericks.
3239         * Scripts/webkitpy/port/mac.py:
3240         (MacPort.is_snowleopard): Delete.
3241         (MacPort.is_lion): Delete.
3242         (MacPort.is_mavericks): Add.
3243
3244 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3245
3246         build.webkit.org/dashboard should filter out commits to other branches
3247         https://bugs.webkit.org/show_bug.cgi?id=140362
3248
3249         Reviewed by Tim Horton.
3250
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3252         (BuildbotQueue):
3253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3254         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3255         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3256         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3257         (BuildbotQueueView.prototype.revisionContentForIteration):
3258         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3259         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3260         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3262         (Trac.prototype.get oldestRecordedRevisionNumber):
3263         (Trac.prototype.commitsOnBranch):
3264         (Trac.prototype._xmlTimelineURL):
3265         (Trac.prototype._convertCommitInfoElementToObject):
3266         (Trac.prototype._update):
3267         (Trac.prototype.startPeriodicUpdates):
3268         (Trac.prototype.loadMoreHistoricalData):
3269         (Trac.prototype.update): Deleted.
3270
3271 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3272
3273         Tests don't work on some bots: Failed to stop wptwk
3274         https://bugs.webkit.org/show_bug.cgi?id=141235
3275
3276         Reviewed by Ryosuke Niwa.
3277
3278         Logging of server subprocesses in launcher script.
3279         Killing of server subprocesses when stopping/before starting.
3280         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3281
3282         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3283         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3284         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3285         (WebPlatformTestServer.__init__):
3286         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3287         (WebPlatformTestServer):
3288         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3289         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3290         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3291         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3292         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3293         (TestWebPlatformTestServer):
3294         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3295
3296 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3297
3298         [WebEditingTester] Allow dropping HTML files on the app
3299         https://bugs.webkit.org/show_bug.cgi?id=141834
3300
3301         Reviewed by Simon Fraser.
3302
3303         * WebEditingTester/AppDelegate.m:
3304         (-[WebEditingAppDelegate openDocument:]):
3305         (-[WebEditingAppDelegate application:openFile:]):
3306         Implement application:openFile:, factoring file loading code out of openDocument.
3307
3308         * WebEditingTester/Info.plist:
3309         Register as an editor for HTML files.
3310
3311         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3312         Enrica is not an organization.
3313
3314 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3315
3316         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3317         https://bugs.webkit.org/show_bug.cgi?id=141833
3318
3319         Reviewed by Anders Carlsson.
3320
3321         * WebEditingTester/AppDelegate.h:
3322         * WebEditingTester/AppDelegate.m:
3323         (-[WebEditingAppDelegate newEditor:]):
3324         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3325         (-[WebEditingAppDelegate validateMenuItem:]):
3326         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3327         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3328         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3329         (-[WebEditingAppDelegate showOperations:]): Deleted.
3330         * WebEditingTester/MainMenu.xib:
3331         The WK abbreviation is unnaturally grating in menu items for some reason.
3332
3333 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3334
3335         [WebEditingTester] Add a custom protocol for loading canned content
3336         https://bugs.webkit.org/show_bug.cgi?id=141830
3337
3338         Reviewed by Enrica Casucci.
3339
3340         Add a canned:// protocol handler, which can be used to emulate behaviors
3341         in WebKit client apps (like Mail) that use custom protocol handlers,
3342         which can have important effects on editing (mostly, the URLs are only
3343         valid inside of the client application, but not when copied/dragged out).
3344
3345         For now, we only support two canned files:
3346
3347             canned://dice is a PNG of dice (stolen from LayoutTests/)
3348             canned://text is the string "canned text" served as text/html
3349
3350         In the future we could support things like very large (generated) files,
3351         progressive loading, etc. to further simulate conditions in other apps.
3352
3353         * WebEditingTester/AppDelegate.m:
3354         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3355         Register the protocol with CFNetwork, and the scheme with WebKit2.
3356
3357         * WebEditingTester/Canned Content/dice.png: Added.
3358         * WebEditingTester/CannedContent.h: Added.
3359         * WebEditingTester/CannedContent.m: Added.
3360         (-[CannedContent initWithRequest:cachedResponse:client:]):
3361         (+[CannedContent canonicalRequestForRequest:]):
3362         (+[CannedContent canInitWithRequest:]):
3363         We only want to handle canned:// URLs.
3364
3365         (-[CannedContent startLoading]):
3366         For now, immediately load the two files we know about.
3367         Otherwise, immediately fail the load.
3368
3369         (-[CannedContent stopLoading]):
3370         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3371
3372 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3373
3374         [WebEditingTester] Implement an open panel
3375         https://bugs.webkit.org/show_bug.cgi?id=141829
3376
3377         Reviewed by Simon Fraser.
3378
3379         * WebEditingTester/AppDelegate.m:
3380         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3381         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3382         (-[WebEditingAppDelegate openDocument:]):
3383         Add an open panel (with radio buttons to pick which WebKit to open with).
3384         Loads the file as an HTML string.
3385
3386 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3387
3388         [WebEditingTester] @properties, dot syntax, and remember the window position
3389         https://bugs.webkit.org/show_bug.cgi?id=141843
3390
3391         Reviewed by Tim Horton.
3392
3393         Modernize a bit with more dot syntax, use @property for the web views,
3394         and give the main window an Autosave name so it remembers the widow position.
3395
3396         * WebEditingTester/WK1WebDocumentController.m:
3397         (-[WK1WebDocumentController awakeFromNib]):
3398         (-[WK1WebDocumentController loadHTMLString:]):
3399         * WebEditingTester/WK2WebDocumentController.m:
3400         (-[WK2WebDocumentController awakeFromNib]):
3401         * WebEditingTester/WebDocument.xib:
3402
3403 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3404
3405         [WebEditingTester] Hook up key equivalents for new window action
3406         https://bugs.webkit.org/show_bug.cgi?id=141828
3407
3408         Reviewed by Enrica Casucci.
3409
3410         * WebEditingTester/AppDelegate.h:
3411         * WebEditingTester/AppDelegate.m:
3412         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3413         (-[WebEditingAppDelegate newEditor:]):
3414         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3415         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3416         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3417         (defaultConfiguration): Deleted.
3418         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3419         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3420         Remove unused application termination code.
3421         Update new-window menu item key equivalents when launching and when
3422         changing the use-WebKit2-by-default setting.
3423         Make WebDocumentController subclasses all initialized the same way,
3424         and use that to factor out alloc/init.
3425         Rename loadContent to loadHTMLString for future use.
3426
3427         * WebEditingTester/MainMenu.xib:
3428         Add default key equivalents.
3429         Cmd-N will always make the default kind of window (controlled by the pref).
3430         Cmd-Opt-N will always make the other kind.
3431         The menu items are configured as alternates so they only show up if you
3432         press alt (just like in MiniBrowser).
3433
3434         * WebEditingTester/WK1WebDocumentController.m:
3435         (-[WK1WebDocumentController loadHTMLString:]):
3436         (-[WK1WebDocumentController loadContent]): Deleted.
3437         * WebEditingTester/WK2WebDocumentController.h:
3438         * WebEditingTester/WK2WebDocumentController.m:
3439         (defaultConfiguration):
3440         (-[WK2WebDocumentController awakeFromNib]):
3441         (-[WK2WebDocumentController loadHTMLString:]):
3442         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3443         (-[WK2WebDocumentController dealloc]): Deleted.
3444         * WebEditingTester/WebDocumentController.h:
3445         * WebEditingTester/WebDocumentController.m:
3446         (-[WebDocumentController init]):
3447         (-[WebDocumentController initWithWindow:]):
3448         (+[WebDocumentController defaultEditingSource]):
3449         (-[WebDocumentController loadHTMLString:]):
3450         (-[WebDocumentController windowDidLoad]): Deleted.
3451         (-[WebDocumentController defaultEditingSource]): Deleted.
3452         (-[WebDocumentController applicationTerminating]): Deleted.
3453         (-[WebDocumentController loadContent]): Deleted.
3454
3455 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3456
3457         [WebEditingTester] ARC-ify WebEditingTester
3458         https://bugs.webkit.org/show_bug.cgi?id=141827
3459
3460         Reviewed by Sam Weinig.
3461
3462         * WebEditingTester/AppDelegate.m:
3463         (-[WebEditingAppDelegate showOperations:]):
3464         * WebEditingTester/EditingOperations.m:
3465         (editingOperations):
3466         * WebEditingTester/WK1WebDocumentController.m:
3467         (-[WK1WebDocumentController dealloc]): Deleted.
3468         * WebEditingTester/WK2WebDocumentController.m:
3469         (-[WK2WebDocumentController dealloc]): Deleted.
3470         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3471         Turn on ARC and remove a few retain/release/autorelease calls.
3472         We don't need to implement dealloc in either document controller
3473         because WebView and WKWebView's UIDelegate property does not hold a
3474         strong reference.
3475
3476 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3477
3478         [WebEditingTester] Factor out list of editing operations
3479         https://bugs.webkit.org/show_bug.cgi?id=141826
3480
3481         Reviewed by Sam Weinig.
3482
3483         * WebEditingTester/AppDelegate.m:
3484         (-[WebEditingAppDelegate showOperations:]):
3485         * WebEditingTester/EditingOperations.h: Added.
3486         * WebEditingTester/EditingOperations.m: Added.
3487         (editingOperations):
3488         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3489         Move EditingOperations array to its own file, and make it an NSArray
3490         instead of a C array. Adjust accordingly in showOperations:.
3491
3492 2015-02-20  Michael Saboff  <msaboff@apple.com>
3493
3494         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3495         https://bugs.webkit.org/show_bug.cgi?id=141676
3496
3497         Reviewed by Filip Pizlo.
3498
3499         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3500         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3501         large string expression that we want to eval.
3502
3503         * Scripts/run-jsc-stress-tests:
3504
3505 2015-02-19  Daniel Bates  <dabates@apple.com>
3506
3507         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3508         https://bugs.webkit.org/show_bug.cgi?id=141815
3509         <rdar://problem/19893933>
3510
3511         Reviewed by Simon Fraser.
3512
3513         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3514         was booted by iOS Simulator in a previous run of run-webkit-test.
3515
3516         * Scripts/webkitpy/port/ios.py:
3517         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3518         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3519         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3520
3521 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3522
3523         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3524         <http://webkit.org/b/141799>
3525
3526         Reviewed by Alex Christensen.
3527
3528         * Scripts/webkitpy/style/checkers/cpp.py:
3529         (_IncludeState.check_next_include_order): Don't emit a warning
3530         if the primary header exists and the source file name ends with
3531         "SoftLink.cpp".  Add 'filename' argument to method.
3532         (check_include_line): Pass in 'filename'.
3533
3534         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3535         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3536         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3537         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3538         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3539         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3540         - Add test filename arguments for calls to
3541           check_next_include_order().
3542         (OrderOfIncludesTest.test_primary_header): Add test for a file
3543         name ending in "SoftLink.cpp".
3544
3545 2015-02-18  Enrica Casucci  <enrica@apple.com>
3546
3547         Add new tool to test editable Webviews.
3548         https://bugs.webkit.org/show_bug.cgi?id=141772
3549
3550         Reviewed by Tim Horton.
3551
3552         Adding WebEditingTester, a Cocoa application to
3553         test WK1 and Wk2 views in editable mode.
3554
3555         * WebEditingTester: Added.
3556         * WebEditingTester/AppDelegate.h: Added.
3557         * WebEditingTester/AppDelegate.m: Added.
3558         (-[WebEditingAppDelegate init]):
3559         (defaultConfiguration):
3560         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3561         (-[WebEditingAppDelegate applicationWillTerminate:]):
3562         (-[WebEditingAppDelegate newEditor:]):
3563         (-[WebEditingAppDelegate showOperations:]):
3564         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3565         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3566         (-[WebEditingAppDelegate validateMenuItem:]):
3567         * WebEditingTester/Info.plist: Added.
3568         * WebEditingTester/MainMenu.xib: Added.
3569         * WebEditingTester/WK1WebDocumentController.h: Added.
3570         * WebEditingTester/WK1WebDocumentController.m: Added.
3571         (-[WK1WebDocumentController awakeFromNib]):
3572         (-[WK1WebDocumentController loadContent]):
3573         (-[WK1WebDocumentController dealloc]):
3574         (-[WK1WebDocumentController pasteAsMarkup:]):
3575         * WebEditingTester/WK2WebDocumentController.h: Added.
3576         * WebEditingTester/WK2WebDocumentController.m: Added.
3577         (-[WK2WebDocumentController initWithConfiguration:]):
3578         (-[WK2WebDocumentController pasteAsMarkup:]):
3579         (-[WK2WebDocumentController awakeFromNib]):
3580         (-[WK2WebDocumentController dealloc]):
3581         (-[WK2WebDocumentController loadContent]):
3582         * WebEditingTester/WebDocument.xib: Added.
3583         * WebEditingTester/WebDocumentController.h: Added.
3584         * WebEditingTester/WebDocumentController.m: Added.
3585         (-[WebDocumentController initWithWindow:]):
3586         (-[WebDocumentController windowDidLoad]):
3587         (-[WebDocumentController defaultEditingSource]):
3588         (-[WebDocumentController applicationTerminating]):
3589         (-[WebDocumentController loadContent]):
3590         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3591         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3592         * WebEditingTester/main.m: Added.
3593         (main):
3594
3595 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3596
3597         Run JSC tests on ARM EFL bots
3598         https://bugs.webkit.org/show_bug.cgi?id=141165
3599
3600         Reviewed by Alexey Proskuryakov.
3601
3602         * BuildSlaveSupport/build.webkit.org-config/config.json:
3603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3604         (RunJavaScriptCoreTests.countFailures):
3605         (RunRemoteJavaScriptCoreTests):
3606         (RunRemoteJavaScriptCoreTests.start):
3607         (BuildAndRemoteJSCTestsFactory):
3608         (BuildAndRemoteJSCTestsFactory.__init__):
3609
3610 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3611
3612         Streamline unexported function build fixes
3613         https://bugs.webkit.org/show_bug.cgi?id=141761
3614
3615         Reviewed by Alex Christensen.
3616
3617         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3618         We don't need to ignore symbols that are not exported due to the .unexp file.
3619
3620 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3621
3622         Remove more references to WebCore.exp.in
3623         https://bugs.webkit.org/show_bug.cgi?id=141747
3624
3625         Reviewed by Alexey Proskuryakov.
3626
3627         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3628         (ShouldBuildTest):
3629
3630 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3631
3632         Windows test results should not fall back to mac-mountainlion after r180176
3633         https://bugs.webkit.org/show_bug.cgi?id=141719
3634
3635         Reviewed by Brent Fulgham.
3636
3637         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3638         (_should_file_trigger_build):
3639         * Scripts/webkitpy/port/win.py:
3640         (WinPort.default_baseline_search_path):
3641         * Scripts/webkitpy/port/win_unittest.py:
3642         (WinPortTest.test_baseline_search_path):
3643
3644 2015-02-17  Daniel Bates  <dabates@apple.com>
3645
3646         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3647         https://bugs.webkit.org/show_bug.cgi?id=141718
3648
3649         Reviewed by Alex Christensen.
3650
3651         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3652
3653         * Scripts/webkitpy/port/ios.py:
3654         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3655         Log a error and return False if we are unable to boot the simulator device so that the caller can take
3656         appropriate action, say exit(3) before running any layout tests.
3657         * Scripts/webkitpy/xcode/simulator.py:
3658         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3659         with the specified UDID.
3660         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3661         with the specified UDID can successfully boot and shut down. We make at most two attempts to
3662         boot and shut down the device, erasing the device between tries so as to restore the device
3663         to a known good state.
3664
3665 2015-02-17  Daniel Bates  <dabates@apple.com>
3666
3667         run_webkit_tests.py should not know about iOS Simulator details
3668         https://bugs.webkit.org/show_bug.cgi?id=141711
3669
3670         Reviewed by Alex Christensen.
3671
3672         Run_webkit_tests.py should only parse the iOS-specific command
3673         line options --runtime and --device-type. Let the port-specific