c0e3cf1c43019f1f14b4923e538529db9d1fe11f
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-18  James Robinson  <jamesr@chromium.org>
2
3         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
4         https://bugs.webkit.org/show_bug.cgi?id=72778
5
6         Reviewed by Kenneth Russell.
7
8         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
9
10         * DumpRenderTree/chromium/EventSender.cpp:
11         (EventSender::scalePageBy):
12
13 2011-11-18  Scott Graham  <scottmg@chromium.org>
14
15         IDL changes for gamepad support
16         https://bugs.webkit.org/show_bug.cgi?id=71753
17
18         Reviewed by Adam Barth.
19
20         Runtime enable gamepad in chromium test shell.
21
22         * DumpRenderTree/chromium/TestShell.cpp:
23         (TestShell::TestShell):
24
25 2011-10-27  Darin Fisher  <darin@chromium.org>
26
27         [chromium] Improve fullscreen API
28         https://bugs.webkit.org/show_bug.cgi?id=70477
29
30         Reviewed by Adam Barth.
31
32         Implement enter/exitFullScreen.  The implementation is asynchronous,
33         via postDelayedTask, to simulate how the browser actually behaves.
34
35         * DumpRenderTree/chromium/WebViewHost.cpp:
36         (WebViewHost::enterFullScreen):
37         (WebViewHost::exitFullScreen):
38         (WebViewHost::setAddressBarURL):
39         (WebViewHost::enterFullScreenNow):
40         (WebViewHost::exitFullScreenNow):
41         * DumpRenderTree/chromium/WebViewHost.h:
42
43 2011-11-18  Adam Roben  <aroben@apple.com>
44
45         Ignore an ANGLE leak that is not WebKit's fault
46
47         * Scripts/old-run-webkit-tests:
48         (countAndPrintLeaks):
49         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
50         (LeakDetector._callstacks_to_exclude_from_leaks):
51         Added ScanFromString to the call stacks to exclude on all OS versions.
52
53 2011-11-18  Adam Roben  <aroben@apple.com>
54
55         Ignore another Lion-specific leak that is not WebKit's fault
56
57         * Scripts/old-run-webkit-tests:
58         (countAndPrintLeaks):
59         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
60         (LeakDetector._callstacks_to_exclude_from_leaks):
61         Added SecTransformExecute to the call stacks to exclude.
62
63 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
64
65         [Qt] Enable WebSocket hybi tests
66         https://bugs.webkit.org/show_bug.cgi?id=72687
67
68         Reviewed by Simon Hausmann.
69
70         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
71
72         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
73         (WebCore::WebPage::resetSettings):
74         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
75         (LayoutTestController::overridePreference):
76
77 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
78
79         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
80         https://bugs.webkit.org/show_bug.cgi?id=72707
81
82         Reviewed by Philippe Normand.
83
84         Make new-run-webkit-tests use the right path to locate the test
85         plugin used by WebKitTestRunner.
86
87         * Scripts/webkitpy/layout_tests/port/gtk.py:
88
89 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
90
91         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
92         https://bugs.webkit.org/show_bug.cgi?id=72697
93
94         Reviewed by Kenneth Rohde Christiansen.
95
96         * Tools.pro: Make WTR linux only for the moment.
97         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
98         * WebKitTestRunner/Target.pri: Ditto.
99         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
100         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
101
102 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
103
104         [Qt] Change default size of the MiniBrowser
105
106         Reviewed by Simon Hausmann.
107
108         As we lay out desktop pages using the width of 980, change our default
109         size to 980x735 so that we are not scaling down by default.
110
111         * MiniBrowser/qt/MiniBrowserApplication.h:
112         (WindowOptions::WindowOptions):
113
114 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
115
116         [EFL] Clean up the use of DATA_DIR in the buildsystem
117         https://bugs.webkit.org/show_bug.cgi?id=72681
118
119         Reviewed by Daniel Bates.
120
121         Instead of adding -DDATA_DIR in all scopes, only define it in
122         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
123         it.
124
125         We can then define DATA_DIR to the generated theme directory for
126         EWebLauncher, since it's what we want here.
127
128         * CMakeListsEfl.txt:
129
130 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
131
132         [EFL] Move platform includes last in DRT's include directories.
133         https://bugs.webkit.org/show_bug.cgi?id=72684
134
135         Reviewed by Daniel Bates.
136
137         This is the first step in fixing the build when a platform include (in
138         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
139         is included instead of WebKit's.
140
141         * DumpRenderTree/efl/CMakeLists.txt:
142
143 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
144
145         fuzzy_match doesn't recognize "Dan B" or "hyatt"
146         https://bugs.webkit.org/show_bug.cgi?id=72636
147
148         Reviewed by Eric Seidel.
149
150         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
151         and user names of email addreses such as rniwa in rniwa@webkit.org.
152
153         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
154
155         * Scripts/webkitpy/common/config/committers.py:
156         * Scripts/webkitpy/common/config/committers_unittest.py:
157
158 2011-11-17  Eric Seidel  <eric@webkit.org>
159
160         Remove support for running check-webkit-style w/o a webkit checkout
161         https://bugs.webkit.org/show_bug.cgi?id=72678
162
163         Reviewed by Adam Barth.
164
165         After talking to Dave Levin we've decided to remove this
166         code.  I know of no users of check-webkit-style w/o a webkit checkout
167         and this needlessly adds complexity.
168
169         * Scripts/webkitpy/style/main.py:
170
171 2011-11-17  Eric Seidel  <eric@webkit.org>
172
173         Remove more direct uses of os.path
174         https://bugs.webkit.org/show_bug.cgi?id=72677
175
176         Reviewed by Adam Barth.
177
178         Remove more uses of os.path, including refactoring
179         CommitterValidator to use a Host object instead of
180         manual hacks to emulate what SCM and FileSystem provide.
181
182         * Scripts/webkitpy/common/checkout/changelog.py:
183         * Scripts/webkitpy/common/config/committervalidator.py:
184         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
185         * Scripts/webkitpy/common/system/filesystem_mock.py:
186          - Turns out none of our unittests actually looked at this path.
187            now I've made it be a valid path.
188         * Scripts/webkitpy/tool/bot/feeders.py:
189         * Scripts/webkitpy/tool/commands/queues.py:
190
191 2011-11-17  Eric Seidel  <eric@webkit.org>
192
193         Teach TextFileReader about FileSystem
194         https://bugs.webkit.org/show_bug.cgi?id=72673
195
196         Reviewed by Adam Barth.
197
198         Unfortunately TextFileReader doesn't use FileSystem
199         everywhere yet, so we can't move the unittests to
200         using MockFileSystem, but we're close.
201
202         * Scripts/webkitpy/style/filereader.py:
203         * Scripts/webkitpy/style/filereader_unittest.py:
204         * Scripts/webkitpy/style/main.py:
205
206 2011-11-17  Eric Seidel  <eric@webkit.org>
207
208         Give check-webkit-style a Host
209         https://bugs.webkit.org/show_bug.cgi?id=72670
210
211         Reviewed by Adam Barth.
212
213         * Scripts/webkitpy/common/checkout/scm/detection.py:
214         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
215          - We don't run these unittests, but this one was looking for the wrong exception.
216         * Scripts/webkitpy/style/main.py:
217         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
218          - This was create a new scm object even though it already had one?
219
220 2011-11-17  Eric Seidel  <eric@webkit.org>
221
222         Move check-webkit-style change_directory code to more modern mocks
223         https://bugs.webkit.org/show_bug.cgi?id=72664
224
225         Reviewed by Adam Barth.
226
227         * Scripts/check-webkit-style:
228         * Scripts/webkitpy/style/main.py:
229         * Scripts/webkitpy/style/main_unittest.py:
230
231 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
232
233         [GTK] enable ref tests
234         https://bugs.webkit.org/show_bug.cgi?id=72601
235
236         Re-enable ref tests. Run the driver under evenly numbered display if performing
237         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
238         being run in an already used Xvfb instance if pixel tests are disabled.
239
240         Reviewed by Tony Chang.
241
242         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
243         after the process is killed
244
245 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
246
247         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
248         https://bugs.webkit.org/show_bug.cgi?id=72620
249
250         Reviewed by David Levin.
251
252         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
253         adding the suffix the cpp file. One example of false positive
254         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
255
256         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
257         basename contains the cpp's basename.
258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
259
260 2011-11-17  Eric Seidel  <eric@webkit.org>
261
262         Move check-webkit-style's guts into webkitpy/style/main.py
263         https://bugs.webkit.org/show_bug.cgi?id=72657
264
265         Reviewed by Adam Barth.
266
267         * Scripts/check-webkit-style:
268         * Scripts/webkitpy/style/main.py:
269
270 2011-11-17  Eric Seidel  <eric@webkit.org>
271
272         new-run-webkit-tests is locale dependent
273         https://bugs.webkit.org/show_bug.cgi?id=68691
274
275         Reviewed by Adam Barth.
276
277         Make NRWT use a clean environment, just like ORWT did.
278
279         * Scripts/webkitpy/layout_tests/port/base.py:
280         * Scripts/webkitpy/layout_tests/port/chromium.py:
281         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
282         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
283         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
284         * Scripts/webkitpy/layout_tests/port/efl.py:
285         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
286         * Scripts/webkitpy/layout_tests/port/mac.py:
287         * Scripts/webkitpy/layout_tests/port/qt.py:
288         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
289         * Scripts/webkitpy/layout_tests/port/webkit.py:
290         * Scripts/webkitpy/layout_tests/port/win.py:
291
292 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
293
294         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
295         https://bugs.webkit.org/show_bug.cgi?id=72615
296
297         Reviewed by James Robinson.
298
299         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
300
301 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
302
303         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
304         https://bugs.webkit.org/show_bug.cgi?id=72595
305
306         Reviewed by Noam Rosenthal.
307
308         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
309         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
310         ensure the registration of the DRTNode JS bindings.
311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
312         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
313         registration of QWebElement (now done implicitly through QWebPage ->
314         QtWebElementRunTime::initialize code path)
315
316 2011-11-17  Adam Roben  <aroben@apple.com>
317
318         Fix a crash-inducing typo I introduced in r100648
319
320         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
321         handling a crashing test
322
323         Reviewed by Adam Barth.
324
325         * Scripts/webkitpy/layout_tests/port/chromium.py:
326         (ChromiumDriver.run_test): Get the driver name from the port.
327
328         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
329         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
330         right crashed process name.
331
332 2011-11-17  Adam Roben  <aroben@apple.com>
333
334         Fix NRWT's parsing of the number of excluded leaks
335
336         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
337         leaks were excluded
338
339         Reviewed by Adam Barth.
340
341         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
342         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
343         regular expression match, not the entire matched string.
344
345         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
346         (LeakDetectorTest): Added some example output that shows how things look when leaks are
347         excluded.
348         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
349         correctly.
350
351 2011-11-17  Adam Roben  <aroben@apple.com>
352
353         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
354
355         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
356         when web process crashes, but WebProcess crash log should get saved instead
357
358         Reviewed by Eric Seidel.
359
360         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
361         (write_test_result): Simplified a little to share more code between the case where we
362         crashed when running the test and where we crashed when checking the expected rendering for
363         a reftest. Changed to pass the crashed process name down to write_crash_report.
364         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
365         along to CrashLogs.find_newest_log rather than always using the driver name.
366
367         * Scripts/webkitpy/layout_tests/port/chromium.py:
368         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
369         crashed.
370
371         * Scripts/webkitpy/layout_tests/port/test.py:
372         (TestInstance.__init__): Initialize new web_process_crash attribute.
373         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
374         test this patch adds.
375         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
376         specifies that the driver crashed or the web process crashed.
377
378         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
379         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
380         which we pretend the web process crashed rather than the driver process.
381
382         (MainTest.test_run_singly_actually_runs_tests):
383         (MainTest.test_unexpected_failures):
384         (EndToEndTest.test_end_to_end):
385         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
386
387 2011-11-17  Tony Chang  <tony@chromium.org>
388
389         [chromium] stop spamming features warning on every build
390         https://bugs.webkit.org/show_bug.cgi?id=72629
391
392         Reviewed by Ojan Vafai.
393
394         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
395         $mediaStreamSupport is on by default for chromium, make the default
396         for $blobSupport also on.
397
398         * Scripts/build-webkit:
399
400 2011-11-17  Adam Roben  <aroben@apple.com>
401
402         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
403
404         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
405         that are supposed to be ignored
406
407         Reviewed by Adam Barth.
408
409         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
410         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
411         required when passing arguments via the shell (which we aren't doing here). It is not
412         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
413
414         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
415         (LeakDetectorTest.test_leaks_args): Updated expectations.
416
417 2011-11-17  Philippe Normand  <pnormand@igalia.com>
418
419         Unreviewed, run-bindings-tests fix after r91028.
420
421         * Scripts/run-bindings-tests: Use scm.detection module.
422
423 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
424
425         Silence a warning about control reaching the end of a non-void function
426         https://bugs.webkit.org/show_bug.cgi?id=72616
427
428         Reviewed by Tony Gentilcore.
429
430         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
431         (AccessibilityUIElement::verticalScrollbar):
432
433 2011-11-17  Adam Roben  <aroben@apple.com>
434
435         Ignore some leaks in frameworks we link against on Lion
436
437         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
438         aren't WebKit's fault
439
440         Reviewed by Antti Koivisto.
441
442         * Scripts/old-run-webkit-tests:
443         (countAndPrintLeaks):
444         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
445         (LeakDetector._callstacks_to_exclude_from_leaks):
446         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
447
448         * Scripts/webkitpy/layout_tests/port/mac.py:
449         (MacPort.is_lion): Added.
450
451         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
452         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
453         methods.
454
455 2011-11-17  Philippe Normand  <pnormand@igalia.com>
456
457         [GTK] Disable ref tests
458         https://bugs.webkit.org/show_bug.cgi?id=72599
459
460         Reviewed by Xan Lopez.
461
462         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
463         tests to avoid massive flakiness.
464
465 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
466
467         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
468
469         A new extension object has been added to QQuickWebView (the same approach should be used
470         for other API classes that need experimental APIs). The QML extension mechanism is then
471         built on top of the experimental object.
472
473         https://bugs.webkit.org/show_bug.cgi?id=72522
474
475         Reviewed by Simon Hausmann.
476
477         * MiniBrowser/qt/BrowserWindow.cpp:
478         (BrowserWindow::BrowserWindow):
479         (BrowserWindow::webView):
480         * MiniBrowser/qt/BrowserWindow.h:
481         * MiniBrowser/qt/UrlLoader.cpp:
482         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
483         * qmake/mkspecs/features/default_post.prf:
484         * qmake/mkspecs/features/default_pre.prf:
485         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
486         * qmake/mkspecs/features/qtwebkit.prf:
487
488 2011-11-17  Adam Barth  <abarth@webkit.org>
489
490         Move test_results_uploader.py out of layout_package
491         https://bugs.webkit.org/show_bug.cgi?id=72590
492
493         Reviewed by Eric Seidel.
494
495         Most of the lines of code in this file are wrong, but I've restrained
496         myself and only changed a few of them to generalized this class to the
497         common package.
498
499         This is part of a series of patches to remove layout_package.
500
501         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
502         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
503         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
504
505 2011-11-17  Adam Barth  <abarth@webkit.org>
506
507         Unreviewed. Fix style nits in printing.py.
508
509         * Scripts/webkitpy/layout_tests/views/printing.py:
510
511 2011-11-17  Adam Barth  <abarth@webkit.org>
512
513         Minor style nits in run_webkit_tests.py
514         https://bugs.webkit.org/show_bug.cgi?id=72583
515
516         Reviewed by Eric Seidel.
517
518         This patch just fixes some minor style issues as I work my way back
519         into this code.
520
521         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
522
523 2011-11-17  Adam Barth  <abarth@webkit.org>
524
525         Move test_result_writer out of layout_package
526         https://bugs.webkit.org/show_bug.cgi?id=72586
527
528         Rubber-stamped by Eric Seidel.
529
530         This is part of a series of patches to remove layout_package.
531
532         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
533         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
534         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
535         * Scripts/webkitpy/tool/commands/rebaseline.py:
536
537 2011-11-17  Adam Barth  <abarth@webkit.org>
538
539         svn-apply shouldn't magically move files into Source anymore
540         https://bugs.webkit.org/show_bug.cgi?id=72579
541
542         Reviewed by Eric Seidel.
543
544         The Source directory has existed for long enough that we don't need
545         svn-apply to magically re-write old-style patches anymore.
546
547         * Scripts/VCSUtils.pm:
548         (parseGitDiffHeader):
549         (parseSvnDiffHeader):
550
551 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
552
553         Add a list of contribution areas
554         https://bugs.webkit.org/show_bug.cgi?id=72566
555
556         Reviewed by Eric Seidel.
557
558         Added ContributionAreas class.
559
560         * Scripts/webkitpy/common/config/contributionareas.py: Added.
561         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
562
563 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
564
565         Refactor ChangeLogTest.test_parse_reviewer_text
566         https://bugs.webkit.org/show_bug.cgi?id=72572
567
568         Reviewed by Eric Seidel.
569
570         Refactored the test code by introduing two helper functions.
571
572         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
573
574 2011-11-16  Eric Seidel  <eric@webkit.org>
575
576         Add SCMDetector object to make scm detection mockable
577         https://bugs.webkit.org/show_bug.cgi?id=72247
578
579         Reviewed by Adam Barth.
580
581         I think SCM detection may eventually be rolled into Checkout,
582         but this patch at least makes it possible to mock code-paths
583         which rely on scm detection.
584         In the process of replacing callers of these free-functions
585         I found that one of the functions was no longer used,
586         and that one of the callers could instead just use the SCM
587         object it already had access to through port.host.scm().
588         I also discovered that I was not calling Host._initialize_scm()
589         and thus host.scm() was always returning None!
590
591         * Scripts/check-webkit-style:
592         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
593         * Scripts/webkitpy/common/checkout/deps.py:
594         * Scripts/webkitpy/common/checkout/scm/__init__.py:
595         * Scripts/webkitpy/common/checkout/scm/detection.py:
596         * Scripts/webkitpy/common/checkout/scm/git.py:
597         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
598         * Scripts/webkitpy/common/checkout/scm/svn.py:
599         * Scripts/webkitpy/common/host.py:
600         * Scripts/webkitpy/common/host_mock.py:
601         * Scripts/webkitpy/layout_tests/controllers/manager.py:
602         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
603         * Scripts/webkitpy/layout_tests/port/base.py:
604         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
605         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
606         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
607         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
608
609 2011-11-16  Mark Rowe  <mrowe@apple.com>
610
611         Fix the build.
612
613         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
614         Apply the workaround that we use in other projects to WebKitTestRunner.
615
616         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
617         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
618         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
619
620 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
621
622         [Qt] Fix build after WTR AX support
623         https://bugs.webkit.org/show_bug.cgi?id=72560
624
625         Reviewed by Geoffrey Garen.
626
627         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
628         * WebKitTestRunner/InjectedBundle/Target.pri:
629
630 2011-11-16  Tony Chang  <tony@chromium.org>
631
632         repurpose the flexbox bot for grid layout
633         https://bugs.webkit.org/show_bug.cgi?id=72557
634
635         Reviewed by Ryosuke Niwa.
636
637         Since new flexbox is enabled everywhere, we don't need this bot
638         anymore.  However, work on grid layout has begun, so we can use this
639         bot to compile with ENABLE_CSS_GRID_LAYOUT.
640
641         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
642         the bot on the waterfall, I will change the slave config to enable
643         the compile flag and tests.
644
645 2011-11-11  Adrienne Walker  <enne@google.com>
646
647         [chromium] Expose mock scrollbars to window.internals
648         https://bugs.webkit.org/show_bug.cgi?id=72195
649
650         Reviewed by James Robinson.
651
652         Because mock scrollbars are a global setting, reset between runs.
653
654         * DumpRenderTree/chromium/WebPreferences.cpp:
655         (WebPreferences::applyTo):
656
657 2011-11-16  James Robinson  <jamesr@chromium.org>
658
659         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
660         https://bugs.webkit.org/show_bug.cgi?id=72562
661
662         Reviewed by Dirk Pranke.
663
664         * DumpRenderTree/chromium/TestShell.cpp:
665         (TestShell::runFileTest):
666
667 2011-11-16  Tony Chang  <tony@chromium.org>
668
669         [NRWT] speculative fix for multiple subprocess test on cygwin
670         https://bugs.webkit.org/show_bug.cgi?id=72518
671
672         Reviewed by Adam Barth.
673
674         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
675             tries to emulate posix fd behavior.
676         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
677
678 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
679
680         Revert r100509; change was committed twice (first time as r100491).
681         Unreviewed, build fix.
682
683         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
684
685 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
686
687         Run a dummy test in the gpu configurations if there's nothing to do.
688         https://bugs.webkit.org/show_bug.cgi?id=72498
689
690         Reviewed by James Robinson.
691
692         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
693
694 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
695
696         contributors_by_fuzzy_match is super slow
697         https://bugs.webkit.org/show_bug.cgi?id=72540
698
699         Reviewed by Eric Seidel.
700
701         Make contributors_by_name do case insensitive search using a dictionary.
702
703         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
704         because that's the most common case.
705
706         * Scripts/webkitpy/common/config/committers.py:
707         * Scripts/webkitpy/common/config/committers_unittest.py:
708
709 2011-11-16  David Levin  <levin@chromium.org>
710
711         check-webkit-style should recognize functions even if they have OVERRIDE after them.
712         https://bugs.webkit.org/show_bug.cgi?id=72515
713
714         Reviewed by Adam Barth.
715
716         * Scripts/webkitpy/style/checkers/cpp.py:
717         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
718
719 2011-11-16  Tony Chang  <tony@chromium.org>
720
721         [NRWT] refactor drivers to require pixel_tests param
722         https://bugs.webkit.org/show_bug.cgi?id=72517
723
724         Reviewed by Ojan Vafai.
725
726         No tests, just a refactoring.
727
728         * Scripts/webkitpy/layout_tests/port/chromium.py:
729         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
730         * Scripts/webkitpy/layout_tests/port/webkit.py:
731         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
732
733 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
734
735         Run a dummy test in the gpu configurations if there's nothing to do.
736         https://bugs.webkit.org/show_bug.cgi?id=72498
737
738         Reviewed by James Robinson.
739
740         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
741
742 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
743
744         WebKitTestRunner needs to support accessibility-related DRT APIs
745         https://bugs.webkit.org/show_bug.cgi?id=42131
746
747         Reviewed by Beth Dakin.
748
749         Port the AX code in DRT to WKTestRunner by using IDL.
750
751         * DumpRenderTree/AccessibilityUIElement.cpp:
752         (horizontalScrollbarCallback):
753         (verticalScrollbarCallback):
754         (AccessibilityUIElement::horizontalScrollbar):
755         (AccessibilityUIElement::verticalScrollbar):
756         (AccessibilityUIElement::getJSClass):
757         * DumpRenderTree/AccessibilityUIElement.h:
758         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
759         (AccessibilityUIElement::horizontalScrollbar):
760         (AccessibilityUIElement::verticalScrollbar):
761         * WebKitTestRunner/DerivedSources.make:
762         * WebKitTestRunner/GNUmakefile.am:
763         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
764         (WTR::AccessibilityController::create):
765         (WTR::AccessibilityController::AccessibilityController):
766         (WTR::AccessibilityController::~AccessibilityController):
767         (WTR::AccessibilityController::makeWindowObject):
768         (WTR::AccessibilityController::wrapperClass):
769         (WTR::AccessibilityController::rootElement):
770         (WTR::AccessibilityController::focusedElement):
771         (WTR::AccessibilityController::elementAtPoint):
772         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
773         (WTR::AccessibilityController::logFocusEvents):
774         (WTR::AccessibilityController::logValueChangeEvents):
775         (WTR::AccessibilityController::logScrollingStartEvents):
776         (WTR::AccessibilityController::logAccessibilityEvents):
777         (WTR::AccessibilityController::addNotificationListener):
778         (WTR::AccessibilityController::notificationReceived):
779         (WTR::AccessibilityController::resetToConsistentState):
780         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
781         (WTR::AccessibilityTextMarker::create):
782         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
783         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
784         (WTR::AccessibilityTextMarker::platformTextMarker):
785         (WTR::AccessibilityTextMarker::wrapperClass):
786         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
787         (WTR::AccessibilityTextMarker::isEqual):
788         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
789         (WTR::AccessibilityTextMarkerRange::create):
790         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
791         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
792         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
793         (WTR::AccessibilityTextMarkerRange::wrapperClass):
794         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
795         (WTR::AccessibilityTextMarkerRange::isEqual):
796         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
797         (WTR::AccessibilityUIElement::create):
798         (WTR::AccessibilityUIElement::wrapperClass):
799         (WTR::AccessibilityUIElement::isValid):
800         (WTR::AccessibilityUIElement::AccessibilityUIElement):
801         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
802         (WTR::AccessibilityUIElement::isEqual):
803         (WTR::AccessibilityUIElement::elementAtPoint):
804         (WTR::AccessibilityUIElement::childAtIndex):
805         (WTR::AccessibilityUIElement::indexOfChild):
806         (WTR::AccessibilityUIElement::childrenCount):
807         (WTR::AccessibilityUIElement::titleUIElement):
808         (WTR::AccessibilityUIElement::parentElement):
809         (WTR::AccessibilityUIElement::takeFocus):
810         (WTR::AccessibilityUIElement::takeSelection):
811         (WTR::AccessibilityUIElement::addSelection):
812         (WTR::AccessibilityUIElement::removeSelection):
813         (WTR::AccessibilityUIElement::allAttributes):
814         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
815         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
816         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
817         (WTR::AccessibilityUIElement::attributesOfChildren):
818         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
819         (WTR::AccessibilityUIElement::increment):
820         (WTR::AccessibilityUIElement::decrement):
821         (WTR::AccessibilityUIElement::showMenu):
822         (WTR::AccessibilityUIElement::press):
823         (WTR::AccessibilityUIElement::stringAttributeValue):
824         (WTR::AccessibilityUIElement::uiElementAttributeValue):
825         (WTR::AccessibilityUIElement::numberAttributeValue):
826         (WTR::AccessibilityUIElement::boolAttributeValue):
827         (WTR::AccessibilityUIElement::isAttributeSupported):
828         (WTR::AccessibilityUIElement::isAttributeSettable):
829         (WTR::AccessibilityUIElement::isActionSupported):
830         (WTR::AccessibilityUIElement::role):
831         (WTR::AccessibilityUIElement::subrole):
832         (WTR::AccessibilityUIElement::roleDescription):
833         (WTR::AccessibilityUIElement::title):
834         (WTR::AccessibilityUIElement::description):
835         (WTR::AccessibilityUIElement::language):
836         (WTR::AccessibilityUIElement::stringValue):
837         (WTR::AccessibilityUIElement::accessibilityValue):
838         (WTR::AccessibilityUIElement::helpText):
839         (WTR::AccessibilityUIElement::orientation):
840         (WTR::AccessibilityUIElement::x):
841         (WTR::AccessibilityUIElement::y):
842         (WTR::AccessibilityUIElement::width):
843         (WTR::AccessibilityUIElement::height):
844         (WTR::AccessibilityUIElement::intValue):
845         (WTR::AccessibilityUIElement::minValue):
846         (WTR::AccessibilityUIElement::maxValue):
847         (WTR::AccessibilityUIElement::valueDescription):
848         (WTR::AccessibilityUIElement::insertionPointLineNumber):
849         (WTR::AccessibilityUIElement::selectedTextRange):
850         (WTR::AccessibilityUIElement::isEnabled):
851         (WTR::AccessibilityUIElement::isRequired):
852         (WTR::AccessibilityUIElement::isFocused):
853         (WTR::AccessibilityUIElement::isFocusable):
854         (WTR::AccessibilityUIElement::isSelected):
855         (WTR::AccessibilityUIElement::isSelectable):
856         (WTR::AccessibilityUIElement::isMultiSelectable):
857         (WTR::AccessibilityUIElement::setSelectedChild):
858         (WTR::AccessibilityUIElement::selectedChildrenCount):
859         (WTR::AccessibilityUIElement::selectedChildAtIndex):
860         (WTR::AccessibilityUIElement::isExpanded):
861         (WTR::AccessibilityUIElement::isChecked):
862         (WTR::AccessibilityUIElement::isVisible):
863         (WTR::AccessibilityUIElement::isOffScreen):
864         (WTR::AccessibilityUIElement::isCollapsed):
865         (WTR::AccessibilityUIElement::isIgnored):
866         (WTR::AccessibilityUIElement::hasPopup):
867         (WTR::AccessibilityUIElement::hierarchicalLevel):
868         (WTR::AccessibilityUIElement::clickPointX):
869         (WTR::AccessibilityUIElement::clickPointY):
870         (WTR::AccessibilityUIElement::documentEncoding):
871         (WTR::AccessibilityUIElement::documentURI):
872         (WTR::AccessibilityUIElement::url):
873         (WTR::AccessibilityUIElement::speak):
874         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
875         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
876         (WTR::AccessibilityUIElement::attributesOfColumns):
877         (WTR::AccessibilityUIElement::attributesOfRows):
878         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
879         (WTR::AccessibilityUIElement::attributesOfHeader):
880         (WTR::AccessibilityUIElement::indexInTable):
881         (WTR::AccessibilityUIElement::rowIndexRange):
882         (WTR::AccessibilityUIElement::columnIndexRange):
883         (WTR::AccessibilityUIElement::rowCount):
884         (WTR::AccessibilityUIElement::columnCount):
885         (WTR::AccessibilityUIElement::selectedRowAtIndex):
886         (WTR::AccessibilityUIElement::disclosedByRow):
887         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
888         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
889         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
890         (WTR::AccessibilityUIElement::ariaIsGrabbed):
891         (WTR::AccessibilityUIElement::ariaDropEffects):
892         (WTR::AccessibilityUIElement::lineForIndex):
893         (WTR::AccessibilityUIElement::rangeForLine):
894         (WTR::AccessibilityUIElement::boundsForRange):
895         (WTR::AccessibilityUIElement::setSelectedTextRange):
896         (WTR::AccessibilityUIElement::stringForRange):
897         (WTR::AccessibilityUIElement::attributedStringForRange):
898         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
899         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
900         (WTR::AccessibilityUIElement::cellForColumnAndRow):
901         (WTR::AccessibilityUIElement::horizontalScrollbar):
902         (WTR::AccessibilityUIElement::verticalScrollbar):
903         (WTR::AccessibilityUIElement::addNotificationListener):
904         (WTR::AccessibilityUIElement::removeNotificationListener):
905         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
906         (WTR::AccessibilityUIElement::textMarkerRangeLength):
907         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
908         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
909         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
910         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
911         (WTR::AccessibilityUIElement::textMarkerForPoint):
912         (WTR::AccessibilityUIElement::previousTextMarker):
913         (WTR::AccessibilityUIElement::nextTextMarker):
914         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
915         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
916         (WTR::AccessibilityUIElement::platformUIElement):
917         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
918         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
919         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
920         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
921         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
922         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
923         (WTR::InjectedBundle::beginTesting):
924         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
925         (WTR::InjectedBundle::accessibilityController):
926         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
927         (WTR::InjectedBundlePage::didClearWindowForFrame):
928         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
929         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
930         (WTR::LayoutTestController::platformName):
931         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
932         (WTR::AccessibilityTextMarker::isEqual):
933         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
934         (WTR::AccessibilityTextMarkerRange::isEqual):
935         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
936         (+[NSString stringWithJSStringRef:]):
937         (-[NSString createJSStringRef]):
938         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
939         (-[AccessibilityNotificationHandler dealloc]):
940         (-[AccessibilityNotificationHandler _notificationReceived:]):
941         (-[AccessibilityNotificationHandler setCallback:]):
942         (WTR::AccessibilityUIElement::AccessibilityUIElement):
943         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
944         (WTR::AccessibilityUIElement::isEqual):
945         (WTR::descriptionOfValue):
946         (WTR::attributesOfElement):
947         (WTR::concatenateAttributeAndValue):
948         (WTR::convertNSArrayToVector):
949         (WTR::descriptionOfElements):
950         (WTR::AccessibilityUIElement::getLinkedUIElements):
951         (WTR::AccessibilityUIElement::getDocumentLinks):
952         (WTR::AccessibilityUIElement::getChildren):
953         (WTR::AccessibilityUIElement::getChildrenWithRange):
954         (WTR::AccessibilityUIElement::childrenCount):
955         (WTR::AccessibilityUIElement::elementAtPoint):
956         (WTR::AccessibilityUIElement::indexOfChild):
957         (WTR::AccessibilityUIElement::childAtIndex):
958         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
959         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
960         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
961         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
962         (WTR::AccessibilityUIElement::selectedChildAtIndex):
963         (WTR::AccessibilityUIElement::selectedChildrenCount):
964         (WTR::AccessibilityUIElement::selectedRowAtIndex):
965         (WTR::AccessibilityUIElement::titleUIElement):
966         (WTR::AccessibilityUIElement::parentElement):
967         (WTR::AccessibilityUIElement::disclosedByRow):
968         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
969         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
970         (WTR::AccessibilityUIElement::attributesOfChildren):
971         (WTR::AccessibilityUIElement::allAttributes):
972         (WTR::AccessibilityUIElement::stringAttributeValue):
973         (WTR::AccessibilityUIElement::numberAttributeValue):
974         (WTR::AccessibilityUIElement::uiElementAttributeValue):
975         (WTR::AccessibilityUIElement::boolAttributeValue):
976         (WTR::AccessibilityUIElement::isAttributeSettable):
977         (WTR::AccessibilityUIElement::isAttributeSupported):
978         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
979         (WTR::AccessibilityUIElement::role):
980         (WTR::AccessibilityUIElement::subrole):
981         (WTR::AccessibilityUIElement::roleDescription):
982         (WTR::AccessibilityUIElement::title):
983         (WTR::AccessibilityUIElement::description):
984         (WTR::AccessibilityUIElement::orientation):
985         (WTR::AccessibilityUIElement::stringValue):
986         (WTR::AccessibilityUIElement::language):
987         (WTR::AccessibilityUIElement::helpText):
988         (WTR::AccessibilityUIElement::x):
989         (WTR::AccessibilityUIElement::y):
990         (WTR::AccessibilityUIElement::width):
991         (WTR::AccessibilityUIElement::height):
992         (WTR::AccessibilityUIElement::clickPointX):
993         (WTR::AccessibilityUIElement::clickPointY):
994         (WTR::AccessibilityUIElement::intValue):
995         (WTR::AccessibilityUIElement::minValue):
996         (WTR::AccessibilityUIElement::maxValue):
997         (WTR::AccessibilityUIElement::valueDescription):
998         (WTR::AccessibilityUIElement::insertionPointLineNumber):
999         (WTR::AccessibilityUIElement::isActionSupported):
1000         (WTR::AccessibilityUIElement::isEnabled):
1001         (WTR::AccessibilityUIElement::isRequired):
1002         (WTR::AccessibilityUIElement::isFocused):
1003         (WTR::AccessibilityUIElement::isSelected):
1004         (WTR::AccessibilityUIElement::isExpanded):
1005         (WTR::AccessibilityUIElement::isChecked):
1006         (WTR::AccessibilityUIElement::hierarchicalLevel):
1007         (WTR::AccessibilityUIElement::speak):
1008         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1009         (WTR::AccessibilityUIElement::ariaDropEffects):
1010         (WTR::AccessibilityUIElement::lineForIndex):
1011         (WTR::AccessibilityUIElement::rangeForLine):
1012         (WTR::AccessibilityUIElement::boundsForRange):
1013         (WTR::AccessibilityUIElement::stringForRange):
1014         (WTR::AccessibilityUIElement::attributedStringForRange):
1015         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1016         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1017         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1018         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1019         (WTR::AccessibilityUIElement::attributesOfColumns):
1020         (WTR::AccessibilityUIElement::attributesOfRows):
1021         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1022         (WTR::AccessibilityUIElement::attributesOfHeader):
1023         (WTR::AccessibilityUIElement::rowCount):
1024         (WTR::AccessibilityUIElement::columnCount):
1025         (WTR::AccessibilityUIElement::indexInTable):
1026         (WTR::AccessibilityUIElement::rowIndexRange):
1027         (WTR::AccessibilityUIElement::columnIndexRange):
1028         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1029         (WTR::AccessibilityUIElement::horizontalScrollbar):
1030         (WTR::AccessibilityUIElement::verticalScrollbar):
1031         (WTR::AccessibilityUIElement::selectedTextRange):
1032         (WTR::AccessibilityUIElement::setSelectedTextRange):
1033         (WTR::AccessibilityUIElement::increment):
1034         (WTR::AccessibilityUIElement::decrement):
1035         (WTR::AccessibilityUIElement::showMenu):
1036         (WTR::AccessibilityUIElement::press):
1037         (WTR::AccessibilityUIElement::setSelectedChild):
1038         (WTR::AccessibilityUIElement::accessibilityValue):
1039         (WTR::AccessibilityUIElement::documentEncoding):
1040         (WTR::AccessibilityUIElement::documentURI):
1041         (WTR::AccessibilityUIElement::url):
1042         (WTR::AccessibilityUIElement::addNotificationListener):
1043         (WTR::AccessibilityUIElement::removeNotificationListener):
1044         (WTR::AccessibilityUIElement::isFocusable):
1045         (WTR::AccessibilityUIElement::isSelectable):
1046         (WTR::AccessibilityUIElement::isMultiSelectable):
1047         (WTR::AccessibilityUIElement::isVisible):
1048         (WTR::AccessibilityUIElement::isOffScreen):
1049         (WTR::AccessibilityUIElement::isCollapsed):
1050         (WTR::AccessibilityUIElement::isIgnored):
1051         (WTR::AccessibilityUIElement::hasPopup):
1052         (WTR::AccessibilityUIElement::takeFocus):
1053         (WTR::AccessibilityUIElement::takeSelection):
1054         (WTR::AccessibilityUIElement::addSelection):
1055         (WTR::AccessibilityUIElement::removeSelection):
1056         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1057         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1058         (WTR::AccessibilityUIElement::previousTextMarker):
1059         (WTR::AccessibilityUIElement::nextTextMarker):
1060         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1061         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1062         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1063         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1064         (WTR::AccessibilityUIElement::textMarkerForPoint):
1065         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1066         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1067         (WTR::LayoutTestController::platformName):
1068         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1069         (WTR::LayoutTestController::platformName):
1070         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1071         (WTR::LayoutTestController::platformName):
1072         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1073         * WebKitTestRunner/win/InjectedBundle.vcproj:
1074
1075 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1076
1077         [Qt] Fix use of config.tests
1078
1079         We were checking @buildArgs to determine if the optional argument was
1080         passed or not, but this is not the right way to do that in Perl. The
1081         right way is to not use a prototype for the function, and to pass
1082         the list as a reference (to avoid list expansion). That way we can
1083         check the number of arguments, and choose the right code path based
1084         on that.
1085
1086         We were also missing a default-value of 0 for any feature that's not
1087         set in features.prf.
1088
1089         Reviewed by Kenneth Rohde Christiansen.
1090
1091         * Scripts/build-webkit:
1092         * Scripts/webkitdirs.pm:
1093         (qtFeatureDefaults):
1094         (buildQMakeProject):
1095
1096 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1097
1098         [Qt] Prospective fix for broken plugin tests
1099
1100         Don't hide symbols for the NPAPI test plugin
1101
1102         Rubber-stamped by Andreas Kling.
1103
1104         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1105
1106 2011-11-16  Adam Roben  <aroben@apple.com>
1107
1108         Move filenames/line numbers off to the right edge in Leaks Viewer
1109
1110         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1111         because filenames/line numbers are right next to function names
1112
1113         Reviewed by Andreas Kling.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1116         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1117         function name. Use the filename as the profile node's URL (we don't have enough info to
1118         compute a real URL currently) and the line number as the profile node's line number so the
1119         Inspector code will put them on the right side of the callstack graph.
1120
1121         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1122         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1123         passed here, just filenames.
1124
1125         (WebInspector.linkifyURLAsNode):
1126         (WebInspector.linkifyResourceAsNode):
1127         Copied and slightly modified from inspector.js.
1128
1129 2011-11-16  Adam Roben  <aroben@apple.com>
1130
1131         Make Leaks Viewer load builds from the new Lion Leaks bot
1132
1133         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1134
1135         Reviewed by Andreas Kling.
1136
1137         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1138         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1139         SnowLeopard one.
1140
1141 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1142
1143         [EFL] Clean up the offline apps-related functions in ewk_settings.
1144         https://bugs.webkit.org/show_bug.cgi?id=72132
1145
1146         Reviewed by Kenneth Rohde Christiansen.
1147
1148         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1149         prefixes for code that is related only to the HTML5 app cache
1150         features.
1151
1152         Use `ewk_settings_application_cache' and
1153         `ewk_view_setting_application_cache' instead.
1154
1155         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1156         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1157
1158 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1159
1160         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1161
1162         Reviewed by Tor Arne Vestbø.
1163
1164         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1165         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1166         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1167         removes the .so.0.0.0 and just produces .so.
1168
1169 2011-11-16  Peter Beverloo  <peter@chromium.org>
1170
1171         Explicitly include unistd.h in TestNetscapePlugIn
1172         https://bugs.webkit.org/show_bug.cgi?id=72385
1173
1174         This is needed for the sleep() call in the indicateTestFailure method,
1175         which seems to be implicitly available for other platforms. This is not
1176         the case on Android.
1177
1178         Reviewed by Steve Block.
1179
1180         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1181
1182 2011-11-16  Peter Beverloo  <peter@chromium.org>
1183
1184         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1185         https://bugs.webkit.org/show_bug.cgi?id=72384
1186
1187         Update to Android NDK r7, which was released last Friday. This adds
1188         support for RTTI and the -mimplicit-it gcc flag, which are required to
1189         respectively build ICU and Skia.
1190
1191         Reviewed by Steve Block.
1192
1193         * Scripts/update-webkit-chromium:
1194         * Scripts/webkitdirs.pm:
1195         (buildChromiumMakefile):
1196
1197 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1198
1199         Unreviewed, rolling out r100266.
1200         http://trac.webkit.org/changeset/100266
1201
1202         Broke WTR.
1203
1204         * qmake/mkspecs/features/default_post.prf:
1205
1206 2011-11-16  Eric Seidel  <eric@webkit.org>
1207
1208         check-webkit-style broken by r99773: "Could not determine the port"
1209         https://bugs.webkit.org/show_bug.cgi?id=72275
1210
1211         Reviewed by Adam Barth.
1212
1213         I will continue engaging hacks, until windows improves.
1214
1215         * Scripts/webkitpy/common/host.py:
1216          - Host uses self.executive instead of self._executive like Port does.
1217          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1218
1219 2011-11-16  Eric Seidel  <eric@webkit.org>
1220
1221         check-webkit-style broken by r99773: "Could not determine the port"
1222         https://bugs.webkit.org/show_bug.cgi?id=72275
1223
1224         Reviewed by Adam Barth.
1225
1226         Engage windows hacks harder.
1227
1228         This is a speculative fix for ChromiumWin.  We're now
1229         creating an SCM object much earlier, so we need to
1230         engage our "awesome" windows hacks earlier.
1231
1232         * Scripts/webkitpy/common/host.py:
1233         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1234
1235 2011-11-15  Darin Adler  <darin@apple.com>
1236
1237         DRT's uiElementAttributeValueCallback function is leaky
1238         https://bugs.webkit.org/show_bug.cgi?id=72453
1239
1240         Reviewed by Dan Bernstein.
1241
1242         * DumpRenderTree/AccessibilityUIElement.cpp:
1243         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1244
1245 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1246
1247         Implement edit-distance based reviewer recognition algorithm
1248         https://bugs.webkit.org/show_bug.cgi?id=72351
1249
1250         Reviewed by Eric Seidel.
1251
1252         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1253         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1254         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1255         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1256
1257         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1258         the edit distance is implemented in edit_distance.py.
1259
1260         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1261         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1262
1263         * Scripts/webkitpy/common/checkout/changelog.py:
1264         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1265         * Scripts/webkitpy/common/config/committers.py:
1266         * Scripts/webkitpy/common/config/committers_unittest.py:
1267         * Scripts/webkitpy/common/editdistance.py: Added.
1268         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1269         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1270         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1271
1272 2011-11-15  Tony Chang  <tony@chromium.org>
1273
1274         Skip a failing webkitpy test on cygwin.
1275
1276         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1277
1278 2011-11-15  Sam Weinig  <sam@webkit.org>
1279
1280         TestWebKitAPI should not put its resources in the root products directory
1281         https://bugs.webkit.org/show_bug.cgi?id=72446
1282
1283         Reviewed by Anders Carlsson.
1284
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1287         directory.
1288
1289         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1290         (TEST_F):
1291         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1292         (TestWebKitAPI::TEST):
1293         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1294         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1295         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1296         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1297         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1298         (TestWebKitAPI::Util::createURLForResource):
1299         Update calls to retrieve files from the bundle to look in the newly
1300         created subdirectory.
1301
1302 2011-11-15  Tony Chang  <tony@chromium.org>
1303
1304         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1305
1306         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1307
1308 2011-11-15  Tony Chang  <tony@chromium.org>
1309
1310         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1311         earlier.
1312
1313         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1314         * Scripts/webkitpy/layout_tests/port/webkit.py:
1315
1316 2011-11-15  James Robinson  <jamesr@chromium.org>
1317
1318         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1319         https://bugs.webkit.org/show_bug.cgi?id=72444
1320
1321         Reviewed by Adam Barth.
1322
1323         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1324
1325 2011-11-15  Tony Chang  <tony@chromium.org>
1326
1327         Unreviewed, better fix for ref tests failures on SL Intel bot.
1328         Revert the previous change and return None if pixel results from
1329         either the test page or the expected page is missing.
1330
1331         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1332         * Scripts/webkitpy/layout_tests/port/webkit.py:
1333
1334 2011-11-15  James Robinson  <jamesr@chromium.org>
1335
1336         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1337         https://bugs.webkit.org/show_bug.cgi?id=72402
1338
1339         Reviewed by Dirk Pranke.
1340
1341         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1342         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1343         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1344         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1345         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1346         compositing enabled.
1347
1348         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1349         patch should not impact any tests.
1350
1351         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1352         (main):
1353         * DumpRenderTree/chromium/TestShell.cpp:
1354         (TestShell::TestShell):
1355         (TestShell::resetWebSettings):
1356         * DumpRenderTree/chromium/TestShell.h:
1357         (TestShell::setAcceleratedCompositingForVideoEnabled):
1358         * DumpRenderTree/chromium/WebPreferences.cpp:
1359         (WebPreferences::reset):
1360         (WebPreferences::applyTo):
1361         * DumpRenderTree/chromium/WebPreferences.h:
1362         * Scripts/webkitpy/layout_tests/port/chromium.py:
1363         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1364         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1365
1366 2011-11-15  Tony Chang  <tony@chromium.org>
1367
1368         Unreviewed, try to fix ref tests failures on SL Intel bot.
1369         It looks like ImageDiff isn't returning an image diff.
1370
1371         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1372
1373 2011-11-15  Tony Chang  <tony@chromium.org>
1374
1375         Unreviewed fix of ref-tests on GTK+.
1376         If a driver is never started, _xvfb_process is never set.
1377
1378         * Scripts/webkitpy/layout_tests/port/gtk.py:
1379
1380 2011-11-14  Tony Chang  <tony@chromium.org>
1381
1382         [NRWT] Reftests should run even when pixel tests are disabled.
1383         https://bugs.webkit.org/show_bug.cgi?id=60605
1384
1385         Reviewed by Dirk Pranke.
1386
1387         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1388             Also add an assert to make sure we get image hashes back when running ref tests.
1389         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1390         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1391         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1392         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1393             of starting a pixel driver if needed.  It handles the logic of sending the test
1394             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1395         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1396         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1397         * Scripts/webkitpy/layout_tests/port/webkit.py:
1398         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1399         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1400
1401 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1402
1403         Don't use File::Slurp for run-leaks unit tests
1404         <http://webkit.org/b/72356>
1405
1406         Reviewed by Daniel Bates.
1407
1408         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1409         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1410         Extracted common package logic into RunLeaks.pm.  Fixed call to
1411         RunLeaks::parseLeaksOutput().
1412         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1413         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1414
1415 2011-11-15  Peter Kasting  <pkasting@google.com>
1416
1417         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1418         https://bugs.webkit.org/show_bug.cgi?id=72349
1419
1420         Reviewed by Adam Roben.
1421
1422         * Scripts/VCSUtils.pm:
1423         (isSVNDirectory):
1424
1425 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1426
1427         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1428
1429         Reviewed by Tor Arne Vestbø.
1430
1431         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1432         magic here where we handle all TEMPLATE = lib .pro files.
1433
1434 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1435
1436         [Qt] Unreviewed prospective --minimal build fix.
1437
1438         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1439         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1440
1441 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1442
1443         [Qt] Unreviewed --minimal build fix.
1444
1445         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1446         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1447         to make moc's preprocessor abort.
1448
1449 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1450
1451         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1452         https://bugs.webkit.org/show_bug.cgi?id=72156
1453
1454         Reviewed by Daniel Bates.
1455
1456         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1457         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1458
1459         * Scripts/build-webkit:
1460         * Scripts/webkitdirs.pm:
1461         (generateBuildSystemFromCMakeProject):
1462
1463 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1464
1465         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1466         https://bugs.webkit.org/show_bug.cgi?id=72340
1467
1468         Reviewed by Eric Seidel.
1469
1470         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1471         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1472
1473         * Scripts/webkitpy/common/checkout/changelog.py:
1474         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1475
1476 2011-11-14  Eric Seidel  <eric@webkit.org>
1477
1478         check-webkit-style broken by r99773: "Could not determine the port"
1479         https://bugs.webkit.org/show_bug.cgi?id=72275
1480
1481         Reviewed by Adam Barth.
1482
1483         The TestExpectationsChecker was using a generic try/except block
1484         which caught all exceptions, so we didn't notice that failing
1485         to pass a Host to PortFactory was causing an exception in port instantiation.
1486         I've factored out the "lookup the port" logic into a separate function
1487         which I've now unittested.  This should fix the bug and prevent
1488         others like it from occuring the the future.
1489
1490         * Scripts/webkitpy/style/checkers/test_expectations.py:
1491         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1492
1493 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1494
1495         Add --css-grid-layout to build-webkit and the build systems
1496         https://bugs.webkit.org/show_bug.cgi?id=72320
1497
1498         Reviewed by Ojan Vafai.
1499
1500         * Scripts/build-webkit:
1501         Added the option.
1502
1503 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1504
1505         Unreviewed, rolling out r100192.
1506         http://trac.webkit.org/changeset/100192
1507         https://bugs.webkit.org/show_bug.cgi?id=72328
1508
1509         Caused infinite tests to fail (Requested by abarth on
1510         #webkit).
1511
1512         * Scripts/webkitpy/layout_tests/port/base.py:
1513         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1514
1515 2011-11-14  Tony Chang  <tony@chromium.org>
1516
1517         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1518         https://bugs.webkit.org/show_bug.cgi?id=72196
1519
1520         Reviewed by Ojan Vafai.
1521
1522         * Scripts/build-webkit:
1523
1524 2011-11-14  John Yani  <vanuan@gmail.com>
1525
1526         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1527         Override LOCALE to en_US.
1528
1529         Reviewed by Eric Seidel.
1530
1531         * Scripts/webkitpy/layout_tests/port/base.py:
1532
1533 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1534
1535         [Chromium] build-webkit silently drops the features flags
1536         https://bugs.webkit.org/show_bug.cgi?id=72293
1537
1538         Reviewed by Tony Chang.
1539
1540         Chromium still ignores @features but now we give a warning!
1541
1542         * Scripts/build-webkit: Check if one of the features is different
1543         from the default and print a warning in this case.
1544
1545 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1546
1547         run-leaks does not work on Lion?
1548         <http://webkit.org/b/71059>
1549         <rdar://problem/10428527>
1550
1551         Reviewed by Adam Roben.
1552
1553         The output of leaks(1) changed again in Lion to move the
1554         "leaks Report Version: 2.0" line from the first line of the
1555         output to just above the "Process " lines that run-leaks is
1556         interested in parsing.  This required using a more generic
1557         algorithm to find the start of the "Process " lines.
1558
1559         * Scripts/run-leaks:
1560         (parseLeaksOutput): Make the code to skip headers more generic.
1561         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1562         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1563         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1564
1565 2011-11-14  Lei Zhang  <thestig@chromium.org>
1566
1567         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1568         https://bugs.webkit.org/show_bug.cgi?id=72088
1569
1570         Reviewed by Tony Chang.
1571
1572         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1573
1574 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1575
1576         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1577         https://bugs.webkit.org/show_bug.cgi?id=72147
1578
1579         Reviewed by Adam Barth.
1580
1581         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1582
1583 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1584
1585         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1586
1587         Reviewed by Simon Hausmann.
1588
1589         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1590
1591 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1592
1593         [Qt] Disable plugins on X11 for WK2
1594
1595         Reviewed by Kenneth Rohde Christiansen.
1596
1597         Currently plugins are in-process and they crash in the likely case of
1598         a plugin installation that uses Qt 4, which beautifully clashes with the
1599         Qt 5 based QtWebProcess.
1600
1601         * qmake/mkspecs/features/features.prf:
1602
1603 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1604
1605         [Qt] Add support for config tests for Qt 5
1606
1607         This allows us to build and run configure-tests at build
1608         time to determine if a given platform feature is available.
1609
1610         Reviewed by Simon Hausmann.
1611
1612         * Scripts/build-webkit:
1613         * Scripts/webkitdirs.pm:
1614         (qtFeatureDefaults):
1615         * qmake/configure.pro: Added.
1616         * qmake/mkspecs/features/features.prf:
1617         * qmake/sync.profile: Added.
1618
1619 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1620
1621         [Qt] Remove the QStyle dependency in Qt's mobile theme
1622         https://bugs.webkit.org/show_bug.cgi?id=67773
1623
1624         This refactoring splits up RenderThemeQt with two
1625         subclasses, a QStyle-backed one, and a Mobile version
1626         that uses the old mobile theme for now.
1627
1628         QStyle availability is detected at compile time, and
1629         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1630         environment variable.
1631
1632         Reviewed by Simon Hausmann.
1633
1634         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1635         (WTR::activateFonts):
1636         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1637         based on availability of QtWidgets.
1638         * qmake/mkspecs/features/webcore.prf: cleanup.
1639
1640 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1641
1642         Unreviewed, rolling out r100116.
1643         http://trac.webkit.org/changeset/100116
1644
1645         r100104 was rolled out, so no longer needed
1646
1647         * Scripts/run-bindings-tests:
1648
1649 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1650
1651         Unreviewed, rolling out r100104.
1652         http://trac.webkit.org/changeset/100104
1653         https://bugs.webkit.org/show_bug.cgi?id=72247
1654
1655         broke windows builds
1656
1657         * Scripts/check-webkit-style:
1658         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1659         * Scripts/webkitpy/common/checkout/deps.py:
1660         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1661         * Scripts/webkitpy/common/checkout/scm/detection.py:
1662         * Scripts/webkitpy/common/checkout/scm/git.py:
1663         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1664         * Scripts/webkitpy/common/checkout/scm/svn.py:
1665         * Scripts/webkitpy/common/host.py:
1666         * Scripts/webkitpy/common/host_mock.py:
1667         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1668         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1669         * Scripts/webkitpy/layout_tests/port/base.py:
1670         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1671         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1672         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1673         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1674
1675 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1676
1677         Unreviewed, build fix after r100104. run-binding-tests broke.
1678
1679         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1680
1681 2011-11-13  Eric Seidel  <eric@webkit.org>
1682
1683         Add SCMDetector object to make scm detection mockable
1684         https://bugs.webkit.org/show_bug.cgi?id=72247
1685
1686         Reviewed by Adam Barth.
1687
1688         I think SCM detection may eventually be rolled into Checkout,
1689         but this patch at least makes it possible to mock code-paths
1690         which rely on scm detection.
1691         In the process of replacing callers of these free-functions
1692         I found that one of the functions was no longer used,
1693         and that one of the callers could instead just use the SCM
1694         object it already had access to through port.host.scm().
1695         I also discovered that I was not calling Host._initialize_scm()
1696         and thus host.scm() was always returning None!
1697
1698         * Scripts/check-webkit-style:
1699         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1700         * Scripts/webkitpy/common/checkout/deps.py:
1701         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1702         * Scripts/webkitpy/common/checkout/scm/detection.py:
1703         * Scripts/webkitpy/common/checkout/scm/git.py:
1704         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1705         * Scripts/webkitpy/common/checkout/scm/svn.py:
1706         * Scripts/webkitpy/common/host.py:
1707         * Scripts/webkitpy/common/host_mock.py:
1708         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1709         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1710         * Scripts/webkitpy/layout_tests/port/base.py:
1711         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1712         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1713         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1714         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1715
1716 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1717
1718         command line control of webcore log channels in chromium DumpRenderTree
1719         https://bugs.webkit.org/show_bug.cgi?id=72126
1720         
1721         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1722         what chromium takes.
1723
1724         Reviewed by Kent Tamura.
1725
1726         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1727         (main):
1728
1729 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1730
1731         [Qt] Fix minor config typo in the build tool documentation
1732         https://bugs.webkit.org/show_bug.cgi?id=72194
1733
1734         Reviewed by Andreas Kling.
1735
1736         * qmake/README:
1737
1738 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1739
1740         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1741         https://bugs.webkit.org/show_bug.cgi?id=49257
1742
1743         Adds the remaining missing layout test functionality for printing.
1744
1745         Reviewed by Darin Fisher.
1746
1747         * DumpRenderTree/chromium/LayoutTestController.cpp:
1748         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1749         (parsePageNumber): Method to parse JS arguments for a page number
1750         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1751         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1752         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1753         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1754         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1755
1756 2011-11-11  Darin Adler  <darin@apple.com>
1757
1758         Remove all releaseRef implementations except for RetainPtr
1759         https://bugs.webkit.org/show_bug.cgi?id=71423
1760
1761         Reviewed by Julien Chaffraix.
1762
1763         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1764         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1765
1766 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1767
1768         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1769         https://bugs.webkit.org/show_bug.cgi?id=72090
1770
1771         Reviewed by Eric Seidel.
1772
1773         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1774         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1775
1776         yay! r100002.
1777
1778         * Scripts/webkitpy/common/checkout/changelog.py:
1779         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1780
1781 2011-11-11  Tony Chang  <tony@chromium.org>
1782
1783         Remove --force from gclient sync.  The bots seem to have made it past
1784         the update step.
1785
1786         * Scripts/update-webkit:
1787
1788 2011-11-11  Tony Chang  <tony@chromium.org>
1789
1790         Add --force to gclient sync. Once the cq bots cycle, we can remove
1791         this since it slows down the normal sync.
1792
1793         * Scripts/update-webkit:
1794
1795 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1796
1797         When --force is used, also use --reset
1798         https://bugs.webkit.org/show_bug.cgi?id=72129
1799
1800         Reviewed by Dimitri Glazkov.
1801
1802         * Scripts/update-webkit-chromium:
1803
1804 2011-11-11  Tony Chang  <tony@chromium.org>
1805
1806         allow two chromium drivers to run at the same time in NRWT
1807         https://bugs.webkit.org/show_bug.cgi?id=72067
1808
1809         Reviewed by Dirk Pranke.
1810
1811         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1812             posix prevents the subprocesses from sharing the same fd for stdin.
1813             Sharing the same fd prevents us from closing the files unless all references
1814             to the fd are closed.
1815         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1816             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1817             the timeout override. It looks like it regressed in r95875.
1818
1819 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1820
1821         Unreviewed, rolling out r99964.
1822         http://trac.webkit.org/changeset/99964
1823         https://bugs.webkit.org/show_bug.cgi?id=72124
1824
1825         Broke too many Qt tests (Requested by tronical_ on #webkit).
1826
1827         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1828         (WTR::activateFonts):
1829         * qmake/mkspecs/features/features.prf:
1830         * qmake/mkspecs/features/webcore.prf:
1831
1832 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1833
1834         [Qt] Remove the QStyle dependency in Qt's mobile theme
1835         https://bugs.webkit.org/show_bug.cgi?id=67773
1836
1837         This refactoring splits up RenderThemeQt with two
1838         subclasses, a QStyle-backed one, and a Mobile version
1839         that uses the old mobile theme for now.
1840
1841         QStyle availability is detected at compile time, and
1842         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1843         environment variable.
1844
1845         Reviewed by Simon Hausmann.
1846
1847         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1848         (WTR::activateFonts):
1849         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1850         based on availability of QtWidgets.
1851         * qmake/mkspecs/features/webcore.prf: cleanup.
1852
1853 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1854
1855         [Qt] Add missing include to PlatformWebViewQt
1856
1857         Reviewed by Simon Hausmann.
1858
1859         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1860
1861 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1862
1863         [Qt] Fix incremental builds on Windows after buildsystem refactor
1864
1865         The qmake rules to ensure that we run make on the derived sources
1866         before running qmake on the target were inside a unix-scope, which
1867         resulted in flakey builds on Windows.
1868
1869         We now generate a rule on all platforms that ensures that "make qmake"
1870         will always run make on the derived sources. In addition, on platforms
1871         that have GNU make (where "make incremental" does not run "make qmake",
1872         but only "make"), we add a similar rule that ensures that any time the
1873         target makefile is regenerated we first run qmake and make on the derived
1874         sources. This rule relies on GNU make's order-only-prerequisites to
1875         not trigger a qmake-run of the target every time we run make.
1876
1877         https://bugs.webkit.org/show_bug.cgi?id=71778
1878
1879         Reviewed by Simon Hausmann.
1880
1881         * qmake/mkspecs/features/functions.prf:
1882
1883 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1884
1885         [Qt][WK2] Remove QWebNavigationController
1886         https://bugs.webkit.org/show_bug.cgi?id=72113
1887
1888         Reviewed by Andreas Kling.
1889
1890         Adapt to the move of the QWebNavigationController functions/properties to
1891         QQuickWebView.
1892
1893         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1894         * MiniBrowser/qt/qml/BrowserWindow.qml:
1895
1896 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1897
1898         [Qt] Build system tweak
1899
1900         Reviewed by Tor Arne Vestbø.
1901
1902         Be a good qmake citizen, return true from our linkStaticLibrary
1903         "test" function.
1904
1905         * qmake/mkspecs/features/functions.prf:
1906
1907 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1908
1909         [Qt] Add support for QT += webkit-private
1910
1911         Reviewed by Tor Arne Vestbø.
1912
1913         * qmake/qt_webkit.pri: Declare private headers.
1914
1915 2011-11-11  Philippe Normand  <pnormand@igalia.com>
1916
1917         Unreviewed, build fix attempt after r99907. Since that revision
1918         GTK layout tests were not running at all...
1919
1920         * Scripts/webkitpy/layout_tests/port/gtk.py:
1921
1922 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
1923
1924         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
1925         https://bugs.webkit.org/show_bug.cgi?id=72001
1926
1927         Reviewed by Dirk Pranke.
1928
1929         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1930
1931 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
1932
1933         bencher script should support remote benchmarking
1934         https://bugs.webkit.org/show_bug.cgi?id=71618
1935
1936         Rubber-stamped by Geoff Garen.
1937         
1938         Added the following features:
1939         
1940         - Benchmark report tells you the hostname and machine model (according to
1941           'sysctl hw.model') of the machine you did the run on, and svn revision number
1942           (according to 'svn info') of the VMs you're testing.
1943         
1944         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
1945           acceptable, in addition to just host, in which case your username is used)
1946           and it automatically packages the build directories of the VMs you're testing,
1947           sends them to the remote machine along with your copy of the bencher script
1948           and all of the options you passed.  This pretty much seamlessly allows you
1949           to run a set of benchmarks on any machine that is sufficiently compatible with
1950           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
1951           must now include a tempPath setting that tells bencher where to put files
1952           when that machine is used as a slave in a remote benchmarking run.
1953           
1954         - Added yet another way of specifying which benchmarks to run. This was sort of
1955           necessary for --remote to work as expected. Previously, you either said what
1956           suites to exclude (for example --exclude-sunspider) or that you only wanted
1957           to run one suite to the exclusion of others (--sunspider-only). But it's
1958           often better to just be able to specify the list of suites you want. This is
1959           now supported. You can say, for example, --v8 --sunspider, which means, just
1960           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
1961           still supported.
1962
1963         * Scripts/bencher:
1964
1965 2011-11-10  Tony Chang  <tony@chromium.org>
1966
1967         Lazily start DRT instances in NRWT
1968         https://bugs.webkit.org/show_bug.cgi?id=72038
1969
1970         Reviewed by Eric Seidel.
1971
1972         Just a refactoring, no new tests.
1973
1974         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1975         * Scripts/webkitpy/layout_tests/port/chromium.py:
1976         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1977         * Scripts/webkitpy/layout_tests/port/test.py:
1978         * Scripts/webkitpy/layout_tests/port/webkit.py:
1979
1980 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
1981
1982         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
1983         https://bugs.webkit.org/show_bug.cgi?id=72057
1984
1985         Reviewed by Eric Seidel.
1986
1987         Make the regular expression more explicit.
1988
1989         * Scripts/webkitpy/common/checkout/changelog.py:
1990         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1991
1992 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
1993
1994         [Qt] X11 plugins need to be reworked for Qt5
1995         https://bugs.webkit.org/show_bug.cgi?id=70023
1996
1997         Reviewed by Simon Hausmann.
1998
1999         Rework our basic plugin support in a way that does
2000         not need a bridge between Qt and X. The solution is
2001         based on getting the content drawed by the plugin
2002         from the server as an image and creating a QImage
2003         from it.
2004
2005         * qmake/mkspecs/features/features.prf: Enable X11
2006         plugins if Qt is built with the xcb-xlib backend.
2007
2008 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2009
2010         [Qt] Fix keyboard related layout tests after API refactoring
2011
2012         Reviewed by Tor Arne Vestbø.
2013
2014         Send key events to the handling page item, not the view.
2015
2016         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2017         (WTR::PlatformWebView::sendEvent):
2018         (WTR::PlatformWebView::postEvent):
2019
2020 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2021
2022         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2023         https://bugs.webkit.org/show_bug.cgi?id=71940
2024
2025         Reviewed by Philippe Normand.
2026
2027         * GNUmakefile.am:
2028         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2029         ENABLE_* variables are part of the environment.
2030
2031 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2032
2033         [Qt] Fix focus related layout tests after API refactoring
2034
2035         Reviewed by Tor Arne Vestbø.
2036
2037         Make sure the focus is set on the page now, not on the view
2038         (which doesn't actually handle the focus).
2039
2040         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2041         (WTR::WrapperWindow::WrapperWindow):
2042         (WTR::WrapperWindow::handleStatusChanged):
2043
2044 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2045
2046         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2047         https://bugs.webkit.org/show_bug.cgi?id=71355
2048
2049         Reviewed by Kenneth Rohde Christiansen.
2050
2051         Make MiniBrowser and WebKitTestRunner work again after the
2052         merge.
2053
2054         * MiniBrowser/qt/BrowserWindow.cpp:
2055         (BrowserWindow::BrowserWindow):
2056         (BrowserWindow::webView):
2057         * MiniBrowser/qt/MiniBrowser.pro:
2058         * MiniBrowser/qt/MiniBrowser.qrc:
2059         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2060         * MiniBrowser/qt/main.cpp:
2061         * MiniBrowser/qt/qml/BrowserWindow.qml:
2062         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2063         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2064         * WebKitTestRunner/PlatformWebView.h:
2065         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2066         (WTR::PlatformWebView::PlatformWebView):
2067
2068 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2069
2070         [Qt] Change semantics of the haveQt() function to match API promises
2071
2072         Having Qt 5 does not imply that we have Qt 4, from an API point of
2073         view, as a major version can in theory break BC/SC. Our minimum
2074         version of Qt 4 will always be the latest released version of Qt 4,
2075         so the only place we should use haveQt(4, x) is when checking for
2076         the minimum requirements.
2077
2078         Reviewed by Simon Hausmann.
2079
2080         * qmake/mkspecs/features/default_pre.prf:
2081         * qmake/mkspecs/features/features.prf:
2082         * qmake/mkspecs/features/functions.prf:
2083
2084 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2085
2086         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2087         https://bugs.webkit.org/show_bug.cgi?id=69411
2088
2089         Reviewed by Martin Robinson.
2090
2091         * WebKitTestRunner/EventSenderProxy.h:
2092         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2093         * WebKitTestRunner/TestController.cpp:
2094         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2095         use the EventSender instead of WebProcess Event Simulation.
2096         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2097         (WTR::WTREventQueueItem::WTREventQueueItem):
2098         (WTR::EventSenderProxy::EventSenderProxy):
2099         (WTR::getMouseButtonModifiers):
2100         (WTR::eventSenderButtonToGDKButton):
2101         (WTR::EventSenderProxy::createMouseButtonEvent):
2102         (WTR::EventSenderProxy::updateClickCountForButton):
2103         (WTR::EventSenderProxy::replaySavedEvents):
2104         (WTR::EventSenderProxy::sendOrQueueEvent):
2105         (WTR::webkitModifiersToGDKModifiers):
2106         (WTR::getGDKKeySymForKeyRef):
2107         (WTR::EventSenderProxy::keyDown):
2108         (WTR::EventSenderProxy::mouseDown):
2109         (WTR::EventSenderProxy::mouseUp):
2110         (WTR::EventSenderProxy::mouseMoveTo):
2111         (WTR::EventSenderProxy::mouseScrollBy):
2112         (WTR::EventSenderProxy::leapForward):
2113
2114 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2115
2116         [Qt] Enable exports and constructor functions in static libs
2117
2118         Reviewed by Tor Arne Vestbø.
2119
2120         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2121         mac/win32-msvc equivalents when linking static libraries into a shared
2122         library or executable.
2123
2124 2011-11-09  Hayato Ito  <hayato@chromium.org>
2125
2126         [NRWT] Make results.html aware of reference filename in reftests.
2127         https://bugs.webkit.org/show_bug.cgi?id=71574
2128
2129         Reviewed by Ryosuke Niwa.
2130
2131         If a reference filename is different from the default one, include that in result summary
2132         so results.html can link to the correct reference file.
2133
2134         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2135         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2136
2137 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2138
2139         [wx] Unreviewed build fix. Update project files and
2140         add LTC stubs for new methods.
2141
2142         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2143         (LayoutTestController::addChromeInputField):
2144         (LayoutTestController::removeChromeInputField):
2145         (LayoutTestController::focusWebView):
2146         (LayoutTestController::setBackingScaleFactor):
2147         * waf/build/settings.py:
2148
2149 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2150
2151         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2152
2153         * wx/install-unix-extras:
2154
2155 2011-11-09  Eric Seidel  <eric@webkit.org>
2156
2157         Remove the concept of platform-dependent unittests
2158         https://bugs.webkit.org/show_bug.cgi?id=71963
2159
2160         Unreviewed.  Fix test-webkitpy on cygwin.
2161
2162         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2163
2164 2011-11-09  Dana Jansens  <danakj@chromium.org>
2165
2166         Add cc-bugs group to watch changes in chromium graphics
2167         https://bugs.webkit.org/show_bug.cgi?id=71690
2168
2169         Reviewed by David Levin.
2170
2171         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2172         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2173         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2174         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2175
2176 2011-11-09  Eric Seidel  <eric@webkit.org>
2177
2178         Remove more platform-dependent unittests
2179         https://bugs.webkit.org/show_bug.cgi?id=71971
2180
2181         Reviewed by Adam Barth.
2182
2183         Tests which only run on a couple platforms will break.
2184         All tests should run on all platforms where possible.
2185
2186         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2187         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2188         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2189         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2190
2191 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2192
2193         Merge in results to the test results server even if build numbers conflict
2194         https://bugs.webkit.org/show_bug.cgi?id=71967
2195
2196         Reviewed by Tony Chang.
2197
2198         This was initially meant to be a sanity check that we don't
2199         enter duplicate runs, but it turns out that we can reasonably get
2200         in these situations when a builder is clobbered (e.g. the build
2201         numbers start over again from 0).
2202
2203         * TestResultServer/model/jsonresults.py:
2204         * TestResultServer/model/jsonresults_unittest.py:
2205
2206 2011-11-09  Eric Seidel  <eric@webkit.org>
2207
2208         Remove the concept of platform-dependent unittests
2209         https://bugs.webkit.org/show_bug.cgi?id=71963
2210
2211         Reviewed by Adam Barth.
2212
2213         These have been the source of never-ending sadness.
2214         We'd change behavior and forget to update results in
2215         some unittests because they were only run on certain platforms.
2216         This change removes a large source of these platform-dependent
2217         unittests, which was caused by the port_maker stuff.
2218
2219         It's possible that this change will break test-webkitpy
2220         on some platforms, but that will be a one-time cost.
2221         I will fix the breakage by removing the platform-dependantness
2222         of any such broken tests.
2223
2224         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2225         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2226         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2227         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2228         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2229         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2230         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2231         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2232         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2233         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2234         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2235         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2236         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2237
2238 2011-11-09  Eric Seidel  <eric@webkit.org>
2239
2240         Make the Port object have a Host
2241         https://bugs.webkit.org/show_bug.cgi?id=71961
2242
2243         Reviewed by Adam Barth.
2244
2245         This has been a long time coming.
2246         Now that Port has a Host object, it's very easy
2247         to write unittests which use a properly mocked Port.
2248         Soon we will remove the executive, filesystem and user
2249         members of Port and get everything through the Host.
2250
2251         Note how in many callsites we're actually removing
2252         explicit mocks, since we're now always going to get the
2253         correct Executive/User/FileSystem from the
2254         Host and callsites don't need to be careful to pass each one.
2255
2256         This is prep-work for adding a new Environment member to
2257         Host and needing to be able to access the Environment
2258         member from Port functions w/o needing to pass an Environment
2259         object (or appropriate Mock) every place we create a Port object.
2260         Now that we have a single Host object to reach out through, its
2261         simple to add additional functionality (like Environment) while
2262         keeping our unittests properly mocked.
2263
2264         * Scripts/webkitpy/common/host.py:
2265         * Scripts/webkitpy/common/net/credentials_unittest.py:
2266         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2267         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2268         * Scripts/webkitpy/layout_tests/port/apple.py:
2269         * Scripts/webkitpy/layout_tests/port/base.py:
2270         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2271         * Scripts/webkitpy/layout_tests/port/chromium.py:
2272         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2273         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2274         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2275         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2276         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2277         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2278         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2279         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2280         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2281         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2282         * Scripts/webkitpy/layout_tests/port/efl.py:
2283         * Scripts/webkitpy/layout_tests/port/factory.py:
2284         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2285         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2286         * Scripts/webkitpy/layout_tests/port/gtk.py:
2287         * Scripts/webkitpy/layout_tests/port/mac.py:
2288         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2289         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2290         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2291         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2292         * Scripts/webkitpy/layout_tests/port/qt.py:
2293         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2294         * Scripts/webkitpy/layout_tests/port/test.py:
2295         * Scripts/webkitpy/layout_tests/port/webkit.py:
2296         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2297         * Scripts/webkitpy/layout_tests/port/win.py:
2298         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2299         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2300         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2301         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2302         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2303
2304 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2305
2306         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2307         https://bugs.webkit.org/show_bug.cgi?id=71561
2308
2309         Reviewed by Dimitri Glazkov.
2310
2311         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2312         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2313
2314 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2315
2316         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2317         https://bugs.webkit.org/show_bug.cgi?id=66772
2318
2319         Reviewed by Simon Fraser.
2320
2321         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2322         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2323
2324         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2325         in the FrameLoadDelegate and print the output in response to the notification.
2326
2327         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2328         (-[FrameLoadDelegate init]):
2329         (-[FrameLoadDelegate dealloc]):
2330         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2331
2332 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2333
2334         [GTK][DRT] window internals object is not reset after each test
2335         https://bugs.webkit.org/show_bug.cgi?id=71890
2336
2337         Reviewed by Martin Robinson.
2338
2339         Call WebCoreTestSupport::resetInternalsObject without going
2340         through DumpRenderTreeSupport.
2341
2342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2343         (runTest):
2344
2345 2011-11-09  Beth Dakin  <bdakin@apple.com>
2346
2347         Build fix.
2348
2349         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2350         (AccessibilityUIElement::uiElementAttributeValue):
2351
2352 2011-11-09  Beth Dakin  <bdakin@apple.com>
2353
2354         Speculative build fix.
2355
2356         * DumpRenderTree/AccessibilityUIElement.h:
2357
2358 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2359
2360         Unreviewed build fix.
2361
2362         * DumpRenderTree/AccessibilityUIElement.cpp:
2363         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2364         A bad merge added this check that is making the bots sad.
2365
2366 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2367
2368         AX: crash when accessing selectedTab in a tab list
2369         https://bugs.webkit.org/show_bug.cgi?id=70938
2370
2371         Reviewed by Beth Dakin.
2372
2373         Add the ability to retrieve an element through an arbitrary attribute.
2374
2375         * DumpRenderTree/AccessibilityUIElement.cpp:
2376         (uiElementAttributeValueCallback):
2377         (AccessibilityUIElement::uiElementAttributeValue):
2378         (AccessibilityUIElement::getJSClass):
2379         * DumpRenderTree/AccessibilityUIElement.h:
2380         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2381         (AccessibilityUIElement::uiElementAttributeValue):
2382
2383 2011-11-09  Andy Wingo  <wingo@igalia.com>
2384
2385         Add webkitdirs.pm:getArchitecture implementation for GTK
2386         https://bugs.webkit.org/show_bug.cgi?id=71370
2387
2388         Reviewed by Xan Lopez.
2389
2390         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2391         implementation for ports using autotools, so that a vanilla
2392         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2393         to build-jsc on x86-64 machines.
2394
2395 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2396
2397         Unreviewed, rolling out r99707.
2398         http://trac.webkit.org/changeset/99707
2399
2400         Re-enable until we can disable it together with tests in one
2401         shot.
2402
2403         * qmake/mkspecs/features/features.prf:
2404
2405 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2406
2407         [Qt] Disable use of QtUiTools if the library/module is not found
2408
2409         We rely on the lookup order of prf files to inject our own uitools.prf
2410         that will verify that QtUiTools is in fact present before allowing the
2411         CONFIG += uitools to have any effect.
2412
2413         Reviewed by Simon Hausmann.
2414
2415         * DumpRenderTree/qt/DumpRenderTree.pro:
2416         * QtTestBrowser/QtTestBrowser.pro:
2417         * qmake/mkspecs/features/uitools.prf: Added.
2418
2419 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2420
2421         Unreviewed, rolling out r99701.
2422         http://trac.webkit.org/changeset/99701
2423
2424         Breaks Qt mac build
2425
2426         * qmake/mkspecs/features/functions.prf:
2427
2428 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2429
2430         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2431
2432         Reviewed by Tor Arne Vestbø.
2433
2434         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2435         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2436         is not up to the task of full XSLT support, so we should disable it.
2437
2438 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2439
2440         [Qt] Enable exports and constructor functions in static libs
2441
2442         Reviewed by Tor Arne Vestbø.
2443
2444         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2445         mac/win32-msvc equivalents when linking static libraries into a shared
2446         library or executable.
2447
2448 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2449
2450         [GTK][DRT] window internals object is not reset after each test
2451         https://bugs.webkit.org/show_bug.cgi?id=71890
2452
2453         Reviewed by Xan Lopez.
2454
2455         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2456         (runTest): reset the Internals object after each test.
2457
2458 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2459
2460         [Qt] Detect presence of QtUiTools and enable it only when available
2461
2462         The disable_uitools option was a workaround for missing detection.
2463
2464         Reviewed by Simon Hausmann.
2465
2466         * QtTestBrowser/QtTestBrowser.pro:
2467         * qmake/mkspecs/features/default_post.prf:
2468         * qmake/mkspecs/features/default_pre.prf:
2469
2470 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2471
2472         [Qt] Don't override config for the build_pass of debug_and_release
2473
2474         Qmake will parse the profile once for each configuration (debug and
2475         release), with the build_pass option set. In that situation we don't
2476         want to override what qmake is setting explicitly, otherwise the
2477         debug-step will end up hitting all the release-scopes.
2478
2479         Reviewed by Simon Hausmann.
2480
2481         * qmake/mkspecs/features/default_pre.prf:
2482
2483 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2484
2485         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2486
2487         * qmake/mkspecs/features/functions.prf:
2488
2489 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2490
2491         [Qt] Centralize duplicated code for linking the static libs
2492
2493         Reviewed by Tor Arne Vestbø.
2494
2495         * qmake/mkspecs/features/functions.prf:
2496         * qmake/mkspecs/features/javascriptcore.prf:
2497         * qmake/mkspecs/features/webcore.prf:
2498         * qmake/mkspecs/features/webkit2.prf:
2499
2500 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2501
2502         [Qt] Build system cleanup
2503         https://bugs.webkit.org/show_bug.cgi?id=71815
2504
2505         Reviewed by Kenneth Rohde Christiansen.
2506
2507         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2508         static library.
2509         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2510         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2511
2512 2011-11-08  Hayato Ito  <hayato@chromium.org>
2513
2514         [NRWT] Make single_test_runner aware of reference filename of test_input.
2515         https://bugs.webkit.org/show_bug.cgi?id=71567
2516
2517         Reviewed by Ryosuke Niwa.
2518
2519         Make single_test_runner honor a reference filename of given test_input so that
2520         we can use any file as reference html, instead of depending on implicit naming convention.
2521         The typical use case is to support w3c reftests.
2522
2523         No tests since no functional changes until there is a client.
2524         Test should be easily written with future clients.
2525
2526         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2527         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2528         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2529         * Scripts/webkitpy/layout_tests/models/test_input.py:
2530
2531 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2532
2533         https://bugs.webkit.org/show_bug.cgi?id=71839
2534         Update the leaks bot OS to Lion.
2535         Update the config.json to reflect the update.
2536
2537         Reviewed by Stephanie Lewis.
2538
2539         * BuildSlaveSupport/build.webkit.org-config/config.json:
2540
2541 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2542
2543         Unreviewed, rolling out r99626.
2544         http://trac.webkit.org/changeset/99626
2545         https://bugs.webkit.org/show_bug.cgi?id=71866
2546
2547         "C++ exceptions cannot be disabled without influencing the
2548         Objective-C exceptions" (Requested by benjaminp on #webkit).
2549
2550         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2551
2552 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2553
2554         [Mac] Disable C++ exceptions from DumpRenderTree
2555         https://bugs.webkit.org/show_bug.cgi?id=71834
2556
2557         Reviewed by Darin Adler.
2558
2559         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2560         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2561         which leads to crashes long after the exception was raised.
2562
2563         This patch disabled C++ exceptions in order to catch the problems where
2564         they happen when a C++ exception is raised.
2565
2566         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2567
2568 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2569
2570         Moved myself to the reviewer list (yay!).
2571
2572         * Scripts/webkitpy/common/config/committers.py:
2573
2574 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2575
2576         Added myself as a committer.
2577
2578         * Scripts/webkitpy/common/config/committers.py:
2579
2580 2011-11-08  Andy Wingo  <wingo@igalia.com>
2581
2582         Skip some ECMAScript tests that fail on Linux in some time zones.
2583         https://bugs.webkit.org/show_bug.cgi?id=71371
2584
2585         Reviewed by Martin Robinson.
2586
2587         * Scripts/run-javascriptcore-tests: Skip some more tests.
2588
2589 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2590
2591         [Qt] Unreviewed trivial fix after build system refactoring.
2592
2593         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2594
2595 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2596
2597         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2598
2599         If a pro file needs to access the OBJECTS_DIR it should use the
2600         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2601         after defaults_post has been processed.
2602
2603         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2604         the command line will override whatever we set in defaults_pre.
2605
2606         Reviewed by Simon Hausmann.
2607
2608         * qmake/mkspecs/features/default_post.prf:
2609         * qmake/mkspecs/features/default_pre.prf:
2610
2611 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2612
2613         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2614
2615         Reviewed by Simon Hausmann.
2616
2617         * qmake/mkspecs/features/default_post.prf:
2618
2619 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2620
2621         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2622         https://bugs.webkit.org/show_bug.cgi?id=71680
2623
2624         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2625         complete urls in MiniBrowser.
2626
2627         Reviewed by Tor Arne Vestbø.
2628
2629         * MiniBrowser/qt/BrowserWindow.cpp:
2630         (BrowserWindow::BrowserWindow):
2631         (BrowserWindow::load):
2632         * MiniBrowser/qt/qml/BrowserWindow.qml:
2633         * MiniBrowser/qt/utils.cpp:
2634         (Utils::urlFromUserInput):
2635         * MiniBrowser/qt/utils.h:
2636         (Utils::Utils):
2637
2638 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2639
2640         Added myself as a committer.
2641
2642         * Scripts/webkitpy/common/config/committers.py:
2643
2644 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2645
2646         Unreviewed webkitpy test fix after r99512.
2647
2648         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2649         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2650
2651 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2652
2653         Added myself as a committer.
2654
2655         * Scripts/webkitpy/common/config/committers.py:
2656
2657 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2658
2659         Unreviewed, rolling out r99470.
2660         http://trac.webkit.org/changeset/99470
2661         https://bugs.webkit.org/show_bug.cgi?id=71740
2662
2663         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2664
2665         * Scripts/webkitpy/common/config/watchlist:
2666
2667 2011-11-07  Tony Chang  <tony@chromium.org>
2668
2669         [chromium] update flakiness dashboard to reflect current bots
2670
2671         Reviewed by Ojan Vafai.
2672
2673         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2674             bots and merged linux debug bots into a single bot.
2675         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2676         (setupExpectationsTest):
2677
2678 2011-11-07  Dana Jansens  <danakj@chromium.org>
2679
2680         Add cc-bugs group to watch changes in chromium graphics
2681         https://bugs.webkit.org/show_bug.cgi?id=71690
2682
2683         Reviewed by James Robinson.
2684
2685         * Scripts/webkitpy/common/config/watchlist:
2686
2687 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2688
2689         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2690         https://bugs.webkit.org/show_bug.cgi?id=70912
2691
2692         Reviewed by Ojan Vafai.
2693
2694         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2695         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2696
2697 2011-11-07  Eric Seidel  <eric@webkit.org>
2698
2699         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2700         https://bugs.webkit.org/show_bug.cgi?id=62199
2701
2702         Reviewed by Dirk Pranke.
2703
2704         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2706         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2707
2708 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2709
2710         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2711         https://bugs.webkit.org/show_bug.cgi?id=71485
2712
2713         Reviewed by Darin Fisher.
2714
2715         * DumpRenderTree/chromium/EventSender.cpp:
2716         (EventSender::scalePageBy):
2717         * DumpRenderTree/chromium/TestShell.cpp:
2718         (TestShell::resetTestController):
2719
2720 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2721
2722         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2723
2724         Allows us to not package up the whole Source/JavaScriptCore directory for the
2725         buildbots.
2726
2727         Reviewed-by Simon Hausmann.
2728
2729         * BuildSlaveSupport/built-product-archive:
2730         * Scripts/webkitdirs.pm:
2731         (jscProductDir):
2732
2733 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2734
2735         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2736
2737         Reviewed-by Simon Hausmann.
2738
2739         * qmake/mkspecs/features/default_post.prf:
2740
2741 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2742
2743         [Qt] Sanitize qmake paths correctly before comparing
2744
2745         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2746         which caused us to always generate derived webcore sources, but never build
2747         them. The bug has been fixed, and we now also sanitize paths for the injected
2748         bundle derived sources.
2749
2750         Reviewed by Simon Hausmann.
2751
2752         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2753         * qmake/mkspecs/features/functions.prf:
2754
2755 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2756
2757         [Qt] Print right order for changing feature defines
2758
2759         Reviewed by Simon Hausmann.
2760
2761         * Scripts/webkitdirs.pm:
2762         (buildQMakeProject):
2763
2764 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2765
2766         [Qt] Unreviewed trivial fix after build system refactoring.
2767
2768         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2769
2770 2011-11-06  Eric Seidel  <eric@webkit.org>
2771
2772         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2773         https://bugs.webkit.org/show_bug.cgi?id=66078
2774
2775         Unreviewed.  Add an assert about the type of "args"
2776         to our Executive Mocks and fix a piece of code
2777         from this patch which was hitting that assert
2778         when executing for real.
2779
2780         * Scripts/webkitpy/common/system/executive_mock.py:
2781         * Scripts/webkitpy/layout_tests/port/webkit.py:
2782
2783 2011-11-06  Eric Seidel  <eric@webkit.org>
2784
2785         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2786         https://bugs.webkit.org/show_bug.cgi?id=71629
2787
2788         Reviewed by Adam Barth.
2789
2790         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2791
2792 2011-11-06  Eric Seidel  <eric@webkit.org>
2793
2794         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2795         https://bugs.webkit.org/show_bug.cgi?id=66078
2796
2797         Reviewed by Adam Barth.
2798
2799         The runtime feature detection was fixed to work in bug 64472.
2800         In this bug I moved the symbol-based feature detection from
2801         popen() to Executive.run_command and cleaned up the callers
2802         and unittests to make sure that we're correctly parsing the
2803         nm output correctly.  The old code happened to work even though
2804         the runtime-features path was using "str in list" and the
2805         symbol features path was using "str in str" and it just happened
2806         to do what we wanted to.  Now runtime features and symbol feature
2807         blacklists are computed separately (and with better documentation).
2808
2809         This system remains confusing, partially because these are black-lists
2810         which are amended to whatever static blacklist may exist for the
2811         port as part of a Skipped list file.
2812
2813         For example, notice how the runtime feature list only has directory
2814         blacklists for a couple features.  If all features are off,
2815         how do we skip enough tests with only 2 entries in the blacklist map?
2816         The answer is that Windows is the only port to use runtime feature
2817         detection, and the win/Skipped file turns off all the other features
2818         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2819         which use symbol-based feature detection turn of mathml, wcss, etc
2820         using the blacklists found in _missing_symbol_to_skipped_tests.
2821
2822         I also noticed a couple places where we still referenced xhtmlmp
2823         even though support for such has been removed from WebKit.  Removed those.
2824
2825         This should result in no functional change.
2826
2827         * Scripts/webkitpy/layout_tests/port/gtk.py:
2828          - Use self._filesystem instead of os.path
2829         * Scripts/webkitpy/layout_tests/port/webkit.py:
2830         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2831
2832 2011-11-06  Dan Bernstein  <mitz@apple.com>
2833
2834         Made show-pretty-diff work when the input path contains spaces.
2835
2836         Reviewed by Anders Carlsson.
2837
2838         * Scripts/show-pretty-diff:
2839
2840 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2841
2842         [chromium] Use the security origin instead of the URL when checking notification permissions
2843         https://bugs.webkit.org/show_bug.cgi?id=71590
2844
2845         Reviewed by Adam Barth.
2846
2847         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2848         (NotificationPresenter::checkPermission):
2849         * DumpRenderTree/chromium/NotificationPresenter.h:
2850
2851 2011-11-05  Darin Adler  <darin@apple.com>
2852
2853         Fix a small leak in Mac version of LayoutTestController
2854         https://bugs.webkit.org/show_bug.cgi?id=71615
2855
2856         Reviewed by Mark Rowe.
2857
2858         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2859         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
2860         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
2861
2862 2011-11-04  Eric Seidel  <eric@webkit.org>
2863
2864         Upgrade to the latest Mechanize
2865         https://bugs.webkit.org/show_bug.cgi?id=71594
2866
2867         Reviewed by Adam Barth.
2868
2869         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
2870         Mechanize is no longer two separate libraries, so importing it is much simpler.
2871
2872         * Scripts/webkitpy/thirdparty/__init__.py:
2873
2874 2011-11-04  Stephen Chenney  <schenney@chromium.org>
2875
2876         Crash in ScrollAnimator.cpp
2877         https://bugs.webkit.org/show_bug.cgi?id=69865
2878
2879         The code in ScrollAnimator assumes that horizontal per-page mouse
2880         wheel events cannot happen, which is not true. This patch adds layout
2881         tests for all paging wheel event situations and fixes the broken
2882         horizontal case.
2883
2884         Reviewed by Anders Carlsson
2885
2886         * DumpRenderTree/chromium/EventSender.cpp:
2887         (EventSender::handleMouseWheel): Added the ability to specify that a
2888         mouse wheel event should be paging.
2889
2890 2011-11-04  Eric Seidel  <eric@webkit.org>
2891
2892         Remove deprecated free functions in port.factory
2893         https://bugs.webkit.org/show_bug.cgi?id=71494
2894
2895         Unreviewed.  Fix exception when running new-run-webkit-httpd.
2896
2897         * Scripts/new-run-webkit-httpd:
2898
2899 2011-11-04  Adam Roben  <aroben@apple.com>
2900
2901         Remove Leopard-specific code from build.webkit.org
2902
2903         We don't have any Leopard bots anymore.
2904
2905         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
2906
2907         Reviewed by Mark Rowe.
2908
2909         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
2910         and StopATSServer steps.
2911         (unitTestsSupported): Removed check for mac-leopard.
2912         (TestFactory.__init__): Removed Leopard-specific steps.
2913
2914 2011-11-04  Eric Seidel  <eric@webkit.org>
2915
2916         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
2917         https://bugs.webkit.org/show_bug.cgi?id=71549
2918
2919         Reviewed by Adam Barth.
2920
2921         Several members of Host didn't really belong there
2922         and were instead specific to WebKitPatch, so I've moved
2923         them up onto that class.
2924
2925         * Scripts/webkitpy/common/host.py:
2926         * Scripts/webkitpy/common/host_mock.py:
2927         * Scripts/webkitpy/tool/main.py:
2928         * Scripts/webkitpy/tool/mocktool.py:
2929         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2930
2931 2011-11-04  Tony Chang  <tony@chromium.org>
2932
2933         garden-o-matic: bring back party time!
2934         https://bugs.webkit.org/show_bug.cgi?id=71582
2935
2936         Reviewed by Adam Barth.
2937
2938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
2939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
2940         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
2941         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
2942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
2944
2945 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
2946
2947         [EFL] DRT: Fix the order of the items in the dumped history list.
2948         https://bugs.webkit.org/show_bug.cgi?id=71562
2949
2950         It did not make much sense to hold the history list in a map, as we do not need
2951         the keys. And the printed items must be sorted by target, which is more easily
2952         done with a vector.
2953
2954         Should make tests such as http/tests/navigation/error404-frames.html pass.
2955
2956         Reviewed by Antonio Gomes.
2957
2958         * DumpRenderTree/efl/DumpHistoryItem.cpp:
2959         (compareHistoryItemsByTarget):
2960         (dumpHistoryItem):
2961
2962 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
2963
2964         [Qt] Remove ENABLE_SQLITE from qmake files
2965         https://bugs.webkit.org/show_bug.cgi?id=71546
2966
2967         Reviewed by Simon Hausmann.
2968
2969         * qmake/mkspecs/features/features.prf:
2970         * qmake/mkspecs/features/webcore.prf:
2971
2972 2011-11-04  Adam Barth  <abarth@webkit.org>
2973
2974         watchlist for WebIDL shouldn't trigger on Internals.idl
2975         https://bugs.webkit.org/show_bug.cgi?id=70657
2976
2977         Reviewed by David Levin.
2978
2979         Internals.idl isn't part of the Web-facing IDL in the project.
2980
2981         * Scripts/webkitpy/common/config/watchlist:
2982
2983 2011-11-04  Anders Carlsson  <andersca@apple.com>
2984
2985         Fix WKTR crash when running NPN_ConvertPoint test.
2986
2987         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
2988
2989         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
2990         (ConvertPoint::NPP_SetWindow):
2991
2992 2011-11-04  Anders Carlsson  <andersca@apple.com>
2993
2994         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
2995         https://bugs.webkit.org/show_bug.cgi?id=71570
2996
2997         Reviewed by Simon Fraser.
2998
2999         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3000         (PluginTest::NPP_SetWindow):
3001         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3002         Remove the NPP parameter from NPP_SetWindow.
3003
3004         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3005         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3006         Remove the NPP parameter from NPP_SetWindow.
3007
3008         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3009         (PassDifferentNPPStruct::NPP_SetWindow):
3010         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3011
3012         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3013         (ConvertPoint::NPP_SetWindow):
3014         Run the test from NPP_SetWindow and call notifyDone() when done.
3015
3016         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3017         (NPP_SetWindow):
3018         Remove unnecessary parameter.
3019
3020 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3021
3022         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3023
3024         Rubber-stamped by Tor Arne Vestbø.
3025
3026         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3027         changed slightly after the refactoring.
3028
3029 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3030
3031         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3032
3033         Reviewed by Simon Hausmann.
3034
3035         * qmake/mkspecs/features/default_pre.prf:
3036
3037 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3038
3039         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3040
3041         Reviewed by Simmon Hausmann.
3042
3043         * qmake/mkspecs/features/default_pre.prf:
3044
3045 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3046
3047         [Qt] Disable STDIN check before cleaning build dir
3048
3049         It didn't work on the bots.
3050
3051         Reviewed by Ossy.
3052
3053         * Scripts/webkitdirs.pm:
3054
3055 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3056
3057         [Qt] Don't build all of webkit when running build-jsc
3058
3059         In case the whole webkit project was built, but we then subsequently
3060         want to build only JSC, we need to run make in the proper subdirectory.
3061
3062         This also means the incremental target needs to be added to all
3063         makefiles.
3064
3065         Reviewed by Simmon Hausmann.
3066
3067         * Scripts/webkitdirs.pm:
3068         (buildQMakeProject):
3069         * qmake/mkspecs/features/default_post.prf:
3070
3071 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3072
3073         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3074
3075         Reviewed by Tor Arne Vestbø.
3076
3077         * Scripts/webkitdirs.pm:
3078         (jscProductDir): jsc path changed.
3079
3080 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3081
3082         [Qt] Error out early if trying to build against Qt < 4.8
3083
3084         Reviewed by Simon Hausmann.
3085
3086         * qmake/mkspecs/features/default_pre.prf:
3087
3088 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3089
3090         Fix run-launcher for Qt and Gtk.
3091
3092         Rubber-stamped by Tor Arne Vestbø.
3093
3094         * Scripts/webkitdirs.pm:
3095         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3096
3097 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3098
3099         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3100
3101         Reviewed by Simon Hausmann.
3102
3103         * Scripts/build-webkit:
3104
3105 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3106
3107         [GTK] Use web view title as window title in MiniBrowser
3108         https://bugs.webkit.org/show_bug.cgi?id=71544
3109
3110         Reviewed by Philippe Normand.
3111
3112         * MiniBrowser/gtk/BrowserWindow.c:
3113         (webViewURIChanged): Removed extra space.
3114         (webViewTitleChanged): Set window title using
3115         webkit_web_view_get_title().
3116         (browser_window_init): Set initial default window title.
3117         (browserWindowConstructed): Connect to WebView notify::title
3118         signal.
3119
3120 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3121
3122         [Qt] Refactor and clean up the qmake build system
3123
3124         The qmake build system has accumulated a bit of cruft and redundancy
3125         over time. There's also a fairly tight coupling between how to build
3126         the various targets, and _what_ to build, making it harder to add new
3127         rules or sources. This patch aims to elevate these issues somewhat.
3128
3129         This is a short-list of the changes:
3130
3131           * The rules for how to build targets are now mostly contained as
3132             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3133             allows us to do pre- and post-processing of each project file,
3134             which helps to clean up the actual project files.
3135
3136           * Derived sources are no longer generated as a separate make-step
3137             but is part of each target's project file as a subdir. Makefile
3138             rules are used to ensure that we run make on the derived sources
3139             before running qmake on the actual target makefile. This makes
3140             it easier to keep a proper dependency between derived sources
3141             and the target.
3142
3143           * We use GNU make and the compiler to generate dependencies on
3144             UNIX-based systems running Qt 5. This allows us to lessen the
3145             need to run qmake, which should reduce compile time.
3146
3147           * WebKit2 is now build by default if building with Qt 5. It can
3148             be disabled by passing --no-webkit2 to build-webkit.
3149
3150         The result of these changes are hopefully a cleaner and easier
3151         build system to modify, and faster build times due to no longer
3152         running qmake on every single build. It's also a first step
3153         towards possibly generating the list of sources using another
3154         build system.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=71222
3157
3158         Reviewed by Simon Hausmann.
3159
3160         * DerivedSources.pro: Removed.
3161         * DumpRenderTree/qt/DumpRenderTree.pro:
3162         * DumpRenderTree/qt/ImageDiff.pro:
3163         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3164         * MiniBrowser/qt/MiniBrowser.pro:
3165         * QtTestBrowser/QtTestBrowser.pro:
3166         * QtTestBrowser/launcherwindow.cpp:
3167         (LauncherWindow::initializeView):
3168         (LauncherWindow::createChrome):
3169         (LauncherWindow::screenshot):
3170         * QtTestBrowser/launcherwindow.h:
3171         (WindowOptions::WindowOptions):
3172         * Scripts/build-webkit:
3173         (unlinkZeroFiles):
3174         * Scripts/webkitdirs.pm:
3175         (qtFeatureDefaults):
3176         (promptUser):
3177         (buildQMakeProject):
3178         * Tools.pro:
3179         * WebKitTestRunner/DerivedSources.pri: Added.
3180         * WebKitTestRunner/DerivedSources.pro: Removed.
3181         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3182         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3183         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3184         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3185         * WebKitTestRunner/Target.pri: Added.
3186         * WebKitTestRunner/WebKitTestRunner.pro:
3187         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3188         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3189         * qmake/README: Added.
3190         * qmake/mkspecs/features/default_post.prf: Added.
3191         * qmake/mkspecs/features/default_pre.prf: Added.
3192         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3193         * qmake/mkspecs/features/functions.prf: Added.
3194         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3195         * qmake/mkspecs/features/mac/default_post.prf: Added.
3196         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3197         * qmake/mkspecs/features/minimal_qt.prf: Added.
3198         * qmake/mkspecs/features/qtwebkit.prf: Added.
3199         * qmake/mkspecs/features/rpath.prf: Added.
3200         * qmake/mkspecs/features/unix/default_post.prf: Added.
3201         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3202         * qmake/mkspecs/features/valgrind.prf: Added.
3203         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3204         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3205         * qmake/mkspecs/features/win32/default_post.prf: Added.
3206         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3207         * qmake/syncqt-4.8: Added.
3208         (showUsage):
3209         ():
3210         (copyFile):
3211         (symlinkFile):
3212
3213 2011-11-04  Eric Seidel  <eric@webkit.org>
3214
3215         Remove deprecated free functions in port.factory
3216         https://bugs.webkit.org/show_bug.cgi?id=71494
3217
3218         Unreviewed.  Fixing exception seen when running test-webkitpy.
3219
3220         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3221         unittest, since that script is nearly ready to be deleted.  But I added
3222         it back at the last second and failed to run the tests. :(
3223         This fixes the exception the bots were seeing.
3224
3225         * Scripts/webkitpy/style/checkers/test_expectations.py:
3226         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3227         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3228
3229 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3230
3231         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3232         https://bugs.webkit.org/show_bug.cgi?id=71163
3233
3234         Reviewed by Ryosuke Niwa.
3235
3236         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3237         (WebPreferences::applyTo):
3238
3239 2011-11-03  Eric Seidel  <eric@webkit.org>
3240
3241         Remove deprecated free functions in port.factory
3242         https://bugs.webkit.org/show_bug.cgi?id=71494
3243
3244         Reviewed by Adam Barth.
3245
3246         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3247         free functions in factory.py.  To remove these required fixing all callsites
3248         to use MockHost, Host, or PortFactory where appropriate.  After this change
3249         we're only left with a handfull of places where we inappropraitely use a
3250         real Executive, FileSystem or User object during unittesting.
3251
3252         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3253          - These PortFactory overrides were from an earlier edition of my previous patch
3254            in the end, I removed MockPortFactory so all tests ended up with this same
3255            real PortFactory() with a MockHost.  This was simply redundent code.
3256         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3257          - Use MockHost to get a mocked-out PortFactory.
3258         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3259          - This code has no access to a Host object, so we just use a default PortFactory
3260            for now.  This will still incorrectly create real Executive/FileSystem objects
3261            durring unittesting, which is wrong. :(
3262         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3263          - Use a MockHost to get a mocked PortFactory.
3264         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3265          - Use a MockHost to get a mocked PortFactory.
3266         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3267          - ditto.
3268         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3269          - ditto.
3270         * Scripts/webkitpy/layout_tests/port/__init__.py:
3271          - factory.get no longer exists.  Yay!
3272         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3273          - Use a MockHost to get a mocked PortFactory.
3274            To do this efficiently, I created a helper function
3275            and combined all these (mostly redundant) tests into one test
3276            with several calls to the helper function.
3277         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3278          - Pass MockUser and MockExecutive in these port testing subclasses.
3279          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3280         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3281          - Awesome windows hacks should only happen on win32.  Once we started
3282            using MockExecutives these 'svn help' commands started printing in
3283            other tests, which is how I found this bug.
3284         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3285          - DryRunPort has no Host, so just use a PortFactory() directly.
3286            This will do the wrong thing if we're unittesting the DryRun port
3287            but it's no worse than the existing code.
3288         * Scripts/webkitpy/layout_tests/port/factory.py:
3289          - Remove the free functions.
3290          - Fix argument overriding to be able to override None.
3291         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3292          - Use a mocked-out PortFactory during testing.
3293         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3294          - Pass MockExecutive and MockUser to these manual Port instantiations.
3295         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3296          - No access to a Host object here, so just using PortFactory directly.
3297            This is wrong, but no more wrong than the existing code was.
3298         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3299          - Use a MockHost to get a mocked out PortFactory.
3300         * Scripts/webkitpy/layout_tests/port/test.py:
3301          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3302         * Scripts/webkitpy/layout_tests/port/win.py:
3303          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3304            now that we're actually passing MockExecutive to most Port instantiations during testing.
3305         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3306          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3307         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3308          - Host is the future.
3309         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3310          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3311            we don't need to pass MockUser explicitly, it does that automatically for us.
3312         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3313          - Use a MockHost to get a mocked out PortFactory.
3314         * Scripts/webkitpy/style/checkers/test_expectations.py:
3315          - We don't have access to a Host object, so using PortFactory() directly.
3316         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3317          - Remove unused variable.
3318         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3319          - Host isn't accessible here, so using PortFactory() directly, which
3320            although unfortunate is no worse than before.
3321         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3322          - Testing is much easier when you don't need to hack global state...
3323         * Scripts/webkitpy/tool/commands/expectations.py:
3324          - Use the port_factory on the tool.
3325         * Scripts/webkitpy/tool/commands/rebaseline.py:
3326          - ditto.
3327         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3328          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3329            the arguments in the right order.  Fixing that made it use a MockFileSystem
3330            (like it had been trying to), which then required us to actually populate
3331            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3332         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3333          - Get the port_factory from the tool.
3334         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3335          - Ditto.
3336         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3337          - Use a MockHost to get a mocked out Port object.
3338
3339 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3340
3341         [EFL] DRT: Allow choosing which backing store to use.
3342         https://bugs.webkit.org/show_bug.cgi?id=70532
3343
3344         Reviewed by Antonio Gomes.
3345
3346         This change makes it possible to change the backing store used by DRT
3347         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3348         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3349
3350         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3351         (DumpRenderTreeChrome::createView):
3352         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3353         (shouldUseSingleBackingStore):
3354         (chooseAndInitializeAppropriateSmartClass):
3355         (drtViewAdd):
3356         * DumpRenderTree/efl/DumpRenderTreeView.h:
3357
3358 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3359
3360         JS Test Harness: Remove more link tags
3361         https://bugs.webkit.org/show_bug.cgi?id=71339
3362
3363         Reviewed by Ojan Vafai.
3364
3365         * Scripts/make-new-script-test:
3366         (writeTestFile): Don't output <link>
3367
3368 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3369
3370         Reviewed by Martin Robinson.
3371
3372         [GTK] arguments passed to build-jsc are not taken into account
3373         https://bugs.webkit.org/show_bug.cgi?id=58333
3374
3375         * Scripts/build-jsc:
3376
3377 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3378
3379         [GTK] Show url of history items in a status bar in MiniBrowser
3380         https://bugs.webkit.org/show_bug.cgi?id=71474
3381
3382         Reviewed by Martin Robinson.
3383
3384         * MiniBrowser/gtk/BrowserWindow.c:
3385         (browserWindowSetStatusText): Set status text and show/hide the
3386         status label.
3387         (resetStatusText): Reset status text when history menu is hidden.
3388         (browserWindowHistoryItemSelected): Show url of currently selected
3389         history item.
3390         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3391         menu to reset the status text.
3392         (browserWindowConstructed): Use GtkOverlay if available to show
3393         status text.
3394
3395 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3396
3397         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3398         https://bugs.webkit.org/show_bug.cgi?id=71466
3399
3400         Reviewed by Martin Robinson.
3401
3402         * MiniBrowser/gtk/BrowserWindow.c:
3403         (browserWindowHistoryItemActivated): Go to selected back formard
3404         list item using webkit_web_view_go_to_back_forward_list_item()
3405         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3406         given GList of WebKitBackForwardListItems.
3407         (browserWindowUpdateNavigationActions): Enable/disable back and
3408         forward buttons depending on whether it's possible to go
3409         back/forward. Create a menu for back and forward toolbar buttons.
3410         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3411         (browserWindowConstructed): Connect to WebKitBackForwardList
3412         changed signal.
3413
3414 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3415
3416         [Qt] Remove Maemo specific code paths
3417         https://bugs.webkit.org/show_bug.cgi?id=71476
3418
3419         Reviewed by Kenneth Rohde Christiansen.
3420
3421         * QtTestBrowser/launcherwindow.cpp:
3422         (LauncherWindow::~LauncherWindow):
3423         (LauncherWindow::init):
3424         (LauncherWindow::showLinkHover):
3425         (LauncherWindow::selectElements):
3426         (LauncherWindow::showFPS):
3427         (LauncherWindow::updateFPS):
3428         * QtTestBrowser/launcherwindow.h:
3429         (WindowOptions::WindowOptions):
3430         * QtTestBrowser/locationedit.cpp:
3431         * QtTestBrowser/locationedit.h:
3432
3433 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3434
3435         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3436         https://bugs.webkit.org/show_bug.cgi?id=71461
3437
3438         Reviewed by Martin Robinson.
3439
3440         * MiniBrowser/gtk/BrowserWindow.c:
3441         (resetEntryProgress): Reset the entry progress after a while when
3442         load has been completed.
3443         (webViewLoadProgressChanged): Update location entry progress.
3444         (browserWindowConstructed): Connect to WebView
3445         notify::estimated-load-progress signal.
3446
3447 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3448
3449         [GTK] Remove WebKit2 C API from MiniBrowser
3450         https://bugs.webkit.org/show_bug.cgi?id=71459
3451
3452         Reviewed by Martin Robinson.
3453
3454         Use the GTK+ API instead to add minimum functionality. The other
3455         features will be ported to GTK+ API in following patches.
3456
3457         * MiniBrowser/gtk/BrowserWindow.c:
3458         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3459         (goBackCallback): Use webkit_web_view_go_back().
3460         (goForwardCallback): Use webkit_web_view_go_forward().
3461         (webViewURIChanged): Update location entry with current uri using
3462         webkit_web_view_get_uri().
3463         (browserWindowFinalize):
3464         (browserWindowGetProperty):
3465         (browserWindowSetProperty):
3466         (browser_window_init):
3467         (browserWindowConstructed): Connect to notify::uri signal of
3468         WebView to be notified when the URI changes.
3469         (browser_window_class_init):
3470         (browser_window_new): Use WebKitWebView.
3471         (browser_window_get_view): Use WebKitWebView
3472         * MiniBrowser/gtk/BrowserWindow.h:
3473         * MiniBrowser/gtk/GNUmakefile.am:
3474         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3475         * MiniBrowser/gtk/main.c:
3476         (loadURI): Use webkit_web_view_new().
3477         (main):
3478
3479 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3480
3481         [Qt] Unable to start MiniBrowser after run-webkit-tests
3482         https://bugs.webkit.org/show_bug.cgi?id=71469
3483
3484         Reviewed by Csaba Osztrogonác.
3485
3486         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3487         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3488         line arguments.
3489
3490 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3491
3492         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3493         https://bugs.webkit.org/show_bug.cgi?id=71445
3494
3495         Reviewed by Martin Robinson.
3496
3497         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3498         (initializeFonts): set directoriesDescription only when needed.
3499         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3500         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3501         refactored the font files loading code to avoid copy/pastes, ease
3502         maintenance and future font directories additions.
3503
3504 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3505
3506         [GTK] Remove GtkLauncher2
3507         https://bugs.webkit.org/show_bug.cgi?id=71449
3508
3509         Reviewed by Martin Robinson.
3510
3511         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3512         made sense when we wanted to implement the exactly same wk1 API
3513         for wk2. Now the code would require an ifdef for most the api, so
3514         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3515         GTK+ API.
3516
3517         * GNUmakefile.am:
3518         * GtkLauncher/main.c:
3519         (notifyProgressCb):
3520         (closeWebViewCb):
3521         (createBrowser):
3522         (addWebSettingsGroupToContext):
3523         (main):
3524
3525 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3526
3527         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3528         https://bugs.webkit.org/show_bug.cgi?id=71359
3529
3530         Reviewed by Martin Robinson.
3531
3532         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3533         (initializeFonts): Add the new font path for Debian fonts and
3534         refactored the font files loading code to avoid copy/pastes, ease
3535         maintenance and future font directories additions.
3536
3537 2011-11-02  Eric Seidel  <eric@webkit.org>
3538
3539         Move Mocks into _mock files near their implementations
3540         https://bugs.webkit.org/show_bug.cgi?id=71425
3541
3542         Reviewed by Adam Barth.
3543
3544         This entire change is splitting mocktool.py into separate _mock.py files
3545         and placing them next to their real implementations.
3546
3547         I also deleted MockPortFactory (since it was wrong) and was just hiding
3548         the fact that the "skipped-ports" command was broken (and has been for a long time).
3549         So I made MockHost use a real PortFactory (passed a MockHost) and changed
3550         the skipped-ports implementation to use modern PortFactory methods.
3551
3552         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3553         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
3554         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3555         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3556         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
3557         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3558         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3559         * Scripts/webkitpy/common/host.py:
3560         * Scripts/webkitpy/common/host_mock.py: Added.
3561         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
3562         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3563         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
3564         * Scripts/webkitpy/common/net/credentials_unittest.py:
3565         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3566         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3567         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3568         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3569         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3570         * Scripts/webkitpy/common/system/executive.py:
3571         * Scripts/webkitpy/common/system/executive_mock.py:
3572         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3573         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3574         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3575         * Scripts/webkitpy/common/system/workspace_unittest.py:
3576         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3577         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3578         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3579         * Scripts/webkitpy/layout_tests/port/__init__.py:
3580         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3581         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3582         * Scripts/webkitpy/layout_tests/port/factory.py:
3583         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3584         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3585         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3586         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3587         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3588         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3589         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3590         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3591         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3592         * Scripts/webkitpy/test/main.py:
3593         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3594         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3595         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3596         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3597         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3598         * Scripts/webkitpy/tool/mocktool.py:
3599         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3600
3601 2011-11-02  Dan Bernstein  <mitz@apple.com>
3602
3603         Fixed the build and removed another copy to ColorBits.ttf.
3604
3605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3606         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3607         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
3608
3609 2011-11-02  Dan Bernstein  <mitz@apple.com>
3610
3611         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
3612         https://bugs.webkit.org/show_bug.cgi?id=71424
3613
3614         Reviewed by Sam Weinig.
3615
3616         Removed the ColorBits font and the code to register it in the process
3617         running the tests. The font was only used by the aforementioned test,
3618         which is now being removed.
3619
3620         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
3621         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
3622         * DumpRenderTree/mac/DumpRenderTree.mm:
3623         (allowedFontFamilySet):
3624         (activateTestingFonts):
3625         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3626         (WTR::inititializeFontConfigSetting):
3627         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3628         (WTR::allowedFontFamilySet):
3629         (WTR::activateFonts):
3630
3631 2011-11-02  Dan Bernstein  <mitz@apple.com>
3632
3633         Fix an intermittent hang in RenderedImageFromDOMRange.
3634
3635         Reviewed by Anders Carlsson.
3636
3637         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3638         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
3639         immediately if there are no sources by passing a date in the distant past.
3640
3641 2011-11-02  Adam Roben  <aroben@apple.com>
3642
3643         Add git-add-reviewer
3644
3645         I've been using this script for a while to add reviewers to git commits in my local
3646         repository before pushing them to the Subversion repository. Basic usage is:
3647
3648         git-add-reviewer HEAD^ "Joe Schmoe"
3649         or
3650         git-add-reviewer -i trunk
3651
3652         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
3653         git commits
3654
3655         Reviewed by Sam Weinig.
3656
3657         * Scripts/git-add-reviewer: Added.
3658         (top level): Parse options, check that the working tree is clean, then run in either
3659         interactive or non-interactive mode as appropriate.
3660         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
3661         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
3662         editor exits, we check out the commit just before the earliest one we're modifying. Then
3663         for each commit, we check it out, update the reviewer, and amend the commit to contain the
3664         new reviewer. Finally, we update the branch that was originally checked out to point to the
3665         last amended commit.
3666         (nonInteractive): Check out the commit to modify, write the current commit message to the
3667         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
3668         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
3669         a usage message and exit.
3670         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
3671         and index are clean.
3672         (fail): Print out the specified error message, if any, and return false. This function is
3673         used as a return value in various error cases throughout the script.
3674         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
3675         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
3676         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
3677         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
3678
3679         (addReviewerToChangeLog):
3680         (addReviewerToCommitMessage):
3681         These just call through to addReviewerToFile.
3682
3683         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
3684         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
3685         temp file, then move the temp file over the original file and stage it for the next commit.
3686         (head): Returns the name of the currently-checked-out branch.
3687         (isAncestor): Returns true if the first commit is an ancestor of the second.
3688         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
3689         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
3690         (resetToCommit): Checks out the given commit, throwing away any local changes.
3691         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
3692         the specified file.
3693         (rebaseOntoHead): Rebases the specified branch onto HEAD.
3694         (checkout): Checks out the given commit.
3695         (getConfigValue): Reads the specified config variable from git-config.
3696
3697 2011-11-02  Dean Jackson  <dino@apple.com>
3698
3699         Add ENABLE_CSS_SHADERS flag
3700         https://bugs.webkit.org/show_bug.cgi?id=71394
3701
3702         Reviewed by Sam Weinig.
3703
3704         * Scripts/build-webkit:
3705
3706 2011-10-31  Eric Seidel  <eric@webkit.org>
3707
3708         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
3709         https://bugs.webkit.org/show_bug.cgi?id=71237
3710
3711         Reviewed by Adam Barth.
3712
3713         Calling the static version of factory.get() with proper mocking
3714         requires passsing an explict filesystem, executive, etc.
3715         So instead, we use a PortFactory instance and pass it a Host pointer.
3716         I had to add a MockHost since we'd not needed a non-host tool before now.
3717
3718         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3719         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3720         * Scripts/webkitpy/tool/commands/rebaseline.py:
3721         * Scripts/webkitpy/tool/mocktool.py:
3722
3723 2011-11-02  Anders Carlsson  <andersca@apple.com>
3724
3725         Update for the WebKit2 API fixage.
3726
3727         * MiniBrowser/mac/BrowserWindowController.m:
3728         (-[BrowserWindowController awakeFromNib]):
3729         * WebKitTestRunner/TestController.cpp:
3730         (WTR::TestController::initialize):
3731
3732 2011-11-02  Anders Carlsson  <andersca@apple.com>
3733
3734         Fix build.
3735
3736         Add new functions to the page loader client.
3737
3738         * MiniBrowser/mac/BrowserWindowController.m:
3739         (-[BrowserWindowController awakeFromNib]):
3740         * WebKitTestRunner/TestController.cpp:
3741         (WTR::TestController::initialize):
3742
3743 2011-11-02  Dan Bernstein  <mitz@apple.com>
3744
3745         <rdar://problem/10336700> Add API to get rendered text image without having to select it
3746         https://bugs.webkit.org/show_bug.cgi?id=71407
3747
3748         Reviewed by Simon Fraser.
3749
3750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3751         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
3752         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
3753         (TestWebKitAPI::TEST):
3754
3755 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
3756
3757         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
3758         https://bugs.webkit.org/show_bug.cgi?id=71351
3759
3760         Reviewed by Darin Adler.
3761
3762         Add the delimiter "/" at the end of the path instead of adding +1 when using
3763         the path.
3764
3765         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3766         (-[NSURL _drt_descriptionSuitableForTestResult]):
3767
3768 2011-11-02  Tom Sepez  <tsepez@chromium.org>
3769
3770         XSSAuditor is silent
3771         https://bugs.webkit.org/show_bug.cgi?id=70973
3772
3773         Reviewed by Adam Barth.
3774
3775         * DumpRenderTree/chromium/WebViewHost.cpp:
3776         (WebViewHost::didDetectXSS):
3777         * DumpRenderTree/chromium/WebViewHost.h:
3778         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3779         (-[FrameLoadDelegate webView:didDetectXSS:]):
3780         * MiniBrowser/mac/BrowserWindowController.m:
3781         (didDetectXSSForFrame):
3782         (-[BrowserWindowController awakeFromNib]):
3783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3784         (WTR::InjectedBundlePage::InjectedBundlePage):
3785         (WTR::InjectedBundlePage::didDetectXSSForFrame):
3786         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3787
3788 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3789
3790         [Qt] REGRESSION: 5 editing tests fail
3791         https://bugs.webkit.org/show_bug.cgi?id=71117
3792
3793         Reviewed by Andreas Kling.
3794
3795         Make sure that the view is properly focused, in order to get the
3796         didBeginEditing DRT calls.
3797
3798         This requires activating the window (the call will result in a FocusIn
3799         event to the window as well as setting QGuiApplication::focusWindow())
3800         as well as enabling the focus on the view item. The signature of
3801         setFocus has changed to take a boolean.
3802
3803         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3804         (WTR::WrapperWindow::handleStatusChanged):
3805
3806 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
3807
3808         [chromium] Add per-script font preferences support in overridePreference
3809         https://bugs.webkit.org/show_bug.cgi?id=71110
3810
3811         This allows a layout test to do something like:
3812
3813         // Set standard font for Arabic to Ahem.
3814         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
3815
3816         This should make writing a layout test for per-script fonts easier.
3817
3818         This change only affects the Chromium DumpRenderTree, but the other
3819         platforms should probably also have a similar change eventually.
3820
3821         Reviewed by Tony Chang.
3822
3823         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
3824         font preferences to overridePreference
3825         (LayoutTestController::cppVariantToWebStringArray):
3826         (setFontMap):
3827         (LayoutTestController::overridePreference):
3828         * DumpRenderTree/chromium/LayoutTestController.h:
3829         * DumpRenderTree/chromium/WebPreferences.cpp:
3830         (setStandardFontFamilyWrapper):
3831         (setFixedFontFamilyWrapper):
3832         (setSerifFontFamilyWrapper):
3833         (setSansSerifFontFamilyWrapper):
3834         (setCursiveFontFamilyWrapper):
3835         (setFantasyFontFamilyWrapper):
3836         (applyFontMap):
3837         (WebPreferences::applyTo):
3838         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
3839         preference members
3840         (WebPreferences::UScriptCodeHashTraits::emptyValue):
3841         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
3842         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
3843
3844 2011-11-02  Elliot Poger  <epoger@google.com>
3845
3846         until use_skia=1 by default on mac, default port should be chromium-cg-mac
3847         https://bugs.webkit.org/show_bug.cgi?id=71312
3848
3849         Reviewed by Adam Barth.
3850
3851         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3852         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3853         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3854
3855 2011-11-02  Stephen Chenney  <schenney@chromium.org>
3856
3857         printing layout test failures after r98634
3858         https://bugs.webkit.org/show_bug.cgi?id=71080
3859
3860         Reviewed by Kent Tamura
3861
3862         * DumpRenderTree/chromium/WebViewHost.cpp:
3863         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
3864         matches that for Skia.
3865
3866 2011-11-01  Sam Weinig  <sam@webkit.org>
3867
3868         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
3869         https://bugs.webkit.org/show_bug.cgi?id=71346
3870
3871         Reviewed by Dan Bernstein.
3872
3873         * Scripts/webkit-tools-completion.sh:
3874         Add "-o default" which allows for completing files in addition to the word list.
3875
3876 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3877
3878         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
3879         https://bugs.webkit.org/show_bug.cgi?id=71310
3880
3881         Reviewed by Kenneth Rohde Christiansen.
3882
3883         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
3884         define works in EventSendingController.idl
3885         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
3886         handlers.
3887         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
3888         required by tests.
3889         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
3890         ui process.
3891         (WTR::EventSendingController::addTouchPoint):
3892         (WTR::EventSendingController::updateTouchPoint):
3893         (WTR::EventSendingController::setTouchModifier):
3894         (WTR::EventSendingController::touchStart):
3895         (WTR::EventSendingController::touchMove):
3896         (WTR::EventSendingController::touchEnd):
3897         (WTR::EventSendingController::clearTouchPoints):
3898         (WTR::EventSendingController::releaseTouchPoint):
3899         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3900         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
3901         defines.
3902         * WebKitTestRunner/TestController.cpp:
3903         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
3904         touch messages to the EventSenderProxy.
3905         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
3906         (WTR::EventSenderProxy::EventSenderProxy):
3907         (WTR::EventSenderProxy::addTouchPoint):
3908         (WTR::EventSenderProxy::updateTouchPoint):
3909         (WTR::EventSenderProxy::setTouchModifier):
3910         (WTR::EventSenderProxy::touchStart):
3911         (WTR::EventSenderProxy::touchMove):
3912         (WTR::EventSenderProxy::touchEnd):
3913         (WTR::EventSenderProxy::clearTouchPoints):
3914         (WTR::EventSenderProxy::releaseTouchPoint):
3915         (WTR::EventSenderProxy::sendTouchEvent):
3916         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
3917
3918 2011-11-01  Sam Weinig  <sam@webkit.org>
3919
3920         resolve-ChangeLogs --help should be faster.
3921
3922         Reviewed by Adam Roben.
3923
3924         * Scripts/resolve-ChangeLogs:
3925         (usageAndExit):
3926         Add a call to usageAndExit() before doing work to find unmerged changelogs
3927         if --help or something illegal is provided on the command line.
3928
3929 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
3930
3931         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
3932         https://bugs.webkit.org/show_bug.cgi?id=71342
3933
3934         Reviewed by Darin Adler.
3935
3936         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
3937         [NSString substringFromIndex:] with an index out of the string range.
3938
3939         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
3940         from the root of the disk.
3941         The problem was hidden because the exception are catched when calling the delegate.
3942
3943         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
3944         in a subdirectory of the main frame.
3945
3946         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3947         (-[NSURL _drt_descriptionSuitableForTestResult]):
3948
3949 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
3950
3951         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
3952         https://bugs.webkit.org/show_bug.cgi?id=71318
3953
3954         Reviewed by James Robinson.
3955         
3956         Fixed a typo for --enable-hardware-gpu flag.
3957
3958         * Scripts/webkitpy/layout_tests/port/chromium.py:
3959
3960 2011-11-01  Elliot Poger  <epoger@google.com>
3961
3962         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
3963         https://bugs.webkit.org/show_bug.cgi?id=71286
3964
3965         Reviewed by Stephen White.
3966
3967         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3968
3969 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
3970
3971         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
3972         https://bugs.webkit.org/show_bug.cgi?id=71299
3973
3974         Reviewed by Andreas Kling.
3975
3976         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
3977         build to enable WebCoreTestSupport::injectInternalsObject.
3978         (WTR::InjectedBundlePage::didClearWindowForFrame):
3979         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
3980
3981 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3982
3983         [Qt] Merge common desktop and touch view APIs under a base class.
3984         https://bugs.webkit.org/show_bug.cgi?id=71280
3985
3986         Reviewed by Andreas Kling.
3987
3988         Remove unneded forwarding logic for TouchWebView since those properties are
3989         now in the view just as the desktop web view.
3990
3991         * MiniBrowser/qt/qml/TouchView.qml:
3992
3993 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3994
3995         check-webkit-style: Allow names starting with "_q_".
3996         https://bugs.webkit.org/show_bug.cgi?id=70625
3997
3998         Reviewed by Tor Arne Vestbø.
3999
4000         Used by the Qt port as the standard prefix for private slots.
4001
4002         * Scripts/webkitpy/style/checkers/cpp.py:
4003         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4004
4005 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
4006
4007         [Qt][WK2] Fix valgrind error about uninitialized variable
4008         https://bugs.webkit.org/show_bug.cgi?id=71273
4009
4010         Reviewed by Kenneth Christiansen.
4011
4012         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4013         (MiniBrowserApplication::notify): Initialize isPrimary.
4014
4015 2011-10-31  Adam Roben  <aroben@apple.com>
4016
4017         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
4018
4019         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
4020         leaky builds
4021
4022         Reviewed by Anders Carlsson.
4023
4024         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
4025         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
4026         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
4027         total of N bytes!").
4028
4029 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
4030
4031         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
4032         https://bugs.webkit.org/show_bug.cgi?id=71228
4033
4034         Reviewed by Antonio Gomes.
4035
4036         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4037         (DumpRenderTreeChrome::createNewWindow):
4038         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4039
4040 2011-10-31  Eric Seidel  <eric@webkit.org>
4041
4042         webkitpy tests depend too much on the user's environment
4043         https://bugs.webkit.org/show_bug.cgi?id=71234
4044
4045         Reviewed by Dirk Pranke.
4046
4047         This change just makes a bunch of our older tests use
4048         more modern mocking to avoid trying to launch processes
4049         or read from the user's filesystem during unittesting.
4050
4051         I found many of these by adding an assert in Executive.run_command
4052         that we were not unittesting.  I can't add that assert always
4053         as there are some valid uses of Executive during unittesting.
4054         Once I fix more of these, I may find a way to add such an assert conditionally.
4055
4056         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4057         * Scripts/webkitpy/common/net/credentials_unittest.py:
4058         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4059         * Scripts/webkitpy/layout_tests/port/base.py:
4060         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4061
4062 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4063
4064         [Qt] MiniBrowser doesn't resize as the size is always overridden
4065         https://bugs.webkit.org/show_bug.cgi?id=71212
4066
4067         Reviewed by Simon Hausmann.
4068
4069         Remove call overriden the size.
4070
4071         * MiniBrowser/qt/main.cpp:
4072         (main):
4073
4074 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
4075
4076         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
4077         http://trac.webkit.org/changeset/98819
4078         http://trac.webkit.org/changeset/98823
4079         http://trac.webkit.org/changeset/98825
4080         http://trac.webkit.org/changeset/98830
4081         https://bugs.webkit.org/show_bug.cgi?id=71199
4082
4083         Broke Chromium Windows bot (Requested by rniwa on #webkit).
4084
4085         * Scripts/webkitpy/layout_tests/port/base.py:
4086         * Scripts/webkitpy/layout_tests/port/chromium.py:
4087         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4088         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4089         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4090         * Scripts/webkitpy/layout_tests/port/efl.py:
4091         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4092         * Scripts/webkitpy/layout_tests/port/mac.py:
4093         * Scripts/webkitpy/layout_tests/port/qt.py:
4094         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4095         * Scripts/webkitpy/layout_tests/port/webkit.py:
4096         * Scripts/webkitpy/layout_tests/port/win.py:
4097
4098 2011-10-30  Eric Seidel  <eric@webkit.org>
4099
4100         new-run-webkit-tests is locale dependent
4101         https://bugs.webkit.org/show_bug.cgi?id=68691
4102
4103         Unreviewed.
4104
4105         This is a temporary hack until someone from the cr-win port
4106         can take a look and determine which environment variable
4107         lighttpd is missing.
4108
4109         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4110
4111 2011-10-30  Eric Seidel  <eric@webkit.org>
4112
4113         new-run-webkit-tests is locale dependent
4114         https://bugs.webkit.org/show_bug.cgi?id=68691
4115
4116         Unreviewed.  I would have preferred to have this reviewed,
4117         but relevant reviewers are asleep and bots are broken.
4118
4119         This was a regression from moving to a clean environment.
4120         ChromiumWin (and possibly other ports), need the "PATH"
4121         environment copied over.  This wasn't caught in my testing
4122         because although we had unittests to cover this, they
4123         weren't being run on anything but windows.  The vast majority
4124         of this change is just fixing the unittests to use our
4125         modern MockFileSystem/MockUser/MockExecutive so they can
4126         be run on any system (and removing the platform checks from
4127         the unittests so they are run everywhere).
4128
4129         The actual fix is the single line "PATH" string added to base.py.
4130         The rest of this change is just fixing the Chromium port unittests
4131         to run on all systems (including changing the Chromium port to
4132         use FileSystem.path_to_module instead of __file__).
4133
4134         * Scripts/webkitpy/layout_tests/port/base.py:
4135         * Scripts/webkitpy/layout_tests/port/chromium.py:
4136         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4137         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4138         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4139         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4140
4141 2011-10-29  Eric Seidel  <eric@webkit.org>
4142
4143         new-run-webkit-tests is locale dependent
4144         https://bugs.webkit.org/show_bug.cgi?id=68691
4145
4146         Unreviewed.
4147
4148         Fix the Qt port and unittest the function so we don't break it again.
4149
4150         * Scripts/webkitpy/layout_tests/port/qt.py:
4151         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4152
4153 2011-10-29  Eric Seidel  <eric@webkit.org>
4154
4155         new-run-webkit-tests is locale dependent
4156         https://bugs.webkit.org/show_bug.cgi?id=68691
4157
4158         Reviewed by Adam Barth.
4159
4160         Make NRWT use a clean environment just like ORWT did.
4161         I've manually validated that NRWT now copies over
4162         the same environment variables that ORWT did.
4163         This new code is exercised by existing setup_environ_for_server tests.
4164
4165         * Scripts/webkitpy/layout_tests/port/base.py:
4166         * Scripts/webkitpy/layout_tests/port/efl.py:
4167         * Scripts/webkitpy/layout_tests/port/mac.py:
4168         * Scripts/webkitpy/layout_tests/port/qt.py:
4169         * Scripts/webkitpy/layout_tests/port/webkit.py:
4170         * Scripts/webkitpy/layout_tests/port/win.py:
4171
4172 2011-10-29  Eric Seidel  <eric@webkit.org>
4173
4174         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
4175         https://bugs.webkit.org/show_bug.cgi?id=34984
4176
4177         Reviewed by Adam Barth.
4178
4179         Move run-webkit-tests from using a white-list of supported NRWT ports
4180         to a blacklist of ports requiring ORWT.
4181
4182         I've also added the ability to opt-in to parallel testing on a per-port basis.
4183
4184         With these changes I'm going to officially declare this bug dead and
4185         work on remaining polish issues and individual developer complaints.
4186
4187         * Scripts/run-webkit-tests:
4188         (useNewRunWebKitTests):
4189         (platformIsReadyForParallelTesting):
4190
4191 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4192
4193         Unreviewed, rolling out r98780.
4194         http://trac.webkit.org/changeset/98780
4195         https://bugs.webkit.org/show_bug.cgi?id=71173
4196
4197         Broke Qt bots (Requested by rniwa on #webkit).
4198
4199         * Scripts/run-webkit-tests:
4200         (useNewRunWebKitTests):
4201
4202 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
4203
4204         webkit.py gdb visualizer is broken after change to StringImpl
4205         https://bugs.webkit.org/show_bug.cgi?id=71154
4206
4207         Reviewed by Tony Chang.
4208
4209         r98624 changed StringImpl m_data to m_data32. This changes updates
4210         webkit.py to match.
4211
4212         * gdb/webkit.py:
4213
4214 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
4215
4216         Fix typo in check-for-inappropriate-objc-class-names
4217         https://bugs.webkit.org/show_bug.cgi?id=71144
4218
4219         Reviewed by Dan Bernstein.
4220
4221         * Scripts/check-for-inappropriate-objc-class-names:
4222
4223 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
4224
4225         Add support for sending scroll-update events from EventSender.
4226         https://bugs.webkit.org/show_bug.cgi?id=66272
4227
4228         Reviewed by Adam Barth.
4229
4230         * DumpRenderTree/chromium/EventSender.cpp:
4231         (EventSender::EventSender):
4232         (EventSender::reset):
4233         (EventSender::gestureScrollUpdate):
4234         (EventSender::gestureEvent):
4235         * DumpRenderTree/chromium/EventSender.h:
4236
4237 2011-10-28  Eric Seidel  <eric@webkit.org>
4238
4239         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
4240         https://bugs.webkit.org/show_bug.cgi?id=34984
4241
4242         Reviewed by Adam Barth.
4243
4244         Move run-webkit-tests from using a white-list of supported NRWT ports
4245         to a blacklist of ports requiring ORWT.
4246
4247         I've also added the ability to opt-in to parallel testing on a per-port basis.
4248
4249         With these changes I'm going to officially declare this bug dead and
4250         work on remaining polish issues and individual developer complaints.
4251
4252         * Scripts/run-webkit-tests:
4253         (useNewRunWebKitTests):
4254         (platformIsReadyForParallelTesting):
4255
4256 2011-10-28  Eric Seidel  <eric@webkit.org>
4257
4258         NRWT crashes when parsing leaks output due to UTF-8 decoding error
4259         https://bugs.webkit.org/show_bug.cgi?id=71112
4260
4261         Reviewed by Adam Barth.
4262
4263         Use read_binary_file instead of read_text_file and add a test
4264         case with some non-utf8 data to make sure we don't break this in the future.
4265
4266         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
4267         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
4268
4269 2011-10-28  David Levin  <levin@chromium.org>
4270
4271         watchlist should not CC the bug reporter
4272         https://bugs.webkit.org/show_bug.cgi?id=71079
4273
4274         Reviewed by Adam Barth.
4275
4276         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)