1 2014-07-02 Carlos Alberto Lopez Perez <clopez@igalia.com>
3 [GTK] Unreviewed gardening.
5 * Scripts/run-gtk-tests:
6 (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
8 2014-07-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
10 Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
11 https://bugs.webkit.org/show_bug.cgi?id=134581
13 Reviewed by Tim Horton.
15 Should be removed unused EFL bot info.
17 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
18 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
20 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
22 * TestResultServer/static-dashboards/builders.jsonp:
23 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
26 2014-07-02 Alex Christensen <achristensen@webkit.org>
28 Unreviewed. Moved self to reviewers list.
30 * Scripts/webkitpy/common/config/contributors.json:
31 Moved self to reviewers list, added WebGL to expertise.
33 2014-07-02 Carlos Garcia Campos <cgarcia@igalia.com>
35 [GTK] Make dist only works when run from the source directory
36 https://bugs.webkit.org/show_bug.cgi?id=134543
38 Reviewed by Martin Robinson.
40 Since the paths in the manifest are relative to the source dir,
41 and the script expects the current working directory to be the
42 source directory, resolve all passed in relative paths while
43 parsing the arguments and then change the current working
48 2014-07-02 Carlos Garcia Campos <cgarcia@igalia.com>
50 [GTK] make dist is broken
51 https://bugs.webkit.org/show_bug.cgi?id=134542
53 Reviewed by Martin Robinson.
55 * gtk/make-dist.py: Rename command line options to match what cmake uses.
56 * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
58 2014-07-02 Carlos Garcia Campos <cgarcia@igalia.com>
60 [GTK] WebKitWebView::create should receive information about the navigation action
61 https://bugs.webkit.org/show_bug.cgi?id=133680
63 Reviewed by Martin Robinson.
65 Add unit test to check the WebKitNavigationAction passed to
66 WebKitWebView::create callback.
68 * MiniBrowser/gtk/BrowserWindow.c:
69 (webViewCreate): Add WebKitNavigationAction parameter.
70 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
71 * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
72 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
73 (testWebViewCreateNavigationData):
75 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
78 2014-07-02 Carlos Garcia Campos <cgarcia@igalia.com>
80 [GTK] Do not add forward declaration of class struct for interfaces
81 https://bugs.webkit.org/show_bug.cgi?id=134297
83 Reviewed by Martin Robinson.
85 Add Iface symbol to documentation instead of Class for interfaces.
88 (WebKitDOMDocGeneratorSections.write_section):
90 2014-07-01 Carlos Garcia Campos <cgarcia@igalia.com>
92 [GTK] XPathNSResolver should be exposed as an interface instead of as a class
93 https://bugs.webkit.org/show_bug.cgi?id=134028
95 Reviewed by Gustavo Noronha Silva.
97 Add unit tests to check WebKitDOMXPathNSResolver API when using the
98 native one and a user provided one.
100 * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
101 to the list of GTK+ public API exceptions.
102 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
103 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
104 (webkitXPathNSResolverLookupNamespaceURI):
105 (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
106 (webkit_xpath_ns_resolver_init):
107 (webkit_xpath_ns_resolver_class_init):
108 (WebKitDOMXPathNSResolverTest::create):
109 (WebKitDOMXPathNSResolverTest::webPageFromArgs):
110 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
111 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
112 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
113 (WebKitDOMXPathNSResolverTest::runTest):
115 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
117 (testWebKitDOMXPathNSResolverNative):
118 (testWebKitDOMXPathNSResolverCustom):
123 (WebKitDOMDocGeneratorSections.write_section): Add
124 WebKitDOMXPathNSResolver to the list of interfaces.
126 2014-07-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
128 Fix build break on EFL and GTK ports since r170683
129 https://bugs.webkit.org/show_bug.cgi?id=134536
131 Unreviewed, build fix.
133 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
135 2014-07-01 Sam Weinig <sam@webkit.org>
137 [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
138 <rdar://problem/17523159>
139 https://bugs.webkit.org/show_bug.cgi?id=134496
141 Reviewed by Beth Dakin.
143 * MiniBrowser/mac/BrowserWindowController.m:
144 (-[BrowserWindowController windowDidLoad]):
145 Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
147 2014-07-01 Zan Dobersek <zdobersek@igalia.com>
149 [CMake] Add necessary support for building for the Wayland target
150 https://bugs.webkit.org/show_bug.cgi?id=134160
152 Reviewed by Darin Adler.
154 * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
155 the X11 windowing target is enabled.
157 2014-07-01 Chris Fleizach <cfleizach@apple.com>
159 AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
160 https://bugs.webkit.org/show_bug.cgi?id=134492
162 Reviewed by Andreas Kling.
164 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
165 (AccessibilityUIElement::isIndeterminate):
166 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
167 (WTR::AccessibilityUIElement::isIndeterminate):
169 2014-07-01 Daniel Bates <dabates@apple.com>
171 Remove unnecessary calls to std::move()
172 https://bugs.webkit.org/show_bug.cgi?id=134493
174 Reviewed by Anders Carlsson.
176 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
177 (TestWebKitAPI::TEST):
178 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
179 (TestWebKitAPI::TEST):
181 2014-07-01 Pratik Solanki <psolanki@apple.com>
183 Unreviewed. Adding myself to the reviewers list to make commit bot happy.
185 * Scripts/webkitpy/common/config/contributors.json:
187 2014-07-01 Youenn Fablet <youenn.fablet@crf.canon.fr>
189 webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
190 https://bugs.webkit.org/show_bug.cgi?id=40095
192 Reviewed by Csaba Osztrogonác.
194 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
195 (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
197 (Bugzilla.bug_id_for_attachment_id): ditto.
199 2014-07-01 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
201 [webkitpy] Refactor pluralizer in grammar.py
202 https://bugs.webkit.org/show_bug.cgi?id=133067
204 Reviewed by Csaba Osztrogonác.
206 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
207 (LayoutTestRunner.run_tests):
208 * Scripts/webkitpy/layout_tests/controllers/manager.py:
210 * Scripts/webkitpy/layout_tests/views/printing.py:
211 (Printer.print_found):
212 (Printer.print_workers_and_shards):
213 (Printer._print_one_line_summary):
214 * Scripts/webkitpy/test/printer.py:
215 (Printer.print_result):
216 * Scripts/webkitpy/tool/bot/feeders.py:
218 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
219 (FlakyTestReporter._lookup_bug_for_flaky_test):
220 * Scripts/webkitpy/tool/bot/irc_command.py:
221 (Rollout._check_diff_failure):
222 * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
223 (IRCCommandTest.test_rollout):
224 * Scripts/webkitpy/tool/commands/download.py:
225 (AbstractPatchProcessingCommand._process_patch.execute):
226 (ProcessBugsMixin._fetch_list_of_patches_to_process):
227 (ProcessURLsMixin._fetch_list_of_patches_to_process):
228 * Scripts/webkitpy/tool/commands/queries.py:
230 * Scripts/webkitpy/tool/commands/suggestnominations.py:
231 (SuggestNominations._print_nominations):
232 (SuggestNominations._print_counts):
233 * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
237 * Scripts/webkitpy/tool/commands/upload.py:
238 (PostCommits.execute):
239 * Scripts/webkitpy/tool/grammar.py:
241 * Scripts/webkitpy/tool/grammar_unittest.py:
242 (GrammarTest.test_join_with_separators):
244 (GrammarTest.test_plural):
245 (GrammarTest.test_pluralize):
246 * Scripts/webkitpy/tool/multicommandtool.py:
247 (Command.check_arguments_and_execute):
248 * Scripts/webkitpy/tool/steps/obsoletepatches.py:
249 (ObsoletePatches.run):
250 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
251 (PrepareChangeLogForRevert._message_for_revert):
253 2014-06-30 Myles C. Maxfield <mmaxfield@apple.com>
255 [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
256 https://bugs.webkit.org/show_bug.cgi?id=134133
258 Reviewed by Simon Fraser.
260 Replace it with CTFontManagerRegisterGraphicsFont
262 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
263 * DumpRenderTree/mac/DumpRenderTree.mm:
266 2014-06-30 Michael Saboff <msaboff@apple.com>
268 Add option to run-jsc-stress-testes to filter out tests that use large heaps
269 https://bugs.webkit.org/show_bug.cgi?id=134458
271 Reviewed by Filip Pizlo.
273 Added new --memory-limited to filter out tests that have large heap usage.
274 Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
276 * Scripts/run-jsc-stress-tests:
278 2014-06-30 Myles C. Maxfield <mmaxfield@apple.com>
280 DRT in iOS sim crashes while loading fonts
281 https://bugs.webkit.org/show_bug.cgi?id=134451
283 Reviewed by Geoffrey Garen.
285 The magic linker symbols had the same name, and were therefore being unified
286 to a single font file. Then, adding the same file twice was failing.
288 * DumpRenderTree/mac/DumpRenderTree.mm:
291 2014-06-30 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
293 Remove Qt cruft from webkitpy
294 https://bugs.webkit.org/show_bug.cgi?id=134445
296 Reviewed by Csaba Osztrogonác.
298 * Scripts/webkitpy/common/config/ports.py:
299 (DeprecatedPort.port):
301 (QtPort.build_webkit_command): Deleted.
302 (QtPort.run_webkit_tests_command): Deleted.
303 (QtWK2Port): Deleted.
304 (QtWK2Port.build_webkit_command): Deleted.
305 (QtWK2Port.run_webkit_tests_command): Deleted.
306 * Scripts/webkitpy/common/config/ports_unittest.py:
307 (DeprecatedPortTest): Deleted.
308 (DeprecatedPortTest.test_qt_port): Deleted.
309 (DeprecatedPortTest.test_qt_wk2_port): Deleted.
311 2014-06-29 Yoav Weiss <yoav@yoav.ws>
313 Add support for HTMLImageElement's sizes attribute
314 https://bugs.webkit.org/show_bug.cgi?id=133620
316 Reviewed by Dean Jackson.
318 Added an ENABLE_PICTURE_SIZES compile flag.
320 * Scripts/webkitperl/FeatureList.pm:
322 2014-06-27 Tim Horton <timothy_horton@apple.com>
324 check-webkit-style should check the order of #imports as well as #includes
325 https://bugs.webkit.org/show_bug.cgi?id=134428
327 Reviewed by Dan Bernstein.
329 * Scripts/webkitpy/style/checkers/cpp.py:
330 Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
332 2014-06-27 Michał Pakuła vel Rutka <m.pakula@samsung.com>
334 [EFL] Remove efl-wk2 from baseline search path
335 https://bugs.webkit.org/show_bug.cgi?id=134391
337 Reviewed by Gyuyoung Kim.
339 As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
340 are merged efl-wk2 search path should be removed.
342 * Scripts/webkitpy/port/base.py:
343 (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
344 * Scripts/webkitpy/port/efl.py:
345 (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
346 (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
347 * Scripts/webkitpy/port/port_testcase.py:
348 (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
349 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
350 (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
351 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
352 (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
354 2014-06-26 Dan Bernstein <mitz@apple.com>
356 prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
357 https://bugs.webkit.org/show_bug.cgi?id=134387
359 Reviewed by Tim Horton.
361 * Scripts/prepare-ChangeLog:
362 (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
364 2014-06-26 Dan Bernstein <mitz@apple.com>
366 prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
367 https://bugs.webkit.org/show_bug.cgi?id=134383
369 Reviewed by Tim Horton.
371 * Scripts/prepare-ChangeLog:
372 (method_decl_to_selector): Strip out the return type and parameter types before splitting at
375 2014-06-26 Brady Eidson <beidson@apple.com>
377 MiniBrowser should support a preference to override the default URL
378 https://bugs.webkit.org/show_bug.cgi?id=134373
380 Reviewed by Darin Adler.
382 * MiniBrowser/mac/AppDelegate.m:
383 (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
384 overriding the default URL, and use it if there is.
386 2014-06-26 Brent Fulgham <bfulgham@apple.com>
388 [Win] Fix potential buffer overrun in DLLLauncher
389 https://bugs.webkit.org/show_bug.cgi?id=134351
390 <rdar://problem/17469185>
392 Reviewed by Darin Adler.
394 * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
395 in end-of-buffer calculation.
397 2014-06-26 Tamas Gergely <tgergely.u-szeged@partner.samsung.com>
399 [EFL] Missing dependency between freetype6 and fontconfig libs.
400 https://bugs.webkit.org/show_bug.cgi?id=134190
402 Reviewed by Gyuyoung Kim.
404 The external dependencies contain the freetype6 and the fontconfig libs.
405 The fontconfig lib requires freetype, but the dependency is not set in
406 the efl/jhbuild.modules file. So, during building the external libs,
407 fontconfig uses the freetype package of the system, while WebKit
408 binaries will use freetype from the WebKitBuild/Dependency directory.
409 There are more similar dependencies that were not indicated in the
410 jhbuild.modules file.
412 * efl/jhbuild.modules:
413 Added dependencies between libs.
415 2014-06-25 Brent Fulgham <bfulgham@apple.com>
417 [Win] Expose Cache Information to WinLauncher
418 https://bugs.webkit.org/show_bug.cgi?id=134318
420 Reviewed by Dean Jackson.
422 * WinLauncher/Common.cpp: Update for new dialog.
423 * WinLauncher/WinLauncher.cpp: Add support for WebCache
424 and WebCoreStatistics.
425 * WinLauncher/WinLauncher.h:
426 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
427 Update for new Cache Dialog.
428 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
430 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
433 2014-06-26 Brent Fulgham <bfulgham@apple.com>
435 [Win] Unreviewed gardening. Use consistent line-endings in file.
437 * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
440 2014-06-25 László Langó <llango.u-szeged@partner.samsung.com>
442 [JavaScriptCore] Make build-jsc output format better.
443 https://bugs.webkit.org/show_bug.cgi?id=133547
445 Reviewed by Ryosuke Niwa.
447 * Scripts/build-jsc: Emit built time information on successful builds.
449 * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
450 (cMakeArgsFromFeatures):
451 (formatBuildTime): Deleted.
452 * Scripts/webkitdirs.pm:
455 2014-06-25 Chris Fleizach <cfleizach@apple.com>
457 Add an undo group for each dictated utterance in WebKit
458 https://bugs.webkit.org/show_bug.cgi?id=134086
460 Reviewed by Enrica Casucci.
462 Create a method for creating attributed strings with the undo insertion marker.
464 * DumpRenderTree/mac/TextInputController.m:
465 (+[TextInputController isSelectorExcludedFromWebScript:]):
466 (+[TextInputController webScriptNameForSelector:]):
467 (-[TextInputController stringWithUndoGroupingInsertion:]):
469 2014-06-25 Michael Saboff <msaboff@apple.com>
471 Provide javascript aware backtrace script for lldb
472 https://bugs.webkit.org/show_bug.cgi?id=134276
474 Reviewed by Jer Noble.
476 * lldb/lldb_webkit.py:
477 (__lldb_init_module):
478 (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
480 2014-06-25 Michał Pakuła vel Rutka <m.pakula@samsung.com>
482 REGRESSION (r170426) Broke two python tests
483 https://bugs.webkit.org/show_bug.cgi?id=134299
485 Reviewed by Csaba Osztrogonác.
487 * Scripts/webkitpy/port/efl.py:
488 (EflPort._search_paths): Added search path for efl-wk2.
490 2014-06-25 Michał Pakuła vel Rutka <m.pakula@samsung.com>
492 [EFL] Remove WebKit1 related code from scripts
493 https://bugs.webkit.org/show_bug.cgi?id=134195
495 Reviewed by Laszlo Gombos.
497 After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree,
498 EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
500 * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
501 * Scripts/webkitdirs.pm:
502 (builtDylibPathForName): Remove reference to libewebkit.so
503 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
504 (_set_up_derived_options): Script runs WKTR by default.
505 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
506 (PerfTestsRunner.__init__): Ditto.
507 * Scripts/webkitpy/port/efl.py:
508 (EflPort._search_paths): Remove efl-wk2 from baseline search path.
509 (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
511 2014-06-25 Laszlo Gombos <l.gombos@samsung.com>
513 Remove build guard for progress element
514 https://bugs.webkit.org/show_bug.cgi?id=134292
516 Reviewed by Benjamin Poulain.
518 * Scripts/webkitperl/FeatureList.pm:
520 2014-06-24 Tomas Popela <tpopela@redhat.com>
522 [GTK] Some of DOM bindings macros are misnamed
523 https://bugs.webkit.org/show_bug.cgi?id=121543
525 Reviewed by Carlos Garcia Campos.
527 As we are using WebKitDOM as a namespace we should unify all type macros
528 to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
529 more exceptions to decamelize function in GObject bindings generator
530 to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
532 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
534 (WebKitDOMDocGeneratorSections._dom_class_decamelize):
535 (WebKitDOMDocGeneratorSections.write_section):
537 2014-06-24 Frédéric Wang <fred.wang@free.fr>
539 [EFL] Install Latin Modern Math on the bots
540 https://bugs.webkit.org/show_bug.cgi?id=134153
542 Reviewed by Gyuyoung Kim.
544 * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
546 2014-06-24 Frédéric Wang <fred.wang@free.fr>
548 [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
549 https://bugs.webkit.org/show_bug.cgi?id=134153
551 Reviewed by Martin Robinson.
553 * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
554 * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
556 2014-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
558 Unreviewed, update my speciality.
560 * Scripts/webkitpy/common/config/contributors.json:
562 2014-06-24 Brent Fulgham <bfulgham@apple.com>
564 [Win] Clean up and refactor WinLauncher
565 https://bugs.webkit.org/show_bug.cgi?id=134209
567 Reviewed by Tim Thorton.
569 Relanding r170339 and r170340 with correct WinLauncher.h file.
571 * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
578 (shouldUseFullDesktop): Deleted.
579 (SimpleEventListener::SimpleEventListener): Deleted.
580 (SimpleEventListener::handleEvent): Deleted.
581 (WinLauncherWebHost::updateAddressBar): Deleted.
582 (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
583 (WinLauncherWebHost::QueryInterface): Deleted.
584 (WinLauncherWebHost::AddRef): Deleted.
585 (WinLauncherWebHost::Release): Deleted.
586 (updateMenuItemForHistoryItem): Deleted.
587 (showLastVisitedSites): Deleted.
588 (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
589 (resizeSubViews): Deleted.
590 (setToDefaultPreferences): Deleted.
592 (MyRegisterClass): Deleted.
593 (LaunchInspector): Deleted.
594 (NavigateForwardOrBackward): Deleted.
595 (NavigateToHistory): Deleted.
596 * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
597 (DOMEventListener::Release):
598 (WebScriptObject::WebScriptObject): Deleted.
599 (WebScriptObject::~WebScriptObject): Deleted.
600 (WebScriptObject::throwException): Deleted.
601 (WebScriptObject::callWebScriptMethod): Deleted.
602 (WebScriptObject::evaluateWebScript): Deleted.
603 (WebScriptObject::removeWebScriptKey): Deleted.
604 (WebScriptObject::stringRepresentation): Deleted.
605 (WebScriptObject::webScriptValueAtIndex): Deleted.
606 (WebScriptObject::setWebScriptValueAtIndex): Deleted.
607 (WebScriptObject::setException): Deleted.
608 (DOMEventListener::throwException): Deleted.
609 (DOMEventListener::callWebScriptMethod): Deleted.
610 (DOMEventListener::evaluateWebScript): Deleted.
611 (DOMEventListener::removeWebScriptKey): Deleted.
612 (DOMEventListener::stringRepresentation): Deleted.
613 (DOMEventListener::webScriptValueAtIndex): Deleted.
614 (DOMEventListener::setWebScriptValueAtIndex): Deleted.
615 (DOMEventListener::setException): Deleted.
616 (DOMEventListener::handleEvent): Deleted.
617 * WinLauncher/DOMDefaultImpl.h:
618 (WebScriptObject::QueryInterface): Deleted.
619 (WebScriptObject::AddRef): Deleted.
620 (WebScriptObject::Release): Deleted.
621 (DOMObject::QueryInterface): Deleted.
622 (DOMEventListener::QueryInterface): Deleted.
623 (DOMEventListener::AddRef): Deleted.
624 (DOMEventListener::Release): Deleted.
625 * WinLauncher/WinLauncher.cpp:
626 (WinLauncher::WinLauncher):
628 (WinLauncher::prepareViews):
629 (WinLauncher::setFrameLoadDelegate):
630 (WinLauncher::setUIDelegate):
631 (WinLauncher::setAccessibilityDelegate):
632 (WinLauncher::mainFrame):
633 (WinLauncher::seedInitialDefaultPreferences):
634 (WinLauncher::setToDefaultPreferences):
635 (updateMenuItemForHistoryItem):
636 (WinLauncher::showLastVisitedSites):
637 (WinLauncher::launchInspector):
638 (WinLauncher::navigateForwardOrBackward):
639 (WinLauncher::navigateToHistory):
640 (WinLauncher::goBack):
641 (WinLauncher::goForward):
642 (WinLauncher::loadURL):
643 (shouldUseFullDesktop): Deleted.
644 (SimpleEventListener::SimpleEventListener): Deleted.
645 (SimpleEventListener::handleEvent): Deleted.
646 (WinLauncherWebHost::updateAddressBar): Deleted.
647 (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
648 (WinLauncherWebHost::QueryInterface): Deleted.
649 (WinLauncherWebHost::AddRef): Deleted.
650 (WinLauncherWebHost::Release): Deleted.
651 (showLastVisitedSites): Deleted.
652 (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
653 (resizeSubViews): Deleted.
654 (subclassForLayeredWindow): Deleted.
655 (computeFullDesktopFrame): Deleted.
657 (getAppDataFolder): Deleted.
658 (setToDefaultPreferences): Deleted.
659 (setCacheFolder): Deleted.
660 (createCrashReport): Deleted.
662 (MyRegisterClass): Deleted.
663 (AbortProc): Deleted.
664 (getPrinterDC): Deleted.
665 (initDocStruct): Deleted.
666 (PrintView): Deleted.
667 (ToggleMenuItem): Deleted.
668 (LaunchInspector): Deleted.
669 (NavigateForwardOrBackward): Deleted.
670 (NavigateToHistory): Deleted.
673 (BackButtonProc): Deleted.
674 (ForwardButtonProc): Deleted.
677 (dllLauncherEntryPoint): Deleted.
678 * WinLauncher/WinLauncher.h:
679 (WinLauncher::standardPreferences):
680 (WinLauncher::privatePreferences):
681 (WinLauncher::hasWebView):
682 (WinLauncher::usesLayeredWebView):
683 (WinLauncherWebHost::WinLauncherWebHost): Deleted.
684 (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
685 (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
686 (WinLauncherWebHost::didCommitLoadForFrame): Deleted.
687 (WinLauncherWebHost::didReceiveTitle): Deleted.
688 (WinLauncherWebHost::didChangeIcons): Deleted.
689 (WinLauncherWebHost::didReceiveIcon): Deleted.
690 (WinLauncherWebHost::didFailLoadWithError): Deleted.
691 (WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
692 (WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
693 (WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
694 (WinLauncherWebHost::willCloseFrame): Deleted.
695 (WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
696 (WinLauncherWebHost::didClearWindowObject): Deleted.
697 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
698 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
699 * WinLauncher/WinLauncherReplace.h:
700 (processCrashReport):
701 * WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
702 (WinLauncherWebHost::updateAddressBar):
703 (WinLauncherWebHost::QueryInterface):
704 (WinLauncherWebHost::AddRef):
705 (WinLauncherWebHost::Release):
706 (WinLauncherWebHost::didFinishLoadForFrame):
707 (shouldUseFullDesktop): Deleted.
708 (updateMenuItemForHistoryItem): Deleted.
709 (showLastVisitedSites): Deleted.
710 (resizeSubViews): Deleted.
711 (subclassForLayeredWindow): Deleted.
712 (computeFullDesktopFrame): Deleted.
714 (getAppDataFolder): Deleted.
715 (setToDefaultPreferences): Deleted.
716 (setCacheFolder): Deleted.
717 (createCrashReport): Deleted.
719 (MyRegisterClass): Deleted.
720 (AbortProc): Deleted.
721 (getPrinterDC): Deleted.
722 (initDocStruct): Deleted.
723 (PrintView): Deleted.
724 (ToggleMenuItem): Deleted.
725 (LaunchInspector): Deleted.
726 (NavigateForwardOrBackward): Deleted.
727 (NavigateToHistory): Deleted.
730 (BackButtonProc): Deleted.
731 (ForwardButtonProc): Deleted.
734 (dllLauncherEntryPoint): Deleted.
735 * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
736 (WinLauncherWebHost::WinLauncherWebHost):
737 (WinLauncherWebHost::didStartProvisionalLoadForFrame):
738 (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
739 (WinLauncherWebHost::didCommitLoadForFrame):
740 (WinLauncherWebHost::didReceiveTitle):
741 (WinLauncherWebHost::didChangeIcons):
742 (WinLauncherWebHost::didReceiveIcon):
743 (WinLauncherWebHost::didFailLoadWithError):
744 (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
745 (WinLauncherWebHost::willPerformClientRedirectToURL):
746 (WinLauncherWebHost::didCancelClientRedirectForFrame):
747 (WinLauncherWebHost::willCloseFrame):
748 (WinLauncherWebHost::windowScriptObjectAvailable):
749 (WinLauncherWebHost::didClearWindowObject):
750 * WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
753 (shouldUseFullDesktop): Deleted.
754 (SimpleEventListener::SimpleEventListener): Deleted.
755 (SimpleEventListener::handleEvent): Deleted.
756 (WinLauncherWebHost::updateAddressBar): Deleted.
757 (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
758 (WinLauncherWebHost::QueryInterface): Deleted.
759 (WinLauncherWebHost::AddRef): Deleted.
760 (WinLauncherWebHost::Release): Deleted.
761 (updateMenuItemForHistoryItem): Deleted.
762 (showLastVisitedSites): Deleted.
763 (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
764 (resizeSubViews): Deleted.
765 (subclassForLayeredWindow): Deleted.
766 (computeFullDesktopFrame): Deleted.
768 (getAppDataFolder): Deleted.
769 (setToDefaultPreferences): Deleted.
770 (setCacheFolder): Deleted.
771 (createCrashReport): Deleted.
772 (AbortProc): Deleted.
773 (getPrinterDC): Deleted.
774 (initDocStruct): Deleted.
775 (PrintView): Deleted.
776 (ToggleMenuItem): Deleted.
777 (LaunchInspector): Deleted.
778 (NavigateForwardOrBackward): Deleted.
779 (NavigateToHistory): Deleted.
782 (BackButtonProc): Deleted.
783 (ForwardButtonProc): Deleted.
786 (dllLauncherEntryPoint): Deleted.
788 2014-06-20 Myles C. Maxfield <mmaxfield@apple.com>
790 [iOS] getsectdata() is deprecated and we use it in DRT
791 https://bugs.webkit.org/show_bug.cgi?id=134122
793 Reviewed by Alexey Proskuryakov.
795 Migrate to using magic linker symbols.
797 No tests because there should be no behavior change
799 * DumpRenderTree/mac/DumpRenderTree.mm:
802 2014-06-24 Javier Fernandez <jfernandez@igalia.com>
804 Name moving. Unreviewed.
806 * Scripts/webkitpy/common/config/contributors.json:
808 2014-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
810 Remove EFL WK1 watch category
811 https://bugs.webkit.org/show_bug.cgi?id=134231
813 Reviewed by Csaba Osztrogonác.
815 * Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
817 2014-06-24 Krzysztof Czech <k.czech@samsung.com>
819 [ATK] Remove some unused code from DumpRenderTree
820 https://bugs.webkit.org/show_bug.cgi?id=134191
822 Reviewed by Chris Fleizach.
824 DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
826 * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
827 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
828 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
829 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
830 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
831 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
833 2014-06-23 Shivakumar JM <shiva.jm@samsung.com>
835 [EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
836 https://bugs.webkit.org/show_bug.cgi?id=134025
838 Reviewed by Gyuyoung Kim.
840 Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
842 * MiniBrowser/efl/main.c:
845 2014-06-23 Ryuan Choi <ryuan.choi@samsung.com>
847 [EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
848 https://bugs.webkit.org/show_bug.cgi?id=134236
850 Reviewed by Gyuyoung Kim.
852 * ImageDiff/efl/ImageDiff.cpp:
853 (calculateDifference):
854 (printImageDifferences):
855 (readImageFromStdin):
858 2014-06-23 Daniel Bates <dabates@apple.com>
860 Rolling out r170340 and r170339.
862 Changeset r170339 broke the Apple Windows Debug and Release builds.
866 "[Win] Build fix after r134209"
867 http://trac.webkit.org/changeset/170340
869 "[Win] Clean up and refactor WinLauncher"
870 https://bugs.webkit.org/show_bug.cgi?id=134209
871 http://trac.webkit.org/changeset/170339
873 2014-06-23 Brent Fulgham <bfulgham@apple.com>
875 [Win] Build fix after r134209
877 * WinLauncher/WinMain.cpp: Must include the resources file
880 2014-06-23 Brent Fulgham <bfulgham@apple.com>
882 [Win] Clean up and refactor WinLauncher
883 https://bugs.webkit.org/show_bug.cgi?id=134209
885 Reviewed by Tim Horton.
887 Make WinLauncher a class, and move all non-class driver functions
888 into "Common.cpp" and "WinMain.cpp". These files are distinct
889 to allow some internal tools to reuse the code in 'Common'.
891 * WinLauncher/Common.cpp: Added. Consists of code moved from
892 'WinLauncher.cpp' that can be reused for other tools.
893 (subclassForLayeredWindow):
894 (computeFullDesktopFrame):
910 (dllLauncherEntryPoint):
911 * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
912 (DOMEventListener::Release):
913 (WebScriptObject::WebScriptObject): Deleted.
914 (WebScriptObject::~WebScriptObject): Deleted.
915 (WebScriptObject::throwException): Deleted.
916 (WebScriptObject::callWebScriptMethod): Deleted.
917 (WebScriptObject::evaluateWebScript): Deleted.
918 (WebScriptObject::removeWebScriptKey): Deleted.
919 (WebScriptObject::stringRepresentation): Deleted.
920 (WebScriptObject::webScriptValueAtIndex): Deleted.
921 (WebScriptObject::setWebScriptValueAtIndex): Deleted.
922 (WebScriptObject::setException): Deleted.
923 (DOMEventListener::throwException): Deleted.
924 (DOMEventListener::callWebScriptMethod): Deleted.
925 (DOMEventListener::evaluateWebScript): Deleted.
926 (DOMEventListener::removeWebScriptKey): Deleted.
927 (DOMEventListener::stringRepresentation): Deleted.
928 (DOMEventListener::webScriptValueAtIndex): Deleted.
929 (DOMEventListener::setWebScriptValueAtIndex): Deleted.
930 (DOMEventListener::setException): Deleted.
931 (DOMEventListener::handleEvent): Deleted.
932 * WinLauncher/DOMDefaultImpl.h:
933 (WebScriptObject::QueryInterface): Deleted.
934 (WebScriptObject::AddRef): Deleted.
935 (WebScriptObject::Release): Deleted.
936 (DOMObject::QueryInterface): Deleted.
937 (DOMEventListener::QueryInterface): Deleted.
938 (DOMEventListener::AddRef): Deleted.
939 (DOMEventListener::Release): Deleted.
940 * WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
941 into a C++ class and removed WinAPI code.
942 (WinLauncher::WinLauncher):
944 (WinLauncher::prepareViews):
945 (WinLauncher::setFrameLoadDelegate):
946 (WinLauncher::setUIDelegate):
947 (WinLauncher::setAccessibilityDelegate):
948 (WinLauncher::mainFrame):
949 (WinLauncher::seedInitialDefaultPreferences):
950 (WinLauncher::setToDefaultPreferences):
951 (updateMenuItemForHistoryItem):
952 (WinLauncher::showLastVisitedSites):
953 (WinLauncher::launchInspector):
954 (WinLauncher::navigateForwardOrBackward):
955 (WinLauncher::navigateToHistory):
956 (WinLauncher::goBack):
957 (WinLauncher::goForward):
958 (WinLauncher::loadURL):
959 (shouldUseFullDesktop): Deleted.
960 (SimpleEventListener::SimpleEventListener): Deleted.
961 (SimpleEventListener::handleEvent): Deleted.
962 (WinLauncherWebHost::updateAddressBar): Deleted.
963 (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
964 (WinLauncherWebHost::QueryInterface): Deleted.
965 (WinLauncherWebHost::AddRef): Deleted.
966 (WinLauncherWebHost::Release): Deleted.
967 (showLastVisitedSites): Deleted.
968 (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
969 (resizeSubViews): Deleted.
970 (subclassForLayeredWindow): Deleted.
971 (computeFullDesktopFrame): Deleted.
973 (getAppDataFolder): Deleted.
974 (setToDefaultPreferences): Deleted.
975 (setCacheFolder): Deleted.
976 (createCrashReport): Deleted.
978 (MyRegisterClass): Deleted.
979 (AbortProc): Deleted.
980 (getPrinterDC): Deleted.
981 (initDocStruct): Deleted.
982 (PrintView): Deleted.
983 (ToggleMenuItem): Deleted.
984 (LaunchInspector): Deleted.
985 (NavigateForwardOrBackward): Deleted.
986 (NavigateToHistory): Deleted.
989 (BackButtonProc): Deleted.
990 (ForwardButtonProc): Deleted.
993 (dllLauncherEntryPoint): Deleted.
994 * WinLauncher/WinLauncher.h: Removed.
995 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
996 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
997 * WinLauncher/WinLauncherReplace.h:
998 (processCrashReport):
999 * WinLauncher/WinLauncherWebHost.cpp: Added.
1000 (SimpleEventListener::SimpleEventListener):
1001 (SimpleEventListener::handleEvent):
1002 (WinLauncherWebHost::updateAddressBar):
1003 (WinLauncherWebHost::didFailProvisionalLoadWithError):
1004 (WinLauncherWebHost::QueryInterface):
1005 (WinLauncherWebHost::AddRef):
1006 (WinLauncherWebHost::Release):
1007 (WinLauncherWebHost::didFinishLoadForFrame):
1008 * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
1009 Moved WinLauncherWebHost implementation from WinLauncher.cpp into
1010 its own set of files.
1011 (WinLauncherWebHost::WinLauncherWebHost):
1012 (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1013 (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1014 (WinLauncherWebHost::didCommitLoadForFrame):
1015 (WinLauncherWebHost::didReceiveTitle):
1016 (WinLauncherWebHost::didChangeIcons):
1017 (WinLauncherWebHost::didReceiveIcon):
1018 (WinLauncherWebHost::didFailLoadWithError):
1019 (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1020 (WinLauncherWebHost::willPerformClientRedirectToURL):
1021 (WinLauncherWebHost::didCancelClientRedirectForFrame):
1022 (WinLauncherWebHost::willCloseFrame):
1023 (WinLauncherWebHost::windowScriptObjectAvailable):
1024 (WinLauncherWebHost::didClearWindowObject):
1025 * WinLauncher/WinMain.cpp: Added. This consists of code from
1026 WinLauncher that is unique to the WinLauncher utility, and is
1027 not part of the WinLauncher class.
1031 2014-06-23 Simon Fraser <simon.fraser@apple.com>
1033 Enable the Web Inspector in MiniBrowser
1034 https://bugs.webkit.org/show_bug.cgi?id=134148
1036 Reviewed by Joseph Pecoraro.
1038 Set the pref to enable Web Inspector in both WK1 and WK2 windows.
1040 * MiniBrowser/mac/AppDelegate.m:
1041 (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1043 2014-06-21 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1045 Disable gamepad feature on EFL and GTK ports by default
1046 https://bugs.webkit.org/show_bug.cgi?id=134169
1048 Reviewed by Brady Eidson.
1050 EFL and GTK ports disabled Gamepad feature now. Besides current implementation
1051 was treated to 'deprecated' status.
1053 ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
1055 * Scripts/webkitperl/FeatureList.pm:
1057 2014-06-21 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1059 [Inspector][EFL] Can't resume a special break point on EFL inspector
1060 https://bugs.webkit.org/show_bug.cgi?id=129294
1062 Reviewed by Gyuyoung Kim.
1064 Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
1065 by Ryuan Choi - <https://phab.enlightenment.org/D790>
1067 * efl/jhbuild.modules:
1068 * efl/patches/ecore.patch: Added.
1070 2014-06-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1072 Removing PAGE_VISIBILITY_API compile guard.
1073 https://bugs.webkit.org/show_bug.cgi?id=133844
1075 Reviewed by Gavin Barraclough.
1077 * Scripts/webkitperl/FeatureList.pm:
1079 2014-06-20 Ryuan Choi <ryuan.choi@samsung.com>
1081 [EFL] Remove DumpRenderTree/efl and EWebLauncher
1082 https://bugs.webkit.org/show_bug.cgi?id=134138
1084 Reviewed by Gyuyoung Kim.
1086 DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
1089 * DumpRenderTree/PlatformEfl.cmake: Removed.
1090 * DumpRenderTree/efl: Removed entire directory.
1091 * EWebLauncher: Ditto.
1092 * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
1097 (getCustomBuildDir):
1098 (getPlatformFontsPath):
1099 (addFontsToEnvironment):
1100 * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
1101 * WebKitTestRunner/PlatformEfl.cmake:
1103 2014-06-20 Zalan Bujtas <zalan@apple.com>
1105 Name moving. Unreviewed.
1107 * Scripts/webkitpy/common/config/contributors.json:
1109 2014-06-20 Javier Fernandez <jfernandez@igalia.com>
1111 Unreviewed. Adding myself to committers.
1113 * Scripts/webkitpy/common/config/contributors.json:
1115 2014-06-20 Yusuke Suzuki <utatane.tea@gmail.com>
1117 Unreviewed. Adding myself to committers.
1119 * Scripts/webkitpy/common/config/contributors.json:
1121 2014-06-20 Tim Horton <timothy_horton@apple.com>
1123 Make WebKit2 more accessible in MiniBrowser
1124 https://bugs.webkit.org/show_bug.cgi?id=134099
1126 Reviewed by Anders Carlsson.
1128 * MiniBrowser/mac/AppDelegate.h:
1129 * MiniBrowser/mac/AppDelegate.m:
1130 (-[BrowserAppDelegate newWindow:]):
1131 (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1132 (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
1133 (-[BrowserAppDelegate _useWebKit2ByDefault]):
1134 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1135 (-[BrowserAppDelegate validateMenuItem:]):
1136 * MiniBrowser/mac/MainMenu.xib:
1137 Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
1138 When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
1139 Make the non-default new-window menu item always show up, because people often don't find it
1140 when you have to press option to have it show up.
1142 * MiniBrowser/mac/BrowserWindowController.h:
1143 * MiniBrowser/mac/BrowserWindowController.m:
1144 (-[BrowserWindowController initWithWindow:]):
1146 * MiniBrowser/mac/WK1BrowserWindowController.m:
1147 (-[WK1BrowserWindowController validateMenuItem:]):
1148 * MiniBrowser/mac/WK2BrowserWindowController.m:
1149 (-[WK2BrowserWindowController validateMenuItem:]):
1150 Use the cached [menuItem action] like the earlier cases do.
1152 2014-06-20 Daniel Bates <dabates@apple.com>
1154 Teach run-{safari, webkit-app} about iOS Simulator
1155 https://bugs.webkit.org/show_bug.cgi?id=133986
1157 Reviewed by David Kilzer.
1159 Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
1160 into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
1163 * Scripts/old-run-webkit-tests:
1164 (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
1165 WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
1167 (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
1168 (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
1169 * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
1170 (say, by specifying the optional command-line argument --simulator). For now, die() with an error
1171 when the iOS device SDK is used as we don't support launching an app on the device at this time.
1172 * Scripts/webkitdirs.pm:
1173 (xcodeSDKVersion): Added.
1174 (setupIOSWebKitEnvironment): Added.
1175 (installedMobileSafariBundle): Added.
1176 (mobileSafariBundle): Added.
1177 (plistPathFromBundle): Added.
1178 (appIdentiferFromBundle): Added.
1179 (appDisplayNameFromBundle): Added.
1180 (loadIPhoneSimulatorNotificationIfNeeded): Added.
1181 (openIOSSimulator): Added.
1182 (quitIOSSimulator): Added.
1183 (iosSimulatorDeviceByName): Added.
1184 (iosSimulatorRuntime): Added.
1185 (findOrCreateSimulatorForIOSDevice): Added.
1186 (runIOSWebKitAppInSimulator): Added.
1187 (installAndLaunchIOSWebKitAppInSimulator): Added.
1188 (runIOSWebKitApp): Added.
1189 (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
1190 die() with an error when the iOS device SDK is used as we don't support launching Safari on the
1191 device at this time.
1193 2014-06-19 Anders Carlsson <andersca@apple.com>
1195 Add WTF::Optional class
1196 https://bugs.webkit.org/show_bug.cgi?id=134083
1198 Reviewed by Andreas Kling.
1200 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1201 * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
1202 (TestWebKitAPI::TEST):
1204 2014-06-20 Ion Rosca <rosca@adobe.com>
1206 Unreviewed. Adding myself to Committers list.
1208 * Scripts/webkitpy/common/config/contributors.json:
1210 2014-06-20 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1212 [EFL] Add gstreamer as dependecy of EFL after r169785
1213 https://bugs.webkit.org/show_bug.cgi?id=134066
1215 Reviewed by Gyuyoung Kim.
1217 * efl/jhbuild.modules:
1219 2014-06-20 Ryuan Choi <ryuan.choi@samsung.com>
1221 [EFL] Merge url_utils.c to MiniBrowser
1222 https://bugs.webkit.org/show_bug.cgi?id=134095
1224 Reviewed by Csaba Osztrogonác.
1226 url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
1227 This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
1229 * MiniBrowser/efl/CMakeLists.txt:
1230 Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
1231 * MiniBrowser/efl/main.c:
1232 (has_scheme): Copied from url_utils.c
1233 (url_from_user_input): Ditto.
1235 2014-06-19 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1237 Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
1239 Reviewed by Csaba Osztrogonác.
1241 * Scripts/webkitpy/common/config/ports_unittest.py:
1242 (DeprecatedPortTest.test_gtk_wk2_port):
1243 (DeprecatedPortTest.test_efl_port): Deleted.
1244 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1245 (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1246 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1247 (TestRebaselineExpectations.test_rebaseline_expectations):
1249 2014-06-19 Ryuan Choi <ryuan.choi@samsung.com>
1251 [EFL][CMAKE] Disable WebKit1 build as a default
1252 https://bugs.webkit.org/show_bug.cgi?id=134093
1254 Reviewed by Gyuyoung Kim.
1258 2014-06-19 Carlos Garcia Campos <cgarcia@igalia.com>
1260 [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
1261 https://bugs.webkit.org/show_bug.cgi?id=93002
1263 Reviewed by Gustavo Noronha Silva.
1265 Add unit tests to check WebKitDOMNodefilter API used from both
1266 TreeWalker and NodeIterator.
1268 * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
1269 public headers and add WebKitDOMNodeFilter to the list of exceptions.
1270 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
1271 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
1272 (webkitNodeFilterAcceptNode):
1273 (webkitNodeFilterDOMNodeFilterIfaceInit):
1274 (webkit_node_filter_init):
1275 (webkit_node_filter_class_init):
1276 (WebKitDOMNodeFilterTest::create):
1277 (WebKitDOMNodeFilterTest::webPageFromArgs):
1278 (WebKitDOMNodeFilterTest::testTreeWalker):
1279 (WebKitDOMNodeFilterTest::testNodeIterator):
1280 (WebKitDOMNodeFilterTest::runTest):
1282 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
1284 (testWebKitDOMNodeFilterTreeWalker):
1285 (testWebKitDOMNodeFilterNodeIterator):
1289 (WebKitDOMDocGeneratorSections.__init__):
1290 (WebKitDOMDocGeneratorSections._symbol_list):
1291 (WebKitDOMDocGeneratorSections.write_section):
1293 2014-06-19 Carlos Garcia Campos <cgarcia@igalia.com>
1295 [GTK] Limit the amount of API exposed to GObject DOM bindings API
1296 https://bugs.webkit.org/show_bug.cgi?id=133726
1298 Reviewed by Gustavo Noronha Silva.
1300 Don't make fatal finding files without a .symbols file, since now
1301 only the stable DOM API has .symbols files.
1304 (get_all_webkitdom_symbol_files):
1306 2014-06-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1308 Remove efl wk1 buildbot and ews
1309 https://bugs.webkit.org/show_bug.cgi?id=134089
1311 Reviewed by Benjamin Poulain.
1313 EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
1315 * BuildSlaveSupport/build.webkit.org-config/config.json:
1316 * QueueStatusServer/config/queues.py:
1317 * Scripts/webkitpy/common/config/ews.json:
1318 * Scripts/webkitpy/common/config/ports.py:
1319 (DeprecatedPort.port):
1320 (QtWK2Port.run_webkit_tests_command):
1322 (EflPort.build_webkit_command): Deleted.
1323 * Scripts/webkitpy/port/builders.py:
1324 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1325 * TestResultServer/static-dashboards/loader_unittests.js:
1327 2014-06-19 David Kilzer <ddkilzer@apple.com>
1329 check-webkit-style does not understand Obj-C literal syntax for NSDictionary
1330 <http://webkit.org/b/134061>
1332 Reviewed by Dan Bernstein.
1334 * Scripts/webkitpy/style/checkers/cpp.py:
1335 (check_spacing): Ignore '@' immediately before '{'.
1336 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1337 (CppStyleTest.test_spacing_before_braces): Add unit test for
1338 '^{' block syntax and '@{' Objective-C liternal NSDitionary
1341 2014-06-18 Tim Horton <timothy_horton@apple.com>
1343 All of MiniBrowser's WKWebViews should share a configuration
1344 https://bugs.webkit.org/show_bug.cgi?id=134017
1346 Reviewed by Anders Carlsson.
1348 * MiniBrowser/mac/WK2BrowserWindowController.m:
1349 (-[WK2BrowserWindowController awakeFromNib]):
1350 Share a single WKWebViewConfiguration between all of MiniBrowser's views.
1351 This means that they'll share things like preferences, visited links, etc.
1352 It also means that we'll properly share processes once we hit the process limit.
1354 2014-06-18 Zan Dobersek <zdobersek@igalia.com>
1356 [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
1357 https://bugs.webkit.org/show_bug.cgi?id=133971
1359 Reviewed by Martin Robinson.
1361 * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
1362 building for the Wayland target. The latest 3.12 version is required to match
1363 the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
1364 as well due to GTK+ depending on a newer version.
1366 2014-06-17 Ryuan Choi <ryuan.choi@samsung.com>
1368 [EFL] Turn on NOSNIFF in FeatureList.pm
1369 https://bugs.webkit.org/show_bug.cgi?id=134010
1371 Reviewed by Csaba Osztrogonác.
1373 r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
1375 * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
1377 2014-06-17 Tim Horton <timothy_horton@apple.com>
1379 MiniBrowser should show Web Content process pids in the window title
1380 https://bugs.webkit.org/show_bug.cgi?id=134016
1382 Reviewed by Sam Weinig.
1384 * MiniBrowser/mac/WK2BrowserWindowController.m:
1385 (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1387 2014-06-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
1389 [GTK] Fix the handling of resize events after r169505.
1390 https://bugs.webkit.org/show_bug.cgi?id=133517
1392 Reviewed by Martin Robinson.
1394 * Scripts/webkitpy/port/xvfbdriver.py:
1395 (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
1396 The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
1397 need at least 900x640 pixels to pass.
1398 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1399 (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
1400 (XvfbDriverTest.test_start_pixel_tests): Update resolution.
1401 (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
1402 (XvfbDriverTest.test_start_next_worker): Update resolution.
1403 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1404 (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
1405 be requested over the main widget instead of the window.
1406 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
1408 (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
1409 (WTR::PlatformWebView::setWindowFrame): Set the size and position
1410 of the Window and the web view.
1412 2014-06-17 Matthew Mirman <mmirman@apple.com>
1414 Unreviewed. Added myself to list of contributors.
1416 * Scripts/webkitpy/common/config/contributors.json: Added myself.
1418 2014-06-17 Commit Queue <commit-queue@webkit.org>
1420 Unreviewed, rolling out r170058.
1421 https://bugs.webkit.org/show_bug.cgi?id=133993
1423 Caused 4 webkitpy failures on the bots (Requested by bradee-oh
1428 "[GTK] Fix the handling of resize events after r169505."
1429 https://bugs.webkit.org/show_bug.cgi?id=133517
1430 http://trac.webkit.org/changeset/170058
1432 2014-06-17 Rebecca Hauck <rhauck@adobe.com>
1434 Update import-w3c-tests to reflect current W3C test repo directory structure
1435 https://bugs.webkit.org/show_bug.cgi?id=133460
1437 Reviewed by Bem Jones-Bey.
1439 Removed all references to test status, which are no longer reflected in the
1440 directory names in the W3C CSS test repo. No tests are required for this
1441 change, the existing tests pass.
1443 * Scripts/webkitpy/w3c/test_importer.py:
1445 (TestImporter.__init__):
1446 (TestImporter.find_importable_tests):
1447 (TestImporter.setup_destination_directory):
1448 (TestImporter.write_import_log):
1449 (TestImporter.update_test_status): Deleted.
1451 2014-06-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
1453 [GTK] Fix the handling of resize events after r169505.
1454 https://bugs.webkit.org/show_bug.cgi?id=133517
1456 Reviewed by Martin Robinson.
1458 * Scripts/webkitpy/port/xvfbdriver.py:
1459 (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
1460 The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
1461 need at least 900x640 pixels to pass.
1462 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1463 (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
1464 be requested over the main widget instead of the window.
1465 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
1467 (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
1468 (WTR::PlatformWebView::setWindowFrame): Set the size and position
1469 of the Window and the web view.
1471 2014-06-17 Dan Bernstein <mitz@apple.com>
1473 String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
1474 https://bugs.webkit.org/show_bug.cgi?id=133968
1476 Reviewed by Anders Carlsson.
1478 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1479 (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
1480 share an impl() with the original.
1482 2014-06-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1484 [EFL][WK2] Skip failing EFL API tests
1485 https://bugs.webkit.org/show_bug.cgi?id=133981
1487 Reviewed by Csaba Osztrogonác.
1489 UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
1491 * TestWebKitAPI/PlatformEfl.cmake:
1493 2014-06-16 Ryuan Choi <ryuan.choi@samsung.com>
1495 [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
1496 https://bugs.webkit.org/show_bug.cgi?id=133962
1498 Reviewed by Gyuyoung Kim.
1500 Since we bumped EFL to 1.9, this workaround is unnecessary.
1502 * MiniBrowser/efl/main.c:
1503 (update_view_favicon):
1505 2014-06-16 Gwang Yoon Hwang <yoon@igalia.com>
1507 [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1508 https://bugs.webkit.org/show_bug.cgi?id=131472
1510 Reviewed by Martin Robinson.
1512 This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
1514 * Scripts/webkitpy/port/xvfbdriver.py:
1515 (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1516 when running WebKitTestRunner with the Xvfb driver.
1517 * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
1518 * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1520 * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1521 how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1522 calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1525 2014-06-16 Tanay C <tanay.c@samsung.com>
1527 Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
1528 https://bugs.webkit.org/show_bug.cgi?id=133792
1530 Reviewed by Gyuyoung Kim.
1532 * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
1533 (show_file_entry_dialog):
1536 2014-06-16 Mario Sanchez Prada <mario.prada@samsung.com>
1538 [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
1539 https://bugs.webkit.org/show_bug.cgi?id=133512
1541 Reviewed by Chris Fleizach.
1543 Added support for connecting to AtkSelection's 'selection-changed'
1544 signal, and print it out as AXSelectedChildrenChanged in the tests.
1546 Also removed some dead code, that became useless after r169487.
1548 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1549 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
1551 2014-06-15 Ryuan Choi <ryuan.choi@samsung.com>
1553 [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
1554 https://bugs.webkit.org/show_bug.cgi?id=133841
1556 Reviewed by Gyuyoung Kim.
1558 * MiniBrowser/efl/main.c:
1561 2014-06-15 Dan Bernstein <mitz@apple.com>
1563 Set the svn:ignore property on an Xcode project to ignore user and workspace data.
1565 * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
1567 2014-06-15 Anders Carlsson <andersca@apple.com>
1571 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1572 (callRunJavaScriptBlockAndRelease):
1573 (runJavaScriptInMainFrame):
1576 2014-06-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
1578 Create MSE and EME watchlist
1579 https://bugs.webkit.org/show_bug.cgi?id=133810
1581 Reviewed by Eric Carlson.
1583 * Scripts/webkitpy/common/config/watchlist: Create MSEEME
1584 definition and add Eric Carlson and myself to it.
1586 2014-06-12 Carlos Garcia Campos <cgarcia@igalia.com>
1588 [GTK] Remove all deprecated API from GObject DOM bindings
1589 https://bugs.webkit.org/show_bug.cgi?id=133728
1591 Reviewed by Martin Robinson.
1594 (WebKitDOMDocGenerator): Remove all deleted classes from the list.
1595 (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
1597 2014-06-12 Simon Fraser <simon.fraser@apple.com>
1599 [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
1600 https://bugs.webkit.org/show_bug.cgi?id=133835
1602 Reviewed by Tim Horton.
1604 Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
1606 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1607 (-[WebKitTestRunnerWindow initWithFrame:]):
1608 (-[WebKitTestRunnerWindow setFrame:]):
1610 2014-06-12 Carlos Alberto Lopez Perez <clopez@igalia.com>
1612 [GTK] Performance tests should be always ran with WKTR.
1613 https://bugs.webkit.org/show_bug.cgi?id=133780
1615 Reviewed by Ryosuke Niwa.
1617 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1618 (PerfTestsRunner.__init__): Enable webkit_test_runner when port
1621 2014-06-12 Sergio Villar Senin <svillar@igalia.com>
1623 [GTK] REGRESSION: application name is not correctly appended to the UA
1624 https://bugs.webkit.org/show_bug.cgi?id=133793
1626 Reviewed by Carlos Garcia Campos.
1628 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1629 (testWebKitSettingsUserAgent):
1631 2014-06-12 Sergio Villar Senin <svillar@igalia.com>
1633 [GTK] Unsupported browser in www.icloud.com
1634 https://bugs.webkit.org/show_bug.cgi?id=133403
1636 Reviewed by Martin Robinson.
1638 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
1639 (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
1640 quirk that was removed.
1642 2014-06-11 Simon Fraser <simon.fraser@apple.com>
1644 [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
1645 https://bugs.webkit.org/show_bug.cgi?id=133779
1647 Reviewed by Benjamin Poulain.
1649 Tell the WebPage to use the testing viewport configuration from the injected bundle.
1651 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1652 (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
1653 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1654 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
1657 2014-06-11 Simon Fraser <simon.fraser@apple.com>
1659 WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
1660 https://bugs.webkit.org/show_bug.cgi?id=133770
1662 Reviewed by Anders Carlsson.
1664 Push the per-test view configuration up to TestController, so that platforms
1665 can modify the behavior. This also allows platform-specific changes (e.g.
1666 for threaded scrolling) to made without #ifefs.
1668 * WebKitTestRunner/TestController.cpp:
1669 (WTR::TestController::updateWebViewSizeForTest):
1670 (WTR::TestController::updateWindowScaleForTest):
1671 (WTR::shouldUseFixedLayout):
1672 (WTR::TestController::updateLayoutTypeForTest):
1673 (WTR::TestController::platformConfigureViewForTest):
1674 (WTR::TestController::configureViewForTest):
1675 * WebKitTestRunner/TestController.h:
1676 * WebKitTestRunner/TestInvocation.cpp:
1677 (WTR::TestInvocation::invoke):
1678 (WTR::sizeWebViewForCurrentTest): Deleted.
1679 (WTR::changeWindowScaleIfNeeded): Deleted.
1680 (WTR::shouldUseThreadedScrolling): Deleted.
1681 (WTR::updateThreadedScrollingForCurrentTest): Deleted.
1682 (WTR::shouldUseFixedLayout): Deleted.
1683 (WTR::updateLayoutType): Deleted.
1684 * WebKitTestRunner/TestInvocation.h:
1685 (WTR::TestInvocation::pathOrURL):
1686 * WebKitTestRunner/ios/TestControllerIOS.mm:
1687 (WTR::shouldMakeViewportFlexible):
1688 (WTR::TestController::platformConfigureViewForTest):
1689 * WebKitTestRunner/mac/TestControllerMac.mm:
1690 (WTR::shouldUseThreadedScrolling):
1691 (WTR::TestController::platformConfigureViewForTest):
1693 2014-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1695 [EFL] Add dependencies packages to efl install-dependencies file
1696 https://bugs.webkit.org/show_bug.cgi?id=133720
1698 Reviewed by Csaba Osztrogonác.
1700 After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
1701 install doxygen and libssl-dev because efl 1.9 depends on those libraries.
1703 * efl/install-dependencies:
1705 2014-06-11 Zoltan Horvath <zoltan@webkit.org>
1707 Unreviewed. Moving myself to the list of reviewers.
1709 * Scripts/webkitpy/common/config/contributors.json:
1711 2014-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1713 [EFL] Drop to maintain EFL 32bit release bot
1714 https://bugs.webkit.org/show_bug.cgi?id=133710
1716 Reviewed by Csaba Osztrogonác.
1718 * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
1720 2014-06-11 Carlos Garcia Campos <cgarcia@igalia.com>
1722 [GTK] Use a different user agent string depending on the site
1723 https://bugs.webkit.org/show_bug.cgi?id=132681
1725 Reviewed by Anders Carlsson.
1727 Add a unit test to check user agent quirks.
1729 * TestWebKitAPI/PlatformGTK.cmake:
1730 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
1731 (TestWebKitAPI::TEST):
1732 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1733 (testWebKitSettings): Site specific quirks setting is now enabled
1736 2014-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1738 Unreviewed, update my list of email addresses in contributors.json.
1740 * Scripts/webkitpy/common/config/contributors.json:
1742 2014-06-10 Simon Fraser <simon.fraser@apple.com>
1744 Always switch to an sRGB screen color profile when running tests
1745 https://bugs.webkit.org/show_bug.cgi?id=133712
1747 Reviewed by Tim Horton.
1749 Switch the screen color profile to sRGB when running tests, because even ref
1750 tests need the screen to use the correct color profile.
1752 * DumpRenderTree/mac/LayoutTestHelper.m:
1753 (installLayoutTestColorProfile):
1754 * Scripts/webkitpy/port/mac.py:
1755 (MacPort.start_helper):
1757 2014-06-10 Martin Hodovan <mhodovan@partner.samsung.com>
1759 [EFL] Bump EFL libraries to 1.9
1760 https://bugs.webkit.org/show_bug.cgi?id=125479
1762 Reviewed by Gyuyoung Kim.
1764 Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
1765 and László Langó <llango.u-szeged@partner.samsung.com>.
1767 * ImageDiff/CMakeLists.txt:
1768 * MiniBrowser/efl/CMakeLists.txt:
1769 * efl/install-dependencies:
1770 * efl/jhbuild.modules:
1773 2014-06-10 David Farler <dfarler@apple.com>
1775 old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
1776 https://bugs.webkit.org/show_bug.cgi?id=133663
1778 Reviewed by David Kilzer.
1780 * Scripts/old-run-webkit-tests:
1781 (installAndLaunchDumpToolAppUsingNotification):
1782 - Remove obsolete notification keys
1783 - Key off of mandatory device UDID (a UUID)
1784 - Create a device on demand via CoreSimulator if necessary
1785 -- Grab the UDID from the created device plist.
1786 * Scripts/webkitdirs.pm:
1787 (iOSSimulatorDevicesPath): Added
1788 (iOSSimulatorDevices): Added
1789 (createiOSSimulatorDevice): Added
1790 (deleteiOSSimulatorDevice): Added
1792 2014-06-10 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
1794 [GTK][gtkdoc] remove -Wcast-align
1795 https://bugs.webkit.org/show_bug.cgi?id=133640
1797 Apparently gcc warns that GParamSpec is not castable to
1798 GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
1799 though ARM hackers claim that those only need 4byte alignment. As long as gcc
1800 behaves that way, this warning is not very useful, also they break the Debian
1803 This patch appends the compiler flag -Wno-align-cast for the gtkdoc
1804 scanner compilation, thus the compiler ignores the previous
1807 Reviewed by Martin Robinson.
1809 * gtk/generate-gtkdoc:
1810 (get_generator_for_config):
1812 2014-06-09 Alexey Proskuryakov <ap@apple.com>
1814 Disable button animations in regression tests
1815 https://bugs.webkit.org/show_bug.cgi?id=133647
1816 <rdar://problem/16677530>
1818 Reviewed by Tim Horton.
1820 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1821 (WTR::InjectedBundle::platformInitialize):
1823 2014-06-09 Simon Fraser <simon.fraser@apple.com>
1825 Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
1826 https://bugs.webkit.org/show_bug.cgi?id=133650
1828 Reviewed by Tim Horton.
1830 No point checking for a Windows-style path in Cocoa code.
1832 * WebKitTestRunner/TestInvocation.cpp:
1833 (WTR::shouldUseThreadedScrolling):
1835 2014-06-09 Simon Fraser <simon.fraser@apple.com>
1837 Fix more latched scrolling test flakiness and slowness
1838 https://bugs.webkit.org/show_bug.cgi?id=133601
1840 Reviewed by Brent Fulgham.
1842 Latched scrolling tests were flakey for two reasons. First, the EventSender
1843 wheel events were async from the web to the UI process, and the resulting
1844 synthetic events also async from the UI to the web process. Make them sync
1847 Secondly, the timer-based scrolling tree commit could result in the scrolling
1848 tree (specifically the frame node's notion of the scrollable area and content
1849 size) not being updated before the scrolling thread starts getting wheel events.
1850 Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
1852 Finally remove all the now-unnecessary timeouts from the tests.
1854 * WebKitTestRunner/mac/EventSenderProxy.mm:
1855 (WTR::EventSenderProxy::mouseMoveTo):
1856 (WTR::EventSenderProxy::mouseScrollBy):
1857 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1859 2014-06-09 Andrzej Badowski <a.badowski@samsung.com>
1861 [EFL] Add parameter to MiniBrowser to disable web security
1862 https://bugs.webkit.org/show_bug.cgi?id=121095
1864 Reviewed by Gyuyoung Kim.
1866 -w (--web-security) commandline allows to disable/enable web security (enabled by default).
1867 The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
1868 resources from other domains (cross-domain requests) such as access map location on another server.
1869 Another possibility is to launch in a webkit browser local file tests that will refer to the links
1870 in the http website loaded in an iframe. It will not be possible without deactivation of web security.
1872 * MiniBrowser/efl/main.c:
1876 2014-06-06 Simon Fraser <simon.fraser@apple.com>
1880 * WebKitTestRunner/mac/EventSenderProxy.mm:
1881 (WTR::EventSenderProxy::mouseMoveTo):
1882 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1884 2014-06-06 Simon Fraser <simon.fraser@apple.com>
1886 Fix builds on 10.8; -firstObject isn't declared on NSArray there.
1888 * DumpRenderTree/mac/DumpRenderTree.mm:
1889 (createWebViewAndOffscreenWindow):
1890 * DumpRenderTree/mac/EventSendingController.mm:
1891 (-[EventSendingController mouseScrollByX:andY:continuously:]):
1892 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1893 * WebKitTestRunner/mac/EventSenderProxy.mm:
1894 (WTR::EventSenderProxy::mouseScrollBy):
1895 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1897 2014-06-06 Simon Fraser <simon.fraser@apple.com>
1899 Latched scrolling tests are flakey on Mavericks
1900 https://bugs.webkit.org/show_bug.cgi?id=133578
1901 <rdar://problem/17180591>
1903 Reviewed by Brent Fulgham.
1905 The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
1906 be wrong on machines with more than one screen. This is because we use
1907 [NSScreen mainScreen] when computing the global coordinates of the events, but
1908 [NSScreen mainScreen] returns the screen with the key window, not the first screen.
1910 So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
1911 add comments clarifying why the coordinate math works (which is not obvious given
1912 the events have no target window).
1914 Some scrolling tests also dispatched events outside the 800x600 test window, so
1915 fix those tests, and add logging that will appear in test output when this happens.
1917 * DumpRenderTree/mac/DumpRenderTree.mm:
1918 (createWebViewAndOffscreenWindow):
1919 * DumpRenderTree/mac/EventSendingController.mm:
1920 (-[EventSendingController mouseScrollByX:andY:continuously:]):
1921 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1922 * WebKitTestRunner/mac/EventSenderProxy.mm:
1923 (WTR::EventSenderProxy::mouseMoveTo):
1924 (WTR::EventSenderProxy::mouseScrollBy):
1925 (WTR::EventSenderProxy::continuousMouseScrollBy):
1926 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1928 2014-06-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
1930 [GTK] run-perf-tests should run the tests inside the jhbuild shell.
1931 https://bugs.webkit.org/show_bug.cgi?id=133533
1933 Reviewed by Carlos Garcia Campos.
1935 * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1936 (run): Remove the jhbuild-wrapper wrapper from here. It should be
1937 on Scripts/webkitpy/port/gtk.py.
1938 * Scripts/webkitpy/port/base.py:
1939 (Port.set_option): Add a set_option(name, value) function to set
1940 the optparse parameter "name" to the value "value", even if the
1941 parameter "name" is already initialized.
1942 * Scripts/webkitpy/port/gtk.py:
1943 (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
1944 If another wrapper is specified via the option "-l --wrapper=x",
1945 then prepend the jhbuild-wrapper to the one specified.
1947 2014-06-04 David Farler <dfarler@apple.com>
1949 Build ASan WebKit for iOS Simulator
1950 https://bugs.webkit.org/show_bug.cgi?id=133489
1952 Reviewed by Darin Adler.
1954 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1955 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1956 - Add missing ASan LDFLAGS.
1957 * asan/asan.xcconfig:
1958 - Split compiler-rt linker flags for OS X and iOS Simulator
1960 2014-06-03 Yoav Weiss <yoav@yoav.ws>
1962 Add myself (yoav@yoav.ws) to contributors.json
1963 https://bugs.webkit.org/show_bug.cgi?id=133492
1965 * Scripts/webkitpy/common/config/contributors.json:
1967 2014-06-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1969 REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
1970 https://bugs.webkit.org/show_bug.cgi?id=133149
1972 Reviewed by Csaba Osztrogonác.
1974 * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
1976 2014-06-02 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1978 Add a verbose flag to binding tests
1979 https://bugs.webkit.org/show_bug.cgi?id=122303
1981 Reviewed by Csaba Osztrogonác.
1984 - Add a verbose keyword argument to the BindingsTests constructor,
1985 - Add --no-verbose option to the run-bindigs-test.
1986 Verbose mode, which is on by default, prints positive results to stdout as before.
1987 When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
1989 Original patch from Matthew Hanson <matthew_hanson@apple.com>
1991 * Scripts/run-bindings-tests:
1993 * Scripts/webkitpy/bindings/main.py:
1994 (BindingsTests.__init__):
1995 (BindingsTests.detect_changes):
1997 2014-06-01 Ryosuke Niwa <rniwa@webkit.org>
1999 Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
2000 https://bugs.webkit.org/show_bug.cgi?id=133455
2002 Reviewed by Timothy Hatcher.
2004 Since the perf. dashboard doesn't support following renamed benchmarks,
2005 keep reporting Speedometer results as DoYouEvenBench results.
2007 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2008 (_generate_results_dict):
2010 2014-05-31 Darin Adler <darin@apple.com>
2012 Viewport percentage tests that resize the viewport are flaky
2013 https://bugs.webkit.org/show_bug.cgi?id=133351
2015 Reviewed by Anders Carlsson.
2017 * DumpRenderTree/mac/DumpRenderTree.mm:
2018 (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
2019 happens to be stored in the UI delegate object. This is part of resetting the
2022 * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
2023 a frame rectangle. The size is stored in the size of the web view itself.
2024 * DumpRenderTree/mac/UIDelegate.mm:
2025 (-[UIDelegate resetWindowOrigin]): Added.
2026 (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
2027 old version would store the frame, but not resize the web view!
2028 (-[UIDelegate webViewFrame:]): Get the size from the web view.
2030 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2031 (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
2033 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2034 (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
2037 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2038 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
2039 window gets resized too, not just the web view.
2040 (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
2042 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2043 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
2044 window gets resized too, not just the web view.
2045 (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
2047 2014-05-30 Michael Saboff <msaboff@apple.com>
2049 Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
2050 https://bugs.webkit.org/show_bug.cgi?id=133409
2052 Reviewed by Filip Pizlo.
2054 Handle creating a tarball the same way as running remote when processing
2055 paths in prepareBundle.
2057 * Scripts/run-jsc-stress-tests:
2059 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
2061 [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
2062 https://bugs.webkit.org/show_bug.cgi?id=132280
2064 Reviewed by Chris Fleizach.
2066 Remove implementation of logAccessibilityEvents() for ATK based
2067 ports, as this has proved to be a flaky method of checking that
2068 ATK events are being properly emitted. Instead, it's better to use
2069 the addNotificationListener() functions and provide a JS callback
2070 to check that the right events are being emmitted from the tests.
2072 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2073 (WTR::AccessibilityController::logAccessibilityEvents): Replaced
2074 with dummy implementation.
2075 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2076 (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
2078 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
2080 [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
2081 https://bugs.webkit.org/show_bug.cgi?id=132280
2083 Rubber stamped by Carlos Garcia Campos.
2085 Fix two small issues with previous patch (r169483), that caused some tests to break.
2087 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2088 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
2090 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2091 (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
2093 2014-05-30 Jarek Czekalski <jarekczek@poczta.onet.pl>
2095 [ATK] Added new accessibility signal: text-caret-moved.
2096 Make AccessibilityUIElement.setSelectedTextRange work
2097 as atk_text_set_caret_offset when given offset == 0.
2098 https://bugs.webkit.org/show_bug.cgi?id=132527
2100 Reviewed by Mario Sanchez Prada.
2102 text-caret-moved signal in accessibilityController is needed to
2103 implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
2104 as LayoutTests. Add the signal to the controller.
2106 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2107 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2108 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2109 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2110 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2111 (setSelectedTextRange): Change return type to bool.
2112 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2113 (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
2114 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2115 (axObjectEventListener): Add notification name AXTextCaretMoved, allow
2116 for extra arguments passed to handler and use it for text-caret-moved offset.
2117 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2118 Connect callback to new listener for ATK:AtkText:text-caret-moved.
2119 Refactor so that failures be reported.
2120 Initialize atk interfaces before trying to connect to them, see
2121 https://bugzilla.gnome.org/show_bug.cgi?id=729922
2122 (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2123 Simplify code by using a vector in place of dozen variables.
2124 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2125 Comment about not synchronizing with accessibilityController.
2127 2014-05-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
2129 [GTK] Add a WebKit2 Performance bot.
2130 https://bugs.webkit.org/show_bug.cgi?id=132862
2132 Reviewed by Csaba Osztrogonác.
2134 This adds a GTK WebKit2 perf bot.
2136 * BuildSlaveSupport/build.webkit.org-config/config.json:
2138 2014-05-29 Dan Bernstein <mitz@apple.com>
2140 Fixed the WebKitTestRunner build after r169452.
2142 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2143 (WTR::InjectedBundle::initialize):
2145 2014-05-28 Gwang Yoon Hwang <yoon@igalia.com>
2147 Unreviewed. Update my email addresses in contributors.json.
2149 * Scripts/webkitpy/common/config/contributors.json:
2151 2014-05-27 Jon Honeycutt <jhoneycutt@apple.com>
2153 Need an API test for bug #133193 (r169315)
2154 <https://bugs.webkit.org/show_bug.cgi?id=133324>
2156 This adds an API test that ensures that calling "stop loading" during a
2157 "did fail provisional load" callback doesn't crash.
2159 Reviewed by Andy Estes.
2161 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2162 Add new files to project.
2164 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
2165 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2166 If the message is the "test done" message, record that.
2167 (TestWebKitAPI::setInjectedBundleClient):
2168 Register a function for the "did receive message from injected bundle"
2170 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2171 Assert that we received the message from the injected bundle, and set
2172 'done' to finish the test.
2173 (TestWebKitAPI::TEST):
2174 Create a WebView, register a page loader client for the "did fail
2175 provisional load" callback, and load a non-existent resource.
2177 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
2178 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
2179 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
2180 Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
2181 provisional load failed.
2182 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
2183 Register a page loader client for the "did fail provisional load"
2185 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
2186 Call WKBundlePageStopLoading() during the callback. This not crashing
2187 is what we're ensuring with this test.
2189 2014-05-28 Carlos Garcia Campos <cgarcia@igalia.com>
2191 [GTK] Make it possible to build with FTL enabled
2192 https://bugs.webkit.org/show_bug.cgi?id=133219
2194 Reviewed by Philippe Normand.
2196 * gtk/jhbuild-optional.modules: Add llvm from svn and build the
2197 same revision than mac.
2199 2014-05-27 Michael Saboff <msaboff@apple.com>
2201 REGRESSION(r169265): sh: line 0: cd: ../.vm
2202 https://bugs.webkit.org/show_bug.cgi?id=133242
2204 Rubber stamped by Oliver Hunt.
2206 Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
2207 array since the command may contain character escapes that don't work with the
2208 array form of system().
2210 * Scripts/run-jsc-stress-tests:
2212 2014-05-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2214 [EFL] Change download url of freetype6
2215 https://bugs.webkit.org/show_bug.cgi?id=133303
2217 Reviewed by Csaba Osztrogonác.
2219 freetype6 tarball isn't downloaded in Korea. So, we need to
2220 change the url for now.
2222 * efl/jhbuild.modules:
2224 2014-05-27 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
2227 https://bugs.webkit.org/show_bug.cgi?id=132863
2229 Reviewed by Csaba Osztrogonác.
2231 * Scripts/webkitperl/FeatureList.pm:
2233 2014-05-27 Alberto Garcia <berto@igalia.com>
2235 Remove leftover comment from r165182.
2237 Rubber stamped by Carlos Garcia Campos.
2239 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2241 2014-05-26 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
2243 [EFL] Add LLVM as optional jhbuild module for FTL developers
2244 https://bugs.webkit.org/show_bug.cgi?id=133216
2246 Reviewed by Gyuyoung Kim.
2248 * efl/jhbuild.modules:
2250 2014-05-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2252 Fix test failures on python test
2253 https://bugs.webkit.org/show_bug.cgi?id=133297
2255 Reviewed by Dirk Schulze.
2257 2 tests are failing because of unbounded local variable reference in test_importer.py.
2259 * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
2260 (TestImporter.import_tests):
2262 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
2264 [GTK] GObject DOM bindings API break test fails in the tests bots
2265 https://bugs.webkit.org/show_bug.cgi?id=133211
2267 Reviewed by Martin Robinson.
2269 When generating the built product archive on platform GTK, we need
2270 to copy also the file gtkdoc-webkitdom.cfg and the directory
2271 DerivedSources/webkitdom.
2273 * BuildSlaveSupport/built-product-archive:
2274 (archiveBuiltProduct):
2276 2014-05-26 Commit Queue <commit-queue@webkit.org>
2278 Unreviewed, rolling out r169122.
2279 https://bugs.webkit.org/show_bug.cgi?id=133288
2281 Broke CJK font fallback (Requested by ap on #webkit).
2285 "[Mac] WebProcess doesn't follow localization of UI process
2286 when run as a service"
2287 https://bugs.webkit.org/show_bug.cgi?id=133126
2288 http://trac.webkit.org/changeset/169122
2290 2014-05-26 Carlos Garcia Campos <cgarcia@igalia.com>
2292 [GTK] WebProcess leaked when closing pages with network process enabled
2293 https://bugs.webkit.org/show_bug.cgi?id=129684
2295 Reviewed by Anders Carlsson.
2297 Enable the test to check that web processes finish when the web
2300 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2302 2014-05-26 Carlos Garcia Campos <cgarcia@igalia.com>
2304 REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
2305 https://bugs.webkit.org/show_bug.cgi?id=133279
2307 Reviewed by Philippe Normand.
2309 generator.saw_warnings is only set by GTKDoc::generate(), so it
2310 should only be used after generate.
2312 * gtk/generate-gtkdoc:
2313 (generate_documentation_for_config): Do not check
2314 generator.saw_warnings again, simply return the value returned by
2315 generate_doc() which is generator.saw_warnings. When rebasing,
2316 returns always False since there aren't warnings.
2318 2014-05-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
2320 W3C test importer should catch exceptions coming from HTML/CSS conversion
2321 https://bugs.webkit.org/show_bug.cgi?id=133176
2323 Reviewed by Darin Adler.
2325 Exceptions raised when converting HTML/CSS are caught.
2326 Files for which conversion failed are still copied to the target directory.
2327 Each individual conversion failure is logged.
2328 Total conversion failure number is logged at the end of the import process.
2330 * Scripts/webkitpy/w3c/test_importer.py:
2331 (TestImporter.import_tests):
2333 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
2335 [GTK] Allow to run the tests on the native X display.
2336 https://bugs.webkit.org/show_bug.cgi?id=133157
2338 Reviewed by Benjamin Poulain.
2340 This adds a new driver (xorgdriver) that runs the tests on the
2341 X display referenced by the environment variable DISPLAY.
2343 This new driver will be activated only if the environment variable
2344 USE_NATIVE_XDISPLAY is defined. This can be used both for layout
2345 tests and performance tests.
2347 This patch also makes the script run-perf-tests to check the
2348 system dependencies before starting the tests. Previously this
2349 was not checked, and if the system dependencies were not met,
2350 the script tried to execute the tests anyway, causing massive
2351 failures. For example, if you had Xvfb not installed and you
2352 wanted to use the Xvfb driver (the default on GTK and EFL),
2353 run-perf-tests would not abort.
2355 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2356 (PerfTestsRunner._parse_args): Check the system dependencies of
2357 the driver before starting the tests.
2358 * Scripts/webkitpy/port/driver.py:
2359 (Driver): Implement generic check_driver method.
2360 (Driver.check_driver):
2361 (Driver.check_driver.implementation):
2362 * Scripts/webkitpy/port/gtk.py:
2363 (GtkPort._driver_class): Check for environment variable
2364 USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
2365 * Scripts/webkitpy/port/xorgdriver.py: Added.
2366 (XorgDriver): Implement Xorg driver.
2367 (XorgDriver.check_driver):
2368 (XorgDriver._start):
2370 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
2372 REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
2373 https://bugs.webkit.org/show_bug.cgi?id=133215
2375 Reviewed by Csaba Osztrogonác.
2377 This reverts r166798.
2379 * BuildSlaveSupport/kill-old-processes:
2382 2014-05-26 Michał Pakuła vel Rutka <m.pakula@samsung.com>
2384 [EFL] Turn on ENABLE_CSS_FILTERS in build script
2385 https://bugs.webkit.org/show_bug.cgi?id=133278
2387 Reviewed by Gyuyoung Kim.
2389 * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
2391 2014-05-26 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2393 run-javascriptcore-tests warning fix on non Mac platforms
2394 https://bugs.webkit.org/show_bug.cgi?id=133260
2396 Reviewed by Darin Adler.
2398 * Scripts/webkitdirs.pm:
2399 (argumentsForConfiguration):
2401 2014-05-23 Michael Saboff <msaboff@apple.com>
2403 REGRESSION(r169265): sh: line 0: cd: ../.vm
2404 https://bugs.webkit.org/show_bug.cgi?id=133242
2406 Rubber stamped by Geoffrey Garen.
2408 Added missing shell escapes '\' required as part of previous fix.
2410 * Scripts/run-jsc-stress-tests:
2412 2014-05-23 Ryosuke Niwa <rniwa@webkit.org>
2414 Revert the erroneous change committed in r169286.
2416 * Scripts/webkitpy/performance_tests/perftest.py:
2417 (PerfTest._run_with_driver):
2419 2014-05-23 Geoffrey Garen <ggaren@apple.com>
2421 run-perf-tests should ignore whitespace lines when snarfing test output
2422 https://bugs.webkit.org/show_bug.cgi?id=133238
2424 Reviewed by Ryosuke Niwa.
2426 Required for PerformanceTests/Canvas/terrain.html.
2428 * Scripts/webkitpy/performance_tests/perftest.py:
2429 (PerfTest._run_with_driver):
2432 2014-05-23 Michael Saboff <msaboff@apple.com>
2434 REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
2435 https://bugs.webkit.org/show_bug.cgi?id=133223
2437 Reviewed by Geoffrey Garen.
2439 Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
2440 string before calling IO.popen() to work with older versions of ruby.
2441 Changed the remote path in runShellTestRunner to quote the command
2442 string we want to run via ssh so that it will work correctly with array
2443 to string conversion needed for popen.
2445 * Scripts/run-jsc-stress-tests:
2447 2014-05-23 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
2449 Remove 'css-shaders' option from the build-webkit
2450 https://bugs.webkit.org/show_bug.cgi?id=133212
2452 Reviewed by Daniel Bates.
2454 Original CSS shaders removed in r162644.
2456 * Scripts/webkitperl/FeatureList.pm:
2458 2014-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
2460 [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
2461 https://bugs.webkit.org/show_bug.cgi?id=133209
2463 Reviewed by Sergio Villar Senin.
2465 Return FAILURE when the command failed to run.
2467 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2468 (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
2470 2014-05-23 Alberto Garcia <berto@igalia.com>
2472 [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
2473 https://bugs.webkit.org/show_bug.cgi?id=133210
2475 Reviewed by Carlos Garcia Campos.
2477 * gtk/install-dependencies:
2479 2014-05-22 Benjamin Poulain <bpoulain@apple.com>
2481 Add Yusuke Suzuki to the list of contributors (for real)
2485 * Scripts/webkitpy/common/config/contributors.json:
2487 2014-05-22 Benjamin Poulain <bpoulain@apple.com>
2489 Add Yusuke Suzuki to the list of contributors
2491 * Scripts/webkitpy/common/config/contributors.json:
2493 2014-05-22 Michael Saboff <msaboff@apple.com>
2495 Eliminate n/total progress update from run-jsc-stress-tests output to file
2496 https://bugs.webkit.org/show_bug.cgi?id=133191
2498 Reviewed by Geoffrey Garen.
2500 Changed progressMeter setting to be based on stdout being a tty instead of
2501 stdin. Unified the processing of output from the shell runner to match the
2502 same processing as is used by the makefile runner. As part of this, the
2503 shell runner script was simplified. It now forwards the output of each
2504 test_script just like the Makefile and doesn't provide its own progress.
2506 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2507 * Scripts/run-jsc-stress-tests:
2509 2014-05-22 Michael Saboff <msaboff@apple.com>
2511 Add option to run-jsc-stress-tests to use installed jsc
2512 https://bugs.webkit.org/show_bug.cgi?id=133102
2514 Reviewed by Geoffrey Garen.
2516 Added --no-copy option to not copy a JavaScriptCore framework, but use the one
2517 provied with the --jsc option.
2519 * Scripts/run-jsc-stress-tests:
2521 2014-05-21 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
2523 [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
2524 https://bugs.webkit.org/show_bug.cgi?id=132907
2526 Reviewed by Gyuyoung Kim.
2528 We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
2529 in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
2531 * efl/install-dependencies:
2533 2014-05-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2535 REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
2536 https://bugs.webkit.org/show_bug.cgi?id=133145
2538 Reviewed by Csaba Osztrogonác.
2540 * Scripts/run-jsc-stress-tests:
2542 2014-05-20 Alexey Proskuryakov <ap@apple.com>
2544 [Mac] WebProcess doesn't follow localization of UI process when run as a service
2545 https://bugs.webkit.org/show_bug.cgi?id=133126
2546 <rdar://problem/13396515>
2547 <rdar://problem/16561084>
2549 Reviewed by Sam Weinig and Tim Horton.
2551 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2552 (WTR::InjectedBundle::platformInitialize): It was too late to override language
2553 here, and it's not necessary any more. Keeping the code for older OS versions in
2554 case it did have effect in some code paths.
2556 2014-05-19 David Farler <dfarler@apple.com>
2558 Move WebKitTestRunner to std::unique_ptr
2559 https://bugs.webkit.org/show_bug.cgi?id=133081
2561 Reviewed by Daniel Bates.
2563 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2564 (WTR::InjectedBundle::didCreatePage):
2565 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2566 * WebKitTestRunner/TestController.cpp:
2567 (WTR::TestController::initialize):
2568 (WTR::TestController::createWebViewWithOptions):
2569 (WTR::TestController::resetStateToConsistentValues):
2570 (WTR::TestController::runTest):
2571 * WebKitTestRunner/TestController.h:
2572 * WebKitTestRunner/TestInvocation.cpp:
2573 * WebKitTestRunner/TestInvocation.h:
2574 * WebKitTestRunner/WorkQueueManager.cpp:
2575 (WTR::WorkQueueManager::processWorkQueue):
2576 (WTR::WorkQueueManager::enqueue):
2577 * WebKitTestRunner/WorkQueueManager.h:
2579 2014-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
2581 [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
2582 https://bugs.webkit.org/show_bug.cgi?id=133119
2584 Reviewed by Sergio Villar Senin.
2586 Check that redirect response parameter of
2587 WebKitWebPage::send-request signal is NULL when not redirecting
2588 and a valid WebKitURIResponse object when redirecting.
2590 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2591 (testWebResourceSendRequest):
2593 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2594 (sendRequestCallback):
2596 2014-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
2598 REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
2599 https://bugs.webkit.org/show_bug.cgi?id=133117
2601 Reviewed by Philippe Normand.
2603 Bring back missing tests to the build.
2605 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2607 2014-05-19 Filip Pizlo <fpizlo@apple.com>
2609 Take care of some ARM64 test failures
2610 https://bugs.webkit.org/show_bug.cgi?id=133090
2612 Reviewed by Geoffrey Garen.
2614 * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
2616 2014-05-19 David Kilzer <ddkilzer@apple.com>
2618 [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
2619 <http://webkit.org/b/133089>
2621 Reviewed by Darin Adler.
2623 * Scripts/webkitdirs.pm:
2624 (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
2625 specified on the command line, we would remove the '--sdk'
2626 arguments, but leave '--sim', potentially passing it along to
2627 xcodebuild causing a build failure. This happens when
2628 'old-run-webkit-tests --release --sim' invokes
2629 build-dumprendertree when DumpRenderTree hasn't been built yet.
2631 2014-05-19 David Farler <dfarler@apple.com>
2633 Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
2634 https://bugs.webkit.org/show_bug.cgi?id=133086
2636 Reviewed by Daniel Bates.
2638 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2640 2014-05-19 David Kilzer <ddkilzer@apple.com>
2642 REGRESSION (r169042): Fix run-api-tests on Mountain Lion
2643 <http://webkit.org/b/132954>
2645 * Scripts/webkitdirs.pm:
2646 (sharedCommandLineOptionsUsage): Remove the prototype for the
2647 subroutine. Older perls don't like the "+@" syntax.
2649 2014-05-19 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2651 run-javascriptcore-tests should sort the list of failing stress tests
2652 https://bugs.webkit.org/show_bug.cgi?id=132989
2654 Reviewed by Csaba Osztrogonác.
2656 * Scripts/run-javascriptcore-tests:
2658 2014-05-19 David Kilzer <ddkilzer@apple.com>
2660 webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
2661 <http://webkit.org/b/132954>
2663 Reviewed by Darin Adler.
2665 Extract code into setupMacWebKitEnvironment() for setting up
2666 common environment variables so it may be shared. Sets
2667 __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
2668 using guardmalloc to some scripts.
2670 Also adds support for parsing shared (common) command-line
2671 switches, initially just -g|--guard-malloc.
2673 * Scripts/bisect-builds: Add -g|--guard-malloc support by using
2674 sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
2675 (mountAndRunNightly): Call setupMacWebKitEnvironment(). Use a
2676 local copy of %ENV when launching Safari so we don't have to
2679 * Scripts/run-api-tests: Add -g|--guard-malloc support by using
2680 sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
2681 Check result of GetOptions() to catch invalid command-line
2683 (runTest): Use a local copy of %ENV when running tests so we
2684 don't have to restore variables.
2685 (prepareEnvironmentForRunningTestTool): Call
2686 setupMacWebKitEnvironment().
2688 * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
2689 using sharedCommandLineOptions() and
2690 sharedCommandLineOptionsUsage(). Call
2691 setupMacWebKitEnvironment().
2693 * Scripts/webkitdirs.pm:
2694 (sharedCommandLineOptions): Return array of common switches to
2695 pass to Getopt::Long::GetOptions().
2696 (sharedCommandLineOptionsUsage): Return formatted string of
2697 common switches for printing usage help text.
2698 (setUpGuardMallocIfNeeded): Support using '-g' for enabling
2700 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
2701 (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
2702 and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
2703 (runMacWebKitApp): Call setupMacWebKitEnvironment(). Use a
2704 local copy of %ENV when launching Safari so we don't have to
2706 (execMacWebKitAppForDebugging): Call
2707 setupMacWebKitEnvironment().
2709 2014-05-18 Rik Cabanier <cabanier@adobe.com>
2711 support for navigator.hardwareConcurrency
2712 https://bugs.webkit.org/show_bug.cgi?id=132588
2714 Reviewed by Filip Pizlo.
2716 * Scripts/webkitperl/FeatureList.pm:
2718 2014-05-18 Anders Carlsson <andersca@apple.com>
2720 Implement Navigations for all methods declared returning one
2721 https://bugs.webkit.org/show_bug.cgi?id=133048
2722 <rdar://problem/16830064>
2724 Reviewed by Sam Weinig.
2726 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2729 * MiniBrowser/mac/WK2BrowserWindowController.m:
2730 (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2731 (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2732 (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2733 (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2734 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2735 (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2736 Print out the navigations.
2738 2014-05-17 Zalan Bujtas <zalan@apple.com>
2740 Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
2741 https://bugs.webkit.org/show_bug.cgi?id=133029
2743 Reviewed by Simon Fraser.
2745 Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
2746 toggling it on a WK2 window needs restart.
2747 Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
2748 the WebPreferences just to support this temporary toggle.
2750 * MiniBrowser/mac/BrowserWindowController.h:
2751 * MiniBrowser/mac/MainMenu.xib:
2752 * MiniBrowser/mac/WK1BrowserWindowController.m:
2753 (-[WK1BrowserWindowController validateMenuItem:]):
2754 (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
2755 (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
2756 * MiniBrowser/mac/WK2BrowserWindowController.m:
2757 (-[WK2BrowserWindowController validateMenuItem:]):
2758 (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
2759 (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
2761 2014-05-17 Anders Carlsson <andersca@apple.com>
2763 Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
2764 https://bugs.webkit.org/show_bug.cgi?id=133033
2765 <rdar://problem/16830143>
2767 Reviewed by Sam Weinig.
2769 Set up the WebSQL and IndexedDB directories.
2771 * WebKitTestRunner/TestController.cpp:
2772 (WTR::TestController::initialize):
2774 2014-05-16 Martin Hock <mhock@apple.com>
2776 MemoryCache::addImageToCache should return the result of add().
2777 https://bugs.webkit.org/show_bug.cgi?id=132928
2778 <rdar://problem/16651547>
2780 Reviewed by Alexey Proskuryakov.
2782 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2783 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2784 * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
2785 (TestWebKitAPI::TEST):
2787 2014-05-15 David Farler <dfarler@apple.com>
2789 old-run-webkit-tests: allow specifying a simulator app path
2790 https://bugs.webkit.org/show_bug.cgi?id=132975
2792 Reviewed by Anders Carlsson.
2794 * Scripts/old-run-webkit-tests:
2795 (openIPhoneSimulator):
2796 Add new --simulator-app command line parameter for specifying the
2797 absolute path to the simulator app to launch before starting a
2800 2014-05-16 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2802 [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
2803 https://bugs.webkit.org/show_bug.cgi?id=131363
2805 Reviewed by Csaba Osztrogonác.
2807 * Scripts/webkitpy/common/checkout/checkout_mock.py:
2808 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2810 * Scripts/webkitpy/tool/commands/download_unittest.py:
2811 (test_create_rollout_multiple_revision_with_one_resolved):
2812 (test_create_rollout_multiple_resolved):
2813 (test_rollout_two_revisions):
2814 (test_rollout_multiple_revisions):
2815 (test_rollout_multiple_revisions_with_a_missing_bug_id):
2816 * Scripts/webkitpy/tool/steps/createbug.py:
2818 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2819 (ReopenBugAfterRollout.run):
2821 2014-05-16 Martin Hodovan <mhodovan.u-szeged@partner.samsung.com>
2823 [WK2] Change the remaining framework includes from WebKit2 to WebKit
2824 https://bugs.webkit.org/show_bug.cgi?id=132956
2826 Reviewed by Sam Weinig.
2828 * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
2829 * MiniBrowser/mac/AppDelegate.m:
2830 * MiniBrowser/mac/WK2BrowserWindowController.m:
2831 * TestWebKitAPI/InjectedBundleController.h:
2832 * TestWebKitAPI/InjectedBundleMain.cpp:
2833 * TestWebKitAPI/JavaScriptTest.cpp:
2834 * TestWebKitAPI/PlatformUtilities.h:
2835 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2836 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2837 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2838 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2839 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2840 (TestWebKitAPI::TEST):
2841 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
2842 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
2843 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2844 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2845 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2846 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2847 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2848 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2849 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2850 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2851 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2852 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2853 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2854 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2855 * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2856 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2857 * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2858 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2859 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2860 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2861 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2862 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2863 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2864 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2865 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2866 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2867 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2868 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2869 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2870 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2871 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2872 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2873 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2874 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2875 * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2876 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2877 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2878 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2879 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2880 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2881 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2882 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2883 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2884 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2885 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2886 * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2887 * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2888 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2889 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2890 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2891 * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2892 * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2893 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2894 * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2895 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2896 * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
2897 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2898 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2899 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2900 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2901 * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2902 * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2903 * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2904 * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2905 * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2906 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2907 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
2908 * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2909 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2910 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
2911 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2912 * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
2913 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2914 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2915 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2916 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2917 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2918 * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2919 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2920 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2921 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2922 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2923 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2924 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2925 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2926 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2927 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2928 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2929 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2930 * TestWebKitAPI/config.h:
2931 * TestWebKitAPI/efl/PlatformWebView.cpp:
2932 * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2933 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2934 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2935 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2936 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2937 * WebKitTestRunner/EventSenderProxy.h:
2938 * WebKitTestRunner/GeolocationProviderMock.cpp:
2939 * WebKitTestRunner/GeolocationProviderMock.h:
2940 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2941 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2942 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2943 * WebKitTestRunner/InjectedBundle/GCController.cpp:
2944 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2945 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2946 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2947 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2948 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2949 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2950 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2951 * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2952 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2953 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2954 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2955 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2956 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2957 * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
2958 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2959 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2960 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2961 * WebKitTestRunner/PlatformWebView.h:
2962 * WebKitTestRunner/StringFunctions.h:
2963 * WebKitTestRunner/TestController.cpp:
2964 * WebKitTestRunner/TestController.h:
2965 * WebKitTestRunner/TestInvocation.cpp:
2966 * WebKitTestRunner/TestInvocation.h:
2967 * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2968 * WebKitTestRunner/WebNotificationProvider.cpp:
2969 * WebKitTestRunner/WebNotificationProvider.h:
2970 * WebKitTestRunner/WorkQueueManager.cpp:
2971 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2972 * WebKitTestRunner/cg/TestInvocationCG.cpp:
2973 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2974 * WebKitTestRunner/config.h:
2975 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2976 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2977 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2978 * WebKitTestRunner/ios/TestControllerIOS.mm:
2979 * WebKitTestRunner/mac/EventSenderProxy.mm:
2980 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2981 * WebKitTestRunner/mac/TestControllerMac.mm:
2983 2014-05-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2985 [EFL][WK2] Skip failing unit tests
2986 https://bugs.webkit.org/show_bug.cgi?id=132979
2988 Reviewed by Daniel Bates.
2990 * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
2992 2014-05-15 David Kilzer <ddkilzer@apple.com>
2994 [iOS] Support TestWebKitAPI in the iOS Simulator
2995 <http://webkit.org/b/129535>
2996 <rdar://problem/16203529>
2998 Reviewed by Daniel Bates.
3000 * Scripts/run-api-tests:
3003 - Extract common arguments into local variable.
3004 - Use xcrun to find the sim tool in order to invoke
3005 TestWebKitAPI properly in the iOS Simulator.
3007 * Scripts/webkitdirs.pm:
3008 (argumentsForConfiguration): Set --device or --sim as
3009 appropriate to fix buildTestTool() in run-api-tests.
3011 2014-05-15 Tim Horton <timothy_horton@apple.com>
3013 Fix a logging typo in copy-webkitlibraries-to-product-directory
3015 Reviewed by Dean Jackson.
3017 * Scripts/copy-webkitlibraries-to-product-directory:
3019 2014-05-15 David Kilzer <ddkilzer@apple.com>
3021 TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
3022 <http://webkit.org/b/132959>
3024 Reviewed by Dan Bernstein.
3026 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
3027 Cocoa directory to project and move URLExtras.mm into it.
3028 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
3030 2014-05-15 Carlos Garcia Campos <cgarcia@igalia.com>
3032 [GTK] Compile all installed resources as GResources
3033 https://bugs.webkit.org/show_bug.cgi?id=131099
3035 Reviewed by Philippe Normand.
3037 * Scripts/webkitpy/port/gtk.py:
3038 (GtkPort.setup_environ_for_server): Removed now unneeded
3039 AUDIO_RESOURCES_PATH env var.
3041 2014-05-14 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
3043 Remove CSS_STICKY_POSITION guards
3044 https://bugs.webkit.org/show_bug.cgi?id=132676
3046 Reviewed by Simon Fraser.
3048 * Scripts/webkitperl/FeatureList.pm:
3050 2014-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
3052 REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
3053 https://bugs.webkit.org/show_bug.cgi?id=132686
3055 Reviewed by Philippe Normand.
3057 Bring back InputMethodFilter test to the build and compile it into
3058 a single binary TestWebCore with the other WebCore tests. Also
3059 move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
3061 * Scripts/run-gtk-tests:
3062 (TestRunner): Remove WebCoreGtk from the list of test directories.
3063 * TestWebKitAPI/PlatformGTK.cmake:
3064 * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
3066 2014-05-14 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
3068 [EFL] Make XVFBDriver optional
3069 https://bugs.webkit.org/show_bug.cgi?id=131036
3071 Reviewed by Gyuyoung Kim.
3073 * Scripts/webkitpy/port/efl.py:
3074 (EflPort._driver_class):
3076 2014-05-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
3078 Flakiness dashboard contains outdated list of bots on builders.jsonp
3079 https://bugs.webkit.org/show_bug.cgi?id=132874
3081 Reviewed by Darin Adler.
3083 * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
3084 file by changing to the directory Tools/TestResultServer and executing
3085 the script generate_builders_json.py
3087 2014-05-11 Anders Carlsson <andersca@apple.com>
3089 Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
3090 https://bugs.webkit.org/show_bug.cgi?id=132809
3092 Reviewed by Dan Bernstein.
3094 * WebKitTestRunner/TestController.cpp:
3095 (WTR::TestController::initialize):
3096 Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
3098 2014-05-12 Carlos Garcia Campos <cgarcia@igalia.com>
3100 REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
3101 https://bugs.webkit.org/show_bug.cgi?id=132739
3103 Reviewed Anders Carlsson.
3105 * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
3107 * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
3109 2014-05-11 Anders Carlsson <andersca@apple.com>
3111 Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
3112 https://bugs.webkit.org/show_bug.cgi?id=132806
3114 Reviewed by Beth Dakin.
3116 Migrate to WKContextConfiguration.
3118 * WebKitTestRunner/TestController.cpp:
3119 (WTR::TestController::initialize):
3121 2014-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
3123 REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
3124 https://bugs.webkit.org/show_bug.cgi?id=132685
3126 Reviewed by Martin Robinson.
3128 Use a single TestWebKit2 binary for all WebKit2 C API tests.
3130 * TestWebKitAPI/PlatformGTK.cmake:
3132 2014-05-09 Benjamin Poulain <benjamin@webkit.org>
3134 [iOS] Switch geolocation to an explicit authorization query model
3135 https://bugs.webkit.org/show_bug.cgi?id=132717
3137 Reviewed by Sam Weinig.
3139 * DumpRenderTree/mac/MockGeolocationProvider.mm:
3140 (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
3141 (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
3143 2014-05-09 David Farler <dfarler@apple.com>
3145 com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
3146 https://bugs.webkit.org/show_bug.cgi?id=132718
3148 Reviewed by David Kilzer.
3150 The simulator may not be able to look up runtimes by SDK paths
3151 and instead will map SDK versions to runtimes instead. In
3152 com.apple.iphonesimulator.startSession notifications,
3153 'runtimeIdentifier' (SDK version string) is preferred over
3154 'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
3155 when creating a new DRT or WKTR simulator session.
3157 IPhoneSimulatorNotification.pm filters out keys for this
3158 notification's userInfo with a hard-coded list. There's no harm
3159 in including extra key-value pairs in an NSNotification userInfo
3160 dictionary anyway and the simulator may again change its
3161 userInfo schema for this notification.
3163 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3164 (postStartSessionNotification):
3165 * Scripts/old-run-webkit-tests:
3166 (installAndLaunchDumpToolAppUsingNotification):
3168 2014-05-09 Anders Carlsson <andersca@apple.com>
3172 * Scripts/build-webkit:
3173 WebKit2 should always be built for OS X and iOS.
3175 2014-05-09 Anders Carlsson <andersca@apple.com>
3177 Follow-up build fix.
3179 * Scripts/build-webkit:
3180 WebKit2 should no longer be built before WebKit.
3182 2014-05-09 Anders Carlsson <andersca@apple.com>
3184 Rename WebKit2.framework to WebKit.framework
3185 https://bugs.webkit.org/show_bug.cgi?id=132743
3186 <rdar://problem/15920046>
3188 Reviewed by Dan Bernstein.
3190 * Scripts/check-for-inappropriate-files-in-framework:
3191 Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
3192 Change WebKit2 to WebKit.
3194 * Scripts/check-for-webkit-framework-include-consistency:
3195 Change WebKit to WebKitLegacy.
3197 2014-05-09 Manuel Rego Casasnovas <rego@igalia.com>
3199 Remove GTK+ WK1 EWS from build.webkit.org/dashboard
3200 https://bugs.webkit.org/show_bug.cgi?id=132732
3202 Reviewed by Alexey Proskuryakov.
3204 GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
3206 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3207 (EWS): Remove GTK+ WK1 EWS.
3209 2014-05-09 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3211 Add new u-szeged contributors.
3213 Reviewed by Csaba Osztrogonác.
3215 * Scripts/webkitpy/common/config/contributors.json:
3217 2014-05-09 Carlos Garcia Campos <cgarcia@igalia.com>
3219 REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
3220 https://bugs.webkit.org/show_bug.cgi?id=132736
3222 Reviewed by Philippe Normand.
3224 There are two problems, the path returned by common.library_build_path() is wrong when
3225 common.binary_build_path() has previously been called, and the test is still looking for
3226 the .la instead of .so
3228 * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3229 (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
3230 of .la as extension of the injected bundle library.
3232 (binary_build_path): Remove unused global variable and add a new
3233 one for binary_build_dir instead of sharing the same global
3234 variable for library_build_path and binary_build_path.
3236 2014-05-08 Praveen R Jadhav <praveen.j@samsung.com>
3238 [EFL] Enable MEDIA_STREAM for EFL port
3239 https://bugs.webkit.org/show_bug.cgi?id=132648
3241 Reviewed by Gyuyoung Kim.
3243 Script modified to enable MEDIA_STREAM for EFL build.
3245 * Scripts/webkitperl/FeatureList.pm:
3247 2014-05-08 David Farler <dfarler@apple.com>
3249 old-run-webkit-tests: update strings for simulator devices and app name
3250 https://bugs.webkit.org/show_bug.cgi?id=132687
3252 Reviewed by Darin Adler.
3254 iPhone Retina (4-inch) -> iPhone 5
3255 iPhone Retina (4-inch 64-bit) -> iPhone 5s
3257 * Scripts/old-run-webkit-tests:
3258 (installAndLaunchDumpToolAppUsingNotification):
3259 (openIPhoneSimulator):
3260 (quitIPhoneSimulator):
3261 quit iOS Simulator, not iPhone Simulator.
3263 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
3265 REGRESSION(r168471): Update the builder names on the scheduler list.
3266 https://bugs.webkit.org/show_bug.cgi?id=132699
3268 Reviewed by Martin Robinson.
3270 On r168471 I missed to update the builder names for the GTK build
3271 bots on the AnyBranchScheduler type scheduler list of bots.
3273 * BuildSlaveSupport/build.webkit.org-config/config.json:
3275 2014-05-08 Brady Eidson <beidson@apple.com>
3277 "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
3278 <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
3280 Reviewed by Tim Horton.
3282 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
3283 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
3285 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
3287 REGRESSION(r168471): Duplicate builddirs broke the build master.
3288 https://bugs.webkit.org/show_bug.cgi?id=132688
3290 Reviewed by Carlos Garcia Campos.
3292 Rename the builddirs of the new GTK bots introduced on r168471 to
3293 be unique. Otherwise the master will break.
3295 * BuildSlaveSupport/build.webkit.org-config/config.json:
3297 2014-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
3299 [GTK] webkitdom script assumes mkdir only fails because the directory already exists
3300 https://bugs.webkit.org/show_bug.cgi?id=132674
3302 Reviewed by Philippe Normand.
3304 Only ignore mkdir failure when exception is raised because the
3305 file already exists and it's a directory.
3310 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
3312 [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
3313 https://bugs.webkit.org/show_bug.cgi?id=131358
3315 Reviewed by Carlos Garcia Campos.
3317 Current 64-bit GTK build bots (Release and Debug) not only test
3318 the build, but run all tests. Split each one of the bots in
3319 BuildOnly and TestWebKit2.
3321 This will allow us to have a better overview of the status of
3324 Original patch from Sergio Villar Senin <svillar@igalia.com>
3326 * BuildSlaveSupport/build.webkit.org-config/config.json:
3327 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3328 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3330 * Scripts/webkitpy/port/builders.py:
3331 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3332 (TestRebaselineTest.test_baseline_directory):
3333 * TestResultServer/static-dashboards/builders.jsonp:
3334 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3336 * TestResultServer/static-dashboards/loader_unittests.js:
3338 2014-05-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3340 [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
3341 https://bugs.webkit.org/show_bug.cgi?id=126022
3343 Reviewed by Benjamin Poulain.
3345 Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
3347 Added an unit test case to check if scroll position and scale are restored properly.
3349 * TestWebKitAPI/PlatformEfl.cmake:
3350 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
3351 (TestWebKitAPI::didFinishLoadForFrame):
3352 (TestWebKitAPI::didChangeContentsPosition):
3353 (TestWebKitAPI::TEST):
3354 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
3355 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
3357 2014-05-07 Simon Fraser <simon.fraser@apple.com>
3359 WebKit1 is flashy when compositing layers come and go
3360 https://bugs.webkit.org/show_bug.cgi?id=132655
3361 <rdar://problem/16830981&16788846>
3363 Reviewed by Sam Weinig.
3365 Revert the change from r166117.
3367 * DumpRenderTree/mac/DumpRenderTree.mm:
3370 2014-05-07 Chris Fleizach <cfleizach@apple.com>
3372 AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
3373 https://bugs.webkit.org/show_bug.cgi?id=132622
3375 Reviewed by Mario Sanchez Prada.
3377 * DumpRenderTree/AccessibilityUIElement.cpp:
3378 (selectTextWithCriteriaCallback):
3380 * DumpRenderTree/AccessibilityUIElement.h:
3381 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3382 (AccessibilityUIElement::selectTextWithCriteria):
3383 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3384 (AccessibilityUIElement::selectTextWithCriteria):
3385 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3386 (selectTextParameterizedAttributeForCriteria):
3387 (AccessibilityUIElement::selectTextWithCriteria):
3388 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3389 (AccessibilityUIElement::selectTextWithCriteria):
3390 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3391 (WTR::AccessibilityUIElement::selectTextWithCriteria):
3392 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3393 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3394 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3395 (WTR::AccessibilityUIElement::selectTextWithCriteria):
3396 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3397 (WTR::AccessibilityUIElement::selectTextWithCriteria):
3398 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3399 (WTR::selectTextParameterizedAttributeForCriteria):
3400 (WTR::AccessibilityUIElement::selectTextWithCriteria):
3402 2014-05-07 Carlos Garcia Campos <cgarcia@igalia.com>
3404 [SOUP] TLSErrors do not cause page load to fail when not ignored
3405 https://bugs.webkit.org/show_bug.cgi?id=121548
3407 Reviewed by Sergio Villar Senin.
3409 Add unit tests to check that the load fails with TLS errors in
3410 case of a redirection.
3412 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3413 (testTLSErrorsRedirect):
3414 (httpsServerCallback):
3417 2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
3419 [CSS Grid Layout] Remove runtime feature
3420 https://bugs.webkit.org/show_bug.cgi?id=132382
3422 Reviewed by Benjamin Poulain.
3424 Remove cssGridLayoutEnabled setting usage.
3426 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3427 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3428 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3429 (TestRunner::overridePreference):
3430 * DumpRenderTree/mac/DumpRenderTree.mm:
3431 (resetWebPreferencesToConsistentValues):
3433 2014-05-06 David Kilzer <ddkilzer@apple.com>
3435 Add Makefile targets for copying static libraries (LLVM and WKSI)
3436 <http://webkit.org/b/132619>
3438 Reviewed by Mark Rowe.
3440 * Scripts/copy-webkitlibraries-to-product-directory: Set a
3441 sensible default for product directory if not specified on
3442 either the command-line or in the environment (by Xcode) by
3443 calling productDir() in webkitdirs.pm.
3445 2014-05-06 Brady Eidson <beidson@apple.com>
3447 Add WK2 SPI to prevent the previous back/forward item from remaining in the list
3448 <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
3450 Reviewed by Sam Weinig.
3452 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3454 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
3455 (TestWebKitAPI::itemURLLastComponentIsString):
3456 (TestWebKitAPI::didFinishLoadForFrame):
3457 (TestWebKitAPI::willGoToBackForwardListItem):
3458 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
3459 (TestWebKitAPI::setPageLoaderClient):
3460 (TestWebKitAPI::TEST):
3461 * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
3462 * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
3464 * WebKitTestRunner/TestController.cpp:
3465 (WTR::TestController::createWebViewWithOptions): Update for new client layout.
3467 2014-05-06 Darin Adler <darin@apple.com>
3469 Try to fix iOS build.
3471 * DumpRenderTree/mac/TestRunnerMac.mm:
3472 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
3473 Updated since I changed testRunner into a pointer instead of a reference.
3474 Updated argument names to avoid conflict with field names.
3475 (-[APITestDelegateIPhone run]): Ditto.
3476 (-[APITestDelegateIPhone _cleanUp]): Ditto.
3478 2014-05-06 Commit Queue <commit-queue@webkit.org>
3480 Unreviewed, rolling out r168304.
3481 https://bugs.webkit.org/show_bug.cgi?id=132607
3483 Broke the build (Requested by KaL on #webkit).
3487 "[GTK][CMake] Unable to do make install"
3488 https://bugs.webkit.org/show_bug.cgi?id=130188
3489 http://trac.webkit.org/changeset/168304
3491 2014-05-04 Darin Adler <darin@apple.com>
3493 RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
3494 https://bugs.webkit.org/show_bug.cgi?id=80222
3496 Reviewed by Alexey Proskuryakov.
3498 * DumpRenderTree/mac/TestRunnerMac.mm:
3499 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
3500 do more work here so we don't use RetainPtr local variables.
3501 (-[APITestDelegateIPhone dealloc]): Added.
3502 (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
3503 created. Updated for changes to member names and types.
3504 (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
3505 updated for changes to member names and types. Changed to two word spelling.
3506 (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
3507 name of _cleanUp method.
3508 (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
3510 (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
3512 2014-05-05 Benjamin Poulain <benjamin@webkit.org>
3514 Clean up Image Document and tweak the layout and viewport
3515 https://bugs.webkit.org/show_bug.cgi?id=132552
3517 Reviewed by Anders Carlsson.
3519 * DumpRenderTree/mac/DumpRenderTree.mm:
3520 (resetWebPreferencesToConsistentValues):
3521 Update the default settings to have something consistent with WebKit2.
3523 2014-05-05 Martin Robinson <mrobinson@igalia.com>
3525 [GTK][CMake] Unable to do make install
3526 https://bugs.webkit.org/show_bug.cgi?id=130188
3528 Reviewed by Carlos Garcia Campos.
3530 * Scripts/webkitdirs.pm:
3531 (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
3532 will give an early signal that a change has broken the documentation.
3534 2014-05-05 Pratik Solanki <psolanki@apple.com>
3536 Update framework locations in package-root
3537 https://bugs.webkit.org/show_bug.cgi?id=132571
3539 Reviewed by Simon Fraser.
3541 * Scripts/package-root:
3543 2014-05-05 Ryuan Choi <ryuan.choi@samsung.com>
3545 [EFL][WK2] Refactor favicon database APIs
3546 https://bugs.webkit.org/show_bug.cgi?id=132519
3548 Reviewed by Gyuyoung Kim.
3550 * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
3551 (update_view_favicon):
3552 (on_icon_changed_cb):
3556 (on_view_favicon_changed): Deleted.
3558 2014-05-02 Mark Rowe <mrowe@apple.com>
3560 <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
3562 Reviewed by Dan Bernstein.
3564 * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
3565 when determining which LLVM archive to extract.
3567 2014-05-02 Jeremy Jones <jeremyj@apple.com>
3569 Add Jeremy as a committer.
3570 https://bugs.webkit.org/show_bug.cgi?id=132492
3572 Reviewed by Jer Noble.
3574 Add myself as a committer.
3576 * Scripts/webkitpy/common/config/contributors.json:
3578 2014-05-02 Jeremy Jones <jeremyj@apple.com>
3580 Add Jeremy as a committer.
3581 https://bugs.webkit.org/show_bug.cgi?id=132492
3583 Reviewed by Jer Noble.
3585 Add Jeremy Jones to the committers file.
3587 * Scripts/webkitpy/common/config/contributors.json:
3589 2014-05-02 Brian J. Burg <burg@cs.washington.edu>
3591 Hard to figure out how to run a single test with run-api-tests
3592 https://bugs.webkit.org/show_bug.cgi?id=116332
3594 Reviewed by Alexey Proskuryakov.
3596 * Scripts/run-api-tests: add two examples to the help message.
3598 2014-05-02 Simon Fraser <simon.fraser@apple.com>
3600 Fix several memory leaks found by code inspection
3601 https://bugs.webkit.org/show_bug.cgi?id=132472
3603 Reviewed by Geoffrey Garen.
3607 * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3608 (TestWebKitAPI::TEST):
3609 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3610 (WTR::InjectedBundlePage::willSendRequestForFrame):
3611 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3612 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3614 2014-05-02 Filip Pizlo <fpizlo@apple.com>
3616 DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
3617 https://bugs.webkit.org/show_bug.cgi?id=132446
3619 Reviewed by Mark Hahnenberg.
3621 Test the FTL by default now that it's enabled by default.
3623 * Scripts/run-javascriptcore-tests:
3625 2014-05-01 Ryuan Choi <ryuan.choi@samsung.com>
3627 [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
3628 https://bugs.webkit.org/show_bug.cgi?id=132240
3630 Reviewed by Anders Carlsson.
3632 Removed ewk_view_setting_tiled_backingstore related code.
3634 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3635 (DumpRenderTreeChrome::createView):
3636 (shouldUseTiledBackingStore): Deleted.
3637 * EWebLauncher/main.c:
3639 (parseUserArguments):
3641 2014-05-01 Anders Carlsson <andersca@apple.com>
3643 window.testRunner.keepWebHistory() should update the UI process state
3644 https://bugs.webkit.org/show_bug.cgi?id=132440
3646 Reviewed by Dan Bernstein.
3648 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3649 (WTR::InjectedBundle::postSetAddsVisitedLinks):
3650 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3651 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3652 (WTR::TestRunner::keepWebHistory):
3653 * WebKitTestRunner/TestInvocation.cpp:
3654 (WTR::TestInvocation::invoke):
3655 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3657 2014-05-01 David Kilzer <ddkilzer@apple.com>