Unreviewed, rolling out r242702.
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Truitt Savell  <tsavell@apple.com>
2
3         Unreviewed, rolling out r242702.
4
5         Broke High Sierra builders.
6
7         Reverted changeset:
8
9         "Add utility function to allow easy reverse range-based
10         iteration of a container"
11         https://bugs.webkit.org/show_bug.cgi?id=195542
12         https://trac.webkit.org/changeset/242702
13
14 2019-03-11  Sam Weinig  <sam@webkit.org>
15
16         Add utility function to allow easy reverse range-based iteration of a container
17         https://bugs.webkit.org/show_bug.cgi?id=195542
18
19         Reviewed by Antti Koivisto.
20
21         * TestWebKitAPI/CMakeLists.txt:
22         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
24         (TestWebKitAPI::TEST):
25         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
26
27 2019-03-10  Alex Christensen  <achristensen@webkit.org>
28
29         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
30         https://bugs.webkit.org/show_bug.cgi?id=195511
31         <rdar://problem/44873269>
32
33         Reviewed by Darin Adler.
34
35         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
36         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
37         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
38         (TEST_F):
39
40 2019-03-10  Tim Horton  <timothy_horton@apple.com>
41
42         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
43         https://bugs.webkit.org/show_bug.cgi?id=195499
44
45         Reviewed by Darin Adler.
46
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
49         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
50         (-[WKWebView synchronouslyFocusTextInputContext:]):
51         (applyStyle):
52         (applyIframe):
53         (TEST):
54         Add some tests for this SPI.
55
56 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
57
58         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
59         https://bugs.webkit.org/show_bug.cgi?id=181151
60
61         Reviewed by Don Olmstead.
62
63         * TestWebKitAPI/CMakeLists.txt:
64         * TestWebKitAPI/PlatformWin.cmake:
65         Enable TestWTF RunLoop tests in all platforms.
66
67         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
68         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
69         (TestWebKitAPI::DerivedOneShotTimer::fired):
70         (TestWebKitAPI::TEST):
71         Only a few platforms support nested RunLoop.
72
73         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
74         (TestWebKitAPI::DerivedRepeatingTimer::fired):
75
76 2019-03-10  David Quesada  <david_quesada@apple.com>
77
78         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
79         https://bugs.webkit.org/show_bug.cgi?id=152480
80
81         Reviewed by Chris Dumez.
82
83         Add a unit test based on Daniel Bates's test case that starts a download, ensures
84         there are no additional references to the process pool besides the one held by
85         the download, waits for the download to finish (in the sense that the
86         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
87         measure, also check that the process pool has been deallocated at the end of the
88         test. The test wouldn't be meaningful if the process pool were still alive.
89
90         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
91         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
92         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
93             The download will be canceled because the delegate does not implement the
94             method to decide the download's destination, so this is where we know the
95             DownloadProxyMap is done with the DownloadProxy.
96         (TEST):
97
98 2019-03-08  Chris Dumez  <cdumez@apple.com>
99
100         Add support for Device Orientation / Motion permission API
101         https://bugs.webkit.org/show_bug.cgi?id=195329
102         <rdar://problem/47645367>
103
104         Reviewed by Geoffrey Garen.
105
106         Add test infrastructure to help test the Device Orientation / Motion permission API.
107
108         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
110         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
111         * WebKitTestRunner/InjectedBundle/TestRunner.h:
112         * WebKitTestRunner/TestController.cpp:
113         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
114         (WTR::TestController::createWebViewWithOptions):
115         (WTR::TestController::resetStateToConsistentValues):
116         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
117         * WebKitTestRunner/TestController.h:
118         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
119         * WebKitTestRunner/TestInvocation.cpp:
120         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
121
122 2019-03-08  Saam barati  <sbarati@apple.com>
123
124         Add a compare-results script to compare benchmark results
125         https://bugs.webkit.org/show_bug.cgi?id=195486
126         <rdar://problem/48723397>
127
128         Reviewed by Geoffrey Garen.
129
130         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
131         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
132         to extend it to learn about our other benchmarks.
133
134         * Scripts/compare-results: Added.
135         (readJSONFile):
136         (detectJetStream2):
137         (JetStream2Results):
138         (detectSpeedometer2):
139         (Speedometer2Results):
140         (detectPLT5):
141         (PLT5Results):
142         (detectBenchmark):
143         (biggerIsBetter):
144         (ttest):
145         (getOptions):
146         (main):
147
148 2019-03-08  Stephanie Lewis  <slewis@apple.com>
149
150         Ensure old tab state is cleared between iterations of run-benchmark
151         https://bugs.webkit.org/show_bug.cgi?id=195393
152         <rdar://problem/46885583>
153
154         Reviewed by Dewei Zhu.
155
156         a) ensure the default to restore state is not set
157         b) terminate Safari correctly
158         c) Set the system default to ignore Persistent State in Safari
159
160         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
161         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
162         (OSXBrowserDriver.prepare_env): 
163         (OSXBrowserDriver.restore_env):
164         (OSXBrowserDriver.close_browsers):
165         (OSXBrowserDriver._terminate_processes):
166         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
167         (OSXChromeDriver):
168         (OSXChromeCanaryDriver):
169         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
170         (OSXFirefoxDriver):
171         (OSXFirefoxNightlyDriver):
172         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
173         (OSXSafariDriver):
174         (OSXSafariDriver.prepare_env):
175
176 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
177
178         [GTK] Several InputMethodFilter tests are failing
179         https://bugs.webkit.org/show_bug.cgi?id=195408
180
181         Reviewed by Carlos Garcia Campos.
182
183         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
184         Regressed in r241751.
185         Hexadecimal values of keycodes are expressed now in upper letters.
186         Composited characters should be cast to UTF8 strings.
187
188         (TestWebKitAPI::TEST):
189
190 2019-03-07  Tomas Popela  <tpopela@redhat.com>
191
192         [GTK] Make Tools/gtkdoc python3 compatible
193         https://bugs.webkit.org/show_bug.cgi?id=195359
194
195         Reviewed by Carlos Garcia Campos.
196
197         * gtkdoc/generate-gtkdoc:
198         ConfigParser was reworked in Python 3.2 so we have adapt the code to
199         work with Python 2 and 3.
200         (get_gtkdoc_module_paths):
201         The iteritems() was removed in Python 3, so let's use items() that's
202         available in Python 2 and 3.
203         (get_generator_for_config):
204         * gtkdoc/gtkdoc.py:
205         (GTKDoc._run_command):
206         The sys.stdout.write() is expecting str in Python 3 and not bytes
207         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
208         for passing the bytes there.
209
210 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
211
212         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
213         https://bugs.webkit.org/show_bug.cgi?id=195346
214         <rdar://problem/48667048>
215
216         Unreviewed build fix for clang-cl.
217
218         * DumpRenderTree/win/DumpRenderTree.cpp:
219         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
220
221 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
222
223         requestAnimationFrame should execute before the next frame
224         https://bugs.webkit.org/show_bug.cgi?id=177484
225
226         Reviewed by Simon Fraser.
227
228         Add trace points for the page RenderingUpdate.
229
230         * Tracing/SystemTracePoints.plist:
231
232 2019-03-07  Zalan Bujtas  <zalan@apple.com>
233
234         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
235         https://bugs.webkit.org/show_bug.cgi?id=195353
236         <rdar://problem/48626394>
237
238         Reviewed by Simon Fraser.
239
240         * WebKitTestRunner/ios/TestControllerIOS.mm:
241         (WTR::TestController::platformResetPreferencesToConsistentValues):
242
243 2019-03-07  John Wilander  <wilander@apple.com>
244
245         Resource Load Statistics: Make it possible to purge only script-accessible cookies
246         https://bugs.webkit.org/show_bug.cgi?id=195383
247         <rdar://problem/48570136>
248
249         Reviewed by Brent Fulgham.
250
251         This patch adds test infrastructure to purge only script-accessible cookies,
252         including a new testRunner function called statisticsDeleteCookiesForHost().git a
253
254         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
256         (WTR::TestRunner::statisticsDeleteCookiesForHost):
257         * WebKitTestRunner/InjectedBundle/TestRunner.h:
258         * WebKitTestRunner/TestController.cpp:
259         (WTR::TestController::statisticsDeleteCookiesForHost):
260         * WebKitTestRunner/TestController.h:
261         * WebKitTestRunner/TestInvocation.cpp:
262         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
263
264 2019-03-07  Commit Queue  <commit-queue@webkit.org>
265
266         Unreviewed, rolling out r242354.
267         https://bugs.webkit.org/show_bug.cgi?id=195402
268
269         breaks layout tests in all configurations (Requested by
270         zdobersek on #webkit).
271
272         Reverted changeset:
273
274         "[WPE] Enable web process sandbox"
275         https://bugs.webkit.org/show_bug.cgi?id=195169
276         https://trac.webkit.org/changeset/242354
277
278 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
279
280         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
281         https://bugs.webkit.org/show_bug.cgi?id=195346
282
283         Reviewed by Fujii Hironori.
284
285         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
286         (TestWebKitAPI::TEST):
287         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
288
289         * DumpRenderTree/win/DumpRenderTree.cpp:
290         (findFontFallback):
291         (addFontFallbackIfPresent):
292         (removeFontFallbackIfPresent):
293         (main):
294         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
295         (TestWebKitAPI::Util::moduleDirectory):
296         (TestWebKitAPI::Util::createInjectedBundlePath):
297         Use wchar helpers as needed.
298
299 2019-03-06  Rob Buis  <rbuis@igalia.com>
300
301         Consider supporting the `referrerpolicy` attribute.
302         https://bugs.webkit.org/show_bug.cgi?id=179053
303
304         Reviewed by Darin Adler.
305
306         Add a runtime flag for referrerpolicy attribute.
307
308         * DumpRenderTree/mac/DumpRenderTree.mm:
309         (enableExperimentalFeatures):
310
311 2019-03-05  Daniel Bates  <dabates@apple.com>
312
313         Update expected API test result following r242379
314         (https://bugs.webkit.org/show_bug.cgi?id=195125)
315
316         Update expected x-coordinate of selection rect now that the left padding of
317         a textarea is sized in ems (so dependent on the font size) just like the left
318         padding of a text field.
319
320         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
321         (TestWebKitAPI::TEST):
322
323 2019-03-05  David Quesada  <david_quesada@apple.com>
324
325         [WK2] It should be possible to follow links with 'download' attributes
326         https://bugs.webkit.org/show_bug.cgi?id=195145
327         rdar://problem/48462642
328
329         Reviewed by Alex Christensen.
330
331         Add a unit test to verify that activating links with 'download' attributes now
332         navigates to the linked resource, rather than starts downloading it. Add another
333         to verify that it is still possible to explicitly download the link via the
334         'Download' navigation action policy.
335
336         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
337         (-[DownloadAttributeTestDelegate init]):
338         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
339         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
340         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
341         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
342         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
343         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
344         (TEST):
345         * WebKitTestRunner/TestController.cpp:
346         (WTR::TestController::decidePolicyForNavigationAction):
347         * WebKitTestRunner/TestController.h:
348
349 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
350
351         [Curl] Implement Cookie Accept Policy.
352         https://bugs.webkit.org/show_bug.cgi?id=191645
353
354         Reviewed by Fujii Hironori.
355
356         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
357         (TestWebKitAPI::Curl::TEST_F):
358
359 2019-03-05  Youenn Fablet  <youenn@apple.com>
360
361         Rename requestCacheStorageSpace to requestStorageSpace
362         https://bugs.webkit.org/show_bug.cgi?id=195282
363
364         Reviewed by Chris Dumez.
365
366         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
367         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
368         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
369
370 2019-03-05  Brady Eidson  <beidson@apple.com>
371
372         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
373         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
374
375         Reviewed by Tim Horton.
376
377         Loading a file: URL into a WKWebView and then loading another file: url from a completely
378         different directory into that same WKWebView should work.
379
380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
381         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
382
383 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
384
385         Add WeakHashSet
386         https://bugs.webkit.org/show_bug.cgi?id=195152
387
388         Reviewed by Antti Koivisto.
389
390         Added tests for WeakHashSet.
391
392         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
393         (TestWebKitAPI::Base::Base): Moved.
394         (TestWebKitAPI::Derived::foo): Moved.
395         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
396         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
397         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
398         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
399
400 2019-03-04  Chris Dumez  <cdumez@apple.com>
401
402         Do not share WebProcesses between private and regular sessions
403         https://bugs.webkit.org/show_bug.cgi?id=195189
404         <rdar://problem/48421064>
405
406         Reviewed by Alex Christensen.
407
408         Add API test coverage.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
411         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
412
413 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
414
415         [WPE] Enable web process sandbox
416         https://bugs.webkit.org/show_bug.cgi?id=195169
417
418         Reviewed by Daniel Bates.
419
420         * wpe/install-dependencies:
421         * wpe/jhbuild.modules:
422
423 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
424
425         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
426         https://bugs.webkit.org/show_bug.cgi?id=195206
427
428         Reviewed by Žan Doberšek.
429
430         Add a new test case.
431
432         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
433         (testJSCClass):
434
435 2019-03-04  Charlie Turner  <cturner@igalia.com>
436
437         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
438         https://bugs.webkit.org/show_bug.cgi?id=194898
439
440         Reviewed by Žan Doberšek.
441
442         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
443         a GCC extension that permits arithmetic on void* pointer. Inline
444         the macro until this issue is fixed upstream.
445
446 2019-03-03  Tim Horton  <timothy_horton@apple.com>
447
448         Rid the world of WK_API_ENABLED
449         https://bugs.webkit.org/show_bug.cgi?id=195263
450
451         Reviewed by Dan Bernstein.
452
453         List of changed files elided because it's useless.
454
455 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
456
457         Unreviewed follow-up to r242292.
458
459         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
460
461         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
462         (TestWebKitAPI::testStrip): Renamed from strip.
463         (TestWebKitAPI::TEST):
464
465 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
466
467         Unreviewed, remove accidentally-committed URLHelpers.cpp test
468
469         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
470         and bug #194272 for details.
471
472         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
473
474 2019-03-03  Tim Horton  <timothy_horton@apple.com>
475
476         Remove some more unused 32-bit code
477         https://bugs.webkit.org/show_bug.cgi?id=195255
478
479         Reviewed by Darin Adler.
480
481         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
482         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
483         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
484         (NPP_New):
485         (NPP_HandleEvent):
486         (handleEventCarbon): Deleted.
487
488 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
489
490         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
491
492         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
493         (TestWebKitAPI::TEST):
494
495 2019-03-01  Darin Adler  <darin@apple.com>
496
497         Finish removing String::format
498         https://bugs.webkit.org/show_bug.cgi?id=194893
499
500         Reviewed by Daniel Bates.
501 '
502         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
503
504 2019-03-01  Alex Christensen  <achristensen@webkit.org>
505
506         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
507         https://bugs.webkit.org/show_bug.cgi?id=195229
508         <rdar://problem/48520362>
509
510         Reviewed by Chris Dumez.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
513         (TEST):
514
515 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
516
517         Add a system trace scope for event region building
518         https://bugs.webkit.org/show_bug.cgi?id=195226
519
520         Reviewed by Jon Lee.
521
522         This trace scope measures the time spend converting element rects into Region objects,
523         which can be large on some pages.
524
525         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
526
527         * Tracing/SystemTracePoints.plist:
528
529 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
530
531         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
532         https://bugs.webkit.org/show_bug.cgi?id=194612
533
534         Reviewed by Alex Christensen.
535
536         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
537         Just test the new string-processing function and don't touch the actual environment.
538         (Test cases are all as before, but based on operator== instead of strcmp.)
539
540 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
541
542         [ews-app] Update primary keys for handling multiple Buildbot instances
543         https://bugs.webkit.org/show_bug.cgi?id=195120
544
545         Reviewed by Stephanie Lewis.
546
547         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
548         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
549         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
550
551         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
552         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
553         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
554         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
555         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
556         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
557
558 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
559
560         [WinCairo] Enable service worker
561         https://bugs.webkit.org/show_bug.cgi?id=188318
562
563         Reviewed by Youenn Fablet.
564
565         * DumpRenderTree/DumpRenderTreePrefix.h:
566         * TestWebKitAPI/PlatformWin.cmake:
567         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
568         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
569         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
570
571 2019-03-01  Justin Fan  <justin_fan@apple.com>
572
573         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
574         https://bugs.webkit.org/show_bug.cgi?id=195191
575
576         Rubber-stamped by Dean Jackson.
577
578         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
579
580         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
581
582 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
583
584         Unreviewed, fix lldb webkitpy tests
585         https://bugs.webkit.org/show_bug.cgi?id=194375
586
587         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
588
589         * lldb/lldb_webkit.py:
590         (WTFStringImplProvider.is_8bit):
591
592 2019-02-28  David Quesada  <david_quesada@apple.com>
593
594         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
595         https://bugs.webkit.org/show_bug.cgi?id=195121
596         rdar://problem/48450302
597
598         Reviewed by Alex Christensen.
599
600         Add API tests for -WKNavigationAction._shouldPerformDownload in various
601         configurations where the 'download' attribute is absent, blank, or populated
602         with a filename, and where the anchor element is same-origin or cross-origin
603         (meaning the 'download' attribute shouldn't be honored).
604
605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
606         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
607         (-[NavigationActionTestDelegate init]):
608         (-[NavigationActionTestDelegate navigationAction]):
609         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
610         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
611         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
612         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
613         (TEST):
614
615 2019-02-28  Antoine Quint  <graouts@apple.com>
616
617         Enable the Pointer Events runtime flag by default
618         https://bugs.webkit.org/show_bug.cgi?id=195156
619
620         Reviewed by Dean Jackson.
621
622         * DumpRenderTree/mac/DumpRenderTree.mm:
623         (enableExperimentalFeatures):
624
625 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
626
627         Several PasteImage API tests are flaky
628         https://bugs.webkit.org/show_bug.cgi?id=195160
629
630         Reviewed by Tim Horton.
631
632         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
633         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
634         listening for a "load" event after image load is already complete.
635
636         To address this, make these tests first register a "load" event handler, then run script to insert an image
637         element into the document, and finally wait until the load event is observed before checking image size.
638
639         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
640
641 2019-02-28  Chris Dumez  <cdumez@apple.com>
642
643         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
644         https://bugs.webkit.org/show_bug.cgi?id=195107
645
646         Reviewed by Alex Christensen.
647
648         Give some time for the zoom level to get restored.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
653
654         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
655         https://bugs.webkit.org/show_bug.cgi?id=194958
656
657         Reviewed by Geoffrey Garen.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
660         (TEST):
661
662 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
663
664         [ews-app] Update method to save build to handle builder_display_name
665         https://bugs.webkit.org/show_bug.cgi?id=195047
666
667         Reviewed by Dewei Zhu.
668
669         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
670         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
671
672 2019-02-28  Justin Fan  <justin_fan@apple.com>
673
674         [Web GPU] Enable Web GPU only on 64-bit
675         https://bugs.webkit.org/show_bug.cgi?id=195139
676
677         Because Metal is only supported on 64 bit apps.
678
679         Unreviewed build fix.
680
681         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
682
683 2019-02-27  Youenn Fablet  <youenn@apple.com>
684
685         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
686         https://bugs.webkit.org/show_bug.cgi?id=194959
687
688         Reviewed by Chris Dumez.
689
690         Spin loop until getting the condition to remove flakiness.
691
692         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
693
694 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
695
696         [ews-build] Buildbot should include builder_display_name in the build events
697         https://bugs.webkit.org/show_bug.cgi?id=195045
698
699         Reviewed by Dewei Zhu.
700
701         * BuildSlaveSupport/ews-build/events.py:
702         (Events.buildStarted): Included builder_display_name in event data. Also renamed
703         buildername to builder_name to be consistent in naming style.
704         (Events.buildFinished): Ditto.
705
706 2019-02-27  Chris Dumez  <cdumez@apple.com>
707
708         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
709         https://bugs.webkit.org/show_bug.cgi?id=194480
710
711         Reviewed by Brady Eidson.
712
713         Update existing API test to make it more likely to reproduce the issue.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
716
717 2019-02-27  Brady Eidson  <beidson@apple.com>
718
719         Universal links from Google search results pages don't open the app.
720         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
721
722         Reviewed by Geoffrey Garen.
723
724         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
725         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
726         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
727         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
728
729 2019-02-27  Chris Dumez  <cdumez@apple.com>
730
731         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
732         https://bugs.webkit.org/show_bug.cgi?id=195102
733
734         Reviewed by Geoffrey Garen.
735
736         If the number of processes is not yet what we expect, wait a bit and check again to give
737         processes some time to exit.
738
739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
740
741 2019-02-27  Chris Dumez  <cdumez@apple.com>
742
743         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
744         https://bugs.webkit.org/show_bug.cgi?id=194545
745
746         Reviewed by Brady Eidson.
747
748         Make sure the test navigates forward and then back only once. Previously, navigating
749         back would trigger a navigation again in a timer.
750
751         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
752
753 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
754
755         High Sierra Debug JSC test queue should use faster hardware
756         https://bugs.webkit.org/show_bug.cgi?id=194603
757
758         Rubber-stamped by Alexey Proskuryakov.
759
760         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
761
762         * BuildSlaveSupport/build.webkit.org-config/config.json:
763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
764         (BubbleQueueServer):
765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
766         (WebKitBuildbot):
767         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
768         * QueueStatusServer/config/queues.py:
769         * Scripts/webkitpy/common/config/ews.json:
770         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
771         (test_ews_name):
772
773 2019-02-27  John Wilander  <wilander@apple.com>
774
775         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
776         https://bugs.webkit.org/show_bug.cgi?id=195071
777         <rdar://problem/48417690>
778
779         Reviewed by Alex Christensen and Brent Fulgham.
780
781         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
782         (TestWebKitAPI::createURL):
783             Convenience function.
784         (TestWebKitAPI::TEST):
785             WebCore::AdClickAttribution now takes a URL when creating Source and
786             Destination.
787         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
788         (TestWebKitAPI::TEST):
789             WebCore::AdClickAttribution now takes a URL when creating Source and
790             Destination.
791
792 2019-02-27  Antoine Quint  <graouts@apple.com>
793
794         Support Pointer Events on macOS
795         https://bugs.webkit.org/show_bug.cgi?id=195008
796         <rdar://problem/47454419>
797
798         Reviewed by Dean Jackson.
799
800         * DumpRenderTree/mac/DumpRenderTree.mm:
801         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
802         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
803
804 2019-02-26  Mark Lam  <mark.lam@apple.com>
805
806         Remove remaining poisoning code.
807         https://bugs.webkit.org/show_bug.cgi?id=194138
808
809         Reviewed by Saam Barati.
810
811         * TestWebKitAPI/CMakeLists.txt:
812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
813         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
814         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
815         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
816         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
817         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
818         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
819
820 2019-02-26  Alex Christensen  <achristensen@webkit.org>
821
822         Move ephemeral local storage from WebProcess to UIProcess
823         https://bugs.webkit.org/show_bug.cgi?id=195074
824         <rdar://problem/47937975>
825
826         Reviewed by Geoff Garen.
827
828         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
829
830 2019-02-20  Jer Noble  <jer.noble@apple.com>
831
832         [Cocoa] Media elements will restart network buffering just before suspending
833         https://bugs.webkit.org/show_bug.cgi?id=193691
834
835         Reviewed by Eric Carlson.
836
837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
839         (TEST):
840
841 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
842
843         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
844         https://bugs.webkit.org/show_bug.cgi?id=191652
845
846         Reviewed by Alex Christensen.
847
848         Fix WinCairo MiniBrowser behavior of authentication dialog.
849
850         * MiniBrowser/win/WebKitBrowserWindow.cpp:
851         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
852
853 2019-02-26  Youenn Fablet  <youenn@apple.com>
854
855         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
856         https://bugs.webkit.org/show_bug.cgi?id=195028
857         <rdar://problem/48243733>
858
859         Reviewed by Eric Carlson.
860
861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
862
863 2019-02-26  Philippe Normand  <pnormand@igalia.com>
864
865         [WPE] Add API for webview background color configuration
866         https://bugs.webkit.org/show_bug.cgi?id=192305
867
868         Reviewed by Michael Catanzaro.
869
870         * MiniBrowser/wpe/main.cpp:
871         (main): Add a new option to configure the webview background
872         color. Example: --bg-color=transparent.
873         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
874         (testWebViewBackgroundColor): Enable background color API tests for WPE.
875         (beforeAll): Ditto.
876
877 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
878
879         scalableNativeWebpageParameters() is not preserved on new page navigation.
880         https://bugs.webkit.org/show_bug.cgi?id=194892
881         <rdar://problem/47538280>
882
883         Reviewed by Wenson Hsieh.
884         
885         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
886
887         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
888         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
889         * DumpRenderTree/mac/UIScriptControllerMac.mm:
890         (WTR::UIScriptController::allowsViewportShrinkToFit):
891         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
892         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
893         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
894         * TestRunnerShared/UIScriptContext/UIScriptController.h:
895         * WebKitTestRunner/UIScriptControllerCocoa.mm:
896         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
897
898 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews-app] Add model for handling multiple Buildbot instances
901         https://bugs.webkit.org/show_bug.cgi?id=194863
902
903         Reviewed by Stephanie Lewis.
904
905         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
906
907 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
908
909         [ews-app] Remove BuilderMapping table
910         https://bugs.webkit.org/show_bug.cgi?id=194961
911
912         Reviewed by Stephanie Lewis.
913
914         Store builder name directly in build table, instead of having a separate
915         table for it.
916
917         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
918         * BuildSlaveSupport/ews-app/ews/models/build.py:
919         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
920         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
921
922 2019-02-25  John Wilander  <wilander@apple.com>
923
924         Introduce and adopt new class RegistrableDomain for eTLD+1
925         https://bugs.webkit.org/show_bug.cgi?id=194791
926         <rdar://problem/48179240>
927
928         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
929
930         This patch adds an API test and replaces two instances of
931         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
932
933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
934         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
935         (TestWebKitAPI::TEST):
936             Changed two strings to make sure the registrable domains are still considered
937             invalid and pass the test.
938         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
939         (TestWebKitAPI::TEST):
940         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
941         (WTR::InjectedBundle::didReceiveMessageToPage):
942
943 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
944
945         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
946         https://bugs.webkit.org/show_bug.cgi?id=195001
947
948         Reviewed by Carlos Garcia Campos.
949
950         API version 1.0 always includes the functionality previously guarded with
951         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
952         unconditionally.
953
954         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
955         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
956         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
957         (WebViewTest::showInWindow): Ditto.
958         (WebViewTest::hideView): Ditto.
959         * wpe/backends/HeadlessViewBackend.cpp:
960         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
961         * wpe/backends/ViewBackend.cpp:
962         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
963         * wpe/backends/WindowViewBackend.cpp:
964         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
965         WPE_BACKEND_CHECK_VERSION().
966         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
967
968 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
969
970         [Flatpak] Add support for flatpak > 1.1.2
971         https://bugs.webkit.org/show_bug.cgi?id=194088
972
973         Flatpak 1.2 is now out so we need to support that
974         version now.
975
976         Reviewed by Michael Catanzaro.
977
978         * flatpak/flatpakutils.py:
979         (check_flatpak):
980         (FlatpakPackages.__init__):
981         (FlatpakPackages.__detect_packages):
982         (FlatpakPackages.__detect_packages.in):
983         (FlatpakRepos.update):
984
985 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
986
987         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
988         https://bugs.webkit.org/show_bug.cgi?id=194998
989
990         Reviewed by Carlos Garcia Campos.
991
992         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
993         to a Git checkout and using the latest commit containing various fixes
994         and improvements.
995
996 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
997
998         [WPE][GTK] Remove user agent quirk for washingtonpost.com
999         https://bugs.webkit.org/show_bug.cgi?id=194981
1000
1001         Reviewed by Žan Doberšek.
1002
1003         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1004         (TestWebKitAPI::TEST):
1005
1006 2019-02-23  Keith Miller  <keith_miller@apple.com>
1007
1008         Add new mac target numbers
1009         https://bugs.webkit.org/show_bug.cgi?id=194955
1010
1011         Reviewed by Tim Horton.
1012
1013         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1014         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1015         * MiniBrowser/Configurations/Base.xcconfig:
1016         * TestWebKitAPI/Configurations/Base.xcconfig:
1017         * WebKitTestRunner/Configurations/Base.xcconfig:
1018
1019 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1020
1021         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1022         https://bugs.webkit.org/show_bug.cgi?id=194846
1023
1024         Reviewed by Don Olmstead.
1025
1026         Added _search_paths() and _port_specific_expectations_files() for
1027         WinCairoPort.
1028
1029         * Scripts/webkitpy/port/win.py:
1030         (WinCairoPort.default_baseline_search_path):
1031         (WinCairoPort):
1032         (WinCairoPort._port_specific_expectations_files):
1033         (WinCairoPort._search_paths):
1034
1035 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1036
1037         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1038         https://bugs.webkit.org/show_bug.cgi?id=194963
1039
1040         Reviewed by Dean Jackson.
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1043         Do a `contains` check instead of `equals`, because in debug builds we
1044         put the GraphicsLayer pointer in a prefix.
1045
1046 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1047
1048         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1049         https://bugs.webkit.org/show_bug.cgi?id=194873
1050         <rdar://problem/46701974>
1051
1052         Reviewed by Tim Horton.
1053
1054         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1055
1056         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1057         (WTR::UIScriptController::menuRect const):
1058         (WTR::UIScriptController::isShowingMenu const):
1059         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1060         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1061         (WTR::UIScriptController::menuRect const):
1062
1063         Add a function to query the bounds of the callout menu in content coordinates.
1064
1065         (WTR::UIScriptController::isShowingMenu const):
1066
1067         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1068
1069         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1070         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1071         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1072         (WTR::UIScriptController::rectForMenuAction const):
1073         (WTR::UIScriptController::menuRect const):
1074         (WTR::UIScriptController::isShowingMenu const):
1075         (WTR::findViewInHierarchyOfType): Deleted.
1076
1077 2019-02-22  Chris Dumez  <cdumez@apple.com>
1078
1079         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1080         https://bugs.webkit.org/show_bug.cgi?id=194954
1081         <rdar://problem/48127957>
1082
1083         Reviewed by Alex Christensen.
1084
1085         Add API test coverage.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1088         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1089         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1090         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1091
1092 2019-02-22  Chris Dumez  <cdumez@apple.com>
1093
1094         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1095         https://bugs.webkit.org/show_bug.cgi?id=194924
1096         <rdar://problem/48216125>
1097
1098         Reviewed by Geoffrey Garen.
1099
1100         Add API test coverage.
1101
1102         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1103
1104 2019-02-22  Chris Dumez  <cdumez@apple.com>
1105
1106         Unreviewed, disable API test added in r241928 on iOS.
1107
1108         The cache is not enabled on devices with less than 3GB of RAM.
1109
1110         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1111
1112 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1113
1114         Hardcode Visual Viewports on everywhere except iOS WK1
1115         https://bugs.webkit.org/show_bug.cgi?id=194928
1116
1117         Reviewed by Zalan Bujtas.
1118
1119         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1120         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1121         set it to false. The setting has shipped for several years and there's no need to turn
1122         it off now.
1123
1124         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1125         Visual Viewports are not enabled.
1126         
1127         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1128         that only runs in WK2
1129
1130         * MiniBrowser/mac/SettingsController.h:
1131         * MiniBrowser/mac/SettingsController.m:
1132         (-[SettingsController init]):
1133         (-[SettingsController _populateMenu]):
1134         (-[SettingsController validateMenuItem:]):
1135         (-[SettingsController visualViewportEnabled]): Deleted.
1136         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1137         * MiniBrowser/mac/WK1BrowserWindowController.m:
1138         (-[WK1BrowserWindowController didChangeSettings]):
1139         * MiniBrowser/mac/WK2BrowserWindowController.m:
1140         (-[WK2BrowserWindowController didChangeSettings]):
1141
1142 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1143
1144         Discard cached processes when clearing website data store
1145         https://bugs.webkit.org/show_bug.cgi?id=194894
1146
1147         Reviewed by Chris Dumez.
1148
1149         Added a test case.
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1152         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1153
1154 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1155
1156         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1157         https://bugs.webkit.org/show_bug.cgi?id=194914
1158         <rdar://problem/47586889>
1159
1160         Reviewed by Geoffrey Garen.
1161
1162         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1163         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1164         (TEST):
1165         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1166
1167 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1168
1169         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1170         <https://webkit.org/b/194761>
1171
1172         Reviewed by Myles Maxfield.
1173
1174         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1175         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1176         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1177         to use ARC-compliant cast.
1178         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1179         ARC-compliant cast.
1180         (WTR::installFakeHelvetica): Log `error` to console if
1181         CTFontManagerRegisterFontsForURL() fails, but only on supported
1182         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1183         Call CFRelease() on `error` to fix the leak.  Update to use
1184         ARC-compliant cast.
1185         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1186         cast.
1187
1188 2019-02-21  Chris Dumez  <cdumez@apple.com>
1189
1190         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1191         https://bugs.webkit.org/show_bug.cgi?id=194481
1192
1193         Reviewed by Alex Christensen.
1194
1195         Give the processes a chance to shutdown and wait until we reached the expected number
1196         of processes.
1197
1198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1199
1200 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1201
1202         Fix the macOS build
1203
1204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1205
1206 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1207
1208         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1211         I am a backwards.
1212
1213 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1214
1215         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1218         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1219         We could force on UI-side compositing, but I feel like the test might be more
1220         valuable exercising the normal path on each platform (though the original
1221         bug was also UI-side specific). Though we can't validate that the overlay
1222         layer was installed successfully, there are layout tests that do that.
1223
1224 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1225
1226         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1227         https://bugs.webkit.org/show_bug.cgi?id=194845
1228         <rdar://problem/47944579>
1229
1230         Reviewed by Antti Koivisto.
1231
1232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1234
1235 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1236
1237         [LFC][Floats] Add support for placing formatting roots in-between floats.
1238         https://bugs.webkit.org/show_bug.cgi?id=194902
1239
1240         Reviewed by Antti Koivisto.
1241
1242         * LayoutReloaded/misc/LFC-passing-tests.txt:
1243
1244 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1245
1246         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1247         https://bugs.webkit.org/show_bug.cgi?id=194901
1248
1249         Unreviewed build fix.
1250
1251         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1252         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1253         WPEBackend-fdo-0.1 as library name.
1254
1255 2019-02-21  Rob Buis  <rbuis@igalia.com>
1256
1257         Update MIME type parser
1258         https://bugs.webkit.org/show_bug.cgi?id=180526
1259
1260         Reviewed by Darin Adler.
1261
1262         Add tests involving leading and trailing whitespace, non-token
1263         characters and quoted strings.
1264
1265         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1266         (TestWebKitAPI::TEST):
1267
1268 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1269
1270         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1271         https://bugs.webkit.org/show_bug.cgi?id=194884
1272
1273         Reviewed by Michael Catanzaro.
1274
1275         * PlatformWin.cmake:
1276
1277 2019-02-20  Chris Dumez  <cdumez@apple.com>
1278
1279         Add API test for <rdar://problem/47471222>
1280         https://bugs.webkit.org/show_bug.cgi?id=194847
1281
1282         Reviewed by Alex Christensen.
1283
1284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1285
1286 2019-02-20  Chris Dumez  <cdumez@apple.com>
1287
1288         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1289         https://bugs.webkit.org/show_bug.cgi?id=194872
1290         <rdar://problem/47924500>
1291
1292         Reviewed by Alex Christensen.
1293
1294         Add API test coverage.
1295
1296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1297
1298 2019-02-20  Jer Noble  <jer.noble@apple.com>
1299
1300         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1301         https://bugs.webkit.org/show_bug.cgi?id=191332
1302
1303         Reviewed by Dean Jackson.
1304
1305         * Scripts/git-is-in-range: Added.
1306
1307 2019-02-20  Andy Estes  <aestes@apple.com>
1308
1309         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1310         https://bugs.webkit.org/show_bug.cgi?id=194869
1311
1312         Rubber-stamped by Jer Noble.
1313
1314         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1315         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1316         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1317         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1319         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1320
1321 2019-02-20  Chris Dumez  <cdumez@apple.com>
1322
1323         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1324         https://bugs.webkit.org/show_bug.cgi?id=194857
1325         <rdar://problem/47759323>
1326
1327         Reviewed by Alex Christensen.
1328
1329         Add API test coverage.
1330
1331         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1332
1333 2019-02-20  Chris Dumez  <cdumez@apple.com>
1334
1335         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1336         https://bugs.webkit.org/show_bug.cgi?id=194829
1337         <rdar://problem/47889906>
1338
1339         Reviewed by Alexey Proskuryakov.
1340
1341         Every time the TestOptions were changing we were creating both a new Web view and
1342         a new WKContext, which would start a new Network process. In most cases, we only
1343         need to contruct a new Web view and we do can keep reusing the same WKContext.
1344         This patch implements this optimization and thus avoids spinning a lot of new
1345         Network processes while running the layout tests.
1346
1347         * WebKitTestRunner/TestController.cpp:
1348         (WTR::TestController::generateContextConfiguration const):
1349         (WTR::TestController::generatePageConfiguration):
1350         (WTR::TestController::createWebViewWithOptions):
1351         (WTR::TestController::resetPreferencesToConsistentValues):
1352         (WTR::updateTestOptionsFromTestHeader):
1353         * WebKitTestRunner/TestController.h:
1354         * WebKitTestRunner/TestOptions.h:
1355         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1356         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1357         (WTR::TestOptions::hasSameInitializationOptions const):
1358         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1359         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1360         (WTR::TestController::platformAddTestOptions const):
1361
1362 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1363
1364         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1365         https://bugs.webkit.org/show_bug.cgi?id=167941
1366
1367         Reviewed by Carlos Garcia Campos.
1368
1369         * MiniBrowser/gtk/main.c:
1370         (filterSavedCallback): Added.
1371         (main): Support loading a JSON rule set file for content filtering.
1372         * MiniBrowser/wpe/main.cpp:
1373         (filterSavedCallback): Added.
1374         (main): Support loading a JSON rule set file for content filtering.
1375         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1376         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1377         (WTF::derefGPtr): Ditto.
1378         (testEmptyStore):
1379         (testSaveInvalidFilter):
1380         (testSaveLoadFilter):
1381         (testSavedFilterIdentifierMatch):
1382         (testRemoveFilter):
1383         (testSaveMultipleFilters):
1384         (testSaveFilterFromFile):
1385         (testFilterPersistence):
1386         (beforeAll):
1387         (afterAll):
1388         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1389         (removeOldInjectedContentAndResetLists): Also reset content filters.
1390         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1391         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1392         the element affected by the style sheet.
1393         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1394         and returns it to be used by tests.
1395         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1396         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1397         (serverCallback): Add support for serving a CSS style sheet for testing.
1398         (beforeAll): Add call to testUserContentManagerContentFilter().
1399         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1400
1401 2019-02-19  Keith Rollin  <krollin@apple.com>
1402
1403         Add timing information to build output
1404         https://bugs.webkit.org/show_bug.cgi?id=194839
1405         <rdar://problem/48219609>
1406
1407         Reviewed by Alexey Proskuryakov.
1408
1409         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1410         emit each project's build time to its output. E.g.,
1411
1412             ** BUILD SUCCEEDED ** [0.132 sec]
1413
1414         * Scripts/webkitdirs.pm:
1415         (XcodeOptions):
1416
1417 2019-02-19  Truitt Savell  <tsavell@apple.com>
1418
1419         Unreviewed, rolling out r241784.
1420
1421         Broke all OpenSource builds.
1422
1423         Reverted changeset:
1424
1425         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1426         instances view"
1427         https://bugs.webkit.org/show_bug.cgi?id=172848
1428         https://trac.webkit.org/changeset/241784
1429
1430 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1431
1432         [LFC][Floats] Remove redundant intersecting logic
1433         https://bugs.webkit.org/show_bug.cgi?id=194804
1434
1435         Reviewed by Antti Koivisto.
1436
1437         * LayoutReloaded/misc/LFC-passing-tests.txt:
1438
1439 2019-02-19  Dean Jackson  <dino@apple.com>
1440
1441         Clean-up output from generate-xcfilelists so it can be filtered
1442         https://bugs.webkit.org/show_bug.cgi?id=194795
1443
1444         Reviewed by Joseph Pecoraro (and Keith Rollin).
1445
1446         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1447         make a slight tweak to filter-build-webkit so such lines are marked
1448         as plain.
1449
1450         * Scripts/filter-build-webkit:
1451         * Scripts/generate-xcfilelists:
1452
1453 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1454
1455         pytest is not correctly auto-installed
1456         https://bugs.webkit.org/show_bug.cgi?id=194707
1457
1458         Reviewed by Carlos Garcia Campos.
1459
1460         * Scripts/webkitpy/thirdparty/__init__.py:
1461         (AutoinstallImportHook._install_pytest):
1462
1463 2019-02-18  Chris Dumez  <cdumez@apple.com>
1464
1465         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1466         https://bugs.webkit.org/show_bug.cgi?id=194797
1467         <rdar://problem/48055151>
1468
1469         Reviewed by Geoffrey Garen.
1470
1471         Add API test coverage.
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1474
1475 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1476
1477         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1478         https://bugs.webkit.org/show_bug.cgi?id=194670
1479         <rdar://problem/39066529>
1480
1481         Reviewed by Tim Horton.
1482
1483         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1484         pasted in an editable area as attachment elements.
1485
1486         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1487         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1488         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1489         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1490         (TestWebKitAPI::TEST):
1491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1492         (WTR::InjectedBundlePage::InjectedBundlePage):
1493
1494 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1495
1496         Fix API test after r241728
1497        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1498
1499         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1500         (TEST):
1501         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1502
1503 2019-02-18  Daniel Bates  <dabates@apple.com>
1504
1505         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1506         https://bugs.webkit.org/show_bug.cgi?id=192824
1507         <rdar://problem/47100332>
1508
1509         Reviewed by Wenson Hsieh.
1510
1511         Fix a bug where the wrong usage code was used for F13 thru F24.
1512
1513         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1514         (keyCodeForDOMFunctionKey):
1515
1516 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1517
1518         Bytecode cache should a have a boot-specific validation
1519         https://bugs.webkit.org/show_bug.cgi?id=194769
1520         <rdar://problem/48149509>
1521
1522         Reviewed by Keith Miller.
1523
1524         Add test for WTF::bootSessionUUIDString()
1525
1526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1527         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1528         (TEST):
1529
1530 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1531
1532         Disable safe browsing in WKWebView and remove its WKPreferences API
1533         https://bugs.webkit.org/show_bug.cgi?id=194723
1534         <rdar://problem/48122993>
1535
1536         Reviewed by Geoffrey Garen.
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1539         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1540         (TEST):
1541         (safeBrowsingView):
1542         Make tests use SPI instead of API.
1543
1544 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1545
1546         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1547         https://bugs.webkit.org/show_bug.cgi?id=194586
1548
1549         Reviewed by Ross Kirsling.
1550
1551         * DumpRenderTree/win/DumpRenderTree.cpp:
1552         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1553         * Scripts/webkitpy/port/driver.py:
1554         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1555
1556 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1557
1558         Unreviewed, rolling out r241620.
1559
1560         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1561         (Requested by ddkilzer on #webkit.)
1562
1563         Reverted changeset:
1564
1565         "[WTF] Add environment variable helpers"
1566         https://bugs.webkit.org/show_bug.cgi?id=192405
1567         https://trac.webkit.org/changeset/241620
1568
1569 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1570
1571         [LFC] RenderImage's default intrinsic size is 0.
1572         https://bugs.webkit.org/show_bug.cgi?id=194745
1573
1574         Reviewed by Antti Koivisto.
1575
1576         * LayoutReloaded/misc/LFC-passing-tests.txt:
1577
1578 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1579
1580         [LFC][BFC] Add support for block replaced intrinsic width.
1581         https://bugs.webkit.org/show_bug.cgi?id=194705
1582
1583         Reviewed by Simon Fraser.
1584
1585         * LayoutReloaded/misc/LFC-passing-tests.txt:
1586
1587 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1588
1589         [LFC] Apply min/max width constraints to preferred width computation
1590         https://bugs.webkit.org/show_bug.cgi?id=194739
1591
1592         Reviewed by Simon Fraser.
1593
1594         * LayoutReloaded/misc/LFC-passing-tests.txt:
1595
1596 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1597
1598         [WTF] Add environment variable helpers
1599         https://bugs.webkit.org/show_bug.cgi?id=192405
1600
1601         Reviewed by Michael Catanzaro.
1602
1603         * DumpRenderTree/mac/DumpRenderTree.mm:
1604         (libraryPathForDumpRenderTree):
1605         * DumpRenderTree/win/DumpRenderTree.cpp:
1606         (libraryPathForDumpRenderTree):
1607         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1608         (setUpIOSLayoutTestCommunication):
1609         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1610         (beforeAll):
1611         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1612         (main):
1613         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1614         (WebKitTestBus::run):
1615         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1616         (WTR::getOutputDir):
1617         (WTR::initializeFontConfigSetting):
1618         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1619         (WTR::InjectedBundle::platformInitialize):
1620         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1621         (WTR::topLevelPath):
1622         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1623         (WTR::topLevelPath):
1624         (WTR::getOutputDir):
1625         (WTR::activateFonts):
1626         * WebKitTestRunner/TestController.cpp:
1627         (WTR::TestController::libraryPathForTesting):
1628         (WTR::TestController::generateContextConfiguration const):
1629         (WTR::TestController::generatePageConfiguration):
1630         (WTR::TestController::decideDestinationWithSuggestedFilename):
1631         (WTR::TestController::platformAdjustContext):
1632         * WebKitTestRunner/TestController.h:
1633         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1634         (WTR::TestController::cocoaPlatformInitialize):
1635         (WTR::TestController::platformAdjustContext):
1636         * WebKitTestRunner/gtk/main.cpp:
1637         (main):
1638         * WebKitTestRunner/mac/TestControllerMac.mm:
1639         (WTR::TestController::configureContentExtensionForTest):
1640         * WebKitTestRunner/wpe/main.cpp:
1641         (main):
1642         Utilize WTF::Environment where possible.
1643
1644 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1645
1646         [iOS] WKWebView callout bar is missing Change Writing Direction item
1647         https://bugs.webkit.org/show_bug.cgi?id=190015
1648         <rdar://problem/44810366>
1649
1650         Reviewed by Tim Horton.
1651
1652         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1653         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1654
1655         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1656         (TestWebKitAPI::TEST):
1657
1658 2019-02-15  Chris Dumez  <cdumez@apple.com>
1659
1660         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1661         https://bugs.webkit.org/show_bug.cgi?id=194717
1662         <rdar://problem/47884404>
1663
1664         Reviewed by Brady Eidson.
1665
1666         Add API test coverage.
1667
1668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1669
1670 2019-02-15  Youenn Fablet  <youenn@apple.com>
1671
1672         Make navigator.mediaDevices SecureContext
1673         https://bugs.webkit.org/show_bug.cgi?id=194666
1674
1675         Reviewed by Eric Carlson.
1676
1677         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1678         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1679         (TEST_F):
1680
1681 2019-02-15  Brian Burg  <bburg@apple.com>
1682
1683         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1684         https://bugs.webkit.org/show_bug.cgi?id=194411
1685         <rdar://problem/47787614>
1686
1687         Reviewed by Joseph Pecoraro.
1688
1689         Remove unnecessary soft linking macro usage.
1690
1691         * DumpRenderTree/mac/TestRunnerMac.mm:
1692         (TestRunner::inspectorTestStubURL):
1693         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1694         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1695         (WTR::TestRunner::inspectorTestStubURL):
1696
1697 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1698
1699         Unreviewed, rolling out r241559 and r241566.
1700         https://bugs.webkit.org/show_bug.cgi?id=194710
1701
1702         Causes layout test crashes under GuardMalloc (Requested by
1703         ryanhaddad on #webkit).
1704
1705         Reverted changesets:
1706
1707         "[WTF] Add environment variable helpers"
1708         https://bugs.webkit.org/show_bug.cgi?id=192405
1709         https://trac.webkit.org/changeset/241559
1710
1711         "Unreviewed build fix for WinCairo Debug after r241559."
1712         https://trac.webkit.org/changeset/241566
1713
1714 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1715
1716         [LFC] Out-of-flow box is never a float box
1717         https://bugs.webkit.org/show_bug.cgi?id=194704
1718
1719         Reviewed by Antti Koivisto.
1720
1721         * LayoutReloaded/misc/LFC-passing-tests.txt:
1722
1723 2019-02-10  Darin Adler  <darin@apple.com>
1724
1725         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1726         https://bugs.webkit.org/show_bug.cgi?id=194487
1727
1728         Reviewed by Daniel Bates.
1729
1730         * DumpRenderTree/win/DumpRenderTree.cpp:
1731         (applicationId): Use makeString instead of String::format.
1732         (main): Ditto.
1733         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1734         (TestWebKitAPI::Util::createURLForResource): Ditto.
1735         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1736         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1737
1738         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1739         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1740         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1741         (WTR::createStringWithAttributes): Use appendLiteral.
1742         (WTR::AccessibilityUIElement::helpText const): Ditto.
1743         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1744         directly instead of using String::format.
1745         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1746         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1747
1748 2019-02-15  Truitt Savell  <tsavell@apple.com>
1749
1750         Unreviewed, rolling out r241564.
1751
1752         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1753
1754         Reverted changeset:
1755
1756         "[Mac] WebInspectorUI.framework does not need to be soft-
1757         linked anymore"
1758         https://bugs.webkit.org/show_bug.cgi?id=194411
1759         https://trac.webkit.org/changeset/241564
1760
1761 2019-02-15  Saam barati  <sbarati@apple.com>
1762
1763         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1764         https://bugs.webkit.org/show_bug.cgi?id=194036
1765
1766         Reviewed by Yusuke Suzuki.
1767
1768         * Scripts/run-jsc-stress-tests:
1769
1770 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1771
1772         Fix the build.
1773
1774         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1775         (WTR::UIScriptController::drawSquareInEditableImage):
1776         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1777         (TestWebKitAPI::drawSquareInEditableImage):
1778
1779 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1780
1781         Fix the build.
1782
1783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1784         (WTR::UIScriptController::drawSquareInEditableImage):
1785         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1786         (TestWebKitAPI::drawSquareInEditableImage):
1787
1788 2019-02-14  Brian Burg  <bburg@apple.com>
1789
1790         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1791         https://bugs.webkit.org/show_bug.cgi?id=194411
1792         <rdar://problem/47787614>
1793
1794         Reviewed by Joseph Pecoraro.
1795
1796         Remove unnecessary soft linking macro usage.
1797
1798         * DumpRenderTree/mac/TestRunnerMac.mm:
1799         (TestRunner::inspectorTestStubURL):
1800         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1801         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1802         (WTR::TestRunner::inspectorTestStubURL):
1803
1804 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1805
1806         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1807         https://bugs.webkit.org/show_bug.cgi?id=194599
1808
1809         Reviewed by Lucas Forschler.
1810
1811         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1812         (StatusBubble._build_bubble):
1813
1814 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1815
1816         [ews-app] Set Foreign Key in Django build model
1817         https://bugs.webkit.org/show_bug.cgi?id=194667
1818
1819         Reviewed by Lucas Forschler.
1820
1821         * BuildSlaveSupport/ews-app/ews/models/build.py:
1822         (Build):
1823
1824 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1825
1826         [WTF] Add environment variable helpers
1827         https://bugs.webkit.org/show_bug.cgi?id=192405
1828
1829         Reviewed by Michael Catanzaro.
1830
1831         * DumpRenderTree/mac/DumpRenderTree.mm:
1832         (libraryPathForDumpRenderTree):
1833         * DumpRenderTree/win/DumpRenderTree.cpp:
1834         (libraryPathForDumpRenderTree):
1835         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1836         (setUpIOSLayoutTestCommunication):
1837         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1838         (TestWebKitAPI::strip):
1839         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1840         (beforeAll):
1841         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1842         (main):
1843         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1844         (WebKitTestBus::run):
1845         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1846         (WTR::getOutputDir):
1847         (WTR::initializeFontConfigSetting):
1848         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1849         (WTR::InjectedBundle::platformInitialize):
1850         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1851         (WTR::topLevelPath):
1852         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1853         (WTR::topLevelPath):
1854         (WTR::getOutputDir):
1855         (WTR::activateFonts):
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::TestController::libraryPathForTesting):
1858         (WTR::TestController::generateContextConfiguration const):
1859         (WTR::TestController::generatePageConfiguration):
1860         (WTR::TestController::decideDestinationWithSuggestedFilename):
1861         (WTR::TestController::platformAdjustContext):
1862         * WebKitTestRunner/TestController.h:
1863         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1864         (WTR::TestController::cocoaPlatformInitialize):
1865         (WTR::TestController::platformAdjustContext):
1866         * WebKitTestRunner/gtk/main.cpp:
1867         (main):
1868         * WebKitTestRunner/mac/TestControllerMac.mm:
1869         (WTR::TestController::configureContentExtensionForTest):
1870         * WebKitTestRunner/wpe/main.cpp:
1871         (main):
1872         Utilize WTF::Environment where possible.
1873
1874 2019-02-14  Chris Dumez  <cdumez@apple.com>
1875
1876         [PSON] Introduce a WebContent Process cache
1877         https://bugs.webkit.org/show_bug.cgi?id=194594
1878         <rdar://problem/46793397>
1879
1880         Reviewed by Geoff Garen.
1881
1882         Update API tests to turn on the WebContent Process cache.
1883
1884         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1885
1886 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1887
1888         Unreviewed, build fix after r241480
1889
1890         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1891         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1892         (-[DragAndDropSimulator initWithWebView:]):
1893
1894 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1895
1896         AX: ARIA Reflection was disabled in error
1897         https://bugs.webkit.org/show_bug.cgi?id=194647
1898         <rdar://problem/48068336>
1899
1900         Reviewed by Ryosuke Niwa.
1901
1902         Remove test override now that this feature should be enabled by default.
1903
1904         * WebKitTestRunner/TestController.cpp:
1905         (WTR::TestController::resetPreferencesToConsistentValues):
1906
1907 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1908
1909         Unreviewed, rolling out r241486.
1910         https://bugs.webkit.org/show_bug.cgi?id=194655
1911
1912         causing API failures in builds (Requested by ShawnRoberts on
1913         #webkit).
1914
1915         Reverted changeset:
1916
1917         "[Cocoa] Media elements will restart network buffering just
1918         before suspending"
1919         https://bugs.webkit.org/show_bug.cgi?id=193691
1920         https://trac.webkit.org/changeset/241486
1921
1922 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1923
1924         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1925         https://bugs.webkit.org/show_bug.cgi?id=194622
1926
1927         Reviewed by Antti Koivisto.
1928
1929         * LayoutReloaded/misc/LFC-passing-tests.txt:
1930
1931 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1932
1933         [LFC] Shrink-to-fit-width should be constrained by min/max width
1934         https://bugs.webkit.org/show_bug.cgi?id=194653
1935
1936         Reviewed by Antti Koivisto.
1937
1938         * LayoutReloaded/misc/LFC-passing-tests.txt:
1939
1940 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1941
1942         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1943         https://bugs.webkit.org/show_bug.cgi?id=194641
1944
1945         Reviewed by Geoffrey Garen.
1946
1947         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1948         so that the test would fail without this fix.
1949
1950         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1951         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1952
1953 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1954
1955         [ews-app] Change log level for a log statement
1956
1957         Unreviewed minor fix.
1958
1959         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1960         (Patch.save_patch):
1961
1962 2019-02-13  Jer Noble  <jer.noble@apple.com>
1963
1964         [Cocoa] Media elements will restart network buffering just before suspending
1965         https://bugs.webkit.org/show_bug.cgi?id=193691
1966
1967         Reviewed by Eric Carlson.
1968
1969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1971         (TEST):
1972
1973 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1974
1975         [ews-app] Fetch builder id to name mapping
1976         https://bugs.webkit.org/show_bug.cgi?id=194355
1977
1978         Reviewed by Lucas Forschler.
1979
1980         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1981         (Buildbot.get_builder_id_to_name_mapping):
1982         (Buildbot._get_display_name_from_builder_name):
1983
1984 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1985
1986         Further restricting webarchive loads
1987         https://bugs.webkit.org/show_bug.cgi?id=194567
1988         <rdar://problem/47610130>
1989
1990         Reviewed by Youenn Fablet.
1991
1992         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1993         navigations on drop.
1994
1995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1996         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1997         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1998         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1999         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2000         (TestWebKitAPI::TEST):
2001         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2002         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2003         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2004         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2005         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2006         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2007         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2008
2009 2019-02-13  John Wilander  <wilander@apple.com>
2010
2011         Store Ad Click Attribution requests in the network process
2012         https://bugs.webkit.org/show_bug.cgi?id=194510
2013         <rdar://problem/47650118>
2014
2015         Reviewed by Alex Christensen and Daniel Bates.
2016
2017         This patch adds two TestRunner functions:
2018         - dumpAdClickAttribution()
2019         - clearAdClickAttribution()
2020
2021         They call into the network process to dump and clear Ad Click
2022         Attribution state, respectively.
2023
2024         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2026         (WTR::TestRunner::dumpAdClickAttribution):
2027         (WTR::TestRunner::clearAdClickAttribution):
2028         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2029         * WebKitTestRunner/TestController.cpp:
2030         (WTR::TestController::resetStateToConsistentValues):
2031         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2032         (WTR::adClickAttributionStringResultCallback):
2033         (WTR::TestController::dumpAdClickAttribution):
2034         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2035         (WTR::adClickAttributionVoidCallback):
2036         (WTR::TestController::clearAdClickAttribution):
2037         * WebKitTestRunner/TestController.h:
2038         * WebKitTestRunner/TestInvocation.cpp:
2039         (WTR::TestInvocation::dumpResults):
2040         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2041         (WTR::TestInvocation::dumpAdClickAttribution):
2042         * WebKitTestRunner/TestInvocation.h:
2043
2044 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2045
2046         [ews-app] Generate status-bubble
2047         https://bugs.webkit.org/show_bug.cgi?id=194572
2048
2049         Reviewed by Lucas Forschler.
2050
2051         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2052         (StatusBubble._build_bubble):
2053         (StatusBubble._should_show_bubble_for):
2054         (StatusBubble._build_bubbles_for_patch):
2055
2056 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-app] Add status bubble html template
2059         https://bugs.webkit.org/show_bug.cgi?id=194571
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/ews-app/ews/templates: Added.
2064         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2065
2066 2019-02-12  Chris Dumez  <cdumez@apple.com>
2067
2068         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2069         https://bugs.webkit.org/show_bug.cgi?id=194568
2070         <rdar://problem/47944490>
2071
2072         Reviewed by Ryosuke Niwa.
2073
2074         Add API test coverage.
2075
2076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2077         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2078
2079 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2080
2081         webkitpy: Remove bug_dummy from parsed test expectations
2082         https://bugs.webkit.org/show_bug.cgi?id=194562
2083         <rdar://problem/47853999>
2084
2085         Reviewed by Lucas Forschler.
2086
2087         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2088         (TestExpectationParser):
2089         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2090         skipped tests.
2091         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2092
2093 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2094
2095         [ews-app] Add method to fetch patch
2096         https://bugs.webkit.org/show_bug.cgi?id=194518
2097
2098         Reviewed by Lucas Forschler.
2099
2100         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2101         (Patch.get_patch):
2102
2103 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2104
2105         [LFC] Expand tests coverage (60 new tests -> 860)
2106
2107         Unreviewed test gardening (run-singly, --child-processes=1).
2108
2109         * LayoutReloaded/misc/LFC-passing-tests.txt:
2110
2111 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2112
2113         Allow pages to trigger programmatic paste from script on iOS
2114         https://bugs.webkit.org/show_bug.cgi?id=194271
2115         <rdar://problem/47808810>
2116
2117         Reviewed by Tim Horton.
2118
2119         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2120
2121         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2122         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2123         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2124         (WTR::UIScriptController::rectForMenuAction const):
2125
2126         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2127         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2128         for when the menu is shown or hidden.
2129
2130         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2131         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2132         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2133         (WTR::UIScriptController::setDidShowMenuCallback):
2134         (WTR::UIScriptController::didShowMenuCallback const):
2135         (WTR::UIScriptController::setDidHideMenuCallback):
2136         (WTR::UIScriptController::didHideMenuCallback const):
2137         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2138         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2139         (WTR::UIScriptController::rectForMenuAction const):
2140         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2141         * WebKitTestRunner/TestController.cpp:
2142         (WTR::TestController::resetPreferencesToConsistentValues):
2143         (WTR::updateTestOptionsFromTestHeader):
2144         * WebKitTestRunner/TestOptions.h:
2145
2146         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2147         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2148
2149         (WTR::TestOptions::hasSameInitializationOptions const):
2150         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2151         (WTR::UIScriptController::calendarType const):
2152         (WTR::UIScriptController::platformUndoManager const):
2153         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2154         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2155         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2156         (-[TestRunnerWKWebView dealloc]):
2157         (-[TestRunnerWKWebView _didShowMenu]):
2158         (-[TestRunnerWKWebView _didHideMenu]):
2159
2160         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2161
2162         * WebKitTestRunner/ios/TestControllerIOS.mm:
2163         (WTR::handleMenuWillHideNotification):
2164         (WTR::handleMenuDidHideNotification):
2165         (WTR::TestController::platformInitialize):
2166         (WTR::TestController::platformDestroy):
2167         (WTR::TestController::platformResetStateToConsistentValues):
2168
2169         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2170         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2171
2172         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2173         (WTR::forEachViewInHierarchy):
2174         (WTR::findViewInHierarchyOfType):
2175
2176         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2177         functions that dig through a given view's hierarchy in search of a view of a given class.
2178
2179         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2180         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2181         (WTR::UIScriptController::selectionCaretViewRect const):
2182         (WTR::UIScriptController::selectionRangeViewRects const):
2183         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2184         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2185
2186         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2187
2188         (WTR::UIScriptController::rectForMenuAction const):
2189
2190         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2191         callout bar) whose label matches the given string.
2192
2193         (WTR::UIScriptController::platformContentView const):
2194
2195         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2196         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2197         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2198
2199         (WTR::UIScriptController::platformUndoManager const): Deleted.
2200         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2201         (WTR::UIScriptController::platformContentView const):
2202         (WTR::UIScriptController::platformUndoManager const): Deleted.
2203
2204 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2205
2206         webkitpy: No option to only show unexpected failures in results.html for iPad
2207         https://bugs.webkit.org/show_bug.cgi?id=194554
2208         <rdar://problem/47922442>
2209
2210         Rubber-stamped by Aakash Jain.
2211
2212         Just because a TestExpecations file does not exist for a specific platform does not mean that
2213         TestExpecations are not being used, given that platforms inherit test expectations.
2214
2215         * Scripts/webkitpy/port/base.py:
2216         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2217         * Scripts/webkitpy/port/base_unittest.py:
2218         (PortTest.test_uses_test_expectations_file):
2219
2220 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2221
2222         Remove setDefersLoading infrastructure from WebKit2
2223         https://bugs.webkit.org/show_bug.cgi?id=194506
2224
2225         Reviewed by Brady Eidson.
2226
2227         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2228         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2229         (WTR::TestRunner::setDefersLoading): Deleted.
2230         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2231
2232 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2233
2234         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2235         https://bugs.webkit.org/show_bug.cgi?id=194522
2236         <rdar://problem/47789393>
2237
2238         Reviewed by Chris Dumez.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2242         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2244
2245 2019-02-12  Andy Estes  <aestes@apple.com>
2246
2247         [iOSMac] Enable Parental Controls Content Filtering
2248         https://bugs.webkit.org/show_bug.cgi?id=194521
2249         <rdar://39732376>
2250
2251         Reviewed by Tim Horton.
2252
2253         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2254
2255 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2256
2257         [LFC][IFC] Add intrinsic width support for float boxes.
2258         https://bugs.webkit.org/show_bug.cgi?id=194528
2259
2260         Reviewed by Antti Koivisto.
2261
2262         Expand tests coverage (2 new tests -> 800).
2263         (This is the correct test ordering --runs-singly --child-processes=1)
2264
2265         * LayoutReloaded/misc/LFC-passing-tests.txt:
2266
2267 2019-02-12  Rob Buis  <rbuis@igalia.com>
2268
2269         Implement serializing in MIME type parser
2270         https://bugs.webkit.org/show_bug.cgi?id=193909
2271
2272         Reviewed by Darin Adler.
2273
2274         Add various tests involving upper case, non-ASCII, control/null characters,
2275         various HTTP whitespace, single quotes and an unpaired surrogate.
2276
2277         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2278         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2279         (TestWebKitAPI::serializeIfValid):
2280         (TestWebKitAPI::TEST):
2281
2282 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2283
2284         [Cocoa] Ask platform for generic font family mappings
2285         https://bugs.webkit.org/show_bug.cgi?id=187723
2286         <rdar://problem/41892438>
2287
2288         Reviewed by Brent Fulgham.
2289
2290         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2291
2292         * DumpRenderTree/mac/DumpRenderTree.mm:
2293         (allowedFontFamilySet):
2294         * WebKitTestRunner/mac/TestControllerMac.mm:
2295         (WTR::allowedFontFamilySet):
2296
2297 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2298
2299         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2300         https://bugs.webkit.org/show_bug.cgi?id=193622
2301
2302         Reviewed by Michael Catanzaro.
2303
2304         This adds support for loading content extension rule sets from the JSON files which
2305         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2306         of WKTR for this could be removed, but that is left for a follow-up patch with
2307         cleanups.
2308
2309         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2310         * WebKitTestRunner/TestController.cpp:
2311         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2312         avoid having the null-terminator copied into the result.
2313         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2314         part of the preparations to run a test.
2315         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2316         (WTR::contentExtensionStoreCallback): Added.
2317         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2318         used for content extensions test.
2319         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2320         extensions and compiling the JSON rule set for tests involving content extensions.
2321         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2322         testing and disables content extensions.
2323         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2324         resetContentExtensions().
2325         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2326         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2327         configureContentExtensionForTest(), and userContentController().
2328
2329 2019-02-11  Daniel Bates  <dabates@apple.com>
2330
2331         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2332         https://bugs.webkit.org/show_bug.cgi?id=191446
2333         <rdar://problem/45929460>
2334
2335         Reviewed by Tim Horton.
2336
2337         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2338
2339         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2340         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2341         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2342         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2343         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2344         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2345         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2346         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2347         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2348         (WTR::arrayLength):
2349         (WTR::parseModifierArray):
2350         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2351         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2352         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2353         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2354
2355 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2356
2357         Unreviewed, rolling out r241272 and r241276.
2358         https://bugs.webkit.org/show_bug.cgi?id=194514
2359
2360         Broke the Apple Internal build and the fix requires human
2361         intervention :( (Requested by dydz on #webkit).
2362
2363         Reverted changesets:
2364
2365         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2366         https://bugs.webkit.org/show_bug.cgi?id=191446
2367         https://trac.webkit.org/changeset/241272
2368
2369         "Fix internal iOS build after r241272"
2370         https://bugs.webkit.org/show_bug.cgi?id=191446
2371         https://trac.webkit.org/changeset/241276
2372
2373 2019-02-11  Truitt Savell  <tsavell@apple.com>
2374
2375         Unreviewed, rolling out r241269.
2376
2377         Caused 5 layout tests crashes on Mac WK1
2378
2379         Reverted changeset:
2380
2381         "DumpRenderTree should report unknown options"
2382         https://bugs.webkit.org/show_bug.cgi?id=191303
2383         https://trac.webkit.org/changeset/241269
2384
2385 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2386
2387         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2388         https://bugs.webkit.org/show_bug.cgi?id=194313
2389
2390         Reviewed by Tim Horton.
2391
2392         Add a helper to determine whether the web view is presenting modal UI.
2393
2394         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2395         (WTR::UIScriptController::isPresentingModally const):
2396         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2397         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2398         (WTR::UIScriptController::isPresentingModally const):
2399         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2400         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2401         (WTR::UIScriptController::calendarType const): Deleted.
2402         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2403         (WTR::UIScriptController::isPresentingModally const):
2404         (WTR::UIScriptController::calendarType const):
2405         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2406         (WTR::UIScriptController::calendarType const):
2407
2408 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2409
2410         GCHeapInspector: Show the retained sizes in more places
2411         https://bugs.webkit.org/show_bug.cgi?id=194464
2412
2413         Reviewed by Simon Fraser.
2414
2415         * GCHeapInspector/gc-heap-inspector.html:
2416         * GCHeapInspector/script/interface.js:
2417         (HeapInspectorUtils.humanReadableSize):
2418         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2419         (HeapInspectorUtils.spanForNode.span.span):
2420         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2421         (HeapSnapshotInspector.prototype.buildRoots):
2422
2423 2019-02-11  Daniel Bates  <dabates@apple.com>
2424
2425         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2426         https://bugs.webkit.org/show_bug.cgi?id=191446
2427         <rdar://problem/45929460>
2428
2429         Reviewed by Tim Horton.
2430
2431         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2432
2433         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2434         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2435         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2436         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2437         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2438         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2439         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2440         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2441         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2442         (WTR::arrayLength):
2443         (WTR::parseModifierArray):
2444         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2445         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2446         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2447         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2448
2449 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2450
2451         DumpRenderTree should report unknown options
2452         https://bugs.webkit.org/show_bug.cgi?id=191303
2453
2454         Reviewed by Frédéric Wang.
2455
2456         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2457         to report unknown options.
2458         Added and assigned test options which are currently used in tests.
2459
2460         * DumpRenderTree/TestOptions.cpp:
2461         (TestOptions::TestOptions):
2462
2463 2019-02-11  Truitt Savell  <tsavell@apple.com>
2464
2465         Unreviewed, rolling out r241229.
2466
2467         Revision broke internal builds for watchOS.
2468
2469         Reverted changeset:
2470
2471         "[Cocoa] Ask platform for generic font family mappings"
2472         https://bugs.webkit.org/show_bug.cgi?id=187723
2473         https://trac.webkit.org/changeset/241229
2474
2475 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2476
2477         [WinCairo][MiniBrowser] Basic authentication always fails.
2478         https://bugs.webkit.org/show_bug.cgi?id=194496
2479
2480         Reviewed by Don Olmstead.
2481
2482         * MiniBrowser/win/DialogHelper.h:
2483         (Dialog::getText):
2484
2485 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2486
2487         [GStreamer] GstMappedBuffer testsuite build fails
2488         https://bugs.webkit.org/show_bug.cgi?id=194495
2489
2490         Reviewed by Carlos Garcia Campos.
2491
2492         Fix the build by explicitely adding the gstreamer1.0-audio include
2493         directories to the include path.
2494
2495         * TestWebKitAPI/PlatformGTK.cmake:
2496         * TestWebKitAPI/PlatformWPE.cmake:
2497
2498 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2499
2500         [GTK][WPE] Add enable-javascript-markup setting
2501         https://bugs.webkit.org/show_bug.cgi?id=193439
2502
2503         Reviewed by Michael Catanzaro.
2504
2505         Add test cases to check the new setting.
2506
2507         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2508         (testWebKitSettings):
2509         (testWebKitSettingsJavaScriptMarkup):
2510         (beforeAll):
2511
2512 2019-02-10  Darin Adler  <darin@apple.com>
2513
2514         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2515         https://bugs.webkit.org/show_bug.cgi?id=194485
2516
2517         Reviewed by Daniel Bates.
2518
2519         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2520
2521 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2522
2523         Add more tests for clampTo<>()
2524         https://bugs.webkit.org/show_bug.cgi?id=194462
2525
2526         Reviewed by Geoffrey Garen.
2527
2528         Darin suggested to test the very last floating point number
2529         at the boundaries when truncating to integer.
2530         I added test for max/min and max-1/min-1.
2531
2532         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2533         (TestWebKitAPI::TEST):
2534
2535 2019-02-09  Darin Adler  <darin@apple.com>
2536
2537         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2538         https://bugs.webkit.org/show_bug.cgi?id=194021
2539
2540         Reviewed by Geoffrey Garen.
2541
2542         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2543         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2544         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2545
2546 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2547
2548         [LFC][IFC] Add intrinsic width support for basic inline containers
2549         https://bugs.webkit.org/show_bug.cgi?id=194473
2550
2551         Reviewed by Antti Koivisto.
2552
2553         Expand tests coverage (11 new tests -> 798)
2554
2555         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2556
2557 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2558
2559         Fix MiniBrowser's entitlements
2560         https://bugs.webkit.org/show_bug.cgi?id=192431
2561
2562         Reviewed by Joseph Pecoraro.
2563
2564         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2565         files, making it impossible to load any extension.
2566
2567         * MiniBrowser/MiniBrowser.entitlements:
2568
2569 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2570
2571         [Cocoa] Ask platform for generic font family mappings
2572         https://bugs.webkit.org/show_bug.cgi?id=187723
2573         <rdar://problem/41892438>
2574
2575         Reviewed by Brent Fulgham.
2576
2577         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2578
2579         * DumpRenderTree/mac/DumpRenderTree.mm:
2580         (allowedFontFamilySet):
2581         * WebKitTestRunner/mac/TestControllerMac.mm:
2582         (WTR::allowedFontFamilySet):
2583
2584 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2585
2586         [GTK] Implement back/forward touchpad gesture
2587         https://bugs.webkit.org/show_bug.cgi?id=193919
2588
2589         Reviewed by Michael Catanzaro.
2590
2591         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2592         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2593
2594 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2595
2596         Add SPI to use networking daemon instead of XPC service
2597         https://bugs.webkit.org/show_bug.cgi?id=194427
2598
2599         Reviewed by Geoffrey Garen
2600
2601         * MiniBrowser/MiniBrowser.entitlements:
2602
2603 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2604
2605         [ews-build] Ensure that every builder in config.json has short name
2606         https://bugs.webkit.org/show_bug.cgi?id=194461
2607
2608         Reviewed by Lucas Forschler.
2609
2610         * BuildSlaveSupport/ews-build/loadConfig.py:
2611         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2612
2613 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2614
2615         [ews-build] Add short name to config.json
2616         https://bugs.webkit.org/show_bug.cgi?id=194456
2617
2618         Reviewed by Lucas Forschler.
2619
2620         * BuildSlaveSupport/ews-build/config.json: Added short name.
2621         * BuildSlaveSupport/ews-build/loadConfig.py:
2622         (loadBuilderConfig): Set the short name as the builder description.
2623
2624 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2625
2626         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2627         https://bugs.webkit.org/show_bug.cgi?id=194418
2628
2629         Reviewed by Lucas Forschler.
2630
2631         Do not include errors trying when finding crashlogs at the end of
2632         a run-webkit-tests run since we don't process those errors.
2633
2634         * Scripts/webkitpy/port/darwin.py:
2635         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2636         * Scripts/webkitpy/port/ios_device.py:
2637         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2638         * Scripts/webkitpy/port/watch_device.py:
2639         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2640
2641 2019-02-08  Beth Dakin  <bdakin@apple.com>
2642
2643         Add afterScreenUpdates to WKSnapshotConfiguration
2644         https://bugs.webkit.org/show_bug.cgi?id=194362
2645         -and corresponding-
2646         <rdar://problem/40655528> Please add an "after screen updates" property to 
2647         WKSnapshotConfiguration (to solve blank snapshots)
2648
2649         Reviewed by Tim Horton.
2650
2651         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2652         (TEST):
2653
2654 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2655
2656         clampTo(): do not convert the input to double when dealing with integers
2657         https://bugs.webkit.org/show_bug.cgi?id=194263
2658         <rdar://problem/47692312>
2659
2660         Reviewed by Darin Adler.
2661
2662         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2663         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2664         (TestWebKitAPI::testClampFloatingPointToInteger):
2665         (TestWebKitAPI::testClampSameSignIntegers):
2666         (TestWebKitAPI::testClampUnsignedToSigned):
2667         (TestWebKitAPI::testClampSignedToUnsigned):
2668
2669 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2670
2671         webkitpy: Respect --dedicated-simulators flag
2672         https://bugs.webkit.org/show_bug.cgi?id=194416
2673         <rdar://problem/47894722>
2674
2675         Reviewed by Lucas Forschler.
2676
2677         * Scripts/webkitpy/port/device_port.py:
2678         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2679         available devices can be safely ignored.
2680
2681 2019-02-07  Keith Rollin  <krollin@apple.com>
2682
2683         Remove extra copy of 100x100-red.tga
2684         https://bugs.webkit.org/show_bug.cgi?id=194371
2685         <rdar://problem/47873465>
2686
2687         Reviewed by Said Abou-Hallawa.
2688
2689         In order to help it pass its tests, Bug 194190 added a second copy of
2690         the file 100x100-red.tga. However, it turns out that this additional
2691         file wasn't actually needed, and that that sole previous copy was
2692         sufficient. At the same time, this second copy -- which was copied to
2693         the same location in the build output as the first copy -- now caused
2694         XCBuild to complain because there were two production rules for the
2695         same output file. Address this by removing the newly-added extra copy.
2696
2697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2698         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2699
2700 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2701
2702         Deprecate WKBundlePageSetDefersLoading
2703         https://bugs.webkit.org/show_bug.cgi?id=191394
2704
2705         Reviewed by Dean Jackson.
2706
2707         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2708         (WTR::TestRunner::setDefersLoading):
2709
2710 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2711
2712         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2713         https://bugs.webkit.org/show_bug.cgi?id=194391
2714
2715         Reviewed by Antti Koivisto.
2716
2717         * LayoutReloaded/misc/LFC-passing-tests.txt:
2718
2719 2019-02-06  Keith Rollin  <krollin@apple.com>
2720
2721         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2722         https://bugs.webkit.org/show_bug.cgi?id=193975
2723         <rdar://problem/47643306>
2724
2725         Reviewed by Tim Horton.
2726
2727         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2728         the Info.plist file into the bundle. This step is not necessary as the
2729         implicit "bundle up all the build products into a framework" build
2730         phase does this already. Having the Copy Bundle Resources phase do
2731         this causes a conflict under XCBuild, which objects to two build
2732         phases producing the same file (Info.plist). Address this by removing
2733         Info.plist from the Copy Bundle Resources phase.
2734
2735         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2736
2737 2019-02-06  Keith Rollin  <krollin@apple.com>
2738
2739         Really enable the automatic checking and regenerations of .xcfilelists during builds
2740         https://bugs.webkit.org/show_bug.cgi?id=194357
2741         <rdar://problem/47861231>
2742
2743         Reviewed by Chris Dumez.
2744
2745         Bug 194124 was supposed to enable the automatic checking and
2746         regenerating of .xcfilelist files during the build. While related
2747         changes were included in that patch, the change to actually enable the
2748         operation somehow was omitted. This patch actually enables the
2749         operation. The check-xcfilelist.sh scripts now check
2750         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2751         from the checking.
2752
2753         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2754         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2755
2756 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2757
2758         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2759         <https://webkit.org/b/194286>
2760         <rdar://problem/47815558>
2761
2762         Reviewed by Alexey Proskuryakov.
2763
2764         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2765         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2766         WKRetainPtr<> to avoid leaking the WKDataRef.
2767
2768 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2769
2770         Unreviewed, fix a typo
2771
2772         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2773
2774 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2775
2776         [GTK][WPE] force libpsl build to use ICU in jhbuild
2777         https://bugs.webkit.org/show_bug.cgi?id=194288
2778
2779         Reviewed by Carlos Garcia Campos.
2780
2781         * gtk/jhbuild.modules:
2782         Require ICU for libpsl build in jhbuild, like done in WPE.
2783
2784 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2785
2786         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2787         https://bugs.webkit.org/show_bug.cgi?id=194209
2788
2789         Reviewed by Carlos Garcia Campos.
2790
2791         Enhance TestCookieManager to ensure this doesn't happen again.
2792
2793         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2794         (testCookieManagerPersistentStorage):
2795         (beforeAll):
2796
2797 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2798
2799         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2800         https://bugs.webkit.org/show_bug.cgi?id=194324
2801
2802         Reviewed by Andy Estes.
2803
2804         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2805         part of the name is already implicit, since this is in testing code in TestOptions.
2806
2807         * WebKitTestRunner/TestController.cpp:
2808         (WTR::TestController::generateContextConfiguration const):
2809         (WTR::updateTestOptionsFromTestHeader):
2810         * WebKitTestRunner/TestOptions.h:
2811         (WTR::TestOptions::hasSameInitializationOptions const):
2812
2813 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2814
2815         [ews-build] Allow * as platform for builders and workers
2816         https://bugs.webkit.org/show_bug.cgi?id=188533
2817
2818         Reviewed by Lucas Forschler.
2819
2820         * BuildSlaveSupport/ews-build/loadConfig.py:
2821         (checkWorkersAndBuildersForConsistency):
2822
2823 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2824
2825         [ews-build] Add few bots to config.json
2826         https://bugs.webkit.org/show_bug.cgi?id=194304
2827
2828         Reviewed by Lucas Forschler.
2829
2830         * BuildSlaveSupport/ews-build/config.json:
2831
2832 2019-02-05  Keith Rollin  <krollin@apple.com>
2833
2834         Enable the automatic checking and regenerations of .xcfilelists during builds
2835         https://bugs.webkit.org/show_bug.cgi?id=194124
2836         <rdar://problem/47721277>
2837
2838         Reviewed by Tim Horton.
2839
2840         Bug 193790 add a facility for checking -- during build time -- that
2841         any needed .xcfilelist files are up-to-date and for updating them if
2842         they are not. This facility was initially opt-in by setting
2843         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2844         the process seemed robust. Its now time to enable this facility and
2845         make it opt-out. If there is a need to disable this facility, set and
2846         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2847         running `make` or `build-webkit`, or before running Xcode from the
2848         command line.
2849
2850         Additionally, remove the step that generates a list of source files
2851         going into the UnifiedSources build step. It's only necessarily to
2852         specify Sources.txt and SourcesCocoa.txt as inputs.
2853
2854         * Scripts/generate-xcfilelists:
2855
2856 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2857
2858         [GTK][WPE] force libpsl build to use ICU in jhbuild
2859         https://bugs.webkit.org/show_bug.cgi?id=194288
2860
2861         Reviewed by Philippe Normand.
2862
2863         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2864         This can cause build failures if libidn is detected but libunistring is not available.
2865
2866         Make sure that ICU is used for runtime and builtin PSL data.
2867
2868         * gtk/jhbuild.modules:
2869         * wpe/jhbuild.modules:
2870
2871 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2872
2873         [ews-app] Modified timestamp should be updated on updating data
2874         https://bugs.webkit.org/show_bug.cgi?id=194295
2875
2876         Reviewed by Lucas Forschler.
2877
2878         * BuildSlaveSupport/ews-app/ews/models/build.py:
2879         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2880         * BuildSlaveSupport/ews-app/ews/models/step.py:
2881
2882 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2883
2884         Unreviewed, rolling out r240742.
2885
2886         Causes crashes on iOS simulator.
2887
2888         Reverted changeset:
2889
2890         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2891         not focused in a content-editable element"
2892         https://bugs.webkit.org/show_bug.cgi?id=192824
2893         https://trac.webkit.org/changeset/240742
2894
2895 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2896
2897         run-webkit-tests emits message "...running None" when running tests
2898         https://bugs.webkit.org/show_bug.cgi?id=194133
2899         <rdar://problem/47724738>
2900
2901         Reviewed by Lucas Forschler.
2902
2903         * Scripts/webkitpy/xcode/device_type.py:
2904         (DeviceType.__str__): Use both version mapping tables and use just the variant
2905         name if no version name is available.
2906         * Scripts/webkitpy/xcode/device_type_unittest.py:
2907         (DeviceTypeTest):
2908         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2909         an associated named.
2910
2911 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2912
2913         [WPE] require python3-setuptools for meson build in jhbuild
2914         https://bugs.webkit.org/show_bug.cgi?id=194287
2915
2916         Reviewed by Philippe Normand.
2917
2918         python3-setuptools is needed to build meson in jhbuild.
2919         It is already required by the GTK port.
2920
2921         * wpe/install-dependencies:
2922
2923 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2924
2925         [ews-app] Add method to save BuilderMapping to database
2926         https://bugs.webkit.org/show_bug.cgi?id=194264
2927
2928         Reviewed by Lucas Forschler.
2929
2930         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2931         (BuilderMapping.__str__):
2932         (BuilderMapping):
2933         (BuilderMapping.save_mapping):
2934         (BuilderMapping.update_mapping):
2935         (BuilderMapping.get_existing_mapping):
2936         (BuilderMapping.is_valid_mapping):
2937
2938 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2939
2940         [ews-app] Add timestamp fields for BuilderMappings
2941         https://bugs.webkit.org/show_bug.cgi?id=194266
2942
2943         Reviewed by Lucas Forschler.
2944
2945         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2946         (BuilderMapping):
2947
2948 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2949
2950         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2951         https://bugs.webkit.org/show_bug.cgi?id=174816
2952
2953         Reviewed by Michael Catanzaro.
2954
2955         Add tests for webkit_uri_for_display().
2956
2957         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2958         (testURIForDisplayUnaffected):
2959         (testURIForDisplayAffected):
2960         (beforeAll):
2961         (afterAll):
2962         * TestWebKitAPI/glib/CMakeLists.txt:
2963
2964 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2965
2966         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2967         https://bugs.webkit.org/show_bug.cgi?id=194158
2968         <rdar://problem/47737268>
2969
2970         Rubber-stamped by Aakash Jain.
2971
2972         * Scripts/webkitpy/port/device_port.py:
2973         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2974
2975 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2976
2977         [CG] Enable setAdditionalSupportedImageTypes for WK1
2978         https://bugs.webkit.org/show_bug.cgi?id=194190
2979
2980         Reviewed by Tim Horton.
2981
2982         Add a test similar to the one under WebKit Cocoa but make it create a
2983         WebView instead of a WKWebView.
2984
2985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2986         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2987         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2988         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2989         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2990         (TestWebKitAPI::runTest):
2991         (TestWebKitAPI::TEST):
2992
2993 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2994
2995         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2996         https://bugs.webkit.org/show_bug.cgi?id=194168
2997
2998         Reviewed by Simon Fraser.
2999
3000         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3001
3002         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3003         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3004         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3005         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3006         (TEST):
3007         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3008         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3009
3010 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3011
3012         REGRESSION (r237269): webkit-patch what-broke is broken 
3013         https://bugs.webkit.org/show_bug.cgi?id=193025
3014
3015         Reviewed by Aakash Jain.
3016
3017         * Scripts/webkitpy/common/host.py:
3018         (Host.buildbot):
3019         (Host.bugzilla): Renamed to 'buildbot'.
3020
3021 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3022
3023         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3024         https://bugs.webkit.org/show_bug.cgi?id=194207
3025
3026         Reviewed by Tim Horton.
3027
3028         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3029         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3030         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3031         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3032         start and delete forwards to remove the original attachment.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3035         (TestWebKitAPI::TEST):
3036
3037 2019-02-04  Youenn Fablet  <youenn@apple.com>
3038
3039         Capture state should be managed consistently when doing process swapping
3040         https://bugs.webkit.org/show_bug.cgi?id=194122
3041         <rdar://problem/47609293>
3042
3043         Reviewed by Eric Carlson.
3044
3045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3046         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3047         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3048         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3049         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3051         (WTR::TestRunner::isDoingMediaCapture const):
3052         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3053         * WebKitTestRunner/TestController.cpp:
3054         (WTR::TestController::isDoingMediaCapture const):
3055         * WebKitTestRunner/TestController.h:
3056         * WebKitTestRunner/TestInvocation.cpp:
3057         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3058         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3059         (WTR::TestController::isDoingMediaCapture const):
3060
3061 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3062
3063         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3064         https://bugs.webkit.org/show_bug.cgi?id=194142
3065
3066         Reviewed by Ross Kirsling.
3067
3068         There three 'separator' variables in TestController.cpp. Renamed
3069         it 'pathSeparator', and unified them.
3070
3071         * WebKitTestRunner/TestController.cpp:
3072         (WTR::TestController::generateContextConfiguration const):
3073         (WTR::createTestURL):
3074         (WTR::TestController::platformAdjustContext):
3075
3076 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3077
3078         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3079         https://bugs.webkit.org/show_bug.cgi?id=194198
3080
3081         Reviewed by Antti Koivisto.
3082
3083         No need to set the banner heights on navigation now, since Page stores them.
3084
3085         * MiniBrowser/mac/WK2BrowserWindowController.m:
3086         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3087
3088 2019-02-03  John Wilander  <wilander@apple.com>
3089
3090         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3091         https://bugs.webkit.org/show_bug.cgi?id=194104
3092         <rdar://problem/47649991>
3093
3094         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3095
3096         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3097         (TestWebKitAPI::TEST):
3098             Changed numeric types from unsigned short to uint32_t.
3099
3100 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3101
3102         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3103         <https://webkit.org/b/194178>
3104         <rdar://problem/47753473>
3105
3106         Reviewed by Alexey Proskuryakov.
3107
3108         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3109         (WTR::uninstallFakeHelvetica): Pass nullptr into
3110         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3111
3112 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3113
3114         [LFC] Initialize ICB's style with fixed width/height.
3115         https://bugs.webkit.org/show_bug.cgi?id=194188
3116
3117         Reviewed by Antti Koivisto.
3118
3119         * LayoutReloaded/misc/LFC-passing-tests.txt:
3120
3121 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3122
3123         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3124         https://bugs.webkit.org/show_bug.cgi?id=194185
3125
3126         Reviewed by Antti Koivisto.
3127
3128         * LayoutReloaded/misc/LFC-passing-tests.txt:
3129
3130 2018-12-16  Darin Adler  <darin@apple.com>
3131
3132         Convert additional String::format clients to alternative approaches
3133         https://bugs.webkit.org/show_bug.cgi?id=192746
3134
3135         Reviewed by Alexey Proskuryakov.
3136
3137         * WebKitTestRunner/TestController.cpp:
3138         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3139         as an intermediate in code that ultimately constructs a WTF::String.
3140         (WTR::userMediaOriginHash): Use makeString.
3141         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3142         (WTR::TestController::didPerformClientRedirect): Ditto.
3143         (WTR::TestController::didPerformServerRedirect): Ditto.
3144         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3145
3146 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3147
3148         [ews-build] Add unit test to verify builder keys
3149         https://bugs.webkit.org/show_bug.cgi?id=194152
3150
3151         Reviewed by Lucas Forschler.
3152
3153         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3154         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3155
3156 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3157
3158         [LFC] Expand tests coverage (12 new tests -> 787)
3159
3160         Unreviewed test gardening.
3161
3162         * LayoutReloaded/misc/LFC-passing-tests.txt:
3163
3164 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3165
3166         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3167         https://bugs.webkit.org/show_bug.cgi?id=194163
3168
3169         Reviewed by Simon Fraser.
3170
3171         775
3172
3173         * LayoutReloaded/misc/LFC-passing-tests.txt:
3174
3175 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3176
3177         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3178         https://bugs.webkit.org/show_bug.cgi?id=194140
3179         <rdar://problem/47728098>
3180
3181         Reviewed by Tim Horton.
3182
3183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3185         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3186
3187         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3188         test to induce an IPC deadlock when presenting a modal alert during touch start.
3189
3190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3191         * WebKitTestRunner/TestController.cpp:
3192         (WTR::runJavaScriptAlert):
3193
3194         Add a client callback function for running JavaScript alerts.
3195
3196         (WTR::TestController::createOtherPage):
3197         (WTR::TestController::generateContextConfiguration const):
3198
3199         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3200         the fix in this patch.
3201
3202         (WTR::TestController::createWebViewWithOptions):
3203
3204         Plumb TestOptions to generateContextConfiguration.
3205
3206         (WTR::TestController::resetPreferencesToConsistentValues):
3207         (WTR::TestController::resetStateToConsistentValues):
3208         (WTR::updateTestOptionsFromTestHeader):
3209         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3210         (WTR::TestController::handleJavaScriptAlert):
3211         * WebKitTestRunner/TestController.h:
3212         * WebKitTestRunner/TestInvocation.cpp:
3213         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3214         * WebKitTestRunner/TestOptions.h:
3215         (WTR::TestOptions::hasSameInitializationOptions const):
3216
3217 2019-02-01  Chris Dumez  <cdumez@apple.com>
3218
3219         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3220         https://bugs.webkit.org/show_bug.cgi?id=193740
3221         <rdar://problem/47527267>
3222
3223         Reviewed by Alex Christensen.
3224
3225         Add API test coverage.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3228
3229 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3230
3231         [ews-app] Add display name field to BuilderMapping model
3232         https://bugs.webkit.org/show_bug.cgi?id=194153
3233
3234         Reviewed by Lucas Forschler.
3235
3236         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3237         (BuilderMapping):
3238
3239 2019-02-01  Youenn Fablet  <youenn@apple.com>
3240
3241         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3242         https://bugs.webkit.org/show_bug.cgi?id=194155
3243
3244         Reviewed by Eric Carlson.
3245
3246         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3247         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3248         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3249
3250 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3251
3252         [LFC] Adjust replaced element's intrinsic ratio
3253         https://bugs.webkit.org/show_bug.cgi?id=194154
3254
3255         Reviewed by Antti Koivisto.
3256
3257         761
3258
3259         * LayoutReloaded/misc/LFC-passing-tests.txt:
3260
3261 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3262
3263         [WPE] Show test results in minibrowser
3264         https://bugs.webkit.org/show_bug.cgi?id=194150
3265
3266         Reviewed by Žan Doberšek.
3267
3268         * Scripts/webkitpy/port/wpe.py:
3269         (WPEPort.show_results_html_file):
3270
3271 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3272
3273         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3274         https://bugs.webkit.org/show_bug.cgi?id=194151
3275
3276         Reviewed by Žan Doberšek.
3277
3278         ALT + <- go back
3279         ALT + -> go forward
3280
3281         * MiniBrowser/wpe/main.cpp:
3282         (main):
3283
3284 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3285
3286         [LFC] Set intrinsic size on Layout::Replaced
3287         https://bugs.webkit.org/show_bug.cgi?id=194139
3288
3289         Reviewed by Antti Koivisto.
3290
3291         744
3292
3293         * LayoutReloaded/misc/LFC-passing-tests.txt:
3294
3295 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3296
3297         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3298         https://bugs.webkit.org/show_bug.cgi?id=194146
3299
3300         Reviewed by Xabier Rodriguez-Calvar.
3301
3302         It allows to open relative paths.
3303
3304         * MiniBrowser/wpe/main.cpp:
3305         (main):
3306
3307 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3308
3309         Update flakiness dashboard configuration after recent queue changes
3310         https://bugs.webkit.org/show_bug.cgi?id=194127
3311
3312         Rubber-stamped by Aakash Jain.
3313
3314         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3315
3316         * TestResultServer/static-dashboards/builders.jsonp:
3317
3318 2019-01-31  Youenn Fablet  <youenn@apple.com>
3319
3320         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3321         https://bugs.webkit.org/show_bug.cgi?id=194106
3322         <rdar://problem/47676333>
3323
3324         Reviewed by Ryosuke Niwa.
3325
3326         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3327         (TestWebKitAPI::didFinishNavigation):
3328         (TestWebKitAPI::TEST):
3329         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3330
3331 2019-01-31  Chris Dumez  <cdumez@apple.com>
3332
3333         Page zoom level is lost after a process swap or a crash
3334         https://bugs.webkit.org/show_bug.cgi?id=194105
3335         <rdar://problem/47610781>
3336
3337         Reviewed by Alex Christensen.
3338
3339         Add API test coverage.
3340
3341         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3342         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3343
3344 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3345
3346         Revert r238819 which is unneeded and caused a performance regression.
3347         https://bugs.webkit.org/show_bug.cgi?id=192272
3348         <rdar://problem/46664625>
3349
3350         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3351         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3352         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3353
3354 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3355
3356         Formalize WebKitAdditions mechanism of LoadOptimizer
3357         https://bugs.webkit.org/show_bug.cgi?id=193886
3358         <rdar://problem/47696809>
3359
3360         Reviewed by Brent Fulgham.
3361
3362         * MiniBrowser/MiniBrowser.entitlements:
3363         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3364
3365 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3366
3367         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3368         https://bugs.webkit.org/show_bug.cgi?id=194090
3369
3370         Reviewed by Antti Koivisto.
3371
3372         * LayoutReloaded/misc/LFC-passing-tests.txt:
3373
3374 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3375
3376         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3377         https://bugs.webkit.org/show_bug.cgi?id=194074
3378
3379         Reviewed by Antti Koivisto.
3380
3381         * LayoutReloaded/misc/LFC-passing-tests.txt:
3382
3383 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3384
3385         [LFC][BFC] Add support for block level replaced box.
3386         https://bugs.webkit.org/show_bug.cgi?id=194071
3387
3388         Reviewed by Antti Koivisto.
3389
3390         * LayoutReloaded/misc/LFC-passing-tests.txt:
3391
3392 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3393
3394         Fix WebKitTestRunner's testPath with Windows full paths
3395         https://bugs.webkit.org/show_bug.cgi?id=194012
3396
3397         Reviewed by Alex Christensen.
3398
3399         updateTestOptionsFromTestHeader failed to open test files because
3400         testPath returned wrong file paths. It returned a path "/C:/..."
3401         if a URL "file:///C:/..." was given.
3402
3403         * WebKitTestRunner/TestController.cpp:
3404         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3405
3406 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3407
3408         [WPE] Bump font related dependencies to match the GTK+ port
3409         https://bugs.webkit.org/show_bug.cgi?id=194017
3410
3411         Reviewed by Žan Doberšek.
3412
3413         * wpe/jhbuild.modules:
3414         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3415         * wpe/patches/icudata-stdlibs.patch: Added.
3416
3417 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3418
3419         Enable swipe tests on iOS
3420         https://bugs.webkit.org/show_bug.cgi?id=194076
3421
3422         Reviewed by Geoffrey Garen.
3423
3424         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3425         it causes a debug assertion failure in runUIScript.
3426
3427         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3428         (WTR::UIScriptController::beginBackSwipe):
3429         (WTR::UIScriptController::completeBackSwipe):
3430
3431 2019-01-30  Keith Rollin  <krollin@apple.com>
3432
3433         Use correct printf format specifier
3434         https://bugs.webkit.org/show_bug.cgi?id=194062
3435         <rdar://problem/47686167>
3436
3437         Reviewed by Alexey Proskuryakov.
3438
3439         LayoutTestSpellChecker.mm is trying to format a variable of type
3440         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3441         actually an unsigned long long. Fix this by formatting with %llu.
3442
3443         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3444         (-[LayoutTestTextCheckingResult description]):
3445
3446 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3447
3448         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3449         https://bugs.webkit.org/show_bug.cgi?id=193979
3450
3451         Reviewed by Wenson Hsieh.
3452
3453         Fix the test for iOS. Make the test work with iOS UA string.
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3456
3457 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3458
3459         Replace High Sierra LLINT CLoop bot due to hardware failure
3460         https://bugs.webkit.org/show_bug.cgi?id=194066
3461
3462         Reviewed by Aakash Jain.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/config.json:
3465
3466 2019-01-30  Keith Rollin  <krollin@apple.com>
3467
3468         [NSDragItem init] is unavailable
3469         https://bugs.webkit.org/show_bug.cgi?id=194059
3470         <rdar://problem/47685715>
3471
3472         Reviewed by Wenson Hsieh.
3473
3474         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3475         DumpRenderTree and TestWebKitAPI, which both try to create an
3476         NSDragItem in a manner that invokes this method. Address this by using
3477         -initWithPasteboardWriter instead.
3478
3479         Note that the parameter passed to initWithPasteboardWriter is likely
3480         incorrect. In both cases, the object passed does not conform to
3481         NSPasteboardWriting. However, with this fix, we're no worse off than
3482         before, and can now perform builds with newer compilers and SDKs until
3483         a real fix can be crafted. That work is tracked in
3484         https://bugs.webkit.org/show_bug.cgi?id=194060
3485
3486         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3487         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3488         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3489         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3490
3491 2019-01-30  Daniel Bates  <dabates@apple.com>
3492
3493         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3494         https://bugs.webkit.org/show_bug.cgi?id=192824
3495         <rdar://problem/47100332>
3496
3497         Reviewed by Wenson Hsieh.
3498
3499         Fix a bug where the wrong usage code was used for F13 thru F24.
3500
3501         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3502         (keyCodeForDOMFunctionKey):
3503
3504 2019-01-30  Chris Dumez  <cdumez@apple.com>
3505
3506         Regression(PSON) Load hang can occur on history navigation
3507         https://bugs.webkit.org/show_bug.cgi?id=194030
3508         <rdar://problem/47656939>
3509
3510         Reviewed by Antti Koivisto.
3511
3512         Add API test coverage.
3513
3514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3515
3516 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3517
3518         [LFC] Expand tests coverage.
3519
3520         Unreviewed test gardening.
3521
3522         * LayoutReloaded/misc/LFC-passing-tests.txt:
3523
3524 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3525
3526         [Flatpak] Add openjpeg support
3527         https://bugs.webkit.org/show_bug.cgi?id=194019
3528
3529         Reviewed by Michael Catanzaro.
3530
3531         * flatpak/org.webkit.CommonModules.yaml:
3532
3533 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3534
3535         Unreviewed, rolling out r240708.
3536         https://bugs.webkit.org/show_bug.cgi?id=194022
3537
3538         It broke WPE build (Requested by KaL on #webkit).
3539
3540         Reverted changeset:
3541
3542         "[WPE] Bump font related dependencies to match the GTK+ port"
3543         https://bugs.webkit.org/show_bug.cgi?id=194017
3544         https://trac.webkit.org/changeset/240708
3545
3546 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3547
3548         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3549         https://bugs.webkit.org/show_bug.cgi?id=194001
3550
3551         Reviewed by Antti Koivisto.
3552
3553         * LayoutReloaded/misc/LFC-passing-tests.txt:
3554
3555 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3556
3557         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3558         https://bugs.webkit.org/show_bug.cgi?id=194020
3559
3560         Reviewed by Antti Koivisto.
3561
3562         * LayoutReloaded/misc/LFC-passing-tests.txt:
3563
3564 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3565
3566         AX: Support color well on iOS
3567         https://bugs.webkit.org/show_bug.cgi?id=194010
3568
3569         Reviewed by Joanmarie Diggs.
3570
3571         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3572         (WTR::AccessibilityUIElement::stringAttributeValue):
3573
3574 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3575
3576         [WPE] Bump font related dependencies to match the GTK+ port
3577         https://bugs.webkit.org/show_bug.cgi?id=194017
3578
3579         Reviewed by Žan Doberšek.
3580
3581         * wpe/jhbuild.modules:
3582         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3583         * wpe/patches/icudata-stdlibs.patch: Added.
3584
3585 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3586
3587         [Mac] Update window scale API usage
3588         https://bugs.webkit.org/show_bug.cgi?id=193991
3589         rdar://problem/47614795
3590
3591         Reviewed by Tim Horton.
3592
3593         * DumpRenderTree/mac/DumpRenderTree.mm:
3594         (changeWindowScaleIfNeeded):
3595         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3596         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3597         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3598
3599 2019-01-29  Chris Dumez  <cdumez@apple.com>
3600
3601         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3602         https://bugs.webkit.org/show_bug.cgi?id=193977
3603         <rdar://problem/47643716>
3604
3605         Reviewed by Geoff Garen.
3606
3607         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3608         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3609         to the previous provisional committing *before* we make the last load. 
3610
3611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3612
3613 2019-01-29  Youenn Fablet  <youenn@apple.com>
3614
3615         Adopt new SPI to evaluate server certificate trust
3616         https://bugs.webkit.org/show_bug.cgi?id=193355
3617
3618         Reviewed by Alex Christensen.
3619
3620         Add infrastructure to handle HTTPS server trust evaluation testing.
3621
3622         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3623         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3624         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3625         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3626         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3627         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3628         * WebKitTestRunner/TestController.cpp:
3629         (WTR::TestController::resetPreferencesToConsistentValues):
3630         (WTR::TestController::didReceiveAuthenticationChallenge):
3631         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3632         * WebKitTestRunner/TestController.h:
3633         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3634         * WebKitTestRunner/TestInvocation.cpp:
3635         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3637         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3638
3639 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3640
3641         [ews-build] Add build step to print bot Configuration
3642         https://bugs.webkit.org/show_bug.cgi?id=193887
3643
3644         Reviewed by Lucas Forschler.
3645
3646         * BuildSlaveSupport/ews-build/steps.py:
3647         (PrintConfiguration): Build step to print configuration.
3648         * BuildSlaveSupport/ews-build/factories.py:
3649
3650 2019-01-29  Chris Dumez  <cdumez@apple.com>
3651
3652         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3653         https://bugs.webkit.org/show_bug.cgi?id=193967
3654         <rdar://problem/47635348>
3655
3656         Reviewed by Alex Christensen.
3657
3658         Add API test coverage.
3659
3660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3661         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3662
3663 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3664
3665         [ews-app] Handle incoming results data
3666         https://bugs.webkit.org/show_bug.cgi?id=193973
3667
3668         Reviewed by Lucas Forschler.
3669
3670         * BuildSlaveSupport/ews-app/ews/views/results.py:
3671
3672 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3673
3674         [ews-app] Make the results url generic
3675         https://bugs.webkit.org/show_bug.cgi?id=193928
3676
3677         Reviewed by Lucas Forschler.
3678
3679         * BuildSlaveSupport/ews-app/ews/urls.py:
3680
3681 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3682
3683         [ews-build] Configure buildbot to send events to ews-app
3684         https://bugs.webkit.org/show_bug.cgi?id=193968
3685
3686         Reviewed by Lucas Forschler.
3687
3688         * BuildSlaveSupport/ews-build/events.py: Added.
3689         * BuildSlaveSupport/ews-build/master.cfg:
3690
3691 2019-01-29  Keith Rollin  <krollin@apple.com>
3692
3693         Add .xcfilelists to Run Script build phases
3694         https://bugs.webkit.org/show_bug.cgi?id=193792
3695         <rdar://problem/47201785>
3696
3697         Reviewed by Alex Christensen.
3698
3699         As part of supporting XCBuild, update the necessary Run Script build
3700         phases in their Xcode projects to refer to their associated
3701         .xcfilelist files.
3702
3703         Note that the addition of these files bumps the Xcode project version
3704         number to something that's Xcode 10 compatible. This change means that
3705         older versions of the Xcode IDE can't read these projects. Nor can it
3706         fully load workspaces that refer to these projects (the updated
3707         projects are shown as non-expandable placeholders). `xcodebuild` can
3708         still build these projects; it's just that the IDE can't open them.
3709
3710         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3711         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3712
3713 2019-01-29  John Wilander  <wilander@apple.com>
3714