Do touch adjustment on GestureTapDown
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-19  Rick Byers  <rbyers@chromium.org>
2
3         Do touch adjustment on GestureTapDown
4         https://bugs.webkit.org/show_bug.cgi?id=96677
5
6         Reviewed by Antonio Gomes.
7
8         Allow radius to be set for GestureTapDown events.
9         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
10         (EventSender::gestureEvent):
11
12 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
13
14         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
15         https://bugs.webkit.org/show_bug.cgi?id=97100
16
17         Reviewed by Gyuyoung Kim.
18
19         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
20         preference, in order to match WebKitTestRunner functionality.
21
22         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
23         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
24         * DumpRenderTree/efl/TestRunnerEfl.cpp:
25         (TestRunner::overridePreference):
26
27 2012-09-18  Kangil Han  <kangil.han@samsung.com>
28
29         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
30         https://bugs.webkit.org/show_bug.cgi?id=96181
31
32         Reviewed by Daniel Bates.
33
34         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
35
36         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
37         (new):
38         (_parseLicenseBlock):
39         (_parseLicenseBlockFromFile):
40         (_defaultLicenseBlock):
41         (_licenseBlock):
42         (_generateHeaderFile):
43         (_generateImplementationFile):
44
45 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
46
47         Title string should be changed when document.title is set to ''.
48         https://bugs.webkit.org/show_bug.cgi?id=96793
49
50         Reviewed by Kenneth Rohde Christiansen.
51
52         Change dump format of dumpTitleChanges more understandable.
53         Uses single quotation marks for the title string.
54
55         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
56         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
57         * DumpRenderTree/chromium/WebViewHost.cpp:
58         (WebViewHost::didReceiveTitle):
59         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
60         (DumpRenderTreeChrome::onFrameTitleChanged):
61         * DumpRenderTree/gtk/DumpRenderTree.cpp:
62         (webViewTitleChanged):
63         * DumpRenderTree/mac/FrameLoadDelegate.mm:
64         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
65         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
66         (WebCore::DumpRenderTree::titleChanged):
67         * DumpRenderTree/win/FrameLoadDelegate.cpp:
68         (FrameLoadDelegate::didReceiveTitle):
69         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
70         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
71         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
72         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
73
74 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
75
76         EWS shouldn't sleep if there are new patches in its queue
77         https://bugs.webkit.org/show_bug.cgi?id=83038
78
79         Reviewed by Eric Seidel.
80
81         EWS tries to process a security patch. Of course it can't, because the EWS isn't
82         the member of the security group. But the problem is that after it can't process
83         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
84         and push the security patch to the end of the queue.
85         Now it stays in the loop until it finds a patch or the queue gets empty.
86
87         * Scripts/webkitpy/tool/commands/queues.py:
88         (AbstractPatchQueue._next_patch):
89         * Scripts/webkitpy/tool/commands/queues_unittest.py:
90         (AbstractPatchQueueTest.test_next_patch):
91
92 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
93
94         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
95         https://bugs.webkit.org/show_bug.cgi?id=97014
96
97         Reviewed by Kenneth Rohde Christiansen.
98
99         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
100         be used for literals rather than WTF::StringBuilder::append().
101
102         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
103         (WTR::InjectedBundle::booleanForKey):
104
105 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
106
107         Update my e-mail address.
108
109         * Scripts/webkitpy/common/config/committers.py:
110
111 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
112
113         Update my e-mail address.
114
115         Unreviewed.
116
117         * Scripts/webkitpy/common/config/committers.py:
118
119 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
120
121         [Qt] qt_webkit.pri should not be listed in Tools.pro
122
123         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
124
125         Since r128751 the module pri file is auto-generated
126         but it was still listed in OTHER_FILES.
127
128         * Tools.pro: Remove unneeded line.
129
130 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
131
132         [Qt] Fix build with some versions of the gold linker
133
134         Reviewed by Tor Arne Vestbø.
135
136         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
137         Instead run a compile/link test first to see if it works.
138
139         * qmake/config.tests/gnuld/gnuld.pro: Added.
140         * qmake/config.tests/gnuld/main.cpp: Added.
141         (main):
142         * qmake/mkspecs/features/unix/default_post.prf:
143
144 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
145
146         [Qt] Remove forced use of gold.
147
148         Reviewed by Tor Arne Vestbø.
149
150         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
151         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
152         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
153
154         * qmake/mkspecs/features/unix/default_post.prf:
155
156 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
157
158         [Qt] Prospective Qt/Windows cross-compiling fix
159
160         Reviewed by Tor Arne Vestbø.
161
162         The win32 scope is not set when cross-compiling from Linux to Windows.
163
164         * qmake/mkspecs/features/functions.prf:
165
166 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
167
168         [EFL] Remove background view on EWebLauncher and MiniBrowser
169         https://bugs.webkit.org/show_bug.cgi?id=96905
170
171         Reviewed by Gyuyoung Kim.
172
173         The size of webview was changed after adding url bar.
174         And the background view is not necessary anymore, since it was used for debugging back in the day.
175
176         * EWebLauncher/main.c:
177         (_ELauncher):
178         (on_ecore_evas_resize):
179         (browserCreate):
180         * MiniBrowser/efl/main.c:
181         (_MiniBrowser):
182         (on_ecore_evas_resize):
183         (browserCreate):
184
185 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
186
187         [GTK] run-webkit-tests unable to find TestExpectations for WK2
188         https://bugs.webkit.org/show_bug.cgi?id=96998
189
190         Reviewed by Philippe Normand.
191
192         We should look for TestExpectations files in all the locations where
193         we currently look for Skipped files. This will allow
194         run-webkit-tests to look for TestExpectations files in
195         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
196
197         * Scripts/webkitpy/layout_tests/port/gtk.py:
198         (GtkPort.expectations_files):
199
200 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
201
202         [Qt] Fix build without the QtQuick module
203
204         Reviewed by Simon Hausmann.
205
206         * qmake/mkspecs/features/features.prf:
207
208 2012-09-18  Stephanie Lewis  <slewis@apple.com>
209
210         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
211
212         Unreviewed.
213
214         * DumpRenderTree/mac/DumpRenderTree.mm:
215         (poseAsClass):
216
217 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
218
219         Unreviewed update of email addresses for Berlin QtWebKit office.
220
221         * Scripts/webkitpy/common/config/committers.py:
222
223 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
224
225         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
226         https://bugs.webkit.org/show_bug.cgi?id=96899
227
228         Reviewed by Martin Robinson.
229
230         When overriding the 'WebKitDisplayImageKey' preference, use the
231         'auto-load-images' property of WebKitWebSettings as the property which
232         should be updated with the corresponding preference value.
233
234         * DumpRenderTree/gtk/DumpRenderTree.cpp:
235         (resetDefaultsToConsistentValues):
236         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
237         (TestRunner::overridePreference):
238
239 2012-09-17  Pratik Solanki  <psolanki@apple.com>
240
241         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
242         https://bugs.webkit.org/show_bug.cgi?id=96973
243
244         Reviewed by Dan Bernstein.
245
246         * DumpRenderTree/mac/Configurations/Base.xcconfig:
247         * WebKitTestRunner/Configurations/Base.xcconfig:
248         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
249
250 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
251
252         nrwt: remove "unexpected EOF" warnings
253         https://bugs.webkit.org/show_bug.cgi?id=96970
254
255         Reviewed by Ojan Vafai.
256
257         After debugging this a bit, it looks like there aren't any cases
258         that I can reproduce where a read() of zero indicates something
259         actually wrong; either it is a prelude to a crash, or a false
260         negative. So, I'm removing these warnings and adding a comment.
261
262         * Scripts/webkitpy/layout_tests/port/server_process.py:
263         (ServerProcess._wait_for_data_and_update_buffers_using_select):
264
265 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
266
267         [chromium] ASAN bot is crashing at the end of the run
268         https://bugs.webkit.org/show_bug.cgi?id=96967
269
270         Reviewed by Abhishek Arya.
271
272         The ASAN bot is crashing attempting to decode some output into
273         UTF-8; there's no reason to do this, so let's not do this and
274         see if something else is going on as well.
275
276         * Scripts/webkitpy/layout_tests/port/chromium.py:
277         (ChromiumPort._get_crash_log):
278
279 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
280
281         nrwt: --results-directory isn't getting printed properly
282         https://bugs.webkit.org/show_bug.cgi?id=96965
283
284         Reviewed by Ojan Vafai.
285
286         options.results_directory isn't actually initialized with the
287         default values until after we call print_config(), so this
288         changes things to print the value directly.
289
290         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
291         (run):
292         * Scripts/webkitpy/layout_tests/views/printing.py:
293         (Printer.print_config):
294         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
295         (Testprinter.test_print_config):
296
297 2012-09-17  Rob Buis  <rbuis@rim.com>
298
299         [BlackBerry] Enable VIDEO_TRACK
300         https://bugs.webkit.org/show_bug.cgi?id=96949
301
302         Reviewed by Antonio Gomes.
303
304         * Scripts/webkitperl/FeatureList.pm:
305
306 2012-09-17  Rick Byers  <rbyers@chromium.org>
307
308         Add handling of new GestureTapCancel in DRT
309
310         https://bugs.webkit.org/show_bug.cgi?id=96183
311
312         Reviewed by Antonio Gomes.
313
314         * DumpRenderTree/chromium/TestWebPlugin.cpp:
315         (TestWebPlugin::handleInputEvent):
316         * DumpRenderTree/chromium/EventSender.cpp:
317         (EventSender::gestureTapCancel):
318
319 2012-09-17  Philip Rogers  <pdr@google.com>
320
321         Teach style checker about preprocessor directive indentation rules
322         https://bugs.webkit.org/show_bug.cgi?id=96874
323
324         Reviewed by Adam Barth.
325
326         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
327         This is not explicit in our style guide but is generally followed in our code.
328         Searching for violations in our codebase shows these are rarely indented:
329             #include - indented in 6 files
330             #ifdef - indented in 0 files
331             #ifndef - indented in 1 file
332             #define - indented in 11 files
333             #if - indented in 7 files
334
335         * Scripts/webkitpy/style/checkers/cpp.py:
336         (check_directive_indentation):
337
338             This is the simple test where we look for spaces followed by a #.
339
340         (check_style):
341         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
342
343             A few tests needed to be modified because they had unintentionally indented
344             preprocessor directives.
345
346         (CppStyleTest.test_build_class.Foo):
347         (CppStyleTest.test_build_class):
348         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
349         (WebKitStyleTest.test_line_breaking):
350         (WebKitStyleTest.test_directive_indentation):
351
352 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
353
354         [Qt] Auto-generate the module pri file for QtWebKit
355
356         Reviewed by Simon Hausmann.
357
358         * qmake/qt_webkit.pri: Removed.
359
360 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
361
362         nrwt: --additional-platform-dir is broken on chromium ports
363         https://bugs.webkit.org/show_bug.cgi?id=96840
364
365         Reviewed by Ojan Vafai.
366
367         Looks like I broke this when cleaning things up as part of
368         adding ML support. Fixing and adding a test.
369
370         * Scripts/webkitpy/layout_tests/port/chromium.py:
371         (ChromiumPort.default_baseline_search_path):
372         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
373         (ChromiumAndroidPort.default_baseline_search_path):
374         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
375         (ChromiumLinuxPort.default_baseline_search_path):
376         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
377         (ChromiumMacPort.__init__):
378         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
379         (ChromiumWinPort.setup_environ_for_server):
380         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
381         (test_check_build):
382         (test_additional_platform_directory):
383
384 2012-09-13  Stephanie Lewis  <slewis@apple.com>
385
386         mac-future ignores previous platform TestExpectations.
387         https://bugs.webkit.org/show_bug.cgi?id=96718.
388
389         Reviewed by Dirk Pranke.
390
391         TestExpectations match an expectation's configuraton against a list of configurations that are 
392         valid for that port.  That list does not contain mac-future so none of the expectations can be
393         applied.
394
395         * Scripts/webkitpy/layout_tests/port/apple.py:
396         (ApplePort._generate_all_test_configurations):
397
398 2012-09-14  Adam Barth  <abarth@webkit.org>
399
400         Remove webkitPostMessage
401         https://bugs.webkit.org/show_bug.cgi?id=96577
402
403         Reviewed by Ojan Vafai.
404
405         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
406
407         * Scripts/webkitperl/FeatureList.pm:
408         * qmake/mkspecs/features/features.pri:
409
410 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
411
412         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
413         https://bugs.webkit.org/show_bug.cgi?id=96817
414
415         Reviewed by Kenneth Rohde Christiansen.
416
417         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
418         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
419         got overlooked when adding logging elsewhere.
420
421 2012-09-14  Peter Beverloo  <peter@chromium.org>
422
423         [Chromium] Build fix for DumpRenderTree following r128628
424         https://bugs.webkit.org/show_bug.cgi?id=96808
425
426         Reviewed by Tony Chang.
427
428         When building DumpRenderTree from the Chromium project, a compile error
429         shows up because including the header ForwardIOStreamsAndroid.h cannot
430         be located. TestWebKitAPI does this correctly.
431
432         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
433
434 2012-09-14  Dana Jansens  <danakj@chromium.org>
435
436         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
437         https://bugs.webkit.org/show_bug.cgi?id=96805
438
439         Reviewed by Dirk Pranke.
440
441         * Scripts/webkitpy/common/config/committers.py:
442         * Scripts/webkitpy/common/config/watchlist:
443
444 2012-09-14  Peter Beverloo  <peter@chromium.org>
445
446         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
447         https://bugs.webkit.org/show_bug.cgi?id=96687
448
449         Reviewed by Tony Chang.
450
451         Android's DumpRenderTree currently supports these arguments, implemented
452         as part of TestShellAndroid:
453         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
454
455         They're used by the layout test runner to get the STDOUT and STDERR while
456         a layout test run is in process, which is a safer alternative to parsing
457         all the logcat output manually. The implementation can be seen here:
458         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
459
460         This patch generalizes parsing of and applying the effects of these arguments
461         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
462         After this patch, this will make it possible to pull out the output-reading
463         code from Android's layout test port and generalize it so it can be re-used
464         in the new test-runner for the other two test suites.
465
466         This has no effect when compiling and running these tests as part of Chromium
467         code, which has a much more advanced test-runner that does parse complete log
468         output, but also directly depends on code licensed under Apache 2.
469
470         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
471         * DumpRenderTree/chromium/TestShellAndroid.cpp:
472         (platformInit):
473         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
474
475 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
476
477         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
478         https://bugs.webkit.org/show_bug.cgi?id=96656
479
480         Reviewed by Adam Barth.
481
482         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
483         macros in 1 line.
484
485         * Scripts/webkitpy/style/checkers/cpp.py:
486         (check_style.definitions):
487         (check_style): Add rule.
488         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
489         (WebKitStyleTest.test_line_breaking): Add unittest.
490
491 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
492
493         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
494         https://bugs.webkit.org/show_bug.cgi?id=57570
495
496         Reviewed by Kenneth Rohde Christiansen.
497
498         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
499         and dump the information expected by the test cases.
500
501         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
502         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
503         (WTR::InjectedBundle::beginTesting): Explicitly set the default
504         database quota.
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
506         (WTR::securityOriginToStr): New convenience function to convert
507         a security origin to the string expected in test results.
508         (WTR):
509         (WTR::InjectedBundlePage::InjectedBundlePage):
510         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
511         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
512         refactoring to share code with didExceedDatabaseQuota.
513         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
514         (InjectedBundlePage):
515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
516         (WTR::TestRunner::TestRunner):
517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
518         (WTR::TestRunner::dumpDatabaseCallbacks):
519         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
520         (TestRunner):
521
522 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
523
524         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
525
526         Rubber-stamped by Simon Hausmann.
527
528         * qmake/mkspecs/features/default_post.prf:
529
530 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
531
532         [Qt] Remove old cruft from the qmake build system
533
534         Rubber-stamped by Simon Hausmann.
535
536         * DumpRenderTree/qt/DumpRenderTree.pro:
537         * qmake/mkspecs/features/default_post.prf:
538
539 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
540
541         [Qt] Enable force_static_libs_as_shared for development
542
543         Not enabled for buildbots or production-builds (part of Qt5)
544
545         Reviewed by Simon Hausmann.
546
547         * qmake/mkspecs/features/default_post.prf:
548
549 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
550
551         [Qt] Make force_static_libs_as_shared work on Mac OS
552
553         We had to move a few LIBS += around that were in the wrong place,
554         and not caught when everything was just linked into the final
555         QtWebKit library.
556
557         Reviewed by Simon Hausmann.
558
559         * qmake/mkspecs/features/default_post.prf:
560         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
561
562 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
563
564         [Qt] Fix build of WTR on Windows
565
566         Reviewed by Tor Arne Vestbø.
567
568         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
569         With qmake's unix makefile generator as well as with the MingW generator,
570         the directory where the pro file lives (WTR/) is automatically added to
571         the include search path, but not so with MSVC. Instead of relying on qmake's
572         implicit feature here, add WTR/ explicitly to the include search path.
573
574         * WebKitTestRunner/Target.pri:
575
576 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
577
578         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
579         https://bugs.webkit.org/show_bug.cgi?id=42691
580
581         Reviewed by Kenneth Rohde Christiansen.
582
583         Add implementation for testrunner.setStopProvisionalFrameLoads()
584         in WebKitTestRunner.
585
586         Original patch by Alexey Proskuryakov.
587
588         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
589         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
590         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
592         (WTR::TestRunner::TestRunner):
593         * WebKitTestRunner/InjectedBundle/TestRunner.h:
594         (TestRunner):
595         (WTR::TestRunner::setStopProvisionalFrameLoads):
596         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
597
598 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
599
600         [Qt] Fix handling of debug/release/debug_and_release/build_all
601
602         We now pick up the defaults from Qt, in default_pre (CONFIG already
603         contains the appropriate values for debug and release). We then let
604         the command line arguments to qmake, or the project files themselves,
605         override the configuration, and finally we sanitize the configuration
606         in default_post.
607
608         Reviewed by Simon Hausmann.
609
610         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
611         * Scripts/webkitdirs.pm:
612         (buildQMakeProjects):
613         * qmake/mkspecs/features/default_post.prf:
614         * qmake/mkspecs/features/default_pre.prf:
615         * qmake/mkspecs/features/mac/default_pre.prf:
616
617 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
618
619         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
620         https://bugs.webkit.org/show_bug.cgi?id=42687
621
622         Reviewed by Kenneth Rohde Christiansen.
623
624         Implement testRunner.setTabKeyCyclesThroughElements for
625         WebKitTestRunner.
626
627         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
628         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
629         (WTR::InjectedBundle::beginTesting):
630         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
631         (WTR::TestRunner::setTabKeyCyclesThroughElements):
632         (WTR):
633         * WebKitTestRunner/InjectedBundle/TestRunner.h:
634         (TestRunner):
635
636 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
637
638         EventSendingController::keyDown does not support non-array modifier arguments
639         https://bugs.webkit.org/show_bug.cgi?id=96727
640
641         Reviewed by Kenneth Rohde Christiansen.
642
643         Add support for handling a string as modifier argument to
644         EventSendingController::keyDown.
645
646         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
647         (WTR::parseModifierArray):
648
649 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
650
651         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
652         https://bugs.webkit.org/show_bug.cgi?id=42546
653
654         Reviewed by Kenneth Rohde Christiansen.
655
656         Exported TestRunner::setCustomPolicyDelegate() method.
657         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
658
659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
660         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
661         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
662
663 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
664
665         [GTK] Clear application cache between tests in DumpRenderTree
666         https://bugs.webkit.org/show_bug.cgi?id=96543
667
668         Reviewed by Philippe Normand.
669
670         Call the new DumpRenderTreeSupportGtk method to clear application cache
671         after each test in DumpRenderTree.
672
673         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
674         as well. It's now being set in XvfbDriver._start so that each driver is assigned
675         a cache directory that's constructed out of the driver's name and its worker
676         number. These directories are located in the layout tests results directory.
677         At least on the builders this ensures a driver-specific empty cache directory
678         with each test run.
679
680         * DumpRenderTree/gtk/DumpRenderTree.cpp:
681         (runTest):
682         * Scripts/webkitpy/layout_tests/port/gtk.py:
683         (GtkPort.setup_environ_for_server):
684         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
685         (XvfbDriver._start):
686
687 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
688
689         [Qt] Fix linking on Windows
690
691         Reviewed by Tor Arne Vestbø.
692
693         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
694         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
695         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
696         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
697
698         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
699         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
700         after the module. Therefore QT did never contain webkit anymore and we always passed
701         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
702
703         This patch introduces a creating_module configuration that is used to
704         scope the qt/pkgconfig sanitization.
705
706         * qmake/mkspecs/features/default_post.prf:
707
708 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
709
710         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
711         https://bugs.webkit.org/show_bug.cgi?id=96740
712
713         Reviewed by Kenneth Rohde Christiansen.
714
715         Dump information expected by the test cases about the following
716         frame load callbacks:
717         "didDisplayInsecureContentForFrame"
718         "didRunInsecureContentForFrame"
719         "didDetectXSSForFrame"
720
721         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
722         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
723         as expected by test results by calling pathSuitableForTestResult() instead
724         of printing raw URL.
725         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
726         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
727         (WTR::InjectedBundlePage::didDetectXSSForFrame):
728
729 2012-09-14  Peter Beverloo  <peter@chromium.org>
730
731         The runtime/unsigned category should be valid in the cpp style-checker.
732         https://bugs.webkit.org/show_bug.cgi?id=96748
733
734         Reviewed by Csaba Osztrogonác.
735
736         This is causing the webkitpy tests to fail because it's not listed in the
737         category array. Furthermore, change an "int" to "long" because it's
738         throwing a double error in one of the earlier asserts.
739
740         * Scripts/webkitpy/style/checkers/cpp.py:
741         (CppChecker):
742         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
743         (WebKitStyleTest.test_names):
744
745 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
746
747         Evas_Object* is a ref'ed structure, so tread it as such
748         https://bugs.webkit.org/show_bug.cgi?id=96659
749
750         Reviewed by Adam Barth.
751
752         Replace OwnPtr<Evas_Object> with RefPtr.
753
754         * DumpRenderTree/efl/ImageDiff.cpp:
755         (calculateDifference):
756         (printImageDifferences):
757         (readImageFromStdin):
758         (main):
759
760 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
761
762         Unreviewed, rolling out r128507.
763         http://trac.webkit.org/changeset/128507
764         https://bugs.webkit.org/show_bug.cgi?id=96659
765
766         Revert. r128507 makes too many crashes in EFL layout test bots.
767
768         * DumpRenderTree/efl/ImageDiff.cpp:
769         (calculateDifference):
770         (printImageDifferences):
771         (readImageFromStdin):
772         (main):
773
774 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
775
776         Make compile with both OS(WINCE) and PLATFORM(QT) support
777         https://bugs.webkit.org/show_bug.cgi?id=95536
778
779         Reviewed by Simon Hausmann.
780
781         Fix wince support in qmake files
782
783         * Tools.pro:
784         * qmake/mkspecs/features/configure.prf:
785         * qmake/mkspecs/features/default_post.prf:
786         * qmake/mkspecs/features/features.prf:
787         * qmake/mkspecs/features/functions.prf:
788
789 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
790
791         [WK2] Add color picker API support for WebKit2
792         https://bugs.webkit.org/show_bug.cgi?id=95058
793
794         Reviewed by Gyuyoung Kim.
795
796         Initialization code for color picker callbacks in UI client.
797
798         * MiniBrowser/mac/BrowserWindowController.m:
799         (-[BrowserWindowController awakeFromNib]):
800         * MiniBrowser/win/BrowserView.cpp:
801         (BrowserView::create):
802         * WebKitTestRunner/TestController.cpp:
803         (WTR::TestController::createOtherPage):
804         (WTR::TestController::initialize):
805
806 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
807
808         Upgrade yutak to reviewer
809         https://bugs.webkit.org/show_bug.cgi?id=96721
810
811         Reviewed by Kent Tamura.
812
813         * Scripts/webkitpy/common/config/committers.py:
814
815 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
816
817         Make the style checker report usage of "unsigned int"
818         https://bugs.webkit.org/show_bug.cgi?id=96693
819
820         Reviewed by Dirk Pranke.
821
822         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
823
824         * Scripts/webkitpy/style/checkers/cpp.py:
825         (check_language):
826
827 2012-09-13  Philip Rogers  <pdr@google.com>
828
829         Add gender-neutral form of webkit-patch land-cowboy
830         https://bugs.webkit.org/show_bug.cgi?id=96709
831
832         Reviewed by Adam Barth.
833
834         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
835
836         * Scripts/webkitpy/tool/commands/download.py:
837         (LandCowhand):
838
839 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
840
841         [EFL] Remove some parameters in browserCreate()
842         https://bugs.webkit.org/show_bug.cgi?id=96499
843
844         Reviewed by Kenneth Rohde Christiansen.
845
846         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
847         And I have moved some parameters into User_Arguments.
848
849         * EWebLauncher/main.c:
850         (_User_Arguments):
851         (_ELauncher):
852         (on_key_down):
853         (browserCreate):
854         (findThemePath):
855         (parseUserArguments):
856         (main):
857
858 2012-09-13  Mark Lam  <mark.lam@apple.com>
859
860         Unreviewed. Adding myself to the committers list.
861
862         * Scripts/webkitpy/common/config/committers.py:
863
864 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
865
866         run-perf-tests output cryptic error when the config file is missing.
867         https://bugs.webkit.org/show_bug.cgi?id=96453
868
869         Reviewed by Tony Chang.
870
871         Add a special error message when a configuration file is missing.
872
873         Also update the help message of --source-json-path to signify the fact it specifies
874         the configuration file on performance tests bots.
875
876         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
877         (PerfTestsRunner._parse_args):
878         (PerfTestsRunner._generate_and_show_results):
879         (PerfTestsRunner._merge_slave_config_json):
880         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
881         (_test_run_with_json_output): Make upload to fail by default and assert the result
882         in the function so that we can return logs instead.
883         (_test_run_with_json_output.mock_upload_json):
884         (test_run_with_json_output):
885         (test_run_with_description):
886         (test_run_respects_no_results):
887         (test_run_with_slave_config_json):
888         (test_run_with_bad_slave_config_json):
889         (test_run_with_multiple_repositories):
890
891 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
892
893         Evas_Object* is a ref'ed structure, so tread it as such
894         https://bugs.webkit.org/show_bug.cgi?id=96659
895
896         Reviewed by Adam Barth.
897
898         Replace OwnPtr<Evas_Object> with RefPtr.
899
900         * DumpRenderTree/efl/ImageDiff.cpp:
901         (calculateDifference):
902         (printImageDifferences):
903         (readImageFromStdin):
904         (main):
905
906 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
907
908         One more unreviewed trivial fix after r128399.
909
910         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
911
912 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
913
914         Unreviewed trivial fix after r128399.
915
916         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
917         (getLatestSVNRevision):
918         (waitForSVNRevision):
919
920 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
921
922         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
923         https://bugs.webkit.org/show_bug.cgi?id=96366
924
925         Reviewed by Anders Carlsson.
926
927         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
928         by calling shouldClose() on the FrameLoader.
929
930         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
931         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
932         (WTR::TestRunner::callShouldCloseOnWebView):
933         (WTR):
934         * WebKitTestRunner/InjectedBundle/TestRunner.h:
935         (TestRunner):
936
937 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
938
939         Unreviewed, rolling out r128453.
940         http://trac.webkit.org/changeset/128453
941         https://bugs.webkit.org/show_bug.cgi?id=96681
942
943         Having tests use the same appcache directory leads to timeouts
944         (Requested by zdobersek on #webkit).
945
946         * DumpRenderTree/gtk/DumpRenderTree.cpp:
947         (runTest):
948         * Scripts/webkitpy/layout_tests/port/gtk.py:
949         (GtkPort.setup_environ_for_server):
950
951 2012-09-13  James Robinson  <jamesr@chromium.org>
952
953         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
954         https://bugs.webkit.org/show_bug.cgi?id=96678
955
956         Reviewed by Dirk Pranke.
957
958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
959         (.):
960
961 2012-09-13  Rob Buis  <rbuis@rim.com>
962
963         Unreviewed changes to watchlist.
964
965         - Add myself to BlackBerry bugs
966
967         * Scripts/webkitpy/common/config/watchlist:
968
969 2012-09-13  Stephen Chenney  <schenney@chromium.org>
970
971         Add an SVG entry to the watchlist
972
973         Unreviewed config change.
974
975         * Scripts/webkitpy/common/config/watchlist:
976         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
977         - Added myself and pdr as watchers
978
979 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
980
981         [Qt] Make WebKit2 work on Windows with Qt 5
982         https://bugs.webkit.org/show_bug.cgi?id=76776
983
984         Reviewed by Tor Arne Vestbø.
985
986         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
987         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
988         that for the GL TextureMapper (it's only built when that feature is set).
989
990         * qmake/mkspecs/features/configure.prf:
991
992 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
993
994         [Qt] Ensure that QT is finalized before loading qt_module.prf
995
996         As qt_module.prf does dependency tracking based on the content of the
997         QT variable. The intermediate WebKit modules modify the variable in
998         their .pri files, so we have to ensure we've loaded all the modules
999         before loading qt_module.
1000
1001         Reviewed by Tor Arne Vestbø.
1002         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1003
1004         * qmake/mkspecs/features/default_post.prf:
1005         * qmake/mkspecs/features/webkit_modules.prf: Added.
1006
1007 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1008
1009         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1010         https://bugs.webkit.org/show_bug.cgi?id=96633
1011
1012         Reviewed by Csaba Osztrogonác.
1013
1014         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1015         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1016         It's the usual problem and the usual solution is to rename one of the conflicting files.
1017         This patch chooses to rename DRT instead of WTR and MBR.
1018
1019         Fixed include order at the same time to match style guide.
1020
1021         * DumpRenderTree/qt/DumpRenderTree.pro:
1022         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1023         (messageHandler):
1024         (isOption):
1025         (takeOptionValue):
1026         (printUsage):
1027         (main):
1028
1029 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1030
1031         The Script run-launcher should support -2 in combination with --efl
1032         https://bugs.webkit.org/show_bug.cgi?id=96639
1033
1034         Reviewed by Simon Hausmann.
1035
1036         Support running the MiniBrowser then supplied -2 as argument.
1037
1038         * Scripts/run-launcher:
1039
1040 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1041
1042         Unreviewed, add my Intel email address to the list.
1043
1044         * Scripts/webkitpy/common/config/committers.py:
1045
1046 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1047
1048         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1049
1050         Reviewed by Ossy.
1051
1052         * qmake/mkspecs/features/default_post.prf:
1053
1054 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1055
1056         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1057         https://bugs.webkit.org/show_bug.cgi?id=82294
1058
1059         Reviewed by Gyuyoung Kim.
1060
1061         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1062
1063         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1064         (TestRunner::layerTreeAsText):
1065
1066 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1067
1068         [GTK] Clear application cache between tests in DumpRenderTree
1069         https://bugs.webkit.org/show_bug.cgi?id=96543
1070
1071         Reviewed by Philippe Normand.
1072
1073         Call the new DumpRenderTreeSupportGtk method to clear application cache
1074         after each test.
1075
1076         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1077         as well. Currently it points to a subdirectory in the layout tests results
1078         directory. At least on the builders this ensures an empty cache directory
1079         with each test run.
1080
1081         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1082         (runTest):
1083         * Scripts/webkitpy/layout_tests/port/gtk.py:
1084         (GtkPort.setup_environ_for_server):
1085
1086 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1087
1088         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1089
1090         Unless it's actually a dependency of the public QtWebKit API.
1091
1092         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1093         files with their _PRIVATE equivivalent, but that's likely to break when
1094         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1095         clean up the variables in default_post.
1096
1097         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1098         longer needed, as it was a workaround for the intermediate libraries ending
1099         up in the prl file. And, since CONFIG -= staticlib was there to support
1100         the explicitlib option, we can remove that too (as well as the exception
1101         for gprof, since it would be empty). If gprof needs tweaks to always link
1102         statically they should go in gprof.prf.
1103
1104         Reviewed by Simon Hausmann.
1105
1106         * qmake/mkspecs/features/default_post.prf:
1107         * qmake/mkspecs/features/functions.prf:
1108
1109 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1110
1111         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1112         https://bugs.webkit.org/show_bug.cgi?id=96632
1113
1114         Reviewed by Carlos Garcia Campos.
1115
1116         Fix this by using atk_object_get_n_accessible_children instead of
1117         calling getChildren() from childCount.
1118
1119         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1120         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1121         loop by using atk_object_get_n_accessible_children().
1122
1123 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1124
1125         [Qt][Win] Enable USE(3D_GRAPHICS)
1126         https://bugs.webkit.org/show_bug.cgi?id=90879
1127
1128         Reviewed by Kenneth Rohde Christiansen.
1129
1130         Enable it on Windows as well as on QNX (bug fixed).
1131
1132         * qmake/mkspecs/features/features.prf:
1133
1134 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1135
1136         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1137         https://bugs.webkit.org/show_bug.cgi?id=96359
1138
1139         Reviewed by Tor Arne Vestbø.
1140
1141         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1142         lexer. The only viable alternative I could find on Windows that provides
1143         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1144         so let's use that one instead.
1145
1146         * Scripts/webkitdirs.pm:
1147         (checkRequiredSystemConfig):
1148         * qmake/mkspecs/features/default_pre.prf:
1149
1150 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1151
1152         [Qt] Add configuration for production builds
1153         https://bugs.webkit.org/show_bug.cgi?id=96607
1154
1155         Reviewed by Kenneth Rohde Christiansen.
1156
1157         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1158         and enable all-in-one-files optimizations.
1159
1160         * qmake/mkspecs/features/production_build.prf: Added.
1161
1162 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1163
1164         [Qt] GStreamer detection does not work when cross-compiling
1165         https://bugs.webkit.org/show_bug.cgi?id=96608
1166
1167         Reviewed by Kenneth Rohde Christiansen.
1168
1169         When cross-compiling it is not safe to just use system(pkg-config),
1170         because there is a high probability that it will find packages in the
1171         host system instead of in the target one. Instead use qmake's new
1172         packagesExist() function that takes care of this delicate aspect of
1173         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1174         PKG_CONFIG_LIBDIR accordingly.
1175
1176         * qmake/mkspecs/features/features.prf:
1177
1178 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1179
1180         [WK2][WTR] More efficient string handling in InjectedBundlePage
1181         https://bugs.webkit.org/show_bug.cgi?id=96609
1182
1183         Reviewed by Kenneth Rohde Christiansen.
1184
1185         Update StringBuilder usage in InjectedBundlePage to follow
1186         the latest recommandations for efficient string handling:
1187         http://trac.webkit.org/wiki/EfficientStrings
1188
1189         This involves using appendLiteral() or appendNumber()
1190         instead of append() whenever possible.
1191
1192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1193         (WTR::dumpPath):
1194         (WTR::rangeToStr):
1195         (WTR::styleDecToStr):
1196         (WTR::frameToStr):
1197         (WTR::dumpResourceURL):
1198         (WTR):
1199         (WTR::dumpFrameDescriptionSuitableForTestResult):
1200         (WTR::dumpRequestDescriptionSuitableForTestResult):
1201         (WTR::dumpResponseDescriptionSuitableForTestResult):
1202         (WTR::dumpErrorDescriptionSuitableForTestResult):
1203         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1204         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1205         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1206         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1207         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1208         (WTR::InjectedBundlePage::didFinishProgress):
1209         (WTR::dumpFrameScrollPosition):
1210         (WTR::dumpFrameText):
1211         (WTR::dumpDescendantFramesText):
1212         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1213         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1214         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1215         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1216         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1217         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1218         (WTR::InjectedBundlePage::willSendRequestForFrame):
1219         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1220         (WTR::InjectedBundlePage::didFinishLoadForResource):
1221         (WTR::InjectedBundlePage::didFailLoadForResource):
1222         (WTR::InjectedBundlePage::shouldCacheResponse):
1223         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1224         (WTR::InjectedBundlePage::willAddMessageToConsole):
1225         (WTR::InjectedBundlePage::willSetStatusbarText):
1226         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1227         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1228         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1229         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1230         (WTR::InjectedBundlePage::shouldBeginEditing):
1231         (WTR::InjectedBundlePage::shouldEndEditing):
1232         (WTR::InjectedBundlePage::shouldInsertNode):
1233         (WTR::InjectedBundlePage::shouldInsertText):
1234         (WTR::InjectedBundlePage::shouldDeleteRange):
1235         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1236         (WTR::InjectedBundlePage::shouldApplyStyle):
1237         (WTR::InjectedBundlePage::didBeginEditing):
1238         (WTR::InjectedBundlePage::didEndEditing):
1239         (WTR::InjectedBundlePage::didChange):
1240         (WTR::InjectedBundlePage::didChangeSelection):
1241         (WTR::InjectedBundlePage::supportsFullScreen):
1242         (WTR::InjectedBundlePage::enterFullScreenForElement):
1243         (WTR::InjectedBundlePage::exitFullScreenForElement):
1244         (WTR::InjectedBundlePage::beganEnterFullScreen):
1245         (WTR::InjectedBundlePage::beganExitFullScreen):
1246         (WTR::InjectedBundlePage::closeFullScreen):
1247         (WTR::dumpBackForwardListItem):
1248         (WTR::InjectedBundlePage::dumpBackForwardList):
1249
1250 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1251
1252         [Qt][WK2] Memory leaks in Qt's TestRunner
1253         https://bugs.webkit.org/show_bug.cgi?id=96603
1254
1255         Reviewed by Csaba Osztrogonác.
1256
1257         Fix memory leaks in Qt's TestRunner code by adopting WKString
1258         created with WKStringCreateWithUTF8CString().
1259
1260         * WebKitTestRunner/qt/TestControllerQt.cpp:
1261         (WTR::TestController::initializeInjectedBundlePath):
1262         (WTR::TestController::initializeTestPluginDirectory):
1263
1264 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1265
1266         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1267         https://bugs.webkit.org/show_bug.cgi?id=96506
1268
1269         Reviewed by Dirk Pranke.
1270
1271         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1272         for debug configuration. These are the same values the Chromium port uses.
1273
1274         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1275         the layout tests under WebKit2 generally) requires more attention and gardening
1276         than what the current effort produces.
1277
1278         The unit test is updated as well to test these changes.
1279
1280         * Scripts/webkitpy/layout_tests/port/gtk.py:
1281         (GtkPort.default_timeout_ms):
1282         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1283         (GtkPortTest.test_default_timeout_ms):
1284         (GtkPortTest.assertLinesEqual):
1285
1286 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1287
1288         Add SVN mirror handling feature to build.webkit.org
1289         https://bugs.webkit.org/show_bug.cgi?id=85887
1290
1291         Reviewed by Dirk Pranke.
1292
1293         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1294         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1295         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1296         (ConfigureBuild.start):
1297         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1298         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1299         (Factory.__init__):
1300         (BuildFactory.__init__):
1301         (TestFactory.__init__):
1302         (BuildAndTestFactory.__init__):
1303         (BuildAndPerfTestFactory.__init__):
1304         (BuildAndPerfTestWebKit2Factory.__init__):
1305         (DownloadAndPerfTestFactory.__init__):
1306         (DownloadAndPerfTestWebKit2Factory.__init__):
1307         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1308         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1309         (SVNMirrorTest):
1310         (SVNMirrorTest.setUp): Load config.json once at startup.
1311         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1312         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1313         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1314         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1315         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1316                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1317
1318 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1319
1320         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1321         https://bugs.webkit.org/show_bug.cgi?id=81606
1322
1323         Reviewed by Tim Horton.
1324
1325         6 seconds is harsh for some jquery test cases.
1326         Therefore, adjust the value to match DumpRenderTree.
1327
1328         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1329         (WTR):
1330
1331 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1332
1333         [EFL] Support download attribute feature
1334         https://bugs.webkit.org/show_bug.cgi?id=96462
1335
1336         Reviewed by Gyuyoung Kim.
1337
1338         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1339         and add "download,request" callback to the DumpRenderTree for EFL.
1340
1341         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1342         (DumpRenderTreeChrome::createView):
1343         (DumpRenderTreeChrome::onDownloadRequest):
1344         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1345         (DumpRenderTreeChrome):
1346         * Scripts/webkitperl/FeatureList.pm:
1347
1348 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1349
1350         Reduce parallism on the wk2 testers.
1351         https://bugs.webkit.org/show_bug.cgi?id=95906
1352
1353         Reviewed by Dirk Pranke.
1354
1355         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1356         resource contention.  Reducing the number of processes alleviates the issue.  
1357
1358         Starting by reducing 25%.
1359
1360         * Scripts/webkitpy/layout_tests/port/mac.py:
1361         (MacPort.default_child_processes):
1362
1363 2012-09-12  Brady Eidson  <beidson@apple.com>
1364
1365         Assert in NetscapePlugin::destroy() with async plugin init
1366         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1367
1368         Reviewed by Anders Carlsson.
1369
1370         Expose NPN_Invoke to plug-in tests:
1371         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1372         (PluginTest::NPN_Invoke):
1373         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1374         (PluginTest):
1375
1376         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1377         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1378         (InvokeDestroysPluginWithinNPP_New):
1379         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1380         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1381         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1382
1383 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1384
1385         refactor TestExpectations tokenization slightly in preparation for the new syntax
1386         https://bugs.webkit.org/show_bug.cgi?id=96564
1387
1388         Reviewed by Ojan Vafai.
1389
1390         This change changes how we will tokenize/lex the
1391         TestExpectations files, in preparation for supporting both the
1392         old syntax and the new one. This change by itself should be a
1393         no-op.
1394
1395         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1396         (TestExpectationParser._tokenize_line):
1397         (TestExpectationParser):
1398         (TestExpectationParser._tokenize_line_using_old_format):
1399         (TestExpectationParser._tokenize_line_using_new_format):
1400
1401 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1402
1403         remove unused testexpectations editing code from webkitpy, garden-o-matic
1404         https://bugs.webkit.org/show_bug.cgi?id=96562
1405
1406         Reviewed by Adam Barth.
1407
1408         This code was prototyped but never fully realized. Removing
1409         until it reanimates :).
1410
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1413         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1414         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1415         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1416         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1417         (GardeningHTTPRequestHandler._run_webkit_patch):
1418         (GardeningHTTPRequestHandler.ping):
1419         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1420         (BuildCoverageExtrapolatorTest.test_extrapolate):
1421         (GardeningServerTest.test_rebaseline_new_port):
1422
1423 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1424
1425         Remove unused bot, apple-xserve-1.
1426         https://bugs.webkit.org/show_bug.cgi?id=96570
1427         
1428         Reviewed by Stephanie Lewis.
1429
1430         * BuildSlaveSupport/build.webkit.org-config/config.json:
1431
1432 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1433
1434         [GTK] We attempt to rebase documentation even if it's not present
1435         https://bugs.webkit.org/show_bug.cgi?id=96553
1436
1437         Reviewed by Martin Robinson.
1438
1439         Do not make the documentation rebase step fatal. This allows make
1440         install to succeed when there's no documentation generated.
1441
1442         * gtk/generate-gtkdoc:
1443
1444 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1445
1446         Respect WEBKITOUTPUTDIR when running EFL tests
1447         https://bugs.webkit.org/show_bug.cgi?id=96528
1448
1449         Reviewed by Dirk Pranke.
1450
1451         Expose user set WEBKITOUTPUTDIR to the web process.
1452
1453         * Scripts/webkitpy/layout_tests/port/driver.py:
1454         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1455         of the web process and its potential jhbuild wrapper.
1456
1457 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1458
1459         webkitdirs: fix uname version handling for cygwin
1460         https://bugs.webkit.org/show_bug.cgi?id=96436
1461
1462         Reviewed by Jon Honeycutt.
1463
1464         Newer versions of cygwin embed an additional version string
1465         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1466         Update the code to handle that.
1467
1468         * Scripts/webkitdirs.pm:
1469         (setupAppleWinEnv):
1470
1471 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1472
1473         Regression(r128338): Broke Windows build
1474         https://bugs.webkit.org/show_bug.cgi?id=96537
1475
1476         Unreviewed build fix.
1477
1478         Fix Apple-Win build by allocating array dynamically
1479         since its size is not constant.
1480
1481         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1482         (WTR::stringArrayToJS):
1483
1484 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1485
1486         [chromium] Add a virtual test suite for fast/hidpi
1487         https://bugs.webkit.org/show_bug.cgi?id=90192
1488
1489         Reviewed by Dirk Pranke.
1490
1491         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1492         on the hardware accelerated path as the software path.
1493
1494         * DumpRenderTree/chromium/WebPreferences.cpp:
1495         (WebPreferences::applyTo):
1496         * Scripts/webkitpy/layout_tests/port/chromium.py:
1497         (ChromiumPort.virtual_test_suites):
1498
1499 2012-09-12  Adam Klein  <adamk@chromium.org>
1500
1501         [chromium] Add content_browsertests to the flakiness dashboard
1502         https://bugs.webkit.org/show_bug.cgi?id=96535
1503
1504         Reviewed by Ojan Vafai.
1505
1506         * TestResultServer/static-dashboards/dashboard_base.js:
1507
1508 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1509
1510         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1511         https://bugs.webkit.org/show_bug.cgi?id=96496
1512
1513         Reviewed by Kenneth Rohde Christiansen.
1514
1515         Add implementation for originsWithApplicationCache to
1516         WebKitTestRunner.
1517
1518         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1520         (WTR::stringArrayToJS):
1521         (WTR):
1522         (WTR::TestRunner::originsWithApplicationCache):
1523         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1524         (TestRunner):
1525
1526 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1527
1528         Fix Qt/Windows build with Python3
1529         https://bugs.webkit.org/show_bug.cgi?id=96473
1530
1531         Reviewed by Csaba Osztrogonác.
1532
1533         In Python 3 print is a real function, so we must use parentheses around
1534         the function parameters. This is backwards compatible with Python 2.
1535
1536         * Scripts/generate-win32-export-forwards:
1537
1538 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1539
1540         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1541
1542         As pointed out by Kevin, we should inject the "set PATH=..." statement
1543         to add the GnuWin32 directory only if that directory actually exists.
1544
1545         * qmake/mkspecs/features/default_post.prf:
1546
1547 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1548
1549         [EFL] [WK2] Memory leaks in TestControllerEfl
1550         https://bugs.webkit.org/show_bug.cgi?id=96525
1551
1552         Reviewed by Kenneth Rohde Christiansen.
1553
1554         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1555         of WKString created with WKStringCreateWithUTF8CString().
1556
1557         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1558         (WTR::TestController::initializeInjectedBundlePath):
1559         (WTR::TestController::initializeTestPluginDirectory):
1560
1561 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1562
1563         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1564         https://bugs.webkit.org/show_bug.cgi?id=96374
1565
1566         Reviewed by Kenneth Rohde Christiansen.
1567
1568         Implement support for dumpApplicationCacheDelegateCallbacks
1569         and disallowIncreaseForApplicationCacheQuota in
1570         WebKitTestRunner and properly dump the information
1571         expected by the tests.
1572
1573         If the application cache quota is reached for a given
1574         security origin, WebKitTestRunner will reset the quota
1575         to its default value, unless intructed not to via
1576         disallowIncreaseForApplicationCacheQuota().
1577
1578         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1580         (WTR::InjectedBundlePage::InjectedBundlePage):
1581         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1582         (WTR):
1583         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1584         (InjectedBundlePage):
1585         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1586         (WTR::TestRunner::TestRunner):
1587         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1588         (WTR):
1589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1590         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1591         (TestRunner):
1592         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1593         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1594
1595 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1596
1597         [chromium] remove deprecated and unused sets import from chromium_android driver
1598         https://bugs.webkit.org/show_bug.cgi?id=96485
1599
1600         Reviewed by Dirk Pranke.
1601
1602         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1603
1604 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1605
1606         Flakiness dashboard doesn't recognize new Chromium Android test builder
1607         https://bugs.webkit.org/show_bug.cgi?id=96523
1608
1609         Reviewed by Ojan Vafai.
1610
1611         Properly return 'ANDROID' as the Chromium platform for Android builders.
1612
1613         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1614         (chromiumPlatform):
1615         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1616         (test):
1617
1618 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1619
1620         [Qt] Build on Windows requires bison/flex in PATH
1621         https://bugs.webkit.org/show_bug.cgi?id=96358
1622
1623         Reviewed by Tor Arne Vestbø.
1624
1625         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1626         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1627         a separate installation of various GNU tools is required as the operating system doesn't come with
1628         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1629         the gnuwin32 directory of the qt5.git top-level repository.
1630
1631         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1632
1633         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1634         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1635         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1636         updated with the new tool.
1637
1638         * Scripts/webkitdirs.pm:
1639         (checkRequiredSystemConfig):
1640         * qmake/mkspecs/features/default_post.prf:
1641
1642 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1643
1644         [Qt] Update build-jsc after r128174
1645
1646         Reviewed by Ossy.
1647
1648         * Scripts/build-jsc:
1649
1650 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1651
1652         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1653
1654         By hard-coding the names of the targets we defined we ended up just
1655         redefining the previous target when using addStrictSubdirOrderBetween
1656         more than once in a single project file.
1657
1658         We now embed the two base targets into the target names.
1659
1660         Reviewed by Simon Hausmann.
1661
1662         * qmake/mkspecs/features/functions.prf:
1663
1664 2012-09-12  Philippe Liard  <pliard@google.com>
1665
1666         Depend on {base,net} GYP targets rather than {base,net}_java.
1667         https://bugs.webkit.org/show_bug.cgi?id=95690
1668
1669         Reviewed by Adam Barth.
1670
1671         {base,net}_java became 'private' targets on the Chromium side that
1672         clients should not depend on (see
1673         https://chromiumcodereview.appspot.com/10913083/).
1674         This removes a bunch of trailing white spaces additionally in
1675         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1676
1677         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1678         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1679
1680 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1681
1682         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1683         https://bugs.webkit.org/show_bug.cgi?id=96494
1684
1685         Reviewed by Tor Arne Vestbø.
1686
1687         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1688         plugin process feature if we don't have NPAPI.
1689
1690         * qmake/mkspecs/features/features.prf:
1691
1692 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1693
1694         Unreviewed, rolling out r128280.
1695         http://trac.webkit.org/changeset/128280
1696         https://bugs.webkit.org/show_bug.cgi?id=96498
1697
1698         it broke compilation on windows debug bot (Requested by loislo
1699         on #webkit).
1700
1701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1703         (WTR::InjectedBundlePage::InjectedBundlePage):
1704         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1705         (InjectedBundlePage):
1706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1707         (WTR::TestRunner::TestRunner):
1708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1709         (TestRunner):
1710
1711 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1712
1713         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1714         https://bugs.webkit.org/show_bug.cgi?id=96488
1715
1716         Reviewed by Tor Arne Vestbø.
1717
1718         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1719         because there are no such targets. We want the generated sources to be independent from release
1720         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1721         redirect to the same general-purpose target (first) of creating the derived sources.
1722
1723         * qmake/mkspecs/features/default_post.prf:
1724
1725 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1726
1727         [EFL] Make DumpRenderTree smarter at finding the fonts
1728         http://webkit.org/b/96281
1729
1730         Reviewed by Gyuyoung Kim.
1731
1732         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1733         Use CString consistently.
1734
1735         * DumpRenderTree/efl/FontManagement.cpp:
1736         (buildPath):
1737         (getCoreFontFiles):
1738         (addFontDirectory):
1739         (addFontFiles):
1740         (getCustomBuildDir):
1741         (getPlatformFontsPath):
1742         (addFontsToEnvironment):
1743
1744 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1745
1746         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1747         https://bugs.webkit.org/show_bug.cgi?id=96374
1748
1749         Reviewed by Kenneth Rohde Christiansen.
1750
1751         Implement support for dumpApplicationCacheDelegateCallbacks
1752         and disallowIncreaseForApplicationCacheQuota in
1753         WebKitTestRunner and properly dump the information
1754         expected by the tests.
1755
1756         If the application cache quota is reached for a given
1757         security origin, WebKitTestRunner will reset the quota
1758         to its default value, unless intructed not to via
1759         disallowIncreaseForApplicationCacheQuota().
1760
1761         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1763         (WTR::InjectedBundlePage::InjectedBundlePage):
1764         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1765         (WTR):
1766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1767         (InjectedBundlePage):
1768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1769         (WTR::TestRunner::TestRunner):
1770         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1771         (WTR):
1772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1773         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1774         (TestRunner):
1775         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1776         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1777
1778 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1779
1780         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1781         https://bugs.webkit.org/show_bug.cgi?id=96388
1782
1783         Reviewed by Kenneth Rohde Christiansen.
1784
1785         Exported TestRunner.workerThreadCount as readonly attribute.
1786
1787         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1788         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1789         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1790         (WTR):
1791         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1792         (TestRunner):
1793
1794 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1795
1796         [chromium] Consume a user gesture when creating a new view.
1797         https://bugs.webkit.org/show_bug.cgi?id=96373
1798
1799         Reviewed by Adam Barth.
1800
1801         * DumpRenderTree/chromium/WebViewHost.cpp:
1802         (WebViewHost::createView):
1803
1804 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1805
1806         [WK2][WTR] Some of TestRunner special options are not reset before testing
1807         https://bugs.webkit.org/show_bug.cgi?id=96384
1808
1809         Reviewed by Kenneth Rohde Christiansen.
1810
1811         Now values of the following special options are reset:
1812         void setAcceptsEditing(in boolean value);
1813         void setCloseRemainingWindowsWhenComplete(in boolean value);
1814         void setXSSAuditorEnabled(in boolean value);
1815         void setAllowFileAccessFromFileURLs(in boolean value);
1816         void setPluginsEnabled(in boolean value);
1817         void setPopupBlockingEnabled(in boolean value);
1818
1819         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1820         (WTR::InjectedBundle::beginTesting):
1821
1822 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1823
1824         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1825         https://bugs.webkit.org/show_bug.cgi?id=96273
1826
1827         Reviewed by Gyuyoung Kim.
1828
1829         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1830         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1831
1832         * WebKitTestRunner/CMakeLists.txt:
1833
1834 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1835
1836         [chromium] rename webkit_resources
1837         https://bugs.webkit.org/show_bug.cgi?id=95874
1838
1839         Reviewed by James Robinson.
1840
1841         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1842
1843 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1844
1845         [chromium] don't include content shell builders in the garden-o-matic view
1846         https://bugs.webkit.org/show_bug.cgi?id=96418
1847
1848         Reviewed by James Robinson.
1849
1850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1851
1852 2012-09-11  Adam Klein  <adamk@chromium.org>
1853
1854         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1855         https://bugs.webkit.org/show_bug.cgi?id=96411
1856
1857         Reviewed by Adam Barth.
1858
1859         Previously only the exact string "warning" was treated as a warning
1860         result. This patch treats any string with "warning" as a substring
1861         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1862
1863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1864         (.):
1865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1866
1867 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1868
1869         Restore original value of mock scrollbars enabled in InternalSettings
1870         https://bugs.webkit.org/show_bug.cgi?id=87680
1871
1872         Reviewed by Adam Barth.
1873
1874         Added backup support for mock scrollbars state in
1875         InternalSettings::Backup, and removed support for these
1876         from Qt's DumpRenderTree.
1877
1878         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1879         (WebCore::WebPage::resetSettings):
1880         * DumpRenderTree/qt/TestRunnerQt.cpp:
1881         (TestRunner::setFrameFlatteningEnabled):
1882         * DumpRenderTree/qt/TestRunnerQt.h:
1883         (TestRunner):
1884
1885 2012-09-11  Dan Bernstein  <mitz@apple.com>
1886
1887         Fixed a bug where kill-old-processes failed to kill clang++.
1888
1889         Rubber-stamped by Alexey Proskuryakov.
1890
1891         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1892         where it is passed as a regular expression to killall.
1893
1894 2012-09-11  Philippe Liard  <pliard@google.com>
1895
1896         Make sure that md5sum is not setup on non-Chromium Android platforms.
1897         https://bugs.webkit.org/show_bug.cgi?id=96393
1898
1899         Reviewed by Adam Barth.
1900
1901         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1902         which is also invoked on non-Chromium Android platforms. The following patch
1903         moves this logic to _startup_test() which is guaranteed to be invoked
1904         only on Android.
1905
1906         This also updates the prompt unit test in chromium_android_unittest.py.
1907
1908         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1909         (ChromiumAndroidDriver.__init__):
1910         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1911         (ChromiumAndroidDriver._setup_test):
1912
1913 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1914
1915         [EFL] Rewrite the EFL-related Find modules
1916         https://bugs.webkit.org/show_bug.cgi?id=95237
1917
1918         Reviewed by Kenneth Rohde Christiansen.
1919
1920         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1921         property and include all the Enlightenment Foundation Libraries
1922         required by the target.
1923         * EWebLauncher/CMakeLists.txt: Ditto.
1924         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1925         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1926         now that they are not added implicitly.
1927         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1928         property.
1929         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1930         property and include all the Enlightenment Foundation Libraries
1931         required by the target.
1932
1933 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1934
1935         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1936         https://bugs.webkit.org/show_bug.cgi?id=96379
1937
1938         Reviewed by Kenneth Rohde Christiansen.
1939
1940         Add implementation for setApplicationCacheOriginQuota
1941         to WebKitTestRunner.
1942
1943         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1944         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1945         (WTR::TestRunner::setApplicationCacheOriginQuota):
1946         (WTR):
1947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1948         (TestRunner):
1949
1950 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1951
1952         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1953         https://bugs.webkit.org/show_bug.cgi?id=91988
1954
1955         Reviewed by Kenneth Rohde Christiansen.
1956
1957         Regular key events generated by Qt for the tab key fill both
1958         keyCode and keyText, so we should do the same for our fake events.
1959
1960         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1961         (WTR::EventSenderProxy::keyDown):
1962
1963 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1964
1965         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1966         https://bugs.webkit.org/show_bug.cgi?id=96269
1967
1968         Reviewed by Kenneth Rohde Christiansen.
1969
1970         Exported missing testRunner.setSpatialNavigationEnabled() method.
1971
1972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1973         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1974         (WTR::InjectedBundle::beginTesting):
1975         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1976         (WTR::TestRunner::setSpatialNavigationEnabled):
1977         (WTR):
1978         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1979         (TestRunner):
1980
1981 2012-09-11  Philippe Liard  <pliard@chromium.org>
1982
1983         Support LayoutTests on non-rooted devices for Chromium Android.
1984         https://bugs.webkit.org/show_bug.cgi?id=95346
1985
1986         Reviewed by Dirk Pranke.
1987
1988         We were requiring root permissions to sync resource files with the
1989         device by comparing host and device files' timestamp after we
1990         synchronized the device and host clocks.
1991         We now rely on md5sum provided by Chromium to handle data files
1992         synchronization.
1993
1994         * Scripts/webkitpy/layout_tests/port/chromium.py:
1995         (ChromiumPort._check_driver_build_up_to_date):
1996         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1997         (ChromiumAndroidDriver.__init__):
1998         (ChromiumAndroidDriver._setup_test):
1999         (ChromiumAndroidDriver._push_executable):
2000         (ChromiumAndroidDriver._push_test_resources):
2001         (ChromiumAndroidDriver._read_prompt):
2002
2003 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2004
2005         [Qt] Fix output paths on Windows
2006
2007         Reviewed by Tor Arne Vestbø.
2008
2009         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2010         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2011         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2012         incorrect here and instead for the calculation we should use forward slashes.
2013
2014         * qmake/mkspecs/features/default_pre.prf:
2015
2016 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2017
2018         [Qt] Fix passing of defines from the build system
2019
2020         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2021         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2022         will add it's own defaults if the features are not defined.
2023
2024         At some point we might want to run a configure-test to inspect what
2025         Platform.h will do, so we can sync up the build system's view of
2026         the feature-defines with the compile-time situation.
2027
2028         Reviewed by Simon Hausmann.
2029
2030         * qmake/mkspecs/features/functions.prf:
2031
2032 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2033
2034         [Qt] Fix --qt option to build-webkit
2035
2036         Reviewed by Ossy.
2037
2038         * Scripts/webkitdirs.pm:
2039         (buildQMakeProjects):
2040
2041 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2042
2043         [Qt] Add a configure step to the Qt build system
2044
2045         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2046         the build-webkit script is still supported, and will add slightly more
2047         logic to the build, such as detecting the need for clean or incremental
2048         builds.
2049
2050         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2051         all things related to configuring the build, such as use/have/enable flags,
2052         and these are translated to defines in default_post. Project files should
2053         no longer check contains(DEFINES,...) to detect features, but use the new
2054         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2055         options have been translated into WEBKIT_CONFIG options as well, and can
2056         be checked using build?().
2057
2058         Reviewed by Simon Hausmann.
2059
2060         * DumpRenderTree/qt/DumpRenderTree.pro:
2061         * MiniBrowser/qt/MiniBrowser.pro:
2062         * QtTestBrowser/QtTestBrowser.pro:
2063         * Scripts/build-webkit:
2064         * Scripts/webkitdirs.pm:
2065         (qtFeatureDefaults):
2066         (buildQMakeProjects):
2067         * Tools.pro:
2068         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2069         * WebKitTestRunner/InjectedBundle/Target.pri:
2070         * WebKitTestRunner/Target.pri:
2071         * qmake/.qmake.cache: Added.
2072         * qmake/configure.pri: Removed.
2073         * qmake/configure.pro: Removed.
2074         * qmake/dump-features: Added.
2075         * qmake/mkspecs/features/configure.prf: Added.
2076         * qmake/mkspecs/features/default_post.prf:
2077         * qmake/mkspecs/features/default_pre.prf:
2078         * qmake/mkspecs/features/features.prf:
2079         * qmake/mkspecs/features/features.pri:
2080         * qmake/mkspecs/features/functions.prf:
2081         * qmake/mkspecs/features/gprof.prf:
2082         * qmake/mkspecs/features/mac/default_pre.prf:
2083         * qmake/mkspecs/features/win32/default_pre.prf:
2084
2085 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2086
2087         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2088         https://bugs.webkit.org/show_bug.cgi?id=96372
2089
2090         Reviewed by Kenneth Rohde Christiansen.
2091
2092         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2093
2094         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2096         (WTR::TestRunner::clearApplicationCacheForOrigin):
2097         (WTR):
2098         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2099         (TestRunner):
2100
2101 2012-09-11  Peter Beverloo  <peter@chromium.org>
2102
2103         Don't ignore .pak files when making an archive for Android
2104         https://bugs.webkit.org/show_bug.cgi?id=96375
2105
2106         Reviewed by Jochen Eisinger.
2107
2108         The .pak files do need to be pushed to the device, which is currently
2109         preventing the layout test runner from correctly pushing all files.
2110
2111         * BuildSlaveSupport/built-product-archive:
2112         (archiveBuiltProduct):
2113
2114 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2115
2116         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2117         https://bugs.webkit.org/show_bug.cgi?id=96256
2118
2119         Reviewed by Kenneth Rohde Christiansen.
2120
2121         Exported TestRunner::setMinimumTimerInterval() method.
2122
2123         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2124         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2125         (WTR::InjectedBundle::beginTesting):
2126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2127         (WTR::TestRunner::setMinimumTimerInterval):
2128         (WTR):
2129         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2130         (TestRunner):
2131
2132 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2133
2134         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2135         https://bugs.webkit.org/show_bug.cgi?id=96097
2136
2137         Reviewed by Adam Barth.
2138
2139         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2140         (MockWebRTCPeerConnectionHandler::addStream):
2141         (MockWebRTCPeerConnectionHandler::removeStream):
2142
2143 2012-09-11  Peter Beverloo  <peter@chromium.org>
2144
2145         Recognize the "--chromium-android" argument in run-webkit-tests
2146         https://bugs.webkit.org/show_bug.cgi?id=96369
2147
2148         Reviewed by Jochen Eisinger.
2149
2150         Chromium for the Android platform cannot determine the platform based on
2151         the host itself, so we'll use the --chromium-android argument as the build
2152         master passes to run-webkit-tests. Make sure the layout test runner
2153         can pick the right port when doing so.
2154
2155         * Scripts/run-webkit-tests:
2156         * Scripts/webkitpy/layout_tests/port/factory.py:
2157         (port_options):
2158
2159 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2160
2161         [QT] Fix build with newer qmake from Qt 5
2162
2163         Rubber-stamped by Tor Arne Vestbø.
2164
2165         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2166         it with the use of QT_HOST_DATA/mkspecs.
2167         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2168
2169         * Scripts/webkitdirs.pm:
2170         (builtDylibPathForName):
2171         (qtMakeCommand):
2172
2173 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2174
2175         [Qt] Remove Qt 4 syncqt, no longer needed
2176
2177         Reviewed by Simon Hausmann.
2178
2179         * qmake/syncqt-4.8: Removed.
2180
2181 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2182
2183         [Qt][WK2] Fix the build with recent Qt5
2184         https://bugs.webkit.org/show_bug.cgi?id=96283
2185
2186         Reviewed by Simon Hausmann.
2187
2188         We should not use deprecated Qt API because doing that results
2189         in build failure since all the deprecated API was disabled
2190         in qtbase (https://codereview.qt-project.org/#change,24890).
2191
2192         * DumpRenderTree/qt/main.cpp:
2193         (main):
2194         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2195         (MiniBrowserApplication::notify):
2196         * MiniBrowser/qt/raw/View.cpp:
2197         (View::exposeEvent):
2198         (main):
2199
2200 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2201
2202         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2203         https://bugs.webkit.org/show_bug.cgi?id=87188
2204
2205         Reviewed by Kenneth Rohde Christiansen.
2206
2207         Add implementation for applicationCacheDiskUsageForOrigin()
2208         in WebKitTestRunner.
2209
2210         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2212         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2213         (WTR):
2214         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2215         (TestRunner):
2216
2217 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2218
2219         Properly expose <legend> elements to ATs
2220         https://bugs.webkit.org/show_bug.cgi?id=84137
2221
2222         Reviewed by Chris Fleizach.
2223
2224         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2225         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2226         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2227
2228         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2229         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2230
2231 2012-09-10  Jer Noble  <jer.noble@apple.com>
2232
2233         Unreviewed; rolling out r128081.
2234         http://trac.webkit.org/changeset/128081
2235         https://bugs.webkit.org/show_bug.cgi?id=96134
2236
2237         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2238
2239         * DumpRenderTree/TestRunner.cpp:
2240         (TestRunner::TestRunner):
2241         (TestRunner::staticFunctions):
2242         * DumpRenderTree/TestRunner.h:
2243         (TestRunner):
2244         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2245         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2246         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2247         (WTR::InjectedBundlePage::InjectedBundlePage):
2248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2249         (InjectedBundlePage):
2250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2251         (WTR::TestRunner::TestRunner):
2252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2253         (TestRunner):
2254
2255 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2256
2257         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2258         https://bugs.webkit.org/show_bug.cgi?id=96205
2259
2260         Reviewed by Tony Chang.
2261
2262         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2263         internally, which means that it would support only 1 TestExpectations file per port. This
2264         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2265         and efl-wk1 -> efl).
2266
2267         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2268         instead so that all the ports TestExpectations are recognized. The ports are also
2269         constructed twice, with "webkit_test_runner" option set to True and False so that we
2270         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2271
2272         * Scripts/webkitpy/style/checkers/test_expectations.py:
2273         (TestExpectationsChecker._determine_port_from_expectations_path):
2274         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2275         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2276
2277 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2278
2279         [WTR] Generated source files should include config.h
2280         https://bugs.webkit.org/show_bug.cgi?id=96254
2281
2282         Reviewed by Benjamin Poulain.
2283
2284         Current coding style has encouraged to include config.h at the first position,
2285         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2286         this rule.
2287         Therefore, this patch added it.
2288
2289         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2290         (_generateImplementationFile):
2291
2292 2012-09-10  Rick Byers  <rbyers@chromium.org>
2293
2294         Add handling of new GestureTapCancel in DRT
2295         
2296         https://bugs.webkit.org/show_bug.cgi?id=96183
2297
2298         Reviewed by Adam Barth.
2299
2300         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2301         (TestWebPlugin::handleInputEvent):
2302
2303 2012-09-10  Brady Eidson  <beidson@apple.com>
2304
2305         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2306         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2307
2308         Reviewed by Geoff Garen.
2309
2310         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2311
2312         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2313         (PluginObject):
2314         (SlowNPPNew::PluginObject::PluginObject):
2315         (SlowNPPNew::PluginObject::~PluginObject):
2316         (SlowNPPNew::PluginObject::hasProperty):
2317         (SlowNPPNew::PluginObject::getProperty):
2318         (SlowNPPNew::NPP_GetValue):
2319         (SlowNPPNew):
2320
2321 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2322
2323         WKTR often reports an unresponsive WebProcess on Mac bots
2324         https://bugs.webkit.org/show_bug.cgi?id=95906
2325
2326         Reviewed by Dan Bernstein.
2327
2328         Attempt to work around resource contention issues by increasing the NRWT
2329         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2330
2331         * Scripts/webkitpy/layout_tests/port/base.py:
2332         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2333         * WebKitTestRunner/TestController.cpp:
2334         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2335
2336 2012-09-07  Jer Noble  <jer.noble@apple.com>
2337
2338         <audio> and <video> should send Do Not Track when appropriate
2339         https://bugs.webkit.org/show_bug.cgi?id=96134
2340
2341         Reviewed by Eric Carlson.
2342
2343         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2344         WTR. Add FrameLoaderClient client methods for retrieving that value.
2345
2346         * DumpRenderTree/TestRunner.cpp:
2347         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2348         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2349         * DumpRenderTree/TestRunner.h:
2350         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2351         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2352         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2353         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2354             Pass the question on to the TestRunner.
2355         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2356         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2357         (WTR::InjectedBundlePage::InjectedBundlePage):
2358             Add the setShouldSendDoNotTrackHTTPHeader client function.
2359         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2360             Pass the question on to the TestRunner.
2361         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2362         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2364         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2365         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2366
2367 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2368
2369         Make EFL bots work on the flakiness dashboard
2370         https://bugs.webkit.org/show_bug.cgi?id=96164
2371
2372         Reviewed by Tony Chang.
2373
2374         Also, update outdated unittests that had started failing.
2375
2376         * TestResultServer/static-dashboards/builders.js:
2377         (isWebkitTestRunner):
2378         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2379         (nonChromiumPlatform):
2380         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2381         (test):
2382
2383 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2384
2385         [chromium] MediaStream API: Remove the Descriptor postfix
2386         https://bugs.webkit.org/show_bug.cgi?id=96268
2387
2388         Reviewed by Adam Barth.
2389
2390         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2391         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2392
2393         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2394         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2395         (MockWebRTCPeerConnectionHandler::createOffer):
2396         (MockWebRTCPeerConnectionHandler::createAnswer):
2397         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2398         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2399         (MockWebRTCPeerConnectionHandler::localDescription):
2400         (MockWebRTCPeerConnectionHandler::remoteDescription):
2401         (MockWebRTCPeerConnectionHandler::addICECandidate):
2402         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2403         (MockWebRTCPeerConnectionHandler):
2404
2405 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2406
2407         [Gtk] failure to build jhbuild dependencies with cups 1.6
2408         https://bugs.webkit.org/show_bug.cgi?id=95991
2409
2410         Reviewed by Gustavo Noronha Silva.
2411
2412         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2413         building with cups >= 1.6 [GNOME #670373].
2414
2415         * gtk/jhbuild.modules:
2416
2417 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2418
2419         [EFL][DRT] Encoding issue in printed console messages
2420         https://bugs.webkit.org/show_bug.cgi?id=96263
2421
2422         Reviewed by Kenneth Rohde Christiansen.
2423
2424         Correctly handle CONSOLE messages that contain non-ascii
2425         characters in EFL's DRT. We need to use String::fromUTF8()
2426         to construct a WTF::String from a raw string.
2427
2428         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2429         (onConsoleMessage):
2430
2431 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2432
2433         [WK2][WTR] User style sheet location should be reset before each test
2434         https://bugs.webkit.org/show_bug.cgi?id=96262
2435
2436         Reviewed by Kenneth Rohde Christiansen.
2437
2438         User style sheet location is reset before each test now.
2439
2440         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2441         (WTR::InjectedBundle::beginTesting):
2442
2443 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2444
2445         Fix build of WTR with Qt on Windows
2446         https://bugs.webkit.org/show_bug.cgi?id=96249
2447
2448         Reviewed by Kenneth Rohde Christiansen.
2449
2450         Windows loves to define min and max as macros, which beautifully
2451         clashes in many places where min and max are used as variable or method
2452         names. It can be convinced not to do this when min and max are already
2453         define as macros (expanding to themselves). We have this kind of
2454         workaround in config.h files all over WebKit and as it turns out when
2455         building WTR with Qt on Windows we do end up with such a clash. Therefore
2456         we need the same workaround.
2457
2458         * WebKitTestRunner/config.h:
2459
2460 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2461
2462         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2463         https://bugs.webkit.org/show_bug.cgi?id=95936
2464
2465         Reviewed by Kenneth Rohde Christiansen.
2466
2467         Enable interactive form validation setting in WebKitTestRunner as
2468         we are currently doing in DumpRenderTree. This is needed for some
2469         tests to pass.
2470
2471         * WebKitTestRunner/TestController.cpp:
2472         (WTR::TestController::resetStateToConsistentValues):
2473
2474 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2475
2476         Clean up the code in XvfbDriver
2477         https://bugs.webkit.org/show_bug.cgi?id=96202
2478
2479         Reviewed by Philippe Normand.
2480
2481         Changes:
2482         - Remove unneeded imports,
2483         - assign the _lock_file member variable when the display number is determined,
2484         - no need for parentheses around a single string format argument,
2485         - use FileSystem.exists method when checking if lock file is present as it
2486         makes the intention much more clearer.
2487
2488         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2489         (XvfbDriver._start):
2490         (XvfbDriver.stop):
2491
2492 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2493
2494         Make the String initialization on the function side of String::number()
2495         https://bugs.webkit.org/show_bug.cgi?id=95940
2496
2497         Reviewed by Benjamin Poulain.
2498
2499         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2500         (testBoundaries):
2501         (testNumbers):
2502
2503 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2504
2505         [WK2] expose element rect for color input type
2506         https://bugs.webkit.org/show_bug.cgi?id=91664
2507
2508         Reviewed by Simon Hausmann.
2509
2510         Update the QML logic in MiniBrowser to take advantage of this.
2511         The picker size is now hardcoded and we try to place it below the
2512         input element if possible.
2513
2514         * MiniBrowser/qt/qml/ColorChooser.qml:
2515
2516 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2517
2518         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2519         https://bugs.webkit.org/show_bug.cgi?id=95329
2520
2521         Reviewed by Kenneth Rohde Christiansen.
2522
2523         Explicitely disable TabToLinks setting in WebKitTestRunner.
2524         Tests override the "WebKitTabToLinksPreferenceKey" preference
2525         to enable it.
2526
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::TestController::resetStateToConsistentValues):
2529
2530 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2531
2532         webkit.py gdb pretty printer can't print CString
2533         https://bugs.webkit.org/show_bug.cgi?id=96068
2534
2535         Reviewed by Tony Chang.
2536
2537         Update WTFCStringPrinter to follow r126191.
2538
2539         * gdb/webkit.py:
2540         (WTFCStringPrinter.to_string):
2541
2542 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2543
2544         Rename the ustring() accessor to string()
2545         https://bugs.webkit.org/show_bug.cgi?id=95919
2546
2547         Reviewed by Geoffrey Garen.
2548
2549         Update EFL's DRT.
2550
2551         Fix some string conversion that have been made useless
2552         with recent changes.
2553
2554         * DumpRenderTree/efl/EventSender.cpp:
2555         (keyPadNameFromJSValue):
2556         (keyNameFromJSValue):
2557         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2558         (TestRunner::queueLoad):
2559         (TestRunner::addOriginAccessWhitelistEntry):
2560         (TestRunner::removeOriginAccessWhitelistEntry):
2561         (TestRunner::setUserStyleSheetLocation):
2562         (TestRunner::setValueForUser):
2563         (TestRunner::elementDoesAutoCompleteForElementWithId):
2564         (TestRunner::execCommand):
2565         (TestRunner::findString):
2566         (TestRunner::isCommandEnabled):
2567         (TestRunner::clearApplicationCacheForOrigin):
2568         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2569         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2570         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2571         (toInt):
2572         (TestRunner::overridePreference):
2573         (TestRunner::addUserScript):
2574         (TestRunner::addUserStyleSheet):
2575         (TestRunner::evaluateInWebInspector):
2576         (TestRunner::evaluateScriptInIsolatedWorld):
2577         (TestRunner::setTextDirection):
2578         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2579         (LoadItem::invoke):
2580         (LoadHTMLStringItem::invoke):
2581         (ScriptItem::invoke):
2582
2583 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2584
2585         Extend third-party storage blocking API to optionally allow blocking all storage
2586         https://bugs.webkit.org/show_bug.cgi?id=95915
2587
2588         Reviewed by Brady Eidson.
2589
2590         Modified API test to use new revised API.
2591
2592         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2593         (TestWebKitAPI::TEST):
2594
2595 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2596
2597         AX: WebCore accessibility roles should be cross-platform
2598         https://bugs.webkit.org/show_bug.cgi?id=94870
2599
2600         Reviewed by Chris Fleizach.
2601
2602         Add debug strings to Chromium for new accessibility roles.
2603
2604         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2605         (roleToString):
2606
2607 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2608
2609         AX: Chromium needs access to canvasHasFallbackContent
2610         https://bugs.webkit.org/show_bug.cgi?id=96124
2611
2612         Reviewed by Chris Fleizach.
2613
2614         Distinguish between canvas roles with and without fallback
2615         content on Chromium.
2616
2617         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2618         (getRole):
2619
2620 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2621
2622         Handle non-existant TestExpectations files gracefully
2623         https://bugs.webkit.org/show_bug.cgi?id=96149
2624
2625         Reviewed by Eric Seidel.
2626
2627         Even when we get rid of Skipped files, we shouldn't have each port
2628         require a TestExpectations file for each platform if it doesn't
2629         need one.
2630
2631         * Scripts/webkitpy/layout_tests/port/base.py:
2632         (Port.expectations_dict):
2633         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2634         (PortTest.test_nonexistant_expectations):
2635
2636 2012-09-07  Tony Chang  <tony@chromium.org>
2637
2638         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2639         https://bugs.webkit.org/show_bug.cgi?id=96136
2640
2641         Reviewed by Ojan Vafai.
2642
2643         When we renamed the file to TestExpectations, it was no longer considered a text file so
2644         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2645         from the port object, so I've removed that from the check. I'm not sure what it was
2646         supposed to do.
2647
2648         * Scripts/webkitpy/style/checker.py:
2649         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2650         * Scripts/webkitpy/style/checkers/test_expectations.py:
2651         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2652         (TestExpectationsChecker.check): Remove overrides param.
2653         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2654         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2655
2656 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2657
2658         [EFL] Use same default minimum logical font size in DRT and WTR
2659         https://bugs.webkit.org/show_bug.cgi?id=96116
2660
2661         Reviewed by Martin Robinson.
2662
2663         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2664         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2665         logical font size to 9 to match the value used in WTR.
2666         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2667         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2668         logical font size to 9 (default value in WK2)
2669
2670 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2671
2672         MediaStream API: add RTCPeerConnection::createAnswer
2673         https://bugs.webkit.org/show_bug.cgi?id=96092
2674
2675         Reviewed by Adam Barth.
2676
2677         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2678
2679         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2680         (MockWebRTCPeerConnectionHandler::createOffer):
2681         (MockWebRTCPeerConnectionHandler::createAnswer):
2682         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2683         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2684         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2685         (MockWebRTCPeerConnectionHandler):
2686
2687 2012-09-07  Dean Jackson  <dino@apple.com>
2688
2689         Unreviewed changes to watchlist.
2690
2691         - Add new WebGL and Filters definitions
2692         - Add myself to OpenGL bugs
2693
2694         * Scripts/webkitpy/common/config/watchlist:
2695
2696 2012-09-07  Peter Beverloo  <peter@chromium.org>
2697
2698         Actually trigger the Android Tester
2699         https://bugs.webkit.org/show_bug.cgi?id=96118
2700
2701         Reviewed by Adam Barth.
2702
2703         * BuildSlaveSupport/build.webkit.org-config/config.json:
2704
2705 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2706
2707         New time input needs accessibility
2708         https://bugs.webkit.org/show_bug.cgi?id=96032
2709
2710         Reviewed by Chris Fleizach.
2711
2712         Add support for valueDescription for testing.
2713
2714         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2715         (getValueDescription):
2716         (AccessibilityUIElement::AccessibilityUIElement):
2717         (AccessibilityUIElement::valueDescriptionGetterCallback):
2718         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2719         (AccessibilityUIElement):
2720
2721 2012-09-07  Peter Beverloo  <peter@chromium.org>
2722
2723         Add the google-android-tests build slave to the master's config
2724         https://bugs.webkit.org/show_bug.cgi?id=96113
2725
2726         Reviewed by Csaba Osztrogonác.
2727
2728         * BuildSlaveSupport/build.webkit.org-config/config.json:
2729
2730 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2731
2732         [WK2] [EFL] Set theme for WebKit2 API test runner
2733         https://bugs.webkit.org/show_bug.cgi?id=96100
2734
2735         Reviewed by Kenneth Rohde Christiansen.
2736
2737         Set the theme generated by the build for the WebKit2 API test runner.
2738
2739         * TestWebKitAPI/PlatformEfl.cmake:
2740         * TestWebKitAPI/efl/PlatformWebView.cpp:
2741         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2742
2743 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2744
2745         Unreviewed. Add Gábor Ballabás as contributor.
2746
2747         * Scripts/webkitpy/common/config/committers.py:
2748
2749 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2750
2751         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2752         https://bugs.webkit.org/show_bug.cgi?id=96078
2753
2754         Reviewed by Tor Arne Vestbø.
2755
2756         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2757
2758         * qmake/mkspecs/features/default_pre.prf:
2759
2760 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2761
2762         [EFL] Add TestExpectations file for efl-wk1
2763         https://bugs.webkit.org/show_bug.cgi?id=96019
2764
2765         Reviewed by Gyuyoung Kim.
2766
2767         Update TestExpectations cascading for EFL port
2768         so that we use efl-wk1 -> efl search paths
2769         for WebKit1 EFL.
2770
2771         * Scripts/webkitpy/layout_tests/port/efl.py:
2772         (EflPort._search_paths):
2773
2774 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2775
2776         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2777         https://bugs.webkit.org/show_bug.cgi?id=95097
2778
2779         Reviewed by Dirk Pranke.
2780
2781         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2782         terminating the process does not always work as expected, leading to timeouts
2783         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2784         as it's not removed by the killed Xvfb process.
2785
2786         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2787         is tested in different circumstances - whether pixel tests are enabled or not,
2788         with an arbitrary worker number or with an Xorg process already running on the system.
2789         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2790         and then set to None.
2791
2792         * BuildSlaveSupport/kill-old-processes:
2793         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2794         is left running, potentially clogging up a display at a certain position.
2795         * Scripts/webkitpy/common/system/executive_mock.py:
2796         (MockExecutive.__init__):
2797         The _running_pids is now a dictionary with process names as keys and pids
2798         as values.
2799         (MockExecutive.check_running_pid):
2800         Check whether the passed-in pid is in the _running_pids dictionary's values.
2801         (MockExecutive):
2802         (MockExecutive.running_pids):
2803         This method returns the list of all the process pids of which the name passes
2804         through the process_name_filter.
2805         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2806         Use the Executive object of the port's host to check for running pids and open
2807         new subprocesses or kill them throughout the class.
2808         (XvfbDriver._start):
2809         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2810         start the server process after it's created.
2811         (XvfbDriver.stop):
2812         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2813         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2814         (XvfbDriverTest):
2815         (XvfbDriverTest.make_driver):
2816         (XvfbDriverTest.assertDriverStartSuccessful):
2817         (XvfbDriverTest.test_start_no_pixel_tests):
2818         (XvfbDriverTest.test_start_pixel_tests):
2819         (XvfbDriverTest.test_start_arbitrary_worker_number):
2820         (XvfbDriverTest.test_start_existing_xorg_process):
2821         (XvfbDriverTest.test_stop):
2822         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2823
2824 2012-09-06  Peter Beverloo  <peter@chromium.org>
2825
2826         Introduce the Chromium Android Release (Tests) bot
2827         https://bugs.webkit.org/show_bug.cgi?id=95980
2828
2829         Reviewed by Adam Barth.
2830
2831         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2832         which will be running layout tests on actual Android devices. Right now,
2833         four Galaxy Nexus phones are attached.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/config.json:
2836
2837 2012-09-06  James Robinson  <jamesr@chromium.org>
2838
2839         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2840         https://bugs.webkit.org/show_bug.cgi?id=96007
2841
2842         Reviewed by Adrienne Walker.
2843
2844         Fixes initialization / settings code to use WebCompositorSupport.
2845
2846         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2847         (main):
2848         * DumpRenderTree/chromium/TestShell.cpp:
2849         (TestShell::initialize):
2850         (TestShell::setPerTilePaintingEnabled):
2851
2852 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2853
2854         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2855         https://bugs.webkit.org/show_bug.cgi?id=95995
2856
2857         Reviewed by Kenneth Rohde Christiansen.
2858
2859         Provide proper implementation for PlatformWebView::windowFrame()
2860         in EFL's WebKitTestRunner.
2861
2862         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2863         (WTR::PlatformWebView::windowFrame):
2864
2865 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2866
2867         Fix WTF.Lrint on 32-bit platforms
2868         https://bugs.webkit.org/show_bug.cgi?id=96003
2869
2870         Reviewed by Benjamin Poulain.
2871
2872         Fixed failing WTF.Lrint test on 32-bit platforms.
2873
2874         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2875         (TestWebKitAPI::TEST):
2876
2877 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2878
2879         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2880         https://bugs.webkit.org/show_bug.cgi?id=95839
2881
2882         Reviewed by Adam Barth.
2883
2884         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2885         up the task definitions a bit. There was no need to have them in the header file.
2886
2887         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2888         (RTCSessionDescriptionRequestSuccededTask):
2889         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2890         (RTCSessionDescriptionRequestFailedTask):
2891         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2892         (RTCVoidRequestTask):
2893         (RTCVoidRequestTask::RTCVoidRequestTask):
2894         (MockWebRTCPeerConnectionHandler::createOffer):
2895         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2896         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2897         (MockWebRTCPeerConnectionHandler::localDescription):
2898         (MockWebRTCPeerConnectionHandler::remoteDescription):
2899         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2900         (MockWebRTCPeerConnectionHandler):
2901
2902 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2903
2904         [Qt] Fix build on Mac OS X 10.6
2905         https://bugs.webkit.org/show_bug.cgi?id=95200
2906
2907         Reviewed by Tor Arne Vestbø.
2908
2909         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2910         10.7 and newer.
2911
2912         * qmake/mkspecs/features/features.prf:
2913
2914 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2915
2916         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2917         https://bugs.webkit.org/show_bug.cgi?id=95973
2918
2919         Reviewed by Kenneth Rohde Christiansen.
2920
2921         Correctly map "addSelectionKey" to "Control" modifier
2922         in WKTR's EventSender on other OSes than Mac OS X,
2923         instead of mapping it to the "Meta" modifier.
2924
2925         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2926         (WTR::parseModifier):
2927
2928 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2929
2930         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2931         https://bugs.webkit.org/show_bug.cgi?id=95710
2932
2933         Reviewed by Dirk Pranke.
2934
2935         The stdout / stderr output can be None so make sure
2936         we won't raise an exception in this case.
2937
2938         * Scripts/webkitpy/layout_tests/port/driver.py:
2939         (Driver.run_test):
2940
2941 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2942
2943         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2944         https://bugs.webkit.org/show_bug.cgi?id=95849
2945
2946         Reviewed by Kenneth Rohde Christiansen.
2947
2948         Sanitize URLs passed by the user as program
2949         argument or typed in the URL bar in order to
2950         be more tolerant.
2951
2952         * EWebLauncher/CMakeLists.txt:
2953         * EWebLauncher/main.c:
2954         (main):
2955         * EWebLauncher/url_bar.c:
2956         (_url_bar_url_get_with_protocol):
2957         (on_urlbar_key_down):
2958         * EWebLauncher/url_utils.c: Added.
2959         (has_scheme):
2960         (url_from_user_input): Add utility function to construct a
2961         URL from user input.
2962         * EWebLauncher/url_utils.h: Added.
2963         * MiniBrowser/efl/CMakeLists.txt:
2964         * MiniBrowser/efl/main.c:
2965         (main):
2966
2967 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2968
2969         [Qt] Various small Windows / MSVC build fixes
2970         https://bugs.webkit.org/show_bug.cgi?id=95934
2971
2972         Reviewed by Kenneth Rohde Christiansen.
2973
2974         setFocus takes a boolean as argument: Don't try to implicitly convert
2975         an enum to a boolean, MSVC doesn't like that. The intent here is to
2976         enable focus, so just pass true.
2977
2978         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2979         (WTR::PlatformWebView::focus):
2980
2981 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2982
2983         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2984         https://bugs.webkit.org/show_bug.cgi?id=95965
2985
2986         Reviewed by Tor Arne Vestbø.
2987
2988         Add ANGLE as a static library module to the Qt WebKit build system.
2989
2990         * qmake/mkspecs/features/default_post.prf:
2991         * qmake/mkspecs/modules/angle.prf: Added.
2992
2993 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2994
2995         [WK2] Make [Qt]ViewportHandler cross platform
2996         https://bugs.webkit.org/show_bug.cgi?id=91257
2997
2998         Reviewed by Kenneth Rohde Christiansen.
2999
3000         Remove initial scale from viewport info item since it is
3001         set to -1 after applied thus it does not hold any valuable
3002         information.
3003
3004         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3005
3006 2012-09-05  Tony Chang  <tony@chromium.org>
3007
3008         [chromium] Remove dependency on webkit_user_agent
3009         https://bugs.webkit.org/show_bug.cgi?id=95886
3010
3011         Reviewed by Adam Barth.
3012
3013         The code isn't used by DumpRenderTree.
3014
3015         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3016
3017 2012-09-05  Rick Byers  <rbyers@chromium.org>
3018
3019         Update chromium DumpRenderTree for new WebGestureEvent fields
3020         https://bugs.webkit.org/show_bug.cgi?id=95573
3021
3022         Reviewed by James Robinson.
3023
3024         Update EventSender to write gesture details into the appropriate
3025         type-specific WebGestureEvent fields.
3026         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3027         (EventSender::gestureEvent):
3028         (EventSender::gestureFlingStart):
3029
3030 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3031
3032         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3033         https://bugs.webkit.org/show_bug.cgi?id=95789
3034
3035         Reviewed by Ojan Vafai.
3036
3037         Fix miscalculation in log message.
3038
3039         * Scripts/webkitpy/layout_tests/views/printing.py:
3040         (Printer.print_found):
3041
3042 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3043
3044         Unreviewed, rolling out r127612, r127660, and r127664.
3045         http://trac.webkit.org/changeset/127612
3046         http://trac.webkit.org/changeset/127660
3047         http://trac.webkit.org/changeset/127664
3048         https://bugs.webkit.org/show_bug.cgi?id=95920
3049
3050         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3051         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3052         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3053         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3054         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3055         (MockWebRTCPeerConnectionHandler::createOffer):
3056         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3057         (MockWebRTCPeerConnectionHandler):
3058         (SuccessCallbackTask):
3059         (FailureCallbackTask):
3060
3061 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3062
3063         Ignore-metrics includes scroll offsets.
3064         https://bugs.webkit.org/show_bug.cgi?id=95845
3065
3066         Reviewed by Dirk Pranke.
3067
3068         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3069
3070         * Scripts/old-run-webkit-tests:
3071         (stripMetrics):
3072         * Scripts/webkitpy/layout_tests/port/driver.py:
3073         (DriverOutput):
3074
3075 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3076
3077         Unreviewed test fix.
3078
3079         Including a plugin source file into the build that was added in r127595.
3080
3081         * GNUmakefile.am:
3082
3083 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3084
3085         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3086         https://bugs.webkit.org/show_bug.cgi?id=95839
3087
3088         Reviewed by Adam Barth.
3089
3090         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3091         up the task definitions a bit. There was no need to have them in the header file.
3092
3093         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3094         (RTCSessionDescriptionRequestSuccededTask):
3095         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3096         (RTCSessionDescriptionRequestFailedTask):
3097         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3098         (RTCVoidRequestTask):
3099         (RTCVoidRequestTask::RTCVoidRequestTask):
3100         (MockWebRTCPeerConnectionHandler::createOffer):
3101         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3102         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3103         (MockWebRTCPeerConnectionHandler::localDescription):
3104         (MockWebRTCPeerConnectionHandler::remoteDescription):
3105         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3106         (MockWebRTCPeerConnectionHandler):
3107
3108 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3109
3110         [EFL] Remove '+=' usage in String
3111         https://bugs.webkit.org/show_bug.cgi?id=95808
3112
3113         Reviewed by Benjamin Poulain.
3114
3115         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3116
3117         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3118         (descriptionSuitableForTestResult):
3119
3120 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3121
3122         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3123         https://bugs.webkit.org/show_bug.cgi?id=95842
3124
3125         Reviewed by Kenneth Rohde Christiansen.
3126
3127         Provide proper implementation for TestRunner::pathToLocalResource()
3128         in EFL WKTR, identical to the one for DumpRenderTree.
3129
3130         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3131         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3132         are found my WebKitTestRunner.
3133
3134         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3135         (WTR::TestRunner::pathToLocalResource):
3136
3137 2012-09-05  Brady Eidson  <beidson@apple.com>
3138
3139         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3140         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3141
3142         Reviewed by Andy Estes.
3143
3144         Add a plug-in that always fails to initialize:
3145         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3146         (NPPNewFails):
3147         (NPPNewFails::NPPNewFails):
3148         (NPPNewFails::NPP_New):
3149
3150         Add it to all the project files:
3151         * DumpRenderTree/DumpRenderTree.gypi:
3152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3153         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3154         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3155         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3156
3157 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3158
3159         [Qt] Fix makefile race condition between derived sources and target
3160
3161         r121966 removed too much of the old qmake logic, including the rule
3162         that ensured that qmake_all would not trigger dual runs of qmake --
3163         one of the derived sources -qmake-all rule, and one for making the
3164         derived sources.
3165
3166         We now follow a similar pattern as before, by introducing a custom
3167         target that explicitly depends on the derived sources' qmake-all before
3168         doing a manual run of make. That ensures a single qmake run for the derived
3169         sources.
3170
3171         https://bugs.webkit.org/show_bug.cgi?id=93847
3172
3173         Reviewed by Csaba Osztrogonác.
3174
3175         * qmake/mkspecs/features/functions.prf:
3176
3177 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3178
3179         WKTR doesn't implement dumpWillCacheResponse()
3180         https://bugs.webkit.org/show_bug.cgi?id=94607
3181
3182         Reviewed by Kenneth Rohde Christiansen.
3183
3184         Define shouldCacheResponse() callback in resource
3185         load client and provide implementation for
3186         dumpWillCacheResponse() in WebKitTestRunner.
3187
3188         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3189         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3190         (WTR::InjectedBundlePage::InjectedBundlePage):
3191         (WTR::InjectedBundlePage::shouldCacheResponse):
3192         (WTR):
3193         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3194         (InjectedBundlePage):
3195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3196         (WTR::TestRunner::TestRunner):
3197         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3198         (WTR::TestRunner::dumpWillCacheResponse):
3199         (WTR::TestRunner::shouldDumpWillCacheResponse):
3200         (TestRunner):
3201
3202 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3203
3204         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3205         https://bugs.webkit.org/show_bug.cgi?id=92735
3206
3207         Reviewed by Hajime Morita.
3208
3209         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3210
3211         * DumpRenderTree/TestRunner.cpp:
3212         (TestRunner::staticFunctions):
3213         * DumpRenderTree/TestRunner.h:
3214         (TestRunner):
3215         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3216         (TestRunner::addUserStyleSheet):
3217         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3218         (DRTTestRunner::DRTTestRunner):
3219         (DRTTestRunner::hasCustomPageSizeStyle):
3220         * DumpRenderTree/chromium/DRTTestRunner.h:
3221         (DRTTestRunner):
3222         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3223         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3224         * DumpRenderTree/mac/TestRunnerMac.mm:
3225         * DumpRenderTree/qt/TestRunnerQt.cpp:
3226         (TestRunner::evaluateScriptInIsolatedWorld):
3227         * DumpRenderTree/qt/TestRunnerQt.h:
3228         (TestRunner):
3229         * DumpRenderTree/win/TestRunnerWin.cpp:
3230         * DumpRenderTree/wx/TestRunnerWx.cpp:
3231         (TestRunner::abortModal):
3232         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3233         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3234         (WTR):
3235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3236         (TestRunner):
3237
3238 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3239
3240         [Qt] Automate the use of AllInOne files in the Qt build
3241         https://bugs.webkit.org/show_bug.cgi?id=95837
3242
3243         Reviewed by Tor Arne Vestbø.
3244
3245         New feature file that implements the all-in-one file automation by
3246         adding the requested all-in-one files to SOURCES and removing the files
3247         it includes from SOURCES.
3248
3249         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3250
3251 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3252
3253         Have NRWT log more output when crash logs are missing
3254         https://bugs.webkit.org/show_bug.cgi?id=95814
3255
3256         Reviewed by Dan Bernstein.
3257
3258         Log the stderr and stdout of the test, in order to provide slightly more
3259         context when the WebProcess times out while running tests.
3260
3261         * Scripts/webkitpy/layout_tests/port/driver.py:
3262         (Driver.run_test):
3263
3264 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3265
3266         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3267         https://bugs.webkit.org/show_bug.cgi?id=95770
3268
3269         Reviewed by Adam Barth.
3270
3271         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3272         (ChromiumAndroidDriver.__init__):
3273         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3274         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3275         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3276         (ChromiumAndroidDriver._push_executable):
3277         (ChromiumAndroidDriver._push_fonts):
3278         (ChromiumAndroidDriver._push_test_resources):
3279         (ChromiumAndroidDriver._run_adb_command):
3280         (ChromiumAndroidDriver._get_last_stacktrace):
3281         (ChromiumAndroidDriver._get_crash_log):
3282         (ChromiumAndroidDriver._start):
3283         (ChromiumAndroidDriver._start_once):
3284         (ChromiumAndroidDriver._start_once.deadlock_detector):
3285         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3286         (ChromiumAndroidDriverTest.test_get_crash_log):
3287
3288 2012-09-04  Satish Sampath  <satish@chromium.org>
3289
3290         Run git commands within the checkout directory
3291         https://bugs.webkit.org/show_bug.cgi?id=95742
3292
3293         Reviewed by Eric Seidel.
3294
3295         git commands run from scm/git.py are sometimes run with cwd set to the
3296         checkout_root and other times with whatever directory was the default cwd.
3297         Instead all these should run with the checkout root set as the cwd
3298         (except where we explicitly need a different path)
3299
3300         * Scripts/webkitpy/common/checkout/scm/git.py:
3301         (Git._run_git):
3302         (Git.find_checkout_root):
3303         (Git.discard_local_commits):
3304         (Git.local_commits):
3305         (Git.working_directory_is_clean):
3306         (Git.clean_working_directory):
3307         (Git.add_list):
3308         (Git.delete_list):
3309         (Git.exists):
3310         (Git._current_branch):
3311         (Git._changes_files_for_commit):
3312         (Git.revisions_changing_file):
3313         (Git.svn_revision):
3314         (Git._run_git_svn_find_rev):
3315         (Git.contents_at_revision):
3316         (Git.diff_for_file):
3317         (Git.show_head):
3318         (Git.committer_email_for_revision):
3319         (Git.apply_reverse_diff):
3320         (Git.revert_files):
3321         (Git.commit_with_message):
3322         (Git._commit_on_branch):
3323         (Git.svn_commit_log):
3324         (Git.last_svn_commit_log):
3325         (Git.svn_blame):
3326         (Git._branch_ref_exists):
3327         (Git.delete_branch):
3328         (Git.remote_merge_base):
3329         (Git.commit_locally_with_message):
3330         (Git.push_local_commits_to_server):
3331         (Git.commit_ids_from_commitish_arguments):
3332         (Git.commit_message_for_local_commit):
3333         (Git.files_changed_summary_for_commit):
3334
3335 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3336
3337         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3338         https://bugs.webkit.org/show_bug.cgi?id=95734
3339
3340         Reviewed by Adam Barth.
3341
3342         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3343         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3344         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3345         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3346         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3347         (MockWebRTCPeerConnectionHandler::createOffer):
3348         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3349         (MockWebRTCPeerConnectionHandler):
3350         (MockWebRTCPeerConnectionHandler::taskList):
3351         (SuccessCallbackTask):
3352         (FailureCallbackTask):
3353
3354 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3355
3356         [Chromium-Android] Output time and thread info in crash log
3357         https://bugs.webkit.org/show_bug.cgi?id=95768
3358
3359         Reviewed by Adam Barth.
3360
3361         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3362         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3363
3364 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3365
3366         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3367         https://bugs.webkit.org/show_bug.cgi?id=95721
3368
3369         Reviewed by Adam Barth.
3370
3371         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3372         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3373         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3374         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3375         (MockWebMediaStreamCenter):
3376
3377 2012-09-04  Tony Chang  <tony@chromium.org>
3378
3379         Elide test names when running new-run-webkit-tests
3380         https://bugs.webkit.org/show_bug.cgi?id=95626
3381
3382         Reviewed by Dirk Pranke.
3383
3384         When the test name exceeds the number of terminal columns, it leaves
3385         text on the screen. Avoid this by eliding the test name when running
3386         tests. This is similar to what ninja does when compiling.
3387
3388         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3389         (MeteredStream):
3390         (MeteredStream.number_of_columns): Helper method to get number of
3391         terminal columns. Won't work on Win32 python, but meh.
3392         * Scripts/webkitpy/layout_tests/views/printing.py:
3393         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3394         because stderr appears to be ascii only.
3395         (Printer.print_started_test): Route through _test_status_line.
3396         (Printer.print_finished_test): Route through _test_status_line.
3397         (Printer._print_test_trace): Route through _test_status_line.
3398         (Printer._print_baseline): Route through _test_status_line.
3399         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3400         (test_test_status_line): Test for _test_status_line.
3401
3402 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3403
3404         [GTK] Print API missing documentation when generating gtkdoc
3405         https://bugs.webkit.org/show_bug.cgi?id=95703
3406
3407         Reviewed by Carlos Garcia Campos.
3408
3409         Print out API missing documentation when generating gtkdoc. This makes it
3410         easier to fix documentation errors.
3411
3412         * gtk/generate-gtkdoc:
3413         (print_missing_api): Added.
3414         (generate_doc): Inline the rebase step, since it now reports an error
3415         when you try to rebase without generating documentation first.
3416         * gtk/gtkdoc.py:
3417         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3418         generating documentation first to enable a small cleanup at the caller.
3419         (GTKDoc.api_missing_documentation): Added.
3420
3421 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3422
3423         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3424         https://bugs.webkit.org/show_bug.cgi?id=95628
3425
3426         Reviewed by James Robinson.
3427
3428         Future tests need the ability to respond asynchronously that
3429         pointer lock requests have been accepted or rejected. This patch
3430         adds the following:
3431             testRunner.setPointerLockWillRespondAsynchronously();
3432             testRunner.didAcquirePointerLock();
3433             testRunner.didNotAcquirePointerLock();
3434
3435         Tested in existing test:
3436             pointerlockchange-pointerlockerror-events.html
3437
3438         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3439         (DRTTestRunner::DRTTestRunner):
3440         (DRTTestRunner::didAcquirePointerLock):
3441         (DRTTestRunner::didNotAcquirePointerLock):
3442         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3443         * DumpRenderTree/chromium/DRTTestRunner.h:
3444         (DRTTestRunner):
3445         * DumpRenderTree/chromium/WebViewHost.cpp:
3446         (WebViewHost::requestPointerLock):
3447         (WebViewHost::didAcquirePointerLock):
3448         (WebViewHost::didNotAcquirePointerLock):
3449         * DumpRenderTree/chromium/WebViewHost.h:
3450         (WebViewHost):
3451         (WebViewHost::setPointerLockWillRespondAsynchronously):
3452
3453 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3454
3455         Move content shell bots to their own builder group
3456         https://bugs.webkit.org/show_bug.cgi?id=95765
3457
3458         Reviewed by Adam Barth.
3459
3460         In their current state of instability, they add too much noise. Once they get more stable,
3461         we can add them back to the regular group or just have them replace the other bots.
3462
3463         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3464
3465         * TestResultServer/static-dashboards/builders.js:
3466         (isWebkitTestRunner):
3467         (isChromiumContentShellTestRunner):
3468         (isChromiumWebkitTipOfTreeTestRunner):
3469         (loadBuildersList):
3470
3471 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3472
3473         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3474         https://bugs.webkit.org/show_bug.cgi?id=95689
3475
3476         Reviewed by Kenneth Rohde Christiansen.
3477
3478         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3479         So, there are bugs that key events are always generated in url bar although
3480         the user clicked the web view.
3481
3482         This patch recovers the focus of the web view when left button is pressed and
3483         adds for MiniBrowser to toggle the focus when middle button is pressed
3484         like EWebLauncher already did.
3485
3486         * EWebLauncher/main.c:
3487         (on_mouse_down):
3488         * MiniBrowser/efl/main.c:
3489         (on_mouse_down):
3490         (browserCreate):
3491
3492 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3493
3494         Added ANDROID_GDBSERVER definition for Ant
3495         https://bugs.webkit.org/show_bug.cgi?id=95265
3496
3497         Reviewed by Adam Barth.
3498
3499         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3500         is only used for finding the gdbserver.
3501
3502         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3503         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3504
3505 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3506
3507         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3508         https://bugs.webkit.org/show_bug.cgi?id=95565
3509
3510         Reviewed by Adam Barth.
3511
3512         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3513         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3514         (MockWebRTCPeerConnectionHandler::updateICE):
3515         (MockWebRTCPeerConnectionHandler::addICECandidate):
3516         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3517         (MockWebRTCPeerConnectionHandler):
3518
3519 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3520
3521         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3522         https://bugs.webkit.org/show_bug.cgi?id=95670
3523
3524         Reviewed by Kenneth Rohde Christiansen.
3525
3526         Fix layout issues related to the URL bar in Minibrowser
3527         and EWebLauncher when the window is resized.
3528
3529         The URL bar was not resized accordingly and the Web
3530         page was moved behing the URL bar, hiding part of it.
3531
3532         * EWebLauncher/main.c:
3533         (on_ecore_evas_resize):
3534         (closeWindow):
3535         * EWebLauncher/url_bar.c:
3536         (url_bar_width_set):
3537         (url_bar_add):
3538         * EWebLauncher/url_bar.h:
3539         * MiniBrowser/efl/main.c:
3540         (on_ecore_evas_resize):
3541         (main):
3542
3543 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3544
3545         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3546         https://bugs.webkit.org/show_bug.cgi?id=95605
3547
3548         Reviewed by Dirk Pranke.
3549
3550         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3551
3552         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3553         (ChromiumAndroidPort.check_sys_deps):
3554         (ChromiumAndroidPort.expectations_files):
3555         (ChromiumAndroidPort.clean_up_test_run):
3556
3557 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3558
3559         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3560         https://bugs.webkit.org/show_bug.cgi?id=95180
3561
3562         Reviewed by Chris Fleizach.
3563
3564         The bug that was fixed stood in the way of fully implementing stringValue().
3565         Testing that the bug is fixed requires stringValue() to be fully implemented
3566         and object replacement characters to be printable.
3567
3568         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3569         (replaceCharactersForResults): New method which turns object replacement
3570         characters into "<obj>" so that the characters can be properly shown in
3571         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3572         accessible text of a single object in the accessible tree doesn't mess up
3573         the readibility of the results.
3574         (AccessibilityUIElement::stringValue): Remove the code that immediately
3575         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3576         replaceCharactersForResults() prior to returning the accessible string
3577         value.
3578
3579 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3580
3581         MediaStream API: Add MediaStream management to RTCPeerConnection
3582         https://bugs.webkit.org/show_bug.cgi?id=95543
3583
3584         Reviewed by Adam Barth.
3585
3586         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3587
3588         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3589         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3590         (MockWebRTCPeerConnectionHandler::addStream):
3591         (MockWebRTCPeerConnectionHandler::removeStream):
3592         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3593         (MockWebRTCPeerConnectionHandler):
3594
3595 2012-08-31  Tony Chang  <tony@chromium.org>
3596
3597         Remove ENABLE_CSS3_FLEXBOX compile time flag
3598         https://bugs.webkit.org/show_bug.cgi?id=95382
3599
3600         Reviewed by Ojan Vafai.
3601
3602         Everyone is already enabling this by default and the spec has stablized.
3603
3604         * Scripts/webkitperl/FeatureList.pm:
3605         * qmake/mkspecs/features/features.pri:
3606
3607 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3608
3609         objc_msgSend and IMP should be cast appropriately before using
3610         https://bugs.webkit.org/show_bug.cgi?id=95242
3611
3612         Reviewed by Benjamin Poulain.
3613
3614         Fix for older compilers. Pass id as the return type to the template
3615         instead of relying on default type.
3616
3617         * DumpRenderTree/mac/DumpRenderTree.mm:
3618         (drt_NSFontManager_availableFontFamilies):
3619         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3620         (WTR::wtr_NSFontManager_availableFontFamilies):
3621
3622 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3623
3624         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3625         https://bugs.webkit.org/show_bug.cgi?id=89616
3626
3627         Reviewed by Eric Seidel.
3628
3629         Add the new 'executive' optional function argument to the SCM.in_working_directory
3630         class method. This way we get to reuse an Executive instance which is necessary in testing
3631         when we're operating with a mock version of the object.
3632
3633         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3634         the SCMDetector with the generator's FileSystem and Executive instances.
3635
3636         * Scripts/webkitpy/common/checkout/scm/detection.py:
3637         (SCMDetector.detect_scm_system):
3638         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3639         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3640         Executive output and test it against expected output.
3641         * Scripts/webkitpy/common/checkout/scm/git.py:
3642         (Git.in_working_directory):
3643         * Scripts/webkitpy/common/checkout/scm/scm.py:
3644         (SCM.in_working_directory):
3645         * Scripts/webkitpy/common/checkout/scm/svn.py:
3646         (SVN.in_working_directory):
3647         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3648         (JSONResultsGeneratorBase.__init__):
3649         (JSONResultsGeneratorBase._get_svn_revision):
3650
3651 2012-08-31  Jon Lee  <jonlee@apple.com>
3652
3653         [Tests] Add basic tests to http/tests/notifications
3654         https://bugs.webkit.org/show_bug.cgi?id=95493
3655         <rdar://problem/12209303>
3656
3657         Reviewed by Alexey Proskuryakov.
3658
3659         Add permission request support for WTR.
3660
3661         * WebKitTestRunner/TestController.cpp:
3662         (WTR::TestController::initialize):
3663         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3664         * WebKitTestRunner/TestController.h:
3665         (TestController):
3666
3667 2012-08-31  Jon Lee  <jonlee@apple.com>
3668
3669         [DRT] Make simulating a web click on a notification a queued task
3670         https://bugs.webkit.org/show_bug.cgi?id=95546
3671         <rdar://problem/12214170>
3672
3673         Reviewed by Alexey Proskuryakov.
3674
3675         Making the web click happen asynchronously better mimics user interaction with the platform.
3676
3677         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3678         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3679         not set.
3680         * DumpRenderTree/mac/DumpRenderTree.mm:
3681         (dump): Assert that the flag is not set.