.: Allow building with arbitrary SDK and ARCHS with make + Xcode
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-26  David Farler  <dfarler@apple.com>
2
3         Makefiles should work for arbitrary SDKs and architectures on Apple ports
4         https://bugs.webkit.org/show_bug.cgi?id=107863
5
6         Reviewed by David Kilzer.
7
8         * Makefile:
9         Added temporary filters for projects not yet building on iOS.
10         * DumpRenderTree/Makefile:
11         Building with iOS SDKs -> -target All-iOS
12         * Scripts/webkitdirs.pm:
13         (determineConfiguration):
14         Added --configuration switch detection.
15         (determineArchitecture):
16         Added --architecture and ARCH=(.*) switch detection.
17         (argumentsForConfiguration):
18         (determineXcodeSDK):
19         Look for --device, --simulator, and --sdk switches.
20         (xcodeSDK):
21         Added.
22         (XcodeOptions):
23         Determine Xcode SDK and generate -arch switches.
24
25 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
26
27         [chromium] move tracking of the top loading frame to TestRunner library
28         https://bugs.webkit.org/show_bug.cgi?id=107948
29
30         Reviewed by Adam Barth.
31
32         * DumpRenderTree/chromium/DRTTestRunner.cpp:
33         (DRTTestRunner::WorkQueue::processWorkSoon):
34         (DRTTestRunner::WorkQueue::processWork):
35         (DRTTestRunner::completeNotifyDone):
36         * DumpRenderTree/chromium/DRTTestRunner.h:
37         (DRTTestRunner):
38         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
39         (WebTestProxyBase):
40         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
41         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
42         (WebTestRunner::WebTestRunner::topLoadingFrame):
43         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
44         (WebTestRunner::TestRunner::TestRunner):
45         (WebTestRunner::TestRunner::reset):
46         (WebTestRunner::TestRunner::setTopLoadingFrame):
47         (WebTestRunner):
48         (WebTestRunner::TestRunner::topLoadingFrame):
49         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
50         (TestRunner):
51         (WebTestRunner::TestRunner::locationChangeDone):
52         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
53         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
54         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
55         (WebTestRunner::WebTestProxyBase::didFailLoad):
56         (WebTestRunner::WebTestProxyBase::didFinishLoad):
57         (WebTestRunner::WebTestProxyBase::locationChangeDone):
58         (WebTestRunner):
59         * DumpRenderTree/chromium/WebViewHost.cpp:
60         (WebViewHost::reset):
61         (WebViewHost::updateURL):
62         * DumpRenderTree/chromium/WebViewHost.h:
63         (WebViewHost):
64
65 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
66
67         Unreviewed, rolling out r140774.
68         http://trac.webkit.org/changeset/140774
69         https://bugs.webkit.org/show_bug.cgi?id=107932
70
71          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
72         and fastScrollingForFixedPosition are failing (Requested by
73         keishi on #webkit).
74
75         * DumpRenderTree/chromium/WebViewHost.cpp:
76         (WebViewHost::initializeLayerTreeView):
77         (WebViewHost::setWebWidget):
78
79 2013-01-25  Alan Cutter  <alancutter@chromium.org>
80
81         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
82         https://bugs.webkit.org/show_bug.cgi?id=107905
83
84         Reviewed by Eric Seidel.
85
86         Added line to EWS loop to clear /tmp of known Chromium test leak.
87         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
88
89         * EWSTools/start-queue.sh:
90
91 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
92
93         Update Anne's email address
94         https://bugs.webkit.org/show_bug.cgi?id=107866
95
96         Reviewed by Adam Barth.
97
98         * Scripts/webkitpy/common/config/committers.py:
99
100 2013-01-24  Alan Cutter  <alancutter@chromium.org>
101
102         HTTP 500 error between QueueStatusServer and bot(s)
103         https://bugs.webkit.org/show_bug.cgi?id=107184
104
105         Reviewed by Adam Barth.
106
107         Removed the use of memcache which was the source of the exception.
108
109         * QueueStatusServer/handlers/updatestatus.py:
110         (UpdateStatus.post):
111         * QueueStatusServer/model/attachment.py:
112         (Attachment):
113         (Attachment.summary):
114
115 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
116
117         Unreviewed, rolling out r140653.
118         http://trac.webkit.org/changeset/140653
119         https://bugs.webkit.org/show_bug.cgi?id=107916
120
121         Causes a temp file leak on the bots (Requested by abarth on
122         #webkit).
123
124         * DumpRenderTree/chromium/TestShell.cpp:
125         (TestShell::resetTestController):
126
127 2013-01-24  Eric Seidel  <eric@webkit.org>
128
129         Skip haslanded_unittest.py on systems which do not have interdiff installed
130         https://bugs.webkit.org/show_bug.cgi?id=106402
131
132         Unreviewed.
133
134         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
135         (HasLandedTest):
136
137 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
138
139         Disable the failing webkitpy test for now.
140
141         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
142
143 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
144
145         Fixing the diff_parser to correctly identify git diffs even with leading comments.
146         https://bugs.webkit.org/show_bug.cgi?id=107871
147
148         Reviewed by Eric Seidel.
149
150         * Scripts/webkitpy/common/checkout/diff_parser.py:
151         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
152         * Scripts/webkitpy/tool/steps/haslanded.py:
153
154 2013-01-24  James Robinson  <jamesr@chromium.org>
155
156         [chromium] Remove dead transitional code from WebViewImpl
157         https://bugs.webkit.org/show_bug.cgi?id=107889
158
159         Reviewed by Adrienne Walker.
160
161         * DumpRenderTree/chromium/WebViewHost.cpp:
162         (WebViewHost::initializeLayerTreeView):
163         (WebViewHost::setWebWidget):
164
165 2013-01-24  Joshua Bell  <jsbell@chromium.org>
166
167         Add watchlist for IndexedDB development, and add myself and others.
168
169         Unreviewed.
170
171         * Scripts/webkitpy/common/config/watchlist:
172
173 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
174
175         Abstract the logic for appending a UChar32 onto StringBuilder
176         https://bugs.webkit.org/show_bug.cgi?id=107505
177
178         Reviewed by Darin Adler.
179
180         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
181         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
182
183 2013-01-24  Erik Arvidsson  <arv@chromium.org>
184
185         Unreviewed, rolling out r140703.
186         http://trac.webkit.org/changeset/140703
187         https://bugs.webkit.org/show_bug.cgi?id=107556
188
189         r140561 was not the reason for the Android breakage
190
191         * DumpRenderTree/chromium/TestShell.cpp:
192         (TestShell::~TestShell):
193         (TestShell::closeWindow):
194         * DumpRenderTree/chromium/WebViewHost.cpp:
195         (WebViewHost::WebViewHost):
196         (WebViewHost::~WebViewHost):
197         (WebViewHost::shutdown):
198         * DumpRenderTree/chromium/WebViewHost.h:
199         (WebViewHost):
200
201 2013-01-24  Dean Jackson  <dino@apple.com>
202
203         Allow some plugin snapshot UI content to come from Injected Bundle
204         https://bugs.webkit.org/show_bug.cgi?id=107852
205
206         Reviewed by Anders Carlsson.
207
208         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
209         plugInExtraStyleSheet.
210
211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
212         (WTR::InjectedBundlePage::InjectedBundlePage):
213
214 2013-01-24  Erik Arvidsson  <arv@chromium.org>
215
216         Unreviewed, rolling out r140561.
217         http://trac.webkit.org/changeset/140561
218         https://bugs.webkit.org/show_bug.cgi?id=107556
219
220         Suspected to break Android which prevens WebKit roll
221
222         * DumpRenderTree/chromium/TestShell.cpp:
223         (TestShell::~TestShell):
224         (TestShell::closeWindow):
225         * DumpRenderTree/chromium/WebViewHost.cpp:
226         (WebViewHost::WebViewHost):
227         (WebViewHost::~WebViewHost):
228         * DumpRenderTree/chromium/WebViewHost.h:
229         (WebViewHost):
230
231 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
232
233         Adding "has-landed" command to webkit-patch which compares a
234         committed patch to the changes which exist locally (ignoring the
235         ChangeLog file).
236
237         https://bugs.webkit.org/show_bug.cgi?id=106402
238
239         Reviewed by Eric Seidel.
240
241         * Scripts/webkitpy/common/checkout/diff_parser.py:
242         (git_diff_to_svn_diff):
243         * Scripts/webkitpy/common/net/bugzilla/bug.py:
244         (Bug.commit_revision):
245         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
246         (BugTest.test_is_in_comments):
247         (BugTest):
248         (BugTest.test_commit_revision):
249         * Scripts/webkitpy/tool/commands/upload.py:
250         (HasLanded):
251         * Scripts/webkitpy/tool/steps/__init__.py:
252         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
253         (HasLanded):
254         (HasLanded.convert_to_svn):
255         (HasLanded.strip_change_log):
256         (run):
257
258         * Scripts/webkitpy/common/net/bugzilla/bug.py:
259         (Bug.commit_revision):
260         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
261         (BugTest.test_is_in_comments):
262         (BugTest):
263         (BugTest.test_commit_revision):
264         * Scripts/webkitpy/tool/commands/upload.py:
265         (HasLanded):
266         * Scripts/webkitpy/tool/steps/__init__.py:
267         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
268         (HasLanded):
269         (HasLanded.convert_to_svn):
270         (HasLanded.strip_change_log):
271         (HasLanded.diff_diff):
272         (HasLanded.run):
273         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
274         (HasLandedTest):
275         (HasLandedTest.test_run):
276         (test_convert_to_svn_and_strip_change_log):
277
278 2013-01-24  Dan Carney  <dcarney@google.com>
279
280         [chromium] move most WebViewHost printf calls to WebTestProxy
281         https://bugs.webkit.org/show_bug.cgi?id=107553
282
283         Reviewed by Jochen Eisinger.
284
285         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
286         (WebKit):
287         (WebTestProxyBase):
288         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
289         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
290         (WebTestRunner::WebTestProxy::runModalAlertDialog):
291         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
292         (WebTestRunner::WebTestProxy::runModalPromptDialog):
293         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
294         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
295         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
296         (WebTestRunner::WebTestProxyBase::reset):
297         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
298         (WebTestRunner):
299         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
300         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
301         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
302         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
303         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
304         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
305         * DumpRenderTree/chromium/TestShell.cpp:
306         (TestShell::showDevTools):
307         * DumpRenderTree/chromium/WebViewHost.cpp:
308         (WebViewHost::didAddMessageToConsole):
309         (WebViewHost::runModalAlertDialog):
310         (WebViewHost::runModalConfirmDialog):
311         (WebViewHost::runModalPromptDialog):
312         (WebViewHost::runModalBeforeUnloadDialog):
313         (WebViewHost::unableToImplementPolicyWithError):
314         (WebViewHost::reset):
315         * DumpRenderTree/chromium/WebViewHost.h:
316         (WebViewHost):
317
318 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
319
320         [Chromium] Give webkit_support a chance to reset state between layout test runs
321         https://bugs.webkit.org/show_bug.cgi?id=107132
322
323         Reviewed by Adam Barth.
324
325         We currently only have need for this on OS(ANDROID), but now it
326         would be useful to have a hook for resetting state on all
327         platforms. Will soon be using this for IDBFactory initialization.
328
329         * DumpRenderTree/chromium/TestShell.cpp:
330         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
331
332 2013-01-23  Alan Cutter  <alancutter@chromium.org>
333
334         QueueStatusServer crashes in production on next-patch
335         https://bugs.webkit.org/show_bug.cgi?id=107775
336
337         Reviewed by Adam Barth.
338
339         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
340
341         * QueueStatusServer/app.yaml:
342         * QueueStatusServer/model/patchlog.py:
343         (PatchLog.calculate_wait_duration):
344         (PatchLog.calculate_process_duration):
345         (PatchLog):
346         (PatchLog._time_delta_to_seconds):
347
348 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
349
350         The previous patch wasn't complete. Finish reverting r139998 for real.
351
352         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
353         (ProfilerAgent.getProfile):
354
355 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
356
357         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
358
359         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
360         (ProfilerAgent.getProfile):
361
362 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
363
364         [Chromium] Remove unused header files in chromium/public/platform/
365         https://bugs.webkit.org/show_bug.cgi?id=107741
366
367         Reviewed by James Robinson.
368
369         These header files have migrated to the new Platform directory.
370         This patch updates the remaining #include references and removes
371         the old files that did nothing but redirect to the new ones.
372
373         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
374         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
375
376 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
377
378         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
379         https://bugs.webkit.org/show_bug.cgi?id=107727
380
381         Reviewed by Gustavo Noronha Silva.
382
383         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
384         We are using the git repository now that github has deprecated the downloads feature.
385
386 2013-01-23  Tony Chang  <tony@chromium.org>
387
388         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
389
390         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
391         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
392         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
393         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
394
395 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
396
397         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
398         https://bugs.webkit.org/show_bug.cgi?id=107145
399
400         Reviewed by Adam Barth.
401
402         Part of a larger refactoring series; see tracking bug 82948.
403         
404         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
405         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
406         * DumpRenderTree/chromium/DRTDevToolsClient.h:
407         * DumpRenderTree/chromium/DRTTestRunner.cpp:
408         * DumpRenderTree/chromium/DRTTestRunner.h:
409         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
410         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
411         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
412         * DumpRenderTree/chromium/NotificationPresenter.cpp:
413         * DumpRenderTree/chromium/TestNavigationController.h:
414         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
415         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
416         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
417         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
418         (WebTestRunner):
419         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
420         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
421         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
422         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
424         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
425         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
426         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
427         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
428         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
429         * DumpRenderTree/chromium/TestShell.cpp:
430         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
431         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
432         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
433         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
434         * DumpRenderTree/chromium/WebViewHost.cpp:
435
436 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
437
438         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
439         https://bugs.webkit.org/show_bug.cgi?id=107556
440
441         Reviewed by Tony Chang.
442
443         WebViewHost initiates a navigation to about:blank in its destructor.
444         However, since WebTestProxy inherits from WebViewHost, at this point
445         the WebViewClient and WebFrameClient interfaces are already partially
446         destructed resulting in the use after free.
447
448         This does not affect the chromium implementation since it doesn't
449         invoke WebKit API methods in its destructor.
450
451         * DumpRenderTree/chromium/TestShell.cpp:
452         (TestShell::~TestShell):
453         (TestShell::closeWindow):
454         * DumpRenderTree/chromium/WebViewHost.cpp:
455         (WebViewHost::WebViewHost):
456         (WebViewHost::~WebViewHost):
457         (WebViewHost::shutdown):
458         * DumpRenderTree/chromium/WebViewHost.h:
459         (WebViewHost):
460
461 2013-01-23  Andrei Bucur  <abucur@adobe.com>
462
463         [CSS Regions] Create Regions watchlist
464         https://bugs.webkit.org/show_bug.cgi?id=107281
465
466         Reviewed by Adam Barth.
467
468         This patch adds 4 new definitions:
469         - RegionsDevelopment - used to track the development progress for regions
470         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
471         - RegionsUsage - used to track changes that make use of regions in all the code base
472
473         For now, the Adobe internal tracker is the only email address listening for these patterns.
474
475         * Scripts/webkitpy/common/config/watchlist:
476
477 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
478
479         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
480         https://bugs.webkit.org/show_bug.cgi?id=107523
481
482         Reviewed by Yury Semikhatsky.
483
484         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
485         (DRTDevToolsClient::isUnderTest):
486         (DRTDevToolsClient::call):
487         * DumpRenderTree/chromium/DRTDevToolsClient.h:
488         (DRTDevToolsClient):
489
490 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
491
492         Removing command line shortening as it makes it difficult to see the command during errors.
493         https://bugs.webkit.org/show_bug.cgi?id=107643
494
495         Reviewed by Eric Seidel.
496
497         * Scripts/webkitpy/common/system/executive.py:
498         (ScriptError):
499         (ScriptError.__init__):
500         * Scripts/webkitpy/common/system/executive_unittest.py:
501
502 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
503
504         Adding myself as contributor in committers.py (as requested by eseidel).
505         https://bugs.webkit.org/show_bug.cgi?id=107647
506
507         Reviewed by Eric Seidel.
508
509         * Scripts/webkitpy/common/config/committers.py:
510
511 2013-01-22  Alan Cutter  <alancutter@chromium.org>
512
513         Add monitoring of patches and queues to the QueueStatusServer
514         https://bugs.webkit.org/show_bug.cgi?id=107612
515
516         Reviewed by Adam Barth.
517
518         Created classes for recording events into the datastore and integrated them into the existing handlers.
519         Code for presenting the recorded data will come in a separate patch.
520
521         * QueueStatusServer/app.yaml:
522         * QueueStatusServer/config/__init__.py: Added.
523         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
524         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
525         * QueueStatusServer/handlers/nextpatch.py:
526         (NextPatch.get):
527         (NextPatch._assign_patch):
528         * QueueStatusServer/handlers/releasepatch.py:
529         (ReleasePatch.post):
530         * QueueStatusServer/handlers/updatestatus.py:
531         (UpdateStatus.post):
532         * QueueStatusServer/handlers/updateworkitems.py:
533         (UpdateWorkItems._parse_work_items_string):
534         (UpdateWorkItems):
535         (UpdateWorkItems._update_work_items_from_request):
536         (UpdateWorkItems._queue_from_request):
537         (UpdateWorkItems.post):
538         * QueueStatusServer/loggers/__init__.py: Added.
539         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
540         (RecordBotEvent):
541         (RecordBotEvent.activity):
542         * QueueStatusServer/loggers/recordpatchevent.py: Added.
543         (RecordPatchEvent):
544         (RecordPatchEvent.added):
545         (RecordPatchEvent.retrying):
546         (RecordPatchEvent.started):
547         (RecordPatchEvent.stopped):
548         (RecordPatchEvent.updated):
549         (RecordPatchEvent._get_patches_waiting):
550         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
551         (PatchLog):
552         (PatchLog.lookup):
553         (PatchLog.calculate_wait_duration):
554         (PatchLog.calculate_process_duration):
555         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
556         (QueueLog):
557         (QueueLog.get_current):
558         (QueueLog.create_key):
559         * QueueStatusServer/model/queuestatus.py:
560         (QueueStatus.is_retry_request):
561
562 2013-01-22  Timothy Loh  <timloh@chromium.com>
563
564         prepare-Changelog should support updating the list of changed files
565         https://bugs.webkit.org/show_bug.cgi?id=74358
566
567         Reviewed by Eric Seidel.
568
569         Needing to re-make ChangeLog entries when the list of files/functions
570         changes is a bit annoying, it'd be nice to have this more automated.
571         This patch makes `webkit-patch update' update the date line and bug
572         description if needed, and if the list of changed files/functions has
573         changed, either updates the list (if there are no annotations), or
574         otherwise appends the new list below.
575
576         * Scripts/webkitpy/tool/steps/preparechangelog.py:
577         (PrepareChangeLog._resolve_existing_entry):
578         (PrepareChangeLog):
579         (PrepareChangeLog._merge_entries):
580         (PrepareChangeLog.run):
581         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
582         (PrepareChangeLogTest.test_resolve_existing_entry):
583         (make_entry):
584         (test_ensure_bug_url):
585
586 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
587
588         Use Python 2.7 unittest syntax in our unittests
589         https://bugs.webkit.org/show_bug.cgi?id=105607
590
591         Reviewed by Eric Seidel.
592
593         * Scripts/webkitpy/**/*_unittest.py:
594
595 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
596
597         Convert disable-msg to disable for new pylint.
598         https://bugs.webkit.org/show_bug.cgi?id=107627
599
600         Reviewed by Eric Seidel.
601
602         * Scripts/webkitpy/common/checkout/scm/svn.py:
603         (SVNRepository.has_authorization_for_realm):
604         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
605         (Builder.force_build):
606         * Scripts/webkitpy/common/system/executive_mock.py:
607         (MockExecutive2.run_command):
608         * Scripts/webkitpy/layout_tests/port/base.py:
609         (Port.reference_files):
610         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
611         (ChromiumPortTestCase.test_default_configuration):
612         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
613         (PortTestCase.test_expectations_ordering):
614         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
615         (HttpServerBase._check_that_all_ports_are_available):
616         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
617         (AbstractLocalServerCommand.execute):
618         * Scripts/webkitpy/tool/commands/download.py:
619         (AbstractPatchProcessingCommand):
620         * Scripts/webkitpy/tool/commands/rebaseline.py:
621         (AbstractRebaseliningCommand):
622         (AbstractParallelRebaselineCommand):
623         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
624         (_BaseTestCase.setUp):
625         (TestAnalyzeBaselines.setUp):
626
627 2013-01-22  Frank Farzan  <frankf@chromium.org>
628
629         Flakiness dashboard: update builders.jsonp
630         https://bugs.webkit.org/show_bug.cgi?id=107610
631
632         Reviewed by Ojan Vafai.
633
634         * TestResultServer/static-dashboards/builders.jsonp:
635
636 2013-01-22  Frank Farzan  <frankf@chromium.org>
637
638         Add Android instrumentation tests from ChromiumLinux waterfall
639         https://bugs.webkit.org/show_bug.cgi?id=107597
640
641         Reviewed by Ojan Vafai.
642
643         * TestResultServer/static-dashboards/builders.js:
644         (loadBuildersList):
645
646 2013-01-21  Kentaro Hara  <haraken@chromium.org>
647
648         Implement UIEvent constructor
649         https://bugs.webkit.org/show_bug.cgi?id=107430
650
651         Reviewed by Adam Barth.
652
653         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
654
655         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
656         which is enabled on Safari and Chromium for now.
657
658         * Scripts/webkitperl/FeatureList.pm:
659
660 2013-01-22  Timothy Loh  <timloh@chromium.com>
661
662         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
663         https://bugs.webkit.org/show_bug.cgi?id=107478
664
665         Reviewed by Eric Seidel.
666
667         On the road to resolving Bug 74358, we need a few more functions in
668         changelog.py.
669         To make things easier to mock, change @staticmethods to @classmethods.
670
671         * Scripts/webkitpy/common/checkout/changelog.py:
672         (ChangeLogEntry):
673         (ChangeLogEntry._parse_reviewer_text):
674         (ChangeLogEntry._split_contributor_names):
675         (ChangeLogEntry._parse_author_name_and_email):
676         (ChangeLogEntry._parse_author_text):
677         (ChangeLogEntry._parse_touched_functions):
678         (ChangeLogEntry._parse_bug_description):
679         (ChangeLogEntry._parse_entry):
680         (ChangeLogEntry.date_line):
681         (ChangeLogEntry.bug_description):
682         (ChangeLogEntry.touched_functions):
683         (ChangeLogEntry.touched_files_text):
684         (ChangeLogEntry.is_touched_files_text_clean):
685         (ChangeLog):
686         (ChangeLog.parse_latest_entry_from_file):
687         (ChangeLog._separate_revision_and_line):
688         (ChangeLog.parse_entries_from_file):
689         (ChangeLog.set_short_description_and_bug_url):
690         (ChangeLog.delete_entries):
691         (ChangeLog.prepend_text):
692         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
693         (test_parse_log_entries_from_changelog):
694         (test_latest_entry_parse):
695         (test_set_short_description_and_bug_url):
696         (test_delete_entries):
697         (test_prepend_text):
698
699 2013-01-22  Lucas Forschler  <lforschler@apple.com>
700
701         Create a MAC EWS startup shell script.
702
703         Reviewed by Ryosuke Niwa.
704
705         * EWSTools/start-queue-mac.sh: Added.
706
707 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
708
709         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
710         https://bugs.webkit.org/show_bug.cgi?id=107230
711
712         Reviewed by David Kilzer.
713
714         * DumpRenderTree/mac/TestRunnerMac.mm:
715         (TestRunner::resetPageVisibility):
716         Fix a typo in the original implementation. resetPageVisibility should
717         pass initialState YES so an event is not dispatched, which causes
718         issues in multiple tests. This now matches other ports.
719
720 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
721
722         [GTK] Enable CSS Image Orientation feature
723         https://bugs.webkit.org/show_bug.cgi?id=99040
724
725         Reviewed by Martin Robinson.
726
727         Enable the CSS Image Orientation feature in the development
728         builds of the GTK port. The feature is still disabled in the release
729         builds.
730
731         * Scripts/webkitperl/FeatureList.pm:
732
733 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
734
735         [GTK] Enable the <template> element support in development builds
736         https://bugs.webkit.org/show_bug.cgi?id=106575
737
738         Reviewed by Martin Robinson.
739
740         Enable the <template> element support in the development builds of the GTK port.
741
742         * Scripts/webkitperl/FeatureList.pm:
743
744 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
745
746         Prettify the output of the override-feature-defines script
747         https://bugs.webkit.org/show_bug.cgi?id=106542
748
749         Reviewed by Martin Robinson.
750
751         The output now clearly lists the feature defines being overridden
752         along with the default and overriding values for each feature define.
753
754         * gtk/override-feature-defines:
755         (adjust_feature_defines_makefile):
756         (adjust_feature_defines_makefile.override_feature_define):
757
758 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
759
760         Remove uses of deprecated unittest.TestCase aliases
761         https://bugs.webkit.org/show_bug.cgi?id=102252
762
763         Reviewed by Adam Barth.
764
765         Replace the deprecated assertEquals method of the TestCase interface
766         used in some webkitpy unittests with the assertEqual method.
767
768         * Scripts/webkitpy/common/system/profiler_unittest.py:
769         (ProfilerFactoryTest._assert_default_profiler_name):
770         (ProfilerFactoryTest.test_default_profiler_output):
771         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
772         (GtkPortTest.test_expectations_files):
773         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
774         (TestHttpServer.test_win32_start_and_stop):
775
776 2013-01-22  Jer Noble  <jer.noble@apple.com>
777
778         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
779         https://bugs.webkit.org/show_bug.cgi?id=107562
780
781         Rubber-stamped by Alexy Proskuryakov.
782
783         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
784
785         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
786         (WTR::PlatformWebView::PlatformWebView):
787         (WTR::PlatformWebView::viewSupportsOptions):
788
789 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
790
791         One is not allowed to use commit-queue to make oneself a committer.
792
793         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
794
795 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
796
797         Add myself to commiters.py
798         https://bugs.webkit.org/show_bug.cgi?id=107546
799
800         Reviewed by Kentaro Hara.
801
802         * Scripts/webkitpy/common/config/committers.py:
803
804 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
805
806         [GTK] Implement TestRunner::setTextDirection
807         https://bugs.webkit.org/show_bug.cgi?id=107131
808
809         Reviewed by Philippe Normand.
810
811         * DumpRenderTree/gtk/DumpRenderTree.cpp:
812         (resetDefaultsToConsistentValues): Reset direction to default value.
813         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
814         (TestRunner::setTextDirection): Implement method using
815         gtk_widget_set_direction.
816
817 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
818
819         [chromium] move spell checking mocks to TestRunner library
820         https://bugs.webkit.org/show_bug.cgi?id=107455
821
822         Reviewed by Kent Tamura.
823
824         The content module doesn't provide its own WebSpellCheckClient.
825
826         * DumpRenderTree/DumpRenderTree.gypi:
827         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
828         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
829         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
830         (WebKit):
831         (WebTestRunner):
832         (WebTestProxyBase):
833         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
834         (WebTestRunner):
835         (WebTestRunner::makeMenuItemStringsFor):
836         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
837         (MockGrammarCheck::checkGrammarOfString):
838         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
839         (WebKit):
840         (MockGrammarCheck):
841         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
842         (MockSpellCheck::MockSpellCheck):
843         (MockSpellCheck::~MockSpellCheck):
844         (isNotASCIIAlpha):
845         (MockSpellCheck::spellCheckWord):
846         (MockSpellCheck::fillSuggestionList):
847         (MockSpellCheck::initializeIfNeeded):
848         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
849         (MockSpellCheck):
850         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
851         (WebTestRunner::SpellCheckClient::SpellCheckClient):
852         (WebTestRunner):
853         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
854         (WebTestRunner::SpellCheckClient::setDelegate):
855         (WebTestRunner::SpellCheckClient::spellCheck):
856         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
857         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
858         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
859         (WebTestRunner::SpellCheckClient::autoCorrectWord):
860         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
861         (WebTestRunner):
862         (SpellCheckClient):
863         (WebTestRunner::SpellCheckClient::taskList):
864         (WebTestRunner::SpellCheckClient::mockSpellCheck):
865         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
866         (TestDelegate):
867         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
868         (WebTestInterfaces::Internal):
869         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
870         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
871         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
872         (WebTestRunner::WebTestProxyBase::setDelegate):
873         (WebTestRunner::WebTestProxyBase::spellCheckClient):
874         (WebTestRunner):
875         * DumpRenderTree/chromium/WebViewHost.cpp:
876         (WebViewHost::WebViewHost):
877         (WebViewHost::setWebWidget):
878         * DumpRenderTree/chromium/WebViewHost.h:
879         (WebViewHost):
880
881 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
882
883         [EFL] Adds Accessibility support to wk1
884         https://bugs.webkit.org/show_bug.cgi?id=107440
885
886         Reviewed by Gyuyoung Kim.
887
888         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
889
890 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
891
892         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
893         https://bugs.webkit.org/show_bug.cgi?id=107506
894
895         Reviewed by Dan Bernstein.
896
897         * MiniBrowser/mac/WK1BrowserWindowController.m:
898         (-[WK1BrowserWindowController dealloc]):
899
900 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
901
902         Add build flag for Canvas's Path object (disabled by default)
903         https://bugs.webkit.org/show_bug.cgi?id=107473
904
905         Reviewed by Dean Jackson.
906
907         Add CANVAS_PATH build flag to build systems.
908
909         * Scripts/webkitperl/FeatureList.pm:
910
911 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
912
913         [EFL][WK2] Add APIs to set/get view source mode
914         https://bugs.webkit.org/show_bug.cgi?id=106633
915
916         Reviewed by Gyuyoung Kim.
917
918         Added a shotcut 'F8' in Minibrowser to display a source code
919         of the web page in a new window.
920
921        * MiniBrowser/efl/main.c:
922         (on_key_down):
923         (on_window_create):
924         (window_create):
925         (elm_main):
926
927 2013-01-21  Nico Weber  <thakis@chromium.org>
928
929         [chromium] Don't archive generated source files.
930         https://bugs.webkit.org/show_bug.cgi?id=106736
931
932         Reviewed by Eric Seidel.
933
934         They shouldn't be needed to run tests. They don't need a lot of space,
935         but add many lines to the "extracting" stdout. This attempts to reduce
936         that noise a bit.
937
938         * BuildSlaveSupport/built-product-archive:
939         (archiveBuiltProduct):
940
941 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
942
943         Mac DumpRenderTree's installSignalHandlers() is unreachable code
944         https://bugs.webkit.org/show_bug.cgi?id=107383
945
946         Reviewed by Sam Weinig.
947
948         The CrashHandler of DumpRenderTree were originally used for restoring
949         the color profile of the main display even if DRT crashes.
950
951         That feature was later limited to pixel tests only in r29999.
952
953         In r104351, the DRT was changed to use device color space. Making the crash
954         handlers useless, but they were left in the code since the error reporting
955         code was still reachable.
956
957         Later, r124581 refactored the code and dumpPixelsForCurrentTest
958         is being used before being assigned its value.
959         This did cause any regression because the code had become useless with the previous change.
960
961         * DumpRenderTree/mac/DumpRenderTree.mm:
962         Remove crashHandler() and installSignalHandlers() as they have become useless and
963         have been unreachable code for 6 months.
964         (dumpRenderTree):
965         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
966         at those points.
967
968 2013-01-21  Nico Weber  <thakis@chromium.org>
969
970         Make ninja the default build system for build-webkit --chromium on mac
971         https://bugs.webkit.org/show_bug.cgi?id=106737
972
973         Reviewed by Eric Seidel.
974
975         * Scripts/update-webkit-chromium:
976
977 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
978
979         Regression(r140262): Causes a lot of flakiness
980         https://bugs.webkit.org/show_bug.cgi?id=107454
981
982         Reviewed by Alexey Proskuryakov.
983
984         r140262 introduced a lot of flakiness due to fixed layout mode
985         not getting disabled on the view after being enabled for
986         specific test cases. This patch makes sure fixed layout mode
987         properly gets reset in WebKitTestRunner to avoid flakiness.
988
989         * WebKitTestRunner/TestInvocation.cpp:
990         (WTR::updateLayoutType):
991
992 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
993
994         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
995         https://bugs.webkit.org/show_bug.cgi?id=107421
996
997         Unreviewed build fix.
998
999         * Scripts/run-gtk-tests:
1000         (TestRunner): skip Resource tests.
1001
1002 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1003
1004         [EFL][WKTR] platformRunUntil() should keep the main loop running
1005         https://bugs.webkit.org/show_bug.cgi?id=107442
1006
1007         Reviewed by Noam Rosenthal.
1008
1009         EFL's implementation of platformRunUntil() should keep the main loop
1010         running and avoid calling sleep() between calls to
1011         ecore_main_loop_iterate(). This call to sleep seems to be a source
1012         of deadlocks (see Bug 106884).
1013
1014         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1015         (WTR::TestController::platformRunUntil):
1016
1017 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
1018
1019         QtTestBrowser should provide way to clear selected elements
1020         https://bugs.webkit.org/show_bug.cgi?id=107437
1021
1022         Reviewed by Simon Hausmann.
1023
1024         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
1025         Invoke the clearSelection prior to highlighting new elements.
1026
1027         * QtTestBrowser/launcherwindow.cpp:
1028         (ElementHighlight):
1029         (LauncherWindow::createChrome):
1030         (LauncherWindow::selectElements):
1031         (LauncherWindow::clearSelection):
1032         * QtTestBrowser/launcherwindow.h:
1033         (LauncherWindow):
1034
1035 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
1036
1037         [chromium] move methods interacting with willSendRequest to TestRunner
1038         https://bugs.webkit.org/show_bug.cgi?id=107270
1039
1040         Reviewed by Kent Tamura.
1041
1042         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1043         (DRTTestRunner::DRTTestRunner):
1044         (DRTTestRunner::waitForPolicyDelegate):
1045         * DumpRenderTree/chromium/DRTTestRunner.h:
1046         (DRTTestRunner):
1047         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1048         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1049         (WebTestRunner::WebTestRunner::httpHeadersToClear):
1050         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
1051         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
1052         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1053         (WebTestRunner::TestRunner::TestRunner):
1054         (WebTestRunner::TestRunner::reset):
1055         (WebTestRunner::TestRunner::httpHeadersToClear):
1056         (WebTestRunner):
1057         (WebTestRunner::TestRunner::shouldBlockRedirects):
1058         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
1059         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
1060         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1061         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
1062         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1063         (TestRunner):
1064         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1065         (WebTestRunner::WebTestProxyBase::willSendRequest):
1066         * DumpRenderTree/chromium/WebViewHost.cpp:
1067         (WebViewHost::willSendRequest):
1068         (WebViewHost::reset):
1069         * DumpRenderTree/chromium/WebViewHost.h:
1070         (WebViewHost):
1071
1072 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
1073
1074         [GTK] Stop building WebKit2 on GTK EWSs
1075         https://bugs.webkit.org/show_bug.cgi?id=107435
1076
1077         Reviewed by Philippe Normand.
1078
1079         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
1080         so stop building it on GTK EWSs.
1081
1082         * Scripts/webkitpy/common/config/ports.py:
1083         (GtkPort.build_webkit_command):
1084         * Scripts/webkitpy/common/config/ports_unittest.py:
1085         (DeprecatedPortTest.test_gtk_port):
1086
1087 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
1088
1089         MediaStream API: Update the RTCPeerConnection states to match the latest specification
1090         https://bugs.webkit.org/show_bug.cgi?id=107120
1091
1092         Reviewed by Adam Barth.
1093
1094         Updating mock to use the new states.
1095
1096         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1097         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
1098         (MockWebRTCPeerConnectionHandler::initialize):
1099         (MockWebRTCPeerConnectionHandler::updateICE):
1100
1101 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
1102
1103         Extend diff_parser to support the --full-index output.
1104         https://bugs.webkit.org/show_bug.cgi?id=107408
1105
1106         Reviewed by Maciej Stachowiak.
1107
1108         * Scripts/webkitpy/common/checkout/diff_parser.py:
1109         (git_diff_to_svn_diff):
1110         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1111         (DiffParserTest):
1112         (DiffParserTest.test_git_diff_to_svn_diff):
1113         (git_diff_to_svn_diff):
1114
1115 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
1116
1117         Dragging over an element with scrollbars should scroll the element when dragging near edges
1118         https://bugs.webkit.org/show_bug.cgi?id=39725
1119
1120         Reviewed by Hajime Morita.
1121
1122         This patch introduces canceling drag-and-drop by escape key for testing
1123         behavior after cancellation drag-and-drop.
1124
1125         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1126         (WebTestRunner):
1127         (WebTestRunner::EventSender::doMouseUp):
1128         (WebTestRunner::EventSender::finishDragAndDrop):
1129         (WebTestRunner::EventSender::keyDown):
1130         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1131         (EventSender):
1132         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
1133
1134 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1135
1136         [chromium] move frame generation related methods to TestRunner
1137         https://bugs.webkit.org/show_bug.cgi?id=107268
1138
1139         Reviewed by Adam Barth.
1140
1141         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1142         (DRTTestRunner::DRTTestRunner):
1143         (DRTTestRunner::setWillSendRequestReturnsNull):
1144         * DumpRenderTree/chromium/DRTTestRunner.h:
1145         (DRTTestRunner):
1146         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1147         (WebTestRunner::WebTestDelegate::display):
1148         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
1149         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1150         (WebTestRunner::TestRunner::TestRunner):
1151         (WebTestRunner::TestRunner::display):
1152         (WebTestRunner):
1153         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1154         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1155         (TestRunner):
1156         * DumpRenderTree/chromium/WebViewHost.cpp:
1157         (WebViewHost::display):
1158         (WebViewHost::displayInvalidatedRegion):
1159         * DumpRenderTree/chromium/WebViewHost.h:
1160
1161 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1162
1163         [chromium] move speech related methods to TestRunner library
1164         https://bugs.webkit.org/show_bug.cgi?id=107266
1165
1166         Reviewed by Adam Barth.
1167
1168         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1169         (DRTTestRunner::DRTTestRunner):
1170         (DRTTestRunner::displayInvalidatedRegion):
1171         * DumpRenderTree/chromium/DRTTestRunner.h:
1172         (DRTTestRunner):
1173         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1174         (WebTestDelegate):
1175         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1176         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1177         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1178         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1179         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1180         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1181         (WebTestRunner::TestRunner::TestRunner):
1182         (WebTestRunner):
1183         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1184         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1185         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1186         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1187         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1188         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1189         (TestRunner):
1190         * DumpRenderTree/chromium/WebViewHost.cpp:
1191         (WebViewHost::addMockSpeechInputResult):
1192         (WebViewHost::setMockSpeechInputDumpRect):
1193         (WebViewHost::addMockSpeechRecognitionResult):
1194         (WebViewHost::setMockSpeechRecognitionError):
1195         (WebViewHost::wasMockSpeechRecognitionAborted):
1196         * DumpRenderTree/chromium/WebViewHost.h:
1197
1198 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1199
1200         [chromium] move notification related methods to TestRunner
1201         https://bugs.webkit.org/show_bug.cgi?id=107269
1202
1203         Reviewed by Adam Barth.
1204
1205         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1206         (DRTTestRunner::DRTTestRunner):
1207         * DumpRenderTree/chromium/DRTTestRunner.h:
1208         (DRTTestRunner):
1209         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1210         (WebTestDelegate):
1211         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1212         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1213         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1214         (WebTestRunner::TestRunner::TestRunner):
1215         (WebTestRunner):
1216         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1217         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1218         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1219         (TestRunner):
1220         * DumpRenderTree/chromium/WebViewHost.cpp:
1221         (WebViewHost::grantWebNotificationPermission):
1222         (WebViewHost::simulateLegacyWebNotificationClick):
1223         * DumpRenderTree/chromium/WebViewHost.h:
1224
1225 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1226
1227         [chromium] move geolocation related methods to TestRunner
1228         https://bugs.webkit.org/show_bug.cgi?id=107267
1229
1230         Reviewed by Adam Barth.
1231
1232         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1233         (DRTTestRunner::DRTTestRunner):
1234         * DumpRenderTree/chromium/DRTTestRunner.h:
1235         (DRTTestRunner):
1236         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1237         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1238         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1239         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1240         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1241         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1242         (WebTestRunner::TestRunner::TestRunner):
1243         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1244         (WebTestRunner):
1245         (WebTestRunner::TestRunner::setGeolocationPermission):
1246         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1247         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1248         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1249         (TestRunner):
1250         * DumpRenderTree/chromium/WebViewHost.cpp:
1251         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1252         (WebViewHost::setGeolocationPermission):
1253         (WebViewHost::setMockGeolocationPosition):
1254         (WebViewHost::setMockGeolocationPositionUnavailableError):
1255         * DumpRenderTree/chromium/WebViewHost.h:
1256
1257 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1258
1259         Unreviewed build fix for Qt WK2 after r140258.
1260         Use the size_t type instead of unsigned for the variable
1261         which holds the position of the first null character in the
1262         console message.
1263
1264         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1265         (WTR::InjectedBundlePage::willAddMessageToConsole):
1266
1267 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1268
1269         Unreviewed, rolling out r140260.
1270         http://trac.webkit.org/changeset/140260
1271         https://bugs.webkit.org/show_bug.cgi?id=107387
1272
1273         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1274         nothing else) (Requested by thakis__ on #webkit).
1275
1276         * Scripts/update-webkit-chromium:
1277
1278 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1279
1280         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1281         https://bugs.webkit.org/show_bug.cgi?id=106890
1282
1283         Reviewed by Kenneth Rohde Christiansen.
1284
1285         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1286
1287         * WebKitTestRunner/TestInvocation.cpp:
1288         (WTR::shouldUseFixedLayout):
1289         (WTR):
1290         (WTR::updateLayoutType):
1291
1292 2013-01-19  Nico Weber  <thakis@chromium.org>
1293
1294         Make ninja the default build system for build-webkit --chromium on mac
1295         https://bugs.webkit.org/show_bug.cgi?id=106737
1296
1297         Reviewed by Eric Seidel.
1298
1299         * Scripts/update-webkit-chromium:
1300
1301 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1302
1303         [WK2] svg/dom/fuzz-path-parser.html is failing
1304         https://bugs.webkit.org/show_bug.cgi?id=107133
1305
1306         Reviewed by Alexey Proskuryakov.
1307
1308         Console messages can contain null characters before the end of string.
1309         Appending such message to the StringBuilder as a WTFString appends the
1310         complete string, including the null character. This later cuts off everything
1311         after the null character when the string is being printed out to the test
1312         output.
1313
1314         To avoid this, truncate the string up to the first null character. This
1315         preserves the newline character appended immediately after this and
1316         stops giving incorrect output.
1317
1318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1319         (WTR::InjectedBundlePage::willAddMessageToConsole):
1320
1321 2013-01-19  Eric Seidel  <eric@webkit.org>
1322
1323         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1324         https://bugs.webkit.org/show_bug.cgi?id=107367
1325
1326         Reviewed by Ryosuke Niwa.
1327
1328         Using srcdoc instead of document.write changes the error output
1329         ever so slightly.  Clearly we were already trying to ignore these
1330         messages, just not succeeding.  This change makes this new test "pass" correctly.
1331
1332         * Scripts/webkitpy/performance_tests/perftest.py:
1333         (PerfTest):
1334
1335 2013-01-18  Dan Winship  <danw@gnome.org>
1336
1337         REGRESSION (r139071): run-webkit-httpd complains at launch
1338         https://bugs.webkit.org/show_bug.cgi?id=107310
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * Scripts/webkitperl/httpd.pm:
1343         (getApacheVersion): use preferred perl syntax
1344
1345 2013-01-18  Julie Parent  <jparent@chromium.org>
1346
1347         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1348         https://bugs.webkit.org/show_bug.cgi?id=107336
1349
1350         We need to have 'group' listed as a parameter, else we never parse it,
1351         as we only parse parameters with defaults.
1352         
1353         Reviewed by Ojan Vafai.
1354
1355         * TestResultServer/static-dashboards/dashboard_base.js:
1356
1357 2013-01-18  Emil A Eklund  <eae@chromium.org>
1358
1359         Update LayoutUnit rounding unit test
1360         https://bugs.webkit.org/show_bug.cgi?id=107322
1361
1362         Reviewed by Levi Weintraub.
1363         
1364         Update the LayoutUnitRounding test to use fromFloatRound for
1365         values that cannot accurately be represented as a LayoutUnit
1366         (the default behavior is to floor the value to the nearest
1367         LayoutUnit).
1368
1369         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1370         (TestWebKitAPI::TEST):
1371
1372 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1373
1374         VCSUtils.pm: Stop calling git repo-config.
1375         https://bugs.webkit.org/show_bug.cgi?id=107294
1376
1377         Reviewed by Dirk Pranke.
1378
1379         The `repo-config' git command has been deprecated since early
1380         2008, and recent versions have started warning it is deprecated.
1381
1382         Basically revert r27870 and use the `config' command all the time.
1383
1384         * Scripts/VCSUtils.pm:
1385         (gitConfig):
1386
1387 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1388
1389         LayoutUnit should round half consistently, not away from zero
1390         https://bugs.webkit.org/show_bug.cgi?id=107208
1391
1392         Reviewed by Eric Seidel.
1393
1394         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1395         cover this change in rounding behavior.
1396
1397 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1398
1399         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1400         https://bugs.webkit.org/show_bug.cgi?id=107234
1401
1402         Reviewed by Simon Fraser.
1403
1404         * DumpRenderTree/mac/DumpRenderTree.mm:
1405         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1406         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1407         (WTR::PlatformWebView::PlatformWebView): Ditto.
1408
1409 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1410
1411         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1412         https://bugs.webkit.org/show_bug.cgi?id=107251
1413
1414         Reviewed by Simon Fraser.
1415
1416         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1417
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (dumpRenderTree):
1420         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1421         (WTR::InjectedBundle::platformInitialize):
1422
1423 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1424
1425         [GTK] Enable indexed database for development builds
1426         https://bugs.webkit.org/show_bug.cgi?id=107299
1427
1428         Reviewed by Gustavo Noronha Silva.
1429
1430         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1431         for GTK+ development builds.
1432
1433 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1434
1435         AX: Improve table-guessing heuristics
1436         https://bugs.webkit.org/show_bug.cgi?id=107042
1437
1438         Reviewed by Chris Fleizach.
1439
1440         Implement parentElementCallback on Chromium to make testing easier.
1441
1442         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1443         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1444
1445 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1446
1447         [GTK] Add property for IndexedDB database path to WebKitGTK+
1448         https://bugs.webkit.org/show_bug.cgi?id=106136
1449
1450         Reviewed by Gustavo Noronha Silva.
1451
1452         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1453         before falling back to the old default. This is necessary because
1454         indexed database tests require that each DRT shard is using a different
1455         IDB database location.
1456
1457         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1458         (temporaryDatabaseDirectory): Added this helper for getting the
1459         database directory.
1460         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1461
1462 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1463
1464         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1465         https://bugs.webkit.org/show_bug.cgi?id=107264
1466
1467         Reviewed by Laszlo Gombos.
1468
1469         Enable API test InjectedBundleFrameHitTest for hit-testing,
1470         since it is now passing on both Debug and Release builds.
1471
1472         * TestWebKitAPI/CMakeLists.txt:
1473         * TestWebKitAPI/PlatformEfl.cmake:
1474
1475 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1476
1477         [GTK] Implement TestRunner::addUserScript
1478         https://bugs.webkit.org/show_bug.cgi?id=107275
1479
1480         Reviewed by Philippe Normand.
1481
1482         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1483         (TestRunner::addUserScript): Implement method using
1484         DumpRenderTreeSupportGtk::addUserScript.
1485
1486 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1487
1488         Unreviewed, add my secondary email address to the list.
1489
1490         * Scripts/webkitpy/common/config/committers.py:
1491
1492 2013-01-18  Dan Carney  <dcarney@google.com>
1493
1494         [chromium] move pointerlock functions to TestRunner library
1495         https://bugs.webkit.org/show_bug.cgi?id=107241
1496
1497         Reviewed by Jochen Eisinger.
1498
1499         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1500         (DRTTestRunner::DRTTestRunner):
1501         * DumpRenderTree/chromium/DRTTestRunner.h:
1502         (DRTTestRunner):
1503         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1504         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1505         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1506         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1507         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1508         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1509         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1510         (WebTestRunner::TestRunner::TestRunner):
1511         (WebTestRunner):
1512         (WebTestRunner::TestRunner::didAcquirePointerLock):
1513         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1514         (WebTestRunner::TestRunner::didLosePointerLock):
1515         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1516         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1517         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1518         (TestRunner):
1519         * DumpRenderTree/chromium/WebViewHost.h:
1520         (WebViewHost):
1521
1522 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1523
1524         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1525         https://bugs.webkit.org/show_bug.cgi?id=106774
1526
1527         Reviewed by Martin Robinson.
1528
1529         In order to fix a long standing linespacing/font ascent & descent issue
1530         we found that FreeType commit b0962ac34e660 solves that problem.
1531         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1532         maintainer recommending several security updates after that said commit.
1533
1534         Also, in order to avoid extra rebaselining, let's activate subpixel
1535         layout at the same time.
1536
1537         * efl/jhbuild.modules: New freetype 2.4.11
1538
1539 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1540
1541         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1542         https://bugs.webkit.org/show_bug.cgi?id=107107
1543         PR 282192
1544
1545         Reviewed by Rob Buis.
1546
1547         The DRT application will convert relative/absolute file path to
1548         file://<real-file-path> format, so we only check for http/file prefix.
1549
1550         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1551         (BlackBerry::WebKit::isFullUrl):
1552         (WebKit):
1553         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
1554
1555 2013-01-17  Frank Farzan  <frankf@chromium.org>
1556
1557         Flakiness dashboard: Add ChromiumFYI master
1558         https://bugs.webkit.org/show_bug.cgi?id=107180
1559
1560         Reviewed by Ojan Vafai.
1561
1562         This is needed to enable Chrome Android bots
1563         to upload results for instrumentation tests.
1564
1565         * TestResultServer/generate_builders_json.py:
1566         (main):
1567         * TestResultServer/static-dashboards/builders.jsonp:
1568
1569 2013-01-17  Frank Farzan  <frankf@chromium.org>
1570
1571         Add Chrome on Android instrumentation test types to flakiness dashboard
1572         https://bugs.webkit.org/show_bug.cgi?id=106964
1573
1574         Reviewed by Ojan Vafai.
1575
1576         Specifically, add these test types:
1577         
1578          androidwebview_instrumentation_tests
1579          chromiumtestshell_instrumentation_tests
1580          contentshell_instrumentation_tests
1581         
1582         Also, add ChromiumFYI to the list of masters.
1583
1584         * TestResultServer/static-dashboards/builders.js:
1585         (loadBuildersList):
1586         * TestResultServer/static-dashboards/dashboard_base.js:
1587         (currentBuilderGroupCategory):
1588
1589 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1590
1591         Fixing webkitpy's SCM unit tests.
1592         https://bugs.webkit.org/show_bug.cgi?id=106429
1593
1594         Reviewed by Eric Seidel.
1595
1596         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1597         (SCMDetectorTest.test_detect_scm_system):
1598         * Scripts/webkitpy/common/checkout/scm/git.py:
1599         (Git.in_working_directory):
1600         (Git.read_git_config):
1601         (Git._assert_can_squash):
1602         (Git.remote_branch_ref):
1603         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1604         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1605         (GitTestWithMock):
1606         (GitTestWithMock.make_scm):
1607         (GitTestWithMock.test_create_patch):
1608         * Scripts/webkitpy/common/system/outputcapture.py:
1609         (OutputCapture.assert_outputs):
1610         (OutputCaptureTestCaseBase):
1611         * Scripts/webkitpy/test/printer.py:
1612         (Printer.configure):
1613
1614 2013-01-17  Julie Parent  <jparent@chromium.org>
1615
1616         Flakiness dashboard assumes there must be ToT tests
1617         https://bugs.webkit.org/show_bug.cgi?id=107155
1618
1619         Remove group as a default parameter, since we can't actually know
1620         the name of a group initially.  Instead, introduces 
1621         currentBuilderGroupName which returns the current builder group
1622         if it has been explicitly set, or picks the first one available
1623         as a default. Allows us to remove some extra code tracking this
1624         stuff as well.
1625         
1626         Reviewed by Ojan Vafai.
1627
1628         * TestResultServer/static-dashboards/dashboard_base.js:
1629         (parseCrossDashboardParameters):
1630         (currentBuilderGroupName):
1631         (currentBuilderGroup):
1632         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1633         (platformAndBuildType):
1634         * TestResultServer/static-dashboards/loader.js:
1635         (.):
1636
1637 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1638
1639         Remove NodeListsNodeData when it's no longer needed
1640         https://bugs.webkit.org/show_bug.cgi?id=107074
1641
1642         Reviewed by Darin Adler.
1643
1644         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1645
1646         * Scripts/webkitpy/performance_tests/perftest.py:
1647         (PerfTest):
1648
1649 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1650
1651         Ref test images are upside-down in WebKit2
1652         https://bugs.webkit.org/show_bug.cgi?id=105457
1653
1654         Reviewed by Sam "Speedy" Weinig.
1655         
1656         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1657         from the window snapshot contained a flipped copy of the image, causing all ref
1658         and pixel images to be upside-down.
1659
1660         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1661         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1662
1663 2013-01-17  Timothy Loh  <timloh@google.com>
1664
1665         Replaced specifiers variable with is_debug in builders.py
1666         https://bugs.webkit.org/show_bug.cgi?id=107057
1667
1668         Reviewed by Dirk Pranke.
1669
1670         Replaced specifiers variable with is_debug in builders.py to simplify
1671         Bug 106259. The other specifiers are not used elsewhere in the code.
1672         Fixed builder_name_for_port_name to return a debug builder if we don't
1673         have a release builder.
1674
1675         * Scripts/webkitpy/layout_tests/port/builders.py:
1676         (all_port_names):
1677         (builder_name_for_port_name):
1678         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1679         (TestRebaselineExpectations.test_rebaseline_expectations):
1680
1681 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
1682
1683         [GTK] Build with LevelDB when IndexedDB is enabled
1684         https://bugs.webkit.org/show_bug.cgi?id=103220
1685
1686         Reviewed by Gustavo Noronha Silva.
1687
1688         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
1689         as it does not conform to WebKit style.
1690
1691 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1692
1693         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
1694         https://bugs.webkit.org/show_bug.cgi?id=107119
1695
1696         Reviewed by Laszlo Gombos.
1697
1698         Do not use ASSERT on ecore_evas_init(), since the expression inside
1699         the macro compiles out of release builds.
1700
1701         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1702         * TestWebKitAPI/efl/PlatformWebView.cpp:
1703         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1704
1705 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1706
1707         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1708         https://bugs.webkit.org/show_bug.cgi?id=104545
1709
1710         Reviewed by Yury Semikhatsky.
1711
1712         Adopt signature changes.
1713
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1715         (ProfilerAgent.getCPUProfile): Renamed.
1716         (ProfilerAgent.getHeapSnapshot): Added.
1717
1718 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1719
1720         [GTK][EFL] NWRT should check that Xvfb is installed
1721         https://bugs.webkit.org/show_bug.cgi?id=71767
1722
1723         Reviewed by Dirk Pranke.
1724
1725         EFL and GTK ports now check that Xvfb is installed before running
1726         layout tests. The command line used to check whether Xvfb is present
1727         is a simple `which Xvfb` that should return 0 as the exit code upon
1728         success.
1729
1730         * Scripts/webkitpy/layout_tests/port/efl.py:
1731         (EflPort.show_results_html_file):
1732         (EflPort):
1733         (EflPort.check_sys_deps):
1734         * Scripts/webkitpy/layout_tests/port/gtk.py:
1735         (GtkPort.check_sys_deps):
1736         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1737         (XvfbDriver):
1738         (XvfbDriver.check_xvfb):
1739
1740 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1741
1742         sheriffbot can't tell me who "kov" is
1743         https://bugs.webkit.org/show_bug.cgi?id=106184
1744
1745         Reviewed by Eric Seidel.
1746
1747         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1748
1749         * Scripts/webkitpy/common/config/committers.py:
1750         (Account.matches_glob):
1751         (CommitterList.contributors_by_search_string):
1752         * Scripts/webkitpy/common/config/committers_unittest.py:
1753         (CommittersTest.test_committer_lookup):
1754         * Scripts/webkitpy/tool/bot/irc_command.py:
1755         (Whois):
1756
1757 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1758
1759         Use xcrun to find path to make for Mac port
1760         <http://webkit.org/b/107091>
1761
1762         Reviewed by Dan Bernstein.
1763
1764         * Scripts/webkitpy/layout_tests/port/mac.py:
1765         (MacPort._build_java_test_support): Call self.make_command().
1766         (MacPort.make_command): Add.  Call xcrun_find().
1767         (MacPort.nm_command): Use self.xcrun_find().
1768         (MacPort.xcrun_find): Add.  Extract from nm_command().
1769
1770 2013-01-16  Sam Weinig  <sam@webkit.org>
1771
1772         Make debug-safari --target-web-process work again
1773         https://bugs.webkit.org/show_bug.cgi?id=107088
1774
1775         Reviewed by Anders Carlsson.
1776
1777         * Scripts/webkitdirs.pm:
1778         (execMacWebKitAppForDebugging):
1779         The shim is now called SecItemShim.
1780
1781 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1782
1783         GCE build scripts don't take working directory into account when calling findzone.sh
1784         https://bugs.webkit.org/show_bug.cgi?id=106962
1785
1786         Reviewed by Adam Barth.
1787
1788         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1789         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1790         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1791
1792 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1793
1794         start-queue.sh does not pass remaining parameters correctly
1795         https://bugs.webkit.org/show_bug.cgi?id=107054
1796
1797         Reviewed by Adam Barth.
1798
1799         start-queue.sh now passes all remaining params to the webkit-patch command.
1800         Previously only one additional queue parameter could be sent.
1801
1802         * EWSTools/start-queue.sh:
1803
1804 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1805
1806         check-webkit-style script cannot running in Chinese windows.
1807         https://bugs.webkit.org/show_bug.cgi?id=87548
1808
1809         Reviewed by Darin Adler.
1810
1811         * Scripts/webkitpy/common/system/platforminfo.py:
1812         (PlatformInfo._win_version_tuple_from_cmd):
1813
1814 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1815
1816         Delete an extraneous print statement.
1817         https://bugs.webkit.org/show_bug.cgi?id=106562
1818
1819         Delete the extraneous print statement introduced in r139841.
1820
1821         * Scripts/webkitpy/layout_tests/views/printing.py:
1822         (Printer.print_found):
1823
1824 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1825
1826         Please reinstate --pixel
1827         https://bugs.webkit.org/show_bug.cgi?id=101995
1828
1829         Reviewed by Dirk Pranke.
1830
1831         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1832         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1833         Some developers are still used to these options that were available in the ORWT.
1834
1835         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1836         (parse_args):
1837
1838 2013-01-16  Eric Seidel  <eric@webkit.org>
1839
1840         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1841         https://bugs.webkit.org/show_bug.cgi?id=99512
1842
1843         Reviewed by Darin Adler.
1844
1845         * Scripts/run-sunspider:
1846
1847 2013-01-16  Eric Seidel  <eric@webkit.org>
1848
1849         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1850         https://bugs.webkit.org/show_bug.cgi?id=106036
1851
1852         Reviewed by Darin Adler.
1853
1854         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1855         * Scripts/webkitpy/webkitpy.sln: Removed.
1856
1857 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1858
1859         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1860         https://bugs.webkit.org/show_bug.cgi?id=104049
1861
1862         Reviewed by Eric Seidel.
1863
1864         Targets with dependencies (direct/indirect) on a java target receive
1865         the chromium_*.jar paths in the variable input_jars_paths. Targets
1866         should use that rather than hardcoding where they think the jar will
1867         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1868         than as --jars to generate_native_test.py.
1869
1870         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1871         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1872
1873 2013-01-16  Dan Carney  <dcarney@google.com>
1874
1875         [chromium] move setMockDeviceOrientation to TestRunner library
1876         https://bugs.webkit.org/show_bug.cgi?id=106895
1877
1878         Reviewed by Jochen Eisinger.
1879
1880         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1881         (DRTTestRunner::DRTTestRunner):
1882         * DumpRenderTree/chromium/DRTTestRunner.h:
1883         (DRTTestRunner):
1884         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1885         (WebKit):
1886         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1887         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1888         (WebTestRunner::TestRunner::TestRunner):
1889         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1890         (WebTestRunner):
1891         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1892         (TestRunner):
1893         * DumpRenderTree/chromium/WebViewHost.cpp:
1894         (WebViewHost::setDeviceOrientation):
1895         * DumpRenderTree/chromium/WebViewHost.h:
1896         (WebViewHost):
1897
1898 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1899
1900         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1901         https://bugs.webkit.org/show_bug.cgi?id=106904
1902
1903         Reviewed by Adam Barth.
1904
1905         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1906         (DRTTestRunner::DRTTestRunner):
1907         (DRTTestRunner::notifyDone):
1908         (DRTTestRunner::reset):
1909         * DumpRenderTree/chromium/DRTTestRunner.h:
1910         (DRTTestRunner):
1911         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1912         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1913         (WebTestRunner::WebTestDelegate::setFocus):
1914         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1915         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1916         (WebTestRunner::WebTestDelegate::setLocale):
1917         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1918         (WebTestRunner::TestRunner::TestRunner):
1919         (WebTestRunner::TestRunner::reset):
1920         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1921         (WebTestRunner):
1922         (WebTestRunner::TestRunner::setWindowIsKey):
1923         (WebTestRunner::TestRunner::pathToLocalResource):
1924         (WebTestRunner::TestRunner::setBackingScaleFactor):
1925         (WebTestRunner::TestRunner::setPOSIXLocale):
1926         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1927         (WebTestRunner::TestRunner::taskList):
1928         (TestRunner):
1929         * DumpRenderTree/chromium/WebViewHost.cpp:
1930         (WebViewHost::setDeviceScaleFactor):
1931         (WebViewHost::setFocus):
1932         (WebViewHost::setAcceptAllCookies):
1933         (WebViewHost::pathToLocalResource):
1934         (WebViewHost::setLocale):
1935         * DumpRenderTree/chromium/WebViewHost.h:
1936         (WebViewHost):
1937
1938 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1939
1940         [GTK] build-webkit fails if the jhbuild wrapper is not used
1941         https://bugs.webkit.org/show_bug.cgi?id=106769
1942
1943         Reviewed by Martin Robinson.
1944
1945         Return an empty array instead of "" in
1946         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1947         will not be recognized as a valid command when the returned array
1948         is directly passed to perl's system() call.
1949
1950         * Scripts/webkitdirs.pm:
1951         (jhbuildWrapperPrefixIfNeeded):
1952
1953 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1954
1955         [chromium] add title text direction attribute to TestRunner
1956         https://bugs.webkit.org/show_bug.cgi?id=106907
1957
1958         Reviewed by Adam Barth.
1959
1960         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1961         (DRTTestRunner::DRTTestRunner):
1962         (DRTTestRunner::reset):
1963         * DumpRenderTree/chromium/DRTTestRunner.h:
1964         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1965         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1966         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1967         (WebTestRunner::TestRunner::TestRunner):
1968         (WebTestRunner::TestRunner::reset):
1969         (WebTestRunner::TestRunner::setTitleTextDirection):
1970         (WebTestRunner):
1971         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1972         (TestRunner):
1973         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1974         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1975         * DumpRenderTree/chromium/WebViewHost.cpp:
1976         (WebViewHost::didReceiveTitle):
1977
1978 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1979
1980         NRWT still confused about test count with --repeat-each and --iterations
1981         https://bugs.webkit.org/show_bug.cgi?id=106562
1982
1983         Reviewed by Dirk Pranke.
1984
1985         Fix the printed unique test count and skipped count. This
1986         seems to have broken in r127688 ("NRWT lies about the number
1987         of tests that it's skipping when used with --repeat-each").
1988
1989         Also add a test for print_found()
1990
1991         * Scripts/webkitpy/layout_tests/views/printing.py:
1992         (Printer.print_found):
1993         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1994         (Testprinter.test_details):
1995         (Testprinter):
1996         (Testprinter.test_found):
1997
1998 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1999
2000         Unreviewed follow-up to r139769.
2001
2002         Note that omitting the WebKit1 code from the build now
2003         works for GTK as well.
2004
2005         * Scripts/build-webkit:
2006
2007 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2008
2009         test-webkitpy: truncate output to the terminal width when necessary
2010         https://bugs.webkit.org/show_bug.cgi?id=106973
2011
2012         Reviewed by Ojan Vafai.
2013
2014         this implements the same logic for test-webkitpy that we have
2015         for run-webkit-tests (and ninja).
2016
2017         No tests written as this is exercised by running test-webkitpy itself.
2018
2019         * Scripts/webkitpy/test/printer.py:
2020         (Printer.configure):
2021         (Printer._test_line):
2022
2023 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2024
2025         remove extraneous output in test-webkitpy
2026         https://bugs.webkit.org/show_bug.cgi?id=106971
2027
2028         Reviewed by Ojan Vafai.
2029
2030         We weren't ignoring or capturing the echoed output from
2031         these two tests, and getting noise in the logs as a result.
2032
2033         * Scripts/webkitpy/common/system/executive_unittest.py:
2034         (ExecutiveTest.test_auto_stringify_args):
2035         (ExecutiveTest.test_popen_args):
2036
2037 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2038
2039         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
2040         https://bugs.webkit.org/show_bug.cgi?id=106974
2041
2042         Reviewed by Ryosuke Niwa.
2043
2044         I forgot to stub out the call to check to ensure that the ports were
2045         available, so this test could fail if something was listening on 8000 or
2046         8443 on the machine.
2047
2048         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2049         (TestHttpServer.test_win32_start_and_stop):
2050
2051 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2052
2053         Unreviewed, rolling out r139792.
2054         http://trac.webkit.org/changeset/139792
2055         https://bugs.webkit.org/show_bug.cgi?id=106970
2056
2057         Broke the windows build.
2058
2059         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2060         (DRTTestRunner::DRTTestRunner):
2061         (DRTTestRunner::notifyDone):
2062         (DRTTestRunner::reset):
2063         (DRTTestRunner::setAlwaysAcceptCookies):
2064         (DRTTestRunner::setWindowIsKey):
2065         (DRTTestRunner::pathToLocalResource):
2066         (DRTTestRunner::setPOSIXLocale):
2067         (InvokeCallbackTask):
2068         (InvokeCallbackTask::InvokeCallbackTask):
2069         (InvokeCallbackTask::runIfValid):
2070         (DRTTestRunner::setBackingScaleFactor):
2071         * DumpRenderTree/chromium/DRTTestRunner.h:
2072         (DRTTestRunner):
2073         (DRTTestRunner::taskList):
2074         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2075         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2076         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2077         (WebTestRunner::TestRunner::TestRunner):
2078         (WebTestRunner::TestRunner::reset):
2079         (WebTestRunner::TestRunner::setDatabaseQuota):
2080         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2081         (TestRunner):
2082         * DumpRenderTree/chromium/WebViewHost.cpp:
2083         (WebViewHost::setPendingExtraData):
2084         (WebViewHost::setDeviceScaleFactor):
2085         * DumpRenderTree/chromium/WebViewHost.h:
2086         (WebViewHost):
2087
2088 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
2089
2090         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
2091
2092         * Scripts/webkitpy/common/config/ports.py:
2093         (MacWK2Port):
2094
2095 2013-01-15  Alan Cutter  <alancutter@chromium.org>
2096
2097         Extend sheriffbot's "help" command to be able to get help on individual commands
2098         https://bugs.webkit.org/show_bug.cgi?id=106629
2099
2100         Reviewed by Eric Seidel.
2101
2102         Added a help command to sheriffbot.
2103         Fixed some style issues and ordered the commands alphabetically.
2104
2105         * Scripts/webkitpy/tool/bot/irc_command.py:
2106         (IRCCommand):
2107         (IRCCommand.execute):
2108         (IRCCommand.usage):
2109         (IRCCommand.help):
2110         (CreateBug):
2111         (CreateBug.execute):
2112         (Help):
2113         (Help.execute):
2114         (Help._post_command_help):
2115         (Hi):
2116         (Hi.execute):
2117         (Restart):
2118         (RollChromiumDEPS):
2119         (RollChromiumDEPS._parse_args):
2120         (RollChromiumDEPS._expand_irc_nickname):
2121         (RollChromiumDEPS.execute):
2122         (Rollout):
2123         (Rollout._extract_revisions):
2124         (Rollout.execute):
2125         (Sheriffs):
2126         (Sheriffs.execute):
2127         (Whois):
2128         (Whois.execute):
2129         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2130         (IRCBotTest.test_help):
2131
2132 2013-01-15  Enrica Casucci  <enrica@apple.com>
2133
2134         Add a new set of WebKit2 APIs for text search and
2135         search results management.
2136         https://bugs.webkit.org/show_bug.cgi?id=106834.
2137         <rdar://problem/12597159>
2138
2139         Added new test for the new WebKit2 API for
2140         text search.
2141         
2142         Reviewed by Simon Fraser.
2143
2144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2145         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
2146
2147 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2148
2149         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2150         https://bugs.webkit.org/show_bug.cgi?id=106904
2151
2152         Reverting 139794. It broke the build. It appears that a header file,
2153         WebTextDirection.h, was left out.
2154
2155         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2156         (DRTTestRunner::DRTTestRunner):
2157         (DRTTestRunner::reset):
2158         * DumpRenderTree/chromium/DRTTestRunner.h:
2159         (DRTTestRunner::setTitleTextDirection):
2160         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2161         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2162         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2163         (WebTestRunner::TestRunner::TestRunner):
2164         (WebTestRunner::TestRunner::reset):
2165         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2166         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2167         (TestRunner):
2168         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2169         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2170         * DumpRenderTree/chromium/WebViewHost.cpp:
2171         (WebViewHost::didReceiveTitle):
2172
2173 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2174
2175         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2176         https://bugs.webkit.org/show_bug.cgi?id=106904
2177
2178         Reviewed by Adam Barth.
2179
2180         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2181         (DRTTestRunner::DRTTestRunner):
2182         (DRTTestRunner::notifyDone):
2183         (DRTTestRunner::reset):
2184         * DumpRenderTree/chromium/DRTTestRunner.h:
2185         (DRTTestRunner):
2186         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2187         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2188         (WebTestRunner::WebTestDelegate::setFocus):
2189         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2190         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2191         (WebTestRunner::WebTestDelegate::setLocale):
2192         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2193         (WebTestRunner::TestRunner::TestRunner):
2194         (WebTestRunner::TestRunner::reset):
2195         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2196         (WebTestRunner):
2197         (WebTestRunner::TestRunner::setWindowIsKey):
2198         (WebTestRunner::TestRunner::pathToLocalResource):
2199         (WebTestRunner::TestRunner::setBackingScaleFactor):
2200         (WebTestRunner::TestRunner::setPOSIXLocale):
2201         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2202         (WebTestRunner::TestRunner::taskList):
2203         (TestRunner):
2204         * DumpRenderTree/chromium/WebViewHost.cpp:
2205         (WebViewHost::setDeviceScaleFactor):
2206         (WebViewHost::setFocus):
2207         (WebViewHost::setAcceptAllCookies):
2208         (WebViewHost::pathToLocalResource):
2209         (WebViewHost::setLocale):
2210         * DumpRenderTree/chromium/WebViewHost.h:
2211         (WebViewHost):
2212
2213 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2214
2215         Tests with WontFix expectation are (indirectly) skipped
2216         https://bugs.webkit.org/show_bug.cgi?id=105860
2217
2218         Reviewed by Dirk Pranke.
2219
2220         Only skip the WontFix expectation if there are no other layout test
2221         expectations (like Failure, ImageOnlyFailure) listed for the test.
2222         This makes it possible to run an expected failure for which there
2223         is no reason or interest to fix. There are some ports that would like
2224         to exercise this behavior as well as specific test cases that should use
2225         such expectations.
2226
2227         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2228         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2229         WONTFIX test if there are no expectations listed. The warning is adjusted
2230         to reflect the new behavior.
2231         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2232         and adjust test cases for these changes.
2233         (ExpectationSyntaxTests.test_wontfix):
2234         (SemanticTests.test_skip_and_wontfix):
2235
2236 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2237
2238         [chromium] add title text direction attribute to TestRunner
2239         https://bugs.webkit.org/show_bug.cgi?id=106907
2240
2241         Reviewed by Adam Barth.
2242
2243         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2244         (DRTTestRunner::DRTTestRunner):
2245         (DRTTestRunner::reset):
2246         * DumpRenderTree/chromium/DRTTestRunner.h:
2247         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2248         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2249         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2250         (WebTestRunner::TestRunner::TestRunner):
2251         (WebTestRunner::TestRunner::reset):
2252         (WebTestRunner::TestRunner::setTitleTextDirection):
2253         (WebTestRunner):
2254         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2255         (TestRunner):
2256         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2257         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2258         * DumpRenderTree/chromium/WebViewHost.cpp:
2259         (WebViewHost::didReceiveTitle):
2260
2261 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2262
2263         nrwt: change the default # of locked shards on chromium_win to 1
2264         https://bugs.webkit.org/show_bug.cgi?id=106938
2265
2266         Reviewed by Eric Seidel.
2267
2268         It looks like LigHTTPd might be buggy or unstable if we are
2269         running multiple http tests in parallel; see
2270         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2271         context as well. This change will stop running http tests in parallel
2272         and we can see if this fixes things.
2273
2274         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2275         (ChromiumWinPort.default_max_locked_shards):
2276         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2277         (ChromiumWinTest.test_path_to_image_diff):
2278         (ChromiumWinTest):
2279         (ChromiumWinTest.test_default_max_locked_shards):
2280
2281 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2282
2283         [chromium] move WebDatabase related methods to TestRunner library
2284         https://bugs.webkit.org/show_bug.cgi?id=106905
2285
2286         Reviewed by Adam Barth.
2287
2288         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2289         (DRTTestRunner::DRTTestRunner):
2290         (DRTTestRunner::reset):
2291         * DumpRenderTree/chromium/DRTTestRunner.h:
2292         (DRTTestRunner):
2293         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2294         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2295         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2296         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2297         (WebTestRunner::TestRunner::TestRunner):
2298         (WebTestRunner::TestRunner::reset):
2299         (WebTestRunner::TestRunner::clearAllDatabases):
2300         (WebTestRunner):
2301         (WebTestRunner::TestRunner::setDatabaseQuota):
2302         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2303         (TestRunner):
2304         * DumpRenderTree/chromium/WebViewHost.cpp:
2305         (WebViewHost::clearAllDatabases):
2306         (WebViewHost::setDatabaseQuota):
2307         * DumpRenderTree/chromium/WebViewHost.h:
2308         (WebViewHost):
2309
2310 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2311
2312         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2313         functionality match the name.
2314         https://bugs.webkit.org/show_bug.cgi?id=106870
2315
2316         Reviewed by Adam Barth.
2317
2318         * Scripts/webkitpy/tool/commands/download.py:
2319         (Clean):
2320         (Update):
2321         (Build):
2322         (BuildAndTest):
2323         (CheckStyle):
2324         (BuildAttachment):
2325         (BuildAndTestAttachment):
2326         (AbstractPatchApplyingCommand):
2327         (ApplyWatchList):
2328         (AbstractPatchLandingCommand):
2329         (CreateRollout):
2330         * Scripts/webkitpy/tool/steps/__init__.py:
2331         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2332         (CleanWorkingDirectory.options):
2333         (CleanWorkingDirectory.run):
2334         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2335         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2336         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2337
2338 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2339
2340         [Autotools] Add support for WebKit2-only builds
2341         https://bugs.webkit.org/show_bug.cgi?id=106889
2342
2343         Reviewed by Gustavo Noronha Silva.
2344
2345         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2346         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2347         building the GTK port through build-webkit.
2348         * Scripts/webkitdirs.pm:
2349         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2350         arguments when not building WebKit1.
2351         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2352         through the Autotools build system.
2353
2354 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2355
2356         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2357         https://bugs.webkit.org/show_bug.cgi?id=106197
2358
2359         Reviewed by Martin Robinson.
2360
2361         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2362         features. Enable them on GTK, meaning they will be enabled in development builds
2363         (i.e. when building with build-webkit).
2364
2365 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2366
2367         [GTK] Enable CSS Image Resolution feature
2368         https://bugs.webkit.org/show_bug.cgi?id=99038
2369
2370         Reviewed by Gustavo Noronha Silva.
2371
2372         Enable the CSS Image Resolution feature for the development
2373         builds of the GTK port.
2374
2375         * Scripts/webkitperl/FeatureList.pm:
2376
2377 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2378
2379         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2380         https://bugs.webkit.org/show_bug.cgi?id=106579
2381
2382         Reviewed by Gustavo Noronha Silva.
2383
2384         The --enable-unstable-features flag is not required to be passed anymore
2385         to the configure script as it was removed in r138252.
2386
2387         * Scripts/webkitdirs.pm:
2388         (buildAutotoolsProject):
2389
2390 2013-01-15  Tony Chang  <tony@chromium.org>
2391
2392         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2393
2394         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2395         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2396         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2397         (TestHttpServer.test_win32_start_and_stop):
2398
2399 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2400
2401         Unreviewed. Adding Michael Pruett as contributor.
2402
2403         * Scripts/webkitpy/common/config/committers.py:
2404
2405 2013-01-15  Victor Carbune  <victor@rosedu.org>
2406
2407         Unreviewed. Update my email addresses.
2408
2409         * Scripts/webkitpy/common/config/committers.py:
2410
2411 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2412
2413         [GTK] Waiting on the gdb process will lead to deadlock
2414         https://bugs.webkit.org/show_bug.cgi?id=106906
2415
2416         Reviewed by Philippe Normand.
2417
2418         Use communicate() rather than wait() on the Popen object that's running the gdb
2419         command. This avoids the deadlock that occurs on the GTK builders.
2420
2421         * Scripts/webkitpy/layout_tests/port/gtk.py:
2422         (GtkPort._get_gdb_output):
2423
2424 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2425
2426         [GTK] Limit the number of frames printed out when backtracing with gdb
2427         https://bugs.webkit.org/show_bug.cgi?id=106901
2428
2429         Reviewed by Philippe Normand.
2430
2431         Printing an unlimited number of frames when dumping the gdb backtracing
2432         output can cause timeouts in the builders. This patch limits the number
2433         of frames that are printed out to 1024.
2434
2435         * Scripts/webkitpy/layout_tests/port/gtk.py:
2436         (GtkPort._get_gdb_output):
2437
2438 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2439
2440         [Qt] Fix ImageDiff's image format conversion
2441         https://bugs.webkit.org/show_bug.cgi?id=106880
2442
2443         Reviewed by Csaba Osztrogonác.
2444
2445         Besides actually doing the conversion this also silences the suspicious warning:
2446         "ignoring return value of function declared with warn_unused_result attribute".
2447
2448         * ImageDiff/qt/ImageDiff.cpp:
2449         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2450         copy of the image in the given format and does not alter the image itself.
2451
2452 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2453
2454         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2455         https://bugs.webkit.org/show_bug.cgi?id=106823
2456
2457         Reviewed by Darin Fisher.
2458
2459         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2460         (DRTTestRunner::DRTTestRunner):
2461         (DRTTestRunner::reset):
2462         * DumpRenderTree/chromium/DRTTestRunner.h:
2463         (DRTTestRunner):
2464         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2465         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2466         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2467         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2468         (WebTestRunner::WebTestRunner::testRepaint):
2469         (WebTestRunner::WebTestRunner::sweepHorizontally):
2470         (WebTestRunner::WebTestRunner::isPrinting):
2471         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2472         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2473         (WebTestRunner::TestRunner::TestRunner):
2474         (WebTestRunner::TestRunner::reset):
2475         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2476         (WebTestRunner):
2477         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2478         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2479         (WebTestRunner::TestRunner::testRepaint):
2480         (WebTestRunner::TestRunner::sweepHorizontally):
2481         (WebTestRunner::TestRunner::isPrinting):
2482         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2483         (WebTestRunner::TestRunner::dumpBackForwardList):
2484         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2485         (WebTestRunner::TestRunner::dumpSelectionRect):
2486         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2487         (WebTestRunner::TestRunner::setPrinting):
2488         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2489         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2490         (TestRunner):
2491
2492 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2493
2494         nrwt: stub out show_results_html for mock ports
2495         https://bugs.webkit.org/show_bug.cgi?id=106848
2496
2497         Reviewed by Ojan Vafai.
2498
2499         We were accidentally using the underlying ports'
2500         show_results_html_file() implementation, which would, unsurprisingly,
2501         fail in many cases (e.g., running mock-efl on the mac).
2502
2503         No test added since we don't generally add tests for the mock
2504         implementation.
2505
2506         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2507         (MockDRTPort.show_results_html_file):
2508
2509 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2510
2511         Changing clean_working_directory/clean_local_commits and related
2512         functions to have consistent naming.
2513
2514         https://bugs.webkit.org/show_bug.cgi?id=104198
2515
2516         Reviewed by Adam Barth.
2517
2518         * Scripts/webkitpy/common/checkout/scm/git.py:
2519         * Scripts/webkitpy/common/checkout/scm/scm.py:
2520         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2521         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2522         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2523         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2524
2525 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2526
2527         Fix EWS GCE build scripts to detect which zone is available
2528         https://bugs.webkit.org/show_bug.cgi?id=106524
2529
2530         Reviewed by Adam Barth.
2531
2532         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2533         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2534         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2535         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2536
2537 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2538
2539         Adding an error string to AmbiguousCommitError.
2540         https://bugs.webkit.org/show_bug.cgi?id=106846
2541
2542         Reviewed by Adam Barth.
2543
2544         * Scripts/webkitpy/common/checkout/scm/git.py:
2545         (AmbiguousCommitError.__init__):
2546
2547 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2548
2549         kill whole lighttpd process tree for chromium win
2550         https://bugs.webkit.org/show_bug.cgi?id=106838
2551
2552         Reviewed by Tony Chang.
2553
2554         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
2555         I think a test is causing a httpd server child process to wedge and
2556         killing the parent httpd server process isn't sufficient to ensure
2557         that the children are also killed.
2558
2559         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2560         (Lighttpd._check_and_kill):
2561         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2562         (TestHttpServer.test_start_cmd):
2563         (TestHttpServer):
2564         (TestHttpServer.test_win32_start_and_stop):
2565         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2566         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2567         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2568
2569 2013-01-14  Nico Weber  <thakis@chromium.org>
2570
2571         [chromium] Enable `update-webkit --chromium --ninja` on windows
2572         https://bugs.webkit.org/show_bug.cgi?id=106836
2573
2574         Reviewed by Eric Seidel.
2575
2576         After running this, build-webkit --chromium will use ninja to build.
2577         Apparently there are some minor issues with that still, so it's
2578         not quite ready for use yet.
2579
2580         * Scripts/webkitdirs.pm:
2581         (determineIsChromiumNinja):
2582         (buildChromium):
2583
2584 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2585
2586         nrwt: use the same search path for baselines and TestExpectations on apple mac
2587         https://bugs.webkit.org/show_bug.cgi?id=105599
2588
2589         Reviewed by Ryosuke Niwa.
2590
2591         Bug 105583 revealed some confusion due to the fact that the Apple
2592         Mac port used a different list of directories to search for baselines
2593         and TestExpectations files (actually, pretty much every port does).
2594
2595         It seems like a good idea to use the same list for both by default, but
2596         making this happen will affect every port in slightly different ways, so
2597         we'll try this on the Apple Mac port first.
2598
2599         Note that the effective changes for this are that:
2600         1) The apple mac port will look in platform/wk2 for baselines where
2601         it didn't before (it will look after looking in mac-wk2 but before
2602         the non-wk2 dirs)
2603         2) The apple mac-snowleopard port will use the expectations in
2604         mac-lion as well as the expectations in mac-snowleopard, although
2605         I'm not even sure if mac-snowleopard is still supported ...
2606
2607         * Scripts/webkitpy/layout_tests/port/mac.py:
2608         (MacPort.default_baseline_search_path):
2609         (MacPort.expectations_files):
2610         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2611         (test_baseline_search_path):
2612
2613 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2614
2615         AX: Need to implement ColorWellRole
2616         https://bugs.webkit.org/show_bug.cgi?id=106756
2617
2618         Reviewed by Chris Fleizach.
2619
2620         Returns a string representation of the value of a color
2621         when the role is Color Well, to make it easy to write layout
2622         tests for color controls.
2623
2624         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2625
2626 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2627
2628         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2629         https://bugs.webkit.org/show_bug.cgi?id=106682
2630
2631         Reviewed by Chris Fleizach.
2632
2633         Modify Chromium's DRT implementation of intValue to return a
2634         different value depending on the role.
2635
2636         There are actually platform-specific differences in what should
2637         be returned in the "value" of an object, so Chromium normally keeps
2638         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2639         but this is a fine simplification to make cross-platform tests easier.
2640
2641         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2642         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2643
2644 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2645
2646         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2647         https://bugs.webkit.org/show_bug.cgi?id=106785
2648
2649         Reviewed by Adam Barth.
2650
2651         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2652         (DRTTestRunner::DRTTestRunner):
2653         (DRTTestRunner::reset):
2654         * DumpRenderTree/chromium/DRTTestRunner.h:
2655         (DRTTestRunner):
2656         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2657         (WebTestProxyBase):
2658         (WebTestRunner::WebTestProxy::setStatusText):
2659         (WebTestRunner::WebTestProxy::didStopLoading):
2660         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2661         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2662         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2663         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2664         (WebTestRunner::TestRunner::TestRunner):
2665         (WebTestRunner::TestRunner::reset):
2666         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2667         (WebTestRunner):
2668         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2669         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2670         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2671         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2672         (TestRunner):
2673         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2674         (WebTestRunner::WebTestProxyBase::setStatusText):
2675         (WebTestRunner):
2676         (WebTestRunner::WebTestProxyBase::didStopLoading):
2677         * DumpRenderTree/chromium/WebViewHost.cpp:
2678         (WebViewHost::didStopLoading):
2679         * DumpRenderTree/chromium/WebViewHost.h:
2680         (WebViewHost):
2681
2682 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2683
2684         Web Inspector: devtools front-end doesn't have focus in TestShell
2685         https://bugs.webkit.org/show_bug.cgi?id=106778
2686
2687         Reviewed by Pavel Feldman.
2688
2689         Focus devTools window after loadURL method.
2690
2691         * DumpRenderTree/chromium/TestShell.cpp:
2692         (TestShell::runFileTest):
2693
2694 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2695
2696         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
2697         https://bugs.webkit.org/show_bug.cgi?id=106573
2698
2699         Reviewed by Philippe Normand.
2700
2701         Similarly to what's been described in bug 106569, we're building
2702         from release tarballs, so there's no reason to regenerate the
2703         autoconf-related stuff with autogen.sh, especially since we might
2704         run into trouble with automake 1.13 and deprecated macros.
2705
2706         * efl/jhbuild.modules:
2707
2708 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2709
2710         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2711         https://bugs.webkit.org/show_bug.cgi?id=104909
2712
2713         Reviewed by Simon Hausmann.
2714
2715         To be able to build redistribuable binary packages, Qt's configure switches
2716         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2717         dynamically link to optional system libraries.
2718         QtWebKit is doing its own configure checks for those libraries, thus adding a
2719         runtime dependency that might not be fulfilled if the packager's machine had
2720         those libraries while the user's machine won't.
2721
2722         Since in most cases where WebKit will want to use those system libraries, Qt will
2723         also be using them, remove these configure tests from WebKit.
2724
2725         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2726         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2727         * qmake/config.tests/libpng/libpng.cpp: Removed.
2728         * qmake/config.tests/libpng/libpng.pro: Removed.
2729         * qmake/mkspecs/features/features.prf:
2730
2731 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2732
2733         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2734         https://bugs.webkit.org/show_bug.cgi?id=106574
2735
2736         Reviewed by Laszlo Gombos.
2737
2738         Rely on a more recent stable release, which includes support for
2739         Lua 5.2 in Edje and other assorted minor fixes.
2740
2741         While here, also use the "configure" script to build the libraries
2742         instead of relying on autogen.sh, which is not really needed with
2743         a release tarball and may have problems with automake 1.13.
2744
2745         * efl/jhbuild.modules:
2746
2747 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2748
2749         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2750         https://bugs.webkit.org/show_bug.cgi?id=106650
2751
2752         Reviewed by Pavel Feldman.
2753
2754         Add separated m_devToolsTestInterfaces object to testShell which is
2755         bind to devTools webview.
2756
2757         * DumpRenderTree/chromium/TestShell.cpp:
2758         (TestShell::initialize):
2759         (TestShell::createMainWindow):
2760         (TestShell::~TestShell):
2761         (TestShell::showDevTools):
2762         (TestShell::resetTestController):
2763         (TestShell::bindJSObjectsToWindow):
2764         (TestShell::createNewWindow):
2765         * DumpRenderTree/chromium/TestShell.h:
2766         (TestShell):
2767
2768 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2769
2770         Sheriffbot command aliases need test cases
2771         https://bugs.webkit.org/show_bug.cgi?id=106754
2772
2773         Reviewed by Eric Seidel.
2774
2775         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2776         (SheriffBotTest.test_command_aliases):
2777
2778 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2779
2780         Allow users to misspell the "sheriffs" command in sheriffbot
2781         https://bugs.webkit.org/show_bug.cgi?id=106628
2782
2783         Reviewed by Steve Block.
2784
2785         * Scripts/webkitpy/tool/bot/irc_command.py:
2786
2787 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2788
2789         Make "gardeners" an alias for "sheriffs" in sherrifbot
2790         https://bugs.webkit.org/show_bug.cgi?id=106627
2791
2792         Reviewed by Eric Seidel.
2793
2794         * Scripts/webkitpy/tool/bot/irc_command.py:
2795
2796 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2797
2798         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2799         https://bugs.webkit.org/show_bug.cgi?id=105380
2800
2801         Reviewed by Eric Seidel.
2802
2803         Fix a regression introduced in r137692 where we were double-encoding
2804         the arguments to popen(); this was only an issue on windows, where
2805         we would try to encode something to mbcs, then try to encode it
2806         to unicode as if the input as ascii.
2807
2808         * Scripts/webkitpy/common/system/executive.py:
2809         (Executive.run_command):
2810
2811 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2812
2813         State who told sheriffbot to roll the Chromium deps and to what revision
2814         https://bugs.webkit.org/show_bug.cgi?id=106626
2815
2816         Reviewed by Eric Seidel.
2817
2818         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2819
2820         * Scripts/webkitpy/tool/bot/irc_command.py:
2821         (RollChromiumDEPS._expand_irc_nickname):
2822         (RollChromiumDEPS.execute):
2823         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2824         (IRCCommandTest.test_roll_chromium_deps):
2825         * Scripts/webkitpy/tool/bot/sheriff.py:
2826         (Sheriff.post_chromium_deps_roll):
2827         * Scripts/webkitpy/tool/commands/roll.py:
2828         (RollChromiumDEPS._prepare_state):
2829         (PostChromiumDEPSRoll):
2830         (PostChromiumDEPSRoll._prepare_state):
2831         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2832         (PostRollCommandsTest.test_prepare_state):
2833         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2834         (PrepareChangeLogForDEPSRoll.run):
2835
2836 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2837
2838         Add Alan Cutter as contributor
2839         https://bugs.webkit.org/show_bug.cgi?id=106747
2840
2841         Reviewed by Eric Seidel.
2842
2843         * Scripts/webkitpy/common/config/committers.py:
2844
2845 2013-01-13  Jonathan Liu  <net147@gmail.com>
2846
2847         Fix CONFIG missing link_pkgconfig on Windows
2848         https://bugs.webkit.org/show_bug.cgi?id=106647
2849
2850         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2851         properly on Windows because they are added to PKGCONFIG but
2852         CONFIG does not contain link_pkgconfig.
2853
2854         This is because link_pkgconfig is added in unix/default_pre.prf
2855         which is only used for UNIX platforms. To fix this, move it to
2856         the general default_pre.prf.
2857
2858         Reviewed by Simon Hausmann.
2859
2860         * qmake/mkspecs/features/default_pre.prf:
2861         * qmake/mkspecs/features/unix/default_pre.prf:
2862
2863 2013-01-12  Nico Weber  <thakis@chromium.org>
2864
2865         nrwt/chromium: Don't prefer chromium over webkit build directories
2866         https://bugs.webkit.org/show_bug.cgi?id=105597
2867
2868         Reviewed by Dirk Pranke.
2869
2870         Rely on the new timestamp logic instead. Requested by dpranke in
2871         https://bugs.webkit.org/show_bug.cgi?id=105498
2872
2873         * Scripts/webkitpy/layout_tests/port/chromium.py:
2874         (ChromiumPort._static_build_path):
2875         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2876         (ChromiumLinuxPortTest.test_build_path):
2877         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2878         (ChromiumMacPortTest.test_build_path):
2879         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2880         (ChromiumWinTest.test_build_path):
2881
2882 2013-01-12  Nico Weber  <thakis@chromium.org>
2883
2884         Use ninja by default on Linux for build-webkit --chromium, bot edition
2885         https://bugs.webkit.org/show_bug.cgi?id=104434
2886
2887         Reviewed by Eric Seidel.
2888
2889         r139557 changed update-webkit to pick ninja by default on linux, but
2890         the bots run update-webkit-chromium directly so they didn't see this.
2891         Move the default for ninja into update-webkit-chromium so that it's
2892         picked up by the bots, and let update-webkit forward non-default
2893         options to there.
2894
2895         This way, the default is in one place only and both developers (who
2896         usually use update-webkit which then shells out to
2897         updat-webkit-chromium) and bots (which use update-webkit-chromium
2898         directly) see the same behavior.
2899
2900         * Scripts/update-webkit:
2901         * Scripts/update-webkit-chromium:
2902
2903 2013-01-12  Nico Weber  <thakis@chromium.org>
2904
2905         Make ninja the default build system on Linux for build-webkit --chromium
2906         https://bugs.webkit.org/show_bug.cgi?id=104434
2907
2908         Reviewed by Eric Seidel.
2909
2910         * Scripts/update-webkit:
2911
2912 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2913
2914         Migrate the remaining bots in EC2 to Google Compute Engine
2915         https://bugs.webkit.org/show_bug.cgi?id=106005
2916
2917         Reviewed by Eric Seidel.
2918
2919         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2920
2921         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2922         * EWSTools/boot.sh:
2923         * EWSTools/build-repo.sh:
2924         * EWSTools/start-queue.sh:
2925
2926 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2927
2928         [chromium] move inspector related methods to TestRunner library
2929         https://bugs.webkit.org/show_bug.cgi?id=106654
2930
2931         Reviewed by Adam Barth.
2932
2933         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2934         (DRTTestRunner::DRTTestRunner):
2935         * DumpRenderTree/chromium/DRTTestRunner.h:
2936         (DRTTestRunner):
2937         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2938         (WebTestRunner::WebTestDelegate::showDevTools):
2939         (WebTestRunner::WebTestDelegate::closeDevTools):
2940         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2941         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2942         (WebTestRunner::TestRunner::TestRunner):
2943         (WebTestRunner::TestRunner::showWebInspector):
2944         (WebTestRunner):
2945         (WebTestRunner::TestRunner::closeWebInspector):
2946         (WebTestRunner::TestRunner::evaluateInWebInspector):
2947         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2948         (TestRunner):
2949         * DumpRenderTree/chromium/WebViewHost.cpp:
2950         (WebViewHost::showDevTools):
2951         (WebViewHost::closeDevTools):
2952         (WebViewHost::evaluateInWebInspector):
2953         * DumpRenderTree/chromium/WebViewHost.h:
2954         (WebViewHost):
2955
2956 2013-01-11  Julie Parent  <jparent@chromium.org>
2957
2958         Builder should not be a valid parameter for stats dashboard
2959         https://bugs.webkit.org/show_bug.cgi?id=106698
2960
2961         Reviewed by Dirk Pranke.
2962         
2963         Since builder is a dashboard specific parameter, dashboard_base
2964         should not be handling it in handleValidHashParameterWrapper, rather,
2965         each specific dashboard should in its handleValidHashParameter function.
2966     
2967         Note that the FIXME in dashboard_base about this was actually wrong -
2968         we don't want to move it to g_crossDashboardState, because it isn't
2969         actually cross dashboard state.
2970         
2971         In fact, flakiness and treemap have the code in 
2972         handleValidHashParameter, but it is currently dead code because 
2973         dashboard_base gets to it first.
2974         
2975         Added the proper handling to timeline_explorer, since builder is
2976         valid there.
2977
2978         * TestResultServer/static-dashboards/dashboard_base.js:
2979         * TestResultServer/static-dashboards/timeline_explorer.html:
2980
2981 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2982
2983         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2984         https://bugs.webkit.org/show_bug.cgi?id=106688
2985
2986         Reviewed by Eric Seidel.
2987
2988         Update the regular expression used to strip the garbage at the beginning.
2989
2990         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2991         (RunWebKitTests.nrwt_log_message_regexp):
2992
2993 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2994
2995         TestRunner leaks when running tests
2996         https://bugs.webkit.org/show_bug.cgi?id=106683
2997
2998         Reviewed by Simon Fraser.
2999
3000         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
3001         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
3002         tests.
3003
3004         * DumpRenderTree/TestRunner.cpp:
3005         (TestRunner::makeWindowObject):
3006
3007 2013-01-11  Julie Parent  <jparent@chromium.org>
3008
3009         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
3010         https://bugs.webkit.org/show_bug.cgi?id=106247
3011
3012         Old code nulled out the loader instance when it completed loading and
3013         then later used the fact that it was null to determine if it had loaded
3014         or not.  This is not only unintuitive, but it also prevents using the
3015         loader object later on.
3016         
3017         Added new method, used it, added unit test for it.
3018         
3019         Reviewed by Dirk Pranke.
3020
3021         * TestResultServer/static-dashboards/dashboard_base.js:
3022         (resourceLoadingComplete):
3023         (handleLocationChange):
3024         * TestResultServer/static-dashboards/loader.js:
3025         (.):
3026         * TestResultServer/static-dashboards/loader_unittests.js:
3027
3028 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3029
3030         Try CRLF to LF change in r139407 again.
3031
3032         * BuildSlaveSupport/delete-stale-build-files:
3033         (main):
3034         (webkitBuildDirectory):
3035         * BuildSlaveSupport/kill-old-processes:
3036         (main):
3037
3038 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3039
3040         [GTK] Disable the unit tests timeout when running from make check
3041         https://bugs.webkit.org/show_bug.cgi?id=106670
3042
3043         Reviewed by Philippe Normand.
3044
3045         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
3046
3047 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3048
3049         Yet another unreviewed fix after r139431.
3050
3051         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
3052         the correct order.
3053
3054 2013-01-11  Dan Carney  <dcarney@google.com>
3055
3056         [chromium] move some whitespace and resize related methods to TestRunner library
3057         https://bugs.webkit.org/show_bug.cgi?id=106655
3058
3059         Reviewed by Jochen Eisinger.
3060
3061         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3062         (DRTTestRunner::DRTTestRunner):
3063         * DumpRenderTree/chromium/DRTTestRunner.h:
3064         (DRTTestRunner):
3065         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3066         (WebKit):
3067         (WebTestRunner::WebTestDelegate::setClientWindowRect):
3068         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
3069         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
3070         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3071         (WebTestRunner::TestRunner::TestRunner):
3072         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
3073         (WebTestRunner):
3074         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
3075         (WebTestRunner::TestRunner::enableAutoResizeMode):
3076         (WebTestRunner::TestRunner::disableAutoResizeMode):
3077         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3078         (TestRunner):
3079         * DumpRenderTree/chromium/WebViewHost.cpp:
3080         (WebViewHost::setClientWindowRect):
3081         * DumpRenderTree/chromium/WebViewHost.h:
3082         (WebViewHost):
3083
3084 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3085
3086         Unreviewed. Update my e-mail addresses.
3087
3088         * Scripts/webkitpy/common/config/committers.py:
3089
3090 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3091
3092         Another unreviewed fix after r139431.
3093
3094         In a way, this is also a generic bug fix, since previously isEfl()
3095         would fail when called from run-efl-tests and we thus did not use
3096         jhbuild to run our tests. This now resulted in us calling
3097         "jhbuild-wrapper run" without specifying a platform.
3098
3099         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
3100         to work.
3101
3102 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3103
3104         [Qt][WK1] Web Audio support
3105         https://bugs.webkit.org/show_bug.cgi?id=106651
3106
3107         Reviewed by Jocelyn Turcotte.
3108
3109         Implements support for dumping audio data in DumpRenderTree.
3110
3111         Adds WebAudio to toggleable features in QtTestBrowser.
3112
3113         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
3114         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
3115
3116         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3117         (WebCore::DumpRenderTree::dump):
3118         * DumpRenderTree/qt/TestRunnerQt.cpp:
3119         (TestRunner::reset):
3120         (TestRunner::overridePreference):
3121         (TestRunner::setAudioData):
3122         * DumpRenderTree/qt/TestRunnerQt.h:
3123         (TestRunner::shouldDumpAsAudio):
3124         (TestRunner::audioData):
3125         (TestRunner):
3126         * QtTestBrowser/launcherwindow.cpp:
3127         (LauncherWindow::applyPrefs):
3128         (LauncherWindow::createChrome):
3129         (LauncherWindow::toggleWebAudio):
3130         * QtTestBrowser/launcherwindow.h:
3131         (WindowOptions::WindowOptions):
3132         (WindowOptions):
3133         (LauncherWindow):
3134         * qmake/mkspecs/features/features.prf:
3135         * qmake/mkspecs/features/features.pri:
3136
3137 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3138
3139         Unreviewed jhbuild-related fix after r139431.
3140
3141         * Scripts/webkitpy/layout_tests/port/efl.py:
3142         (EflPort.__init__): Pass a string to set_option_default(), since
3143         shlex.split() will be called on it later.
3144
3145 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
3146
3147         Unreviewed typo fixes after r139431.
3148
3149         * Scripts/run-javascriptcore-tests:
3150
3151 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3152
3153         [jhbuild] Remove the "run-with-jhbuild" scripts.
3154         https://bugs.webkit.org/show_bug.cgi?id=106572
3155
3156         Reviewed by Martin Robinson.
3157
3158         Both ports which use jhbuild were mostly duplicating the
3159         `run-with-jhbuild' script in their own directories for no clear reason.
3160
3161         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3162         so just start using that directly and get rid of a useless middle man.
3163
3164         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3165         instead.
3166
3167         * Scripts/run-javascriptcore-tests:
3168         * Scripts/run-launcher:
3169         * Scripts/webkitdirs.pm:
3170         (runAutogenForAutotoolsProjectIfNecessary):
3171         (buildAutotoolsProject):
3172         (jhbuildWrapperPrefixIfNeeded):
3173         (generateBuildSystemFromCMakeProject):
3174         (buildCMakeGeneratedProject):
3175         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3176         (run):
3177         * Scripts/webkitpy/layout_tests/port/efl.py:
3178         (EflPort.__init__):
3179         (EflPort._image_diff_command):
3180         * efl/run-with-jhbuild: Removed.
3181         * gtk/run-with-jhbuild: Removed.
3182
3183 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3184
3185         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3186         https://bugs.webkit.org/show_bug.cgi?id=106636
3187
3188         Reviewed by Adam Barth.
3189
3190         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3191
3192         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3193         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3194         * EWSTools/screen-config:
3195         * EWSTools/start-queue.sh:
3196
3197 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3198
3199         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3200         https://bugs.webkit.org/show_bug.cgi?id=106622
3201
3202         Reviewed by Simon Fraser.
3203
3204         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3205         Also escape clang\+\+ correctly in kill-old-processes.
3206
3207         * BuildSlaveSupport/delete-stale-build-files:
3208         * BuildSlaveSupport/kill-old-processes:
3209
3210 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3211
3212         Build fix after r139357. It was missing a comma.
3213
3214         * QueueStatusServer/model/queues.py:
3215         (Queue):
3216
3217 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3218
3219         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3220         https://bugs.webkit.org/show_bug.cgi?id=106420
3221
3222         Reviewed by Eric Seidel.
3223
3224         * Scripts/webkitpy/common/checkout/scm/git.py:
3225         (Git.push_local_commits_to_server):
3226         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3227         * Scripts/webkitpy/common/checkout/scm/svn.py:
3228         (SVNRepository):
3229         (SVNRepository.has_authorization_for_realm):
3230
3231 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3232
3233         [EFL][jhbuild] Use tarballs for gstreamer instead of git
3234         https://bugs.webkit.org/show_bug.cgi?id=106552
3235
3236         Reviewed by Laszlo Gombos.
3237
3238         Use tarballs for gstreamer instead of git in EFL's jhbuild
3239         to work around intermittent network issues on our build
3240         bots. Tarballs are fully cached and require no network
3241         operation if their checksum matches.
3242
3243         * efl/jhbuild.modules:
3244
3245 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3246
3247         Add Mac WK2 EWS bots
3248         https://bugs.webkit.org/show_bug.cgi?id=106590
3249
3250         Reviewed by Adam Barth.
3251
3252         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
3253         Also add a deprecated MacWK2Port class.
3254
3255         * QueueStatusServer/model/queues.py:
3256         (Queue):
3257         * Scripts/webkitpy/common/config/ports.py:
3258         (DeprecatedPort.port):
3259         (MacWK2Port):
3260         (MacWK2Port.run_webkit_tests_command):
3261         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3262         (MacEWS):
3263         (MacWK2EWS):
3264         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3265         (_test_ewses):
3266
3267 2013-01-10  Dan Carney  <dcarney@google.com>
3268
3269         [chromium] move webpermissionclient related methods to TestRunner library
3270         https://bugs.webkit.org/show_bug.cgi?id=106548
3271
3272         Reviewed by Jochen Eisinger.
3273
3274         * DumpRenderTree/DumpRenderTree.gypi:
3275         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3276         (DRTTestRunner::DRTTestRunner):
3277         (DRTTestRunner::reset):
3278         * DumpRenderTree/chromium/DRTTestRunner.h:
3279         (DRTTestRunner):
3280         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3281         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
3282         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3283         (WebKit):
3284         (WebTestRunner::WebTestRunner::webPermissions):
3285         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3286         (WebTestRunner::TestRunner::TestRunner):
3287         (WebTestRunner::TestRunner::setDelegate):
3288         (WebTestRunner):
3289         (WebTestRunner::TestRunner::reset):
3290         (WebTestRunner::TestRunner::webPermissions):
3291         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
3292         (WebTestRunner::TestRunner::setImagesAllowed):
3293         (WebTestRunner::TestRunner::setScriptsAllowed):
3294         (WebTestRunner::TestRunner::setStorageAllowed):
3295         (WebTestRunner::TestRunner::setPluginsAllowed):
3296         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
3297         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
3298         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3299         (WebTestRunner):
3300         (TestRunner):
3301         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
3302         (WebTestRunner):
3303         (WebTestRunner::WebPermissions::WebPermissions):
3304         (WebTestRunner::WebPermissions::~WebPermissions):
3305         (WebTestRunner::WebPermissions::allowImage):
3306         (WebTestRunner::WebPermissions::allowScriptFromSource):
3307         (WebTestRunner::WebPermissions::allowStorage):
3308         (WebTestRunner::WebPermissions::allowPlugins):
3309         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
3310         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
3311         (WebTestRunner::WebPermissions::setImagesAllowed):
3312         (WebTestRunner::WebPermissions::setScriptsAllowed):
3313         (WebTestRunner::WebPermissions::setStorageAllowed):
3314         (WebTestRunner::WebPermissions::setPluginsAllowed):
3315         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
3316         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
3317         (WebTestRunner::WebPermissions::setDelegate):
3318         (WebTestRunner::WebPermissions::setDumpCallbacks):
3319         (WebTestRunner::WebPermissions::reset):
3320         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
3321         (WebTestRunner):
3322         (WebPermissions):
3323         * DumpRenderTree/chromium/TestShell.cpp:
3324         (TestShell::initialize):
3325         (TestShell::resetTestController):
3326         (TestShell::createNewWindow):
3327         * DumpRenderTree/chromium/TestShell.h:
3328         (TestShell):
3329         * DumpRenderTree/chromium/WebViewHost.cpp:
3330         (WebViewHost::normalizeLayoutTestURL):
3331         * DumpRenderTree/chromium/WebViewHost.h:
3332         (WebViewHost):
3333
3334 2013-01-10  Alan Cutter  <alancutter@chromium.org>
3335
3336         Split EWS tool cold-boot.sh into modular components
3337         https://bugs.webkit.org/show_bug.cgi?id=106527
3338
3339         Reviewed by Adam Barth.
3340
3341         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
3342         Updated GCE bot build scripts to match.
3343         Unable to test scripts directly as they depend on being in the repository to work!
3344
3345         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3346         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3347         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3348         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
3349         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
3350
3351 2013-01-10  Julie Parent  <jparent@chromium.org>
3352
3353         Dashboard Cleanup: Do not generate the page if we are about to reload.
3354         https://bugs.webkit.org/show_bug.cgi?id=106584
3355
3356         Reviewed by Dirk Pranke.
3357
3358         Move the logic to determine if we should generate the page into
3359         parseParameters() since that is where we have the knowledge to
3360         determine it, and return that value to handleLocationChange, 
3361         rather than passing the changed parameters back to handleLocationChange
3362         and having it make the decision.
3363         
3364         This is logically equivalent, save one case: when we are about to do
3365         a reload, we know that there is no reason to generate the page.  Old
3366         code was causing an extra page generation in this case.
3367         
3368         * TestResultServer/static-dashboards/dashboard_base.js:
3369         (parseParameters):
3370         (handleLocationChange):
3371
3372 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3373
3374         [jhbuild] Use the "configure" script to build glib
3375         https://bugs.webkit.org/show_bug.cgi?id=106569
3376
3377         Reviewed by Martin Robinson.
3378
3379         So far both EFL and GTK have been using autogen.sh to build glib.
3380         While that does work most of the time, it's not really needed since
3381         we are downloading and building stable releases from tarballs.
3382         Additionally, autogen.sh fails to work with automake 1.13 due to the
3383         usage of some macros that have been removed (this has already been
3384         fixed in glib master).
3385
3386         * efl/jhbuild.modules:
3387         * gtk/jhbuild.modules:
3388
3389 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3390
3391         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3392         (Missed a couple)
3393         https://bugs.webkit.org/show_bug.cgi?id=106536
3394
3395         Reviewed by Eric Seidel.
3396
3397         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3398
3399 2013-01-10  Tony Chang  <tony@chromium.org>
3400
3401         Speed up supplemental dependency computation
3402         https://bugs.webkit.org/show_bug.cgi?id=106503
3403
3404         Reviewed by Adam Barth.
3405
3406         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
3407
3408         * WebKitTestRunner/CMakeLists.txt:
3409
3410 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
3411
3412         Remove the ENABLE_ANIMATION_API feature define occurences
3413         https://bugs.webkit.org/show_bug.cgi?id=106544
3414
3415         Reviewed by Simon Fraser.
3416
3417         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
3418         feature define handling still lingers in various build systems and configurations
3419         but is of no use, so it should be removed.
3420
3421         * Scripts/webkitperl/FeatureList.pm:
3422         * qmake/mkspecs/features/features.pri:
3423
3424 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3425
3426         [GTK] Add support for loading web process extensions
3427         https://bugs.webkit.org/show_bug.cgi?id=105631
3428
3429         Reviewed by Gustavo Noronha Silva.
3430
3431         * MiniBrowser/gtk/GNUmakefile.am:
3432         * MiniBrowser/gtk/main.c:
3433         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
3434         bundle lib from build dir.
3435         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
3436         located in WebProcess/InjectedBundle/API/gtk.
3437         * gtk/generate-gtkdoc:
3438         (get_webkit2_options): Scan also files in
3439         WebProcess/InjectedBundle/API/gtk to generate API docs.
3440         (get_webkit2_options.injected_bundle_src_path): Helper function to
3441         build paths in WebProcess/InjectedBundle/API/gtk.
3442
3443 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3444
3445         [EFL][WK2] Writing immediately to created windows (open) fails
3446         https://bugs.webkit.org/show_bug.cgi?id=105276
3447
3448         Reviewed by Kenneth Rohde Christiansen.
3449
3450         Do not reset 'about:blank' url for the new pages in mini browser.
3451
3452         * MiniBrowser/efl/main.c:
3453         (window_create):
3454
3455 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3456
3457         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3458         https://bugs.webkit.org/show_bug.cgi?id=106536
3459
3460         Reviewed by Eric Seidel.
3461
3462         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3463
3464 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3465
3466         Converting to unittest2 so we can use assertItemsEqual, making tests
3467         not dependent on order of items.
3468         https://bugs.webkit.org/show_bug.cgi?id=106532
3469
3470         Before:
3471         Ran 1733 tests in 38.385s
3472         FAILED (failures=1, errors=22)
3473
3474         After:
3475         Ran 1733 tests in 32.298s
3476         FAILED (failures=0, errors=22)
3477
3478         Reviewed by Eric Seidel.
3479
3480         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3481         * Scripts/webkitpy/thirdparty/__init__.py:
3482         (AutoinstallImportHook._install_unittest2):
3483
3484 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3485
3486         [EFL] Add gstreamer 1.0.5 to jhbuild
3487         https://bugs.webkit.org/show_bug.cgi?id=106178
3488
3489         Reviewed by Laszlo Gombos.
3490
3491         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
3492
3493         * efl/jhbuild.modules:
3494
3495 2013-01-09  Alan Cutter  <alancutter@chromium.org>
3496
3497         Updated parameters in GCE build scripts so they now work.
3498         https://bugs.webkit.org/show_bug.cgi?id=106523
3499
3500         Reviewed by Adam Barth.
3501
3502         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3503         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3504         * EWSTools/cold-boot.sh:
3505
3506 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
3507
3508         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
3509         https://bugs.webkit.org/show_bug.cgi?id=106520
3510
3511         Reviewed by James Robinson.
3512
3513         Part of a larger refactoring series. See tracking bug 82948.
3514
3515         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3516         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3517
3518 2013-01-09  Julie Parent  <jparent@chromium.org>
3519
3520         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
3521         https://bugs.webkit.org/show_bug.cgi?id=106514
3522
3523         This is old code, as these can no longer get out of sync.
3524         permmaLinkURLHash is generated from currentState, which is set only
3525         from the location.  The commment about how these can get out of sync
3526         refers to a function that no longer exists.
3527         
3528         Reviewed by Dirk Pranke.
3529
3530         * TestResultServer/static-dashboards/dashboard_base.js:
3531         (handleLocationChange):
3532
3533 2013-01-09  Julie Parent  <jparent@chromium.org>
3534
3535         Dashboard Cleanup: Reload the page as soon as we know we need to.
3536         https://bugs.webkit.org/show_bug.cgi?id=106515
3537
3538         No need to continue parsing all of the data once we know that
3539         we need to do a reload.
3540         
3541         Reviewed by Dirk Pranke.
3542
3543         * TestResultServer/static-dashboards/dashboard_base.js:
3544         (parseParameters):
3545
3546 2013-01-09  Eric Seidel  <eric@webkit.org>
3547
3548         run-perf-tests --chromium-android --profile should show symbols for the kernel
3549         https://bugs.webkit.org/show_bug.cgi?id=106498
3550
3551         Reviewed by Adam Barth.
3552
3553         Turns out this was easy, once I finally read the output from "perf report".
3554         It appears there may be a bug in "perf record" on android, as it complains
3555         about not being able to read from /proc/kallsyms even when
3556         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
3557         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
3558         but rather just flip it to 0 long enough to grab the /proc/kallsyms
3559         and then flip it back to whatever the device had.
3560
3561         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
3562         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
3563         to symbol names.  Its world-readable, but will return all 0s if you
3564         don't have permission to see the kernel symbols.  kptr_restrict
3565         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
3566         1 is only a specific group, and 2 is "no one, not even root".
3567         By default kptr_restrict is 2 on Android it seems.
3568         More kptr_restrict docs: http://lwn.net/Articles/420403/
3569
3570         I also took this opportunity to clean up how the perf record command
3571         was built for use/display in AndroidPerf.profile_after_exit and
3572         change to always using long-form names for the arguments (to hopefully help readability).
3573
3574         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3575         (AndroidPerf.__init__):
3576         (profile_after_exit):
3577         (ChromiumAndroidDriver.__init__):
3578         (ChromiumAndroidDriver._update_kallsyms_cache):
3579         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3580
3581 2013-01-09  Julie Parent  <jparent@chromium.org>
3582
3583         Dashboard cleanup: remove dead code.
3584         https://bugs.webkit.org/show_bug.cgi?id=106509
3585
3586         Reviewed by Dirk Pranke.
3587
3588         * TestResultServer/static-dashboards/dashboard_base.js:
3589         (parseParameters):
3590
3591 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
3592
3593         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
3594         https://bugs.webkit.org/show_bug.cgi?id=105638
3595
3596         Reviewed by Martin Robinson.
3597
3598         The test was failing for two reasons:
3599         - AccessibilityRenderObject::correspondingLabelForControlElement() was
3600           not ignoring the ARIA labelled-by property
3601         - AccessibilityController::accessibleElementById() was not implemented
3602
3603         Because getting an element by ID cannot be done in the UIProcess, the
3604         decision was made to expose the element's ID as an accessible attribute
3605         of the object.
3606
3607         In addition, fixing the bug in AccessibilityRenderObject made it possible
3608         to eliminate the Gtk platform-specific expectations for another test.
3609
3610         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3611         (childElementById): Added. Walks the tree looking for the AtkObject
3612         Attribute which exposes the HTML element's ID.
3613         (AccessibilityController::accessibleElementById): Implemented.
3614         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3615         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
3616         when there is no title, as is done with the Mac port.
3617         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3618         (WTR):
3619         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3620         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
3621         Attribute which exposes the HTML element's ID.
3622         (WTR):
3623         (WTR::AccessibilityController::accessibleElementById): Implemented.
3624         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3625         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
3626         even when there is no title, as is done with the Mac port.
3627
3628 2013-01-09  Gregg Tavares  <gman@google.com>
3629
3630         Add Gregg Tavares as a committer
3631         https://bugs.webkit.org/show_bug.cgi?id=106492
3632
3633         Unreviewed.
3634
3635         * Scripts/webkitpy/common/config/committers.py:
3636
3637 2013-01-09  Roger Fong  <roger_fong@apple.com>
3638
3639         Enable seamless iFrames for Windows DRT.
3640         https://bugs.webkit.org/show_bug.cgi?id=106468.
3641
3642         Rubberstamped by Timothy Horton.
3643
3644         * DumpRenderTree/win/DumpRenderTree.cpp:
3645         (resetDefaultsToConsistentValues):
3646
3647 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
3648
3649         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
3650         https://bugs.webkit.org/show_bug.cgi?id=93979
3651
3652         Reviewed by Benjamin Poulain.
3653
3654         Implement eventSender.scheduleAsynchronousKeyDown() in
3655         WebKitTestRunner.
3656
3657         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3658         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3659         (WTR::createKeyDownMessageBody):
3660         (WTR::EventSendingController::keyDown):
3661         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3662         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3663         (EventSendingController):
3664         * WebKitTestRunner/TestController.cpp:
3665         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3666         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3667         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3668         * WebKitTestRunner/TestController.h:
3669         (TestController):
3670
3671 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
3672
3673         [chromium] move resource load callback dumping to TestRunner library
3674         https://bugs.webkit.org/show_bug.cgi?id=106449
3675
3676         Reviewed by Adam Barth.
3677
3678         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3679         (DRTTestRunner::DRTTestRunner):
3680         (DRTTestRunner::reset):
3681         * DumpRenderTree/chromium/DRTTestRunner.h:
3682         (DRTTestRunner):
3683         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: