bfc6e12f324682695ad58d41cb1f02ffc41c0ab3
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2
3         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
4         https://bugs.webkit.org/show_bug.cgi?id=181136
5         <rdar://problem/36116604>
6
7         Reviewed by Chris Dumez.
8
9         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
10         browsing sessions.
11
12         * Scripts/run-gtk-tests:
13         (GtkTestRunner): Unskip test now that it passes.
14         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
15         (TEST): Add new WebsiteDataStoreEphemeral test.
16
17 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
18
19         Unreviewed, rolling out r226816.
20
21         This change broke LayoutTests on the bots.
22
23         Reverted changeset:
24
25         "run-webkit-tests fails when there is a curly brace in Xcode
26         build output"
27         https://bugs.webkit.org/show_bug.cgi?id=181254
28         https://trac.webkit.org/changeset/226816
29
30 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
31
32         webkitpy: Fix flakey webserver tests
33         https://bugs.webkit.org/show_bug.cgi?id=181555
34         <rdar://problem/36448273>
35
36         Reviewed by Aakash Jain.
37
38         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
39         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
40         determine if a specific server is running.
41
42 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
43
44         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
45         https://bugs.webkit.org/show_bug.cgi?id=181561
46         <rdar://problem/36452652>
47
48         Reviewed by Aakash Jain.
49
50         BeautifulSoup.find may return None, this case should be gracefully handled.
51
52         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
53         (BugzillaQueries._parse_result_count):
54         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
55
56 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
57
58         run-webkit-tests fails when there is a curly brace in Xcode build output
59         https://bugs.webkit.org/show_bug.cgi?id=181254
60
61         Reviewed by Daniel Bates.
62
63         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
64         (MeteredStream.write):
65
66 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
67
68         webkitpy: Reimplement simulator code (Part 3)
69         https://bugs.webkit.org/show_bug.cgi?id=180555
70         <rdar://problem/36131381>
71
72         Reviewed by Aakash Jain.
73
74         Remove old simulator code.
75
76         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
77         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
78         * Scripts/webkitpy/xcode/simulator.py: Removed.
79         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
80
81 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
84         https://bugs.webkit.org/show_bug.cgi?id=181337
85         <rdar://problem/36324813>
86
87         Reviewed by Tim Horton.
88
89         Add 3 new API tests for attachment element dragging.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
92         (-[TestWKWebView expectElementTag:toComeBefore:]):
93         (-[NSItemProvider expectType:withData:]):
94         (TestWebKitAPI::TEST):
95
96 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
97
98         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
99         https://bugs.webkit.org/show_bug.cgi?id=179621
100         <rdar://problem/35589585>
101
102         Unreviewed infrastructure fix.
103
104         * Scripts/webkitpy/port/mac.py:
105         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
106         list if we are the VERSION_MAX, which usually corresponds with future.
107
108 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
109
110         CodeBlocks should be in IsoSubspaces
111         https://bugs.webkit.org/show_bug.cgi?id=180884
112
113         Reviewed by Saam Barati.
114         
115         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
116         shouldn't take a long time due to benchmarks we don't optimize for.
117         
118         * Scripts/run-jsc-benchmarks:
119
120 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
121
122         Test gardening for GTK.
123         https://bugs.webkit.org/show_bug.cgi?id=181477
124
125         Unreviewed test gardening.
126
127         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
128         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
129
130 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
131
132         Add the new JSCOnly bot to the scheduler.
133         https://bugs.webkit.org/show_bug.cgi?id=181487
134
135         Unreviewed follow-up patch after r226729
136
137         On r226729 I missed to add the new JSCOnly bot the default scheduler.
138         This is needed to make the bot automatically pick each commit for testing.
139
140         * BuildSlaveSupport/build.webkit.org-config/config.json:
141
142 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
143
144         [Attachment Support] Support dragging attachment elements out as files on iOS
145         https://bugs.webkit.org/show_bug.cgi?id=181199
146         <rdar://problem/36299316>
147
148         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
149
150         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
151         attachment API tests.
152
153         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
154         (-[NSItemProvider expectType:withData:]):
155         (TestWebKitAPI::TEST):
156
157         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
158         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
159         -expectType:withData: helper to inspect the item providers created from the drag source.
160
161         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
162         (TestWebKitAPI::TEST):
163         * TestWebKitAPI/ios/DataInteractionSimulator.h:
164         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
165         (-[MockDragSession localContext]):
166         (-[MockDragSession setLocalContext:]):
167         (-[DataInteractionSimulator _resetSimulatedState]):
168         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
169         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
170         (-[DataInteractionSimulator _advanceProgress]):
171         (-[DataInteractionSimulator endDataTransfer]):
172
173         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
174         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
175         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
176         MockDragSession to hold on to a localContext.
177
178 2018-01-11  Ali Juma  <ajuma@chromium.org>
179
180         Unreviewed. Add Ali Juma as contributor
181
182         * Scripts/webkitpy/common/config/contributors.json:
183
184 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
185
186         Unreviewed. Update Selenium WebDriver imported tests.
187
188         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
189         environment variables.
190
191         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
192         (collect): Reorder the arguments to make pytest happy.
193         (run): Ditto.
194         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
195         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
196
197 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
198
199         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
200         https://bugs.webkit.org/show_bug.cgi?id=181492
201         <rdar://problem/36359679>
202
203         Reviewed by Alexey Proskuryakov. 
204
205 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
206
207         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
208         https://bugs.webkit.org/show_bug.cgi?id=181475
209
210         Reviewed by Michael Catanzaro.
211
212         * gtk/install-dependencies: Update package list for Arch Linux, extend
213         message shown at end of installation with additional tips.
214
215 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
216
217         REGRESSION(r222507): Composition highlight doesn't render when using IME
218         https://bugs.webkit.org/show_bug.cgi?id=181485
219         <rdar://problem/35896516>
220
221         Reviewed by Ryosuke Niwa.
222
223         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
224         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
225         allow rendering composition backgrounds (see InlineTextBox::paint).
226
227         * DumpRenderTree/ios/TextInputControllerIOS.m:
228         (+[TextInputController isSelectorExcludedFromWebScript:]):
229         (+[TextInputController webScriptNameForSelector:]):
230         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
231         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
232         * DumpRenderTree/mac/TextInputControllerMac.m:
233         (+[TextInputController isSelectorExcludedFromWebScript:]):
234         (+[TextInputController webScriptNameForSelector:]):
235         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
236         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
237         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
238         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
239         (WTR::TextInputController::setMarkedText):
240         * WebKitTestRunner/InjectedBundle/TextInputController.h:
241
242 2018-01-10  JF Bastien  <jfbastien@apple.com>
243
244         Poison small JSObject derivatives which only contain pointers
245         https://bugs.webkit.org/show_bug.cgi?id=181483
246         <rdar://problem/36407127>
247
248         Reviewed by Mark Lam.
249
250         Test the new move-assign and move-copy from unique_ptr, as well as
251         nullptr_t ctors.
252
253         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
256         (TestWebKitAPI::TEST):
257         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
258         (TestWebKitAPI::TEST):
259
260 2018-01-10  Chris Dumez  <cdumez@apple.com>
261
262         Multiple http/wpt/beacon/contentextensions/ test are flaky.
263         https://bugs.webkit.org/show_bug.cgi?id=179256
264         <rdar://problem/35401978>
265
266         Reviewed by Alex Christensen.
267
268         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
269         instance gets its own folder to avoid conflicts and flakiness.
270
271         * WebKitTestRunner/mac/TestControllerMac.mm:
272         (WTR::TestController::platformConfigureViewForTest):
273
274 2018-01-10  Tim Horton  <timothy_horton@apple.com>
275
276         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
277         https://bugs.webkit.org/show_bug.cgi?id=181269
278         <rdar://problem/35110344>
279
280         Reviewed by Simon Fraser.
281
282         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
283         (WTR::UIScriptController::beginBackSwipe):
284         (WTR::UIScriptController::completeBackSwipe):
285         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
286         (WTR::UIScriptController::beginBackSwipe):
287         (WTR::UIScriptController::completeBackSwipe):
288         (WTR::UIScriptController::overridePreference):
289         (WTR::UIScriptController::replaceTextAtRange):
290         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
291         (WTR::PlatformWebView::setNavigationGesturesEnabled):
292         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
293         (WTR::UIScriptController::beginBackSwipe):
294         (WTR::UIScriptController::completeBackSwipe):
295         Implement beginBackSwipe and completeBackSwipe on iOS (they already
296         exist on Mac) in terms of the new WKWebView testing SPI.
297
298 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
299
300         REGRESSION (r226715): ignore WARNING output in linter tests
301         https://bugs.webkit.org/show_bug.cgi?id=181486
302         <rdar://problem/36408847>
303
304         Reviewed by Aakash Jain.
305
306         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
307
308         * Scripts/webkitpy/common/system/outputcapture.py:
309         (OutputCapture.__init__): Pass logging level to be captured.
310         * Scripts/webkitpy/style/main_unittest.py:
311         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
312         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
313         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
314         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
315         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
316         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
317         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
318         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
319
320 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
321
322         Add a JSCOnly MIPS buildbot
323         https://bugs.webkit.org/show_bug.cgi?id=181487
324
325         Reviewed by Michael Catanzaro.
326
327         Add the new bot configs definitions for the master and update the unit tests.
328
329         * BuildSlaveSupport/build.webkit.org-config/config.json:
330         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
331
332 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
333
334         REGRESSION (r226715): don't re-check number of simulators in child processes
335         https://bugs.webkit.org/show_bug.cgi?id=181484
336         <rdar://problem/36407151>
337
338         Reviewed by Aakash Jain.
339
340         * Scripts/webkitpy/port/ios_simulator.py:
341         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
342         are already initialized.
343
344 2018-01-10  Commit Queue  <commit-queue@webkit.org>
345
346         Unreviewed, rolling out r226667 and r226673.
347         https://bugs.webkit.org/show_bug.cgi?id=181488
348
349         This caused a flaky crash. (Requested by mlewis13 on #webkit).
350
351         Reverted changesets:
352
353         "CodeBlocks should be in IsoSubspaces"
354         https://bugs.webkit.org/show_bug.cgi?id=180884
355         https://trac.webkit.org/changeset/226667
356
357         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
358         https://bugs.webkit.org/show_bug.cgi?id=180884
359         https://trac.webkit.org/changeset/226673
360
361 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
362
363         Follow-up fix to r226715
364         https://bugs.webkit.org/show_bug.cgi?id=180555
365         <rdar://problem/36131381>
366
367         Unreviewed infrastructure fix.
368
369         * Scripts/webkitpy/xcode/new_simulated_device.py:
370         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
371         of delete.
372
373 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
374
375         webkitpy: Refactor simulator code (Part 2)
376         https://bugs.webkit.org/show_bug.cgi?id=180555
377         <rdar://problem/36131381>
378
379         Reviewed by Aakash Jain.
380
381         The patch leverages the SimulatedDeviceManager when running layout tests.
382         This patch is primarily code removal, since much of the IOSSimulatorPort
383         was dedicated to managing simulators. The removed code is either now owned by the
384         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
385         boot multiple simulators which was made obsolete in Xcode 9.
386
387         * Scripts/webkitpy/layout_tests/controllers/manager.py:
388         (Manager._custom_device_for_test.in): Device names now have spaces in them,
389         strip those spaces.
390         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
391         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
392         * Scripts/webkitpy/port/ios.py:
393         (IOSPort.__init__): The _current_device idiom is no longer required since the
394         SimulatedDeviceManager keeps track of any previously booted devices.
395         (IOSPort.target_host): Even when only a single device is used, it will be accessed
396         through the array of managed devices.
397         (IOSPort.using_multiple_devices): Deleted.
398         * Scripts/webkitpy/port/ios_device.py:
399         (IOSDevicePort.using_multiple_devices): Deleted.
400         * Scripts/webkitpy/port/ios_simulator.py:
401         (IOSSimulatorPort): Remove constants required to manage simulators, change device
402         class strings so they can be parsed by the DeviceType class.
403         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
404         the number of simulators currently booted, the number of child processes specified
405         and the maximum number of simulators supported by this system.
406         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
407         devices owned by the SimulatedDeviceManager.
408         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
409         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
410         the maximum number of supported simulators on this system.
411         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
412         request for each child process and send this list to the SimulatedDeviceManager to
413         initialize the devices.
414         (IOSSimulatorPort.clean_up_test_run):
415         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
416         specified version of iOS.
417         (IOSSimulatorPort.reset_preferences):
418         (IOSSimulatorPort.simulator_runtime): Deleted.
419         (IOSSimulatorPort.simulator_device_type): Deleted.
420         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
421         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
422         (IOSSimulatorPort._create_simulators): Deleted.
423         (IOSSimulatorPort._quit_ios_simulator): Deleted.
424         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
425         (IOSSimulatorPort.using_multiple_devices): Deleted.
426         (IOSSimulatorPort._create_device): Deleted.
427         (IOSSimulatorPort.get_simulator_path): Deleted.
428         (IOSSimulatorPort._createSimulatorApps): Deleted.
429         (IOSSimulatorPort._createSimulatorApp): Deleted.
430         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
431         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
432         maximum number of simulators run on this system.
433         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
434         * Scripts/webkitpy/xcode/new_simulated_device.py:
435         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
436
437 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
438
439         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
440         https://bugs.webkit.org/show_bug.cgi?id=181474
441
442         Reviewed by Carlos Alberto Lopez Perez.
443
444         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
445         name as the name.
446
447         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
448         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
449         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
450
451 2018-01-09  Andy Estes  <aestes@apple.com>
452
453         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
454         https://bugs.webkit.org/show_bug.cgi?id=181459
455
456         Reviewed by Dan Bernstein.
457
458         * ImageDiff/cg/Configurations/Base.xcconfig:
459
460 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
461
462         font-display:fallback can cause a visual flash (which is supposed to be impossible)
463         https://bugs.webkit.org/show_bug.cgi?id=181374
464
465         Reviewed by Simon Fraser.
466
467         The test requires Palatino.
468
469         * DumpRenderTree/mac/DumpRenderTree.mm:
470         (allowedFontFamilySet):
471         * WebKitTestRunner/mac/TestControllerMac.mm:
472         (WTR::allowedFontFamilySet):
473
474 2018-01-09  Saam Barati  <sbarati@apple.com>
475
476         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
477         https://bugs.webkit.org/show_bug.cgi?id=181449
478
479         Reviewed by JF Bastien.
480
481         This allows me to Cmd+f in my terminal to search for things without
482         having the results become misaligned.
483
484         * Scripts/display-profiler-output:
485
486 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
487
488         [webkitpy] PlatformInfo should have default argument for casual use
489         https://bugs.webkit.org/show_bug.cgi?id=180827
490
491         Reviewed by David Kilzer.
492
493         PlatformInfo should be the only way to check platform specific thing instead
494         of sys.platform or other various checks. If there is something you want to check,
495         it should be placed in PlatformInfo.
496
497         Currently to instantiate PlatformInfo, it requires arguments, which is usually
498         sys, platform and Executive(). They are straight forward and should be handled
499         by default arguments. Then we can instantiate PlatformInfo more casual.
500
501         * Scripts/webkitpy/common/system/platforminfo.py:
502         (PlatformInfo): Use relative module path import
503         (PlatformInfo.__init__):
504         (PlatformInfo.executive): Lazy instantiation of Executive()
505         (PlatformInfo.total_bytes_memory): Accessing via above property
506         (PlatformInfo.xcode_sdk_version): Ditto
507         (PlatformInfo.xcode_simctl_list): Ditto
508         (PlatformInfo.xcode_version): Ditto
509         (PlatformInfo._win_version_str): Ditto
510         * Scripts/webkitpy/common/system/systemhost.py:
511         (SystemHost.__init__):
512         * Scripts/webkitpy/common/system/user.py:
513         (User.__init__):
514
515 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
516
517         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
518         https://bugs.webkit.org/show_bug.cgi?id=176443
519
520         Reviewed by Darin Adler.
521
522         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
523         (TEST):
524
525 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
526
527         check-webkit-style: Verify syntax for WK_API_AVAILABLE
528         https://bugs.webkit.org/show_bug.cgi?id=181394
529
530         Reviewed by Darin Adler.
531
532         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
533         as the second parameter instead of ios(WK_IOS_TBA). This generally
534         builds for iOS on EWS but not when using the public SDK. See r224057,
535         r223207 and r226211 for example. This patch adds a basic style check
536         for that macro to prevent this kind of mistake.
537
538         * Scripts/webkitpy/style/checkers/cpp.py:
539         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
540         (check_style): Run new style check.
541         (CppChecker): Add build type for the new style check.
542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
543         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
544
545 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
546
547         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
548         https://bugs.webkit.org/show_bug.cgi?id=181420
549         <rdar://problem/36365827>
550
551         Reviewed by Alex Christensen.
552
553         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
554         of corresponding _WKAttachments.
555
556         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
557         (TestWebKitAPI::TEST):
558
559 2018-01-08  Alex Christensen  <achristensen@webkit.org>
560
561         Add WKNavigationDelegate SPI exposing WebProcess crash reason
562         https://bugs.webkit.org/show_bug.cgi?id=181410
563         <rdar://problem/36167199>
564
565         Reviewed by Wenson Hsieh.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
568         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
569         (TEST):
570
571 2018-01-08  Alex Christensen  <achristensen@webkit.org>
572
573         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
574         https://bugs.webkit.org/show_bug.cgi?id=181408
575         <rdar://problem/35884960>
576
577         Reviewed by Tim Horton.
578
579         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
580         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
581
582 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
583
584         [Attachment Support] Expose file name and content type of WKAttachment
585         https://bugs.webkit.org/show_bug.cgi?id=181390
586         <rdar://problem/36336837>
587
588         Reviewed by Tim Horton.
589
590         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
591
592         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
593         (-[_WKAttachment synchronouslyRequestInfo:]):
594         (-[_WKAttachment synchronouslyRequestData:]):
595
596         Reimplement this in terms of -synchronouslyRequestInfo:.
597
598         (-[_WKAttachment expectRequestedDataToBe:]):
599         (TestWebKitAPI::TEST):
600
601 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
602
603         Copying, pasting, and then deleting an attachment element breaks attachment data requests
604         https://bugs.webkit.org/show_bug.cgi?id=181365
605         <rdar://problem/36340647>
606
607         Reviewed by Tim Horton.
608
609         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
610         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
611         detail.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
614         (TestWebKitAPI::TEST):
615
616 2018-01-08  Youenn Fablet  <youenn@apple.com>
617
618         navigator.onLine does not work inside service workers
619         https://bugs.webkit.org/show_bug.cgi?id=181079
620         <rdar://problem/36178606>
621
622         Reviewed by Darin Adler.
623
624         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
625         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
626
627 2018-01-07  Saam Barati  <sbarati@apple.com>
628
629         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
630         https://bugs.webkit.org/show_bug.cgi?id=181372
631
632         Reviewed by Filip Pizlo.
633
634         Adding these sorting modes makes it easier to analyze functions
635         that recompile a lot and exit a lot.
636
637         * Scripts/display-profiler-output:
638
639 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
640
641         Unreviewed, remove my Cisco email from contributors.json
642
643         * Scripts/webkitpy/common/config/contributors.json:
644
645 2018-01-05  JF Bastien  <jfbastien@apple.com>
646
647         WebAssembly: poison JS object's secrets
648         https://bugs.webkit.org/show_bug.cgi?id=181339
649         <rdar://problem/36325001>
650
651         Reviewed by Mark Lam.
652
653         Update tests for swap(Poisoned<k, T>, T*)
654
655         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
656         (TestWebKitAPI::TEST):
657         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
658         (TestWebKitAPI::TEST):
659         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
660         (TestWebKitAPI::TEST):
661
662 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
663
664         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
665         https://bugs.webkit.org/show_bug.cgi?id=181359
666
667         Reviewed by Tim Horton.
668
669         Ensure that these tests still pass using older SDKs.
670
671         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
672         (TestWebKitAPI::TEST):
673
674 2018-01-05  Alex Christensen  <achristensen@webkit.org>
675
676         Rebase API test after r226469
677         https://bugs.webkit.org/show_bug.cgi?id=181308
678
679         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
680         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
681         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
682
683 2018-01-05  Alex Christensen  <achristensen@webkit.org>
684
685         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
686         https://bugs.webkit.org/show_bug.cgi?id=181217
687
688         Reviewed by Tim Horton.
689
690         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
691         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
692         (TEST):
693
694 2018-01-05  Alex Christensen  <achristensen@webkit.org>
695
696         Add WKBundleFrameCreateFrameHandle
697         https://bugs.webkit.org/show_bug.cgi?id=181232
698         <rdar://problem/35926696>
699
700         Reviewed by Tim Horton.
701
702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
703         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
704         (mouseDidMoveOverElement):
705         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
706         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
707         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
708         (TEST):
709
710 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
711
712         iOS: Build fix after r226432.
713         
714         Unreviewed. Stop duplicating speakAs symbols for iOS.
715
716         * DumpRenderTree/AccessibilityUIElement.cpp:
717         (AccessibilityUIElement::speakAs):
718
719 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
720
721         Unreviewed, added myself as WebKit reviewer
722
723         * Scripts/webkitpy/common/config/contributors.json:
724
725 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
726
727         WPE: Build fix after r226432.
728
729         Unreviewed. Rename ::speak() to ::speakAs().
730         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
731         (WTR::AccessibilityUIElement::speakAs):
732         (WTR::AccessibilityUIElement::speak): Deleted.
733
734 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
735
736         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
737         https://bugs.webkit.org/show_bug.cgi?id=180361
738
739         Reviewed by Zalan Bujtas.
740
741         * DumpRenderTree/AccessibilityUIElement.cpp:
742         (speakAsCallback):
743         (AccessibilityUIElement::speakAs):
744         (AccessibilityUIElement::getJSClass):
745         (speakCallback): Deleted.
746         (AccessibilityUIElement::speak): Deleted.
747         * DumpRenderTree/AccessibilityUIElement.h:
748         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
749         (AccessibilityUIElement::speakAs):
750         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
751         (AccessibilityUIElement::speakAs):
752         (AccessibilityUIElement::speak): Deleted.
753         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
754         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
755         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
756         (WTR::AccessibilityUIElement::speakAs):
757         (WTR::AccessibilityUIElement::speak): Deleted.
758         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
759         (WTR::AccessibilityUIElement::speakAs):
760         (WTR::AccessibilityUIElement::speak): Deleted.
761
762 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
763
764         REGRESSION (r226395): test-webkitperl test expectations incorrect
765         https://bugs.webkit.org/show_bug.cgi?id=181307
766         <rdar://problem/36306558>
767
768         Rubber-stamped by Aakash Jain.
769
770         r226395 added two lines towards the beginning of
771         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
772         numbers in the test expectations need to update.
773
774         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
775
776 2018-01-04  Tim Horton  <timothy_horton@apple.com>
777
778         WKWebView loses minimum layout size overrides that happen while the process is terminated
779         https://bugs.webkit.org/show_bug.cgi?id=181306
780         <rdar://problem/34398288>
781
782         Reviewed by Dan Bernstein.
783
784         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
785         (TEST):
786         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
787         while the process is terminated results in the page getting the correct
788         minimum layout size.
789
790 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
791
792         [MediaStream] Add Mock screen capture source
793         https://bugs.webkit.org/show_bug.cgi?id=181291
794         <rdar://problem/36298164>
795
796         Reviewed by Dean Jackson.
797
798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
799         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
800         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
801
802 2018-01-04  Lucas Forschler  <lforschler@apple.com>
803
804         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
805
806         Reviewed by Ling Ho.
807
808         * BuildSlaveSupport/build.webkit.org-config/steps.py:
809
810 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
811
812         [Attachment Support] Create attachment elements when dropping files on iOS
813         https://bugs.webkit.org/show_bug.cgi?id=181192
814         <rdar://problem/36280945>
815
816         Reviewed by Tim Horton.
817
818         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
819         switch is enabled. See below for more details.
820
821         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
822         (-[NSItemProvider registerData:type:]):
823         (platformCopyPNG):
824         (TestWebKitAPI::TEST):
825         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
826
827         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
828         source item provider when dragging rich text *without* attachments, so this should have been a check for just
829         kUTTypeRTF instead.
830
831         (TestWebKitAPI::TEST):
832
833         Tests a few cases of inserting attachment elements via drop:
834         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
835             Instead of inserting the contents as inline web content, this should generate attachment elements.
836         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
837             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
838             back to inserting the content as an attachment.
839         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
840             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
841             or at the end).
842
843         * TestWebKitAPI/cocoa/TestWKWebView.h:
844         * TestWebKitAPI/cocoa/TestWKWebView.mm:
845         (-[TestWKWebView objectByEvaluatingJavaScript:]):
846
847         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
848         -stringByEvaluatingJavaScript to just turn around and call this.
849
850         (-[TestWKWebView stringByEvaluatingJavaScript:]):
851
852 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
853
854         Replace hard-coded paths in shebangs with #!/usr/bin/env
855         https://bugs.webkit.org/show_bug.cgi?id=181040
856
857         Reviewed by Alex Christensen.
858
859         * BuildSlaveSupport/build-launcher-app:
860         * BuildSlaveSupport/build-launcher-dmg:
861         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
862         * BuildSlaveSupport/built-product-archive:
863         * BuildSlaveSupport/clean-build:
864         * BuildSlaveSupport/delete-stale-build-files:
865         * BuildSlaveSupport/download-built-product:
866         * BuildSlaveSupport/gtk/buildbot/log/run:
867         * BuildSlaveSupport/gtk/buildbot/run:
868         * BuildSlaveSupport/gtk/pulseaudio/run:
869         * BuildSlaveSupport/kill-old-processes:
870         * BuildSlaveSupport/test-result-archive:
871         * BuildSlaveSupport/win/kill-old-processes:
872         * Scripts/SpacingHeuristics.pm:
873         * Scripts/add-include:
874         * Scripts/build-api-tests:
875         * Scripts/build-dumprendertree:
876         * Scripts/build-imagediff:
877         * Scripts/build-jsc:
878         * Scripts/build-webkit:
879         * Scripts/build-webkittestrunner:
880         * Scripts/check-Xcode-source-file-types:
881         * Scripts/check-dom-results:
882         * Scripts/check-for-exit-time-destructors:
883         * Scripts/check-for-global-initializers:
884         * Scripts/check-for-inappropriate-objc-class-names:
885         * Scripts/check-for-weak-vtables-and-externals:
886         * Scripts/clean-header-guards:
887         * Scripts/compare-timing-files:
888         * Scripts/configure-xcode-for-ios-development:
889         * Scripts/copy-webkitlibraries-to-product-directory:
890         * Scripts/create-exports:
891         * Scripts/debug-minibrowser:
892         * Scripts/debug-safari:
893         * Scripts/debug-test-runner:
894         * Scripts/do-file-rename:
895         * Scripts/do-webcore-rename:
896         * Scripts/dump-webkit-tests-run:
897         * Scripts/ensure-valid-python:
898         * Scripts/execAppWithEnv:
899         * Scripts/extract-localizable-js-strings:
900         * Scripts/filter-build-webkit:
901         * Scripts/find-extra-includes:
902         * Scripts/fix-blink-patch:
903         * Scripts/generate-coverage-data:
904         * Scripts/git-add-reviewer:
905         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
906         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
907         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
908         * Scripts/make-new-script-test:
909         * Scripts/make-script-test-wrappers:
910         * Scripts/package-root:
911         * Scripts/parse-malloc-history:
912         * Scripts/report-include-statistics:
913         * Scripts/resolve-ChangeLogs:
914         * Scripts/run-api-tests:
915         * Scripts/run-bindings-tests:
916         * Scripts/run-content-extension-tester:
917         * Scripts/run-iexploder-tests:
918         * Scripts/run-javascriptcore-tests:
919         * Scripts/run-jsc:
920         * Scripts/run-leaks:
921         * Scripts/run-mangleme-tests:
922         * Scripts/run-minibrowser:
923         * Scripts/run-pageloadtest:
924         * Scripts/run-regexp-tests:
925         * Scripts/run-safari:
926         * Scripts/run-sunspider:
927         * Scripts/run-test-runner:
928         * Scripts/run-webkit-app:
929         * Scripts/run-webkit-httpd:
930         * Scripts/run-webkit-websocketserver:
931         * Scripts/set-webkit-configuration:
932         * Scripts/show-pretty-diff:
933         * Scripts/sort-Xcode-project-file:
934         * Scripts/split-file-by-class:
935         * Scripts/sunspider-compare-results:
936         * Scripts/svn-apply:
937         * Scripts/svn-unapply:
938         * Scripts/test-webkit-scripts:
939         * Scripts/test-webkitperl:
940         * Scripts/update-iexploder-cssproperties:
941         * Scripts/update-javascriptcore-test-results:
942         * Scripts/update-webkit:
943         * Scripts/update-webkit-auxiliary-libs:
944         * Scripts/update-webkit-dependency:
945         * Scripts/update-webkit-libs-jhbuild:
946         * Scripts/update-webkit-localizable-strings:
947         * Scripts/update-webkit-support-libs:
948         * Scripts/update-webkitgtk-libs:
949         * Scripts/update-webkitwpe-libs:
950         * Scripts/webkit-build-directory:
951         * Scripts/webkitperl/LoadAsModule.pm:
952         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
953         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
954         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
955         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
956         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
957         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
958         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
959         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
960         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
961         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
962         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
963         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
964         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
965         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
966         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
967         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
968         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
969         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
970         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
971         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
972         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
973         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
974         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
975         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
976         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
977         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
978         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
979         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
980         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
981         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
982         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
983         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
984         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
985         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
986         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
987         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
988         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
989         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
990         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
991         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
992         * ccache/ccache-clang:
993         * ccache/ccache-clang++:
994         * ccache/ccache-wrapper:
995         * gtk/install-dependencies:
996         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
997         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
998         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
999         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1000         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1001         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1002         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1003         * iExploder/iexploder-1.7.2/src/webserver.rb:
1004         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1005         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1006         * wpe/install-dependencies:
1007
1008 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1009
1010         filter-build-webkit filters out useful compiler error lines
1011         https://bugs.webkit.org/show_bug.cgi?id=179864
1012
1013         Reviewed by Tim Horton.
1014
1015         Don't filter out lines that contain information about build errors by always showing lines
1016         after a line that contains "note:" or "error:".
1017
1018         * Scripts/filter-build-webkit:
1019         (shouldShowSubsequentLine):
1020         (shouldIgnoreLine):
1021
1022 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1023
1024         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1025         https://bugs.webkit.org/show_bug.cgi?id=173915
1026
1027         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1028         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1029         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1030         empty string in this case.
1031
1032         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1033         (emitFormSubmissionEvent):
1034
1035 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1036
1037         [GTK] Add web process API to detect when form is submitted via JavaScript
1038         https://bugs.webkit.org/show_bug.cgi?id=173915
1039
1040         Reviewed by Carlos Garcia Campos.
1041
1042         Test it.
1043
1044         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1045         (FormSubmissionTest::FormSubmissionTest):
1046         (FormSubmissionTest::~FormSubmissionTest):
1047         (FormSubmissionTest::testFormSubmissionResult):
1048         (FormSubmissionTest::willSendDOMEventCallback):
1049         (FormSubmissionTest::willCompleteCallback):
1050         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1051         (testWebExtensionFormSubmissionSteps):
1052         (beforeAll):
1053         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1054         (DelayedSignal::DelayedSignal):
1055         (emitFormSubmissionEvent):
1056         (handleFormSubmissionCallback):
1057         (willSubmitFormCallback):
1058         (pageCreatedCallback):
1059
1060 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1061
1062         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1063         https://bugs.webkit.org/show_bug.cgi?id=181251
1064
1065         * Scripts/run-gtk-tests:
1066         (GtkTestRunner):
1067
1068 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1069
1070         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1071         https://bugs.webkit.org/show_bug.cgi?id=181136
1072
1073         * Scripts/run-gtk-tests:
1074         (GtkTestRunner):
1075
1076 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1077
1078         [macOS, iOS] Adopt new secure coding APIs in WebKit
1079         https://bugs.webkit.org/show_bug.cgi?id=181085
1080         <rdar://problem/34837397>
1081
1082         Reviewed by Tim Horton.
1083
1084         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1085         capable of supporting NSSecureCoding, so pass through the current coding routines.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1088         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1089         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1090         routines if necessary.
1091         (TEST): Updated for NSSecureCoding.
1092         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1093         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1094
1095 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1096
1097         Remove std::chrono completely
1098         https://bugs.webkit.org/show_bug.cgi?id=181186
1099
1100         Reviewed by Alex Christensen.
1101
1102         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1103         (WTR::TestController::platformRunUntil):
1104
1105 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1106
1107         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1108         https://bugs.webkit.org/show_bug.cgi?id=181231
1109
1110         Reviewed by Alex Christensen.
1111
1112         Implement TestController APIs needed by ResourceLoadStatistics tests.
1113
1114         * WebKitTestRunner/TestController.cpp:
1115         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1116         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1117
1118 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1119
1120         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1121         https://bugs.webkit.org/show_bug.cgi?id=181219
1122
1123         Reviewed by Wenson Hsieh.
1124
1125         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1126
1127 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1128
1129         Add a WebAuthentication runtime feature flag
1130         https://bugs.webkit.org/show_bug.cgi?id=181220
1131         <rdar://problem/36055305>
1132
1133         Reviewed by Brent Fulgham.
1134
1135         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1136
1137         * DumpRenderTree/TestOptions.h:
1138         * DumpRenderTree/TestOptions.mm:
1139         (TestOptions::TestOptions):
1140         * DumpRenderTree/mac/DumpRenderTree.mm:
1141         (enableExperimentalFeatures):
1142         (setWebPreferencesForTestOptions):
1143         * WebKitTestRunner/TestController.cpp:
1144         (WTR::TestController::resetPreferencesToConsistentValues):
1145         (WTR::updateTestOptionsFromTestHeader):
1146         * WebKitTestRunner/TestOptions.h:
1147         (WTR::TestOptions::hasSameInitializationOptions const):
1148
1149 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1150
1151         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1152         https://bugs.webkit.org/show_bug.cgi?id=181143
1153         <rdar://problem/36200381>
1154
1155         Reviewed by Tim Horton.
1156
1157         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1158         attachment elements are enabled.
1159
1160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1161         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1162         (TestWebKitAPI::TEST):
1163
1164 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1165
1166         Update Credential Management API for WebAuthentication
1167         https://bugs.webkit.org/show_bug.cgi?id=181082
1168         <rdar://problem/36055239>
1169
1170         Reviewed by Brent Fulgham.
1171
1172         Enable Credential Management API for testing.
1173
1174         * DumpRenderTree/TestOptions.h:
1175         * WebKitTestRunner/TestOptions.h:
1176
1177 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1178
1179         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1180         https://bugs.webkit.org/show_bug.cgi?id=168194
1181
1182         Reviewed by Carlos Garcia Campos.
1183
1184         Fix an assertion and unskip the test. The order that form controls are associated is not
1185         guaranteed.
1186
1187         * Scripts/run-gtk-tests:
1188         (GtkTestRunner):
1189         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1190         (didAssociateFormControlsCallback):
1191
1192 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1193
1194         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1195         https://bugs.webkit.org/show_bug.cgi?id=180897
1196         <rdar://problem/35535328>
1197
1198         Reviewed by Brent Fulgham.
1199
1200         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1201
1202         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1203         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1204         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1205         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1206         (websiteDataStoreTestWebView):
1207         (TEST):
1208
1209 == Rolled over to ChangeLog-2018-01-01 ==