Add a command line default to force WebKitTestRunner to turn on process swap on navig...
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-11  Brady Eidson  <beidson@apple.com>
2
3         Add a command line default to force WebKitTestRunner to turn on process swap on navigation.
4         https://bugs.webkit.org/show_bug.cgi?id=186534
5
6         Reviewed by Chris Dumez.
7
8         Right now Process Swap On Navigation is enabled on a per-test basis.
9         The future is to enable it by default.
10
11         Adding a 'defaults write' helps us get to that future.
12
13         * WebKitTestRunner/TestController.cpp:
14         (WTR::TestController::testOptionsForTest const):
15         (WTR::TestController::platformAddTestOptions const):
16         * WebKitTestRunner/TestController.h:
17         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
18         (WTR::TestController::platformAddTestOptions const):
19
20 2018-06-11  Chris Dumez  <cdumez@apple.com>
21
22         Allow enabling PSON in layout tests without window.open support
23         https://bugs.webkit.org/show_bug.cgi?id=186537
24
25         Reviewed by Geoffrey Garen.
26
27         Allow enabling PSON in layout tests without window.open support since window.open support
28         is far from being ready and we plan to enable PSON in layout tests soon.
29
30         * WebKitTestRunner/TestController.cpp:
31         (WTR::TestController::createWebViewWithOptions):
32         (WTR::updateTestOptionsFromTestHeader):
33         * WebKitTestRunner/TestOptions.h:
34         (WTR::TestOptions::hasSameInitializationOptions const):
35
36 2018-06-11  Brady Eidson  <beidson@apple.com>
37
38         Followup to [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
39         https://bugs.webkit.org/show_bug.cgi?id=186436
40
41         Patch by Darin Adler
42         Reviewed by Brady Eidson.
43
44         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
45         (TestWebKitAPI::TEST):
46
47 2018-06-11  Mark Lam  <mark.lam@apple.com>
48
49         Gardening: skip BigInt tests on iOS until the feature is stable.
50         <rdar://problem/40331121>
51
52         Not reviewed.
53
54         * Scripts/run-jsc-stress-tests:
55
56 2018-06-11  Fujii Hironori  <Hironori.Fujii@sony.com>
57
58         [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
59         https://bugs.webkit.org/show_bug.cgi?id=186478
60
61         Reviewed by Alex Christensen.
62
63         Added "New WebKit Window" and "New WebKitLegacy Window" menu
64         items. Disabled the menu item "New WebKit Window" if
65         !ENABLE(WEBKIT).
66
67         * MiniBrowser/win/CMakeLists.txt: Added WebKitBrowserWindow.cpp
68         source file and ENABLE_WEBKIT macro if ENABLE_WEBKIT.
69         * MiniBrowser/win/MainWindow.cpp:
70         (MainWindow::MainWindow):
71         (MainWindow::create):
72         (MainWindow::init):
73         (MainWindow::WndProc):
74         * MiniBrowser/win/MainWindow.h:
75         * MiniBrowser/win/MiniBrowserLib.rc:
76         * MiniBrowser/win/MiniBrowserLibResource.h:
77         * MiniBrowser/win/PrintWebUIDelegate.cpp:
78         (PrintWebUIDelegate::createWebViewWithRequest):
79         * MiniBrowser/win/WebKitBrowserWindow.cpp: Added.
80         (createString):
81         (toUtf8):
82         (createWKString):
83         (createWKURL):
84         (WebKitBrowserWindow::create):
85         (WebKitBrowserWindow::WebKitBrowserWindow):
86         (WebKitBrowserWindow::init):
87         (WebKitBrowserWindow::hwnd):
88         (WebKitBrowserWindow::loadURL):
89         (WebKitBrowserWindow::loadHTMLString):
90         (WebKitBrowserWindow::navigateForwardOrBackward):
91         (WebKitBrowserWindow::navigateToHistory):
92         (WebKitBrowserWindow::setPreference):
93         (WebKitBrowserWindow::print):
94         (WebKitBrowserWindow::launchInspector):
95         (WebKitBrowserWindow::setUserAgent):
96         (WebKitBrowserWindow::userAgent):
97         (WebKitBrowserWindow::showLayerTree):
98         (WebKitBrowserWindow::updateStatistics):
99         (WebKitBrowserWindow::resetZoom):
100         (WebKitBrowserWindow::zoomIn):
101         (WebKitBrowserWindow::zoomOut):
102         (toWebKitBrowserWindow):
103         (WebKitBrowserWindow::didReceiveTitleForFrame):
104         (WebKitBrowserWindow::didCommitLoadForFrame):
105         * MiniBrowser/win/WebKitBrowserWindow.h:
106         * MiniBrowser/win/WinMain.cpp:
107         (wWinMain):
108
109 2018-06-11  Keith Miller  <keith_miller@apple.com>
110
111         Add missing whitespace to run-jsc command
112         https://bugs.webkit.org/show_bug.cgi?id=186528
113
114         Reviewed by Mark Lam.
115
116         * Scripts/run-jsc:
117
118 2018-06-11  Philippe Normand  <pnormand@igalia.com>
119
120         [webkitpy] PHP7.2 support on Debian platforms
121         https://bugs.webkit.org/show_bug.cgi?id=186521
122
123         Reviewed by Michael Catanzaro.
124
125         * Scripts/webkitpy/port/base.py:
126         (Port._debian_php_version): Refactor and add PHP 7.2 version support.
127
128 2018-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
129
130         Unreviewed. Fix WPE API and layout tests after r232670.
131
132         Now that dyz is not installed, there's not -default.so symlink for the WPE backend, so we need to use
133         WPE_BACKEND_LIBRARY environment variable to ensure tests are run with fdo backend.
134
135         * Scripts/run-wpe-tests:
136         (WPETestRunner.__init__):
137         (WPETestRunner):
138         (WPETestRunner.setup_testing_environment):
139         * Scripts/webkitpy/port/wpe.py:
140         (WPEPort.setup_environ_for_server):
141         * glib/api_test_runner.py:
142         (TestRunner.setup_testing_environment):
143         (TestRunner.run_tests):
144         (TestRunner._setup_testing_environment): Deleted.
145
146 2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         [GTK][WPE] Add API run run javascript from a WebKitWebView in an isolated world
149         https://bugs.webkit.org/show_bug.cgi?id=186192
150
151         Reviewed by Michael Catanzaro.
152
153         Add tests cases for the new API.
154
155         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
156         (testWebViewRunJavaScript):
157         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
158         (methodCallCallback):
159         (webkit_web_extension_initialize_with_user_data):
160         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
161         (runJavaScriptInWorldReadyCallback):
162         (WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):
163         (WebViewTest::runJavaScriptInWorldAndWaitUntilFinished):
164         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
165
166 2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>
167
168         [WPE] Add a MiniBrowser and use it to run WebDriver tests
169         https://bugs.webkit.org/show_bug.cgi?id=186345
170
171         Reviewed by Žan Doberšek.
172
173         Most of the code is based on dyz and gtk MiniBrowser. This patch adds a new internal library WPEToolingBackends,
174         including the headless view backend and a new window backend to be used by the MiniBrowser. MiniBrowser can also
175         run in headless mode, by using the headless backend instead of the window one, which will allow us to run the
176         WebDriver tests in the bots.
177
178         * CMakeLists.txt:
179         * MiniBrowser/wpe/CMakeLists.txt: Added.
180         * MiniBrowser/wpe/main.cpp: Added.
181         (automationStartedCallback):
182         (createViewBackend):
183         (main):
184         * Scripts/run-minibrowser: Remove WPE specific code.
185         * Scripts/run-webdriver-tests: Add headless display-server option.
186         * Scripts/webkitdirs.pm:
187         (launcherName): Remove WPE specific code.
188         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
189         (WebDriverWPE.browser_name): Return MiniBrowser.
190         (WebDriverWPE.browser_path): Return the path to the MiniBrowser in build dir.
191         (WebDriverWPE.browser_args): Add --headless when running in headless mode.
192         (WebDriverWPE.capabilities): Use the full browser path.
193         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
194         (WebDriverTestRunnerSelenium.collect_tests): Fix early return value.
195         * TestWebKitAPI/PlatformWPE.cmake: Use WPEToolingBackends instead of HeadlessViewBackend.
196         * TestWebKitAPI/PlatformWebView.h: Ditto.
197         * TestWebKitAPI/glib/PlatformWPE.cmake: Ditto
198         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
199         (Test::createWebViewBackend): Ditto.
200         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
201         (TestWebKitAPI::PlatformWebView::initialize): Ditto.
202         * WebKitTestRunner/PlatformWPE.cmake: Ditto.
203         * WebKitTestRunner/PlatformWebView.h: Ditto.
204         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
205         (WTR::PlatformWebView::PlatformWebView): Ditto.
206         * wpe/HeadlessViewBackend/CMakeLists.txt: Removed.
207         * wpe/backends/CMakeLists.txt: Added.
208         * wpe/backends/HeadlessViewBackend.cpp: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.cpp.
209         (WPEToolingBackends::getEGLDisplay):
210         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
211         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
212         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
213         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
214         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
215         * wpe/backends/HeadlessViewBackend.h: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.h.
216         * wpe/backends/ViewBackend.cpp: Added.
217         (WPEToolingBackends::ViewBackend::ViewBackend):
218         (WPEToolingBackends::ViewBackend::~ViewBackend):
219         (WPEToolingBackends::ViewBackend::initialize):
220         (WPEToolingBackends::ViewBackend::setInputClient):
221         (WPEToolingBackends::ViewBackend::backend const):
222         (WPEToolingBackends::ViewBackend::dispatchInputPointerEvent):
223         (WPEToolingBackends::ViewBackend::dispatchInputAxisEvent):
224         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
225         * wpe/backends/ViewBackend.h: Added.
226         * wpe/backends/WindowViewBackend.cpp: Added.
227         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
228         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
229         (WPEToolingBackends::WindowViewBackend::displayBuffer):
230         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
231         * wpe/backends/WindowViewBackend.h: Added.
232         * wpe/jhbuild.modules: Remove dyz and add wayland-protocols.
233
234 2018-06-10  Fujii Hironori  <Hironori.Fujii@sony.com>
235
236         [Win][MiniBrowser] MiniBrowser class should be renamed to WebKitLegacyBrowserWindow
237         https://bugs.webkit.org/show_bug.cgi?id=186427
238
239         Reviewed by Ryosuke Niwa.
240
241         * MiniBrowser/win/AccessibilityDelegate.cpp:
242         * MiniBrowser/win/AccessibilityDelegate.h:
243         (AccessibilityDelegate::AccessibilityDelegate):
244         * MiniBrowser/win/CMakeLists.txt: Removed MiniBrowser.cpp. Added WebKitLegacyBrowserWindow.cpp.
245         * MiniBrowser/win/Common.h:
246         * MiniBrowser/win/MainWindow.cpp:
247         (MainWindow::init):
248         * MiniBrowser/win/MainWindow.h:
249         * MiniBrowser/win/MiniBrowserWebHost.cpp:
250         * MiniBrowser/win/MiniBrowserWebHost.h:
251         (MiniBrowserWebHost::MiniBrowserWebHost):
252         * MiniBrowser/win/PageLoadTestClient.cpp:
253         (PageLoadTestClient::PageLoadTestClient):
254         * MiniBrowser/win/PageLoadTestClient.h:
255         * MiniBrowser/win/PrintWebUIDelegate.cpp:
256         (PrintWebUIDelegate::createWebViewWithRequest):
257         * MiniBrowser/win/PrintWebUIDelegate.h:
258         (PrintWebUIDelegate::PrintWebUIDelegate):
259         * MiniBrowser/win/ResourceLoadDelegate.cpp:
260         * MiniBrowser/win/ResourceLoadDelegate.h:
261         (ResourceLoadDelegate::ResourceLoadDelegate):
262         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: Renamed from Tools/MiniBrowser/win/MiniBrowser.cpp.
263         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Renamed from Tools/MiniBrowser/win/MiniBrowser.h.
264         * MiniBrowser/win/WebDownloadDelegate.cpp:
265         (WebDownloadDelegate::WebDownloadDelegate):
266         * MiniBrowser/win/WebDownloadDelegate.h:
267
268 2018-06-10  Chris Dumez  <cdumez@apple.com>
269
270         Reload the Web view in case of crash if the client does not implement webViewWebContentProcessDidTerminate delegate
271         https://bugs.webkit.org/show_bug.cgi?id=186468
272
273         Reviewed by Geoffrey Garen.
274
275         Add API test coverage.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
278         (-[BasicNavigationDelegateWithoutCrashHandler webView:didStartProvisionalNavigation:]):
279         (-[BasicNavigationDelegateWithoutCrashHandler webView:didFinishNavigation:]):
280         (TEST):
281
282 2018-06-10  Michael Catanzaro  <mcatanzaro@igalia.com>
283
284         [WPE][GTK] paypal.com requires user agent quirk
285         https://bugs.webkit.org/show_bug.cgi?id=186466
286
287         Reviewed by Carlos Garcia Campos.
288
289         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
290         (TestWebKitAPI::TEST):
291
292 2018-06-09  Dan Bernstein  <mitz@apple.com>
293
294         [Xcode] Clean up and modernize some build setting definitions
295         https://bugs.webkit.org/show_bug.cgi?id=186463
296
297         Reviewed by Sam Weinig.
298
299         * DumpRenderTree/mac/Configurations/Base.xcconfig: Removed definition for macOS 10.11.
300           Simplified the definition of WK_PRIVATE_FRAMEWORK_STUBS_DIR now that
301           WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
302         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Removed definition for macOS
303           10.11.
304         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
305         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
306         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
307         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
308         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Simplified the definitions of
309           ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest
310           supported version.
311         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for
312           macOS 10.11.
313         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also simplified the definition of
314           WK_PRIVATE_FRAMEWORK_STUBS_DIR now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all
315           supported Xcode versions
316         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Removed definition for macOS 10.11.
317
318 2018-06-09  Dan Bernstein  <mitz@apple.com>
319
320         Added missing file references to the Configuration group.
321
322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
323
324 2018-06-08  Darin Adler  <darin@apple.com>
325
326         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
327         https://bugs.webkit.org/show_bug.cgi?id=186436
328
329         Reviewed by Anders Carlsson.
330
331         * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:
332         (TestWebKitAPI::WebKit2CustomProtocolsTest_ProcessPoolDestroyedDuringLoading):
333         Use @autoreleasepool.
334         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
335         (TestWebKitAPI::buildAndPerformTest): Ditto.
336         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
337         (TestWebKitAPI::WebKitLegacy_StopLoadingFromDidFinishLoading): Ditto.
338
339 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
340
341         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
342         https://bugs.webkit.org/show_bug.cgi?id=186442
343         <rdar://problem/40879364>
344
345         Reviewed by Tim Horton.
346
347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
348
349 2018-06-08  Alicia Boya García  <aboya@igalia.com>
350
351         [GTK] Update to libva-2.1.0 in jhbuild
352         https://bugs.webkit.org/show_bug.cgi?id=186434
353
354         Reviewed by Philippe Normand.
355
356         * gstreamer/jhbuild.modules:
357
358 2018-06-07  Yusuke Suzuki  <utatane.tea@gmail.com>
359
360         [WTF] Add WorkerPool
361         https://bugs.webkit.org/show_bug.cgi?id=174569
362
363         Reviewed by Carlos Garcia Campos.
364
365         * TestWebKitAPI/CMakeLists.txt:
366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
367         * TestWebKitAPI/Tests/WTF/WorkerPool.cpp: Added.
368         (TestWebKitAPI::TEST):
369
370 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
371
372         [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow
373         https://bugs.webkit.org/show_bug.cgi?id=186421
374
375         Reviewed by Ryosuke Niwa.
376
377         This is the core patch to make MiniBrowser to support WK1 and WK2
378         windows (Bug 184770).
379
380         I will rename MiniBrowser class to WK1BrowserWindow in a follow-up
381         patch (Bug 184770 Comment 12).
382
383         * MiniBrowser/win/BrowserWindow.h: Added.
384         * MiniBrowser/win/MainWindow.cpp:
385         (MainWindow::WndProc):
386         * MiniBrowser/win/MainWindow.h:
387         (MainWindow::browserWindow const):
388         * MiniBrowser/win/MiniBrowser.cpp:
389         (MiniBrowser::create):
390         (MiniBrowser::navigateForwardOrBackward): Removed the unsed first argument hWnd.
391         (MiniBrowser::navigateToHistory): Ditto.
392         * MiniBrowser/win/MiniBrowser.h: Inherit BrowserWindow interface.
393         Make all other methods private and make delegates classes friends.
394         * MiniBrowser/win/PrintWebUIDelegate.cpp:
395         (PrintWebUIDelegate::createWebViewWithRequest):
396
397 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
398
399         [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindow's method
400         https://bugs.webkit.org/show_bug.cgi?id=186387
401
402         Reviewed by Ryosuke Niwa.
403
404         MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser.
405         It should be a MainWindow's method.
406
407         * MiniBrowser/win/MainWindow.cpp:
408         (MainWindow::init): Call MainWindow::updateDeviceScaleFactor.
409         (MainWindow::resizeSubViews): Do not set a font every time window size is changed.
410         (MainWindow::WndProc): Call MainWindow::updateDeviceScaleFactor on WM_DPICHANGED.
411         (MainWindow::updateDeviceScaleFactor): Converted from
412         MiniBrowser::updateDeviceScaleFactor and
413         MiniBrowser::generateFontForScaleFactor. Set a URL bar's font if DPI is changed.
414         * MiniBrowser/win/MainWindow.h:
415         * MiniBrowser/win/MiniBrowser.cpp:
416         (MiniBrowser::init):
417         (MiniBrowser::generateFontForScaleFactor): Deleted.
418         (MiniBrowser::updateDeviceScaleFactor): Deleted.
419         * MiniBrowser/win/MiniBrowser.h:
420         (MiniBrowser::deviceScaleFactor): Deleted.
421         (MiniBrowser::urlBarFont): Deleted.
422
423 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
424
425         [webkitpy] Treat svn versions as Version objects
426         https://bugs.webkit.org/show_bug.cgi?id=186403
427         <rdar://problem/40904860>
428
429         Reviewed by Dan Bernstein.
430
431         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
432         * Scripts/webkitpy/common/checkout/scm/svn.py:
433         (SVN.svn_version): Return Version object instead of string.
434         (SVN._status_regexp): Convert version string to Version object.
435         (SVN.add_list): Ditto.
436
437 2018-06-07  Tadeu Zagallo  <tzagallo@apple.com>
438
439         Don't try to allocate JIT memory if we don't have the JIT entitlement
440         https://bugs.webkit.org/show_bug.cgi?id=182605
441         <rdar://problem/38271229>
442
443         Reviewed by Mark Lam.
444
445         Add the Security framework to the TestWTF target, since it's required by the new function to check the entitlements.
446
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448
449 2018-06-07  Mark Lam  <mark.lam@apple.com>
450
451         Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run.
452         https://bugs.webkit.org/show_bug.cgi?id=186409
453         <rdar://problem/40909007>
454
455         Reviewed by Saam Barati.
456
457         This is needed because some tests are written with specific features in mind, and
458         we may not necessarily want to enable that option for all tests.
459
460         We can now specify something like this at the top of a test file:
461             //@ requireOptions("--useIntlPluralRules=true")
462
463         ... and ensure that that test will be run with the --useIntlPluralRules=true
464         option for all test configurations that run the test.
465
466         * Scripts/run-jsc-stress-tests:
467
468 2018-06-07  Tim Horton  <timothy_horton@apple.com>
469
470         REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
471         https://bugs.webkit.org/show_bug.cgi?id=186395
472         <rdar://problem/40902427>
473
474         Reviewed by Wenson Hsieh.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
477         (TEST):
478         endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
479
480 2018-06-07  Thibault Saunier  <tsaunier@igalia.com>
481
482         [GTK][WPE] Start implementing MediaStream API
483         https://bugs.webkit.org/show_bug.cgi?id=185787
484
485         Reviewed by Philippe Normand.
486
487         * Scripts/webkitpy/style/checker.py: Apply special formatting rules for new GObject subclasses.
488         * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base.
489         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch:
490         Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d0e9cc92a86aa0227ee87406737b6d31670aea
491
492 2018-06-07  Brendan McLoughlin  <brendan@bocoup.com>
493
494         Update web-platform-tests github location in webkitpy.w3c.test_importer
495         https://bugs.webkit.org/show_bug.cgi?id=186392
496
497         Reviewed by Youenn Fablet.
498
499         * Scripts/webkitpy/w3c/test_importer.py:
500         (TestImporter.write_import_log):
501
502 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
503
504         webkitperl: Generalize .internal SDK suffix
505         https://bugs.webkit.org/show_bug.cgi?id=186352
506         <rdar://problem/40853947>
507
508         Reviewed by Alexey Proskuryakov.
509
510         * Scripts/build-webkit:
511         * Scripts/package-root:
512         (usage):
513         * Scripts/webkitdirs.pm:
514         (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output.
515         (availableXcodeSDKS): Generate a list of all available Xcode SDKs on this machine.
516         (determineXcodeSDK): Always prefer .internal SDKs if available.
517         * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl:
518         
519 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
520
521         [Win][MiniBrowser] Support multiple windows properly
522         https://bugs.webkit.org/show_bug.cgi?id=186263
523
524         Reviewed by Ryosuke Niwa.
525
526         The current implementation of
527         PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using
528         CreateProcess to open a new window, and doesn't return the new
529         instance of IWebView. As the result, for example, window.close
530         doesn't work as expected.
531
532         In this change, a new MainWindow is created and return the
533         IWebView in PrintWebUIDelegate::createWebViewWithRequest.
534
535         In addition to it, this change unifies the lifetime of MiniBrowser
536         and its delegates AccessibilityDelegate, PrintWebUIDelegate,
537         ResourceLoadDelegate and WebDownloadDelegate in order to keep
538         MiniBrowser alive as long as the delegates live. Because the
539         window of webview keeps references of such delegates and accesses
540         those after MiniBrowser destruction.
541
542         * MiniBrowser/win/MainWindow.h: Added s_numInstances class member
543         to count the number of instance to close the application. Do not
544         use unique_ptr for m_browserWindow because it has ref count now.
545         * MiniBrowser/win/MainWindow.cpp:
546         (MainWindow::MainWindow): Increment s_numInstances.
547         (MainWindow::~MainWindow): Decrement s_numInstances.
548         (MainWindow::create):
549         (MainWindow::init):
550         (MainWindow::WndProc): Rename thiz to thisWindow. Keep this
551         instance alive during this function by using RefPtr<MainWindow>.
552         Deref the MainWindow instance on WM_DESTROY. Quit the application
553         when the last MainWindow is closed.
554         (MainWindow::cachesDialogProc): Rename thiz to thisWindow.
555         (MainWindow::customUserAgentDialogProc): Ditto.
556         * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release.
557         * MiniBrowser/win/MiniBrowser.cpp:
558         (MiniBrowser::create):
559         (MiniBrowser::AddRef):
560         (MiniBrowser::Release):
561         (MiniBrowser::init): Passes this to the constructors of delegates.
562         * MiniBrowser/win/AccessibilityDelegate.cpp:
563         (AccessibilityDelegate::AddRef): Delegate to MiniBrowser.
564         (AccessibilityDelegate::Release): Ditto.
565         * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount.
566         (AccessibilityDelegate::AccessibilityDelegate):
567         * MiniBrowser/win/MiniBrowserWebHost.cpp:
568         (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser.
569         (MiniBrowserWebHost::Release): Ditto.
570         * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount.
571         * MiniBrowser/win/PrintWebUIDelegate.cpp:
572         (PrintWebUIDelegate::createWebViewWithRequest): Create a new
573         MainWindow and return the IWebView.
574         (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser.
575         (PrintWebUIDelegate::Release): Ditto.
576         * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount.
577         (PrintWebUIDelegate::PrintWebUIDelegate):
578         * MiniBrowser/win/ResourceLoadDelegate.cpp:
579         (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser.
580         (ResourceLoadDelegate::Release): Ditto.
581         * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount.
582         * MiniBrowser/win/WebDownloadDelegate.cpp:
583         (WebDownloadDelegate::WebDownloadDelegate):
584         (WebDownloadDelegate::AddRef): Delegate to MiniBrowser.
585         (WebDownloadDelegate::Release): Ditto.
586         * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount.
587
588 2018-06-06  Fujii Hironori  <Hironori.Fujii@sony.com>
589
590         [Win][MiniBrowser] Remove gMainWindow global variable
591         https://bugs.webkit.org/show_bug.cgi?id=186378
592
593         Reviewed by Ryosuke Niwa.
594
595         I'm going to support multiple MainWindow in Bug 186263. It should
596         not be assumed that MainWindow has only one instance. gMainWindow
597         is used only in DisplayAuthDialog.
598
599         * MiniBrowser/win/Common.cpp:
600         (authDialogProc): Use DWLP_USER to store the dialog data.
601         (displayAuthDialog): Moved and renamed from
602         MainWindow::displayAuthDialog. Use DialogBoxParam instead of
603         DialogBox to pass a data pointer. Do not return S_OK if
604         DialogBoxParam returns -1. Take a HWND argument as the parent
605         window.
606         (DisplayAuthDialog): Deleted.
607         * MiniBrowser/win/Common.h:
608         * MiniBrowser/win/MainWindow.cpp:
609         (authDialogProc): Moved to Common.cpp.
610         (MainWindow::displayAuthDialog): Ditto.
611         * MiniBrowser/win/MainWindow.h:
612         * MiniBrowser/win/ResourceLoadDelegate.cpp:
613         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
614         * MiniBrowser/win/WinMain.cpp:
615         (wWinMain): Added a local variable mainWindow instead of using
616         gMainWindow.
617
618 2018-06-06  Dan Bernstein  <mitz@apple.com>
619
620         [Xcode] Opt out of the New Build System
621         https://bugs.webkit.org/show_bug.cgi?id=186380
622
623         Reviewed by Alexey Proskuryakov.
624
625         * Scripts/webkitdirs.pm:
626         (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.
627
628 2018-06-06  Antoine Quint  <graouts@apple.com>
629
630         Rename color-filter to -apple-color-filter and do not expose it to Web content
631         https://bugs.webkit.org/show_bug.cgi?id=186306
632         <rdar://problem/39874167>
633
634         Reviewed by Simon Fraser.
635
636         Adding an option to turn support for the -apple-color-filter property on via an HTML comment.
637
638         * DumpRenderTree/TestOptions.cpp:
639         (TestOptions::TestOptions):
640         * DumpRenderTree/TestOptions.h:
641         * DumpRenderTree/mac/DumpRenderTree.mm:
642         (setWebPreferencesForTestOptions):
643         * WebKitTestRunner/TestController.cpp:
644         (WTR::TestController::resetPreferencesToConsistentValues):
645         (WTR::updateTestOptionsFromTestHeader):
646         * WebKitTestRunner/TestOptions.h:
647         (WTR::TestOptions::hasSameInitializationOptions const):
648         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
649         (WTR::TestController::platformCreateWebView):
650
651 2018-06-06  Brent Fulgham  <bfulgham@apple.com>
652
653         Adjust compile and runtime flags to match shippable state of features (Part 2)
654         https://bugs.webkit.org/show_bug.cgi?id=186319
655         <rdar://problem/40352045>
656
657         Unreviewed test fix.
658
659         TestWebKitAPI was timing out because 'color' input types are no longer support. I also discovered that the
660         ASSERT_STREQ macro returns on error, which causes tests to time out whenever a 'done = true' call (needed to
661         end the test) is done after ASSERT_STREQ, which might fail and return early, preventing the flag from being
662         set.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
665         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]): Make testing of
666         the 'color' input type conditional on the feature being part of the build.
667         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
668         (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set the 'done=true' state before performing
669         string equality assertions, since they do an early return and bypass the end state of the test.
670         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto.
671         (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
672         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
673
674 2018-06-05  Chris Dumez  <cdumez@apple.com>
675
676         Regression(r232082): Websites get loaded inside of Messages App chat transcript
677         https://bugs.webkit.org/show_bug.cgi?id=186331
678         <rdar://problem/40735446>
679
680         Reviewed by Darin Adler.
681
682         Add API test coverage.
683
684         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm:
685         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
686         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartProvisionalLoadForFrame:]):
687         (TestWebKitAPI::TEST):
688         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Deleted.
689         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Deleted.
690         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): Deleted.
691
692 2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
693
694         DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
695         https://bugs.webkit.org/show_bug.cgi?id=186325
696         <rdar://problem/40527850>
697
698         Reviewed by Tim Horton.
699
700         Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
701         providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
702         text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
703         fidelity than plain text.
704
705         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
706         (checkRichTextTypePrecedesPlainTextType):
707         (TestWebKitAPI::TEST):
708         (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.
709
710 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
711
712         Adjust compile and runtime flags to match shippable state of features
713         https://bugs.webkit.org/show_bug.cgi?id=186319
714         <rdar://problem/40352045>
715
716         Reviewed by Maciej Stachowiak, Jon Lee, and others.
717
718         This patch revises the compile time and runtime state for various features to match their
719         suitability for end-user releases.
720
721         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
722         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
723         Cocoa builds.
724         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
725         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
726
727 2018-06-05  Saam Barati  <sbarati@apple.com>
728
729         run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
730         https://bugs.webkit.org/show_bug.cgi?id=186293
731
732         Reviewed by Mark Lam.
733
734         This makes it easier to execute run-testmem on a device that doesn't have ruby
735         on it. run-testmem now has a --dry option that will output commands to execute
736         in bash. To run on a device that doesn't have ruby, just put its output into
737         a bash script, and copy the PerformanceTests/testmem directory onto that device,
738         and execute the bash script. Running that bash script will give you raw output.
739         Make a file with that output and pass it into run-testmem using the --parse option.
740         run-testmem will parse the raw output and compute the benchmark score.
741
742         * Scripts/run-testmem:
743
744 2018-06-05  Youenn Fablet  <youenn@apple.com>
745
746         ServiceWorker registration should store any script fetched through importScripts
747         https://bugs.webkit.org/show_bug.cgi?id=182444
748         <rdar://problem/37164835>
749
750         Reviewed by Chris Dumez.
751
752         Add support to crash the storage process from Internals.
753
754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
755         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
756         (WTR::TestRunner::terminateStorageProcess):
757         * WebKitTestRunner/InjectedBundle/TestRunner.h:
758         * WebKitTestRunner/TestController.cpp:
759         (WTR::TestController::terminateStorageProcess):
760         * WebKitTestRunner/TestController.h:
761         * WebKitTestRunner/TestInvocation.cpp:
762         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
763
764 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
765
766         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
767         https://bugs.webkit.org/show_bug.cgi?id=186286
768         <rdar://problem/40782992>
769
770         Reviewed by Dan Bernstein.
771
772         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
773         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
774         change this flag when preparing for a production release.
775
776         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
777         determine whether experimental features should be enabled, and use it to properly define
778         the feature flag.
779
780 2018-06-05  Robin Morisset  <rmorisset@apple.com>
781
782         Add a grammar (in antlr4 format) to the WSL spec.
783         https://bugs.webkit.org/show_bug.cgi?id=186310
784
785         Rubberstamped by Filip Pizlo
786
787         It is just the raw rules, without much comments and no typesetting.
788         Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)
789
790         It does not exactly match the parser of the current js implementation of WSL, it:
791         - Accepts negative literals
792         - Reserves keywords fallthrough/auto
793         - Refuses '_' as a valid identifier
794         - Accepts several capitalizations for Null/True/False
795         - Accepts variable declarations at the top-level
796         - Correctly parses ternary expressions
797         - Forbids empty extension list for protocols
798         - Does not allow a space between '[' and ']' in type suffixes
799         - Correctly parses nested generics
800         - Accepts a 'fallthrough;' statement (for switches)
801         - Refuses chained relational operator (e.g. x < y < z)
802         - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
803         - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
804         There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
805         I will try to see if it can be automatically derived from the antlr4 grammar.
806
807         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.
808
809 2018-06-04  Frederic Wang  <fwang@igalia.com>
810
811         import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
812         https://bugs.webkit.org/show_bug.cgi?id=186261
813
814         Reviewed by Youenn Fablet.
815
816         * Scripts/webkitpy/w3c/test_parser.py:
817         (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
818         from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
819         the WPT repository.
820         * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
821         <meta name="flags"> are manual or non-manual according to CSS WG rules.
822
823 2018-06-04  Dan Bernstein  <mitz@apple.com>
824
825         Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.
826
827         * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
828           HaveInternalSDK.xcconfig, since it may not be preent.
829
830 2018-06-04  Dan Bernstein  <mitz@apple.com>
831
832         Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
833         default build system in the Xcode 10 developer beta.
834
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
836           built libWTF.a to be relative to the built products directory.
837
838 2018-06-04  Chris Dumez  <cdumez@apple.com>
839
840         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
841         https://bugs.webkit.org/show_bug.cgi?id=186287
842         <rdar://problem/40783352>
843
844         Reviewed by Youenn Fablet.
845
846         * DumpRenderTree/mac/DumpRenderTree.mm:
847         (enableExperimentalFeatures):
848         * DumpRenderTree/win/DumpRenderTree.cpp:
849         (enableExperimentalFeatures):
850
851 2018-06-04  Daniel Bates  <dabates@apple.com>
852
853         Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
854         https://bugs.webkit.org/show_bug.cgi?id=186290
855
856         Reviewed by Aakash Jain.
857
858         Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
859         questionable we should fix a typo when calling this mocked function with argument since.
860
861         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
862         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
863
864 2018-06-04  Dan Bernstein  <mitz@apple.com>
865
866         Fixed building with the macOS Mojave seed SDK.
867
868         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
869
870 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
871
872         Add Mojave support to WebKit tools
873         https://bugs.webkit.org/show_bug.cgi?id=186282
874
875         Reviewed by Daniel Bates.
876
877         Nightly build support will be added separately.
878
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
883         Added dashboard support.
884
885         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
886         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
887         Trigger the right build queues on check-in.
888
889         * Scripts/webkitpy/common/version_name_map.py:
890         * Scripts/webkitpy/common/version_name_map_unittest.py:
891         The main version mapping class updated.
892
893         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
894         * Scripts/webkitpy/port/mac_unittest.py:
895         Updated for more platforms in unit tests.
896
897         * TestResultServer/static-dashboards/flakiness_dashboard.js:
898         Added the new platform to flakiness dashboard.
899
900 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
901
902         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
903         https://bugs.webkit.org/show_bug.cgi?id=186279
904
905         Reviewed by Tim Horton.
906
907         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
908
909         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
910
911 2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
912
913         [Win][MiniBrowser] Remove gMiniBrowser global variable
914         https://bugs.webkit.org/show_bug.cgi?id=186134
915
916         Reviewed by Brent Fulgham.
917
918         It should not be assumed there is only one main window and one browser
919         window to support multiple windows properly. gMainWindow and
920         gMiniBrowser global variables should be removed. This change
921         removes gMiniBrowser.
922
923         * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
924         * MiniBrowser/win/Common.h: Ditto.
925         * MiniBrowser/win/MainWindow.cpp:
926         (MainWindow::init):
927         (MainWindow::WndProc):
928         (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
929         (MainWindow::cachesDialogProc): Renamed from Caches.
930         (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
931         (MainWindow::onURLBarEnter): Extracted from EditProc.
932         (BackButtonProc): Deleted.
933         (ForwardButtonProc): Deleted.
934         (Caches): Renamed to MainWindow::cachesDialogProc.
935         (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
936         * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
937         * MiniBrowser/win/MiniBrowserLibResource.h:
938         * MiniBrowser/win/WinMain.cpp:
939         (wWinMain):
940
941 2018-06-02  Darin Adler  <darin@apple.com>
942
943         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
944         https://bugs.webkit.org/show_bug.cgi?id=186227
945
946         Reviewed by Dan Bernstein.
947
948         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
949         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
950         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
951
952         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.
953
954         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
955         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
956         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
957         (AccessibilityTextMarker::isEqual): Ditto.
958         (AccessibilityTextMarkerRange::isEqual): Ditto.
959
960         * DumpRenderTree/mac/DumpRenderTree.mm:
961         (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
962         (DumpRenderTreeMain): Ditto.
963         (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
964         (runTest): Ditto.
965
966         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
967         (copyFile): Use a std::pair to return both a URL and an error rather than using an
968         out argument for the NSError.
969         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
970         Updated for the above change.
971
972         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
973         (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
974         (-[DumpRenderTreeWindow close]): Ditto.
975         * DumpRenderTree/mac/LayoutTestHelper.m:
976         (setDisplayColorProfile): Ditto.
977
978         * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.
979
980         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
981         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
982         Add __bridge to a bridging typecast.
983         * DumpRenderTree/mac/TestRunnerMac.mm:
984         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
985         (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.
986
987         * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.
988
989         * DumpRenderTree/mac/UIScriptControllerMac.mm:
990         (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
991         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
992         (WTR::UIScriptController::overridePreference): Ditto.
993         * DumpRenderTree/mac/WorkQueueItemMac.mm:
994         (LoadItem::invoke const): Ditto.
995         (LoadHTMLStringItem::invoke const): Ditto.
996         (ScriptItem::invoke const): Ditto.
997
998         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
999         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1000         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1001
1002         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1003         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1004         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1005
1006         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1007         (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
1008         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1009         (-[NSString createJSStringRef]): Ditto.
1010         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
1011         (WTR::AccessibilityTextMarker::isEqual): Ditto.
1012         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
1013         (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
1014         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1015         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
1016         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
1017         (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
1018         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
1019         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
1020         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
1021         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
1022         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
1023         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
1024         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
1025         (WTR::createJSStringRef): Ditto.
1026         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
1027         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
1028         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
1029         (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
1030         (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
1031         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
1032         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
1033         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
1034         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
1035         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
1036         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
1037         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
1038         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
1039         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
1040         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
1041         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1042         (WTR::initializeWebViewConfiguration): Ditto.
1043         (WTR::TestController::platformContext): Ditto.
1044         (WTR::TestController::platformPreferences): Ditto.
1045         (WTR::TestController::platformAdjustContext): Ditto.
1046         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1047         (WTR::PlatformWebView::PlatformWebView): Ditto.
1048         * WebKitTestRunner/mac/TestControllerMac.mm:
1049         (WTR::TestController::initializeInjectedBundlePath): Ditto.
1050         (WTR::TestController::initializeTestPluginDirectory): Ditto.
1051         (WTR::TestController::platformConfigureViewForTest): Ditto.
1052
1053         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1054         (WTR::nsString): Use CFBridgingRelease instead of autorelease.
1055         (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
1056         typecast.
1057
1058         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.
1059
1060         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
1061         (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
1062         (-[LocalPasteboard setString:forType:]): Ditto.
1063
1064         * WebKitTestRunner/mac/main.mm:
1065         (main): Use @autoreleasepool instead of NSAutoreleasePool.
1066
1067 2018-06-02  Keith Miller  <keith_miller@apple.com>
1068
1069         run-jsc should pass the option to use dollar vm by default
1070         https://bugs.webkit.org/show_bug.cgi?id=186170
1071
1072         Reviewed by Yusuke Suzuki.
1073
1074         * Scripts/run-jsc:
1075
1076 2018-06-02  Commit Queue  <commit-queue@webkit.org>
1077
1078         Unreviewed, rolling out r232421.
1079         https://bugs.webkit.org/show_bug.cgi?id=186240
1080
1081         Breaks webkitpy tests (Requested by aakashjain on #webkit).
1082
1083         Reverted changeset:
1084
1085         "Add some tests for lldb_webkit.py"
1086         https://bugs.webkit.org/show_bug.cgi?id=183744
1087         https://trac.webkit.org/changeset/232421
1088
1089 2018-06-01  Daniel Bates  <dabates@apple.com>
1090
1091         Add some tests for lldb_webkit.py
1092         https://bugs.webkit.org/show_bug.cgi?id=183744
1093
1094         Reviewed by Alexey Proskuryakov.
1095
1096         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
1097         and WTF::String objects.
1098
1099         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
1100         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
1101         on Mac.
1102
1103         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
1104         * Scripts/build-lldbwebkittester: Added.
1105         (buildProjectOrDie):
1106         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
1107         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
1108         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
1109         the file and take advantage of Python's default error semantics to throw an exception
1110         if the import fails instead of handling it ourself. This has the side effect that we
1111         now always import the LLDB Python module even if this script is invoked with --help.
1112         If this turns out to be a significant annoyance then we can look to dynamically import
1113         the module as we did before this change.
1114         (webkit_build_dir):
1115         (main):
1116         (developer_dir): Deleted.
1117         (import_lldb): Deleted.
1118         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
1119         that fact that test-webkitpy does not support class and module fixtures. This is because
1120         test-webkitpy currently implements parallelism by breaking down existing test classes
1121         into individual test methods itself and having each worker run exactly one test method (via
1122         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
1123         setUpModule()/setUpClass() are called for each test method as opposed to once per test
1124         class/test module.
1125         (remove_dir): Ditto.
1126         * Scripts/webkitpy/common/system/systemhost.py:
1127         (SystemHost):
1128         (SystemHost.path_to_lldb_python_directory): Added.
1129         * Scripts/webkitpy/test/main.py:
1130         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
1131         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
1132         lldbWebKitTester on Mac.
1133         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
1134         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
1135         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
1136         If we will run these tests then build lldbWebKitTester if it has not already been built as the
1137         unit tests depend on this program.
1138         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
1139         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
1140         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
1141         * lldb/lldbWebKitTester/Makefile: Added.
1142         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
1143         * lldb/lldbWebKitTester/main.cpp: Added.
1144         (breakForTestingSummaryProviders):
1145         (utf16String):
1146         (testSummaryProviders):
1147         (main):
1148         * lldb/lldb_webkit_unittest.py: Added.
1149         (destroy_cached_debug_session):
1150         (LLDBDebugSession):
1151         (LLDBDebugSession.setup):
1152         (LLDBDebugSession.tearDown):
1153         (TestSummaryProviders):
1154         (TestSummaryProviders.setUpClass):
1155         (TestSummaryProviders._sbFrame):
1156         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
1157         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
1158         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
1159         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
1160         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
1161         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
1162         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
1163         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
1164
1165 2018-06-01  Frederic Wang  <fwang@igalia.com>
1166
1167         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
1168         https://bugs.webkit.org/show_bug.cgi?id=186133
1169
1170         Reviewed by Youenn Fablet.
1171
1172         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
1173         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
1174
1175 2018-05-31  Frederic Wang  <fwang@igalia.com>
1176
1177         export-w3c-test-changes should use the new location & name of the WPT repo
1178         https://bugs.webkit.org/show_bug.cgi?id=186135
1179
1180         Reviewed by Youenn Fablet.
1181
1182         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
1183         corresponding variables to use the new organization and repository name. It also refactors a
1184         bit the code to reduce the amount of hardcoded strings.
1185
1186         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
1187         final slash to WPT_GH_URL, so it can be used for repo URL too.
1188         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
1189         WPT_GH_URL.
1190         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
1191         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
1192         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
1193         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
1194         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
1195         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
1196         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1197         (TestExporterTest.test_export): Update organization and repository names for the remote
1198         branch and pull request.
1199         (TestExporterTest.test_export_with_specific_branch): Update repository name.
1200
1201 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1202
1203         Update expected results for BuildStepsConstructorTest
1204         https://bugs.webkit.org/show_bug.cgi?id=186119
1205
1206         Reviewed by Alex Christensen.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
1209
1210 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
1211
1212         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
1213         https://bugs.webkit.org/show_bug.cgi?id=185831
1214         <rdar://problem/40468716>
1215
1216         Reviewed by David Kilzer.
1217
1218         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1219         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1220         (TEST):
1221
1222 2018-05-31  Chris Dumez  <cdumez@apple.com>
1223
1224         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
1225         https://bugs.webkit.org/show_bug.cgi?id=184893
1226         <rdar://problem/39747271>
1227
1228         Reviewed by Wenson Hsieh.
1229
1230         Update test to wait until the view is the expected height instead of
1231         calling waitForNextPresentationUpdate once and expect the view to
1232         have the right height. This fixes the flakiness.
1233
1234         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1235         (TestWebKitAPI::waitUntilInnerHeightIs):
1236         (TestWebKitAPI::TEST):
1237
1238 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
1239
1240         test262-runner should run in verbose mode in automation
1241         https://bugs.webkit.org/show_bug.cgi?id=186115
1242
1243         Reviewed by Yusuke Suzuki.
1244
1245         This patch toggles the verbose mode in the build bot and reports every test file
1246         in order to avoid the '1200 seconds without output' issue.
1247         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1248         (RunTest262Tests):
1249         * Scripts/test262/Runner.pm:
1250         (processResult):
1251
1252 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1253
1254         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
1255         https://bugs.webkit.org/show_bug.cgi?id=186079
1256
1257         Reviewed by Alex Christensen.
1258
1259         This is a sub task of Bug 184770.
1260
1261         This change is partial. I'm going to remove global variables
1262         gMainWindow and gMiniBrowser and convert more functions to
1263         MainWindow's methods in follow-up patches.
1264
1265         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
1266         * MiniBrowser/win/Common.cpp:
1267         (menuItemIsChecked): Moved to MainWindow.cpp.
1268         (turnOffOtherUserAgents): Ditto.
1269         (EditProc): Ditto.
1270         (BackButtonProc): Ditto.
1271         (ForwardButtonProc): Ditto.
1272         (About): Ditto.
1273         (Caches): Ditto.
1274         (CustomUserAgent): Ditto.
1275         (AuthDialogProc): Ditto.
1276         (DisplayAuthDialog): Converted to MainWindow's method.
1277         (ToggleMenuItem): Ditto.
1278         (loadURL): Ditto.
1279         * MiniBrowser/win/Common.h:
1280         * MiniBrowser/win/MainWindow.cpp:
1281         (MainWindow::init): Call SetFocus at the end of the construction.
1282         (MainWindow::WndProc):
1283         (menuItemIsChecked): Moved from Common.cpp.
1284         (turnOffOtherUserAgents): Ditto.
1285         (EditProc): Ditto.
1286         (BackButtonProc): Ditto.
1287         (ForwardButtonProc): Ditto.
1288         (About): Ditto.
1289         (Caches): Ditto.
1290         (CustomUserAgent): Ditto.
1291         (authDialogProc): Ditto.
1292         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
1293         (MainWindow::toggleMenuItem): Ditto.
1294         (MainWindow::loadURL): Ditto.
1295         * MiniBrowser/win/MainWindow.h: Added method declarations.
1296         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
1297         * MiniBrowser/win/WinMain.cpp:
1298         (wWinMain): Include Common.h instead of Common.cpp.
1299
1300 2018-05-30  Brady Eidson  <beidson@apple.com>
1301
1302         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
1303         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
1304
1305         Reviewed by Andy Estes.
1306
1307         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1309         (WTR::TestRunner::setCustomUserAgent):
1310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::TestController::resetStateToConsistentValues):
1313         * WebKitTestRunner/TestInvocation.cpp:
1314         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1315
1316 2018-05-30  Youenn Fablet  <youenn@apple.com>
1317
1318         Rename CrossOriginResourcePolicy same to same-origin
1319         https://bugs.webkit.org/show_bug.cgi?id=186080
1320
1321         Reviewed by Chris Dumez.
1322
1323         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1324         (TestWebKitAPI::TEST):
1325
1326 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
1327
1328         [GTK] Unreviewed test gardening
1329         https://bugs.webkit.org/show_bug.cgi?id=186098
1330
1331         Unreviewed gardening.
1332
1333         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
1334
1335 2018-05-29  Youenn Fablet  <youenn@apple.com>
1336
1337         Add a consistency check between URL and CFURL
1338         https://bugs.webkit.org/show_bug.cgi?id=182444
1339         <rdar://problem/37164835>
1340
1341         Reviewed by Geoff Garen.
1342
1343         DRT code expected a non null URL which is no longer the case now.
1344         Updated DRT to remove that assumption.
1345
1346         * DumpRenderTree/TestRunner.cpp:
1347         (TestRunner::redirectionDestinationForURL):
1348         * DumpRenderTree/TestRunner.h:
1349         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1350         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1351
1352 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
1353
1354         Export changes to web-platform-test as part of the webkit-patch upload workflow
1355         https://bugs.webkit.org/show_bug.cgi?id=184914
1356
1357         Reviewed by Youenn Fablet.
1358
1359         * Scripts/webkitpy/tool/commands/upload.py:
1360         (Upload):
1361         (CreateBug.execute):
1362         (WPTChangeExport):
1363         * Scripts/webkitpy/tool/steps/__init__.py:
1364         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1365         (WPTChangeExport):
1366         (WPTChangeExport.options):
1367         (WPTChangeExport.run):
1368         * Scripts/webkitpy/w3c/common.py:
1369         * Scripts/webkitpy/w3c/test_exporter.py:
1370         (WebPlatformTestExporter):
1371         (WebPlatformTestExporter.__init__):
1372         (WebPlatformTestExporter.username):
1373         (WebPlatformTestExporter.token):
1374         (WebPlatformTestExporter._github):
1375         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1376         (WebPlatformTestExporter._wpt_fork_remote):
1377         (WebPlatformTestExporter._wpt_fork_push_url):
1378         (WebPlatformTestExporter._git):
1379         (WebPlatformTestExporter._branch_name):
1380         (WebPlatformTestExporter._public_branch_name):
1381         (WebPlatformTestExporter._wpt_patch):
1382         (WebPlatformTestExporter.has_wpt_changes):
1383         (WebPlatformTestExporter._find_filename):
1384         (WebPlatformTestExporter._is_ignored_file):
1385         (WebPlatformTestExporter._strip_ignored_files_from_diff):
1386         (WebPlatformTestExporter.write_git_patch_file):
1387         (WebPlatformTestExporter._prompt_for_token):
1388         (WebPlatformTestExporter._prompt_for_username):
1389         (WebPlatformTestExporter._ensure_username_and_token):
1390         (WebPlatformTestExporter._validate_and_save_token):
1391         (WebPlatformTestExporter.create_branch_with_patch):
1392         (WebPlatformTestExporter.push_to_wpt_fork):
1393         (WebPlatformTestExporter.make_pull_request):
1394         (WebPlatformTestExporter.delete_local_branch):
1395         (WebPlatformTestExporter.create_upload_remote_if_needed):
1396         (WebPlatformTestExporter.do_export):
1397         (parse_args):
1398         (TestExporter): Deleted.
1399         (TestExporter.__init__): Deleted.
1400         (TestExporter._ensure_wpt_repository): Deleted.
1401         (TestExporter._fetch_wpt_repository): Deleted.
1402         (TestExporter._ensure_new_branch_name): Deleted.
1403         (TestExporter.download_and_commit_patch): Deleted.
1404         (TestExporter.clean): Deleted.
1405         (TestExporter.create_branch_with_patch): Deleted.
1406         (TestExporter.push_to_wpt_fork): Deleted.
1407         (TestExporter.make_pull_request): Deleted.
1408         (TestExporter.create_wpt_pull_request): Deleted.
1409         (TestExporter.delete_local_branch): Deleted.
1410         (TestExporter.create_git_patch): Deleted.
1411         (TestExporter.create_upload_remote): Deleted.
1412         (TestExporter.do_export): Deleted.
1413         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1414         (TestExporterTest.MockGit):
1415         (TestExporterTest.MockGit.create_patch):
1416         (TestExporterTest.test_export):
1417         (TestExporterTest.test_export_with_specific_branch):
1418         (TestExporterTest):
1419         (TestExporterTest.test_export_interactive_mode):
1420         (TestExporterTest.test_export_invalid_token):
1421         (TestExporterTest.test_export_wrong_token):
1422         (TestExporterTest.test_has_wpt_changes):
1423         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
1424         (TestExporterTest.test_ignore_changes_to_expected_file):
1425
1426 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1427
1428         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
1429         https://bugs.webkit.org/show_bug.cgi?id=186029
1430
1431         Reviewed by Alex Christensen.
1432
1433         This is a sub task of Bug 184770.
1434
1435         * MiniBrowser/win/Common.cpp:
1436         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
1437         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
1438         (AbortProc): Moved to MiniBrowser.cpp.
1439         (getPrinterDC): Ditto.
1440         (initDocStruct): Ditto.
1441         (PrintView): Ditto.
1442         (ToggleMenuFlag): Ditto.
1443         (setWindowText): Ditto.
1444         (updateStatistics): Ditto.
1445         * MiniBrowser/win/MainWindow.cpp:
1446         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
1447         * MiniBrowser/win/MiniBrowser.cpp:
1448         (AbortProc): Moved from Common.cpp.
1449         (getPrinterDC): Moved from Common.cpp.
1450         (initDocStruct): Moved from Common.cpp.
1451         (setWindowText): Moved from Common.cpp.
1452         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
1453         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
1454         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
1455         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
1456         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
1457
1458 2018-05-29  Saam Barati  <sbarati@apple.com>
1459
1460         JSC should put bmalloc's scavenger into mini mode
1461         https://bugs.webkit.org/show_bug.cgi?id=185988
1462
1463         Reviewed by Michael Saboff.
1464
1465         This patch makes it so that we turn off the JIT when running run-testmem
1466         that way we make JSC use its mini mode.
1467
1468         * Scripts/run-testmem:
1469
1470 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
1471
1472         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
1473         https://bugs.webkit.org/show_bug.cgi?id=185835
1474         <rdar://problem/39142257>
1475
1476         Reviewed by Chris Dumez.
1477
1478         Add API test coverage.
1479
1480         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1481         (TEST):
1482
1483 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1484
1485         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
1486         https://bugs.webkit.org/show_bug.cgi?id=186042
1487         <rdar://problem/40604182>
1488
1489         Reviewed by Tim Horton.
1490
1491         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
1492         significant portion of the page has been painted before document load is finished.
1493
1494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1495         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
1496         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
1497         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
1498         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
1499         (-[RenderingProgressHandler initWithHandler:]):
1500         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
1501         (TEST):
1502
1503 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
1504
1505         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
1506         https://bugs.webkit.org/show_bug.cgi?id=186040
1507
1508         The patch we merge contained a type and was merged in upstream GStreamer fixing that
1509         (s/avalaible/available/).
1510
1511         Reviewed by Xabier Rodriguez-Calvar.
1512
1513         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
1514
1515 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
1516
1517         Add an API test to check process privilege when using Cookie API
1518         https://bugs.webkit.org/show_bug.cgi?id=185406
1519
1520         Reviewed by Geoffrey Garen.
1521
1522         Add API test coverage.
1523
1524         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1525         (TEST):
1526
1527 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
1528
1529         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
1530         https://bugs.webkit.org/show_bug.cgi?id=185948
1531
1532         Reviewed by Xabier Rodriguez-Calvar.
1533
1534         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
1535         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
1536         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
1537         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
1538
1539         * gstreamer/jhbuild.modules:
1540         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
1541         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
1542         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
1543
1544 2018-05-27  Dan Bernstein  <mitz@apple.com>
1545
1546         Reverted the changes made for https://webkit.org/b/186016
1547
1548         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1549
1550 2018-05-27  Dan Bernstein  <mitz@apple.com>
1551
1552         [Cocoa] Avoid importing directly from subumbrella frameworks
1553         https://bugs.webkit.org/show_bug.cgi?id=186016
1554
1555         Reviewed by Sam Weinig.
1556
1557         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1558           LaunchServices header.
1559         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1560           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1561         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1562           when using SDKs earlier than 10.13.
1563         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1564           and OTHER_CPLUSPLUSFLAGS.
1565         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
1566           HIToolbox header.
1567         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1568           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1569         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1570           LaunchServices header.
1571
1572 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1573
1574         [Win][MiniBrowser] Add MainWindow class
1575         https://bugs.webkit.org/show_bug.cgi?id=185814
1576
1577         Reviewed by Per Arne Vollan.
1578
1579         This is a sub task of Bug 184770. Added a new class MainWindow to
1580         represent the main window which will be shared among WK1 and WK2.
1581
1582         This change is partial so that it's easy to review this patch.
1583         I'll move more functions into MainWindow.cpp, and remove more
1584         global variables in forthcoming patches.
1585
1586         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
1587         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
1588         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
1589         hForwardButtonWnd. Added a new global variable gMainWindow.
1590         (WndProc): Moved to MainWindow.cpp.
1591         (resizeSubViews): Ditto.
1592         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
1593         (ToggleMenuItem): Ditto.
1594         (CustomUserAgent): Follow the global variables removal.
1595         (DisplayAuthDialog): Ditto.
1596         (loadURL): Ditto.
1597         (WndProc): Renamed to MainWindow::WndProc.
1598         * MiniBrowser/win/MainWindow.cpp: Added.
1599         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
1600         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
1601         (MainWindow::resizeSubViews): Moved from Common.cpp.
1602         (MainWindow::WndProc): Ditto.
1603         * MiniBrowser/win/MainWindow.h: Added.
1604         (MainWindow::hwnd):
1605         (MainWindow::browserWindow):
1606         * MiniBrowser/win/MiniBrowser.cpp:
1607         (MiniBrowser::init):
1608         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
1609         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
1610         * MiniBrowser/win/MiniBrowser.h:
1611         * MiniBrowser/win/WinMain.cpp:
1612         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
1613         (MyRegisterClass): Moved to MainWindow.cpp.
1614
1615 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1616
1617         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
1618         https://bugs.webkit.org/show_bug.cgi?id=185969
1619
1620         Reviewed by Alex Christensen.
1621
1622         MiniBrowser::init takes URL argument, but it's used only for
1623         loading default HTML if URL is not given.
1624
1625         - Add a new method MiniBrowser::loadHTMLString
1626         - Remove loadHTMLString process from MiniBrowser::prepareViews
1627
1628         * MiniBrowser/win/MiniBrowser.cpp:
1629         (MiniBrowser::init): Removed `requestedURL` argument.
1630         (MiniBrowser::prepareViews): Ditto.
1631         (MiniBrowser::loadHTMLString): New.
1632         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
1633         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
1634         * MiniBrowser/win/WinMain.cpp:
1635         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
1636
1637 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1638
1639         svn-apply fails when a patch has an empty file
1640         <https://webkit.org/b/29684>
1641
1642         Reviewed by Daniel Bates.
1643
1644         Prior to this change, applying the following patches resulted in:
1645         - svn: add empty file     (failure)
1646         - svn: delete empty file  (failure)
1647         - svn: rename empty file  (failure)
1648         - git: add empty file     (false-positive success)
1649         - git: delete empty file  (success)
1650         - git: rename empty file  (failure)
1651
1652         * Scripts/VCSUtils.pm:
1653         (parseSvnDiffHeader): Handle the case when there is no patch
1654         following the header.  If the file exists and is empty, that
1655         means it's a deletion.  If the file does not exist, that means
1656         it's an addition. Everything else is a fatal error.
1657         * Scripts/svn-apply:
1658         (patch):
1659         - Only apply a patch for deletion if it has one or more text
1660           chunks.
1661         - Add a case to handle adding an empty file (an addition with no
1662           text chunks), and verify the file doesn't exist yet.
1663         - Any unhandled patch is a fatal error.
1664         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1665         Add tests for adding an empty file and deleting an empty file.
1666         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
1667         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
1668         test case.
1669
1670 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
1671
1672         Display detailed error logs when a script fails in EWS
1673         https://bugs.webkit.org/show_bug.cgi?id=175696
1674         <rdar://problem/34841885>
1675
1676         Reviewed by Darin Adler.
1677
1678         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
1679         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
1680         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1681         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
1682         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1683         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
1684
1685 2018-05-25  Daniel Bates  <dabates@apple.com>
1686
1687         test-webkitpy messages logged using __main__ logger are not displayed
1688         https://bugs.webkit.org/show_bug.cgi?id=185823
1689
1690         Rubber-stamped by Aakash Jain.
1691
1692         Configure the logger for __main__ so that messages that are logged before it parses its
1693         command line arguments are printed to standard error.
1694
1695         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
1696         not configure a stream to use for printing until after it parses its command line arguments
1697         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
1698         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
1699         earlier because the latter both configures a stream and filters logged messages based on
1700         the specified verbosity. Logged messaged from code in __main__ should not be subject to
1701         such filtering. So, we explicitly configure the __main__ logger.
1702
1703         * Scripts/webkitpy/test/main.py:
1704         (main):
1705
1706 2018-05-25  Saam Barati  <sbarati@apple.com>
1707
1708         Make JSC have a mini mode that kicks in when the JIT is disabled
1709         https://bugs.webkit.org/show_bug.cgi?id=185931
1710
1711         Reviewed by Mark Lam.
1712
1713         This renames a variable for clarity.
1714
1715         * Scripts/run-testmem:
1716
1717 2018-05-25  Alex Christensen  <achristensen@webkit.org>
1718
1719         URL::host should return a StringView to reduce allocations
1720         https://bugs.webkit.org/show_bug.cgi?id=185986
1721
1722         Reviewed by Geoff Garen.
1723
1724         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1725         (TestWebKitAPI::TEST_F):
1726         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1727         (TestWebKitAPI::eq):
1728         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
1729         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1730
1731 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
1732
1733         Minor improvements to wpt exporter.
1734         https://bugs.webkit.org/show_bug.cgi?id=185978
1735
1736         Reviewed by Youenn Fablet.
1737
1738         * Scripts/webkitpy/w3c/test_exporter.py:
1739         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
1740         (TestExporter.make_pull_request): Improve the description of the created PR.
1741         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
1742
1743 2018-05-25  Saam Barati  <sbarati@apple.com>
1744
1745         Have a memory test where we can validate JSCs mini memory mode
1746         https://bugs.webkit.org/show_bug.cgi?id=185932
1747
1748         Reviewed by Mark Lam.
1749
1750         This patch adds the run-testmem script. This runs the new testmem
1751         CLI against the contents in the testmem benchmark. The contents of testmem
1752         contain tests from ARES-6, Sunspider, Octane, and JetStream.
1753         
1754         One iteration of the benchmark comprises of running each testmem test for
1755         a certain number of iterations. We collect the peak memory usage, the memory
1756         usage after running all the iterations, and the time it takes to run all the
1757         iterations. We then run the entire benchmark 3 times over. For each test, we
1758         compute the arithmetic mean over each iteration for time, peak memory, and
1759         end memory. The benchmark then computes a time score and memory score.
1760         
1761         peak memory score = geomean({peak memory of each individual test})
1762         end memory score = geomean({end memory of each individual test})
1763         memory score = geomean({peak memory score, end memory score})
1764         time score = geomean({time score of each individual test})
1765         
1766         We want the memory score to weigh improvements to peak memory usage and
1767         memory usage at the end equally.
1768         
1769         We plan to tune this benchmark in JSC's mini mode by improving the memory
1770         score while ensuring the time score is not more than 10-15% regressed.
1771
1772         * Scripts/run-testmem: Added.
1773
1774 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
1775
1776         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1777         https://bugs.webkit.org/show_bug.cgi?id=185041
1778         <rdar://problem/34684214>
1779
1780         Reviewed by Geoffrey Garen.
1781
1782         Add API test coverage.
1783
1784         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1785         (TEST):
1786
1787 2018-05-24  Chris Dumez  <cdumez@apple.com>
1788
1789         Reduce copying of FontCascadeDescription objects by moving them around
1790         https://bugs.webkit.org/show_bug.cgi?id=185963
1791
1792         Reviewed by Simon Fraser.
1793
1794         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1795
1796         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1797         (TestWebKitAPI::TEST_F):
1798
1799 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1800
1801         WebDriver: implement maximize, minimize and fullscreen window commands
1802         https://bugs.webkit.org/show_bug.cgi?id=180398
1803
1804         Reviewed by Brian Burg.
1805
1806         * Scripts/webkitpy/port/xvfbdriver.py:
1807         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
1808
1809 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1810
1811         [GStreamer] Save some time disabling some compile options in the dependencies
1812         https://bugs.webkit.org/show_bug.cgi?id=185909
1813
1814         Reviewed by Philippe Normand.
1815
1816         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
1817         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
1818
1819 2018-05-23  Roy Reapor  <rreapor@apple.com>
1820
1821         Use Helvetica on build.webkit.org webpages
1822         https://bugs.webkit.org/show_bug.cgi?id=185894
1823
1824         Reviewed by Aakash Jain.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1829
1830 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
1831
1832         Add Buildbot configuration for Opensource EWS
1833         https://bugs.webkit.org/show_bug.cgi?id=185484
1834
1835         Rubber-stamped by Alexey Proskuryakov.
1836
1837         * BuildSlaveSupport/ews-build/config.json: Added, config file.
1838         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
1839         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
1840         (loadBuilderConfig): Loads the configuration.
1841         (checkValidWorker): Checks if the worker is valid.
1842         (checkValidBuilder): Checks if the builder is valid.
1843         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
1844         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
1845         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
1846         (getValidTags): Returns a list of valid tags.
1847         (getTagsForBuilder): Return a list of tags for given builder.
1848         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
1849         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
1850
1851 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
1852
1853         [GTK] Silence GCC 8 warnings
1854         https://bugs.webkit.org/show_bug.cgi?id=185556
1855
1856         Reviewed by Žan Doberšek.
1857
1858         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
1859         source and destination are always identical. But switching to snprintf avoids the warning.
1860
1861         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
1862         (FormValue::NPP_GetValue):
1863
1864 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
1865
1866         Unreviewed, rolling out r232112.
1867
1868         The tests added with this change  are failing on the bots.
1869
1870         Reverted changeset:
1871
1872         "test262/Runner.pm: add unit tests"
1873         https://bugs.webkit.org/show_bug.cgi?id=185783
1874         https://trac.webkit.org/changeset/232112
1875
1876 2018-05-23  Valerie R Young  <valerie@bocoup.com>
1877
1878         test262/Runner.pm: add unit tests
1879         https://bugs.webkit.org/show_bug.cgi?id=185783
1880
1881         Reviewed by Aakash Jain.
1882
1883         Add unit tests to be run by test-webkitperl
1884
1885         * Scripts/test262/Runner.pm:
1886         (main):
1887          - If harness files cannot be found in a custom, supplies test262 path,
1888            then sure the webkit test262 harness files.
1889          - Lazily create the test262-results directory.
1890          - If an expectation file is supplied via command line, save to the
1891            supplied location instead of the detault webkit location.
1892         (compileTest):
1893         (processResult):
1894         (getHarness):
1895         * Scripts/webkitperl/test262_unittest/README: Added.
1896         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
1897         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
1898         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
1899         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
1900         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
1901         (f):
1902         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
1903         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
1904         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
1905         (f):
1906         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
1907
1908 2018-05-22  Roy Reapor  <rreapor@apple.com>
1909
1910         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
1911         https://bugs.webkit.org/show_bug.cgi?id=185788
1912
1913         Reviewed by Aakash Jain.
1914
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1920         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1921         * TestResultServer/static-dashboards/run-unittests.html:
1922
1923 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1924
1925         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
1926         https://bugs.webkit.org/show_bug.cgi?id=185831
1927
1928         Reviewed by Chris Dumez.
1929
1930         Updated the test to prevent crash after assertion fails.
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1933         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1934
1935 2018-05-22  Chris Dumez  <cdumez@apple.com>
1936
1937         Regression(AsyncPolicyDelegates): Box.app login Window is blank
1938         https://bugs.webkit.org/show_bug.cgi?id=185832
1939         <rdar://problem/40307871>
1940
1941         Reviewed by Geoffrey Garen.
1942
1943         Add API test coverage.
1944
1945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1946         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
1947         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
1948         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1949         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
1950         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
1951         (TestWebKitAPI::TEST):
1952         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1953         (-[WKWebView _isBackground]):
1954
1955 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1956
1957         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
1958         https://bugs.webkit.org/show_bug.cgi?id=185715
1959
1960         Reviewed by Geoffrey Garen.
1961
1962         Add API test coverage.
1963
1964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1965         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
1966         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1967         (TEST):
1968
1969 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1970
1971         Unreviewed, added myself as a WebKit committer.
1972
1973         * Scripts/webkitpy/common/config/contributors.json:
1974
1975 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
1976
1977         Unreviewed, rolling out r232052.
1978
1979         Breaks internal builds.
1980
1981         Reverted changeset:
1982
1983         "Use more C++17"
1984         https://bugs.webkit.org/show_bug.cgi?id=185176
1985         https://trac.webkit.org/changeset/232052
1986
1987 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
1988
1989         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
1990         https://bugs.webkit.org/show_bug.cgi?id=185689
1991
1992         Reviewed by Philippe Normand.
1993
1994         And update the patches, removing the ones that have been merged upstream.
1995
1996         * gstreamer/jhbuild.modules:
1997         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
1998         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
1999         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
2000         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
2001         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
2002         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
2003         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
2004         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
2005
2006 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2007
2008         Use more C++17
2009         https://bugs.webkit.org/show_bug.cgi?id=185176
2010
2011         Reviewed by JF Bastien.
2012
2013         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2014         * ImageDiff/cg/Configurations/Base.xcconfig:
2015         * MiniBrowser/Configurations/Base.xcconfig:
2016         * MobileMiniBrowser/Configurations/Base.xcconfig:
2017         * TestWebKitAPI/Configurations/Base.xcconfig:
2018         * WebKitTestRunner/Configurations/Base.xcconfig:
2019
2020 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2021
2022         [WinCairo] Enable WebKit build by default
2023         https://bugs.webkit.org/show_bug.cgi?id=185141
2024
2025         Reviewed by Per Arne Vollan.
2026
2027         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
2028         WebKitForwardingHeaders because config.h includes a header of WK2.
2029
2030         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
2031         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
2032
2033 2018-05-21  Jer Noble  <jer.noble@apple.com>
2034
2035         Complete fix for enabling modern EME by default
2036         https://bugs.webkit.org/show_bug.cgi?id=185770
2037         <rdar://problem/40368220>
2038
2039         Reviewed by Eric Carlson.
2040
2041         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2042
2043 2018-05-18  Christopher Reid  <chris.reid@sony.com>
2044
2045         Unreviewed, add myself as a WebKit committer.
2046
2047         * Scripts/webkitpy/common/config/contributors.json:
2048
2049 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2050
2051         Unreviewed, rolling out r222967.
2052
2053         It's not ready yet
2054
2055         Reverted changeset:
2056
2057         "[GTK][WPE] Add API to configure and enable resource load
2058         statistics"
2059         https://bugs.webkit.org/show_bug.cgi?id=177943
2060         https://trac.webkit.org/changeset/222967
2061
2062 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2063
2064         [GTK] MiniBrowser crashes when loading twice quickly
2065         https://bugs.webkit.org/show_bug.cgi?id=185763
2066
2067         Reviewed by Michael Catanzaro.
2068
2069         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
2070         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
2071         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
2072         leaked, it will crash when scheduled if the window has already been destroyed.
2073
2074         * MiniBrowser/gtk/BrowserWindow.c:
2075         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
2076
2077 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
2078
2079         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
2080         https://bugs.webkit.org/show_bug.cgi?id=185624
2081         <rdar://problem/39111626>
2082
2083         Reviewed by Chris Dumez.
2084
2085         Modified expectation to make test more robust as cookies can be returned in different orders.
2086
2087         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2088         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2089         (TEST):
2090
2091 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2092
2093         Unreviewed, rolling out r231982.
2094         https://bugs.webkit.org/show_bug.cgi?id=185793
2095
2096         Caused layout test failures (Requested by realdawei on
2097         #webkit).
2098
2099         Reverted changeset:
2100
2101         "Complete fix for enabling modern EME by default"
2102         https://bugs.webkit.org/show_bug.cgi?id=185770
2103         https://trac.webkit.org/changeset/231982
2104
2105 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
2106
2107         Handle failure to extend sandbox gracefully
2108         https://bugs.webkit.org/show_bug.cgi?id=185779
2109         <rdar://problem/40316349>
2110
2111         Unreviewed, fix test results.
2112
2113         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2114         (TEST_F):
2115
2116 2018-05-18  Jer Noble  <jer.noble@apple.com>
2117
2118         Complete fix for enabling modern EME by default
2119         https://bugs.webkit.org/show_bug.cgi?id=185770
2120         <rdar://problem/40368220>
2121
2122         Reviewed by Eric Carlson.
2123
2124         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2125
2126 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
2127
2128         Handle failure to extend sandbox gracefully
2129         https://bugs.webkit.org/show_bug.cgi?id=185779
2130         <rdar://problem/40316349>
2131
2132         Reviewed by Brent Fulgham.
2133
2134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2135         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
2136         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
2137         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2138         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2139         (MediaCaptureSimulateFailedSandbox::SetUp):
2140         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
2141         (TEST_F):
2142         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
2143
2144 2018-05-18  Daniel Bates  <dabates@apple.com>
2145
2146         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
2147         https://bugs.webkit.org/show_bug.cgi?id=185774
2148
2149         Reviewed by Andy Estes.
2150
2151         For now, the script debug-safari is not supported for WebKit for iOS. To
2152         fix this we differentiate between the Apple Mac port and Apple embedded
2153         ports.
2154
2155         * Scripts/webkitdirs.pm:
2156         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2157         (isAppleMacWebKit): Added.
2158         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
2159         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2160         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
2161         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2162         (runSafari): Ditto.
2163         (runMiniBrowser): Ditto.
2164         (debugMiniBrowser): Ditto.
2165         (runWebKitTestRunner): Ditto.
2166         (debugWebKitTestRunner): Ditto.
2167
2168 2018-05-18  Antoine Quint  <graouts@apple.com>
2169
2170         [Web Animations] Turn Web Animations with CSS integration on for test runners
2171         https://bugs.webkit.org/show_bug.cgi?id=184819
2172         <rdar://problem/39597337>
2173
2174         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
2175
2176         * DumpRenderTree/TestOptions.cpp:
2177         (TestOptions::TestOptions):
2178         * DumpRenderTree/TestOptions.h:
2179         * DumpRenderTree/mac/DumpRenderTree.mm:
2180         (runTest):
2181         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
2182         * WebKitTestRunner/TestController.cpp:
2183         (WTR::TestController::resetPreferencesToConsistentValues):
2184         (WTR::updateTestOptionsFromTestHeader):
2185         * WebKitTestRunner/TestOptions.cpp:
2186         (WTR::TestOptions::TestOptions):
2187         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2188         * WebKitTestRunner/TestOptions.h:
2189
2190 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2191
2192         [Win][MiniBrowser] Create MainWindow even in transparent mode
2193         https://bugs.webkit.org/show_bug.cgi?id=185597
2194
2195         Reviewed by Per Arne Vollan.
2196
2197         The current implementations doesn't create the MainWindow in
2198         transparent mode. The screenshot is in Bug 58300.
2199
2200         There were three problems:
2201         - Can't control the WebView. ie. going backward and forward.
2202         - Can't quit the program.
2203         - It makes implementation complicated.
2204
2205         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
2206         even in the transparent mode.
2207         * MiniBrowser/win/WinMain.cpp:
2208         (wWinMain): Create the main window even in the transparent mode.
2209
2210 2018-05-18  Antoine Quint  <graouts@apple.com>
2211
2212         [Web Animations] Turn Web Animations with CSS integration on for test runners
2213         https://bugs.webkit.org/show_bug.cgi?id=184819
2214         <rdar://problem/39597337>
2215
2216         Reviewed by Jon Lee.
2217
2218         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
2219         integration flag on.
2220
2221         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
2222         comment directly at the top of the file since test runners now set the flag on by default
2223         and a dedicated directory exists for tests that need to run with this flag off.
2224
2225         * DumpRenderTree/TestOptions.cpp:
2226         (TestOptions::TestOptions):
2227         * DumpRenderTree/TestOptions.h:
2228         * DumpRenderTree/mac/DumpRenderTree.mm:
2229         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
2230         (runTest):
2231         * WebKitTestRunner/TestController.cpp:
2232         (WTR::TestController::resetPreferencesToConsistentValues):
2233         (WTR::updateTestOptionsFromTestHeader):
2234         * WebKitTestRunner/TestOptions.cpp:
2235         (WTR::isLegacyAnimationEngineTestPath):
2236         (WTR::TestOptions::TestOptions):
2237         * WebKitTestRunner/TestOptions.h:
2238
2239 2018-05-17  Nan Wang  <n_wang@apple.com>
2240
2241         AX: [macOS] Expose the primary screen height through AX API
2242         https://bugs.webkit.org/show_bug.cgi?id=185742
2243
2244         Reviewed by Chris Fleizach.
2245
2246         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2247         (attributesOfElement):
2248         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2249         (WTR::attributesOfElement):
2250
2251 2018-05-17  Commit Queue  <commit-queue@webkit.org>
2252
2253         Unreviewed, rolling out r231912.
2254         https://bugs.webkit.org/show_bug.cgi?id=185750
2255
2256         It is prompting the user when there is no WPT changes
2257         (Requested by bmac on #webkit).
2258
2259         Reverted changeset:
2260
2261         "Export changes to web-platform-test as part of the webkit-
2262         patch upload workflow"
2263         https://bugs.webkit.org/show_bug.cgi?id=184914
2264         https://trac.webkit.org/changeset/231912
2265
2266 2018-05-17  Valerie R Young  <valerie@bocoup.com>
2267
2268         test262/Runner.pm: expand $INC to find webkitdirs.pm
2269         https://bugs.webkit.org/show_bug.cgi?id=185739
2270
2271         Reviewed by Michael Saboff.
2272
2273         * Scripts/test262/Runner.pm:
2274         (getBuildPath):
2275
2276 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2277
2278         [WPE] Implement and enable FULLSCREEN_API
2279         https://bugs.webkit.org/show_bug.cgi?id=185676
2280
2281         Reviewed by Žan Doberšek.
2282
2283         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2284         (testWebViewFullScreen):
2285
2286 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
2287
2288         Export changes to web-platform-test as part of the webkit-patch upload workflow
2289         https://bugs.webkit.org/show_bug.cgi?id=184914
2290
2291         Reviewed by Youenn Fablet.
2292
2293         * Scripts/webkitpy/tool/commands/upload.py:
2294         (Upload):
2295         (CreateBug.execute):
2296         (WPTChangeExport):
2297         * Scripts/webkitpy/tool/steps/__init__.py:
2298         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
2299         (WPTChangeExport):
2300         (WPTChangeExport.options):
2301         (WPTChangeExport.run):
2302         * Scripts/webkitpy/w3c/common.py:
2303         * Scripts/webkitpy/w3c/test_exporter.py:
2304         (WebPlatformTestExporter):
2305         (WebPlatformTestExporter.__init__):
2306         (WebPlatformTestExporter.username):
2307         (WebPlatformTestExporter.token):
2308         (WebPlatformTestExporter._github):
2309         (WebPlatformTestExporter._wpt_fork_branch_github_url):
2310         (WebPlatformTestExporter._wpt_fork_remote):
2311         (WebPlatformTestExporter._wpt_fork_push_url):
2312         (WebPlatformTestExporter._git):
2313         (WebPlatformTestExporter._branch_name):
2314         (WebPlatformTestExporter._public_branch_name):
2315         (WebPlatformTestExporter.has_wpt_changes):
2316         (WebPlatformTestExporter._create_patch):
2317         (WebPlatformTestExporter.create_git_patch):
2318         (WebPlatformTestExporter._prompt_for_token):
2319         (WebPlatformTestExporter._prompt_for_username):
2320         (WebPlatformTestExporter._ensure_username_and_token):
2321         (WebPlatformTestExporter._validate_and_save_token):
2322         (WebPlatformTestExporter.push_to_wpt_fork):
2323         (WebPlatformTestExporter.make_pull_request):
2324         (WebPlatformTestExporter.delete_local_branch):
2325         (parse_args):
2326         (TestExporter): Deleted.
2327         (TestExporter.__init__): Deleted.
2328         (TestExporter._ensure_wpt_repository): Deleted.
2329         (TestExporter._fetch_wpt_repository): Deleted.
2330         (TestExporter._ensure_new_branch_name): Deleted.
2331         (TestExporter.download_and_commit_patch): Deleted.
2332         (TestExporter.clean): Deleted.
2333         (TestExporter.create_branch_with_patch): Deleted.
2334         (TestExporter.push_to_wpt_fork): Deleted.
2335         (TestExporter.make_pull_request): Deleted.
2336         (TestExporter.create_wpt_pull_request): Deleted.
2337         (TestExporter.delete_local_branch): Deleted.
2338         (TestExporter.create_git_patch): Deleted.
2339         (TestExporter.create_upload_remote_if_needed): Deleted.
2340         (TestExporter.do_export): Deleted.
2341         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2342         (TestExporterTest.test_export):
2343         (TestExporterTest.test_export_with_specific_branch):
2344         (TestExporterTest):
2345         (TestExporterTest.test_export_interactive_mode):
2346         (TestExporterTest.test_export_invalid_token):
2347         (TestExporterTest.test_export_wrong_token):
2348
2349 2018-05-17  Valerie R Young  <valerie@bocoup.com>
2350
2351         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
2352         https://bugs.webkit.org/show_bug.cgi?id=185650
2353
2354         Reviewed by Michael Saboff.
2355
2356         First, use jsc from CLI arg, then try to use webkit-build-directory,
2357         if that doesn't work, look for jsc in the $PATH
2358
2359         * Scripts/test262/Runner.pm:
2360         (processCLI):
2361         (getBuildPath):
2362         (runTest):
2363
2364 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
2365
2366         Test262-Runner: Adds a --timeout option
2367         https://bugs.webkit.org/show_bug.cgi?id=185696
2368
2369         Reviewed by Michael Saboff.
2370
2371         The timeout option is used to set a timeout execution in ms for each test run in JSC.
2372         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
2373         * Scripts/test262/Runner.pm:
2374         (processCLI):
2375         (runTest):
2376
2377 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
2378
2379         Test262-Runner: Set timer for each test run
2380         https://bugs.webkit.org/show_bug.cgi?id=185692
2381
2382         Reviewed by Michael Saboff.
2383
2384         Sets a high resolution timer for each execution call of JSC, reporting
2385         the time in the results report to allow identifying slow tests.
2386         * Scripts/test262/Runner.pm:
2387         (main):
2388         (processFile):
2389         (runTest):
2390         (processResult):
2391
2392 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2393
2394         Add support for Intl NumberFormat formatToParts
2395         https://bugs.webkit.org/show_bug.cgi?id=185375
2396
2397         Reviewed by Yusuke Suzuki.
2398
2399         Add flag for NumberFormat formatToParts.
2400
2401         * Scripts/webkitperl/FeatureList.pm:
2402         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2403
2404 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2405
2406         [Win] Use C++17 in MSVC
2407         https://bugs.webkit.org/show_bug.cgi?id=185232
2408
2409         Reviewed by Alex Christensen.
2410
2411         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
2412         conflicts with ::byte defined in Windows' header.
2413
2414         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2415         (WindowedPluginTest::WindowedPluginTest):
2416         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2417         (logEventProc):
2418         (stringEvent):
2419         (AccessibilityController::winNotificationReceived):
2420         * DumpRenderTree/win/TextInputController.cpp:
2421         (markedRangeCallback):
2422         (firstRectForCharacterRangeCallback):
2423         (selectedRangeCallback):
2424         * DumpRenderTree/win/TextInputController.h:
2425         * DumpRenderTree/win/TextInputControllerWin.cpp:
2426         (TextInputController::markedRange):
2427         (TextInputController::firstRectForCharacterRange):
2428         (TextInputController::selectedRange):
2429
2430 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
2431
2432         Session cookies aren't reliably set when using default WKWebSiteDataStore
2433         https://bugs.webkit.org/show_bug.cgi?id=185624
2434         <rdar://problem/39111626>
2435
2436         Reviewed by Geoffrey Garen.
2437
2438         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
2439
2440         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2441         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2442         (TEST):
2443
2444 2018-05-16  Valerie R Young  <valerie@bocoup.com>
2445
2446         test262/Runner.pm: save to supplied expectation file if supplied
2447         https://bugs.webkit.org/show_bug.cgi?id=185660
2448
2449         Reviewed by Michael Saboff.
2450
2451         * Scripts/test262/Runner.pm:
2452         (processCLI):
2453         (main):
2454
2455 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
2456
2457         Unreviewed, rolling out r231763.
2458
2459         The test added with this change is failing an assertion.
2460
2461         Reverted changeset:
2462
2463         "NSEvent event trackers don't work from WebKitTestRunner"
2464         https://bugs.webkit.org/show_bug.cgi?id=185383
2465         https://trac.webkit.org/changeset/231763
2466
2467 2018-05-15  David Kilzer  <ddkilzer@apple.com>
2468
2469         TestWebKitAPI: Fix warnings found by new clang compiler
2470         <https://webkit.org/b/185631>
2471
2472         Reviewed by Michael Catanzaro.
2473
2474         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2475         (TestWebKitAPI::TEST):
2476         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2477         (TestWebKitAPI::TEST):
2478         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2479         (TestWebKitAPI::TEST):
2480         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2481         (TestWebKitAPI::TEST):
2482         - Add #pragma statements to ignore the new
2483           -Wself-assign-overloaded warning and to ignore
2484           this as an unknown warning on older clang versions.  We want
2485           to keep these self assigments as this code is designed to test
2486           that use case.
2487
2488         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2489         (TestWebKitAPI::didFindStringMatches):
2490         - Replace the "rect = rect;" statement that was used to avoid an
2491           unused variable warning with two expectations.
2492
2493         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2494         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2495         - Switch from -integerValue to -unsignedIntegerValue when
2496           comparing against _WKRectEdgeAll since it's an enum declared
2497           as an NSUInteger.
2498
2499 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2500
2501         Unreviewed, rolling out r230749
2502
2503         This did not work as desired.
2504
2505         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2506         (TestWebKitAPI::TEST):
2507
2508 2018-05-15  Antoine Quint  <graouts@apple.com>
2509
2510         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2511         https://bugs.webkit.org/show_bug.cgi?id=185647
2512
2513         Reviewed by Dean Jackson.
2514
2515         Rename the Web Animations CSS integration flag.
2516
2517         * DumpRenderTree/TestOptions.cpp:
2518         (TestOptions::TestOptions):
2519         * DumpRenderTree/TestOptions.h:
2520         * DumpRenderTree/mac/DumpRenderTree.mm:
2521         (setWebPreferencesForTestOptions):
2522         * WebKitTestRunner/TestController.cpp:
2523         (WTR::TestController::resetPreferencesToConsistentValues):
2524         (WTR::updateTestOptionsFromTestHeader):
2525         * WebKitTestRunner/TestOptions.h:
2526         (WTR::TestOptions::hasSameInitializationOptions const):
2527
2528 2018-05-14  Brady Eidson  <beidson@apple.com>
2529
2530         Add an API test to guard against regressions while re-entering setDefersLoading:.
2531         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
2532
2533         Reviewed by Chris Dumez.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
2537         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
2538         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
2539         (-[DefersScheme initWithBytes:]):
2540         (-[DefersScheme webView:startURLSchemeTask:]):
2541         (-[DefersScheme webView:stopURLSchemeTask:]):
2542         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
2543         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2544         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
2545         (-[DoubleDefersLoadingPlugIn dealloc]):
2546
2547 2018-05-14  Daniel Bates  <dabates@apple.com>
2548
2549         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
2550         https://bugs.webkit.org/show_bug.cgi?id=185599
2551         <rdar://problem/22493890>
2552
2553         Reviewed by Simon Fraser.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
2557         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2558         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2559         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2560         (TestWebKitAPI::TEST):
2561         * TestWebKitAPI/ios/set-timeout-function.html: Added.
2562
2563 2018-05-14  Valerie R Young  <valerie@bocoup.com>
2564
2565         test262/Runner.pm: small bugs in CLI and error codes
2566         https://bugs.webkit.org/show_bug.cgi?id=185629
2567
2568         Reviewed by Michael Saboff.
2569
2570         Fix two commandline args with use '-f', correct
2571         error code of failures.
2572
2573         * Scripts/test262/Runner.pm:
2574         (processCLI):
2575         (main):
2576
2577 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
2578
2579         Disable API tests that time out after pointer poisioning was disabled.
2580         https://bugs.webkit.org/show_bug.cgi?id=185586
2581
2582         Unreviewed test gardening.
2583
2584         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2585         (TestWebKitAPI::TEST):
2586         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2587         (TestWebKitAPI::TEST):
2588         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2589         (TestWebKitAPI::TEST):
2590         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2591         (TestWebKitAPI::TEST):
2592
2593 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
2594
2595         Test262-Runner: Fix RegExp for capturing tests metadata"
2596         https://bugs.webkit.org/show_bug.cgi?id=185622
2597
2598         Reviewed by Michael Saboff.
2599
2600         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
2601         both LF and CRLF forms.
2602
2603         The fix also allows the runner to capture the proper results from two specific files using CR and
2604         CRLF line terminators. They are updated in the expectations file.
2605         * Scripts/test262/Runner.pm:
2606         (parseData):
2607
2608 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
2609
2610         NSEvent event trackers don't work from WebKitTestRunner
2611         https://bugs.webkit.org/show_bug.cgi?id=185383
2612         rdar://problem/40025045
2613
2614         Reviewed by Simon Fraser.
2615
2616         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
2617         NSEvent swipe tracking is used for webkit swipe navigation.
2618
2619         * WebKitTestRunner/mac/EventSenderProxy.mm:
2620         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2621
2622 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
2623
2624         Test262 Runner should search for the Debug JSC by default
2625         https://bugs.webkit.org/show_bug.cgi?id=185562
2626
2627         Reviewed by Michael Saboff.
2628
2629         The Test262 Runner is now searching for the Debug build of JSC by
2630         default, not the Release build.
2631
2632         This fix allows a similar call from the previous runner, making
2633         it compatible with the current build bot configuration parameters.
2634
2635         This patch also adds some minor improvements the verbose mode output.
2636
2637         * Scripts/test262/Runner.pm:
2638         (processCLI):
2639         (main):
2640         (getBuildPath):
2641         (processResult):
2642
2643 2018-05-11  Charles Vazac  <cvazac@gmail.com>
2644
2645         Runtime feature flag for Server-Timing
2646         https://bugs.webkit.org/show_bug.cgi?id=184758
2647
2648         Reviewed by Youenn Fablet.
2649
2650         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
2651         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
2652
2653 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2654
2655         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
2656         https://bugs.webkit.org/show_bug.cgi?id=185418
2657
2658         Reviewed by Alex Christensen.
2659
2660         All WK1 related code should be moved into MiniBrowser for the preparation
2661         of Bug 184770.
2662
2663         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
2664
2665         * MiniBrowser/win/Common.cpp:
2666         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
2667         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
2668         * MiniBrowser/win/Common.h: Added.
2669         * MiniBrowser/win/MiniBrowser.cpp:
2670         (MiniBrowser::init): Moved the initilization code from wWinMain.
2671         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
2672         * MiniBrowser/win/MiniBrowser.h:
2673         (MiniBrowser::setCacheFolder): Changed to a private method.
2674         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
2675         * MiniBrowser/win/WinMain.cpp:
2676         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
2677
2678 2018-05-11  Brady Eidson  <beidson@apple.com>
2679
2680         Make sure history navigations reuse the existing process when necessary.
2681         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
2682
2683         Reviewed by Ryosuke Niwa.
2684
2685         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2686
2687 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2688
2689         [JSC][GLIB] Add introspectable alternatives to functions using vargars
2690         https://bugs.webkit.org/show_bug.cgi?id=185508
2691
2692         Reviewed by Michael Catanzaro.
2693
2694         Add test cases for the new API.
2695
2696         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2697         (testJSCFunction):
2698         (testJSCObject):
2699
2700 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
2701
2702         [Build Bot] Restore configuration options to the Test262 Runner
2703
2704         During the switch from the previous Test262 runner to the new one,
2705         a call for an extra configurations options got removed.
2706
2707         This call is important to inform the script to find the debug or
2708         release build of JSC. It's being restored in this patch.
2709
2710         https://bugs.webkit.org/show_bug.cgi?id=185513
2711
2712         Reviewed by Yusuke Suzuki.
2713
2714         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2715         (RunTest262Tests):
2716
2717 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
2718
2719         REGRESSION (r230998): Cannot stream API test output
2720         https://bugs.webkit.org/show_bug.cgi?id=185090
2721
2722         Reviewed by Ryosuke Niwa.
2723
2724         Change run-api-tests so that the stdout and stderr of a test will be printed
2725         before it's result. If -v is passed, the output of single test runs will be
2726         streamed. 
2727
2728         * Scripts/webkitpy/api_tests/run_api_tests.py:
2729         (run): Use print_timestamps flag.
2730         (parse_args): Add timestamps option to print timestamps in the log.
2731         * Scripts/webkitpy/api_tests/runner.py:
2732         (Runner): Add running status.
2733         (Runner.__init__): Add number of workers and a flag to detect if a newline
2734         is needed at the beginning of a log line.
2735         (Runner.run): Turn off most logging coming from server process since it is
2736         not constructive for API tests.
2737         (Runner.handle): Add new log message to stream stdout and stderr instead of
2738         caching values until the test run finished.
2739         (_Worker._run_single_test): Log stdout and stderr in real time.
2740         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
2741         the test.
2742         (_Worker.post): Provide a post with explicitly enumerated argument names.
2743         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2744         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
2745         (MeteredStream.write): Allow for verbose logging without timestamps.
2746         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2747         (RegularTest): Add print_timestamps flag.
2748         (RegularTest.setUp):
2749         (RegularTest.test_logging_not_included):
2750         (VerboseTest.test_log_args):
2751         (VerboseWithOutTimestamp):
2752         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
2753
2754 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
2755
2756         build-webkit can erroneously warn about Xcode being too old
2757         https://bugs.webkit.org/show_bug.cgi?id=185533
2758
2759         Reviewed by Dan Bernstein.
2760
2761         Don't assume the version number is always a single digit.
2762
2763         * Scripts/webkitdirs.pm:
2764         (determineXcodeVersion):
2765
2766 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
2767
2768         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
2769         https://bugs.webkit.org/show_bug.cgi?id=185528
2770
2771         Reviewed by Lucas Forschler.
2772
2773         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2774         (TestFactory.__init__):
2775         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2776         (InstallWinCairoDependencies):
2777
2778 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2779
2780         Fix some -Wstring-op-truncation warnings
2781         https://bugs.webkit.org/show_bug.cgi?id=185496
2782
2783         Reviewed by Alex Christensen.
2784
2785         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
2786         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
2787         set the last bucket to NUL.
2788
2789         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2790         (TestWebKitAPI::testAtomicStringNumber):
2791         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2792         (TestWebKitAPI::testStringNumberFixedPrecision):
2793         (TestWebKitAPI::testStringNumberFixedWidth):
2794         (TestWebKitAPI::testStringNumber):
2795
2796 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2797
2798         [Win][MiniBrowser] Add a separate WndProc for the layered window
2799         https://bugs.webkit.org/show_bug.cgi?id=185460
2800
2801         Reviewed by Brent Fulgham.
2802
2803         All WK1 related code should be moved into MiniBrowser for the
2804         preparation of Bug 184770.
2805
2806         The layered window was using WndProc of the main window. The
2807         layered window is specific only for WK1. the main window will be
2808         shared among WK1 and WK2.
2809
2810         This change add a new WndProc for the layer window.
2811
2812         * MiniBrowser/win/Common.cpp:
2813         (WndProc): Removed code for the layered windows.
2814         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
2815         * MiniBrowser/win/MiniBrowser.cpp:
2816         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
2817         (viewWndProc): New WndProc for the layered windows.
2818         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
2819         * MiniBrowser/win/MiniBrowser.h:
2820         (MiniBrowser::hwnd):
2821         * MiniBrowser/win/WinMain.cpp:
2822         (wWinMain): Added m_viewWnd.
2823
2824 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
2825
2826         Support --verbose in run-javascriptcore-tests
2827         https://bugs.webkit.org/show_bug.cgi?id=185492
2828
2829         Reviewed by Daniel Bates.
2830
2831         * Scripts/run-javascriptcore-tests:
2832         (runJSCStressTests):
2833
2834 2018-05-10  Valerie R Young  <valerie@bocoup.com>
2835
2836         test262/Runner.pm: --failing-files uses results file not expectations
2837         https://bugs.webkit.org/show_bug.cgi?id=185395
2838
2839         Reviewed by Michael Saboff.
2840
2841         --failing-files arg now uses results file to find failing tests
2842         to rerun. It will look in the test262-results directory from whereever
2843         the script is run, or a results.yaml file can be supplied via command
2844         line argument.
2845         --expectations arg added for suppling expectation file.
2846
2847         * Scripts/test262/Runner.pm:
2848         (processCLI):
2849         (main):
2850         (loadImportFile):
2851         (findAllFailing):
2852
2853 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
2856         https://bugs.webkit.org/show_bug.cgi?id=185506
2857
2858         Reviewed by Philippe Normand.
2859
2860         Useful for testing and debugging.
2861
2862         * MiniBrowser/gtk/main.c:
2863         (main):
2864
2865 2018-05-09  Chris Dumez  <cdumez@apple.com>
2866
2867         Unreviewed Windows build fix after r231622.
2868
2869         * DumpRenderTree/win/DumpRenderTree.cpp:
2870         (enableExperimentalFeatures):
2871
2872 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
2873
2874         Update WebKit.WebsiteDataStoreCustomPaths after r231536
2875         https://bugs.webkit.org/show_bug.cgi?id=185486
2876         <rdar://problem/37214391>
2877
2878         Reviewed by Chris Dumez.
2879
2880         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
2881
2882         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2883         (TEST):
2884
2885 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2886
2887         Test262-Runner: Improve the verbose output
2888         https://bugs.webkit.org/show_bug.cgi?id=185491
2889
2890         Reviewed by Michael Saboff.
2891
2892         * Scripts/test262/Import.pm:
2893         (transferFiles):
2894         * Scripts/test262/Runner.pm:
2895         (processResult):
2896
2897 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2898
2899         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
2900         https://bugs.webkit.org/show_bug.cgi?id=185488
2901
2902         Reviewed by Michael Saboff.
2903
2904         * Scripts/test262/Runner.pm:
2905         (processCLI):
2906         (getBuildPath):
2907         (runTest):
2908
2909 2018-05-09  Richard Houle  <rhoule@apple.com>
2910
2911         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
2912         https://bugs.webkit.org/show_bug.cgi?id=185260
2913         <rdar://problem/39290394>
2914
2915         Reviewed by Tim Horton.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
2919         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
2920         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
2921         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2922         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2923
2924 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
2925
2926         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2927         https://bugs.webkit.org/show_bug.cgi?id=185481
2928
2929         Reviewed by Philippe Normand.
2930
2931         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2932
2933         * Scripts/webkitpy/port/gtk.py:
2934         (GtkPort.setup_environ_for_server):
2935
2936 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2937
2938         Set build.webkit.org to use the new Test262-runner
2939         https://bugs.webkit.org/show_bug.cgi?id=184933
2940
2941         Reviewed by Aakash Jain.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2944         (RunTest262Tests):
2945         (RunTest262Tests.countFailures):
2946         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2947
2948 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2949
2950         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
2951         https://bugs.webkit.org/show_bug.cgi?id=185461
2952
2953         Reviewed by Michael Catanzaro.
2954
2955         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
2956
2957         * gtk/jhbuild.modules:
2958
2959 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2960
2961         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
2962
2963         * wpe/manifest.txt.in: Distribute the NEWS.
2964
2965 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2966
2967         [WPE] Build cleanly with GCC 8 and ICU 60
2968         https://bugs.webkit.org/show_bug.cgi?id=185462
2969
2970         Reviewed by Carlos Alberto Lopez Perez.
2971
2972         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
2973         sure why this was never noticed until now or why the bots are OK.
2974         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2975         * gtk/patches/glib-cast-function-type.patch: Added.
2976         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2977         * wpe/patches/glib-cast-function-type.patch: Added.
2978
2979 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2980
2981         [JSC][GTK][JSCONLY] Use capstone disassembler
2982         https://bugs.webkit.org/show_bug.cgi?id=185283
2983
2984         Reviewed by Michael Catanzaro.
2985
2986         * gtk/manifest.txt.in:
2987         * wpe/manifest.txt.in:
2988
2989 2018-05-09  Antti Koivisto  <antti@apple.com>
2990
2991         Add OptionSet::operator& and operator bool
2992         https://bugs.webkit.org/show_bug.cgi?id=185306
2993
2994         Reviewed by Anders Carlsson.
2995
2996         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2997         (TestWebKitAPI::TEST):
2998
2999 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3000
3001         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
3002         https://bugs.webkit.org/show_bug.cgi?id=185340
3003
3004         Reviewed by Tim Horton.
3005
3006         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
3007         non-empty text in a contenteditable.
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3010         (TestWebKitAPI::TEST):
3011
3012 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3013
3014         test262/Runner.pm: create results dir for results of test262 run
3015         https://bugs.webkit.org/show_bug.cgi?id=185392
3016
3017         Reviewed by Michael Saboff.
3018
3019         New directory test262-results created from where ever script is
3020         called.
3021
3022         * Scripts/test262/Runner.pm:
3023         (processCLI):
3024
3025 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3026
3027         test262/Runner.pm: lower number of processes per core
3028         https://bugs.webkit.org/show_bug.cgi?id=185426
3029
3030         Reviewed by Michael Saboff.
3031
3032         * Scripts/test262/Runner.pm:
3033         (getProcesses):
3034
3035 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
3036
3037         Test262-Runner: Add base Perl UnicodeData
3038         https://bugs.webkit.org/show_bug.cgi?id=185444
3039
3040         Reviewed by Michael Saboff.
3041
3042         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
3043         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
3044
3045 2018-05-08  Daniel Bates  <dabates@apple.com>
3046
3047         Add tests to ensure that the Strong Password appearance is removed on form reset
3048         https://bugs.webkit.org/show_bug.cgi?id=185440
3049
3050         Reviewed by Ryosuke Niwa.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
3053         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
3054         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3055         (TEST):
3056
3057 2018-05-08  Daniel Bates  <dabates@apple.com>
3058
3059         Resign Strong Password appearance when text field value changes
3060         https://bugs.webkit.org/show_bug.cgi?id=185433
3061         <rdar://problem/39958508>
3062
3063         Reviewed by Ryosuke Niwa.
3064
3065         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
3066         when the field has the Strong Password button and its value changes.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3069         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3070         (TEST):
3071
3072 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
3073
3074         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
3075         https://bugs.webkit.org/show_bug.cgi?id=185365
3076
3077         Reviewed by Saam Barati.
3078         
3079         Make it possible to measure compile times.
3080         
3081         Rolling back in after fixing cloop builds.
3082
3083         * Scripts/run-jsc-benchmarks:
3084
3085 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3086
3087         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
3088         https://bugs.webkit.org/show_bug.cgi?id=185414
3089
3090         Reviewed by Tim Horton.
3091
3092         Adjust a test expectation to check that the resulting DOM contains an attachment element,
3093         anchor element, and another attachment element in that order. This ensures that the test
3094         still passes, even after the anchor element is followed by a line break.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3097         (TestWebKitAPI::TEST):
3098
3099 2018-05-08  Commit Queue  <commit-queue@webkit.org>
3100
3101         Unreviewed, rolling out r231491.
3102         https://bugs.webkit.org/show_bug.cgi?id=185434
3103
3104         Setting the Created key on a cookie does not work yet, due a
3105         bug in CFNetwork (Requested by ggaren on #webkit).
3106
3107         Reverted changeset:
3108
3109         "[WKHTTPCookieStore getAllCookies] returns inconsistent
3110         creation time"
3111         https://bugs.webkit.org/show_bug.cgi?id=185041
3112         https://trac.webkit.org/changeset/231491
3113
3114 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3115
3116         test262/Runner.pm: move input files to JSTests/test262
3117         https://bugs.webkit.org/show_bug.cgi?id=185389
3118
3119         Reviewed by Michael Saboff.
3120
3121         * Scripts/test262/Runner.pm:
3122         (processCLI):
3123
3124 2018-05-08  Chris Dumez  <cdumez@apple.com>
3125
3126         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
3127
3128         * Scripts/webkitpy/performance_tests/perftest.py:
3129         (PerfTest):
3130
3131 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
3132
3133         Unreviewed, rolling out r231468.
3134
3135         Broke the CLoop build
3136
3137         Reverted changeset:
3138
3139         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
3140         any abstract values"
3141         https://bugs.webkit.org/show_bug.cgi?id=185365
3142         https://trac.webkit.org/changeset/231468
3143
3144 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
3145
3146         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
3147         https://bugs.webkit.org/show_bug.cgi?id=185041
3148         <rdar://problem/34684214>
3149
3150         Reviewed by Geoffrey Garen.
3151
3152         Add API test Coverage.
3153
3154         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3155         (TEST):
3156
3157 2018-05-08  Chris Dumez  <cdumez@apple.com>
3158
3159         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
3160
3161         * Scripts/webkitpy/performance_tests/perftest.py:
3162         (PerfTest):
3163
3164 2018-05-08  Chris Dumez  <cdumez@apple.com>
3165
3166         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
3167
3168         * Scripts/webkitpy/performance_tests/perftest.py:
3169         (PerfTest):
3170
3171 2018-05-07  Chris Dumez  <cdumez@apple.com>
3172
3173         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
3174
3175         * Scripts/webkitpy/performance_tests/perftest.py:
3176         (PerfTest):
3177
3178 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
3179
3180         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
3181         https://bugs.webkit.org/show_bug.cgi?id=185365
3182
3183         Reviewed by Saam Barati.
3184         
3185         Make it possible to measure compile times.
3186
3187         * Scripts/run-jsc-benchmarks:
3188
3189 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
3190
3191         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
3192         https://bugs.webkit.org/show_bug.cgi?id=185390
3193
3194         Reviewed by Michael Saboff.
3195
3196         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
3197
3198 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
3199
3200         Check for com.apple.datamigrator before declaring simulators booted
3201         https://bugs.webkit.org/show_bug.cgi?id=185315
3202         <rdar://problem/39986261>
3203
3204         Reviewed by David Kilzer.
3205
3206         * Scripts/webkitdirs.pm:
3207         (waitUntilProcessNotRunning): Wait until a process is not found.
3208         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
3209         a simulator booted.
3210         * Scripts/webkitpy/common/system/executive_mock.py:
3211         (MockExecutive2.__init__): Define _running_pids.
3212         * Scripts/webkitpy/xcode/simulated_device.py:
3213         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
3214         declaring that devices have been booted, increase the timeout since data migration will frequently
3215         take longer than 60 seconds, especially with multiple simulators booting.
3216         (SimulatedDeviceManager.swap): Ditto.
3217         (SimulatedDeviceManager):
3218         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
3219         processes running.
3220
3221 2018-05-07  Daniel Bates  <dabates@apple.com>
3222
3223         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
3224         https://bugs.webkit.org/show_bug.cgi?id=185054
3225         <rdar://problem/39773209>
3226
3227         Reviewed by Ryosuke Niwa.
3228
3229         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
3230
3231         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
3232         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
3233         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
3234         tests for the port.
3235
3236         * Scripts/webkitpy/port/mac.py:
3237         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
3238         have Apple Additions.
3239         * Scripts/webkitpy/port/mac_unittest.py:
3240         (MacTest.test_factory_with_future_version): Added.
3241         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
3242         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
3243         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
3244         is absent.
3245
3246 2018-05-07  Brian Burg  <bburg@apple.com>
3247
3248         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
3249         https://bugs.webkit.org/show_bug.cgi?id=184861
3250         <rdar://problem/39153768>
3251
3252         Reviewed by Timothy Hatcher.
3253
3254         Add a new test that checks whether a new process is used for navigation when
3255         an Inspector is shown. Also check that the behavior reverts to normal after
3256         the Inspector has been closed.
3257
3258         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3259
3260 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3261
3262         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
3263         https://bugs.webkit.org/show_bug.cgi?id=185289
3264         <rdar://problem/35756912>
3265
3266         Reviewed by Tim Horton and Darin Adler.
3267
3268         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
3269         sessions.
3270
3271         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3272         (TestWebKitAPI::TEST):
3273
3274 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3275
3276         Deprecate legacy WebView and friends
3277         https://bugs.webkit.org/show_bug.cgi?id=185279
3278         rdar://problem/33268700
3279
3280         Reviewed by Tim Horton.
3281
3282         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
3283         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
3284
3285 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
3286
3287         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
3288         https://bugs.webkit.org/show_bug.cgi?id=185314
3289
3290         Reviewed by Michael Saboff.
3291
3292         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
3293
3294 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
3295
3296         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
3297         https://bugs.webkit.org/show_bug.cgi?id=184196
3298         <rdar://problem/39054481>
3299
3300         Reviewed by Tim Horton.
3301
3302         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
3303         earlier than 11.3. Also re-enables these tests.
3304
3305         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3306         (TestWebKitAPI::TEST):
3307         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
3308         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
3309
3310 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
3311
3312         Text shaping in the simple path is flipped in the y direction
3313         https://bugs.webkit.org/show_bug.cgi?id=185062
3314         <rdar://problem/39778678>
3315
3316         Reviewed by Simon Fraser.
3317
3318         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
3319
3320         * Scripts/webkitpy/common/config/contributors.json:
3321
3322 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
3323
3324         Test262-Runner: place the processCLI inside the main call
3325         https://bugs.webkit.org/show_bug.cgi?id=185304
3326
3327         Reviewed by Michael Saboff.
3328
3329         * Scripts/test262/Runner.pm:
3330         (main):
3331
3332 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3333
3334         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
3335         https://bugs.webkit.org/show_bug.cgi?id=174730
3336
3337         Reviewed by Michael Catanzaro.
3338
3339         Update unit tests to check that User-Agent header is included in HTTP download requests.
3340
3341         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3342         (testDownloadRemoteFile):
3343         (testWebViewDownloadURI):
3344         (testPolicyResponseDownload):
3345         (testPolicyResponseDownloadCancel):
3346         (testDownloadMIMEType):
3347         (testContextMenuDownloadActions):
3348
3349 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
3350
3351         [WinCairo] Test archive must use Python zipfile, just like build product.
3352         https://bugs.webkit.org/show_bug.cgi?id=185265
3353
3354         Reviewed by Per Arne Vollan.
3355
3356         * BuildSlaveSupport/test-result-archive:
3357         (archive_test_results):
3358         Copy over Win32-oriented archiving logic from built-product-archive.
3359
3360 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
3361
3362         cleanup modules usage for the Test262-Runner
3363         https://bugs.webkit.org/show_bug.cgi?id=185263
3364
3365         Reviewed by Michael Saboff.
3366
3367         * Scripts/test262-runner:
3368         * Scripts/test262/Runner.pm:
3369         (processCLI):
3370
3371 2018-05-03  Valerie R Young  <valerie@bocoup.com>
3372
3373         test262/Runner.pm: minor fixes
3374         https://bugs.webkit.org/show_bug.cgi?id=185250
3375
3376         Reviewed by Michael Saboff.
3377
3378         Add comments, change output and fix bug: unintended interpolation
3379         of filename when running jsc.
3380
3381         * Scripts/test262/Runner.pm:
3382         (processCLI):
3383         (main):
3384         (runTest):
3385
3386 2018-05-03  Chris Dumez  <cdumez@apple.com>
3387
3388         Load hangs if the WebProcess fails to launch
3389         https://bugs.webkit.org/show_bug.cgi?id=185225
3390         <rdar://problem/38249058>
3391
3392         Reviewed by Geoff Garen.
3393
3394         Add API test coverage.
3395
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
3398         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
3399         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
3400         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3401         (TEST):
3402
3403 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
3404
3405         [WinCairo] Add JSC test bots
3406         https://bugs.webkit.org/show_bug.cgi?id=185234
3407
3408         Reviewed by Per Arne Vollan.
3409
3410         * BuildSlaveSupport/build.webkit.org-config/config.json:
3411         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3412         (RunJavaScriptCoreTests.start):
3413
3414 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3415
3416         WebKit should send fake macOS user agent to docs.google.com
3417         https://bugs.webkit.org/show_bug.cgi?id=185165
3418
3419         Reviewed by Carlos Garcia Campos.
3420
3421         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3422         (TestWebKitAPI::TEST):
3423
3424 2018-05-03  Valerie R Young  <valerie@bocoup.com>
3425
3426         test262/Runner.pm: performance improvements
3427         https://bugs.webkit.org/show_bug.cgi?id=185202
3428
3429         Reviewed by Michael Saboff.
3430
3431         Batch the tests by the number of processes, and give each process
3432         a file to save results to to avoid threading. Do not parallelize
3433         when running small sets of tests.
3434
3435         * Scripts/test262/Runner.pm:
3436         (processCLI):
3437         (main):
3438         (processFile):
3439         (processResult):
3440
3441 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
3442
3443         Unreviewed, rolling out r231253.
3444
3445         The API test added with this change is crashing on the bots.
3446
3447         Reverted changeset:
3448
3449         "Web Inspector: opt out of process swap on navigation if a Web
3450         Inspector frontend is connected"
3451         https://bugs.webkit.org/show_bug.cgi?id=184861
3452         https://trac.webkit.org/changeset/231253
3453
3454 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3455
3456         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
3457         https://bugs.webkit.org/show_bug.cgi?id=183348
3458
3459         Reviewed by Michael Catanzaro.
3460
3461         Add a test case to reproduce the crash.
3462
3463         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3464         (testWebViewCloseQuickly):
3465         (beforeAll):
3466
3467 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
3468
3469         Can't copy and paste URLs that have no title into Mail (macOS)
3470         https://bugs.webkit.org/show_bug.cgi?id=185205
3471         <rdar://problem/36352406>
3472
3473         Reviewed by Tim Horton.
3474
3475         Added test to verify behavior when copying and pasting a URL without a title.
3476
3477         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
3478         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3479         (TestWebKitAPI::TEST):
3480
3481 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3482
3483         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
3484         https://bugs.webkit.org/show_bug.cgi?id=184699
3485
3486         Unreviewed follow-up fix after r231230.
3487
3488         * Scripts/generate-jsc-bundle:
3489         (generate_wrapper_script): Quote the arguments passed to jsc.
3490
3491 2018-05-02  Brian Burg  <bburg@apple.com>
3492
3493         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
3494         https://bugs.webkit.org/show_bug.cgi?id=184861
3495         <rdar://problem/39153768>
3496
3497         Reviewed by Ryosuke Niwa.
3498
3499         Add a new test that checks whether a new process is used for navigation when
3500         an Inspector is shown. Also check that the behavior reverts to normal after
3501         the Inspector has been closed.
3502
3503         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3504
3505 2018-05-02  Valerie R Young  <valerie@bocoup.com>
3506
3507         test262/Runner.pm: save summary to file
3508         https://bugs.webkit.org/show_bug.cgi?id=185200
3509
3510         Reviewed by Michael Saboff.
3511
3512         * Scripts/test262/Runner.pm:
3513         (processCLI):
3514         (main):
3515         (summarizeResults):
3516
3517 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3518
3519         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
3520         https://bugs.webkit.org/show_bug.cgi?id=184699
3521
3522         Reviewed by Gustavo Noronha Silva.
3523
3524         This adds a new step for the GTK 64-bit release build bot and the
3525         GTK 32-bit release build&test bot.
3526
3527         This step will be run as one of the lasts ones (after the product
3528         is built) and will execute the script generate-jsc-bundle.
3529         This script will take care of creating a JSC bundle and uploading
3530         it to a server defined on a configuration file that has to be
3531         deployed on the bots with the required server data and credentials
3532         for this upload.
3533
3534         In this case, the built products should then be accessible at
3535         <https://webkitgtk.org/jsc-built-products>. But the implementation
3536         is not tied to any specific server. All the details about where
3537         to upload the file is done in configuration file that is kept
3538         private on each bot outside of the WebKit source tree.
3539
3540         The script also supports generating a JSC bundle locally and not
3541         uploading it anywhere. This is the default mode of running.
3542         The remote upload will only be activated if a --remote-config-file
3543         parameter is passed (which is done from the buildbot config)
3544
3545         * BuildSlaveSupport/build.webkit.org-config/config.json:
3546         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3547         (BuildFactory):
3548         (BuildFactory.__init__):
3549         (TestFactory):
3550         (TestFactory.__init__):
3551         (BuildAndGenerateJSCBundleFactory):
3552         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
3553         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3554         (GenerateJSCBundle):
3555         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3556         * Scripts/generate-jsc-bundle: Added.
3557         (ldd_get_libs_and_interpreter):
3558         (generate_readme):
3559         (generate_wrapper_script):
3560         (copy_and_remove_rpath):
3561         (createJSCBundle):
3562         (sha256sum):
3563         (uploadJSCBundle):
3564         (main):
3565
3566 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3567
3568         PSON: Make WebKitTestRunner work with process swap on navigation turned on
3569         https://bugs.webkit.org/show_bug.cgi?id=185111
3570
3571         Reviewed by Chris Dumez.
3572
3573         Add the basic support for running layout tests with process-swap-on-navigation turned on.
3574
3575         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
3576         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
3577
3578         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
3579         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
3580         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
3581         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
3582
3583         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3584         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
3585         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
3586         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
3587         beginTesting with BegingTestingMode::Resume when this boolean is set.
3588         (WTR::InjectedBundle::didReceiveMessageToPage):
3589         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
3590         bundle after a process swap on navigation.
3591         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3592         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3593         (WTR::InjectedBundlePage::dump):
3594         (WTR::InjectedBundlePage::frameDidChangeLocation):
3595         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3596         (WTR::TestRunner::TestRunner):
3597         (WTR::TestRunner::shouldDumpPixels const): Added.
3598         (WTR::TestRunner::setDumpPixels): Added.
3599         (WTR::TestRunner::dumpAsText):
3600         (WTR::TestRunner::whatToDump const): Added.
3601         (WTR::TestRunner::setWhatToDump): Added.
3602         (WTR::TestRunner::waitUntilDone):
3603         (WTR::TestRunner::setWaitUntilDone): Added.
3604         (WTR::TestRunner::shouldWaitUntilDone): Added.
3605         (WTR::TestRunner::notifyDone):
3606         (WTR::TestRunner::forceImmediateCompletion):
3607         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
3608         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
3609         (WTR::TestRunner::setAudioResult):
3610         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3611 &nb