bf42aaa2efcef75d7239a191c9960e4ce2acee59
[WebKit-https.git] / Tools / ChangeLog
1 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2
3         Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
4         https://bugs.webkit.org/show_bug.cgi?id=162251
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9         (TestWebKitAPI::checkURL):
10         (TestWebKitAPI::TEST_F):
11         (TestWebKitAPI::checkRelativeURL):
12         (TestWebKitAPI::checkURLDifferences):
13         (TestWebKitAPI::checkRelativeURLDifferences):
14
15 2016-09-20  Alex Christensen  <achristensen@webkit.org>
16
17         URLParser should allow '@' in user
18         https://bugs.webkit.org/show_bug.cgi?id=162272
19
20         Reviewed by Tim Horton.
21
22         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
23         (TestWebKitAPI::TEST_F):
24
25 2016-09-20  Alex Christensen  <achristensen@webkit.org>
26
27         URLParser: Fix parsing relative URLs with one slash after the scheme:
28         https://bugs.webkit.org/show_bug.cgi?id=162294
29
30         Reviewed by Tim Horton.
31
32         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
33         (TestWebKitAPI::TEST_F):
34
35 2016-09-20  Alex Christensen  <achristensen@webkit.org>
36
37         Fix Windows file URL quirks in URLParser
38         https://bugs.webkit.org/show_bug.cgi?id=162303
39
40         Reviewed by Tim Horton.
41
42         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
43         (TestWebKitAPI::TEST_F):
44
45 2016-09-20  Filip Pizlo  <fpizlo@apple.com>
46
47         Make MarkedBlock state tracking support overlapped allocation and marking state
48         https://bugs.webkit.org/show_bug.cgi?id=161581
49
50         Reviewed by Geoffrey Garen.
51         
52         Remove the always-trigger-copy-phase configuration.
53
54         * Scripts/run-jsc-stress-tests:
55
56 2016-09-20  Don Olmstead  <don.olmstead@am.sony.com>
57
58         [WinCairo] Use find_package cairo in build
59         https://bugs.webkit.org/show_bug.cgi?id=162239
60
61         Reviewed by Alex Christensen.
62
63         * DumpRenderTree/PlatformWin.cmake:
64         * TestWebKitAPI/PlatformWin.cmake:
65
66 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
67
68         Unreviewed build fix on 10.10 bots.
69
70         * TestWebKitAPI/mac/TestWKWebViewMac.h:
71
72 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
73
74         VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
75         https://bugs.webkit.org/show_bug.cgi?id=162255
76
77         Reviewed by Jer Noble.
78
79         This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test
80         back-to-back would result in the second one failing). This suggests that even on the runloop after the video
81         starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we
82         can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and
83         will probably address flakiness on the bots for this test.
84
85         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
86         (TestWebKitAPI::TEST):
87         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
88
89 2016-09-20  Per Arne Vollan  <pvollan@apple.com>
90
91         [Win] Run layout tests in parallel.
92         https://bugs.webkit.org/show_bug.cgi?id=162145
93
94         Reviewed by Brent Fulgham.
95
96         To speed up layout tests, try running them in parallel.
97
98         * Scripts/webkitpy/port/win.py:
99         (WinPort.default_child_processes): Deleted.
100
101 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
102
103         Unreviewed build fix after r206135
104
105         NSEventMaskLeftMouseDown and friends are only available on 10.12.
106
107         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
108         (__simulated_forceClickAssociatedEventsMask):
109
110 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
111
112         Add a unit test covering <https://trac.webkit.org/changeset/205983>
113         https://bugs.webkit.org/show_bug.cgi?id=162112
114
115         Reviewed by Beth Dakin.
116
117         Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also
118         further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both
119         cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event
120         at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as
121         pressure-sensitive events that are needed for the new test.
122
123         Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests,
124         checking whether or not to should be requesting candidates in password and non-password fields.
125
126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
127         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
128         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
129         (TestWebKitAPI::TEST):
130         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
131         (-[CandidateTestWebView typeString:inputMessage:]):
132         (+[CandidateTestWebView setUpWithFrame:testPage:]):
133         * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added.
134         * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added.
135         * TestWebKitAPI/mac/TestWKWebViewMac.h:
136         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
137         (__simulated_forceClickAssociatedEventsMask):
138         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
139         (-[TestWKWebView initWithFrame:]):
140         (-[TestWKWebView initWithFrame:configuration:]):
141         (-[TestWKWebView _setUpTestWindow:]):
142         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
143         (-[TestWKWebView typeCharacter:]):
144         (-[TestWKWebView mouseDownAtPoint:]): Deleted.
145
146 2016-09-19  Alex Christensen  <achristensen@webkit.org>
147
148         URLParser can read memory out of bounds
149         https://bugs.webkit.org/show_bug.cgi?id=162206
150
151         Reviewed by Geoff Garen.
152
153         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
154         (TestWebKitAPI::TEST_F):
155
156 2016-09-19  Daniel Bates  <dabates@apple.com>
157
158         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
159         https://bugs.webkit.org/show_bug.cgi?id=162167
160
161         Reviewed by Simon Fraser.
162
163         * Scripts/webkitperl/FeatureList.pm:
164         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
165
166 2016-09-19  Nan Wang  <n_wang@apple.com>
167
168         AX: Add accessibility support for details element on iOS
169         https://bugs.webkit.org/show_bug.cgi?id=162041
170
171         Reviewed by Chris Fleizach.
172
173         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
174         (AccessibilityUIElement::isExpanded):
175         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
176         (WTR::AccessibilityUIElement::isExpanded):
177
178 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
179
180         [EFL] Bump efl library to 1.18.1
181         https://bugs.webkit.org/show_bug.cgi?id=162120
182
183         Reviewed by Michael Catanzaro.
184
185         * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18.
186
187 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
188
189         [EFL] Adjust EFL coding style to EFL MiniBrowser
190         https://bugs.webkit.org/show_bug.cgi?id=162119
191
192         Reviewed by Michael Catanzaro.
193
194         Apply EFL coding style to main.c for MiniBrowser.
195           - Use _foo_cb instead of on_foo for callback function
196           - Use 3 spaces and use 2 spaces in keywords.
197
198         - EFL coding style.
199           https://phab.enlightenment.org/w/coding_convention/
200
201         Additionally this patch adds an exception rule that style checker doesn't
202         check indentation rule in EFL MiniBrowser.
203
204         * MiniBrowser/efl/main.c:
205         (miniBrowserViewSmartClass):
206         (window_find_with_ewk_view):
207         (_tooltip_show):
208         (window_tooltip_hide):
209         (window_tooltip_update):
210         (_mouse_in_cb):
211         (_mouse_move_cb):
212         (_mouse_out_cb):
213         (_mouse_wheel_cb):
214         (_window_resize_cb):
215         (update_view_favicon):
216         (_icon_changed_cb):
217         (window_free):
218         (window_close):
219         (search_icon_show):
220         (search_box_show):
221         (search_box_hide):
222         (history_list_hide):
223         (save_page_contents_callback):
224         (script_execute_callback):
225         (toggle_window_fullscreen):
226         (_key_down_cb):
227         (_mouse_down_cb):
228         (_title_changed_cb):
229         (_url_changed_cb):
230         (_back_forward_list_changed_cb):
231         (_progress_cb):
232         (_error_cb):
233         (_download_request_cb):
234         (close_file_picker):
235         (_filepicker_parent_deletion_cb):
236         (_filepicker_deletion_cb):
237         (_fileselector_done_cb):
238         (_file_chooser_request_cb):
239         (_download_finished_cb):
240         (_download_failed_cb):
241         (_color_changed_cb):
242         (_color_item_selected_cb):
243         (_color_picker_ok_clicked_cb):
244         (_color_picker_cancel_clicked_cb):
245         (_color_picker_dismiss_cb):
246         (_color_picker_request_cb):
247         (_url_bar_activated_cb):
248         (_url_bar_clicked_cb):
249         (_search_field_aborted_cb):
250         (_search_field_activated_cb):
251         (_search_field_clicked_cb):
252         (_back_button_clicked_cb):
253         (_forward_button_clicked_cb):
254         (_search_backward_button_clicked_cb):
255         (_search_forward_button_clicked_cb):
256         (_search_case_option_changed):
257         (_search_word_start_option_changed_cb):
258         (_search_close_button_clicked_cb):
259         (_refresh_button_clicked_cb):
260         (_stop_button_clicked_cb):
261         (_list_item_select_cb):
262         (navigation_button_longpress_process):
263         (_forward_button_longpress_cb):
264         (_back_button_longpress_cb):
265         (_ok_clicked_cb):
266         (_file_entry_dialog_show):
267         (_javascript_alert_cb):
268         (_javascript_confirm_cb):
269         (_javascript_prompt_cb):
270         (_javascript_before_unload_confirm_cb):
271         (_popup_menu_item_clicked_cb):
272         (popup_menu_populate):
273         (_popup_menu_show):
274         (_popup_menu_hide):
275         (_window_geometry_get):
276         (_window_geometry_set):
277         (_fullscreen_accept_cb):
278         (_fullscreen_deny_cb):
279         (_fullscreen_enter_cb):
280         (_fullscreen_exit_cb):
281         (_window_create_cb):
282         (_window_close_cb):
283         (_context_menu_item_selected_cb):
284         (context_menu_populate):
285         (_context_menu_show):
286         (_context_menu_hide):
287         (auth_popup_close):
288         (_auth_cancel_cb):
289         (_auth_ok_cb):
290         (_authentication_request_cb):
291         (_search_text_found_cb):
292         (_tooltip_text_set):
293         (_tooltip_text_unset):
294         (_navigation_policy_decision_cb):
295         (_home_button_clicked_cb):
296         (_window_deletion_cb):
297         (create_toolbar_button):
298         (window_create):
299         (configuration):
300         (parse_cookies_policy):
301         (parse_window_size):
302         (elm_main):
303         (on_tooltip_show): Deleted.
304         (on_mouse_in): Deleted.
305         (on_mouse_move): Deleted.
306         (on_mouse_out): Deleted.
307         (on_mouse_wheel): Deleted.
308         (on_window_resize): Deleted.
309         (on_icon_changed_cb): Deleted.
310         (on_key_down): Deleted.
311         (on_mouse_down): Deleted.
312         (on_title_changed): Deleted.
313         (on_url_changed): Deleted.
314         (on_back_forward_list_changed): Deleted.
315         (on_progress): Deleted.
316         (on_error): Deleted.
317         (on_download_request): Deleted.
318         (on_filepicker_parent_deletion): Deleted.
319         (on_filepicker_deletion): Deleted.
320         (on_fileselector_done): Deleted.
321         (on_file_chooser_request): Deleted.
322         (on_download_finished): Deleted.
323         (on_download_failed): Deleted.
324         (on_color_changed): Deleted.
325         (on_color_item_selected): Deleted.
326         (on_color_picker_ok_clicked): Deleted.
327         (on_color_picker_cancel_clicked): Deleted.
328         (on_color_picker_dismiss): Deleted.
329         (on_color_picker_request): Deleted.
330         (on_url_bar_activated): Deleted.
331         (on_url_bar_clicked): Deleted.
332         (on_search_field_aborted): Deleted.
333         (on_search_field_activated): Deleted.
334         (on_search_field_clicked): Deleted.
335         (on_back_button_clicked): Deleted.
336         (on_forward_button_clicked): Deleted.
337         (on_search_backward_button_clicked): Deleted.
338         (on_search_forward_button_clicked): Deleted.
339         (on_search_case_option_changed): Deleted.
340         (on_search_word_start_option_changed): Deleted.
341         (on_search_close_button_clicked): Deleted.
342         (on_refresh_button_clicked): Deleted.
343         (on_stop_button_clicked): Deleted.
344         (on_list_item_select): Deleted.
345         (on_forward_button_longpress): Deleted.
346         (on_back_button_longpress): Deleted.
347         (on_ok_clicked): Deleted.
348         (show_file_entry_dialog): Deleted.
349         (on_javascript_alert): Deleted.
350         (on_javascript_confirm): Deleted.
351         (on_javascript_prompt): Deleted.
352         (on_javascript_before_unload_confirm): Deleted.
353         (on_popup_menu_item_clicked): Deleted.
354         (on_popup_menu_show): Deleted.
355         (on_popup_menu_hide): Deleted.
356         (on_window_geometry_get): Deleted.
357         (on_window_geometry_set): Deleted.
358         (on_fullscreen_accept): Deleted.
359         (on_fullscreen_deny): Deleted.
360         (on_fullscreen_enter): Deleted.
361         (on_fullscreen_exit): Deleted.
362         (on_window_create): Deleted.
363         (on_window_close): Deleted.
364         (context_menu_item_selected_cb): Deleted.
365         (on_context_menu_show): Deleted.
366         (on_context_menu_hide): Deleted.
367         (on_auth_cancel): Deleted.
368         (on_auth_ok): Deleted.
369         (on_authentication_request): Deleted.
370         (on_search_text_found): Deleted.
371         (on_tooltip_text_set): Deleted.
372         (on_tooltip_text_unset): Deleted.
373         (on_navigation_policy_decision): Deleted.
374         (on_home_button_clicked): Deleted.
375         (on_window_deletion): Deleted.
376         * Scripts/webkitpy/style/checker.py:
377
378 2016-09-16  Dave Hyatt  <hyatt@apple.com>
379
380         [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
381         https://bugs.webkit.org/show_bug.cgi?id=162078
382
383         Reviewed by Dean Jackson.
384
385         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
386         (TestWebKitAPI::createTestValue):
387         Convert to ValueRange.
388
389 2016-09-16  Alex Christensen  <achristensen@webkit.org>
390
391         Fix API tests after r206036
392         https://bugs.webkit.org/show_bug.cgi?id=162049
393
394         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
395         (TestWebKitAPI::TEST_F):
396         An emoji had been UTF-8 encoded in the patch that was applied.
397         The test needed to check the encoding of the emoji, not the UTF-8 encoding of the emoji.
398         Everything was correct except applying the patch before committing.
399
400 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
401
402         RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
403         https://bugs.webkit.org/show_bug.cgi?id=162080
404
405         Reviewed by Jer Noble.
406
407         I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
408         RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
409
410         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
411         (RequiresUserActionForPlaybackTest::SetUp):
412
413 2016-09-16  Alex Christensen  <achristensen@webkit.org>
414
415         URLParser should percent encode the user and password according to spec
416         https://bugs.webkit.org/show_bug.cgi?id=162049
417
418         Reviewed by Tim Horton.
419
420         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
421         (TestWebKitAPI::TEST_F):
422
423 2016-09-16  Alex Christensen  <achristensen@webkit.org>
424
425         Fix more edge cases in URLParser
426         https://bugs.webkit.org/show_bug.cgi?id=162051
427
428         Reviewed by Tim Horton.
429
430         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
431         (TestWebKitAPI::TEST_F):
432
433 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
434
435         Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker
436         https://bugs.webkit.org/show_bug.cgi?id=162009
437         <rdar://problem/28086237>
438
439         Reviewed by Tim Horton.
440
441         Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in
442         WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new
443         WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of
444         simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and
445         performing actions in response.
446
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
449         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
450         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
451         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
452         (TestWebKitAPI::TEST):
453         (-[MessageHandler initWithMessage:handler:]): Deleted.
454         (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
455         (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted.
456         (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted.
457         (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted.
458         (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted.
459         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted.
460         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added.
461         (-[TestCandidate initWithReplacementString:inRange:]):
462         (-[TestCandidate replacementString]):
463         (-[TestCandidate resultType]):
464         (-[TestCandidate range]):
465         (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]):
466         (-[CandidateTestWebView _didHandleAcceptedCandidate]):
467         (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]):
468         (-[CandidateTestWebView _didUpdateCandidateListVisibility:]):
469         (TEST):
470         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
471         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html:
472         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html:
473         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html:
474         * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added.
475         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
476         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html:
477         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html:
478         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
479         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html:
480         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html:
481         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
482         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
483         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
484         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
485         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
486         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
487         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
488         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
489         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html:
490         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html:
491         * TestWebKitAPI/mac/TestWKWebViewMac.h: Added.
492         * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added.
493         (-[TestMessageHandler initWithMessage:handler:]):
494         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
495         (-[TestWKWebView mouseDownAtPoint:]):
496         (-[TestWKWebView performAfterReceivingMessage:action:]):
497         (-[TestWKWebView loadTestPageNamed:]):
498         (-[TestWKWebView typeCharacter:]):
499         (-[TestWKWebView stringByEvaluatingJavaScript:]):
500         (-[TestWKWebView waitForMessage:]):
501         (-[TestWKWebView performAfterLoading:]):
502
503 2016-09-14  Jer Noble  <jer.noble@apple.com>
504
505         [media-source] fix imported/w3c/web-platform-tests/media-source/mediasource-duration.html
506         https://bugs.webkit.org/show_bug.cgi?id=161999
507
508         Reviewed by Eric Carlson.
509
510         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
511         (TestWebKitAPI::TEST):
512
513 2016-09-16  Anders Carlsson  <andersca@apple.com>
514
515         Fix isValidEnum to work with older versions of GCC
516         https://bugs.webkit.org/show_bug.cgi?id=162065
517
518         Reviewed by Michael Catanzaro.
519
520         Add EnumTraits.cpp to the CMake build.
521
522         * TestWebKitAPI/CMakeLists.txt:
523
524 2016-09-16  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
525
526         Unreviewed: Change my primary address for auto-complete in bugzilla.
527
528         * Scripts/webkitpy/common/config/contributors.json:
529
530 2016-09-15  Alex Christensen  <achristensen@webkit.org>
531
532         URLParser: Check for invalid characters in the host
533         https://bugs.webkit.org/show_bug.cgi?id=162023
534
535         Reviewed by Tim Horton.
536
537         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
538         (TestWebKitAPI::TEST_F):
539
540 2016-09-15  Fujii Hironori  <Hironori.Fujii@sony.com>
541
542         [CMake] Refactor GENERATE_BINDINGS
543         https://bugs.webkit.org/show_bug.cgi?id=161854
544
545         Reviewed by Gyuyoung Kim.
546
547         * DumpRenderTree/CMakeLists.txt: Changed the arguments of
548         GENERATE_BINDINGS to new style.
549         * WebKitTestRunner/CMakeLists.txt: Ditto.
550
551 2016-09-15  Ryan Haddad  <ryanhaddad@apple.com>
552
553         Disable failing API WebKit2.DataDetectionReferenceDate until it can be investigated.
554         https://bugs.webkit.org/show_bug.cgi?id=161967
555
556         Unreviewed test gardening.
557
558         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
559         (TEST):
560
561 2016-09-15  Per Arne Vollan  <pvollan@apple.com>
562
563         [Win] run-api-tests is failing.
564         https://bugs.webkit.org/show_bug.cgi?id=162015
565
566         Reviewed by Brent Fulgham.
567
568         MSVC is not interpreting C++ string literals with unicode characters correctly when the source file
569         doesn't contain encoding information. Save the file with utf8 encoding with signature.
570
571         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
572
573 2016-09-15  Jonathan Bedard  <jbedard@apple.com>
574
575         Move --no-sample-on-timeout to config.json for each bot
576         https://bugs.webkit.org/show_bug.cgi?id=161964
577
578         Reviewed by Daniel Bates.
579
580         Roll out changes from 205573 and move them into config.json.  At this time, only macOS and iOS simulator sample a process on timeout, —no-sample-on-timeout is unneeded for GTK, EFL and Windows.
581
582         * BuildSlaveSupport/build.webkit.org-config/config.json: Each bot now independently defines if it will be running sample on timeout.
583         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
584         (RunWebKitTests.start): Rolled out changes from 205573.
585
586 2016-09-15  Csaba Osztrogonác  <ossy@webkit.org>
587
588         js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
589         https://bugs.webkit.org/show_bug.cgi?id=159807
590
591         Reviewed by Saam Barati.
592
593         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
594         (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.
595         * Scripts/run-javascriptcore-tests:
596         (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.
597         * Scripts/run-jsc-stress-tests: Typo fix.
598
599 2016-09-14  Wenson Hsieh  <wenson_hsieh@apple.com>
600
601         Media controls behave strangely when changing media sources
602         https://bugs.webkit.org/show_bug.cgi?id=161914
603         <rdar://problem/28227805>
604
605         Reviewed by Tim Horton.
606
607         Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also
608         tweaks an existing test to account for new `ended` behavior.
609
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
611         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
612         (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]):
613         (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]):
614         (TestWebKitAPI::TEST):
615         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added.
616         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added.
617         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added.
618
619 2016-09-14  Jonathan Bedard  <jbedard@apple.com>
620
621         Fix mastercfg_unittest
622         https://bugs.webkit.org/show_bug.cgi?id=161816
623
624         Reviewed by Daniel Bates.
625
626         (RunWebKitTests.start):
627         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Fixed broken unit tests.
628
629 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
630
631         Landing optimized .png files, forgot to do it initially.
632
633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
638
639 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
640
641         Switch build.webkit.org to iOS 10
642         https://bugs.webkit.org/show_bug.cgi?id=161930
643
644         Reviewed by Daniel Bates.
645
646         * BuildSlaveSupport/build.webkit.org-config/config.json:
647         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
648         (RunWebKitTests.start):
649         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: Added.
651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: Added.
652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: Added.
653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png: Added.
654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png: Added.
657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png: Added.
658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
662         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
663         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
664         * Scripts/webkitpy/port/ios.py:
665         * TestResultServer/static-dashboards/builders.jsonp:
666
667 2016-09-13  Tim Horton  <timothy_horton@apple.com>
668
669         Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
670         https://bugs.webkit.org/show_bug.cgi?id=161896
671         <rdar://problem/28229827>
672
673         Reviewed by Simon Fraser.
674
675         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm:
676         (TestWebKitAPI::TEST):
677         Add a test for the new property.
678         Also fix the old new test to run on arbitrary scale displays without failing.
679
680 2016-09-12  Brent Fulgham  <bfulgham@apple.com>
681
682         [Win][Direct2D] Provide Direct2D-based geometry and transform cast operations
683         https://bugs.webkit.org/show_bug.cgi?id=161818
684
685         Reviewed by Dean Jackson.
686
687         Add several new test suites for the various geometric primitives in WebCore.
688
689         * TestWebKitAPI/PlatformWin.cmake: Add new files for test cases.
690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
691         * TestWebKitAPI/Tests/WebCore/AffineTransform.cpp: Added.
692         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: Added.
693         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: Added.
694         * TestWebKitAPI/Tests/WebCore/FloatSize.cpp: Added.
695         * TestWebKitAPI/Tests/WebCore/IntPoint.cpp: Added.
696         * TestWebKitAPI/Tests/WebCore/IntRect.cpp: Added.
697         * TestWebKitAPI/Tests/WebCore/IntSize.cpp: Added.
698         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Add some new
699         Windows-focused test cases.
700
701 2016-09-12  Chris Dumez  <cdumez@apple.com>
702
703         Fix post-landing review comments after r205787
704         https://bugs.webkit.org/show_bug.cgi?id=161885
705
706         Reviewed by Darin Adler.
707
708         Leverage new StringBuilder::append(CFStringRef) overload.
709
710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
711         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
712
713 2016-09-12  Alex Christensen  <achristensen@webkit.org>
714
715         URLParser: Correctly ignore spaces before relative URLs with no scheme
716         https://bugs.webkit.org/show_bug.cgi?id=161889
717
718         Reviewed by Daniel Bates.
719
720         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
721         (TestWebKitAPI::TEST_F):
722
723 2016-09-12  Alex Christensen  <achristensen@webkit.org>
724
725         URLParser: Fix relative URLs containing only fragments
726         https://bugs.webkit.org/show_bug.cgi?id=161882
727
728         Reviewed by Brady Eidson.
729
730         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
731         (TestWebKitAPI::TEST_F):
732
733 2016-09-12  Alex Christensen  <achristensen@webkit.org>
734
735         URLParser: Correctly handle relative URLs that are just a scheme and a colon
736         https://bugs.webkit.org/show_bug.cgi?id=161876
737
738         Reviewed by Brady Eidson.
739
740         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
741         (TestWebKitAPI::TEST_F):
742
743 2016-09-12  DAN SAUNDERS  <dasau@microsoft.com>
744
745         AX: WKWebView for macOS does not allow configuration of tabsToLinks
746         https://bugs.webkit.org/show_bug.cgi?id=161394
747
748         Reviewed by Anders Carlsson.
749
750         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
751         (TEST):
752
753 2016-09-12  Alex Christensen  <achristensen@webkit.org>
754
755         Remove trailing control characters and spaces before parsing a URL
756         https://bugs.webkit.org/show_bug.cgi?id=161870
757
758         Reviewed by Tim Horton.
759
760         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
761         (TestWebKitAPI::TEST_F):
762
763 2016-09-12  Alex Christensen  <achristensen@webkit.org>
764
765         Fix more URLParser quirks
766         https://bugs.webkit.org/show_bug.cgi?id=161834
767
768         Reviewed by Brady Eidson.
769
770         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
771         (TestWebKitAPI::TEST_F):
772
773 2016-09-10  Alex Christensen  <achristensen@webkit.org>
774
775         Optimize URLParser performance
776         https://bugs.webkit.org/show_bug.cgi?id=161837
777
778         Reviewed by Brady Eidson.
779
780         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
781         (TestWebKitAPI::TEST_F):
782         Added a test to verify the case insensitivity of the default port checks.
783
784 2016-09-10  Chris Dumez  <cdumez@apple.com>
785
786         parseHTMLInteger() should take a StringView in parameter
787         https://bugs.webkit.org/show_bug.cgi?id=161669
788
789         Reviewed by Ryosuke Niwa.
790
791         Explicitly construct a String from the CFStringRef in order to call
792         StringBuilder::append(). This is needed now that there is an append()
793         overload taking an AtomicString in parameter.
794
795         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
796         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
797
798 2016-09-10  Wenson Hsieh  <wenson_hsieh@apple.com>
799
800         Apple.com keynote does not display media controls
801         https://bugs.webkit.org/show_bug.cgi?id=161833
802         <rdar://problem/28230123>
803
804         Reviewed by Tim Horton.
805
806         New unit test verifying that wide videos (~2 aspect ratio) still get media controls.
807
808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
809         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
810         (TestWebKitAPI::TEST):
811         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added.
812
813 2016-09-09  Tim Horton  <timothy_horton@apple.com>
814
815         WKThumbnailView should expose a mode where it can be reparented without resnapshotting
816         https://bugs.webkit.org/show_bug.cgi?id=161828
817         <rdar://problem/28229756>
818
819         Reviewed by Alex Christensen.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added.
823         (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]):
824         (TestWebKitAPI::didFinishLoadForFrame):
825         (TestWebKitAPI::setPageLoaderClient):
826         (TestWebKitAPI::TEST):
827         Add a test ensuring that this behaves correctly.
828
829 2016-09-09  Alex Christensen  <achristensen@webkit.org>
830
831         URLParser: Keep track of cannot-be-a-base-url according to spec
832         https://bugs.webkit.org/show_bug.cgi?id=161830
833
834         Reviewed by Tim Horton.
835
836         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
837         (TestWebKitAPI::TEST_F):
838
839 2016-09-09  Alex Christensen  <achristensen@webkit.org>
840
841         Fix API tests after r205774.
842         https://bugs.webkit.org/show_bug.cgi?id=161820
843
844         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
845         (TestWebKitAPI::TEST_F):
846         I had committed the wrong expected path in one case. The functionality is correct.
847
848 2016-09-09  Michael Saboff  <msaboff@apple.com>
849
850         Unreviewed, rolling r205759 back in with a fix.
851
852         An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc,
853         should be named "toString.baseline-jsc".  For systems with case-insensitive
854         filesystems, the wrong name isn't an issue.  That rename is part of this
855         fix.
856
857         * Scripts/run-javascriptcore-tests:
858         (runJSCStressTests):
859
860 2016-09-09  Johan K. Jensen  <johan_jensen@apple.com>
861
862         Unreviewed. Added myself to the list of committers.
863
864         * Scripts/webkitpy/common/config/contributors.json:
865
866 2016-09-09  Alex Christensen  <achristensen@webkit.org>
867
868         URLParser should convert ASCII hosts to lowercase
869         https://bugs.webkit.org/show_bug.cgi?id=161820
870
871         Reviewed by Geoffrey Garen.
872
873         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
874         (TestWebKitAPI::TEST_F):
875
876 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
877
878         Unreviewed, rolling out r205759.
879
880         This change broke all JSC tests
881
882         Reverted changeset:
883
884         "Add ChakraCore tests to run-javascriptcore-tests"
885         https://bugs.webkit.org/show_bug.cgi?id=161808
886         http://trac.webkit.org/changeset/205759
887
888 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
889
890         Revert r205770 because Ricky is already a committer.
891
892         Unreviewed.
893
894         * Scripts/webkitpy/common/config/contributors.json:
895
896 2016-09-09  Ricky Mondello  <rmondello@apple.com>
897
898         Unreviewed. Added myself to the list of committers.
899
900         * Scripts/webkitpy/common/config/contributors.json:
901
902 2016-09-09  Alex Christensen  <achristensen@webkit.org>
903
904         URLParser: Fix and optimize parsing file URLs ending with a host but no slash
905         https://bugs.webkit.org/show_bug.cgi?id=161815
906
907         Reviewed by Geoffrey Garen.
908
909         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
910         (TestWebKitAPI::TEST_F):
911
912 2016-09-08  Dean Jackson  <dino@apple.com>
913
914         Expose Apple Pencil data to Touch events
915         https://bugs.webkit.org/show_bug.cgi?id=161783
916         <rdar://problem/28218898>
917
918         Reviewed by Beth Dakin.
919
920         The values that IOHID expects are different from their
921         documentation, and from what UITouch interprets. Tweak
922         incoming data so it will produce the output we expect.
923
924         * WebKitTestRunner/ios/HIDEventGenerator.mm:
925         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
926         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
927
928 2016-09-09  JF Bastien  <jfbastien@apple.com>
929
930         Unreviewed. Added myself to the list of committers.
931
932         * Scripts/webkitpy/common/config/contributors.json:
933
934 2016-09-09  Michael Saboff  <msaboff@apple.com>
935
936         Add ChakraCore tests to run-javascriptcore-tests
937         https://bugs.webkit.org/show_bug.cgi?id=161808
938
939         Reviewed by Saam Barati.
940
941         Added ChakraCore tests to the default list of tests to run.
942
943         * Scripts/run-javascriptcore-tests:
944         (runJSCStressTests):
945
946 2016-09-09  Alex Christensen  <achristensen@webkit.org>
947
948         URLParser: Handle \ in path according to spec
949         https://bugs.webkit.org/show_bug.cgi?id=161805
950
951         Reviewed by Andy Estes.
952
953         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
954         (TestWebKitAPI::TEST_F):
955
956 2016-09-09  Alex Christensen  <achristensen@webkit.org>
957
958         URLParser should parse URLs with non-special schemes
959         https://bugs.webkit.org/show_bug.cgi?id=161786
960
961         Reviewed by Andy Estes.
962
963         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
964         (TestWebKitAPI::TEST_F):
965
966 2016-09-08  Yusuke Suzuki  <utatane.tea@gmail.com>
967
968         [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
969         https://bugs.webkit.org/show_bug.cgi?id=161763
970
971         Reviewed by Mark Lam.
972
973         Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
974         that ASan crash does not occur with this patch.
975
976         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
977         (TestWebKitAPI::TEST):
978         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
979         (TestWebKitAPI::TEST):
980
981 2016-09-08  Alex Christensen  <achristensen@webkit.org>
982
983         URLParser: Handle \ in paths of special URLs according to spec
984         https://bugs.webkit.org/show_bug.cgi?id=161781
985
986         Reviewed by Tim Horton.
987
988         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
989         (TestWebKitAPI::TEST_F):
990
991 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
992
993         Update the content-animation.plan file to run css-accelerated-animation.html
994         and pull SVN revision r205680.
995
996         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
997
998 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
999
1000         Add a content-animation test with accelerated CSS animations
1001         https://bugs.webkit.org/show_bug.cgi?id=161776
1002
1003         Reviewed by Dean Jackson.
1004
1005         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
1006
1007 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1008
1009         URLParser: Parsing empty URLs with a base URL should return the base URL
1010         https://bugs.webkit.org/show_bug.cgi?id=161777
1011
1012         Reviewed by Tim Horton.
1013
1014         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1015         (TestWebKitAPI::TEST_F):
1016
1017 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1018
1019         URLParser failures should preserve the original input string
1020         https://bugs.webkit.org/show_bug.cgi?id=161769
1021
1022         Reviewed by Tim Horton.
1023
1024         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1025         (TestWebKitAPI::TEST_F):
1026         (TestWebKitAPI::shouldFail):
1027
1028 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1029
1030         URLParser should parse URLs with a user but no password
1031         https://bugs.webkit.org/show_bug.cgi?id=161773
1032
1033         Reviewed by Brady Eidson.
1034
1035         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1036         (TestWebKitAPI::TEST_F):
1037
1038 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1039
1040         URLParser should parse ports after IPv4 and IPv6 hosts
1041         https://bugs.webkit.org/show_bug.cgi?id=161731
1042
1043         Reviewed by Brady Eidson.
1044
1045         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1046         (TestWebKitAPI::TEST_F):
1047
1048 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1049
1050         URLParser should correctly handle \ in path
1051         https://bugs.webkit.org/show_bug.cgi?id=161762
1052
1053         Reviewed by Brady Eidson.
1054
1055         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1056         (TestWebKitAPI::TEST_F):
1057
1058 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1059
1060         URLParser should handle URLs with empty authority
1061         https://bugs.webkit.org/show_bug.cgi?id=161711
1062
1063         Reviewed by Brady Eidson.
1064
1065         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1066         (TestWebKitAPI::TEST_F):
1067
1068 2016-09-08  Alex Christensen  <achristensen@webkit.org>
1069
1070         Re-land r205580 after r205649 fixed the test failures
1071         https://bugs.webkit.org/show_bug.cgi?id=161668
1072
1073         Re-landing changesets:
1074
1075         "Punycode encode non-ascii hosts in URLParser"
1076         https://bugs.webkit.org/show_bug.cgi?id=161655
1077         http://trac.webkit.org/changeset/205521
1078
1079         "Fix query-only and fragment-only relative URLs when using
1080         URLParser"
1081         https://bugs.webkit.org/show_bug.cgi?id=161657
1082         http://trac.webkit.org/changeset/205526
1083
1084         "URLParser should parse / as a relative URL"
1085         https://bugs.webkit.org/show_bug.cgi?id=161667
1086         http://trac.webkit.org/changeset/205532
1087
1088 2016-09-08  Dean Jackson  <dino@apple.com>
1089
1090         Expose Apple Pencil input to testing system
1091         https://bugs.webkit.org/show_bug.cgi?id=161670
1092         <rdar://problem/28183327>
1093
1094         I fixed the internal builds, now try to fix the public builds.
1095
1096         * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values.
1097
1098 2016-09-07  Dean Jackson  <dino@apple.com>
1099
1100         Expose Apple Pencil input to testing system
1101         https://bugs.webkit.org/show_bug.cgi?id=161670
1102         <rdar://problem/28183327>
1103
1104         Attempt to fix iOS 9 builds.
1105
1106         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1107         (-[HIDEventGenerator _createIOHIDEventType:]):
1108
1109 2016-09-07  Alex Christensen  <achristensen@webkit.org>
1110
1111         Roll out r205580 and r205582.
1112         https://bugs.webkit.org/show_bug.cgi?id=161668
1113
1114         I need to figure out why this is failing on the bots before landing any more URLParser progress.
1115
1116 2016-09-07  Alex Christensen  <achristensen@webkit.org>
1117
1118         Unreviewed, revert r205533.
1119         https://bugs.webkit.org/show_bug.cgi?id=161668
1120
1121         Re-landing changesets:
1122
1123         "Punycode encode non-ascii hosts in URLParser"
1124         https://bugs.webkit.org/show_bug.cgi?id=161655
1125         http://trac.webkit.org/changeset/205521
1126
1127         "Fix query-only and fragment-only relative URLs when using
1128         URLParser"
1129         https://bugs.webkit.org/show_bug.cgi?id=161657
1130         http://trac.webkit.org/changeset/205526
1131
1132         "URLParser should parse / as a relative URL"
1133         https://bugs.webkit.org/show_bug.cgi?id=161667
1134         http://trac.webkit.org/changeset/205532
1135
1136 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
1137
1138         Enable the <meter> element on iOS
1139         https://bugs.webkit.org/show_bug.cgi?id=161714
1140         rdar://problem/8978410
1141
1142         Reviewed by Tim Horton.
1143
1144         Define ENABLE_METER_ELEMENT unconditionally now.
1145
1146         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1147
1148 2016-09-07  Jonathan Bedard  <jbedard@apple.com>
1149
1150         Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests)
1151         https://bugs.webkit.org/show_bug.cgi?id=161699
1152
1153         Reviewed by Alexey Proskuryakov.
1154
1155         This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables.
1156
1157         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1158         (RunWebKitTests): Enable sample on timeout for everything.
1159         (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators.
1160
1161 2016-09-06  Dean Jackson  <dino@apple.com>
1162
1163         Expose Apple Pencil input to testing system
1164         https://bugs.webkit.org/show_bug.cgi?id=161670
1165         <rdar://problem/28183327>
1166
1167         Reviewed by Simon Fraser.
1168
1169         Add API to UIScriptController that allows a test to emulate
1170         stylus input, such as from the Apple Pencil.
1171
1172         The code is only implemented for WebKitTestRunner.
1173
1174         There are also four new tests that ensure an Apple Pencil
1175         operates similarly to a regular touch. The main difference
1176         is that you can't have multiple touches when using an Apple Pencil.
1177
1178         * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations.
1179         (WTR::UIScriptController::stylusDownAtPoint):
1180         (WTR::UIScriptController::stylusMoveToPoint):
1181         (WTR::UIScriptController::stylusUpAtPoint):
1182         (WTR::UIScriptController::stylusTapAtPoint):
1183         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods.
1184         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations.
1185         (WTR::UIScriptController::stylusDownAtPoint):
1186         (WTR::UIScriptController::stylusMoveToPoint):
1187         (WTR::UIScriptController::stylusUpAtPoint):
1188         (WTR::UIScriptController::stylusTapAtPoint):
1189         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1190
1191         * WebKitTestRunner/ios/HIDEventGenerator.h:
1192         * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties
1193         to SyntheticEventDigitizerInfo.
1194         (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types.
1195         (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info.
1196         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
1197         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
1198         (-[HIDEventGenerator stylusUpAtPoint:]):
1199         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1200         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1201         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1202         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1203         * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI.
1204         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API.
1205         (WTR::UIScriptController::stylusDownAtPoint):
1206         (WTR::UIScriptController::stylusMoveToPoint):
1207         (WTR::UIScriptController::stylusUpAtPoint):
1208         (WTR::UIScriptController::stylusTapAtPoint):
1209
1210 2016-09-07  Daniel Bates  <dabates@apple.com>
1211
1212         Update WebKitSystemInterface
1213
1214         Rubber-stamped by Dean Jackson.
1215
1216         Copy WebKitSystemInterface for iOS 10 to the built products directory.
1217
1218         * Scripts/copy-webkitlibraries-to-product-directory:
1219
1220 2016-09-07  Youenn Fablet  <youenn@apple.com>
1221
1222         [Streams API] Separate compile flag for ReadableStream and WritableStream
1223         https://bugs.webkit.org/show_bug.cgi?id=161044
1224
1225         Reviewed by Alex Christensen.
1226
1227         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
1228
1229         * Scripts/webkitperl/FeatureList.pm:
1230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1231
1232 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1233
1234         [GTK] Move some GObject DOM unstable API to stable
1235         https://bugs.webkit.org/show_bug.cgi?id=161681
1236
1237         Reviewed by Žan Doberšek.
1238
1239         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
1240
1241         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1242         (testUserContentManagerScriptMessageFromDOMBindings):
1243         (serverCallback): Deleted.
1244         (beforeAll): Deleted.
1245         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1246         (documentLoadedCallback):
1247         (emitURIChanged): Deleted.
1248
1249 2016-09-07  Youenn Fablet  <youenn@apple.com>
1250
1251         Using tests-options.json to compute whether tests are slow
1252         https://bugs.webkit.org/show_bug.cgi?id=161626
1253
1254         Reviewed by Darin Adler.
1255
1256         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
1257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1258         (Manager.__init__): Loading tests-options.json
1259         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
1260
1261 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1262
1263         [EFL] Need the libosmesa to support the software backend drawing.
1264         https://bugs.webkit.org/show_bug.cgi?id=147065
1265
1266         Reviewed by Gyuyoung Kim.
1267
1268         Added the libosmesa to support the software backend drawing.
1269
1270         * efl/install-dependencies:
1271
1272 2016-09-06  Commit Queue  <commit-queue@webkit.org>
1273
1274         Unreviewed, rolling out r205521, r205526, and r205532.
1275         https://bugs.webkit.org/show_bug.cgi?id=161668
1276
1277         broke API tests (Requested by alexchristensen on #webkit).
1278
1279         Reverted changesets:
1280
1281         "Punycode encode non-ascii hosts in URLParser"
1282         https://bugs.webkit.org/show_bug.cgi?id=161655
1283         http://trac.webkit.org/changeset/205521
1284
1285         "Fix query-only and fragment-only relative URLs when using
1286         URLParser"
1287         https://bugs.webkit.org/show_bug.cgi?id=161657
1288         http://trac.webkit.org/changeset/205526
1289
1290         "URLParser should parse / as a relative URL"
1291         https://bugs.webkit.org/show_bug.cgi?id=161667
1292         http://trac.webkit.org/changeset/205532
1293
1294 2016-09-06  Alex Christensen  <achristensen@webkit.org>
1295
1296         URLParser should parse / as a relative URL
1297         https://bugs.webkit.org/show_bug.cgi?id=161667
1298
1299         Reviewed by Tim Horton.
1300
1301         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1302         (TestWebKitAPI::TEST_F):
1303
1304 2016-09-06  Daniel Bates  <dabates@apple.com>
1305
1306         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
1307         https://bugs.webkit.org/show_bug.cgi?id=161661
1308
1309         Reviewed by Darin Adler.
1310
1311         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
1312         command line tools for simulator with the iOS 10 beta SDK.
1313
1314         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1315         * WebKitTestRunner/Configurations/Base.xcconfig:
1316
1317 2016-09-06  Alex Christensen  <achristensen@webkit.org>
1318
1319         Fix query-only and fragment-only relative URLs when using URLParser
1320         https://bugs.webkit.org/show_bug.cgi?id=161657
1321
1322         Reviewed by Tim Horton.
1323
1324         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1325         (TestWebKitAPI::TEST_F):
1326
1327 2016-09-06  Alex Christensen  <achristensen@webkit.org>
1328
1329         Punycode encode non-ascii hosts in URLParser
1330         https://bugs.webkit.org/show_bug.cgi?id=161655
1331
1332         Reviewed by Tim Horton.
1333
1334         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1335         (TestWebKitAPI::wideString):
1336         (TestWebKitAPI::TEST_F):
1337
1338 2016-09-05  Alex Christensen  <achristensen@webkit.org>
1339
1340         Implement relative file urls and begin implementing character encoding in URLParser
1341         https://bugs.webkit.org/show_bug.cgi?id=161618
1342
1343         Reviewed by Tim Horton.
1344
1345         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1346         (TestWebKitAPI::TEST_F):
1347
1348 2016-09-06  Commit Queue  <commit-queue@webkit.org>
1349
1350         Unreviewed, rolling out r205480.
1351         https://bugs.webkit.org/show_bug.cgi?id=161630
1352
1353         tests-options.json is not known from knockout filesystem
1354         (Requested by youenn on #webkit).
1355
1356         Reverted changeset:
1357
1358         "Using tests-options.json to compute whether tests are slow"
1359         https://bugs.webkit.org/show_bug.cgi?id=161626
1360         http://trac.webkit.org/changeset/205480
1361
1362 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1363
1364         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
1365         https://bugs.webkit.org/show_bug.cgi?id=161606
1366
1367         Reviewed by Darin Adler.
1368
1369         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
1370         time.
1371
1372         * Scripts/prepare-ChangeLog:
1373         (statusDescription):
1374
1375 2016-09-06  Youenn Fablet  <youenn@apple.com>
1376
1377         Using tests-options.json to compute whether tests are slow
1378         https://bugs.webkit.org/show_bug.cgi?id=161626
1379
1380         Reviewed by Darin Adler.
1381
1382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1383         (Manager.__init__): Loading tests-options.json
1384         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
1385
1386 2016-09-06  Commit Queue  <commit-queue@webkit.org>
1387
1388         Unreviewed, rolling out r205461.
1389         https://bugs.webkit.org/show_bug.cgi?id=161628
1390
1391         Introduced "Use of uninitialized value $original in sprintf"
1392         warning (Requested by mcatanzaro on #webkit).
1393
1394         Reverted changeset:
1395
1396         ""Redundant argument in sprintf" warning spam from prepare-
1397         ChangeLog"
1398         https://bugs.webkit.org/show_bug.cgi?id=161606
1399         http://trac.webkit.org/changeset/205461
1400
1401 2016-09-06  Youenn Fablet  <youenn@apple.com>
1402
1403         W3C test importer should be able to identify slow test
1404         https://bugs.webkit.org/show_bug.cgi?id=161601
1405
1406         Reviewed by Darin Adler.
1407
1408         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
1409         Test importer is updating test-options.json file according that information.
1410
1411         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
1412
1413         * Scripts/webkitpy/w3c/test_importer.py:
1414         (TestImporter.__init__):
1415         (TestImporter.find_importable_tests):
1416         (TestImporter.import_tests):
1417         (TestImporter.update_test_options):
1418         (TestImporter):
1419         (TestImporter.remove_slow_from_w3c_test_options):
1420         * Scripts/webkitpy/w3c/test_parser.py:
1421         (TestParser.analyze_test):
1422         (TestParser.is_slow_test):
1423         (TestParser.potential_ref_filename):
1424
1425 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
1426
1427         [Win] Crash logs have incorrect symbols.
1428         https://bugs.webkit.org/show_bug.cgi?id=161603
1429
1430         Reviewed by Darin Adler.
1431
1432         Add build path to _NT_SYMBOL_PATH environment variable.
1433
1434         * Scripts/webkitpy/port/win.py:
1435         (WinPort.setup_crash_log_saving):
1436
1437 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
1438
1439         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
1440         https://bugs.webkit.org/show_bug.cgi?id=160125
1441
1442         Reviewed by Geoffrey Garen and Keith Miller.
1443
1444         * DumpRenderTree/TestRunner.cpp:
1445         * DumpRenderTree/mac/DumpRenderTree.mm:
1446         (DumpRenderTreeMain):
1447         * Scripts/run-jsc-stress-tests:
1448         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1449         (TestWebKitAPI::TEST):
1450
1451 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1452
1453         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
1454         https://bugs.webkit.org/show_bug.cgi?id=161606
1455
1456         Reviewed by Darin Adler.
1457
1458         Avoid extra arguments in call to sprintf.
1459
1460         * Scripts/prepare-ChangeLog:
1461         (statusDescription):
1462
1463 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1464
1465         [GTK] Skip several failing API tests
1466
1467         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
1468         them after bugs are filed.
1469
1470         * Scripts/run-gtk-tests:
1471         (TestRunner):
1472
1473 2016-09-05  Youenn Fablet  <youenn@apple.com>
1474
1475         Fix W3C test importer unit tests after r205447
1476         https://bugs.webkit.org/show_bug.cgi?id=161604
1477
1478         Unreviewed.
1479
1480         * Scripts/webkitpy/w3c/test_importer.py:
1481         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
1482
1483 2016-09-05  Philippe Normand  <pnormand@igalia.com>
1484
1485         WebRTC: Several media stream tests crashing
1486         https://bugs.webkit.org/show_bug.cgi?id=161582
1487
1488         Reviewed by Alejandro G. Castro.
1489
1490         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
1491         glvideoflip GStreamer element.
1492
1493 2016-09-05  Youenn Fablet  <youenn@apple.com>
1494
1495         W3C test importer should generate the list of resource files
1496         https://bugs.webkit.org/show_bug.cgi?id=161578
1497
1498         Reviewed by Ryosuke Niwa.
1499
1500         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
1501
1502         * Scripts/webkitpy/w3c/test_importer.py:
1503         (TestImporter.__init__): Reading test resource files configuration file.
1504         (TestImporter.find_importable_tests):
1505         (TestImporter.import_tests): Update the test resource files based on test parsed files.
1506         (TestImporter):
1507         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
1508         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
1509
1510 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1511
1512         Media controls behave strangely when videos mute from within a playing handler
1513         https://bugs.webkit.org/show_bug.cgi?id=161559
1514         <rdar://problem/28018438>
1515
1516         Reviewed by Darin Adler.
1517
1518         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
1519         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
1520         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
1521         clicking or scrolling.
1522
1523         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1524         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
1525         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
1526         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
1527         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
1528         (TestWebKitAPI::TEST):
1529         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
1530         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
1531         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
1532         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
1533         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
1534         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
1536         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
1537         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
1538         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
1539
1540 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1541
1542         Refactor the heuristic for showing media controls to take all media sessions into account
1543         https://bugs.webkit.org/show_bug.cgi?id=161503
1544         <rdar://problem/28033783>
1545
1546         Reviewed by Darin Adler.
1547
1548         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
1549         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
1550         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
1551         tests more readable.
1552
1553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1554         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1555         (-[MessageHandler initWithMessage:handler:]):
1556         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
1557         (-[VideoControlsManagerTestWebView performAfterLoading:]):
1558         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
1559         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
1560         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
1561         (-[VideoControlsManagerTestWebView controlledElementID]):
1562         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
1563         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
1564         (TestWebKitAPI::TEST):
1565         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
1566         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1567         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
1568         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1569         (-[WKWebView performAfterLoading:]): Deleted.
1570         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
1571         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
1572         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
1573         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
1574         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
1575         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
1576
1577 2016-09-03  Youenn Fablet  <youenn@apple.com>
1578
1579         run-webkit-tests should detect w3c test resource files
1580         https://bugs.webkit.org/show_bug.cgi?id=161307
1581
1582         Reviewed by Ryosuke Niwa.
1583
1584         * Scripts/webkitpy/port/base.py:
1585         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
1586         (Port.potential_test_names_from_expected_file):
1587         (Port._real_tests):
1588         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
1589         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
1590         (Port): Deleted.
1591         * Scripts/webkitpy/port/base_unittest.py:
1592         (PortTest.test_additional_platform_directory):
1593         (PortTest.test_find_no_paths_specified):
1594         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
1595         (PortTest.test_is_w3c_resource_file): Adding tests.
1596
1597 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1598
1599         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
1600
1601         * BuildSlaveSupport/built-product-archive:
1602         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
1603         that no longer exist.
1604
1605 2016-09-02  Alex Christensen  <achristensen@webkit.org>
1606
1607         URLParser should parse file URLs
1608         https://bugs.webkit.org/show_bug.cgi?id=161556
1609
1610         Reviewed by Tim Horton.
1611
1612         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1613         (TestWebKitAPI::TEST_F):
1614         (TestWebKitAPI::checkURLDifferences):
1615
1616 2016-09-01  Michael Saboff  <msaboff@apple.com>
1617
1618         Import Chakra tests to JSC
1619         https://bugs.webkit.org/show_bug.cgi?id=154697
1620
1621         Reviewed by Saam Barati.
1622
1623         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
1624         Chakra tests.
1625
1626         * Scripts/run-jsc-stress-tests:
1627
1628 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
1629
1630         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
1631         https://bugs.webkit.org/show_bug.cgi?id=42547
1632  
1633         Reviewed by Darin Adler.
1634
1635         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
1636         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
1637
1638         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
1639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1640         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
1641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1642         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
1643         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
1644         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
1645         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
1646         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
1647         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
1648         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
1649
1650 2016-09-02  Jer Noble  <jer.noble@apple.com>
1651
1652         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
1653
1654         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
1655         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
1656
1657 2016-09-02  Tim Horton  <timothy_horton@apple.com>
1658
1659         REGRESSION (r205329): Two API tests time out on iOS Simulator
1660         https://bugs.webkit.org/show_bug.cgi?id=161542
1661
1662         Reviewed by Brady Eidson.
1663
1664         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1665         (createAnimatedResizeWebView):
1666         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
1667         (TEST):
1668         (animatedResizeWebView): Deleted.
1669         The navigation delegate was being stored in a local and went out of scope
1670         before the test was over. Keep it around, instead.
1671
1672 2016-08-31  Jer Noble  <jer.noble@apple.com>
1673
1674         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
1675         https://bugs.webkit.org/show_bug.cgi?id=161462
1676
1677         Reviewed by Eric Carlson.
1678
1679         XCTest targets need to be in the same project as the application which they're testing. To facilitate
1680         having external projects with XCTest targets, move the application's implementation into a framework
1681         that can be included with a bare-bones application shell for testing.
1682
1683         Simultaneously, add the ability to load files from within the new framework's bundle by using a
1684         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
1685         an external server for testing.
1686
1687         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1688         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
1689         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
1690         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1691         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
1692         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
1693         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
1694             controller from the framework's bundle.
1695         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
1696         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
1697         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
1698         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
1699         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
1700         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
1701         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
1702         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
1703         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
1704         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
1705         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
1706             pointing to the framework's resources directory.
1707         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
1708         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1709         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1710
1711 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
1712
1713         Fix --no-sample-on-timeout command line argument
1714         https://bugs.webkit.org/show_bug.cgi?id=161507
1715
1716         Reviewed by Alexey Proskuryakov.
1717
1718         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
1719
1720         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1721         (parse_args): Fixed —-no-sample-on-timeout.
1722         * Scripts/webkitpy/port/apple.py:
1723         (ApplePort.sample_process): Use correct file name.
1724         (ApplePort.spindump_file_path): Spindump and sample file names are different.
1725         * Scripts/webkitpy/port/driver.py:
1726         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
1727         * Scripts/webkitpy/port/mac_unittest.py:
1728         (MacTest.test_spindump): Modified for correct filename.
1729
1730 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
1731
1732         Unreviewed: moved myself to the reviewers list.
1733
1734         * Scripts/webkitpy/common/config/contributors.json:
1735
1736 2016-09-02  Tomas Popela  <tpopela@redhat.com>
1737
1738         [GTK] Fix compiler warning in MiniBrowser
1739         https://bugs.webkit.org/show_bug.cgi?id=161529
1740
1741         We were missing a return statement in decidePermissionRequest() and
1742         also there was unused variable in browserWindowConstructed().
1743
1744         Reviewed by Carlos Garcia Campos.
1745
1746         * MiniBrowser/gtk/BrowserTab.c:
1747         (decidePermissionRequest):
1748         * MiniBrowser/gtk/BrowserWindow.c:
1749         (browserWindowConstructed):
1750
1751 2016-09-01  Dan Bernstein  <mitz@apple.com>
1752
1753         Build fix.
1754
1755         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1756
1757 2016-09-01  Tim Horton  <timothy_horton@apple.com>
1758
1759         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
1760         https://bugs.webkit.org/show_bug.cgi?id=161413
1761
1762         Reviewed by Simon Fraser.
1763
1764         Add TestNavigationDelegate, which provides block properties to make
1765         writing tests feel a little more natural (the callbacks can be inline),
1766         and also add WKWebView _test_waitForDidFinishNavigation, so that many
1767         tests don't even need to manually allocate a navigation delegate at all.
1768
1769         Adopt in some of the simpler tests; there are a few navigation delegates
1770         left behind, which we can move to the new model in the future.
1771
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
1774         (TEST):
1775         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
1776         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
1777         (TEST):
1778         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
1779         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1780         (animatedResizeWebView):
1781         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
1782         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1783         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
1784         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1785         (TEST):
1786         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
1787         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
1788         (TEST):
1789         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
1790         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
1791         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
1792         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
1793         (TEST_F):
1794         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
1795         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1796         (expectLinkCount):
1797         (TEST):
1798         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
1799         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
1800         (TEST):
1801         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
1802         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1803         (TEST):
1804         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
1805         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1806         (TEST):
1807         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
1808         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1809         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
1810         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
1811         (TEST):
1812         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
1813         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
1814         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1815         (RequiresUserActionForPlaybackTest::createWebView):
1816         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
1817         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
1818         (RequiresUserActionForPlaybackTest::testAudioOnly):
1819         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
1820         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
1821         (TEST):
1822         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
1823         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1824         (TEST):
1825         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
1826         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
1827         (TEST):
1828         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
1829         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
1830         (TEST):
1831         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1833         (TEST):
1834         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
1835         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
1836         (TEST):
1837         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
1838         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
1839         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
1840         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1841         (-[TestNavigationDelegate webView:didFinishNavigation:]):
1842         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
1843         (-[TestNavigationDelegate waitForDidFinishNavigation]):
1844         (-[WKWebView _test_waitForDidFinishNavigation]):
1845
1846 2016-09-01  Ricky Mondello  <rmondello@apple.com>
1847
1848         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
1849         https://bugs.webkit.org/show_bug.cgi?id=161478
1850         <rdar://problem/28050847>
1851
1852         Reviewed by Eric Carlson.
1853
1854         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
1855         (TestWebKitAPI::TEST_F): Update expected results.
1856
1857 2016-09-01  Anders Carlsson  <andersca@apple.com>
1858
1859         add BlockPtr::fromCallable
1860         https://bugs.webkit.org/show_bug.cgi?id=161504
1861
1862         Reviewed by Tim Horton.
1863
1864         Add a test.
1865
1866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1867         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
1868         (TestWebKitAPI::TEST):
1869
1870 2016-09-01  Alex Christensen  <achristensen@webkit.org>
1871
1872         URLParser should handle . and .. in URL paths
1873         https://bugs.webkit.org/show_bug.cgi?id=161443
1874
1875         Reviewed by Brady Eidson.
1876
1877         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1878         (TestWebKitAPI::eq):
1879         (TestWebKitAPI::TEST_F):
1880
1881 2016-09-01  Commit Queue  <commit-queue@webkit.org>
1882
1883         Unreviewed, rolling out r205295 and r205303.
1884         https://bugs.webkit.org/show_bug.cgi?id=161505
1885
1886         Broke the iOS build (Requested by ryanhaddad on #webkit).
1887
1888         Reverted changesets:
1889
1890         "Refactor MobileMiniBrowser into an application framework to
1891         allow external XCTesting"
1892         https://bugs.webkit.org/show_bug.cgi?id=161462
1893         http://trac.webkit.org/changeset/205295
1894
1895         "Unreviewed build-fix; don't specify an explicit deployment
1896         target."
1897         http://trac.webkit.org/changeset/205303
1898
1899 2016-09-01  Ricky Mondello  <rmondello@apple.com>
1900
1901         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
1902         https://bugs.webkit.org/show_bug.cgi?id=161476
1903         <rdar://problem/28050847>
1904
1905         Reviewed by Eric Carlson.
1906
1907         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
1908         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
1909             logic. A few other tests are added, too.
1910
1911 2016-09-01  Jer Noble  <jer.noble@apple.com>
1912
1913         Unreviewed build-fix; don't specify an explicit deployment target.
1914
1915         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1916
1917 2016-08-31  Jer Noble  <jer.noble@apple.com>
1918
1919         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
1920         https://bugs.webkit.org/show_bug.cgi?id=161462
1921
1922         Reviewed by Eric Carlson.
1923
1924         XCTest targets need to be in the same project as the application which they're testing. To facilitate
1925         having external projects with XCTest targets, move the application's implementation into a framework
1926         that can be included with a bare-bones application shell for testing.
1927
1928         Simultaneously, add the ability to load files from within the new framework's bundle by using a
1929         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
1930         an external server for testing.
1931
1932         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1933         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
1934         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
1935         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1936         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
1937         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
1938         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
1939             controller from the framework's bundle.
1940         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
1941         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
1942         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
1943         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
1944         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
1945         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
1946         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
1947         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
1948         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
1949         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
1950         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
1951             pointing to the framework's resources directory.
1952         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
1953         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1954         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1955
1956 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1957
1958         Unreviewed. Fix webkitpy unit tests after r205280.
1959
1960         * Scripts/webkitpy/style/checker_unittest.py:
1961         (GlobalVariablesTest.test_path_rules_specifier):
1962
1963 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1964
1965         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
1966         https://bugs.webkit.org/show_bug.cgi?id=161438
1967
1968         Reviewed by Michael Catanzaro.
1969
1970         Remove scripts related to the GObject DOM bindings auto-generation.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1973         (RunGtkAPITests.getText2):
1974         (TestFactory.__init__):
1975         (RunWebKit1Tests): Deleted.
1976         (RunWebKit1Tests.start): Deleted.
1977         (RunWebKit1LeakTests): Deleted.
1978         (RunWebKit1LeakTests.start): Deleted.
1979         (RunAndUploadPerfTests): Deleted.
1980         (RunAndUploadPerfTests.start): Deleted.
1981         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
1982         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1983         (BuildStepsTest.test_unnecessary_expected_results):
1984         (RunAndUploadPerfTestsTest): Deleted.
1985         (RunAndUploadPerfTestsTest.assertResults): Deleted.
1986         (RunAndUploadPerfTestsTest.test_success): Deleted.
1987         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
1988         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
1989         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
1990         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
1991         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
1992         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1993         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
1994         (RunBenchmarkTest): Deleted.
1995         (RunBenchmarkTest.assertResults): Deleted.
1996         (RunBenchmarkTest.test_success): Deleted.
1997         * Scripts/run-bindings-tests:
1998         (main):
1999         * Scripts/webkitpy/style/checker.py:
2000         * gtk/check-for-webkitdom-api-breaks: Removed.
2001         * gtk/generate-gtkdoc:
2002         * gtk/webkitdom.py: Removed.
2003
2004 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2005
2006         [EFL] Small clean up in MiniBrowser
2007         https://bugs.webkit.org/show_bug.cgi?id=161428
2008
2009         Reviewed by Yusuke Suzuki.
2010
2011         This patch resizes MiniBrowser, add *char* constants for scheme,
2012         does line breaking, and remove unnecessary spaces.
2013
2014         * MiniBrowser/efl/main.c:
2015         (on_mouse_wheel):
2016         (history_list_hide):
2017         (script_execute_callback):
2018         (on_key_down):
2019         (on_url_changed):
2020         (on_error):
2021         (on_color_picker_request):
2022         (url_from_user_input):
2023         (url_load_from_user_input):
2024         (on_back_button_clicked):
2025         (on_search_case_option_changed):
2026         (on_search_word_start_option_changed):
2027         (on_list_item_select):
2028         (navigation_button_longpress_process):
2029         (on_navigation_policy_decision):
2030         (window_create):
2031         (parse_cookies_policy):
2032
2033 2016-08-31  Alex Christensen  <achristensen@webkit.org>
2034
2035         Implement IPv6 parsing in URLParser
2036         https://bugs.webkit.org/show_bug.cgi?id=161390
2037
2038         Reviewed by Darin Adler.
2039
2040         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2041         (TestWebKitAPI::TEST_F):
2042         (TestWebKitAPI::checkURLDifferences):
2043
2044 2016-08-31  Brady Eidson  <beidson@apple.com>
2045
2046         WK2 Gamepad provider on iOS.
2047         https://bugs.webkit.org/show_bug.cgi?id=161412
2048
2049         Reviewed by Tim Horton.
2050
2051         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2052
2053 2016-08-30  Ricky Mondello  <rmondello@apple.com>
2054
2055         YouTubePluginReplacementTest's URL transformation logic should have tests
2056         https://bugs.webkit.org/show_bug.cgi?id=161406
2057         <rdar://problem/28050847>
2058
2059         Reviewed by Eric Carlson.
2060
2061         Add some very basic tests. Future patches should expand on these to find and fix bugs.
2062
2063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
2064         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
2065         (TestWebKitAPI::test): Added.
2066         (TestWebKitAPI::TEST_F): Added.
2067
2068 2016-08-30  Brady Eidson  <beidson@apple.com>
2069
2070         GameController.framework backend for gamepad API.
2071         https://bugs.webkit.org/show_bug.cgi?id=161086
2072
2073         Reviewed by Alex Christensen.
2074
2075         * MiniBrowser/mac/AppDelegate.m:
2076         (-[BrowserAppDelegate awakeFromNib]):
2077
2078         * MiniBrowser/mac/SettingsController.h:
2079         * MiniBrowser/mac/SettingsController.m:
2080         (-[SettingsController _populateMenu]):
2081         (-[SettingsController validateMenuItem:]):
2082         (-[SettingsController usesGameControllerFramework]):
2083         (-[SettingsController toggleUsesGameControllerFramework:]):
2084
2085 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
2086
2087         Use of uninitialised memory in TransformationMatrx::blend4()
2088         https://bugs.webkit.org/show_bug.cgi?id=134621
2089         <rdar://problem/27337539>
2090
2091         Reviewed by Dean Jackson.
2092
2093         Change is based on the Blink change (patch by <alancutter@chromium.org>):
2094         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
2098         (TestWebKitAPI::TEST):
2099
2100 2016-08-30  Alex Christensen  <achristensen@webkit.org>
2101
2102         URLParser should handle relative URLs that start with //
2103         https://bugs.webkit.org/show_bug.cgi?id=161364
2104
2105         Reviewed by Darin Adler.
2106
2107         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2108         (TestWebKitAPI::checkRelativeURL):
2109         (TestWebKitAPI::TEST_F):
2110
2111 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
2112
2113         EWS patch status page should indicate bot corresponding to each status message
2114         https://bugs.webkit.org/show_bug.cgi?id=161280
2115
2116         Reviewed by Alexey Proskuryakov.
2117
2118         * QueueStatusServer/templates/patch.html: Formatting changes.
2119
2120 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
2121
2122         EWS should indicate which bot processed the patch
2123         https://bugs.webkit.org/show_bug.cgi?id=161222
2124
2125         Reviewed by Alexey Proskuryakov.
2126
2127         * QueueStatusServer/handlers/statusbubble.py:
2128         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
2129         bot ids are now displayed in patch status page.
2130
2131 2016-08-29  Alex Christensen  <achristensen@webkit.org>
2132
2133         URLParser should parse about:blank
2134         https://bugs.webkit.org/show_bug.cgi?id=161324
2135
2136         Reviewed by Brady Eidson.
2137
2138         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2139         (TestWebKitAPI::TEST_F):
2140
2141 2016-08-29  JF Bastien  <jfbastien@apple.com>
2142
2143         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
2144         https://bugs.webkit.org/show_bug.cgi?id=161165
2145
2146         Reviewed by Geoffrey Garen.
2147
2148         Fix handling of `else` in a macro. Don't handle labels in a macro:
2149         the checker is already pretty messy in that area and it should be
2150         a rare thing.
2151
2152         * Scripts/webkitpy/style/checkers/cpp.py:
2153         (check_braces):
2154         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2155         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
2156
2157 2016-08-29  Alex Christensen  <achristensen@webkit.org>
2158
2159         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
2160         https://bugs.webkit.org/show_bug.cgi?id=161317
2161
2162         Reviewed by Brady Eidson.
2163
2164         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2165         (TestWebKitAPI::TEST_F):
2166
2167 2016-08-29  Jer Noble  <jer.noble@apple.com>
2168
2169         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
2170
2171         * Makefile:
2172
2173 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
2174
2175         Sample Process on notifyDone timed out
2176         https://bugs.webkit.org/show_bug.cgi?id=161063
2177
2178         Reviewed by Darin Adler.
2179
2180         * Scripts/webkitpy/port/driver.py:
2181         (Driver._check_for_driver_timeout): 
2182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
2183         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
2184         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
2185
2186 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
2187
2188         Check-webkit-style does not work with Objective-C blocks
2189         https://bugs.webkit.org/show_bug.cgi?id=161247
2190
2191         Reviewed by Darin Adler.
2192
2193         * Scripts/webkitpy/style/checkers/cpp.py:
2194         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
2195         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
2196         (check_spacing_for_function_call): Pass file state for lambda check.
2197         (check_spacing): Pass file state for lambda check.
2198         (check_braces): Pass file state for lambda check.
2199         (check_style): Pass file state for lambda check.
2200         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2201         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
2202         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
2203         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
2204
2205 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
2206
2207         EWS patch status page should indicate bot corresponding to each status message
2208         https://bugs.webkit.org/show_bug.cgi?id=161280
2209
2210         Reviewed by Alexey Proskuryakov.
2211
2212         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
2213         for each status message.
2214         * QueueStatusServer/stylesheets/common.css:
2215         (.status-bot): Added corresponding stylesheet class.
2216
2217 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
2218
2219         Attempt to fix Windows build after r205090.
2220
2221         Unreviewed build fix.
2222
2223         * DumpRenderTree/win/DRTDataObject.cpp:
2224         (cfFileNameWFormat):
2225         (cfUrlWFormat):
2226
2227 2016-08-27  Alex Christensen  <achristensen@webkit.org>
2228
2229         URLParser should parse relative URLs
2230         https://bugs.webkit.org/show_bug.cgi?id=161282
2231
2232         Reviewed by Darin Adler.
2233
2234         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2235         (TestWebKitAPI::TEST):
2236         Added some tests for the new operator=.
2237         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
2238         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
2239         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2240         (TestWebKitAPI::checkURL):
2241         (TestWebKitAPI::TEST_F):
2242         (TestWebKitAPI::checkRelativeURL):
2243         (TestWebKitAPI::checkURLDifferences):
2244         (TestWebKitAPI::shouldFail):
2245         Add some relative URL tests.
2246
2247 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
2248
2249         WTR needs an implementation of setAutomaticLinkDetectionEnabled
2250         https://bugs.webkit.org/show_bug.cgi?id=87162
2251
2252         Reviewed by Darin Adler.
2253
2254         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
2255         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2256         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
2257         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2258         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
2259         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
2260
2261 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
2262
2263         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
2264         https://bugs.webkit.org/show_bug.cgi?id=28685
2265         <rdar://problem/16460975>
2266
2267         Reviewed by Darin Adler.
2268
2269         * Scripts/extract-localizable-js-strings:
2270         * Scripts/update-webkit-localizable-strings:
2271         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
2272         this script still use UTF-16, so keep that the default.
2273
2274 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
2275
2276         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
2277         https://bugs.webkit.org/show_bug.cgi?id=161254
2278
2279         Reviewed by Darin Adler.
2280
2281         Simplify the CSS. My understanding that the CSS was correct, and the root cause
2282         is tracked in bug 160478.
2283
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2285
2286 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
2287
2288         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
2289         https://bugs.webkit.org/show_bug.cgi?id=161217
2290
2291         Reviewed by Ryosuke Niwa.
2292
2293         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
2294         dumps out the lists of tests that would be run and skipped, and, for each, the entry
2295         in TestExpectations that determines the expected outcome of the test.
2296
2297         This is an improved version of webkit-patch print-expectations.
2298
2299         See bug for sample output.
2300
2301         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2302         (Manager._print_expectations_for_subset): Print out the list of tests and expected
2303         outcome for some subset of tests.
2304         (Manager.print_expectations): Do the same splitting by device class that running tests
2305         does, and for each subset of tests, call _print_expectations_for_subset.
2306         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2307         (TestExpectationParser.expectation_for_skipped_test): Set the flag
2308         expectation_line.not_applicable_to_current_platform
2309         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
2310         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
2311         even for skipped tests. This function returns a list relevant for display, taking the skipped
2312         modifier into account.
2313         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
2314         (TestExpectations.readable_filename_and_line_number): Return something printable for 
2315         lines with and without filenames
2316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2317         (main): Handle options.print_expectations
2318         (parse_args): Add support for --print-expectations
2319         (_print_expectations):
2320         * Scripts/webkitpy/port/ios.py:
2321         (IOSSimulatorPort.default_child_processes): Make this a debug log.
2322
2323 2016-08-26  Dan Bernstein  <mitz@apple.com>
2324
2325         Keep trying to fix the build after r205057.
2326
2327         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2328
2329 2016-08-26  Dan Bernstein  <mitz@apple.com>
2330
2331         Keep trying to fix the build after r205057.
2332
2333         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
2334           config.h. This file is only meant to be built with Xcode anyway.
2335         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
2336           with Xcode 7.3 and deploy to iOS 9.0.
2337         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
2338         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
2339         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
2340
2341 2016-08-26  Dan Bernstein  <mitz@apple.com>
2342
2343         Start trying to fix the build after r205057.
2344
2345         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2346
2347 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
2348
2349         Remove Yosemite Leaks from the flakiness dashboard
2350         https://bugs.webkit.org/show_bug.cgi?id=161253
2351
2352         Reviewed by Anders Carlsson.
2353
2354         * TestResultServer/static-dashboards/builders.jsonp:
2355
2356 2016-08-26  Sam Weinig  <sam@webkit.org>
2357
2358         Remove support for ENABLE_LEGACY_WEB_AUDIO
2359         https://bugs.webkit.org/show_bug.cgi?id=161262
2360
2361         Reviewed by Anders Carlsson.
2362
2363         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2364
2365 2016-08-26  Jer Noble  <jer.noble@apple.com>
2366
2367         Add a test harness for running UI tests on the iOS Simulator
2368         https://bugs.webkit.org/show_bug.cgi?id=161265
2369
2370         Reviewed by Simon Fraser.
2371
2372         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
2373         can serve as a test harness for WebKit UI tests.
2374
2375         Also add a basic media playback test which verifies that a <video> element will begin playing in
2376         fullscreen on an iPhone device, but will play inline on an iPad device.
2377
2378         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
2379         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
2380         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
2381         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
2382         * MobileMiniBrowser/Makefile: Added.
2383         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
2384         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
2385         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
2386         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
2387         (-[AppDelegate applicationWillResignActive:]):
2388         (-[AppDelegate applicationDidEnterBackground:]):
2389         (-[AppDelegate applicationWillEnterForeground:]):
2390         (-[AppDelegate applicationDidBecomeActive:]):
2391         (-[AppDelegate applicationWillTerminate:]):
2392         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
2393         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
2394         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
2395         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
2396         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
2397         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
2398         (-[TabViewController dealloc]):
2399         (-[TabViewController viewDidLoad]):
2400         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
2401         (-[TabViewController tableView:cellForRowAtIndexPath:]):
2402         (-[TabViewController tableView:numberOfRowsInSection:]):
2403         (-[TabViewController numberOfSectionsInTableView:]):
2404         (-[TabViewController tableView:canEditRowAtIndexPath:]):
2405         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
2406         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
2407         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
2408         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
2409         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
2410         (-[WebViewController viewDidLoad]):
2411         (-[WebViewController didReceiveMemoryWarning]):
2412         (-[WebViewController reload:]):
2413         (-[WebViewController goBack:]):
2414         (-[WebViewController goForward:]):
2415         (-[WebViewController urlFieldEditingBegan:]):
2416         (-[WebViewController navigateTo:]):
2417         (-[WebViewController showTabs:]):
2418         (-[WebViewController selectWebViewAtIndex:]):
2419         (-[WebViewController removeWebViewAtIndex:]):
2420         (-[WebViewController addWebView]):
2421         (-[WebViewController createWebView]):
2422         (-[WebViewController removeWebView:]):
2423         (-[WebViewController setCurrentWebView:]):
2424         (-[WebViewController webView:didFailNavigation:withError:]):
2425         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
2426         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
2427         (main):
2428         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
2429         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
2430         (-[MobileMiniBrowserUITests setUp]):
2431         (-[MobileMiniBrowserUITests tearDown]):
2432         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
2433
2434 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
2435
2436         webkit-queues queue-status page should should list more recent statuses
2437         https://bugs.webkit.org/show_bug.cgi?id=161220
2438
2439         Reviewed by Daniel Bates.
2440
2441         * QueueStatusServer/handlers/queuestatus.py:
2442         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
2443
2444 2016-08-26  Dan Bernstein  <mitz@apple.com>
2445
2446         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
2447         https://bugs.webkit.org/show_bug.cgi?id=161258
2448
2449         Reviewed by Anders Carlsson.
2450
2451         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
2452         (TestWebKitAPI::TEST):
2453
2454 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2455
2456         Fix the ENABLE(WEBASSEMBLY) build on Linux
2457         https://bugs.webkit.org/show_bug.cgi?id=161197
2458
2459         Reviewed by Mark Lam.
2460
2461         * Scripts/build-jsc:
2462
2463 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2464
2465         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
2466         https://bugs.webkit.org/show_bug.cgi?id=161149
2467
2468         Reviewed by Carlos Garcia Campos.
2469
2470         Add a new function for waiting for the accesibility bus. It sets
2471         the test environment variables before starting the GLib mainloop.
2472         And restores the previous environment after it has finished.
2473         It also adds a timeout (5 seconds) to abort in case it has not
2474         been able to detect the accesibility bus before the timeout expires.
2475
2476         * Scripts/run-gtk-tests:
2477         (TestRunner):
2478         (TestRunner._wait_for_accessibility_bus):
2479         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
2480         (TestRunner._start_accessibility_daemons):
2481         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
2482
2483 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
2484
2485         [Win] Warning fix.
2486         https://bugs.webkit.org/show_bug.cgi?id=161236
2487
2488         Reviewed by Brent Fulgham.
2489
2490         The & operator in the Test struct has no body.
2491
2492         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2493         (TestWebKitAPI::TEST):
2494
2495 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2496
2497         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
2498         https://bugs.webkit.org/show_bug.cgi?id=160736
2499
2500         Reviewed by Carlos Garcia Campos.
2501
2502         This plugs run-gtk-tests into the webkitpy testing infrastructure.
2503         As a benefit of this, run-gtk-tests now can be executed over any of
2504         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
2505         or native xorg). A new command line switch --wayland is added for
2506         run-gtk-tests.
2507
2508         * Scripts/run-gtk-tests:
2509         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
2510         Add a --wayland command line switch.
2511         (TestRunner._start_accessibility_daemons):
2512         (TestRunner):
2513         (TestRunner.__init__):
2514         (TestRunner._run_xvfb): Deleted.
2515         (TestRunner._create_driver):
2516         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
2517         are now done by driver._setup_environ_for_test().
2518         (TestRunner._tear_down_testing_environment):
2519         * Scripts/webkitpy/port/driver.py:
2520         (Driver.__init__): Define self._server_name in the constructor of the base class.
2521         It is used by several functions, so it makes sense to store once the value here.
2522         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
2523         (Driver._start): Get the environment from self._setup_environ_for_test()
2524         * Scripts/webkitpy/port/driver_unittest.py:
2525         (DriverTest):
2526         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
2527         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
2528         (GtkPort.__init__):
2529         (GtkPort._driver_class):
2530         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
2531         (WestonDriver._setup_environ_for_test):
2532         (WestonDriver._start):
2533         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
2534         (XorgDriver._setup_environ_for_test):
2535         (XorgDriver._start):
2536         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
2537         (XvfbDriver._setup_environ_for_test):
2538         (XvfbDriver._start):
2539
2540 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2541
2542         [EFL][GTK] REGRESSION(204877): Fix the clean build
2543         https://bugs.webkit.org/show_bug.cgi?id=161240
2544
2545         Reviewed by Carlos Garcia Campos.
2546
2547         * WebKitTestRunner/PlatformEfl.cmake:
2548         * WebKitTestRunner/PlatformGTK.cmake:
2549
2550 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
2551
2552         EWS should indicate which bot processed the patch
2553         https://bugs.webkit.org/show_bug.cgi?id=161222
2554
2555         Reviewed by Daniel Bates.
2556
2557         * QueueStatusServer/handlers/statusbubble.py:
2558         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
2559         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
2560         Also added "Started processing patch" message to progress_statuses.
2561         I might consider displaying bot id in other statuses as well later on.
2562
2563 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2564
2565         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
2566         https://bugs.webkit.org/show_bug.cgi?id=161184
2567
2568         Reviewed by Carlos Garcia Campos.
2569
2570         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
2571
2572 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
2573
2574         ews queues should update status server when they start processing patch
2575         https://bugs.webkit.org/show_bug.cgi?id=161223
2576
2577         Reviewed by Daniel Bates.
2578
2579         * Scripts/webkitpy/tool/commands/queues.py:
2580         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
2581         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2582         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
2583         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2584         (StyleQueueTest.test_style_queue_with_style_exception): Same.
2585         (test_style_queue_with_watch_list_exception): Same.
2586         (test_non_valid_patch): Same.
2587
2588 2016-08-25  Alex Christensen  <achristensen@webkit.org>
2589
2590         CMake build fix.
2591
2592         * DumpRenderTree/PlatformMac.cmake:
2593
2594 2016-08-25  Alex Christensen  <achristensen@webkit.org>
2595
2596         Fix URLParserTest with GuardMalloc
2597         https://bugs.webkit.org/show_bug.cgi?id=161214
2598         rdar://problem/28014390
2599
2600         Reviewed by Tim Horton.
2601
2602         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
2603         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
2604
2605         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2606         (TestWebKitAPI::eq):
2607         (TestWebKitAPI::checkURL):
2608         (TestWebKitAPI::checkURLDifferences):
2609         (TestWebKitAPI::s): Deleted.
2610
2611 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2612
2613         Dragging against the end of the inline media scrubber causes the media scrubber to hide
2614         https://bugs.webkit.org/show_bug.cgi?id=161207
2615
2616         Reviewed by Eric Carlson.
2617
2618         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
2619         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
2620         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
2621
2622         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2623         (TestWebKitAPI::TEST):
2624
2625 2016-08-25  Daniel Bates  <dabates@apple.com>
2626
2627         Watch more things.
2628
2629         * Scripts/webkitpy/common/config/watchlist:
2630
2631 2016-08-25  Daniel Bates  <dabates@apple.com>
2632
2633         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
2634         (https://bugs.webkit.org/show_bug.cgi?id=148437)
2635
2636         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
2637         and is not installed on the GTK Linux bots.
2638
2639         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
2640         (writeFileWithContent): Added.
2641
2642 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
2643
2644         [Win] run-api-tests is failing.
2645         https://bugs.webkit.org/show_bug.cgi?id=161140
2646
2647         Reviewed by Brent Fulgham.
2648
2649         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
2650
2651         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
2652         (TestWebKitAPI::TEST):
2653
2654 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
2655
2656         [Win] run-api-tests is failing.
2657         https://bugs.webkit.org/show_bug.cgi?id=161140
2658
2659         Reviewed by Brent Fulgham.
2660
2661         The number of times the move constructor is called is different on Windows in this test. This seems
2662         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
2663
2664         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
2665         (TestWebKitAPI::TEST):
2666
2667 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2668
2669         Fix iOS DRT build.
2670
2671         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2672         (WTR::UIScriptController::zoomToScale):
2673
2674 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2675
2676         [iOS DRT] Hook up uiController.zoomToScale() for DRT
2677         https://bugs.webkit.org/show_bug.cgi?id=161173
2678
2679         Reviewed by Tim Horton.
2680         
2681         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
2682         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
2683         
2684         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
2685         the WebThread!), but queue up the callback first.
2686
2687         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2688         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2689         (-[DumpRenderTreeWebScrollView initWithFrame:]):
2690         (-[DumpRenderTreeWebScrollView dealloc]):
2691         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
2692         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
2693         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
2694         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
2695         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
2696         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2697         (WTR::UIScriptController::zoomToScale):
2698         * DumpRenderTree/mac/DumpRenderTree.mm:
2699         (createWebViewAndOffscreenWindow):
2700         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2701         (WTR::UIScriptController::context):
2702
2703 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
2704
2705         Attempt to fix Windows build after r204918.
2706
2707         Unreviewed build fix.
2708
2709         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2710         (ResourceLoadDelegate::willSendRequest):
2711
2712 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2713
2714         [iOS DRT] Get basic viewport tests working in DRT
2715         https://bugs.webkit.org/show_bug.cgi?id=161160
2716
2717         Reviewed by Tim Horton.
2718         
2719         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
2720         scale, and get the contentVisibleRect.
2721         
2722         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
2723         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
2724         
2725         One test has different results between DRT and WTR, but DRT behavior seems to differ
2726         from UIWebView here, so just give it a WK1-specific result.
2727
2728         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2729         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2730         (-[DumpRenderTreeBrowserView documentVisibleRect]):
2731         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2732         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2733         (WTR::UIScriptController::zoomScale):
2734         (WTR::UIScriptController::minimumZoomScale):
2735         (WTR::UIScriptController::maximumZoomScale):
2736         (WTR::UIScriptController::contentVisibleRect):
2737         * DumpRenderTree/mac/DumpRenderTree.mm:
2738         (createWebViewAndOffscreenWindow):
2739         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2740
2741 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2742
2743         Minor project rearrangement.
2744
2745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2746
2747 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2748
2749         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
2750         https://bugs.webkit.org/show_bug.cgi?id=161124
2751
2752         Reviewed by Daniel Bates.
2753         
2754         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
2755         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
2756         
2757         Remove some unnecessary zero initializations of static variables.
2758         
2759         Change _setVisibleSize to use the window size, which should not be a behavior change
2760         because this it just used for text autosizing, which is disabled by default,
2761         and only the width is consulted.
2762
2763         * DumpRenderTree/mac/DumpRenderTree.mm:
2764         (adjustWebDocumentForFlexibleViewport):
2765         (adjustWebDocumentForStandardViewport):
2766         (createWebViewAndOffscreenWindow):
2767
2768 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
2769
2770         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
2771         https://bugs.webkit.org/show_bug.cgi?id=42777
2772
2773         Reviewed by Darin Adler.
2774
2775         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
2776
2777         * DumpRenderTree/TestRunner.cpp:
2778         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
2779         * DumpRenderTree/TestRunner.h:
2780         (TestRunner::deferMainResourceDataLoad): Ditto.
2781         (TestRunner::setDeferMainResourceDataLoad): Ditto.
2782         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
2783
2784 2016-08-23  Anders Carlsson  <andersca@apple.com>
2785
2786         Add enum traits and use them in the IPC::Decoder
2787         https://bugs.webkit.org/show_bug.cgi?id=161103
2788
2789         Reviewed by Sam Weinig.
2790
2791         Add API test.
2792
2793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2794         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
2795         (TestWebKitAPI::TEST):
2796
2797 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
2798
2799         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
2800
2801         * DumpRenderTree/TestRunner.cpp:
2802         * DumpRenderTree/mac/DumpRenderTree.mm:
2803         (DumpRenderTreeMain):
2804         * Scripts/run-jsc-stress-tests:
2805         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2806         (TestWebKitAPI::TEST):
2807
2808 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2809
2810         Try to fix Production builds.
2811         
2812         PRODUCTION_FRAMEWORKS_DIR was undefined here.
2813
2814         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2815
2816 2016-08-24  Dan Bernstein  <mitz@apple.com>
2817
2818         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
2819         https://bugs.webkit.org/show_bug.cgi?id=161152
2820
2821         Reviewed by Anders Carlsson.
2822
2823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2824         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
2825         (TestWebKitAPI::didFinishLoadForFrame):
2826         (TestWebKitAPI::TEST):
2827
2828 2016-08-24  Nan Wang  <n_wang@apple.com>
2829
2830         AX: Add test for line text marker range on iOS
2831         https://bugs.webkit.org/show_bug.cgi?id=161108
2832         <rdar://problem/27976405>
2833
2834         Reviewed by Chris Fleizach.
2835
2836         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2837         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2838         (AccessibilityUIElement::textMarkerRangeForElement):
2839         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2840         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2841         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2842
2843 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
2844
2845         [Win] Warning fixes.
2846         https://bugs.webkit.org/show_bug.cgi?id=161079
2847
2848         Reviewed by Brent Fulgham.
2849
2850         * MiniBrowser/win/WebDownloadDelegate.cpp:
2851         * MiniBrowser/win/WinMain.cpp:
2852         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2853         (TestWebKitAPI::TEST):
2854
2855 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
2856
2857         Fix Windows DRT build.
2858
2859         * DumpRenderTree/win/TestRunnerWin.cpp:
2860         (TestRunner::mainFrameJSContext):
2861
2862 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
2863
2864         Try to fix Windows build.
2865         
2866         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
2867         so that perl finds CodeGeneratorDumpRenderTree.pm.
2868
2869         * DumpRenderTree/CMakeLists.txt:
2870
2871 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
2872
2873         Hook up UIScriptController in DumpRenderTree
2874         https://bugs.webkit.org/show_bug.cgi?id=161064
2875
2876         Reviewed by Sam Weinig.
2877
2878         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
2879         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
2880         in fast/harness which test this.
2881
2882         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
2883
2884         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
2885         WK2-isms. Fix the makefiles to refer to the new location.
2886
2887         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
2888         by ID and firing them once they are complete.
2889
2890         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
2891         * DumpRenderTree/CMakeLists.txt:
2892         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
2893         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2894         * DumpRenderTree/TestRunner.cpp:
2895         (runUIScriptCallback):
2896         (TestRunner::staticFunctions):
2897         (TestRunner::cacheTestRunnerCallback):
2898         (TestRunner::callTestRunnerCallback):
2899         (TestRunner::clearTestRunnerCallbacks):
2900         (nextUIScriptCallbackID):
2901         (TestRunner::runUIScript):
2902         (TestRunner::callUIScriptCallback):
2903         (TestRunner::uiScriptDidComplete):
2904         (TestRunner::cleanup):
2905         * DumpRenderTree/TestRunner.h:
2906         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
2907         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
2908         * DumpRenderTree/mac/DumpRenderTree.mm:
2909         (runTest):
2910         * DumpRenderTree/mac/TestRunnerMac.mm:
2911         (TestRunner::mainFrameJSContext):
2912         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
2913         (WTR::UIScriptController::doAsyncTask):
2914         * DumpRenderTree/win/DumpRenderTree.cpp:
2915         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
2916         (WTR::JSWrappable::~JSWrappable):
2917         (WTR::JSValueMakeStringOrNull):
2918         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
2919         (WTR::JSWrapper::wrap):
2920         (WTR::JSWrapper::unwrap):
2921         (WTR::unwrapObject):
2922         (WTR::JSWrapper::initialize):
2923         (WTR::JSWrapper::finalize):
2924         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
2925         (WTR::toJS):
2926         (WTR::setProperty):
2927         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
2928         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
2929         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
2930         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
2931         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
2932         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
2933         * WebKitTestRunner/CMakeLists.txt:
2934         * WebKitTestRunner/DerivedSources.make:
2935         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2936         (WTR::JSWrappable::~JSWrappable): Deleted.
2937         (WTR::JSValueMakeStringOrNull): Deleted.
2938         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2939         (WTR::JSWrapper::wrap): Deleted.
2940         (WTR::JSWrapper::unwrap): Deleted.
2941         (WTR::unwrapObject): Deleted.
2942         (WTR::JSWrapper::initialize): Deleted.
2943         (WTR::JSWrapper::finalize): Deleted.
2944         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2945         (WTR::toJS): Deleted.
2946         (WTR::setProperty): Deleted.
2947         * WebKitTestRunner/TestInvocation.cpp:
2948         (WTR::TestInvocation::runUISideScript):
2949         (WTR::TestInvocation::uiScriptDidComplete):
2950         * WebKitTestRunner/TestInvocation.h:
2951         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
2952         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
2953         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
2954         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
2955         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2956         * WebKitTestRunner/config.h:
2957         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2958         (WTR::UIScriptController::contentVisibleRect):
2959
2960 2016-08-23  Saam Barati  <sbarati@apple.com>
2961
2962         JSC should have a "microbenchmarks" directory instead of "regress" directory
2963         https://bugs.webkit.org/show_bug.cgi?id=161096
2964
2965         Rubber stamped by Mark Lam.
2966
2967         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
2968         directory and removes all the related html and txt files. I did this because
2969         that directory was only there for microbenchmarks, and not for "regression"
2970         tests. I also changed the various scripts to point to it.
2971
2972         * Scripts/run-javascriptcore-tests:
2973         (runJSCStressTests):
2974         * Scripts/run-jsc-benchmarks:
2975
2976 2016-08-23  Alex Christensen  <achristensen@webkit.org>
2977
2978         Fix EFL build.
2979
2980         * TestWebKitAPI/CMakeLists.txt:
2981         Include new directory.
2982
2983 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
2984
2985         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
2986         https://bugs.webkit.org/show_bug.cgi?id=160125
2987
2988         Reviewed by Geoffrey Garen.
2989
2990         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
2991         * Scripts/run-jsc-stress-tests: New test flag!
2992
2993 2016-08-23  Brady Eidson  <beidson@apple.com>
2994
2995         WK2 Gamepad layout test support.
2996         https://bugs.webkit.org/show_bug.cgi?id=134671
2997
2998         Reviewed by Alex Christensen.
2999         
3000         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
3001         feed back into the UIGamepadProvider.
3002         
3003         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
3004         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
3005
3006         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3007         
3008         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3009         (WTR::TestRunner::setMockGamepadDetails):
3010         (WTR::TestRunner::setMockGamepadAxisValue):
3011         (WTR::TestRunner::setMockGamepadButtonValue):
3012         
3013         * WebKitTestRunner/PlatformWebView.h:
3014         
3015         * WebKitTestRunner/TestController.cpp:
3016         (WTR::TestController::initialize):
3017         
3018         * WebKitTestRunner/TestInvocation.cpp:
3019         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3020         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
3021         
3022         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3023         
3024         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3025         (-[WebKitTestRunnerWindow initWithFrame:]):
3026         (-[WebKitTestRunnerWindow dealloc]):
3027         (WTR::PlatformWebView::keyWindow):
3028         
3029         * WebKitTestRunner/ios/TestControllerIOS.mm:
3030         (WTR::wtr_NSApplication_keyWindow):
3031         (WTR::TestController::platformInitialize):
3032         
3033         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3034         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
3035         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
3036         (-[WebKitTestRunnerWindow dealloc]):
3037         (WTR::PlatformWebView::keyWindow):
3038         
3039         * WebKitTestRunner/mac/TestControllerMac.mm:
3040         (WTR::wtr_NSApplication_keyWindow):
3041         (WTR::TestController::platformInitialize):
3042         * WebKitTestRunner/mac/main.mm:
3043
3044 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
3045
3046         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
3047         https://bugs.webkit.org/show_bug.cgi?id=161047
3048         rdar://problem/27434307
3049
3050         Reviewed by Lucas Forschler.
3051
3052         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
3053
3054 2016-08-23  Chris Dumez  <cdumez@apple.com>
3055
3056         Unreviewed, rolling out r204243.
3057
3058         Caused some layout test failures
3059
3060         Reverted changeset:
3061
3062         "Write API test to cover crash fix in r204135"
3063         https://bugs.webkit.org/show_bug.cgi?id=160587
3064         http://trac.webkit.org/changeset/204243
3065
3066 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3067
3068         Order feature option list in FeatureList.pm
3069         https://bugs.webkit.org/show_bug.cgi?id=161074
3070
3071         Reviewed by Michael Catanzaro.
3072
3073         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
3074
3075         * Scripts/webkitperl/FeatureList.pm:
3076
3077 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
3078
3079         Stop python icon bouncing in the dock while running browser benchmarks.
3080         https://bugs.webkit.org/show_bug.cgi?id=161066
3081
3082         Reviewed by Ryosuke Niwa.
3083
3084         Bouncing python icon may impact browser benchmark results.
3085         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3086         (OSXBrowserDriver.prepare_env):
3087         (OSXBrowserDriver.restore_env):
3088
3089 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
3090
3091         <select> menu on iPad causes shifting of hit-testing areas
3092         https://bugs.webkit.org/show_bug.cgi?id=150079
3093
3094         Reviewed by Tim Horton.
3095
3096         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
3097         so when it changes we have to update visible rects. We were doing this on focus, but failing
3098         to do it on blur.
3099
3100         Added the ability to test by:
3101         1. Making it possible to initiate an animated scroll in the UI process
3102         2. Adding callbacks for starting and ending interaction with a form control. Sadly
3103         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
3104         have no way currently to know when the dimming view behind the popover animates out,
3105         so for now the test keeps trying to tap a button.
3106
3107         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3108         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
3109         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3110         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
3111         (WTR::UIScriptController::didStartFormControlInteractionCallback):
3112         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
3113         (WTR::UIScriptController::didEndFormControlInteractionCallback):
3114         (WTR::UIScriptController::scrollToOffset):
3115         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
3116         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
3117         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3118         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3119         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3120         (-[TestRunnerWKWebView dealloc]):
3121         (-[TestRunnerWKWebView didStartFormControlInteraction]):
3122         (-[TestRunnerWKWebView didEndFormControlInteraction]):
3123         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3124         (WTR::contentOffsetBoundedInValidRange):
3125         (WTR::UIScriptController::scrollToOffset):
3126         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
3127         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
3128
3129 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3130
3131         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
3132         https://bugs.webkit.org/show_bug.cgi?id=160927
3133
3134         Reviewed by Daniel Bates.
3135
3136         * Scripts/process-linux-coredump: Removed.
3137         * Scripts/webkitpy/port/efl.py:
3138         (EflPort._get_crash_log):
3139         * Scripts/webkitpy/port/gtk.py:
3140         (GtkPort._get_crash_log):
3141         * Scripts/webkitpy/port/linux_get_crash_log.py:
3142         (GDBCrashLogGenerator.__init__):
3143         (GDBCrashLogGenerator.generate_crash_log):
3144         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3145         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3146
3147 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
3148
3149         check-webkit-style does not work with Lambda functions in C++
3150         https://bugs.webkit.org/show_bug.cgi?id=160910
3151
3152         Reviewed by Darin Adler.
3153
3154         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
3155
3156         * Scripts/webkitpy/style/checkers/cpp.py:
3157         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
3158         (check_for_non_standard_constructs): Added lambda function check.
3159         (check_spacing_for_function_call): Added lambda function check.
3160         (check_braces): Added lambda function check.
3161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3162         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
3163
3164 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3165
3166         URLParser should parse IPv4 addresses
3167         https://bugs.webkit.org/show_bug.cgi?id=161023
3168
3169         Reviewed by Darin Adler.
3170
3171         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3172         (TestWebKitAPI::TEST_F):
3173         (TestWebKitAPI::checkURLDifferences):
3174         We are already getting differences between the old URL::parse and the new URLParser.
3175         (TestWebKitAPI::shouldFail):
3176
3177 2016-08-21  Daniel Bates  <dabates@apple.com>
3178
3179         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
3180         https://bugs.webkit.org/show_bug.cgi?id=148437
3181
3182         Reviewed by Dan Bernstein.
3183
3184         * Scripts/prepare-ChangeLog:
3185         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
3186         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
3187         assumes that its line ranges were from a unified diff without any context lines.
3188         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
3189         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
3190         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
3191         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
3192         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
3193         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
3194         to /dev/null for the duration of the function call.
3195
3196 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
3197
3198         [EFL] Remove unnecessary a patch to mute ecore warnings
3199         https://bugs.webkit.org/show_bug.cgi?id=160997
3200
3201         Reviewed by Darin Adler.
3202
3203         There is no warning messages during the layout test and perf test
3204         after bumping efl version from 1.17 to 1.18. Remove it.
3205
3206         * efl/patches/ecore_remove_warnings.patch: Removed.
3207
3208 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
3209
3210         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
3211         https://bugs.webkit.org/show_bug.cgi?id=160985
3212
3213         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
3214         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
3215         with that.
3216
3217         * Scripts/webkitpy/layout_tests/views/printing.py:
3218         (Printer.print_config):
3219         * Scripts/webkitpy/port/base.py:
3220         (Port.driver_cmd_line_for_logging):
3221         (Port.driver_cmd_line): Deleted.
3222         * Scripts/webkitpy/port/driver.py:
3223         (IOSSimulatorDriver.cmd_line):
3224         * Scripts/webkitpy/port/ios.py:
3225         (IOSSimulatorPort.__init__):
3226         (IOSSimulatorPort.driver_cmd_line_for_logging):
3227         (IOSSimulatorPort._create_simulators):
3228         (IOSSimulatorPort.setup_test_run):
3229         (IOSSimulatorPort._quit_ios_simulator):
3230         (IOSSimulatorPort.clean_up_test_run):
3231         (IOSSimulatorPort._create_device):
3232         (IOSSimulatorPort):
3233         (IOSSimulatorPort._remove_device):
3234         (IOSSimulatorPort._testing_device):
3235         (IOSSimulatorPort.device_id_for_worker_number):
3236         (IOSSimulatorPort._set_device_class): Deleted.
3237         (IOSSimulatorPort.testing_device): Deleted.
3238         * Scripts/webkitpy/port/port_testcase.py:
3239         (PortTestCase.test_driver_cmd_line):
3240         * Scripts/webkitpy/xcode/simulator.py:
3241         (Device.shutdown):
3242         (Device):
3243         (Device.delete):
3244         (Device.reset):
3245         (Simulator):
3246         (Simulator.create_device):
3247         (Simulator.remove_device):
3248         (Simulator.device_number):
3249         (Simulator.device_state_description):
3250         (Simulator.wait_until_device_is_in_state):
3251
3252 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
3253
3254         Unreviewed, rolling out r204659.
3255
3256         This change appears to have caused ios-simulator LayoutTests
3257         to fail when shutting down the simulator
3258
3259         Reverted changeset:
3260
3261         "REGRESSION (r204477): Running LayoutTests on ios-simulator
3262         became ~15 minutes slower"
3263         https://bugs.webkit.org/show_bug.cgi?id=160985
3264         http://trac.webkit.org/changeset/204659
3265
3266 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
3267
3268         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
3269         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
3270
3271 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
3272
3273         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
3274         https://bugs.webkit.org/show_bug.cgi?id=160985
3275
3276         Reviewed by Alexey Proskuryakov.
3277         
3278         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
3279         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
3280         must not be @memoized, because their return value depends on the value of simulator_device_type().
3281         
3282         Fix by adding some global state in simulator.py that tracks the created devices 
3283         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
3284         and delete them in clean_up_test_run().
3285         
3286         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
3287         that killing the Simulator apps isn't enough.
3288         
3289         Simulator tracks the devices in a global dictionary, since state needs to persist
3290         across different instances of IOSSimulatorPort.
3291         
3292         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
3293         any setup. Rather than implicitly creating a device here (which the old code did),
3294         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
3295         and set flag to say that device_id_for_worker_number() doesn't need to return a real
3296         device id.
3297
3298         * Scripts/webkitpy/layout_tests/views/printing.py:
3299         (print_options):
3300         (Printer.print_config):
3301         * Scripts/webkitpy/port/base.py:
3302         (Port.driver_cmd_line_for_logging):
3303         (Port.driver_cmd_line): Deleted.
3304         * Scripts/webkitpy/port/driver.py:
3305         (IOSSimulatorDriver.cmd_line):
3306         * Scripts/webkitpy/port/ios.py:
3307         (IOSSimulatorPort.__init__):
3308         (IOSSimulatorPort.driver_cmd_line_for_logging):
3309         (IOSSimulatorPort._create_simulators):
3310         (IOSSimulatorPort.setup_test_run):
3311         (IOSSimulatorPort.clean_up_test_run):
3312         (IOSSimulatorPort._create_device):
3313         (IOSSimulatorPort):
3314         (IOSSimulatorPort._remove_device):
3315         (IOSSimulatorPort._testing_device):
3316         (IOSSimulatorPort.device_id_for_worker_number):
3317         (IOSSimulatorPort._set_device_class): Deleted.
3318         (IOSSimulatorPort.testing_device): Deleted.
3319         * Scripts/webkitpy/port/port_testcase.py:
3320         (PortTestCase.test_driver_cmd_line):
3321         * Scripts/webkitpy/xcode/simulator.py:
3322         (Device.shutdown):
3323         (Device.delete):
3324         (Device.reset):
3325         (Simulator.create_device):
3326         (Simulator.remove_device):
3327         (Simulator.device_number):
3328         (Simulator.device_state_description):
3329         (Simulator.wait_until_device_is_in_state):
3330
3331 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
3332
3333         Adopt SimServiceContext in LayoutTestRelay
3334         https://bugs.webkit.org/show_bug.cgi?id=161000
3335         <rdar://problem/25765594>
3336
3337         Reviewed by Daniel Bates.
3338
3339         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3340         * LayoutTestRelay/LayoutTestRelay/main.m:
3341
3342 2016-08-19  Lucas Forschler  <lforschler@apple.com>
3343
3344         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
3345
3346         Reviewed by Kocsen Chung.
3347
3348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3349         (WebKitBuildbot):
3350
3351 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
3352
3353         Partial revert of r203811 - this key is not needed.
3354
3355         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
3356
3357 2016-08-19  Daniel Bates  <dabates@apple.com>
3358
3359         Another attempt to fix the iOS 9.3 build
3360
3361         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
3362
3363         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3364         * WebKitTestRunner/Configurations/Base.xcconfig:
3365
3366 2016-08-19  Lucas Forschler  <lforschler@apple.com>
3367
3368         Remove Yosemite Leaks bot from config.json
3369         
3370         Reviewed by Alexey Proskuryakov.
3371
3372         * BuildSlaveSupport/build.webkit.org-config/config.json:
3373
3374 2016-08-18  Dan Bernstein  <mitz@apple.com>
3375
3376         [Cocoa] API::Number needs to be wrapped by an NSNumber
3377         https://bugs.webkit.org/show_bug.cgi?id=160977
3378         <rdar://problem/27877735>
3379
3380         Reviewed by Anders Carlsson.
3381
3382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3383         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
3384         (TestWebKitAPI::TEST):
3385
3386 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3387
3388         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
3389         https://bugs.webkit.org/show_bug.cgi?id=160895
3390
3391         Reviewed by Dean Jackson.
3392
3393         Link to the existing CoreText framework.
3394
3395         * DumpRenderTree/PlatformWin.cmake:
3396         * TestWebKitAPI/PlatformWin.cmake:
3397
3398 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
3399
3400         [Win] Remove old libraries from build inputs
3401         https://bugs.webkit.org/show_bug.cgi?id=160949
3402
3403         Reviewed by Dean Jackson.
3404
3405         Modify the download script to remove the old 'icuuc.lib' and
3406         'icuin.lib' files for Windows builds.
3407
3408         * Scripts/update-webkit-auxiliary-libs:
3409
3410 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
3411
3412         Extra logging for crash reason
3413         https://bugs.webkit.org/show_bug.cgi?id=160943
3414
3415         Reviewed by Alexey Proskuryakov.
3416
3417         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
3418
3419         * Scripts/webkitpy/port/server_process.py:
3420         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
3421         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
3422         (ServerProcess.has_crashed): Ditto.
3423
3424 2016-08-17  Dan Bernstein  <mitz@apple.com>
3425
3426         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
3427         https://bugs.webkit.org/show_bug.cgi?id=160938
3428         <rdar://problem/27876652>
3429
3430         Reviewed by Anders Carlsson.
3431
3432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3433         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
3434         (TestWebKitAPI::TEST):
3435
3436 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
3437
3438         AX: Support abbreviations in iOS
3439         https://bugs.webkit.org/show_bug.cgi?id=160907
3440
3441         Reviewed by Joanmarie Diggs.
3442
3443         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3444         (AccessibilityUIElement::stringAttributeValue):
3445         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3446         (WTR::AccessibilityUIElement::stringAttributeValue):
3447
3448 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
3449
3450         [EFL] Bump efl version from 1.17 to 1.18
3451         https://bugs.webkit.org/show_bug.cgi?id=160899
3452
3453         Reviewed by Antonio Gomes.
3454
3455         To use efl-1.18, EFL port needs to update install dependencies as well.
3456
3457         * efl/install-dependencies:
3458         * efl/jhbuild.modules:
3459
3460 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
3461
3462         [Win] Add tests for linked fonts.
3463         https://bugs.webkit.org/show_bug.cgi?id=160898
3464
3465         Reviewed by Brent Fulgham.
3466
3467         Add tests for https://trac.webkit.org/changeset/204502.
3468
3469         * TestWebKitAPI/PlatformWin.cmake:
3470         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
3471         (TestWebKitAPI::TEST):
3472
3473 2016-08-16  Daniel Bates  <dabates@apple.com>
3474
3475         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
3476         https://bugs.webkit.org/show_bug.cgi?id=160924
3477
3478         Reviewed by Stephanie Lewis.
3479
3480         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
3481         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
3482         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
3483         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
3484         object that mocks out the file system and SCM operations.
3485
3486         * Scripts/VCSUtils.pm:
3487         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
3488         * Scripts/prepare-ChangeLog:
3489         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
3490         abstracting the logic to query the file system and SCM into functions on a delegate object that
3491         we pass to it.
3492         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
3493         (diffHeaderFormat): Deleted.
3494
3495 2016-08-16  Alex Christensen  <achristensen@webkit.org>
3496
3497         URLParser should parse URLs without credentials
3498         https://bugs.webkit.org/show_bug.cgi?id=160913
3499
3500         Reviewed by Brady Eidson.
3501
3502         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3503         (TestWebKitAPI::s):
3504         (TestWebKitAPI::checkURL):
3505         (TestWebKitAPI::TEST_F):
3506
3507 2016-08-16  Anders Carlsson  <andersca@apple.com>
3508
3509         Add WTF::ScopeExit
3510         https://bugs.webkit.org/show_bug.cgi?id=160908
3511
3512         Reviewed by Geoffrey Garen.
3513
3514         * TestWebKitAPI/CMakeLists.txt:
3515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3516         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
3517         (TestWebKitAPI::TEST):
3518
3519 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
3520
3521         EWS logs file are rotated too quickly
3522         https://bugs.webkit.org/show_bug.cgi?id=160724
3523
3524         Reviewed by Daniel Bates.
3525
3526         Currently we are rotating the log file after 10 iterations of queue. If the queue
3527         doesn't have any pending patches, these iterations result in very small amount of 
3528         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
3529         This results in a lot of log files in a day. This patch ensures that we rotate the
3530         log file when its file size is greater than or equal to 100 KB.
3531
3532         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
3533
3534 2016-08-16  Daniel Bates  <dabates@apple.com>
3535
3536         WKSI static library should be named by major iOS revision, not individual updates
3537         https://bugs.webkit.org/show_bug.cgi?id=160727
3538         <rdar://problem/22274848>
3539
3540         Reviewed by Alexey Proskuryakov.
3541
3542         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3543         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3544         * Scripts/copy-webkitlibraries-to-product-directory:
3545         * WebKitTestRunner/Configurations/Base.xcconfig:
3546         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3547
3548 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3549
3550         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
3551         https://bugs.webkit.org/show_bug.cgi?id=160909
3552
3553         Reviewed by Enrica Casucci.
3554         
3555         Add functions to UIScriptController to dismiss the form accessory view for iOS,
3556         and to programmatically pick a row from a <select> picker.
3557
3558         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3559         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3560         (WTR::UIScriptController::dismissFormAccessoryView):
3561         (WTR::UIScriptController::selectFormAccessoryPickerRow):
3562         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3563         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3564         (WTR::UIScriptController::dismissFormAccessoryView):
3565         (WTR::UIScriptController::selectFormAccessoryPickerRow):
3566
3567 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3568
3569         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
3570         https://bugs.webkit.org/show_bug.cgi?id=160878
3571
3572         Reviewed by Tim Horton.
3573         
3574         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
3575         now that we have the ability to run tests in the iPad simulator.
3576
3577         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3578         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3579         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
3580         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
3581         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3582         * WebKitTestRunner/ios/TestControllerIOS.mm:
3583         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
3584         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3585         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
3586         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
3587
3588 2016-08-15  Anders Carlsson  <andersca@apple.com>
3589
3590         Add an address-of operator to RetainPtr
3591         https://bugs.webkit.org/show_bug.cgi?id=160879
3592
3593         Reviewed by Tim Horton.
3594
3595         Test HashMap and HashSet with an object whose operator& is deleted.
3596
3597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3598         Sort the Xcode project.
3599
3600         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
3601         (DeletedAddressOfOperator::DeletedAddressOfOperator):
3602         (DeletedAddressOfOperator::value):
3603         (DeletedAddressOfOperator::operator==):
3604         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
3605         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
3606         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
3607         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
3608         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3609         (TestWebKitAPI::TEST):
3610         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3611         (TestWebKitAPI::TEST):
3612
3613 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
3614
3615         False crashes in fast/text/emoji-gender-* tests
3616         https://bugs.webkit.org/show_bug.cgi?id=160779
3617
3618         Reviewed by Alexey Proskuryakov.
3619
3620         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
3621
3622         * Scripts/webkitpy/port/driver.py:
3623         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
3624         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
3625         * Scripts/webkitpy/port/server_process.py:
3626         (ServerProcess.write): Allow caller to disable crash flag on exception.
3627
3628 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3629
3630         webkitpy error in TestRunResults.merge()
3631         https://bugs.webkit.org/show_bug.cgi?id=160882
3632
3633         Reviewed by Daniel Bates.
3634         
3635         The argument to TestRunResults.merge() can be None if there are no device-specifc
3636         initial results or retry results in Manager.run(), so just return early in that case.
3637
3638         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3639         (TestRunResults.merge):
3640
3641 2016-08-15  Sam Weinig  <sam@webkit.org>
3642
3643         Speed up compile times by not including wtf/Variant.h so much
3644         https://bugs.webkit.org/show_bug.cgi?id=160847
3645
3646         Reviewed by Alex Christensen and Saam Barati.
3647
3648         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3649         (TestWebKitAPI::TEST):
3650         Explicitly use std::experimental::variant.
3651
3652 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3653
3654         Allow a port to run tests with a custom device setup
3655         https://bugs.webkit.org/show_bug.cgi?id=160833
3656
3657         Reviewed by Daniel Bates.
3658
3659         These changes allow the IOSSimulator port to run tests in iPad mode.
3660
3661         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
3662         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
3663         a custom device will be collected into a set, and run in that device's environment after
3664         the other tests have run.
3665
3666         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3667         (Manager._custom_device_for_test): If the test contains a directory matching a
3668         custom device suffix, return that custom device.
3669         (Manager._set_up_run): Push the custom device class, if any, into options so
3670         that the Worker can get to it.
3671         (Manager.run): Go through the list of tests, and break it down into device-generic
3672         tests, and tests for each device class. _run_test_subset is then called for
3673         each collection of tests, and the results merged.
3674         (Manager._run_test_subset): Some lines unwrapped.
3675         (Manager._end_test_run):
3676         (Manager._run_tests):
3677         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3678         (SingleTestRunner.__init__): Unwrapped a line.
3679         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3680         (TestRunResults.merge): Add this function to merge TestRunResults
3681         * Scripts/webkitpy/layout_tests/views/printing.py:
3682         (Printer.print_workers_and_shards): Print the custom device, if any.
3683         * Scripts/webkitpy/port/base.py:
3684         (Port): Base port has empty array of custom devices.
3685         (Port.setup_test_run): Add device_class argument.
3686         * Scripts/webkitpy/port/driver.py:
3687         (DriverInput.__repr__):
3688         (Driver.check_driver.implementation):
3689         * Scripts/webkitpy/port/efl.py:
3690         (EflPort.setup_test_run):
3691         * Scripts/webkitpy/port/gtk.py:
3692         (GtkPort.setup_test_run):
3693         * Scripts/webkitpy/port/ios.py:
3694         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
3695         (IOSSimulatorPort.__init__):
3696         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
3697         based on the custom device class.
3698         (IOSSimulatorPort._set_device_class):
3699         (IOSSimulatorPort._create_simulators): Factor some code into this function.
3700         (IOSSimulatorPort.setup_test_run):
3701         (IOSSimulatorPort.testing_device):
3702         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
3703         seemed wrong for this function. That was moved to setup_test_run().
3704         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
3705         but this happened too early, before we knew which kind of devices to create. Devices
3706         are now created in setup_test_run().
3707         * Scripts/webkitpy/port/win.py:
3708         (WinPort.setup_test_run):
3709
3710 2016-08-15  Daniel Bates  <dabates@apple.com>
3711
3712         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
3713         private frameworks and libraries
3714         https://bugs.webkit.org/show_bug.cgi?id=155931
3715         <rdar://problem/25807989>
3716
3717         Reviewed by Dan Bernstein.
3718
3719         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
3720         where X is the major version of the active iOS SDK.
3721
3722         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3723         * WebKitTestRunner/Configurations/Base.xcconfig:
3724
3725 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3726
3727         Add a setting and preferences to enable visual viewport mode
3728         https://bugs.webkit.org/show_bug.cgi?id=160843
3729
3730         Reviewed by Sam Weinig.
3731         
3732         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
3733
3734         * MiniBrowser/mac/SettingsController.h:
3735         * MiniBrowser/mac/SettingsController.m:
3736         (-[SettingsController _populateMenu]):
3737         (-[SettingsController validateMenuItem:]):
3738         (-[SettingsController visualViewportEnabled]):
3739         (-[SettingsController toggleVisualViewportEnabled:]):
3740         * MiniBrowser/mac/WK1BrowserWindowController.m:
3741         (-[WK1BrowserWindowController didChangeSettings]):
3742         * MiniBrowser/mac/WK2BrowserWindowController.m:
3743         (-[WK2BrowserWindowController didChangeSettings]):
3744
3745 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
3746
3747         Allow using make-dist with non-GTK ports
3748         https://bugs.webkit.org/show_bug.cgi?id=160842
3749
3750         Reviewed by Michael Catanzaro.
3751
3752         This patch adds support for setting base name of tarball and argument
3753         passed to cmake's -DPORT= via command line arguments.
3754
3755         * gtk/make-dist.py:
3756         (Distcheck.configure):
3757         (Distcheck.check):
3758         (get_tarball_root_and_output_filename_from_arguments):
3759
3760 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3761
3762         [GTK] Install script lacks gstreamer related dependencies
3763         https://bugs.webkit.org/show_bug.cgi?id=160814
3764
3765         Reviewed by Carlos Garcia Campos.
3766
3767         * gtk/install-dependencies: Fedora case had already listed this dependencies,
3768         but both Arch and Debian/Ubuntu were missing them.
3769
3770 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
3771
3772         make-dist.py should not allow unknown rules in manifest
3773         https://bugs.webkit.org/show_bug.cgi?id=160841
3774
3775         Reviewed by Carlos Garcia Campos.
3776
3777         * gtk/make-dist.py:
3778         (Manifest.process_line):
3779
3780 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3781
3782         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
3783         https://bugs.webkit.org/show_bug.cgi?id=160809
3784
3785         Reviewed by Carlos Garcia Campos.
3786
3787         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
3788         case, and use it also for the new package names of libpng and libgeoclue.
3789         * gtk/install-dependencies: Ditto.
3790
3791 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3792
3793         Skip to check directories existence in build-webkit
3794         https://bugs.webkit.org/show_bug.cgi?id=160691
3795
3796         Reviewed by Alex Christensen.
3797
3798         CMake checks if directories are there itself. So CMake ports
3799         don't need to check it in the build-webkit script.
3800
3801         * Scripts/build-webkit:
3802         * Scripts/webkitdirs.pm:
3803         (determineSourceDir):
3804         (isCMakeBuild):
3805
3806 2016-08-12  Alex Christensen  <achristensen@webkit.org>
3807
3808         Make URLParser work with URLs missing URL parts
3809         https://bugs.webkit.org/show_bug.cgi?id=160824
3810
3811         Reviewed by Brady Eidson.
3812
3813         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3814         (TestWebKitAPI::s):
3815         (TestWebKitAPI::checkURL):
3816         (TestWebKitAPI::TEST_F):
3817         (TestWebKitAPI::eq): Deleted.
3818
3819 2016-08-12  John Wilander  <wilander@apple.com>
3820
3821         Add HashCountedSet API tests to TestWTFLibrary target
3822         https://bugs.webkit.org/show_bug.cgi?id=160815
3823
3824         Reviewed by Alex Christensen.
3825
3826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3827             Added HashCountedSet.cpp and sorted the file reference section
3828             according to UNIX sort.
3829
3830 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
3831
3832         run-benchmark should run JetStream 1.1 instead of 1.0.1
3833         https://bugs.webkit.org/show_bug.cgi?id=160816
3834
3835         Reviewed by Filip Pizlo.
3836
3837         Use the latest JetStream 1.1 in run-benchmark.
3838
3839         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3840         (BenchmarkBuilder.__exit__):
3841         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
3842         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
3843         change to JetStream directory.
3844
3845 2016-08-12  Alex Christensen  <achristensen@webkit.org>
3846
3847         Initial URLParser implementation
3848         https://bugs.webkit.org/show_bug.cgi?id=160811
3849
3850         Reviewed by Brady Eidson.
3851
3852         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3853         (TestWebKitAPI::eq):
3854         (TestWebKitAPI::checkURL):
3855         (TestWebKitAPI::TEST_F):
3856
3857 2016-08-12  Brady Eidson  <beidson@apple.com>
3858
3859         Fix the 32-bit Mac build after:
3860         Add WK2 ExperimentalFeature support to MiniBrowser
3861         https://bugs.webkit.org/show_bug.cgi?id=160788
3862
3863         Unreviewed.
3864
3865         Sprinkle "#if WK_API_ENABLED"s liberally.
3866         
3867         * MiniBrowser/mac/AppDelegate.m:
3868         (defaultConfiguration):
3869         * MiniBrowser/mac/SettingsController.m:
3870         (-[SettingsController _populateMenu]):
3871         (-[SettingsController validateMenuItem:]):
3872
3873 2016-08-12  Philippe Normand  <pnormand@igalia.com>
3874
3875         [GStreamer][OWR] Video rendering fixes
3876         https://bugs.webkit.org/show_bug.cgi?id=160764
3877
3878         Reviewed by Xabier Rodriguez-Calvar.
3879
3880         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
3881
3882 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
3883
3884         Add missing return statement in convertFast function added in r204376.
3885
3886         Unreviewed.
3887
3888         * Scripts/webkitpy/common/system/path.py:
3889         (_CygPath.convertFast):
3890
3891 2016-08-11  Brady Eidson  <beidson@apple.com>
3892
3893         Add WK2 ExperimentalFeature support to MiniBrowser.
3894         https://bugs.webkit.org/show_bug.cgi?id=160788
3895
3896         Reviewed by Alex Christensen.
3897
3898         * MiniBrowser/mac/AppDelegate.h:
3899         * MiniBrowser/mac/AppDelegate.m:
3900         (defaultConfiguration):
3901         (defaultPreferences):
3902         
3903         * MiniBrowser/mac/SettingsController.m:
3904         (-[SettingsController _populateMenu]):
3905         (-[SettingsController validateMenuItem:]):
3906         (-[SettingsController toggleExperimentalFeature:]):
3907
3908 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
3909
3910         Keep EWS logs for longer
3911         https://bugs.webkit.org/show_bug.cgi?id=160776
3912
3913         Reviewed by Daniel Bates.
3914
3915         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
3916
3917 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
3918
3919         iOS DRT/WTR project cleanup
3920         https://bugs.webkit.org/show_bug.cgi?id=160778
3921
3922         Reviewed by Tim Horton.
3923
3924         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
3925
3926         Remove AppDelegate.* which were unused.
3927
3928         Exclude ios/Launch.storyboard on more platforms.
3929
3930         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3931         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3932         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3933         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3934         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
3935         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
3936         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
3937
3938 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3939
3940         Fix Yosemite bots' cookie accept policies after r204365.
3941         https://bugs.webkit.org/show_bug.cgi?id=160758
3942
3943         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
3944         (TEST):
3945         This makes the test fully clean up after itself.
3946
3947 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3948
3949         Fix Yosemite bots' cookie accept policies after r204365.
3950         https://bugs.webkit.org/show_bug.cgi?id=160758
3951
3952         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
3953         (TEST):
3954         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
3955         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
3956         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
3957         causing any problems because there are no other API tests that do anything with cookies.
3958         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
3959         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
3960         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
3961
3962 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
3963
3964         EWS should check if the patch is still valid before executing every major step
3965         https://bugs.webkit.org/show_bug.cgi?id=160739
3966         rdar://problem/27768813
3967
3968         Reviewed by Alexey Proskuryakov.
3969
3970         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3971         (CommitQueueTask.run): validate method is now executed in base class.
3972         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3973         (EarlyWarningSystemTask.run): validate method is now executed in base class.
3974         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3975         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
3976         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3977         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
3978         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
3979         * Scripts/webkitpy/tool/commands/perfalizer.py:
3980         (PerfalizerTask.validate): Added.
3981         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3982         (test_manual_reject_during_processing): Updated test case.
3983
3984 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3985
3986         Add URLParser stub
3987         https://bugs.webkit.org/show_bug.cgi?id=160770
3988
3989         Reviewed by Sam Weinig.
3990
3991         * TestWebKitAPI/PlatformGTK.cmake:
3992         * TestWebKitAPI/PlatformWin.cmake:
3993         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3994         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
3995         (TestWebKitAPI::TEST_F):
3996
3997 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3998
3999         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
4000         https://bugs.webkit.org/show_bug.cgi?id=160761
4001
4002         Reviewed by Tim Horton.
4003
4004         Give iOS DRT a Launch storyboard.
4005
4006         Have it use a UIViewController so future forms testing works correctly.
4007
4008         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
4009         can run in iPad mode.
4010
4011         Remove empty InfoPlist.strings files.
4012
4013         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4014         * DumpRenderTree/ios/Info.plist:
4015         * DumpRenderTree/ios/Launch.storyboard: Added.
4016         * DumpRenderTree/mac/DumpRenderTree.mm:
4017         (createWebViewAndOffscreenWindow):
4018         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4019         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
4020         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4021         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
4022
4023 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
4024
4025         [Win] Unable to reliably run tests in parallel
4026         https://bugs.webkit.org/show_bug.cgi?id=140914
4027
4028         Reviewed by Brent Fulgham.
4029
4030         The cygpath utility function can fail badly when running with multiple DumpRenderTree
4031         processes. We can use string replacement to convert the Cygwin path to a Windows path
4032         instead.
4033
4034         * Scripts/webkitpy/common/system/path.py:
4035         (cygpathFast):
4036         * Scripts/webkitpy/port/driver.py:
4037         (Driver._command_from_driver_input):
4038
4039 2016-08-10  Alex Christensen  <achristensen@webkit.org>
4040
4041         Fix crash when changing cookie accept policy after r204327
4042         https://bugs.webkit.org/show_bug.cgi?id=160758
4043
4044         Reviewed by Simon Fraser.
4045
4046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4047         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
4048         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
4049         (TEST):
4050         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
4051
4052 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
4053
4054         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
4055         https://bugs.webkit.org/show_bug.cgi?id=160757
4056
4057         Reviewed by Tim Horton.
4058
4059         When programmatically creating the test UIWindow, make a root UIViewController and parent
4060         the WKWebView in its view. This makes the app more like a normal UIKit application.
4061         
4062         Move the WKWebView down 20px to avoid the status bar.
4063         
4064         Give the UIWindow a gray background so it's obvious where the window and view positioned.
4065
4066         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
4067         
4068         Remove duplicate references to Launch.storyboard.
4069
4070         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4071         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
4072         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
4073         (-[AppDelegate applicationWillResignActive:]): Deleted.
4074         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
4075         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
4076         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
4077         (-[AppDelegate applicationWillTerminate:]): Deleted.
4078         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4079         (WTR::viewRectForWindowRect):
4080         (WTR::PlatformWebView::PlatformWebView):
4081         (WTR::PlatformWebView::setWindowFrame):
4082
4083 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
4084
4085         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
4086         https://bugs.webkit.org/show_bug.cgi?id=160748
4087
4088         Reviewed by Tim Horton.
4089         
4090         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
4091         opens the door for tests using other device sizes.
4092
4093         * WebKitTestRunner/ios/TestControllerIOS.mm:
4094         (WTR::TestController::platformConfigureViewForTest):
4095
4096 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
4097
4098         Sort the feature flags in the FEATURE_DEFINES lines
4099         https://bugs.webkit.org/show_bug.cgi?id=160742
4100
4101         Reviewed by Anders Carlsson.
4102         
4103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4104
4105 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
4106
4107         Logging and other minor improvements to iOS webkitpy
4108         https://bugs.webkit.org/show_bug.cgi?id=160722
4109
4110         Reviewed by Dan Bates.
4111
4112         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
4113         to make it easier to debug launching issues.
4114
4115         Have reset_preferences() reset the device, rather than just nuking the data
4116         directory (which broke some versions of the simulator).
4117
4118         Make the Simulator.app launch in the background with open -g.
4119
4120         Wait for the simulator device to be in a known state in some more places.
4121
4122         * Scripts/webkitpy/port/ios.py:
4123         (IOSSimulatorPort.setup_test_run):
4124         (IOSSimulatorPort._quit_ios_simulator):
4125         (IOSSimulatorPort.clean_up_test_run):
4126         (IOSSimulatorPort.setup_environ_for_server):
4127         (IOSSimulatorPort.reset_preferences):
4128         * Scripts/webkitpy/xcode/simulator.py:
4129         (Device.create):
4130         (Device.delete):
4131         (Device):
4132         (Device.reset):
4133         (Simulator.wait_until_device_is_booted):
4134         (Simulator.wait_until_device_is_in_state):
4135         (Simulator):
4136         (Simulator.delete_device):
4137         (Simulator.reset_device):
4138         (Simulator.lookup_or_create_device):
4139
4140 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4141
4142         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
4143         https://bugs.webkit.org/show_bug.cgi?id=160697
4144
4145         Reviewed by Antonio Gomes.
4146
4147         * Scripts/webkitpy/port/base.py:
4148         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
4149         list of environment variables to copy.
4150
4151 2016-08-09  George Ruan  <gruan@apple.com>
4152
4153         Implement functionality of media capture on iOS
4154         https://bugs.webkit.org/show_bug.cgi?id=158945
4155         <rdar://problem/26893343>
4156
4157         Reviewed by Tim Horton.
4158
4159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
4160         Capture feature on iOS.
4161
4162 2016-08-09  Saam Barati  <sbarati@apple.com>
4163
4164         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
4165         https://bugs.webkit.org/show_bug.cgi?id=160671
4166         <rdar://problem/27756112>
4167
4168         Reviewed by Mark Lam.
4169
4170         * Scripts/run-jsc-stress-tests:
4171
4172 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
4173
4174         Make directory reading code in iOSSimulatorDevices() more strict
4175         https://bugs.webkit.org/show_bug.cgi?id=160702
4176
4177         Reviewed by Tim Horton.
4178
4179         * Scripts/webkitdirs.pm:
4180         (iOSSimulatorDevices):
4181
4182 2016-08-06  Sam Weinig  <sam@webkit.org>
4183
4184         Replace NodeOrString with std::variant<RefPtr<Node>, String>
4185         https://bugs.webkit.org/show_bug.cgi?id=160638
4186
4187         Reviewed by Anders Carlsson.
4188
4189         * TestWebKitAPI/CMakeLists.txt:
4190         * TestWebKitAPI/Tests/WTF/Variant.cpp:
4191         Add additional tests for the initial state of std::variant and using
4192         makeVisitor for visiting.
4193
4194 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
4195
4196         EWS logging should ensure the logging to file is stopped on queue termination
4197         https://bugs.webkit.org/show_bug.cgi?id=160698
4198         rdar://problem/24464570
4199
4200         Reviewed by Daniel Bates.
4201
4202         * Scripts/webkitpy/tool/bot/queueengine.py:
4203         (QueueEngine._stopping): Stop logging to file on queue termination.
4204         (QueueEngine._begin_logging): Configure the Python logger to log to file.
4205         * Scripts/webkitpy/common/system/logutils.py:
4206         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
4207         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4208         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
4209         * Scripts/webkitpy/tool/commands/queues.py:
4210         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
4211         (AbstractQueue.queue_log_path): Same.
4212         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
4213         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
4214         which moved to QueueEngine now.
4215         (PatchProcessingQueue.__init__): Same.
4216         (CommitQueue.__init__): Same.
4217         (AbstractReviewQueue.__init__): Same.
4218         (StyleQueue.__init__): Same.
4219         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4220         (TestCommitQueue): Removed host parameter.
4221         (TestCommitQueue.__init__): Same.
4222         (AbstractPatchQueueTest.test_next_patch): Same.
4223         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
4224         (test_commit_queue_failure): Same.
4225         (mock_run_webkit_patch):
4226         (MockCommitQueueTask.results_from_patch_test_run): Same.
4227         (test_rollout_lands): Same.
4228         (test_non_valid_patch): Same.
4229         (test_auto_retry): Same.
4230         (test_style_queue_with_watch_list_exception): Same.
4231         (TestQueue.__init__): Deleted.
4232         (TestReviewQueue.__init__): Deleted.
4233         (TestFeederQueue.__init__): Deleted.
4234
4235 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
4236
4237         webkit-gtk tarball fails to build due to missing files
4238         https://bugs.webkit.org/show_bug.cgi?id=160684
4239
4240         Reviewed by Alex Christensen.
4241
4242         * gtk/manifest.txt.in: Added back spi directories.
4243
4244 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4245
4246         [GTK] Build the jhbuild with -O2 optimization level by default
4247         https://bugs.webkit.org/show_bug.cgi?id=160544
4248
4249         Reviewed by Michael Catanzaro.
4250
4251         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
4252         which don't increases the required disk space significatively and
4253         provides better debug information than no passing it.
4254
4255 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
4256
4257         Allow more --cmakeargs option in build-jsc and build-webkit
4258         https://bugs.webkit.org/show_bug.cgi?id=160340
4259
4260         Reviewed by Michael Catanzaro.
4261
4262         * Scripts/build-jsc:
4263         * Scripts/build-webkit:
4264
4265 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4266
4267         Do not check if WebKitLibraries folder exists on EFL and GTK
4268         https://bugs.webkit.org/show_bug.cgi?id=160659
4269
4270         Reviewed by Csaba Osztrogonác.
4271
4272         Though WebKitLibraries is only needed by mac and win ports,
4273         EFL and GTK ports have checked whether it exists.
4274
4275         * Scripts/build-webkit:
4276
4277 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
4278
4279         Some EWS console logs doesn't go to log file
4280         https://bugs.webkit.org/show_bug.cgi?id=160585
4281         rdar://problem/24464570
4282
4283         Reviewed by Daniel Bates.
4284
4285         * Scripts/webkitpy/common/system/logutils.py:
4286         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
4287         any possible overwriting.
4288         * Scripts/webkitpy/common/system/filesystem.py:
4289         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
4290         * Scripts/webkitpy/common/system/filesystem_mock.py:
4291         (MockFileSystem.open_text_file_for_writing): Same.
4292         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4293         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
4294         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
4295         * Scripts/webkitpy/tool/commands/queues.py:
4296         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
4297         This will ensure that all the sub-modules inside webkitpy will log to file.
4298
4299 2016-08-08  Simon Fraser  <simon.fraser@apple.com>