WebKit1 is flashy when compositing layers come and go
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
2
3         WebKit1 is flashy when compositing layers come and go
4         https://bugs.webkit.org/show_bug.cgi?id=132655
5         <rdar://problem/16830981&16788846>
6
7         Reviewed by Sam Weinig.
8         
9         Revert the change from r166117.
10
11         * DumpRenderTree/mac/DumpRenderTree.mm:
12         (updateDisplay):
13
14 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
15
16         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
17         https://bugs.webkit.org/show_bug.cgi?id=132622
18
19         Reviewed by Mario Sanchez Prada.
20
21         * DumpRenderTree/AccessibilityUIElement.cpp:
22         (selectTextWithCriteriaCallback):
23         (isEqualCallback):
24         * DumpRenderTree/AccessibilityUIElement.h:
25         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
26         (AccessibilityUIElement::selectTextWithCriteria):
27         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
28         (AccessibilityUIElement::selectTextWithCriteria):
29         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
30         (selectTextParameterizedAttributeForCriteria):
31         (AccessibilityUIElement::selectTextWithCriteria):
32         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
33         (AccessibilityUIElement::selectTextWithCriteria):
34         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
35         (WTR::AccessibilityUIElement::selectTextWithCriteria):
36         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
37         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
38         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
39         (WTR::AccessibilityUIElement::selectTextWithCriteria):
40         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
41         (WTR::AccessibilityUIElement::selectTextWithCriteria):
42         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
43         (WTR::selectTextParameterizedAttributeForCriteria):
44         (WTR::AccessibilityUIElement::selectTextWithCriteria):
45
46 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
47
48         [SOUP] TLSErrors do not cause page load to fail when not ignored
49         https://bugs.webkit.org/show_bug.cgi?id=121548
50
51         Reviewed by Sergio Villar Senin.
52
53         Add unit tests to check that the load fails with TLS errors in
54         case of a redirection.
55
56         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
57         (testTLSErrorsRedirect):
58         (httpsServerCallback):
59         (beforeAll):
60
61 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
62
63         [CSS Grid Layout] Remove runtime feature
64         https://bugs.webkit.org/show_bug.cgi?id=132382
65
66         Reviewed by Benjamin Poulain.
67
68         Remove cssGridLayoutEnabled setting usage.
69
70         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
71         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
72         * DumpRenderTree/efl/TestRunnerEfl.cpp:
73         (TestRunner::overridePreference):
74         * DumpRenderTree/mac/DumpRenderTree.mm:
75         (resetWebPreferencesToConsistentValues):
76
77 2014-05-06  David Kilzer  <ddkilzer@apple.com>
78
79         Add Makefile targets for copying static libraries (LLVM and WKSI)
80         <http://webkit.org/b/132619>
81
82         Reviewed by Mark Rowe.
83
84         * Scripts/copy-webkitlibraries-to-product-directory: Set a
85         sensible default for product directory if not specified on
86         either the command-line or in the environment (by Xcode) by
87         calling productDir() in webkitdirs.pm.
88
89 2014-05-06  Brady Eidson  <beidson@apple.com>
90
91         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
92         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
93
94         Reviewed by Sam Weinig.
95
96         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
97
98         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
99         (TestWebKitAPI::itemURLLastComponentIsString):
100         (TestWebKitAPI::didFinishLoadForFrame):
101         (TestWebKitAPI::willGoToBackForwardListItem):
102         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
103         (TestWebKitAPI::setPageLoaderClient):
104         (TestWebKitAPI::TEST):
105         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
106         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
107
108         * WebKitTestRunner/TestController.cpp:
109         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
110
111 2014-05-06  Darin Adler  <darin@apple.com>
112
113         Try to fix iOS build.
114
115         * DumpRenderTree/mac/TestRunnerMac.mm:
116         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
117         Updated since I changed testRunner into a pointer instead of a reference.
118         Updated argument names to avoid conflict with field names.
119         (-[APITestDelegateIPhone run]): Ditto.
120         (-[APITestDelegateIPhone _cleanUp]): Ditto.
121
122 2014-05-06  Commit Queue  <commit-queue@webkit.org>
123
124         Unreviewed, rolling out r168304.
125         https://bugs.webkit.org/show_bug.cgi?id=132607
126
127         Broke the build (Requested by KaL on #webkit).
128
129         Reverted changeset:
130
131         "[GTK][CMake] Unable to do make install"
132         https://bugs.webkit.org/show_bug.cgi?id=130188
133         http://trac.webkit.org/changeset/168304
134
135 2014-05-04  Darin Adler  <darin@apple.com>
136
137         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
138         https://bugs.webkit.org/show_bug.cgi?id=80222
139
140         Reviewed by Alexey Proskuryakov.
141
142         * DumpRenderTree/mac/TestRunnerMac.mm:
143         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
144         do more work here so we don't use RetainPtr local variables.
145         (-[APITestDelegateIPhone dealloc]): Added.
146         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
147         created. Updated for changes to member names and types.
148         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
149         updated for changes to member names and types. Changed to two word spelling.
150         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
151         name of _cleanUp method.
152         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
153         Ditto.
154         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
155
156 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
157
158         Clean up Image Document and tweak the layout and viewport
159         https://bugs.webkit.org/show_bug.cgi?id=132552
160
161         Reviewed by Anders Carlsson.
162
163         * DumpRenderTree/mac/DumpRenderTree.mm:
164         (resetWebPreferencesToConsistentValues):
165         Update the default settings to have something consistent with WebKit2.
166
167 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
168
169         [GTK][CMake] Unable to do make install
170         https://bugs.webkit.org/show_bug.cgi?id=130188
171
172         Reviewed by Carlos Garcia Campos.
173
174         * Scripts/webkitdirs.pm:
175         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
176         will give an early signal that a change has broken the documentation.
177
178 2014-05-05  Pratik Solanki  <psolanki@apple.com>
179
180         Update framework locations in package-root
181         https://bugs.webkit.org/show_bug.cgi?id=132571
182
183         Reviewed by Simon Fraser.
184
185         * Scripts/package-root:
186
187 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
188
189         [EFL][WK2] Refactor favicon database APIs
190         https://bugs.webkit.org/show_bug.cgi?id=132519
191
192         Reviewed by Gyuyoung Kim.
193
194         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
195         (update_view_favicon):
196         (on_icon_changed_cb):
197         (window_free):
198         (on_url_changed):
199         (window_create):
200         (on_view_favicon_changed): Deleted.
201
202 2014-05-02  Mark Rowe  <mrowe@apple.com>
203
204         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
205
206         Reviewed by Dan Bernstein.
207
208         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
209         when determining which LLVM archive to extract.
210
211 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
212
213         Add Jeremy as a committer.
214         https://bugs.webkit.org/show_bug.cgi?id=132492
215
216         Reviewed by Jer Noble.
217
218         Add myself as a committer.
219
220         * Scripts/webkitpy/common/config/contributors.json:
221
222 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
223
224         Add Jeremy as a committer.
225         https://bugs.webkit.org/show_bug.cgi?id=132492
226
227         Reviewed by Jer Noble.
228
229         Add Jeremy Jones to the committers file.
230
231         * Scripts/webkitpy/common/config/contributors.json:
232
233 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
234
235         Hard to figure out how to run a single test with run-api-tests
236         https://bugs.webkit.org/show_bug.cgi?id=116332
237
238         Reviewed by Alexey Proskuryakov.
239
240         * Scripts/run-api-tests: add two examples to the help message.
241
242 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
243
244         Fix several memory leaks found by code inspection
245         https://bugs.webkit.org/show_bug.cgi?id=132472
246
247         Reviewed by Geoffrey Garen.
248         
249         Fix memory leaks.
250
251         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
252         (TestWebKitAPI::TEST):
253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
254         (WTR::InjectedBundlePage::willSendRequestForFrame):
255         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
256         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
257
258 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
259
260         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
261         https://bugs.webkit.org/show_bug.cgi?id=132446
262
263         Reviewed by Mark Hahnenberg.
264         
265         Test the FTL by default now that it's enabled by default.
266
267         * Scripts/run-javascriptcore-tests:
268
269 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
270
271         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
272         https://bugs.webkit.org/show_bug.cgi?id=132240
273
274         Reviewed by Anders Carlsson.
275
276         Removed ewk_view_setting_tiled_backingstore related code.
277
278         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
279         (DumpRenderTreeChrome::createView):
280         (shouldUseTiledBackingStore): Deleted.
281         * EWebLauncher/main.c:
282         (windowCreate):
283         (parseUserArguments):
284
285 2014-05-01  Anders Carlsson  <andersca@apple.com>
286
287         window.testRunner.keepWebHistory() should update the UI process state
288         https://bugs.webkit.org/show_bug.cgi?id=132440
289
290         Reviewed by Dan Bernstein.
291
292         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
293         (WTR::InjectedBundle::postSetAddsVisitedLinks):
294         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
296         (WTR::TestRunner::keepWebHistory):
297         * WebKitTestRunner/TestInvocation.cpp:
298         (WTR::TestInvocation::invoke):
299         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
300
301 2014-05-01  David Kilzer  <ddkilzer@apple.com>
302
303         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
304         <http://webkit.org/b/132432>
305
306         Reviewed by Tim Horton.
307
308         * Scripts/webkitperl/FeatureList.pm: Remove support for
309         --plugin-proxy-for-video switch.
310
311 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
312
313         Kernel sysctl interface hw.activecpu don't exists on Linux.
314         https://bugs.webkit.org/show_bug.cgi?id=132286
315
316         Reviewed by Filip Pizlo.
317
318         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
319         calling sysctl over hw.activecpu
320
321 2014-04-30  Anders Carlsson  <andersca@apple.com>
322
323         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
324         https://bugs.webkit.org/show_bug.cgi?id=132399
325         <rdar://problem/15920046>
326
327         Reviewed by Dan Bernstein.
328
329         * Scripts/check-for-webkit-framework-include-consistency:
330         Allos WAK headers in WebKitLegacy as well as WebKit.
331
332         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
333         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
334         Update header imports.
335
336 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
337
338         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
339         https://bugs.webkit.org/show_bug.cgi?id=131954
340
341         Reviewed by Darin Adler.
342         
343         WebKitTestRunner was adding application-specific information to crash reports
344         to log the test path, but only in the web process. Fix it to also do this
345         for the UI process, for both iOS and OS X.
346         
347         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
348         both iOS and OS X.
349         
350         Factored crash reprorter-related code into CrashReporterInfo, and call it from
351         a new TestController::platformWillRunTest() function on Mac and iOS.
352         
353         Also remove Xcode-added unit test junk from the project.
354
355         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
356         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
357         * WebKitTestRunner/TestController.cpp:
358         (WTR::TestController::runTest):
359         * WebKitTestRunner/TestController.h:
360         * WebKitTestRunner/TestInvocation.cpp:
361         (WTR::TestInvocation::url):
362         * WebKitTestRunner/TestInvocation.h:
363         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
364         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
365         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
366         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
367         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
368         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
369         (WTR::testPathFromURL):
370         (WTR::setCrashReportApplicationSpecificInformationToURL):
371         * WebKitTestRunner/efl/TestControllerEfl.cpp:
372         (WTR::TestController::platformWillRunTest):
373         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
374         (WTR::TestController::platformWillRunTest):
375         * WebKitTestRunner/ios/TestControllerIOS.mm:
376         (WTR::TestController::platformWillRunTest):
377         (WTR::TestController::setHidden):
378         * WebKitTestRunner/mac/TestControllerMac.mm:
379         (WTR::TestController::platformWillRunTest):
380
381 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
382
383         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
384
385         Reviewed by Tim Horton.
386
387         * DumpRenderTree/mac/DumpRenderTree.mm:
388         (resetWebPreferencesToConsistentValues):
389         (prepareConsistentTestingEnvironment):
390
391 2014-04-30  Anders Carlsson  <andersca@apple.com>
392
393         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
394         https://bugs.webkit.org/show_bug.cgi?id=132397
395
396         Reviewed by Dan Bernstein.
397
398         * Scripts/check-for-inappropriate-macros-in-external-headers:
399
400 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
401
402         [GTK] Make it easier to run CMake for downstreams
403         https://bugs.webkit.org/show_bug.cgi?id=132370
404
405         Reviewed by Carlos Garcia Campos.
406
407         * Scripts/webkitdirs.pm:
408         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
409         the GTK+ port.
410
411 2014-04-29  Stephanie Lewis  <slewis@apple.com>
412
413         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
414         
415         Rubber stamped by Jessie Berlin.
416
417         JSON.pm was removed from our tools setup.
418
419         * Scripts/generate-coverage-data:
420
421 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
422
423         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
424         https://bugs.webkit.org/show_bug.cgi?id=112840
425
426         Rubber stamped by Geoffrey Garen.
427
428         * Scripts/build-jsc: Enable it on Mac.
429         * Scripts/build-webkit: Enable it on Mac.
430         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
431
432 2014-04-28  Sam Weinig  <sam@webkit.org>
433
434         REGRESSION (r167751): svn-create-patch is very slow
435         https://bugs.webkit.org/show_bug.cgi?id=132300
436
437         Reviewed by Alexey Proskuryakov.
438
439         * Scripts/svn-create-patch:
440         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
441         by calling `svn-create-patch --style`.
442
443 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
444
445         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
446         https://bugs.webkit.org/show_bug.cgi?id=132190
447
448         Reviewed by Gustavo Noronha Silva.
449
450         * Scripts/webkitdirs.pm:
451         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
452             if ninja is in the path.
453         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
454             to the previous ninja generator if not.
455
456 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
457
458         check-webkit-style should understand --git-index
459         https://bugs.webkit.org/show_bug.cgi?id=125364
460
461         Reviewed by Csaba Osztrogonác.
462
463         * Scripts/webkitpy/common/checkout/scm/git.py:
464         (Git.create_patch): The command now supports the --cached option.
465         * Scripts/webkitpy/style/main.py:
466         (CheckWebKitStyle.main): Passing the --git-index option.
467         * Scripts/webkitpy/style/optparser.py:
468         (CommandOptionValues.__init__): The git-index option is switched off by default.
469         (CommandOptionValues.__eq__): Equality check for the new option.
470         (ArgumentParser._create_option_parser):Adding the --git-index option
471         (ArgumentParser.parse):
472         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
473         (CommandOptionValuesTest.test_init): 
474         (CommandOptionValuesTest.test_eq):
475
476 2014-04-28  Michael Saboff  <msaboff@apple.com>
477
478         Crash in platform/mac/accessibility/table-visible-rows.html
479         https://bugs.webkit.org/show_bug.cgi?id=132146
480
481         Reviewed by Filip Pizlo.
482
483         Instead of creating a local JSValueRef array on the stack and passing that to
484         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
485         values using the JSObjectSetPropertyAtIndex() API.
486
487         * DumpRenderTree/AccessibilityUIElement.cpp:
488         (elementsForRangeCallback):
489         (convertElementsToObjectArray):
490         * DumpRenderTree/mac/TestRunnerMac.mm:
491         (originsArrayToJS):
492         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
493         (WTR::EventSendingController::contextClick):
494         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
495         (WTR::stringArrayToJS):
496         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
497         (WTR::convertElementsToObjectArray):
498
499 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
500
501         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
502         "no-cjit" runs force the old-school threshold.
503
504         Rubber stamped by Mark Hahnenberg.
505
506         * Scripts/run-jsc-stress-tests:
507
508 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
509
510         [GTK] install-dependencies should also install ruby-json and ruby-highline
511         https://bugs.webkit.org/show_bug.cgi?id=132292
512
513         Reviewed by Philippe Normand.
514
515         * gtk/install-dependencies: Install ruby json and highline packages.
516
517 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
518
519         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
520         https://bugs.webkit.org/show_bug.cgi?id=132176
521
522         Reviewed by Gyuyoung Kim.
523
524         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
525         and turn off indexedDB feature until the sqlite implementation is introduced.
526
527         * Scripts/webkitperl/FeatureList.pm:
528
529 2014-04-25  James Craig  <jcraig@apple.com>
530
531         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
532         https://bugs.webkit.org/show_bug.cgi?id=132209
533
534         Reviewed by Daniel Bates.
535
536         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
537         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
538
539         * Scripts/prepare-ChangeLog:
540         (main): 
541
542 2014-04-25  Michael Saboff  <msaboff@apple.com>
543
544         Crash in platform/mac/accessibility/table-visible-rows.html
545         https://bugs.webkit.org/show_bug.cgi?id=132146
546
547         Reviewed by Mark Lam.
548
549         Changed to use a local JSValueRef array temporary instead of a
550         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
551         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
552         the temporary values could be collected.
553
554         * DumpRenderTree/AccessibilityUIElement.cpp:
555         (convertElementsToObjectArray):
556         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
557         (WTR::EventSendingController::contextClick):
558         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
559         (WTR::convertElementsToObjectArray):
560
561 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
562
563         Unreviewed GTK gardening
564
565         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
566         (TestRunner):
567
568 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
569
570         prepare-ChangeLog reports as deleted methods that has not been removed.
571         https://bugs.webkit.org/show_bug.cgi?id=131733
572
573         Reviewed by Ryosuke Niwa.
574
575         * Scripts/prepare-ChangeLog:
576         (originalFile): Set merge base to origin/master by default.
577
578 2014-04-23  James Craig  <jcraig@apple.com>
579
580         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
581         https://bugs.webkit.org/show_bug.cgi?id=131115
582
583         Reviewed by Daniel Bates.
584
585         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
586
587         * Scripts/commit-log-editor: Added --no-style.
588         * Scripts/prepare-ChangeLog: Primary patch.
589         (main): Primary patch.
590         (createPatchCommand): Added --no-style.
591         * Scripts/svn-create-patch: Primary patch.
592         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
593         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
594         (SVN.create_patch): Added --no-style.
595
596 2014-04-23  Anders Carlsson  <andersca@apple.com>
597
598         Try to fix iOS build.
599
600         * DumpRenderTree/mac/DumpRenderTree.mm:
601
602 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
603
604         Eliminate internals.setMockScrollbarsEnabled()
605         https://bugs.webkit.org/show_bug.cgi?id=132085
606
607         Reviewed by Tim Horton.
608
609         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
610         No need to reset the preference, there is no way it can change.
611
612 2014-04-23  James Craig  <jcraig@apple.com>
613
614         Unreviewed. Moving myself from Contributors to Committers list.
615
616         * Scripts/webkitpy/common/config/contributors.json:
617
618 2014-04-23  Tim Horton  <timothy_horton@apple.com>
619
620         Mock scrollbars don't always work in DumpRenderTree
621         https://bugs.webkit.org/show_bug.cgi?id=132082
622
623         Reviewed by Alexey Proskuryakov.
624
625         * DumpRenderTree/mac/DumpRenderTree.mm:
626         (prepareConsistentTestingEnvironment):
627         Set the mock scrollbar setting before creating the WebView, as this setting
628         cannot be dynamically changed, so any scrollbars that are created during
629         WebView initialization and are not replaced before snapshotting will end
630         up being platform scrollbars instead of mock ones.
631         WebKitTestRunner already sets this preference before creating WKViews,
632         so we're just matching its behavior.
633
634 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
635
636         [GTK] ShadowRoot API was removed in r164131
637         https://bugs.webkit.org/show_bug.cgi?id=132059
638
639         Reviewed by Gustavo Noronha Silva.
640
641         Add WebKitDOMShadowRoot to the list of deleted classes to generate
642         the API docs.
643
644         * gtk/webkitdom.py:
645         (WebKitDOMDocGenerator):
646
647 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
648
649         [GTK] run-webkit-tests script is failing to invoke run-launcher
650         https://bugs.webkit.org/show_bug.cgi?id=132051
651
652         Reviewed by Philippe Normand.
653
654         After the WK1 support was dropped, if run-webkit-tests is executed
655         without --no-show-results parameter, the launcher is being called
656         using a -2 parameter that is it causing the run-launcher to break.
657
658         * Scripts/webkitpy/port/gtk.py:
659         (GtkPort.show_results_html_file):
660
661 2014-04-22  Tim Horton  <timothy_horton@apple.com>
662
663         DumpRenderTree generates black snapshots on some platforms
664         https://bugs.webkit.org/show_bug.cgi?id=132029
665         <rdar://problem/16679363>
666
667         Reviewed by Simon Fraser.
668
669         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
670         (createBitmapContextFromWebView):
671         DRT checks with the WebView to determine whether it can use the window's
672         backing store directly or (because of compositing) needs to take a WindowServer
673         snapshot. However, on some platforms and in some situations, the window can
674         be layer backed without the WebView necessarily currently being composited.
675         We should check with the window in addition to the WebView before going
676         ahead and using its backing store.
677
678 2014-04-22  Tim Horton  <timothy_horton@apple.com>
679
680         DumpRenderTree generates white snapshots on some platforms
681         https://bugs.webkit.org/show_bug.cgi?id=132026
682         <rdar://problem/16679363>
683
684         Reviewed by Simon Fraser.
685
686         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
687         Link DRT against QuartzCore.
688
689         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
690         (createBitmapContextFromWebView):
691         Force CoreAnimation to synchronously update layers in a more explicit
692         way that doesn't depend on AppKit behavior. This is very similar to what
693         WebKitTestRunner does (indirectly) during its force repaint.
694
695 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
696
697         [Win] Support Python 2.7 in Cygwin
698         https://bugs.webkit.org/show_bug.cgi?id=132023
699
700         Reviewed by Michael Saboff.
701
702         * Scripts/webkitdirs.pm:
703         (checkInstalledTools): Remove check for Python 2.7, since
704         it now works properly.
705
706 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
707
708         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
709         https://bugs.webkit.org/show_bug.cgi?id=130867
710         <rdar://problem/16432456> 
711
712         Reviewed by Mark Hahnenberg.
713
714         * Scripts/build-webkit:
715         * Scripts/copy-webkitlibraries-to-product-directory:
716
717 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
718
719         [GTK] Fails to build documentation when output is redirected
720         https://bugs.webkit.org/show_bug.cgi?id=131178
721
722         Reviewed by Martin Robinson.
723
724         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
725         explicitly to avoid encoding issues when they are redirected.
726
727 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
728
729         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
730         https://bugs.webkit.org/show_bug.cgi?id=131911
731
732         Reviewed by Martin Robinson.
733
734         common.get_build_path returns release path even though Debug configuration
735         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
736
737         * gtk/ycm_extra_conf.py:
738         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
739         (FlagsForFile):
740
741 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
742
743         Unreviewed build fix.
744
745         * DumpRenderTree/mac/EventSendingController.mm:
746         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
747         Correct a typo that prevented tests from working properly.
748
749 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
750
751         [GTK] Should have the ability to output composited contents during layout testing
752         https://bugs.webkit.org/show_bug.cgi?id=131864
753
754         Reviewed by Philippe Normand.
755
756         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
757         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
758         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
759         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
760         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
761
762 2014-04-21  Sam Weinig  <sam@webkit.org>
763
764         Attempt to fix the tests.
765
766         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
767         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
768         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
769
770 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
771
772         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
773         being the same as a "quick run", which is meant for genuinely slow tests).
774
775         * Scripts/run-jsc-stress-tests:
776
777 2014-04-21  Darin Adler  <darin@apple.com>
778
779         Add HashSet::takeAny
780         https://bugs.webkit.org/show_bug.cgi?id=131928
781
782         Reviewed by Benjamin Poulain.
783
784         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
785
786 2014-04-20  Dan Bernstein  <mitz@apple.com>
787
788         Fixed a test timing out after r167572.
789
790         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
791         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
792         -webView:didFinishLoadingNavigation:.
793
794 2014-04-20  Commit Queue  <commit-queue@webkit.org>
795
796         Unreviewed, rolling out r167510.
797         https://bugs.webkit.org/show_bug.cgi?id=131915
798
799         broke GTK Debug bot (Requested by philn on #webkit).
800
801         Reverted changeset:
802
803         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
804         it when running layout tests"
805         https://bugs.webkit.org/show_bug.cgi?id=131472
806         http://trac.webkit.org/changeset/167510
807
808 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
809
810         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
811         https://bugs.webkit.org/show_bug.cgi?id=131472
812
813         Reviewed by Philippe Normand.
814
815         * Scripts/webkitpy/port/gtk.py:
816         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
817         when running WebKitTestRunner with run-webkit-tests.
818         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
819         installed.
820         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
821         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
822         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
823         deal.
824
825 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
826
827         DownloadDecideDestinationCrash API test uses an incorrect value for path
828         https://bugs.webkit.org/show_bug.cgi?id=131845
829         <rdar://problem/15925560>
830
831         Reviewed by Enrica Casucci.
832
833         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
834         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
835
836 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
837
838         [Mac] AttributedStringTest API tests fail with async text input
839         https://bugs.webkit.org/show_bug.cgi?id=131833
840
841         Reviewed by Enrica Casucci.
842
843         Don't run sync NSTextInputClient tests where we don't implement these calls.
844
845         * TestWebKitAPI/Tests/mac/AttributedString.mm:
846         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
847         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
848         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
849         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
850         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
851         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
852
853 2014-04-18  Philippe Normand  <pnormand@igalia.com>
854
855         Remove NETWORK_INFO support
856         https://bugs.webkit.org/show_bug.cgi?id=131841
857
858         Reviewed by Gyuyoung Kim.
859
860         * Scripts/webkitperl/FeatureList.pm:
861
862 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
863
864         [GTK] YouCompleteMe doesn't work for cmake build system.
865         https://bugs.webkit.org/show_bug.cgi?id=131591
866
867         Reviewed by Martin Robinson.
868
869         Add cmake build system support for YouCompleteMe. It should work regardless of
870         using make or ninja. In addition, autotools related code is removed since it's
871         not used anymore in WebKit.
872
873         * Scripts/webkitdirs.pm:
874         (generateBuildSystemFromCMakeProject):
875         * gtk/ycm_extra_conf.py:
876         (transform_relative_paths_to_absolute_paths):
877         (FlagsForFile):
878
879 2014-04-17  Anders Carlsson  <andersca@apple.com>
880
881         Fix build.
882
883         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
884         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
885         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
886
887 2014-04-17  Anders Carlsson  <andersca@apple.com>
888
889         Remove unused API enums
890         https://bugs.webkit.org/show_bug.cgi?id=131836
891
892         Reviewed by Tim Horton.
893
894         * MiniBrowser/mac/WK2BrowserWindowController.m:
895         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
896
897 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
898
899         [Win] A few final cleanups to the DataObject classes.
900         https://bugs.webkit.org/show_bug.cgi?id=131784
901
902         Reviewed by Anders Carlsson.
903
904         * DumpRenderTree/win/DRTDataObject.cpp:
905         (DRTDataObject::clearData): Use 'last()' method.
906         * DumpRenderTree/win/UIDelegate.cpp:
907         (DRTUndoStack::pop): Use 'takeLast()' method.
908
909 2014-04-17  Andres Gomez  <agomez@igalia.com>
910
911         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
912         https://bugs.webkit.org/show_bug.cgi?id=131365
913
914         Reviewed by Brent Fulgham.
915
916         The cygwin installer is now downloading the wanted versions for
917         the local installation given to the setup wizard.
918
919         * CygwinDownloader/cygwin-downloader.py:
920         * CygwinDownloader/cygwin-downloader.zip:
921
922 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
923
924         [GTK] Make run-webkit-tests always use WKTR
925         https://bugs.webkit.org/show_bug.cgi?id=131737
926
927         Reviewed by Darin Adler.
928
929         Now that the GTK+ port only has support for WebKit2, instruct
930         run-webkit-tests to always use WKTR. This avoids needing to pass
931         flag "-2" every time.
932
933         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
934         (_set_up_derived_options): Always set webkit_test_runner when
935         the platform is GTK+.
936
937 2014-04-17  Brendan Long  <b.long@cablelabs.com>
938
939         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
940         https://bugs.webkit.org/show_bug.cgi?id=131760
941
942         Reviewed by Philippe Normand.
943
944         * gtk/install-dependencies: Install ninja-build when it's available.
945
946 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
947
948         [Win] run-javascriptcore-tests fails to run.
949         https://bugs.webkit.org/show_bug.cgi?id=131761
950
951         Reviewed by Brent Fulgham.
952
953         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
954
955 2014-04-16  Andres Gomez  <agomez@igalia.com>
956
957         [Win] Pass default parameters to cygwin setup wizard
958         https://bugs.webkit.org/show_bug.cgi?id=131361
959
960         Reviewed by Brent Fulgham.
961
962         Added some parameters to the cygwin setup wizard so the user
963         doesn't really have to do any interaction.
964
965         * CygwinDownloader/cygwin-downloader.py:
966         * CygwinDownloader/cygwin-downloader.zip:
967
968 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
969
970         [Win] Eliminate use of deleteAllValues in Windows Files
971         https://bugs.webkit.org/show_bug.cgi?id=131631
972
973         Reviewed by Darin Adler.
974
975         Switch to std::unique_ptr for memory lifetime. Get rid of
976         deleteAllValues now that it is no longer needed. Use ranged
977         for loops where possible.
978
979         * DumpRenderTree/win/DRTDataObject.cpp:
980         (WCEnumFormatEtc::WCEnumFormatEtc):
981         (DRTDataObject::~DRTDataObject):
982         (DRTDataObject::GetData):
983         (DRTDataObject::QueryGetData):
984         (DRTDataObject::SetData):
985         (DRTDataObject::clearData):
986         * DumpRenderTree/win/DRTDataObject.h:
987         * DumpRenderTree/win/UIDelegate.cpp:
988         (DRTUndoObject::DRTUndoObject):
989         (DRTUndoObject::~DRTUndoObject):
990         (DRTUndoStack::~DRTUndoStack):
991         (DRTUndoStack::clear):
992         (DRTUndoStack::pop):
993         (DRTUndoManager::DRTUndoManager):
994         (DRTUndoManager::redo):
995         (DRTUndoManager::undo):
996         (UIDelegate::UIDelegate):
997         (UIDelegate::resetUndoManager):
998         * DumpRenderTree/win/UIDelegate.h:
999
1000 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1001
1002         [GTK] Unreviewed GTK gardening.
1003
1004         Update list of skipped unit tests:
1005
1006           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1007
1008           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1009           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1010
1011         * Scripts/run-gtk-tests:
1012         (TestRunner):
1013
1014 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1015
1016         check-webkit-style doesn't check code style in .mm or .m files
1017         https://bugs.webkit.org/show_bug.cgi?id=131708
1018
1019         Reviewed by Darin Adler.
1020
1021         * Scripts/webkitpy/style/checker.py:
1022         * Scripts/webkitpy/style/checker_unittest.py:
1023         (CheckerDispatcherDispatchTest.test_cpp_paths):
1024         (CheckerDispatcherDispatchTest.test_text_paths):
1025         Check .mm and .m files as C++.
1026
1027         * Scripts/webkitpy/style/checkers/cpp.py:
1028         (check_spacing):
1029         Add an override for our ordinary "missing spaces around =" for @synthesize,
1030         which should look like "@synthesize propertyName=_varName;"
1031
1032         Add an override for "missing space before {" for blocks' "^{".
1033
1034         Don't follow the "extra space before [" rule for Objective-C, because
1035         it breaks this rule in a multitude of ways because of method calls.
1036
1037         (check_braces):
1038         Don't complain about { not being on the end of the previous line if
1039         the previous line starts with "- (" or "+ (", which would indicate a
1040         Objective-C method definition.
1041
1042 2014-04-16  Darin Adler  <darin@apple.com>
1043
1044         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1045         https://bugs.webkit.org/show_bug.cgi?id=131735
1046
1047         Reviewed by Alexey Proskuryakov.
1048
1049         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1050         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1051         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1052         way, but gtest works better this way.
1053
1054 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1055
1056         [EFL] Fix problems with the pixel dump.
1057         https://bugs.webkit.org/show_bug.cgi?id=131265
1058
1059         Reviewed by Gyuyoung Kim.
1060
1061         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1062         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1063         which causes that nothing is drawn.
1064
1065         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1066         One of new functions is AcceleratedCompositingContext::extractImageData(),
1067         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1068         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1069
1070         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1071         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1072
1073 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1074
1075         Update LLVM export scrpt to handle the build directory being different from the
1076         source directory.
1077
1078         Rubber stamped by Geoffrey Garen.
1079
1080         * Scripts/export-llvm-build:
1081
1082 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1083
1084         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1085         https://bugs.webkit.org/show_bug.cgi?id=131695
1086
1087         Reviewed by Antti Koivisto.
1088
1089         Updated.
1090
1091         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1092
1093 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1094
1095         [GTK] Reduce the binary size by compressing the text based web inspector resources
1096         https://bugs.webkit.org/show_bug.cgi?id=121545
1097
1098         Reviewed by Gustavo Noronha Silva.
1099
1100         Compress text based files when compiling inspector resources. It
1101         reduces the binary size in 3MB.
1102
1103         * gtk/generate-inspector-gresource-manifest.py:
1104         (find_all_files_in_directory):
1105         (is_compressible):
1106
1107 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1108
1109         Remove Gtk WebKit1 tester.
1110
1111         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1112         results over and over as fast as it could.
1113
1114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1115         (WebKitBuildbot):
1116
1117 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1118
1119         Wrong link for webkitpy tests results in dashboard popover
1120         https://bugs.webkit.org/show_bug.cgi?id=131664
1121
1122         Reviewed by Timothy Hatcher.
1123
1124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1125         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1126         Use a correct link.
1127
1128 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1129
1130         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1131
1132         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1133
1134         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1135         (CommitMessageForThisCommitTest):
1136
1137 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1138
1139         Fix commit-log-editor bug revealed by r165447
1140         https://bugs.webkit.org/show_bug.cgi?id=130676
1141
1142         Reviewed by Csaba Osztrogonác.
1143
1144         * Scripts/commit-log-editor:
1145         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1146         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1147         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1148         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1149
1150 2014-04-13  Darin Adler  <darin@apple.com>
1151
1152         userVisibleString should not try to "encode" host names
1153         https://bugs.webkit.org/show_bug.cgi?id=131587
1154         rdar://problem/14686849
1155
1156         Reviewed by Alexey Proskuryakov.
1157
1158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1159
1160         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1161         Coverage is tiny at this point; we could add a lot more cases!
1162
1163 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1164
1165         Use #include instead of #import
1166         https://bugs.webkit.org/show_bug.cgi?id=131604
1167
1168         Reviewed by Darin Adler.
1169
1170         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1171
1172         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1173
1174 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1175
1176         Make slow-stress tests run faster by running fewer VM variants.
1177
1178         Rubber stamped by Geoffrey Garen.
1179
1180         * Scripts/run-javascriptcore-tests:
1181         * Scripts/run-jsc-stress-tests:
1182
1183 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1184
1185         [CMake] Add missing WTF unit tests
1186         https://bugs.webkit.org/show_bug.cgi?id=131459
1187
1188         Reviewed by Martin Robinson.
1189
1190         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1191         that should be compiled into the TestWTF binary.
1192
1193 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1194
1195         [Gtk] run-launcher doesn't work by default
1196         https://bugs.webkit.org/show_bug.cgi?id=131494
1197
1198         Reviewed by Philippe Normand.
1199
1200         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1201         * Scripts/webkitdirs.pm:
1202         (launcherName): Same.
1203         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1204         * gtk/common.py:
1205         (get_build_path.is_valid_build_directory): Same.
1206         * gtk/manifest.txt: Same.
1207
1208 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1209
1210         Unreviewed, rolling out r167046.
1211         https://bugs.webkit.org/show_bug.cgi?id=131479
1212
1213         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1214         on #webkit).
1215
1216         Reverted changeset:
1217
1218         "Remove "System Font" from whitelisted DRT fonts and char
1219         width calculations"
1220         https://bugs.webkit.org/show_bug.cgi?id=131411
1221         http://trac.webkit.org/changeset/167046
1222
1223 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1224
1225         Remove "System Font" from whitelisted DRT fonts and char width calculations
1226         https://bugs.webkit.org/show_bug.cgi?id=131411
1227
1228         Reviewed by Tim Horton.
1229
1230         Covered by existing tests.
1231
1232         * DumpRenderTree/mac/DumpRenderTree.mm:
1233         (allowedFontFamilySet):
1234
1235 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1236
1237         systemHiddenFontFamilySet in DRT is unnecessary
1238         https://bugs.webkit.org/show_bug.cgi?id=131414
1239
1240         Reviewed by Tim Horton.
1241
1242         It doesn't seem to affect test results on my machine.
1243
1244         * DumpRenderTree/mac/DumpRenderTree.mm:
1245         (drt_NSFontManager_availableFonts):
1246         (systemHiddenFontFamilySet): Deleted.
1247
1248 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1249
1250         [Win] Unreviewed test fix: Don't double-release BSTR.
1251
1252         * DumpRenderTree/win/DumpRenderTree.cpp:
1253         (dump): Remove unneeded call to SysFreeString now that we are
1254         using _bstr_t for this variable.
1255
1256 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1257
1258         [Win] Various DumpRenderTree Fixes.
1259         https://bugs.webkit.org/show_bug.cgi?id=131446.
1260
1261         Reviewed by Tim Horton.
1262
1263         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1264         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1265         (AccessibilityUIElement::description): Ditto.
1266         (AccessibilityUIElement::helpText): Ditto.
1267         (AccessibilityUIElement::intValue): Ditto.
1268         (AccessibilityUIElement::isPressActionSupported): Ditto.
1269         (AccessibilityUIElement::accessibilityValue): Ditto.
1270         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1271         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1272         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1273         (DRTDesktopNotificationPresenter::Release): Ditto.
1274         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1275         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1276         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1277         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1278         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1279         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1280         * DumpRenderTree/win/DumpRenderTree.cpp:
1281         (dumpFrameScrollPosition): Ditto.
1282         (dumpFramesAsText): Ditto.
1283         (compareHistoryItems): Ditto.
1284         (dumpHistoryItem): Ditto.
1285         (dump): Ditto.
1286         (resetDefaultsToConsistentValues): Ditto.
1287         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1288         (runTest): Ditto.
1289         (createWebViewAndOffscreenWindow): Ditto.
1290         * DumpRenderTree/win/EditingDelegate.cpp:
1291         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1292         (EditingDelegate::AddRef): Ditto.
1293         (EditingDelegate::Release): Ditto.
1294         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1295         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1296         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1297         (EditingDelegate::shouldInsertNode): Ditto.
1298         (EditingDelegate::shouldInsertText): Ditto.
1299         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1300         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1301         (EditingDelegate::shouldApplyStyle): Ditto.
1302         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1303         (EditingDelegate::doPlatformCommand): Ditto.
1304         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1305         (EditingDelegate::webViewDidChange): Ditto.
1306         (EditingDelegate::webViewDidEndEditing): Ditto.
1307         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1308         (EditingDelegate::webViewDidChangeSelection): Ditto.
1309         (EditingDelegate::checkSpellingOfString): Ditto.
1310         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1311         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1312         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1313         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1314         (FrameLoadDelegate::AddRef): Ditto.
1315         (FrameLoadDelegate::Release): Ditto.
1316         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1317         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1318         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1319         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1320         (FrameLoadDelegate::didReceiveTitle): Ditto.
1321         (FrameLoadDelegate::didChangeIcons): Ditto.
1322         (delegatesWithDelayedWork): Ditto.
1323         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1324         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1325         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1326         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1327         (FrameLoadDelegate::willCloseFrame): Ditto.
1328         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1329         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1330         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1331         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1332         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1333         * DumpRenderTree/win/FrameLoadDelegate.h:
1334         * DumpRenderTree/win/HistoryDelegate.cpp:
1335         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1336         (HistoryDelegate::updateHistoryTitle): Ditto.
1337         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1338         * DumpRenderTree/win/PolicyDelegate.cpp:
1339         (dumpPath):
1340         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1341         (PolicyDelegate::AddRef): Ditto.
1342         (PolicyDelegate::Release): Ditto.
1343         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1344         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1345         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1346         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1347         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1348         (ResourceLoadDelegate::AddRef): Ditto.
1349         (ResourceLoadDelegate::Release): Ditto.
1350         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1351         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1352         (ResourceLoadDelegate::willSendRequest): Ditto.
1353         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1354         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1355         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1356         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1357         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1358         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1359         (TestRunner::setUserStyleSheetLocation): Ditto.
1360         (TestRunner::execCommand): Ditto.
1361         (TestRunner::overridePreference): Ditto.
1362         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1363         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1364         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1365         (TextInputController::insertText): Ditto.
1366         * DumpRenderTree/win/UIDelegate.cpp:
1367         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1368         (UIDelegate::AddRef): Ditto.
1369         (UIDelegate::Release): Ditto.
1370         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1371         (UIDelegate::trackCustomPopupMenu): Ditto.
1372         (UIDelegate::registerUndoWithTarget): Ditto.
1373         (UIDelegate::removeAllActionsWithTarget): Ditto.
1374         (UIDelegate::setActionTitle): Ditto.
1375         (UIDelegate::undo): Ditto.
1376         (UIDelegate::redo): Ditto.
1377         (UIDelegate::canUndo): Ditto.
1378         (UIDelegate::canRedo): Ditto.
1379         (UIDelegate::printFrame): Ditto.
1380         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1381         (UIDelegate::webViewHeaderHeight): Ditto.
1382         (UIDelegate::webViewFooterHeight): Ditto.
1383         (UIDelegate::drawHeaderInRect): Ditto.
1384         (UIDelegate::drawFooterInRect): Ditto.
1385         (UIDelegate::webViewPrintingMarginRect): Ditto.
1386         (UIDelegate::canRunModal): Ditto.
1387         (UIDelegate::createModalDialog): Ditto.
1388         (UIDelegate::runModal): Ditto.
1389         (UIDelegate::isMenuBarVisible): Ditto.
1390         (UIDelegate::setMenuBarVisible): Ditto.
1391         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1392         (UIDelegate::paintCustomScrollbar): Ditto.
1393         (UIDelegate::paintCustomScrollCorner): Ditto.
1394         (UIDelegate::setFrame): Ditto.
1395         (UIDelegate::webViewFrame): Ditto.
1396         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1397         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1398         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1399         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1400         (UIDelegate::webViewAddMessageToConsole): Ditto.
1401         (UIDelegate::doDragDrop): Ditto.
1402         (UIDelegate::webViewGetDlgCode): Ditto.
1403         (UIDelegate::createWebViewWithRequest): Ditto.
1404         (UIDelegate::webViewClose): Ditto.
1405         (UIDelegate::webViewFocus): Ditto.
1406         (UIDelegate::webViewUnfocus): Ditto.
1407         (UIDelegate::webViewPainted): Ditto.
1408         (UIDelegate::exceededDatabaseQuota): Ditto.
1409         (UIDelegate::embeddedViewWithArguments): Ditto.
1410         (UIDelegate::webViewClosing): Ditto.
1411         (UIDelegate::webViewSetCursor): Ditto.
1412         (UIDelegate::webViewDidInvalidate): Ditto.
1413         (UIDelegate::setStatusText): Ditto.
1414         (UIDelegate::desktopNotificationsDelegate): Ditto.
1415         (UIDelegate::drawBackground): Ditto.
1416         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1417         (UIDelegate::didPressMissingPluginButton): Ditto.
1418         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1419         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1420         (LoadHTMLStringItem::invoke): Ditto.
1421         (ScriptItem::invoke): Ditto.
1422
1423 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1424
1425         Stylechecker: False positive on inline asm code.
1426         https://bugs.webkit.org/show_bug.cgi?id=130570
1427
1428         Reviewed by Csaba Osztrogonác.
1429
1430         Disable stylechecking in asm blocks.
1431
1432         * Scripts/webkitpy/style/checkers/cpp.py:
1433         (process_line):
1434         (_InlineASMState):
1435         (_InlineASMState.__init__):
1436         (_InlineASMState.process_line):
1437         (_InlineASMState.isInside):
1438         (_process_lines):
1439         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1440         (WebKitStyleTest.test_member_initialization_list):
1441
1442 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1443
1444         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1445         https://bugs.webkit.org/show_bug.cgi?id=131029
1446
1447         Reviewed by Philippe Normand.
1448
1449         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1450         tests and remove the getWebKit1TestResoucesDir() method.
1451
1452         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1453         (testDownloadLocalFile): Use Test::getResourcesDir().
1454         (testDownloadLocalFileError): Ditto.
1455         (serverCallback): Ditto.
1456         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1457         (serverCallback): Ditto.
1458         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1459         (httpServerCallback): Ditto.
1460         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1461         (serverCallback): Ditto.
1462         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1463         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1464         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1465         (Test::getWebKit1TestResoucesDir): Deleted.
1466
1467 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1468
1469         [WK2] HTTP authentication regression tests fail
1470         https://bugs.webkit.org/show_bug.cgi?id=81627
1471         <rdar://problem/11079296>
1472
1473         Reviewed by Anders Carlsson.
1474
1475         * WebKitTestRunner/TestController.h:
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1478         to pageLoaderClient structure.
1479         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1480         for password based authentication (we do get server trust challenges on some tests,
1481         which WKTR can't handle).
1482         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1483         calls won't be made, at least on CFNetwork based platforms.
1484         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1485         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1486         make sense to associate auth requests with individual resources - there can be
1487         multiple resources loading at once from the same protection space, so WebKit1 API
1488         that had a resource identifier was inherently racy.
1489
1490 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1491
1492         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1493         https://bugs.webkit.org/show_bug.cgi?id=131427
1494
1495         Reviewed by Gyuyoung Kim.
1496
1497         Since r166973, font path was changed.
1498
1499         * DumpRenderTree/PlatformEfl.cmake:
1500         * WebKitTestRunner/PlatformEfl.cmake:
1501
1502 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1503
1504         Fix the build-jsc build
1505         https://bugs.webkit.org/show_bug.cgi?id=131410
1506
1507         Reviewed by Michael Saboff.
1508
1509         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1510         WTF depends on it.
1511
1512 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1513
1514         [GTK] Remove WebKit1 unit tests
1515         https://bugs.webkit.org/show_bug.cgi?id=131359
1516
1517         Reviewed by Anders Carlsson.
1518
1519         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1520         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1521         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1522
1523         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1524         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1525         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1526         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1527         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1528         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1529         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1530         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1531         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1532         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1533         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1534         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1535         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1536         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1537         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1538         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1539         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1540         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1541         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1542         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1543         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1544         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1545         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1546         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1547         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1548         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1549         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1550         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1551         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1552         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1553         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1554         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1555         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1556         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1557         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1558         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1559         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1560         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1561
1562 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1563
1564         Unreviewed gardening (Take 2): Prevent users from attempting
1565         to build with known invalid cURL. 
1566
1567         * Scripts/webkitdirs.pm:
1568         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1569         7.33.0 (the known good version).
1570
1571 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1572
1573         [GTK] Remove DumpRenderTree and GtkLauncher
1574         https://bugs.webkit.org/show_bug.cgi?id=131373
1575
1576         Reviewed by Andreas Kling.
1577
1578         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1579         no longer necessary now that WebKit1 GTK+ will be removed.
1580
1581         * CMakeLists.txt:
1582         * DumpRenderTree/PlatformGTK.cmake: Removed.
1583         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1584         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1585         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1586         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1587         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1588         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1589         * DumpRenderTree/gtk/EventSender.h: Removed.
1590         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1591         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1592         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1593         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1594         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1595         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1596         * DumpRenderTree/gtk/TextInputController.h: Removed.
1597         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1598         * GtkLauncher/CMakeLists.txt: Removed.
1599         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1600         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1601         * GtkLauncher/main.c: Removed.
1602         * GtkLauncher/simple.svg: Removed.
1603         * GtkLauncher/text.html: Removed.
1604         * WebKitTestRunner/PlatformGTK.cmake:
1605         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1606         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1607         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1608
1609 2014-04-08  Mark Rowe  <mrowe@apple.com>
1610
1611         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1612         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1613
1614         Reviewed by Alexey Proskuryakov.
1615
1616         * Scripts/webkitdirs.pm:
1617         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1618         (execMacWebKitAppForDebugging): Ditto.
1619
1620 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1621
1622         Build bmalloc on iOS too
1623         https://bugs.webkit.org/show_bug.cgi?id=131381
1624
1625         Reviewed by Andreas Kling.
1626
1627         * Scripts/build-webkit:
1628
1629 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1630
1631         Unreviewed gardening: Prevent users from attempting
1632         to build with known invalid cURL.
1633
1634         * Scripts/webkitdirs.pm:
1635         (checkInstalledTools): Block build attempts with bad
1636         Cygwin tool set.
1637
1638 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1639
1640         Build bmalloc on Mac
1641         https://bugs.webkit.org/show_bug.cgi?id=131333
1642
1643         Reviewed by Mark Rowe.
1644
1645         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1646         (Note: Just testing Mac is not good enough because in this
1647         script 'Mac' means 'Mac or iOS'.)
1648
1649 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1650
1651         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1652         https://bugs.webkit.org/show_bug.cgi?id=130951
1653
1654         Reviewed by Geoffrey Garen.
1655
1656         * Scripts/run-javascriptcore-tests:
1657
1658 2014-04-06  Darin Adler  <darin@apple.com>
1659
1660         Rework CSS calc logic, fixing some reference count mistakes in Length
1661         https://bugs.webkit.org/show_bug.cgi?id=131280
1662
1663         Reviewed by Andreas Kling.
1664
1665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1666         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1667
1668 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1669
1670         Enable WEB_REPLAY for PLATFORM(MAC)
1671         https://bugs.webkit.org/show_bug.cgi?id=130700
1672
1673         Reviewed by Timothy Hatcher.
1674
1675         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1676
1677 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1678
1679         [CMake] Include X11's include dirs in TestNetscapePlugin
1680         https://bugs.webkit.org/show_bug.cgi?id=131270
1681
1682         Reviewed by Martin Robinson.
1683
1684         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1685         TestNetscapePlugin includes WebCore code that includes X headers.
1686
1687 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1688
1689         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1690         <http://webkit.org/b/130986>
1691
1692         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1693         prefix to TileCache class names in exception list.
1694
1695 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1696
1697         [GTK] kill-old-processes should kill dbus-daemon processes
1698         https://bugs.webkit.org/show_bug.cgi?id=127352
1699
1700         Reviewed by Martin Robinson.
1701
1702         * BuildSlaveSupport/kill-old-processes:
1703         (main):
1704
1705 2014-04-04  Andres Gomez  <agomez@igalia.com>
1706
1707         [Win] Update obsolete packages in cygwin
1708         https://bugs.webkit.org/show_bug.cgi?id=126264
1709
1710         Reviewed by Brent Fulgham.
1711
1712         Removed "apache" and "minires" as the first has been replaced by
1713         "lighttpd" and the second is now integrated into
1714         "cygwin". Replaced the transitional and now obsolete "gcc" package
1715         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1716         since the newer version available is "2.7.3" which breaks the
1717         build due to some funniness with environment variable handling.
1718
1719         * CygwinDownloader/cygwin-downloader.py:
1720         * CygwinDownloader/cygwin-downloader.zip:
1721
1722 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1723
1724         check-webkit-style: Improve warnings on Objective-C @property syntax
1725         https://bugs.webkit.org/show_bug.cgi?id=131200
1726
1727         Reviewed by Dan Bernstein.
1728
1729         * Scripts/webkitpy/style/checkers/cpp.py:
1730         (check_spacing):
1731         (CppChecker):
1732         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1733         (CppStyleTest.test_spacing_in_objective_c_properties):
1734
1735 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1736
1737         Unreviewed. Moving my name to commiter section
1738
1739         * Scripts/webkitpy/common/config/contributors.json:
1740
1741 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1742
1743         Unreviewed. Add myself as a committer.
1744
1745         * Scripts/webkitpy/common/config/contributors.json:
1746
1747 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1748
1749         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1750         https://bugs.webkit.org/show_bug.cgi?id=130391
1751
1752         Reviewed by Gyuyoung Kim.
1753
1754         Change the implementation of the zoom functionality from ewk_view_scale_set
1755         to ewk_view_page_zoom_set.
1756
1757         * MiniBrowser/efl/main.c:
1758
1759 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1760
1761         [webkitpy] perf profiler does not understand --call-graph argument
1762         https://bugs.webkit.org/show_bug.cgi?id=131132
1763
1764         Reviewed by Ryosuke Niwa.
1765
1766         New versions of perf profiler have changed the argument from --call-graph to -g.
1767
1768         * Scripts/webkitpy/common/system/profiler.py:
1769         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1770         * Scripts/webkitpy/port/driver_unittest.py:
1771         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1772
1773 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1774
1775         Add EFL WK2 performance bot to build.webkit.org
1776         https://bugs.webkit.org/show_bug.cgi?id=131034
1777
1778         Fix after r166707, use "Perf" instead of "perf" for consistency.
1779
1780         Reviewed by Csaba Osztrogonác.
1781
1782         * BuildSlaveSupport/build.webkit.org-config/config.json:
1783
1784 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1785
1786         Add EFL WK2 performance bot to build.webkit.org
1787         https://bugs.webkit.org/show_bug.cgi?id=131034
1788
1789         Reviewed by Csaba Osztrogonác.
1790
1791         * BuildSlaveSupport/build.webkit.org-config/config.json:
1792
1793 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1794
1795         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1796         https://bugs.webkit.org/show_bug.cgi?id=131151
1797
1798         Reviewed by Gyuyoung Kim.
1799
1800         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1801         (TouchEventInfo::TouchEventInfo):
1802         (sendTouchEvent):
1803         (addTouchPointCallback):
1804         (updateTouchPointCallback):
1805         (cancelTouchPointCallback):
1806         (releaseTouchPointCallback):
1807
1808 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1809
1810         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1811         <http://webkit.org/b/131045>
1812
1813         Reviewed by Daniel Bates.
1814
1815         * Scripts/filter-build-webkit:
1816         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1817         of clang, plus debug data for all DVTAssertions.
1818
1819 2014-04-01  Dean Jackson  <dino@apple.com>
1820
1821         Load Media Controls js/css from bundle
1822         https://bugs.webkit.org/show_bug.cgi?id=131086
1823
1824         Reviewed by Eric Carlson.
1825
1826         We're now putting CSS files into the bundle, so remove the test for them.
1827
1828         * Scripts/check-for-inappropriate-files-in-framework:
1829
1830 2014-04-02  Martin Hock  <mhock@apple.com>
1831
1832         Unify private browsing with sessions.
1833         https://bugs.webkit.org/show_bug.cgi?id=130099
1834
1835         Reviewed by Alexey Proskuryakov.
1836
1837         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1839         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1840         (TestWebKitAPI::didNavigateWithNavigationData):
1841         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1842         (TestWebKitAPI::TEST):
1843
1844         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1845         (TestWebKitAPI::didNavigateWithoutNavigationData):
1846         (TestWebKitAPI::didNavigateWithNavigationData):
1847         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1848         (TestWebKitAPI::TEST):
1849
1850 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1851
1852         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1853         https://bugs.webkit.org/show_bug.cgi?id=130343
1854
1855         Reviewed by Gustavo Noronha Silva.
1856
1857         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1858         of directories on the command line and look for all appropriate files in those directories for the
1859         GResource archive. Also make archive paths relative to those directories.
1860         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1861         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1862
1863 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1864
1865         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1866         https://bugs.webkit.org/show_bug.cgi?id=131106
1867
1868         Reviewed by Csaba Osztrogonác.
1869
1870         * Scripts/webkitpy/tool/commands/download.py:
1871         (AbstractRolloutPrepCommand._prepare_state):
1872         * Scripts/webkitpy/tool/commands/download_unittest.py:
1873         (test_prepare_rollout):
1874         (test_create_rollout):
1875         (test_create_rollout_resolved):
1876         (test_rollout):
1877
1878 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1879
1880         [EFL] Add option to use separate web process for new window in MiniBrowser
1881         https://bugs.webkit.org/show_bug.cgi?id=130190
1882
1883         Reviewed by Gyuyoung Kim.
1884
1885         New created window (CTRL + n) will be open in separated web process.
1886         This option is enabled by adding a flag (S/separate-process) with launching
1887         MiniBrowser.
1888
1889         * MiniBrowser/efl/main.c:
1890         (elm_main):
1891
1892 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1893
1894         [GTK] Move NEWS file to a new location
1895         https://bugs.webkit.org/show_bug.cgi?id=130901
1896
1897         Reviewed by Brent Fulgham.
1898
1899         * gtk/manifest.txt: Update the NEWS file path.
1900
1901 2014-04-01  Anders Carlsson  <andersca@apple.com>
1902
1903         Fix build.
1904
1905         * MiniBrowser/mac/WK2BrowserWindowController.m:
1906         (-[WK2BrowserWindowController awakeFromNib]):
1907         (-[WK2BrowserWindowController dealloc]):
1908         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1909
1910 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1911
1912         Unreviewed test gardening.
1913
1914         * Scripts/webkitpy/port/base_unittest.py:
1915         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1916
1917 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1918
1919         [CSS Exclusions] Remove exclusions parsing support
1920         https://bugs.webkit.org/show_bug.cgi?id=131046
1921
1922         Reviewed by David Hyatt.
1923
1924         * Scripts/webkitperl/FeatureList.pm:
1925
1926 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1927
1928         [GTK] Remove last reference to GTK+ WK1 EWS
1929         https://bugs.webkit.org/show_bug.cgi?id=131058
1930
1931         Reviewed by Martin Robinson.
1932
1933         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1934
1935         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1936
1937 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1938
1939         Add a 32bit JSC builder/tester.
1940         https://bugs.webkit.org/show_bug.cgi?id=131054
1941         
1942         Reviewed by Michael Saboff.
1943
1944         * BuildSlaveSupport/build.webkit.org-config/config.json:
1945         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1946         (Compile32bitJSC):
1947         (Run32bitJSCTests):
1948         (Run32bitJSCTests.countFailures):
1949         (BuildAndTest32bitJSCFactory):
1950         (BuildAndTest32bitJSCFactory.__init__):
1951
1952 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1953
1954         [GTK] No longer build WebKit1 gtkdoc
1955         https://bugs.webkit.org/show_bug.cgi?id=130970
1956
1957         Reviewed by Anders Carlsson.
1958
1959         * gtk/common.py:
1960         (gtk_version_of_pkg_config_file): Deleted.
1961         * gtk/generate-gtkdoc:
1962         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1963         was only applicable for WebKit1.
1964         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1965
1966 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1967
1968         [GTK] Running minibrowser with url crashes in debug build
1969         https://bugs.webkit.org/show_bug.cgi?id=130492
1970
1971         Reviewed by Martin Robinson.
1972
1973         Update "uri-scheme" test not to use invalid URIs in it, so we
1974         don't get a mistmatch when comparing the original URI stored in
1975         the test class with the one returned by the WebKitWebView.
1976
1977         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1978         (testWebContextURIScheme): Update the test.
1979
1980 2014-04-01  Mihai Tica  <mitica@adobe.com>
1981
1982         Unreviewed: Add myself as a commiter to the contributors list.
1983
1984         * Scripts/webkitpy/common/config/contributors.json:
1985
1986 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1987
1988         [EFL][WK2] Extract the control of page background out of color_set
1989         https://bugs.webkit.org/show_bug.cgi?id=127539
1990
1991         Reviewed by Gyuyoung Kim.
1992
1993         Added an option(C) to change background color.
1994
1995         * MiniBrowser/efl/main.c:
1996         (window_create):
1997         (elm_main):
1998
1999 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2000
2001         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2002
2003         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2004
2005 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2006
2007         Unreviewed test correction after r166530.
2008
2009         * DumpRenderTree/mac/DumpRenderTree.mm:
2010         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2011         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2012
2013 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2014
2015         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2016         https://bugs.webkit.org/show_bug.cgi?id=130987
2017
2018         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2019         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2020
2021         Reviewed by Martin Robinson.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/config.json:
2024
2025 2014-03-31  Dean Jackson  <dino@apple.com>
2026
2027         Remove WEB_ANIMATIONS
2028         https://bugs.webkit.org/show_bug.cgi?id=130989
2029
2030         Reviewed by Simon Fraser.
2031
2032         Remove this feature flag until we plan to implement.
2033
2034         * Scripts/webkitperl/FeatureList.pm:
2035
2036 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2037
2038         Reduced Latched Scroll Test Flakiness
2039         https://bugs.webkit.org/show_bug.cgi?id=130983
2040
2041         Reviewed by Darin Adler.
2042
2043         * DumpRenderTree/mac/DumpRenderTree.mm:
2044         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2045         * DumpRenderTree/mac/EventSendingController.mm:
2046         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2047         with high resolution flags turned on.
2048         * WebKitTestRunner/mac/EventSenderProxy.mm:
2049         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2050
2051 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2052
2053         run-webkit-tests should have a --no-timeout option
2054         https://bugs.webkit.org/show_bug.cgi?id=128286
2055
2056         Reviewed by Joseph Pecoraro.
2057
2058         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2059         (Worker._run_test): Renaming _run_test_with_timeout()
2060         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2061         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2062         (Worker._run_test_in_this_thread):
2063         (Worker._run_test_with_timeout): Deleted.
2064         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2065         (parse_args): Added the --no-timeout option
2066
2067 2014-03-31  Samuel White  <samuel_white@apple.com>
2068
2069         AX: Need ability to get line range for text marker.
2070         https://bugs.webkit.org/show_bug.cgi?id=130906
2071
2072         Reviewed by Chris Fleizach.
2073
2074         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2075
2076         * DumpRenderTree/AccessibilityUIElement.cpp:
2077         (lineTextMarkerRangeForTextMarkerCallback):
2078         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2079         (AccessibilityUIElement::getJSClass):
2080         * DumpRenderTree/AccessibilityUIElement.h:
2081         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2082         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2083         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2084         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2086         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2087         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2088         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2089         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2090         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2091         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2092         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2093
2094 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2095
2096         More validation for FTL inline caches
2097         https://bugs.webkit.org/show_bug.cgi?id=130948
2098
2099         Reviewed by Geoffrey Garen.
2100
2101         * Scripts/run-jsc-stress-tests:
2102
2103 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2104
2105         [GTK] Do not run WebKit1 unit tests by default
2106         https://bugs.webkit.org/show_bug.cgi?id=130968
2107
2108         Reviewed by Martin Robinson.
2109
2110         * Scripts/run-gtk-tests:
2111         (TestRunner):
2112
2113 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2114
2115         [GTK] Remove scripts code only applicable to autotools
2116         https://bugs.webkit.org/show_bug.cgi?id=130841
2117
2118         Reviewed by Anders Carlsson.
2119
2120         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2121         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2122         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2123         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2124         * gtk/find-make-dist-errors: Removed.
2125         * gtk/generate-feature-defines-files: Removed.
2126         * gtk/manifest.txt: No longer need to consider autotools files.
2127
2128 2014-03-30  Andy Estes  <aestes@apple.com>
2129
2130         Fix two failing layout tests on Mountain Lion after r166466.
2131
2132         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2133         (-[DownloadDelegate _downloadDidStart:]):
2134
2135 2014-03-30  Andy Estes  <aestes@apple.com>
2136
2137         [Cocoa] Add an originatingWebView property to _WKDownload
2138         https://bugs.webkit.org/show_bug.cgi?id=130945
2139
2140         Reviewed by Anders Carlsson.
2141
2142         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2143         (-[DownloadDelegate _downloadDidStart:]):
2144         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2145         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2146         (TEST):
2147
2148 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2149
2150         Land the stackmap register liveness glue with the uses of the liveness disabled
2151         https://bugs.webkit.org/show_bug.cgi?id=130924
2152
2153         Reviewed by Oliver Hunt.
2154
2155         * Scripts/run-jsc-stress-tests:
2156
2157 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2158
2159         Update WebKit1.StringTruncator for Mountain Lion.
2160
2161         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2162         due to different font metrics on 10.8.
2163
2164 2014-03-28  Darin Adler  <darin@apple.com>
2165
2166         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2167         https://bugs.webkit.org/show_bug.cgi?id=130889
2168
2169         Reviewed by Alexey Proskuryakov.
2170
2171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2172         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2173         WebStringTruncator methods; should be good for a start. These are dependent on the
2174         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2175
2176 2014-03-28  Martin Hock  <mhock@apple.com>
2177
2178         Unreviewed. Add myself as a committer.
2179
2180         * Scripts/webkitpy/common/config/contributors.json:
2181
2182 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2183
2184         Remove WebKit1 GTK+ bots
2185         https://bugs.webkit.org/show_bug.cgi?id=130904
2186
2187         Reviewed by Anders Carlsson.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2190         all bots are testing WebKit2 only.
2191         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2192         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2193         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2194         * Scripts/webkitpy/port/builders.py: Ditto.
2195         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2196         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2197
2198 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2199
2200         Remove Brian Burg's apple.com email address.
2201
2202         * Scripts/webkitpy/common/config/contributors.json:
2203
2204 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2205
2206         bisect-builds should print Trac 'changeset' URL if only one build is detected
2207         <http://webkit.org/b/130903>
2208
2209         Reviewed by Dan Bernstein.
2210
2211         * Scripts/bisect-builds:
2212         (printTracLink): Print a direct link to the Trac 'changeset'
2213         URL if there is only one revision in the range.
2214
2215 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2216
2217         [EFL] Bump glib version from 2.36 to 2.38 
2218         https://bugs.webkit.org/show_bug.cgi?id=130886
2219
2220         Reviewed by Csaba Osztrogonác.
2221
2222         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2223         we need to bump glib version up to 2.38 as gtk port.
2224
2225         * efl/jhbuild.modules:
2226
2227 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2228
2229         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2230
2231         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2232         the globalhistory directory.
2233
2234         Reviewed by Sam Weinig.
2235
2236         * WebKitTestRunner/TestController.cpp:
2237         (WTR::TestController::TestController):
2238         (WTR::TestController::initialize): Set the history client.
2239         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2240         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2241         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2242         and we don't yet have API to access the data in question.
2243         (WTR::TestController::didPerformClientRedirect):
2244         (WTR::TestController::didPerformServerRedirect):
2245         (WTR::TestController::didUpdateHistoryTitle):
2246         * WebKitTestRunner/TestController.h:
2247         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2248         * WebKitTestRunner/TestInvocation.cpp:
2249         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2250         (WTR::TestInvocation::invoke):
2251
2252 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2253
2254         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2255
2256         * Scripts/build-webkit:
2257         * Scripts/copy-webkitlibraries-to-product-directory:
2258
2259 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2260
2261         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2262         https://bugs.webkit.org/show_bug.cgi?id=130867
2263         <rdar://problem/16432456> 
2264
2265         Reviewed by Mark Hahnenberg.
2266
2267         * Scripts/build-webkit:
2268         * Scripts/copy-webkitlibraries-to-product-directory:
2269
2270 2014-03-26  Andy Estes  <aestes@apple.com>
2271
2272         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2273         https://bugs.webkit.org/show_bug.cgi?id=130805
2274
2275         Reviewed by Dan Bernstein.
2276
2277         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2278         (-[DownloadDelegate _download:didReceiveResponse:]):
2279         (-[DownloadDelegate _downloadDidFinish:]):
2280         (runTest):
2281         (TEST):
2282         (-[FailingDownloadDelegate _downloadDidFinish:]):
2283         (-[FailingDownloadDelegate _download:didFailWithError:]):
2284         (-[FailingDownloadDelegate _downloadDidCancel:]):
2285         (-[CancelledDownloadDelegate _downloadDidStart:]):
2286         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2287         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2288         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2289         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2290         (-[DownloadDelegate sourceURL]): Deleted.
2291         (runTestWithNavigationDelegate): Deleted.
2292
2293 2014-03-26  Anders Carlsson  <andersca@apple.com>
2294
2295         Change MiniBrowser to hold on to window controllers instead of windows
2296         https://bugs.webkit.org/show_bug.cgi?id=130797
2297
2298         Reviewed by Oliver Hunt.
2299
2300         * MiniBrowser/mac/AppDelegate.h:
2301         * MiniBrowser/mac/AppDelegate.m:
2302         (-[BrowserAppDelegate init]):
2303         (-[BrowserAppDelegate newWindow:]):
2304         (-[BrowserAppDelegate browserWindowWillClose:]):
2305         (-[BrowserAppDelegate applicationWillTerminate:]):
2306         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2307
2308 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2309
2310         Unreviewed, rolling out r166264.
2311         https://bugs.webkit.org/show_bug.cgi?id=130785
2312
2313         Broke some window.opener tests for WK2 Mavericks (Requested by
2314         brrian__ on #webkit).
2315
2316         Reverted changeset:
2317
2318         "Web Replay: resource unique identifiers should be unique-per-
2319         frame, not globally"
2320         https://bugs.webkit.org/show_bug.cgi?id=130632
2321         http://trac.webkit.org/changeset/166264
2322
2323 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2324
2325         [CSS Shapes] Remove shape-inside support
2326         https://bugs.webkit.org/show_bug.cgi?id=130698
2327
2328         Reviewed by David Hyatt.
2329
2330         * Scripts/webkitperl/FeatureList.pm:
2331
2332 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2333
2334         Unreviewed. Add myself as a committer.
2335
2336         * Scripts/webkitpy/common/config/contributors.json:
2337
2338 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2339
2340         run-launcher is Perl script so use elsif and not elif
2341         https://bugs.webkit.org/show_bug.cgi?id=130771
2342
2343         Reviewed by Carlos Garcia Campos.
2344
2345         * Scripts/run-launcher:
2346
2347 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2348
2349         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2350         https://bugs.webkit.org/show_bug.cgi?id=130575
2351
2352         Reviewed by Mario Sanchez Prada.
2353
2354         Change ATK version to 2.11.92. Adjust current implementation.
2355
2356         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2357         (AccessibilityUIElement::intValue):
2358         (AccessibilityUIElement::minValue):
2359         (AccessibilityUIElement::maxValue):
2360         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2361         (WTR::AccessibilityUIElement::intValue):
2362         (WTR::AccessibilityUIElement::minValue):
2363         (WTR::AccessibilityUIElement::maxValue):
2364         * efl/jhbuild.modules:
2365         * gtk/jhbuild.modules:
2366
2367 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2368
2369         [GTK] The gnumake package is no longer needed in jhbuild
2370         https://bugs.webkit.org/show_bug.cgi?id=130121
2371
2372         Reviewed by Martin Robinson.
2373
2374         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2375         for a debug build cmake/system-gnumake worked just fine for me.
2376
2377         * gtk/jhbuild.modules: Removed gnumake.
2378         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2379         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2380
2381 2014-03-25  Andy Estes  <aestes@apple.com>
2382
2383         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2384
2385         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2386         (-[DownloadDelegate _download:didReceiveData:]):
2387         (-[DownloadDelegate _downloadDidFinish:]):
2388
2389 2014-03-25  Brian Burg  <bburg@apple.com>
2390
2391         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2392         https://bugs.webkit.org/show_bug.cgi?id=130623
2393
2394         Reviewed by Timothy Hatcher.
2395
2396         The resource loader callback dumping routines assumed that resource identifiers
2397         were globally unique. Its map of resource identifiers to URLs must also track the
2398         frame associated with the resource.
2399
2400         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2401         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2402         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2403         stable as long as the frame is valid.
2404         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2405         (WTR::InjectedBundlePage::willSendRequestForFrame):
2406         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2407         (WTR::InjectedBundlePage::didFinishLoadForResource):
2408         (WTR::InjectedBundlePage::didFailLoadForResource):
2409
2410 2014-03-25  Andy Estes  <aestes@apple.com>
2411
2412         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2413
2414         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2415         (-[DownloadDelegate _download:didReceiveResponse:]):
2416         (-[DownloadDelegate _download:didReceiveData:]):
2417
2418 2014-03-25  Andy Estes  <aestes@apple.com>
2419
2420         Add some debug logging to an API test that's failing on Mountain Lion.
2421
2422         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2423         (-[DownloadDelegate _download:didReceiveResponse:]):
2424         (-[DownloadDelegate _downloadDidFinish:]):
2425
2426 2014-03-25  Anders Carlsson  <andersca@apple.com>
2427
2428         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2429         https://bugs.webkit.org/show_bug.cgi?id=130732
2430
2431         Reviewed by Tim Horton.
2432
2433         * MiniBrowser/mac/WK2BrowserWindowController.m:
2434         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2435
2436 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2437
2438         [GTK] Remove the autotools build
2439         https://bugs.webkit.org/show_bug.cgi?id=130717
2440
2441         Reviewed by Anders Carlsson.
2442
2443         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2444         * GNUmakefile.am: Removed.
2445         * GtkLauncher/GNUmakefile.am: Removed.
2446         * GtkLauncher/main.c: Remove references to the autotools configure file.
2447         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2448         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2449         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2450         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2451         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2452         * Scripts/build-webkit: No longer handle autotools.
2453         * Scripts/run-gtk-tests: Ditto.
2454         (TestRunner._setup_testing_environment):
2455         * Scripts/run-launcher: Ditto.
2456         * Scripts/webkitdirs.pm: Ditto.
2457         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2458         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2459         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2460         * Scripts/webkitpy/style/checker.py:
2461         * TestWebKitAPI/GNUmakefile.am: Removed.
2462         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2463         * WebKitTestRunner/GNUmakefile.am: Removed.
2464         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2465         * gtk/GNUmakefile.am: Removed.
2466         * gtk/common.py: Remove checks for the autotools build.
2467         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2468
2469 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2470
2471         prepare-ChangeLog throws false positive warnings for modified files.
2472         https://bugs.webkit.org/show_bug.cgi?id=130687
2473
2474         Reviewed by Darin Adler.
2475
2476         * Scripts/prepare-ChangeLog:
2477         (originalFile): Ignore git commit paremeter.
2478         We don't need this to get the unmodified file.
2479         (extractLineRangeBeforeChange):
2480         Simplify the if statement. Follow-up after r166189.
2481
2482 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2483
2484         [EFL] Add ARM64 build support
2485         https://bugs.webkit.org/show_bug.cgi?id=130506
2486
2487         Rubber stamped by Gyuyoung Kim.
2488
2489         * Scripts/webkitdirs.pm:
2490         (isARM): Detect aarch64 as ARM.
2491
2492 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2493
2494         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2495         https://bugs.webkit.org/show_bug.cgi?id=130137
2496
2497         Reviewed by Csaba Osztrogonác.
2498
2499         * Scripts/webkitpy/common/checkout/changelog.py:
2500         (ChangeLogEntry._parse_bug_description):
2501         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2502         (test_parse_log_entries_from_changelog):
2503         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2504         (CheckoutTest.test_commit_info_for_revision):
2505
2506 2014-03-24  Andy Estes  <aestes@apple.com>
2507
2508         Fix the iOS build of TestWebKitAPI.
2509
2510         * TestWebKitAPI/Configurations/Base.xcconfig:
2511         * TestWebKitAPI/PlatformUtilities.h:
2512
2513 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2514
2515         Fix prepare-ChangeLog after r166156.
2516         https://bugs.webkit.org/show_bug.cgi?id=130674
2517
2518         Reviewed by Darin Adler.
2519
2520         * Scripts/prepare-ChangeLog:
2521         (generateFunctionLists):
2522         (extractLineRangeBeforeChange):
2523
2524 2014-03-24  Andy Estes  <aestes@apple.com>
2525
2526         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2527         https://bugs.webkit.org/show_bug.cgi?id=129322
2528
2529         Reviewed by Anders Carlsson.
2530
2531         Add an API test suite for _WKDownload.
2532
2533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2534         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2535         (-[DownloadDelegate initWithSourceURL:]):
2536         (-[DownloadDelegate sourceURL]):
2537         (-[DownloadDelegate _downloadDidStart:]):
2538         (-[DownloadDelegate _download:didReceiveResponse:]):
2539         (-[DownloadDelegate _download:didReceiveData:]):
2540         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2541         (-[DownloadDelegate _downloadDidFinish:]):
2542         (TEST):
2543         (runTestWithNavigationDelegate):
2544         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2545         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2546
2547 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2548
2549         filter-build-webkit: reduce unfiltered output
2550         https://bugs.webkit.org/show_bug.cgi?id=130485
2551
2552         Reviewed by Brent Fulgham.
2553
2554         * Scripts/filter-build-webkit:
2555         (shouldIgnoreLine):
2556
2557 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2558
2559         prepare-ChangeLog should list functions that have been removed too.
2560         https://bugs.webkit.org/show_bug.cgi?id=130508
2561
2562         Reviewed by Darin Adler.
2563
2564         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2565         We have to read the functions and the line ranges of them from the source
2566         before the change, then search for overlaps between them and the changed
2567         line ranges from diff.
2568
2569         * Scripts/prepare-ChangeLog:
2570         (originalFile): Get original source command.
2571         (generateFunctionLists): Collect deleted functions too.
2572         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2573         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2574         deleted functions ranges too.
2575         (extractLineRange): Renamed to extractLineRangeAfterChange.
2576
2577 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2578
2579         Move all EFL typedefs into EflTypedefs.h.
2580         https://bugs.webkit.org/show_bug.cgi?id=130511
2581
2582         Reviewed by Gyuyoung Kim.
2583
2584         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2585         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2586         * WebKitTestRunner/PlatformWebView.h: Ditto.
2587
2588 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2589
2590         Don't flush compositing layers within FrameView::willPaintContents()
2591         https://bugs.webkit.org/show_bug.cgi?id=130627
2592         <rdar://problem/16368869>
2593
2594         Reviewed by Sam Weinig.
2595         
2596         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2597         does not flush.
2598         
2599         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2600         into an explicit function called before dumping. 
2601         
2602         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2603         are flushed to CA. They will be pushed to the window by snapshotting.
2604
2605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2606         Fix weird path to IOKit.framework.
2607         * DumpRenderTree/mac/DumpRenderTree.mm:
2608         (updateDisplay):
2609         (dump):
2610         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2611         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2612         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2613
2614 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2615
2616         fix-blink-patch: tool to fix up renamed directory paths in Blink
2617         <http://webkit.org/b/130609>
2618
2619         Reviewed by Ryosuke Niwa.
2620
2621         Usage: cat blink.patch | fix-blink-patch | svn-apply
2622
2623         * Scripts/fix-blink-patch: Added.
2624
2625 2014-03-21  Darin Adler  <darin@apple.com>
2626
2627         Remove use of deprecatedCharacters in WebKit API tests
2628         https://bugs.webkit.org/show_bug.cgi?id=130602
2629
2630         Reviewed by Antti Koivisto.
2631
2632         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2633         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2634         (TestWebKitAPI::expectEmpty): Use characters8.
2635         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2636
2637         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2638         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2639         the deprecatedCharacters function itself, which we are about to delete.
2640
2641 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2642
2643         [webkitpy] Fix has_valid_reviewer()
2644         https://bugs.webkit.org/show_bug.cgi?id=130589
2645
2646         Reviewed by Csaba Osztrogonác.
2647
2648         * Scripts/webkitpy/common/checkout/changelog.py:
2649         (ChangeLogEntry.has_valid_reviewer):
2650         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2651         (test_has_valid_reviewer):
2652         * Scripts/webkitpy/common/config/committers.py:
2653         (CommitterList._reviewer_only):
2654         (CommitterList.committer_by_name):
2655         (CommitterList.reviewer_by_email):
2656         (CommitterList):
2657         (CommitterList.reviewer_by_name):
2658
2659 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2660
2661         Add cache support for jhbuild
2662         https://bugs.webkit.org/show_bug.cgi?id=130588
2663
2664         Reviewed by Csaba Osztrogonác.
2665
2666         * jhbuild/jhbuildrc_common.py:
2667         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2668
2669 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2670
2671         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2672         https://bugs.webkit.org/show_bug.cgi?id=130504
2673
2674         Reviewed by Martin Robinson.
2675
2676         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2677         CMake if not specified.
2678         * Scripts/webkitdirs.pm:
2679         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2680         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2681
2682 2014-03-21  Andreas Kling  <akling@apple.com>
2683
2684         RetainPtr API test should use CFArray instead of CFString for testing.
2685         <rdar://problem/16384899>
2686
2687         Unreviewed bot fix.
2688
2689         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2690         (TestWebKitAPI::TEST):
2691         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2692         (TestWebKitAPI::TEST):
2693
2694 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2695
2696         Move to using std::unique_ptr for EFL objects.
2697         https://bugs.webkit.org/show_bug.cgi?id=129853
2698
2699         Reviewed by Gyuyoung Kim.
2700
2701         EflUniquePtr is a template alias of std::unique_ptr
2702         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2703         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2704
2705         * DumpRenderTree/efl/DumpRenderTree.cpp:
2706         (main):
2707         * ImageDiff/efl/ImageDiff.cpp:
2708         (initEfl):
2709         (main):
2710
2711 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2712
2713         Unreviewed buildfix after r165983 for non Cocoa platforms
2714
2715         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2716
2717         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2718         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2719         * WebKitTestRunner/TestController.cpp:
2720
2721 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2722
2723         [GTK][CMake] Add support for building with Clang
2724         https://bugs.webkit.org/show_bug.cgi?id=130260
2725
2726         Reviewed by Martin Robinson.
2727
2728         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2729         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2730         included GTest framework headers.
2731         * gtk/generate-gtkdoc:
2732         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2733         in case of using Clang since that is now set by the CMake rule.
2734
2735 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2736
2737         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2738         https://bugs.webkit.org/show_bug.cgi?id=130476
2739
2740         Reviewed by Anders Carlsson.
2741         
2742         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2743
2744         * MiniBrowser/mac/WK1BrowserWindowController.m:
2745         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2746         Remove log.
2747         * MiniBrowser/mac/WK2BrowserWindowController.m:
2748         (-[WK2BrowserWindowController awakeFromNib]):
2749         (-[WK2BrowserWindowController validateMenuItem:]):
2750         (-[WK2BrowserWindowController reload:]):
2751         Hook up reload.
2752         (-[WK2BrowserWindowController toggleZoomMode:]):
2753         (-[WK2BrowserWindowController resetZoom:]):
2754         (-[WK2BrowserWindowController canResetZoom]):
2755         (-[WK2BrowserWindowController currentZoomFactor]):
2756         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2757         (-[WK2BrowserWindowController canZoomIn]):
2758         (-[WK2BrowserWindowController canZoomOut]):
2759
2760 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2761
2762         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2763         https://bugs.webkit.org/show_bug.cgi?id=130463
2764
2765         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2766
2767 2014-03-18  Samuel White  <samuel_white@apple.com>
2768
2769         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2770         https://bugs.webkit.org/show_bug.cgi?id=130250
2771
2772         Reviewed by Chris Fleizach.
2773
2774         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2775
2776         * DumpRenderTree/AccessibilityController.cpp:
2777         (enableEnhancedAccessibilityCallback):
2778         (getEnhancedAccessibilityEnabledCallback):
2779         (AccessibilityController::getJSClass):
2780         * DumpRenderTree/AccessibilityController.h:
2781         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2782         (AccessibilityController::enableEnhancedAccessibility):
2783         (AccessibilityController::enhancedAccessibilityEnabled):
2784         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2785         (AccessibilityController::enableEnhancedAccessibility):
2786         (AccessibilityController::enhancedAccessibilityEnabled):
2787         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2788         (AccessibilityController::enableEnhancedAccessibility):
2789         (AccessibilityController::enhancedAccessibilityEnabled):
2790         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2791         (AccessibilityController::enableEnhancedAccessibility):
2792         (AccessibilityController::enhancedAccessibilityEnabled):
2793         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2794         (WTR::AccessibilityController::enableEnhancedAccessibility):
2795         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2796         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2797         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2798
2799 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2800
2801         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2802         yet).
2803
2804         * Scripts/webkitpy/common/config/contributors.json:
2805
2806 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2807
2808         Web Inspector: Remove stale ReportMemoryUsagePlugin
2809         https://bugs.webkit.org/show_bug.cgi?id=130405
2810
2811         Reviewed by Andreas Kling.
2812
2813         This clang plugin looks like it was used for the old Inspector memory
2814         instrumentation that was removed. So the tool can be removed.
2815
2816         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2817         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2818         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2819         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2820
2821 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2822
2823         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2824         https://bugs.webkit.org/show_bug.cgi?id=130220
2825
2826         Reviewed by Csaba Osztrogonác.
2827
2828         * Scripts/webkitpy/common/checkout/changelog.py:
2829         (ChangeLog.set_reviewer):
2830         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2831         (test_set_reviewer):
2832
2833 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2834
2835         More FTL enabling.
2836
2837         Rubber stamped by Dan Bernstein.
2838
2839         * Tools/Scripts/build-webkit:
2840
2841 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2842
2843         Renable pagination mode in WK2 MiniBrowser
2844         https://bugs.webkit.org/show_bug.cgi?id=130374
2845
2846         Reviewed by Anders Carlsson.
2847         
2848         Put the implementation of togglePaginationMode: back, and correctly
2849         enable the menu item.
2850
2851         * MiniBrowser/mac/WK2BrowserWindowController.m:
2852         (-[WK2BrowserWindowController validateMenuItem:]):
2853         (-[WK2BrowserWindowController isPaginated]):
2854         (-[WK2BrowserWindowController togglePaginationMode:]):
2855
2856 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2857
2858         Add --reset option to Tools/Scripts/set-webkit-configuration script
2859         https://bugs.webkit.org/show_bug.cgi?id=130401
2860
2861         Reviewed by Csaba Osztrogonác.
2862
2863         * Scripts/set-webkit-configuration:
2864
2865 2014-03-18  Alberto Garcia  <berto@igalia.com>
2866
2867         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2868         https://bugs.webkit.org/show_bug.cgi?id=130388
2869
2870         Reviewed by Sergio Villar Senin.
2871
2872         * Scripts/webkitdirs.pm:
2873         (shouldRemoveCMakeCache): make sure that the build directory
2874         exists before attempting to create a file in it.
2875
2876 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2877
2878         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2879         https://bugs.webkit.org/show_bug.cgi?id=130336
2880
2881         Reviewed by Gyuyoung Kim.
2882
2883         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2884         requires a space between literal and string macro [-Wliteral-suffix]'
2885         warning treated as error.
2886
2887         This patch applies a solution from r162448 to the EFL port.
2888
2889         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2890         * efl/jhbuild.modules: Added appropriate patch section.
2891
2892 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2893
2894         webkitpy test rebaseline.
2895
2896         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2897         (MainTest.test_default_args):
2898
2899 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2900
2901         --profile should imply --test-runner-count=1 in run-perf-tests
2902         https://bugs.webkit.org/show_bug.cgi?id=130375
2903
2904         Reviewed by Benjamin Poulain.
2905
2906         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2907
2908         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2909         (PerfTestsRunner._parse_args): Use -1 as the default value.
2910         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2911         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2912         should be 1.
2913
2914 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2915
2916         Address some style nits.
2917
2918         * MiniBrowser/mac/WK2BrowserWindowController.m:
2919
2920 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2921
2922         Add transparent window support back into MiniBrowser
2923         https://bugs.webkit.org/show_bug.cgi?id=130363
2924
2925         Reviewed by Anders Carlsson.
2926         
2927         Re-enable transparent window support for WK2.
2928
2929         * MiniBrowser/mac/WK2BrowserWindowController.m:
2930         (-[WK2BrowserWindowController validateMenuItem:]):
2931         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2932
2933 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2934
2935         Fix the 32-bit build; make the open panel make a WK1 window.
2936
2937         * MiniBrowser/mac/AppDelegate.m:
2938         (-[BrowserAppDelegate openDocument:]):
2939
2940 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2941
2942         Convert MiniBrowser to use WKWebView API
2943         https://bugs.webkit.org/show_bug.cgi?id=130061
2944
2945         Reviewed by Anders Carlsson.
2946         
2947         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2948         as possible.
2949         
2950         Some functionality was removed temporarily:
2951             - text zoom, page zoom
2952             - reload
2953             - pagination mode
2954             - transparent window
2955             - dumping source
2956             - window.open support
2957             - beforeUnload panel
2958             - find in page
2959
2960         * MiniBrowser/mac/AppDelegate.h:
2961         * MiniBrowser/mac/AppDelegate.m:
2962         (-[BrowserAppDelegate init]):
2963         (-[BrowserAppDelegate newWindow:]):
2964         (-[BrowserAppDelegate applicationWillTerminate:]):
2965         (-[BrowserAppDelegate openDocument:]):
2966         * MiniBrowser/mac/WK2BrowserWindowController.h:
2967         * MiniBrowser/mac/WK2BrowserWindowController.m:
2968         (-[WK2BrowserWindowController awakeFromNib]):
2969         (-[WK2BrowserWindowController dealloc]):
2970         (-[WK2BrowserWindowController fetch:]):
2971         (-[WK2BrowserWindowController validateMenuItem:]):
2972         (-[WK2BrowserWindowController reload:]):
2973         (-[WK2BrowserWindowController goBack:]):
2974         (-[WK2BrowserWindowController goForward:]):
2975         (-[WK2BrowserWindowController toggleZoomMode:]):
2976         (-[WK2BrowserWindowController resetZoom:]):
2977         (-[WK2BrowserWindowController canResetZoom]):
2978         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2979         (-[WK2BrowserWindowController togglePaginationMode:]):
2980         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2981         (-[WK2BrowserWindowController windowShouldClose:]):
2982         (-[WK2BrowserWindowController applicationTerminating]):
2983         (-[WK2BrowserWindowController currentZoomFactor]):
2984         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2985         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2986         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2987         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2988         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2989         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2990         (-[WK2BrowserWindowController find:]):
2991         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2992         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2993         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2994         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2995         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2996         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2997         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2998         * WebKitTestRunner/PlatformWebView.h:
2999         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3000         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3001
3002 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3003
3004         Use RunLoop objects through references instead of pointers
3005         https://bugs.webkit.org/show_bug.cgi?id=130313
3006
3007         Reviewed by Andreas Kling.
3008
3009         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3010         return RunLoop reference instead of a pointer.
3011
3012         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3013         (loadedCallback):
3014         (clickedCallback):
3015
3016 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3017
3018         sort-export-file --help doesn't work (missing 'use')
3019         https://bugs.webkit.org/show_bug.cgi?id=130338
3020
3021         Reviewed by Anders Carlsson.
3022
3023         * Scripts/sort-export-file:
3024         Add a missing 'use', and fix a typo in an error message.
3025
3026 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3027
3028         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3029         https://bugs.webkit.org/show_bug.cgi?id=130155
3030
3031         Reviewed by Philippe Normand.
3032
3033         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3034
3035 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3036
3037         [GTK] MiniBrowser fails to load injected bundle lib
3038         https://bugs.webkit.org/show_bug.cgi?id=130332
3039
3040         Reviewed by Anders Carlsson.
3041
3042         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3043
3044         * MiniBrowser/gtk/main.c:
3045         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3046         process is spawn.
3047
3048 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3049
3050         [EFL] Enable TOUCH_SLIDER macro
3051         https://bugs.webkit.org/show_bug.cgi?id=130185
3052
3053         Reviewed by Gyuyoung Kim.
3054
3055         * Scripts/webkitperl/FeatureList.pm:
3056
3057 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3058
3059         [GTK][CMake] Build with -fno-rtti
3060         https://bugs.webkit.org/show_bug.cgi?id=130261
3061
3062         Reviewed by Martin Robinson.
3063
3064         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3065         defined to 0 to prevent typeid use in included GTest headers.
3066
3067 2014-03-16  Brian Burg  <bburg@apple.com>
3068
3069         Web Inspector: vended backend commands file should be generated as part of the build
3070         https://bugs.webkit.org/show_bug.cgi?id=130110
3071
3072         Reviewed by Timothy Hatcher.
3073
3074         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3075
3076 2014-03-16  Diego Pino García  <dpino@igalia.com>
3077
3078         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3079         https://bugs.webkit.org/show_bug.cgi?id=128999
3080
3081         Reviewed by Philippe Normand.
3082
3083         * MiniBrowser/gtk/BrowserWindow.c:
3084         (reloadPage):
3085         (reloadPageIgnoringCache):
3086         (browser_window_init):
3087
3088 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3089
3090         [GTK] Improve ninja detection in webkitdirs.pm
3091         https://bugs.webkit.org/show_bug.cgi?id=129902
3092
3093         Reviewed by Daniel Bates.
3094
3095         * Scripts/webkitdirs.pm:
3096         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3097         us to look for ninja-build as well.
3098
3099 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3100
3101         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3102         https://bugs.webkit.org/show_bug.cgi?id=130276
3103         <rdar://problem/16266927>
3104         
3105         Reviewed by Simon Fraser.
3106
3107         * BuildSlaveSupport/build-launcher-app:
3108         * BuildSlaveSupport/build-launcher-dmg:
3109         * DumpRenderTree/DumpRenderTree.h:
3110         * DumpRenderTree/DumpRenderTreePrefix.h:
3111         * DumpRenderTree/GCController.cpp:
3112         * DumpRenderTree/GCController.h:
3113         * DumpRenderTree/JavaScriptThreading.cpp:
3114         * DumpRenderTree/JavaScriptThreading.h:
3115         * DumpRenderTree/PixelDumpSupport.cpp:
3116         * DumpRenderTree/PixelDumpSupport.h:
3117         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3118         * DumpRenderTree/TestRunner.cpp:
3119         * DumpRenderTree/TestRunner.h:
3120         * DumpRenderTree/WorkQueue.cpp:
3121         * DumpRenderTree/WorkQueue.h:
3122         * DumpRenderTree/WorkQueueItem.h:
3123         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3124         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3125         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3126         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3127         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3128         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3129         * DumpRenderTree/efl/EditingCallbacks.cpp:
3130         * DumpRenderTree/efl/EditingCallbacks.h:
3131         * DumpRenderTree/efl/EventSender.cpp:
3132         * DumpRenderTree/efl/EventSender.h:
3133         * DumpRenderTree/efl/GCControllerEfl.cpp:
3134         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3135         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3136         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3137         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3138         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3139         * DumpRenderTree/gtk/EditingCallbacks.h:
3140         * DumpRenderTree/gtk/EventSender.cpp:
3141         * DumpRenderTree/gtk/EventSender.h:
3142         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3143         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3144         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3145         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3146         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3147         * DumpRenderTree/gtk/TextInputController.cpp:
3148         * DumpRenderTree/gtk/TextInputController.h:
3149         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3150         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3151         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3152         * DumpRenderTree/mac/AppleScriptController.h:
3153         * DumpRenderTree/mac/AppleScriptController.m:
3154         * DumpRenderTree/mac/CheckedMalloc.cpp:
3155         * DumpRenderTree/mac/CheckedMalloc.h:
3156         * DumpRenderTree/mac/DumpRenderTree.mm:
3157         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3158         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3159         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3160         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3161         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3162         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3163         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3164         * DumpRenderTree/mac/EditingDelegate.h:
3165         * DumpRenderTree/mac/EditingDelegate.mm:
3166         * DumpRenderTree/mac/EventSendingController.h:
3167         * DumpRenderTree/mac/EventSendingController.mm:
3168         * DumpRenderTree/mac/FrameLoadDelegate.h:
3169         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3170         * DumpRenderTree/mac/GCControllerMac.mm:
3171         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3172         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3173         * DumpRenderTree/mac/NavigationController.h:
3174         * DumpRenderTree/mac/NavigationController.m:
3175         * DumpRenderTree/mac/ObjCController.h:
3176         * DumpRenderTree/mac/ObjCController.m:
3177         * DumpRenderTree/mac/ObjCPlugin.h:
3178         * DumpRenderTree/mac/ObjCPlugin.m:
3179         * DumpRenderTree/mac/ObjCPluginFunction.h:
3180         * DumpRenderTree/mac/ObjCPluginFunction.m:
3181         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3182         * DumpRenderTree/mac/PolicyDelegate.h:
3183         * DumpRenderTree/mac/PolicyDelegate.mm:
3184         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3185         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3186         * DumpRenderTree/mac/TestRunnerMac.mm:
3187         * DumpRenderTree/mac/TextInputController.h:
3188         * DumpRenderTree/mac/TextInputController.m:
3189         * DumpRenderTree/mac/UIDelegate.h:
3190         * DumpRenderTree/mac/UIDelegate.mm:
3191         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3192         * DumpRenderTree/win/DRTDataObject.cpp:
3193         * DumpRenderTree/win/DRTDataObject.h:
3194         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3195         * DumpRenderTree/win/DRTDropSource.cpp:
3196         * DumpRenderTree/win/DRTDropSource.h:
3197         * DumpRenderTree/win/DraggingInfo.h:
3198         * DumpRenderTree/win/DumpRenderTree.cpp:
3199         * DumpRenderTree/win/DumpRenderTreeWin.h:
3200         * DumpRenderTree/win/EditingDelegate.cpp:
3201         * DumpRenderTree/win/EditingDelegate.h:
3202         * DumpRenderTree/win/EventSender.cpp:
3203         * DumpRenderTree/win/EventSender.h:
3204         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3205         * DumpRenderTree/win/FrameLoadDelegate.h:
3206         * DumpRenderTree/win/GCControllerWin.cpp:
3207         * DumpRenderTree/win/HistoryDelegate.cpp:
3208         * DumpRenderTree/win/HistoryDelegate.h:
3209         * DumpRenderTree/win/MD5.cpp:
3210         * DumpRenderTree/win/MD5.h:
3211         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3212         * DumpRenderTree/win/PolicyDelegate.cpp:
3213         * DumpRenderTree/win/PolicyDelegate.h:
3214         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3215         * DumpRenderTree/win/ResourceLoadDelegate.h:
3216         * DumpRenderTree/win/TestRunnerWin.cpp:
3217         * DumpRenderTree/win/TextInputController.cpp:
3218         * DumpRenderTree/win/TextInputController.h:
3219         * DumpRenderTree/win/TextInputControllerWin.cpp:
3220         * DumpRenderTree/win/UIDelegate.cpp:
3221         * DumpRenderTree/win/UIDelegate.h:
3222         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3223         * EWebLauncher/main.c:
3224         * GtkLauncher/main.c:
3225         * ImageDiff/efl/ImageDiff.cpp:
3226         * ImageDiff/gtk/ImageDiff.cpp:
3227         * MiniBrowser/gtk/main.c:
3228         * Scripts/SpacingHeuristics.pm:
3229         * Scripts/VCSUtils.pm:
3230         * Scripts/bisect-builds:
3231         * Scripts/build-dumprendertree:
3232         * Scripts/build-jsc:
3233         * Scripts/build-webkit:
3234         * Scripts/check-dom-results:
3235         * Scripts/check-for-exit-time-destructors:
3236         * Scripts/check-for-global-initializers:
3237         * Scripts/commit-log-editor:
3238         * Scripts/compare-timing-files:
3239         * Scripts/debug-minibrowser:
3240         * Scripts/debug-safari:
3241         * Scripts/do-file-rename:
3242         * Scripts/find-extra-includes:
3243         * Scripts/generate-coverage-data:
3244         * Scripts/make-script-test-wrappers:
3245         * Scripts/malloc-tree:
3246         * Scripts/old-run-webkit-tests:
3247         * Scripts/parse-malloc-history:
3248         * Scripts/report-include-statistics:
3249         * Scripts/resolve-ChangeLogs:
3250         * Scripts/run-bindings-tests:
3251         * Scripts/run-iexploder-tests:
3252         * Scripts/run-javascriptcore-tests:
3253         * Scripts/run-jsc:
3254         * Scripts/run-launcher:
3255         * Scripts/run-leaks:
3256         * Scripts/run-mangleme-tests:
3257         * Scripts/run-minibrowser:
3258         * Scripts/run-pageloadtest:
3259         * Scripts/run-regexp-tests:
3260         * Scripts/run-safari:
3261         * Scripts/run-sunspider:
3262         * Scripts/run-webkit-app:
3263         * Scripts/sampstat:
3264         * Scripts/set-webkit-configuration:
3265         * Scripts/sort-Xcode-project-file:
3266         * Scripts/sort-export-file:
3267         * Scripts/split-file-by-class:
3268         * Scripts/sunspider-compare-results:
3269         * Scripts/svn-apply:
3270         * Scripts/svn-create-patch:
3271         * Scripts/svn-unapply:
3272         * Scripts/test-webkit-scripts:
3273         * Scripts/update-javascriptcore-test-results:
3274         * Scripts/update-webkit:
3275         * Scripts/update-webkit-auxiliary-libs:
3276         * Scripts/update-webkit-dependency:
3277         * Scripts/update-webkit-localizable-strings:
3278         * Scripts/update-webkit-support-libs:
3279         * Scripts/update-webkit-wincairo-libs:
3280         * Scripts/webkit-build-directory:
3281         * Scripts/webkitdirs.pm:
3282         (installedSafariPath):
3283         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3284         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3285         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3286         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3287         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3288         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3289         * Scripts/webkitperl/features.pm:
3290         * Scripts/webkitperl/httpd.pm:
3291         * Scripts/webkitpy/bindings/main.py:
3292         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3293         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3294         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3295         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3296         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3297         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3298         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3299         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3300         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3301         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3302         * WebKitTestRunner/PixelDumpSupport.cpp:
3303         * WebKitTestRunner/PixelDumpSupport.h:
3304         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3305         * WinLauncher/WinLauncher.cpp:
3306         * WinLauncher/WinLauncher.h:
3307         * WinLauncher/stdafx.cpp:
3308         * WinLauncher/stdafx.h:
3309
3310 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3311
3312         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3313         https://bugs.webkit.org/show_bug.cgi?id=130265
3314
3315         Reviewed by Michael Saboff.
3316
3317         * Scripts/build-webkit:
3318         * Scripts/copy-webkitlibraries-to-product-directory:
3319
3320 2014-03-14  Landry Breuil  <landry@openbsd.org>
3321
3322         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3323         Also allow to set MAKE in the environment.
3324         https://bugs.webkit.org/show_bug.cgi?id=129991
3325
3326         Reviewed by Andreas Kling.
3327
3328         * Scripts/webkitdirs.pm:
3329         (determineArchitecture):
3330         (determineNumberOfCPUs):
3331         (isBSD):
3332         (buildAutotoolsProject):
3333         * Scripts/webkitpy/common/system/platforminfo.py:
3334         (PlatformInfo.__init__):
3335         (PlatformInfo.is_openbsd):
3336         (PlatformInfo):
3337         (PlatformInfo.is_netbsd):
3338         (PlatformInfo._determine_os_name):
3339
3340 2014-03-14  Dean Jackson  <dino@apple.com>
3341
3342         Remove libWebKitSystemInterfaceLion.a
3343         https://bugs.webkit.org/show_bug.cgi?id=130254
3344
3345         Reviewed by Geoffrey Garen and Andreas Kling.
3346
3347         No need to copy the Lion libraries into the build.
3348
3349         * Scripts/copy-webkitlibraries-to-product-directory:
3350
3351 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3352
3353         [EFL][MiniBrowser] Revise help messages of command line parameters
3354         https://bugs.webkit.org/show_bug.cgi?id=130222
3355
3356         Reviewed by Csaba Osztrogonác.
3357
3358         Correct the default value description and make help messages to be consistent.
3359
3360         * MiniBrowser/efl/main.c:
3361
3362 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3363
3364         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3365         https://bugs.webkit.org/show_bug.cgi?id=129612
3366
3367         Reviewed by Darin Adler.
3368
3369         For new code use static NeverDestroyed<T> instead.
3370
3371         * DumpRenderTree/JavaScriptThreading.cpp:
3372         (javaScriptThreadsMutex):
3373         (javaScriptThreads):
3374         * DumpRenderTree/efl/EventSender.cpp:
3375         (touchPointList):
3376         (delayedEventQueue):
3377         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3378         (delegatesWithDelayedWork):
3379         * Scripts/check-for-exit-time-destructors:
3380         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3381         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3382         (testsMap):
3383
3384 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3385
3386         [EFL][WK2] Fix compilation warning in Minibrowser
3387         https://bugs.webkit.org/show_bug.cgi?id=130132
3388
3389         Reviewed by Csaba Osztrogonác.
3390
3391         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3392
3393         * MiniBrowser/efl/main.c:
3394         (on_download_request):
3395
3396 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3397
3398         FTL should support IsBlah
3399         https://bugs.webkit.org/show_bug.cgi?id=130202
3400
3401         Reviewed by Geoffrey Garen.
3402         
3403         Running existing JSRegress tests with noInline gives us coverage for these
3404         changes. Chances are, this will also give coverage for other interesting things
3405         as well.
3406
3407         * Scripts/run-jsc-stress-tests:
3408
3409 2014-03-12  Brian Burg  <bburg@apple.com>
3410
3411         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3412         https://bugs.webkit.org/show_bug.cgi?id=129744
3413
3414         Reviewed by Timothy Hatcher.
3415
3416         * DumpRenderTree/TestRunner.cpp:
3417         (evaluateInWebInspectorCallback):
3418         * DumpRenderTree/TestRunner.h:
3419         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3420         (TestRunner::evaluateInWebInspector):
3421         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3422         (TestRunner::evaluateInWebInspector):
3423         * DumpRenderTree/mac/TestRunnerMac.mm:
3424         (TestRunner::evaluateInWebInspector):
3425         * DumpRenderTree/win/TestRunnerWin.cpp:
3426         (TestRunner::evaluateInWebInspector):
3427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3428         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3429         (WTR::TestRunner::evaluateInWebInspector):
3430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3431
3432 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3433
3434         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3435         https://bugs.webkit.org/show_bug.cgi?id=130129
3436
3437         Reviewed by Csaba Osztrogonác.
3438
3439         * Scripts/webkitdirs.pm:
3440         (canUseNinja): Redirecting stderr to /dev/null
3441
3442 2014-03-13  Andres Gomez  <agomez@igalia.com>
3443
3444         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3445         https://bugs.webkit.org/show_bug.cgi?id=130092
3446
3447         Reviewed by Csaba Osztrogonác.
3448
3449         Added "python-dev" as dependency for deb based distros. It is
3450         already present for rpm based distros. This dependency will allow
3451         libxml2 to generate its python bindings, needed by gtk-doc.
3452
3453         * gtk/install-dependencies:
3454
3455 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3456
3457         Unreviewed. Fix GTK+ cmake build after r165488.
3458
3459         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3460
3461 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3462
3463         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3464         https://bugs.webkit.org/show_bug.cgi?id=130014
3465
3466         Reviewed by Martin Robinson.
3467
3468         Include cmake or autotools config header.
3469
3470         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3471         * MiniBrowser/gtk/BrowserSearchBar.c:
3472         * MiniBrowser/gtk/BrowserWindow.c:
3473         * MiniBrowser/gtk/main.c:
3474
3475 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3476
3477         Unreviewed, rolling out r165471.
3478         https://bugs.webkit.org/show_bug.cgi?id=130139
3479
3480         Didn't really fix the issue and broke another bot (Requested
3481         by mrobinson on #webkit).
3482
3483         Reverted changeset:
3484
3485         "[CMake] Newer versions of CMake cannot find older versions of
3486         Freetype"
3487         https://bugs.webkit.org/show_bug.cgi?id=130107
3488         http://trac.webkit.org/changeset/165471
3489
3490 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3491
3492         It should be possible to build WebKit with FTL on iOS
3493         https://bugs.webkit.org/show_bug.cgi?id=130116
3494
3495         Reviewed by Dan Bernstein.
3496
3497         * Scripts/build-webkit:
3498         * Scripts/copy-webkitlibraries-to-product-directory:
3499
3500 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3501
3502         [Win] Remove use of QTSDK
3503         https://bugs.webkit.org/show_bug.cgi?id=130049
3504
3505         Reviewed by Darin Adler.
3506
3507         * DumpRenderTree/win/DumpRenderTree.cpp:
3508         (initialize): Remove QuickTime code.
3509         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3510         building QTMovieWin.
3511
3512 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3513
3514         [GTK][CMAKE] Too verbose build output
3515         https://bugs.webkit.org/show_bug.cgi?id=130076
3516
3517         Reviewed by Carlos Garcia Campos.
3518
3519         Instead of building with cmake --build which isn't smart about pretty printing and
3520         colors, we build with a script which calls the proper build command.
3521
3522         * Scripts/webkitdirs.pm:
3523         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3524         the CMake configuration pass.
3525
3526 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3527
3528         [CMake] Newer versions of CMake cannot find older versions of Freetype
3529         https://bugs.webkit.org/show_bug.cgi?id=130107
3530
3531         Reviewed by Gustavo Noronha Silva.
3532
3533         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3534         to CMake during jhbuild initialization.
3535
3536 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3537
3538         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3539         https://bugs.webkit.org/show_bug.cgi?id=129961
3540
3541         Reviewed by Simon Fraser.
3542
3543         Now scaled content can go through the window capturing mechanism too for compositing content.
3544         AppleMagnifiedMode is redundant.
3545
3546         * DumpRenderTree/mac/DumpRenderTree.mm:
3547         (setDefaultsToConsistentValuesForTesting):
3548         (runTest):
3549         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3550         (createBitmapContextFromWebView):
3551         * WebKitTestRunner/PlatformWebView.h:
3552         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3553         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3554         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3555         (WTR::PlatformWebView::didInitializeClients):
3556         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3557         (WTR::PlatformWebView::forceWindowFramesChanged):
3558         * WebKitTestRunner/mac/main.mm:
3559         (setDefaultsToConsistentValuesForTesting):
3560
3561 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3562
3563         Unreviewed. Add myself as a committer.
3564
3565         * Scripts/webkitpy/common/config/contributors.json:
3566
3567 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3568
3569         Unreviewed build fix on the EFL port when used lower version of ATK
3570
3571         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3572         (WTR::AccessibilityUIElement::y): Fixed typo.
3573
3574 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3575
3576         Some images are blank in the rebaseline server UI
3577         https://bugs.webkit.org/show_bug.cgi?id=130104
3578
3579         Reviewed by Tim Horton.
3580
3581         Let the server check for images in the 'retries' directory
3582         if it can't find an image otherwise.
3583
3584         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3585         (RebaselineHTTPRequestHandler.test_result):
3586
3587 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3588
3589         [GTK][CMake] --update-gtk has no effect
3590         https://bugs.webkit.org/show_bug.cgi?id=130088
3591
3592         Reviewed by Philippe Normand.
3593
3594         * Scripts/webkitdirs.pm:
3595         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3596         as an argument.
3597
3598 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3599
3600         Add "System Font" to the list of whitelisted DRT fonts
3601         https://bugs.webkit.org/show_bug.cgi?id=130046
3602
3603         Reviewed by Darin Adler.
3604
3605         * DumpRenderTree/mac/DumpRenderTree.mm:
3606         (allowedFontFamilySet):
3607         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3608
3609 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3610
3611         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3612         https://bugs.webkit.org/show_bug.cgi?id=130064
3613
3614         Reviewed by Philippe Normand.
3615
3616         * efl/jhbuildrc: Remove duplicated code.
3617         * gtk/jhbuildrc: Remove duplicated code.
3618         * jhbuild/jhbuildrc_common.py:
3619         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3620         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3621         and is apparently necessary for GTK+.
3622
3623 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3624
3625         check-webkit-style failed to complain about missing braces
3626         https://bugs.webkit.org/show_bug.cgi?id=34189
3627
3628         Reviewed by Ryosuke Niwa.
3629
3630         * Scripts/webkitpy/style/checkers/cpp.py:
3631         (check_braces):
3632         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3633         (WebKitStyleTest.test_braces):
3634
3635 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3636
3637         Remove Qt cruft from style checker.
3638         https://bugs.webkit.org/show_bug.cgi?id=130085
3639
3640         Reviewed by Csaba Osztrogonác.
3641
3642         There is no 'foreach' keyword in c++. That was a Qt feature
3643         added in: http://trac.webkit.org/changeset/46113
3644         Qt was removed from WebKit, so we should remove the checks
3645         of this keyword from check-webkit-style scripts.
3646
3647         * Scripts/webkitpy/style/checkers/cpp.py:
3648         (check_spacing_for_function_call):
3649         (check_spacing):
3650         (check_braces):
3651         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3652         (CppStyleTest.test_mismatching_spaces_in_parens):
3653         (CppStyleTest.test_spacing_for_fncall):
3654         (WebKitStyleTest.test_braces):
3655
3656 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3657
3658         [GTK] update-webkitgtk-libs needs itstool
3659         https://bugs.webkit.org/show_bug.cgi?id=130082
3660
3661         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3662         itstool is a dependency of building gtk-doc from version 1.19, so it should
3663         be added to Tools/gtk/install-dependencies script, too.
3664
3665         Reviewed by Philippe Normand.
3666
3667         * gtk/install-dependencies:
3668
3669 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3670
3671         webkitbot rollout ChangeLogs should be nicer
3672         https://bugs.webkit.org/show_bug.cgi?id=122654
3673
3674         Reviewed by Csaba Osztrogonác.
3675
3676         Added bug urls and descriptions of rolled out patches to the&