be743080b425f5fec0f044ba341623ab653dd5f4
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2
3         Log stack-trace for run-webkit-tests when interrupted
4         https://bugs.webkit.org/show_bug.cgi?id=176393
5         <rdar://problem/34262310>
6
7         Reviewed by Lucas Forschler.
8
9         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
10         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
11         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
12         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
13         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
14         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15         (main): Set handlers to log stack trace on interruption.
16
17 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
18
19         AX: Support API: accessibilityReplaceRange:withText
20         https://bugs.webkit.org/show_bug.cgi?id=196636
21
22         Unreviewed build fix for Windows port.
23
24         * DumpRenderTree/AccessibilityUIElement.cpp:
25         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
26
27 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
28
29         [ews-build] Scripts using Buildbot API have CORS error
30         https://bugs.webkit.org/show_bug.cgi?id=196709
31
32         Reviewed by Alexey Proskuryakov.
33
34         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
35
36 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
37
38         AX: Support API: accessibilityReplaceRange:withText
39         https://bugs.webkit.org/show_bug.cgi?id=196636
40
41         Reviewed by Daniel Bates.
42
43         * DumpRenderTree/AccessibilityUIElement.cpp:
44         (replaceTextInRangeCallback):
45         (AccessibilityUIElement::replaceTextInRange):
46         (AccessibilityUIElement::getJSClass):
47         * DumpRenderTree/AccessibilityUIElement.h:
48         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
49         (AccessibilityUIElement::replaceTextInRange):
50         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
51         (AccessibilityUIElement::replaceTextInRange):
52         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
53         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
54         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
55         (WTR::AccessibilityUIElement::replaceTextInRange):
56         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
57         (WTR::AccessibilityUIElement::replaceTextInRange):
58
59 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
60
61         [iOS] Do not allow starting selection drags when selection views are not visible
62         https://bugs.webkit.org/show_bug.cgi?id=196686
63         <rdar://problem/49399192>
64
65         Reviewed by Tim Horton.
66
67         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
68         also add some new API tests to cover scenarios where the web view is not first responder.
69
70         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
71         (TestWebKitAPI::TEST):
72         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
73
74         Add a switch to optionally make the web view first responder when starting the simulated drag.
75
76         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
77         (-[DragAndDropSimulator initWithWebView:]):
78         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
79
80 2019-04-08  Justin Fan  <justin_fan@apple.com>
81
82         [Web GPU] Fix Web GPU experimental feature on iOS
83         https://bugs.webkit.org/show_bug.cgi?id=196632
84
85         Reviewed by Myles C. Maxfield.
86
87         Properly make Web GPU available on iOS 11+.
88
89         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
90
91 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
92
93         [ews-build] Do not upload archive when Compile Fails
94         https://bugs.webkit.org/show_bug.cgi?id=196674
95
96         Reviewed by Alexey Proskuryakov.
97
98         * BuildSlaveSupport/ews-build/factories.py:
99         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
100         * BuildSlaveSupport/ews-build/steps.py:
101         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
102         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
103         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
104
105 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
106
107         Enable DFG on MIPS
108         https://bugs.webkit.org/show_bug.cgi?id=196689
109
110         Reviewed by Žan Doberšek.
111
112         Since the bytecode change, we enabled the baseline JIT on mips in
113         r240432, but DFG is still missing. With this change, all tests are
114         passing on a ci20 board.
115
116         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
117
118 2019-04-08  Philippe Normand  <pnormand@igalia.com>
119
120         [Flatpak] Second run update-webkitwpe-flatpak fails
121         https://bugs.webkit.org/show_bug.cgi?id=192702
122
123         Reviewed by Carlos Garcia Campos.
124
125         * flatpak/flatpakutils.py:
126         (FlatpakObject.flatpak): Fix typo.
127         (FlatpakPackage.install): When installing, also update to the configured remote commit.
128         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
129
130 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
131
132         [GTK][WPE] outlook.live.com displays old-fashioned UI
133         https://bugs.webkit.org/show_bug.cgi?id=196642
134
135         Reviewed by Carlos Garcia Campos.
136
137         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
138         (TestWebKitAPI::TEST): New Mac platform quirk test.
139
140 2019-04-07  Commit Queue  <commit-queue@webkit.org>
141
142         Unreviewed, rolling out r243956.
143         https://bugs.webkit.org/show_bug.cgi?id=196688
144
145         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
146         by aakashjain on #webkit).
147
148         Reverted changeset:
149
150         "Clicking "Go Back" from a safe browsing warning from an
151         iframe should navigate the WKWebView back to the previous
152         page"
153         https://bugs.webkit.org/show_bug.cgi?id=196665
154         https://trac.webkit.org/changeset/243956
155
156 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
157
158         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
159         https://bugs.webkit.org/show_bug.cgi?id=196669
160
161         Reviewed by Geoffrey Garen.
162
163         Added three new unit tests for WeakHashSet.
164
165         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
166         (WTF_WeakPtr.WeakHashSetConstObjects):
167         (WTF_WeakPtr.WeakHashSetComputesEmpty):
168         (WTF_WeakPtr.WeakHashSetComputeSize):
169
170 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
171
172         Hide next and previous form control buttons when WKWebView is editable
173         https://bugs.webkit.org/show_bug.cgi?id=196672
174         <rdar://problem/35625321>
175
176         Reviewed by Tim Horton.
177
178         Add a new API test.
179
180         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
181         (-[TestWKWebView lastTrailingBarButtonGroup]):
182         (TestWebKitAPI::TEST):
183         * TestWebKitAPI/ios/UIKitSPI.h:
184
185 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
186
187         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
188         https://bugs.webkit.org/show_bug.cgi?id=196077
189         <rdar://problem/49108202>
190
191         Reviewed by Chris Dumez.
192
193         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
194         on new web view.
195
196         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
197
198 2019-04-05  Saam Barati  <sbarati@apple.com>
199
200         Make compare-results understand MotionMark
201         https://bugs.webkit.org/show_bug.cgi?id=196666
202
203         Reviewed by Yusuke Suzuki.
204
205         * Scripts/compare-results:
206         (PLT5Results):
207         (detectMotionMark):
208         (detectMotionMark1_1):
209         (motionMarkResults):
210         (motionMark1_1Results):
211         (detectBenchmark):
212         (biggerIsBetter):
213         (main):
214
215 2019-04-05  Alex Christensen  <achristensen@webkit.org>
216
217         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
218         https://bugs.webkit.org/show_bug.cgi?id=196665
219         <rdar://45115669>
220
221         Reviewed by Geoff Garen.
222
223         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
224         (goBack):
225         (+[SimpleLookupContext sharedLookupContext]):
226         (-[SimpleLookupContext lookUpURL:completionHandler:]):
227         (TEST):
228         (+[Simple3LookupContext sharedLookupContext]): Deleted.
229         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
230
231 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
232
233         [ews-build] Add configuration and architecture for windows builders
234         https://bugs.webkit.org/show_bug.cgi?id=196660
235
236         Reviewed by Lucas Forschler.
237
238         * BuildSlaveSupport/ews-build/config.json:
239
240 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
241
242         webkitpy: Don't run subsequent rounds if interrupted
243         https://bugs.webkit.org/show_bug.cgi?id=196646
244
245         Reviewed by Aakash Jain.
246
247         * Scripts/webkitpy/layout_tests/controllers/manager.py:
248         (Manager.run): Bail out if interrupted.
249
250 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
251
252         Test sessionStorage in PSON private browsing mode
253         https://bugs.webkit.org/show_bug.cgi?id=196561
254
255         Reviewed by Alex Christensen.
256
257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
258
259 2019-04-05  Commit Queue  <commit-queue@webkit.org>
260
261         Unreviewed, rolling out r243833.
262         https://bugs.webkit.org/show_bug.cgi?id=196645
263
264         This change breaks build of WPE and GTK ports (Requested by
265         annulen on #webkit).
266
267         Reverted changeset:
268
269         "[CMake][WTF] Mirror XCode header directories"
270         https://bugs.webkit.org/show_bug.cgi?id=191662
271         https://trac.webkit.org/changeset/243833
272
273 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
274
275         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
276         https://bugs.webkit.org/show_bug.cgi?id=196635
277
278         Reviewed by Antti Koivisto.
279         
280         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
281         for a test to enable async frame scrolling via:
282             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
283         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
284         
285         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
286
287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
288         (WTR::InjectedBundle::beginTesting):
289         * WebKitTestRunner/TestController.cpp:
290         (WTR::TestController::resetPreferencesToConsistentValues):
291
292 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
293
294         Use a correct LC_RPATH when building with ASan
295         https://bugs.webkit.org/show_bug.cgi?id=196576
296
297         Reviewed by David Kilzer.
298
299         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
300         so that ../Frameworks is checked. This is simpler and more reliable than updating
301         each SPC service xcconfig.
302
303 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
304
305         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
306         https://bugs.webkit.org/show_bug.cgi?id=196629
307
308         Reviewed by Lucas Forschler.
309
310         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
311
312 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
315         https://bugs.webkit.org/show_bug.cgi?id=196618
316
317         Reviewed by Lucas Forschler.
318
319         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
320         (StatusBubble): Added QUEUE_TRIGGERS.
321         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
322         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
323         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
324         its parent(builder).
325
326 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
327
328         [ews-app] Status-bubble steps are sometimes displayed in reverse order
329         https://bugs.webkit.org/show_bug.cgi?id=196625
330
331         Reviewed by Lucas Forschler.
332
333         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
334         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
335
336 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
337
338         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
339         https://bugs.webkit.org/show_bug.cgi?id=196630
340
341         Reviewed by Wenson Hsieh.
342
343         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
344
345 2019-04-04  Youenn Fablet  <youenn@apple.com>
346
347         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
348         https://bugs.webkit.org/show_bug.cgi?id=196543
349
350         Reviewed by Alex Christensen.
351
352         * WebKitTestRunner/TestController.cpp:
353         (WTR::TestController::generatePageConfiguration):
354
355 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
356
357         [ews-app] Status bubble should not display skipped buildbot steps
358         https://bugs.webkit.org/show_bug.cgi?id=196584
359
360         Reviewed by Lucas Forschler.
361
362         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
363
364 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
365
366         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
367         https://bugs.webkit.org/show_bug.cgi?id=196620
368
369         Reviewed by Lucas Forschler.
370
371         * BuildSlaveSupport/ews-app/ews/config.py:
372
373 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
374
375         [Win] DumpRenderTreeWatchDog.py is not checked into source
376         https://bugs.webkit.org/show_bug.cgi?id=196567
377         <rdar://problem/49525901>
378
379         Reviewed by Lucas Forschler.
380
381         This script is used on Win EWS bots to terminate hanging DRT processes.
382
383         * EWSTools/dumprendertreewatchdog.py: Added.
384
385 2019-04-04  Chris Dumez  <cdumez@apple.com>
386
387         Unreviewed, roll out r243858 which made tests time out.
388
389         Disable new API tests on Windows instead.
390
391         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
392         (TestWebKitAPI::TEST):
393
394 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
395
396         [ATK] Cleanup WebPageAccessibilityObjectAtk
397         https://bugs.webkit.org/show_bug.cgi?id=196537
398
399         Reviewed by Michael Catanzaro.
400
401         Also consider files under atk directories as exceptions for GObject conventions.
402
403         * Scripts/webkitpy/style/checkers/cpp.py:
404         (check_identifier_name_in_declaration):
405
406 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
407
408         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
409         https://bugs.webkit.org/show_bug.cgi?id=196588
410         <rdar://problem/49365787>
411
412         Unreviewed build fix for Windows port.
413
414         error C3861: 'kill': identifier not found
415
416         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
417         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
418
419 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
420
421         [ews-build] Cancel build and similar operations should have authentication
422         https://bugs.webkit.org/show_bug.cgi?id=196520
423
424         Reviewed by Dewei Zhu.
425
426         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
427         environment variables.
428
429 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
430
431         [ews-build] Do not trigger queues which are not in production yet
432         https://bugs.webkit.org/show_bug.cgi?id=196581
433
434         Reviewed by Dewei Zhu.
435
436         * BuildSlaveSupport/ews-build/config.json:
437
438 2019-04-03  Chris Dumez  <cdumez@apple.com>
439
440         Unreviewed, fix typo in the name of API test added in r243848.
441
442         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
443         (TestWebKitAPI::TEST):
444
445 2019-04-03  Chris Dumez  <cdumez@apple.com>
446
447         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
448         https://bugs.webkit.org/show_bug.cgi?id=196588
449         <rdar://problem/49365787>
450
451         Reviewed by Ryosuke Niwa.
452
453         Add API test coverage.
454
455         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
456         (TestWebKitAPI::nullJavaScriptCallback):
457         (TestWebKitAPI::didCrashCheckFrames):
458         (TestWebKitAPI::TEST):
459
460 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
461
462         run-webkit-tests: Upload test results (new results database)
463         https://bugs.webkit.org/show_bug.cgi?id=196577
464         <rdar://problem/34841155>
465
466         Reviewed by Lucas Forschler.
467
468         * Scripts/webkitpy/layout_tests/controllers/manager.py:
469         (Manager.run): Upload results after each device shard, since the configuration will be
470         different for each device.
471         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
472         uploaded to a results database.
473         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
474         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
475
476 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
477
478         -apple-trailing-word is needed for browser detection
479         https://bugs.webkit.org/show_bug.cgi?id=196575
480
481         Unreviewed.
482
483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
484
485 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
486
487         [CMake][WTF] Mirror XCode header directories
488         https://bugs.webkit.org/show_bug.cgi?id=191662
489
490         Reviewed by Konstantin Tokarev.
491
492         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
493         builds.
494
495         * CMakeLists.txt:
496         * DumpRenderTree/CMakeLists.txt:
497         * DumpRenderTree/PlatformWin.cmake:
498         * MiniBrowser/win/CMakeLists.txt:
499         * TestWebKitAPI/CMakeLists.txt:
500         * TestWebKitAPI/PlatformWin.cmake:
501         * WebKitTestRunner/PlatformGTK.cmake:
502         * WebKitTestRunner/PlatformWin.cmake:
503
504 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
505
506         [ews-app] Status bubble should not display certain infrastructure status messages
507         https://bugs.webkit.org/show_bug.cgi?id=196550
508
509         Reviewed by Lucas Forschler.
510
511         Do not display the steps which are un-needed for end-user. This information is still avaiable
512         if the user click on the bubble and look at the Buildbot build.
513         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
514         (StatusBubble._steps_messages):
515         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
516
517 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-build] Use https for sending data to ews-app
520         https://bugs.webkit.org/show_bug.cgi?id=196492
521
522         Reviewed by Lucas Forschler.
523
524         * BuildSlaveSupport/ews-build/events.py:
525
526 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
527
528         Remove support for -apple-trailing-word
529         https://bugs.webkit.org/show_bug.cgi?id=196525
530
531         Reviewed by Zalan Bujtas.
532
533         This CSS property is nonstandard and not used.
534
535         * Scripts/webkitperl/FeatureList.pm:
536         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
537
538 2019-04-03  Youenn Fablet  <youenn@apple.com>
539
540         Add a test for DOMCache on multiple browsing in case of private browsing
541         https://bugs.webkit.org/show_bug.cgi?id=196524
542
543         Reviewed by Alex Christensen.
544
545         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
546         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
547
548 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
549
550         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
551         https://bugs.webkit.org/show_bug.cgi?id=196540
552
553         Reviewed by Aakash Jain.
554
555         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
556
557 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
558
559         Add plumbing for a compatibility mode preference in WebKit
560         https://bugs.webkit.org/show_bug.cgi?id=196005
561
562         Reviewed by Tim Horton.
563
564         Add new API tests.
565
566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
567         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
568
569 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
570
571         [WPE][GTK] Update libsrtp dependency package for Debian
572         https://bugs.webkit.org/show_bug.cgi?id=196528
573
574         Reviewed by Frédéric Wang.
575
576         * gtk/install-dependencies:
577         * wpe/install-dependencies:
578
579 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
580
581         [WK2] Add support for Window's beforeprint / afterprint events
582         https://bugs.webkit.org/show_bug.cgi?id=196478
583         <rdar://problem/49535124>
584
585         Unreviewed build fix for MSVC.
586
587         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
588
589         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
590
591         * WebKitTestRunner/TestController.cpp:
592         (WTR::printFrame): Use int and float literals.
593
594 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
595
596         [ews-build] Reassign bots to queues
597
598         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
599
600 2019-04-02  Chris Dumez  <cdumez@apple.com>
601
602         [WK2] Add support for Window's beforeprint / afterprint events
603         https://bugs.webkit.org/show_bug.cgi?id=196478
604
605         Reviewed by Alex Christensen.
606
607         Add minimal implementation for printFrame in WebKitTestRunner.
608
609         * WebKitTestRunner/TestController.cpp:
610         (WTR::printFrame):
611         (WTR::TestController::createOtherPage):
612         (WTR::TestController::createWebViewWithOptions):
613
614 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
615
616         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
617         https://bugs.webkit.org/show_bug.cgi?id=196491
618
619         Reviewed by Lucas Forschler.
620
621         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
622
623 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
624
625         [ews-build] Configure buildbot try credentials in environment variables
626         https://bugs.webkit.org/show_bug.cgi?id=196501
627
628         Reviewed by Lucas Forschler.
629
630         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
631         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
632         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
633
634 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
635
636         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
637         https://bugs.webkit.org/show_bug.cgi?id=196496
638         <rdar://problem/49521634>
639
640         Reviewed by Chris Dumez.
641
642         Add new API tests (see WebKit ChangeLog for more detail).
643
644         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
645         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
646         (TEST):
647
648 2019-04-02  David Kilzer  <ddkilzer@apple.com>
649
650         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
651         <https://webkit.org/b/196499>
652
653         Reviewed by Alexey Proskuryakov.
654
655         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
656         ENABLE_ADDRESS_SANITIZER.
657
658 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
659
660         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
661         https://bugs.webkit.org/show_bug.cgi?id=182757
662
663         Reviewed by Don Olmstead.
664
665         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
666         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
667
668 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
669
670         run-api-tests: Upload test results
671         https://bugs.webkit.org/show_bug.cgi?id=196323
672         <rdar://problem/49356714>
673
674         Reviewed by Lucas Forschler.
675
676         * Scripts/webkitpy/api_tests/manager.py:
677         (Manager):
678         (Manager.run): Upload results to a results database.
679         * Scripts/webkitpy/api_tests/run_api_tests.py:
680         (parse_args): Add upload arguments.
681         * Scripts/webkitpy/port/base.py:
682         (Port):
683         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
684         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
685         with commits from any other associated repositories.
686         * Scripts/webkitpy/port/device.py:
687         (Device):
688         (Device.build_version): Access build_versoin of underlying platform device.
689         * Scripts/webkitpy/port/ios_simulator_unittest.py:
690         (IOSSimulatorTest):
691         (IOSSimulatorTest.test_configuration_for_upload):
692         * Scripts/webkitpy/port/device_port.py:
693         (DevicePort):
694         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
695         the same as the machine uploading results.
696         * Scripts/webkitpy/port/mac.py:
697         (MacPort):
698         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
699         * Scripts/webkitpy/port/mac_unittest.py:
700         (MacTest):
701         (MacTest.test_configuration_for_upload):
702         * Scripts/webkitpy/xcode/simulated_device.py:
703         (SimulatedDeviceManager._create_device_with_runtime):
704         (SimulatedDevice.__init__): Create simulated device with a build_version.
705         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
706         (test_existing_simulator):
707
708 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
709
710         Remove extra newline characters (Follow-up fix to r243707)
711
712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
713
714 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
715
716         [ews-app] Use API_KEY to accept results data
717         https://bugs.webkit.org/show_bug.cgi?id=196461
718
719         Reviewed by Dewei Zhu.
720
721         * BuildSlaveSupport/ews-app/ews/views/results.py:
722         (Results.post): Validate EWS_API_KEY before accepting any data.
723         * BuildSlaveSupport/ews-build/events.py:
724         (Events.sendData): Send EWS_API_KEY if available along with event data.
725
726 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
727
728         Unable to copy and paste a PDF from Notes into Mail compose body
729         https://bugs.webkit.org/show_bug.cgi?id=196442
730         <rdar://problem/48573098>
731
732         Reviewed by Tim Horton.
733
734         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
735         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
736         to be specified on the item providers.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
739         (TestWebKitAPI::mapItemForTesting):
740         (TestWebKitAPI::contactItemForTesting):
741
742 2019-04-01  Tim Horton  <timothy_horton@apple.com>
743
744         Make UIWKDocumentContext rects per-character instead of per-word
745         https://bugs.webkit.org/show_bug.cgi?id=196459
746
747         Reviewed by Wenson Hsieh.
748
749         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
750         (TEST):
751         Adjust test results due to switching to per-character rects.
752
753 2019-04-01  Chris Dumez  <cdumez@apple.com>
754
755         UIProcess crash when a prewarmed process is terminated
756         https://bugs.webkit.org/show_bug.cgi?id=196451
757         <rdar://problem/49245471>
758
759         Reviewed by Geoffrey Garen.
760
761         Add API test coverage.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
764         (TEST):
765
766 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
767
768         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
769         https://bugs.webkit.org/show_bug.cgi?id=196449
770
771         Reviewed by Lucas Forschler.
772
773         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
774         (StatusBubble.get_os_details): Method to get OS and Xcode details.
775         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
776         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
777
778 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
779
780         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
781         https://bugs.webkit.org/show_bug.cgi?id=196444
782
783         Reviewed by Lucas Forschler.
784
785         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
786
787 2019-04-01  Alex Christensen  <achristensen@webkit.org>
788
789         Add SPI to canonicalize NSURLs with WTF::URL
790         https://bugs.webkit.org/show_bug.cgi?id=196415
791         <rdar://problem/44980271>
792
793         Reviewed by Darin Adler.
794
795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
796         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
797         (TestWebKitAPI::TEST):
798
799 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
800
801         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
802         https://bugs.webkit.org/show_bug.cgi?id=196441
803
804         Reviewed by Carlos Garcia Campos.
805
806         Don't cache the wpe_view_backend object that might not exist yet at the
807         time of EventSenderProxy constructor invocation, but instead retrieve
808         that object whenever it's required for event dispatching. This should
809         avoid crashes in this constructor now that it's invoked before any
810         PlatformWindow has been set up (as changed in r243496).
811
812         * WebKitTestRunner/EventSenderProxy.h:
813         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
814         (WTR::viewBackend):
815         (WTR::EventSenderProxy::EventSenderProxy):
816         (WTR::EventSenderProxy::mouseDown):
817         (WTR::EventSenderProxy::mouseUp):
818         (WTR::EventSenderProxy::mouseMoveTo):
819         (WTR::EventSenderProxy::mouseScrollBy):
820         (WTR::EventSenderProxy::keyDown):
821         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
822
823 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
824
825         [Win][WebKit] MiniBrowser should support high DPI display
826         https://bugs.webkit.org/show_bug.cgi?id=196391
827
828         Reviewed by Alex Christensen.
829
830         * MiniBrowser/win/WebKitBrowserWindow.cpp:
831         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
832         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
833         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
834
835 2019-03-31  Sam Weinig  <weinig@apple.com>
836
837         Remove more i386 specific configurations
838         https://bugs.webkit.org/show_bug.cgi?id=196430
839
840         Reviewed by Alexey Proskuryakov.
841
842         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
843         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
844
845 2019-03-31  Andy Estes  <aestes@apple.com>
846
847         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
848         https://bugs.webkit.org/show_bug.cgi?id=196433
849         <rdar://problem/49293305>
850
851         Reviewed by Tim Horton.
852
853         Enhanced API test coverage to include all navigation response policy decisions in both
854         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
855
856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
857         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
858         (TestWebKitAPI::TEST):
859         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
860         (readFile):
861         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
862         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
863         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
864         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
865         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
866         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
867         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
868         (-[QuickLookDelegate _downloadDidStart:]):
869         (-[QuickLookDelegate _download:didReceiveResponse:]):
870         (-[QuickLookDelegate _download:didReceiveData:]):
871         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
872         (-[QuickLookDelegate _downloadDidFinish:]):
873         (-[QuickLookDelegate _download:didFailWithError:]):
874         (-[QuickLookDelegate _downloadDidCancel:]):
875         (-[QuickLookDelegate verifyDownload]):
876         (runTest):
877         (runTestDecideBeforeLoading):
878         (runTestDecideAfterLoading):
879         (TEST):
880         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
881         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
882         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
883         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
884         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
885         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
886         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
887         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
888         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
889         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
890         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
891         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
892         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
893         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
894
895 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
896
897         [CMake] add testdfg as target with build-jsc
898         https://bugs.webkit.org/show_bug.cgi?id=196393
899
900         Reviewed by Saam Barati.
901
902         Added testdfg as one of the targets to build when
903         using CMake.
904
905         * Scripts/build-jsc:
906
907 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
908
909         Delete WebMetal implementation in favor of WebGPU
910         https://bugs.webkit.org/show_bug.cgi?id=195418
911
912         Reviewed by Dean Jackson.
913
914         * DumpRenderTree/mac/DumpRenderTree.mm:
915         (enableExperimentalFeatures):
916         (resetWebPreferencesToConsistentValues):
917         * Scripts/webkitperl/FeatureList.pm:
918         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
920         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
921         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
922         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
923         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
924         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
925         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
926         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
927         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
928         (WTR::InjectedBundle::beginTesting):
929         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
930         (WTR::TestRunner::setWebMetalEnabled): Deleted.
931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
932
933 2019-03-29  Chris Dumez  <cdumez@apple.com>
934
935         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
936         https://bugs.webkit.org/show_bug.cgi?id=196405
937         <rdar://problem/49428130>
938
939         Reviewed by Wenson Hsieh.
940
941         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
942         the popover presentation methods to be no-ops. Use this in the new test added in
943         r243523 so that we do not swizzle those methods for all tests. This is needed because
944         those WatchOS tests rely on the popover getting presented and interactive.
945
946         * WebKitTestRunner/TestController.cpp:
947         (WTR::updateTestOptionsFromTestHeader):
948         * WebKitTestRunner/TestController.h:
949         * WebKitTestRunner/TestOptions.h:
950         (WTR::TestOptions::hasSameInitializationOptions const):
951         * WebKitTestRunner/ios/TestControllerIOS.mm:
952         (WTR::TestController::platformInitialize):
953         (WTR::TestController::platformResetStateToConsistentValues):
954
955 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
956
957         [Curl] Add Server Trust Evaluation Support.
958         https://bugs.webkit.org/show_bug.cgi?id=191646
959
960         Reviewed by Fujii Hironori.
961
962         Implemented MiniBrowser UI for asking if user trusts the server.
963
964         * MiniBrowser/win/Common.cpp:
965         (askServerTrustEvaluation):
966         (replaceString):
967         * MiniBrowser/win/Common.h:
968         * MiniBrowser/win/MiniBrowserLib.rc:
969         * MiniBrowser/win/MiniBrowserLibResource.h:
970         * MiniBrowser/win/WebKitBrowserWindow.cpp:
971         (createPEMString):
972         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
973         (WebKitBrowserWindow::canTrustServerCertificate):
974         * MiniBrowser/win/WebKitBrowserWindow.h:
975
976 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
977
978         Implement ResizeObserver.
979         https://bugs.webkit.org/show_bug.cgi?id=157743
980
981         Reviewed by Simon Fraser.
982
983         Support resizeObserverEnabled webPreferences.
984
985         * DumpRenderTree/TestOptions.cpp:
986         (TestOptions::TestOptions):
987         * DumpRenderTree/TestOptions.h:
988         * DumpRenderTree/mac/DumpRenderTree.mm:
989         (setWebPreferencesForTestOptions):
990         * DumpRenderTree/win/DumpRenderTree.cpp:
991         (enableExperimentalFeatures):
992         * Scripts/webkitperl/FeatureList.pm:
993         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
994
995 2019-03-28  John Wilander  <wilander@apple.com>
996
997         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
998         https://bugs.webkit.org/show_bug.cgi?id=196281
999         <rdar://problem/48938748>
1000
1001         Reviewed by Alex Christensen.
1002
1003         This patch adds the function isStatisticsHasLocalStorage() to the
1004         TestRunner. With it, the page can query the WebsiteDataStore in the
1005         UI process to make sure that it sees LocalStorage.
1006
1007         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1008         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1009         (WTR::TestRunner::isStatisticsHasLocalStorage):
1010         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1011         * WebKitTestRunner/TestController.cpp:
1012         (WTR::TestController::isStatisticsHasLocalStorage):
1013         * WebKitTestRunner/TestController.h:
1014         * WebKitTestRunner/TestInvocation.cpp:
1015         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1016
1017 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1018
1019         API::Data::createWithoutCopying should do a null check before calling CFRelease
1020         https://bugs.webkit.org/show_bug.cgi?id=196276
1021         <rdar://problem/48059859>
1022
1023         Reviewed by Alex Christensen.
1024
1025         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1026
1027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1028         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1029         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1030         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1031         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1032         (TestWebKitAPI::TEST):
1033
1034 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1035
1036         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1037         https://bugs.webkit.org/show_bug.cgi?id=186276
1038
1039         Reviewed by Carlos Garcia Campos.
1040
1041         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1042         (webViewLoadChanged):
1043         (testWebResourceGetDataError):
1044         (testWebResourceGetDataEmpty):
1045         (beforeAll):
1046         (webViewloadChanged): Deleted.
1047
1048 2019-03-27  Andy Estes  <aestes@apple.com>
1049
1050         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1051         https://bugs.webkit.org/show_bug.cgi?id=196317
1052
1053         Reviewed by Dan Bernstein.
1054
1055         package-root copies built products into a staging directory using ditto(1), which does not
1056         follow symbolic links as it traverses a directory. Now that the files in
1057         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1058         itself, these become broken links when ditto'd into the staging directory.
1059
1060         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1061
1062         * Scripts/package-root:
1063
1064 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1065
1066         [ews-app] Update display text of Submit for ews analysis
1067         https://bugs.webkit.org/show_bug.cgi?id=196309
1068
1069         Reviewed by Dewei Zhu.
1070
1071         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1072
1073 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1074
1075         run-webkit-tests should check for leaks in WebKit processes
1076         <https://webkit.org/b/193772>
1077         <rdar://problem/46526680>
1078
1079         Reviewed by Ryosuke Niwa.
1080
1081         This works by doing the following:
1082         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1083           The list of child processes are returned one per line:
1084           process.name: pid
1085         - Run the "#LIST CHILD PROCESSES" command just before the
1086           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1087           processes on the ServerProcess object.
1088         - When the `--leaks` switch is handled, run check_for_leaks() on
1089           each child process after the main test harness.
1090
1091         * DumpRenderTree/mac/DumpRenderTree.mm:
1092         (handleControlCommand):
1093         - Use strncmp() instead of strcmp().
1094         - Add support for handling "#LIST CHILD PROCESSES" command.
1095
1096         * Scripts/webkitpy/port/base.py:
1097         (Port.check_for_leaks):
1098         * Scripts/webkitpy/port/darwin.py:
1099         (DarwinPort.check_for_leaks):
1100         - Rename redundant 'process_pid' argument to 'process_id'.
1101
1102         * Scripts/webkitpy/port/driver.py:
1103         (Driver.do_post_tests_work):
1104         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1105           longer the only command this sends to WebKitTestRunner.
1106         - If the `--leaks` switch is present, send the
1107           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1108           result using Port.set_webkit_processes().
1109         (Driver._parse_child_processes_output):
1110         - Add helper method to parse list of child process names and
1111           process IDs returned from WebKitTestRunner.
1112
1113         * Scripts/webkitpy/port/ios_device.py:
1114         (IOSDevicePort.check_for_leaks):
1115         - Rename redundant 'process_pid' argument to 'process_id'.
1116
1117         * Scripts/webkitpy/port/leakdetector.py:
1118         (LeakDetector._parse_leaks_output):
1119         - Return early if there is no leaks_output.
1120         (LeakDetector.check_for_leaks):
1121         - Rename redundant 'process_pid' argument to 'process_id'.
1122
1123         * Scripts/webkitpy/port/server_process.py:
1124         (ServerProcess.__init__):
1125         (ServerProcess.child_processes):
1126         (ServerProcess.set_child_processes):
1127         - Add instance variable to Port to store list of child process
1128           names and process IDs returned from WebKitTestRunner.
1129         (ServerProcess._start):
1130         - Clear self._child_processes.
1131         (ServerProcess.stop):
1132         - If self._child_processes is set, call
1133           self._port.check_for_leaks() for each child process.
1134
1135         * Scripts/webkitpy/port/server_process_unittest.py:
1136         (TrivialMockPort.check_for_leaks):
1137         - Rename redundant 'process_pid' argument to 'process_id'.
1138
1139         * Scripts/webkitpy/port/simulator_process.py:
1140         (SimulatorProcess.stop):
1141         - If self._child_processes is set, call
1142           self._port.check_for_leaks() for each child process.
1143
1144         * Scripts/webkitpy/port/watch_device.py:
1145         (WatchDevicePort.check_for_leaks):
1146         - Rename redundant 'process_pid' argument to 'process_id'.
1147
1148         * WebKitTestRunner/TestController.cpp:
1149         (WTR::TestController::dumpResponse):
1150         - Extract method from findAndDumpWorldLeaks() so that it may be
1151           reused by findAndDumpWebKitProcessIdentifiers().
1152         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1153         - Add method to output process name and process ID of both the
1154           WebContent and Networking processes.
1155         (WTR::TestController::findAndDumpWorldLeaks):
1156         - Fix missing newline in output when there were no abandoned
1157           documents.
1158         - Call dumpResponse() for extracted code.
1159         (WTR::TestController::handleControlCommand):
1160         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1161         - Use strncmp() instead of strcmp().
1162         - Call findAndDumpWebKitProcessIdentifiers() when
1163           "#LIST CHILD PROCESSES" command is sent.
1164         * WebKitTestRunner/TestController.h:
1165         (WTR::TestController::dumpResponse):
1166         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1167         - Declare methods.
1168
1169 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         Unreviewed. Add GLib API test cases after r243434.
1172
1173         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1174         (testWebViewActiveURI):
1175         (serverCallback):
1176         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1177         (sendRequestCallback):
1178
1179 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1180
1181         Geolocation request not complete when watch request was started in a different web process
1182         https://bugs.webkit.org/show_bug.cgi?id=195996
1183
1184         Reviewed by Alex Christensen.
1185
1186         Add a test case.
1187
1188         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1189         (TestWebKitAPI::runJavaScriptAlert):
1190         (TestWebKitAPI::TEST):
1191
1192 2019-03-26  Keith Rollin  <krollin@apple.com>
1193
1194         Update the way generate-xcfilelists returns strings from functions
1195         https://bugs.webkit.org/show_bug.cgi?id=195975
1196         <rdar://problem/49040807>
1197
1198         Reviewed by Dean Jackson.
1199
1200         There are places where generate-xcfilelists executes assignments with
1201         statements like:
1202
1203             FOO=$(some_function)
1204
1205         where "some_function" return a string by echoing it. E.g.
1206
1207             some_function()
1208             {
1209                 echo "Hello, World"
1210             }
1211
1212         This is a common idiom, but it has a problem if "some_function" needs
1213         to call "exit" in an attempt to halt the entire script right then and
1214         there. Since "some_function" is called inside of $(), it's being
1215         executed in a sub-shell. Calling exit in that sub-shell simply exits
1216         that shell; it doesn't not exit the outer shell in which the main part
1217         of the script is still running. As such, the main script keeps
1218         executing when the intent was for the script to halt.
1219
1220         The solution to this is to use a different idiom for returning
1221         strings. The one we now is to pass in the name of the variable to
1222         receive the string result:
1223
1224             some_function()
1225             {
1226                 variable_name=$1
1227                 eval $variable_name ="Hello, World"
1228             }
1229
1230         The call site now looks like
1231
1232             some_function FOO
1233
1234         Because there's no invocation of a sub-shell, some_function can now
1235         call "exit" if it wants to, and the entire script will exit at that
1236         point.
1237
1238         * Scripts/generate-xcfilelists:
1239
1240 2019-03-26  Chris Dumez  <cdumez@apple.com>
1241
1242         Add basic layout test coverage for File Picker on iOS
1243         https://bugs.webkit.org/show_bug.cgi?id=196265
1244
1245         Reviewed by Wenson Hsieh.
1246
1247         Add layout test infrastructure to test the file picker on iOS.
1248
1249         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1250         (WTR::UIScriptController::dismissFilePicker):
1251         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1252         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1253         (WTR::UIScriptController::dismissFilePicker):
1254         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1255         * WebKitTestRunner/TestController.cpp:
1256         (WTR::TestController::createWebViewWithOptions):
1257         (WTR::updateTestOptionsFromTestHeader):
1258         * WebKitTestRunner/TestOptions.h:
1259         (WTR::TestOptions::hasSameInitializationOptions const):
1260         * WebKitTestRunner/ios/TestControllerIOS.mm:
1261         (overridePresentViewController):
1262         (WTR::TestController::platformInitialize):
1263         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1264         (WTR::UIScriptController::dismissFilePicker):
1265
1266 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1267
1268         Implement async paste method on UIWKInteractionViewProtocol
1269         https://bugs.webkit.org/show_bug.cgi?id=196267
1270         <rdar://problem/49236346>
1271
1272         Reviewed by Tim Horton.
1273
1274         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1275         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1276         are now a part of all iOS 12 internal SDKs.
1277
1278         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1279
1280         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1281         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1282
1283         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1284         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1285         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1286         * TestWebKitAPI/ios/UIKitSPI.h:
1287
1288 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1289
1290         [ews-build] Use PostgreSQL for ews.webkit.org database
1291         https://bugs.webkit.org/show_bug.cgi?id=196270
1292
1293         Reviewed by Lucas Forschler.
1294
1295         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1296
1297 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1298
1299         [ews] Reset simctl states on reboot
1300         https://bugs.webkit.org/show_bug.cgi?id=196260
1301
1302         Rubber-stamped by Aakash Jain.
1303
1304         * EWSTools/start-queue-mac.sh:
1305
1306 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1307
1308         [ews-build] Use PostgreSQL for ews-build database
1309         https://bugs.webkit.org/show_bug.cgi?id=196229
1310
1311         Reviewed by Lucas Forschler.
1312
1313         * BuildSlaveSupport/ews-build/master.cfg:
1314
1315 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1316
1317         [ews-build] Get master_hostname dynamically in master.cfg
1318         https://bugs.webkit.org/show_bug.cgi?id=196255
1319
1320         Reviewed by Lucas Forschler.
1321
1322         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1323         send events data in test mode.
1324
1325 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1326
1327         [ews-app] Set db_constraint to False for Foreign Keys
1328         https://bugs.webkit.org/show_bug.cgi?id=196252
1329
1330         Reviewed by Lucas Forschler.
1331
1332         * BuildSlaveSupport/ews-app/ews/models/build.py:
1333         * BuildSlaveSupport/ews-app/ews/models/step.py:
1334
1335 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1336
1337         [ews-build] is_test_mode_enabled should default to True
1338         https://bugs.webkit.org/show_bug.cgi?id=196248
1339
1340         Reviewed by Lucas Forschler.
1341
1342         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1343
1344 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews-app] Add webkitperl to ENABLED_QUEUES
1347         https://bugs.webkit.org/show_bug.cgi?id=196253
1348
1349         Reviewed by Lucas Forschler.
1350
1351         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1352
1353 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1354
1355         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1356         https://bugs.webkit.org/show_bug.cgi?id=196211
1357         rdar://problem/49110552
1358
1359         Reviewed by Tim Horton.
1360
1361         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1362         Make sure that EventSenderProxy always exists when running tests. We used to create
1363         it when resetting before the first test, which is a bit too late.
1364
1365         * WebKitTestRunner/TestController.h:
1366         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1367         (WTR::TestController::platformCreateWebView):
1368         (WTR::TestController::platformCreateOtherPage):
1369         (WTR::TestController::finishCreatingPlatformWebView):
1370         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1371         (WTR::PlatformWebView::PlatformWebView):
1372         Moved some code that made NSWindow use NSEvent during web view creation. We may
1373         need to move more if some other case us found, but this is enough for now.
1374
1375 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1376
1377         Unreviewed. Fix typo in GLib geolocation API after r243285.
1378
1379         gelocation -> geolocation.
1380
1381         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1382         (testGeolocationManagerWatchPosition):
1383
1384 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1385
1386         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1387         https://bugs.webkit.org/show_bug.cgi?id=196213
1388
1389         Reviewed by Geoff Garen.
1390
1391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1392         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1393         (credentialWithIdentityAndKeychainPath):
1394         (-[ChallengeDelegate webView:didFinishNavigation:]):
1395         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1396         (TestWebKitAPI::TEST):
1397
1398 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1399
1400         Expected shouldn't assume its contained types are copyable
1401         https://bugs.webkit.org/show_bug.cgi?id=195986
1402
1403         Reviewed by JF Bastien.
1404
1405         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1406         (TestWebKitAPI::NonCopyable::operator== const):
1407         (TestWebKitAPI::NonCopyable::operator!= const):
1408         (TestWebKitAPI::TEST):
1409
1410 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1411
1412         Remove some now-unnecessary dynamic class lookup
1413         https://bugs.webkit.org/show_bug.cgi?id=196237
1414
1415         Reviewed by Simon Fraser.
1416
1417         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1418         (makeRequest):
1419         (TEST):
1420
1421 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1422
1423         Unreviewed, rolling out r243450.
1424
1425         AppleWin and WinCairo port builds get broken.
1426
1427         Reverted changeset:
1428
1429         "Add test for fix of #196095"
1430         https://bugs.webkit.org/show_bug.cgi?id=196097
1431         https://trac.webkit.org/changeset/243450
1432
1433 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1434
1435         Unreviewed, rolling out r243465.
1436         https://bugs.webkit.org/show_bug.cgi?id=196226
1437
1438         the test doesn't build (Requested by thorton on #webkit).
1439
1440         Reverted changeset:
1441
1442         "Do not terminate the NetworkProcess if a third party
1443         application sends a NSCredential with a SecIdentityRef"
1444         https://bugs.webkit.org/show_bug.cgi?id=196213
1445         https://trac.webkit.org/changeset/243465
1446
1447 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1448
1449         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1450         https://bugs.webkit.org/show_bug.cgi?id=196213
1451
1452         Reviewed by Geoff Garen.
1453
1454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1455         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1456         (credentialWithIdentityAndKeychainPath):
1457         (-[ChallengeDelegate webView:didFinishNavigation:]):
1458         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1459         (TestWebKitAPI::TEST):
1460
1461 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1462
1463         [ews-build] Gracefully handle missing patch_id in events
1464         https://bugs.webkit.org/show_bug.cgi?id=196216
1465
1466         Reviewed by Lucas Forschler.
1467
1468         * BuildSlaveSupport/ews-build/events.py:
1469
1470 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1471
1472         [ews-build] use lz4 compression for improving buildbot performance
1473         https://bugs.webkit.org/show_bug.cgi?id=196155
1474
1475         Reviewed by Lucas Forschler.
1476
1477         * BuildSlaveSupport/ews-build/master.cfg:
1478
1479 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1480
1481         Pull some API testing helper methods out of TestWKWebView
1482         https://bugs.webkit.org/show_bug.cgi?id=196212
1483
1484         Reviewed by Tim Horton.
1485
1486         Refactor some more API testing utility methods, so that they can be used in
1487         tests that do not use TestWKWebView.
1488
1489         * TestWebKitAPI/cocoa/TestWKWebView.h:
1490         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1491         (-[WKWebView loadTestPageNamed:]):
1492         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1493         (-[WKWebView synchronouslyLoadHTMLString:]):
1494         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1495         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1496         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1497         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1498         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1499
1500 2019-03-25  Jer Noble  <jer.noble@apple.com>
1501
1502         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1503         https://bugs.webkit.org/show_bug.cgi?id=196097
1504
1505         Reviewed by Eric Carlson.
1506
1507         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1508
1509         * DumpRenderTree/mac/DumpRenderTree.mm:
1510         (resetWebPreferencesToConsistentValues):
1511         * WebKitTestRunner/TestController.cpp:
1512         (WTR::TestController::resetPreferencesToConsistentValues):
1513
1514 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1515
1516         Pull IPadUserInterfaceSwizzler out into a separate header file
1517         https://bugs.webkit.org/show_bug.cgi?id=196193
1518
1519         Reviewed by Anders Carlsson.
1520
1521         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1522         be used in other API tests.
1523
1524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1525         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1526         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1527         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1528         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1529         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1530         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1531
1532 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1533
1534         Remove NavigatorContentUtils in WebCore/Modules
1535         https://bugs.webkit.org/show_bug.cgi?id=196070
1536
1537         Reviewed by Alex Christensen.
1538
1539         NavigatorContentUtils was to support the custom scheme spec [1].
1540         However, in WebKit side, no port has supported the feature in
1541         WebKit layer after EFL port was removed. So there has been the
1542         only IDL implementation of the NavigatorContentUtils in WebCore.
1543         So we don't need to keep the implementation in WebCore anymore.
1544
1545         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1546
1547         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1548
1549 2019-03-24  Andy Estes  <aestes@apple.com>
1550
1551         [watchOS] Remove unused Proximity Networking code
1552         https://bugs.webkit.org/show_bug.cgi?id=196188
1553
1554         Reviewed by Tim Horton.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1557         (TEST):
1558
1559 2019-03-23  Keith Miller  <keith_miller@apple.com>
1560
1561         Refactor clz/ctz and fix getLSBSet.
1562         https://bugs.webkit.org/show_bug.cgi?id=196162
1563
1564         Reviewed by Saam Barati.
1565
1566         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1567
1568         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1569         (TestWebKitAPI::TEST):
1570
1571 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1572
1573         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1574         https://bugs.webkit.org/show_bug.cgi?id=196143
1575
1576         Reviewed by Michael Catanzaro.
1577
1578         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1579         directories.
1580
1581         * Scripts/webkitpy/style/checkers/cpp.py:
1582         (check_identifier_name_in_declaration):
1583         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1584         (WebKitStyleTest.test_names):
1585
1586 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1587
1588         [Flatpak] Manifest expanding fails for qt WPE extension
1589         https://bugs.webkit.org/show_bug.cgi?id=196148
1590
1591         Reviewed by Alex Christensen.
1592
1593         * flatpak/flatpakutils.py:
1594         (expand_submodules_recurse): The last recurse manifest expand
1595         iteration might lead to a single module so take it into account
1596         and don't try to recurse further.
1597
1598 2019-03-22  Chris Dumez  <cdumez@apple.com>
1599
1600         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1601         https://bugs.webkit.org/show_bug.cgi?id=195348
1602         <rdar://problem/48622090>
1603
1604         Reviewed by Alex Christensen.
1605
1606         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1607         to NO when test.options().shouldIgnoreMetaViewport is false.
1608
1609         * WebKitTestRunner/ios/TestControllerIOS.mm:
1610         (WTR::TestController::platformConfigureViewForTest):
1611
1612 2019-03-22  Chris Dumez  <cdumez@apple.com>
1613
1614         Prewarmed processes should be usable with any website data store
1615         https://bugs.webkit.org/show_bug.cgi?id=196104
1616
1617         Reviewed by Alex Christensen.
1618
1619         Add API test coverage.
1620
1621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1622         (runInitialWarmedProcessUsedTest):
1623         (TEST):
1624
1625 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1626
1627         Back out local changes to Alex's Subversion working directory
1628
1629         They were accidentally committed.
1630
1631         * Scripts/webkitpy/common/system/abstractexecutive.py:
1632         (AbstractExecutive.wait_newest):
1633         * Scripts/webkitpy/common/system/executive.py:
1634         (Executive.running_pids):
1635         * Scripts/webkitpy/common/system/executive_mock.py:
1636         (MockExecutive.running_pids):
1637         * Scripts/webkitpy/common/system/executive_unittest.py:
1638         (ExecutiveTest.serial_test_running_pids):
1639         * Scripts/webkitpy/port/darwin.py:
1640         (DarwinPort.check_for_leaks):
1641         * Scripts/webkitpy/port/leakdetector.py:
1642         (LeakDetector.check_for_leaks):
1643         - This was the hack attached to Bug 193772.
1644
1645         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1646         (+[WebKitTestRunnerEvent mouseLocation]):
1647         - This works around a crash on an internal build.
1648
1649 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1650
1651         Fix the build after r243354
1652         https://bugs.webkit.org/show_bug.cgi?id=196138
1653         <rdar://problem/49145951>
1654
1655         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1656         (TEST):
1657         * TestWebKitAPI/ios/UIKitSPI.h:
1658
1659 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1660
1661         Adopt UIWKDocumentContext
1662         https://bugs.webkit.org/show_bug.cgi?id=196040
1663         <rdar://problem/48642440>
1664
1665         Reviewed by Ryosuke Niwa.
1666
1667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1668         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1669         (makeRequest):
1670         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1671         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1672         (applyStyle):
1673         (TEST):
1674         Add tests for UIWKDocumentContext.
1675
1676         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1677         (TEST):
1678         (recursiveFindWKContentView): Deleted.
1679         * TestWebKitAPI/cocoa/TestWKWebView.h:
1680         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1681         (recursiveFindWKContentView):
1682         (-[TestWKWebView wkContentView]):
1683         * TestWebKitAPI/ios/UIKitSPI.h:
1684         Share the WKContentView finding code between tests.
1685
1686 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1687
1688         [iOS WK2] Turn on async overflow scrolling by default
1689         https://bugs.webkit.org/show_bug.cgi?id=196011
1690         rdar://problem/48453859
1691
1692         Reviewed by Antti Koivisto.
1693         
1694         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1695         since so many basic layout tests have different results when compositing is triggered for
1696         overflow.
1697         
1698         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1699
1700         * WebKitTestRunner/TestController.cpp:
1701         (WTR::TestController::resetPreferencesToConsistentValues):
1702
1703 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1704
1705         [ews-build] Retry API test in case of failures
1706         https://bugs.webkit.org/show_bug.cgi?id=196004
1707
1708         Reviewed by Lucas Forschler.
1709
1710         * BuildSlaveSupport/ews-build/steps.py:
1711         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1712         (CompileWebKitToT.doStepIf): Ditto.
1713         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1714         (ReRunAPITests): Re-run API tests.
1715         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1716         (RunAPITestsWithoutPatch): Run API tests without patch.
1717         (RunAPITestsWithoutPatch.doStepIf):
1718         (RunAPITestsWithoutPatch.hideStepIf):
1719         (RunAPITestsWithoutPatch.evaluateCommand):
1720         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1721         (AnalyzeAPITestsResults.start):
1722         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1723         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1724         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1725         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1726
1727 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-build] Update queues configurations
1730         https://bugs.webkit.org/show_bug.cgi?id=196074
1731
1732         Reviewed by Dewei Zhu.
1733
1734         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1735         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1736
1737 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1738
1739         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1740         https://bugs.webkit.org/show_bug.cgi?id=195680
1741         <rdar://problem/48903534>
1742
1743         Unreviewed infrastructure fix.
1744
1745         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1746         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1747
1748 2019-03-21  Andy Estes  <aestes@apple.com>
1749
1750         [iOS] Apple Pay should be available in documents with no user agent scripts
1751         https://bugs.webkit.org/show_bug.cgi?id=196061
1752         <rdar://problem/48649391>
1753
1754         Reviewed by Brady Eidson.
1755
1756         Added API tests and related infrastructure.
1757
1758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1759         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1760         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1761         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1762         (TestWebKitAPI::TEST):
1763         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1764         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1765         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1766         * TestWebKitAPI/cocoa/TestProtocol.mm:
1767         (-[TestProtocol startLoading]):
1768         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1769         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1770         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1771         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1772
1773 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1774
1775         REGRESSSION (r243297): webkitpy tests broken
1776         https://bugs.webkit.org/show_bug.cgi?id=196108
1777
1778         Reviewed by Aakash Jain.
1779
1780         r243297 updated contributors.json, which broke a few unit tests.
1781
1782         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1783         (IRCCommandTest.test_whois):
1784         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1785
1786 2019-03-21  Chris Dumez  <cdumez@apple.com>
1787
1788         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1789         https://bugs.webkit.org/show_bug.cgi?id=196041
1790         <rdar://problem/49083230>
1791
1792         Reviewed by Alex Christensen.
1793
1794         Add API test coverage.
1795
1796         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1797         (TEST):
1798
1799 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1800
1801         Add SPI to inform applications of WKContentRuleList actions
1802         https://bugs.webkit.org/show_bug.cgi?id=195965
1803         <rdar://problem/42664365>
1804
1805         Reviewed by Geoff Garen.
1806
1807         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1808         (TestWebKitAPI::allActionsForResourceLoad):
1809         (TestWebKitAPI::testRequest):
1810         (TestWebKitAPI::TEST_F):
1811         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1812         (Notification::description):
1813         (Notification::operator== const):
1814         (toVector):
1815         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1816         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1817         (makeContentRuleList):
1818         (TEST):
1819         (makeWarnContentRuleList): Deleted.
1820
1821 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1822
1823         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1824         https://bugs.webkit.org/show_bug.cgi?id=196088
1825
1826         Reviewed by Brian Burg.
1827
1828         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1829         Support checks when only one platform is specified. Also deprecate macosx() and
1830         force the use of macos() instead.
1831
1832         * Scripts/webkitpy/style/checkers/cpp.py:
1833         (check_min_versions_of_wk_api_available):
1834         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1835         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1836
1837 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1838
1839         Update status inactive committers' status to 'contributor'.
1840
1841         * Scripts/webkitpy/common/config/contributors.json:
1842
1843 2019-03-21  Xan Lopez  <xan@igalia.com>
1844
1845         [JSC][x86] Drop support for x87 floating point
1846         https://bugs.webkit.org/show_bug.cgi?id=194853
1847
1848         Reviewed by Don Olmstead.
1849
1850         Force SSE2 on x86/32bit builds.
1851
1852         * Scripts/webkitdirs.pm:
1853         (generateBuildSystemFromCMakeProject):
1854
1855 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1856
1857         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1858         https://bugs.webkit.org/show_bug.cgi?id=196073
1859
1860         Reviewed by Michael Catanzaro.
1861
1862         Add test cases to check functions and constructors with no arguments but receiving user data.
1863
1864         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1865         (checkUserData):
1866         (testJSCFunction):
1867         (fooCreateWithUserData):
1868         (testJSCClass):
1869
1870 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1871
1872         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1873
1874         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1875
1876         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1877
1878 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1879
1880         [GTK][WPE] Add API to provide geolocation information
1881         https://bugs.webkit.org/show_bug.cgi?id=195940
1882
1883         Reviewed by Michael Catanzaro.
1884
1885         Add a new test to check the new API.
1886
1887         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1888         (testGeolocationManagerCurrentPosition):
1889         (testGeolocationManagerWatchPosition):
1890         (beforeAll):
1891         (afterAll):
1892         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1893         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1894         (beforeAll): Ditto.
1895         * TestWebKitAPI/glib/CMakeLists.txt:
1896
1897 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1898
1899         [GLib] Returning G_TYPE_OBJECT from a method does not work
1900         https://bugs.webkit.org/show_bug.cgi?id=195574
1901
1902         Reviewed by Michael Catanzaro.
1903
1904         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1905
1906         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1907         (getGFile):
1908         (getParent):
1909         (createGString):
1910         (getGString):
1911         (getGStringCopyWillRaise):
1912         (getGStringCopy):
1913         (getGStringStr):
1914         (getGStringLen):
1915         (freeGString):
1916         (testJSCClass):
1917
1918 2019-03-20  Saam Barati  <sbarati@apple.com>
1919
1920         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1921         https://bugs.webkit.org/show_bug.cgi?id=195721
1922
1923         Reviewed by Filip Pizlo.
1924
1925         * Scripts/run-javascriptcore-tests:
1926
1927 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1928
1929         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1930         https://bugs.webkit.org/show_bug.cgi?id=196049
1931
1932         Reviewed by Tim Horton.
1933
1934         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1935         overflow scrolling in general, so rename it.
1936
1937         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1938
1939 2019-03-20  Daniel Bates  <dabates@apple.com>
1940
1941         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1942         https://bugs.webkit.org/show_bug.cgi?id=196031
1943         <rdar://problem/49078172>
1944
1945         Reviewed by Tim Horton.
1946
1947         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1948         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1949         same code path used when the Done button is pressed to dismiss the <select> picker.
1950
1951         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1952         (TestWebKitAPI::TEST):
1953
1954 2019-03-20  Chris Dumez  <cdumez@apple.com>
1955
1956         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1957         https://bugs.webkit.org/show_bug.cgi?id=196029
1958         <rdar://problem/48954651>
1959
1960         Reviewed by Tim Horton.
1961
1962         Add API test coverage.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1965
1966 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1967
1968         [ews-build] Improve failure summary string for ApplyPatch step
1969         https://bugs.webkit.org/show_bug.cgi?id=195995
1970
1971         Reviewed by Alexey Proskuryakov.
1972
1973         * BuildSlaveSupport/ews-build/steps.py:
1974         (ApplyPatch.getResultSummary): Override getResultSummary.
1975
1976 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1977
1978         AX: Implement support for new meter ARIA role
1979         https://bugs.webkit.org/show_bug.cgi?id=195966
1980
1981         Reviewed by Chris Fleizach.
1982
1983         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1984         to AXLevelIndicator.
1985
1986         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1987
1988 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1989
1990         [WebAuthN] Implement FIDO AppID extension
1991         https://bugs.webkit.org/show_bug.cgi?id=143491
1992         <rdar://problem/48298273>
1993
1994         Reviewed by Brent Fulgham.
1995
1996         Add a test that covers the new flag of convertToU2fSignCommand.
1997
1998         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1999         (TestWebKitAPI::TEST):
2000         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2001         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2002         (TestWebKitAPI::TEST):
2003
2004 2019-03-19  Keith Rollin  <krollin@apple.com>
2005
2006         Add support for more platforms to generate-xcfilelists
2007         https://bugs.webkit.org/show_bug.cgi?id=195977
2008
2009         Reviewed by Alexey Proskuryakov.
2010
2011         generate-xcfilelists incorrectly complains when involved with building
2012         WebKit for iphonesimulator:
2013
2014             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2015             …
2016             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2017
2018         Address this by teaching generate-xcfilelists about more platforms.
2019
2020         * Scripts/generate-xcfilelists:
2021
2022 2019-03-19  John Wilander  <wilander@apple.com>
2023
2024         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2025         https://bugs.webkit.org/show_bug.cgi?id=195923
2026         <rdar://problem/49001272>
2027
2028         Reviewed by Alex Christensen.
2029
2030         This patch does the following to the TestRunner:
2031         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2032         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2033         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2034
2035         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2036         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2037         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2038         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2039         * WebKitTestRunner/TestController.cpp:
2040         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2041         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2042         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2043         * WebKitTestRunner/TestController.h:
2044         * WebKitTestRunner/TestInvocation.cpp:
2045         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2046
2047 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2048
2049         [CMake] Support more clang and gcc sanitizers
2050         https://bugs.webkit.org/show_bug.cgi?id=195956
2051
2052         Reviewed by Michael Catanzaro.
2053
2054         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2055
2056 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-build] Improve summary for PrintConfiguration step
2059         https://bugs.webkit.org/show_bug.cgi?id=195945
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/ews-build/steps.py:
2064         (PrintConfiguration.getResultSummary): Override getResultSummary.
2065
2066 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2067
2068         [ews-build] Improve summary for CheckOutSource step
2069         https://bugs.webkit.org/show_bug.cgi?id=195963
2070
2071         Reviewed by Lucas Forschler.
2072
2073         * BuildSlaveSupport/ews-build/steps.py:
2074         (CheckOutSource.getResultSummary):
2075
2076 2019-03-19  Daniel Bates  <dabates@apple.com>
2077
2078         [iOS] Focus not preserved when switching between tabs
2079         https://bugs.webkit.org/show_bug.cgi?id=195820
2080         <rdar://problem/43614450>
2081
2082         Reviewed by Brent Fulgham.
2083
2084         Add tests to ensure that we restore focus when resigning and becoming first responder.
2085
2086         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2087         (TestWebKitAPI::TEST):
2088
2089 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2090
2091         Make WTFLogChannelState and WTFLogLevel enum classes
2092         https://bugs.webkit.org/show_bug.cgi?id=195904
2093
2094         Reviewed by Eric Carlson.
2095
2096         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2097         (TestWebKitAPI::TEST_F):
2098
2099 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2100
2101         [GStreamer][EME] Backported mssdemux protection data crash fix
2102         https://bugs.webkit.org/show_bug.cgi?id=195918
2103
2104         Reviewed by Philippe Normand.
2105
2106         * gstreamer/jhbuild.modules:
2107         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2108
2109 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2110
2111         Unreviewed, rolling out r243132.
2112
2113         Broke GTK build
2114
2115         Reverted changeset:
2116
2117         "Make WTFLogChannelState and WTFLogLevel enum classes"
2118         https://bugs.webkit.org/show_bug.cgi?id=195904
2119         https://trac.webkit.org/changeset/243132
2120
2121 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2122
2123         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2124
2125         * Scripts/webkitdirs.pm:
2126         (builtDylibPathForName): Adjust the shared library name that's changed
2127         with the API version bump in r243073.
2128
2129 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2130
2131         Make WTFLogChannelState and WTFLogLevel enum classes
2132         https://bugs.webkit.org/show_bug.cgi?id=195904
2133
2134         Reviewed by Eric Carlson.
2135
2136         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2137         (TestWebKitAPI::TEST_F):
2138
2139 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2140
2141         Disable flaky test added in r2431100
2142         https://webkit.org/b/195785
2143
2144         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2145         (TestWebKitAPI::TEST):
2146         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2147
2148 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2149
2150         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2151         https://bugs.webkit.org/show_bug.cgi?id=195916
2152
2153         Reviewed by Tim Horton.
2154
2155         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2156         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2157
2158 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2159
2160         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2161
2162         * Scripts/webkitpy/common/config/contributors.json:
2163
2164 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2165
2166         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2167         https://bugs.webkit.org/show_bug.cgi?id=195785
2168
2169         Reviewed by Geoffrey Garen.
2170
2171         * TestWebKitAPI/TCPServer.cpp: Added.
2172         (TestWebKitAPI::TCPServer::TCPServer):
2173         (TestWebKitAPI::TCPServer::~TCPServer):
2174         (TestWebKitAPI::TCPServer::socketBindListen):
2175         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2176         * TestWebKitAPI/TCPServer.h: Added.
2177         (TestWebKitAPI::TCPServer::port const):
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2180         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2181         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2182         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2183         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2184         (TestWebKitAPI::respondSlowly):
2185         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2186         (TestWebKitAPI::downloadAtRate):
2187         (TestWebKitAPI::TEST):
2188
2189 2019-03-18  Saam Barati  <sbarati@apple.com>
2190
2191         Add a plan file for JetStream 2
2192         https://bugs.webkit.org/show_bug.cgi?id=190734
2193
2194         Reviewed by Mark Lam.
2195
2196         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2197
2198 2019-03-18  Chris Dumez  <cdumez@apple.com>
2199
2200         Delay WebProcess launch until a load is triggered in a Web view
2201         https://bugs.webkit.org/show_bug.cgi?id=195758
2202         <rdar://problem/48126013>
2203
2204         Reviewed by Geoff Garen.
2205
2206         Add API test coverage. Also update some existing API tests to not expect
2207         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2208
2209         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2210         (TestWebKitAPI::TEST):
2211         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2212         (TestWebKitAPI::TEST):
2213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2214         (TEST):
2215         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2216         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2217         (TEST):
2218         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2219         (TEST):
2220         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2221
2222 2019-03-18  Xan Lopez  <xan@igalia.com>
2223
2224         [CMake] Prevent potential warning when determining $architecture
2225         https://bugs.webkit.org/show_bug.cgi?id=195891
2226
2227         Reviewed by Michael Catanzaro.
2228
2229         It's possible for generateBuildSystemForCMakeProject to be called
2230         before determineArchitecture() is ever called. This will make the
2231         first eq check with $architecture to be bogus (and print a
2232         warning). Change that to an eq check with architecture(), which
2233         implicitly calls determineArchitecture() if needed, and change all
2234         the other similar cases in the method in the same way to prevent
2235         future bugs like this one.
2236
2237         * Scripts/webkitdirs.pm:
2238         (generateBuildSystemFromCMakeProject):
2239
2240 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2241
2242         [WPE] Tarballs generated with “make dist” cannot build documentation
2243         https://bugs.webkit.org/show_bug.cgi?id=195885
2244
2245         Reviewed by Carlos Garcia Campos.
2246
2247         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2248
2249 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2250
2251         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2252         https://bugs.webkit.org/show_bug.cgi?id=195883
2253
2254         Reviewed by Carlos Garcia Campos.
2255
2256         * gtkdoc/gtkdoc.py:
2257         (GTKDoc._run_command): When commands fail to run, include the full command line for
2258         the program invocation and the output it has generated on the standard error stream.
2259
2260 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2261
2262         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2263         https://bugs.webkit.org/show_bug.cgi?id=195786
2264
2265         Reviewed by Philippe Normand.
2266
2267         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2268         * wpe/jhbuild.modules: Ditto.
2269
2270 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2271
2272         [ews-build] Don't run clean builds on EWS builders
2273         https://bugs.webkit.org/show_bug.cgi?id=195851
2274
2275         Reviewed by Geoffrey Garen.
2276
2277         * BuildSlaveSupport/ews-build/factories.py:
2278
2279 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2280
2281         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2282         https://bugs.webkit.org/show_bug.cgi?id=195849
2283
2284         Reviewed by Chris Dumez.
2285
2286         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2287
2288         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2289         (runWebsiteDataStoreCustomPaths):
2290
2291 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2292
2293         webkitpy: Upload test results
2294         https://bugs.webkit.org/show_bug.cgi?id=195755
2295         <rdar://problem/48896182>
2296
2297         Reviewed by Aakash Jain.
2298
2299         Establish a new format for uploading results that is not tied to layout tests, apply
2300         that format to webkitpy tests.
2301
2302         * Scripts/webkitpy/common/checkout/scm/git.py:
2303         (Git.native_branch): Return what branch the current checkout is on.
2304         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2305         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2306         * Scripts/webkitpy/common/checkout/scm/svn.py:
2307         (SVN.native_branch): Ditto.
2308         * Scripts/webkitpy/common/system/platforminfo.py:
2309         (PlatformInfo.build_version): Return a build version for Mac.
2310         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2311         (MockPlatformInfo.__init__):
2312         (MockPlatformInfo.build_version):
2313         * Scripts/webkitpy/results: Added.
2314         * Scripts/webkitpy/results/__init__.py: Added.
2315         * Scripts/webkitpy/results/options.py: Added.
2316         (upload_options): OptParse list for upload options.
2317         * Scripts/webkitpy/results/upload.py: Added.
2318         (Upload): Class which enforces the upload format expected by the results server.
2319         (Upload.Expectations):
2320         (Upload.create_configuration):
2321         (Upload.create_commit):
2322         (Upload.create_details):
2323         (Upload.create_run_stats):
2324         (Upload.create_test_result):
2325         (Upload.__init__):
2326         (Upload.Encoder): Encode Upload object as json.
2327         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2328         * Scripts/webkitpy/results/upload_unittest.py: Added.
2329         * Scripts/webkitpy/test/main.py:
2330         (Tester._parse_args): Add upload arguments.
2331         (Tester._run_tests): Allow results to be uploaded.
2332         * Scripts/webkitpy/test/runner.py:
2333         (Runner.__init__): Record which tests were run, rather than just counting them.
2334         (Runner.handle):
2335         * Scripts/webkitpy/test/runner_unittest.py:
2336         (RunnerTest.test_run):
2337         * Scripts/webkitpy/thirdparty/__init__.py:
2338         (AutoinstallImportHook.find_module): Add requests auto-install.
2339         (AutoinstallImportHook._install_requests):
2340         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2341         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2342
2343 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2344
2345         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2346         https://bugs.webkit.org/show_bug.cgi?id=195810
2347
2348         Reviewed by Tim Horton.
2349
2350         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2351         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2352         ending certain layout tests.
2353
2354         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2355         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2356         (-[TestRunnerWKWebView dealloc]):
2357         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2358
2359         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2360         helper method when destroying the web view, and when resetting state between tests.
2361
2362         * WebKitTestRunner/ios/TestControllerIOS.mm:
2363         (WTR::TestController::platformResetStateToConsistentValues):
2364
2365         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2366
2367 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2368
2369         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2370         https://bugs.webkit.org/show_bug.cgi?id=190350
2371         <rdar://problem/45089503>
2372
2373         Reviewed by Geoffrey Garen.
2374
2375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2376         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2377         (TEST):
2378         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2379         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2380         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2381         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2382         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2383         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2384         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2385         (runTest):
2386         (createDirectories):
2387         (TEST):
2388         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2389         (TEST):
2390         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2391         (TEST):
2392
2393 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2394
2395         Add support to WebPage for getting the contents as an attributed string.
2396         https://bugs.webkit.org/show_bug.cgi?id=195636
2397         rdar://problem/45055697
2398
2399         Reviewed by Tim Horton.
2400
2401         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2402         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2403
2404 2019-03-15  Chris Dumez  <cdumez@apple.com>
2405
2406         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2407         https://bugs.webkit.org/show_bug.cgi?id=195747
2408
2409         Reviewed by Geoff Garen.
2410
2411         Add API test coverage.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2414
2415 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2416
2417         Unreviewed, rolling out r242952.
2418
2419         Causing API failures on iOS Simulator
2420
2421         Reverted changeset:
2422
2423         "[PSON] Make sure the WebProcessCache is leverage when
2424         relaunching a process after termination"
2425         https://bugs.webkit.org/show_bug.cgi?id=195747
2426         https://trac.webkit.org/changeset/242952
2427
2428 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2429
2430         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2431         https://bugs.webkit.org/show_bug.cgi?id=195740
2432
2433         Reviewed by Ross Kirsling.
2434
2435         window.open doesn't work for WebKitBrowserWindow because it is not
2436         implemented yet.
2437
2438         1. Implemented createNewPage callback of WKPageUIClient.
2439         2. Changed MainWindow to take a BrowserWindow factory function
2440           instead of BrowserWindowType to be flexible to create
2441           BrowserWindow with extra settings.
2442         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2443           because it is not relevant with MainWindow anymore.
2444
2445         * MiniBrowser/win/Common.cpp:
2446         (parseCommandLine):
2447         * MiniBrowser/win/Common.h:
2448         (CommandLineOptions::CommandLineOptions):
2449         * MiniBrowser/win/MainWindow.cpp:
2450         (MainWindow::MainWindow):
2451         (MainWindow::create):
2452         (MainWindow::init):
2453         (MainWindow::WndProc):
2454         * MiniBrowser/win/MainWindow.h:
2455         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2456         (PrintWebUIDelegate::createWebViewWithRequest):
2457         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2458         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2459         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2460         (WebKitBrowserWindow::updateProxySettings):
2461         (WebKitBrowserWindow::createNewPage):
2462         * MiniBrowser/win/WebKitBrowserWindow.h:
2463         * MiniBrowser/win/WinMain.cpp:
2464         (wWinMain):
2465
2466 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2467
2468         Make it possible to test scrolling tree layer manipulation more easily
2469         https://bugs.webkit.org/show_bug.cgi?id=195780
2470
2471         Reviewed by Tim Horton.
2472         
2473         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2474         cuts off communication of scrolling tree scrolls back to the web process
2475         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2476         allows tests to trigger scrolls which run the scrolling tree layer positioning
2477         logic, but never get another commit from the web process that might mask
2478         scrolling tree bugs.
2479         
2480         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2481         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2482         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2483
2484         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2485         (WTR::UIScriptController::scrollUpdatesDisabled const):
2486         (WTR::UIScriptController::setScrollUpdatesDisabled):
2487         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2488         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2489         (WTR::UIScriptController::scrollUpdatesDisabled const):
2490         (WTR::UIScriptController::setScrollUpdatesDisabled):
2491         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2492         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2493         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2494         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2495         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2496         * WebKitTestRunner/ios/TestControllerIOS.mm:
2497         (WTR::TestController::platformResetStateToConsistentValues):
2498         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2499         (WTR::UIScriptController::scrollUpdatesDisabled const):
2500         (WTR::UIScriptController::setScrollUpdatesDisabled):
2501
2502 2019-03-14  Youenn Fablet  <youenn@apple.com>
2503
2504         Move IDB storage in private browsing mode to NetworkProcess
2505         https://bugs.webkit.org/show_bug.cgi?id=195602
2506
2507         Reviewed by Brady Eidson.
2508
2509         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2510         (TEST):
2511
2512 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2513
2514         [ews-build] Make descriptionDone messages more readable
2515         https://bugs.webkit.org/show_bug.cgi?id=195760
2516
2517         Reviewed by Lucas Forschler.
2518
2519         * BuildSlaveSupport/ews-build/steps.py:
2520         * BuildSlaveSupport/ews-build/steps_unittest.py:
2521
2522 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-build] Generate status-bubble hover-over messages
2525         https://bugs.webkit.org/show_bug.cgi?id=195680
2526
2527         Reviewed by Lucas Forschler.
2528
2529         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2530         (StatusBubble):
2531         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2532         on hover-over.
2533         (StatusBubble._iso_time):
2534         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2535         hover-over message.
2536         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2537
2538 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2539
2540         [ews-app] Gracefully handle the case when state_string is None
2541         https://bugs.webkit.org/show_bug.cgi?id=195753
2542
2543         Reviewed by Lucas Forschler.
2544
2545         * BuildSlaveSupport/ews-app/ews/models/build.py:
2546         * BuildSlaveSupport/ews-app/ews/models/step.py:
2547
2548 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-app] Status bubble display pending for currently running build step
2551         https://bugs.webkit.org/show_bug.cgi?id=195744
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * BuildSlaveSupport/ews-build/events.py:
2556         (Events.stepStarted): If state_string is pending, replace it with step name.
2557
2558 2019-03-14  Chris Dumez  <cdumez@apple.com>
2559
2560         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2561         https://bugs.webkit.org/show_bug.cgi?id=195750
2562
2563         Reviewed by Geoffrey Garen.
2564
2565         Add API test coverage.
2566
2567         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2568         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2569         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2570         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2571
2572 2019-03-14  Chris Dumez  <cdumez@apple.com>
2573
2574         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2575         https://bugs.webkit.org/show_bug.cgi?id=195747
2576
2577         Reviewed by Geoff Garen.
2578
2579         Add API test coverage.
2580
2581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2582
2583 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2584
2585         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2586         https://bugs.webkit.org/show_bug.cgi?id=195725
2587         <rdar://problem/48545062>
2588
2589         Reviewed by Tim Horton.
2590
2591         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2592         handler is nil.
2593
2594         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2595         (TestWebKitAPI::TEST):
2596
2597 2019-03-13  Sam Weinig  <sam@webkit.org>
2598
2599         Add utility function to allow easy reverse range-based iteration of a container
2600         https://bugs.webkit.org/show_bug.cgi?id=195542
2601
2602         Reviewed by Antti Koivisto.
2603
2604         * TestWebKitAPI/CMakeLists.txt:
2605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2606         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2607         (TestWebKitAPI::TEST):
2608         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2609
2610 2019-03-13  Chris Dumez  <cdumez@apple.com>
2611
2612         Use a ServiceWorker process per registrable domain
2613         https://bugs.webkit.org/show_bug.cgi?id=195649
2614
2615         Reviewed by Youenn Fablet.
2616
2617         Update API test coverage.
2618
2619         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2620
2621 2019-03-13  Chris Dumez  <cdumez@apple.com>
2622
2623         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2624         https://bugs.webkit.org/show_bug.cgi?id=195684
2625         <rdar://problem/48294714>
2626
2627         Reviewed by Antti Koivisto.
2628
2629         Add API test coverage.
2630
2631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2632
2633 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2634
2635         [ews-app] Remove unused patch view
2636         https://bugs.webkit.org/show_bug.cgi?id=195669
2637
2638         Reviewed by Lucas Forschler.
2639
2640         * BuildSlaveSupport/ews-app/ews/urls.py:
2641         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2642
2643 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2644
2645         [ews-app] Use Buildbot result code variables
2646         https://bugs.webkit.org/show_bug.cgi?id=195668
2647
2648         Reviewed by Alexey Proskuryakov.
2649
2650         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2651         (Buildbot): Added Buildbot result code variables.
2652         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2653         (StatusBubble._build_bubble): Used Buildbot result code variables.
2654
2655 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2656
2657         [Flatpak] Expand submodule recursively
2658         https://bugs.webkit.org/show_bug.cgi?id=195672
2659
2660         Building WPE with flatpak was impossible without that as it was raising an exception.
2661         Also update wpebackend-fdo to match what is built in jhbuild
2662
2663         Reviewed by Philippe Normand.
2664
2665         * flatpak/flatpakutils.py:
2666         (expand_submodules_recurse):
2667         (expand_manifest):
2668         * flatpak/org.webkit.WPEModules.yaml:
2669
2670 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2671
2672         [ews-app] status bubble should be hidden for certain builds
2673         https://bugs.webkit.org/show_bug.cgi?id=194597
2674
2675         Reviewed by Dewei Zhu.
2676
2677         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2678         (StatusBubble._build_bubble):
2679         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2680         because the patch didn't have relevant changes.
2681         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2682         in production yet.
2683
2684 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2685
2686         [Win] Fix a slew of simple clang-cl warnings.
2687         https://bugs.webkit.org/show_bug.cgi?id=195652
2688
2689         Reviewed by Don Olmstead.
2690
2691         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2692         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2693
2694 2019-03-12  Justin Fan  <justin_fan@apple.com>
2695
2696         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2697         https://bugs.webkit.org/show_bug.cgi?id=195518
2698         <rdar://problem/46322356>
2699
2700         Reviewed by Myles C. Maxfield.
2701
2702         * DumpRenderTree/DerivedSources-input.xcfilelist:
2703         * DumpRenderTree/DerivedSources-output.xcfilelist:
2704
2705 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2706
2707         Unreviewed, rolling out r242825.
2708         https://bugs.webkit.org/show_bug.cgi?id=195648
2709
2710         "Broke webkitpy tests with my change to
2711         lldb_dump_class_layout.py" (Requested by rmorisset on
2712         #webkit).
2713
2714         Reverted changeset:
2715
2716         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2717         classes with suspicious padding"
2718         https://bugs.webkit.org/show_bug.cgi?id=195573
2719         https://trac.webkit.org/changeset/242825
2720
2721 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-build] Show status bubbles while the patch is waiting in queue
2724         https://bugs.webkit.org/show_bug.cgi?id=195618
2725
2726         Reviewed by Lucas Forschler.
2727
2728         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2729         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2730         enabled in initial deployment.
2731         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2732         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2733         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2734         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2735         (StatusBubble._build_bubbles_for_patch):
2736
2737 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2738
2739         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2740         https://bugs.webkit.org/show_bug.cgi?id=195573
2741
2742         Reviewed by Simon Fraser.
2743
2744         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2745
2746         * Scripts/dump-class-layout:
2747         (main):
2748         * lldb/lldb_dump_class_layout.py:
2749         (ClassLayout.__init__):
2750         (ClassLayout._compute_padding_recursive):
2751         (LLDBDebuggerInstance.dump_layout_for_classname):
2752         (LLDBDebuggerInstance):
2753         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2754         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2755
2756 2019-03-12  Chris Dumez  <cdumez@apple.com>
2757
2758         Device Orientation access permission should be denied unless explicitly granted by the client
2759         https://bugs.webkit.org/show_bug.cgi?id=195625
2760
2761         Reviewed by Youenn Fablet.
2762
2763         add API test coverage.
2764
2765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2766         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2767         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2768         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2769         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2770         (runDeviceOrientationTest):
2771         (TEST):
2772         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2773         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2774
2775 2019-03-12  Jer Noble  <jer.noble@apple.com>
2776
2777         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2778         https://bugs.webkit.org/show_bug.cgi?id=195137
2779         <rdar://problem/48810307>
2780
2781         Reviewed by Eric Carlson.
2782
2783         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2784         (TestWebKitAPI::TEST):
2785
2786 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2787
2788         [ews-build] Change urls from uat to production
2789         https://bugs.webkit.org/show_bug.cgi?id=195566
2790
2791         Reviewed by Lucas Forschler.
2792
2793         * BuildSlaveSupport/ews-app/ews/config.py:
2794         * BuildSlaveSupport/ews-build/events.py:
2795         * BuildSlaveSupport/ews-build/steps.py:
2796
2797 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2798
2799         [ews-build] change max_builds for local-worker to 1
2800         https://bugs.webkit.org/show_bug.cgi?id=195568
2801
2802         Reviewed by Lucas Forschler.
2803
2804         * BuildSlaveSupport/ews-build/loadConfig.py:
2805
2806 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2807
2808         Fix the build
2809
2810         * TestRunnerShared/spi/PencilKitTestSPI.h:
2811         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2812
2813 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2814
2815         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2816         https://bugs.webkit.org/show_bug.cgi?id=194131
2817
2818         Reviewed by Michael Catanzaro.
2819
2820         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2821         (uriChanged):
2822         (testUnfinishedSubresourceLoad):
2823         (serverCallback):
2824         (beforeAll):
2825
2826 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2827
2828         WTF::Expected should use std::addressof instead of operator&
2829         https://bugs.webkit.org/show_bug.cgi?id=195604
2830
2831         Reviewed by Myles Maxfield.
2832
2833         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2834         (TestWebKitAPI::Unique::Unique):
2835         (TestWebKitAPI::Unique::operator&):
2836         (TestWebKitAPI::TEST):
2837
2838 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2839
2840         Add Optional to Forward.h.
2841         https://bugs.webkit.org/show_bug.cgi?id=195586
2842
2843         Reviewed by Darin Adler.
2844
2845         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2846         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2847         Remove unnecessary includes from headers.
2848
2849 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2850
2851         Add testing API to hit-test and scroll overflow scrollers
2852         https://bugs.webkit.org/show_bug.cgi?id=195278
2853
2854         Reviewed by Antti Koivisto.
2855         
2856         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2857         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2858         
2859         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2860
2861         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2862         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2863         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2864         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2865         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2866         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2867         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2868         (WTR::enclosingScrollViewIncludingSelf):
2869         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2870
2871 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2872
2873         API test WebKit.RequestTextInputContext fails on iOS
2874         https://bugs.webkit.org/show_bug.cgi?id=195585
2875
2876         Reviewed by Wenson Hsieh and Simon Fraser.
2877
2878         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2879         (applyStyle):
2880         (TEST):
2881         Add a viewport, so that the coordinates match up on iOS.
2882         Scroll by moving the UIScrollView's contentOffset.
2883
2884 2019-03-11  Chris Dumez  <cdumez@apple.com>
2885
2886         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2887         https://bugs.webkit.org/show_bug.cgi?id=195506
2888         <rdar://problem/48733477>
2889
2890         Reviewed by Alex Christensen.
2891
2892         Add API test coverage.
2893
2894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2895
2896 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2897
2898         Adding myself to contributors.json
2899
2900         Unreviewed, addming myself to contributors.json .
2901
2902         * Scripts/webkitpy/common/config/contributors.json:
2903
2904 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2905
2906         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2907         https://bugs.webkit.org/show_bug.cgi?id=195511
2908         <rdar://problem/44873269>
2909
2910         Reviewed by Darin Adler.
2911
2912         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2913         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2914         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2915         (TEST_F):
2916
2917 2019-03-11  Chris Dumez  <cdumez@apple.com>
2918
2919         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2920         https://bugs.webkit.org/show_bug.cgi?id=195561
2921
2922         Reviewed by Youenn Fablet.
2923
2924         Make sure the JS in the test requests for permission to receive device orientation events.
2925
2926         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2927
2928 2019-03-11  Youenn Fablet  <youenn@apple.com>
2929
2930         Allow storage quota increase by default in WTR
2931         https://bugs.webkit.org/show_bug.cgi?id=195541
2932
2933         Reviewed by Geoffrey Garen.
2934
2935         Allow storage quota increase by default in WTR.
2936         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2937         Use this for tests that explicitly need cache increase.
2938
2939         Instead of increasing quota by 2, make sure the next request is
2940         granted by adding all given parameters.
2941
2942         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2943         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2944         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2945         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2946         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::TestController::setAllowStorageQuotaIncrease):
2949         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2950         * WebKitTestRunner/TestController.h:
2951         * WebKitTestRunner/TestInvocation.cpp:
2952         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2953         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2954         (WTR::TestController::cocoaResetStateToConsistentValues):
2955         (WTR::TestController::setAllowStorageQuotaIncrease):
2956         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2957         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2958         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2959
2960 2019-03-11  Xan Lopez  <xan@igalia.com>
2961
2962         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2963         https://bugs.webkit.org/show_bug.cgi?id=194147
2964
2965         Reviewed by Michael Saboff.
2966
2967         To make --32-bit work correctly on Linux/64bit we need to:
2968
2969         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2970         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2971         unfortunately CMake only allows us to do this during
2972         crosscompilation, which is overkill here.
2973         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2974         pkg-config detection module uses the x86 .pc files instead of the
2975         x86_64 ones.
2976         - Set the -m32 flags for the compiler.
2977
2978         * Scripts/webkitdirs.pm:
2979         (generateBuildSystemFromCMakeProject):
2980
2981 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2982
2983         Add MotionMark-1.1 plan file for run-benchmark script.
2984         https://bugs.webkit.org/show_bug.cgi?id=195481
2985
2986         Rubber-stamped by Darin Adler.
2987
2988         Run-benchmark script should support MontionMark-1.1.
2989
2990         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2991
2992 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [ews-app] Add support for submit-to-ews url
2995         https://bugs.webkit.org/show_bug.cgi?id=195477
2996
2997         Reviewed by Lucas Forschler.
2998
2999         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3000         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3001         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3002         * BuildSlaveSupport/ews-app/ews/urls.py:
3003         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3004
3005 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3006
3007         Unreviewed, rolling out r242688, r242643, r242624.
3008
3009         Caused multiple layout test failures and crashes on iOS and macOS.
3010
3011         Reverted changeset:
3012
3013         "requestAnimationFrame should execute before the next frame"
3014         https://bugs.webkit.org/show_bug.cgi?id=177484
3015         https://trac.webkit.org/changeset/242624/webkit
3016
3017         * Tracing/SystemTracePoints.plist:
3018
3019 2019-03-11  John Wilander  <wilander@apple.com>
3020
3021         Resource Load Statistics: Make it possible exclude localhost from classification
3022         https://bugs.webkit.org/show_bug.cgi?id=195474
3023         <rdar://problem/47520577>
3024
3025         Reviewed by Brent Fulgham.
3026
3027         This patch allows for localhost to be excluded from classification and
3028         treatment as a prevalent resource.
3029
3030         The WebKit Tools change adds a new function called
3031         testRunner.setStatisticsIsRunningTest() which can be used to control this
3032         behavior.
3033
3034         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3035         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3036         (WTR::TestRunner::setStatisticsIsRunningTest):
3037         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3038         * WebKitTestRunner/TestController.cpp:
3039         (WTR::TestController::setStatisticsIsRunningTest):
3040         * WebKitTestRunner/TestController.h:
3041         * WebKitTestRunner/TestInvocation.cpp:
3042         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3043
3044 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3045
3046         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3047         https://bugs.webkit.org/show_bug.cgi?id=195560
3048
3049         Reviewed by Lucas Forschler.
3050
3051         * BuildSlaveSupport/ews-build/master.cfg:
3052
3053 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3054
3055         Unreviewed, rolling out r242698.
3056
3057         API test crashes on bots.
3058
3059         Reverted changeset:
3060
3061         "Add a WKContentRuleList variant that uses copied memory
3062         instead of mmap'd shared memory for class A containerized
3063         apps"
3064         https://bugs.webkit.org/show_bug.cgi?id=195511
3065         https://trac.webkit.org/changeset/242698
3066
3067 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3068
3069         [WPE] Enable web process sandbox
3070         https://bugs.webkit.org/show_bug.cgi?id=195169
3071
3072         Reviewed by Daniel Bates.
3073
3074         * wpe/install-dependencies:
3075         * wpe/jhbuild.modules:
3076
3077 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3078
3079         [ews-app] Use port 17000 for worker communication
3080         https://bugs.webkit.org/show_bug.cgi?id=195558
3081
3082         Reviewed by Lucas Forschler.
3083
3084         * BuildSlaveSupport/ews-build/master.cfg:
3085
3086 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3087
3088         [ews-build] unit-tests fail when passwords.json is missing
3089         https://bugs.webkit.org/show_bug.cgi?id=195557
3090
3091         Reviewed by Lucas Forschler.
3092
3093         * BuildSlaveSupport/ews-build/loadConfig.py:
3094         (loadBuilderConfig):
3095         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3096         (ConfigDotJSONTest.test_configuration):
3097         * BuildSlaveSupport/ews-build/master.cfg:
3098
3099 2019-03-11  Truitt Savell  <tsavell@apple.com>
3100
3101         Unreviewed, rolling out r242702.
3102
3103         Broke High Sierra builders.
3104
3105         Reverted changeset:
3106
3107         "Add utility function to allow easy reverse range-based
3108         iteration of a container"
3109         https://bugs.webkit.org/show_bug.cgi?id=195542
3110         https://trac.webkit.org/changeset/242702
3111
3112 2019-03-11  Sam Weinig  <sam@webkit.org>
3113
3114         Add utility function to allow easy reverse range-based iteration of a container
3115         https://bugs.webkit.org/show_bug.cgi?id=195542
3116
3117         Reviewed by Antti Koivisto.
3118
3119         * TestWebKitAPI/CMakeLists.txt:
3120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3121         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3122         (TestWebKitAPI::TEST):
3123         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3124
3125 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3126
3127         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3128         https://bugs.webkit.org/show_bug.cgi?id=195511
3129         <rdar://problem/44873269>
3130
3131         Reviewed by Darin Adler.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3134         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3135         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3136         (TEST_F):
3137
3138 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3139
3140         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3141         https://bugs.webkit.org/show_bug.cgi?id=195499
3142
3143         Reviewed by Darin Adler.
3144
3145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3146         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3147         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3148         (-[WKWebView synchronouslyFocusTextInputContext:]):
3149         (applyStyle):
3150         (applyIframe):
3151         (TEST):
3152         Add some tests for this SPI.
3153
3154 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3155
3156         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3157         https://bugs.webkit.org/show_bug.cgi?id=181151
3158
3159         Reviewed by Don Olmstead.
3160
3161         * TestWebKitAPI/CMakeLists.txt:
3162         * TestWebKitAPI/PlatformWin.cmake:
3163         Enable TestWTF RunLoop tests in all platforms.
3164
3165         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3166         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3167         (TestWebKitAPI::DerivedOneShotTimer::fired):
3168         (TestWebKitAPI::TEST):
3169         Only a few platforms support nested RunLoop.
3170
3171         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3172         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3173
3174 2019-03-10  David Quesada  <david_quesada@apple.com>
3175
3176         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3177         https://bugs.webkit.org/show_bug.cgi?id=152480
3178
3179         Reviewed by Chris Dumez.
3180
3181         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3182         there are no additional references to the process pool besides the one held by
3183         the download, waits for the download to finish (in the sense that the
3184         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3185         measure, also check that the process pool has been deallocated at the end of the
3186         test. The test wouldn't be meaningful if the process pool were still alive.
3187
3188         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3189         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3190         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3191             The download will be canceled because the delegate does not implement the
3192             method to decide the download's destination, so this is where we know the
3193             DownloadProxyMap is done with the DownloadProxy.
3194         (TEST):
3195
3196 2019-03-08  Chris Dumez  <cdumez@apple.com>
3197
3198         Add support for Device Orientation / Motion permission API
3199         https://bugs.webkit.org/show_bug.cgi?id=195329
3200         <rdar://problem/47645367>
3201
3202         Reviewed by Geoffrey Garen.
3203
3204         Add test infrastructure to help test the Device Orientation / Motion permission API.
3205
3206         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3208         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3210         * WebKitTestRunner/TestController.cpp:
3211         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3212         (WTR::TestController::createWebViewWithOptions):
3213         (WTR::TestController::resetStateToConsistentValues):
3214         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3215         * WebKitTestRunner/TestController.h:
3216         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3217         * WebKitTestRunner/TestInvocation.cpp:
3218         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3219
3220 2019-03-08  Saam barati  <sbarati@apple.com>
3221
3222         Add a compare-results script to compare benchmark results
3223         https://bugs.webkit.org/show_bug.cgi?id=195486
3224         <rdar://problem/48723397>
3225
3226         Reviewed by Geoffrey Garen.
3227
3228         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3229         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3230         to extend it to learn about our other benchmarks.
3231
3232         * Scripts/compare-results: Added.
3233         (readJSONFile):
3234         (detectJetStream2):
3235         (JetStream2Results):
3236         (detectSpeedometer2):
3237         (Speedometer2Results):
3238         (detectPLT5):
3239         (PLT5Results):
3240         (detectBenchmark):
3241         (biggerIsBetter):
3242         (ttest):
3243         (getOptions):
3244         (main):
3245
3246 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3247
3248         Ensure old tab state is cleared between iterations of run-benchmark
3249         https://bugs.webkit.org/show_bug.cgi?id=195393
3250         <rdar://problem/46885583>
3251
3252         Reviewed by Dewei Zhu.
3253
3254         a) ensure the default to restore state is not set
3255         b) terminate Safari correctly
3256         c) Set the system default to ignore Persistent State in Safari
3257
3258         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3259         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3260         (OSXBrowserDriver.prepare_env): 
3261         (OSXBrowserDriver.restore_env):
3262         (OSXBrowserDriver.close_browsers):
3263         (OSXBrowserDriver._terminate_processes):
3264         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3265         (OSXChromeDriver):
3266         (OSXChromeCanaryDriver):
3267         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3268         (OSXFirefoxDriver):
3269         (OSXFirefoxNightlyDriver):
3270         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3271         (OSXSafariDriver):
3272         (OSXSafariDriver.prepare_env):
3273
3274 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3275
3276         [GTK] Several InputMethodFilter tests are failing
3277         https://bugs.webkit.org/show_bug.cgi?id=195408
3278
3279         Reviewed by Carlos Garcia Campos.
3280
3281         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3282         Regressed in r241751.
3283         Hexadecimal values of keycodes are expressed now in upper letters.
3284         Composited characters should be cast to UTF8 strings.
3285
3286         (TestWebKitAPI::TEST):
3287
3288 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3289
3290         [GTK] Make Tools/gtkdoc python3 compatible
3291         https://bugs.webkit.org/show_bug.cgi?id=195359
3292
3293         Reviewed by Carlos Garcia Campos.
3294
3295         * gtkdoc/generate-gtkdoc:
3296         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3297         work with Python 2 and 3.
3298         (get_gtkdoc_module_paths):
3299         The iteritems() was removed in Python 3, so let's use items() that's
3300         available in Python 2 and 3.
3301         (get_generator_for_config):
3302         * gtkdoc/gtkdoc.py:
3303         (GTKDoc._run_command):
3304         The sys.stdout.write() is expecting str in Python 3 and not bytes
3305         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3306         for passing the bytes there.
3307
3308 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3309
3310         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3311         https://bugs.webkit.org/show_bug.cgi?id=195346
3312         <rdar://problem/48667048>
3313
3314         Unreviewed build fix for clang-cl.
3315
3316         * DumpRenderTree/win/DumpRenderTree.cpp:
3317         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3318
3319 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3320
3321         requestAnimationFrame should execute before the next frame
3322         https://bugs.webkit.org/show_bug.cgi?id=177484
3323
3324         Reviewed by Simon Fraser.
3325
3326         Add trace points for the page RenderingUpdate.
3327
3328         * Tracing/SystemTracePoints.plist:
3329
3330 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3331
3332         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3333         https://bugs.webkit.org/show_bug.cgi?id=195353
3334         <rdar://problem/48626394>
3335
3336         Reviewed by Simon Fraser.
3337
3338         * WebKitTestRunner/ios/TestControllerIOS.mm:
3339         (WTR::TestController::platformResetPreferencesToConsistentValues):
3340
3341 2019-03-07  John Wilander  <wilander@apple.com>
3342
3343         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3344         https://bugs.webkit.org/show_bug.cgi?id=195383
3345         <rdar://problem/48570136>
3346
3347         Reviewed by Brent Fulgham.
3348
3349         This patch adds test infrastructure to purge only script-accessible cookies,
3350         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3351
3352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3354         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3355         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3356         * WebKitTestRunner/TestController.cpp:
3357         (WTR::TestController::statisticsDeleteCookiesForHost):
3358         * WebKitTestRunner/TestController.h:
3359         * WebKitTestRunner/TestInvocation.cpp:
3360         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3361
3362 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3363
3364         Unreviewed, rolling out r242354.
3365         https://bugs.webkit.org/show_bug.cgi?id=195402
3366
3367         breaks layout tests in all configurations (Requested by
3368         zdobersek on #webkit).
3369
3370         Reverted changeset:
3371
3372         "[WPE] Enable web process sandbox"
3373         https://bugs.webkit.org/show_bug.cgi?id=195169
3374         https://trac.webkit.org/changeset/242354
3375
3376 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3377
3378         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3379         https://bugs.webkit.org/show_bug.cgi?id=195346
3380
3381         Reviewed by Fujii Hironori.
3382
3383         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3384         (TestWebKitAPI::TEST):
3385         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3386
3387         * DumpRenderTree/win/DumpRenderTree.cpp:
3388         (findFontFallback):
3389         (addFontFallbackIfPresent):
3390         (removeFontFallbackIfPresent):
3391         (main):
3392         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3393         (TestWebKitAPI::Util::moduleDirectory):
3394         (TestWebKitAPI::Util::createInjectedBundlePath):
3395         Use wchar helpers as needed.
3396
3397 2019-03-06  Rob Buis  <rbuis@igalia.com>
3398
3399         Consider supporting the `referrerpolicy` attribute.
3400         https://bugs.webkit.org/show_bug.cgi?id=179053
3401
3402         Reviewed by Darin Adler.
3403
3404         Add a runtime flag for referrerpolicy attribute.
3405
3406         * DumpRenderTree/mac/DumpRenderTree.mm:
3407         (enableExperimentalFeatures):
3408
3409 2019-03-05  Daniel Bates  <dabates@apple.com>
3410
3411         Update expected API test result following r242379
3412         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3413
3414         Update expected x-coordinate of selection rect now that the left padding of
3415         a textarea is sized in ems (so dependent on the font size) just like the left
3416         padding of a text field.
3417
3418         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3419         (TestWebKitAPI::TEST):
3420
3421 2019-03-05  David Quesada  <david_quesada@apple.com>
3422
3423         [WK2] It should be possible to follow links with 'download' attributes
3424         https://bugs.webkit.org/show_bug.cgi?id=195145
3425         rdar://problem/48462642
3426
3427         Reviewed by Alex Christensen.
3428
3429         Add a unit test to verify that activating links with 'download' attributes now
3430         navigates to the linked resource, rather than starts downloading it. Add another
3431         to verify that it is still possible to explicitly download the link via the
3432         'Download' navigation action policy.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3435         (-[DownloadAttributeTestDelegate init]):
3436         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3437         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3438         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3439         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3440         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3441         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3442         (TEST):
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::decidePolicyForNavigationAction):
3445         * WebKitTestRunner/TestController.h:
3446
3447 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3448
3449         [Curl] Implement Cookie Accept Policy.
3450         https://bugs.webkit.org/show_bug.cgi?id=191645
3451
3452         Reviewed by Fujii Hironori.
3453
3454         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3455         (TestWebKitAPI::Curl::TEST_F):
3456
3457 2019-03-05  Youenn Fablet  <youenn@apple.com>
3458
3459         Rename requestCacheStorageSpace to requestStorageSpace
3460         https://bugs.webkit.org/show_bug.cgi?id=195282
3461
3462         Reviewed by Chris Dumez.
3463
3464         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3465         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3466         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3467
3468 2019-03-05  Brady Eidson  <beidson@apple.com>
3469
3470         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3471         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3472
3473         Reviewed by Tim Horton.
3474
3475         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3476         different directory into that same WKWebView should work.
3477
3478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3479         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3480
3481 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3482
3483         Add WeakHashSet
3484         https://bugs.webkit.org/show_bug.cgi?id=195152
3485
3486         Reviewed by Antti Koivisto.
3487
3488         Added tests for WeakHashSet.
3489
3490         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3491         (TestWebKitAPI::Base::Base): Moved.
3492         (TestWebKitAPI::Derived::foo): Moved.
3493         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3494         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3495         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3496         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3497
3498 2019-03-04  Chris Dumez  <cdumez@apple.com>
3499
3500         Do not share WebProcesses between private and regular sessions
3501         https://bugs.webkit.org/show_bug.cgi?id=195189
3502         <rdar://problem/48421064>
3503
3504         Reviewed by Alex Christensen.
3505
3506         Add API test coverage.
3507
3508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3509         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3510
3511 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3512
3513         [WPE] Enable web process sandbox
3514         https://bugs.webkit.org/show_bug.cgi?id=195169
3515
3516         Reviewed by Daniel Bates.
3517
3518         * wpe/install-dependencies:
3519         * wpe/jhbuild.modules:
3520
3521 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3522
3523         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3524         https://bugs.webkit.org/show_bug.cgi?id=195206
3525
3526         Reviewed by Žan Doberšek.
3527
3528         Add a new test case.
3529
3530         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3531         (testJSCClass):
3532
3533 2019-03-04  Charlie Turner  <cturner@igalia.com>
3534
3535         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3536         https://bugs.webkit.org/show_bug.cgi?id=194898
3537
3538         Reviewed by Žan Doberšek.
3539
3540         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3541         a GCC extension that permits arithmetic on void* pointer. Inline
3542         the macro until this issue is fixed upstream.
3543
3544 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3545
3546         Rid the world of WK_API_ENABLED
3547         https://bugs.webkit.org/show_bug.cgi?id=195263
3548
3549         Reviewed by Dan Bernstein.
3550
3551         List of changed files elided because it's useless.
3552
3553 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3554
3555         Unreviewed follow-up to r242292.
3556
3557         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3558
3559         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3560         (TestWebKitAPI::testStrip): Renamed from strip.
3561         (TestWebKitAPI::TEST):
3562
3563 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3564
3565         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3566
3567         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3568         and bug #194272 for details.
3569
3570         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3571
3572 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3573
3574         Remove some more unused 32-bit code
3575         https://bugs.webkit.org/show_bug.cgi?id=195255
3576
3577         Reviewed by Darin Adler.
3578
3579         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3580         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3581         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3582         (NPP_New):
3583         (NPP_HandleEvent):
3584         (handleEventCarbon): Deleted.
3585
3586 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3587
3588         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3589
3590         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3591         (TestWebKitAPI::TEST):
3592
3593 2019-03-01  Darin Adler  <darin@apple.com>
3594
3595         Finish removing String::format
3596         https://bugs.webkit.org/show_bug.cgi?id=194893
3597
3598         Reviewed by Daniel Bates.
3599 '
3600         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3601
3602 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3603
3604         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3605         https://bugs.webkit.org/show_bug.cgi?id=195229
3606         <rdar://problem/48520362>
3607
3608         Reviewed by Chris Dumez.
3609
3610         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3611         (TEST):
3612
3613 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3614
3615         Add a system trace scope for event region building
3616         https://bugs.webkit.org/show_bug.cgi?id=195226
3617
3618         Reviewed by Jon Lee.
3619
3620         This trace scope measures the time spend converting element rects into Region objects,
3621         which can be large on some pages.
3622
3623         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3624
3625         * Tracing/SystemTracePoints.plist:
3626
3627 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3628
3629         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3630         https://bugs.webkit.org/show_bug.cgi?id=194612
3631
3632         Reviewed by Alex Christensen.
3633
3634         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3635         Just test the new string-processing function and don't touch the actual environment.
3636         (Test cases are all as before, but based on operator== instead of strcmp.)
3637
3638 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3639
3640         [ews-app] Update primary keys for handling multiple Buildbot instances
3641         https://bugs.webkit.org/show_bug.cgi?id=195120
3642
3643         Reviewed by Stephanie Lewis.
3644
3645         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3646         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3647         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3648
3649         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3650         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3651         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3652         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3653         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3654         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3655
3656 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3657
3658         [WinCairo] Enable service worker
3659         https://bugs.webkit.org/show_bug.cgi?id=188318
3660
3661         Reviewed by Youenn Fablet.
3662
3663         * DumpRenderTree/DumpRenderTreePrefix.h:
3664         * TestWebKitAPI/PlatformWin.cmake:
3665         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3666         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3667         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3668
3669 2019-03-01  Justin Fan  <justin_fan@apple.com>
3670
3671         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3672         https://bugs.webkit.org/show_bug.cgi?id=195191
3673
3674         Rubber-stamped by Dean Jackson.
3675
3676         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3677
3678         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3679
3680 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3681
3682         Unreviewed, fix lldb webkitpy tests
3683         https://bugs.webkit.org/show_bug.cgi?id=194375
3684
3685         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3686
3687         * lldb/lldb_webkit.py:
3688         (WTFStringImplProvider.is_8bit):
3689
3690 2019-02-28  David Quesada  <david_quesada@apple.com>
3691
3692         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3693         https://bugs.webkit.org/show_bug.cgi?id=195121
3694         rdar://problem/48450302
3695
3696         Reviewed by Alex Christensen.
3697
3698         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3699         configurations where the 'download' attribute is absent, blank, or populated
3700         with a filename, and where the anchor element is same-origin or cross-origin
3701         (meaning the 'download' attribute shouldn't be honored).
3702
3703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3704         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3705         (-[NavigationActionTestDelegate init]):