bda4f3ad7c59448f647bedf5ac91cdeaa3fa5455
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
2
3         [macOS] Notification observer is not removed
4         https://bugs.webkit.org/show_bug.cgi?id=208834
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
10         (TEST):
11
12 2020-03-06  Brian Burg  <bburg@apple.com>
13
14         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
15         https://bugs.webkit.org/show_bug.cgi?id=208729
16         <rdar://problem/60105447>
17
18         Reviewed by Jonathan Bedard.
19
20         Improve upload.py to look for the svn branch and revision for the 'webkit'
21         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
22
23         * Scripts/webkitpy/common/checkout/scm/git.py:
24         (Git):
25         (Git.git_svn_id_regexp):
26         (Git._field_from_git_svn_id):
27         (Git.svn_revision):
28         (Git.svn_branch):
29         (Git.svn_url):
30         (Git.native_branch):
31         Refactor svn revision, branch, url to use the same regexp and helper code.
32
33         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
34         (StubRepository.svn_branch):
35         Expose a stub since this is used unconditionally by Port.commits_for_upload.
36
37         * Scripts/webkitpy/common/checkout/scm/svn.py:
38         (SVN.svn_branch):
39         (SVN.native_revision):
40         (SVN):
41         (SVN.native_branch):
42         Refactor so the actual implementation is contained in svn_revision / svn_branch.
43         The native_* methods call out to the SVN equivalents since this is an SVN repository.
44
45         * Scripts/webkitpy/port/base.py:
46         (Port.commits_for_upload):
47         Add special git-svn handling for the WebKit repository so that SVN branch and revision
48         is preferred over the git equivalents.
49
50 2020-03-09  Antoine Quint  <graouts@apple.com>
51
52         TestWebKitAPI fails to build on watchOS
53         https://bugs.webkit.org/show_bug.cgi?id=208820
54
55         Reviewed by Tim Horton.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
58
59 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
60
61         resultsdbpy: Add tool to manage resultsdbpy container
62         https://bugs.webkit.org/show_bug.cgi?id=208743
63
64         Rubber-stamped by Aakash Jain.
65
66         Add tool to start, stop and restart the resultsdbpy Docker container.
67
68         * resultsdbpy/resultsdbpy/container: Added.
69
70 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
71
72         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
73         https://bugs.webkit.org/show_bug.cgi?id=208706
74
75         Reviewed by Žan Doberšek.
76
77         Add test case to check surrounding text in multiline context.
78
79         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
80         (testWebKitInputMethodContextSurrounding):
81
82 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
83
84         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
85         https://bugs.webkit.org/show_bug.cgi?id=208783
86
87         Reviewed by Brent Fulgham.
88
89         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
90
91 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
92
93         Replace the use of term "rollout" to "revert" in various tools
94         https://bugs.webkit.org/show_bug.cgi?id=208775
95
96         Reviewed by Ryosuke Niwa.
97
98         See this webkit-dev thread for the originating discussion:
99         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
100
101         'rollout' is a confusing term to anyone unacquainted with WebKit;
102         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
103
104         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
105         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
106
107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
115         * BuildSlaveSupport/ews-build/steps.py:
116         * BuildSlaveSupport/ews-build/steps_unittest.py:
117         * Scripts/webkit-tools-completion.sh:
118         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
119         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
120         * Scripts/webkitpy/common/checkout/scm/svn.py:
121         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
122         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
123         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
124         * Scripts/webkitpy/tool/bot/feeders.py:
125         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
126         * Scripts/webkitpy/tool/bot/irc_command.py:
127         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
128         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
129         * Scripts/webkitpy/tool/bot/sheriff.py:
130         * Scripts/webkitpy/tool/commands/download.py:
131         * Scripts/webkitpy/tool/commands/download_unittest.py:
132         * Scripts/webkitpy/tool/commands/newcommitbot.py:
133         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
134         * Scripts/webkitpy/tool/commands/queues_unittest.py:
135         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
136         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
137         * Scripts/webkitpy/tool/steps/__init__.py:
138         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
139         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
140         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
141         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
142
143 2020-03-07  David Quesada  <david_quesada@apple.com>
144
145         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
146         https://bugs.webkit.org/show_bug.cgi?id=208781
147         rdar://problem/60061016
148
149         Reviewed by Alex Christensen.
150
151         Add a test that recreates the conditions of this crash:
152         - Send a message from the injected bundle to the UI process that contains a reply block.
153         - Hold a reference to the reply block.
154         - Let the web view deallocate.
155         - Call the block, and expect not to crash.
156
157         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
158         (localObjectInterface):
159         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
160         (-[LocalObject doSomethingWithCompletionHandler:]):
161         (TEST):
162         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
163         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
164
165 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
166
167         TextManipulationController should work with ARIA labels
168         https://bugs.webkit.org/show_bug.cgi?id=208759
169
170         Reviewed by Wenson Hsieh.
171
172         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
173         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
174         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
175         the expected number of tokens for the first item as the very first image is correctly
176         detected per the code change. 
177         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
178
179 2020-03-07  Alex Christensen  <achristensen@webkit.org>
180
181         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
182         https://bugs.webkit.org/show_bug.cgi?id=208767
183
184         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
185         The frameID of the main frame before loading is only 0 on Mac right now.
186         The test is still good because it validates that execution works in the main frame before loading.
187
188 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
189
190         [ews] commit queue is not skipping layout tests for rollout patches
191         https://bugs.webkit.org/show_bug.cgi?id=208716
192
193         Unreviewed minor fix.
194
195         * BuildSlaveSupport/ews-build/steps.py:
196         (RunWebKitTests.doStepIf):
197         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
198         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
199
200 2020-03-05  Sam Weinig  <weinig@apple.com>
201
202         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
203         https://bugs.webkit.org/show_bug.cgi?id=207436
204         <rdar://problem/59296762>
205
206         Reviewed by Darin Adler.
207
208         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
209         Remove JSC related defines.
210
211 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
212
213         AX: Provide a way to run tests in isolated tree mode
214         https://bugs.webkit.org/show_bug.cgi?id=208629
215         <rdar://problem/60075583>
216
217         Reviewed by Ryosuke Niwa.
218
219         Provide the ability to run tests for accessibility in the isolated tree mode.
220         This sends a flag over to the injected bundle which calls the right HIServices override so that
221         the system thinks it is in isolated mode.
222
223         * Scripts/compare-webkit-configurations:
224         (flag_for_comparison):
225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
226         (parse_args):
227         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
228         (parse_args):
229         * Scripts/webkitpy/port/driver.py:
230         (Driver.cmd_line):
231         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
232         (WTR::AccessibilityController::AccessibilityController):
233         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
234         (WTR::AccessibilityController::updateIsolatedTreeMode):
235         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
236         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
238         (WTR::InjectedBundle::didReceiveMessageToPage):
239         (WTR::InjectedBundle::beginTesting):
240         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
241         * WebKitTestRunner/Options.cpp:
242         (WTR::handleOptionAccessibilityIsolatedTreeMode):
243         (WTR::OptionsHandler::OptionsHandler):
244         * WebKitTestRunner/Options.h:
245         * WebKitTestRunner/TestController.cpp:
246         (WTR::TestController::initialize):
247         (WTR::TestController::resetPreferencesToConsistentValues):
248         (WTR::TestController::resetStateToConsistentValues):
249         * WebKitTestRunner/TestController.h:
250         (WTR::TestController::accessibilityIsolatedTreeMode const):
251
252 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
253
254         [Cocoa] Re-enable CFPrefs direct mode
255         https://bugs.webkit.org/show_bug.cgi?id=208690
256
257         Reviewed by Brent Fulgham.
258
259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
260         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
261         (TEST):
262         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
263         (TestWebKitAPI::TEST):
264
265 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
266
267         UIProcess needs mechanism to specify AppBound domains
268         https://bugs.webkit.org/show_bug.cgi?id=208528
269         <rdar://problem/59980340>
270
271         Reviewed by Brent Fulgham.
272
273         Added test app-bound domains to the plist and tested that the domains
274         are properly stored in the website data store after a navigation.
275
276         * TestWebKitAPI/Info.plist:
277         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
278         (TEST):
279
280 2020-03-06  Alex Christensen  <achristensen@webkit.org>
281
282         Add SPI to disable cross origin access control checks
283         https://bugs.webkit.org/show_bug.cgi?id=208748
284
285         Reviewed by Tim Hatcher.
286
287         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
288         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
289
290 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
291
292         [webkitpy] Fix executive on Windows to run wpt server correctly
293         https://bugs.webkit.org/show_bug.cgi?id=208693
294
295         Reviewed by Jonathan Bedard.
296
297         Bug fix for Windows environment a) fixing a typo. b) fixing path
298         c) fix how to kill subprocesses.
299
300         * Scripts/webkitpy/common/system/executive.py:
301         (Executive._windows_kill_command):
302         (Executive.interrupt):
303         (Executive.kill_all):
304         * Scripts/webkitpy/port/base.py:
305         (Port.web_platform_test_server_doc_root):
306
307 2020-03-06  Alex Christensen  <achristensen@webkit.org>
308
309         Evaluating JavaScript in main frame before loading should succeed
310         https://bugs.webkit.org/show_bug.cgi?id=208733
311
312         Reviewed by Tim Horton.
313
314         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
315
316 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
317
318         TextManipulationController should preserve images
319         https://bugs.webkit.org/show_bug.cgi?id=208692
320
321         Reviewed by Wenson Hsieh.
322
323         Added tests for preserving images and their ordering.
324
325         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
326         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
327         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
328         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
329
330 2020-03-06  David Quesada  <david_quesada@apple.com>
331
332         Add _WKResourceLoadInfo.resourceType SPI
333         https://bugs.webkit.org/show_bug.cgi?id=208723
334
335         Reviewed by Alex Christensen.
336
337         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
338         (TEST):
339
340 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
341
342         Stop reporting to webkit-test-results.webkit.org
343         https://bugs.webkit.org/show_bug.cgi?id=207218
344
345         Reviewed by Alexey Proskuryakov.
346
347         * BuildSlaveSupport/build.webkit.org-config/steps.py:
348         (RunWebKitTests):
349
350 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
351
352         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
353         https://bugs.webkit.org/show_bug.cgi?id=208365
354         <rdar://problem/59877296>
355
356         Reviewed by Geoffrey Garen.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
359         (TEST):
360
361 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
362
363         EWS should be able to fetch patch status for security bugs while processing them
364         https://bugs.webkit.org/show_bug.cgi?id=206511
365
366         Reviewed by Alexey Proskuryakov.
367
368         * BuildSlaveSupport/ews-build/steps.py:
369         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
370         (BugzillaMixin.get_patch_json): 
371         (BugzillaMixin.get_bug_json):
372         (BugzillaMixin._is_bug_closed):
373         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
374         (TransferToS3.hideStepIf): Ditto.
375
376 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
377
378         [ews] commit-queue should show the trac url for the commit on the build page
379         https://bugs.webkit.org/show_bug.cgi?id=208715
380
381         Reviewed by Jonathan Bedard.
382
383         * BuildSlaveSupport/ews-build/steps.py:
384         (PushCommitToWebKitRepo.evaluateCommand):
385
386 2020-03-06  Alex Christensen  <achristensen@webkit.org>
387
388         Fix ResourceLoadDelegate.LoadInfo API test after r257816
389         https://bugs.webkit.org/show_bug.cgi?id=208550
390
391         * TestWebKitAPI/cocoa/HTTPServer.mm:
392         (TestWebKitAPI::HTTPServer::respondToRequests):
393         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
394         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
395
396 2020-03-06  Lauro Moura <lmoura@igalia.com>
397
398         [WPE][WebDriver] MiniBrowser should react to close session commands
399         https://bugs.webkit.org/show_bug.cgi?id=207529
400
401         Reviewed by Carlos Garcia Campos.
402
403         Do not call g_object_unref on the first created view if it has already
404         been disposed in the "close" signal handler.
405
406         Based on original patch by Yury Semikhatsky.
407
408         * MiniBrowser/wpe/main.cpp:
409         (main):
410
411 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
412
413         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
414         https://bugs.webkit.org/show_bug.cgi?id=208647
415
416         Reviewed by Carlos Garcia Campos.
417
418         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
419         (TestWebKitAPI::TEST):
420
421 2020-03-05  Alex Christensen  <achristensen@webkit.org>
422
423         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
424         https://bugs.webkit.org/show_bug.cgi?id=208670
425
426         Reviewed by Brady Eidson.
427
428         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
429         (-[FrameNavigationDelegate waitForNavigations:]):
430         (-[FrameNavigationDelegate requests]):
431         (-[FrameNavigationDelegate frames]):
432         (-[FrameNavigationDelegate callbacks]):
433         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
434         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
435         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
436         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
437         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
438         (TEST):
439
440 2020-03-05  Alex Christensen  <achristensen@webkit.org>
441
442         Add WKFrameInfo._parentFrameHandle SPI
443         https://bugs.webkit.org/show_bug.cgi?id=208674
444
445         Reviewed by Brady Eidson.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
448
449 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
450
451         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
452         https://bugs.webkit.org/show_bug.cgi?id=208626
453         <rdar://problem/60074148>
454
455         Reviewed by Brent Fulgham.
456
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
458         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
459         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
460         (TestWebKitAPI::TEST):
461         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
462         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
463         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
464
465 2020-03-05  Antoine Quint  <graouts@apple.com>
466
467         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
468         https://bugs.webkit.org/show_bug.cgi?id=208644
469         <rdar://problem/60042429>
470
471         Reviewed by Brady Eidson.
472
473         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
474         
475         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
476            empty document has been removed in favor of the document for the requested URL,
477         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
478            correctly does not injected the style sheet.
479
480         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
481
482 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
483
484         [ews] Add build step to push commit to WebKit repository
485         https://bugs.webkit.org/show_bug.cgi?id=208589
486
487         Reviewed by Jonathan Bedard.
488
489         * BuildSlaveSupport/ews-build/steps.py:
490         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
491         (PushCommitToWebKitRepo.start): Initialize log observer.
492         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
493         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
494         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
495         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
496         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
497         * BuildSlaveSupport/ews-build/factories.py:
498
499 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
500
501         [ews] Add unit tests for ValidateCommiterAndReviewer build step
502         https://bugs.webkit.org/show_bug.cgi?id=208262
503
504         Reviewed by Jonathan Bedard.
505
506         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
507
508 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
509
510         commit-queue should run WK2 tests instead of WK1 tests
511         https://bugs.webkit.org/show_bug.cgi?id=208544
512
513         Reviewed by Jonathan Bedard.
514
515         * BuildSlaveSupport/ews-build/factories.py:
516
517 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
520         https://bugs.webkit.org/show_bug.cgi?id=208645
521
522         Reviewed by Alexey Proskuryakov.
523
524         * BuildSlaveSupport/ews-build/steps.py:
525         (ValidateCommiterAndReviewer.load_contributors):
526         (ValidateCommiterAndReviewer.start):
527
528 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
529
530         style-checker: Add UAF to the list of security words to warn about.
531         https://bugs.webkit.org/show_bug.cgi?id=208643
532
533         Reviewed by Jonathan Bedard.
534
535         UAF is a common acronym used for use after free.
536
537         * Scripts/webkitpy/style/checkers/changelog.py:
538         (ChangeLogChecker.check_for_unwanted_security_phrases):
539
540 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
541
542         [MSVC] Add .natvis support of WebKit types
543         https://bugs.webkit.org/show_bug.cgi?id=193119
544
545         Reviewed by Don Olmstead.
546
547         To help the WebKit developer while debugging, this file defines how
548         WebKit types are displayed in debugger of Visual Studio.
549         Very limited set of WebKit types, but it changes the world.
550
551         * VisualStudio/WebKit.natvis: Added.
552
553 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
554
555         Add system trace points around display list replay
556         https://bugs.webkit.org/show_bug.cgi?id=208616
557
558         Reviewed by Simon Fraser.
559
560         Add a new "Display list replay" trace point.
561
562         * Tracing/SystemTracePoints.plist:
563
564 2020-03-04  Alex Christensen  <achristensen@webkit.org>
565
566         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
567         https://bugs.webkit.org/show_bug.cgi?id=208615
568         <rdar://problem/59406743>
569
570         Reviewed by Alex Christensen.
571
572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
573         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
574         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
575         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
576         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
577         (TEST):
578         Also make a test written in bug 206310 actually run code.
579
580 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
581
582         [build.webkit.org] Remove leaks queue
583         https://bugs.webkit.org/show_bug.cgi?id=208580
584
585         Reviewed by Jonathan Bedard.
586
587         * BuildSlaveSupport/build.webkit.org-config/config.json:
588         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
590
591 2020-03-04  Alex Christensen  <achristensen@webkit.org>
592
593         Add SPI to evaluate JavaScript in an iframe
594         https://bugs.webkit.org/show_bug.cgi?id=208605
595
596         Reviewed by Brady Eidson.
597
598         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
599
600 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
601
602         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
603         https://bugs.webkit.org/show_bug.cgi?id=208533
604         <rdar://problem/60010184>
605
606         Reviewed by Alex Christensen.
607
608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
609         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
610         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
611         (TestWebKitAPI::TEST):
612         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
613         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
614
615 2020-03-04  Alex Christensen  <achristensen@webkit.org>
616
617         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
618         https://bugs.webkit.org/show_bug.cgi?id=208593
619
620         Reviewed by Brady Eidson.
621
622         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
623         (TestWebKitAPI::TEST):
624
625 2020-03-04  Alex Christensen  <achristensen@webkit.org>
626
627         WKWebView's frames accessor should return a traversable type
628         https://bugs.webkit.org/show_bug.cgi?id=208591
629
630         Reviewed by Brady Eidson.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
633
634 2020-03-04  Antoine Quint  <graouts@apple.com>
635
636         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
637         https://bugs.webkit.org/show_bug.cgi?id=208575
638         <rdar://problem/59773690>
639
640         Reviewed by Brady Eidson.
641
642         Add new tests for the new SPI which check:
643         
644         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
645            specified WKWebView alone,
646         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
647         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
648         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
649         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
650         6. and that the same test also works with PSON enabled.
651
652         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
653
654 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
655
656         [macOS] test-lldb-webkit failing on debug bots
657         https://bugs.webkit.org/show_bug.cgi?id=208545
658
659         Reviewed by Jonathan Bedard.
660
661         The lldb-webkit-test step must pass in the build configuration as an
662         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
663         binary that is downloaded with the rest of the build products. Without this
664         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
665         regardless of their actual build configuration.
666
667         * BuildSlaveSupport/build.webkit.org-config/steps.py:
668         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
669         * Scripts/test-lldb-webkit:
670         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
671
672 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
675         https://bugs.webkit.org/show_bug.cgi?id=208539
676
677         Unreviewed follow-up fix.
678
679         * BuildSlaveSupport/ews-build/steps.py:
680
681 2020-03-04  Daniel Bates  <dabates@apple.com>
682
683         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
684         https://bugs.webkit.org/show_bug.cgi?id=208565
685
686         Reviewed by Wenson Hsieh.
687
688         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
689         of its frame as a means to find all the editable elements in the visible content area
690         of the web view.
691
692         Coincidentally this makes no difference to the test results right now because the web view
693         happens to be located at the origin (0, 0) in the window. However if in the future the
694         web view would be located at some other point then the tests may fail because the rectangle
695         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
696         rectangle for the visible content area.
697
698         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
699         (TEST):
700
701 2020-03-04  Daniel Bates  <dabates@apple.com>
702
703         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
704         https://bugs.webkit.org/show_bug.cgi?id=208564
705
706         Reviewed by Alex Christensen.
707
708         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
709         to make it easy to run just these tests.
710
711         Currently, the tests are organized under the test case name WebKit. This means you need to
712         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
713         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
714         so that a person can run just these test using:
715         
716                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
717
718         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
719         (TEST):
720
721 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
722
723         [ews] Add build step to create local git commit for commit-queue
724         https://bugs.webkit.org/show_bug.cgi?id=208539
725
726         Reviewed by Jonathan Bedard.
727
728         * BuildSlaveSupport/ews-build/steps.py:
729         (CreateLocalGITCommit): Build step to create local git commit.
730         (CreateLocalGITCommit.start):
731         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
732         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
733         * BuildSlaveSupport/ews-build/factories.py:
734
735 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
736
737         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
738         https://bugs.webkit.org/show_bug.cgi?id=207948
739
740         Reviewed by Zalan Bujtas.
741
742         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
743         so that it receives the wheel events.
744
745         * DumpRenderTree/mac/EventSendingController.mm:
746         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
747         * DumpRenderTree/win/EventSender.cpp:
748         (mouseScrollBy):
749
750 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
751
752         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
753         https://bugs.webkit.org/show_bug.cgi?id=208520
754         <rdar://problem/60000214>
755
756         Reviewed by Chris Fleizach.
757
758         Calling InjectedBundle::singleton().page()->page() in the constructor
759         of the AccessibilityController is having this side effect on iOS.
760         So #if to MAC where it's actually being used.
761
762         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
763         (WTR::AccessibilityController::AccessibilityController):
764
765 2020-03-03  Alex Christensen  <achristensen@webkit.org>
766
767         Add SPI _WKResourceLoadInfo.loadedFromCache
768         https://bugs.webkit.org/show_bug.cgi?id=208554
769
770         Reviewed by Wenson Hsieh.
771
772         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
773         (TEST):
774
775 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
776
777         Batch observations and completions of text manipulations
778         https://bugs.webkit.org/show_bug.cgi?id=208406
779
780         Reviewed by Wenson Hsieh.
781
782         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
783         multiple paragraphs at once.
784
785         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
786         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
787         (-[TextManipulationDelegate items]):
788         (-[LegacyTextManipulationDelegate init]):
789         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
790         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
791         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
792         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
793         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
794         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
795         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
796
797 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
798
799         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
800         https://bugs.webkit.org/show_bug.cgi?id=208415
801
802         Reviewed by Brent Fulgham.
803
804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
805         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
806         (TEST):
807
808 2020-03-03  Alex Christensen  <achristensen@webkit.org>
809
810         Add response to _WKResourceLoadDelegate didCompleteWithError callback
811         https://bugs.webkit.org/show_bug.cgi?id=208553
812
813         Reviewed by Simon Fraser.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
816         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
817         (TEST):
818         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
819
820 2020-03-03  Brady Eidson  <beidson@apple.com>
821
822         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
823         https://bugs.webkit.org/show_bug.cgi?id=198795
824
825         Reviewed by Chris Dumez.
826
827         This test appears to no longer be flaky.
828         
829         Let's re-enable it.
830         
831         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
832         (TestWebKitAPI::TEST):
833
834 2020-03-03  Alex Christensen  <achristensen@webkit.org>
835
836         Requests sent to _WKResourceLoadDelegate should include HTTPBody
837         https://bugs.webkit.org/show_bug.cgi?id=208550
838
839         Reviewed by Tim Hatcher.
840
841         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
842         (TEST):
843         * TestWebKitAPI/cocoa/HTTPServer.mm:
844         (TestWebKitAPI::HTTPServer::respondToRequests):
845         HTTPServer now looks for Content-Length in its request.
846         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
847
848 2020-03-03  Alex Christensen  <achristensen@webkit.org>
849
850         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
851         https://bugs.webkit.org/show_bug.cgi?id=208522
852
853         Reviewed by Brian Weinstein.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
856         (TEST):
857
858 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
859
860         commit-queue should update working directory and reapply patch just before commiting
861         https://bugs.webkit.org/show_bug.cgi?id=208521
862
863         Reviewed by Jonathan Bedard.
864
865         * BuildSlaveSupport/ews-build/factories.py:
866
867 2020-03-03  Matt Lewis  <jlewis3@apple.com>
868
869         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
870         https://bugs.webkit.org/show_bug.cgi?id=208485
871
872         Reviewed by Jonathan Bedard.
873
874         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
875         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
876         that we don't have to recreate the variables that are already created.
877         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
878         from each module, rather than making extra imports that we don't need.
879         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
880         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
881         and not part of the host.
882         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
883         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
884         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
885         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
886         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
887         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
888         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
889         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
890         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
891         if we were geting any value at all
892         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
893         sure we aren't gabking the wrong key:value pair
894         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
895         come with the MockHosts and MockHost inherits from MockSystemHost.
896         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
897         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
898         to the various upload steps.
899
900 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
901
902         [ews] Add build step to find list of modified changelogs
903         https://bugs.webkit.org/show_bug.cgi?id=208514
904
905         Reviewed by Jonathan Bedard.
906
907         * BuildSlaveSupport/ews-build/factories.py:
908         * BuildSlaveSupport/ews-build/steps.py:
909         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
910         (FindModifiedChangeLogs.start): Initialize log observer.
911         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
912         (FindModifiedChangeLogs.evaluateCommand):
913         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
914         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
915         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
916         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
917
918 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
919
920         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
921         https://bugs.webkit.org/show_bug.cgi?id=208451
922
923         Unreviewed test gardening.
924
925         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
926
927 2020-03-03  Jiten Mehta  <jmehta@apple.com>
928
929         Adopt HTTP Alternative Services Storage
930         https://bugs.webkit.org/show_bug.cgi?id=208387
931
932         Reviewed by Alex Christensen.
933
934         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
935         (checkUntilEntryFound):
936         (TEST):
937
938 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
939
940         Check for navigation to app-bound domain during script evaluation
941         https://bugs.webkit.org/show_bug.cgi?id=208319
942         <rdar://problem/57569321>
943
944         Reviewed by Brent Fulgham.
945
946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
947         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
948         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
949         (TEST):
950         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
951         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
952
953 2020-03-03  Commit Queue  <commit-queue@webkit.org>
954
955         Unreviewed, rolling out r257754.
956         https://bugs.webkit.org/show_bug.cgi?id=208513
957
958         Introduced API test failure (Requested by perarne on #webkit).
959
960         Reverted changeset:
961
962         "[Cocoa] Mapping from MIME type to UTI type should be done in
963         the UI process"
964         https://bugs.webkit.org/show_bug.cgi?id=208415
965         https://trac.webkit.org/changeset/257754
966
967 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
968
969         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
970         https://bugs.webkit.org/show_bug.cgi?id=208506
971
972         Reviewed by Carlos Garcia Campos.
973
974         * WebKitTestRunner/TestController.cpp:
975         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
976
977 2020-03-02  Ben Nham  <nham@apple.com>
978
979         Add performance probes for HTML parsing
980         https://bugs.webkit.org/show_bug.cgi?id=208271
981
982         Reviewed by Daniel Bates.
983
984         This adds probes that show which lines of HTML are have been parsed.
985
986         * Tracing/SystemTracePoints.plist:
987
988 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
989
990         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
991         https://bugs.webkit.org/show_bug.cgi?id=208415
992
993         Reviewed by Brent Fulgham.
994
995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
996         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
997         (TEST):
998
999 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1000
1001         Unreviewed, rolling out r257725.
1002
1003         This commit caused 10 API tests to fail
1004
1005         Reverted changeset:
1006
1007         "[Cocoa] Mapping from MIME type to UTI type should be done in
1008         the UI process"
1009         https://bugs.webkit.org/show_bug.cgi?id=208415
1010         https://trac.webkit.org/changeset/257725
1011
1012 2020-03-02  Saam Barati  <sbarati@apple.com>
1013
1014         Don't skip tests unnecessarily on arm64
1015         https://bugs.webkit.org/show_bug.cgi?id=208470
1016         <rdar://problem/59968869>
1017
1018         Reviewed by Tadeu Zagallo.
1019
1020         * Scripts/run-jsc-stress-tests:
1021
1022 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1023
1024         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1025         https://bugs.webkit.org/show_bug.cgi?id=208434
1026
1027         Reviewed by Chris Fleizach.
1028
1029         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1030         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1031         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1032         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1033         (WTR::AccessibilityController::accessibleElementById): Same as above.
1034
1035 2020-03-02  John Wilander  <wilander@apple.com>
1036
1037         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1038         https://bugs.webkit.org/show_bug.cgi?id=208399
1039         <rdar://problem/24731650>
1040
1041         Reviewed by Brent Fulgham.
1042
1043         The majority of the changes in WTR::TestController is (partially) fixing a bug
1044         where the TestRunner would statically use the default website datastore instead
1045         of the website data store configure for the page. This worked for persistent
1046         storage testing but not for ephemeral sessions which is what this patch is all
1047         about. The previous TestController::websiteDataStore() is now called
1048         TestController::defaultWebsiteDataStore() and the new
1049         TestController::websiteDataStore() returns the configured website data store.
1050         Most of the use of the default website data store should probably change but
1051         that's not really for this patch to deal with. I did however move all of
1052         resource load statistics' use to the new TestController::websiteDataStore().
1053
1054         A new TestRunner function was added: isStatisticsEphemeral()
1055         It allows test cases to query the ephemeral status of resource load statistics.
1056
1057         One problem that is mitigated in this patch but not fully fixed is that for
1058         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1059         TestController::generatePageConfiguration() via C API 
1060         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1061         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1062         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1063         I tried removing the latter since one session for all platforms should be
1064         Enough but got broken behavior as a result. So now both are still there
1065         and both enable resource load statistics.
1066
1067         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1069         (WTR::TestRunner::isStatisticsEphemeral):
1070         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1071         * WebKitTestRunner/TestController.cpp:
1072         (WTR::TestController::defaultWebsiteDataStore):
1073         (WTR::TestController::websiteDataStore):
1074         (WTR::TestController::generatePageConfiguration):
1075         (WTR::TestController::resetPreferencesToConsistentValues):
1076         (WTR::TestController::resetStateToConsistentValues):
1077         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1078         (WTR::TestController::decidePolicyForNavigationAction):
1079         (WTR::TestController::platformAdjustContext):
1080         (WTR::TestController::clearServiceWorkerRegistrations):
1081         (WTR::TestController::clearDOMCache):
1082         (WTR::TestController::clearDOMCaches):
1083         (WTR::TestController::clearIndexedDatabases):
1084         (WTR::TestController::clearLocalStorage):
1085         (WTR::TestController::hasDOMCache):
1086         (WTR::TestController::domCacheSize):
1087         (WTR::TestController::setStatisticsEnabled):
1088         (WTR::TestController::isStatisticsEphemeral):
1089         (WTR::TestController::setStatisticsDebugMode):
1090         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1091         (WTR::TestController::setStatisticsLastSeen):
1092         (WTR::TestController::setStatisticsMergeStatistic):
1093         (WTR::TestController::setStatisticsPrevalentResource):
1094         (WTR::TestController::setStatisticsVeryPrevalentResource):
1095         (WTR::TestController::dumpResourceLoadStatistics):
1096         (WTR::TestController::isStatisticsPrevalentResource):
1097         (WTR::TestController::isStatisticsVeryPrevalentResource):
1098         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1099         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1100         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1101         (WTR::TestController::setStatisticsHasHadUserInteraction):
1102         (WTR::TestController::isStatisticsHasHadUserInteraction):
1103         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1104         (WTR::TestController::setStatisticsGrandfathered):
1105         (WTR::TestController::isStatisticsGrandfathered):
1106         (WTR::TestController::setUseITPDatabase):
1107         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1108         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1109         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1110         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1111         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1112         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1113         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1114         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1115         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1116         (WTR::TestController::statisticsUpdateCookieBlocking):
1117         (WTR::TestController::statisticsSubmitTelemetry):
1118         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1119         (WTR::TestController::setStatisticsIsRunningTest):
1120         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1121         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1122         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1123         (WTR::TestController::setStatisticsGrandfatheringTime):
1124         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1125         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1126         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1127         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1128         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1129         (WTR::TestController::statisticsDeleteCookiesForHost):
1130         (WTR::TestController::isStatisticsHasLocalStorage):
1131         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1132         (WTR::TestController::hasStatisticsIsolatedSession):
1133         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1134         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1135         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1136         (WTR::TestController::statisticsResetToConsistentState):
1137         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1138         * WebKitTestRunner/TestController.h:
1139         * WebKitTestRunner/TestInvocation.cpp:
1140         (WTR::TestInvocation::invoke):
1141         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1142         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1143         (WTR::initializeWebViewConfiguration):
1144         (WTR::TestController::platformCreateWebView):
1145
1146 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1147
1148         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1149         https://bugs.webkit.org/show_bug.cgi?id=208415
1150
1151         Reviewed by Brent Fulgham.
1152
1153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1154         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1155         (TEST):
1156
1157 2020-03-02  Daniel Bates  <dabates@apple.com>
1158
1159         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1160         https://bugs.webkit.org/show_bug.cgi?id=208352
1161         <rdar://problem/59867815>
1162
1163         Reviewed by Wenson Hsieh.
1164
1165         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1166         to actually scroll the web content. This also means we now execute the same code on both Mac and
1167         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1168         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1169         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1172         (TEST):
1173
1174 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1175
1176         Unreviewed, rolling out r257687.
1177
1178         This commit caused debug tests to crash for macOS & iOS
1179
1180         Reverted changeset:
1181
1182         "[Cocoa] Mapping from MIME type to UTI type should be done in
1183         the UI process"
1184         https://bugs.webkit.org/show_bug.cgi?id=208415
1185         https://trac.webkit.org/changeset/257687
1186
1187 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1188
1189         Unreviewed, rolling out r257618.
1190
1191         This allegedly causes Safari to crash when closing a window
1192         (see rdar://problem/59922725).
1193
1194         Reverted changeset:
1195
1196         "UIProcess crash after using _prepareForMoveToWindow, then
1197         deallocating the WKWebView before moving to the window"
1198         https://bugs.webkit.org/show_bug.cgi?id=208365
1199         https://trac.webkit.org/changeset/257618
1200
1201 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1202
1203         Remove std::lock_guard
1204         https://bugs.webkit.org/show_bug.cgi?id=206451
1205
1206         Reviewed by Anders Carlsson.
1207
1208         Add std::lock_guard lint rule to prevent from using it.
1209
1210         * Scripts/webkitpy/style/checkers/cpp.py:
1211         (check_lock_guard):
1212         (check_style):
1213         (CppChecker):
1214         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1215         (WebKitStyleTest.test_lock_guard):
1216         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1217         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1218         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1219         (assertHasObjects):
1220         (assertHasOnlyObjects):
1221         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1222         (WTR::AXThread::dispatch):
1223         (WTR::AXThread::dispatchFunctionsFromAXThread):
1224         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1225         (WTR::AXThread::initializeRunLoop):
1226
1227 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1228
1229         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1230         https://bugs.webkit.org/show_bug.cgi?id=208415
1231
1232         Reviewed by Brent Fulgham.
1233
1234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1235         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1236         (TEST):
1237
1238 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1239
1240         Unreviewed, rolling out r257565.
1241
1242         It broke WinCairo MiniBrowser
1243
1244         Reverted changeset:
1245
1246         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1247         https://bugs.webkit.org/show_bug.cgi?id=206894
1248         https://trac.webkit.org/changeset/257565
1249
1250 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1251
1252         EWS fails to retry build in case of kill-old-processes exception
1253         https://bugs.webkit.org/show_bug.cgi?id=208003
1254
1255         Reviewed by Jonathan Bedard.
1256
1257         * BuildSlaveSupport/ews-build/steps.py:
1258         (KillOldProcesses.evaluateCommand):
1259         (KillOldProcesses.getResultSummary):
1260
1261 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews] commit-queue should update the ChangeLog with Reviewer name
1264         https://bugs.webkit.org/show_bug.cgi?id=206535
1265
1266         Reviewed by Jonathan Bedard.
1267
1268         * BuildSlaveSupport/ews-build/steps.py:
1269         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1270
1271 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1272
1273         run-javascriptcore-tests: Make upload format valid
1274         https://bugs.webkit.org/show_bug.cgi?id=208341
1275
1276         Rubber-stamped by Aakash Jain.
1277
1278         * Scripts/run-javascriptcore-tests:
1279         (uploadResults): Remove. FIXME.
1280         * Scripts/webkitdirs.pm:
1281         (splitVersionString): Handle case where the subminor version number has a - in it.
1282         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1283
1284 2020-02-28  youenn fablet  <youenn@apple.com>
1285
1286         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1287         https://bugs.webkit.org/show_bug.cgi?id=208130
1288
1289         Reviewed by Eric Carlson.
1290
1291         * WebKitTestRunner/TestOptions.h:
1292         Use GPU process to capture by default.
1293         We will remove this option once done verifying that every test works smoothly.
1294
1295 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1296
1297         [ews] commit queue should skip building and testing for rollout patches
1298         https://bugs.webkit.org/show_bug.cgi?id=208329
1299
1300         Reviewed by Jonathan Bedard.
1301
1302         * BuildSlaveSupport/ews-build/steps.py:
1303         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1304         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1305         (RunWebKit1Tests.doStepIf): Ditto.
1306         * BuildSlaveSupport/ews-build/steps_unittest.py:
1307         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1308         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1309
1310 2020-02-28  Daniel Bates  <dabates@apple.com>
1311
1312         Update my watch list preferences and contributor's entry.
1313
1314         * Scripts/webkitpy/common/config/contributors.json:
1315         * Scripts/webkitpy/common/config/watchlist:
1316
1317 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1318
1319         Fix WebCore export macros for declspec
1320         https://bugs.webkit.org/show_bug.cgi?id=208363
1321
1322         Reviewed by Konstantin Tokarev.
1323
1324         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1325         files. Removed precompiled headers that were empty.
1326
1327         * DumpRenderTree/DumpRenderTreePrefix.h:
1328         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1329         * MiniBrowser/win/stdafx.h:
1330         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1331         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1332         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1333         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1334         * WebKitTestRunner/PlatformFTW.cmake:
1335         * WebKitTestRunner/PlatformWin.cmake:
1336         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1337
1338 2020-02-27  Tim Horton  <timothy_horton@apple.com>
1339
1340         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1341         https://bugs.webkit.org/show_bug.cgi?id=208365
1342
1343         Reviewed by Alex Christensen.
1344
1345         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1346         (TEST):
1347         Add a test! It was a 100% repro crash before this change.
1348
1349 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
1350
1351         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1352         https://bugs.webkit.org/show_bug.cgi?id=208260
1353         <rdar://problem/59820107>
1354
1355         Reviewed by Tim Horton.
1356
1357         Followed instructions for adding an Info.plist for Single-File Tools
1358         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1359
1360         The default WebsiteDataStore file path will change with this test to
1361         reflect the new bundleID so we must change expectations for any api
1362         tests which rely on knowing the path.
1363
1364         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1367         (TEST):
1368         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1369         (TEST):
1370         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
1371         (TEST):
1372         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
1373         (TEST):
1374         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1375         (TEST):
1376         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1377         (TEST):
1378         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1379         (TEST):
1380         (defaultWebsiteCacheDirectory):
1381         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
1382         (TEST):
1383         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1384         (TEST):
1385         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1386         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1387         (TEST):
1388         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1389         (TEST):
1390         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1391         (runWebsiteDataStoreCustomPaths):
1392         (TEST):
1393         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1394         (TestWebKitAPI::resetTestState):
1395         Now that we set a bundleID, we have to reset the cache model between
1396         tests, otherwise it gets stored between tests.
1397
1398         (TestWebKitAPI::TEST):
1399         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1400         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1401
1402 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1403
1404         TextManipulationController should not generate a new item for content in manipulated paragraphs
1405         https://bugs.webkit.org/show_bug.cgi?id=208286
1406
1407         Reviewed by Wenson Hsieh.
1408
1409         Added a regression test.
1410
1411         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1412         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
1413
1414 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
1415
1416         run-javascriptcore-tests: Make upload format valid
1417         https://bugs.webkit.org/show_bug.cgi?id=208341
1418
1419         Reviewed by Aakash Jain.
1420
1421         * Scripts/run-javascriptcore-tests:
1422         (uploadResults): Print json blob for upload after failure for debugging.
1423
1424 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1425
1426         [CMake] Add WebKit::PAL target
1427         https://bugs.webkit.org/show_bug.cgi?id=198493
1428
1429         Reviewed by Michael Catanzaro.
1430
1431         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
1432
1433         * DumpRenderTree/PlatformWin.cmake:
1434
1435 2020-02-27  Alex Christensen  <achristensen@webkit.org>
1436
1437         Add SPI to query WKFrameInfos in a WKWebView
1438         https://bugs.webkit.org/show_bug.cgi?id=208212
1439
1440         Reviewed by Brady Eidson.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1443         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
1444         * WebKitTestRunner/TestController.cpp:
1445         (WTR::TestController::saltForOrigin):
1446
1447 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
1448
1449         Unreviewed, rolling out r257530.
1450
1451         This commit seems to have broke the build internally for
1452         watchOS
1453
1454         Reverted changeset:
1455
1456         "Add SPI to query WKFrameInfos in a WKWebView"
1457         https://bugs.webkit.org/show_bug.cgi?id=208212
1458         https://trac.webkit.org/changeset/257530
1459
1460 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1461
1462         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
1463         https://bugs.webkit.org/show_bug.cgi?id=206894
1464
1465         Reviewed by Adrian Perez de Castro.
1466
1467         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
1468         MiniBrowsers.
1469
1470         * MiniBrowser/gtk/CMakeLists.txt:
1471         * MiniBrowser/win/CMakeLists.txt:
1472         * MiniBrowser/wpe/CMakeLists.txt:
1473
1474 2020-02-26  Alex Christensen  <achristensen@webkit.org>
1475
1476         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
1477         https://bugs.webkit.org/show_bug.cgi?id=206456
1478
1479         Reviewed by Brady Eidson.
1480
1481         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1482         (TEST):
1483
1484 2020-02-26  Alex Christensen  <achristensen@webkit.org>
1485
1486         _WKUserContentWorld should be a wrapper around WKContentWorld
1487         https://bugs.webkit.org/show_bug.cgi?id=208274
1488
1489         Reviewed by Brady Eidson.
1490
1491         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
1492         (TEST):
1493         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1494         (TEST):
1495
1496 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
1497
1498         Unreviewed, rolling out r257522.
1499
1500         Caused 16 API test failures on the bots
1501
1502         Reverted changeset:
1503
1504         "TestWebKitAPI and WebKitTestRunner should have bundle
1505         identifiers"
1506         https://bugs.webkit.org/show_bug.cgi?id=208260
1507         https://trac.webkit.org/changeset/257522
1508
1509 2020-02-26  Alex Christensen  <achristensen@webkit.org>
1510
1511         Add SPI to query WKFrameInfos in a WKWebView
1512         https://bugs.webkit.org/show_bug.cgi?id=208212
1513
1514         Reviewed by Brady Eidson.
1515
1516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1517         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
1518         * WebKitTestRunner/TestController.cpp:
1519         (WTR::TestController::saltForOrigin):
1520
1521 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
1522
1523         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1524         https://bugs.webkit.org/show_bug.cgi?id=208260
1525         <rdar://problem/59820107>
1526
1527         Reviewed by Tim Horton.
1528
1529         Followed instructions for adding an Info.plist for Single-File Tools
1530         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1531
1532         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1533         * TestWebKitAPI/Info.plist: Added.
1534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1535         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1536         * WebKitTestRunner/Info.plist: Added.
1537         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1538
1539 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
1540
1541         Tests should each use a unique ResourceLoadStatistics file path for its database store
1542         https://bugs.webkit.org/show_bug.cgi?id=208206
1543         <rdar://problem/59690272>
1544
1545         Reviewed by Brady Eidson.
1546
1547         Initialize a default website data store before checking for the ITP
1548         store to ensure the directory exists after the file has been deleted.
1549
1550         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1551         (TEST):
1552
1553 2020-02-26  Christopher Reid  <chris.reid@sony.com>
1554
1555         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
1556         https://bugs.webkit.org/show_bug.cgi?id=197684
1557         <rdar://problem/59467397>
1558
1559         Reviewed by Yusuke Suzuki.
1560
1561         Add test for FileSystem::createFile
1562
1563         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1564
1565 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
1566
1567         [ews] commit-queue should verify patch committer and reviewer
1568         https://bugs.webkit.org/show_bug.cgi?id=206532
1569
1570         Reviewed by Jonathan Bedard.
1571
1572         * BuildSlaveSupport/ews-build/steps.py:
1573         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
1574         (ValidateCommiterAndReviewer._addToLog):
1575         (ValidateCommiterAndReviewer.getResultSummary):
1576         (ValidateCommiterAndReviewer.fail_build):
1577         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
1578         (ValidateCommiterAndReviewer.is_reviewer):
1579         (ValidateCommiterAndReviewer.is_committer):
1580         (ValidateCommiterAndReviewer.full_name_from_email):
1581         (ValidateCommiterAndReviewer.start):
1582
1583 2020-02-26  Daniel Bates  <dabates@apple.com>
1584
1585         [iOS] Send focus update immediately on becoming or resigning first responder
1586         https://bugs.webkit.org/show_bug.cgi?id=208082
1587         <rdar://problem/59688413>
1588
1589         Rubber-stamped by Jer Noble.
1590
1591         Add a test to ensure that selecting a position at a point after the web view
1592         becomes first responder is allowed. Such an operation is only allowed if the
1593         web view is focused.
1594
1595         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1596         (-[TestWKWebView selectPositionAtPoint:]):
1597         (TEST):
1598         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
1599
1600 2020-02-26  Chris Dumez  <cdumez@apple.com>
1601
1602         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
1603
1604         The test was added for macOS and times out on iOS.
1605
1606         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1607         (TEST):
1608
1609 2020-02-26  Youenn Fablet  <youenn@apple.com>
1610
1611         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
1612         https://bugs.webkit.org/show_bug.cgi?id=208238
1613
1614         Reviewed by Eric Carlson.
1615
1616         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1617         (TEST):
1618         Remove use of deleted parameter.
1619
1620 2020-02-25  Devin Rousso  <drousso@apple.com>
1621
1622         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
1623         https://bugs.webkit.org/show_bug.cgi?id=206911
1624         <rdar://problem/58026635>
1625
1626         Reviewed by Brian Burg.
1627
1628         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1629         (TestWebKitAPI::TEST):
1630         Add test for `WTF::HashSet::reserveInitialCapacity`.
1631
1632         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1633         (TestWebKitAPI::TEST):
1634         Actually check the value of `WTF::HashMap::capacity`.
1635
1636         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
1637         (-[InspectorDelegate _webView:didAttachInspector:])
1638         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
1639         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
1640         (TestWebKitAPI::TEST):
1641         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1642         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
1643         (TestWebKitAPI::TEST): Deleted.
1644
1645 2020-02-25  Matt Lewis  <jlewis3@apple.com>
1646
1647         Add checkout_root to stubrepository.py
1648         https://bugs.webkit.org/show_bug.cgi?id=208213
1649
1650         Reviewed by Jonathan Bedard.
1651
1652         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1653         (StubRepository.__init__):
1654
1655         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
1656         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
1657
1658 2020-02-25  Daniel Bates  <dabates@apple.com>
1659
1660         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
1661         https://bugs.webkit.org/show_bug.cgi?id=208214
1662
1663         Reviewed by Wenson Hsieh.
1664
1665         Wait until the copy operation completes before loading the second web view and testing paste
1666         to ensure that something was actually copied to the clipboard.
1667
1668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
1669         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1670         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
1671         so that we wait until the command completes.
1672
1673 2020-02-25  Chris Dumez  <cdumez@apple.com>
1674
1675         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
1676         https://bugs.webkit.org/show_bug.cgi?id=208199
1677         <rdar://problem/59746887>
1678
1679         Reviewed by Alex Christensen.
1680
1681         Add API test coverage.
1682
1683         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1684         (TEST):
1685
1686 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1687
1688         spinRunLoop should take a non-zero integer as parameter
1689         https://bugs.webkit.org/show_bug.cgi?id=208148
1690         <rdar://problem/59766682>
1691
1692         Unreviewed iOS build fix.
1693
1694         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1695         (TestWebKitAPI::Util::spinRunLoop):
1696
1697 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1698
1699         spinRunLoop should take a non-zero integer as parameter
1700         https://bugs.webkit.org/show_bug.cgi?id=208148
1701
1702         Reviewed by Darin Adler.
1703
1704         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1705         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1706         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1707         (TestWebKitAPI::Util::spinRunLoop):
1708
1709 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1710
1711         [WTF] Add tests for CompactRefPtrTuple
1712         https://bugs.webkit.org/show_bug.cgi?id=208172
1713
1714         Reviewed by Darin Adler.
1715
1716         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
1717         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
1718
1719         * TestWebKitAPI/CMakeLists.txt:
1720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1721         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
1722         (TestWebKitAPI::TEST):
1723
1724 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
1725
1726         [ews] commit-queue should check that patch have appropriate review flag
1727         https://bugs.webkit.org/show_bug.cgi?id=208138
1728
1729         Reviewed by Jonathan Bedard.
1730
1731         * BuildSlaveSupport/ews-build/steps.py:
1732         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
1733         (BugzillaMixin._is_patch_cq_plus):
1734         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
1735         (ValidatePatch.start):
1736
1737 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
1738
1739         [WebAuthn] Implement SPI for the platform authenticator
1740         https://bugs.webkit.org/show_bug.cgi?id=208087
1741         <rdar://problem/59369305>
1742
1743         Reviewed by Brent Fulgham.
1744
1745         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
1746
1747         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
1748         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1750         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1751         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
1752         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
1753         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
1754         (TestWebKitAPI::TEST):
1755         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
1756         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
1757         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
1758         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
1759
1760 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1761
1762         Unreviewed, updating LLDB test for CompactPointerTuple.
1763         https://bugs.webkit.org/show_bug.cgi?id=207827
1764
1765         * lldb/lldb_webkit.py:
1766         (WTFCompactPointerTupleProvider):
1767         (WTFCompactPointerTupleProvider.update):
1768
1769 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
1770
1771         Provide alternate way to name Web Content process
1772         https://bugs.webkit.org/show_bug.cgi?id=205224
1773         rdar://57038084
1774
1775         Reviewed by Alex Christensen.
1776
1777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1778         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
1779         (TestWebKitAPI::TEST):
1780
1781 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
1782
1783         results.webkit.org: Link to result archives
1784         https://bugs.webkit.org/show_bug.cgi?id=207646
1785         <rdar://problem/59395807>
1786
1787         Rubber-stamped by Aakash Jain.
1788
1789         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
1790         (_ArchiveRouter): Retrieve json from archive-router endpoint.
1791         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
1792         return the most specific value.
1793         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
1794         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
1795         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
1796         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1797         (parametersForInstance): Extract from lambda function.
1798         (testRunLink): Use parametersForInstance instead of a lambda function.
1799         (archiveLink): Return an archive link for data. 
1800         (contentForData): Add archive link to view.
1801         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1802         (TimelineFromEndpoint): Accept both suite and test.
1803         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
1804         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
1805         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
1806         * resultsdbpy/resultsdbpy/view/view_routes.py:
1807         (ViewRoutes.__init__): Add archive_route dictionary.
1808
1809 2020-02-24  Alex Christensen  <achristensen@webkit.org>
1810
1811         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
1812         https://bugs.webkit.org/show_bug.cgi?id=208035
1813         <rdar://problem/58011337>
1814
1815         Reviewed by Tim Hatcher.
1816
1817         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1818
1819 2020-02-22  Darin Adler  <darin@apple.com>
1820
1821         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
1822         https://bugs.webkit.org/show_bug.cgi?id=208099
1823
1824         Reviewed by Antti Koivisto.
1825
1826         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1827         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
1828         so we can use the -[NSString createJSStringRef] method.
1829         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
1830         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
1831
1832 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1833
1834         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
1835         https://bugs.webkit.org/show_bug.cgi?id=208096
1836         <rdar://problem/59632008>
1837
1838         Reviewed by Alexey Proskuryakov.
1839
1840         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
1841         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
1842         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
1843
1844         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
1845         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
1846         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
1847         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
1848         in the credit card expiry field.
1849
1850         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
1851
1852         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1853         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1854         (WTR::UIScriptController::setDefaultCalendarType):
1855         * WebKitTestRunner/TestController.h:
1856
1857         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
1858         identifier and calendar locale identifier.
1859
1860         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1861         (WTR::swizzledCalendar):
1862         (WTR::TestController::overriddenCalendarIdentifier const):
1863         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
1864
1865         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
1866
1867         (WTR::TestController::setDefaultCalendarType):
1868
1869         Plumb the new calendar's locale identifier through this method.
1870
1871         (WTR::TestController::cocoaResetStateToConsistentValues):
1872         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
1873         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1874         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1875         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
1876
1877 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
1878
1879         App-bound domains should have separate Network Sessions
1880         https://bugs.webkit.org/show_bug.cgi?id=208026
1881         <rdar://problem/59434006>
1882
1883         Reviewed by Brent Fulgham.
1884
1885         This patch is mostly test infrastructure involving 3 functions.
1886         One sets in-app browser privacy as enabled in the network process
1887         manually for the test. One ensures that setting the WebView category
1888         works properly, and the last one checks for an app-bound session for
1889         an app-bound navigation.
1890
1891         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1893         (WTR::InjectedBundle::didReceiveMessageToPage):
1894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1895         (WTR::TestRunner::getWebViewCategory):
1896         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
1897         (WTR::TestRunner::hasAppBoundSession):
1898         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
1899         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
1900         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1901         * WebKitTestRunner/TestController.cpp:
1902         (WTR::TestController::ensureViewSupportsOptionsForTest):
1903         Clearing the bundleID should happen right before setting a new one, 
1904         otherwise it clears the ID after it is set and returns a null ID.
1905
1906         (WTR::TestController::resetStateToConsistentValues):
1907         (WTR::TestController::getWebViewCategory):
1908         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
1909         (WTR::inAppBrowserPrivacyBooleanResultCallback):
1910         (WTR::inAppBrowserPrivacyVoidResultCallback):
1911         (WTR::TestController::hasAppBoundSession):
1912         (WTR::TestController::setInAppBrowserPrivacyEnabled):
1913         * WebKitTestRunner/TestController.h:
1914         * WebKitTestRunner/TestInvocation.cpp:
1915         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1917         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
1918         (WTR::TestInvocation::didReceivePrevalentDomains):
1919         (WTR::TestInvocation::didReceiveWebViewCategory):
1920         * WebKitTestRunner/TestInvocation.h:
1921         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1922         (WTR::TestController::getWebViewCategory):
1923
1924 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
1925
1926         Build DumpRenderTree and WebKitTestRunner for macCatalyst
1927         https://bugs.webkit.org/show_bug.cgi?id=208068
1928         <rdar://problem/59676596>
1929
1930         Reviewed by Tim Horton.
1931
1932         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
1933         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1934         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
1935         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
1936         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
1937         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
1938         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
1939         * DumpRenderTree/mac/EventSendingController.h: Ditto.
1940         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
1941         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1942         * Makefile: Add DumpRenderTree and WebKitTestRunner.
1943         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1944         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
1945         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1946
1947 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1948
1949         [ews] Add build step to Validate ChangeLog for commit-queue
1950         https://bugs.webkit.org/show_bug.cgi?id=208064
1951
1952         Reviewed by Jonathan Bedard.
1953
1954         * BuildSlaveSupport/ews-build/steps.py:
1955         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
1956         (ValidateChangeLogAndReviewer.start):
1957         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
1958         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
1959
1960 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1961
1962         [ews] Add build step to set cq- flag on bugzilla patch
1963         https://bugs.webkit.org/show_bug.cgi?id=208021
1964
1965         Reviewed by Jonathan Bedard.
1966
1967         * BuildSlaveSupport/ews-build/steps.py:
1968         (BugzillaMixin.set_cq_minus_flag_on_patch):
1969         (SetCommitQueueMinusFlagOnPatch):
1970         (SetCommitQueueMinusFlagOnPatch.start):
1971         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
1972
1973 2020-02-20  Matt Lewis  <jlewis3@apple.com>
1974
1975         Stub repositories fail to upload some results due to missing head svn revision
1976         https://bugs.webkit.org/show_bug.cgi?id=207684
1977
1978         Reviewed by Jonathan Bedard.
1979
1980         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
1981         (MockHost.__init__):
1982         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1983         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1984         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1985         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
1986         * Scripts/webkitpy/port/base.py:
1987         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
1988         from using mock SCMs and more
1989         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
1990
1991 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
1992
1993         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
1994         https://bugs.webkit.org/show_bug.cgi?id=208051
1995
1996         Reviewed by Carlos Alberto Lopez Perez.
1997
1998         Verbose flag prints out each test name executed. Without this flag
1999         stdout prints out one or two periods.
2000
2001         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2002         (RunJavaScriptCoreTests.start):
2003
2004 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2005
2006         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2007         https://bugs.webkit.org/show_bug.cgi?id=207984
2008
2009         Reviewed by Daniel Bates.
2010
2011         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2012         (TestWebKitAPI::TEST):
2013
2014 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2015
2016         [GTK] Improve user agent quirk for Google Docs and Google Drive
2017         https://bugs.webkit.org/show_bug.cgi?id=206506
2018
2019         Reviewed by Carlos Garcia Campos.
2020
2021         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2022         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2023         (TestWebKitAPI::TEST):
2024
2025 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2026
2027         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2028         https://bugs.webkit.org/show_bug.cgi?id=207380
2029
2030         Reviewed by Jonathan Bedard.
2031
2032         Added a new rule 'build/export_macro'.
2033
2034         Removed a obsolete rule 'readability/webkit_export' which was used
2035         only by Chromium port (r148185).
2036
2037         * Scripts/webkitpy/style/checkers/cpp.py:
2038         (_FunctionState.export_macro):
2039         (check_function_definition):
2040         (_unix_path): Added.
2041         (is_generated_file): Use _unix_path.
2042         (check_has_config_header): Ditto.
2043         (CppChecker):
2044         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2045         (WebKitStyleTest.test_export_macro_check):
2046         (WebKitStyleTest.test_webkit_export_check): Deleted.
2047
2048 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2049
2050         [Win][MiniBrowser] Add prettier toolbar button icons
2051         https://bugs.webkit.org/show_bug.cgi?id=207999
2052
2053         Reviewed by Ross Kirsling.
2054
2055         Use a custom toolbar button icons instead of system stock icons.
2056
2057         Fixed a bug toolbar button dropdown arrows always looked being
2058         hovered. TBSTYLE_FLAT should be given.
2059
2060         Removed the window border line of Progress Indicator.
2061
2062         * MiniBrowser/win/MainWindow.cpp:
2063         (MainWindow::createToolbar):
2064         * MiniBrowser/win/MiniBrowserLib.rc:
2065         * MiniBrowser/win/MiniBrowserLibResource.h:
2066         * MiniBrowser/win/toolbar.bmp: Added.
2067
2068 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2069
2070         Update run-webkit-tests help description for skip-failing-tests
2071         https://bugs.webkit.org/show_bug.cgi?id=208031
2072
2073         Reviewed by Alexey Proskuryakov.
2074
2075         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2076
2077 2020-02-20  Chris Dumez  <cdumez@apple.com>
2078
2079         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2080         https://bugs.webkit.org/show_bug.cgi?id=208015
2081         <rdar://problem/59591630>
2082
2083         Reviewed by Geoffrey Garen.
2084
2085         Add API test coverage.
2086
2087         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2088         (TEST):
2089
2090 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2091
2092         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2093         https://bugs.webkit.org/show_bug.cgi?id=207998
2094         <rdar://problem/40942425>
2095
2096         Reviewed by Sam Weinig.
2097
2098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2100         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2101         (TestWebKitAPI::TEST):
2102         Add some tests for top content insets.
2103
2104 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2105
2106         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2107         https://bugs.webkit.org/show_bug.cgi?id=207910
2108
2109         Unreviewed infrastructure fix.
2110
2111         * Scripts/run-javascriptcore-tests:
2112         (configurationForUpload): Use the major version instead of the sub-minor version
2113         for version name.
2114
2115 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2116
2117         [CMake] Add WPE::libwpe target
2118         https://bugs.webkit.org/show_bug.cgi?id=207970
2119
2120         Reviewed by Adrian Perez de Castro.
2121
2122         Use the WPE::libwpe target.
2123
2124         * MiniBrowser/wpe/CMakeLists.txt:
2125         * TestWebKitAPI/PlatformWPE.cmake:
2126         * TestWebKitAPI/glib/PlatformWPE.cmake:
2127         * wpe/backends/CMakeLists.txt:
2128
2129 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2130
2131         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2132         https://bugs.webkit.org/show_bug.cgi?id=207749
2133
2134         Reviewed by Ross Kirsling.
2135
2136         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2137
2138         * MiniBrowser/win/MainWindow.cpp:
2139         (MainWindow::createToolbar):
2140         (MainWindow::WndProc):
2141         (MainWindow::setDefaultURLToCurrentURL):
2142         (MainWindow::goHome): Added.
2143         (MainWindow::onURLBarEnter):
2144         * MiniBrowser/win/MainWindow.h:
2145         * MiniBrowser/win/MiniBrowserLib.rc:
2146         * MiniBrowser/win/MiniBrowserLibResource.h:
2147         * MiniBrowser/win/MiniBrowserReplace.h:
2148         * MiniBrowser/win/WinMain.cpp:
2149         (wWinMain):
2150
2151 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2152
2153         Fix check-webkit-style errors related to AVFoundationSPI.h
2154         https://bugs.webkit.org/show_bug.cgi?id=207834
2155
2156         Reviewed by Daniel Bates.
2157
2158         Revert the change in r256770 regarding the headers ordering.
2159         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2160
2161         * Scripts/webkitpy/style/checkers/cpp.py:
2162         (check_include_line):
2163
2164 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2165
2166         results.webkit.org: Correctly report JSC tests for windows
2167         https://bugs.webkit.org/show_bug.cgi?id=207910
2168
2169         Rubber-stamped by Aakash Jain.
2170
2171         * Scripts/run-javascriptcore-tests:
2172         (configurationForUpload): Give Windows a version name.
2173         * Scripts/webkitdirs.pm:
2174         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2175         Version dictionary.
2176
2177 2020-02-19  Chris Dumez  <cdumez@apple.com>
2178
2179         Unreviewed, fix assertions in storage access API layout tests after r256882.
2180
2181         Drop dead testRunner code to toggle storage access API feature.
2182
2183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2185         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2187         * WebKitTestRunner/TestInvocation.cpp:
2188         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2189
2190 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2191
2192         [WPE] Support 2D axis, smooth-motion events
2193         https://bugs.webkit.org/show_bug.cgi?id=207881
2194
2195         Reviewed by Carlos Garcia Campos.
2196
2197         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2198
2199 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2200
2201         Unreviewed, rolling out r256851.
2202
2203         Broke internal bots
2204
2205         Reverted changeset:
2206
2207         "Stub repositories fail to upload some results due to missing
2208         head svn revision"
2209         https://bugs.webkit.org/show_bug.cgi?id=207684
2210         https://trac.webkit.org/changeset/256851
2211
2212 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2213
2214         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2215         https://bugs.webkit.org/show_bug.cgi?id=207883
2216
2217         Reviewed by Ross Kirsling.
2218
2219         Unlike other mouse buttons, 4th and 5th mouse buttons are
2220         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2221         WM_XBUTTONUP events to the window under the mouse cursor.
2222         Unhandled WM_XBUTTONUP events are automatically converted to
2223         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2224         parent window.
2225         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2226
2227         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2228         handled.
2229
2230         * MiniBrowser/win/BrowserWindow.h:
2231         * MiniBrowser/win/MainWindow.cpp:
2232         (MainWindow::WndProc):
2233         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2234         (WebKitBrowserWindow::navigateForwardOrBackward):
2235         * MiniBrowser/win/WebKitBrowserWindow.h:
2236         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2237         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2238         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2239
2240 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2241
2242         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2243         https://bugs.webkit.org/show_bug.cgi?id=207912
2244         <rdar://problem/59556922>
2245
2246         Reviewed by Brian Weinstein.
2247
2248         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2249         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2250         (TEST):
2251         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2252         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2253
2254 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2255
2256         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2257         https://bugs.webkit.org/show_bug.cgi?id=207899
2258         <rdar://problem/55658207>
2259
2260         Reviewed by Tim Horton and Simon Fraser.
2261
2262         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2263
2264         * WebKitTestRunner/TestController.cpp:
2265         (WTR::updateTestOptionsFromTestHeader):
2266         * WebKitTestRunner/TestOptions.h:
2267         (WTR::TestOptions::hasSameInitializationOptions const):
2268         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2269         (WTR::TestController::platformCreateWebView):
2270
2271 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2272
2273         Stub repositories fail to upload some results due to missing head svn revision
2274         https://bugs.webkit.org/show_bug.cgi?id=207684
2275
2276         Reviewed by Jonathan Bedard.
2277
2278         * Scripts/webkitpy/api_tests/run_api_tests.py:
2279         (main): Added initializing the scm to the host object.
2280         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2281         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2282         it in line with modern code.
2283         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2284         (main): Added inializing the scm to the host object.
2285         * Scripts/webkitpy/port/base.py:
2286         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2287         from using mock SCMs and more
2288         * Scripts/webkitpy/test/main.py:
2289         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2290         and converted the webkit_root variable to the SCM checkout root.
2291         (Tester._run_tests):
2292
2293 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2294
2295         Move [UIDevice currentDevice] calls to UI process
2296         https://bugs.webkit.org/show_bug.cgi?id=204320
2297
2298         Reviewed by Darin Adler.
2299
2300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2301         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2302         (TEST):
2303
2304 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2305
2306         Move from "layer flush" terminology to "rendering update"
2307         https://bugs.webkit.org/show_bug.cgi?id=207870
2308
2309         Reviewed by Tim Horton.
2310
2311         Rename various functions and member variables to move away from the legacy "layer flush"
2312         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2313         that we have layers is an implementation detail.
2314         
2315         Change LayerFlushThrottlingState to be an OptionSet<>.
2316
2317         * Tracing/SystemTracePoints.plist:
2318
2319 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2320
2321         [Webkit.css] Adding popover style element
2322         This help to prevent us reinventing the wheel ever again
2323         https://bugs.webkit.org/show_bug.cgi?id=207787
2324
2325         Reviewed by Dean Jackson.
2326
2327         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2328         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2329         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2330         (.popover):
2331         (.popover>.content):
2332         (.popover.display):
2333         (.popover .arrow):
2334         (.popover .arrow.point-top):
2335         (.popover .arrow.point-bottom):
2336         (.popover .arrow.point-left):
2337         (.popover .arrow.point-right):
2338         (@media (prefers-color-scheme: dark) .popover>.content):
2339         (@media (prefers-color-scheme: dark) .popover.display):
2340         (@media (prefers-color-scheme: dark) .popover .arrow):
2341         (.popover>.content>.section): Deleted.
2342         (.popover:focus>.content, .popover:hover>.content): Deleted.
2343         (.popover.right>.content): Deleted.
2344         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
2345         (.popover.left>.content): Deleted.
2346         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
2347         (.popover.bottom>.content): Deleted.
2348         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
2349
2350 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
2351
2352         Update WebKit Tools to issue mach extensions as needed
2353         https://bugs.webkit.org/show_bug.cgi?id=207850
2354         <rdar://problem/59521019>
2355
2356         Reviewed by Per Arne Vollan.
2357
2358         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
2359         to its child processes (WebContent, GPU, Network, etc.) as needed.
2360
2361         * MiniBrowser/MiniBrowser.entitlements:
2362         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
2363         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2365         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
2366
2367 2020-02-17  Peng Liu  <peng.liu6@apple.com>
2368
2369         Fix check-webkit-style errors related to AVFoundationSPI.h
2370         https://bugs.webkit.org/show_bug.cgi?id=207834
2371
2372         Reviewed by Eric Carlson.
2373
2374         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
2375         Soft-link headers can be included as either "file.h" or <file.h>.
2376
2377         * Scripts/webkitpy/style/checkers/cpp.py:
2378         (_classify_include):
2379         (check_include_line):
2380
2381 2020-02-17  Keith Rollin  <krollin@apple.com>
2382
2383         Unreviewed build fix after r256715.
2384
2385         Fix tvOS and watchOS builds.
2386
2387         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2388
2389 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
2390
2391         Use CF prefs direct mode in the WebContent process
2392         https://bugs.webkit.org/show_bug.cgi?id=203420
2393
2394         Reviewed by Brent Fulgham.
2395
2396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2397         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
2398         (TEST):
2399
2400 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
2401
2402         EWS should be able to file Bugzilla bugs
2403         https://bugs.webkit.org/show_bug.cgi?id=207845
2404
2405         Reviewed by Alexey Proskuryakov.
2406
2407         * BuildSlaveSupport/ews-build/steps.py:
2408         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
2409
2410 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
2411
2412         EWS should be able to comment on Bugzilla
2413         https://bugs.webkit.org/show_bug.cgi?id=201927
2414
2415         Reviewed by Jonathan Bedard.
2416
2417         * BuildSlaveSupport/ews-build/steps.py:
2418         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
2419         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
2420         (BugzillaMixin.close_bug): Ditto.
2421         (CommentOnBug): Build step to comment on bugzilla bug.
2422
2423 2020-02-17  Antti Koivisto  <antti@apple.com>
2424
2425         [macOS] Add trace points for layer flush runloop observer
2426         https://bugs.webkit.org/show_bug.cgi?id=207837
2427
2428         Reviewed by Sam Weinig.
2429
2430         * Tracing/SystemTracePoints.plist:
2431
2432 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
2433
2434         [CMake] Use builtin targets
2435         https://bugs.webkit.org/show_bug.cgi?id=205166
2436
2437         Reviewed by Darin Adler.
2438
2439         * TestWebKitAPI/PlatformWin.cmake:
2440
2441 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
2442
2443         [ews] add SetBuildSummary step for Windows EWS
2444         https://bugs.webkit.org/show_bug.cgi?id=207556
2445
2446         Reviewed by Jonathan Bedard.
2447
2448         * BuildSlaveSupport/ews-build/factories.py:
2449         (WindowsFactory.__init__):
2450         (GTKBuildAndTestFactory.__init__):
2451         * BuildSlaveSupport/ews-build/factories_unittest.py:
2452         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
2453
2454 2020-02-17  Alberto Garcia  <berto@igalia.com>
2455
2456         [WPE] Change the QML plugin install path
2457         https://bugs.webkit.org/show_bug.cgi?id=207761
2458
2459         Reviewed by Philippe Normand.
2460
2461         * Scripts/run-qt-wpe-minibrowser:
2462         * glib/api_test_runner.py:
2463         (TestRunner._run_test_qt):
2464
2465 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2466
2467         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
2468         https://bugs.webkit.org/show_bug.cgi?id=207746
2469
2470         Reviewed by Don Olmstead.
2471
2472         * MiniBrowser/win/stdafx.h:
2473
2474 2020-02-16  Brady Eidson  <beidson@apple.com>
2475
2476         Expose "allowsContentJavaScript" on WKWebpagePreferences
2477         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
2478
2479         Reviewed by Darin Adler.
2480
2481         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2482         (TEST):
2483         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2484         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2485         (TEST):
2486         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
2487         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2488         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2489         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2490         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
2491         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
2492         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2493         * TestWebKitAPI/cocoa/TestWKWebView.h:
2494         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2495         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
2496
2497 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
2498
2499         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
2500         https://bugs.webkit.org/show_bug.cgi?id=207747
2501
2502         Reviewed by Keith Miller.
2503
2504         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
2505         (TestWebKitAPI::TEST):
2506
2507 2020-02-14  Alex Christensen  <achristensen@webkit.org>
2508
2509         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
2510         https://bugs.webkit.org/show_bug.cgi?id=207360
2511         <rdar://problem/57825317>
2512
2513         Reviewed by Ryosuke Niwa.
2514
2515         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2516         (TestWebKitAPI::TEST):
2517
2518 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
2519
2520         [CMake] Add Fontconfig::Fontconfig target
2521         https://bugs.webkit.org/show_bug.cgi?id=207730
2522
2523         Reviewed by Adrian Perez de Castro.
2524
2525         Use the Fontconfig::Fontconfig target.
2526
2527         * WebKitTestRunner/PlatformGTK.cmake:
2528
2529 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
2530
2531          Expose prevalent domains on a per-page basis
2532          https://bugs.webkit.org/show_bug.cgi?id=207523
2533          <rdar://problem/59270758>
2534
2535         Reviewed by Chris Dumez.
2536
2537         Added WebKitTestRunner functions so this functionality can be tested.
2538         clearPrevalentDomains should be called between tests to reset the
2539         state.
2540
2541         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2543         (WTR::InjectedBundle::didReceiveMessageToPage):
2544         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2545         (WTR::TestRunner::getPrevalentDomains):
2546         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
2547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2548         * WebKitTestRunner/TestController.cpp:
2549         (WTR::TestController::resetStateToConsistentValues):
2550         (WTR::TestController::getPrevalentDomains):
2551         (WTR::TestController::clearPrevalentDomains):
2552         * WebKitTestRunner/TestController.h:
2553         * WebKitTestRunner/TestInvocation.cpp:
2554         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2555         (WTR::TestInvocation::didReceivePrevalentDomains):
2556         * WebKitTestRunner/TestInvocation.h:
2557         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2558         (WTR::TestController::getPrevalentDomains):
2559         (WTR::TestController::clearPrevalentDomains):
2560
2561 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2562
2563         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
2564         https://bugs.webkit.org/show_bug.cgi?id=207682
2565
2566         Reviewed by Ross Kirsling.
2567
2568         The toolbar placed button common controls as the toolbar buttons.
2569         However, because these buttons are focusable, shortcut keys don't
2570         work after clicking them.
2571
2572         Added Home button, Add to Bookmarks button, dropdown buttons of
2573         back and forward buttons, but they aren't implemented yet. Just
2574         placeholders at the moment.
2575
2576         * MiniBrowser/win/MainWindow.cpp:
2577         (MainWindow::createToolbar): Added.
2578         (MainWindow::resizeToolbar): Added.
2579         (MainWindow::rescaleToolbar): Added.
2580         (MainWindow::init):
2581         (MainWindow::resizeSubViews):
2582         (MainWindow::updateDeviceScaleFactor):
2583         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
2584
2585 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2586
2587         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
2588         https://bugs.webkit.org/show_bug.cgi?id=207676
2589
2590         Reviewed by Wenson Hsieh and Timothy Hatcher.
2591
2592         Added regression tests for pasting content with -apple-system-label and outdenting content.
2593
2594         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2595         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
2596         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
2597
2598 2020-02-13  Alex Christensen  <achristensen@webkit.org>
2599
2600         _WKResourceLoadInfo should conform to NSSecureCoding
2601         https://bugs.webkit.org/show_bug.cgi?id=207667
2602
2603         Reviewed by Brady Eidson.
2604
2605         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2606         (TEST):
2607
2608 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
2609
2610         [PlayStation] Add Buildbots for Debug/Release builds
2611         https://bugs.webkit.org/show_bug.cgi?id=199454
2612
2613         Reviewed by Aakash Jain.
2614
2615         * BuildSlaveSupport/build.webkit.org-config/config.json:
2616         Add PlayStation slaves, builders
2617         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2618         Use higher timeout for playstation as with win bot
2619         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2620         Set PlayStation category for playstation platform
2621         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2622         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
2623         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2624         Add PlayStation expectations
2625
2626 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
2627
2628         [iOS] Check if PIP is supported in the UI process
2629         https://bugs.webkit.org/show_bug.cgi?id=207406
2630
2631         Reviewed by Brent Fulgham.
2632
2633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2634         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
2635         (TEST):
2636
2637 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2638
2639         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
2640         https://bugs.webkit.org/show_bug.cgi?id=207397
2641         <rdar://problem/59268128>
2642
2643         Reviewed by Jer Noble.
2644
2645         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2646         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2647
2648 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2649
2650         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
2651         https://bugs.webkit.org/show_bug.cgi?id=207696
2652
2653         Reviewed by Tim Horton.
2654
2655         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2656
2657 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2658
2659         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
2660         https://bugs.webkit.org/show_bug.cgi?id=207680
2661         <rdar://problem/59340940>
2662
2663         Reviewed by Tim Horton.
2664
2665         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
2666         the current selection works.
2667
2668         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2669         (-[TestWKWebView updateSelectionWithExtentPoint:]):
2670         * TestWebKitAPI/ios/UIKitSPI.h:
2671
2672 2020-02-13  Said Abou-Hallawa  <said@apple.com>
2673
2674         Unreviewed, rolling out r255158, 255405 and r255486
2675
2676         Caused test flakiness and PLT regression.
2677
2678         * DumpRenderTree/mac/DumpRenderTree.mm:
2679         (resetWebPreferencesToConsistentValues):
2680         * DumpRenderTree/win/DumpRenderTree.cpp:
2681         (enableExperimentalFeatures):
2682         * WebKitTestRunner/TestController.cpp:
2683         (WTR::TestController::resetPreferencesToConsistentValues):
2684
2685 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2686
2687         run-javascriptcore-tests: Allow insecure requests on upload
2688         https://bugs.webkit.org/show_bug.cgi?id=207662
2689
2690         Rubber-stamped by Aakash Jain.
2691
2692         * Scripts/run-javascriptcore-tests:
2693         (uploadResults): Allow insecure curl request when posting results.
2694
2695 2020-02-12  Truitt Savell  <tsavell@apple.com>
2696
2697         Unreviewed, rolling out r256463.
2698
2699         Caused major flakiness on Mac wk2
2700
2701         Reverted changeset:
2702
2703         "REGRESSION (r255158): http/tests/frame-throttling/raf-
2704         throttle-in-cross-origin-subframe.html is a flaky failure"
2705         https://bugs.webkit.org/show_bug.cgi?id=206839
2706         https://trac.webkit.org/changeset/256463
2707
2708 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2709
2710         results.webkit.org: Remove debug JS logging
2711         https://bugs.webkit.org/show_bug.cgi?id=207663
2712
2713         Reviewed by Aakash Jain.
2714
2715         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2716         (elapsed):
2717         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2718         (_ToolTip.prototype.toString):
2719         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2720         (prototype.addWithDelay):
2721         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
2722
2723 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
2724
2725         Remove CSS_DEVICE_ADAPTATION
2726         https://bugs.webkit.org/show_bug.cgi?id=203479
2727
2728         Reviewed by Tim Horton.
2729         
2730         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
2731         so remove the code.
2732
2733         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2734
2735 2020-02-12  Said Abou-Hallawa  <said@apple.com>
2736
2737         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
2738         https://bugs.webkit.org/show_bug.cgi?id=206839
2739
2740         Reviewed by Simon Fraser.
2741
2742         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
2743
2744         * DumpRenderTree/mac/DumpRenderTree.mm:
2745         (resetWebPreferencesToConsistentValues):
2746         * DumpRenderTree/win/DumpRenderTree.cpp:
2747         (enableExperimentalFeatures):
2748         * WebKitTestRunner/TestController.cpp:
2749         (WTR::TestController::resetPreferencesToConsistentValues):
2750
2751 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2752
2753         results.webkit.org: Cache archive content
2754         https://bugs.webkit.org/show_bug.cgi?id=207589
2755
2756         Reviewed by Aakash Jain.
2757
2758         * resultsdbpy/resultsdbpy/flask_support/util.py:
2759         (cache_for): Add decorator function which sets the cache values on the returned response.
2760         * resultsdbpy/resultsdbpy/view/archive_view.py:
2761         (ArchiveView): Cache archive content client-side for 12 hours.
2762         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
2763         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
2764
2765 2020-02-12  Youenn Fablet  <youenn@apple.com>
2766
2767         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2768         https://bugs.webkit.org/show_bug.cgi?id=207537
2769
2770         Reviewed by Chris Dumez.
2771
2772         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2773
2774 2020-02-11  Rob Buis  <rbuis@igalia.com>
2775
2776         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
2777         <https://webkit.org/b/207424>
2778         <rdar://problem/59250384>
2779
2780         Reviewed by Rob Buis.
2781
2782         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2783         (TestWebKitAPI::TEST): Add more tests.
2784
2785 2020-02-11  Commit Queue  <commit-queue@webkit.org>
2786
2787         Unreviewed, rolling out r256314.
2788         https://bugs.webkit.org/show_bug.cgi?id=207594
2789
2790         It is breaking an API test (Requested by youenn on #webkit).
2791
2792         Reverted changeset:
2793
2794         "WebSWServerConnection::registerServiceWorkerClient is not
2795         sending IPC message to UIProcess when it should"
2796         https://bugs.webkit.org/show_bug.cgi?id=207537
2797         https://trac.webkit.org/changeset/256314
2798
2799 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
2800
2801         results.webkit.org: Configuration documentation should include architecture
2802         https://bugs.webkit.org/show_bug.cgi?id=207584
2803
2804         Reviewed by Aakash Jain.
2805
2806         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
2807
2808 2020-02-11  Youenn Fablet  <youenn@apple.com>
2809
2810         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
2811         https://bugs.webkit.org/show_bug.cgi?id=207325
2812         <rdar://problem/59224810>
2813
2814         Reviewed by Eric Carlson.
2815
2816         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2817         (TestWebKitAPI::TEST):
2818         Add a test validating that RTCRtpSender.getCapabilities does not return null.
2819         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2820
2821 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2822
2823         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
2824         https://bugs.webkit.org/show_bug.cgi?id=207557
2825
2826         Reviewed by Jonathan Bedard.
2827
2828         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
2829         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
2830         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
2831         around this by focusing an empty select element instead (for which we won't attempt to create and select any
2832         table view cells).
2833
2834         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2835
2836 2020-02-11  Alex Christensen  <achristensen@webkit.org>
2837
2838         Add WKHTTPCookieStore._getCookiesForURL SPI
2839         https://bugs.webkit.org/show_bug.cgi?id=207527
2840
2841         Reviewed by Brady Eidson.
2842
2843         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2844         (TEST):
2845
2846 2020-02-11  Youenn Fablet  <youenn@apple.com>
2847
2848         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2849         https://bugs.webkit.org/show_bug.cgi?id=207537
2850
2851         Reviewed by Chris Dumez.
2852
2853         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2854
2855 2020-02-11  Lauro Moura  <lmoura@igalia.com>
2856
2857         [WPE][WebDriver] MiniBrowser should react to close session commands
2858         https://bugs.webkit.org/show_bug.cgi?id=207529
2859
2860         Reviewed by Carlos Garcia Campos.
2861
2862         WebDriver delete session command asks to close the WebView associated to the
2863         current automation session. We must react to it to avoid lots of
2864         timeouts and errors.
2865
2866         * MiniBrowser/wpe/main.cpp:
2867         (main): Listen to "close" signal on the main WebView.
2868
2869 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2870
2871         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
2872         https://bugs.webkit.org/show_bug.cgi?id=207525
2873         <rdar://problem/59110543>
2874
2875         Reviewed by Tim Horton.
2876
2877         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
2878         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
2879         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
2880         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
2881         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
2882         causing us to crash upon trying to create the dictionary.
2883
2884         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
2885         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
2886         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
2887         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
2888         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
2889         beginning of each API test.
2890
2891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2892         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2893         (overrideBundleIdentifier):
2894
2895         Move this to the top of the file, so it can be shared.
2896
2897         (+[WKWebView initialize]):
2898
2899         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
2900         internal class method that calls into the internal helper function, with no other side effects.
2901
2902         * TestWebKitAPI/ios/UIKitSPI.h:
2903
2904 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2905
2906         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
2907         https://bugs.webkit.org/show_bug.cgi?id=207501
2908         <rdar://problem/59323414>
2909
2910         Reviewed by Alex Christensen.
2911
2912         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2913         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
2914         The same behavior.
2915
2916 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
2917
2918         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
2919         https://bugs.webkit.org/show_bug.cgi?id=207352
2920         <rdar://problem/59115798>
2921
2922         Reviewed by Alex Christensen.
2923
2924         Add a test to exercise the new SPI.
2925
2926         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
2927         a webpage that contains text in subframes.
2928
2929
2930 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2931
2932         [iOS] Crash when granting access to asset services
2933         https://bugs.webkit.org/show_bug.cgi?id=207520
2934
2935         Reviewed by Brent Fulgham.
2936
2937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2938         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
2939         (TEST):
2940
2941 2020-02-10  Chris Dumez  <cdumez@apple.com>
2942
2943         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
2944         https://bugs.webkit.org/show_bug.cgi?id=207481
2945
2946         Reviewed by Alexey Proskuryakov.
2947
2948         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
2949         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
2950         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
2951
2952         * DumpRenderTree/mac/DumpRenderTree.mm:
2953         (resetWebViewToConsistentStateBeforeTesting):
2954         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
2955         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
2956         over internal settings.
2957
2958 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2959
2960         [watchOS] Notification listener is never unregistered
2961         https://bugs.webkit.org/show_bug.cgi?id=207459
2962
2963         Reviewed by Maciej Stachowiak.
2964
2965         Add a test which tests that posting a backlight level change notification will not cause a crash.
2966
2967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2968         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
2969         (TEST):
2970
2971 2020-02-10  James Howard  <jameshoward@mac.com>
2972
2973         Standard gamepad mapping for GameControllerGamepads
2974         https://bugs.webkit.org/show_bug.cgi?id=206033
2975
2976         Reviewed by Dean Jackson.
2977
2978         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2979         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2980         (WTR::TestRunner::setMockGamepadDetails):
2981         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2982         * WebKitTestRunner/TestInvocation.cpp:
2983         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2984
2985 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2986
2987         [ews] Display flaky layout test names in build summary
2988         https://bugs.webkit.org/show_bug.cgi?id=207504
2989
2990         Reviewed by Jonathan Bedard.
2991
2992         * BuildSlaveSupport/ews-build/steps.py:
2993         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
2994         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
2995         (AnalyzeLayoutTestsResults.start):
2996
2997 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2998
2999         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
3000         https://bugs.webkit.org/show_bug.cgi?id=207492
3001
3002         Reviewed by Jonathan Bedard.
3003
3004         * BuildSlaveSupport/ews-build/steps.py:
3005         (RunWebKitTests.evaluateCommand):
3006         (ReRunWebKitTests.evaluateCommand):
3007         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3008         * BuildSlaveSupport/ews-build/factories.py:
3009         (TestFactory.__init__):
3010
3011 2020-02-10  Truitt Savell  <tsavell@apple.com>
3012
3013         Unreviewed, rolling out r256091.
3014
3015         Broke internal builds
3016
3017         Reverted changeset:
3018
3019         "Move trivial definitions from FeatureDefines.xcconfig to
3020         PlatformEnableCocoa.h"
3021         https://bugs.webkit.org/show_bug.cgi?id=207155
3022         https://trac.webkit.org/changeset/256091
3023
3024 2020-02-10  Truitt Savell  <tsavell@apple.com>
3025
3026         Unreviewed, rolling out r256103.
3027
3028         This patch is blocking the rollout of r256091
3029
3030         Reverted changeset:
3031
3032         "Move JavaScriptCore related feature defines from
3033         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
3034         https://bugs.webkit.org/show_bug.cgi?id=207436
3035         https://trac.webkit.org/changeset/256103
3036
3037 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3038
3039         results.webkit.org: Abstract archive storage solutions
3040         https://bugs.webkit.org/show_bug.cgi?id=207277
3041
3042         Rubber-stamped by Aakash Jain.
3043
3044         * resultsdbpy/resultsdbpy/model/archive_context.py:
3045         (ArchiveContext):
3046         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
3047         (ArchiveContext.__init__): Add archiver member.
3048         (ArchiveContext.__enter__): archiver is a context manager.
3049         (ArchiveContext.__exit__): Ditto.
3050         (ArchiveContext.register): The archiver member owns saving an archive.
3051         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
3052         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
3053         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
3054         (Archiver): Base class for all Archiving systems.
3055         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
3056         (Archiver.archive_size): Given a file-like archive, calculate it's size.
3057         (Archiver.save):
3058         (Archiver.retrieve):
3059         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
3060         (CassandraArchiver):
3061         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
3062         (CassandraArchiver.__init__):
3063         (CassandraArchiver.__enter__):
3064         (CassandraArchiver.__exit__):
3065         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
3066         from ArchiveContext.
3067         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
3068         from ArchiveContext.
3069
3070 2020-02-09  Lauro Moura  <lmoura@igalia.com>
3071
3072         [GTK][WPE] Expose allowTopNavigationToDataURL
3073         https://bugs.webkit.org/show_bug.cgi?id=207384
3074
3075         Reviewed by Adrian Perez de Castro.
3076
3077         Updates with new "allow-top-navigation-to-data-urls" property.
3078
3079         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3080         (testWebViewAllowModalDialogs): This test requires this property to be
3081         set.
3082         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3083         (testWebKitSettings): Added tests for getter/setter.
3084
3085 2020-02-08  Sam Weinig  <weinig@apple.com>
3086
3087         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3088         https://bugs.webkit.org/show_bug.cgi?id=207436
3089
3090         Reviewed by Tim Horton.
3091
3092         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3093         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
3094
3095 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
3096
3097         [WTF] Try using 75% load factor for HashTable
3098         https://bugs.webkit.org/show_bug.cgi?id=207183
3099
3100         Reviewed by Mark Lam.
3101
3102         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3103         (TestWebKitAPI::testInitialCapacity):
3104
3105 2020-02-08  Sam Weinig  <weinig@apple.com>
3106
3107         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3108         https://bugs.webkit.org/show_bug.cgi?id=207155
3109
3110         Reviewed by Tim Horton.
3111
3112         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3113         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3114         also has a default value in PlatformEnable.h
3115
3116         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3117
3118 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3119
3120         Several iOS API tests that call -makeKeyWindow assert after r255907
3121         https://bugs.webkit.org/show_bug.cgi?id=207411
3122
3123         Reviewed by Tim Horton.
3124
3125         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
3126         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
3127         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
3128         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
3129
3130         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3131         (TestWebKitAPI::TEST):
3132         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
3133         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3134         (overrideBundleIdentifier):
3135         (setOverriddenApplicationKeyWindow):
3136
3137 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3138
3139         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
3140         https://bugs.webkit.org/show_bug.cgi?id=207405
3141
3142         Reviewed by Wenson Hsieh.
3143
3144         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3145
3146 2020-02-07  Alex Christensen  <achristensen@apple.com>
3147
3148         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
3149         https://bugs.webkit.org/show_bug.cgi?id=207409
3150         rdar://problem/59275641
3151
3152         Reviewed by Chris Dumez.
3153
3154         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3155         (TestWebKitAPI::TEST):
3156
3157 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
3158
3159         Unreviewed, rolling out r256051.
3160
3161         Broke internal builds.
3162
3163         Reverted changeset:
3164
3165         "Move trivial definitions from FeatureDefines.xcconfig to
3166         PlatformEnableCocoa.h"
3167         https://bugs.webkit.org/show_bug.cgi?id=207155
3168         https://trac.webkit.org/changeset/256051
3169
3170 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3171
3172         iPad testers failing to launch processes
3173         https://bugs.webkit.org/show_bug.cgi?id=207401
3174         <rdar://problem/58184777>
3175
3176         Unreviewed infrastructure fix.
3177
3178         This is a speculative fix because I've had problems reproducing this error.
3179         The only time I managed to reproduce the problem was immediately after killing the 
3180         SimulatorTrampoline and CoreSimulator.xpc processes.
3181
3182         * BuildSlaveSupport/kill-old-processes:
3183         (main): Only kill Simulator.app, not all associated simulator processes.
3184
3185 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
3186
3187         [WebAuthn] Report CTAP Client Pin Error to clients
3188         https://bugs.webkit.org/show_bug.cgi?id=205837
3189         <rdar://problem/58356872>
3190
3191         Reviewed by Brent Fulgham.
3192
3193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3194         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3195         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3196         (TestWebKitAPI::TEST):
3197         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3198         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
3199         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3200         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3201         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
3202         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3203         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
3204         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
3205
3206 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3207
3208         run-safari Doesn't work with the latest Xcode version and iOS
3209         https://bugs.webkit.org/show_bug.cgi?id=207394
3210
3211         Reviewed by Ryosuke Niwa.
3212
3213         * Scripts/webkitdirs.pm:
3214         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
3215         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
3216
3217 2020-02-07  Daniel Bates  <dabates@apple.com>
3218
3219         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
3220         https://bugs.webkit.org/show_bug.cgi?id=207366
3221
3222         Reviewed by Brent Fulgham.
3223
3224         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
3225         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
3226         as the actual test instead of under a platform-specific directory even when the tests' behavior
3227         depends on the link-time version of WebKit.
3228
3229         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
3230         and toggling them in a test.
3231
3232         * DumpRenderTree/mac/DumpRenderTree.mm:
3233         (setDefaultsToConsistentValuesForTesting):
3234
3235 2020-02-03  Sam Weinig  <weinig@apple.com>
3236
3237         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3238         https://bugs.webkit.org/show_bug.cgi?id=207155
3239
3240         Reviewed by Tim Horton.
3241
3242         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3243         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3244         also has a default value in PlatformEnable.h
3245
3246         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3247
3248 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
3249
3250         Update WebView category name to be more accurate
3251         https://bugs.webkit.org/show_bug.cgi?id=207334
3252         <rdar://problem/59224855>
3253
3254         Reviewed by Brent Fulgham.
3255
3256         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
3257         (TEST):
3258
3259 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
3260
3261         [ews] add commit-queue build step to close the bug
3262         https://bugs.webkit.org/show_bug.cgi?id=207387
3263
3264         Reviewed by Jonathan Bedard.
3265
3266         * BuildSlaveSupport/ews-build/steps.py:
3267         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
3268         (CloseBug): Build step to close bugzilla bug.
3269
3270 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
3271
3272         [ews] add commit-queue build step to clear flags on patch
3273         https://bugs.webkit.org/show_bug.cgi?id=206536
3274
3275         Reviewed by Jonathan Bedard.
3276
3277         * BuildSlaveSupport/ews-build/steps.py:
3278         (BugzillaMixin): Class for common bugzilla related methods.
3279         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
3280         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
3281         (ValidatePatch):
3282         (RemoveFlagsOnPatch): Class to remove flags on patch.
3283         (RemoveFlagsOnPatch.start):
3284         (ValidatePatch._addToLog): Moved.
3285         (ValidatePatch.fetch_data_from_url): Moved.
3286         (ValidatePatch.get_patch_json): Moved.
3287         (ValidatePatch.get_bug_json): Moved.
3288         (ValidatePatch.get_bug_id_from_patch): Moved.
3289         (ValidatePatch._is_patch_obsolete): Moved.
3290         (ValidatePatch._is_patch_review_denied): Moved.
3291         (ValidatePatch._is_patch_cq_plus): Moved.
3292         (ValidatePatch._is_bug_closed): Moved.
3293
3294 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3295
3296         EWS should run resultsdbpy tests
3297         https://bugs.webkit.org/show_bug.cgi?id=201928
3298
3299         Reviewed by Aakash Jain.
3300
3301         * BuildSlaveSupport/ews-build/factories.py:
3302         (ServicesFactory.__init__): Add RunResultsdbpyTests.
3303         * BuildSlaveSupport/ews-build/factories_unittest.py:
3304         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
3305         * BuildSlaveSupport/ews-build/steps.py:
3306         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
3307         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
3308         * BuildSlaveSupport/ews-build/steps_unittest.py:
3309         (TestRunResultsdbpyTests):
3310         (TestRunResultsdbpyTests.setUp):
3311         (TestRunResultsdbpyTests.tearDown):
3312         (TestRunResultsdbpyTests.test_success):
3313         (TestRunResultsdbpyTests.test_failure):
3314
3315 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
3316
3317         Adding myself to contributors.json
3318         
3319         Unreviewed
3320
3321         * Scripts/webkitpy/common/config/contributors.json:
3322
3323 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
3324
3325         Adding myself to contributors.json
3326         
3327         Unreviewed
3328
3329         * Scripts/webkitpy/common/config/contributors.json:
3330
3331 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
3332
3333         [GTK][WPE] Add same-site cookie support
3334         https://bugs.webkit.org/show_bug.cgi?id=204137
3335
3336         Reviewed by Carlos Garcia Campos.
3337
3338         Update libsoup to 2.69.90 in JHBuild.
3339
3340         * gtk/jhbuild.modules:
3341         * wpe/jhbuild.modules:
3342
3343 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
3344
3345         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
3346         https://bugs.webkit.org/show_bug.cgi?id=207183
3347
3348         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3349         (TestWebKitAPI::testInitialCapacity):
3350
3351 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3352
3353         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
3354         https://bugs.webkit.org/show_bug.cgi?id=207350
3355         <rdar://problem/59239914>
3356
3357         Reviewed by Tim Horton.
3358
3359         Add a test to exercise the corner case in the SPI.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
3363
3364 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
3365
3366         Adopt new SOAuthorizationOption constants
3367         https://bugs.webkit.org/show_bug.cgi?id=207186
3368         <rdar://problem/48909336>
3369
3370         Reviewed by Brent Fulgham.
3371
3372         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3373         (checkAuthorizationOptions):
3374
3375 2020-02-06  Brady Eidson  <beidson@apple.com>
3376
3377         Cleanup and promote WKContentWorld and its clients in WKWebView.
3378         https://bugs.webkit.org/show_bug.cgi?id=207351
3379
3380         Reviewed by Alex Christensen.
3381
3382         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
3383         (TestWebKitAPI::TEST):
3384         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3385         (TEST):
3386         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3387         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
3388
3389 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3390
3391         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
3392         https://bugs.webkit.org/show_bug.cgi?id=207250
3393
3394         Reviewed by Alex Christensen.
3395
3396         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
3397         reload. However, they don't work unless the main window is
3398         focused.
3399
3400         Ctrl-W should be processed differently. Ctrl-W should be handled
3401         without dispatching to WebKit, others should be handled only when
3402         WebKit didn't consume. So, this change split the accelerator table
3403         into two, one is for Ctrl-W, another is for other shortcut keys.
3404
3405         For Ctrl-W, key events are processed before dispatching to
3406         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
3407         dispatched to WebView. WebKit2 WebView bubbles up unhandled
3408         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
3409         in the main window's WndProc. However, it doesn't work for WebKit1
3410         because this change doesn't add the bubbling up code to WebKit1
3411         WebView.
3412
3413         For other shortcut keys, for example Ctrl-R, key events are
3414         dispatched to WebView without accelerator key translations. Then,
3415         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
3416         aren't consumed. didNotHandleKeyEvent posts the messasge to the
3417         main window. The message loop processed key events dispatched to
3418         the main window with another accelerator table. However, it
3419         doesn't work for WebKit1, because WebKit1 doesn't have a API
3420         equivalent to didNotHandleKeyEvent.
3421
3422         After switching the active window by pressing Alt-Tab and
3423         reactivating the main window, the main window got the focus. This
3424         was the reason shortcut keys worked only after reactivating the
3425         main window. But, this is not the desired behavior after this
3426         change because other shortcut keys don't work if the main window
3427         is focused. So. set the focus to the brower window when
3428         WM_ACTIVATE of the main window.
3429
3430         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
3431         effective only for keyboard numpad. Add VK_OEM_MINUS and
3432         VK_OEM_PLUS for them.
3433
3434         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
3435
3436         * MiniBrowser/win/MainWindow.cpp:
3437         (MainWindow::isInstance):
3438         (MainWindow::WndProc):
3439         * MiniBrowser/win/MainWindow.h:
3440         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
3441         IDR_ACCELERATORS_PRE for Ctrl-W.
3442         * MiniBrowser/win/MiniBrowserLibResource.h:
3443         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3444         (WebKitBrowserWindow::didNotHandleKeyEvent):
3445         * MiniBrowser/win/WinMain.cpp:
3446         (wWinMain):
3447
3448 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
3449
3450         results.webkitorg: Dead CI links
3451         https://bugs.webkit.org/show_bug.cgi?id=207340
3452
3453         Reviewed by Alexey Proskuryakov.
3454
3455         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
3456         (Configuration.prototype.toParams): Version name and version number often duplicate the
3457         same information, exception version number is often more specific than is useful.
3458
3459 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
3460
3461         Prevent navigating top level frames to Data URLs
3462         https://bugs.webkit.org/show_bug.cgi?id=206962
3463         <rdar://problem/56770676>
3464
3465         Reviewed by Youenn Fablet.
3466
3467         Revise test running code to allow data URL navigations by default, since they are so frequently
3468         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
3469         function.
3470
3471         * DumpRenderTree/TestOptions.cpp:
3472         (TestOptions::TestOptions):
3473         * DumpRenderTree/TestOptions.h:
3474         * DumpRenderTree/mac/DumpRenderTree.mm:
3475         (setWebPreferencesForTestOptions):
3476         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3477         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
3478         (StartDownloadWithDownloadAttribute): Ditto.
3479         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3480         (WebViewWillPerformClientRedirect): Ditto.
3481         (WebViewDidCancelClientRedirect): Ditto.
3482         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3483         (NavigateToDataURLThenBack): Ditto.
3484         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
3485         * WebKitTestRunner/TestController.cpp:
3486         (WTR::TestController::resetPreferencesToConsistentValues):
3487         (WTR::updateTestOptionsFromTestHeader):
3488         * WebKitTestRunner/TestOptions.h:
3489         (WTR::TestOptions::hasSameInitializationOptions const):
3490         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3491         (WTR::initializeWebViewConfiguration):
3492         (WTR::TestController::platformCreateWebView):
3493
3494 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3495
3496         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
3497         https://bugs.webkit.org/show_bug.cgi?id=207272
3498         <rdar://problem/59190828>
3499
3500         Reviewed by Tim Horton.
3501
3502         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
3503         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
3504         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
3505
3506         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3507         (TestWebKitAPI::overrideBundleIdentifier):
3508         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3509         (setOverriddenApplicationKeyWindow):
3510         (applicationKeyWindowOverride):
3511         (-[TestWKWebViewHostWindow makeKeyWindow]):
3512         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3513         * TestWebKitAPI/ios/UIKitSPI.h:
3514
3515         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
3516         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
3517
3518 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
3519
3520         [PlayStation] Build a shared JavaScriptCore
3521         https://bugs.webkit.org/show_bug.cgi?id=198446
3522
3523         Reviewed by Fujii Hironori.
3524
3525         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
3526
3527         * TestWebKitAPI/PlatformPlayStation.cmake:
3528
3529 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
3530
3531         [WinCairo] Set up fonts for layout tests for test bot image
3532         https://bugs.webkit.org/show_bug.cgi?id=207223
3533
3534         Reviewed by Fujii Hironori.
3535
3536         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
3537           Implement activateFonts to load fonts for test
3538
3539 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
3540
3541         [PlayStation] Miscellaneous build fixes February 2020 edition
3542         https://bugs.webkit.org/show_bug.cgi?id=207312
3543
3544         Unreviewed build fix.
3545
3546         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
3547
3548 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
3549
3550         [WTF] Try using 75% load factor for HashTable
3551         https://bugs.webkit.org/show_bug.cgi?id=207183
3552
3553         Reviewed by Mark Lam.
3554
3555         Fix load-factor assumption in existing tests.
3556
3557         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3558         (TestWebKitAPI::testInitialCapacity):
3559
3560 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3561
3562         resulsdbpy: Fix unit tests
3563         https://bugs.webkit.org/show_bug.cgi?id=207304
3564
3565         Reviewed by Aakash Jain.
3566
3567         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
3568         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
3569         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
3570         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
3571         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
3572         (FailureContextTest.test_unexpected_failures): Ditto.
3573         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
3574         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
3575         of knowing how expensive the callback may be.
3576
3577 2020-02-05  Chris Dumez  <cdumez@apple.com>
3578
3579         Unreviewed, another build fix after r255846
3580
3581         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3582
3583 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3584
3585         Unreviewed infrastructure fix.
3586
3587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3588         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
3589
3590 2020-02-05  Chris Dumez  <cdumez@apple.com>
3591
3592         Unreviewed build fix after r255846.
3593
3594         * TestWebKitAPI/cocoa/HTTPServer.h:
3595
3596 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
3597
3598         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
3599         https://bugs.webkit.org/show_bug.cgi?id=207173
3600         <rdar://problem/55669065>
3601
3602         Reviewed by Brent Fulgham.
3603
3604         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3605         (TestWebKitAPI::TEST):
3606         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3607         (-[TestWKWebView _setUpTestWindow:]):
3608         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
3609
3610 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3611
3612         results.webkit.org: Apply ttl to archive shards
3613         https://bugs.webkit.org/show_bug.cgi?id=207295
3614
3615         Rubber-stamped by Aakash Jain.
3616
3617         * resultsdbpy/resultsdbpy/model/archive_context.py:
3618         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
3619         (ArchiveContext.ArchiveChunks): Use new table.
3620         (ArchiveContext.register): Add ttl to archive shards.
3621
3622 2020-02-05  Alex Christensen  <achristensen@webkit.org>
3623
3624         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
3625         https://bugs.webkit.org/show_bug.cgi?id=207207
3626
3627         Reviewed by Chris Dumez.
3628
3629         HTTPServer now supports HTTPS. Tell your friends!
3630
3631         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3632         (testCertificate):
3633         (testIdentity):
3634         (credentialWithIdentity):
3635         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3636         (TestWebKitAPI::webViewWithNavigationDelegate):
3637         (TestWebKitAPI::TEST):
3638         * TestWebKitAPI/cocoa/HTTPServer.h:
3639         * TestWebKitAPI/cocoa/HTTPServer.mm:
3640         (TestWebKitAPI::HTTPServer::HTTPServer):
3641         (TestWebKitAPI::HTTPServer::request const):
3642
3643 2020-02-05  Brady Eidson  <beidson@apple.com>
3644
3645         _WKDownload should expose the originating FrameInfo.
3646         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
3647
3648         Reviewed by Geoff Garen.
3649
3650         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3651         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3652         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
3653         (loaded):
3654         * TestWebKitAPI/cocoa/HTTPServer.mm:
3655
3656 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3657
3658         [GTK] Fix dependencies build
3659         https://bugs.webkit.org/show_bug.cgi?id=207273
3660
3661         Reviewed by Carlos Garcia Campos.
3662
3663         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
3664         added mesa as one of its deps. Added the xserver patch as well.
3665         * gtk/patches/xserver-gl-version.patch: Added.
3666
3667 2020-02-05  Chris Dumez  <cdumez@apple.com>
3668
3669         REGRESSION(r255595): page not closed after beforeunload handler returns true
3670         https://bugs.webkit.org/show_bug.cgi?id=207189
3671         <rdar://problem/59149593>
3672
3673         Reviewed by Youenn Fablet.
3674
3675         Add API test coverage for fix landed in r255677.
3676
3677         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3678         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3679         (TEST):
3680
3681 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3682
3683         results.webkit.org should disable auto-capitalize over the search field
3684         https://bugs.webkit.org/show_bug.cgi?id=207240
3685         <rdar://problem/59053042>
3686
3687         Rubber-stamped by Aakash Jain.
3688
3689         * resultsdbpy/resultsdbpy/view/static/js/search.js:
3690
3691 2020-02-01  Darin Adler  <darin@apple.com>
3692
3693         Replace RGBA32 typedef with a class to improve type safety
3694         https://bugs.webkit.org/show_bug.cgi?id=206862
3695
3696         Reviewed by Sam Weinig.
3697
3698         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
3699         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
3700
3701 2020-02-04  Darin Adler  <darin@apple.com>
3702
3703         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
3704         https://bugs.webkit.org/show_bug.cgi?id=207203
3705
3706         Reviewed by Anders Carlsson.
3707
3708         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
3709         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
3710         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
3711         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
3712         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
3713
3714 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3715
3716         results.webkit.org: Support Internal in run-javascriptcore-tests
3717         https://bugs.webkit.org/show_bug.cgi?id=204095
3718
3719         Rubber-stamped by Aakash Jain.
3720
3721         * Scripts/VCSUtils.pm:
3722         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
3723         (gitBranchForDirectory): Compute branch for directory.
3724         (gitBranch): Compute branch for the current git directory.
3725         (commitForDirectory): Add git support.
3726         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
3727         * Scripts/run-javascriptcore-tests:
3728         (uploadResults): Check for Internal repository.
3729
3730 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3731
3732         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
3733         https://bugs.webkit.org/show_bug.cgi?id=207204
3734
3735         Reviewed by Simon Fraser.
3736
3737         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
3738         in LLDB's python API.
3739
3740         * lldb/lldb_webkit_unittest.py:
3741         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
3742         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
3743         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3744
3745 2020-02-04  Lauro Moura  <lmoura@igalia.com>
3746
3747         [EWS] Stop GTK/WPE build if jhbuild fails.
3748         https://bugs.webkit.org/show_bug.cgi?id=207220
3749
3750         Reviewed by Adrian Perez de Castro.
3751
3752         * BuildSlaveSupport/ews-build/steps.py:
3753         (InstallGtkDependencies): Halt on failure
3754         (InstallWpeDependencies): Ditto
3755
3756 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3757
3758         Fix Mac CMake build
3759         https://bugs.webkit.org/show_bug.cgi?id=207231
3760
3761         * DumpRenderTree/PlatformMac.cmake:
3762         * MiniBrowser/mac/CMakeLists.txt:
3763         * MiniBrowser/mac/WK2BrowserWindowController.m:
3764         (-[WK2BrowserWindowController awakeFromNib]):
3765         * WebKitTestRunner/PlatformMac.cmake:
3766
3767 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
3768
3769         [PlayStation] Enable TestWebKit
3770         https://bugs.webkit.org/show_bug.cgi?id=207211
3771
3772         Reviewed by Ross Kirsling.
3773
3774         Stub out PlayStation implementation of TestWebKit so it builds.
3775
3776         * TestWebKitAPI/PlatformPlayStation.cmake:
3777         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
3778         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
3779         (TestWebKitAPI::Util::createInjectedBundlePath):
3780         (TestWebKitAPI::Util::createURLForResource):
3781         (TestWebKitAPI::Util::URLForNonExistentResource):
3782         (TestWebKitAPI::Util::isKeyDown):
3783         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
3784         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3785         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3786         (TestWebKitAPI::PlatformWebView::initialize):
3787         (TestWebKitAPI::PlatformWebView::page const):
3788         (TestWebKitAPI::PlatformWebView::resizeTo):
3789         (TestWebKitAPI::PlatformWebView::focus):
3790         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3791         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3792         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3793         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3794
3795 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3796
3797         results.webkit.org: Support branches in run-javascriptcore-tests
3798         https://bugs.webkit.org/show_bug.cgi?id=204094
3799
3800         Rubber-stamped by Aakash Jain.
3801
3802         * Scripts/run-javascriptcore-tests:
3803         (uploadResults): Use webkitdirs function to generate commit information.
3804         * Scripts/VCSUtils.pm:
3805         (commitForDirectory): Generate commit information for SVN repository, including
3806         branch name.
3807
3808 2020-02-04  Matt Lewis  <jlewis3@apple.com>
3809
3810         Replace bot677 due to hardware failure
3811         https://bugs.webkit.org/show_bug.cgi?id=207224
3812
3813         Reviewed by Aakash Jain.
3814
3815         * BuildSlaveSupport/build.webkit.org-config/config.json:
3816
3817 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3818
3819         TestWebKitAPI: Handle case where test result does not contain path
3820         https://bugs.webkit.org/show_bug.cgi?id=207216
3821
3822         Reviewed by Tim Horton.
3823
3824         * TestWebKitAPI/TestsController.cpp:
3825         (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
3826         will not contain a file name. We should handle this case.
3827
3828 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3829
3830         results.webkit.org: Better order upload callbacks
3831         https://bugs.webkit.org/show_bug.cgi?id=207219
3832
3833         Reviewed by Aakash Jain.
3834
3835         Order upload callbacks more deliberately so that the quickest callbacks
3836         that are least likely to link to information from unfinished callbacks are
3837         executed first.
3838
3839         * resultsdbpy/resultsdbpy/model/model.py:
3840         (Model.__init__): Generate buildbot links first, then generate a failure
3841         list, then generate the collective suite results and finally, individual
3842         test results.
3843
3844 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3845
3846         [EWS] Do not remove TestWebKitAPI prefix from api test failures
3847         https://bugs.webkit.org/show_bug.cgi?id=207210
3848
3849         Reviewed by Jonathan Bedard.
3850
3851         * BuildSlaveSupport/ews-build/steps.py:
3852         (AnalyzeAPITestsResults.analyzeResults):
3853
3854 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3855
3856         [EWS] Do not remove webkitpy prefix from test failures
3857         https://bugs.webkit.org/show_bug.cgi?id=207206
3858
3859         Reviewed by Jonathan Bedard.
3860
3861         * BuildSlaveSupport/ews-build/steps.py:
3862         (WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
3863         case when json output doesn't have failures/errors key.
3864         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3865
3866 2020-02-04  Ross Kirsling  <ross.kirsling@sony.com>
3867
3868         [CMake] Add Cairo::Cairo target
3869         https://bugs.webkit.org/show_bug.cgi?id=207159
3870
3871         Reviewed by Konstantin Tokarev.
3872
3873         * DumpRenderTree/PlatformWin.cmake:
3874         * ImageDiff/Cairo.cmake:
3875         * TestWebKitAPI/PlatformWPE.cmake:
3876         * TestWebKitAPI/PlatformWin.cmake:
3877         * TestWebKitAPI/glib/CMakeLists.txt:
3878         * WebKitTestRunner/PlatformGTK.cmake:
3879         * WebKitTestRunner/PlatformWPE.cmake:
3880         * WebKitTestRunner/PlatformWin.cmake:
3881         * wpe/backends/CMakeLists.txt:
3882
3883 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
3884
3885         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
3886         https://bugs.webkit.org/show_bug.cgi?id=207079
3887         <rdar://problem/48290464>
3888
3889         Reviewed by Brent Fulgham.
3890
3891         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3892         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3893         (overrideGetAuthorizationHintsWithURL):
3894         (TestWebKitAPI::TEST):
3895
3896 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3897
3898         results.webkit.org: Support jsc stress tests
3899         https://bugs.webkit.org/show_bug.cgi?id=204096
3900
3901         Rubber-stamped by Aakash Jain.
3902
3903         * Scripts/run-javascriptcore-tests:
3904         (runJSCStressTests): Add pass and failures to reported results.
3905
3906 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3907
3908         Make Bugzilla._find_select_element_for_flag more robust
3909         https://bugs.webkit.org/show_bug.cgi?id=207148
3910
3911         Reviewed by Jonathan Bedard.
3912
3913         This patch resolves two FIXMEs:
3914         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
3915         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
3916
3917         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3918         (Bugzilla._fill_attachment_form):
3919         (Bugzilla._find_select_element_for_flag):
3920
3921 2020-02-03  Alex Christensen  <achristensen@webkit.org>
3922
3923         Reduce size of HashMap and HashSet
3924         https://bugs.webkit.org/show_bug.cgi?id=207138
3925
3926         Reviewed by Yusuke Suzuki.
3927
3928         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3929         (TestWebKitAPI::TEST):
3930         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3931         (TestWebKitAPI::TEST):
3932
3933 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3934
3935         obsolete_attachment should not fail when flags do not exist
3936         https://bugs.webkit.org/show_bug.cgi?id=171121
3937
3938         Reviewed by Jonathan Bedard.
3939
3940         Before this change, an error occured if a contributor without EditBugs privileges tried
3941         to obsolete not their own attachment. With this patch, uploading routine continues with
3942         friendly console warning like we have in reassign_bug() method.
3943
3944         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3945         (Bugzilla):
3946         (Bugzilla.obsolete_attachment):
3947         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
3948
3949 2020-02-03  Chris Dumez  <cdumez@apple.com>
3950
3951         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
3952         https://bugs.webkit.org/show_bug.cgi?id=207121
3953         <rdar://problem/58880177>
3954
3955         Reviewed by Alex Christensen.
3956
3957         Add API test coverage.
3958
3959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3960         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
3961         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3962         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3963         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
3964         (TEST):
3965
3966 2020-02-03  Lauro Moura  <lmoura@igalia.com>
3967
3968         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
3969         https://bugs.webkit.org/show_bug.cgi?id=206517
3970
3971         Reviewed by Carlos Alberto Lopez Perez.
3972
3973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3974         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
3975         starts with a leading slash instead of using the test URL, which could
3976         cause input forms with invalid file data.
3977
3978 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
3979
3980         [ews] Set custom build summary for webkitpy tests
3981         https://bugs.webkit.org/show_bug.cgi?id=207027
3982
3983         Reviewed by Jonathan Bedard.
3984
3985         * BuildSlaveSupport/ews-build/factories.py:
3986         * BuildSlaveSupport/ews-build/steps.py:
3987         (WebKitPyTest.setBuildSummary):
3988         (WebKitPyTest.getResultSummary):
3989         * BuildSlaveSupport/ews-build/factories_unittest.py:
3990
3991 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3992
3993         run-javascriptcore-tests: Don't split binary results
3994         https://bugs.webkit.org/show_bug.cgi?id=207118
3995
3996         Rubber-stamped by Aakash Jain.
3997
3998         * Scripts/run-javascriptcore-tests:
3999         (runTest): Only report aggregated binary results.
4000
4001 2020-02-03  Chris Dumez  <cdumez@apple.com>
4002
4003         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
4004
4005         The ResponsivenessTimer is disabled for those configurations as of r255518.
4006
4007         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
4008
4009 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
4010
4011         Use std::hypot() where possible
4012         https://bugs.webkit.org/show_bug.cgi?id=198483
4013
4014         Reviewed by Carlos Garcia Campos.
4015
4016         Use std::hypot() where possible, allowing for a possibly more precise
4017         calculation of square roots of sums of two or three square values.
4018
4019         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4020         (-[DragAndDropSimulator initialProgressForMouseDrag]):
4021
4022 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
4023
4024         [JHBuild] remove libvpx
4025         https://bugs.webkit.org/show_bug.cgi?id=207103
4026
4027         Reviewed by Xabier Rodriguez-Calvar.
4028
4029         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
4030         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
4031
4032         * gstreamer/jhbuild.modules: remove libvpx.
4033
4034 2020-02-02  Sam Weinig  <weinig@apple.com>
4035
4036         Update style checker with new locations OS version checks are allowed
4037         https://bugs.webkit.org/show_bug.cgi?id=207106
4038
4039         Reviewed by Alexey Proskuryakov.
4040
4041         * Scripts/webkitpy/style/checkers/cpp.py:
4042         (check_os_version_checks):
4043         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4044         (WebKitStyleTest.test_os_version_checks):
4045         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
4046
4047 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
4048
4049         Closing a MiniBrowser WK2 window does not release the WKWebView
4050         https://bugs.webkit.org/show_bug.cgi?id=203185
4051
4052         Reviewed by Wenson Hsieh.
4053         
4054         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
4055         to avoid a retain cycle that keeps the window controller and WKWebView alive.
4056
4057         * MiniBrowser/mac/WK2BrowserWindowController.m:
4058         (-[WK2BrowserWindowController awakeFromNib]):
4059
4060 2020-01-31  David Quesada  <david_quesada@apple.com>
4061
4062         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
4063         https://bugs.webkit.org/show_bug.cgi?id=206984
4064         rdar://problem/58999654
4065
4066         Reviewed by Brady Eidson.
4067
4068         Add an API test for a resumed download that receives an authentication challenge. The download
4069         delegate should be asked to handle the challenge, and the download should be able to finish.
4070
4071         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4072         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4073         (-[DownloadCancelingDelegate _download:didReceiveData:]):
4074         (-[DownloadCancelingDelegate _downloadDidCancel:]):
4075         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
4076         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
4077         (TEST):
4078
4079 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
4080
4081         Add support for specifying background colors when setting marked text
4082         https://bugs.webkit.org/show_bug.cgi?id=207065
4083         <rdar://problem/57876140>
4084
4085         Reviewed by Tim Horton.
4086
4087         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
4088         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
4089         each describing one range (in the composition) to highlight.
4090
4091         * DumpRenderTree/ios/TextInputControllerIOS.m:
4092         (+[TextInputController isSelectorExcludedFromWebScript:]):
4093         (+[TextInputController webScriptNameForSelector:]):
4094         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
4095         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
4096         * DumpRenderTree/mac/TextInputControllerMac.m:
4097         (+[TextInputController isSelectorExcludedFromWebScript:]):
4098         (+[TextInputController webScriptNameForSelector:]):
4099         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
4100         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
4101         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
4102         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
4103         (WTR::arrayLength):
4104         (WTR::createCompositionHighlightData):
4105
4106         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
4107         is then passed into WebKit via WKBundlePageSetComposition.
4108
4109         (WTR::TextInputController::setMarkedText):
4110         * WebKitTestRunner/InjectedBundle/TextInputController.h:
4111
4112 2020-01-31  Alex Christensen  <achristensen@webkit.org>
4113
4114         Add KVO SPI WKWebView._negotiatedLegacyTLS
4115         https://bugs.webkit.org/show_bug.cgi?id=207067
4116
4117         Reviewed by Andy Estes.
4118
4119         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4120         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
4121         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
4122         (TestWebKitAPI::TEST):
4123         * TestWebKitAPI/config.h:
4124
4125 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
4126
4127         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
4128         https://bugs.webkit.org/show_bug.cgi?id=207050
4129
4130         Reviewed by Jonathan Bedard.
4131
4132         * BuildSlaveSupport/ews-build/steps.py:
4133         (ReRunWebKitTests.evaluateCommand):
4134
4135 2020-01-31  David Kilzer  <ddkilzer@apple.com>
4136
4137         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
4138         <https://webkit.org/b/206759>
4139         <rdar://problem/58872607>
4140
4141         Reviewed by Brent Fulgham.
4142
4143         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
4144         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
4145         - Add declaration.
4146         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4147         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
4148         - Implement by waiting for
4149           -[UIViewController isPerformingModalTransition] to return NO
4150           while spinning the runloop.
4151         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
4152         - Call waitForModalTransitionToFinish() to fix the test.
4153
4154 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
4155
4156         [ews] add build step to set custom build summary
4157         https://bugs.webkit.org/show_bug.cgi?id=207026
4158
4159         Reviewed by Jonathan Bedard.
4160
4161         * BuildSlaveSupport/ews-build/steps.py:
4162         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
4163         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
4164         (SetBuildSummary.start):
4165
4166 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
4167
4168         results.webkit.org: Handle modified firewall rules
4169         https://bugs.webkit.org/show_bug.cgi?id=207047
4170
4171         Reviewed by Aakash Jain.
4172
4173         * Scripts/webkitpy/results/upload.py:
4174         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
4175         indicating the upload failed.
4176         * Scripts/webkitpy/results/upload_unittest.py:
4177         (UploadTest.test_archive_upload):
4178
4179 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
4180
4181         Unreviewed, another speculative test fix after r255041
4182
4183         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4184         (WTR::TestController::addTestKeyToKeychain):
4185         Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
4186         potential error due to screen locks.
4187
4188 2020-01-30  Alex Christensen  <achristensen@webkit.org>
4189
4190         Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1
4191         https://bugs.webkit.org/show_bug.cgi?id=206979
4192
4193         Reviewed by Brady Eidson.
4194
4195         * MiniBrowser/mac/SettingsController.m:
4196         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4197         (-[TLSNavigationDelegate waitForDidFinishNavigation]):
4198         (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]):
4199         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]):
4200         (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4201         (-[TLSNavigationDelegate webView:didFinishNavigation:]):
4202         (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4203         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]):
4204         (TestWebKitAPI::TEST):
4205
4206 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
4207
4208         PAL: Remove old iOS version macros
4209         https://bugs.webkit.org/show_bug.cgi?id=206905
4210
4211         Reviewed by Darin Adler.
4212
4213         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Remove USE(NSPROGRESS_PUBLISHING_SPI)
4214         with HAVE(NSPROGRESS_PUBLISHING_SPI)
4215
4216 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
4217
4218         TestWebKitAPI: Re-baseline AccessibilityTests for Catalyst
4219         https://bugs.webkit.org/show_bug.cgi?id=206997
4220
4221         Reviewed by Wenson Hsieh.
4222
4223         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
4224         (TestWebKitAPI::TEST):
4225
4226 2020-01-29  Jonathan Bedard  <jbedard@apple.com>
4227
4228         run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
4229         https://bugs.webkit.org/show_bug.cgi?id=206932
4230
4231         Reviewed by Alexey Proskuryakov.
4232
4233         * Scripts/webkitpy/xcode/simulated_device.py:
4234         (SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
4235         some version will return a runtime of the same major version with a minor version
4236         that is equal to or greater than the specified minor version.
4237         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4238         (test_matching_up_success):
4239         (test_matching_up_failure):
4240
4241 2020-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4242
4243         [JSC] Give up IC when unknown structure transition happens
4244         https://bugs.webkit.org/show_bug.cgi?id=206846
4245
4246         Reviewed by Mark Lam.
4247
4248         Add `crash!` annotation, which allows us to write a crashing JS test.
4249
4250         * Scripts/run-jsc-stress-tests:
4251         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
4252         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
4253         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
4254
4255 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4256
4257         [GTK] Add api-gtk to EWS bubbles.
4258         https://bugs.webkit.org/show_bug.cgi?id=206930
4259
4260         Reviewed by Aakash Jain.
4261
4262         A new queue has been added to the EWS to run GTK API tests in r255238.
4263         The queue is now running fine with no pre-existent failures.
4264         Let's add it to the EWS bubbles.
4265
4266         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4267         (StatusBubble):
4268
4269 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4270
4271         [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
4272         https://bugs.webkit.org/show_bug.cgi?id=206927
4273
4274         Reviewed by Carlos Garcia Campos.
4275
4276         Update the default value tested from 4MB to 5MB.
4277
4278         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4279         (testsJSCOptions):
4280
4281 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4282
4283         [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
4284         https://bugs.webkit.org/show_bug.cgi?id=206925
4285
4286         Reviewed by Carlos Garcia Campos.
4287
4288         Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
4289         run the printing related GTK API tests. Add also the liberation fonts, which are needed to
4290         run the complex text controller API tests.
4291
4292         * gtk/install-dependencies:
4293         * wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
4294
4295 2020-01-28  Tim Horton  <timothy_horton@apple.com>
4296
4297         macCatalyst: Right clicking on a link follows it immediately
4298         https://bugs.webkit.org/show_bug.cgi?id=206919
4299         <rdar://problem/58936679>
4300
4301         Reviewed by Wenson Hsieh.
4302
4303         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:
4304         (TEST):
4305         Add a test ensuring that mouseup is still called with the secondary button,
4306         even if the event's buttonmask is 0.
4307
4308 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
4309
4310         TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
4311         https://bugs.webkit.org/show_bug.cgi?id=206913
4312         <rdar://problem/58973357>
4313
4314         Reviewed by Chris Dumez.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
4317
4318 2020-01-28  Tim Horton  <timothy_horton@apple.com>
4319
4320         macCatalyst: Triple clicking to select a sentence results in an empty selection
4321         https://bugs.webkit.org/show_bug.cgi?id=206863
4322         <rdar://problem/58776993>
4323
4324         Reviewed by Wenson Hsieh.