Adding a .ycm_extra_conf file for webkitGtk
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
2
3         Adding a .ycm_extra_conf file for webkitGtk
4         https://bugs.webkit.org/show_bug.cgi?id=119618
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
9         read the GTK+ build files to determine dynamically what flags to compile a source
10         file with. This allows Vim to provide auto-complete for C++/C language. See
11         https://github.com/Valloric/YouCompleteMe for how to use this file.
12
13         * gtk/common.py:
14         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
15         * gtk/ycm_extra_conf.py: Added.
16
17 2013-12-12  Tim Horton  <timothy_horton@apple.com>
18
19         [wk2] Handle pinch-to-zoom gesture
20         https://bugs.webkit.org/show_bug.cgi?id=125604
21
22         Reviewed by Simon Fraser.
23
24         * MiniBrowser/mac/WK2BrowserWindowController.m:
25         (-[WK2BrowserWindowController awakeFromNib]):
26         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
27
28 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
29
30         Unreviewed. Add myself as a committer.
31
32         * Scripts/webkitpy/common/config/contributors.json:
33
34 2013-12-12  Lucas Forschler  <lforschler@apple.com>
35
36         Update hardware for Apple bots.
37         
38         Unreviewed.
39
40         * BuildSlaveSupport/build.webkit.org-config/config.json:
41
42 2013-12-12  Lucas Forschler  <lforschler@apple.com>
43
44         Remove unused Apple Bots.
45         
46         Unreviewed.
47
48         * BuildSlaveSupport/build.webkit.org-config/config.json:
49
50 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
51
52         Unreviewed. Add myself as a committer.
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
57
58         Test new JSContext name APIs
59         https://bugs.webkit.org/show_bug.cgi?id=125607
60
61         Reviewed by Darin Adler.
62
63         * Scripts/run-javascriptcore-tests:
64         Remove trailing whitespace.
65
66 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
67
68         [Autotools] Prepend the WebCore layer archives' names with 'lib'
69         https://bugs.webkit.org/show_bug.cgi?id=125627
70
71         Reviewed by Martin Robinson.
72
73         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
74         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
75
76 2013-12-12  Commit Queue  <commit-queue@webkit.org>
77
78         Unreviewed, rolling out r160446.
79         http://trac.webkit.org/changeset/160446
80         https://bugs.webkit.org/show_bug.cgi?id=125630
81
82         The upower-glib-based implementation is using API that was
83         recently removed (Requested by zdobersek1 on #webkit).
84
85         * Scripts/webkitperl/FeatureList.pm:
86
87 2013-12-12  Commit Queue  <commit-queue@webkit.org>
88
89         Unreviewed, rolling out r160417.
90         http://trac.webkit.org/changeset/160417
91         https://bugs.webkit.org/show_bug.cgi?id=125629
92
93         The patch is causing crashes (Requested by zdobersek1 on
94         #webkit).
95
96         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
97         (axObjectEventListener):
98         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
99
100 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
101
102         Use of ar T option not supported by older binutils
103         https://bugs.webkit.org/show_bug.cgi?id=118732
104
105         Reviewed by Gustavo Noronha Silva.
106
107         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
108         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
109         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
110         of the member's object file, and not the full path to it. To work around that, all the object files
111         under the build directory are listed by their relative paths. The members of various archives then have
112         the basenames of their paths grepped against that list, with the found path correlating to the member
113         finally added as the new member of the WebCoreLayer archive.
114
115 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
116
117         check-webkit-style shouldn't check spacing in #if preprocessor lines
118         https://bugs.webkit.org/show_bug.cgi?id=125534
119
120         Reviewed by Ryosuke Niwa.
121
122         Preprocessor lines that start with #if shouldn't have to adhere to
123         the same spacing requirements that regular code does
124
125         * Scripts/webkitpy/style/checkers/cpp.py:
126         (check_spacing):
127         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
128         (CppStyleTest.test_spacing_for_binary_ops):
129         (WebKitStyleTest.test_line_breaking):
130
131 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
132
133         check-webkit-style can't determine if a comma is part of an initialization list
134         https://bugs.webkit.org/show_bug.cgi?id=125537
135
136         Reviewed by Darin Adler.
137
138         The original check to make sure that initialization list lines start with
139         a comma didn't distinguish between commas that belong to the initialization
140         list and commas that are part of function calls. Because we don't want to
141         match parentheses with regular expressions, we should weaken this check to
142         only check for commas at the end of initialization list lines.
143
144         * Scripts/webkitpy/style/checkers/cpp.py:
145         (check_member_initialization_list):
146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
147         (WebKitStyleTest.test_member_initialization_list):
148
149 2013-12-11  Tim Horton  <timothy_horton@apple.com>
150
151         Make it possible to compare layout test results between various configurations of WebKit
152         https://bugs.webkit.org/show_bug.cgi?id=125212
153         <rdar://problem/15199108>
154
155         Reviewed by Darin Adler.
156
157         * Scripts/compare-webkit-configurations: Added.
158         Add a script that allows comparison between the "normal" WebKit configuration
159         used for testing and a different configuration (e.g. with accelerated drawing
160         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
161
162         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
163
164         This script runs the tests once in the default configuration, ignoring
165         all test expectations, writing the results out to a temporary directory.
166
167         It then runs the tests again in the modified configuration, against the
168         just-written temporary results.
169
170         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
171
172         * DumpRenderTree/mac/DumpRenderTree.mm:
173         (resetWebPreferencesToConsistentValues):
174         (initializeGlobalsFromCommandLineOptions):
175         Enable accelerated drawing if requested.
176
177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
178         (parse_args):
179         Add --accelerated-drawing and --remote-layer-tree feature switches, which
180         are forwarded on to the test drivers.
181         Move those two and --complex-text into their own "feature switches" section.
182         Drive-by change "Mac OS X" to "OS X".
183         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
184         as traditional pixel tests (with PNGs dumped on disk), and
185         ignores e.g. -expected.html files.
186
187         * Scripts/webkitpy/port/base.py:
188         (Port.reference_files):
189         Pretend that there are no ref tests.
190         Since is_reference_html_file is intact, our mechanism to ignore
191         the expected files will continue working in this case.
192
193         * Scripts/webkitpy/port/driver.py:
194         (Driver.cmd_line):
195         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
196
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::TestController::TestController):
199         (WTR::TestController::initialize):
200         (WTR::TestController::resetPreferencesToConsistentValues):
201         * WebKitTestRunner/TestController.h:
202         (WTR::TestController::shouldUseRemoteLayerTree):
203         * WebKitTestRunner/TestInvocation.cpp:
204         (WTR::updateThreadedScrollingForCurrentTest):
205         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
206         (WTR::PlatformWebView::PlatformWebView):
207         Parse and implement the three feature switches.
208
209 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
210
211         [ATK] Expose accessibility objects WAI-ARIA landmark roles
212         https://bugs.webkit.org/show_bug.cgi?id=125584
213
214         Reviewed by Chris Fleizach.
215
216         Add mappings to DRT & WKTR for landmark roles.
217
218         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
219         (AccessibilityUIElement::role):
220         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
221         (WTR::AccessibilityUIElement::role):
222         * gtk/jhbuild.modules:
223
224 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
225
226         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
227         https://bugs.webkit.org/show_bug.cgi?id=125441
228
229         Reviewed by Martin Robinson.
230
231         Just avoid the double quotations when building the parameter
232         because some versions of valgrind are not handling it correctly.
233
234         * Scripts/webkitpy/port/gtk.py:
235         (GtkPort.setup_environ_for_server):
236
237 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
238
239         [GTK] Enable Battery Status API
240         https://bugs.webkit.org/show_bug.cgi?id=125453
241
242         Reviewed by Martin Robinson.
243
244         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
245
246 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
247
248         [GTK][WK2] Add the WebKitBatteryProvider class
249         https://bugs.webkit.org/show_bug.cgi?id=115720
250
251         Reviewed by Martin Robinson.
252
253         * gtk/generate-gtkdoc:
254         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
255
256 2013-12-11  Mark Rowe  <mrowe@apple.com>
257
258         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
259
260         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
261         to build and maintain this custom Perl module.
262
263         Reviewed by Anders Carlsson.
264
265         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
266         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
267         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
268         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
269         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
270         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
271         build DumpRenderTree.
272         (dumpToolDidCrash): Stop importing and using the module.
273         * Scripts/webkitpy/port/base.py:
274         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
275
276 2013-12-11  Brendan Long  <b.long@cablelabs.com>
277
278         [GTK] Add "enable-mediasource" property to WebKitWebSettings
279         https://bugs.webkit.org/show_bug.cgi?id=125566
280
281         Reviewed by Philippe Normand.
282
283         * DumpRenderTree/gtk/DumpRenderTree.cpp:
284         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
285         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
286         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
287
288 2013-12-11  Dan Bernstein  <mitz@apple.com>
289
290         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
291         https://bugs.webkit.org/show_bug.cgi?id=125579
292
293         Reviewed by Anders Carlsson.
294
295         * MiniBrowser/mac/WK2BrowserWindowController.m:
296         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
297         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
298         activeURL property changes, update the URL field with its value.
299         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
300         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
301         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
302         Ditto.
303         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
304         Ditto.
305         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
306         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
307
308 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
309
310         Fixed test-wepkitpy logging for buildslaves
311         https://bugs.webkit.org/show_bug.cgi?id=125445
312
313         Reviewed by Csaba Osztrogonác.
314
315         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
316         (RunPythonTests):
317
318 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
319
320         Programmatically-inserted children lack accessibility events
321         https://bugs.webkit.org/show_bug.cgi?id=100275
322
323         Reviewed by Chris Fleizach.
324
325         Update DRT and WebKitTestRunner to handle the children-changed
326         signal properly, considering the detail and optional parameters.
327
328         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
329         (axObjectEventListener):
330         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
331
332 2013-12-03  Mark Rowe  <mrowe@apple.com>
333
334         <https://webkit.org/b/125139> Modernize the WebKit API headers
335         <rdar://problem/15540175>
336
337         Reviewed by Anders Carlsson.
338
339         * DumpRenderTree/mac/TestRunnerMac.mm:
340         (TestRunner::setCacheModel): Cast to the enum type.
341
342 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
343
344         Get rid of forward exit on DoubleAsInt32
345         https://bugs.webkit.org/show_bug.cgi?id=125552
346
347         Reviewed by Oliver Hunt.
348         
349         Add some support for testing the generic (non-X86) paths on X86 by disabling
350         architecture-specific optimizations (ASO's).
351
352         * Scripts/run-javascriptcore-tests:
353         * Scripts/run-jsc-stress-tests:
354
355 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
356
357         Unreviewed EFL build fix attempt
358
359         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
360         * WebKitTestRunner/CMakeLists.txt: Ditto.
361
362 2013-12-10  Anders Carlsson  <andersca@apple.com>
363
364         Add a HashMap constructor that takes an initializer list
365         https://bugs.webkit.org/show_bug.cgi?id=125551
366
367         Reviewed by Dan Bernstein.
368
369         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
370         (TestWebKitAPI::TEST):
371
372 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
373
374         Use std::array when computing MD5 checksum
375         https://bugs.webkit.org/show_bug.cgi?id=125509
376
377         Reviewed by Anders Carlsson.
378
379         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
380
381         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
382         (computeMD5HashStringForBitmapContext):
383         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
384         (computeMD5HashStringForBitmapContext):
385         * TestWebKitAPI/Tests/WTF/MD5.cpp:
386         (TestWebKitAPI::expectMD5):
387         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
388         (WTR::computeMD5HashStringForCairoSurface):
389         * WebKitTestRunner/cg/TestInvocationCG.cpp:
390         (WTR::computeMD5HashStringForContext):
391
392 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
393
394         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
395         https://bugs.webkit.org/show_bug.cgi?id=125522
396
397         Reviewed by Chris Fleizach.
398
399         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
400
401         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
402         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
403
404 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
405
406         Add --makeargs option to build-jsc
407         https://bugs.webkit.org/show_bug.cgi?id=125344
408
409         Reviewed by Filip Pizlo.
410
411         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
412
413 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
414
415         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
416         https://bugs.webkit.org/show_bug.cgi?id=125497
417
418         Reviewed by Mario Sanchez Prada.
419
420         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
421         (AccessibilityUIElement::stringForRange): Implemented.
422         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
423         (WTR::AccessibilityUIElement::stringForRange): Implemented.
424
425 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
426
427         Various fixes for the CMake GTK+ build
428
429         Reviewed by Gustavo Noronha.
430
431         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
432         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
433
434 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
435
436         --cloop option does not work in Tools/Scripts/build-jsc.
437         https://bugs.webkit.org/show_bug.cgi?id=125214
438
439         Reviewed by Csaba Osztrogonác.
440
441         * Scripts/build-jsc:
442
443 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
444
445         Merge mark_for_landing and mark_for_commit_queue into one argument
446         https://bugs.webkit.org/show_bug.cgi?id=125448
447
448         Reviewed by Ryosuke Niwa.
449
450         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
451         (CommitQueueFlag):
452         (Bugzilla._commit_queue_flag):
453         (Bugzilla._fill_attachment_form):
454         (Bugzilla.add_patch_to_bug):
455         (Bugzilla.create_bug):
456         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
457         (test_commit_queue_flag.assert_commit_queue_flag):
458         (test_commit_queue_flag):
459
460 2013-12-09  Tim Horton  <timothy_horton@apple.com>
461
462         Remove dead extract_reference_link.py (and the reftests module)
463         https://bugs.webkit.org/show_bug.cgi?id=125116
464
465         Reviewed by Ryosuke Niwa.
466
467         This code doesn't seem to have ever been used.
468
469         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
470         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
471         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
472
473 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
474
475         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
476         https://bugs.webkit.org/show_bug.cgi?id=125456
477
478         Reviewed by Chris Fleizach.
479
480         Return 'AXSection' for section roles instead of 'AXDiv'.
481
482         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
483         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
484
485 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
486
487         check-webkit-style should check for extra newlines at EOF
488         https://bugs.webkit.org/show_bug.cgi?id=125424
489
490         Reviewed by Darin Adler.
491
492         Report a style violation if extraneous newlines are added
493         to the end of a C++ file. There should only be one newline at EOF.
494
495         * Scripts/webkitpy/style/checkers/cpp.py:
496         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
497         (check_for_extra_new_line_at_eof): Added.
498         (_process_lines): Added new check and renamed existing EOF check.
499         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
500         (CppStyleTest.test_extra_newlines_at_eof): Added.
501         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
502
503 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
504
505         check-webkit-style: ternary operator in macro call identified as initialization list
506         https://bugs.webkit.org/show_bug.cgi?id=125443
507
508         Reviewed by Ryosuke Niwa.
509
510         Do not match initialization list when questionmark is placed before :
511
512         * Scripts/webkitpy/style/checkers/cpp.py:
513         (check_member_initialization_list):
514
515 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
516
517         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
518         https://bugs.webkit.org/show_bug.cgi?id=125451
519
520         Reviewed by Mario Sanchez Prada.
521
522         Create the needed callbacks for DRT and WKTR.
523
524         * DumpRenderTree/AccessibilityUIElement.cpp:
525         (characterAtOffsetCallback): added
526         (wordAtOffsetCallback): added
527         (lineAtOffsetCallback): added
528         (sentenceAtOffsetCallback): added
529         (AccessibilityUIElement::getJSClass):
530         * DumpRenderTree/AccessibilityUIElement.h:
531         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
532         (stringAtOffset): added
533         (AccessibilityUIElement::characterAtOffset): added
534         (AccessibilityUIElement::wordAtOffset): added
535         (AccessibilityUIElement::lineAtOffset): added
536         (AccessibilityUIElement::sentenceAtOffset): added
537         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
538         (WTR::AccessibilityUIElement::characterAtOffset): added
539         (WTR::AccessibilityUIElement::wordAtOffset): added
540         (WTR::AccessibilityUIElement::lineAtOffset): added
541         (WTR::AccessibilityUIElement::sentenceAtOffset): added
542         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
543         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
544         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
545         (WTR::stringAtOffset): added
546         (WTR::AccessibilityUIElement::characterAtOffset): added
547         (WTR::AccessibilityUIElement::wordAtOffset): added
548         (WTR::AccessibilityUIElement::lineAtOffset): added
549         (WTR::AccessibilityUIElement::sentenceAtOffset): added
550
551 2013-12-08  Sam Weinig  <sam@webkit.org>
552
553         32-bit MiniBrowser doesn't build
554         https://bugs.webkit.org/show_bug.cgi?id=125420
555
556         Reviewed by Dan Bernstein.
557
558         * MiniBrowser/mac/AppDelegate.h:
559         * MiniBrowser/mac/AppDelegate.m:
560         (-[BrowserAppDelegate init]):
561         (-[BrowserAppDelegate applicationWillTerminate:]):
562
563 2013-12-08  Brian Holt  <brian.holt@samsung.com>
564
565         [WK2] Add ENABLE_NETWORK_PROCESS flag
566         https://bugs.webkit.org/show_bug.cgi?id=125421
567
568         Add support to build with the Network Process enabled.
569
570         Reviewed by Martin Robinson.
571
572         * Scripts/webkitperl/FeatureList.pm:
573
574 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
575
576         Fold typedArray.length if typedArray is constant
577         https://bugs.webkit.org/show_bug.cgi?id=125252
578
579         Reviewed by Sam Weinig.
580         
581         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
582         should put tests that run just like JSRegress but don't run as part of LayoutTests.
583         Currently I'm using it for tests that require some surgical support from jsc.cpp.
584
585         * Scripts/run-javascriptcore-tests:
586
587 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
588
589         [gdb] Update printers for WTF::CString, JSC::JSString
590         https://bugs.webkit.org/show_bug.cgi?id=124600
591
592         Reviewed by Gustavo Noronha Silva.
593
594         Update the two printers after they fell behind the changes in implementation.
595
596         * gdb/webkit.py:
597         (WTFCStringPrinter.to_string):
598         (JSCJSStringPrinter.to_string):
599
600 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
601
602         [webkitpy] Add a WestonDriver unit test
603         https://bugs.webkit.org/show_bug.cgi?id=125408
604
605         Reviewed by Gustavo Noronha Silva.
606
607         Add a webkitpy unit test for the Weston driver.
608
609         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
610         (WestonDriverTest):
611         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
612         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
613         the server environment contains proper WAYLAND and GDK_BACKEND entries.
614         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
615         the driver cleans up the temporary directory.
616         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
617         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
618
619 2013-12-08  Brendan Long  <b.long@cablelabs.com>
620
621         [Gtk] install-dependencies doesn't install libgtk-3-dev
622         https://bugs.webkit.org/show_bug.cgi?id=125320
623
624         Reviewed by Gustavo Noronha Silva.
625
626         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
627
628 2013-12-07  Sam Weinig  <sam@webkit.org>
629
630         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
631         https://bugs.webkit.org/show_bug.cgi?id=125401
632
633         Reviewed by Dan Bernstein.
634
635         * MiniBrowser/mac/WK2BrowserWindowController.m:
636         (-[WK2BrowserWindowController fetch:]):
637         (-[WK2BrowserWindowController reload:]):
638         (-[WK2BrowserWindowController goBack:]):
639         (-[WK2BrowserWindowController goForward:]):
640         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
641         (-[WK2BrowserWindowController currentZoomFactor]):
642         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
643         (-[WK2BrowserWindowController zoomIn:]):
644         (-[WK2BrowserWindowController zoomOut:]):
645         (-[WK2BrowserWindowController canResetZoom]):
646         (-[WK2BrowserWindowController resetZoom:]):
647         (-[WK2BrowserWindowController toggleZoomMode:]):
648         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
649
650 2013-12-07  Sam Weinig  <sam@webkit.org>
651
652         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
653         https://bugs.webkit.org/show_bug.cgi?id=125400
654
655         Reviewed by Dan Bernstein.
656
657         * MiniBrowser/mac/AppDelegate.h:
658         * MiniBrowser/mac/AppDelegate.m:
659         * MiniBrowser/mac/WK2BrowserWindowController.h:
660         * MiniBrowser/mac/WK2BrowserWindowController.m:
661         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
662         (-[WK2BrowserWindowController dealloc]):
663         (createNewPage):
664         (-[WK2BrowserWindowController awakeFromNib]):
665         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
666         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
667         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
668         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
669         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
670         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
671
672 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
673
674         [GTK] Run each gtest subtest separately instead of in one go
675         https://bugs.webkit.org/show_bug.cgi?id=125386
676
677         Reviewed by Martin Robinson.
678
679         This is what other ports are doing (except they build each test as a separate binary)
680         and will help with the timeouts we sometimes hit because it applies to the full test
681         run.
682
683         * Scripts/run-gtk-tests:
684         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
685         (TestRunner._run_google_test): run a single subtest from a gtest binary.
686         (TestRunner._run_google_test_suite): call the binary once per subtest.
687
688 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
689
690         Move PrettyPatch related code to prettypatch.py
691         https://bugs.webkit.org/show_bug.cgi?id=124937
692
693         Reviewed by Ryosuke Niwa.
694
695         This code seems to have a better place here than in Port, since PrettyPatch already knows
696         pretty_patch_path, and this also unifies the usage of PrettyPatch
697
698         * Scripts/webkitpy/common/prettypatch.py:
699         (PrettyPatch.__init__):
700         (PrettyPatch.pretty_diff):
701         (PrettyPatch):
702         (PrettyPatch.pretty_patch_available):
703         (PrettyPatch.check_pretty_patch):
704         (PrettyPatch.pretty_patch_text):
705         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
706         (TestResultWriter.create_text_diff_and_write_result):
707         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
708         (summarize_results):
709         * Scripts/webkitpy/port/base.py:
710         (Port.__init__):
711         (Port.wdiff_available):
712         (Port.check_image_diff):
713         (Port.wdiff_text):
714         * Scripts/webkitpy/port/base_unittest.py:
715         (PortTest.test_pretty_patch_os_error):
716         (PortTest.test_pretty_patch_script_error):
717
718 2013-12-06  Dan Bernstein  <mitz@apple.com>
719
720         [Mac] MiniBrowser Debug builds are compiled with -Os
721         https://bugs.webkit.org/show_bug.cgi?id=125376
722
723         Reviewed by Tim Horton.
724
725         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
726         the Debug configuration at the project level.
727
728 2013-12-06  Jer Noble  <jer.noble@apple.com>
729
730         [MSE] Add a runtime-setting for the MediaSource constructor.
731         https://bugs.webkit.org/show_bug.cgi?id=125336
732
733         Reviewed by Eric Carlson.
734
735         Enable MediaSource in DRT and WKTR.
736
737         * DumpRenderTree/mac/DumpRenderTree.mm:
738         (resetWebPreferencesToConsistentValues):
739         * WebKitTestRunner/TestController.cpp:
740         (WTR::TestController::resetPreferencesToConsistentValues):
741
742 2013-12-06  Jer Noble  <jer.noble@apple.com>
743
744         Strip out extraneous logging from AppleGVA in media tests.
745         https://bugs.webkit.org/show_bug.cgi?id=125357
746
747         Reviewed by Simon Fraser.
748
749         Add a mechanism for stripping out abritrary regular expressions from test input and output.
750
751         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
752         (SingleTestRunner._run_compare_test): Strip out logging
753         * Scripts/webkitpy/port/base.py:
754         (Port.logging_patterns_to_strip): Return an empty list by default.
755         * Scripts/webkitpy/port/driver.py:
756         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
757         * Scripts/webkitpy/port/mac.py:
758         (MacPort.logging_patterns_to_strip): Return a complete list.
759
760 2013-12-06  Dean Jackson  <dino@apple.com>
761
762         Updating ANGLE should point to instructions
763         https://bugs.webkit.org/show_bug.cgi?id=125361
764
765         Reviewed by Eric Carlson.
766
767         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
768         someone wants to patch ANGLE.
769
770         * Scripts/webkitpy/common/config/watchlist:
771
772 2013-12-06  Dan Bernstein  <mitz@apple.com>
773
774         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
775         https://bugs.webkit.org/show_bug.cgi?id=125334
776
777         Reviewed by Darin Adler.
778
779         * MiniBrowser/mac/WK2BrowserWindowController.m:
780         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
781         title property.
782         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
783         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
784         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
785         window title with the title property changes.
786         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
787         set the load delegate instead of the load client.
788         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
789         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
790         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
791         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
792         Implemented this load delegate method.
793         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
794         Ditto.
795         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
796         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
797         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
798         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
799         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
800         Ditto.
801         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
802         Ditto.
803         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
804
805 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
806
807         Remove function from style/checkers/cpp.py.
808         https://bugs.webkit.org/show_bug.cgi?id=125341
809
810         Reviewed by Darin Adler.
811
812         Corrects a FIXME: by removing a function from cpp.py.
813
814         * Scripts/webkitpy/style/checkers/cpp.py:
815         (CppChecker.__init__):
816         (CppChecker.check):
817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
818         (CppStyleTestBase.process_file_data):
819
820 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
821
822         check-webkit-style: false positive warning for indentation of #ifdef code.
823         https://bugs.webkit.org/show_bug.cgi?id=125254
824
825         Reviewed by Darin Adler.
826
827         * Scripts/webkitpy/style/checkers/cpp.py:
828         (check_member_initialization_list):
829         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
830         (WebKitStyleTest.test_member_initialization_list):
831
832 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
833
834         Fix spelling error in style checker: beggining
835         https://bugs.webkit.org/show_bug.cgi?id=125347
836
837         Reviewed by Anders Carlsson.
838
839         * Scripts/webkitpy/style/checkers/cpp.py:
840         (check_member_initialization_list):
841         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
842         (WebKitStyleTest.test_member_initialization_list):
843
844 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
845
846         [ATK] Missing aria roles mappings
847         https://bugs.webkit.org/show_bug.cgi?id=117729
848
849         Reviewed by Mario Sanchez Prada.
850
851         Added new mappings to AccessibilityUIElementAtk.cpp.
852
853         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
854         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
855
856 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
857
858         Typo fix after r160218.
859
860         * Scripts/webkitpy/test/main.py:
861         (main):
862
863 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
864
865         Unreviewed fix after r160206.
866
867         * Scripts/webkitpy/test/main.py:
868         (main): sys.platform can be win32 or cygwin too on Windows.
869
870 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
871
872         Disable WebKit2 webkitpy unittests on Windows
873         https://bugs.webkit.org/show_bug.cgi?id=125318
874
875         Reviewed by Ryosuke Niwa.
876
877         * Scripts/webkitpy/test/main.py:
878         (main):
879
880 2013-12-05  Anders Carlsson  <andersca@apple.com>
881
882         Tweak WeakObjCPtr
883         https://bugs.webkit.org/show_bug.cgi?id=125311
884
885         Reviewed by Darin Adler.
886
887         Split up tests into more logical groups. Add new tests for new functionality.
888
889         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
890
891 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
892
893         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
894         https://bugs.webkit.org/show_bug.cgi?id=125302
895
896         Reviewed by Philippe Normand.
897
898         * gtk/generate-webkitdom-doc-files:
899         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
900         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
901         and WEBKIT_DEPRECATED_FOR macros.
902
903 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
904
905         Fix cross compilation on x86
906         https://bugs.webkit.org/show_bug.cgi?id=125295
907
908         Reviewed by Zoltan Herczeg.
909
910         Certain compiler flags should not be added when cross compilation is enabled.
911
912         * Scripts/webkitdirs.pm:
913         (runAutogenForAutotoolsProjectIfNecessary):
914         (generateBuildSystemFromCMakeProject):
915
916 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
917
918         Remove duplicated/dead code from cpp style checker unit tests.
919         https://bugs.webkit.org/show_bug.cgi?id=125226
920
921         Reviewed by Ryosuke Niwa.
922
923         Remove the first definition of OrderOfIncludesTest class as it is
924         overwritten by the second. Remove a duplicated assert statement
925         from the second class.
926
927         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
928         (OrderOfIncludesTest.setUp):
929         (OrderOfIncludesTest.test_try_drop_common_suffixes):
930           The last assert was duplicated.
931
932 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
933
934         Remove Scripts/generate-qt-inspector-resource.
935         https://bugs.webkit.org/show_bug.cgi?id=125288
936
937         Reviewed by Andreas Kling.
938
939         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
940         We don't need this file.
941
942 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
943
944         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
945         https://bugs.webkit.org/show_bug.cgi?id=125218
946
947         Reviewed by Ryosuke Niwa.
948
949         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
950         (LayoutTestFinder.skip_tests):
951         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
952         (LayoutTestRunner.run_tests):
953         (LayoutTestRunner._update_summary_with_result):
954         * Scripts/webkitpy/layout_tests/controllers/manager.py:
955         (Manager._test_is_slow):
956         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
957         (JSONLayoutResultsGenerator._insert_failure_summaries):
958         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
959         (TestExpectations.get_rebaselining_failures):
960         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
961         (assert_exp):
962         (MiscTests.test_multiple_results):
963         (MiscTests.test_category_expectations):
964         (MiscTests.test_get_modifiers):
965         (MiscTests.test_get_expectations_string):
966         (MiscTests.test_expectation_to_string):
967         (MiscTests.test_get_test_set):
968         (MiscTests.test_more_specific_override_resets_skip):
969         (SkippedTests.check):
970         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
971         (TestRunResults.__init__):
972         (summarize_results):
973         * Scripts/webkitpy/tool/commands/rebaseline.py:
974         (RebaselineExpectations._tests_to_rebaseline):
975
976 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
977
978         Enable HTMLTemplateElement by default
979         https://bugs.webkit.org/show_bug.cgi?id=123851
980
981         Reviewed by Antti Koivisto.
982
983         * Scripts/webkitperl/FeatureList.pm:
984
985 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
986
987         [EFL] Bumping GStreamer version to 1.2.1
988         https://bugs.webkit.org/show_bug.cgi?id=125155
989
990         Reviewed by Gyuyoung Kim.
991
992         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
993
994
995 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
996
997         Update jhbuild revision.
998         https://bugs.webkit.org/show_bug.cgi?id=124966
999         
1000         Reviewed by Gyuyoung Kim.
1001
1002         Used version of Jhbuild failed to create directories and caused
1003         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1004
1005         * jhbuild/jhbuild-wrapper:
1006
1007 2013-12-04  Anders Carlsson  <andersca@apple.com>
1008
1009         Add a WeakObjCPtr class
1010         https://bugs.webkit.org/show_bug.cgi?id=125267
1011
1012         Reviewed by Geoffrey Garen.
1013
1014         Add API tests for WeakObjCPtr.
1015
1016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1017         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1018         (TEST):
1019
1020 2013-12-04  Anders Carlsson  <andersca@apple.com>
1021
1022         Make the estimatedProgress property observable using KVO
1023         https://bugs.webkit.org/show_bug.cgi?id=125259
1024
1025         Reviewed by Dan Bernstein.
1026
1027         Bind the progress indicator value to the "estimatedProgress" property.
1028
1029         * MiniBrowser/mac/WK2BrowserWindowController.m:
1030         (-[WK2BrowserWindowController dealloc]):
1031         (-[WK2BrowserWindowController awakeFromNib]):
1032
1033 2013-12-04  Anders Carlsson  <andersca@apple.com>
1034
1035         Add a loading property to WKBrowsingContextController
1036         https://bugs.webkit.org/show_bug.cgi?id=125256
1037
1038         Reviewed by Dan Bernstein.
1039
1040         Bind the progress indicator visibility to the "loading" property.
1041
1042         * MiniBrowser/mac/WK2BrowserWindowController.m:
1043         (-[WK2BrowserWindowController dealloc]):
1044         (-[WK2BrowserWindowController awakeFromNib]):
1045         (-[WK2BrowserWindowController didStartProgress]):
1046         (-[WK2BrowserWindowController didFinishProgress]):
1047
1048 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1049
1050         [EFL][WK2] Buildfix after r160104
1051         https://bugs.webkit.org/show_bug.cgi?id=125231
1052
1053         Reviewed by Anders Carlsson.
1054
1055         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1056         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1057         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1058         (TestWebKitAPI::setViewClient): Ditto.
1059
1060 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1061
1062         check-webkit-style detected some ternary statements as initialization lists
1063         https://bugs.webkit.org/show_bug.cgi?id=125246
1064
1065         Reviewed by Dean Jackson.
1066
1067         The regular expression that check-webkit-tests uses to detect initialization
1068         lists was too broad, resulting in false positives. This patch makes the
1069         regex more specific
1070
1071         * Scripts/webkitpy/style/checkers/cpp.py:
1072         (check_member_initialization_list):
1073         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1074         (WebKitStyleTest.test_member_initialization_list):
1075
1076 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1077
1078         run-jsc-stress-tests can only run locally
1079         https://bugs.webkit.org/show_bug.cgi?id=124551
1080
1081         Reviewed by Filip Pizlo.
1082
1083         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1084         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1085         added a couple more signals to handle gracefully at shutdown. 
1086         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1087         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1088         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1089         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1090         toward the end of the script to make it easier to tell which of the various modes do what.
1091
1092 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1093
1094         [EFL][WK2] Buildfix after r160104
1095         https://bugs.webkit.org/show_bug.cgi?id=125233
1096
1097         Reviewed by Anders Carlsson.
1098
1099         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1100         (TestWebKitAPI::TEST):
1101         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1102         (TestWebKitAPI::setPageLoaderClient):
1103
1104 2013-12-03  Anders Carlsson  <andersca@apple.com>
1105
1106         Deprecate all unversioned client structs in favor of having explicit versioned structs
1107         https://bugs.webkit.org/show_bug.cgi?id=125203
1108
1109         Reviewed by Dan Bernstein.
1110
1111         Update for WebKit2 API changes.
1112
1113         * MiniBrowser/mac/AppDelegate.m:
1114         (-[BrowserAppDelegate init]):
1115         * MiniBrowser/mac/WK2BrowserWindowController.m:
1116         (-[WK2BrowserWindowController awakeFromNib]):
1117         * TestWebKitAPI/InjectedBundleController.cpp:
1118         (TestWebKitAPI::InjectedBundleController::initialize):
1119         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1120         (TestWebKitAPI::TEST):
1121         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1122         (TestWebKitAPI::setInjectedBundleClient):
1123         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1124         (TestWebKitAPI::TEST):
1125         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1126         (TestWebKitAPI::TEST):
1127         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1128         (TestWebKitAPI::TEST):
1129         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1130         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1131         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1132         (TestWebKitAPI::TEST):
1133         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1134         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1135         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1136         (TestWebKitAPI::setInjectedBundleClient):
1137         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1138         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1139         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1140         (TestWebKitAPI::TEST):
1141         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1142         (TestWebKitAPI::TEST):
1143         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1144         (TestWebKitAPI::setContextDownloadClient):
1145         (TestWebKitAPI::setPagePolicyClient):
1146         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1155         (TestWebKitAPI::TEST):
1156         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1159         (TestWebKitAPI::setupGeolocationProvider):
1160         (TestWebKitAPI::setupView):
1161         (TestWebKitAPI::TEST):
1162         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1163         (TestWebKitAPI::TEST):
1164         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1165         (TestWebKitAPI::setPageLoaderClient):
1166         (TestWebKitAPI::setInjectedBundleClient):
1167         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1168         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
1169         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1170         (TestWebKitAPI::TEST):
1171         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1172         (TestWebKitAPI::setInjectedBundleClient):
1173         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1174         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
1175         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1176         (TestWebKitAPI::TEST):
1177         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1178         (TestWebKitAPI::TEST):
1179         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1180         (TestWebKitAPI::TEST):
1181         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1182         (TestWebKitAPI::TEST):
1183         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1184         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
1185         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1186         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1187         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1188         (TestWebKitAPI::setPageLoaderClient):
1189         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1190         (TestWebKitAPI::setPageLoaderClient):
1191         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1192         (TestWebKitAPI::setPageLoaderClient):
1193         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1194         (TestWebKitAPI::setPageLoaderClient):
1195         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1196         (TestWebKitAPI::setPageLoaderClient):
1197         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1198         (TestWebKitAPI::TEST):
1199         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1200         (TestWebKitAPI::TEST):
1201         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1202         (TestWebKitAPI::setInjectedBundleClient):
1203         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1204         (TestWebKitAPI::ParentFrameTest::didCreatePage):
1205         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1206         (TestWebKitAPI::setInjectedBundleClient):
1207         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1208         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
1209         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1210         (TestWebKitAPI::TEST):
1211         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1212         (TestWebKitAPI::TEST):
1213         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1214         (TestWebKitAPI::TEST):
1215         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1216         (TestWebKitAPI::TEST):
1217         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1218         (TestWebKitAPI::setInjectedBundleClient):
1219         (TestWebKitAPI::setPageLoaderClient):
1220         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1221         (TestWebKitAPI::setPageLoaderClient):
1222         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1223         (TestWebKitAPI::TEST):
1224         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1225         (TestWebKitAPI::setPageLoaderClient):
1226         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1227         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1228         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1229         (TestWebKitAPI::TEST):
1230         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1231         (TestWebKitAPI::TEST):
1232         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1233         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
1234         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1235         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
1236         (TestWebKitAPI::TEST):
1237         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
1238         (TestWebKitAPI::WKConnectionTest::initialize):
1239         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1240         (TestWebKitAPI::setPageLoaderClient):
1241         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1242         (TestWebKitAPI::setInjectedBundleClient):
1243         (TestWebKitAPI::TEST):
1244         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1245         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
1246         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1247         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1248         (TestWebKitAPI::setInjectedBundleClient):
1249         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1250         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
1251         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1252         (TestWebKitAPI::TEST):
1253         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1254         (TestWebKitAPI::setInjectedBundleClient):
1255         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1256         (TestWebKitAPI::TEST):
1257         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1258         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1259         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1260         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1261         (TestWebKitAPI::didCreateConnection):
1262         (TestWebKitAPI::TEST):
1263         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1264         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1265         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1266         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1267         (TestWebKitAPI::setPageLoaderClient):
1268         * WebKitTestRunner/GeolocationProviderMock.cpp:
1269         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1270         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1271         (WTR::InjectedBundle::initialize):
1272         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1273         (WTR::InjectedBundlePage::InjectedBundlePage):
1274         * WebKitTestRunner/TestController.cpp:
1275         (WTR::TestController::createOtherPage):
1276         (WTR::TestController::initialize):
1277         (WTR::TestController::createWebViewWithOptions):
1278
1279 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1280
1281         Style checker for .messages.in files (WTF:: prefix)
1282         https://bugs.webkit.org/show_bug.cgi?id=125142
1283
1284         Reviewed by Anders Carlsson.
1285
1286         A new style checker for .messages.in files, that checks for the use of WTF::
1287         prefix in these files. (Also checks for tabs as these files were previously
1288         handled as text files.)
1289
1290         * Scripts/webkitpy/style/checker.py:
1291         (CheckerDispatcher._create_checker):
1292           New checker is returned for .messages.in files.
1293         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
1294           The new style checker class.
1295         (MessagesInChecker):
1296         (MessagesInChecker.__init__):
1297         (MessagesInChecker.check):
1298         (MessagesInChecker.check_WTF_prefix):
1299         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
1300           Unit test for the new style  checker class.
1301         (MessagesInCheckerStyleTestCase):
1302         (test_checker):
1303         (test_checker.error_handler_for_test):
1304         (MessagesInCheckerTestCase):
1305         (MessagesInCheckerTestCase.test_init):
1306         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
1307
1308 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1309
1310         Style checker requires alphabetical ordering in cmake lists even it contains variable.
1311         https://bugs.webkit.org/show_bug.cgi?id=124918
1312
1313         Reviewed by Csaba Osztrogonác.
1314
1315         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1316         (CMakeCheckerTest.test_check):
1317         * Scripts/webkitpy/style/checkers/cmake.py:
1318         (CMakeChecker._check_list_order):
1319         This will ignore lines with variable substitution.
1320
1321 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1322
1323         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
1324         https://bugs.webkit.org/show_bug.cgi?id=124731
1325
1326         Reviewed by Zoltan Herczeg.
1327
1328         * Scripts/webkitpy/style/checkers/cpp.py:
1329         (check_spacing):
1330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1331         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
1332
1333 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1334
1335         Remove codecs and os dependencies from filereader.py in webkitpy/style.
1336         https://bugs.webkit.org/show_bug.cgi?id=124719
1337
1338         Although TextFileReader requires a FileSystem it circumvents it in two places!
1339         We should use the FileSystem only and remove codecs and os imports.
1340
1341         Reviewed by Zoltan Herczeg.
1342
1343         * Scripts/webkitpy/common/system/filesystem.py:
1344         (FileSystem.open_stdin): Moved from TextFileReader
1345         * Scripts/webkitpy/style/filereader.py:
1346         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
1347         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
1348
1349 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1350
1351         check-webkit-style should check member initialization indentation.
1352         https://bugs.webkit.org/show_bug.cgi?id=124820
1353
1354         Reviewed by Zoltan Herczeg.
1355
1356         check-webkit-style should check member initialization indentation
1357         belongs to webkit coding style:
1358         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1359
1360         * Scripts/webkitpy/style/checkers/cpp.py:
1361         (check_member_initialization_list): Add new method to check member
1362         initialization list.
1363         (check_style): Add the call of the new method.
1364         (check_language): Move self initialization checking into the new method.
1365         (CppChecker): Add a new category for initialization list.
1366         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1367         (CppStyleTest.test_runtime_selfinit):
1368         (CppStyleTest.test_deprecated_cast):
1369         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1370         the new feature.
1371
1372 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1373
1374         style-bot should reject Committer additions to committers.py
1375         https://bugs.webkit.org/show_bug.cgi?id=107574
1376
1377         Reviewed by Zoltan Herczeg.
1378
1379         The style check when executed in non-interactive mode (probably by a
1380         bot) will raise an additional error if the contributors.json file is
1381         modified. Non-interactive mode information is propagated to the
1382         Dispatcher, which creates a special JSON checker for the
1383         contributors.json file.
1384
1385         * Scripts/webkitpy/style/checker.py:
1386         (check_webkit_style_configuration):
1387         (CheckerDispatcher._create_checker):
1388         (CheckerDispatcher.dispatch):
1389         (StyleProcessorConfiguration.__init__):
1390         (StyleProcessor.process):
1391         * Scripts/webkitpy/style/checker_unittest.py:
1392         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1393         (CheckerDispatcherDispatchTest.dispatch):
1394         (StyleProcessorConfigurationTest._style_checker_configuration):
1395         (StyleProcessor_EndToEndTest.test_init):
1396         (StyleProcessor_EndToEndTest.test_process):
1397         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
1398         (StyleProcessor_CodeCoverageTest.setUp):
1399         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1400         (JSONChecker.line_number_from_json_exception):
1401         (JSONContributorsChecker):
1402         (JSONContributorsChecker.check):
1403         * Scripts/webkitpy/style/error_handlers_unittest.py:
1404         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1405         * Scripts/webkitpy/style/optparser.py:
1406         (CommandOptionValues.__init__):
1407         (ArgumentParser._create_option_parser):
1408         (ArgumentParser.parse):
1409         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1410         (test_post):
1411         (test_upload):
1412         * Scripts/webkitpy/tool/steps/checkstyle.py:
1413         (CheckStyle.run):
1414
1415 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1416
1417         [EFL][WK2] Fix build after API::Client changes
1418         https://bugs.webkit.org/show_bug.cgi?id=125206
1419
1420         Reviewed by Csaba Osztrogonác.
1421
1422         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1423         (TestWebKitAPI::TEST):
1424         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1425         (TestWebKitAPI::setViewClient):
1426
1427 2013-12-03  Dan Bernstein  <mitz@apple.com>
1428
1429         Fixed a test timing out after r160040.
1430
1431         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1432         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1433         Updated for the delegate method rename.
1434
1435 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
1436
1437         REGRESSION: repro scripts disappear when you rerun tests
1438         https://bugs.webkit.org/show_bug.cgi?id=125184
1439
1440         Reviewed by Mark Hahnenberg.
1441         
1442         This bug made it difficult to quickly see if a test that recently failed is still
1443         failing while also running a new batch of tests.
1444
1445         Repro scripts are supposed to stay around until you delete them explicitly. This
1446         patch accomplishes that.
1447
1448         * Scripts/run-jsc-stress-tests:
1449
1450 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
1451
1452         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
1453         https://bugs.webkit.org/show_bug.cgi?id=125111
1454
1455         Reviewed by Filip Pizlo.
1456
1457         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
1458
1459         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
1460         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
1461
1462 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1463
1464         Add a script to automatically configure a git clone
1465         https://bugs.webkit.org/show_bug.cgi?id=110073
1466
1467         Revert the change to use https for now since git.webkit.org is setup with http.
1468
1469         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1470         (SetupGitClone.execute):
1471
1472 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1473
1474         Add a script to automatically configure a git clone
1475         https://bugs.webkit.org/show_bug.cgi?id=110073
1476
1477         Reviewed by Benjamin Poulain.
1478
1479         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
1480
1481         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
1482
1483         * Scripts/webkitpy/tool/commands/__init__.py:
1484         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
1485         (SetupGitClone):
1486         (SetupGitClone.execute):
1487
1488 2013-12-03  Anders Carlsson  <andersca@apple.com>
1489
1490         Deprecate WKNotificationProvider
1491         https://bugs.webkit.org/show_bug.cgi?id=125178
1492
1493         Reviewed by Sam Weinig.
1494
1495         Update for WebKit2 changes.
1496
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::TestController::initialize):
1499         * WebKitTestRunner/WebNotificationProvider.cpp:
1500         (WTR::WebNotificationProvider::provider):
1501         * WebKitTestRunner/WebNotificationProvider.h:
1502
1503 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
1504
1505         [Win] Support 64-bit Application Support Libraries Location 
1506         https://bugs.webkit.org/show_bug.cgi?id=125179
1507
1508         Reviewed by Tim Horton.
1509
1510         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
1511         on Windows until an official distribution is available that properly creates registry settings
1512         to specify these locations.
1513
1514         * Scripts/webkitdirs.pm:
1515         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
1516         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
1517         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
1518         running 64-bit builds.
1519
1520 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
1521
1522         run-jsc-stress-tests only supports host environments that have make installed
1523         https://bugs.webkit.org/show_bug.cgi?id=124550
1524
1525         Reviewed by Darin Adler.
1526
1527         This might not be the case for all hosts, so this patch implements an alternate "backend" 
1528         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
1529         least somewhat competitive with the make-based test runner, the shell backend uses subshells
1530         run in the background to allow tests to run in parallel. Since the concurrency primitives 
1531         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
1532         of the make-based runner.
1533
1534         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
1535         the bundle and controls all of the parallel aspects of the shell-based test runner.
1536         * Scripts/run-jsc-stress-tests:
1537
1538 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1539
1540         Remove function from TextChecker
1541         https://bugs.webkit.org/show_bug.cgi?id=125148
1542
1543         Reviewed by Darin Adler.
1544
1545         The process_file_data is used only from the unit tests, so it is simply moved there.
1546
1547         * Scripts/webkitpy/style/checkers/text.py:
1548         (TextChecker.check):
1549         * Scripts/webkitpy/style/checkers/text_unittest.py:
1550         (TextStyleTestCase.process_file_data):
1551         (TextStyleTestCase.assertNoError):
1552         (TextStyleTestCase.assertError):
1553
1554 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1555
1556         Remove get_test() and reference test names directly instead.
1557         https://bugs.webkit.org/show_bug.cgi?id=124962
1558
1559         Reviewed by Csaba Osztrogonác.
1560
1561         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1562         (Base.__init__):
1563         (Base.get_basic_tests):
1564         (assert_exp):
1565         (MiscTests.test_multiple_results):
1566         (MiscTests.test_category_expectations):
1567         (MiscTests.test_get_modifiers):
1568         (MiscTests.test_get_expectations_string):
1569         (MiscTests.test_get_test_set):
1570         (MiscTests.test_parse_warning):
1571         (MiscTests.test_pixel_tests_flag.match):
1572
1573 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1574
1575         Style Checker false pass.
1576         https://bugs.webkit.org/show_bug.cgi?id=112456
1577
1578         Reviewed by Csaba Osztrogonác.
1579
1580         * Scripts/webkitpy/style/checkers/changelog.py:
1581         (ChangeLogChecker.check_entry):
1582         simple regex fix to check "No new tests (...)."
1583         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1584         (ChangeLogCheckerTest.test_no_new_tests):
1585
1586 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
1587
1588         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
1589         https://bugs.webkit.org/show_bug.cgi?id=125130
1590
1591         Reviewed by Geoffrey Garen.
1592
1593         * Scripts/run-jsc-stress-tests:
1594
1595 2013-12-02  Samuel White  <samuel_white@apple.com>
1596
1597         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
1598         https://bugs.webkit.org/show_bug.cgi?id=124561
1599
1600         Reviewed by Chris Fleizach.
1601
1602         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
1603
1604         * DumpRenderTree/AccessibilityUIElement.cpp:
1605         (uiElementCountForSearchPredicateCallback):
1606         (uiElementForSearchPredicateCallback):
1607         (AccessibilityUIElement::getJSClass):
1608         * DumpRenderTree/AccessibilityUIElement.h:
1609         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1610         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1611         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1612         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1613         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1614         (searchPredicateParameterizedAttributeForSearchCriteria):
1615         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1616         (AccessibilityUIElement::uiElementForSearchPredicate):
1617         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1618         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1619         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1620         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1621         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1622         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1623         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1624         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1625         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1626         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1627         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1628         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1629
1630 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1631
1632         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
1633         https://bugs.webkit.org/show_bug.cgi?id=124714
1634
1635         Reviewed by Ryosuke Niwa.
1636
1637         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1638         (write_test_result):
1639         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1640         (TestFailure.write_failure):
1641         (FailureText):
1642         (FailureText.write_failure):
1643         (FailureAudio):
1644         (FailureAudio.write_failure):
1645         (FailureCrash.write_failure):
1646         (FailureMissingResult):
1647         (FailureTextMismatch):
1648         (FailureMissingImageHash.write_failure):
1649         (FailureMissingImage.write_failure):
1650         (FailureImageHashMismatch.write_failure):
1651         (FailureReftestMismatch.write_failure):
1652         (FailureReftestMismatchDidNotOccur.write_failure):
1653         (FailureMissingAudio):
1654         (FailureAudioMismatch):
1655
1656 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
1657
1658         Remove the stderr_write attribute from StyleProcessorConfiguration
1659         https://bugs.webkit.org/show_bug.cgi?id=124703
1660
1661         Reviewed by Ryosuke Niwa.
1662
1663         Remove the stderr_write attribute from this class in checker and
1664         replace its use with calls to a logging module logger. We Should 
1665         use logging module instead of writing to stderr directly.
1666
1667         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
1668         (check_webkit_style_configuration):
1669         (CheckerDispatcher.dispatch): Remove FIXME comment.
1670         (StyleProcessorConfiguration):
1671         (StyleProcessorConfiguration.__init__):
1672         (StyleProcessorConfiguration.write_style_error):
1673         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
1674         There is an "ERROR" prefix in log messiges from now.
1675         (StyleProcessorConfigurationTest):
1676         (StyleProcessorConfigurationTest._style_checker_configuration):
1677         (StyleProcessorConfigurationTest.test_init):
1678         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
1679         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
1680         (StyleProcessor_EndToEndTest.with):
1681         (StyleProcessor_EndToEndTest.test_init):
1682         (StyleProcessor_EndToEndTest.test_process):
1683         (StyleProcessor_CodeCoverageTest.setUp):
1684         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
1685         (DefaultStyleErrorHandler.__call__):
1686         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
1687         There is an "ERROR" prefix in log messiges from now.
1688         (DefaultStyleErrorHandlerTest):
1689         (DefaultStyleErrorHandlerTest.setUp):
1690         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
1691         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1692         (DefaultStyleErrorHandlerTest._check_initialized):
1693         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
1694         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
1695         (DefaultStyleErrorHandlerTest.test_line_numbers):
1696
1697 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
1698
1699         Add JavaScript style checker and teach checker.py about .js files
1700         https://bugs.webkit.org/show_bug.cgi?id=125049
1701
1702         Reviewed by Joseph Pecoraro.
1703
1704         Add a JavaScript file type, extension, and checker (JSChecker).
1705         Use TextChecker for JavaScript tests, libraries, website resources,
1706         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
1707
1708         Amended tests for TextChecker to reflect the rule above.
1709
1710         * Scripts/webkitpy/style/checker.py:
1711         (_all_categories): Add categories defined by JSChecker.
1712         (FileType): Add file type for JS and re-number the enum.
1713         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
1714         (CheckerDispatcher._create_checker):
1715         Create a JSChecker or TextChecker depending on the file's path.
1716
1717         * Scripts/webkitpy/style/checker_unittest.py:
1718         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
1719         (CheckerDispatcherDispatchTest.test_js_paths): Added.
1720         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
1721         that end in .js but should be checked with TextChecker.
1722         * Scripts/webkitpy/style/checkers/js.py: Added.
1723         (JSChecker):
1724         (JSChecker.__init__):
1725         (JSChecker.check):
1726         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
1727         (JSTestCase):
1728         (JSTestCase.assertNoError):
1729         (JSTestCase.assertNoError.error_for_test):
1730         (JSTestCase.assertError):
1731         (JSTestCase.assertError.error_for_test):
1732         (JSTestCase.test_no_error):
1733         (JSTestCase.test_error):
1734
1735 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1736
1737         run-jsc-stress-tests always copies the VM
1738         https://bugs.webkit.org/show_bug.cgi?id=125092
1739
1740         Reviewed by Filip Pizlo.
1741
1742         This can be slow, especially with full debug builds. It should just symlink the VM into the 
1743         bundle by default and do a full copy only when asked.
1744
1745         * Scripts/run-jsc-stress-tests:
1746
1747 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
1748
1749         [Win] Port run-jsc-stress-tests
1750         https://bugs.webkit.org/show_bug.cgi?id=124801
1751
1752         Reviewed by Filip Pizlo.
1753
1754         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
1755         command on Windows so that stress tests can run.
1756
1757 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1758
1759         Build fix after r159955
1760
1761         * Scripts/run-jsc-stress-tests:
1762
1763 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1764
1765         run-jsc-stress-tests should be able to package its tests and move them places
1766         https://bugs.webkit.org/show_bug.cgi?id=124549
1767
1768         Reviewed by Filip Pizlo.
1769
1770         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
1771         of grep -i -q
1772         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
1773         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
1774         We now also copy whatever VM was specified, along with its associated framework, into this directory.
1775         All of the generated scripts now are completely relative within the results directory. This allows
1776         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
1777         tarball of the generated results directory. Also refactored several portions of the script into
1778         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
1779
1780 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
1781
1782         [ATK] Support active state for listbox elements.
1783         https://bugs.webkit.org/show_bug.cgi?id=125009
1784
1785         Reviewed by Chris Fleizach.
1786
1787         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
1788
1789         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1790         (AccessibilityUIElement::isSelectedOptionActive):
1791         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1792         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1793         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1794         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1795         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1796         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1797         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1798         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1799
1800 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
1801
1802         Unreviewed GTK gardening.
1803
1804         * Scripts/run-gtk-tests:
1805         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
1806
1807 2013-12-01  Dan Bernstein  <mitz@apple.com>
1808
1809         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
1810         https://bugs.webkit.org/show_bug.cgi?id=125046
1811
1812         Reviewed by Sam Weinig.
1813
1814         * MiniBrowser/mac/AppDelegate.m:
1815         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
1816         (-[BrowserAppDelegate openDocument:]): Ditto.
1817         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
1818         interface to the implementation.
1819         * MiniBrowser/mac/WK2BrowserWindowController.m:
1820         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
1821         the policy client.
1822         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1823         Moved policy client implementation into this delegate method.
1824         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
1825         Ditto.
1826         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
1827         Ditto.
1828
1829 2013-12-01  Dan Bernstein  <mitz@apple.com>
1830
1831         [Mac] Remove the MiniBrowser injected bundle
1832         https://bugs.webkit.org/show_bug.cgi?id=125041
1833
1834         Reviewed by Anders Carlsson.
1835
1836         It had no ops!
1837
1838         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
1839         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1840         * MiniBrowser/mac/AppDelegate.m:
1841         (-[BrowserAppDelegate init]):
1842         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
1843         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
1844
1845 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1846
1847         check-webkit-style should check for extraneous newline between config.h and primary header.
1848         https://bugs.webkit.org/show_bug.cgi?id=124821
1849
1850         Reviewed by Csaba Osztrogonác.
1851
1852         * Scripts/webkitpy/style/checkers/cpp.py:
1853         (check_include_line):
1854         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1855         (OrderOfIncludesTest.test_check_line_break_after_own_header):
1856         (OrderOfIncludesTest):
1857         (OrderOfIncludesTest.test_check_line_break_before_own_header):
1858
1859 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
1860
1861         test-webkit-scripts should show the failing tests and use an appropriate exit code
1862         https://bugs.webkit.org/show_bug.cgi?id=124840
1863
1864         Reviewed by Ryosuke Niwa.
1865
1866         A fixme in test-webkit-scripts asked that the script should display success or failiure
1867         and exit with a 0 or 1 value accordingly after all of the tests have completed.
1868
1869         * Scripts/test-webkit-scripts:
1870         (ScriptsTester.run_test_script):
1871         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
1872         because at this point we don't need to pass on more information other than success or failiure.
1873         (ScriptsTester.main):
1874         The return values are now stored for each script and when all tests have completed successfully,
1875         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
1876
1877 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
1878
1879         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
1880         https://bugs.webkit.org/show_bug.cgi?id=124923
1881
1882         Reviewed by Mario Sanchez Prada.
1883
1884         Added missing implementation of isAttributeSettable. Using
1885         ATK_STATE_EDITABLE for checking whether attribute is settable.
1886
1887         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1888         (AccessibilityUIElement::isAttributeSettable):
1889         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1890         (WTR::AccessibilityUIElement::isAttributeSettable):
1891
1892 2013-11-28  Commit Queue  <commit-queue@webkit.org>
1893
1894         Unreviewed, rolling out r159839.
1895         http://trac.webkit.org/changeset/159839
1896         https://bugs.webkit.org/show_bug.cgi?id=124974
1897
1898         run-webkit-tests doesn't generate pretty diff (Requested by
1899         Ossy on #webkit).
1900
1901         * Scripts/webkitpy/common/prettypatch.py:
1902         (PrettyPatch.__init__):
1903         (PrettyPatch.pretty_diff):
1904         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1905         (TestResultWriter.create_text_diff_and_write_result):
1906         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1907         (summarize_results):
1908         * Scripts/webkitpy/port/base.py:
1909         (Port.__init__):
1910         (Port.pretty_patch_available):
1911         (Port.check_pretty_patch):
1912         (Port.variable):
1913         (Port.variable.pretty_patch_text):
1914         * Scripts/webkitpy/port/base_unittest.py:
1915         (PortTest.test_pretty_patch_os_error):
1916         (PortTest.test_pretty_patch_script_error):
1917
1918 2013-11-28  Antti Koivisto  <antti@apple.com>
1919
1920         Remove feature: CSS variables
1921         https://bugs.webkit.org/show_bug.cgi?id=114119
1922
1923         Reviewed by Andreas Kling.
1924
1925         * Scripts/webkitperl/FeatureList.pm:
1926
1927 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1928
1929         Move PrettyPatch related code to prettypatch.py
1930         https://bugs.webkit.org/show_bug.cgi?id=124937
1931
1932         Reviewed by Ryosuke Niwa.
1933
1934         This code seems to have a better place here than in Port, since PrettyPatch already knows
1935         pretty_patch_path, and this also unifies the usage of PrettyPatch
1936
1937         * Scripts/webkitpy/common/prettypatch.py:
1938         (PrettyPatch.__init__):
1939         (PrettyPatch.pretty_diff):
1940         (PrettyPatch):
1941         (PrettyPatch.pretty_patch_available):
1942         (PrettyPatch.check_pretty_patch):
1943         (PrettyPatch.pretty_patch_text):
1944         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1945         (TestResultWriter.create_text_diff_and_write_result):
1946         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1947         (summarize_results):
1948         * Scripts/webkitpy/port/base.py:
1949         (Port.__init__):
1950         (Port.wdiff_available):
1951         (Port.check_image_diff):
1952         (Port.wdiff_text):
1953         * Scripts/webkitpy/port/base_unittest.py:
1954         (PortTest.test_pretty_patch_os_error):
1955         (PortTest.test_pretty_patch_script_error):
1956
1957 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1958
1959         Checkout should own the scm object in Host
1960         https://bugs.webkit.org/show_bug.cgi?id=124943
1961
1962         Reviewed by Ryosuke Niwa.
1963
1964         * Scripts/webkitpy/common/host.py:
1965         (Host.__init__):
1966         (Host.initialize_scm):
1967         (Host.scm):
1968
1969 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
1970
1971         Do bytecode validation as part of testing
1972         https://bugs.webkit.org/show_bug.cgi?id=124913
1973
1974         Reviewed by Oliver Hunt.
1975
1976         * Scripts/run-jsc-stress-tests:
1977
1978 2013-11-27  Andres Gomez  <agomez@igalia.com>
1979
1980         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
1981         https://bugs.webkit.org/show_bug.cgi?id=124940
1982
1983         Reviewed by Martin Robinson.
1984
1985         xserver-font-utils is needed for building gtk port dependencies
1986         with jhbuild.
1987
1988         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
1989         dependecies.
1990
1991 2013-11-27  Andres Gomez  <agomez@igalia.com>
1992
1993         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
1994         https://bugs.webkit.org/show_bug.cgi?id=124938
1995
1996         Reviewed by Philippe Normand.
1997
1998         Added needed git dependency for building the gtk port with
1999         jhbuild. Also, the dependencies needed for building the gtk port
2000         are now sorted alphabetically.
2001
2002         * gtk/install-dependencies: Added git as jhbuild dependency and
2003         sorted dependencies alphabetically.
2004
2005 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2006
2007         run_webkit_tests.py: error: no such option: --wincairo
2008         https://bugs.webkit.org/show_bug.cgi?id=124927
2009
2010         Reviewed by Ryosuke Niwa.
2011
2012         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2013         the layout testing on wincairo, so it is turned off.
2014
2015 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2016
2017         Nix upstreaming - Adding build files and supporting scripts
2018         https://bugs.webkit.org/show_bug.cgi?id=118367
2019
2020         Reviewed by Ryosuke Niwa.
2021
2022         * Scripts/build-webkit:
2023         * Scripts/run-nix-tests: Added.
2024         * Scripts/run-webkit-tests:
2025         * Scripts/update-webkit-libs-jhbuild:
2026         * Scripts/update-webkitnix-libs: Added.
2027         * Scripts/webkitdirs.pm:
2028         (determineArchitecture):
2029         (argumentsForConfiguration):
2030         (jscProductDir):
2031         (builtDylibPathForName):
2032         (determineIsNix):
2033         (isNix):
2034         (isAppleWebKit):
2035         (launcherPath):
2036         (launcherName):
2037         (checkRequiredSystemConfig):
2038         (copyInspectorFrontendFiles):
2039         (jhbuildWrapperPrefixIfNeeded):
2040         (buildCMakeProjectOrExit):
2041         (cmakeBasedPortName):
2042         * Scripts/webkitpy/common/config/ports.py:
2043         (DeprecatedPort.port):
2044         (EflWK2Port.build_webkit_command):
2045         (NixPort):
2046         (NixPort.build_webkit_command):
2047         * Scripts/webkitpy/port/factory.py:
2048         (platform_options):
2049         (PortFactory):
2050         * Scripts/webkitpy/port/nix.py: Added.
2051         (NixPort):
2052         (NixPort._wk2_port_name):
2053         (NixPort.determine_full_port_name):
2054         (NixPort.__init__):
2055         (NixPort._port_flag_for_scripts):
2056         (NixPort.setup_test_run):
2057         (NixPort.setup_environ_for_server):
2058         (NixPort.default_timeout_ms):
2059         (NixPort.clean_up_test_run):
2060         (NixPort._generate_all_test_configurations):
2061         (NixPort._path_to_driver):
2062         (NixPort._path_to_image_diff):
2063         (NixPort._image_diff_command):
2064         (NixPort._search_paths):
2065         (NixPort.show_results_html_file):
2066         (NixPort._port_specific_expectations_files):
2067         (NixPort.default_baseline_search_path):
2068         * Scripts/webkitpy/port/nix_unittest.py: Added.
2069         (NixPortTest):
2070         (NixPortTest._assert_search_path):
2071         (NixPortTest._assert_expectations_files):
2072         (NixPortTest.test_baseline_search_path):
2073         (NixPortTest.test_expectations_files):
2074         (NixPortTest.test_default_timeout_ms):
2075         * jhbuild/jhbuild-wrapper:
2076         (determine_platform):
2077         * nix/common.py: Added.
2078         (script_path):
2079         (top_level_path):
2080         * nix/jhbuild.modules: Added.
2081         * nix/jhbuildrc: Added.
2082
2083 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2084
2085         Record subtest values in Dromaeo tests
2086         https://bugs.webkit.org/show_bug.cgi?id=124498
2087
2088         Reviewed by Andreas Kling.
2089
2090         Supported parsing subtest results.
2091
2092         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2093         which contains a dictionary with its name and an ordered list of subtest's metrics.
2094         (PerfTest.__init__): Initialize _metrics as a list.
2095         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2096         (PerfTest._run_with_driver):
2097         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2098
2099         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2100         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2101         (TestPerfTest.test_parse_output): Ditto.
2102         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2103         assertions to ensure subtest results are parsed properly.
2104         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2105         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2106
2107         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2108         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2109         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2110         adding new results.
2111
2112         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2113         (TestWithSubtestsData): Added.
2114         (TestDriver.run_test):
2115         (MainTest.test_run_test_with_subtests): Added.
2116
2117 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2118
2119         Enable HTML template element on Windows ports
2120         https://bugs.webkit.org/show_bug.cgi?id=124758
2121
2122         Reviewed by Andreas Kling.
2123
2124         * Scripts/webkitperl/FeatureList.pm:
2125
2126 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2127
2128         Remove replay performance tests as it's not actively maintained
2129         https://bugs.webkit.org/show_bug.cgi?id=124764
2130
2131         Reviewed by Andreas Kling.
2132
2133         Removed the feature.
2134
2135         * Scripts/webkitpy/performance_tests/perftest.py:
2136         (SingleProcessPerfTest.__init__):
2137         (PerfTestFactory):
2138         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2139         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2140         (PerfTestsRunner._parse_args):
2141         (PerfTestsRunner._collect_tests):
2142         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2143         (MainTest.test_collect_tests_with_ignored_skipped_list):
2144         (MainTest.test_default_args):
2145         * Scripts/webkitpy/thirdparty/__init__.py:
2146         (AutoinstallImportHook.find_module):
2147         (AutoinstallImportHook._install_unittest2):
2148         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2149         (ThirdpartyTest.test_imports):
2150
2151 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2152
2153         Enable aggressive DFG validation in testing
2154         https://bugs.webkit.org/show_bug.cgi?id=124911
2155
2156         Rubber stamped by Ryosuke Niwa.
2157         
2158         This enables validation testing in non-concurrent-JIT runs.
2159
2160         * Scripts/run-jsc-stress-tests:
2161
2162 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2163
2164         Moved methods which belong to Checkout into checkout.py
2165         https://bugs.webkit.org/show_bug.cgi?id=124889
2166
2167         Reviewed by Ryosuke Niwa.
2168
2169         * Scripts/webkitpy/common/checkout/checkout.py:
2170         (Checkout.scripts_directory):
2171         (Checkout):
2172         (Checkout.script_path):
2173         (Checkout.commit_message_for_this_commit):
2174         (Checkout.apply_patch):
2175         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2176         (test_commit_message_for_this_commit):
2177         (CheckoutTest.test_apply_patch):
2178         * Scripts/webkitpy/common/checkout/scm/scm.py:
2179         (SCM.absolute_path):
2180         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2181         (SCMTest._setup_webkittools_scripts_symlink):
2182         * Scripts/webkitpy/common/checkout/scm/svn.py:
2183         (SVN.create_patch):
2184
2185 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
2186
2187         [EFL] Use Config mode of find_package for EFL 1.8
2188         https://bugs.webkit.org/show_bug.cgi?id=124555
2189
2190         Reviewed by Gyuyoung Kim.
2191
2192         * MiniBrowser/efl/CMakeLists.txt:
2193         Added optional config mode and made version requirement optional.
2194
2195 2013-11-25  Andres Gomez  <agomez@igalia.com>
2196
2197         [GTK] Search functionality in MiniBrowser provides feedback on search fail
2198         https://bugs.webkit.org/show_bug.cgi?id=122681
2199
2200         Reviewed by Mario Sanchez Prada.
2201
2202         When using the search functionality in MiniBrowser, if the search
2203         fails, the entry background color gets red to report the user
2204         about the failing condition. When the entry is cleaned or the
2205         search is again succesful the background turns back to its
2206         original color.
2207
2208         * MiniBrowser/gtk/BrowserSearchBar.c:
2209         (setFailedStyleForEntry): Added.
2210         (doSearch): Sets the entry's background to its original style if
2211         there is no text to search.
2212         (findControllerFailedToFindTextCallback): Added.
2213         (findControllerFoundTextCallback): Added.
2214         (browser_search_bar_init): Creates and adds a new CSS provider to
2215         the text entry so we can change its style based on the success
2216         condition of the search.
2217         (browserSearchBarFinalize): Frees the new CSS provider.
2218         (browser_search_bar_new): Connects the two new handlers to the
2219         "failed-to-find-text" and "found-text" signals emitted by the
2220         WebKitFindController.
2221
2222 2013-11-25  Dan Bernstein  <mitz@apple.com>
2223
2224         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
2225         https://bugs.webkit.org/show_bug.cgi?id=124850
2226
2227         Reviewed by Brady Eidson.
2228
2229         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
2230
2231         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2232         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2233         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2234         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2235         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2236         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2237         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2238
2239 2013-11-25  Commit Queue  <commit-queue@webkit.org>
2240
2241         Unreviewed, rolling out r159752 and r159754.
2242         http://trac.webkit.org/changeset/159752
2243         http://trac.webkit.org/changeset/159754
2244         https://bugs.webkit.org/show_bug.cgi?id=124847
2245
2246         Broke linux test bots. (Requested by mhahnenberg on #webkit).
2247
2248         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2249         * Scripts/run-javascriptcore-tests:
2250         * Scripts/run-jsc-stress-tests:
2251
2252 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2253
2254         Followup fix after r159752
2255
2256         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
2257
2258 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2259
2260         run-jsc-stress-tests should be able to package its tests and move them places
2261         https://bugs.webkit.org/show_bug.cgi?id=124549
2262
2263         Reviewed by Filip Pizlo.
2264
2265         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
2266         of grep -i -q
2267         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2268         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
2269         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
2270         All of the generated scripts now are completely relative within the results directory. This allows 
2271         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
2272         tarball of the generated results directory. Also refactored several portions of the script into 
2273         separate functions to make it easier to run them conditionally depending on which mode we're running in.
2274
2275 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
2276
2277         EWS creates 0 byte sized log files
2278         https://bugs.webkit.org/show_bug.cgi?id=107606
2279
2280         Reviewed by Ryosuke Niwa.
2281
2282         There was a modification in r138264, that tried to make less log,
2283         because some of the messeges were duplicated. After this the EWS
2284         created the log file (with the same name as the bugID) but doesn't
2285         write anything into it, even if there were errors during the build.
2286         From now only creates the log file only if there is some error.
2287
2288         * Scripts/webkitpy/tool/bot/queueengine.py:
2289         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2290         there is nothing to log. Open the log file only if a ScriptError was raised to
2291         avoid to make empty log files for bugs.
2292         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2293         because of changes in r138264. Teeing is used for locally testing purposes and
2294         this feature is not used anymore.
2295         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
2296         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2297         change.
2298         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2299         (LoggingDelegate): The order of the callbacks was changed by this patch.
2300         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
2301         so we have to update this test.
2302         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
2303         this patch.
2304         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2305         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2306         to be able to handle it in QueueEngine.run. Without this change, the existing
2307         exception handler never run (the process_work_item method never raise ScriptError)
2308         We can get the error message only from the ScriptError at this point.
2309
2310 2013-11-22  Dean Jackson  <dino@apple.com>
2311
2312         Speculative Mountain Lion build fix.
2313
2314         * MiniBrowser/mac/AppDelegate.m:
2315         (-[BrowserAppDelegate openDocument:]):
2316
2317 2013-11-22  Anders Carlsson  <andersca@apple.com>
2318
2319         Fix Mountain Lion bug.
2320
2321         * MiniBrowser/mac/AppDelegate.m:
2322         (-[BrowserAppDelegate openDocument:]):
2323
2324 2013-11-22  Anders Carlsson  <andersca@apple.com>
2325
2326         MiniBrowser should use the blocks-based NSOpenPanel API
2327         https://bugs.webkit.org/show_bug.cgi?id=124786
2328
2329         Reviewed by Simon Fraser.
2330
2331         * MiniBrowser/mac/AppDelegate.m:
2332         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2333         Account for windows that don't have a BrowserWindowController.
2334
2335         (-[BrowserAppDelegate openDocument:]):
2336
2337 2013-11-22  Commit Queue  <commit-queue@webkit.org>
2338
2339         Unreviewed, rolling out r159690.
2340         http://trac.webkit.org/changeset/159690
2341         https://bugs.webkit.org/show_bug.cgi?id=124782
2342
2343         Broke webkitpy tests (Requested by ap on #webkit).
2344
2345         * Scripts/webkitpy/tool/bot/queueengine.py:
2346         (QueueEngine.run):
2347         (QueueEngine._open_work_log):
2348         (QueueEngine._ensure_work_log_closed):
2349         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2350         (AbstractEarlyWarningSystem.review_patch):
2351
2352 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
2353
2354         EWS creates 0 byte sized log files
2355         https://bugs.webkit.org/show_bug.cgi?id=107606
2356
2357         Reviewed by Ryosuke Niwa.
2358
2359         There was a modification in r138264, that tried to make less log, 
2360         because some of the messeges were duplicated. After this the EWS 
2361         created the log file (with the same name as the bugID) but doesn't 
2362         write anything into it, even if there were errors during the build. 
2363         From now only creates the log file only if there is some error.
2364
2365         * Scripts/webkitpy/tool/bot/queueengine.py:
2366         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2367         there is nothing to log. Open the log file only if a ScriptError was raised to
2368         avoid to make empty log files for bugs.
2369         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2370         because of changes in r138264. Teeing is used for locally testing purposes and
2371         this feature is not used anymore.
2372         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2373         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2374         change.
2375         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2376         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2377         to be able to handle it in QueueEngine.run. Without this change, the existing
2378         exception handler never run (the process_work_item method never raise ScriptError)
2379         We can get the error message only from the ScriptError at this point.
2380
2381 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2382
2383         Remove ENABLE_WORKERS
2384         https://bugs.webkit.org/show_bug.cgi?id=105784
2385
2386         Reviewed by Darin Adler.
2387
2388         * Scripts/webkitperl/FeatureList.pm:
2389
2390 2013-11-21  Darin Adler  <darin@apple.com>
2391
2392         Try to fix buildbot Dashboard for people who have not hidden anything.
2393
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2395         Add a null check for hidden platforms.
2396
2397 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
2398
2399         Remove chrome/chromium related things from webkitpy.
2400         https://bugs.webkit.org/show_bug.cgi?id=124493
2401
2402         Reviewed by Darin Adler.
2403
2404         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2405         (PortTest.assert_mock_port_works):
2406         * Scripts/webkitpy/port/base.py:
2407         (Port.to.setup_environ_for_server):
2408         * Scripts/webkitpy/port/mac_unittest.py:
2409         (test_tests_for_other_platforms):
2410         * Scripts/webkitpy/port/mock_drt.py:
2411         (MockTestShell.output_for_test):
2412         * Scripts/webkitpy/tool/bot/irc_command.py:
2413         (Restart.execute):
2414         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2415         (IRCBotTest.test_help):
2416
2417 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2418
2419         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
2420         https://bugs.webkit.org/show_bug.cgi?id=124717
2421
2422         Reviewed by Ryosuke Niwa.
2423
2424         * Scripts/webkitpy/style/filereader.py:
2425         (TextFileReader.process_file):
2426         * Scripts/webkitpy/style/filereader_unittest.py:
2427         (TextFileReaderTest.test_process_file__does_not_exist):
2428
2429 2013-11-21  Mark Rowe  <mrowe@apple.com>
2430
2431         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
2432
2433         All modern versions of Xcode set it appropriately for our needs.
2434
2435         Reviewed by Alexey Proskuryakov.
2436
2437         * MiniBrowser/Configurations/Base.xcconfig:
2438         * WebKitTestRunner/Configurations/Base.xcconfig:
2439
2440 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
2441
2442         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
2443         https://bugs.webkit.org/show_bug.cgi?id=124676
2444
2445         Reviewed by Daniel Bates.
2446
2447         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
2448         elements when there were more then one occurrence of that argument.
2449         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
2450         {b, a}, when it should be {b, c}.
2451
2452         * Scripts/webkitdirs.pm:
2453         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
2454         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2455         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
2456
2457 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2458
2459         Update build-webkit after r159550.
2460
2461         * Scripts/webkitperl/FeatureList.pm:
2462
2463 2013-11-21  Lucas Forschler  <lforschler@apple.com>
2464
2465         Bring a new bot online, replacing the previous ones.
2466         
2467         Unreviewed.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/config.json:
2470
2471 2013-11-21  Dean Jackson  <dino@apple.com>
2472
2473         Don't fetch hidden platforms on build.webkit.org/dashboard
2474         https://bugs.webkit.org/show_bug.cgi?id=124750
2475
2476         Reviewed by Tim Horton.
2477
2478         If a platform is hidden, don't fetch its data. If it
2479         becomes unhidden, try to fetch immediately (unless
2480         you've recently fetched).
2481
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2484
2485 2013-11-21  Commit Queue  <commit-queue@webkit.org>
2486
2487         Unreviewed, rolling out r159633.
2488         http://trac.webkit.org/changeset/159633
2489         https://bugs.webkit.org/show_bug.cgi?id=124726
2490
2491         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
2492
2493         * Scripts/webkitpy/style/checker.py:
2494         (check_webkit_style_configuration):
2495         (CheckerDispatcher.dispatch):
2496         (StyleProcessorConfiguration):
2497         (StyleProcessorConfiguration.__init__):
2498         (StyleProcessorConfiguration.write_style_error):
2499
2500 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
2501
2502         Remove the stderr_write attribute from StyleProcessorConfiguration.
2503         https://bugs.webkit.org/show_bug.cgi?id=124703
2504
2505         Reviewed by Brent Fulgham.
2506
2507         * Scripts/webkitpy/style/checker.py:
2508         (check_webkit_style_configuration):
2509         (CheckerDispatcher.dispatch):
2510         (StyleProcessorConfiguration):
2511         (StyleProcessorConfiguration.__init__):
2512         (StyleProcessorConfiguration.write_style_error):
2513
2514 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2515
2516         PerfTestRunner._generate_results_dict shouldn't depend on test objects
2517         https://bugs.webkit.org/show_bug.cgi?id=124623
2518
2519         Removed the dependency on test objects from results JSON generation.
2520         This allows single test.run to return metrics for multiple tests
2521
2522         Reviewed by Antti Koivisto.
2523
2524         * Scripts/webkitpy/performance_tests/perftest.py:
2525         (PerfTestMetric.__init__): Takes the test path and test name.
2526         (PerfTestMetric.path): Added.
2527         (PerfTestMetric.test_file_name): Added.
2528         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
2529         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
2530         The path is going to have the names of subtests at the end once we support them.
2531
2532         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2533         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
2534         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
2535         (TestPerfTestMetric.test_has_values): Ditto.
2536         (TestPerfTestMetric.test_append): Ditto.
2537
2538         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2539         (_generate_results_dict): Only use metrics.
2540         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
2541
2542 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
2543
2544         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
2545         https://bugs.webkit.org/show_bug.cgi?id=124697
2546
2547         Reviewed by Ryosuke Niwa.
2548
2549         * Scripts/webkitdirs.pm:
2550         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
2551         before trying to access to the first element.
2552
2553 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2554
2555         [GTK] Mark all deprecated symbols in GObject DOM bindings
2556         https://bugs.webkit.org/show_bug.cgi?id=124406
2557
2558         Reviewed by Gustavo Noronha Silva.
2559
2560         * Scripts/webkitpy/style/checker.py: Add special case for
2561         WebKitDOMDeprecated.
2562         * gtk/generate-gtkdoc:
2563         (get_webkit2_options): Use the prefix of the methods as namespace,
2564         since this is what gtkdoc expects to sort the index.
2565         (get_webkit1_options): Ditto.
2566         (get_webkitdom_options): Ditto.
2567         * gtk/generate-webkitdom-doc-files:
2568         (WebKitDOMDocGenerator): Add a global list of deleted objects.
2569         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
2570         the documentation for classes that are deprecated because they
2571         have been removed.
2572         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
2573         for deleted classes too.
2574         (WebKitDOMDocGeneratorSections.__init__): Build a list of
2575         deprecated symbols using the given symbols file.
2576         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
2577         deleted class corresponding to the given function.
2578         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
2579         dictionary of deprecated symbols for every class.
2580         (WebKitDOMDocGeneratorSections.write_section): Add also the
2581         deprecated symbols in every section.
2582         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
2583         sections for deleted classes too.
2584
2585 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
2586
2587         check-webkit-style should support C++11 rvalue references.
2588         https://bugs.webkit.org/show_bug.cgi?id=123406
2589
2590         Reviewed by Brent Fulgham.
2591
2592         * Scripts/webkitpy/style/checkers/cpp.py:
2593         (check_style):
2594         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2595         (Cpp11StyleTest):
2596         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
2597
2598 2013-11-20  Dean Jackson  <dino@apple.com>
2599
2600         Allow settings to be shown/hidden on build.webkit.org/dashboard
2601         https://bugs.webkit.org/show_bug.cgi?id=124694
2602
2603         Reviewed by Tim Horton.
2604
2605         In preparation for more options/buttons, allow the page to
2606         show or hide all the interactive things using a little gear icon
2607         in the top left corner.
2608
2609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2611         (Settings.prototype.toggleSettingsDisplay):
2612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2613         (div.cellButton.hide):
2614         (div.cellButton.unhide):
2615         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
2616         (.settings):
2617         (.settings:hover):
2618         (.settings-visible .settings):
2619
2620 2013-11-20  Dean Jackson  <dino@apple.com>
2621
2622         No need to base64 SVG on build.webkit.org/dashboard
2623         https://bugs.webkit.org/show_bug.cgi?id=124687
2624
2625         Reviewed by Tim Horton.
2626
2627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2628         (.status-line.good .bubble.pictogram):
2629
2630 2013-11-20  Dean Jackson  <dino@apple.com>
2631
2632         Make links look more like links on build.webkit.org/dashboard
2633         https://bugs.webkit.org/show_bug.cgi?id=124686
2634
2635         Reviewed by Tim Horton.
2636
2637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2638         (.queue-view .queueLabel:hover):
2639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2640         (.status-line.linked .label:hover):
2641
2642 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
2643
2644         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
2645         https://bugs.webkit.org/show_bug.cgi?id=124581
2646
2647         Reviewed by Daniel Bates.
2648
2649         Some subroutines are replicating code from checkForArgument**
2650         functions instead of reusing them as is being done by all other functions.
2651
2652         * Scripts/webkitdirs.pm:
2653         (determineXcodeSDK): Added.
2654         (determinePassedConfiguration): Added.
2655         (determinePassedArchitecture): Added.
2656         (checkForArgumentAndRemoveFromARGV): Added.
2657         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
2658
2659 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
2660
2661         Delete baseline optimizer
2662         https://bugs.webkit.org/show_bug.cgi?id=122333
2663
2664         Reviewed by Ryosuke Niwa.
2665
2666         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
2667         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
2668         * Scripts/webkitpy/tool/commands/rebaseline.py:
2669         (RebaselineTest.execute):
2670         (AbstractParallelRebaselineCommand._files_to_add):
2671         (AbstractParallelRebaselineCommand._rebaseline):
2672         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2673         (TestRebaselineJson.test_rebaseline_all):
2674         (TestRebaselineJson.test_rebaseline_debug):
2675         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
2676
2677 2013-11-20  Anders Carlsson  <andersca@apple.com>
2678
2679         Enable PageLoadTest assertions again
2680         https://bugs.webkit.org/show_bug.cgi?id=124681
2681
2682         Reviewed by Tim Horton.
2683
2684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2685         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
2686
2687 2013-11-20  Mark Rowe  <mrowe@apple.com>
2688
2689         Remove some obsolete logic from WebKit.app.
2690
2691         Reviewed by Alexey Proskuryakov.
2692
2693         * WebKitLauncher/WebKitNightlyEnabler.m:
2694         (poseAsWebKitApp): Remove a pre-10.6 codepath.
2695         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
2696
2697 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2698
2699         Moved stray urls from svn.py and statusserver.py into common.config.urls
2700         https://bugs.webkit.org/show_bug.cgi?id=124650
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         * Scripts/webkitpy/common/checkout/scm/svn.py:
2705         (SVNRepository):
2706         * Scripts/webkitpy/common/config/urls.py:
2707         * Scripts/webkitpy/common/net/statusserver.py:
2708         (StatusServer.__init__):
2709         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2710         (_generate_results_dict):
2711
2712 2013-11-20  Commit Queue  <commit-queue@webkit.org>
2713
2714         Unreviewed, rolling out r159496.
2715         http://trac.webkit.org/changeset/159496
2716         https://bugs.webkit.org/show_bug.cgi?id=124641
2717
2718         It caused warning and build break with cmake lower than 2.8.8
2719         (Requested by ryuan on #webkit).
2720
2721         * MiniBrowser/efl/CMakeLists.txt:
2722
2723 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
2724
2725         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
2726         https://bugs.webkit.org/show_bug.cgi?id=124412
2727
2728         Reviewed by Gyuyoung Kim.
2729
2730         Update libseccomp to a newer 2.1.0 version.
2731
2732         * efl/jhbuild.modules:
2733
2734 2013-11-19  Mark Rowe  <mrowe@apple.com>
2735
2736         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
2737
2738         Gestalt is deprecated on recent OS X versions so we should switch off it.
2739
2740         Reviewed by Sam Weinig.
2741
2742         * WebKitLauncher/main.m:
2743         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
2744         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
2745         two components, then join them back up.
2746         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
2747         the version we care about.
2748
2749 2013-11-19  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r159538.
2752         http://trac.webkit.org/changeset/159538
2753         https://bugs.webkit.org/show_bug.cgi?id=124627
2754
2755         it broke run-jsc-stress-tests (Requested by mhahnenberg on
2756         #webkit).
2757
2758         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2759         * Scripts/run-javascriptcore-tests:
2760         * Scripts/run-jsc-stress-tests:
2761
2762 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2763
2764         run-jsc-stress-tests should be able to package its tests and move them places
2765         https://bugs.webkit.org/show_bug.cgi?id=124549
2766
2767         Reviewed by Geoff Garen and Filip Pizlo.
2768
2769         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
2770         of grep -i -q 
2771         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
2772         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
2773         other files that those tests require to run in any environment along with a fixed root directory into which these
2774         files and their expected directory structure are cloned. The default Bundle class is basically 
2775         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
2776         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
2777         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
2778         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
2779         to use MovableBundle instead of just Bundle. 
2780
2781 2013-11-19  Dan Bernstein  <mitz@apple.com>
2782
2783         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
2784
2785         Rubber-stamped by Mark Rowe.
2786
2787         Reverted r156840.
2788
2789         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2790
2791 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2792
2793         Yet another build fix. Just allow any character.
2794         There are just too many special characters to be listed here.
2795
2796         * Scripts/webkitpy/performance_tests/perftest.py:
2797         (PerfTest._lines_to_ignore_in_parser_result):
2798         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2799         (TestPerfTest.test_parse_output_with_subtests)
2800
2801 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2802
2803         Another build fix. Allow ':' in subtest names.
2804
2805         * Scripts/webkitpy/performance_tests/perftest.py:
2806         (PerfTest._lines_to_ignore_in_parser_result):
2807         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2808         (TestPerfTest.test_parse_output_with_subtests)
2809
2810 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
2811
2812         [EFL] Use Config mode of find_package for EFL 1.8
2813         https://bugs.webkit.org/show_bug.cgi?id=124555
2814
2815         Reviewed by Gyuyoung Kim.
2816
2817         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
2818
2819 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2820
2821         Build fix. Subtest names need to be more permissive.
2822
2823         * Scripts/webkitpy/performance_tests/perftest.py:
2824         (PerfTest._lines_to_ignore_in_parser_result):
2825         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2826         (TestPerfTest.test_parse_output_with_subtests)
2827
2828 2013-11-18  Mark Rowe  <mrowe@apple.com>
2829
2830         Use hw.activecpu for determining how many processes to spawn.
2831
2832         It's documented as the preferred way to determine the number of threads
2833         or processes to create in a SMP aware application.
2834
2835         Rubber-stamped by Tim Horton.
2836
2837         * Scripts/copy-webkitlibraries-to-product-directory:
2838         * Scripts/run-jsc-stress-tests:
2839         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2840
2841 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2842
2843         build.webkit.org/dashboard builder headers should link to the builder page
2844         https://bugs.webkit.org/show_bug.cgi?id=124553
2845
2846         Reviewed by Timothy Hatcher.
2847
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2849         (BuildbotQueue.prototype.get overviewURL):
2850         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
2851
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2853         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
2854         (BuildbotBuilderQueueView.prototype.update):
2855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2856         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2857         (BuildbotTesterQueueView.prototype.update.appendBuild):
2858         (BuildbotTesterQueueView.prototype.update):
2859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2860         (.queue-view .queueLabel):
2861         (.queue-view .queueLabel:not(:first-child)):
2862         Make the header a link instead of a label, and wire it up to overviewURL.
2863
2864 2013-11-18  Samuel White  <samuel_white@apple.com>
2865
2866         AX: Add ability to fetch only visible table rows.
2867         https://bugs.webkit.org/show_bug.cgi?id=124430
2868
2869         Reviewed by Chris Fleizach.
2870
2871         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
2872         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
2873         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
2874         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
2875         as the test guidelines state, our tests should be more focused and specific about what they test.
2876
2877         * DumpRenderTree/AccessibilityUIElement.cpp:
2878         (uiElementArrayAttributeValueCallback):
2879         (AccessibilityUIElement::uiElementArrayAttributeValue):
2880         (AccessibilityUIElement::getJSClass):
2881         * DumpRenderTree/AccessibilityUIElement.h:
2882         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2883         (AccessibilityUIElement::uiElementArrayAttributeValue):
2884         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2885         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2886         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2887         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2889         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2890         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2891         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
2892         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2893
2894 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
2895
2896         Simplify and reformat the output of performance tests inside test runners
2897         https://bugs.webkit.org/show_bug.cgi?id=124496
2898
2899         Reviewed by Antti Koivisto.
2900
2901         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
2902         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
2903         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
2904         the first place.
2905
2906         Also modernize the output to adopt "metric" concept better and make it forward compatible
2907         with subtests.
2908
2909         With this patch, performance tests written using runner.js only produces empty lines or
2910         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
2911         <subtest name> -> [<value 1>, <value 2>, ...]
2912         :<metric name> -> [<value 1>, <value 2>, ...]
2913
2914         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
2915
2916         * Scripts/webkitpy/performance_tests/perftest.py:
2917         (PerfTest): Removed a bunch of regular expressions that are no longer used.
2918         (PerfTest._run_with_driver): Just parse the values and description and treat everything
2919         else as errors.
2920
2921         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2922         (TestPerfTest.test_parse_output): Removed the junk.
2923         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
2924         which was removed in favor of the tests below.
2925         (TestPerfTest.test_parse_output_with_running_five_times): Added.
2926         (TestPerfTest.test_parse_output_with_detailed_info): Added.
2927         (TestPerfTest.test_parse_output_with_statistics): Added.
2928         (TestPerfTest.test_parse_output_with_description): Removed the junk.
2929         (TestPerfTest.test_parse_output_with_subtests): Ditto.
2930         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
2931
2932         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2933         (EventTargetWrapperTestData): Ditto.
2934         (SomeParserTestData): Ditto.
2935         (MemoryTestData): Ditto.
2936
2937 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2938
2939         Occasionally, hundreds of tests fail with small text diffs on Mavericks
2940         https://bugs.webkit.org/show_bug.cgi?id=124312
2941
2942         Reviewed by Simon Fraser.
2943
2944         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2945         (Manager._set_up_run):
2946         * Scripts/webkitpy/port/base.py:
2947         (Port.to.reset_preferences):
2948         * Scripts/webkitpy/port/mac.py:
2949         (MacPort.reset_preferences):
2950         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
2951         returning some of the functionality of 158652 after 159364 removed it.
2952
2953 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2954
2955         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
2956         https://bugs.webkit.org/show_bug.cgi?id=122909
2957
2958         Reviewed by Alexey Proskuryakov.
2959
2960         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
2961
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2963         (.status-line .bubble):
2964         (.status-line.good .bubble.pictogram):
2965
2966 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
2967
2968         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
2969         https://bugs.webkit.org/show_bug.cgi?id=124499
2970
2971         Reviewed by Csaba Osztrogonác.
2972
2973         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
2974
2975         * Scripts/webkitpy/performance_tests/perftest.py:
2976         (PerfTest._should_ignore_line):
2977         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2978         (TestPerfTest): Removed the unit test.
2979
2980 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
2981
2982         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
2983         quite as easily.
2984         
2985         With help from Andy Trick.
2986
2987         * Scripts/export-llvm-build:
2988
2989 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
2990
2991         FTL should have an explicit notion of bytecode liveness
2992         https://bugs.webkit.org/show_bug.cgi?id=124181
2993
2994         Reviewed by Mark Hahnenberg.
2995
2996         * Scripts/run-jsc-stress-tests:
2997
2998 2013-11-16  Dan Bernstein  <mitz@apple.com>
2999
3000         No way for policy client to determine if a the response’s MIME type can be shown
3001         https://bugs.webkit.org/show_bug.cgi?id=124445
3002
3003         Reviewed by Sam Weinig.
3004
3005         * MiniBrowser/mac/WK2BrowserWindowController.m:
3006         (decidePolicyForResponse): Added canShowMIMEType parameter.
3007         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
3008
3009         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3010         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
3011
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
3014         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
3015         * WebKitTestRunner/TestController.h:
3016
3017 2013-11-16  Tim Horton  <timothy_horton@apple.com>
3018
3019         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3020         https://bugs.webkit.org/show_bug.cgi?id=122909
3021
3022         Reviewed by Timothy Hatcher.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3026         (StatusLineView.prototype.set repeatCount):
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3028         (.status-line.good .bubble.pictogram):
3029         Use an SVG image instead of an obscure font for the checkboxes so they
3030         render identically on all platforms.
3031
3032 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3033
3034         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3035         https://bugs.webkit.org/show_bug.cgi?id=124312
3036
3037         Reviewed by Alexey Proskuryakov.
3038
3039         Try reverting the part of r158652 that deleted all of the persistent
3040         defaults, in the thought that there might be some sort of race between
3041         processes causing some settings to be left in the wrong state.
3042
3043         * DumpRenderTree/mac/DumpRenderTree.mm:
3044         (setDefaultsToConsistentValuesForTesting):
3045         * WebKitTestRunner/mac/main.mm:
3046         (setDefaultsToConsistentValuesForTesting):
3047
3048 2013-11-15  Dan Bernstein  <mitz@apple.com>
3049
3050         Give the policy client the originating frame of a navigation action
3051         https://bugs.webkit.org/show_bug.cgi?id=124431
3052
3053         Reviewed by Anders Carlsson.
3054
3055         * MiniBrowser/mac/WK2BrowserWindowController.m:
3056         (decidePolicyForNavigationAction): Added originatingFrame parameter.
3057         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
3058         client.
3059
3060         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3061         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3062         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
3063
3064         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3065         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3066         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
3067
3068         * WebKitTestRunner/TestController.cpp:
3069         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
3070         client.
3071         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
3072         * WebKitTestRunner/TestController.h:
3073
3074 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3075
3076         build.webkit.org/dashboard should provide a way to focus on a subset of bots
3077         https://bugs.webkit.org/show_bug.cgi?id=122676
3078
3079         Reviewed by Timothy Hatcher.
3080
3081         Add a small 'hide' button next to every platform logo, and a 'show all'
3082         button which only appears when at least one platform is hidden. Hidden
3083         platforms persist using localStorage.
3084
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3087         (updateHiddenPlatforms):
3088         (documentReady.unhideButton):
3089         (documentReady.hideButton):
3090         (documentReady):
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
3092         (Settings.prototype.setObject):
3093         (Settings.prototype.getObject):
3094         (Settings.prototype.addSettingListener):
3095         (Settings.prototype.fireSettingListener):
3096         (Settings.prototype.toggleHiddenPlatform):
3097         (Settings.prototype.clearHiddenPlatforms):
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3099         (div.cellButton):
3100         (div.cellButton.hide):
3101         (.hidden):
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3103
3104 2013-11-15  Jer Noble  <jer.noble@apple.com>
3105
3106         MediaTime addition and subtraction operators have errors when the rhs is infinite.
3107         https://bugs.webkit.org/show_bug.cgi?id=124413
3108
3109         Reviewed by Eric Carlson.
3110
3111         Add a test for operator+ and operator- where an infinite value appears
3112         on the right-hand side:
3113         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3114         (TestWebKitAPI::TEST):
3115
3116         Add a LLDB summary provider for MediaTime which displays the rational
3117         time as well as the value in seconds:
3118         * lldb/lldb_webkit.py:
3119         (__lldb_init_module):
3120         (WTFMediaTime_SummaryProvider):
3121         (WTFHashTableProvider.has_children):
3122         (WTFMediaTimeProvider):
3123         (WTFMediaTimeProvider.__init__):
3124         (WTFMediaTimeProvider.timeValue):
3125         (WTFMediaTimeProvider.timeScale):
3126         (WTFMediaTimeProvider.isInvalid):
3127         (WTFMediaTimeProvider.isPositiveInfinity):
3128         (WTFMediaTimeProvider.isNegativeInfinity):
3129         (WTFMediaTimeProvider.isIndefinite):
3130
3131 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3132
3133         Make it possible to select revision numbers on build.webkit.org/dashboard
3134         https://bugs.webkit.org/show_bug.cgi?id=124400
3135
3136         Reviewed by Timothy Hatcher.
3137
3138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3139         (BuildbotQueueView.prototype.revisionLinksForIteration):
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3141         (.selectable):
3142         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
3143         This way, a Dashboard user can highlight revision numbers for easy copying,
3144         and doesn't even have to be precise about the selection.
3145
3146 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3147
3148         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
3149         https://bugs.webkit.org/show_bug.cgi?id=124399
3150
3151         Reviewed by Gustavo Noronha Silva.
3152
3153         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
3154         with the icons adjusted to have solid backgrounds, to not be squished, and to not
3155         intersect the ring, similar to the Mac icons.
3156
3157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
3161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3162         (documentReady.hideButton):
3163         (documentReady):
3164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3165         (table.queue-grid tr.platform.linux-gtk img.logo):
3166         (table.queue-grid tr.platform.linux-efl img.logo):
3167
3168 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
3169
3170         [GStreamer] Add support for Media Source API
3171         https://bugs.webkit.org/show_bug.cgi?id=99065
3172
3173         Reviewed by Philippe Normand.
3174
3175         * Scripts/webkitperl/FeatureList.pm:
3176
3177 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3178
3179         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
3180         https://bugs.webkit.org/show_bug.cgi?id=124360
3181
3182         Reviewed by Philippe Normand.
3183
3184         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
3185
3186 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
3187
3188         [Win] Improve support for command line builds of 64-bit JSC
3189         https://bugs.webkit.org/show_bug.cgi?id=124380
3190
3191         Reviewed by David Kilzer.
3192
3193         * Scripts/webkitdirs.pm:
3194         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
3195         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
3196         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
3197         what the "$configurationForVisualStudio" value is for.
3198
3199 2013-11-14  Oliver Hunt  <oliver@apple.com>
3200
3201         Make CLoop easier to build, and make it work
3202         https://bugs.webkit.org/show_bug.cgi?id=124359
3203
3204         Reviewed by Geoffrey Garen.
3205
3206         Add --cloop support to forcibly enable to CLoop build
3207
3208         * Scripts/build-jsc:
3209         * Scripts/build-webkit:
3210
3211 2013-11-14  Lucas Forschler  <lforschler@apple.com>
3212
3213         Add webkit slave.
3214
3215         Unreviewed.
3216
3217         * BuildSlaveSupport/build.webkit.org-config/config.json:
3218
3219 2013-11-14  Tim Horton  <timothy_horton@apple.com>
3220
3221         build.webkit.org/dashboard can’t open different results in two new tabs
3222         https://bugs.webkit.org/show_bug.cgi?id=124383
3223
3224         Reviewed by Alexey Proskuryakov.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3227         (BuildbotQueueView.prototype.revisionLinksForIteration):
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3229         (StatusLineView.prototype._clicked):
3230         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
3231         real pseudo-target and instead acts as a named target and will end up causing all link clicks
3232         to open in the same secondary tab).
3233
3234 2013-11-14  Anders Carlsson  <andersca@apple.com>
3235
3236         Remove duplicate entry.
3237
3238         * Scripts/webkitpy/common/config/contributors.json:
3239
3240 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
3241
3242         [ATK] Change WKTR/DRT AX methods to use nullptr 
3243         https://bugs.webkit.org/show_bug.cgi?id=124352
3244
3245         Reviewed by Anders Carlsson.
3246
3247         Change WKTR/DRT accessibility related methods to use nullptr.
3248
3249         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3250         (AccessibilityController::AccessibilityController):
3251         (AccessibilityController::elementAtPoint):
3252         (AccessibilityController::removeNotificationListener):
3253         (AccessibilityController::childElementById):
3254         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3255         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3256         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3257         (AccessibilityUIElement::elementAtPoint):
3258         (AccessibilityUIElement::linkedUIElementAtIndex):
3259         (AccessibilityUIElement::getChildAtIndex):
3260         (AccessibilityUIElement::titleUIElement):
3261         (AccessibilityUIElement::parentElement):
3262         (AccessibilityUIElement::subrole):
3263         (AccessibilityUIElement::roleDescription):
3264         (AccessibilityUIElement::orientation):
3265         (AccessibilityUIElement::ariaDropEffects):
3266         (AccessibilityUIElement::uiElementForSearchPredicate):
3267         (AccessibilityUIElement::cellForColumnAndRow):
3268         (AccessibilityUIElement::disclosedRowAtIndex):
3269         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3270         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3271         (AccessibilityUIElement::selectedRowAtIndex):
3272         (AccessibilityUIElement::rowAtIndex):
3273         (AccessibilityUIElement::disclosedByRow):
3274         (AccessibilityUIElement::removeNotificationListener):
3275         (AccessibilityUIElement::classList):
3276         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3277         (WTR::AccessibilityController::logAccessibilityEvents):
3278         (WTR::AccessibilityController::resetToConsistentState):
3279         (WTR::childElementById):
3280         (WTR::AccessibilityController::accessibleElementById):
3281         (WTR::AccessibilityController::removeNotificationListener):
3282         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3283         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3284         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3285         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3286         (WTR::AccessibilityUIElement::elementAtPoint):
3287         (WTR::AccessibilityUIElement::childAtIndex):
3288         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3289         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3290         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3291         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3292         (WTR::AccessibilityUIElement::rowAtIndex):
3293         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3294         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3295         (WTR::AccessibilityUIElement::titleUIElement):
3296         (WTR::AccessibilityUIElement::parentElement):
3297         (WTR::AccessibilityUIElement::disclosedByRow):
3298         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3299         (WTR::AccessibilityUIElement::orientation):
3300         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3301         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3302         (WTR::AccessibilityUIElement::horizontalScrollbar):
3303         (WTR::AccessibilityUIElement::verticalScrollbar):
3304         (WTR::AccessibilityUIElement::removeNotificationListener):
3305         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3306         (WTR::AccessibilityUIElement::previousTextMarker):
3307         (WTR::AccessibilityUIElement::nextTextMarker):
3308         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3309         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3310         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3311         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3312         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3313         (WTR::AccessibilityUIElement::textMarkerForPoint):
3314         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3315         (WTR::AccessibilityUIElement::textMarkerForIndex):
3316         (WTR::AccessibilityUIElement::supportedActions):
3317         (WTR::AccessibilityUIElement::pathDescription):
3318         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3319         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3320         (WTR::AccessibilityUIElement::classList):
3321
3322 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3323
3324         run-perf-tests should warn loudly if you're using a Debug build.
3325         https://bugs.webkit.org/show_bug.cgi?id=105236
3326
3327         Reviewed by Csaba Osztrogonác.
3328
3329         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3330         (PerfTestsRunner.run):
3331
3332 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3333
3334         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
3335         https://bugs.webkit.org/show_bug.cgi?id=124143
3336
3337         Reviewed by Csaba Osztrogonác.
3338
3339         * Scripts/webkitpy/port/factory.py:
3340         (configuration_options):
3341
3342 2013-11-13  Anders Carlsson  <andersca@apple.com>
3343
3344         Add a Vector constructor that takes an std::initializer_list
3345         https://bugs.webkit.org/show_bug.cgi?id=124287
3346
3347         Reviewed by Antti Koivisto.
3348
3349         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3350         (TestWebKitAPI::TEST):
3351
3352 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
3353
3354         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
3355
3356         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3357         (TestRebaselineTest.test_baseline_directory): Updated.
3358
3359 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
3360
3361         [ATK] Support compilation of EFL/GTK without accessibility
3362         https://bugs.webkit.org/show_bug.cgi?id=122448
3363
3364         Reviewed by Chris Fleizach.
3365
3366         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
3367         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
3368
3369         * DumpRenderTree/AccessibilityController.h:
3370         * DumpRenderTree/AccessibilityUIElement.h:
3371         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3372         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3373         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
3374         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3375         (WTR::AccessibilityController::rootElement):
3376         (WTR::AccessibilityController::focusedElement):
3377         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3378         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3379         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3381         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3382         * WebKitTestRunner/PlatformEfl.cmake:
3383
3384 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
3385
3386         [EFL] Added libxss-dev to install-dependencies
3387         https://bugs.webkit.org/show_bug.cgi?id=124254
3388
3389         Reviewed by Gyuyoung Kim.
3390
3391         libxss-dev is required to build EFL packages.
3392         see building part in http://www.enlightenment.org/p.php?p=contribute
3393
3394         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
3395
3396 2013-11-12  Tim Horton  <timothy_horton@apple.com>
3397
3398         After http://trac.webkit.org/changeset/159109, update
3399         rebaseline_unittest to use the new GTK bot names.
3400
3401         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3402         (TestRebaselineTest.test_baseline_directory):
3403
3404 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3405
3406         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
3407         https://bugs.webkit.org/show_bug.cgi?id=124144
3408
3409         Reviewed by Gustavo Noronha Silva.
3410
3411         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
3412         according to http://build.webkit.org/builders.
3413
3414         * Scripts/webkitpy/port/builders.py:
3415
3416 2013-11-11  Samuel White  <samuel_white@apple.com>
3417
3418         AX: support helpText() in DumpRenderTree
3419         https://bugs.webkit.org/show_bug.cgi?id=40194
3420
3421         Reviewed by Chris Fleizach.
3422
3423         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
3424
3425         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3426         (AccessibilityUIElement::helpText):
3427
3428 2013-11-11  Anders Carlsson  <andersca@apple.com>
3429
3430         Remove block based APIs from the WebKit2 C API
3431         https://bugs.webkit.org/show_bug.cgi?id=124157
3432
3433         Reviewed by Sam Weinig.
3434
3435         Update for WK2 changes.
3436
3437         * MiniBrowser/mac/WK2BrowserWindowController.m:
3438         (dumpSource):
3439         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3440
3441 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3442
3443         The feeder queue will not feed patches older than one week.
3444         https://bugs.webkit.org/show_bug.cgi?id=107152
3445
3446         Reviewed by Csaba Osztrogonác.
3447
3448         The feeder queue will not feed patches older than one week.
3449         Unit test added to this scenario.
3450
3451         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3452         (BugzillaQueries._parse_attachment_ids_request_query):
3453           Handle date parameter.
3454         (BugzillaQueries):
3455         (BugzillaQueries._fetch_attachment_ids_request_query):
3456           Propagate date.
3457         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
3458           Propagate date.
3459         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3460         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
3461           Handle date.
3462         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3463         (test_request_page_parsing):
3464           Unit test added.
3465         * Scripts/webkitpy/tool/bot/feeders.py:
3466         (EWSFeeder.feed):
3467           Query patch ids with date parameter (now - 1 week).
3468
3469 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3470
3471         Do not shut down ImageDiff server after every diff during the tests.
3472         https://bugs.webkit.org/show_bug.cgi?id=124140
3473
3474         Reviewed by Csaba Osztrogonác.
3475
3476         There was a FIXME: There is no need to shut down the ImageDiff
3477         server after every diff. Shutdown is removed from that point.
3478
3479         * Scripts/webkitpy/port/image_diff.py:
3480         (ImageDiffer._read):
3481
3482 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
3483
3484         Unreviewed. Added myself as a contributor.
3485
3486         * Scripts/webkitpy/common/config/contributors.json:
3487
3488 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
3489
3490         [GTK] accessibility/aria-link-supports-press.html is failing
3491         https://bugs.webkit.org/show_bug.cgi?id=98355
3492
3493         Reviewed by Mario Sanchez Prada.
3494
3495         Checking "jump" action for link elements. Action "jump" occurs when a link 
3496         element is pressed/clicked.
3497
3498         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3499         (AccessibilityUIElement::isPressActionSupported):
3500         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3501         (WTR::AccessibilityUIElement::isPressActionSupported):
3502
3503 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
3504
3505         [JHBUILD] Jhbuild Makefile build bug workaround
3506         https://bugs.webkit.org/show_bug.cgi?id=123971
3507
3508         Reviewed by Ryosuke Niwa.
3509
3510         After Jhbuild repository is cloned (for instance when you use
3511         Tools/Scripts/update-webkitefl-libs) it is built from sources.
3512         If you have GREP_OPTIONS grep env variable set (for instance
3513         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
3514         uses shell grep. For specific GREP_OPTIONS grep output will be
3515         different than expected one by Jhbuild and there is an error
3516         with Jhbuild build. Jhbuild will not be built and then WebKit
3517         source also will not be built. This patch is a workaround to this
3518         issue. It disables GREP_OPTIONS for Jhbuild build time.
3519
3520         * jhbuild/jhbuild-wrapper:
3521         (install_jhbuild):
3522
3523 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3524
3525         [GTK] Ignore deprecated macros when generating gtk-doc
3526         https://bugs.webkit.org/show_bug.cgi?id=123988
3527
3528         Reviewed by Philippe Normand.
3529
3530         * gtk/generate-gtkdoc:
3531         (get_common_options): Ignore also WEBKIT_DEPRECATED and
3532         WEBKIT_DEPRECATED_FOR decorators.
3533
3534 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3535
3536         [GTK] Pass the library namespace to gtkdoc-mkdb
3537         https://bugs.webkit.org/show_bug.cgi?id=123900
3538
3539         Reviewed by Martin Robinson.
3540
3541         This fixes the generation of the index of symbols in the API
3542         documentation.
3543
3544         * gtk/generate-gtkdoc:
3545         (get_webkit2_options): Define namespace as WebKit.
3546         (get_webkit1_options): Ditto.
3547         (get_webkitdom_options): Define namespace as WebKitDOM.
3548         * gtk/gtkdoc.py:
3549         (GTKDoc.__init__): Add namespace option.
3550         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
3551
3552 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
3553
3554         Modify email order list for James Craig so his primary email is first.
3555
3556         * Scripts/webkitpy/common/config/contributors.json:
3557
3558 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3559
3560         [Gtk] Disable LTO when building cairo
3561         https://bugs.webkit.org/show_bug.cgi?id=123954
3562
3563         Reviewed by Martin Robinson.
3564
3565         Cairo always uses LTO, when it detects compiler support.
3566         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3567         default. This patch disables LTO when building cairo library.
3568         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3569
3570         With gcc 4.7.3, for example, the build fails with the following message:
3571         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3572
3573         * gtk/jhbuild.modules:
3574
3575 2013-11-07  Samuel White  <samuel_white@apple.com>
3576
3577         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
3578         https://bugs.webkit.org/show_bug.cgi?id=123774
3579
3580         Reviewed by Chris Fleizach.
3581
3582         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
3583
3584         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3585         (AccessibilityUIElement::isFocused):
3586         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3587         (WTR::AccessibilityUIElement::isFocused):
3588
3589 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3590
3591         Removed retrieveQMakespecVar function
3592         https://bugs.webkit.org/show_bug.cgi?id=123996
3593
3594         Reviewed by Csaba Osztrogonác.
3595
3596         * Scripts/webkitdirs.pm:
3597
3598 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3599
3600         Removed QMake related filters
3601         https://bugs.webkit.org/show_bug.cgi?id=123992
3602
3603         Reviewed by Csaba Osztrogonác.
3604
3605         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3606         (TestRebaseline.test_rebaseline):
3607         (TestRebaselineExpectations.test_rebaseline_expectations):
3608
3609 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3610
3611         [Efl] Disable LTO when building cairo
3612         https://bugs.webkit.org/show_bug.cgi?id=123947
3613
3614         Reviewed by Gyuyoung Kim.
3615
3616         Cairo always uses LTO, when it detects compiler support.
3617         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3618         default. This patch disables LTO when building cairo library.
3619         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3620
3621         With gcc 4.7.3, for example, the build fails with the following message:
3622         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3623
3624         * efl/jhbuild.modules:
3625
3626 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
3627
3628         AX: [ATK] Video and audio elements are not properly exposed
3629         https://bugs.webkit.org/show_bug.cgi?id=123894
3630
3631         Reviewed by Chris Fleizach.
3632
3633         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.