Unreviewed test gardening for iOS API tests.
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-24  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed test gardening for iOS API tests.
4
5         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
6         (TEST):
7         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
8         (TestWebKitAPI::TEST):
9
10 2020-03-26  Daniel Bates  <dabates@apple.com>
11
12         WebPage::selectPositionAtPoint() does not focus an element in a non-focused frame
13         https://bugs.webkit.org/show_bug.cgi?id=209559
14         <rdar://problem/60887055>
15
16         Reviewed by Wenson Hsieh.
17
18         Add a test.
19
20         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
21         (TEST):
22
23 2020-03-26  Fujii Hironori  <Hironori.Fujii@sony.com>
24
25         WebKitTestRunner should enable ResourceLoadStatistics also for non-Cocoa ports
26         https://bugs.webkit.org/show_bug.cgi?id=209410
27
28         Reviewed by Youenn Fablet.
29
30         Cocoa WebKitTestRunner always enables ResourceLoadStatistics.
31         Other ports should do so.
32
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::TestController::platformAdjustContext): Enable ResourceLoadStatistics
35         by using WKWebsiteDataStoreSetResourceLoadStatisticsEnabled.
36
37 2020-03-26  Kate Cheney  <katherine_cheney@apple.com>
38
39         Guard AppBound domain protections with PLATFORM(iOS_FAMILY)
40         https://bugs.webkit.org/show_bug.cgi?id=209615
41         <rdar://problem/60931014>
42
43         Reviewed by Darin Adler.
44
45         Tests should only be run on iOS.
46
47         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
48
49 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
50
51         [ews] status-bubble for tester queues should point to tester queue while waiting in queue (Follow-up fix)
52         https://bugs.webkit.org/show_bug.cgi?id=209598
53
54         Unreviewed follow-up fix.
55
56         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
57         (StatusBubble._build_bubble): Display the tester name in tester's status-bubble hover-over message.
58
59 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
60
61         [ews] status-bubble for tester queues should point to tester queue while waiting in queue
62         https://bugs.webkit.org/show_bug.cgi?id=209598
63
64         Reviewed by Jonathan Bedard.
65
66         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
67         (StatusBubble._build_bubble):
68
69 2020-03-26  Chris Fleizach  <cfleizach@apple.com>
70
71         AX: WKTR: Don't update isolated tree mode behavior if not required
72         https://bugs.webkit.org/show_bug.cgi?id=209555
73         <rdar://problem/60885094>
74
75         Reviewed by Darin Adler.
76
77         If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
78         This might have the side effect of turning on accessibility unexpectedly.
79
80         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
81         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
82
83 2020-03-26  Philippe Normand  <pnormand@igalia.com>
84
85         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
86         https://bugs.webkit.org/show_bug.cgi?id=209558
87
88         Reviewed by Žan Doberšek.
89
90         When using flatpak some of the arguments we pass to build-webkit
91         are not meant to be used by that script but by webkit-flatpak. However we are
92         not passing all of them to webkit-flatpak but just the configuration ones
93         (port, release/debug...). This means that all the arguments that configure the
94         behaviour of webkit-flatpak are lost.
95
96         * Scripts/webkitdirs.pm:
97         (runInFlatpak): Filter-out Flatpak SDK-specific arguments to a
98         separate array, passed to webkit-flatpak.
99
100 2020-03-26  Commit Queue  <commit-queue@webkit.org>
101
102         Unreviewed, reverting r259035.
103         https://bugs.webkit.org/show_bug.cgi?id=209597
104
105         broke windows layout-tests (Requested by aakashjain on
106         #webkit).
107
108         Reverted changeset:
109
110         "[Win] lld-link: error: /manifestdependency: is not allowed in
111         .drectve"
112         https://bugs.webkit.org/show_bug.cgi?id=204831
113         https://trac.webkit.org/changeset/259035
114
115 2020-03-26  Philippe Normand  <pnormand@igalia.com>
116
117         [Flatpak SDK] update-webkitgtk-libs fails
118         https://bugs.webkit.org/show_bug.cgi?id=209546
119
120         Reviewed by Žan Doberšek.
121
122         Simplify the code a bit, add a `--assumeyes` argument to the
123         `flatpak update` command to make it non-interactive and improve
124         error handling/reporting a bit as well.
125
126         * flatpak/flatpakutils.py:
127         (FlatpakObject.flatpak):
128         (WebkitFlatpak.main):
129         (WebkitFlatpak.run):
130         (WebkitFlatpak.install_all):
131         (WebkitFlatpak.update_all): Deleted.
132
133 2020-03-26  Philippe Normand  <pnormand@igalia.com>
134
135         [Flatpak SDK] Crash post-mortem debugging is broken
136         https://bugs.webkit.org/show_bug.cgi?id=209537
137
138         Reviewed by Žan Doberšek.
139
140         webkit-flatpak --gdb now properly launches gdb to inspect the last
141         crash reported to coredumpctl. The -m argument can be used to
142         select another crash dump.
143
144         * flatpak/flatpakutils.py:
145         (WebkitFlatpak.clean_args):
146         (WebkitFlatpak.run_in_sandbox):
147         (WebkitFlatpak.run_gdb):
148
149 2020-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
150
151         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
152         https://bugs.webkit.org/show_bug.cgi?id=204831
153
154         Reviewed by Ross Kirsling.
155
156         * TestWebKitAPI/win/main.cpp:
157         * win/DLLLauncher/DLLLauncherMain.cpp:
158
159 2020-03-25  Alexey Shvayka  <shvaikalesh@gmail.com>
160
161         Invalid numeric and named references should be early syntax errors
162         https://bugs.webkit.org/show_bug.cgi?id=178175
163
164         Reviewed by Ross Kirsling.
165
166         Removes FIXME as YarrParser is correct not to throw errors as it is
167         parsing in non-Unicode mode. Also adds a few named groups tests.
168
169         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
170
171 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
172
173         [Timeline] A better default get label function, which fit the assumpation the label is always a string
174         https://bugs.webkit.org/show_bug.cgi?id=209567
175
176         Reviewed by Jonathan Bedard.
177
178         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
179
180 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
181
182         [Timeline] Fix the out of bound dot index
183         https://bugs.webkit.org/show_bug.cgi?id=209492
184
185         Reviewed by Jonathan Bedard.
186
187         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
188         (Timeline.CanvasSeriesComponent):
189
190 2020-03-25  Daniel Bates  <dabates@apple.com>
191
192         Element context character rects may be in wrong coordinate system
193         https://bugs.webkit.org/show_bug.cgi?id=209493
194         <rdar://problem/60840261>
195
196         Reviewed by Wenson Hsieh.
197
198         Add some tests.
199
200         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
201         (TEST):
202
203 2020-03-25  Doug Kelly  <dougk@apple.com>
204
205         Unreviewed, add new committer to contributors.json
206
207         * Scripts/webkitpy/common/config/contributors.json:
208
209 2020-03-25  Frank Yang  <guowei_yang@apple.com>
210
211         Unprefix -webkit-text-orientation
212         https://bugs.webkit.org/show_bug.cgi?id=196139
213
214         Reviewed by Myles C. Maxfield.
215
216         This change is made to add the extra flag "related-property" in CSSProperty.json
217         in the jsonchecker so that the jsonchecker would not complain about unrecognized key
218
219         * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property
220         (JSONCSSPropertiesChecker.check_codegen_properties): 
221
222 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
223
224         [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
225         https://bugs.webkit.org/show_bug.cgi?id=209550
226
227         Reviewed by Jonathan Bedard.
228
229         * BuildSlaveSupport/ews-build/steps.py:
230         (FindModifiedChangeLogs): Set haltOnFailure to false.
231         (FindModifiedChangeLogs.getResultSummary):
232         (FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
233         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
234
235 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
236
237         [ews] status-bubble should link to buildbot queue while waiting in queue
238         https://bugs.webkit.org/show_bug.cgi?id=209543
239
240         Reviewed by Jonathan Bedard.
241
242         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
243         (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
244         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
245         (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
246
247 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
248
249         [GTK] Add user agent quirk for auth.mayohr.com
250         https://bugs.webkit.org/show_bug.cgi?id=209378
251
252         Reviewed by Michael Catanzaro.
253
254         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
255         (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
256         (TestWebKitAPI::TEST):
257
258 2020-03-24  Daniel Bates  <dabates@apple.com>
259
260         Unreviewed, reverting r258945.
261
262         Revert change that broke API tests while I investigate
263         offline.
264
265         Reverted changeset:
266
267         "Element context character rects may be in wrong coordinate
268         system"
269         https://bugs.webkit.org/show_bug.cgi?id=209493
270         https://trac.webkit.org/changeset/258945
271
272 2020-03-24  Jiewen Tan  <jiewen_tan@apple.com>
273
274         Unreviewed, skips a test for iOS
275
276         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
277
278 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
279
280         results.webkit.org: Documentation for uncollapsed failure endpoints is wrong
281         https://bugs.webkit.org/show_bug.cgi?id=209496
282
283         Rubber-stamped by Aakash Jain.
284
285         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
286
287 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
288
289         results.webkit.org: Filter suite results by expectation by default
290         https://bugs.webkit.org/show_bug.cgi?id=209500
291
292         Rubber-stamped by Aakash Jain.
293
294         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Allow the Legend constructor
295         to set a willFilterExpected default.
296         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
297
298 2020-03-24  Per Arne Vollan  <pvollan@apple.com>
299
300         [Cocoa] Fix launch time regression with CF prefs direct mode enabled
301         https://bugs.webkit.org/show_bug.cgi?id=209244
302
303         Reviewed by Darin Adler.
304
305         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
306         (TEST):
307         (sharedInstanceMethodOverride):
308
309 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
310
311         results.webkit.org: Correct UUID capitalization in documentation
312         https://bugs.webkit.org/show_bug.cgi?id=209497
313
314         Reviewed by Aakash Jain.
315
316         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
317
318 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
319
320         [ews] commit-queue should comment on bug if it fails to create git commit
321         https://bugs.webkit.org/show_bug.cgi?id=209487
322
323         Reviewed by Jonathan Bedard.
324
325         * BuildSlaveSupport/ews-build/steps.py:
326         (CreateLocalGITCommit):
327         (CreateLocalGITCommit.start):
328         (CreateLocalGITCommit.evaluateCommand):
329         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
330
331 2020-03-24  Daniel Bates  <dabates@apple.com>
332
333         Element context character rects may be in wrong coordinate system
334         https://bugs.webkit.org/show_bug.cgi?id=209493
335         <rdar://problem/60840261>
336
337         Reviewed by Wenson Hsieh.
338
339         Add some tests.
340
341         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
342         (TEST):
343
344 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
345
346         [ews] position in queue shown in status-bubble is larger than actual position
347         https://bugs.webkit.org/show_bug.cgi?id=209481
348
349         Reviewed by Jonathan Bedard.
350
351         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
352         (StatusBubble._queue_position): Use created timestamp instead of modified.
353
354 2020-03-24  Daniel Bates  <dabates@apple.com>
355
356         [iOS][WK2] Set text trait isSingleLineDocument
357         https://bugs.webkit.org/show_bug.cgi?id=209391
358         <rdar://problem/60705870>
359
360         Reviewed by Darin Adler.
361
362         Add a test.
363
364         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/ios/UIKitSPI.h: Expose more SPI.
367
368 2020-03-24  Alex Christensen  <achristensen@webkit.org>
369
370         Unreviewed, reverting r258862.
371
372         SPI was not what was needed
373
374         Reverted changeset:
375
376         "Add SPI to move localStorage to a different domain"
377         https://bugs.webkit.org/show_bug.cgi?id=209260
378         https://trac.webkit.org/changeset/258862
379
380 2020-03-24  Chris Lord  <clord@igalia.com>
381
382         [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
383         https://bugs.webkit.org/show_bug.cgi?id=209478
384
385         Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.
386
387         Reviewed by Philippe Normand.
388
389         * flatpak/flatpakutils.py:
390         (WebkitFlatpak.run_in_sandbox):
391
392 2020-03-23  Simon Fraser  <simon.fraser@apple.com>
393
394         [mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
395         https://bugs.webkit.org/show_bug.cgi?id=209427
396
397         Reviewed by Wenson Hsieh.
398         
399         0 => NULL
400
401         * DumpRenderTree/mac/DumpRenderTree.mm:
402         (invalidateAnyPreviousWaitToDumpWatchdog):
403
404 2020-03-23  Dean Jackson  <dino@apple.com>
405
406         webkitpy Git class must expose the repository URL
407         https://bugs.webkit.org/show_bug.cgi?id=209439
408         <rdar://problem/60792668>
409
410         Reviewed by Simon Fraser.
411
412         Some internal tools were relying on the svn_url() method
413         that was changed/removed in r258164. Add a replacement.
414
415         * Scripts/webkitpy/common/checkout/scm/git.py:
416         (Git.svn_repository_url):
417
418 2020-03-23  Alex Christensen  <achristensen@webkit.org>
419
420         Fix memory leak introduced in r257726
421         https://bugs.webkit.org/show_bug.cgi?id=208399
422
423         Reviewed by John Wilander.
424
425         * WebKitTestRunner/TestController.cpp:
426         (WTR::TestController::websiteDataStore):
427         We were leaking page configurations.
428
429 2020-03-23  John Wilander  <wilander@apple.com>
430
431         Add the capability to change all of a website's cookies to SameSite=Strict
432         https://bugs.webkit.org/show_bug.cgi?id=209369
433         <rdar://problem/60710690>
434
435         Reviewed by Alex Christensen and David Kilzer.
436
437         These changes add TestRunner function statisticsSetToSameSiteStrictCookies().
438
439         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
440         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
441         (WTR::InjectedBundle::didReceiveMessageToPage):
442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
443         (WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
444         (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):
445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
446         * WebKitTestRunner/TestController.cpp:
447         (WTR::TestController::setStatisticsToSameSiteStrictCookies):
448         * WebKitTestRunner/TestController.h:
449         * WebKitTestRunner/TestInvocation.cpp:
450         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
451         (WTR::TestInvocation::didSetToSameSiteStrictCookies):
452         * WebKitTestRunner/TestInvocation.h:
453
454 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
455
456         Uneviewed, added myself to contributors.json.
457
458         * Scripts/webkitpy/common/config/contributors.json:
459
460 2020-03-23  Daniel Bates  <dabates@apple.com>
461
462         Support inserting text or dictation alternative by simulating keyboard input
463         https://bugs.webkit.org/show_bug.cgi?id=209380
464         <rdar://problem/59445102>
465
466         Reviewed by Darin Adler.
467
468         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
469         is enabled.
470
471         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
472         compare NSObjects so long as they implement -isEqual and -description. I
473         make use of this to compare the actual array of fired DOM events types to
474         an expected array.
475
476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
477         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
478         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/cocoa/TestCocoa.h:
481         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
482         (EXPECT_NS_EQUAL): Added.
483         * TestWebKitAPI/ios/insert-text.html: Added.
484
485 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
486
487         Add checks for app-bound navigations when evaluating user style sheets
488         https://bugs.webkit.org/show_bug.cgi?id=209368
489         <rdar://problem/60204230>
490
491         Reviewed by Brent Fulgham.
492
493         Tested cases based on those in UserContentController.mm.
494
495         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
496         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
497         (expectScriptEvaluatesToColor):
498         (TEST):
499
500
501 2020-03-23  Alex Christensen  <achristensen@webkit.org>
502
503         Add SPI to move localStorage to a different domain
504         https://bugs.webkit.org/show_bug.cgi?id=209260
505         <rdar://problem/60285683>
506
507         Reviewed by Brady Eidson.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
510         (TEST):
511
512 2020-03-23  youenn fablet  <youenn@apple.com>
513
514         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
515         https://bugs.webkit.org/show_bug.cgi?id=209428
516
517         Reviewed by Jonathan Bedard.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
520
521 2020-03-23  Chris Lord  <clord@igalia.com>
522
523         Add missing committer status to Chris Lord in contributors.json
524
525         Unreviewed
526
527         * Scripts/webkitpy/common/config/contributors.json:
528
529 2020-03-23  youenn fablet  <youenn@apple.com>
530
531         StringView::startsWith and String::startsWith do not treat null strings the same
532         https://bugs.webkit.org/show_bug.cgi?id=209273
533
534         Reviewed by Darin Adler.
535
536         * TestWebKitAPI/Tests/WTF/StringView.cpp:
537         (TestWebKitAPI::TEST):
538         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
539         (TestWebKitAPI::TEST):
540
541 2020-03-22  Antoine Quint  <graouts@apple.com>
542
543         DocumentTimeline / CSSTransition objects are leaking on CNN.com
544         https://bugs.webkit.org/show_bug.cgi?id=208069
545         <rdar://problem/59680143>
546
547         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
548
549         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
550
551         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
552         (TestWebKitAPI::ListHashSetReferencedItem::create):
553         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
554         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
555         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
556         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
557         (TestWebKitAPI::FakeElementAnimationRareData::collection):
558         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
559         (TestWebKitAPI::TEST):
560
561 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
562
563         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
564         https://bugs.webkit.org/show_bug.cgi?id=208970
565
566         Reviewed by Konstantin Tokarev.
567
568         We are allowed to use /usr/bin/env in this script because it's not installed (so not
569         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
570         case.
571
572         * gtkdoc/generate-gtkdoc:
573
574 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
575
576         run-webkit-tests: Report MacCatalyst as a unique platform
577         https://bugs.webkit.org/show_bug.cgi?id=209361
578
579         Rubber-stamped by Aakash Jain.
580
581         * Scripts/webkitpy/port/mac.py:
582         (MacCatalystPort):
583         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
584
585 2020-03-20  Alex Christensen  <achristensen@webkit.org>
586
587         CORS-disabling SPI introduced in r253978 should make responses non-opaque
588         https://bugs.webkit.org/show_bug.cgi?id=209351
589         <rdar://problem/60024850>
590
591         Reviewed by Chris Dumez.
592
593         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
594
595 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
596
597         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
598         https://bugs.webkit.org/show_bug.cgi?id=208938
599
600         Reviewed by Jonathan Bedard.
601
602         * BuildSlaveSupport/ews-build/steps.py:
603         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
604         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
605         (CheckPatchStatusOnEWSQueues.get_patch_status):
606         (CheckPatchStatusOnEWSQueues.start):
607         * BuildSlaveSupport/ews-build/steps_unittest.py:
608         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
609         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
610         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
611         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
612
613 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
614
615         [ews] Better organize patch status api data
616         https://bugs.webkit.org/show_bug.cgi?id=209342
617
618         Reviewed by Jonathan Bedard.
619
620         * BuildSlaveSupport/ews-app/ews/views/status.py:
621         (Status._build_status):
622         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
623         (Status.get): Remove safe=false now that we are returning a dictionary.
624
625 2020-03-20  Tim Horton  <timothy_horton@apple.com>
626
627         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
628         https://bugs.webkit.org/show_bug.cgi?id=209307
629
630         Reviewed by Andy Estes.
631
632         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
633
634 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
635
636         Unreviewed, reverting r258748.
637
638         This commit broke the Catalina build
639
640         Reverted changeset:
641
642         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
643         https://bugs.webkit.org/show_bug.cgi?id=209307
644         https://trac.webkit.org/changeset/258748
645
646 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
647
648         [ews] commit-queue should comment on bug if patch fails to apply
649         https://bugs.webkit.org/show_bug.cgi?id=209334
650
651         Reviewed by Jonathan Bedard.
652
653         * BuildSlaveSupport/ews-build/steps.py:
654         (ApplyPatch):
655         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
656         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
657         (TestApplyPatch):
658         (TestApplyPatch.setUp):
659         (TestApplyPatch.setUp.mock_start):
660         (TestApplyPatch.tearDown):
661         (TestApplyPatch.test_success):
662         (TestApplyPatch.test_failure):
663         (TestApplyPatch.test_failure_on_commit_queue):
664
665 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
666
667         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
668         https://bugs.webkit.org/show_bug.cgi?id=209122
669
670         Reviewed by Jonathan Bedard.
671
672         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
673         (StatusBubble._build_bubble):
674
675 2020-03-19  Tim Horton  <timothy_horton@apple.com>
676
677         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
678         https://bugs.webkit.org/show_bug.cgi?id=209307
679
680         Reviewed by Andy Estes.
681
682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
683
684 2020-03-19  Alex Christensen  <achristensen@webkit.org>
685
686         Remove test failing after r258734
687         https://bugs.webkit.org/show_bug.cgi?id=209303
688
689         We removed the functionality it was testing because it did nothing useful except call the callback.
690         I'm about to remove the only user of WKContextGetStatistics.
691
692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
693         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
694
695 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
696
697         commit-queue status-bubble shows incorrect position in queue
698         https://bugs.webkit.org/show_bug.cgi?id=209313
699
700         Reviewed by Jonathan Bedard.
701
702         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
703         (StatusBubble._queue_position):
704
705 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
706
707         [Curl] Add an API returns description of verification errors.
708         https://bugs.webkit.org/show_bug.cgi?id=208913
709
710         Reviewed by Fujii Hironori.
711
712         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
713         Browser can display more precise error information with this API.
714
715         API Test: Curl.CertificateAPI
716
717         * MiniBrowser/win/Common.cpp:
718         (askServerTrustEvaluation):
719         * MiniBrowser/win/Common.h:
720         * MiniBrowser/win/WebKitBrowserWindow.cpp:
721         (createPEMString):
722         (WebKitBrowserWindow::canTrustServerCertificate):
723         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
724         (TestWebKitAPI::Curl::TEST):
725
726 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
727
728         Update build.webkit.org link for EWS
729         https://bugs.webkit.org/show_bug.cgi?id=209280
730
731         Reviewed by Alexey Proskuryakov.
732
733         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
734
735 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
736
737         [WinCairo] extract-built-product fails after r258612
738         https://bugs.webkit.org/show_bug.cgi?id=209285
739
740         extractBuiltProduct also references the old name for the
741         requirements on wincairo.
742
743         Reviewed by Ross Kirsling.
744
745         * BuildSlaveSupport/built-product-archive:
746
747 2020-03-19  Philippe Normand  <pnormand@igalia.com>
748
749         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
750         https://bugs.webkit.org/show_bug.cgi?id=209223
751
752         Reviewed by Carlos Alberto Lopez Perez.
753
754         flatpak build doesn't expose a --socket option for white-listing
755         the systemd journal socket. So white-list everything in /run. 🤷
756
757         * flatpak/flatpakutils.py:
758         (WebkitFlatpak.run_in_sandbox):
759
760 2020-03-19  Charlie Turner  <cturner@igalia.com>
761
762         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
763         https://bugs.webkit.org/show_bug.cgi?id=209146
764
765         Reviewed by Darin Adler.
766
767         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
768         (TestWebKitAPI::TEST):
769         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
770         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
771         (testDownloadMIMEType):
772         (testContextMenuDownloadActions):
773         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
774
775 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
776
777         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
778         https://bugs.webkit.org/show_bug.cgi?id=209278
779
780         Reviewed by Philippe Normand.
781
782         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
783         means flatpak.
784
785         * Scripts/webkitdirs.pm:
786         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
787
788 2020-03-19  Philippe Normand  <pnormand@igalia.com>
789
790         [CMake] cache not cleared when build-webkit options change
791         https://bugs.webkit.org/show_bug.cgi?id=209277
792
793         Reviewed by Adrian Perez de Castro.
794
795         * Scripts/webkitdirs.pm:
796         (shouldRemoveCMakeCache): The expected function signature never
797         included the cache file path. Remove it.
798
799 2020-03-18  Philippe Normand  <pnormand@igalia.com>
800
801         REGRESSION(r258626): webkit-dirs warning
802         https://bugs.webkit.org/show_bug.cgi?id=209221
803
804         Reviewed by Adrian Perez de Castro.
805
806         * Scripts/webkitdirs.pm:
807         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
808
809 2020-03-19  Chris Lord  <clord@igalia.com>
810
811         Add Chris Lord (clord@igalia.com) to the list of contributors
812         https://bugs.webkit.org/show_bug.cgi?id=209274
813
814         Unreviewed
815
816         * Scripts/webkitpy/common/config/contributors.json:
817
818 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
819
820         Remove commit queue bubble from bot watchers dashboard
821         https://bugs.webkit.org/show_bug.cgi?id=209271
822
823         Reviewed by Alexey Proskuryakov.
824
825         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
826
827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
828         (BubbleQueueServer): 
829
830 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
831
832         eventSender.monitorWheelEvents() is very fragile
833         https://bugs.webkit.org/show_bug.cgi?id=197819
834         <rdar://problem/51319456>
835
836         Reviewed by Tim Horton.
837
838         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
839         adding back changes from r257844 that were reverted in r258558.
840         
841         First, have EventSendingController keep track of whether it's seen then "end" event
842         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
843         now waits until it sees these, which prevents premature triggering which was a common cause of
844         failure before.
845         
846         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
847         for completion in a callout from the end of Page::updateRendering(), which makes it test
848         and fire at a more consistent time.
849         
850         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
851         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
852         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
853         also resulting in a premature trigger.
854
855         * DumpRenderTree/mac/EventSendingController.h:
856         * DumpRenderTree/mac/EventSendingController.mm:
857         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
858         (-[EventSendingController monitorWheelEvents]):
859         (-[EventSendingController callAfterScrollingCompletes:]):
860         * DumpRenderTree/win/EventSender.cpp:
861         (mouseScrollBy):
862         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
863         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
864         (WTR::EventSendingController::monitorWheelEvents):
865         (WTR::EventSendingController::callAfterScrollingCompletes):
866         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
867
868 2020-03-18  John Wilander  <wilander@apple.com>
869
870         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
871         https://bugs.webkit.org/show_bug.cgi?id=209245
872         <rdar://problem/60511121>
873
874         Reviewed by Chris Dumez.
875
876         These changes to the TestRunner makes sure that
877         - statisticsClearInMemoryAndPersistentStore()
878         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
879         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
880         and adds the infrastructure for that.
881
882         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
883         (WTR::InjectedBundle::didReceiveMessageToPage):
884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
885         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
886         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
887         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
888         * WebKitTestRunner/InjectedBundle/TestRunner.h:
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
891         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
892         * WebKitTestRunner/TestInvocation.cpp:
893         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
894         * WebKitTestRunner/TestInvocation.h:
895
896 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
897
898         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
899         https://bugs.webkit.org/show_bug.cgi?id=209218
900         <rdar://problem/60560831>
901
902         Reviewed by Tim Horton.
903
904         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
905         those views must be parented (i.e. they must be connected to a UIWindow).
906
907         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
908         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
909         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
910         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
911
912 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
913
914         [ews] commit-queue should comment on bug in case of test failures
915         https://bugs.webkit.org/show_bug.cgi?id=209226
916
917         Reviewed by Jonathan Bedard.
918
919         * BuildSlaveSupport/ews-build/steps.py:
920         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
921         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
922         (SetBuildSummary): Ditto.
923         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
924
925 2020-03-18  Philippe Normand  <pnormand@igalia.com>
926
927         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
928         https://bugs.webkit.org/show_bug.cgi?id=209238
929
930         Reviewed by Jonathan Bedard.
931
932         * Scripts/test262-runner: Perform the flatpak check on Linux only.
933
934 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
935
936         [WinCairo] archive-built-product fails after r258612
937         https://bugs.webkit.org/show_bug.cgi?id=209237
938
939         Reviewed by Alex Christensen.
940
941         * BuildSlaveSupport/built-product-archive:
942         Update name of version file for requirements version
943         file for wincairo.
944
945 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
946
947         commit-queue should allow patches which are reviewed by patch author
948         https://bugs.webkit.org/show_bug.cgi?id=209231
949
950         Reviewed by Jonathan Bedard.
951
952         * BuildSlaveSupport/ews-build/steps.py:
953         (BugzillaMixin._does_patch_have_acceptable_review_flag):
954
955 2020-03-18  Philippe Normand  <pnormand@igalia.com>
956
957         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
958         https://bugs.webkit.org/show_bug.cgi?id=209222
959
960         Reviewed by Carlos Alberto Lopez Perez.
961
962         * Scripts/webkitdirs.pm:
963         (runInFlatpakIfAvailable): If a command wrapper is required it
964         means Flatpak shouldn't be used.
965
966 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
967
968         [ews] commit-queue should comment on bug in case patch fails to build
969         https://bugs.webkit.org/show_bug.cgi?id=209227
970
971         Reviewed by Jonathan Bedard.
972
973         * BuildSlaveSupport/ews-build/steps.py:
974         (AnalyzeCompileWebKitResults.start):
975         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
976
977 2020-03-18  Philippe Normand  <pnormand@igalia.com>
978
979         [GTK][WPE] Migrate to Flatpak-based dev SDK
980         https://bugs.webkit.org/show_bug.cgi?id=205658
981
982         Reviewed by Carlos Alberto Lopez Perez.
983
984         JHBuild will now be used only if the WEBKIT_JHBUILD environment
985         variable is set to 1, which is the case for the time being on the
986         GTK and WPE EWS/build bots.
987
988         By default the build dependencies are now locally installed from a
989         Flatpak repository hosted at https://software.igalia.com. The
990         repository can be regenerated with the scripts from the
991         webkit-flatpak-sdk Github project
992         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
993         transparently with the update-webkit{gtk,wpe}-libs scripts. As
994         there is no need to rebuild the dependencies from scratch, the
995         developer user-experience should now be much more friendly and
996         overall build times reduced.
997
998         As an additional commodity, the new environment supports the
999         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
1000         environment variable to your gst-build path. This feature was
1001         contributed by Thibault Saunier.
1002
1003         The JHBuild infrastructure will be removed once all the bots have
1004         been switched over to Flatpak.
1005
1006         * BuildSlaveSupport/ews-build/steps.py:
1007         (InstallGtkDependencies):
1008         (InstallWpeDependencies):
1009         (CompileWebKit.start):
1010         * BuildSlaveSupport/gtk/buildbot/run:
1011         * Scripts/build-webkit:
1012         * Scripts/run-bindings-tests:
1013         * Scripts/run-builtins-generator-tests:
1014         * Scripts/run-gtk-tests:
1015         * Scripts/run-javascriptcore-tests:
1016         * Scripts/run-minibrowser:
1017         * Scripts/run-qt-wpe-minibrowser:
1018         * Scripts/run-webdriver-tests:
1019         * Scripts/run-wpe-tests:
1020         * Scripts/test-webkitperl:
1021         * Scripts/test-webkitpy:
1022         * Scripts/test262-runner:
1023         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
1024         * Scripts/update-webkitgtk-libs:
1025         * Scripts/update-webkitwpe-flatpak: Removed.
1026         * Scripts/update-webkitwpe-libs:
1027         * Scripts/webkitdirs.pm:
1028         (getUserFlatpakPath):
1029         (inFlatpakSandbox):
1030         (runInFlatpakIfAvailable):
1031         (wrapperPrefixIfNeeded):
1032         (shouldUseJhbuild):
1033         (shouldUseFlatpak):
1034         (shouldRemoveCMakeCache):
1035         * Scripts/webkitpy/common/system/executive.py:
1036         (Executive.kill_all):
1037         * Scripts/webkitpy/port/base.py:
1038         (Port._path_to_apache):
1039         (Port._should_run_as_pixel_test):
1040         (Port._in_flatpak_sandbox):
1041         * Scripts/webkitpy/port/gtk.py:
1042         (GtkPort.setup_environ_for_server):
1043         (GtkPort._get_crash_log):
1044         * Scripts/webkitpy/port/linux_get_crash_log.py:
1045         (GDBCrashLogGenerator):
1046         (GDBCrashLogGenerator.__init__):
1047         (GDBCrashLogGenerator.generate_crash_log):
1048         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1049         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1050         * Scripts/webkitpy/port/wpe.py:
1051         (WPEPort.setup_environ_for_server):
1052         (WPEPort._get_crash_log):
1053         * Scripts/webkitpy/port/xvfbdriver.py:
1054         (XvfbDriver._setup_environ_for_test):
1055         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1056         (WTR::getFontsPath):
1057         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1058         (WTR::getFontsPath):
1059         * flatpak/files/default.xkm: Removed.
1060         * flatpak/files/httpd-autogen.sh: Removed.
1061         * flatpak/flatpakutils.py:
1062         (check_flatpak):
1063         (FlatpakRepos.update):
1064         (FlatpakPackage.__repr__):
1065         (FlatpakPackage.__str__):
1066         (WebkitFlatpak.load_from_args):
1067         (WebkitFlatpak.__init__):
1068         (WebkitFlatpak.clean_args):
1069         (WebkitFlatpak.setup_builddir):
1070         (WebkitFlatpak):
1071         (WebkitFlatpak.setup_gstbuild):
1072         (WebkitFlatpak.run_in_sandbox):
1073         (WebkitFlatpak.run):
1074         (WebkitFlatpak.has_environment):
1075         (WebkitFlatpak.save_config):
1076         (WebkitFlatpak.setup_dev_env):
1077         (WebkitFlatpak.install_all):
1078         (WebkitFlatpak.run_gdb):
1079         * flatpak/org.webkit.CommonModules.yaml: Removed.
1080         * flatpak/org.webkit.GTK.yaml: Removed.
1081         * flatpak/org.webkit.WPE.yaml: Removed.
1082         * flatpak/org.webkit.WPEModules.yaml: Removed.
1083         * flatpak/org.webkit.WPEQT.yaml: Removed.
1084         * flatpak/org.webkit.WebKit.yaml: Removed.
1085         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
1086         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
1087         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
1088
1089 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
1090
1091         Expand In-App-Browser-Privacy testing
1092         https://bugs.webkit.org/show_bug.cgi?id=209142
1093         <rdar://problem/60496618>
1094
1095         Reviewed by Darin Adler.
1096
1097         Expanded test coverage by adding new tests and creating a custom url
1098         scheme handler to get around the fact that local file loads are
1099         always classified as app-bound.
1100
1101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1102         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1103         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
1104         If the path indicates testing user scripts on load, notify the script message
1105         handler that the navigation has finished. If the path indicates
1106         testing user-agent scripts, set the window.wkUserScriptInjected
1107         variable to true. A user agent script will attempt to read this
1108         variable and should fail.
1109
1110         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
1111         (initializeInAppBrowserPrivacyTestSettings):
1112         Basic test setup. Initialize the main run loop and make sure we are
1113         starting with a clean state.
1114
1115         (TEST):
1116         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
1117         except for blob files which must be generated within the web content.
1118
1119         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
1120         Basic html document to test local file loads are classified as
1121         app-bound.
1122
1123         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
1124         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
1125         These files are no longer needed as their content is directly copied
1126         into the URL scheme handler.
1127
1128 2020-03-17  Chris Dumez  <cdumez@apple.com>
1129
1130         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
1131         https://bugs.webkit.org/show_bug.cgi?id=207307
1132         <rdar://problem/59206964>
1133
1134         Reviewed by Alex Christensen.
1135
1136         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
1137         notifications from the map but not tell WebCore that the notification were discarded. As a result,
1138         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
1139         notification would no longer be in the map, causing us to hit an assertion in debug.
1140
1141         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
1142         to let WebCore know the notification was discarded. This is similar to what is already done for
1143         WebKit2 in WebNotificationManager::clearNotifications().
1144
1145         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1146         (-[MockWebNotificationProvider reset]):
1147
1148 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
1149
1150         [WinCairo][FTW] Update path to requirements download
1151         https://bugs.webkit.org/show_bug.cgi?id=209202
1152
1153         Reviewed by Ross Kirsling.
1154
1155         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
1156         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
1157         WebKitRequirementsWin64.zip.
1158
1159         * Scripts/update-webkit-wincairo-libs.py:
1160
1161 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1162
1163         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
1164         https://bugs.webkit.org/show_bug.cgi?id=208920
1165
1166         Reviewed by Jonathan Bedard.
1167
1168         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1169         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
1170         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
1171         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
1172         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1173         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
1174         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1175         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
1176         for commit-queue which isn't expected to change.
1177         (BugzillaPatchFetcher.fetch_commit_queue_patches):
1178         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
1179         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
1180         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
1181         setting cq+ flag on bugzilla.
1182
1183 2020-03-17  Chris Dumez  <cdumez@apple.com>
1184
1185         [WKTR] testRunner API that takes in a completion handler should use async IPC
1186         https://bugs.webkit.org/show_bug.cgi?id=209187
1187
1188         Reviewed by John Wilander.
1189
1190         testRunner API that takes in a completion handler should use async IPC. This hangs
1191         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
1192         to IPC the WebProcess as a result of this testRunner call.
1193
1194         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1195         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1196         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1197         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1198         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1199         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1200         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
1201         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
1202         (WTR::TestRunner::statisticsResetToConsistentState):
1203         (WTR::TestRunner::getAllStorageAccessEntries):
1204         (WTR::TestRunner::removeAllSessionCredentials):
1205         (WTR::TestRunner::getApplicationManifestThen):
1206         * WebKitTestRunner/TestInvocation.cpp:
1207         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1208         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1209
1210 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-app] Timestamp shown in status-bubble hover-over message is in future
1213         https://bugs.webkit.org/show_bug.cgi?id=196628
1214
1215         Reviewed by Jonathan Bedard.
1216
1217         * BuildSlaveSupport/ews-build/events.py:
1218         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
1219         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1220         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
1221         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
1222
1223 2020-03-17  Alex Christensen  <achristensen@webkit.org>
1224
1225         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
1226         https://bugs.webkit.org/show_bug.cgi?id=209192
1227         <rdar://problem/51313336>
1228
1229         Reviewed by Geoff Garen.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1232         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
1233         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
1234         (TEST):
1235
1236 2020-03-17  Chris Dumez  <cdumez@apple.com>
1237
1238         Use less sync IPC for ITP testRunner methods
1239         https://bugs.webkit.org/show_bug.cgi?id=209184
1240
1241         Reviewed by Alex Christensen.
1242
1243         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1244         (WTR::TestRunner::setStatisticsDebugMode):
1245         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1246         (WTR::TestRunner::setStatisticsLastSeen):
1247         (WTR::TestRunner::setStatisticsMergeStatistic):
1248         (WTR::TestRunner::setStatisticsPrevalentResource):
1249         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1250         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1251         * WebKitTestRunner/TestInvocation.cpp:
1252         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1253         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1254
1255 2020-03-17  Chris Dumez  <cdumez@apple.com>
1256
1257         [WKTR] Crash when trying to open a new window in an ephemeral session test
1258         https://bugs.webkit.org/show_bug.cgi?id=209181
1259
1260         Reviewed by Geoffrey Garen.
1261
1262         Make sure that the new WKWebView is using the same data store as its related WKWebView.
1263
1264         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1265         (WTR::TestController::platformCreateOtherPage):
1266
1267 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
1268
1269         Unreviewed, reverting r257844.
1270
1271         this revision caused a test to start timing out
1272
1273         Reverted changeset:
1274
1275         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
1276         zero.html is a flaky failure"
1277         https://bugs.webkit.org/show_bug.cgi?id=207948
1278         https://trac.webkit.org/changeset/257844
1279
1280 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
1281
1282         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
1283         https://bugs.webkit.org/show_bug.cgi?id=209151
1284
1285         Reviewed by Yusuke Suzuki.
1286
1287         * Scripts/webkitpy/common/config/contributors.json:
1288
1289 2020-03-16  Chris Dumez  <cdumez@apple.com>
1290
1291         Crash under WebCookieCache::clearForHost()
1292         https://bugs.webkit.org/show_bug.cgi?id=209149
1293         <rdar://problem/60453086>
1294
1295         Reviewed by Alex Christensen.
1296
1297         Add API test coverage.
1298
1299         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
1300         (TEST):
1301
1302 2020-03-16  Keith Rollin  <krollin@apple.com>
1303
1304         Remove support for WebKitSystemInterface
1305         https://bugs.webkit.org/show_bug.cgi?id=208894
1306         <rdar://problem/60297590>
1307
1308         Reviewed by Brent Fulgham.
1309
1310         This project provided support for facilities that are now handled
1311         elsewhere and is no longer needed.
1312
1313         * Scripts/copy-webkitlibraries-to-product-directory:
1314
1315 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1316
1317         [macOS] Accessibility sandbox regressions
1318         https://bugs.webkit.org/show_bug.cgi?id=209065
1319
1320         Reviewed by Brent Fulgham.
1321
1322         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
1323         (TEST):
1324         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
1325         (TEST):
1326
1327 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
1328
1329         Unreviewed infrastructure fix.
1330
1331         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
1332         while the hardware is out for repair.
1333
1334 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
1335
1336         [WebXR] IDLs, stubs and build configuration for WPE
1337         https://bugs.webkit.org/show_bug.cgi?id=208702
1338
1339         Reviewed by Dean Jackson.
1340
1341         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
1342         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
1343
1344 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1345
1346         [Cocoa] Limit set of classes that can be decoded when a preference has changed
1347         https://bugs.webkit.org/show_bug.cgi?id=208012
1348
1349         Reviewed by Brent Fulgham.
1350
1351         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1352         (TEST):
1353
1354 2020-03-16  youenn fablet  <youenn@apple.com>
1355
1356         Unique origins should not be Potentially Trustworthy
1357         https://bugs.webkit.org/show_bug.cgi?id=209049
1358
1359         Reviewed by Darin Adler.
1360
1361         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1362         (TestWebKitAPI::TEST_F):
1363
1364 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1365
1366         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
1367         https://bugs.webkit.org/show_bug.cgi?id=207324
1368
1369         Reviewed by Darin Adler.
1370
1371         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
1372         (TestWebKitAPI::generateRandomData): Added.
1373         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
1374
1375 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
1376
1377         Should not use variable-length-array (VLA)
1378         https://bugs.webkit.org/show_bug.cgi?id=209043
1379
1380         Reviewed by Mark Lam.
1381
1382         * ContentExtensionTester/Configurations/Base.xcconfig:
1383         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1384
1385 2020-03-13  Alex Christensen  <achristensen@webkit.org>
1386
1387         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
1388         https://bugs.webkit.org/show_bug.cgi?id=209011
1389         <rdar://problem/59370588>
1390
1391         Reviewed by Youenn Fablet.
1392
1393         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1394         (TestWebKitAPI::TEST):
1395
1396 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1397
1398         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
1399         https://bugs.webkit.org/show_bug.cgi?id=209089
1400
1401         Reviewed by Tim Horton.
1402
1403         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
1404         marketing name for the feature.
1405
1406         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1407         (runUntilReceivesAutoplayEvent):
1408
1409         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
1410         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
1411         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
1412         be any compelling reason to compare against different types here (especially since we only set
1413         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
1414         these all to be `_WKAutoplayEvent`.
1415
1416         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1417         (-[AutoFillTestView _autofillInputView]):
1418         (-[AutoFillTestView textInputHasAutoFillContext]):
1419         (TestWebKitAPI::TEST):
1420         (-[AutofillTestView initWithFrame:]): Deleted.
1421         (-[AutofillTestView _autofillInputView]): Deleted.
1422         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
1423         * TestWebKitAPI/ios/UIKitSPI.h:
1424
1425 2020-03-13  Chris Dumez  <cdumez@apple.com>
1426
1427         Unreviewed, reverting r256232.
1428
1429         Caused ResizeObserver tests to become flaky
1430
1431         Reverted changeset:
1432
1433         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
1434         override TestOptions"
1435         https://bugs.webkit.org/show_bug.cgi?id=207481
1436         https://trac.webkit.org/changeset/256232
1437
1438 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1439
1440         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
1441         https://bugs.webkit.org/show_bug.cgi?id=209016
1442         <rdar://problem/60329530> 
1443
1444         Reviewed by Chris Dumez.
1445
1446         Re-initialize the app-bound domains when the correct
1447         TestOptions parameter is set.
1448
1449         * WebKitTestRunner/TestController.cpp:
1450         (WTR::TestController::createWebViewWithOptions):
1451         (WTR::TestController::reinitializeAppBoundDomains):
1452         * WebKitTestRunner/TestController.h:
1453
1454 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1455
1456         Report all third party loads on a per-page basis
1457         https://bugs.webkit.org/show_bug.cgi?id=209032
1458         <rdar://problem/60397323>
1459
1460         Reviewed by Chris Dumez.
1461
1462         Mostly naming updates to reflect the change in use for this SPI call.
1463         It now returns all loaded third party domains, not just prevalent ones.
1464
1465         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1466         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1467         (WTR::InjectedBundle::didReceiveMessageToPage):
1468         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1469         (WTR::TestRunner::getLoadedThirdPartyDomains):
1470         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
1471         (WTR::TestRunner::getPrevalentDomains): Deleted.
1472         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
1473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::TestController::resetStateToConsistentValues):
1476         (WTR::TestController::getLoadedThirdPartyDomains):
1477         (WTR::TestController::clearLoadedThirdPartyDomains):
1478         (WTR::TestController::getPrevalentDomains): Deleted.
1479         (WTR::TestController::clearPrevalentDomains): Deleted.
1480         * WebKitTestRunner/TestController.h:
1481         * WebKitTestRunner/TestInvocation.cpp:
1482         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1483         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
1484         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
1485         * WebKitTestRunner/TestInvocation.h:
1486         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1487         (WTR::TestController::getLoadedThirdPartyDomains):
1488         (WTR::TestController::clearLoadedThirdPartyDomains):
1489         (WTR::TestController::getPrevalentDomains): Deleted.
1490         (WTR::TestController::clearPrevalentDomains): Deleted.
1491
1492 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1493
1494         [ews] run FindModifiedChangeLogs early in the build
1495         https://bugs.webkit.org/show_bug.cgi?id=209060
1496
1497         Reviewed by Jonathan Bedard.
1498
1499         * BuildSlaveSupport/ews-build/factories.py:
1500         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1501
1502 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
1503
1504         [GTK] Add EWS testers to run GTK layout tests
1505         https://bugs.webkit.org/show_bug.cgi?id=207648
1506
1507         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
1508
1509         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
1510         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
1511         tests (layout tests).
1512
1513         * BuildSlaveSupport/ews-build/config.json: Added new queue for
1514         WK2 tests.
1515         * BuildSlaveSupport/ews-build/factories.py:
1516         (GTKTestsFactory):
1517         * BuildSlaveSupport/ews-build/factories_unittest.py:
1518         (TestCommitQueueFactory.test_commit_queue_factory):
1519         (TestGTKFactory): Added unit-test.
1520         (TestGTKFactory.test_gtk_factory):
1521         * BuildSlaveSupport/ews-build/loadConfig.py:
1522         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1523         (TagsForBuilderTest.test_getTagsForBuilder):
1524
1525 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1526
1527         Add API endpoint in EWS django app to provide patch status in json format
1528         https://bugs.webkit.org/show_bug.cgi?id=208940
1529
1530         Reviewed by Jonathan Bedard.
1531
1532         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
1533         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
1534
1535 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1536
1537         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
1538         https://bugs.webkit.org/show_bug.cgi?id=209055
1539         <rdar://problem/60272692>
1540
1541         Reviewed by Simon Fraser.
1542
1543         Now that WebKitTestRunner has a bundleID, its' user default values
1544         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
1545         to NO before running tests. It will be set to YES in PlatformWebView
1546         if specified by the test.
1547
1548         * WebKitTestRunner/mac/main.mm:
1549         (setDefaultsToConsistentValuesForTesting):
1550
1551 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
1552
1553         [CMake] Eleminate mismatches between Find* module names and variables they set
1554         https://bugs.webkit.org/show_bug.cgi?id=208948
1555
1556         Reviewed by Michael Catanzaro.
1557
1558         * wpe/backends/CMakeLists.txt:
1559
1560 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1561
1562         [ews-app] reduce logging
1563         https://bugs.webkit.org/show_bug.cgi?id=209062
1564
1565         Reviewed by Jonathan Bedard.
1566
1567         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1568         (BugzillaBeautifulSoup.authenticate):
1569         (BugzillaBeautifulSoup._load_query):
1570
1571 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1572
1573         Crash in TextIterator::node via TextManipulationController::replace
1574         https://bugs.webkit.org/show_bug.cgi?id=209048
1575
1576         Reviewed by Wenson Hsieh.
1577
1578         Added a regression test.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1581         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1582
1583 2020-03-13  Saam Barati  <sbarati@apple.com>
1584
1585         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1586         https://bugs.webkit.org/show_bug.cgi?id=209038
1587
1588         Reviewed by Keith Miller.
1589
1590         This allows us to automatically pull in some tests that are in non open sourced Apple
1591         checkouts.
1592
1593         * Scripts/run-javascriptcore-tests:
1594         (runJSCStressTests):
1595
1596 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1597
1598         Crash in TextManipulationController::replace
1599         https://bugs.webkit.org/show_bug.cgi?id=209021
1600
1601         Reviewed by Wenson Hsieh.
1602
1603         Added a regression test.
1604
1605         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1606         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1607
1608 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1609
1610         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1611         https://bugs.webkit.org/show_bug.cgi?id=208953
1612
1613         Reviewed by Brent Fulgham.
1614
1615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1616
1617 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1618
1619         Resource load statistics data summary should return all third party data
1620         https://bugs.webkit.org/show_bug.cgi?id=209000
1621         <rdar://problem/60348306>
1622
1623         Reviewed by John Wilander.
1624
1625         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1626         the call returns all third parties, not just prevalent ones.
1627         Added a more aggressive check for the size of the array at the
1628         beginning of the test to ensure the array is still returning 3 values. 
1629         Also removed the ASSERT statements as they seem to cause timeouts (not
1630         clear crashes) when they are not true, which is hard to debug.
1631         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1632         checks, we don't need ASSERT statements.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1635         (TEST):
1636
1637 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1638
1639         resultsdpy: Add script to run local instance
1640         https://bugs.webkit.org/show_bug.cgi?id=208746
1641
1642         Rubber-stamped by Aakash Jain.
1643
1644         * resultsdbpy/resultsdbpy/example: Added.
1645         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1646         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1647         (Environment): Organize environment variables used by results database.
1648         (ModelFromEnvironment): Construct the database model from the environment.
1649         (main): Create and drop tables, if required.
1650         * resultsdbpy/resultsdbpy/example/main.py: Added.
1651         (health): Web-server health check.
1652         (handle_errors):
1653         (main): Run results database web-server.
1654         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1655         (main): Asynchronously process uploaded results.
1656         * resultsdbpy/resultsdbpy/run: Added.
1657
1658 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1659
1660         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1661         https://bugs.webkit.org/show_bug.cgi?id=209004
1662
1663         Reviewed by Tim Horton.
1664
1665         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1666         `use_gpu_process` is specified.
1667
1668         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1669         (parse_args):
1670
1671 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1672
1673         Make flatpack import for run-webkit-tests only happen on linux systems
1674         https://bugs.webkit.org/show_bug.cgi?id=208954
1675
1676         Reviewed by Philippe Normand.
1677
1678         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1679         to determine if we need the flatpackutils import. 
1680
1681 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1682
1683         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1684         https://bugs.webkit.org/show_bug.cgi?id=207609
1685
1686         Reviewed by Ryosuke Niwa.
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1689         (TestWebKitAPI::TEST):
1690
1691 2020-03-12  Daniel Bates  <dabates@apple.com>
1692
1693         FocusController::setFocusedElement() should tell client of refocused element
1694         https://bugs.webkit.org/show_bug.cgi?id=208880
1695
1696         Reviewed by Wenson Hsieh.
1697
1698         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1699         to start an input session. Currently, it does not even try.
1700
1701         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1702         (TEST):
1703
1704 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1705
1706         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1707         https://bugs.webkit.org/show_bug.cgi?id=208970
1708
1709         Reviewed by Daniel Bates.
1710
1711         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1712         #!/usr/bin/env python.
1713
1714         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1715         probably has similar rules.
1716
1717         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1718         Everything else that does so is probably only used by webkit-build.
1719
1720         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1721
1722         * gtkdoc/generate-gtkdoc:
1723
1724 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1725
1726         [WebAuthn] Formalize the Keychain schema
1727         https://bugs.webkit.org/show_bug.cgi?id=183533
1728         <rdar://problem/43347926>
1729
1730         Reviewed by Brent Fulgham.
1731
1732         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1733         the original combination of RP ID and user handle.
1734
1735         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1737         (WTR::TestRunner::cleanUpKeychain):
1738         (WTR::TestRunner::keyExistsInKeychain):
1739         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1740         * WebKitTestRunner/TestController.h:
1741         * WebKitTestRunner/TestInvocation.cpp:
1742         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1743         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1744         (WTR::TestController::cleanUpKeychain):
1745         (WTR::TestController::keyExistsInKeychain):
1746
1747 2020-03-11  Keith Miller  <keith_miller@apple.com>
1748
1749         Test262-runner should always consider crashes as new failures
1750         https://bugs.webkit.org/show_bug.cgi?id=208943
1751
1752         Reviewed by Yusuke Suzuki.
1753
1754         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1755         Since we should never crash on a conformance test we should consider a crash as a new failure
1756         100% of the time.
1757
1758         * Scripts/test262/Runner.pm:
1759         (processFile):
1760         (runTest):
1761         (processResult):
1762
1763 2020-03-11  Chris Dumez  <cdumez@apple.com>
1764
1765         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1766         https://bugs.webkit.org/show_bug.cgi?id=208927
1767         <rdar://problem/55448331>
1768
1769         Reviewed by Alex Christensen.
1770
1771         Add API test coverage.
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1774
1775 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1776
1777         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1778         https://bugs.webkit.org/show_bug.cgi?id=208860
1779
1780         Reviewed by Carlos Alberto Lopez Perez.
1781
1782         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1783         (StatusBubble): Added 'api-gtk'.
1784         * BuildSlaveSupport/ews-build/config.json:
1785         * BuildSlaveSupport/ews-build/factories.py:
1786         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1787         GTK.
1788         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1789         GTK.
1790         (GTKBuildFactory):
1791         (GTKBuildFactory.__init__): Deleted.
1792         (GTKBuildAndTestFactory): Deleted.
1793         (GTKBuildAndTestFactory.__init__): Deleted.
1794         (GTKAPIBuildAndTestFactory): Deleted.
1795         * BuildSlaveSupport/ews-build/loadConfig.py:
1796
1797 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1798
1799         [ews] Add unit test to prevent multiple schedulers for a builder.
1800         https://bugs.webkit.org/show_bug.cgi?id=208917
1801
1802         Reviewed by Carlos Alberto Lopez Perez.
1803
1804         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1805         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1806         (TagsForBuilderTest): Fixed a typo.
1807
1808 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1809
1810         [GTK] Failing API tests under the Flatpak SDK environment
1811         https://bugs.webkit.org/show_bug.cgi?id=208871
1812
1813         Reviewed by Michael Catanzaro.
1814
1815         The load-failed signal callback should return a boolean result,
1816         otherwise we enter in unknown territory depending on how the
1817         toolchain compiles this, possibly triggering bad behavior (with
1818         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1819         GCC toolchain on buildbots).
1820
1821         Patch suggested by Michael Catanzaro.
1822
1823         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1824         (loadFailedCallback):
1825
1826 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1827
1828         Sync FeatureList.pm with CMake definitions
1829         https://bugs.webkit.org/show_bug.cgi?id=208866
1830
1831         Reviewed by Michael Catanzaro.
1832
1833         * Scripts/webkitperl/FeatureList.pm:
1834
1835 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1836
1837         [ews] Add unit tests for commit queue factory
1838         https://bugs.webkit.org/show_bug.cgi?id=208862
1839
1840         Reviewed by Jonathan Bedard.
1841
1842         * BuildSlaveSupport/ews-build/factories_unittest.py:
1843         (TestCommitQueueFactory):
1844         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1845
1846 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1847
1848         [ews-app] Status bubble should only display important messages in pop-over - part 3
1849         https://bugs.webkit.org/show_bug.cgi?id=208865
1850
1851         Reviewed by Jonathan Bedard.
1852
1853         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1854         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1855
1856 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1857
1858         [WPE] MiniBrowser: Close child WebViews when exiting
1859         https://bugs.webkit.org/show_bug.cgi?id=208689
1860
1861         Reviewed by Carlos Garcia Campos.
1862
1863         Store created views so we can release them before exiting.
1864
1865         * MiniBrowser/wpe/main.cpp:
1866         (webViewClose):
1867         (createWebView):
1868         (main):
1869
1870 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1871
1872         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1873         https://bugs.webkit.org/show_bug.cgi?id=208861
1874
1875         Reviewed by Jonathan Bedard.
1876
1877         * BuildSlaveSupport/ews-build/factories.py:
1878         (Factory.__init__): Remove verifycqplus parameter.
1879         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1880         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1881         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1882
1883 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1884
1885         [GTK] API favicon test flaky timeouts
1886         https://bugs.webkit.org/show_bug.cgi?id=208189
1887
1888         Reviewed by Carlos Garcia Campos.
1889
1890         Sometimes the favicon changes already during the load. Keeping
1891         track of it in the WebView favicon property notification handler
1892         gets us rid of the race.
1893
1894         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1895         (testFaviconDatabaseGetFavicon):
1896
1897 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1898
1899         Generate commit-queue status bubble from new EWS
1900         https://bugs.webkit.org/show_bug.cgi?id=208811
1901
1902         Reviewed by Jonathan Bedard.
1903
1904         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1905         (StatusBubble._build_bubbles_for_patch):
1906
1907 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1908
1909         Remove obsolete feature flags
1910         https://bugs.webkit.org/show_bug.cgi?id=208830
1911
1912         Reviewed by Alex Christensen.
1913
1914         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1915         are no longer used.
1916
1917         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1918         when the compilation flag was removed in r258148.
1919
1920         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1921         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1922
1923         * Scripts/webkitperl/FeatureList.pm:
1924         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1925
1926 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1927
1928         WebKitTestRunner bundleID should not be cleared before every test
1929         https://bugs.webkit.org/show_bug.cgi?id=208823
1930         <rdar://problem/60204539>
1931
1932         Reviewed by Per Arne Vollan.
1933
1934         This is causing test failures for layout tests which rely on the Info.plist 
1935         bundle identifier (not the one set via the override method).
1936
1937         * WebKitTestRunner/TestController.cpp:
1938         (WTR::TestController::createWebViewWithOptions):
1939         (WTR::TestController::ensureViewSupportsOptionsForTest):
1940         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1941
1942 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1943
1944         [macOS] Notification observer is not removed
1945         https://bugs.webkit.org/show_bug.cgi?id=208834
1946
1947         Reviewed by Tim Horton.
1948
1949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1950         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1951         (TEST):
1952
1953 2020-03-06  Brian Burg  <bburg@apple.com>
1954
1955         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1956         https://bugs.webkit.org/show_bug.cgi?id=208729
1957         <rdar://problem/60105447>
1958
1959         Reviewed by Jonathan Bedard.
1960
1961         Improve upload.py to look for the svn branch and revision for the 'webkit'
1962         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1963
1964         * Scripts/webkitpy/common/checkout/scm/git.py:
1965         (Git):
1966         (Git.git_svn_id_regexp):
1967         (Git._field_from_git_svn_id):
1968         (Git.svn_revision):
1969         (Git.svn_branch):
1970         (Git.svn_url):
1971         (Git.native_branch):
1972         Refactor svn revision, branch, url to use the same regexp and helper code.
1973
1974         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1975         (StubRepository.svn_branch):
1976         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1977
1978         * Scripts/webkitpy/common/checkout/scm/svn.py:
1979         (SVN.svn_branch):
1980         (SVN.native_revision):
1981         (SVN):
1982         (SVN.native_branch):
1983         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1984         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1985
1986         * Scripts/webkitpy/port/base.py:
1987         (Port.commits_for_upload):
1988         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1989         is preferred over the git equivalents.
1990
1991 2020-03-09  Antoine Quint  <graouts@apple.com>
1992
1993         TestWebKitAPI fails to build on watchOS
1994         https://bugs.webkit.org/show_bug.cgi?id=208820
1995
1996         Reviewed by Tim Horton.
1997
1998         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1999
2000 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
2001
2002         resultsdbpy: Add tool to manage resultsdbpy container
2003         https://bugs.webkit.org/show_bug.cgi?id=208743
2004
2005         Rubber-stamped by Aakash Jain.
2006
2007         Add tool to start, stop and restart the resultsdbpy Docker container.
2008
2009         * resultsdbpy/resultsdbpy/container: Added.
2010
2011 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2012
2013         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
2014         https://bugs.webkit.org/show_bug.cgi?id=208706
2015
2016         Reviewed by Žan Doberšek.
2017
2018         Add test case to check surrounding text in multiline context.
2019
2020         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
2021         (testWebKitInputMethodContextSurrounding):
2022
2023 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
2024
2025         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
2026         https://bugs.webkit.org/show_bug.cgi?id=208783
2027
2028         Reviewed by Brent Fulgham.
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031
2032 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
2033
2034         Replace the use of term "rollout" to "revert" in various tools
2035         https://bugs.webkit.org/show_bug.cgi?id=208775
2036
2037         Reviewed by Ryosuke Niwa.
2038
2039         See this webkit-dev thread for the originating discussion:
2040         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
2041
2042         'rollout' is a confusing term to anyone unacquainted with WebKit;
2043         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
2044
2045         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
2046         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
2049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2056         * BuildSlaveSupport/ews-build/steps.py:
2057         * BuildSlaveSupport/ews-build/steps_unittest.py:
2058         * Scripts/webkit-tools-completion.sh:
2059         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2060         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2061         * Scripts/webkitpy/common/checkout/scm/svn.py:
2062         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2063         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2064         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2065         * Scripts/webkitpy/tool/bot/feeders.py:
2066         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2067         * Scripts/webkitpy/tool/bot/irc_command.py:
2068         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2069         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2070         * Scripts/webkitpy/tool/bot/sheriff.py:
2071         * Scripts/webkitpy/tool/commands/download.py:
2072         * Scripts/webkitpy/tool/commands/download_unittest.py:
2073         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2074         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2076         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2077         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2078         * Scripts/webkitpy/tool/steps/__init__.py:
2079         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2080         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2081         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2082         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
2083
2084 2020-03-07  David Quesada  <david_quesada@apple.com>
2085
2086         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
2087         https://bugs.webkit.org/show_bug.cgi?id=208781
2088         rdar://problem/60061016
2089
2090         Reviewed by Alex Christensen.
2091
2092         Add a test that recreates the conditions of this crash:
2093         - Send a message from the injected bundle to the UI process that contains a reply block.
2094         - Hold a reference to the reply block.
2095         - Let the web view deallocate.
2096         - Call the block, and expect not to crash.
2097
2098         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2099         (localObjectInterface):
2100         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2101         (-[LocalObject doSomethingWithCompletionHandler:]):
2102         (TEST):
2103         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2104         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
2105
2106 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2107
2108         TextManipulationController should work with ARIA labels
2109         https://bugs.webkit.org/show_bug.cgi?id=208759
2110
2111         Reviewed by Wenson Hsieh.
2112
2113         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2114         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
2115         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
2116         the expected number of tokens for the first item as the very first image is correctly
2117         detected per the code change. 
2118         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
2119
2120 2020-03-07  Alex Christensen  <achristensen@webkit.org>
2121
2122         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
2123         https://bugs.webkit.org/show_bug.cgi?id=208767
2124
2125         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2126         The frameID of the main frame before loading is only 0 on Mac right now.
2127         The test is still good because it validates that execution works in the main frame before loading.
2128
2129 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2130
2131         [ews] commit queue is not skipping layout tests for rollout patches
2132         https://bugs.webkit.org/show_bug.cgi?id=208716
2133
2134         Unreviewed minor fix.
2135
2136         * BuildSlaveSupport/ews-build/steps.py:
2137         (RunWebKitTests.doStepIf):
2138         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
2139         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2140
2141 2020-03-05  Sam Weinig  <weinig@apple.com>
2142
2143         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2144         https://bugs.webkit.org/show_bug.cgi?id=207436
2145         <rdar://problem/59296762>
2146
2147         Reviewed by Darin Adler.
2148
2149         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2150         Remove JSC related defines.
2151
2152 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
2153
2154         AX: Provide a way to run tests in isolated tree mode
2155         https://bugs.webkit.org/show_bug.cgi?id=208629
2156         <rdar://problem/60075583>
2157
2158         Reviewed by Ryosuke Niwa.
2159
2160         Provide the ability to run tests for accessibility in the isolated tree mode.
2161         This sends a flag over to the injected bundle which calls the right HIServices override so that
2162         the system thinks it is in isolated mode.
2163
2164         * Scripts/compare-webkit-configurations:
2165         (flag_for_comparison):
2166         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2167         (parse_args):
2168         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2169         (parse_args):
2170         * Scripts/webkitpy/port/driver.py:
2171         (Driver.cmd_line):
2172         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2173         (WTR::AccessibilityController::AccessibilityController):
2174         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
2175         (WTR::AccessibilityController::updateIsolatedTreeMode):
2176         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
2177         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2178         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2179         (WTR::InjectedBundle::didReceiveMessageToPage):
2180         (WTR::InjectedBundle::beginTesting):
2181         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2182         * WebKitTestRunner/Options.cpp:
2183         (WTR::handleOptionAccessibilityIsolatedTreeMode):
2184         (WTR::OptionsHandler::OptionsHandler):
2185         * WebKitTestRunner/Options.h:
2186         * WebKitTestRunner/TestController.cpp:
2187         (WTR::TestController::initialize):
2188         (WTR::TestController::resetPreferencesToConsistentValues):
2189         (WTR::TestController::resetStateToConsistentValues):
2190         * WebKitTestRunner/TestController.h:
2191         (WTR::TestController::accessibilityIsolatedTreeMode const):
2192
2193 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
2194
2195         [Cocoa] Re-enable CFPrefs direct mode
2196         https://bugs.webkit.org/show_bug.cgi?id=208690
2197
2198         Reviewed by Brent Fulgham.
2199
2200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2201         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
2202         (TEST):
2203         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2204         (TestWebKitAPI::TEST):
2205
2206 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
2207
2208         UIProcess needs mechanism to specify AppBound domains
2209         https://bugs.webkit.org/show_bug.cgi?id=208528
2210         <rdar://problem/59980340>
2211
2212         Reviewed by Brent Fulgham.
2213
2214         Added test app-bound domains to the plist and tested that the domains
2215         are properly stored in the website data store after a navigation.
2216
2217         * TestWebKitAPI/Info.plist:
2218         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2219         (TEST):
2220
2221 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2222
2223         Add SPI to disable cross origin access control checks
2224         https://bugs.webkit.org/show_bug.cgi?id=208748
2225
2226         Reviewed by Tim Hatcher.
2227
2228         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2229         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
2230
2231 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
2232
2233         [webkitpy] Fix executive on Windows to run wpt server correctly
2234         https://bugs.webkit.org/show_bug.cgi?id=208693
2235
2236         Reviewed by Jonathan Bedard.
2237
2238         Bug fix for Windows environment a) fixing a typo. b) fixing path
2239         c) fix how to kill subprocesses.
2240
2241         * Scripts/webkitpy/common/system/executive.py:
2242         (Executive._windows_kill_command):
2243         (Executive.interrupt):
2244         (Executive.kill_all):
2245         * Scripts/webkitpy/port/base.py:
2246         (Port.web_platform_test_server_doc_root):
2247
2248 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2249
2250         Evaluating JavaScript in main frame before loading should succeed
2251         https://bugs.webkit.org/show_bug.cgi?id=208733
2252
2253         Reviewed by Tim Horton.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2256
2257 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
2258
2259         TextManipulationController should preserve images
2260         https://bugs.webkit.org/show_bug.cgi?id=208692
2261
2262         Reviewed by Wenson Hsieh.
2263
2264         Added tests for preserving images and their ordering.
2265
2266         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2267         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
2268         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
2269         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
2270
2271 2020-03-06  David Quesada  <david_quesada@apple.com>
2272
2273         Add _WKResourceLoadInfo.resourceType SPI
2274         https://bugs.webkit.org/show_bug.cgi?id=208723
2275
2276         Reviewed by Alex Christensen.
2277
2278         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2279         (TEST):
2280
2281 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
2282
2283         Stop reporting to webkit-test-results.webkit.org
2284         https://bugs.webkit.org/show_bug.cgi?id=207218
2285
2286         Reviewed by Alexey Proskuryakov.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2289         (RunWebKitTests):
2290
2291 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
2292
2293         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2294         https://bugs.webkit.org/show_bug.cgi?id=208365
2295         <rdar://problem/59877296>
2296
2297         Reviewed by Geoffrey Garen.
2298
2299         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2300         (TEST):
2301
2302 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2303
2304         EWS should be able to fetch patch status for security bugs while processing them
2305         https://bugs.webkit.org/show_bug.cgi?id=206511
2306
2307         Reviewed by Alexey Proskuryakov.
2308
2309         * BuildSlaveSupport/ews-build/steps.py:
2310         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
2311         (BugzillaMixin.get_patch_json): 
2312         (BugzillaMixin.get_bug_json):
2313         (BugzillaMixin._is_bug_closed):
2314         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
2315         (TransferToS3.hideStepIf): Ditto.
2316
2317 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [ews] commit-queue should show the trac url for the commit on the build page
2320         https://bugs.webkit.org/show_bug.cgi?id=208715
2321
2322         Reviewed by Jonathan Bedard.
2323
2324         * BuildSlaveSupport/ews-build/steps.py:
2325         (PushCommitToWebKitRepo.evaluateCommand):
2326
2327 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2328
2329         Fix ResourceLoadDelegate.LoadInfo API test after r257816
2330         https://bugs.webkit.org/show_bug.cgi?id=208550
2331
2332         * TestWebKitAPI/cocoa/HTTPServer.mm:
2333         (TestWebKitAPI::HTTPServer::respondToRequests):
2334         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
2335         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
2336
2337 2020-03-06  Lauro Moura <lmoura@igalia.com>
2338
2339         [WPE][WebDriver] MiniBrowser should react to close session commands
2340         https://bugs.webkit.org/show_bug.cgi?id=207529
2341
2342         Reviewed by Carlos Garcia Campos.
2343
2344         Do not call g_object_unref on the first created view if it has already
2345         been disposed in the "close" signal handler.
2346
2347         Based on original patch by Yury Semikhatsky.
2348
2349         * MiniBrowser/wpe/main.cpp:
2350         (main):
2351
2352 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2353
2354         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
2355         https://bugs.webkit.org/show_bug.cgi?id=208647
2356
2357         Reviewed by Carlos Garcia Campos.
2358
2359         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2360         (TestWebKitAPI::TEST):
2361
2362 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2363
2364         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
2365         https://bugs.webkit.org/show_bug.cgi?id=208670
2366
2367         Reviewed by Brady Eidson.
2368
2369         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2370         (-[FrameNavigationDelegate waitForNavigations:]):
2371         (-[FrameNavigationDelegate requests]):
2372         (-[FrameNavigationDelegate frames]):
2373         (-[FrameNavigationDelegate callbacks]):
2374         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
2375         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
2376         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
2377         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
2378         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
2379         (TEST):
2380
2381 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2382
2383         Add WKFrameInfo._parentFrameHandle SPI
2384         https://bugs.webkit.org/show_bug.cgi?id=208674
2385
2386         Reviewed by Brady Eidson.
2387
2388         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2389
2390 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
2391
2392         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
2393         https://bugs.webkit.org/show_bug.cgi?id=208626
2394         <rdar://problem/60074148>
2395
2396         Reviewed by Brent Fulgham.
2397
2398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2399         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2400         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
2401         (TestWebKitAPI::TEST):
2402         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
2403         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
2404         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
2405
2406 2020-03-05  Antoine Quint  <graouts@apple.com>
2407
2408         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
2409         https://bugs.webkit.org/show_bug.cgi?id=208644
2410         <rdar://problem/60042429>
2411
2412         Reviewed by Brady Eidson.
2413
2414         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
2415         
2416         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
2417            empty document has been removed in favor of the document for the requested URL,
2418         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
2419            correctly does not injected the style sheet.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2422
2423 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2424
2425         [ews] Add build step to push commit to WebKit repository
2426         https://bugs.webkit.org/show_bug.cgi?id=208589
2427
2428         Reviewed by Jonathan Bedard.
2429
2430         * BuildSlaveSupport/ews-build/steps.py:
2431         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
2432         (PushCommitToWebKitRepo.start): Initialize log observer.
2433         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
2434         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
2435         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
2436         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
2437         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2438         * BuildSlaveSupport/ews-build/factories.py:
2439
2440 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2441
2442         [ews] Add unit tests for ValidateCommiterAndReviewer build step
2443         https://bugs.webkit.org/show_bug.cgi?id=208262
2444
2445         Reviewed by Jonathan Bedard.
2446
2447         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
2448
2449 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2450
2451         commit-queue should run WK2 tests instead of WK1 tests
2452         https://bugs.webkit.org/show_bug.cgi?id=208544
2453
2454         Reviewed by Jonathan Bedard.
2455
2456         * BuildSlaveSupport/ews-build/factories.py:
2457
2458 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
2461         https://bugs.webkit.org/show_bug.cgi?id=208645
2462
2463         Reviewed by Alexey Proskuryakov.
2464
2465         * BuildSlaveSupport/ews-build/steps.py:
2466         (ValidateCommiterAndReviewer.load_contributors):
2467         (ValidateCommiterAndReviewer.start):
2468
2469 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2470
2471         style-checker: Add UAF to the list of security words to warn about.
2472         https://bugs.webkit.org/show_bug.cgi?id=208643
2473
2474         Reviewed by Jonathan Bedard.
2475
2476         UAF is a common acronym used for use after free.
2477
2478         * Scripts/webkitpy/style/checkers/changelog.py:
2479         (ChangeLogChecker.check_for_unwanted_security_phrases):
2480
2481 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2482
2483         [MSVC] Add .natvis support of WebKit types
2484         https://bugs.webkit.org/show_bug.cgi?id=193119
2485
2486         Reviewed by Don Olmstead.
2487
2488         To help the WebKit developer while debugging, this file defines how
2489         WebKit types are displayed in debugger of Visual Studio.
2490         Very limited set of WebKit types, but it changes the world.
2491
2492         * VisualStudio/WebKit.natvis: Added.
2493
2494 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2495
2496         Add system trace points around display list replay
2497         https://bugs.webkit.org/show_bug.cgi?id=208616
2498
2499         Reviewed by Simon Fraser.
2500
2501         Add a new "Display list replay" trace point.
2502
2503         * Tracing/SystemTracePoints.plist:
2504
2505 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2506
2507         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
2508         https://bugs.webkit.org/show_bug.cgi?id=208615
2509         <rdar://problem/59406743>
2510
2511         Reviewed by Alex Christensen.
2512
2513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2514         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
2515         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2516         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
2517         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2518         (TEST):
2519         Also make a test written in bug 206310 actually run code.
2520
2521 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2522
2523         [build.webkit.org] Remove leaks queue
2524         https://bugs.webkit.org/show_bug.cgi?id=208580
2525
2526         Reviewed by Jonathan Bedard.
2527
2528         * BuildSlaveSupport/build.webkit.org-config/config.json:
2529         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2531
2532 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2533
2534         Add SPI to evaluate JavaScript in an iframe
2535         https://bugs.webkit.org/show_bug.cgi?id=208605
2536
2537         Reviewed by Brady Eidson.
2538
2539         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2540
2541 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
2542
2543         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
2544         https://bugs.webkit.org/show_bug.cgi?id=208533
2545         <rdar://problem/60010184>
2546
2547         Reviewed by Alex Christensen.
2548
2549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2550         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2551         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
2552         (TestWebKitAPI::TEST):
2553         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
2554         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
2555
2556 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2557
2558         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
2559         https://bugs.webkit.org/show_bug.cgi?id=208593
2560
2561         Reviewed by Brady Eidson.
2562
2563         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2564         (TestWebKitAPI::TEST):
2565
2566 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2567
2568         WKWebView's frames accessor should return a traversable type
2569         https://bugs.webkit.org/show_bug.cgi?id=208591
2570
2571         Reviewed by Brady Eidson.
2572
2573         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2574
2575 2020-03-04  Antoine Quint  <graouts@apple.com>
2576
2577         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2578         https://bugs.webkit.org/show_bug.cgi?id=208575
2579         <rdar://problem/59773690>
2580
2581         Reviewed by Brady Eidson.
2582
2583         Add new tests for the new SPI which check:
2584         
2585         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2586            specified WKWebView alone,
2587         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2588         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2589         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2590         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2591         6. and that the same test also works with PSON enabled.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2594
2595 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2596
2597         [macOS] test-lldb-webkit failing on debug bots
2598         https://bugs.webkit.org/show_bug.cgi?id=208545
2599
2600         Reviewed by Jonathan Bedard.
2601
2602         The lldb-webkit-test step must pass in the build configuration as an
2603         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2604         binary that is downloaded with the rest of the build products. Without this
2605         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2606         regardless of their actual build configuration.
2607
2608         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2609         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2610         * Scripts/test-lldb-webkit:
2611         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2612
2613 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2614
2615         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2616         https://bugs.webkit.org/show_bug.cgi?id=208539
2617
2618         Unreviewed follow-up fix.
2619
2620         * BuildSlaveSupport/ews-build/steps.py:
2621
2622 2020-03-04  Daniel Bates  <dabates@apple.com>
2623
2624         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2625         https://bugs.webkit.org/show_bug.cgi?id=208565
2626
2627         Reviewed by Wenson Hsieh.
2628
2629         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2630         of its frame as a means to find all the editable elements in the visible content area
2631         of the web view.
2632
2633         Coincidentally this makes no difference to the test results right now because the web view
2634         happens to be located at the origin (0, 0) in the window. However if in the future the
2635         web view would be located at some other point then the tests may fail because the rectangle
2636         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2637         rectangle for the visible content area.
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2640         (TEST):
2641
2642 2020-03-04  Daniel Bates  <dabates@apple.com>
2643
2644         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2645         https://bugs.webkit.org/show_bug.cgi?id=208564
2646
2647         Reviewed by Alex Christensen.
2648
2649         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2650         to make it easy to run just these tests.
2651
2652         Currently, the tests are organized under the test case name WebKit. This means you need to
2653         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2654         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2655         so that a person can run just these test using:
2656         
2657                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2658
2659         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2660         (TEST):
2661
2662 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2663
2664         [ews] Add build step to create local git commit for commit-queue
2665         https://bugs.webkit.org/show_bug.cgi?id=208539
2666
2667         Reviewed by Jonathan Bedard.
2668
2669         * BuildSlaveSupport/ews-build/steps.py:
2670         (CreateLocalGITCommit): Build step to create local git commit.
2671         (CreateLocalGITCommit.start):
2672         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2673         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2674         * BuildSlaveSupport/ews-build/factories.py:
2675
2676 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2677
2678         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2679         https://bugs.webkit.org/show_bug.cgi?id=207948
2680
2681         Reviewed by Zalan Bujtas.
2682
2683         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2684         so that it receives the wheel events.
2685
2686         * DumpRenderTree/mac/EventSendingController.mm:
2687         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2688         * DumpRenderTree/win/EventSender.cpp:
2689         (mouseScrollBy):
2690
2691 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2692
2693         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2694         https://bugs.webkit.org/show_bug.cgi?id=208520
2695         <rdar://problem/60000214>
2696
2697         Reviewed by Chris Fleizach.
2698
2699         Calling InjectedBundle::singleton().page()->page() in the constructor
2700         of the AccessibilityController is having this side effect on iOS.
2701         So #if to MAC where it's actually being used.
2702
2703         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2704         (WTR::AccessibilityController::AccessibilityController):
2705
2706 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2707
2708         Add SPI _WKResourceLoadInfo.loadedFromCache
2709         https://bugs.webkit.org/show_bug.cgi?id=208554
2710
2711         Reviewed by Wenson Hsieh.
2712
2713         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2714         (TEST):
2715
2716 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2717
2718         Batch observations and completions of text manipulations
2719         https://bugs.webkit.org/show_bug.cgi?id=208406
2720
2721         Reviewed by Wenson Hsieh.
2722
2723         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2724         multiple paragraphs at once.
2725
2726         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2727         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2728         (-[TextManipulationDelegate items]):
2729         (-[LegacyTextManipulationDelegate init]):
2730         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2731         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2732         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2733         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2734         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2735         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2736         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2737
2738 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2739
2740         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2741         https://bugs.webkit.org/show_bug.cgi?id=208415
2742
2743         Reviewed by Brent Fulgham.
2744
2745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2746         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2747         (TEST):
2748
2749 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2750
2751         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2752         https://bugs.webkit.org/show_bug.cgi?id=208553
2753
2754         Reviewed by Simon Fraser.
2755
2756         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2757         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2758         (TEST):
2759         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2760
2761 2020-03-03  Brady Eidson  <beidson@apple.com>
2762
2763         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2764         https://bugs.webkit.org/show_bug.cgi?id=198795
2765
2766         Reviewed by Chris Dumez.
2767
2768         This test appears to no longer be flaky.
2769         
2770         Let's re-enable it.
2771         
2772         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2773         (TestWebKitAPI::TEST):
2774
2775 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2776
2777         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2778         https://bugs.webkit.org/show_bug.cgi?id=208550
2779
2780         Reviewed by Tim Hatcher.
2781
2782         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2783         (TEST):
2784         * TestWebKitAPI/cocoa/HTTPServer.mm:
2785         (TestWebKitAPI::HTTPServer::respondToRequests):
2786         HTTPServer now looks for Content-Length in its request.
2787         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2788
2789 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2790
2791         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2792         https://bugs.webkit.org/show_bug.cgi?id=208522
2793
2794         Reviewed by Brian Weinstein.
2795
2796         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2797         (TEST):
2798
2799 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2800
2801         commit-queue should update working directory and reapply patch just before commiting
2802         https://bugs.webkit.org/show_bug.cgi?id=208521
2803
2804         Reviewed by Jonathan Bedard.
2805
2806         * BuildSlaveSupport/ews-build/factories.py:
2807
2808 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2809
2810         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2811         https://bugs.webkit.org/show_bug.cgi?id=208485
2812
2813         Reviewed by Jonathan Bedard.
2814
2815         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2816         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2817         that we don't have to recreate the variables that are already created.
2818         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2819         from each module, rather than making extra imports that we don't need.
2820         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2821         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2822         and not part of the host.
2823         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2824         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2825         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2826         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2827         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2828         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2829         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2830         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2831         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2832         if we were geting any value at all
2833         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2834         sure we aren't gabking the wrong key:value pair
2835         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2836         come with the MockHosts and MockHost inherits from MockSystemHost.
2837         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2838         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2839         to the various upload steps.
2840
2841 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2842
2843         [ews] Add build step to find list of modified changelogs
2844         https://bugs.webkit.org/show_bug.cgi?id=208514
2845
2846         Reviewed by Jonathan Bedard.
2847
2848         * BuildSlaveSupport/ews-build/factories.py:
2849         * BuildSlaveSupport/ews-build/steps.py:
2850         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2851         (FindModifiedChangeLogs.start): Initialize log observer.
2852         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2853         (FindModifiedChangeLogs.evaluateCommand):
2854         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2855         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2856         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2857         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2858
2859 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2860
2861         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2862         https://bugs.webkit.org/show_bug.cgi?id=208451
2863
2864         Unreviewed test gardening.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2867
2868 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2869
2870         Adopt HTTP Alternative Services Storage
2871         https://bugs.webkit.org/show_bug.cgi?id=208387
2872
2873         Reviewed by Alex Christensen.
2874
2875         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2876         (checkUntilEntryFound):
2877         (TEST):
2878
2879 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2880
2881         Check for navigation to app-bound domain during script evaluation
2882         https://bugs.webkit.org/show_bug.cgi?id=208319
2883         <rdar://problem/57569321>
2884
2885         Reviewed by Brent Fulgham.
2886
2887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2888         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2889         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2890         (TEST):
2891         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2892         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2893
2894 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2895
2896         Unreviewed, rolling out r257754.
2897         https://bugs.webkit.org/show_bug.cgi?id=208513
2898
2899         Introduced API test failure (Requested by perarne on #webkit).
2900
2901         Reverted changeset:
2902
2903         "[Cocoa] Mapping from MIME type to UTI type should be done in
2904         the UI process"
2905         https://bugs.webkit.org/show_bug.cgi?id=208415
2906         https://trac.webkit.org/changeset/257754
2907
2908 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2909
2910         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2911         https://bugs.webkit.org/show_bug.cgi?id=208506
2912
2913         Reviewed by Carlos Garcia Campos.
2914
2915         * WebKitTestRunner/TestController.cpp:
2916         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2917
2918 2020-03-02  Ben Nham  <nham@apple.com>
2919
2920         Add performance probes for HTML parsing
2921         https://bugs.webkit.org/show_bug.cgi?id=208271
2922
2923         Reviewed by Daniel Bates.
2924
2925         This adds probes that show which lines of HTML are have been parsed.
2926
2927         * Tracing/SystemTracePoints.plist:
2928
2929 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2930
2931         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2932         https://bugs.webkit.org/show_bug.cgi?id=208415
2933
2934         Reviewed by Brent Fulgham.
2935
2936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2937         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2938         (TEST):
2939
2940 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2941
2942         Unreviewed, rolling out r257725.
2943
2944         This commit caused 10 API tests to fail
2945
2946         Reverted changeset:
2947
2948         "[Cocoa] Mapping from MIME type to UTI type should be done in
2949         the UI process"
2950         https://bugs.webkit.org/show_bug.cgi?id=208415
2951         https://trac.webkit.org/changeset/257725
2952
2953 2020-03-02  Saam Barati  <sbarati@apple.com>
2954
2955         Don't skip tests unnecessarily on arm64
2956         https://bugs.webkit.org/show_bug.cgi?id=208470
2957         <rdar://problem/59968869>
2958
2959         Reviewed by Tadeu Zagallo.
2960
2961         * Scripts/run-jsc-stress-tests:
2962
2963 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2964
2965         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2966         https://bugs.webkit.org/show_bug.cgi?id=208434
2967
2968         Reviewed by Chris Fleizach.
2969
2970         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2971         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2972         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2973         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2974         (WTR::AccessibilityController::accessibleElementById): Same as above.
2975
2976 2020-03-02  John Wilander  <wilander@apple.com>
2977
2978         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2979         https://bugs.webkit.org/show_bug.cgi?id=208399
2980         <rdar://problem/24731650>
2981
2982         Reviewed by Brent Fulgham.
2983
2984         The majority of the changes in WTR::TestController is (partially) fixing a bug
2985         where the TestRunner would statically use the default website datastore instead
2986         of the website data store configure for the page. This worked for persistent
2987         storage testing but not for ephemeral sessions which is what this patch is all
2988         about. The previous TestController::websiteDataStore() is now called
2989         TestController::defaultWebsiteDataStore() and the new
2990         TestController::websiteDataStore() returns the configured website data store.
2991         Most of the use of the default website data store should probably change but
2992         that's not really for this patch to deal with. I did however move all of
2993         resource load statistics' use to the new TestController::websiteDataStore().
2994
2995         A new TestRunner function was added: isStatisticsEphemeral()
2996         It allows test cases to query the ephemeral status of resource load statistics.
2997
2998         One problem that is mitigated in this patch but not fully fixed is that for
2999         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
3000         TestController::generatePageConfiguration() via C API 
3001         WKPageConfigurationSetWebsiteDataStore(), and then again in 
3002         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
3003         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
3004         I tried removing the latter since one session for all platforms should be
3005         Enough but got broken behavior as a result. So now both are still there
3006         and both enable resource load statistics.
3007
3008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3010         (WTR::TestRunner::isStatisticsEphemeral):
3011         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::TestController::defaultWebsiteDataStore):
3014         (WTR::TestController::websiteDataStore):
3015         (WTR::TestController::generatePageConfiguration):
3016         (WTR::TestController::resetPreferencesToConsistentValues):
3017         (WTR::TestController::resetStateToConsistentValues):
3018         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3019         (WTR::TestController::decidePolicyForNavigationAction):
3020         (WTR::TestController::platformAdjustContext):
3021         (WTR::TestController::clearServiceWorkerRegistrations):
3022         (WTR::TestController::clearDOMCache):
3023         (WTR::TestController::clearDOMCaches):
3024         (WTR::TestController::clearIndexedDatabases):
3025         (WTR::TestController::clearLocalStorage):
3026         (WTR::TestController::hasDOMCache):
3027         (WTR::TestController::domCacheSize):
3028         (WTR::TestController::setStatisticsEnabled):
3029         (WTR::TestController::isStatisticsEphemeral):
3030         (WTR::TestController::setStatisticsDebugMode):
3031         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
3032         (WTR::TestController::setStatisticsLastSeen):
3033         (WTR::TestController::setStatisticsMergeStatistic):
3034         (WTR::TestController::setStatisticsPrevalentResource):
3035         (WTR::TestController::setStatisticsVeryPrevalentResource):
3036         (WTR::TestController::dumpResourceLoadStatistics):
3037         (WTR::TestController::isStatisticsPrevalentResource):
3038         (WTR::TestController::isStatisticsVeryPrevalentResource):
3039         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
3040         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3041         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3042         (WTR::TestController::setStatisticsHasHadUserInteraction):
3043         (WTR::TestController::isStatisticsHasHadUserInteraction):
3044         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
3045         (WTR::TestController::setStatisticsGrandfathered):
3046         (WTR::TestController::isStatisticsGrandfathered):
3047         (WTR::TestController::setUseITPDatabase):
3048         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
3049         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
3050         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
3051         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
3052         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
3053         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
3054         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3055         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3056         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3057         (WTR::TestController::statisticsUpdateCookieBlocking):
3058         (WTR::TestController::statisticsSubmitTelemetry):
3059         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3060         (WTR::TestController::setStatisticsIsRunningTest):
3061         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3062         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3063         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3064         (WTR::TestController::setStatisticsGrandfatheringTime):
3065         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3066         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3067         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3068         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3069         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
3070         (WTR::TestController::statisticsDeleteCookiesForHost):
3071         (WTR::TestController::isStatisticsHasLocalStorage):
3072         (WTR::TestController::setStatisticsCacheMaxAgeCap):
3073         (WTR::TestController::hasStatisticsIsolatedSession):
3074         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
3075         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
3076         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
3077         (WTR::TestController::statisticsResetToConsistentState):
3078         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3079         * WebKitTestRunner/TestController.h:
3080         * WebKitTestRunner/TestInvocation.cpp:
3081         (WTR::TestInvocation::invoke):
3082         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3083         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3084         (WTR::initializeWebViewConfiguration):
3085         (WTR::TestController::platformCreateWebView):
3086
3087 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
3088
3089         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3090         https://bugs.webkit.org/show_bug.cgi?id=208415
3091
3092         Reviewed by Brent Fulgham.
3093
3094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3095         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3096         (TEST):
3097
3098 2020-03-02  Daniel Bates  <dabates@apple.com>
3099
3100         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
3101         https://bugs.webkit.org/show_bug.cgi?id=208352
3102         <rdar://problem/59867815>
3103
3104         Reviewed by Wenson Hsieh.
3105
3106         Update test results to reflect the new behavior. To do this I also need to fix up the test code
3107         to actually scroll the web content. This also means we now execute the same code on both Mac and
3108         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
3109         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
3110         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
3111
3112         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3113         (TEST):
3114
3115 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
3116
3117         Unreviewed, rolling out r257687.
3118
3119         This commit caused debug tests to crash for macOS & iOS
3120
3121         Reverted changeset:
3122
3123         "[Cocoa] Mapping from MIME type to UTI type should be done in
3124         the UI process"
3125         https://bugs.webkit.org/show_bug.cgi?id=208415
3126         https://trac.webkit.org/changeset/257687
3127
3128 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3129
3130         Unreviewed, rolling out r257618.
3131
3132         This allegedly causes Safari to crash when closing a window
3133         (see rdar://problem/59922725).
3134
3135         Reverted changeset:
3136
3137         "UIProcess crash after using _prepareForMoveToWindow, then
3138         deallocating the WKWebView before moving to the window"
3139         https://bugs.webkit.org/show_bug.cgi?id=208365
3140         https://trac.webkit.org/changeset/257618
3141
3142 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
3143
3144         Remove std::lock_guard
3145         https://bugs.webkit.org/show_bug.cgi?id=206451
3146
3147         Reviewed by Anders Carlsson.
3148
3149         Add std::lock_guard lint rule to prevent from using it.
3150
3151         * Scripts/webkitpy/style/checkers/cpp.py:
3152         (check_lock_guard):
3153         (check_style):
3154         (CppChecker):
3155         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3156         (WebKitStyleTest.test_lock_guard):
3157         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3158         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3159         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3160         (assertHasObjects):
3161         (assertHasOnlyObjects):
3162         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3163         (WTR::AXThread::dispatch):
3164         (WTR::AXThread::dispatchFunctionsFromAXThread):
3165         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3166         (WTR::AXThread::initializeRunLoop):
3167
3168 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
3169
3170         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3171         https://bugs.webkit.org/show_bug.cgi?id=208415
3172
3173         Reviewed by Brent Fulgham.
3174
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3177         (TEST):
3178
3179 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3180
3181         Unreviewed, rolling out r257565.
3182
3183         It broke WinCairo MiniBrowser
3184
3185         Reverted changeset:
3186
3187         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
3188         https://bugs.webkit.org/show_bug.cgi?id=206894
3189         https://trac.webkit.org/changeset/257565
3190
3191 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3192
3193         EWS fails to retry build in case of kill-old-processes exception
3194         https://bugs.webkit.org/show_bug.cgi?id=208003
3195
3196         Reviewed by Jonathan Bedard.
3197
3198         * BuildSlaveSupport/ews-build/steps.py:
3199         (KillOldProcesses.evaluateCommand):
3200         (KillOldProcesses.getResultSummary):
3201
3202 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3203
3204         [ews] commit-queue should update the ChangeLog with Reviewer name
3205         https://bugs.webkit.org/show_bug.cgi?id=206535
3206
3207         Reviewed by Jonathan Bedard.
3208
3209         * BuildSlaveSupport/ews-build/steps.py:
3210         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
3211
3212 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
3213
3214         run-javascriptcore-tests: Make upload format valid
3215         https://bugs.webkit.org/show_bug.cgi?id=208341
3216
3217         Rubber-stamped by Aakash Jain.
3218
3219         * Scripts/run-javascriptcore-tests:
3220         (uploadResults): Remove. FIXME.
3221         * Scripts/webkitdirs.pm:
3222         (splitVersionString): Handle case where the subminor version number has a - in it.
3223         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
3224
3225 2020-02-28  youenn fablet  <youenn@apple.com>
3226
3227         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
3228         https://bugs.webkit.org/show_bug.cgi?id=208130
3229
3230         Reviewed by Eric Carlson.
3231
3232         * WebKitTestRunner/TestOptions.h:
3233         Use GPU process to capture by default.
3234         We will remove this option once done verifying that every test works smoothly.
3235
3236 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3237
3238         [ews] commit queue should skip building and testing for rollout patches
3239         https://bugs.webkit.org/show_bug.cgi?id=208329
3240
3241         Reviewed by Jonathan Bedard.
3242
3243         * BuildSlaveSupport/ews-build/steps.py:
3244         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
3245         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
3246         (RunWebKit1Tests.doStepIf): Ditto.
3247         * BuildSlaveSupport/ews-build/steps_unittest.py:
3248         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
3249         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
3250
3251 2020-02-28  Daniel Bates  <dabates@apple.com>
3252
3253         Update my watch list preferences and contributor's entry.
3254
3255         * Scripts/webkitpy/common/config/contributors.json:
3256         * Scripts/webkitpy/common/config/watchlist:
3257
3258 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3259
3260         Fix WebCore export macros for declspec
3261         https://bugs.webkit.org/show_bug.cgi?id=208363
3262
3263         Reviewed by Konstantin Tokarev.
3264
3265         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
3266         files. Removed precompiled headers that were empty.
3267
3268         * DumpRenderTree/DumpRenderTreePrefix.h:
3269         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
3270         * MiniBrowser/win/stdafx.h:
3271         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
3272         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
3273         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
3274         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
3275         * WebKitTestRunner/PlatformFTW.cmake:
3276         * WebKitTestRunner/PlatformWin.cmake:
3277         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3278
3279 2020-02-27  Tim Horton  <timothy_horton@apple.com>
3280
3281         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
3282         https://bugs.webkit.org/show_bug.cgi?id=208365
3283
3284         Reviewed by Alex Christensen.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3287         (TEST):
3288         Add a test! It was a 100% repro crash before this change.
3289
3290 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
3291
3292         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3293         https://bugs.webkit.org/show_bug.cgi?id=208260
3294         <rdar://problem/59820107>
3295
3296         Reviewed by Tim Horton.
3297
3298         Followed instructions for adding an Info.plist for Single-File Tools
3299         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3300
3301         The default WebsiteDataStore file path will change with this test to
3302         reflect the new bundleID so we must change expectations for any api
3303         tests which rely on knowing the path.
3304
3305         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3307         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
3308         (TEST):
3309         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3310         (TEST):
3311         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
3312         (TEST):
3313         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
3314         (TEST):
3315         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3316         (TEST):
3317         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3318         (TEST):
3319         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3320         (TEST):
3321         (defaultWebsiteCacheDirectory):
3322         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
3323         (TEST):
3324         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3325         (TEST):
3326         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3327         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3328         (TEST):
3329         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3330         (TEST):
3331         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3332         (runWebsiteDataStoreCustomPaths):
3333         (TEST):
3334         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3335         (TestWebKitAPI::resetTestState):
3336         Now that we set a bundleID, we have to reset the cache model between
3337         tests, otherwise it gets stored between tests.
3338
3339         (TestWebKitAPI::TEST):
3340         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3341         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3342
3343 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3344
3345         TextManipulationController should not generate a new item for content in manipulated paragraphs
3346         https://bugs.webkit.org/show_bug.cgi?id=208286
3347
3348         Reviewed by Wenson Hsieh.
3349
3350         Added a regression test.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3353         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
3354
3355 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
3356
3357         run-javascriptcore-tests: Make upload format valid
3358         https://bugs.webkit.org/show_bug.cgi?id=208341
3359
3360         Reviewed by Aakash Jain.
3361
3362         * Scripts/run-javascriptcore-tests:
3363         (uploadResults): Print json blob for upload after failure for debugging.
3364
3365 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3366
3367         [CMake] Add WebKit::PAL target
3368         https://bugs.webkit.org/show_bug.cgi?id=198493
3369
3370         Reviewed by Michael Catanzaro.
3371
3372         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
3373
3374         * DumpRenderTree/PlatformWin.cmake:
3375
3376 2020-02-27  Alex Christensen  <achristensen@webkit.org>
3377
3378         Add SPI to query WKFrameInfos in a WKWebView
3379         https://bugs.webkit.org/show_bug.cgi?id=208212
3380
3381         Reviewed by Brady Eidson.
3382
3383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3384         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3385         * WebKitTestRunner/TestController.cpp:
3386         (WTR::TestController::saltForOrigin):
3387
3388 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
3389
3390         Unreviewed, rolling out r257530.
3391
3392         This commit seems to have broke the build internally for
3393         watchOS
3394
3395         Reverted changeset:
3396
3397         "Add SPI to query WKFrameInfos in a WKWebView"
3398         https://bugs.webkit.org/show_bug.cgi?id=208212
3399         https://trac.webkit.org/changeset/257530
3400
3401 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3402
3403         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
3404         https://bugs.webkit.org/show_bug.cgi?id=206894
3405
3406         Reviewed by Adrian Perez de Castro.
3407
3408         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
3409         MiniBrowsers.
3410
3411         * MiniBrowser/gtk/CMakeLists.txt:
3412         * MiniBrowser/win/CMakeLists.txt:
3413         * MiniBrowser/wpe/CMakeLists.txt:
3414
3415 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3416
3417         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
3418         https://bugs.webkit.org/show_bug.cgi?id=206456
3419
3420         Reviewed by Brady Eidson.
3421
3422         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3423         (TEST):
3424
3425 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3426
3427         _WKUserContentWorld should be a wrapper around WKContentWorld
3428         https://bugs.webkit.org/show_bug.cgi?id=208274
3429
3430         Reviewed by Brady Eidson.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
3433         (TEST):
3434         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3435         (TEST):
3436
3437 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
3438
3439         Unreviewed, rolling out r257522.
3440
3441         Caused 16 API test failures on the bots
3442
3443         Reverted changeset:
3444
3445         "TestWebKitAPI and WebKitTestRunner should have bundle
3446         identifiers"
3447         https://bugs.webkit.org/show_bug.cgi?id=208260
3448         https://trac.webkit.org/changeset/257522
3449
3450 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3451
3452         Add SPI to query WKFrameInfos in a WKWebView
3453         https://bugs.webkit.org/show_bug.cgi?id=208212
3454
3455         Reviewed by Brady Eidson.
3456
3457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3458         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3459         * WebKitTestRunner/TestController.cpp:
3460         (WTR::TestController::saltForOrigin):
3461
3462 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3463
3464         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3465         https://bugs.webkit.org/show_bug.cgi?id=208260
3466         <rdar://problem/59820107>
3467
3468         Reviewed by Tim Horton.
3469
3470         Followed instructions for adding an Info.plist for Single-File Tools
3471         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3472
3473         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3474         * TestWebKitAPI/Info.plist: Added.
3475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3476         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3477         * WebKitTestRunner/Info.plist: Added.
3478         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3479
3480 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3481
3482         Tests should each use a unique ResourceLoadStatistics file path for its database store
3483         https://bugs.webkit.org/show_bug.cgi?id=208206
3484         <rdar://problem/59690272>
3485
3486         Reviewed by Brady Eidson.
3487
3488         Initialize a default website data store before checking for the ITP
3489         store to ensure the directory exists after the file has been deleted.
3490
3491         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3492         (TEST):
3493
3494 2020-02-26  Christopher Reid  <chris.reid@sony.com>
3495
3496         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
3497         https://bugs.webkit.org/show_bug.cgi?id=197684
3498         <rdar://problem/59467397>
3499
3500         Reviewed by Yusuke Suzuki.
3501
3502         Add test for FileSystem::createFile
3503
3504         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3505
3506 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
3507
3508         [ews] commit-queue should verify patch committer and reviewer
3509         https://bugs.webkit.org/show_bug.cgi?id=206532
3510
3511         Reviewed by Jonathan Bedard.
3512
3513         * BuildSlaveSupport/ews-build/steps.py:
3514         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
3515         (ValidateCommiterAndReviewer._addToLog):
3516         (ValidateCommiterAndReviewer.getResultSummary):
3517         (ValidateCommiterAndReviewer.fail_build):
3518         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
3519         (ValidateCommiterAndReviewer.is_reviewer):
3520         (ValidateCommiterAndReviewer.is_committer):
3521         (ValidateCommiterAndReviewer.full_name_from_email):
3522         (ValidateCommiterAndReviewer.start):
3523
3524 2020-02-26  Daniel Bates  <dabates@apple.com>
3525
3526         [iOS] Send focus update immediately on becoming or resigning first responder
3527         https://bugs.webkit.org/show_bug.cgi?id=208082
3528         <rdar://problem/59688413>
3529
3530         Rubber-stamped by Jer Noble.
3531
3532         Add a test to ensure that selecting a position at a point after the web view
3533         becomes first responder is allowed. Such an operation is only allowed if the
3534         web view is focused.
3535
3536         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3537         (-[TestWKWebView selectPositionAtPoint:]):
3538         (TEST):
3539         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
3540
3541 2020-02-26  Chris Dumez  <cdumez@apple.com>
3542
3543         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
3544
3545         The test was added for macOS and times out on iOS.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3548         (TEST):
3549
3550 2020-02-26  Youenn Fablet  <youenn@apple.com>
3551
3552         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
3553         https://bugs.webkit.org/show_bug.cgi?id=208238
3554
3555         Reviewed by Eric Carlson.
3556
3557         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3558         (TEST):
3559         Remove use of deleted parameter.
3560
3561 2020-02-25  Devin Rousso  <drousso@apple.com>
3562
3563         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3564         https://bugs.webkit.org/show_bug.cgi?id=206911
3565         <rdar://problem/58026635>
3566
3567         Reviewed by Brian Burg.
3568
3569         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3570         (TestWebKitAPI::TEST):
3571         Add test for `WTF::HashSet::reserveInitialCapacity`.
3572
3573         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3574         (TestWebKitAPI::TEST):
3575         Actually check the value of `WTF::HashMap::capacity`.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3578         (-[InspectorDelegate _webView:didAttachInspector:])
3579         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3580         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3583         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3584         (TestWebKitAPI::TEST): Deleted.
3585
3586 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3587
3588         Add checkout_root to stubrepository.py
3589         https://bugs.webkit.org/show_bug.cgi?id=208213
3590
3591         Reviewed by Jonathan Bedard.
3592
3593         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3594         (StubRepository.__init__):
3595
3596         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3597         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3598
3599 2020-02-25  Daniel Bates  <dabates@apple.com>
3600
3601         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3602         https://bugs.webkit.org/show_bug.cgi?id=208214
3603
3604         Reviewed by Wenson Hsieh.
3605
3606         Wait until the copy operation completes before loading the second web view and testing paste
3607         to ensure that something was actually copied to the clipboard.
3608
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3610         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3611         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3612         so that we wait until the command completes.
3613
3614 2020-02-25  Chris Dumez  <cdumez@apple.com>
3615
3616         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3617         https://bugs.webkit.org/show_bug.cgi?id=208199
3618         <rdar://problem/59746887>
3619
3620         Reviewed by Alex Christensen.
3621
3622         Add API test coverage.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3625         (TEST):
3626
3627 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3628
3629         spinRunLoop should take a non-zero integer as parameter
3630         https://bugs.webkit.org/show_bug.cgi?id=208148
3631         <rdar://problem/59766682>
3632
3633         Unreviewed iOS build fix.
3634
3635         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3636         (TestWebKitAPI::Util::spinRunLoop):
3637
3638 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3639
3640         spinRunLoop should take a non-zero integer as parameter
3641         https://bugs.webkit.org/show_bug.cgi?id=208148
3642
3643         Reviewed by Darin Adler.
3644
3645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3646         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3647         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3648         (TestWebKitAPI::Util::spinRunLoop):
3649
3650 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3651
3652         [WTF] Add tests for CompactRefPtrTuple
3653         https://bugs.webkit.org/show_bug.cgi?id=208172
3654
3655         Reviewed by Darin Adler.
3656
3657         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3658         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3659
3660         * TestWebKitAPI/CMakeLists.txt:
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3663         (TestWebKitAPI::TEST):
3664
3665 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3666
3667         [ews] commit-queue should check that patch have appropriate review flag
3668         https://bugs.webkit.org/show_bug.cgi?id=208138
3669
3670         Reviewed by Jonathan Bedard.
3671
3672         * BuildSlaveSupport/ews-build/steps.py:
3673         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, comm