2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
2
3         Reviewed by Kent Tamura.
4
5         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
6         https://bugs.webkit.org/show_bug.cgi?id=61631
7
8         * Scripts/build-webkit:
9
10 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         Unreviewed. Fix the GTK+ build.
13
14         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
15
16 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
17
18         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
19         works properly).
20
21         * Scripts/webkitpy/common/config/committers.py:
22
23 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
24
25         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
26         WebKit scripts expect, so other scripts work properly with wx.
27
28         * waf/build/build_utils.py:
29         * waf/build/settings.py:
30
31 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
32
33         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
34         to build on Mac.
35
36         * waf/build/settings.py:
37         * wx/install-unix-extras:
38
39 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
40
41         [wx] Unreviewed build fixes for recent trunk changes.
42
43         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
44         (LayoutTestController::setTextDirection):
45         * waf/build/settings.py:
46
47 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
48
49         Fix the GTK+ build.
50
51         * GNUmakefile.am: Add some missing newline escape.
52
53 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
54
55         Try to fix the GTK+ bulid.
56
57         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
58         source list.
59
60 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
61
62         Reviewed by Adam Barth.
63
64         nrwt: should skip chromium test expectation overrides on upstream bots
65         https://bugs.webkit.org/show_bug.cgi?id=61888
66
67         * Scripts/webkitpy/layout_tests/port/chromium.py:
68         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
69
70 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
71
72         Reviewed by Ojan Vafai.
73
74         new-run-webkit-tests: minor logging, code cleanup
75         https://bugs.webkit.org/show_bug.cgi?id=62055
76
77         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
78         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
79
80 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
81
82         Try to fix the build failure on the GTK+ 32-bit Release bot.
83
84         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
85
86 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
87
88         Reviewed by Ryosuke Niwa.
89
90         [GTK] Support smart replace for the pasteboard
91         https://bugs.webkit.org/show_bug.cgi?id=61734
92
93         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
94         This is required to produce consistent test results.
95
96         * DumpRenderTree/gtk/DumpRenderTree.cpp:
97         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
98         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
99         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
100         methods which calls into DumpRenderTreeSupportGtk.
101
102 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
103
104         Reviewed by Dimitri Glazkov.
105
106         Teach Gtk build about window.internals
107         https://bugs.webkit.org/show_bug.cgi?id=61071
108
109         * DumpRenderTree/gtk/DumpRenderTree.cpp:
110         (webViewWindowObjectCleared): Inject the new internals object when the
111         window object clears.
112         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
113         Also do a little bit of cleanup.
114
115 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
116
117         Reviewed by Tony Chang.
118
119         Worker may not be stopped after LT.
120         https://bugs.webkit.org/show_bug.cgi?id=61847
121
122         Re-submit a variant of the first fix for this bug. It's possible
123         that actually calling cleanup() in the worker threads was taking
124         too long and we triggered the assertions in the manager thread.
125
126         I've bumped up the timeout in the manager and added better
127         diagnostics. I also cleaned up the cleanup() code a bit because
128         there was some unnecessary if-checks.
129
130         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
131         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
132
133 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
134
135         Reviewed by Tony Chang.
136
137         nrwt: fix duplicate logging regression
138         https://bugs.webkit.org/show_bug.cgi?id=61981
139
140         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
141
142 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
143
144         Reviewed by Adam Barth.
145
146         Modified addTouchPoint to correctly re-use touchPoint id values starting
147         from the lowest not-un-use touchPoint id as is done by the embedder
148         APIs. (Fixes BUGCR36415)
149
150         https://bugs.webkit.org/show_bug.cgi?id=62016
151
152         * DumpRenderTree/chromium/EventSender.cpp:
153         (EventSender::addTouchPoint):
154
155 2011-06-03  Cary Clark  <caryclark@google.com>
156
157         Reviewed by Eric Seidel.
158
159         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
160         https://bugs.webkit.org/show_bug.cgi?id=61534
161
162         Skia on Mac uses Skia to render WebKit, and CG
163         to render UI elements. The CG elements need a
164         transcribed graphics context that preserves the
165         canvas matrix, and the canvas clip.
166
167         The SkiaBitLocker utility class sets up a CGContext
168         from the SkCanvas, locks the bitmap's bits, and
169         releases the lock when the class goes out of scope.
170
171         The SkiaBitLocker implementation is described by
172         this patch:
173         http://codereview.chromium.org/7031006/
174
175         When WebKit uses Skia for rendering, the WebCanvas
176         is an SkCanvas. Create an equivalent CGContext to
177         draw the scrollbar thumb.
178
179         As the Chrome Mac port does not yet use Skia, this
180         patch has no effect and requires no tests.
181
182         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
183         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
184
185 2011-06-03  Andras Becsi  <abecsi@webkit.org>
186
187         Unreviewed build fix.
188
189         Fix typo.
190
191         * Scripts/old-run-webkit-tests:
192
193 2011-06-03  Andras Becsi  <abecsi@webkit.org>
194
195         Reviewed by Csaba Osztrogonác.
196
197         Print error message when there is no httpd present on the system
198         https://bugs.webkit.org/show_bug.cgi?id=61939
199
200         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
201         * Scripts/webkitperl/httpd.pm:
202
203 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
204
205         Reviewed by Yury Semikhatsky.
206
207         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
208         https://bugs.webkit.org/show_bug.cgi?id=61533
209
210         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
211
212         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
213         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
214         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
215         * DumpRenderTree/chromium/LayoutTestController.cpp:
216         (LayoutTestController::LayoutTestController):
217         (LayoutTestController::setJavaScriptProfilingEnabled):
218         * DumpRenderTree/chromium/LayoutTestController.h:
219         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
220         (LayoutTestController::setJavaScriptProfilingEnabled):
221         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
222         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
223         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
224
225 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
226
227         Reviewed by Tony Chang.
228
229         NRWT needs a way to log to a file without including backspaces without needing --verbose
230         https://bugs.webkit.org/show_bug.cgi?id=60328
231
232         This change modifies NRWT so that if it can tell if it is
233         writing to a terminal, it will overwrite any messages printed
234         in the 'one-line-progress' and 'updates' print options, and if
235         not (or if --verbose was specified) the messages will be printed
236         without backspaces.
237
238         If the overwriting updates are disabled, one-line-progress will
239         only print every 10 seconds instead of on every update. This
240         ensures that we still get updates once in a while while the
241         tests are running, even if we're not in --verbose mode. Note
242         that one-line-progress will now still be printed in --verbose,
243         since it's useful as long as you're not flooded with the
244         updates.
245
246         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
247         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
248         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
249
250 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
251
252         Reviewed by Gustavo Noronha Silva.
253
254         [GTK] autogen.sh is run twice for each buld on the bots
255         https://bugs.webkit.org/show_bug.cgi?id=61951
256
257         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
258         for the WebKit project. This prevents build-jsc runs from forcing subsequent
259         build-webkit runs to re-rerun autogen.sh.
260
261 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
262
263         Unreviewed, rolling out r87946.
264         http://trac.webkit.org/changeset/87946
265         https://bugs.webkit.org/show_bug.cgi?id=61965
266
267         Cause NRWT to break (Requested by abarth|gardener on #webkit).
268
269         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
270
271 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
272
273         Reviewed by Darin Adler.
274
275         Add build logistics and plumbing for window.internals object.
276         https://bugs.webkit.org/show_bug.cgi?id=60313
277
278         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
279         * DumpRenderTree/chromium/TestShell.cpp:
280         (TestShell::bindJSObjectsToWindow): Added injection code.
281         * DumpRenderTree/mac/FrameLoadDelegate.mm:
282         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
283
284 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
285
286         Reviewed by Dirk Pranke.
287
288         Call cleanup() explicitly at the end of worker.run().
289         https://bugs.webkit.org/show_bug.cgi?id=61847
290
291         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
292
293 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
294
295         Unreviewed, rolling out r87926.
296         http://trac.webkit.org/changeset/87926
297         https://bugs.webkit.org/show_bug.cgi?id=60313
298
299         Fails to find WebCoreTestSupport.dylib on bots.
300
301         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
302         * DumpRenderTree/chromium/TestShell.cpp:
303         (TestShell::bindJSObjectsToWindow):
304         * DumpRenderTree/mac/FrameLoadDelegate.mm:
305         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
306
307 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
308
309         Reviewed by Darin Adler.
310
311         Add build logistics and plumbing for window.internals object.
312         https://bugs.webkit.org/show_bug.cgi?id=60313
313
314         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
315         * DumpRenderTree/chromium/TestShell.cpp:
316         (TestShell::bindJSObjectsToWindow): Added injection code.
317         * DumpRenderTree/mac/FrameLoadDelegate.mm:
318         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
319
320 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
321
322         Reviewed by Eric Seidel.
323
324         Adjust efl coding style to more efl directories
325         https://bugs.webkit.org/show_bug.cgi?id=61903
326
327         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
328
329 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
330
331         Reviewed by Tony Chang.
332
333         old-run-webkit-tests: add support for audio files
334         https://bugs.webkit.org/show_bug.cgi?id=57992
335
336         * Scripts/old-run-webkit-tests:
337
338 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
339
340         Reviewed by Adam Barth.
341
342         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
343         https://bugs.webkit.org/show_bug.cgi?id=34314
344
345         * DumpRenderTree/DumpRenderTree.gypi:
346         * DumpRenderTree/chromium/LayoutTestController.cpp:
347         (LayoutTestController::LayoutTestController):
348         (LayoutTestController::setImagesAllowed):
349         (LayoutTestController::setStorageAllowed):
350         * DumpRenderTree/chromium/LayoutTestController.h:
351         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
352         (WebPermissions::WebPermissions):
353         (WebPermissions::~WebPermissions):
354         (WebPermissions::allowImages):
355         (WebPermissions::allowStorage):
356         (WebPermissions::setImagesAllowed):
357         (WebPermissions::setStorageAllowed):
358         (WebPermissions::reset):
359         * DumpRenderTree/chromium/WebPermissions.h:
360
361 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
362
363         Reviewed by Tony Chang.
364
365         Test plugin should support event logging on the windows port.
366         https://bugs.webkit.org/show_bug.cgi?id=61721
367
368         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
369         (handleEventWin): Well, handle them.
370
371 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
372
373         Reviewed by Tony Chang.
374
375         [chromium] Use correct file name for dragging out images.
376         https://bugs.webkit.org/show_bug.cgi?id=24887
377
378         * DumpRenderTree/chromium/EventSender.cpp:
379         (EventSender::EventSender):
380         (EventSender::dumpFilenameBeingDragged):
381         * DumpRenderTree/chromium/EventSender.h:
382
383 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
384
385         Reviewed by Tony Chang.
386
387         nrwt: make webaudio work w/o content-length header
388         https://bugs.webkit.org/show_bug.cgi?id=61819
389
390         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
391         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
392         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
393         * Scripts/webkitpy/layout_tests/port/webkit.py:
394
395 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
396
397         Reviewed by Andreas Kling.
398
399         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
400         https://bugs.webkit.org/show_bug.cgi?id=61802
401
402         Add command line parameter and menu item to MiniBrowser application 
403         enabling use of QGLWidget for browser viewport.
404
405         * MiniBrowser/qt/BrowserWindow.cpp:
406         (BrowserWindow::BrowserWindow):
407         (BrowserWindow::toggleGLViewport):
408         * MiniBrowser/qt/BrowserWindow.h:
409         * MiniBrowser/qt/MiniBrowserApplication.cpp:
410         (MiniBrowserApplication::handleUserOptions):
411         * MiniBrowser/qt/MiniBrowserApplication.h:
412         (WindowOptions::WindowOptions):
413
414 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
415
416         Reviewed by Xan Lopez.
417
418         Print out autogen arguments when they differ from the last set, to help
419         with debugging build issues.
420
421         * Scripts/webkitdirs.pm: Print out previous and current build arguments
422         when they differ.
423
424 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         Reviewed by Martin Robinson.
427
428         [GTK] run-launcher should run MiniBrowser in WebKit2
429         https://bugs.webkit.org/show_bug.cgi?id=61858
430
431         * Scripts/run-launcher: Check whether -2 command line option has
432         been passed and run MiniBrowser instead of GtkLauncher.
433
434 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
435
436         Reviewed by Dirk Pranke.
437
438         Fix exception in verbose printing mode.
439         https://bugs.webkit.org/show_bug.cgi?id=61723
440
441         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
442
443 2011-05-31  Yong Li  <yoli@rim.com>
444
445         Reviewed by Eric Seidel.
446
447         https://bugs.webkit.org/show_bug.cgi?id=54807
448         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
449         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
450         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
451         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
452         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
453         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
454         rule we should have in order to make our code independent from compilers and compiler flags.
455
456         * Scripts/webkitpy/style/checkers/cpp.py:
457
458 2011-05-31  Hironori Bono  <hbono@chromium.org>
459
460         Reviewed by Eric Seidel.
461
462         Add a JavaScript function layoutTestController.setTextDirection().
463         https://bugs.webkit.org/show_bug.cgi?id=50952
464
465         This change adds a new JavaScript function setTextDirection() to the
466         LayoutTestController class of Safari and Chrome to write layout tests
467         that changes the text direction of an editable element.
468
469         * DumpRenderTree/LayoutTestController.cpp:
470         (setTextDirectionCallback):
471         (LayoutTestController::staticFunctions):
472         * DumpRenderTree/LayoutTestController.h:
473         * DumpRenderTree/chromium/LayoutTestController.cpp:
474         (LayoutTestController::LayoutTestController):
475         (LayoutTestController::setTextDirection):
476         * DumpRenderTree/chromium/LayoutTestController.h:
477         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
478         (LayoutTestController::setTextDirection):
479         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
480         (LayoutTestController::setTextDirection):
481         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
482         (LayoutTestController::setTextDirection):
483
484 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
485
486         Reviewed by Simon Hausmann.
487
488         [Qt] User-agent list of Qt test browsers is very outdated
489         https://bugs.webkit.org/show_bug.cgi?id=61531
490
491         The user can edit the user-agent manually, so there's no need to have
492         a super complete and up to date list, but it's nice to have it
493         minimally updated.
494
495         * MiniBrowser/qt/useragentlist.txt:
496         * QtTestBrowser/useragentlist.txt:
497
498 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
499
500         Reviewed by Adam Roben.
501
502         [GTK] [WebKit2] Implement a basic WebKitTestRunner
503         https://bugs.webkit.org/show_bug.cgi?id=57068
504
505         Add an implementation of WebKitTestRunner for GTK+.
506
507         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
508         * Scripts/old-run-webkit-tests: Ditto.
509         * Scripts/run-launcher: Ditto.
510         * Scripts/webkitdirs.pm: Ditto.
511         * WebKitTestRunner/GNUmakefile.am: Added.
512         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
513         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
514         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
515         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
516         * WebKitTestRunner/PlatformWebView.h:
517         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
518         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
519         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
520         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
521         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
522         (main): Added.
523
524 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
525
526         Reviewed by Tony Chang.
527
528         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
529         https://bugs.webkit.org/show_bug.cgi?id=60241
530
531         * Scripts/new-run-webkit-tests:
532
533 2011-05-31  Eric Seidel  <eric@webkit.org>
534
535         Reviewed by David Kilzer.
536
537         webkitpy should create zips with zip -9
538         https://bugs.webkit.org/show_bug.cgi?id=61789
539
540         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
541
542         * Scripts/webkitpy/common/system/workspace.py:
543         * Scripts/webkitpy/common/system/workspace_unittest.py:
544
545 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
546
547         Reviewed by Csaba Osztrogonác.
548
549         [Qt] Implement find feature for QtTestBrowser
550         https://bugs.webkit.org/show_bug.cgi?id=61425
551
552         Buildfix for --minimal and CONFIG+=qt_minimal build.
553
554         * QtTestBrowser/launcherwindow.cpp:
555         (LauncherWindow::LauncherWindow):
556         (LauncherWindow::createChrome):
557         * QtTestBrowser/launcherwindow.h:
558
559 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
560
561         Reviewed by Csaba Osztrogonác.
562
563         [Qt] Implement find feature for QtTestBrowser
564         https://bugs.webkit.org/show_bug.cgi?id=61425
565
566         * QtTestBrowser/launcherwindow.cpp:
567         (LauncherWindow::LauncherWindow):
568         (LauncherWindow::createChrome):
569         (LauncherWindow::showFindBar):
570         (LauncherWindow::find):
571         * QtTestBrowser/launcherwindow.h:
572
573 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
574
575         Reviewed by Martin Robinson.
576
577         [GTK] Implement JavaScript dialogs in MiniBrowser
578         https://bugs.webkit.org/show_bug.cgi?id=61725
579
580         * MiniBrowser/gtk/BrowserWindow.c:
581         (WKStringGetCString): Helper function to get a UTF-8 c string from
582         a WKStringRef.
583         (WKURLGetCString): Helper function to get a UTF-8 c string from a
584         WKURLRef.
585         (browserWindowUpdateURL): Update to use WKURLGetCString.
586         (didReceiveTitleForFrame): Update to use WKStringGetCString.
587         (createMessageDialog): Create a GtkMessageDialog.
588         (runJavaScriptAlert):
589         (runJavaScriptConfirm):
590         (runJavaScriptPrompt):
591         (browserWindowUIClientInit):
592
593 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
594
595         Reviewed by Kent Tamura.
596
597         WebSocket closing handshake
598         https://bugs.webkit.org/show_bug.cgi?id=35721
599
600         * Scripts/webkitpy/thirdparty/__init__.py:
601         Pull in pywebsocket 0.6b1. We need to update pywebsocket
602         to get the right behavior of closing handshake.
603
604 2011-05-29  Daniel Bates  <dbates@rim.com>
605
606         Reviewed by David Kilzer.
607
608         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
609         https://bugs.webkit.org/show_bug.cgi?id=61162
610
611         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
612         that omits a line count. In particular, the chunk range regular expression does
613         not match a chunk range line that omits a line count. GNU diff(1) will omit the
614         line count in the chunk range if the line count is exactly 1. For example, appending
615         a new line to the end of an existing file F that contains exactly one line of text will
616         be represented in a diff with a chunk range line that omits the line count for F.
617
618         * Scripts/VCSUtils.pm:
619           (parseChunkRange): Added.
620         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
621         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
622           - Added unit test "Git: Append new line to the end of an existing file".
623
624 2011-05-28  Adam Barth  <abarth@webkit.org>
625
626         Reviewed by Eric Seidel.
627
628         EWS builds patches that fail to build twice, which seems useless and slows down the bots
629         https://bugs.webkit.org/show_bug.cgi?id=55585
630
631         This patch switches all the early warning system bots over to the new
632         PatchAnalysisTask-based infrastructure.  This patch makes these bots
633         more efficient (in the case where patches fail to build) and paves the
634         way for running tests on these bots!
635
636         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
637         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
638         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
639         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
640         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
641         * Scripts/webkitpy/tool/commands/queues.py:
642
643 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
644
645         Reviewed by Kent Tamura.
646
647         Add bashi as a committer.
648
649         https://bugs.webkit.org/show_bug.cgi?id=61685
650
651         * Scripts/webkitpy/common/config/committers.py:
652
653 2011-05-27  Adam Barth  <abarth@webkit.org>
654
655         Reviewed by Eric Seidel.
656
657         When checking whether the tree is red, the EWS posts a link to the wrong log
658         https://bugs.webkit.org/show_bug.cgi?id=61072
659
660         We need to cache the original script error because that contains the
661         failure log we want to upload.  If we don't cache that script error,
662         self._script_error will get overwritten when we sanity check the clean
663         tree (and it also has test failures).
664
665         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
666             - This testing approach is slightly goofy.  We'd like to use
667               assertRaisesRegexp, but that's not available until Python 2.7.
668         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
669
670 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
671
672         Reviewed by Adam Barth.
673
674         Add layoutTestController.setStorageAllowed() to control whether access
675         to the localStorage API is enabled via the WebPermissionClient
676         https://bugs.webkit.org/show_bug.cgi?id=61581
677
678         * DumpRenderTree/chromium/LayoutTestController.cpp:
679         (LayoutTestController::LayoutTestController):
680         (LayoutTestController::setStorageAllowed):
681         * DumpRenderTree/chromium/LayoutTestController.h:
682         * DumpRenderTree/chromium/TestShell.cpp:
683         (TestShell::TestShell):
684         (TestShell::createNewWindow):
685         * DumpRenderTree/chromium/TestShell.h:
686         * DumpRenderTree/chromium/WebPermissions.h: Added.
687         (WebPermissions::WebPermissions):
688         (WebPermissions::allowStorage):
689         (WebPermissions::setStorageAllowed):
690         (WebPermissions::reset):
691
692 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
693
694         Reviewed by Eric Seidel.
695
696         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
697         https://bugs.webkit.org/show_bug.cgi?id=60326
698
699         This patch removes a lot of the complexity from the
700         metered_stream implementation that was unnecessary since there
701         was only one caller and the logic could be coordinated better.
702
703         There should be no functional changes in this patch, just code
704         getting deleted and cleaned up.
705
706         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
707         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
708         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
709         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
710
711 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
712
713         Reviewed by Eric Seidel.
714
715         NRWT: minor cleanup in printing module
716         https://bugs.webkit.org/show_bug.cgi?id=60329
717
718         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
719
720 2011-05-27  Steve Lacey  <sjl@chromium.org>
721
722         Reviewed by David Levin.
723
724         Add sjl@chromium.org as a committer.
725
726         https://bugs.webkit.org/show_bug.cgi?id=61672
727
728         * Scripts/webkitpy/common/config/committers.py:
729
730 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
731
732         Reviewed by Adam Barth.
733
734         NRWT: remove --print detailed-progress
735         https://bugs.webkit.org/show_bug.cgi?id=60324
736
737         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
738         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
739         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
740         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
741
742 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
743
744         Reviewed by Ojan Vafai.
745
746         NRWT: debug messages from the workers are being logged twice
747         https://bugs.webkit.org/show_bug.cgi?id=60428
748
749         It looks like when the workers are run in separate processes
750         we end up getting two copies of every log message they print.
751         This has to do with the multiprocessing module on UNIX cloning
752         the log configuration in a way I wasn't expecting, and so two
753         log handlers end up getting registered.
754
755         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
756         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
757         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
758         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
759
760 2011-05-27  Adam Roben  <aroben@apple.com>
761
762         Always decode tester names from location.hash
763
764         When navigating directly to a tester-specific URL (e.g.,
765         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
766         with a URL-encoded tester name in the page, and then the encoded name could make its way
767         into Bugzilla bugs. Bad!
768
769         Reviewed by David Kilzer.
770
771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
772         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
773         decodeURIComponent before trying to use it.
774
775 2011-05-27  Adam Roben  <aroben@apple.com>
776
777         Remove testing code that snuck into r87528
778
779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
780         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
781
782 2011-05-27  Adam Roben  <aroben@apple.com>
783
784         Add links to TestFailures to easily file bugs about failing tests
785
786         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
787         links to file bugs for failing tests
788
789         Reviewed by David Kilzer.
790
791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
792         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
793         for a particular build.
794         (Builder.prototype._getFailingTests): Use resultsPageURL.
795
796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
797         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
798         failures.
799         (ViewController.prototype._domForBuildName): Use resultsPageURL.
800         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
801         new bug link. The bug has a title, description, and URL already filled in for you!
802
803 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
804
805         Unreviewed, rolling out r87464.
806         http://trac.webkit.org/changeset/87464
807         https://bugs.webkit.org/show_bug.cgi?id=61643
808
809         client-close/server-close tests are flaky on Chromium Mac and
810         Windows (Requested by aklein on #webkit).
811
812         * Scripts/webkitpy/thirdparty/__init__.py:
813
814 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
815
816         Added Douglas Davidson to contributors list for easier CC'ing.
817
818         * Scripts/webkitpy/common/config/committers.py:
819
820 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
821
822         Reviewed by Adam Barth.
823
824         Fix worldID and destinationDomain argument names
825         https://bugs.webkit.org/show_bug.cgi?id=61571
826
827         As part of working on r87423, I noticed a couple of inconsistencies in
828         argument names:
829         - We would use worldId in .h files but worldID in .cpp files.
830           Standardize on the latter
831         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
832           destinationDomains argument, even though the actual parameter was for
833           a single domain (renamed to be singular).
834
835         * DumpRenderTree/LayoutTestController.h:
836         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
837         (LayoutTestController::evaluateScriptInIsolatedWorld):
838
839 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
840
841         Reviewed by Kent Tamura.
842
843         WebSocket closing handshake
844         https://bugs.webkit.org/show_bug.cgi?id=35721
845
846         * Scripts/webkitpy/thirdparty/__init__.py:
847         Pull in pywebsocket 0.6b1. We need to update pywebsocket
848         to get the right behavior of closing handshake.
849
850 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
851
852         Reviewed by Andreas Kling.
853
854         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
855         https://bugs.webkit.org/show_bug.cgi?id=42676
856
857         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
858
859         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
860         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
861         (WTR::InjectedBundle::beginTesting):
862         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
863         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
864         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
865
866 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
867
868         Reviewed by Andreas Kling.
869
870         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
871         https://bugs.webkit.org/show_bug.cgi?id=61527
872
873         The setMaximumHeight() call is unecessary and breaks the dialog at
874         least on my setup.
875
876         * QtTestBrowser/launcherwindow.cpp:
877         (LauncherWindow::showUserAgentDialog):
878
879 2011-05-02  Robert Hogan  <robert@webkit.org>
880
881         Reviewed by Adam Roben.
882
883         [Qt] Allow popup windows from plugins when initiated by a user gesture
884
885         https://bugs.webkit.org/show_bug.cgi?id=41292
886
887         Support parameters introduced in plugin-initiate-popup-window.html
888
889         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
890         (webkit_test_plugin_new_instance):
891         (webkit_test_plugin_handle_event):
892
893 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
894
895         Reviewed by Adam Barth.
896
897         Support cross-origin XMLHttpRequest in isolated worlds
898         https://bugs.webkit.org/show_bug.cgi?id=59843
899
900         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
901
902         * DumpRenderTree/chromium/LayoutTestController.cpp:
903         (LayoutTestController::LayoutTestController):
904         (LayoutTestController::setIsolatedWorldSecurityOrigin):
905         * DumpRenderTree/chromium/LayoutTestController.h:
906
907 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
908
909         Reviewed by Adam Roben.
910
911         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
912         https://bugs.webkit.org/show_bug.cgi?id=61474
913         <rdar://problem/9468337>
914
915         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
916         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
917
918 2011-05-26  Andreas Kling  <kling@webkit.org>
919
920         Unreviewed, correct address to webkit-committers mailing list.
921
922         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
923
924 2011-05-25  Adam Roben  <aroben@apple.com>
925
926         Don't assume that builds finish in the order they were started
927
928         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
929         build when one slave is taking a long time to finish a build
930
931         Reviewed by Antti Koivisto.
932
933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
934         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
935         newer than the oldest in-progress build are also themselves in progress. Just check whether
936         each build is actually in progress (as signified by its presence in the currentBuilds set).
937
938 2011-05-25  Adam Roben  <aroben@apple.com>
939
940         Correctly detect cases where only a single test failed/crashed/timed out
941
942         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
943         failing test
944
945         Reviewed by Darin Adler.
946
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
948         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
949         will be singular when only a single test fails/crashes/times out.
950
951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
952         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
953         failed/crashed/timed out.
954
955 2011-05-26  Tom Hudson  <tomhudson@google.com>
956
957         Reviewed by Tony Chang.
958
959         Add flags to Chromium ImageDiff to write image comparison metrics on
960         stdout.
961         https://bugs.webkit.org/show_bug.cgi?id=60569
962
963         * DumpRenderTree/chromium/ImageDiff.cpp:
964         (Image::createFromStdin): Fix spelling.
965         (maxOf3): New function to do 3-way maximum.
966         (getRedComponent): Extract red component from ABGR packed encoding.
967         (getGreenComponent): Extract green component from ABGR packed encoding.
968         (getBlueComponent): Extract blue component from ABGR packed encoding.
969         (weightedPercentageDifferent): Determine % of pixels different in two
970         images multiplied by intensity difference of each pixel.
971         (printHelp): Document new arguments.
972         (compareImages): Parameterize.
973         (untestedCompareImages): Parameterize.
974         (diffImages): Parameterize; write results on stdout if requested.
975         (main): Parse new arguments.
976
977 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
978
979         Reviewed by Simon Hausmann.
980
981         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
982         https://bugs.webkit.org/show_bug.cgi?id=42697
983
984         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
985
986         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
987         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
988         (WTR::InjectedBundle::beginTesting):
989         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
990         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
991         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
992
993 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
994
995         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
996         https://bugs.webkit.org/show_bug.cgi?id=61428
997         <rdar://problem/9457006>
998
999         Reviewed by Adam Roben.
1000
1001         The crash occurs when Flash posts a message to a window that it
1002         creates, and in processing the message, it calls NPN_Evaluate to
1003         evaluate JavaScript that removes the plug-in from the page. Flash then
1004         crashes when we return to Flash code.
1005
1006         This test emulates that behavior.
1007
1008         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1009         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1010         Initialize member vars.
1011         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1012         Remove our custom property from the message window, and destroy it.
1013         (CallJSThatDestroysPlugin::NPP_Destroy):
1014         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1015         layout test controller that we're done.
1016         (wndProc):
1017         Get the PluginTest object, and call its runTest() function.
1018         (CallJSThatDestroysPlugin::NPP_New):
1019         Setup the test: register a class for the message-only window, create
1020         it, and post a message to it to run the test.
1021         (CallJSThatDestroysPlugin::runTest):
1022         Execute JS that removes the plug-in from the page, and if we're not
1023         destroyed, log a success message.
1024
1025         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1026         Add new test to project.
1027
1028 2011-05-25  Tony Chang  <tony@chromium.org>
1029
1030         Reviewed by Adam Barth.
1031
1032         webkitpy's NetworkTransaction shouldn't use mechanize
1033         https://bugs.webkit.org/show_bug.cgi?id=61450
1034
1035         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1036         use urllib2 directly.  Re-add NetworkTransaction to
1037         test_results_uploader.py (reverting r87124).
1038
1039         * Scripts/webkitpy/common/net/networktransaction.py:
1040         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1041
1042 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1043
1044         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1045         until the port begins using those export macros.
1046
1047         * DumpRenderTree/chromium/config.h:
1048
1049 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1050
1051         Unreviewed, rolling out r87257.
1052         http://trac.webkit.org/changeset/87257
1053         https://bugs.webkit.org/show_bug.cgi?id=61457
1054
1055         This broke layout tests, see bug 61431. (Requested by
1056         hwennborg on #webkit).
1057
1058         * DumpRenderTree/chromium/LayoutTestController.cpp:
1059         (LayoutTestController::LayoutTestController):
1060         (LayoutTestController::clearAllDatabases):
1061         * DumpRenderTree/chromium/LayoutTestController.h:
1062
1063 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1064
1065         Reviewed by Andreas Kling.
1066
1067         [Qt] fast/css/disabled-author-styles.html failed
1068         https://bugs.webkit.org/show_bug.cgi?id=61438
1069
1070         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1071
1072         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1073         (WebCore::WebPage::resetSettings):
1074         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1075         (LayoutTestController::setAuthorAndUserStylesEnabled):
1076         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1077
1078 2011-05-25  Adam Roben  <aroben@apple.com>
1079
1080         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1081
1082         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1083         started exiting early due to too many crashes, timeouts, or failures
1084
1085         Reviewed by David Kilzer.
1086
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1088         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1089         run-webkit-tests exits early due to too many failures, pass that information in another
1090         argument to the callback.
1091         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1092         the new structure of the object passed to the callback.
1093         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1094         getNumberOfFailingTests and to pass that along to our own callbacks.
1095         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1096         from _getFailingTests and to store that value in the history object.
1097
1098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1099         (.info): Added.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1102         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1103         object and to add a note when run-webkit-tests exited early due to too many failures.
1104         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1105         latestBuildInfos since each entry now contains more than just the tester and failure count.
1106         Now displays a message for testers where the latest build exited early due to too many
1107         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1108         store that value in latestBuildInfos.
1109
1110 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1111
1112         Reviewed by Kent Tamura.
1113
1114         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1115         https://bugs.webkit.org/show_bug.cgi?id=61273
1116
1117         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1118
1119 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1120
1121         Reviewed by Dimitri Glazkov.
1122
1123         Control Indexeddb backends from LayoutTestController
1124         https://bugs.webkit.org/show_bug.cgi?id=61000
1125
1126         * DumpRenderTree/chromium/LayoutTestController.cpp:
1127         (LayoutTestController::LayoutTestController):
1128         (LayoutTestController::setOverrideIndexedDBBackingStore):
1129         (LayoutTestController::clearAllDatabases):
1130         * DumpRenderTree/chromium/LayoutTestController.h:
1131
1132 2011-05-24  Robert Hogan  <robert@webkit.org>
1133
1134         Reviewed by Ryosuke Niwa.
1135
1136         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1137         https://bugs.webkit.org/show_bug.cgi?id=61393
1138
1139         * DumpRenderTree/qt/EventSenderQt.h:
1140         * DumpRenderTree/qt/EventSenderQt.cpp:
1141         (getModifiers): static function for interpreting modifiers
1142         (EventSender::mouseDown): Respect keyboard modifiers
1143         (EventSender::keyDown): use new static function
1144         (EventSender::sendOrQueueEvent): whitespace fix
1145
1146 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1147
1148         Reviewed by Adam Barth.
1149
1150         Adding MHTML reading support.
1151         https://bugs.webkit.org/show_bug.cgi?id=7168
1152
1153         * Scripts/build-webkit:
1154         * Scripts/old-run-webkit-tests:
1155         * Scripts/webkitperl/features.pm:
1156         * Scripts/webkitpy/layout_tests/port/test_files.py:
1157         * Scripts/webkitpy/layout_tests/port/webkit.py:
1158
1159 2011-05-24  Stephen White  <senorblanco@chromium.org>
1160
1161         Reviewed by Kenneth Russell.
1162
1163         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1164         follow WebKit style.
1165         https://bugs.webkit.org/show_bug.cgi?id=61365
1166
1167         * Scripts/webkitpy/style/checker.py:
1168
1169 2011-05-24  Adam Roben  <aroben@apple.com>
1170
1171         Don't allow forcing builds through the build.webkit.org web interface
1172
1173         Someone has been forcing bogus builds.
1174
1175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1176
1177 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1178
1179         Reviewed by Adam Roben.
1180
1181         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1182         https://bugs.webkit.org/show_bug.cgi?id=42669
1183
1184         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1185         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1186         Because that case changed the setting.
1187
1188         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1189         (WTR::InjectedBundle::beginTesting):
1190
1191 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1192
1193         Reviewed by Kenneth Rohde Christiansen.
1194
1195         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1196         https://bugs.webkit.org/show_bug.cgi?id=61052
1197
1198         * Scripts/old-run-webkit-tests:
1199
1200 2011-05-24  Adam Roben  <aroben@apple.com>
1201
1202         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1203
1204         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1205         that don't have any failing tests, which isn't useful
1206
1207         Reviewed by David Kilzer.
1208
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1210         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1211         instead of name strings.
1212         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1213         builder names into an array of builders.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1216         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1217         the most recently completed build, or -1 if there is no such build.
1218         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1219         in the given build, or -1 if the number could not be determined. Some of this code came from
1220         _getFailingTests.
1221         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1222         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1223         getNumberOfFailingTests functions.
1224
1225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1226         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1227         tester and show it in the list. Omit testers that have no failures at all. We keep the
1228         testers and failure counts in an array and sort it before displaying the current data, as
1229         the order in which data will be fetched is unpredictable.
1230
1231 2011-05-23  Tony Chang  <tony@chromium.org>
1232
1233         Reviewed by Ojan Vafai.
1234
1235         [nrwt] don't use NetworkTranslation when uploading results
1236         https://bugs.webkit.org/show_bug.cgi?id=61315
1237
1238         This avoids autoinstalling mechanize.  It didn't matter anyway
1239         because test_results_uploader.py wasn't using mechanize to make the
1240         request so NetworkTransaction::run wasn't doing anything extra
1241         (it only matters if it catches mechanize.HTTPError).
1242
1243         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1244
1245 2011-05-23  Tony Chang  <tony@chromium.org>
1246
1247         Reviewed by Dirk Pranke.
1248
1249         [chromium] fix the rebaseline tool to work with Linux GPU failures
1250         https://bugs.webkit.org/show_bug.cgi?id=61312
1251
1252         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1253
1254 2011-05-23  Darin Adler  <darin@apple.com>
1255
1256         Ignore generated .pyc files in a directory full of python code.
1257
1258         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
1259
1260 2011-05-23  Adam Barth  <abarth@webkit.org>
1261
1262         Reviewed by Eric Seidel.
1263
1264         sheriffbot should give more details about the failures in IRC
1265         https://bugs.webkit.org/show_bug.cgi?id=61233
1266
1267         With this patch, sheriffbot will annonce the set of failing tests,
1268         which might help folks triage the problem.
1269
1270         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1271         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1272
1273 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1274
1275         Unreviewed, rolling out r87078.
1276         http://trac.webkit.org/changeset/87078
1277         https://bugs.webkit.org/show_bug.cgi?id=61294
1278
1279         Patch contains errors and seems likely to break a bunch of
1280         bots (Requested by abarth on #webkit).
1281
1282         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1283         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1284         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1285
1286 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
1287
1288         Reviewed by Ojan Vafai.
1289
1290         Convert json_results_generator.py to output version 4 JSON.
1291         https://bugs.webkit.org/show_bug.cgi?id=60869
1292
1293         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1294         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1295         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1296
1297 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
1298
1299         Reviewed by Adam Barth.
1300
1301         Move generation of shell_command from port to executive
1302         https://bugs.webkit.org/show_bug.cgi?id=61251
1303
1304         After move it's possible to use the code in other places too.
1305
1306         * Scripts/webkitpy/common/config/ports.py:
1307         * Scripts/webkitpy/common/system/executive.py:
1308
1309 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
1310
1311         Reviewed by Darin Adler.
1312
1313         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1314         https://bugs.webkit.org/show_bug.cgi?id=42669
1315
1316         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
1317
1318         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1319         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1320         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
1321         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1322
1323 2011-05-22  Robert Hogan  <robert@webkit.org>
1324
1325         Reviewed by Kenneth Rohde Christiansen.
1326
1327         Fix policyDelegate in Qt DRT
1328         https://bugs.webkit.org/show_bug.cgi?id=61247
1329
1330         Use the 'policy delegate' implemented in FrameLoaderClient
1331         for layout tests. The partial implementation in DumpRenderTreeQt
1332         is redundant, so remove it.
1333
1334         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1335         (WebCore::WebPage::acceptNavigationRequest):
1336         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1337         (LayoutTestController::waitForPolicyDelegate):
1338
1339 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
1340
1341         Reviewed by Darin Adler.
1342
1343         Use double quotes for filename arguments
1344         https://bugs.webkit.org/show_bug.cgi?id=61250
1345
1346         Windows does not support single quotes on the command line,
1347         so replace them with double quotes.
1348
1349         * Scripts/prepare-ChangeLog:
1350
1351 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1352
1353         Reviewed by Sam Weinig.
1354
1355         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
1356         https://bugs.webkit.org/show_bug.cgi?id=42550
1357         
1358         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
1359
1360         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1361         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1362         Copy the code for pausing animations, FIXME comments and all.
1363         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1364         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1365
1366 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
1367
1368         Reviewed by Stephen White.
1369
1370         Adding myself to the committers list.
1371
1372         * Scripts/webkitpy/common/config/committers.py:
1373
1374 2011-05-19  Adam Roben  <aroben@apple.com>
1375
1376         Test that the WebKit2 UI process doesn't crash when starting a download
1377
1378         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1379         (preceded by assertion) in fastMalloc when downloading a file
1380
1381         Reviewed by Darin Adler.
1382
1383         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1384
1385         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1386         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1387         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1388         started, cancel the download, and return a bogus string.
1389
1390         (TestWebKitAPI::setContextDownloadClient):
1391         (TestWebKitAPI::setPagePolicyClient):
1392         Simple helper functions.
1393
1394         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1395         our policy client, and run until we know that the download was started. If we haven't
1396         crashed, we win!
1397
1398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1399         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1400         * TestWebKitAPI/win/copy-resources.cmd:
1401         Added new files.
1402
1403 2011-05-20  Kent Tamura  <tkent@chromium.org>
1404
1405         Reviewed by Ryosuke Niwa.
1406
1407         Fix style errors in DumpRenderTree/chromium/.
1408         https://bugs.webkit.org/show_bug.cgi?id=61172
1409
1410         * DumpRenderTree/chromium/CppBoundClass.cpp:
1411         (CppBoundClass::getAsCppVariant):
1412         (CppBoundClass::bindToJavascript):
1413         * DumpRenderTree/chromium/CppBoundClass.h:
1414         (CppBoundClass::GetterCallback::~GetterCallback):
1415         (CppBoundClass::CppBoundClass):
1416         (CppBoundClass::Callback::~Callback):
1417         (CppBoundClass::MemberCallback::MemberCallback):
1418         (CppBoundClass::MemberCallback::~MemberCallback):
1419         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1420         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1421         * DumpRenderTree/chromium/CppVariant.h:
1422         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1423         (DRTDevToolsAgent::~DRTDevToolsAgent):
1424         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1425         (DRTDevToolsClient::sendFrontendLoaded):
1426         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1427         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1428         (main):
1429         * DumpRenderTree/chromium/EventSender.cpp:
1430         (SavedEvent::SavedEvent):
1431         (EventSender::EventSender):
1432         (EventSender::keyDown):
1433         * DumpRenderTree/chromium/EventSender.h:
1434         * DumpRenderTree/chromium/ImageDiff.cpp:
1435         (Image::Image):
1436         * DumpRenderTree/chromium/LayoutTestController.cpp:
1437         (LayoutTestController::LayoutTestController):
1438         (LayoutTestController::WorkQueue::reset):
1439         (WorkItemBackForward::WorkItemBackForward):
1440         (WorkItemLoadingScript::WorkItemLoadingScript):
1441         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1442         (WorkItemLoad::WorkItemLoad):
1443         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1444         (LayoutTestController::pathToLocalResource):
1445         * DumpRenderTree/chromium/LayoutTestController.h:
1446         (LayoutTestController::WorkItem::~WorkItem):
1447         (LayoutTestController::WorkQueue::WorkQueue):
1448         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1449         (MockSpellCheck::MockSpellCheck):
1450         (MockSpellCheck::~MockSpellCheck):
1451         * DumpRenderTree/chromium/MockSpellCheck.h:
1452         * DumpRenderTree/chromium/NotificationPresenter.h:
1453         (NotificationPresenter::NotificationPresenter):
1454         * DumpRenderTree/chromium/Task.cpp:
1455         (WebTask::WebTask):
1456         * DumpRenderTree/chromium/Task.h:
1457         (TaskList::TaskList):
1458         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1459         (DRTPrinter::DRTPrinter):
1460         (TestShellPrinter::TestShellPrinter):
1461         * DumpRenderTree/chromium/TestNavigationController.cpp:
1462         (TestNavigationEntry::TestNavigationEntry):
1463         (TestNavigationEntry::~TestNavigationEntry):
1464         (TestNavigationController::TestNavigationController):
1465         (TestNavigationController::reload):
1466         (TestNavigationController::loadEntry):
1467         (TestNavigationController::didNavigateToEntry):
1468         * DumpRenderTree/chromium/TestNavigationController.h:
1469         (TestShellExtraData::TestShellExtraData):
1470         * DumpRenderTree/chromium/TestShell.cpp:
1471         (dumpHistoryItem):
1472         * DumpRenderTree/chromium/TestShell.h:
1473         (TestParams::TestParams):
1474         * DumpRenderTree/chromium/TestShellWin.cpp:
1475         (TestShell::waitTestFinished):
1476         * DumpRenderTree/chromium/TestWebWorker.h:
1477         (TestWebWorker::startWorkerContext):
1478         (TestWebWorker::terminateWorkerContext):
1479         (TestWebWorker::postMessageToWorkerContext):
1480         (TestWebWorker::clientDestroyed):
1481         (TestWebWorker::postMessageToWorkerObject):
1482         (TestWebWorker::postExceptionToWorkerObject):
1483         (TestWebWorker::postConsoleMessageToWorkerObject):
1484         (TestWebWorker::confirmMessageFromWorkerObject):
1485         (TestWebWorker::reportPendingActivity):
1486         (TestWebWorker::workerContextClosed):
1487         (TestWebWorker::~TestWebWorker):
1488         * DumpRenderTree/chromium/TextInputController.cpp:
1489         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1490         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1491         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1492         (WebThemeEngineDRTWin::paintButton):
1493         (WebThemeEngineDRTWin::paintMenuList):
1494         (WebThemeEngineDRTWin::paintTrackbar):
1495         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1496         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1497         * DumpRenderTree/chromium/WebViewHost.cpp:
1498         (WebViewHost::navigate):
1499         (WebViewHost::updateSessionHistory):
1500         (WebViewHost::paintInvalidatedRegion):
1501         * DumpRenderTree/chromium/WebViewHost.h:
1502
1503 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1504
1505         Reviewed by Adam Roben.
1506
1507         Detect hangs in run-api-tests
1508         https://bugs.webkit.org/show_bug.cgi?id=48043
1509
1510         * Scripts/run-api-tests: Added test timeouts
1511
1512 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1513
1514         Reviewed by Adam Roben.
1515
1516         run-api-tests should run one test per process
1517         https://bugs.webkit.org/show_bug.cgi?id=61088
1518
1519         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1520         return code, and parsing GTest output format.
1521
1522 2011-05-15  Robert Hogan  <robert@webkit.org>
1523
1524         Reviewed by Antonio Gomes.
1525
1526         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1527         https://bugs.webkit.org/show_bug.cgi?id=60834
1528         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1529
1530         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1531         (webkit_test_plugin_new_stream):
1532         (webkit_test_plugin_write_ready):
1533         (webkit_test_plugin_write):
1534
1535 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1536
1537         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1538         http://trac.webkit.org/changeset/86869
1539         http://trac.webkit.org/changeset/86873
1540         http://trac.webkit.org/changeset/86875
1541         http://trac.webkit.org/changeset/86877
1542         https://bugs.webkit.org/show_bug.cgi?id=61139
1543
1544         broke builds and debug DRT (Requested by rniwa on #webkit).
1545
1546         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1547         * DumpRenderTree/chromium/TestShell.cpp:
1548         (TestShell::bindJSObjectsToWindow):
1549         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1550         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1551
1552 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1553
1554         Reviewed by Darin Adler.
1555
1556         Add build logistics and plumbing for window.internals object.
1557         https://bugs.webkit.org/show_bug.cgi?id=60313
1558
1559         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1560         * DumpRenderTree/chromium/TestShell.cpp:
1561         (TestShell::bindJSObjectsToWindow): Added injection code.
1562         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1563         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1564
1565 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1566
1567         Reviewed by Csaba Osztrogonác.
1568
1569         [Qt] Implement eventSender.scalePageBy
1570         https://bugs.webkit.org/show_bug.cgi?id=60015
1571
1572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1573         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1574         * DumpRenderTree/qt/EventSenderQt.cpp:
1575         (EventSender::scalePageBy):
1576         * DumpRenderTree/qt/EventSenderQt.h:
1577
1578 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
1579
1580         Reviewed by Kent Tamura.
1581
1582         [Chromium] IME candidate window appears wrong position in an iframe
1583         https://bugs.webkit.org/show_bug.cgi?id=61023
1584
1585         Call the focused frame's firstRectForCharacterRange() instead of the
1586         main frame so that DRT behaves as the same as Chromium.
1587
1588         * DumpRenderTree/chromium/TextInputController.cpp:
1589         (TextInputController::firstRectForCharacterRange):
1590
1591 2011-05-18  Adam Roben  <aroben@apple.com>
1592
1593         Add a new page to build.webkit.org to help find when tests started failing
1594
1595         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
1596         right now, but already shows some useful information. It's somewhat similar to webkit-patch
1597         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
1598         little more convenient than either of them, though, because it's all done in the browser
1599         (and thus it's easy to go directly to the relevant test results).
1600
1601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
1602         (Buildbot): This class represents a Buildbot server.
1603         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
1604         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
1605         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
1606         callback.
1607         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
1608         be implemented by a derived class that understands this server's build naming scheme.
1609         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1610         particular build.
1611
1612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
1613         (Builder): This class represents one builder on the buildbot.
1614         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
1615         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
1616         information about a particular test failure.
1617         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
1618         information about when tests started failing.
1619         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1620         particular build.
1621         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
1622         callback.
1623         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
1624         extracts all the failing tests listed in it, passing them to the callback.
1625         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
1626         build, merges them into the build history, and calls the callback telling it whether the
1627         next build should be fetched to provide more information.
1628
1629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1630         Added. Just some simple styles.
1631
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
1633         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
1634         (getResource): Wrapper around XMLHttpRequest.
1635         (Array.prototype.findFirst): Finds the first element matching the given predicate and
1636         returns it.
1637         (Array.prototype.last): Returns the last element of the array.
1638
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
1640         (ViewController): This class contains the main logic for displaying the page.
1641         (ViewController.loaded): Just calls through to parseHash.
1642         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
1643         shows the list of all testers so one can be chosen. This function is called when the page
1644         loads and whenever we get a hashchange event.
1645         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
1646         as it is fetched. The display ends up grouping tests by when they started failing.
1647         (ViewController._displayTesters): Gets the list of testers and displays it.
1648
1649         (ViewController._domForBuildName):
1650         (ViewController._domForFailedTest):
1651         Helper functions to create descriptions and links for a particular build or failed test.
1652
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
1654         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
1655         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
1656
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
1658         loads all the files and sets up a ViewController, which does the rest.
1659
1660         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
1661         page.
1662
1663 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1664
1665         Reviewed by Csaba Osztrogonác.
1666
1667         [Qt] Implement layoutTestController.setValueForUser()
1668         https://bugs.webkit.org/show_bug.cgi?id=60956
1669
1670         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1671         (LayoutTestController::setValueForUser):
1672         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1673
1674 2011-05-16  Robert Hogan  <robert@webkit.org>
1675
1676         Reviewed by Kenneth Rohde Christiansen.
1677
1678         plugins/invalidate_rect.html fails on linux ports
1679
1680         - Make the unix test netscape plugin recognize the onPaintEvent
1681           and windowedPlugin parameters.
1682
1683         https://bugs.webkit.org/show_bug.cgi?id=54051
1684
1685         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1686         (handleEventX11):
1687         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1688         (LayoutTestController::displayInvalidatedRegion):
1689         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1690         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1691         (webkit_test_plugin_new_instance):
1692         (webkit_test_plugin_handle_event):
1693
1694 2011-05-17  Tony Chang  <tony@chromium.org>
1695
1696         Reviewed by Ojan Vafai.
1697
1698         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
1699         https://bugs.webkit.org/show_bug.cgi?id=60895
1700
1701         Update the tools to handle the move.  Lucid 32 results now go in
1702         chromium-linux-x86 and the default platform on Linux is now x86_64.
1703
1704         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
1705         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1706         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
1707         * Scripts/webkitpy/layout_tests/port/base.py: ditto
1708         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
1709         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1710         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
1711         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
1712         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
1713
1714 2011-05-17  Adam Roben  <aroben@apple.com>
1715
1716         Make run-api-tests work on Windows when there are spaces in the path
1717
1718         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
1719         spaces in the path to TestWebKitAPI.exe
1720
1721         Reviewed by David Levin.
1722
1723         * Scripts/run-api-tests:
1724         (runTestTool): Use the "direct object" form of system() to avoid having the path to
1725         TestWebKitAPI.exe be split by the shell.
1726
1727 2011-05-16  Ian Henderson  <ianh@apple.com>
1728
1729         Reviewed by Joseph Pecoraro.
1730
1731         Page::goToItem doesn't work while loading is deferred
1732         https://bugs.webkit.org/show_bug.cgi?id=60412
1733
1734         Add setDefersLoading and goBack methods to LayoutTestController.  We
1735         need to use goBack() instead of history.back() because the latter goes
1736         through NavigationScheduler, hence doesn't exhibit the bug.
1737
1738         * DumpRenderTree/LayoutTestController.cpp:
1739         (goBackCallback):
1740         (setDefersLoadingCallback):
1741         (LayoutTestController::staticFunctions):
1742         * DumpRenderTree/LayoutTestController.h:
1743         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1744         (LayoutTestController::goBack):
1745         (LayoutTestController::setDefersLoading):
1746         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1747         (LayoutTestController::goBack):
1748         (LayoutTestController::setDefersLoading):
1749         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1750         (LayoutTestController::goBack):
1751         (LayoutTestController::setDefersLoading):
1752         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1753         (LayoutTestController::goBack):
1754         (LayoutTestController::setDefersLoading):
1755
1756 2011-05-16  Sam Weinig  <sam@webkit.org>
1757
1758         Reviewed by Anders Carlsson.
1759
1760         TestWebKitAPI should build with clang if it can
1761         https://bugs.webkit.org/show_bug.cgi?id=60918
1762
1763         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1764         Update CompilerVersion.xcconfig to match others.
1765
1766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1767         Add CompilerVersion.xcconfig to the project.
1768
1769         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1770         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1771         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1772         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1773         Add some casts to quiet warnings from clang.
1774
1775 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
1776
1777         Reviewed by David Levin.
1778
1779         add dpranke as a reviewer
1780         https://bugs.webkit.org/show_bug.cgi?id=60919
1781
1782         * Scripts/webkitpy/common/config/committers.py:
1783
1784 2011-05-16  Robert Hogan  <robert@webkit.org>
1785
1786         Reviewed by Anders Carlsson.
1787
1788         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
1789
1790         https://bugs.webkit.org/show_bug.cgi?id=60838
1791
1792         The unix test plugin needs to call the test's NPP_URLNotify
1793         rather than the browsers.
1794
1795         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1796         (webkit_test_plugin_url_notify):
1797
1798 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
1799
1800         Rubber-stamped by Adam Roben.
1801
1802         Adding myself as a reviewer.
1803         * Scripts/webkitpy/common/config/committers.py:
1804
1805 2011-05-16  Sam Weinig  <sam@webkit.org>
1806
1807         Fix typo pointed out by Dave Levin.
1808
1809         * TestWebKitAPI/PlatformUtilities.h:
1810         (TestWebKitAPI::Util::assertWKStringEqual):
1811         Strig -> String.
1812
1813 2011-05-16  Sam Weinig  <sam@webkit.org>
1814
1815         Reviewed by David Levin.
1816
1817         Convert api tester over to using gtest expectations directly
1818         https://bugs.webkit.org/show_bug.cgi?id=60862
1819
1820         * TestWebKitAPI/PlatformUtilities.cpp:
1821         (TestWebKitAPI::Util::toSTD):
1822         * TestWebKitAPI/PlatformUtilities.h:
1823         (TestWebKitAPI::Util::assertWKStrigEqual):
1824         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
1825         the implementation of the macro simpler.
1826
1827         * TestWebKitAPI/Test.h:
1828         Remove TEST_ASSERT forwarder.
1829
1830         [Test changes elided]
1831
1832 2011-05-16  David Kilzer  <ddkilzer@apple.com>
1833
1834         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1835         <rdar://problem/9446430>
1836
1837         Reviewed by Mark Rowe.
1838
1839         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
1840         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1841         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1842
1843 2011-05-16  Jon Lee  <jonlee@apple.com>
1844
1845         Reviewed by Simon Fraser.
1846
1847         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1848         https://bugs.webkit.org/show_bug.cgi?id=60779
1849
1850         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1851         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
1852
1853 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1854
1855         Reviewed by Csaba Osztrogonác.
1856
1857         [Qt] Tools.pro misses include(common.pri)
1858         https://bugs.webkit.org/show_bug.cgi?id=60883
1859
1860         It includes features.pri, which depends on common.pri (the build is
1861         not broken today with the default options, but this is the right
1862         thing to do).
1863
1864         * Tools.pro:
1865
1866 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
1867
1868         Unreviewed: adding myself to committers.py.
1869
1870         * Scripts/webkitpy/common/config/committers.py:
1871
1872 2011-05-15  Daniel Bates  <dbates@webkit.org>
1873
1874         Reviewed by Chris Jerdonek.
1875
1876         svn-apply can't handle Git diff that only changes executable bit
1877         https://bugs.webkit.org/show_bug.cgi?id=60848
1878
1879         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
1880         that only has an executable bit change.
1881
1882         * Scripts/VCSUtils.pm:
1883           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
1884         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
1885         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
1886         * Scripts/svn-apply:
1887         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
1888         * Scripts/svn-unapply:
1889         (patch): Ditto.
1890         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1891           - Updated expected results for test cases to account for numTextChunks.
1892           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
1893           - Added test case "Git: file that only has an executable bit change".
1894         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1895           - Updated expected results for test cases to account for numTextChunks.
1896
1897 2011-05-15  Sam Weinig  <sam@webkit.org>
1898
1899         Fix windows build.
1900
1901         * TestWebKitAPI/win/main.cpp:
1902         (main):
1903
1904 2011-05-15  Sam Weinig  <sam@webkit.org>
1905
1906         Reviewed by David Levin.
1907
1908         Make API tester more gtest friendly
1909         https://bugs.webkit.org/show_bug.cgi?id=60859
1910
1911         * Scripts/run-api-tests:
1912         Numerous changes:
1913         - Remove logic to run tests one at a time.
1914         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
1915           the test runner and allow gtest to print it for us.
1916         - Forward stdout from the test tool to stdout, even in non-verbose runs.
1917         - Run test tool from the current working directory instead of the root webkit
1918           directory.
1919
1920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1921         Move plist to be with other bundle sources.
1922
1923         * TestWebKitAPI/TestsController.cpp:
1924         (TestWebKitAPI::TestsController::TestsController):
1925         (TestWebKitAPI::TestsController::run):
1926         * TestWebKitAPI/TestsController.h:
1927         * TestWebKitAPI/mac/main.mm:
1928         Simplify TestController down to a single run function. We should consider removing the class
1929         entirely at some point.
1930
1931 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1932
1933         Unreviewed, rolling out r86504.
1934         http://trac.webkit.org/changeset/86504
1935         https://bugs.webkit.org/show_bug.cgi?id=60853
1936
1937         "Broke Qt EventSender in editing/selection tests" (Requested
1938         by mwenge on #webkit).
1939
1940         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1941         (WebCore::WebPage::WebPage):
1942         (WebCore::DumpRenderTree::DumpRenderTree):
1943         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1944         (WebCore::DumpRenderTree::initJSObjects):
1945         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1946         (WebCore::DumpRenderTree::eventSender):
1947         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1948         (webkit_test_plugin_new_instance):
1949         (webkit_test_plugin_set_window):
1950         (webkit_test_plugin_handle_event):
1951
1952 2011-05-12  Robert Hogan  <robert@webkit.org>
1953
1954         Reviewed by Benjamin Poulain.
1955
1956         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1957
1958         The support for this test added to the unix test plugin here
1959         may allow other platforms to pass it (nearly everyone
1960         skips it). On Qt it required a bit of trickiness with
1961         the page's EventSender object to get it working fully though,
1962         so only unskipping Qt here.
1963
1964         https://bugs.webkit.org/show_bug.cgi?id=60722
1965
1966         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1967         (WebCore::WebPage::WebPage):
1968         (WebCore::WebPage::eventSender):
1969         (WebCore::DumpRenderTree::DumpRenderTree):
1970         (WebCore::DumpRenderTree::initJSObjects):
1971         (WebCore::DumpRenderTree::createWindow):
1972         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1973         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1974         (webkit_test_plugin_new_instance):
1975         (webkit_test_plugin_set_window):
1976         (webkit_test_plugin_handle_event):
1977
1978 2011-05-14  Arno Renevier  <arno@renevier.net>
1979
1980         Reviewed by Martin Robinson.
1981
1982         make run-gtk-tests executable
1983         https://bugs.webkit.org/show_bug.cgi?id=59278
1984
1985         * Scripts/run-gtk-tests:
1986
1987 2011-05-14  Anders Carlsson  <andersca@apple.com>
1988
1989         Reviewed by Kevin Decker.
1990
1991         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1992         https://bugs.webkit.org/show_bug.cgi?id=60823
1993         <rdar://problem/9430386>
1994
1995         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1996
1997         * DumpRenderTree/DumpRenderTree.gypi:
1998         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1999         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2000         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2001         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2002         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2003         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2004         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2005         * GNUmakefile.am:
2006
2007 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2008
2009         Unreviewed, rolling out r86476.
2010         http://trac.webkit.org/changeset/86476
2011         https://bugs.webkit.org/show_bug.cgi?id=60832
2012
2013         It made plugins/get-url-notify-with-url-that-fails-to-
2014         load.html crash on GTK (Requested by Ossy on #webkit).
2015
2016         * DumpRenderTree/DumpRenderTree.gypi:
2017         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2018         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2019         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2020         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2021         * GNUmakefile.am:
2022
2023 2011-05-13  Anders Carlsson  <andersca@apple.com>
2024
2025         Reviewed by Sam Weinig.
2026
2027         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2028         https://bugs.webkit.org/show_bug.cgi?id=60823
2029         <rdar://problem/9430386>
2030
2031         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2032
2033         * DumpRenderTree/DumpRenderTree.gypi:
2034         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2035         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2036         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2037         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2038         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2039         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2040         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2041         * GNUmakefile.am:
2042
2043 2011-05-13  Anders Carlsson  <andersca@apple.com>
2044
2045         Build fix.
2046
2047         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2048
2049 2011-05-13  Anders Carlsson  <andersca@apple.com>
2050
2051         Reviewed by Sam Weinig.
2052
2053         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2054         https://bugs.webkit.org/show_bug.cgi?id=60810
2055
2056         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2057
2058         * DumpRenderTree/DumpRenderTree.gypi:
2059         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2060         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2061         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2062         * GNUmakefile.am:
2063         Add files.
2064
2065         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2066         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2067         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2068
2069         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2070         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2071         (GetURLWithJavaScriptURL::NPP_New):
2072         (GetURLWithJavaScriptURL::NPP_NewStream):
2073         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2074         (GetURLWithJavaScriptURL::NPP_WriteReady):
2075         (GetURLWithJavaScriptURL::NPP_Write):
2076         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2077         (NPP_NewStream):
2078         (NPP_WriteReady):
2079         (NPP_Write):
2080         (NPP_URLNotify):
2081         call the PluginTest NPP wrappers.
2082
2083 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2084
2085         Unreviewed, rolling out r86447.
2086         http://trac.webkit.org/changeset/86447
2087         https://bugs.webkit.org/show_bug.cgi?id=60809
2088
2089         "Broke some uses of EventSender object on Qt" (Requested by
2090         mwenge on #webkit).
2091
2092         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2093         (WebCore::WebPage::WebPage):
2094         (WebCore::DumpRenderTree::DumpRenderTree):
2095         (WebCore::DumpRenderTree::initJSObjects):
2096         (WebCore::DumpRenderTree::createWindow):
2097         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2098         (WebCore::DumpRenderTree::eventSender):
2099         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2100         (webkit_test_plugin_new_instance):
2101         (webkit_test_plugin_set_window):
2102         (webkit_test_plugin_handle_event):
2103
2104 2011-05-13  Robert Hogan  <robert@webkit.org>
2105
2106         Reviewed by Benjamin Poulain.
2107
2108         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2109
2110         The support for this test added to the unix test plugin here
2111         may allow other platforms to pass it (nearly everyone
2112         skips it). On Qt it required a bit of trickiness with
2113         the page's EventSender object to get it working fully though,
2114         so only unskipping Qt here.
2115
2116         https://bugs.webkit.org/show_bug.cgi?id=60722
2117
2118         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2119         (WebCore::WebPage::WebPage):
2120         (WebCore::WebPage::eventSender):
2121         (WebCore::DumpRenderTree::DumpRenderTree):
2122         (WebCore::DumpRenderTree::initJSObjects):
2123         (WebCore::DumpRenderTree::createWindow):
2124         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2125         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2126         (webkit_test_plugin_new_instance):
2127         (webkit_test_plugin_set_window):
2128         (webkit_test_plugin_handle_event):
2129
2130 2011-05-13  Adam Roben  <aroben@apple.com>
2131
2132         Exclude the Leopard NRWT bot from the core builder set
2133
2134         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2135
2136         Reviewed by Darin Adler.
2137
2138         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2139         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2140         in the core builder set.
2141
2142         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2143         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2144         regexps.
2145
2146 2011-05-13  Adam Roben  <aroben@apple.com>
2147
2148         Group all the NRWT bots together
2149
2150         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2151         bots are experimental, it seems best not to clutter up the non-experimental bots with
2152         experimental ones.
2153
2154         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2155         on build.webkit.org
2156
2157         Reviewed by Dan Bernstein.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2160         Chromium testers, which also use new-run-webkit-tests.
2161
2162 2011-05-13  Adam Roben  <aroben@apple.com>
2163
2164         Add a plugin test that dumps the plugin window's rect
2165
2166         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2167         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2168
2169         Reviewed by Dan Bernstein.
2170
2171         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2172         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2173         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2174         harness window and log it.
2175
2176         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2177
2178 2011-05-13  Adam Roben  <aroben@apple.com>
2179
2180         Move code required for most tests of plugin window geometry into a base class
2181
2182         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2183         having all the trickiness in a shared base class, writing new window geometry tests will be
2184         much easier.
2185
2186         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2187
2188         Reviewed by Anders Carlsson.
2189
2190         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2191         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2192         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2193         class.
2194         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2195         This is called by the base class when it is safe to check the window's geometry. Note that
2196         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2197         just vestigial code from an earlier version of this test.
2198
2199         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2200         WindowGeometryTest class.
2201
2202         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2203         WindowRegionIsSetToClipRect.
2204         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2205         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2206         Subclasses can implement that function to perform their own tests.
2207
2208         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2209
2210 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2211
2212         Reviewed by Csaba Osztrogonác.
2213
2214         Missing 2nd #EOF if WebProcess is killed.
2215         https://bugs.webkit.org/show_bug.cgi?id=60761
2216
2217         If the WebProcess is killed, only one #EOF is yielded
2218         by WebKitTestRunner. However, run-webkit-test wait for
2219         a second #EOF, which signals the finishing of pixel dump.
2220         Since this never happens, run-webkit-test waits forever.
2221
2222         * WebKitTestRunner/TestInvocation.cpp:
2223         (WTR::TestInvocation::dump):
2224         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2225         * WebKitTestRunner/TestInvocation.h:
2226
2227 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2228
2229         Reviewed by Csaba Osztrogonác.
2230
2231         [NRWT] chromium-linux tests shouldn't run on other platforms
2232         https://bugs.webkit.org/show_bug.cgi?id=60162
2233
2234         Remove _tests_for_other_platforms defs because r82753
2235         implemented it properly in the baseclass in webkit.py.
2236
2237         * Scripts/webkitpy/layout_tests/port/gtk.py:
2238         * Scripts/webkitpy/layout_tests/port/qt.py:
2239         * Scripts/webkitpy/layout_tests/port/win.py:
2240
2241 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2242
2243         Reviewed by Antonio Gomes.
2244
2245         [EFL] Remove unused option of EWeblauncher
2246         https://bugs.webkit.org/show_bug.cgi?id=60747
2247
2248         Remove sudo-workaround option.
2249         This option is not used and make other option wrong.
2250
2251         * EWebLauncher/main.c:
2252
2253 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2254
2255         Reviewed by Stephanie Lewis.
2256
2257         Fix config.json to address missing WK2 builder/tester config.
2258         Fix naming of machines (xserve not macpro)
2259
2260         * BuildSlaveSupport/build.webkit.org-config/config.json:
2261
2262 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2263
2264         Reviewed by Stephanie Lewis.
2265
2266         Add SnowLeopard Debug builder and Test bot.
2267         apple-xserve-8 = SL Debug Tester.
2268         apple-xserve-9 = SL Debug Builder.
2269         
2270         * BuildSlaveSupport/build.webkit.org-config/config.json:
2271
2272 2011-05-12  Adam Barth  <abarth@webkit.org>
2273
2274         This patch disables sheriffbot's bug postings.  He's just been way too
2275         spammy recently due to test flakiness.
2276
2277         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2278         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2279
2280 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2281
2282         Reviewed by Anders Carlsson.
2283
2284         After relaunching an unresponsive web process, web page stops responding to mouse movement
2285         https://bugs.webkit.org/show_bug.cgi?id=60669
2286         <rdar://problem/9409934>
2287         
2288         This test follows the steps needed to reproduce this bug:
2289         1) Hang the web process
2290         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
2291         3) Kill and restart the WebProcess
2292         4) Move the mouse
2293         
2294         We are testing that we receive mouse move events after the WebProcess has restarted.
2295
2296         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
2297         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
2298         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
2299         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
2300         (TestWebKitAPI::setPageLoaderClient):
2301         (TestWebKitAPI::TEST):
2302         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
2303         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
2304         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
2305         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
2306
2307         * TestWebKitAPI/PlatformWebView.h:
2308         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2309         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
2310         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2311         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
2312
2313         Add new files.
2314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2315         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2316         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2317         * TestWebKitAPI/win/copy-resources.cmd:
2318
2319 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
2320
2321         Reviewed by Antonio Gomes.
2322
2323         [EFL] Added initialization/shutdown for ecore_file library
2324         https://bugs.webkit.org/show_bug.cgi?id=60457
2325
2326         Added initialization and shuthown for ecore_file library and replaced
2327         realpath function to ecore_file_realpath.
2328
2329         * EWebLauncher/main.c:
2330         (quit):
2331         (findThemePath):
2332         (main):
2333
2334 2011-05-12  Young Han Lee  <joybro@company100.net>
2335
2336         Reviewed by Kenneth Rohde Christiansen.
2337
2338         [Qt] Implement layoutTestController.layerTreeAsText()
2339         https://bugs.webkit.org/show_bug.cgi?id=60367
2340
2341         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2342         (LayoutTestController::layerTreeAsText):
2343         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2344
2345 2011-05-11  Eric Seidel  <eric@webkit.org>
2346
2347         Reviewed by David Levin.
2348
2349         Teach validate-committer-lists how to validate committers bugzilla_email()
2350         https://bugs.webkit.org/show_bug.cgi?id=60651
2351
2352         It turns out we currently have 9 committers with invalid values for their
2353         bugzilla_email field (meaning we don't know what email is their bugzilla account).
2354         "Alexander Kellett" <lypanov@mac.com>
2355         "Andre Boule" <aboule@apple.com>
2356         "Cameron McCormack" <cam@webkit.org>
2357         "Chris Petersen" <cpetersen@apple.com>
2358         "Eli Fidler" <eli@staikos.net>
2359         "Matt Lilek" <webkit@mattlilek.com>
2360         "Pierre d'Herbemont" <pdherbemont@free.fr>
2361         "Scott Violet" <sky@chromium.org>
2362         "Adam Treat" <treat@kde.org>
2363
2364         Most of those haven't committed in a very long time, so it's not suprising
2365         that we haven't noticed that their bugzilla emails are bogus.
2366
2367         * Scripts/validate-committer-lists:
2368         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2369         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2370
2371 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2372
2373         Reviewed by David Levin.
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=59561
2376         Switch TestWebKitAPI to GTest
2377
2378         Fixes Makefiles and WinCairo build as well
2379
2380         * Makefile:
2381         * Scripts/build-api-tests:
2382         * Scripts/run-api-tests:
2383         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2384         * TestWebKitAPI/Test.h:
2385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2387         (TestWebKitAPI::TEST):
2388         * TestWebKitAPI/TestsController.cpp:
2389         (TestWebKitAPI::TestsController::TestsController):
2390         (TestWebKitAPI::TestsController::dumpTestNames):
2391         (TestWebKitAPI::TestsController::runTestNamed):
2392         (TestWebKitAPI::TestsController::runAllTests):
2393         * TestWebKitAPI/TestsController.h:
2394         * TestWebKitAPI/mac/main.mm:
2395         (main):
2396
2397 2011-05-11  Eric Seidel  <eric@webkit.org>
2398
2399         Reviewed by Alexey Proskuryakov.
2400
2401         Add Luke Macpherson to committers.py as a Contributor
2402         https://bugs.webkit.org/show_bug.cgi?id=60639
2403
2404         * Scripts/webkitpy/common/config/committers.py:
2405
2406 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2407
2408         Reviewed by Kenneth Rohde Christiansen.
2409
2410         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2411         https://bugs.webkit.org/show_bug.cgi?id=60439
2412
2413         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2414
2415         * Scripts/build-webkit:
2416
2417 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2418
2419         Reviewed by Adam Roben.
2420
2421         REGRESSION (r86161): WKPreferences API test failing on Windows
2422         https://bugs.webkit.org/show_bug.cgi?id=60658
2423
2424         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2425         (TestWebKitAPI::TEST):
2426
2427 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2428
2429         Reviewed by Ojan Vafai.
2430
2431         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2432         https://bugs.webkit.org/show_bug.cgi?id=60521
2433
2434         First steps towards making the results JSON all hierarchical.
2435
2436         * TestResultServer/model/jsonresults.py:
2437         * TestResultServer/model/jsonresults_unittest.py:
2438
2439 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2440
2441         [wx] Build fix, adding new LayoutTestController method stubs.
2442
2443         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2444         (LayoutTestController::localStorageDiskUsageForOrigin):
2445         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2446
2447 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2448
2449         Reviewed by Darin Adler.
2450
2451         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2452         about the usage for both the origin overall and the database in question.
2453         https://bugs.webkit.org/show_bug.cgi?id=60573
2454
2455         * WebKitTestRunner/TestController.cpp:
2456         (WTR::exceededDatabaseQuota):
2457
2458 2011-05-10  Stephen White  <senorblanco@chromium.org>
2459
2460         Reviewed by David Levin.
2461
2462         Adding myself as a reviewer.
2463         https://bugs.webkit.org/show_bug.cgi?id=60587
2464
2465         * Scripts/webkitpy/common/config/committers.py:
2466
2467 2011-05-11  Eric Seidel  <eric@webkit.org>
2468
2469         Reviewed by Csaba Osztrogonác.
2470
2471         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2472         https://bugs.webkit.org/show_bug.cgi?id=60614
2473
2474         AppEngine has a result limit of 1000.  We hit that when trying
2475         to find out how many patches the style-queue (and other queues)
2476         have passed in the last 30 days.  So lets display 1000+ instead
2477         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2478
2479         I also made the status pages show "never" instead of just "ago" when we
2480         haven't seen a pass or boot message in the last 1000 messages.
2481
2482         * QueueStatusServer/handlers/queuestatus.py:
2483         * QueueStatusServer/templates/queuestatus.html:
2484
2485 2011-05-11  Adam Barth  <abarth@webkit.org>
2486
2487         Reviewed by Eric Seidel.
2488
2489         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2490         https://bugs.webkit.org/show_bug.cgi?id=60613
2491
2492         This patch limits the number of bugs sheriffbot will spam to three.
2493         Ideally, we'd come up with some smarter huerstics, but hopefully this
2494         will cut down on the bugmail spam for slow bots.
2495
2496         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2497
2498 2011-05-10  Eric Seidel  <eric@webkit.org>
2499
2500         Reviewed by Adam Barth.
2501
2502         EWS bots should be robust against test-webkitpy hangs
2503         https://bugs.webkit.org/show_bug.cgi?id=60579
2504
2505         Added a killAfterTimeout subroutine, which takes a child_pid
2506         and timeout, and will setup a watchdog process to kill that child
2507         after the timeout.  killAfterTimeout will waitpid on the child.
2508
2509         * EWSTools/start-queue.sh:
2510
2511 2011-05-10  MORITA Hajime  <morrita@google.com>
2512
2513         Unreviewed, moved myself to the reviewers list.
2514
2515         * Scripts/webkitpy/common/config/committers.py:
2516
2517 2011-05-10  Anton D'Auria  <adauria@apple.com>
2518
2519         Reviewed by David Levin.
2520
2521         StorageTracker should report actual local storage usage on disk
2522         https://bugs.webkit.org/show_bug.cgi?id=60558
2523
2524         * DumpRenderTree/LayoutTestController.cpp:
2525         (localStorageDiskUsageForOriginCallback):
2526         (LayoutTestController::staticFunctions):
2527         * DumpRenderTree/LayoutTestController.h:
2528         * DumpRenderTree/chromium/LayoutTestController.cpp:
2529         (LayoutTestController::LayoutTestController):
2530         (LayoutTestController::localStorageDiskUsageForOrigin):
2531         * DumpRenderTree/chromium/LayoutTestController.h:
2532         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2533         (LayoutTestController::localStorageDiskUsageForOrigin):
2534         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2535         (LayoutTestController::localStorageDiskUsageForOrigin):
2536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2537         (LayoutTestController::localStorageDiskUsageForOrigin):
2538         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2539         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2540         (LayoutTestController::localStorageDiskUsageForOrigin):
2541
2542 2011-05-10  Anton D'Auria  <adauria@apple.com>
2543
2544         Reviewed by Alexey Proskuryakov.
2545
2546         Add ApplicationCache API to get disk usage per origin
2547         https://bugs.webkit.org/show_bug.cgi?id=57127
2548
2549         Added test that loads two frames with ~15Kb image, checks usage,
2550         deletes app cache, verifies usage is 0.
2551
2552         * DumpRenderTree/LayoutTestController.cpp:
2553         (applicationCacheDiskUsageForOriginCallback):
2554         (LayoutTestController::staticFunctions):
2555         * DumpRenderTree/LayoutTestController.h:
2556         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2557         (LayoutTestController::LayoutTestController):
2558         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2559         * DumpRenderTree/chromium/LayoutTestController.h:
2560         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2561         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2562         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2563         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2565         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2566         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2567         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2568         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2569
2570 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2571
2572         Unreviewed, adding Rafael Antognolli as a committer.
2573
2574         * Scripts/webkitpy/common/config/committers.py:
2575
2576 2011-05-10  Chris Evans  <cevans@chromium.org>
2577
2578         Reviewed by Adam Barth.
2579
2580         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2581         https://bugs.webkit.org/show_bug.cgi?id=58378
2582
2583         * DumpRenderTree/chromium/LayoutTestController.cpp:
2584         (LayoutTestController::LayoutTestController):
2585         (LayoutTestController::setAllowDisplayOfInsecureContent):
2586         (LayoutTestController::setAllowRunningOfInsecureContent):
2587         * DumpRenderTree/chromium/LayoutTestController.h:
2588         * DumpRenderTree/chromium/WebPreferences.cpp:
2589         (WebPreferences::reset):
2590         (WebPreferences::applyTo):
2591         * DumpRenderTree/chromium/WebPreferences.h:
2592         Add plumbing for new settings to Chromium DRT.
2593
2594 2011-05-10  Enrica Casucci  <enrica@apple.com>
2595
2596         Reviewed by Beth Dakin.
2597
2598         Added my name to the reviewers list and removed my name from
2599         to committer-only list.
2600
2601         * Scripts/webkitpy/common/config/committers.py:
2602
2603 2011-05-10  David Levin  <levin@chromium.org>
2604
2605         Reviewed by Shinichiro Hamaji.
2606
2607         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
2608         https://bugs.webkit.org/show_bug.cgi?id=60466
2609
2610         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
2611         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
2612           that property was removed.
2613         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
2614           filtering for errors.
2615         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
2616           verify that the line filtering is turned off.
2617         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
2618           and remove the unused file_path parameter.
2619         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
2620           line filtering is turned off (and fix test_no_error).
2621         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
2622           of errors based on the lines changed in the patch.
2623         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
2624           the filtering.
2625
2626 2011-05-10  Adam Roben  <aroben@apple.com>
2627
2628         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
2629
2630         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
2631         platform/win/plugins/window-geometry-initialized-before-set-window.html and
2632         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
2633         (WebKit2 Tests)
2634
2635         Reviewed by Anders Carlsson.
2636
2637         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2638         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
2639         WindowedPluginTest::testHarnessWindow function.
2640
2641         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2642         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
2643         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
2644         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
2645         created for.
2646
2647         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2648         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
2649         WindowedPluginTest, and initialized new members.
2650         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
2651         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
2652         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
2653         then clean up and tell the test harness we're done.
2654         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
2655         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
2656         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
2657         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
2658         window becomes visible.
2659         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
2660         if it was hidden at the start of the test.
2661         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
2662         This should cause our window to become visible and our window region to get set. When we get
2663         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
2664         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
2665         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
2666         "startTest".
2667         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
2668
2669         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2670         (WindowedPluginTest::testHarnessWindow):
2671         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
2672         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
2673
2674 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2675
2676         Reviewed by Kenneth Rohde Christiansen.
2677
2678         [Qt] Add new qt-4.8 platform for layout testing
2679         https://bugs.webkit.org/show_bug.cgi?id=60544
2680
2681         * Scripts/old-run-webkit-tests:
2682         * Scripts/webkitdirs.pm:
2683
2684 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2685
2686         Unreviewed, rolling out r86108.
2687         http://trac.webkit.org/changeset/86108
2688         https://bugs.webkit.org/show_bug.cgi?id=60533
2689
2690         Broke makefile based builds and Cairo (Requested by weinig on
2691         #webkit).
2692
2693         * Scripts/build-api-tests:
2694         * Scripts/run-api-tests:
2695         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2696         * TestWebKitAPI/Test.h:
2697         (TestWebKitAPI::Test::~Test):
2698         (TestWebKitAPI::Test::name):
2699         (TestWebKitAPI::Test::Register::Register):
2700         (TestWebKitAPI::Test::Register::create):
2701         (TestWebKitAPI::Test::Test):
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2703         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2704         (TestWebKitAPI::TEST):
2705         * TestWebKitAPI/TestsController.cpp:
2706         (TestWebKitAPI::TestsController::TestsController):
2707         (TestWebKitAPI::TestsController::dumpTestNames):
2708         (TestWebKitAPI::TestsController::runTestNamed):
2709         (TestWebKitAPI::TestsController::testFailed):
2710         (TestWebKitAPI::TestsController::registerCreateTestFunction):
2711         * TestWebKitAPI/TestsController.h:
2712         * TestWebKitAPI/mac/main.mm:
2713         (main):
2714
2715 2011-05-09  Hayato Ito  <hayato@chromium.org>
2716
2717         Reviewed by Ojan Vafai.
2718
2719         Skip reftests if pixel tests are disabled.
2720
2721         https://bugs.webkit.org/show_bug.cgi?id=59078
2722
2723         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2724         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2725         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2726         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2727
2728 2011-05-09  Chang Shu  <cshu@webkit.org>
2729
2730         Reviewed by Kenneth Rohde Christiansen.
2731
2732         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
2733         https://bugs.webkit.org/show_bug.cgi?id=60499
2734
2735         The implementation is similar to gtk.
2736
2737         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2738         (TextInputController::unmarkText):
2739         * DumpRenderTree/qt/TextInputControllerQt.h:
2740
2741 2011-05-09  James Robinson  <jamesr@chromium.org>
2742
2743         Reviewed by Eric Seidel.
2744
2745         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
2746         https://bugs.webkit.org/show_bug.cgi?id=60520
2747
2748         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2749
2750 2011-05-09  Dmitry Lomov  <dslomov@google.com>
2751
2752         Reviewed by Sam Weinig.
2753
2754         Switch TestWebKitAPI to GTest
2755         https://bugs.webkit.org/show_bug.cgi?id=59561
2756
2757         * Scripts/build-api-tests:
2758         * Scripts/run-api-tests:
2759         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2760         * TestWebKitAPI/Test.h:
2761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2762         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2763         (TestWebKitAPI::TEST):
2764         * TestWebKitAPI/TestsController.cpp:
2765         (TestWebKitAPI::TestsController::TestsController):
2766         (TestWebKitAPI::TestsController::dumpTestNames):
2767         (TestWebKitAPI::TestsController::runTestNamed):
2768         (TestWebKitAPI::TestsController::runAllTests):
2769         * TestWebKitAPI/TestsController.h:
2770         * TestWebKitAPI/mac/main.mm:
2771         (main):
2772
2773 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
2774
2775         Reviewed by Andreas Kling.
2776
2777         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
2778         https://bugs.webkit.org/show_bug.cgi?id=60487
2779
2780         When adding a new touch point, the start position of this point needs to be set.
2781
2782         * DumpRenderTree/qt/EventSenderQt.cpp:
2783         (EventSender::addTouchPoint):
2784
2785 2011-05-09  Robert Hogan  <robert@webkit.org>
2786
2787         Reviewed by Adam Roben.
2788
2789         https://bugs.webkit.org/show_bug.cgi?id=57137
2790
2791         Unskip plugins/embed-prefers-plugins-for-images.html
2792
2793         Add image/png mime-type to test netscape plugin on Unix.
2794
2795         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2796         (NP_GetMIMEDescription):
2797
2798 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
2799
2800         Reviewed by Ojan Vafai.
2801
2802         Pull jsonresults_unittest test cases out into separate test methods.
2803         https://bugs.webkit.org/show_bug.cgi?id=60418
2804
2805         * TestResultServer/model/jsonresults_unittest.py:
2806
2807 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2808
2809         Reviewed by Andreas Kling.
2810
2811         [Qt] fix fast/dom/Geolocation/window-close-crash.html
2812         https://bugs.webkit.org/show_bug.cgi?id=60458
2813
2814         Update all pages with Mock position/error/permission.
2815
2816         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2817         (LayoutTestController::setGeolocationPermission):
2818         (LayoutTestController::setMockGeolocationError):
2819         (LayoutTestController::setMockGeolocationPosition):
2820
2821 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
2822
2823         Reviewed by Tony Gentilcore.
2824
2825         Implement Page Visibility API.
2826         https://bugs.webkit.org/show_bug.cgi?id=54181
2827
2828         * DumpRenderTree/LayoutTestController.cpp:
2829         (setPageVisibilityCallback):
2830         (resetPageVisibilityCallback):
2831         (LayoutTestController::staticFunctions):
2832         * DumpRenderTree/LayoutTestController.h:
2833         (LayoutTestController::setPageVisibility):
2834         (LayoutTestController::resetPageVisibility):
2835         * DumpRenderTree/chromium/LayoutTestController.cpp:
2836         (LayoutTestController::LayoutTestController):
2837         (LayoutTestController::resetPageVisibility):
2838         (LayoutTestController::setPageVisibility):
2839         * DumpRenderTree/chromium/LayoutTestController.h:
2840
2841 2011-05-07  Adam Barth  <abarth@webkit.org>
2842
2843         Reviewed by Eric Seidel.
2844
2845         Testing EWS spins on patches with a large number of failures
2846         https://bugs.webkit.org/show_bug.cgi?id=60441
2847
2848         In cases where the tree has a small number of persistent failures but a
2849         patch has a large number of failures, we weren't believing any results.
2850         That lead to us retrying the patch forever while we waited for
2851         trustworthy results that would never come.
2852
2853         This patch loosens the semantics of unexpected_failures to return a
2854         subset (rather than the exact set) of unexpected failures.  In the case
2855         where the tree has a bounded number of failures and the patch has an
2856         unbounded number of failures, we can accurately compute such a subset
2857         and reject the patch.
2858
2859         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2860         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2861         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2862         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2863         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2864
2865 2011-05-07  Joe Mason  <jmason@rim.com>
2866
2867         Reviewed by Daniel Bates.
2868
2869         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
2870         https://bugs.webkit.org/show_bug.cgi?id=52211
2871
2872         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
2873         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
2874
2875         * DumpRenderTree/chromium/WebViewHost.cpp:
2876         (WebViewHost::willPerformClientRedirect):
2877         (WebViewHost::didStartProvisionalLoad):
2878         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2879         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2880
2881 2011-05-07  Daniel Bates  <dbates@webkit.org>
2882
2883         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
2884         <http://trac.webkit.org/changeset/86007> (bug #60438).
2885
2886         * Scripts/old-run-webkit-tests:
2887           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
2888             file local variable. 
2889
2890 2011-05-07  Pratik Solanki  <psolanki@apple.com>
2891
2892         Reviewed by Darin Adler.
2893
2894         Remove references to Tiger in scripts
2895         https://bugs.webkit.org/show_bug.cgi?id=60438
2896
2897         Remove isTiger() and all of the code that depends on it.
2898
2899         * Scripts/build-webkit:
2900         * Scripts/ensure-valid-python:
2901         * Scripts/gdb-safari:
2902         * Scripts/webkitdirs.pm:
2903
2904 2011-05-06  David Grogan  <dgrogan@chromium.org>
2905
2906         Reviewed by Eric Seidel.
2907
2908         update link to message about mac 64bit git binaries
2909         https://bugs.webkit.org/show_bug.cgi?id=60411
2910
2911         The original message implied (correctly, at-the-time) that
2912         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
2913         binaries. The new message notes that they do. This might prevent someone
2914         else from spending a few minutes confused.
2915
2916         * Scripts/webkitpy/common/checkout/scm/git.py:
2917
2918 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
2919
2920         Reviewed by Ojan Vafai.
2921
2922         new-run-webkit-tests: crashes in race with crashing DRT
2923         https://bugs.webkit.org/show_bug.cgi?id=60238
2924
2925         This fixes a race where if we wrote the URL to DRT and
2926         DRT crashed immediately, we could get a broken pipe
2927         error back during the write() and not handle it correctly,
2928         causing NRWT to also crash.
2929
2930         * Scripts/webkitpy/layout_tests/port/server_process.py:
2931         * Scripts/webkitpy/layout_tests/port/webkit.py:
2932
2933 2011-05-06  Adam Barth  <abarth@webkit.org>
2934
2935         Reviewed by Eric Seidel.
2936
2937         Add a --skip-integrationtests mode to test-webkitpy
2938         https://bugs.webkit.org/show_bug.cgi?id=60354
2939
2940         These two test suites account for 2/3 of test-webkitpy's running time
2941         because they're not actually unit tests.  They're integration tests.
2942         This patch adds the ability to skip integration tests by passing a
2943         command line argument to test-webkitpy.  The buildbots will continue to
2944         run these integration tests to make sure they don't regress.  This
2945         option is for use by developers when working on parts of the code that
2946         are well-covered by unit tests.
2947
2948         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
2949         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2950         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
2951         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
2952         * Scripts/webkitpy/test/main.py:
2953
2954 2011-05-06  Adam Barth  <abarth@webkit.org>
2955
2956         Reviewed by Eric Seidel.
2957
2958         The results.zip generated by the Chromium EWS are too big
2959         https://bugs.webkit.org/show_bug.cgi?id=60352
2960
2961         Currently results.zip created by the Chromium EWS bot contain roughly
2962         1000 tests that we expect to fail.  These test results are not helpful
2963         to contributors.
2964
2965         There are several approaches to solving this problem:
2966
2967         1) We could be more selective about which files to include in the zip.
2968         2) We could ask new-run-webkit-tests not to generate results for
2969            expected failures.
2970         3) We could ask new-run-webkit-tests not to run tests that we expect to
2971            fail.
2972
2973         This patch takes approach (3).  Currently, we're ignoring the outcome
2974         of failing tests anyway, so there's not much point in actually running
2975         them.  As a side benefit, this will speed up the test run by about 6%.
2976         In the future, we might revisit this decision and choose another
2977         approach.
2978
2979         * Scripts/webkitpy/common/config/ports.py:
2980         * Scripts/webkitpy/common/config/ports_unittest.py:
2981
2982 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
2983
2984         Reviewed by Csaba Osztrogonác.
2985
2986         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
2987
2988         * Scripts/old-run-webkit-tests:
2989
2990 2011-05-06  Adam Barth  <abarth@webkit.org>
2991
2992         Reviewed by Ojan Vafai.
2993
2994         Add an option to NRWT to skip failing tests
2995         https://bugs.webkit.org/show_bug.cgi?id=60295
2996
2997         This option is similar to the way old-run-webkit-tests works.  We're
2998         planning to use this option on the testing EWS bots because they don't
2999         use information from failing tests yet.
3000
3001         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3002         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3003         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3004
3005 2011-05-04  Philippe Normand  <pnormand@igalia.com>
3006
3007         Reviewed by Dimitri Glazkov.
3008
3009         Implement LayoutTestController::pseudoShadowId()
3010         https://bugs.webkit.org/show_bug.cgi?id=60034
3011
3012         shadowPseudoId support in the various LayoutTestController
3013         implementations.
3014
3015         * DumpRenderTree/LayoutTestController.cpp:
3016         (shadowPseudoIdCallback):
3017         (LayoutTestController::staticFunctions):
3018         * DumpRenderTree/LayoutTestController.h:
3019         * DumpRenderTree/chromium/LayoutTestController.cpp:
3020         (LayoutTestController::LayoutTestController):
3021         (LayoutTestController::shadowPseudoId):
3022         * DumpRenderTree/chromium/LayoutTestController.h:
3023         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3024         (LayoutTestController::shadowPseudoId):
3025         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3026         (LayoutTestController::shadowPseudoId):
3027         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3028         (LayoutTestController::shadowPseudoId):
3029         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3030         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3031         (LayoutTestController::shadowPseudoId):
3032         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3033         (LayoutTestController::shadowPseudoId):
3034         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3035         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3036         (WTR::LayoutTestController::shadowPseudoId):
3037         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3038
3039 2011-05-06  Adam Barth  <abarth@webkit.org>
3040
3041         EWS can't reject patches
3042         https://bugs.webkit.org/show_bug.cgi?id=60345
3043
3044         We're supposed to use patch.id() for the attachment ID, silly.
3045
3046         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3047         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3048
3049 2011-05-05  Steve Lacey  <sjl@chromium.org>
3050
3051         Reviewed by Ojan Vafai.
3052
3053         Fix generation of results html file by passing relative path to scm
3054         methods.
3055         Generate diff images for results html file.
3056
3057         https://bugs.webkit.org/show_bug.cgi?id=60086
3058
3059         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3060         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3061
3062 2011-05-05  Andy Estes  <aestes@apple.com>
3063
3064         Reviewed by Daniel Bates.
3065
3066         update-webkit should handle Internal using a different VCS than OpenSource.
3067         https://bugs.webkit.org/show_bug.cgi?id=60310
3068
3069         isGit() and isSVN() cache their results, so Internal will always be
3070         updated using the VCS commands used for OpenSource. If Internal uses a
3071         different VCS, this will fail. Fix this by calling isGitDirectory() and
3072         isSVNDirectory() instead, which do not cache their results.
3073
3074         * Scripts/update-webkit:
3075
3076 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3077
3078         Reviewed by Ojan Vafai.
3079
3080         nrwt: revamp integration tests incl. tests for servers
3081         https://bugs.webkit.org/show_bug.cgi?id=59985
3082
3083         This change adds the ability to run "integration tests" that
3084         depend on (and affect) the local environment on your machine.
3085         These tests can be run manually by invoking python on the
3086         test file in question and passing the '-i' flag, but are
3087         not run automatically as part of test-webkitpy.
3088
3089         Integration tests are identified by being methods named as
3090         "integration_test_*" instead of "test_*", and we use a
3091         custom TestLoader instead of the default one provided by
3092         unittest.
3093
3094         This change also adds a protected "_default_to_apache" method
3095         to the port object so we can do the right thing when starting
3096         and stopping web servers with less mechanism.
3097
3098         * Scripts/webkitpy/layout_tests/port/base.py:
3099         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3100         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3101         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3102         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3103         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3104
3105 2011-05-05  Adam Roben  <aroben@apple.com>
3106
3107         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3108
3109         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3110         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3111         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3112         safeguard against this, we fill the alpha channel with constant full opacity after the
3113         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3114         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3115         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3116         results need an alpha channel, too.)
3117
3118         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3119         generated due to alpha channel weirdness
3120
3121         Reviewed by Sam Weinig.
3122
3123         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3124         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3125         constant full opacity.
3126         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3127         in a CGContext or cairo_surface.
3128
3129 2011-05-05  Adam Roben  <aroben@apple.com>
3130
3131         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3132
3133         Passing true tells the test harness to dump pixels even though we're not dumping a render
3134         tree.
3135
3136         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3137         WebKitTestRunner doesn't result in pixel results being generated
3138
3139         Reviewed by Sam Weinig.
3140
3141         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3142         argument to dumpAsText.
3143
3144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3145         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3146
3147         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3148         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3149
3150         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3151
3152         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3153         developers.
3154
3155 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3156
3157         Reviewed by Ojan Vafai.
3158
3159         new-run-webkit-tests: merge os, version fields in test config
3160         https://bugs.webkit.org/show_bug.cgi?id=60004
3161
3162         This change removes the 'o/s' field from the TestConfiguration
3163         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3164         the expectations file to macros that expand to the version names
3165         for each platform.
3166
3167         This means that you can once again put any subset of the
3168         operating system versions on a single line, e.g.:
3169           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3170
3171         This change will break any existing test_expectations.txt
3172         file that uses the "OS-VERSION" macros, which are no longer
3173         needed. It turns out they were never needed, as just VERSION
3174         by itself was sufficient. The test_expectations.txt file should
3175         be updated accordingly prior to landing this change.
3176
3177         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3178         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3179         * Scripts/webkitpy/layout_tests/port/base.py:
3180
3181 2011-05-05  Tony Chang  <tony@chromium.org>
3182
3183         Reviewed by Adam Barth.
3184
3185         [chromium] switch from Lucida to free fonts for Hindi and Thai
3186         https://bugs.webkit.org/show_bug.cgi?id=60287
3187
3188         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3189         packages on Lucid. There are actually multiple Thai fonts in the
3190         package, so I just picked one.
3191
3192         * DumpRenderTree/chromium/TestShellGtk.cpp:
3193         (setupFontconfig):
3194
3195 2011-05-05  Tony Chang  <tony@chromium.org>
3196
3197         Reviewed by Ojan Vafai.
3198
3199         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3200         https://bugs.webkit.org/show_bug.cgi?id=60290
3201
3202         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
3203         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
3204         lucid64.  Because of that, google-chrome-64 used to skip the
3205         chromium-linux-x86_64 results since they were more incorrect.
3206
3207         Now that we're switching to lucid for google-chrome, we want
3208         google-chrome-64 to fall back to chromium-linux-x86_64.
3209
3210         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3211
3212 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3213
3214         Reviewed by Ojan Vafai.
3215
3216         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
3217         https://bugs.webkit.org/show_bug.cgi?id=60002
3218
3219         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3220         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3221         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3222         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3223         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3224         * Scripts/webkitpy/style/checkers/test_expectations.py:
3225
3226 2011-05-05  Eric Seidel  <eric@webkit.org>
3227
3228         Reviewed by Adam Barth.
3229
3230         commit-queue should reject patches which fail ewses
3231         https://bugs.webkit.org/show_bug.cgi?id=47534
3232
3233         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3234         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3235         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3236
3237 2011-05-05  Chang Shu  <cshu@webkit.org>
3238
3239         Reviewed by Andreas Kling.
3240
3241         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
3242         https://bugs.webkit.org/show_bug.cgi?id=59638
3243
3244         1. Call QGraphicsWKView constructor with pageGroupRef.
3245         2. Disable setFontFamily calls as it breaks Qt test fonts.
3246
3247         * WebKitTestRunner/TestController.cpp:
3248         (WTR::TestController::resetStateToConsistentValues):
3249         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3250         (WTR::WebView::WebView):
3251         (WTR::PlatformWebView::PlatformWebView):
3252
3253 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
3254
3255         Reviewed by David Kilzer.
3256
3257         Add --only-webkit option to build-webkit
3258         https://bugs.webkit.org/show_bug.cgi?id=60245
3259
3260         * Scripts/build-webkit: If --only-webkit was specified
3261         just build the WebKit project, and not its dependencies.
3262
3263 2011-05-05  Jeff Miller  <jeffm@apple.com>
3264
3265         Reviewed by Darin Adler.
3266
3267         Add didNotHandleWheelEvent callback to WKPageUIClient
3268         https://bugs.webkit.org/show_bug.cgi?id=60203
3269
3270         * MiniBrowser/gtk/BrowserWindow.c:
3271         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
3272         * MiniBrowser/mac/BrowserWindowController.m:
3273         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
3274         * MiniBrowser/win/BrowserView.cpp:
3275         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
3276         * WebKitTestRunner/TestController.cpp:
3277         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
3278         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
3279
3280 2011-05-04  Eric Seidel  <eric@webkit.org>
3281
3282         Reviewed by Adam Barth.
3283
3284         Add more missing imports from scm refactor
3285         https://bugs.webkit.org/show_bug.cgi?id=60239
3286
3287         * Scripts/webkitpy/common/checkout/scm/git.py:
3288         * Scripts/webkitpy/common/checkout/scm/svn.py:
3289
3290 2011-05-04  Eric Seidel  <eric@webkit.org>
3291
3292         Reviewed by Adam Barth.
3293
3294         sheriff-bot is having more exception trouble
3295         https://bugs.webkit.org/show_bug.cgi?id=60233
3296
3297         A webpage-forced build was causing SB to throw an exception.
3298         We've long had this bug, but we just didn't notice it until now.
3299
3300         In debugging this I found we fetch an absurd amount of data now
3301         that we use buildbot's json (instead of xmlrpc), so I added
3302         the filter=1 parameter to reduce it a little.  That required
3303         me to handle the case where filter=1 would strip
3304         result=0 in some cases (it's unclear why it does that).
3305
3306         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3307         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3308
3309 2011-05-04  Cris Neckar  <cdn@chromium.org>
3310
3311         Unreviewed, Adding Cris Neckar as a committer
3312
3313         * Scripts/webkitpy/common/config/committers.py:
3314
3315 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3316
3317         Reviewed by Laszlo Gombos.
3318
3319         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
3320         https://bugs.webkit.org/show_bug.cgi?id=59462
3321
3322         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
3323
3324 2011-05-04  Eric Seidel  <eric@webkit.org>
3325
3326         Reviewed by Adam Barth.
3327
3328         The testing EWS bots should upload layout-test-results.zip to bugs after failures
3329         https://bugs.webkit.org/show_bug.cgi?id=60223
3330
3331         This required sharing a bit of code between the commit-queue
3332         (which already knew how to do this) and the new EWS testing bots.
3333
3334         In the process I also cleaned up EWS testing a little and
3335         removed some dead code from the commit-queue.
3336
3337         * Scripts/webkitpy/common/config/committervalidator.py:
3338         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3339         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3340         * Scripts/webkitpy/tool/commands/queues.py:
3341         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3342
3343 2011-05-04  James Kozianski  <koz@chromium.org>
3344
3345         Reviewed by Eric Seidel.
3346
3347         Add method to make a Port able to retrieve TestOutputSets from its builders.
3348         https://bugs.webkit.org/show_bug.cgi?id=58211
3349
3350         This will be used in the new rebaseline script - TestOutputs are
3351         potential new baselines.
3352
3353         * Scripts/webkitpy/common/config/urls.py:
3354         * Scripts/webkitpy/layout_tests/port/base.py:
3355         * Scripts/webkitpy/layout_tests/port/chromium.py:
3356         * Scripts/webkitpy/layout_tests/port/factory.py:
3357         * Scripts/webkitpy/layout_tests/port/webkit.py:
3358
3359 2011-05-04  Eric Seidel  <eric@webkit.org>
3360
3361         Reviewed by Ojan Vafai.
3362
3363         sheriff-bot can't parse results.html
3364         https://bugs.webkit.org/show_bug.cgi?id=60196
3365
3366         The problem was that the NRWT bots are currently core
3367         and so sheriff-bot was trying to diagnose failures on
3368         them.  It was trying to parse their results.html file
3369         and BeautifulSoup was throwing an exception.
3370
3371         It seems our version of BeautifulSoup was quite old
3372         and unable to handle <script> tags correctly.
3373         This moves us to 3.2 which doesn't seem to have this bug.
3374
3375         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
3376
3377 2011-05-04  Adam Barth  <abarth@webkit.org>
3378
3379         Reviewed by Eric Seidel.
3380
3381         Make the EWS test logging less verbose
3382         https://bugs.webkit.org/show_bug.cgi?id=60201
3383
3384         This should help us generate less than a hundred MB of logs per hour.
3385
3386         * Scripts/webkitpy/common/config/ports.py:
3387         * Scripts/webkitpy/common/config/ports_unittest.py:
3388
3389 2011-05-04  Tao Bai  <michaelbai@chromium.org>
3390
3391         Reviewed by David Kilzer.
3392
3393         Populate touch-icon url to FrameLoaderClient
3394         https://bugs.webkit.org/show_bug.cgi?id=59143
3395
3396         Disable touch icon by default. 
3397
3398         * Scripts/build-webkit:
3399
3400 2011-05-04  Justin Novosad  <junov@chromium.org>
3401
3402         Reviewed by Kenneth Russell.
3403
3404         [Chromium] Add gpu acceleration flags to DumpRenderTree
3405         https://bugs.webkit.org/show_bug.cgi?id=60168
3406         Adding support for command line flags 
3407         enable-accelerated-2d-canvas an
3408         enable-accelerated-drawing in DumpRenderTree.
3409
3410         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3411         (main):
3412         * DumpRenderTree/chromium/TestShell.cpp:
3413         (TestShell::TestShell):
3414         (TestShell::resetWebSettings):
3415         * DumpRenderTree/chromium/TestShell.h:
3416         (TestShell::setLegacyAccelerated2dCanvasEnabled):
3417         (TestShell::setAcceleratedDrawingEnabled):
3418         * DumpRenderTree/chromium/WebPreferences.cpp:
3419         (WebPreferences::reset):
3420         (WebPreferences::applyTo):
3421         * DumpRenderTree/chromium/WebPreferences.h:
3422
3423 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3424
3425         Reviewed by Csaba Osztrogonác.
3426
3427         [Qt] run-qtwebkit-tests misses exec bit
3428         https://bugs.webkit.org/show_bug.cgi?id=60188
3429
3430         Also removing an unecessary import (mostly to let this bugfix goes
3431         through the system, as this is just a chmod).
3432
3433         * Scripts/run-qtwebkit-tests:
3434
3435 2011-05-04  Adam Barth  <abarth@webkit.org>
3436
3437         Fix import of ircproxy module to actually import the module.  I don't
3438         really understand how this code could have worked before.
3439
3440         * Scripts/webkitpy/common/host.py:
3441
3442 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3443
3444         Reviewed by Andreas Kling.
3445
3446         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3447         https://bugs.webkit.org/show_bug.cgi?id=60172
3448
3449         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3450         (BrowserWindow::BrowserWindow):
3451
3452 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3453
3454         Reviewed by Ojan Vafai.
3455
3456         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3457         https://bugs.webkit.org/show_bug.cgi?id=60088
3458         
3459         Makes --new-baseline put new baselines into the first entry in the
3460         baseline search path, including any additional directories passed in via
3461         --additional-platform-directory.
3462         
3463         Simplifies baseline_path() by making it return the first entry in the
3464         baseline search path instead of requiring each port to have an
3465         implementation (should not result in any behavior change).
3466
3467         * Scripts/webkitpy/layout_tests/port/base.py:
3468         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3469         * Scripts/webkitpy/layout_tests/port/chromium.py:
3470         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3471         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3472         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3473         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3474         * Scripts/webkitpy/layout_tests/port/mac.py:
3475         * Scripts/webkitpy/layout_tests/port/test.py:
3476         * Scripts/webkitpy/layout_tests/port/webkit.py:
3477
3478 2011-05-04  Adam Barth  <abarth@webkit.org>
3479
3480         Reviewed by Eric Seidel.
3481
3482         Fix circular dependency in webkitpy
3483         https://bugs.webkit.org/show_bug.cgi?id=60075
3484
3485         These functions don't belong in bugzilla.py.  They only exist there
3486         because they are old.  Really, these functions shouldn't be free
3487         functions at all, but that's a patch for another day.
3488
3489         * Scripts/webkitpy/common/checkout/changelog.py:
3490         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3491         * Scripts/webkitpy/common/checkout/checkout.py:
3492         * Scripts/webkitpy/common/config/urls.py:
3493         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3494         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3495         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3496         * Scripts/webkitpy/style/checkers/changelog.py:
3497         * Scripts/webkitpy/tool/bot/irc_command.py:
3498         * Scripts/webkitpy/tool/bot/sheriff.py:
3499         * Scripts/webkitpy/tool/commands/upload.py:
3500
3501 2011-05-03  Pratik Solanki  <psolanki@apple.com>
3502
3503         Reviewed by Dan Bernstein.
3504
3505         https://bugs.webkit.org/show_bug.cgi?id=60141
3506         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
3507
3508         * Scripts/build-webkit:
3509
3510 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
3511
3512         Reviewed by Ojan Vafai.
3513
3514         Update rebaseline queue server to handle hierarchical test results
3515         https://bugs.webkit.org/show_bug.cgi?id=60063
3516         
3517         Update test result parsing done by the rebaseline queue server to handle
3518         the hierarchical test result output that is generated as of r85254.
3519
3520         * RebaselineQueueServer/templates/builder-queue-edit.html:
3521
3522 2011-05-03  Eric Seidel  <eric@webkit.org>
3523
3524         Reviewed by Adam Roben.
3525
3526         webkit-patch post-commits HEAD^.. throws an exception
3527         https://bugs.webkit.org/show_bug.cgi?id=60027
3528
3529         * Scripts/webkitpy/common/checkout/scm/git.py:
3530
3531 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
3532
3533         Reviewed by Kenneth Rohde Christiansen.
3534
3535         [Qt] Layout tests may timeout if loadFinished receives false
3536         https://bugs.webkit.org/show_bug.cgi?id=60064
3537
3538         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
3539         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
3540         a response is ignored, like it should be for 204 responses. It is a problem for creating
3541         tests for 204 responses for example.
3542
3543         This change has been tested and it causes no regressions in layout tests.
3544
3545         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3546         (LayoutTestController::maybeDump):
3547
3548 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3549
3550         Unreviewed, rolling out r85659.
3551         http://trac.webkit.org/changeset/85659
3552         https://bugs.webkit.org/show_bug.cgi?id=59977
3553
3554         restarting isn't working correctly
3555
3556         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3557         * Scripts/webkitpy/layout_tests/port/http_server.py:
3558         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3559         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3560
3561 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3562
3563         Reviewed by Ojan Vafai.
3564
3565         new-run-webkit-tests: fix http server startup/shutdown
3566
3567         Previous versions of the code had three problems that made startup
3568         and shutdown flaky. The first is that it would throw exceptions
3569         if it couldn't delete stale log files, which was overly
3570         paranoid. The second is that some of the exceptions weren't
3571         defined properly. The third, and most important, is that it was
3572         using urllib to check if ports were available, which was leaving
3573         sockets in a half-closed state, and keeping ports from being
3574         reused. By switching to raw sockets, we are able to now reliably
3575         restart.
3576
3577         This change also switches the code to using Executives to stop
3578         processes, which will let us delete a bunch of code in the
3579         port/* implementations and fix a weird layering problem in a
3580         subsequent patch.
3581
3582         https://bugs.webkit.org/show_bug.cgi?id=59977
3583
3584         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3585         * Scripts/webkitpy/layout_tests/port/http_server.py:
3586         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3587         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3588
3589 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3590
3591         Reviewed by Adam Barth.
3592
3593         fix failing printing_unittest on win32
3594         https://bugs.webkit.org/show_bug.cgi?id=59963
3595
3596         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3597
3598 2011-05-03  Adam Roben  <aroben@apple.com>
3599
3600         Fix most strict PassOwnPtr violations on Windows
3601
3602         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3603         enabled
3604
3605         Reviewed by Anders Carlsson.
3606
3607         * WebKitAPITest/Test.h: Use adoptPtr.
3608
3609 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3610
3611         Reviewed by Andreas Kling.
3612
3613         Add myself to the committers list.
3614
3615         * Scripts/webkitpy/common/config/committers.py:
3616
3617 2011-05-03  James Robinson  <jamesr@chromium.org>
3618
3619         Reviewed by Kenneth Russell.
3620
3621         [chromium] Layout test animations/3d/replace-filling-transform.html failing
3622         https://bugs.webkit.org/show_bug.cgi?id=59839
3623
3624         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
3625
3626         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3627
3628 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3629
3630         Unreviewed, rolling out r85471.
3631         http://trac.webkit.org/changeset/85471
3632         https://bugs.webkit.org/show_bug.cgi?id=59922
3633
3634         The rule of thumb in EFL is that you init in all the places
3635         you use it. So, if in your application you call ecore_evas_*
3636         functions, you have to call ecore_evas_init() first.
3637
3638         * EWebLauncher/main.c: always call *_init() functions when you use
3639         that namespace.
3640         (quit):
3641         (main):
3642
3643 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3644
3645         Reviewed by Tony Ch