Tools/ChangeLog

   1 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
   2
   3         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
   4         https://bugs.webkit.org/show_bug.cgi?id=146308
   5
   6         Reviewed by Csaba Osztrogonác.
   7
   8         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
   9
  10         * Scripts/webkitperl/FeatureList.pm:
  11
  12 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
  13
  14         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
  15         https://bugs.webkit.org/show_bug.cgi?id=146149
  16
  17         Reviewed by Sergio Villar Senin.
  18
  19         Update unit tests to use WebKitWebsiteDataManager.
  20
  21         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
  22         (testWebContextConfiguration):
  23         (serverCallback):
  24         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
  25         (Test::Test): Use WebKitWebsiteDataManager and set all possible
  26         values to ensure unit tests don't write outside the temporary directory.
  27         (Test::~Test): Explicitly reset the web context to ensure its
  28         objects are released before the leaks check.
  29         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
  30         (WebViewTest::wait): Fix the GSource used, since we are receiving
  31         a double in seconds, but using g_timeout_add_seconds() that
  32         expects an unsigned in seconds. Use GMainLoopSource to correctly
  33         handle the value and simplify the code.
  34
  35 2015-06-24  Jason Marcell  <jmarcell@apple.com>
  36
  37         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
  38         https://bugs.webkit.org/show_bug.cgi?id=146126
  39         <rdar://problem/18226291>
  40
  41         Reviewed by Alexey Proskuryakov.
  42
  43         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
  44         (documentReady): Using combined queues to display iOS projects
  45
  46 2015-06-24  Doug Russell  <d_russell@apple.com>
  47
  48         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject
  49         when posting a selection notification when on the border between two accessibilityObjects
  50         https://bugs.webkit.org/show_bug.cgi?id=146177
  51
  52         Reviewed by Darin Adler.
  53
  54         Add support for mapping WebCore Accessibility types into JSValueRef types
  55         so they can be used in tests.
  56
  57         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
  58         (webAccessibilityObjectWrapperClass):
  59         (-[AccessibilityNotificationHandler startObserving]):
  60         (makeValueRefForValue):
  61         (makeArrayRefForArray):
  62         (makeObjectRefForDictionary):
  63         (-[AccessibilityNotificationHandler _notificationReceived:]):
  64         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
  65         (webAccessibilityObjectWrapperClass):
  66         (-[AccessibilityNotificationHandler startObserving]):
  67         (makeValueRefForValue):
  68         (makeArrayRefForArray):
  69         (makeObjectRefForDictionary):
  70         (-[AccessibilityNotificationHandler _notificationReceived:]):
  71
  72 2015-06-24  Zalan Bujtas  <zalan@apple.com>
  73
  74         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
  75         https://bugs.webkit.org/show_bug.cgi?id=146273
  76         rdar://problem/18509840
  77
  78         Reviewed by Simon Fraser.
  79
  80         Due to the floating point approximate representation, we can't always produce
  81         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
  82         and by changing the rounding in roundToDevicePixel() from float to double.
  83
  84         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
  85         (TestWebKitAPI::TEST):
  86
  87 2015-06-24  Brady Eidson  <beidson@apple.com>
  88
  89         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
  90         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
  91
  92         Reviewed by Alex Christensen.
  93
  94         - Update WKTR to the new client structure.
  95         - Update existing TestWebKitAPI tests to either use the new client structure or
  96           assign the old function signature to the updated variable name.
  97         - Include a new test.
  98
  99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 100
 101         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
 102         (TestWebKitAPI::runJavaScriptAlert):
 103
 104         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 105         (TestWebKitAPI::TEST):
 106
 107         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
 108         (TestWebKitAPI::analyzeDialogArguments):
 109         (TestWebKitAPI::runJavaScriptAlert):
 110         (TestWebKitAPI::runJavaScriptConfirm):
 111         (TestWebKitAPI::runJavaScriptPrompt):
 112         (TestWebKitAPI::createNewPage):
 113         (TestWebKitAPI::TEST):
 114
 115         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
 116         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
 117
 118         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 119         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
 120
 121         * WebKitTestRunner/TestController.cpp:
 122         (WTR::TestController::createOtherPage):
 123         (WTR::TestController::createWebViewWithOptions):
 124
 125 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
 126
 127         Refactoring benchmark runner script to follow pep8 code style.
 128         https://bugs.webkit.org/show_bug.cgi?id=146264
 129
 130         Reviewed by Ryosuke Niwa.
 131
 132         Refactor benchmark runner script to follow pep8 code style.
 133
 134         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
 135         (GenericBenchmarkBuilder.prepare):
 136         (GenericBenchmarkBuilder._run_create_script):
 137         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
 138         (GenericBenchmarkBuilder._fetch_remote_archive):
 139         (GenericBenchmarkBuilder):
 140         (GenericBenchmarkBuilder._checkout_with_subversion):
 141         (GenericBenchmarkBuilder._apply_patch):
 142         (GenericBenchmarkBuilder.clean):
 143         (GenericBenchmarkBuilder._runCreateScript): Deleted.
 144         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
 145         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
 146         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
 147         (GenericBenchmarkBuilder._applyPatch): Deleted.
 148         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 149         (BenchmarkRunner.__init__):
 150         (BenchmarkRunner._find_plan_file):
 151         (BenchmarkRunner.execute):
 152         (BenchmarkRunner._cleanup):
 153         (BenchmarkRunner._dump):
 154         (BenchmarkRunner._wrap):
 155         (BenchmarkRunner._merge):
 156         (BenchmarkRunner._show_results):
 157         (BenchmarkRunner._findPlanFile): Deleted.
 158         (BenchmarkRunner.cleanup): Deleted.
 159         (BenchmarkRunner.dump): Deleted.
 160         (BenchmarkRunner.wrap): Deleted.
 161         (BenchmarkRunner.merge): Deleted.
 162         (BenchmarkRunner.show_results): Deleted.
 163         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 164         (BrowserDriver.prepare_env):
 165         (BrowserDriver.launch_url):
 166         (BrowserDriver.close_browsers):
 167         (BrowserDriver.prepareEnv): Deleted.
 168         (BrowserDriver.launchUrl): Deleted.
 169         (BrowserDriver.closeBrowser): Deleted.
 170         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 171         (OSXBrowserDriver):
 172         (OSXBrowserDriver.prepare_env):
 173         (OSXBrowserDriver.close_browsers):
 174         (OSXBrowserDriver._launch_process):
 175         (OSXBrowserDriver._terminiate_processes):
 176         (OSXBrowserDriver._launch_process_with_caffinate):
 177         (OSXBrowserDriver._screen_size):
 178         (OSXBrowserDriver.prepareEnv): Deleted.
 179         (OSXBrowserDriver.closeBrowsers): Deleted.
 180         (OSXBrowserDriver.launchProcess): Deleted.
 181         (OSXBrowserDriver.terminateProcesses): Deleted.
 182         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
 183         (OSXBrowserDriver.screenSize): Deleted.
 184         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 185         (OSXChromeDriver):
 186         (OSXChromeDriver.launch_url):
 187         (OSXChromeCanaryDriver):
 188         (OSXChromeCanaryDriver.launch_url):
 189         (OSXChromeDriver.launchUrl): Deleted.
 190         (OSXChromeCanaryDriver.launchUrl): Deleted.
 191         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 192         (OSXFirefoxDriver):
 193         (OSXFirefoxDriver.launch_url):
 194         (OSXFirefoxNightlyDriver):
 195         (OSXFirefoxNightlyDriver.launch_url):
 196         (OSXFirefoxDriver.launchUrl): Deleted.
 197         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
 198         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 199         (OSXSafariDriver):
 200         (OSXSafariDriver.prepare_env):
 201         (OSXSafariDriver.launch_url):
 202         (OSXSafariDriver.close_browsers):
 203         (OSXSafariDriver._maximize_window):
 204         (OSXSafariDriver.prepareEnv): Deleted.
 205         (OSXSafariDriver.launchUrl): Deleted.
 206         (OSXSafariDriver.closeBrowsers): Deleted.
 207         (OSXSafariDriver.maximizeWindow): Deleted.
 208         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 209         (HTTPServerDriver.fetch_result):
 210         (HTTPServerDriver.kill_server):
 211         (HTTPServerDriver.get_return_code):
 212         (HTTPServerDriver.set_device_id):
 213         (HTTPServerDriver.fetchResult): Deleted.
 214         (HTTPServerDriver.killServer): Deleted.
 215         (HTTPServerDriver.getReturnCode): Deleted.
 216         (HTTPServerDriver.setDeviceID): Deleted.
 217         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
 218         (SimpleHTTPServerDriver.serve):
 219         (SimpleHTTPServerDriver.base_url):
 220         (SimpleHTTPServerDriver.fetch_result):
 221         (SimpleHTTPServerDriver.kill_server):
 222         (SimpleHTTPServerDriver.get_return_code):
 223         (SimpleHTTPServerDriver): Deleted.
 224         (SimpleHTTPServerDriver.baseUrl): Deleted.
 225         (SimpleHTTPServerDriver.fetchResult): Deleted.
 226         (SimpleHTTPServerDriver.killServer): Deleted.
 227         (SimpleHTTPServerDriver.getReturnCode): Deleted.
 228         * Scripts/webkitpy/benchmark_runner/utils.py:
 229         (get_path_from_project_root):
 230         (force_remove):
 231         (getPathFromProjectRoot): Deleted.
 232         (forceRemove): Deleted.
 233
 234 2015-06-23  Anders Carlsson  <andersca@apple.com>
 235
 236         Add operator! and copy/move constructors to WeakObjCPtr
 237         https://bugs.webkit.org/show_bug.cgi?id=146255
 238
 239         Reviewed by Andreas Kling.
 240
 241         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
 242         (TEST):
 243
 244 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
 245
 246         Expose some more rendering progress events, and have MiniBrowser log for each of them
 247         https://bugs.webkit.org/show_bug.cgi?id=146227
 248
 249         Reviewed by Darin Adler.
 250
 251         Register for layout milestones/rendering progress events in the WK1 and WK2
 252         browser window controllers, and, if logging is turned on, log when they are
 253         reached.
 254
 255         * MiniBrowser/mac/WK1BrowserWindowController.m:
 256         (-[WK1BrowserWindowController awakeFromNib]):
 257         (-[WK1BrowserWindowController webView:didLayout:]):
 258         * MiniBrowser/mac/WK2BrowserWindowController.m:
 259         (-[WK2BrowserWindowController awakeFromNib]):
 260         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
 261
 262 2015-06-23  Brady Eidson  <beidson@apple.com>
 263
 264         WKFrameInfo should have an accessor for the Frame's current security origin.
 265         https://bugs.webkit.org/show_bug.cgi?id=146162
 266
 267         Reviewed by Dan Bernstein.
 268
 269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 270         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
 271         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
 272         (sawDialog):
 273         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
 274         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
 275         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
 276         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
 277         (TEST):
 278
 279 2015-06-23  Tanay C  <tanay.c@samsung.com>
 280
 281         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
 282         https://bugs.webkit.org/show_bug.cgi?id=146007
 283
 284         Reviewed by Darin Adler.
 285
 286         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 287         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
 288         (pluginLogWithWindowObject):
 289         (pluginLogWithArguments):
 290         (pluginLog):
 291         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
 292         (PluginTest::executeScript):
 293         (PluginTest::log):
 294
 295 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
 296
 297         [EFL] Add libhyphen-dev as dependency after r185862
 298         https://bugs.webkit.org/show_bug.cgi?id=146230
 299
 300         Reviewed by Gyuyoung Kim.
 301
 302         * efl/install-dependencies:
 303
 304 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
 305
 306         [EFL] Hyphenation is not supported
 307         https://bugs.webkit.org/show_bug.cgi?id=89830
 308
 309         Reviewed by Gyuyoung Kim.
 310
 311         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
 312
 313 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
 314
 315         Get rid of factory json files in benchmark_runner
 316         https://bugs.webkit.org/show_bug.cgi?id=146175
 317
 318         Reviewed by Ryosuke Niwa.
 319
 320         Get rid of factory json files in benchmark_runner and refactoring the code.
 321
 322         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
 323         (benchmark_builder_loader):
 324         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
 325         (BenchmarkBuilderFactory):
 326         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
 327         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
 328         (GenericBenchmarkBuilder):
 329         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 330         (BenchmarkRunner.__init__):
 331         (BenchmarkRunner.execute):
 332         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
 333         (browser_driver_loader):
 334         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 335         (BrowserDriver):
 336         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
 337         (BrowserDriverFactory):
 338         (BrowserDriverFactory.available_platforms):
 339         (BrowserDriverFactory.available_browsers):
 340         (BrowserDriverFactory.add_browser_driver):
 341         (BrowserDriverFactory.create):
 342         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
 343         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 344         (OSXBrowserDriver):
 345         (OSXBrowserDriver.prepareEnv):
 346         (OSXBrowserDriver.terminateProcesses):
 347         (OSXBrowserDriver.screenSize):
 348         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 349         (OSXChromeDriver):
 350         (OSXChromeCanaryDriver):
 351         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 352         (OSXFirefoxDriver):
 353         (OSXFirefoxNightlyDriver):
 354         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 355         (OSXSafariDriver):
 356         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
 357         (GenericFactory.create):
 358         (GenericFactory.add):
 359         (GenericFactory.iterateGetItem): Deleted.
 360         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
 361         (http_server_driver_loader):
 362         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 363         (HTTPServerDriver):
 364         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
 365         (HTTPServerDriverFactory):
 366         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
 367         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
 368         (SimpleHTTPServerDriver):
 369         * Scripts/webkitpy/benchmark_runner/utils.py:
 370         (is_subclass):
 371         (load_subclasses):
 372         (ModuleNotFoundError): Deleted.
 373         (loadModule): Deleted.
 374         (loadJSONFromFile): Deleted.
 375
 376 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
 377
 378         Make it possible to enable incremental rendering suppression in MiniBrowser
 379         https://bugs.webkit.org/show_bug.cgi?id=146223
 380
 381         Reviewed by Tim Horton.
 382
 383         Add a menu item to enable incremental rendering suppression to MiniBrowser.
 384
 385         For WK1, this just toggles a pref, and takes effect immediately.
 386
 387         For WK2, this is a WKConfiguration property, so only affects new web views.
 388
 389         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
 390         logging on launch.
 391
 392         * MiniBrowser/mac/AppDelegate.m:
 393         (defaultConfiguration):
 394         * MiniBrowser/mac/BrowserWindow.xib:
 395         * MiniBrowser/mac/SettingsController.h:
 396         * MiniBrowser/mac/SettingsController.m:
 397         (-[SettingsController _populateMenu]):
 398         (-[SettingsController validateMenuItem:]):
 399         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
 400         (-[SettingsController incrementalRenderingSuppressed]):
 401         * MiniBrowser/mac/WK1BrowserWindowController.m:
 402         (-[WK1BrowserWindowController didChangeSettings]):
 403
 404 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
 405
 406         Run CDjs as part of JSC stress testing
 407         https://bugs.webkit.org/show_bug.cgi?id=146174
 408
 409         Reviewed by Geoffrey Garen.
 410
 411         * Scripts/run-javascriptcore-tests:
 412         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
 413         * Scripts/run-jsc-stress-tests:
 414         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
 415         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
 416         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
 417
 418 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
 419
 420         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
 421         https://bugs.webkit.org/show_bug.cgi?id=146121
 422         rdar://problem/21395180
 423
 424         Reviewed by Darin Adler.
 425
 426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 427         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
 428         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
 429         (TestWebKitAPI::overrideAppleLanguages):
 430         (TestWebKitAPI::languageForSystemLanguage):
 431         (TestWebKitAPI::TEST):
 432
 433 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 434
 435         [CMake] Ignore warnings from system headers when compiling Tools
 436         https://bugs.webkit.org/show_bug.cgi?id=146185
 437
 438         Reviewed by Martin Robinson.
 439
 440         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
 441         from system headers that we don't control.
 442
 443         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 444         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
 445         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
 446         * ImageDiff/PlatformGTK.cmake:
 447         * MiniBrowser/efl/CMakeLists.txt:
 448         * MiniBrowser/gtk/CMakeLists.txt:
 449         * TestWebKitAPI/PlatformEfl.cmake:
 450         * TestWebKitAPI/PlatformGTK.cmake:
 451         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
 452         * WebKitTestRunner/CMakeLists.txt:
 453         * WebKitTestRunner/PlatformEfl.cmake:
 454         * WebKitTestRunner/PlatformGTK.cmake:
 455
 456 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
 457
 458         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
 459         https://bugs.webkit.org/show_bug.cgi?id=146186
 460
 461         Reviewed by Martin Robinson.
 462
 463         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
 464         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
 465
 466         * MiniBrowser/gtk/CMakeLists.txt:
 467
 468 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
 469
 470         Build fix after r146125.
 471
 472         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 473         (OSXSafariDriver):
 474         (OSXSafariDriver.prepareEnv):
 475
 476 2015-06-19  Brady Eidson  <beidson@apple.com>
 477
 478         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
 479         https://bugs.webkit.org/show_bug.cgi?id=146152
 480
 481         Reviewed by Dan Bernstein.
 482
 483         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 484         * WebKitTestRunner/WebNotificationProvider.cpp:
 485
 486 2015-06-19  Mark Lam  <mark.lam@apple.com>
 487
 488         CheckedArithmetic's operator bool() and operator==() is broken.
 489         https://bugs.webkit.org/show_bug.cgi?id=146129
 490
 491         Reviewed by Geoffrey Garen and Oliver Hunt.
 492
 493         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
 494         and overflow scenarios in usage of the Checked arithmetic class.
 495
 496         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 497         (TestWebKitAPI::OverflowCrashLogger::overflowed):
 498         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
 499         (TestWebKitAPI::OverflowCrashLogger::crash):
 500         (TestWebKitAPI::OverflowCrashLogger::reset):
 501         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
 502         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
 503         (TestWebKitAPI::OverflowCrashLogger::didCrash):
 504         - crash logger for verifying that a crash occurs when expected.
 505
 506         (TestWebKitAPI::resetOverflow):
 507         - convenience function for resetting a test value to an initial overflowed state
 508           before a crash.  We will use this value in the overflow testing.
 509
 510         (TestWebKitAPI::CheckedArithmeticTester::run):
 511         - Added new tests for all the comparison operators.
 512
 513 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
 514
 515         Fix the Windows build after r185721
 516         https://bugs.webkit.org/show_bug.cgi?id=146146
 517
 518         Reviewed by Csaba Osztrogonác.
 519
 520         Speculative buildfix.
 521
 522         * DumpRenderTree/win/UIDelegate.h:
 523         (UIDelegate::unused4): Added.
 524         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
 525
 526 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
 527
 528         Unreviewed. Add myself as a committer.
 529
 530         * Scripts/webkitpy/common/config/contributors.json:
 531
 532 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
 533
 534         Remove unnecessary svn:executable flags
 535         https://bugs.webkit.org/show_bug.cgi?id=146107
 536
 537         Reviewed by Alexey Proskuryakov.
 538
 539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
 540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
 541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
 542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
 543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
 544         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
 545         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
 546         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
 547         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
 548         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
 549         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
 550         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
 551         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
 552         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
 553
 554 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
 555
 556         Disable tests on the WinCairo buildbot
 557         https://bugs.webkit.org/show_bug.cgi?id=146106
 558
 559         Reviewed by Alexey Proskuryakov.
 560
 561         * BuildSlaveSupport/build.webkit.org-config/config.json:
 562         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 563
 564 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
 565
 566         [EFL] Fix the minibrowser after r185725
 567         https://bugs.webkit.org/show_bug.cgi?id=146135
 568
 569         Reviewed by Gyuyoung Kim.
 570
 571         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
 572         for the elm_config_accel_preference_set() to set the config of acceleration preference.
 573
 574         * MiniBrowser/efl/main.c:
 575         (elm_main): Deleted the HAVE_ECORE_X guard.
 576
 577 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
 578
 579         Extend capability of run-benchmark script to support mobile device
 580         https://bugs.webkit.org/show_bug.cgi?id=146125
 581
 582         Reviewed by Ryosuke Niwa.
 583
 584         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
 585         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
 586
 587         * Scripts/run-benchmark:
 588         (main): Deleted.
 589         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 590         (BenchmarkRunner.__init__):
 591         (BenchmarkRunner.execute):
 592         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 593         (BrowserDriver.prepareEnv):
 594         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 595         (OSXBrowserDriver.prepareEnv):
 596         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 597         (OSXSafariDriver.prepareEnv):
 598         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 599         (HTTPServerDriver.getReturnCode):
 600         (HTTPServerDriver):
 601         (HTTPServerDriver.setDeviceID):
 602         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
 603         (parse_args):
 604         (start):
 605         (main):
 606         * Scripts/webkitpy/benchmark_runner/utils.py:
 607         (getPathFromProjectRoot):
 608
 609 2015-06-18  Jon Lee  <jonlee@apple.com>
 610
 611         Unreviewed. Add Matt Daiter as a contributor.
 612
 613         * Scripts/webkitpy/common/config/contributors.json:
 614
 615 2015-06-18  Mark Lam  <mark.lam@apple.com>
 616
 617         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
 618         https://bugs.webkit.org/show_bug.cgi?id=146103
 619
 620         Not reviewed.
 621
 622         Follow up to fix some typos not caught before original patch was landed.
 623
 624         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 625         (TestWebKitAPI::CheckedArithmeticTester::run):
 626         (TestWebKitAPI::AllowMixedSignednessTest::run):
 627         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
 628
 629 2015-06-18  Daniel Bates  <dabates@apple.com>
 630
 631         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
 632         https://bugs.webkit.org/show_bug.cgi?id=146082
 633
 634         Reviewed by Darin Adler.
 635
 636         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
 637         working directory after being invoked in a different Git checkout. In particular,
 638         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
 639         a pure Git checkout g will fail to update g.
 640
 641         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
 642         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
 643         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
 644         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
 645         different than the current working directory). Instead runGitUpdate() should check
 646         whether the current working directory is a Git SVN checkout on each invocation.
 647
 648         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
 649         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
 650         SVN directory from isGitSVN().
 651         (isGitSVN): Implemented in terms of isGitSVNDirectory().
 652         * Scripts/webkitdirs.pm:
 653         (runGitUpdate): Modified to use isGitSVNDirectory().
 654
 655 2015-06-18  Mark Lam  <mark.lam@apple.com>
 656
 657         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
 658         https://bugs.webkit.org/show_bug.cgi?id=146103
 659
 660         Reviewed by Anders Carlsson.
 661
 662         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
 663         part of a large macro.  This makes them harder to:
 664
 665         1. write: no editor help with indentations, have to add trailing '\'s,
 666            inconvenient to add line breaks and comments.
 667
 668         2. read: no chroma coding / syntax highlighting.
 669
 670         3. debug: compile time errors are reported as being on the single line where
 671            the macro is used.
 672
 673         Refactoring the tests to use C++ templates solves all these issues.
 674
 675         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 676         (TestWebKitAPI::CheckedArithmeticTester::run):
 677         (TestWebKitAPI::AllowMixedSignednessTest::run):
 678         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
 679         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
 680         (TestWebKitAPI::CoerceLiteralNop::coerce):
 681
 682 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 683
 684         [EFL][WK2] Use Web Browser cache model in MiniBrowser
 685         https://bugs.webkit.org/show_bug.cgi?id=112273
 686
 687         Reviewed by Laszlo Gombos.
 688
 689         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
 690         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
 691         This way we have a decent cache capacity and the page cache actually works.
 692
 693         * MiniBrowser/efl/main.c:
 694         (elm_main):
 695
 696 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 697
 698         Remove redundant Chromium bug keyword
 699         https://bugs.webkit.org/show_bug.cgi?id=146097
 700
 701         Reviewed by Csaba Osztrogonác.
 702
 703         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 704         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
 705         (TestExpectationLine._format_line): Deleted.
 706
 707 2015-06-17  Daniel Bates  <dabates@apple.com>
 708
 709         Client may receive began editing callback for already focused text field
 710         https://bugs.webkit.org/show_bug.cgi?id=146074
 711         <rdar://problem/21293562>
 712
 713         Reviewed by Darin Adler.
 714
 715         Add a unit test to ensure that a client receives exactly one began editing
 716         callback when a text field is newly focused. In particular, dispatching
 717         a DOM focus event at an already focused text field does not dispatch a
 718         began editing callback to the client.
 719
 720         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
 721         (TestWebKitAPI::TEST_F):
 722
 723 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
 724
 725         [Win]Implement layoutTestController.dispatchPendingLoadRequests.
 726         https://bugs.webkit.org/show_bug.cgi?id=26481
 727
 728         Reviewed by Darin Adler.
 729
 730         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
 731
 732         * DumpRenderTree/win/TestRunnerWin.cpp:
 733         (TestRunner::dispatchPendingLoadRequests):
 734         (TestRunner::overridePreference):
 735
 736 2015-06-17  Alex Christensen  <achristensen@webkit.org>
 737
 738         [Content Extensions] Fail to parse invalid arrays
 739         https://bugs.webkit.org/show_bug.cgi?id=146079
 740         rdar://problem/21422649
 741
 742         Reviewed by Benjamin Poulain.
 743
 744         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 745         (TestWebKitAPI::TEST_F):
 746         Correct and add parsing tests with invalid arrays.
 747
 748 2015-06-17  Matt Rajca  <mrajca@apple.com>
 749
 750         Unreviewed. Added myself as a committer.
 751
 752         * Scripts/webkitpy/common/config/contributors.json:
 753
 754 2015-06-17  Daniel Bates  <dabates@apple.com>
 755
 756         Export VCSUtils::gitTreeDirectory()
 757         <rdar://problem/21248901>
 758
 759         Rubber-stamped by Alexey Proskuryakov.
 760
 761         * Scripts/VCSUtils.pm:
 762
 763 2015-06-17  Tim Horton  <timothy_horton@apple.com>
 764
 765         Safari tabs still have shrunken content after coming out of fullscreen
 766         https://bugs.webkit.org/show_bug.cgi?id=146037
 767         <rdar://problem/21105960>
 768
 769         Reviewed by Simon Fraser and Darin Adler.
 770
 771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 772         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
 773         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
 774         (TEST):
 775         Add a test that ensures that disabling scale-to-fit mode correctly updates
 776         the page's layout.
 777
 778 2015-06-17  Dan Bernstein  <mitz@apple.com>
 779
 780         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
 781         https://bugs.webkit.org/show_bug.cgi?id=145957
 782
 783         Reviewed by Darin Adler.
 784
 785         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
 786         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
 787
 788 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
 789
 790         AX:  iOS accessibility tests are not running because we need WKTR support
 791         https://bugs.webkit.org/show_bug.cgi?id=145991
 792
 793         Reviewed by Daniel Bates.
 794
 795         Add support for WKTR iOS accessibility.
 796         Utilize the notification handling mechanisms that Mac already uses.
 797         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
 798
 799         * DumpRenderTree/AccessibilityUIElement.cpp:
 800         (stringForSelectionCallback):
 801         (getIdentifierCallback):
 802         (getTraitsCallback):
 803         (getElementTextPositionCallback):
 804         (getElementTextLengthCallback):
 805         (AccessibilityUIElement::getJSClass):
 806         (getIPhoneLabelCallback): Deleted.
 807         (getIPhoneHintCallback): Deleted.
 808         (getIPhoneValueCallback): Deleted.
 809         (getIPhoneIdentifierCallback): Deleted.
 810         (getIPhoneTraitsCallback): Deleted.
 811         (getIPhoneIsElementCallback): Deleted.
 812         (getIPhoneElementTextPositionCallback): Deleted.
 813         (getIPhoneElementTextLengthCallback): Deleted.
 814         * DumpRenderTree/AccessibilityUIElement.h:
 815         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 816         (AccessibilityUIElement::identifier):
 817         (AccessibilityUIElement::traits):
 818         (AccessibilityUIElement::elementTextPosition):
 819         (AccessibilityUIElement::elementTextLength):
 820         (AccessibilityUIElement::description):
 821         (AccessibilityUIElement::orientation):
 822         (AccessibilityUIElement::stringValue):
 823         (AccessibilityUIElement::language):
 824         (AccessibilityUIElement::helpText):
 825         (AccessibilityUIElement::intValue):
 826         (AccessibilityUIElement::isSelected):
 827         (AccessibilityUIElement::isExpanded):
 828         (AccessibilityUIElement::documentURI):
 829         (AccessibilityUIElement::addNotificationListener):
 830         (AccessibilityUIElement::removeNotificationListener):
 831         (AccessibilityUIElement::isFocusable):
 832         (AccessibilityUIElement::isIgnored):
 833         (AccessibilityUIElement::hasPopup):
 834         (AccessibilityUIElement::iphoneLabel): Deleted.
 835         (AccessibilityUIElement::iphoneHint): Deleted.
 836         (AccessibilityUIElement::iphoneValue): Deleted.
 837         (AccessibilityUIElement::iphoneIdentifier): Deleted.
 838         (AccessibilityUIElement::iphoneTraits): Deleted.
 839         (AccessibilityUIElement::iphoneIsElement): Deleted.
 840         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
 841         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
 842         (_accessibilityNotificationCallback): Deleted.
 843         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 844         (WTR::AccessibilityUIElement::isValid):
 845         (WTR::AccessibilityUIElement::identifier):
 846         (WTR::AccessibilityUIElement::traits):
 847         (WTR::AccessibilityUIElement::elementTextPosition):
 848         (WTR::AccessibilityUIElement::elementTextLength):
 849         (WTR::AccessibilityUIElement::stringForSelection):
 850         (WTR::AccessibilityUIElement::elementsForRange):
 851         (WTR::AccessibilityUIElement::increaseTextSelection):
 852         (WTR::AccessibilityUIElement::decreaseTextSelection):
 853         (WTR::AccessibilityUIElement::linkedElement):
 854         (WTR::AccessibilityUIElement::headerElementAtIndex):
 855         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
 856         (WTR::AccessibilityUIElement::characterAtOffset):
 857         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 858         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 859         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
 860         (WTR::findAccessibleObjectById):
 861         (WTR::AccessibilityController::accessibleElementById):
 862         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 863         (+[NSString stringWithJSStringRef:]):
 864         (-[NSString createJSStringRef]):
 865         (WTR::convertNSArrayToVector):
 866         (WTR::concatenateAttributeAndValue):
 867         (WTR::AccessibilityUIElement::AccessibilityUIElement):
 868         (WTR::AccessibilityUIElement::isEqual):
 869         (WTR::AccessibilityUIElement::headerElementAtIndex):
 870         (WTR::AccessibilityUIElement::linkedElement):
 871         (WTR::AccessibilityUIElement::getLinkedUIElements):
 872         (WTR::AccessibilityUIElement::elementAtPoint):
 873         (WTR::convertElementsToObjectArray):
 874         (WTR::AccessibilityUIElement::elementsForRange):
 875         (WTR::AccessibilityUIElement::indexOfChild):
 876         (WTR::AccessibilityUIElement::stringAttributeValue):
 877         (WTR::AccessibilityUIElement::description):
 878         (WTR::AccessibilityUIElement::orientation):
 879         (WTR::AccessibilityUIElement::stringValue):
 880         (WTR::AccessibilityUIElement::language):
 881         (WTR::AccessibilityUIElement::helpText):
 882         (WTR::AccessibilityUIElement::x):
 883         (WTR::AccessibilityUIElement::clickPointX):
 884         (WTR::AccessibilityUIElement::clickPointY):
 885         (WTR::AccessibilityUIElement::intValue):
 886         (WTR::AccessibilityUIElement::minValue):
 887         (WTR::AccessibilityUIElement::maxValue):
 888         (WTR::AccessibilityUIElement::valueDescription):
 889         (WTR::AccessibilityUIElement::isSelected):
 890         (WTR::AccessibilityUIElement::isSelectedOptionActive):
 891         (WTR::AccessibilityUIElement::stringForRange):
 892         (WTR::AccessibilityUIElement::attributedStringForRange):
 893         (WTR::AccessibilityUIElement::attributesOfHeader):
 894         (WTR::AccessibilityUIElement::traits):
 895         (WTR::AccessibilityUIElement::identifier):
 896         (WTR::AccessibilityUIElement::rowCount):
 897         (WTR::AccessibilityUIElement::rowIndexRange):
 898         (WTR::AccessibilityUIElement::columnIndexRange):
 899         (WTR::AccessibilityUIElement::cellForColumnAndRow):
 900         (WTR::AccessibilityUIElement::horizontalScrollbar):
 901         (WTR::AccessibilityUIElement::documentURI):
 902         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
 903         (WTR::AccessibilityUIElement::increaseTextSelection):
 904         (WTR::AccessibilityUIElement::decreaseTextSelection):
 905         (WTR::AccessibilityUIElement::stringForSelection):
 906         (WTR::AccessibilityUIElement::elementTextPosition):
 907         (WTR::AccessibilityUIElement::elementTextLength):
 908         (WTR::AccessibilityUIElement::url):
 909         (WTR::AccessibilityUIElement::addNotificationListener):
 910         (WTR::AccessibilityUIElement::removeNotificationListener):
 911         (WTR::AccessibilityUIElement::isFocusable):
 912         (WTR::AccessibilityUIElement::isIgnored):
 913         (WTR::AccessibilityUIElement::hasPopup):
 914         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
 915         (WTR::_CGPathEnumerationIteration):
 916         (WTR::AccessibilityUIElement::pathDescription):
 917         (WTR::AccessibilityUIElement::supportedActions):
 918
 919 2015-06-16  Mark Lam  <mark.lam@apple.com>
 920
 921         Use NakedPtr<Exception>& to return exception results.
 922         https://bugs.webkit.org/show_bug.cgi?id=145870
 923
 924         Reviewed by Anders Carlsson and Filip Pizlo.
 925
 926         * TestWebKitAPI/CMakeLists.txt:
 927         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 928         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 930         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
 931         (TestWebKitAPI::TEST):
 932         (TestWebKitAPI::nakedPtrFoo):
 933
 934 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
 935
 936         Unreviewed. Adding myself as a committer.
 937
 938         * Scripts/webkitpy/common/config/contributors.json:
 939
 940 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
 941
 942         Add test expectations for El Capitan
 943         https://bugs.webkit.org/show_bug.cgi?id=146005
 944
 945         Rubber-stamped by Dan Bernstein.
 946
 947         Add appropriate tools code.
 948
 949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
 950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
 951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 953         Added dashboard support.
 954
 955         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 956         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
 957         Trigger the right build queues on check-in.
 958
 959         * Scripts/webkitpy/common/system/platforminfo.py:
 960         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
 961         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 962         * Scripts/webkitpy/port/mac.py:
 963         * Scripts/webkitpy/port/mac_unittest.py:
 964         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 965         * TestResultServer/static-dashboards/flakiness_dashboard.js:
 966         Added cases for El Capitan, and updated tests for new baseline search paths.
 967
 968 2015-06-15  Alex Christensen  <achristensen@webkit.org>
 969
 970         [Content Extensions] Make max NFA size and max rule count user defaults.
 971         https://bugs.webkit.org/show_bug.cgi?id=145663
 972
 973         Reviewed by Benjamin Poulain.
 974
 975         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 976         (TestWebKitAPI::TEST_F):
 977
 978 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
 979
 980         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
 981         https://bugs.webkit.org/show_bug.cgi?id=145900
 982
 983         Reviewed by Sam Weinig.
 984
 985         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
 986         (TEST): Added tests.
 987
 988 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
 989
 990         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
 991         https://bugs.webkit.org/show_bug.cgi?id=145969
 992
 993         Reviewed by Sergio Villar Senin.
 994
 995         Add a test case to the custom URI schemes unit test.
 996
 997         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
 998         (testWebContextURIScheme):
 999
1000 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1001
1002         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
1003         https://bugs.webkit.org/show_bug.cgi?id=145922
1004
1005         Reviewed by Carlos Garcia Campos.
1006
1007         * gtk/jhbuild.modules:
1008         * gtk/patches/glib-warning-fix.patch: Added.
1009
1010 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1011
1012         Update springLoadingHighlight type
1013         https://bugs.webkit.org/show_bug.cgi?id=145939
1014         rdar://problem/20880213
1015
1016         Reviewed by Darin Adler.
1017
1018         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1019         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1020         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1021         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1022
1023 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
1024
1025         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
1026         https://bugs.webkit.org/show_bug.cgi?id=145945
1027
1028         Reviewed by Stephanie Lewis.
1029
1030         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1031         (OSXBrowserDriver.prepareEnv):
1032         (OSXBrowserDriver.moveCursor): Deleted.
1033         (OSXBrowserDriver): Deleted.
1034         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1035         (OSXSafariDriver.prepareEnv):
1036
1037 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
1038
1039         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
1040         https://bugs.webkit.org/show_bug.cgi?id=145938
1041
1042         Reviewed by Alexey Proskuryakov.
1043
1044         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1045         LWP::UserAgent to get access to more robust HTTPS support.
1046
1047 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1048
1049         [GTK] Fix return type warning in WebViewTest.cpp
1050         https://bugs.webkit.org/show_bug.cgi?id=145914
1051
1052         Reviewed by Darin Adler.
1053
1054         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1055         (WebViewTest::isEditable):
1056
1057 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1058
1059         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1060         https://bugs.webkit.org/show_bug.cgi?id=145799
1061
1062         Reviewed by Carlos Garcia Campos.
1063
1064         Update header inclusions for headers that have been moved
1065         to Source/WTF/wtf/glib/.
1066
1067         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1068         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1069
1070         * TestWebKitAPI/PlatformGTK.cmake:
1071         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1072         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1073         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1074         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1075         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1076         (TestWebKitAPI::GMainLoopSourceTest::finish):
1077         (TestWebKitAPI::GMainLoopSourceTest::source):
1078         (TestWebKitAPI::basicRescheduling):
1079         (TestWebKitAPI::TEST):
1080         (TestWebKitAPI::reentrantRescheduling):
1081         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1082         (TestWebKitAPI::basicDestroyCallbacks):
1083         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1084         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1085         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1086         (log):
1087         (takeLogStr):
1088         (TestWebKitAPI::TEST):
1089         (TestWebKitAPI::returnOutChar):
1090         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1091         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1092         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1093         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1094         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1095         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1096         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1097         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1098         (TestWebKitAPI::basicRescheduling): Deleted.
1099         (TestWebKitAPI::TEST): Deleted.
1100         (TestWebKitAPI::reentrantRescheduling): Deleted.
1101         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1102         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1103         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1104         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1105         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1106         (log): Deleted.
1107         (takeLogStr): Deleted.
1108         (TestWebKitAPI::TEST): Deleted.
1109         (TestWebKitAPI::returnOutChar): Deleted.
1110         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1111         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1112         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1113         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1114         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1115         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1116         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1117         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1118         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1119         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1120         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1121         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1122         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1123         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1124         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1125         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1126         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1127         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1128         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1129         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1130         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1131         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1132         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1133         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1134         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1135         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1136         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1137         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1138         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1139         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1140         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1141         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1142         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1144         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1145         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1147         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1148         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1149         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1150         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1151         * WebKitTestRunner/PlatformGTK.cmake:
1152         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1153         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1154
1155 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1156
1157         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1158         https://bugs.webkit.org/show_bug.cgi?id=145913
1159
1160         Reviewed by Gyuyoung Kim.
1161
1162         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1163         (TestWebKitAPI::setupGeolocationProvider):
1164         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1165         (TestWebKitAPI::setPageLoaderClient):
1166         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1167         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1168         * WebKitTestRunner/GeolocationProviderMock.cpp:
1169         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1170         * WebKitTestRunner/WebNotificationProvider.cpp:
1171         (WTR::WebNotificationProvider::provider):
1172
1173 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1174
1175         Fix the libusrsctp build with clang
1176         https://bugs.webkit.org/show_bug.cgi?id=145128
1177
1178         Reviewed by Gyuyoung Kim.
1179
1180         * efl/jhbuild.modules:
1181         * gtk/jhbuild.modules:
1182
1183 2015-06-11  Mark Lam  <mark.lam@apple.com>
1184
1185         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1186         https://bugs.webkit.org/show_bug.cgi?id=145872
1187
1188         Reviewed by Michael Saboff.
1189
1190         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1191         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1192         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1193           exception will be returned as a JSValue instead of an Exception object.  We
1194           will use this JSValue to test WebCore::reportException() to confirm that it is
1195           able to handle an exception value which is not an Exception object.
1196
1197 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1198
1199         Move cursor to corner and fix safari window size before running benchmark
1200         https://bugs.webkit.org/show_bug.cgi?id=145858
1201
1202         Reviewed by Ryosuke Niwa
1203
1204         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1205         (OSXBrowserDriver.prepareEnv):
1206         (OSXBrowserDriver):
1207         (OSXBrowserDriver.moveCursor):
1208         (OSXBrowserDriver.getScreenSize):
1209         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1210         (OSXChromeDriver.launchUrl):
1211         (OSXChromeCanaryDriver.launchUrl):
1212         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1213         (OSXFirefoxDriver.launchUrl):
1214         (OSXFirefoxNightlyDriver.launchUrl):
1215         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1216         (OSXSafariDriver.prepareEnv):
1217         (OSXSafariDriver):
1218         (OSXSafariDriver.maximizeWindow):
1219
1220 2015-06-11  Daniel Bates  <dabates@apple.com>
1221
1222         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1223         https://bugs.webkit.org/show_bug.cgi?id=145319
1224
1225         Reviewed by David Kilzer.
1226
1227         Add SPI wrapper header for CoreSimulator and update the source files to reference
1228         it instead of directly referencing the CoreSimulator header.
1229
1230         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1231         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1232         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1233         * LayoutTestRelay/LayoutTestRelay/main.m:
1234
1235 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1236
1237         [EFL] dimmed area for popup does not cover the fullscreen mode.
1238         https://bugs.webkit.org/show_bug.cgi?id=145133
1239
1240         Reviewed by Gyuyoung Kim.
1241
1242         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1243         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1244
1245         * MiniBrowser/efl/main.c:
1246         (on_fullscreen_accept):
1247         (on_fullscreen_deny):
1248         (on_fullscreen_enter):
1249
1250 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1251
1252         Unreviewed, rolling out r185442.
1253         https://bugs.webkit.org/show_bug.cgi?id=145871
1254
1255         seems to have broken WTF.StringOperators test (Requested by
1256         alexchristensen on #webkit).
1257
1258         Reverted changeset:
1259
1260         "[Content Extensions] Limit number of rules."
1261         https://bugs.webkit.org/show_bug.cgi?id=145663
1262         http://trac.webkit.org/changeset/185442
1263
1264 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1265
1266         [Content Extensions] Make max NFA size and max rule count user defaults.
1267         https://bugs.webkit.org/show_bug.cgi?id=145663
1268         rdar://problem/21242407
1269
1270         Reviewed by Benjamin Poulain.
1271
1272         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1273         (TestWebKitAPI::TEST_F):
1274
1275 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1276
1277         [EFL] Execute Javascript method in mini browser address bar.
1278         https://bugs.webkit.org/show_bug.cgi?id=145725
1279
1280         Reviewed by Gyuyoung Kim.
1281
1282         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1283
1284         * MiniBrowser/efl/main.c:
1285         (url_from_user_input):
1286         (url_load_from_user_input):
1287         (on_url_bar_activated):
1288         (elm_main):
1289
1290 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1291
1292         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1293         https://bugs.webkit.org/show_bug.cgi?id=66773
1294
1295         Reviewed by Darin Adler.
1296
1297         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1298         * DumpRenderTree/win/FrameLoadDelegate.h:
1299
1300 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1301
1302         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1303         https://bugs.webkit.org/show_bug.cgi?id=145764
1304
1305         Reviewed by Darin Adler.
1306
1307         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1308         JetStream and SunSpider.
1309
1310         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1311         (GenericBenchmarkBuilder):
1312         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1313         the whole JSON as the input.
1314         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1315         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1316         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1317         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1318         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1319         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1320         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1321
1322 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1323
1324         Remove ewstool scripts used by chromium port
1325         https://bugs.webkit.org/show_bug.cgi?id=145789
1326
1327         Reviewed by Csaba Osztrogonác.
1328
1329         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1330         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1331         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1332         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1333         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1334
1335 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1336
1337         Unreviewed, updated my list of email addresses.
1338
1339         * Scripts/webkitpy/common/config/contributors.json:
1340
1341 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1342
1343         [cmake] Fix the style issues in cmake project files
1344         https://bugs.webkit.org/show_bug.cgi?id=145755
1345
1346         Reviewed by Darin Adler.
1347
1348         * TestWebKitAPI/CMakeLists.txt:
1349         * TestWebKitAPI/PlatformEfl.cmake:
1350
1351 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1352
1353         Fix a typo in r185345.
1354
1355         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1356         (OSXSafariDriver.closeBrowsers):
1357
1358 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1359
1360         Yet another unreviewed build fix :(
1361
1362         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1363         (OSXSafariDriver):
1364         (OSXSafariDriver.launchUrl):
1365         (OSXSafariDriver.closeBrowsers):
1366
1367 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1368
1369         Unreviewed build fix. Initialize result in the case things blow up below.
1370
1371         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1372         (BenchmarkRunner.execute):
1373
1374 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1375
1376         Partially revert and fix after r185243.
1377
1378         * Scripts/benchmark_runner/benchmark_runner.py:
1379         * Scripts/run-benchmark:
1380
1381 2015-06-08  Daniel Bates  <dabates@apple.com>
1382
1383         Many LayoutTests/http tests time out in DumpRenderTree
1384         https://bugs.webkit.org/show_bug.cgi?id=145770
1385         <rdar://problem/19593910>
1386
1387         Reviewed by Alexey Proskuryakov.
1388
1389         * DumpRenderTree/ios/Info.plist: Add ATS key.
1390         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1391         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1392         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1393         that make use of testRunner.pathToLocalResource().
1394
1395 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1396
1397         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1398         https://bugs.webkit.org/show_bug.cgi?id=145759
1399
1400         Reviewed by Carlos Garcia Campos.
1401
1402         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1403         (testWebViewSave):
1404
1405 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1406
1407         [GTK] Add editor mode to MiniBrowser
1408         https://bugs.webkit.org/show_bug.cgi?id=145595
1409
1410         Reviewed by Sergio Villar Senin.
1411
1412         It loads an empty editable web view with an edit toolbar. It makes
1413         easier to test the editor, editing commands and input methods.
1414
1415         * MiniBrowser/gtk/BrowserWindow.c:
1416         (editingCommandCallback):
1417         (browserWindowSetupEditorToolbar):
1418         (browserWindowConstructed):
1419         * MiniBrowser/gtk/main.c:
1420         (createBrowserWindow):
1421
1422 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1423
1424         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1425
1426         Reviewed by Dan Bernstein.
1427
1428         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1429         (TestWebKitAPI::TEST):
1430
1431 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1432
1433         [EFL] API test has been broken since r184357
1434         https://bugs.webkit.org/show_bug.cgi?id=145635
1435
1436         Reviewed by Darin Adler.
1437
1438         r184357 suppress cmake build warning using TARGET_FILE property. However
1439         many EFL API test cases have been broken after applying it.
1440
1441         * TestWebKitAPI/CMakeLists.txt:
1442
1443 2015-06-05  Anders Carlsson  <andersca@apple.com>
1444
1445         Make the network cache directory part of WKContextConfigurationRef
1446         https://bugs.webkit.org/show_bug.cgi?id=145711
1447
1448         Reviewed by Antti Koivisto.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::TestController::initialize):
1452
1453 2015-06-05  Anders Carlsson  <andersca@apple.com>
1454
1455         Make the application cache directory part of WKContextConfigurationRef
1456         https://bugs.webkit.org/show_bug.cgi?id=145704
1457
1458         Reviewed by Geoffrey Garen.
1459
1460         * WebKitTestRunner/TestController.cpp:
1461         (WTR::TestController::initialize):
1462
1463 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1464
1465         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1466         https://bugs.webkit.org/show_bug.cgi?id=145680
1467
1468         Reviewed by Brent Fulgham.
1469
1470         * Scripts/webkitpy/style/checkers/cpp.py:
1471         (check_for_null):
1472         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1473         (WebKitStyleTest.test_null_false_zero):
1474
1475 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1476
1477         Make the web server more robust to timing issues..
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         Cleaned up exception handling.
1482         Test server is actually serving pages before returning.
1483         Clean up some style issues.
1484
1485         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1486         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1487         (SimpleHTTPServerDriver.__init__):
1488         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1489         (SimpleHTTPServerDriver.baseUrl):
1490         (SimpleHTTPServerDriver.fetchResult):
1491         (SimpleHTTPServerDriver.killServer):
1492         (SimpleHTTPServerDriver.getReturnCode):
1493
1494 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1495
1496
1497         Add errors to run-benchmark exception handling.
1498
1499         Reviewed by Ryosuke Niwa.
1500
1501         * Scripts/run-benchmark:
1502         (main):
1503         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1504         (GenericBenchmarkBuilder.prepare):
1505         (GenericBenchmarkBuilder._runCreateScript):
1506         (GenericBenchmarkBuilder._applyPatch):
1507         (GenericBenchmarkBuilder.clean):
1508         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1509         (BenchmarkRunner.__init__):
1510         (BenchmarkRunner.execute):
1511         (BenchmarkRunner):
1512         (BenchmarkRunner.cleanup):
1513         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1514         (GenericFactory.iterateGetItem):
1515         (GenericFactory.create):
1516         * Scripts/webkitpy/benchmark_runner/utils.py:
1517         (loadModule):
1518         (loadJSONFromFile):
1519         (forceRemove):
1520
1521 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1522
1523         Streamline run-benchmark browser
1524
1525         Reviewed by Ryosuke Niwa.
1526
1527         Add Caffeinate so computer won't sleep while running.
1528         Remove calls to collect output since we were just dumping to stdout anyway.
1529         Add xpc dyld_path.
1530         Default to system safari.
1531
1532         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1533         (OSXBrowserDriver.launchProcess):
1534         (OSXBrowserDriver.terminateProcesses):
1535         (OSXBrowserDriver):
1536         (OSXBrowserDriver.launchCaffeinateForProcess):
1537         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1538         (OSXSafariDriver.launchUrl):
1539         (OSXSafariDriver.closeBrowsers):
1540
1541 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1542
1543         Combine tiny DFAs into slightly larger ones
1544         https://bugs.webkit.org/show_bug.cgi?id=145572
1545
1546         Reviewed by Alex Christensen.
1547
1548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1549         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1550         (TestWebKitAPI::DFACombinerTest::SetUp):
1551         (TestWebKitAPI::combine):
1552         (TestWebKitAPI::TEST_F):
1553         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1554         (TestWebKitAPI::countLiveNodes):
1555         (TestWebKitAPI::createNFAs):
1556         (TestWebKitAPI::buildDFAFromPatterns):
1557         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1558         (TestWebKitAPI::countLiveNodes): Deleted.
1559         (TestWebKitAPI::createNFAs): Deleted.
1560         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1561
1562 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1563
1564         WebKitTestRunner leaks strings in generateWhitelist()
1565         https://bugs.webkit.org/show_bug.cgi?id=145665
1566
1567         Reviewed by Myles C. Maxfield.
1568
1569         * WebKitTestRunner/mac/TestControllerMac.mm:
1570         (WTR::generateWhitelist):
1571
1572 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1573
1574         Fix options in build-jsc for CMake builds
1575         https://bugs.webkit.org/show_bug.cgi?id=145636
1576
1577         Reviewed by Gyuyoung Kim.
1578
1579         CMake only accepts -DXXX=YYY style options.
1580         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1581
1582         * Scripts/build-jsc:
1583
1584 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1585
1586         Added a patch so that the colors displayed on the page could be toggled
1587         in case people need accessibility colors displayed in their browser.
1588         https://bugs.webkit.org/show_bug.cgi?id=145570
1589         <rdar://problem/20994468>
1590
1591         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1592         the page could be rendered in a specific way for accessibility needs if needed.
1593
1594         Reviewed by Alexey Proskuryakov.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1597         (updateHiddenPlatforms):
1598         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1599         (toggleAccessibilityColors): Toggle colors on and off
1600         (documentReady): Needed to make changes to the initialization
1601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1602         (a:hover):
1603         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1604         (div.cellButton.hide, div.accessibilityButton.hide):
1605         (div.cellButton.unhide, div.accessibilityButton.unhide):
1606         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1607         (.popover-tracking:hover):
1608         (.accessibilityButton):
1609         (div.cellButton): Deleted.
1610         (div.cellButton.hide): Deleted.
1611         (div.cellButton.unhide): Deleted.
1612         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1614         (.status-line.neutral .bubble):
1615         (.status-line.unauthorized .bubble):
1616         (.status-line.danger .bubble.pictogram):
1617         (.status-line.bad .bubble.pictogram):
1618         (.status-line.no-bubble .message):
1619         (.status-line.bad .bubble):
1620         (.status-line.good .bubble):
1621         (.status-line.good .message):
1622         (.status-line.bad .message):
1623         (body.accessibility-colors .status-line.good .bubble):
1624         (body.accessibility-colors .status-line.bad .bubble):
1625         (body.accessibility-colors .status-line.good .message):
1626         (body.accessibility-colors .status-line.bad .message):
1627         (.status-line.danger .message):
1628         (.status-line.unauthorized .message):
1629
1630 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1631
1632         Unreviewed build fix for Dromaeo.
1633
1634         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1635         (BenchmarkResults._aggregate_results_for_test):
1636
1637 2015-06-03  Anders Carlsson  <andersca@apple.com>
1638
1639         Fix build.
1640
1641         * DumpRenderTree/mac/TestRunnerMac.mm:
1642
1643 2015-06-03  Daniel Bates  <dabates@apple.com>
1644
1645         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1646         https://bugs.webkit.org/show_bug.cgi?id=145616
1647
1648         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1649         of the test. Further investigation is needed.
1650
1651         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1652         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1653
1654 2015-06-03  Brady Eidson  <beidson@apple.com>
1655
1656         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1657         https://bugs.webkit.org/show_bug.cgi?id=145580
1658
1659         Reviewed by Mark Lam.
1660
1661         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1662         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1663
1664 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1665
1666         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1667
1668         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1669         (TestWebKitAPI::TEST): Update the syntax.
1670
1671 2015-06-02  Mark Lam  <mark.lam@apple.com>
1672
1673         build-jsc's --cloop option is broken.
1674         https://bugs.webkit.org/show_bug.cgi?id=145516
1675
1676         Reviewed by Darin Adler.
1677
1678         * Scripts/build-jsc:
1679         - Make sure to disable the JIT when --cloop is specified.
1680           Did analogous fix for --ftljit.
1681
1682 2015-06-02  Daniel Bates  <dabates@apple.com>
1683
1684         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1685
1686         Rubber-stamped by Alexey Proskuryakov.
1687
1688         * MiniBrowser/mac/Info.plist:
1689         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1690
1691 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1692
1693         Unreviewed, rolling out r185066.
1694         https://bugs.webkit.org/show_bug.cgi?id=145543
1695
1696         it breaks the FTL JIT builds with a local checkout of llvm
1697         (Requested by pizlo on #webkit).
1698
1699         Reverted changeset:
1700
1701         "build-jsc's --cloop option is broken."
1702         https://bugs.webkit.org/show_bug.cgi?id=145516
1703         http://trac.webkit.org/changeset/185066
1704
1705 2015-06-01  Daniel Bates  <dabates@apple.com>
1706
1707         Notify client that we began editing when text field is focused
1708         https://bugs.webkit.org/show_bug.cgi?id=145439
1709         <rdar://problem/21142108>
1710
1711         Reviewed by Anders Carlsson.
1712
1713         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
1714         a text field is focused and defocused.
1715
1716         * TestWebKitAPI/CMakeLists.txt:
1717         * TestWebKitAPI/PlatformEfl.cmake:
1718         * TestWebKitAPI/PlatformGTK.cmake:
1719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1720         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
1721         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
1722         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
1723         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
1724         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1725         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
1726         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
1727         (TestWebKitAPI::TEST_F):
1728         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
1729         (TestWebKitAPI::textFieldDidBeginEditing):
1730         (TestWebKitAPI::textFieldDidEndEditing):
1731         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
1732         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
1733         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
1734
1735 2015-06-01  Alex Christensen  <achristensen@webkit.org>
1736
1737         [Content Extensions] resource-type and load-type should be independent.
1738         https://bugs.webkit.org/show_bug.cgi?id=145528
1739         rdar://problem/21190765
1740
1741         Reviewed by Benjamin Poulain.
1742
1743         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1744         (TestWebKitAPI::TEST_F):
1745
1746 2015-06-01  Daniel Bates  <dabates@apple.com>
1747
1748         Add ATS keys to WebKitTestRunnerApp
1749         https://bugs.webkit.org/show_bug.cgi?id=145519
1750
1751         Reviewed by Alexey Proskuryakov.
1752
1753         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
1754
1755         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1756
1757 2015-06-01  Brady Eidson  <beidson@apple.com>
1758
1759         Add WKTR support for "should open external URLs".
1760         https://bugs.webkit.org/show_bug.cgi?id=145505
1761
1762         Reviewed by Darin Adler.
1763
1764         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
1765           "should open external URLs" bit set.
1766
1767         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
1768           the policy delegate, including whether or not the bit was set.
1769
1770         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1772         (WTR::TestRunner::queueLoad):
1773         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1774         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
1775         (WTR::TestRunner::shouldDumpPolicyCallbacks):
1776
1777         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1778         (WTR::InjectedBundle::queueLoad):
1779         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1780
1781         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1782         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1783
1784         * WebKitTestRunner/TestInvocation.cpp:
1785         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1786
1787         * WebKitTestRunner/WorkQueueManager.cpp:
1788         (WTR::WorkQueueManager::queueLoad):
1789         * WebKitTestRunner/WorkQueueManager.h:
1790
1791 2015-06-01  Mark Lam  <mark.lam@apple.com>
1792
1793         build-jsc's --cloop option is broken.
1794         https://bugs.webkit.org/show_bug.cgi?id=145516
1795
1796         Reviewed by Darin Adler.
1797
1798         * Scripts/build-jsc:
1799         - Make sure to disable the JIT when --cloop is specified.
1800           Did analogous fix for --ftljit.
1801
1802 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1803
1804         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
1805         https://bugs.webkit.org/show_bug.cgi?id=144959
1806
1807         Reviewed by Darin Adler.
1808
1809         * Scripts/webkitpy/style/checkers/cmake.py:
1810         (CMakeChecker.check): Use enumerate instead of xrange.
1811         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
1812         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1813         (CMakeCheckerTest.test_check): Update the expected results.
1814
1815 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1816
1817         Fix the webkitpy scm unittests after r174051
1818         https://bugs.webkit.org/show_bug.cgi?id=145511
1819
1820         Reviewed by Darin Adler.
1821
1822         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1823         (GitTestWithMock.make_scm):
1824
1825 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1826
1827         EWS provides misleading information for not applyable patches
1828         https://bugs.webkit.org/show_bug.cgi?id=145307
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
1833
1834 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
1835
1836         Further tweak results of WebKit1.StringTruncator after r184965.
1837
1838         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1839
1840 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1841
1842         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
1843         https://bugs.webkit.org/show_bug.cgi?id=145264
1844
1845         Reviewed by Carlos Garcia Campos.
1846
1847         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
1848
1849 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1850
1851         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
1852
1853         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1854         (BenchmarkResults._lint_subtest_results):
1855         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1856         (test_aggregate_nested_results):
1857         (test_lint_results):
1858         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
1859
1860 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
1861
1862         run-benchmark should print out the results
1863         https://bugs.webkit.org/show_bug.cgi?id=145398
1864
1865         Reviewed by Antti Koivisto.
1866
1867         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
1868         of the output to catch early errors.
1869
1870         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
1871         (BenchmarkResults): Added.
1872         (BenchmarkResults.__init__): Added.
1873         (BenchmarkResults.format): Added.
1874         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
1875         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
1876         Uses the sample standard deviation to compute the significant figures for the value.
1877         (BenchmarkResults._unit_from_metric): Added.
1878         (BenchmarkResults._aggregate_results): Added.
1879         (BenchmarkResults._aggregate_results_for_test): Added.
1880         (BenchmarkResults._flatten_list): Added.
1881         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
1882         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
1883         (BenchmarkResults._aggregate_values): Added.
1884         (BenchmarkResults._lint_results): Added.
1885         (BenchmarkResults._lint_subtest_results): Added.
1886         (BenchmarkResults._lint_aggregator_list): Added.
1887         (BenchmarkResults._lint_configuration): Added.
1888         (BenchmarkResults._lint_values): Added.
1889         (BenchmarkResults._is_numeric): Added.
1890         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
1891         (BenchmarkResultsTest):
1892         (BenchmarkResultsTest.test_init):
1893         (BenchmarkResultsTest.test_format):
1894         (test_format_values_with_large_error):
1895         (test_format_values_with_small_error):
1896         (test_format_values_with_time):
1897         (test_format_values_with_no_error):
1898         (test_format_values_with_small_difference):
1899         (test_aggregate_results):
1900         (test_aggregate_results_with_gropus):
1901         (test_aggregate_nested_results):
1902         (test_lint_results):
1903         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1904         (BenchmarkRunner.execute): Added a call to show_results
1905         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
1906         (BenchmarkRunner.show_results): Added.
1907
1908 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1909
1910         run_benchmark should have an option to specify the number of runs
1911         https://bugs.webkit.org/show_bug.cgi?id=145091
1912
1913         Reviewed by Antti Koivisto.
1914
1915         Added --count option.
1916
1917         * Scripts/run-benchmark:
1918         (main):
1919         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1920         (BenchmarkRunner.__init__):
1921
1922 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1923
1924         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
1925
1926         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1927
1928 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1929
1930         Update results of WebKit1.StringTruncator after r184965.
1931
1932         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1933
1934 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1935
1936         Unreviewed, updated my list of email addresses.
1937
1938         * Scripts/webkitpy/common/config/contributors.json:
1939
1940 2015-05-27  Dean Jackson  <dino@apple.com>
1941
1942         img.currentSrc problem in strict mode with old picturefill
1943         https://bugs.webkit.org/show_bug.cgi?id=144095
1944         <rdar://problem/21087013>
1945
1946         Reviewed by Simon Fraser.
1947
1948         Add a PICTURE_SIZES flag.
1949
1950         * Scripts/webkitperl/FeatureList.pm:
1951
1952 2015-05-26  Dana Burkart  <dburkart@apple.com>
1953
1954         Fixes compatibility issues with recent dashboard cleanup.
1955         https://bugs.webkit.org/show_bug.cgi?id=144814
1956
1957         Reviewed by Alexey Proskuryakov.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1960         (BuildbotStaticAnalyzerQueueView):
1961         (BuildbotStaticAnalyzerQueueView.prototype.update):
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1963         (documentReady):
1964
1965 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1966
1967         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
1968         https://bugs.webkit.org/show_bug.cgi?id=143091
1969         rdar://problem/19330328
1970
1971         Reviewed by Darin Adler and Timothy Hatcher.
1972
1973         We have many of these, which are hard to fit on the dashboard. Added a view that
1974         collapses to a single green bubble when everything is good, and expands when there
1975         are failures (or manually).
1976
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
1978
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1980         (Buildbot.prototype.set isAuthenticated):
1981         (Buildbot.prototype._normalizeQueueInfo):
1982         (Buildbot.prototype._normalizeQueuesInfo):
1983         (Buildbot.prototype.updateQueues):
1984         Moved queue info normalization here from BuildbitQueue. The latter is a model class
1985         that shouldn't have to know about presentation, and this lets us leep the knowledge
1986         about combined queues out if it. Later, we can refactor existing code, and move out
1987         all knowledge about headings and such.
1988
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1990         Added the new view. It's not quite universal, and doesn't have as helpful popovers
1991         as other views, but we can extend it when/if we use it for more than JSC.
1992
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1994         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
1995
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1997         (documentReady): Added support for combined queues. These are currently always ending up
1998         in Other column, but it's easy to customize in the future if we need to.
1999
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2001         (WebKitBuildbot): Added JSC queus.
2002
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2004         (.combined-queue-popover):
2005         (.combined-queue-popover .revision):
2006         Added styles for the combined view.
2007
2008 2015-05-26  Dan Bernstein  <mitz@apple.com>
2009
2010         Changed a file to use Unix line endings.
2011
2012         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2013
2014 2015-05-26  Dan Bernstein  <mitz@apple.com>
2015
2016         <rdar://problem/21104551> Update build settings
2017
2018         Reviewed by Anders Carlsson.
2019
2020         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2021         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2022         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2023         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2024         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2025         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2026         * asan/asan.xcconfig:
2027
2028 2015-05-26  Anders Carlsson  <andersca@apple.com>
2029
2030         Fix build.
2031
2032         * WebKitTestRunner/mac/EventSenderProxy.mm:
2033         (WTR::EventSenderProxy::mouseForceDown):
2034         (WTR::EventSenderProxy::mouseForceUp):
2035         (WTR::EventSenderProxy::mouseForceChanged):
2036
2037 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2038
2039         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
2040         https://bugs.webkit.org/show_bug.cgi?id=145342
2041
2042         Reviewed by Darin Adler.
2043
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2045         (BuildbotIteration.prototype._parseData):
2046
2047 2015-05-26  Milan Crha  <mcrha@redhat.com>
2048
2049         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2050         https://bugs.webkit.org/show_bug.cgi?id=138134
2051
2052         Reviewed by Žan Doberšek.
2053
2054         * gtk/generate-inspector-gresource-manifest.py:
2055         (get_filenames): Command line with expanded resources exceeds 32KB, which
2056         is a limit on Windows. It's better to expand wildcards inside the python script.
2057
2058 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2061         https://bugs.webkit.org/show_bug.cgi?id=140882
2062
2063         Reviewed by Gustavo Noronha Silva.
2064
2065         Make sure unit tests write IndexedDB databases to the temporary
2066         directory, and add a test case to check that the directory is
2067         correctly created at the expected path.
2068
2069         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2070         (testWebContextConfiguration):
2071         (serverCallback):
2072         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2073         (Test::Test):
2074
2075 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2076
2077         [GTK] Enable IndexedDB
2078         https://bugs.webkit.org/show_bug.cgi?id=98932
2079
2080         Reviewed by Žan Doberšek.
2081
2082         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2083
2084 2015-05-24  Sam Weinig  <sam@webkit.org>
2085
2086         Crash when using a removed ScriptMessageHandler
2087         <rdar://problem/20888499>
2088         https://bugs.webkit.org/show_bug.cgi?id=145359
2089
2090         Reviewed by Dan Bernstein.
2091
2092         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2093         Add tests for removing script message handlers.
2094
2095 2015-05-23  Dan Bernstein  <mitz@apple.com>
2096
2097         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2098         https://bugs.webkit.org/show_bug.cgi?id=145345
2099
2100         Reviewed by Sam Weinig.
2101
2102         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2103         * LayoutTestRelay/Configurations/Base.xcconfig:
2104         * TestWebKitAPI/Configurations/Base.xcconfig:
2105         * WebKitTestRunner/Configurations/Base.xcconfig:
2106
2107 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2108
2109         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2110         https://bugs.webkit.org/show_bug.cgi?id=144848
2111
2112         Reviewed by Darin Adler.
2113
2114         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2115
2116         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2117
2118 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2119
2120         Fix one more merge error in static analyzer support.
2121
2122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2123         (BuildbotStaticAnalyzerQueueView):
2124
2125 2015-05-22  Dana Burkart  <dburkart@apple.com>
2126
2127         Fix internal dashboard breakage from recent commit.
2128         https://bugs.webkit.org/show_bug.cgi?id=144814
2129
2130         Unreviewed build fix.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2133         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2134         (BuildbotStaticAnalyzerQueueView.prototype.update):
2135
2136 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2137
2138         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2139         https://bugs.webkit.org/show_bug.cgi?id=130463
2140         rdar://problem/20461342
2141
2142         Reviewed by Tim Horton.
2143
2144         This was more of a timing related flakiness than an actual OS version specific bug,
2145         we weren't getting window visibility notifications.
2146
2147         I will look into adding this function call to DumpRenderTree separately, layout tests
2148         might actually rely on the broken behavior.
2149
2150         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2151         (TestWebKitAPI::TEST_F):
2152         * TestWebKitAPI/mac/mainMac.mm:
2153         (main):
2154
2155 2015-05-22  Dana Burkart  <dburkart@apple.com>
2156
2157         Add missing file from r184804 (mis-applied diff).
2158         https://bugs.webkit.org/show_bug.cgi?id=144814
2159
2160         Reviewed by Alexey Proskuryakov.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2163         (BuildbotStaticAnalyzerQueueView):
2164         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2165         (BuildbotStaticAnalyzerQueueView.prototype.update):
2166
2167 2015-05-22  Dana Burkart  <dburkart@apple.com>
2168
2169         Add support to the botwatchers dashboard for a static analyzer bot.
2170         https://bugs.webkit.org/show_bug.cgi?id=144814
2171
2172         Reviewed by Alexey Proskuryakov.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2175         scan-build should be considered a productive step.
2176
2177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2178         (BuildbotQueue):
2179         Adds support for the staticAnalyzer property
2180
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2182         (BuildbotTestResults.prototype._parseResults):
2183         Get bug count from the scan-build step output
2184
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2186         (documentReady):
2187         Rename the performance column 'Other', and merge the current 'Other' column with it.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2190         (WebKitBuildbot):
2191         Now that performance bots are part of the 'Other' column, give them better headings.
2192
2193 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2194
2195         Turn on autosaving of toolbar configuration in MiniBrowser
2196
2197         Rubber-stamped by Dan Bernstein.
2198
2199         * MiniBrowser/mac/BrowserWindow.xib:
2200
2201 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2202
2203         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2204         https://bugs.webkit.org/show_bug.cgi?id=145297
2205
2206         Reviewed by Tim Horton.
2207
2208         This is a refactoring to simplify code, and to make it more logical.
2209
2210         It is up to the view to decide how to present the queues, and whether to split
2211         them into debug and release, or in some different way.
2212
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2214         (BuildbotBuilderQueueView.filterQueues):
2215         (BuildbotBuilderQueueView):
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2217         (BuildbotLeaksQueueView):
2218         (BuildbotLeaksQueueView.prototype.update):
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2220         (BuildbotPerformanceQueueView):
2221         (BuildbotPerformanceQueueView.prototype.update):
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2223         (BuildbotQueueView):
2224         (BuildbotQueueView.prototype._updateQueues):
2225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2226         (BuildbotTesterQueueView):
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2228         (documentReady):
2229
2230 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2231
2232         Remove action menu support
2233         https://bugs.webkit.org/show_bug.cgi?id=145305
2234         <rdar://problem/21070771>
2235
2236         Reviewed by Anders Carlsson.
2237
2238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2239         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2240         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2241         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2242         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2243         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2244         Remove the tests.
2245
2246 2015-05-22  Dan Bernstein  <mitz@apple.com>
2247
2248         Removed the Use Shrink To Fit button from the toolbar’s default set.
2249
2250         Rubber-stamped by Tim Horton.
2251
2252         * MiniBrowser/mac/BrowserWindow.xib:
2253
2254 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2255
2256         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2257         https://bugs.webkit.org/show_bug.cgi?id=128420
2258
2259         Reviewed by Chris Fleizach.
2260
2261         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2262         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2263
2264 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2265
2266         [EFL] Bump libsoup version to 2.50.0
2267         https://bugs.webkit.org/show_bug.cgi?id=145127
2268
2269         Reviewed by Gyuyoung Kim.
2270
2271         * efl/jhbuild.modules:
2272         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2273         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2274
2275 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2276
2277         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2278         https://bugs.webkit.org/show_bug.cgi?id=145117
2279
2280         Reviewed by Csaba Osztrogonác.
2281
2282         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2283         Tools/TestWebKitAPI/Tests/WTF/glib/.
2284
2285         * TestWebKitAPI/PlatformGTK.cmake:
2286         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2287         (TestWebKitAPI::TEST):
2288
2289 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2290
2291         [EFL] fix efreet error
2292         https://bugs.webkit.org/show_bug.cgi?id=143670
2293
2294         Reviewed by Gyuyoung Kim.
2295
2296         Fix efreet error by using external variable efreet_cache_update.
2297         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2298         efreet error for efreet_cache does not occur.
2299
2300         * MiniBrowser/efl/main.c:
2301         (elm_main):
2302
2303 2015-05-20  Michael Saboff  <msaboff@apple.com>
2304
2305         Add option to run_jsc_stress_tests to disable JIT testing
2306         https://bugs.webkit.org/show_bug.cgi?id=145233
2307
2308         Reviewed by Mark Lam.
2309
2310         Added --no-jit option.
2311
2312         * Scripts/run-jsc-stress-tests:
2313
2314 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2315
2316         Use correct String for StringView in WTF API tests
2317         https://bugs.webkit.org/show_bug.cgi?id=145226
2318         rdar://problem/20361786
2319
2320         Reviewed by Benjamin Poulain.
2321
2322         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2323         (TestWebKitAPI::TEST):
2324         Use patternHolder for pattern.
2325
2326 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2327
2328         [Content Extensions] Relax restrictions on triggers that match everything.
2329         https://bugs.webkit.org/show_bug.cgi?id=145069
2330
2331         Reviewed by Benjamin Poulain.
2332
2333         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2334         (TestWebKitAPI::TEST_F):
2335         Update and add tests for new possibilities with .*
2336
2337 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2338
2339         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2340         https://bugs.webkit.org/show_bug.cgi?id=144992
2341
2342         Reviewed by Gyuyoung Kim.
2343
2344         * MiniBrowser/efl/main.c:
2345         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2346         (on_key_down):
2347         (on_fullscreen_enter):
2348         (on_fullscreen_exit):
2349         (window_create):
2350
2351 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2352
2353         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2354         https://bugs.webkit.org/show_bug.cgi?id=145109
2355
2356         Reviewed by Darin Adler.
2357
2358         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2359         (TestWebKitAPI::TEST):
2360
2361 2015-05-19  Anders Carlsson  <andersca@apple.com>
2362
2363         Add alternate menu items for performing operations on the default data store
2364         https://bugs.webkit.org/show_bug.cgi?id=145184
2365
2366         Reviewed by Sam Weinig.
2367
2368         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2369         associated with a data store.
2370
2371         * MiniBrowser/mac/AppDelegate.m:
2372         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2373         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2374         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2375         * MiniBrowser/mac/MainMenu.xib:
2376
2377 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2378
2379         Fix tautological-compare warning in AtomicString.cpp
2380         https://bugs.webkit.org/show_bug.cgi?id=145120
2381
2382         Reviewed by Alexey Proskuryakov.
2383
2384         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2385         (TestWebKitAPI::TEST): Removed always true assert.
2386
2387 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2388
2389         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2390         https://bugs.webkit.org/show_bug.cgi?id=145123
2391
2392         Reviewed by Gyuyoung Kim.
2393
2394         * MiniBrowser/efl/main.c:
2395         (on_key_down):
2396
2397 2015-05-18  Daniel Bates  <dabates@apple.com>
2398
2399         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2400         when staged non-empty file for commit
2401         https://bugs.webkit.org/show_bug.cgi?id=145082
2402
2403         Reviewed by Darin Adler.
2404
2405         Fixes two issues when running prepare-ChangeLog:
2406             1. The function above a deleted function is reported as changed.
2407             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2408             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2409             included in this patch).
2410
2411         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2412         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2413         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2414         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2415         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2416         VCSUtil::parseChunkRange() has existing test coverage.
2417
2418         * Scripts/prepare-ChangeLog:
2419         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2420         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2421         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2422         examine files that only have deletions. Currently this works as a side effect of the behavior of
2423         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2424         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2425         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2426         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2427         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2428         We return (-1, -1) when the change represents a deletion.
2429         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2430         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2431         We return (-1, -1) when the change represents an addition.
2432         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2433         unit tests.
2434
2435 2015-05-18  Anders Carlsson  <andersca@apple.com>
2436
2437         Add ATS keys to MiniBrowser
2438         https://bugs.webkit.org/show_bug.cgi?id=145141
2439
2440         Reviewed by Sam Weinig.
2441
2442         * MiniBrowser/mac/Info.plist:
2443
2444 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2445
2446         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2447         <http://webkit.org/b/145100>
2448
2449         Reviewed by Darin Adler.
2450
2451         * Scripts/bisect-builds:
2452         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2453         - Switch to using PROMPT_RESPONSE_* constants when testing the
2454           value of $didReproduceBug.
2455         - Add do { } while loops to implement 'retry' mode.
2456         (promptForTest):
2457         - Switch to returning PROMPT_RESPONSE_* constants.
2458         - Add support for 'retry' response.
2459
2460 2015-05-16  Tanay C  <tanay.c@samsung.com>
2461
2462         [EFL][WK2] Minibrowser : Add search icon to search bar
2463         https://bugs.webkit.org/show_bug.cgi?id=139773
2464
2465         Reviewed by Gyuyoung Kim.
2466
2467         * MiniBrowser/efl/main.c:
2468         (search_icon_show): Added.
2469         (search_box_show): Modified.
2470
2471 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2472
2473         run_benchmark should have an option to specify the number of runs
2474         https://bugs.webkit.org/show_bug.cgi?id=145091
2475
2476         Reviewed by Stephanie Lewis.
2477
2478         Added --count option.
2479
2480         * Scripts/run-benchmark:
2481         (main):
2482         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2483         (BenchmarkRunner.__init__):
2484
2485 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2486
2487         Temporarily disable failing API test.
2488
2489         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2490         (TestWebKitAPI::TEST):
2491
2492 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2493
2494         User interruption while running of run-webkit-tests should also generate results.html
2495         https://bugs.webkit.org/show_bug.cgi?id=122154
2496
2497         Reviewed by Csaba Osztrogonác.
2498
2499         Generation of results.html on execution of run-webkit-tests happens only
2500         on completion of entire layout tests run. It should be created even when
2501         the execution has been interrupted - either by user (by pressing Ctrl+C)
2502         or because of other interruptions (like exit-after-n-failures option).
2503
2504         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2505         (LayoutTestRunner.run_tests):
2506         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2507         (Manager.run):
2508         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2509         (TestRunResults.__init__):
2510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2511         (main):
2512         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2513         (RunTest.test_keyboard_interrupt):
2514         (MainTest.test_exception_handling):
2515
2516 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2517
2518         [buildbot] Fix the URL of the performance bots
2519         https://bugs.webkit.org/show_bug.cgi?id=145043
2520
2521         Reviewed by Ryosuke Niwa.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2524
2525 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2526
2527         Add a layout mode that scales down the view to try to fit the document
2528         https://bugs.webkit.org/show_bug.cgi?id=145022
2529         <rdar://problem/19790341>
2530
2531         Reviewed by Dean Jackson.
2532
2533         * MiniBrowser/mac/BrowserWindow.xib:
2534         * MiniBrowser/mac/BrowserWindowController.h:
2535         * MiniBrowser/mac/WK2BrowserWindowController.m:
2536         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2537         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2538         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2539
2540 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2541
2542         [CMake] Don't read the LOCATION property of targets
2543         https://bugs.webkit.org/show_bug.cgi?id=145018
2544
2545         Reviewed by Martin Robinson.
2546
2547         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2548         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2549         be the same at configure-time as it is at generate-time.
2550
2551         * TestWebKitAPI/CMakeLists.txt:
2552
2553 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2554
2555         Add String literal overloads to equalIgnoringASCIICase()
2556         https://bugs.webkit.org/show_bug.cgi?id=145008
2557
2558         Reviewed by Benjamin Poulain.
2559
2560         Test changes to WTF.
2561
2562         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2563         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2564         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2565         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2566         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2567         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2568
2569 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2570
2571         SharedBuffer::createWithContentsOfFile should use map file routines
2572         https://bugs.webkit.org/show_bug.cgi?id=144192
2573
2574         Reviewed by Darin Adler.
2575
2576         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2577
2578         * TestWebKitAPI/PlatformGTK.cmake:
2579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2580         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2581         (TestWebKitAPI::FileSystemTest::tempFilePath):
2582         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2583         (TestWebKitAPI::TEST_F):
2584         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2585         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2586         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2587         (TestWebKitAPI::TEST_F):
2588
2589 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2590
2591         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2592         https://bugs.webkit.org/show_bug.cgi?id=144967
2593
2594         Reviewed by Benjamin Poulain.
2595
2596         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2597         Xcode wanted to fix an alphabetization issue.
2598         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2599         (TestWebKitAPI::TEST_F):
2600         Test interactions that worked but were not explicitly tested before.
2601
2602 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2603
2604         Unreviewed build fix.
2605
2606         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2607
2608         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2609
2610 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2611
2612         Fix the previous commit, which made both bubbles green.
2613
2614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2615         (.status-line.good .bubble):
2616         (.status-line.bad .bubble):
2617         (.status-line.good .message):
2618
2619 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2620
2621         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2622         https://bugs.webkit.org/show_bug.cgi?id=144929
2623
2624         Reviewed by Eric Carlson.
2625
2626         Tweaked colors as I see fit.
2627
2628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2629         (.status-line.good .bubble):
2630         (.status-line.bad .bubble):
2631
2632 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2633
2634         [Mac] Share cookie storage between UI process and secondary processes
2635         https://bugs.webkit.org/show_bug.cgi?id=144820
2636         rdar://problem/20572830
2637
2638         Reviewed by Darin Adler.
2639
2640         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2641         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2642         for testing.
2643
2644 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2645
2646         Fix internal build configuration issues
2647         https://bugs.webkit.org/show_bug.cgi?id=144762
2648
2649         Reviewed by David Kilzer.
2650
2651         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2652
2653         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2654         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2655         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2656         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2657         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2658         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2659         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2660         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2661
2662 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2663
2664         Switch to launching iOS Simulator using bundle ID
2665         <rdar://problem/20916096>
2666
2667         This is required to fix the layout tests on internal bots.
2668
2669         * Scripts/webkitdirs.pm:
2670         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2671         Simulator.  Add FIXME.
2672         (quitIOSSimulator): Add FIXME.
2673         * Scripts/webkitpy/port/ios.py:
2674         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2675         launch iOS Simulator.  Add FIXME.
2676         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2677
2678 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2679
2680         Fix run-javascriptcore-tests step on the WinCairo bot
2681         https://bugs.webkit.org/show_bug.cgi?id=144866
2682
2683         Reviewed by Csaba Osztrogonác.
2684
2685         Catch exception when failing to create soft link, so we can fall back to copy.
2686
2687         * Scripts/run-jsc-stress-tests:
2688
2689 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2690
2691         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2692         https://bugs.webkit.org/show_bug.cgi?id=116971
2693
2694         Reviewed by Chris Fleizach.
2695
2696         Implement rowAtIndex for ATK.
2697
2698         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2699         (WTR::AccessibilityUIElement::rowAtIndex):
2700
2701 2015-05-11  Dan Bernstein  <mitz@apple.com>
2702
2703         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2704
2705         Reviewed by Alexey Proskuryakov.
2706
2707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2708         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2709         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2710         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2711
2712 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
2713
2714         Fix internal build configuration issues
2715         https://bugs.webkit.org/show_bug.cgi?id=144762
2716
2717         Reviewed by Darin Adler.
2718
2719         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
2720
2721         * TestWebKitAPI/Configurations/Base.xcconfig:
2722         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2723         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2724         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2725         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2726         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2727         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2728
2729 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2730
2731         [Win] Move Windows build target to Windows 7 (or newer)
2732         https://bugs.webkit.org/show_bug.cgi?id=144890
2733         <rdar://problem/20707307>
2734
2735         Reviewed by Anders Carlsson.
2736
2737         Update linked SDK and minimal Windows level to be compatible with
2738         Windows 7 or newer.
2739
2740         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2741         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2742         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2743         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2744         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2745         * DumpRenderTree/config.h:
2746         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2747         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2748         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2749         * WinLauncher/stdafx.h:
2750
2751 2015-05-11  Commit Queue  <commit-queue@webkit.org>
2752
2753         Unreviewed, rolling out r184119.
2754         https://bugs.webkit.org/show_bug.cgi?id=144888
2755
2756         broke JSC tests on Apple Windows bots (Requested by kling on
2757         #webkit).
2758
2759         Reverted changeset:
2760
2761         "Fix run-javascriptcore-tests step on the WinCairo bot"
2762         https://bugs.webkit.org/show_bug.cgi?id=144866
2763         http://trac.webkit.org/changeset/184119
2764
2765 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2766
2767         run-benchmark should support Dromaeo
2768         https://bugs.webkit.org/show_bug.cgi?id=144849
2769
2770         Reviewed by Chris Dumez.
2771
2772         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
2773         they can take as much as 15 minutes to run each.
2774
2775         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
2776         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
2777         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
2778         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
2779
2780 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2781
2782         Build fix. jetstream has a local copy, not remote archive.
2783
2784         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2785
2786 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2787
2788         run-benchmark should support SunSpider, Kraken and Octane
2789         https://bugs.webkit.org/show_bug.cgi?id=144840
2790
2791         Reviewed by Darin Adler.
2792
2793         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
2794         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
2795         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
2796         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
2797
2798         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
2799         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
2800
2801         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
2802         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
2803
2804         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
2805         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
2806         now has the ability to run an arbitrary "create script".
2807
2808         * Scripts/run-benchmark:
2809         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
2810         This also overrides the remote archive URL specified in the plan.
2811
2812         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
2813
2814         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
2815         JetStreamBenchmarkBuilder.
2816
2817         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2818         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
2819         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
2820         _runCreateScript and _applyPatch to clean after themselves.
2821         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
2822         JetStream, SunSpider, Kraken all use this feature.
2823         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
2824         the leaf directory name since the latter is not available when a remote ZIP file is used.
2825         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
2826         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
2827         the benchmark name in the patches.
2828
2829         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
2830
2831         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2832         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
2833         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
2834         the browser opens by planName as the plan file no longer contains that.
2835
2836         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
2837         the top directory of JetStream instead of its parent.
2838         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
2839         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
2840         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
2841         the top directory of JetStream instead of its parent.
2842         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
2843         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
2844         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
2845         done in JetStream.patch.
2846         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
2847         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
2848         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
2849         path from the top directory of JetStream as done in JetStream.patch.
2850         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
2851
2852 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
2853
2854         Fix run-javascriptcore-tests step on the WinCairo bot
2855         https://bugs.webkit.org/show_bug.cgi?id=144866
2856
2857         Reviewed by Darin Adler.
2858
2859         * Scripts/run-jsc-stress-tests:
2860
2861 2015-05-11  Alex Christensen  <achristensen@webkit.org>
2862
2863         [Content Extensions] Support domain-specific rules and exceptions.
2864         https://bugs.webkit.org/show_bug.cgi?id=144833
2865
2866         Reviewed by Darin Adler.
2867
2868         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2869         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2870         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2871         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2872         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
2873         (TestWebKitAPI::mainDocumentRequest):
2874         (TestWebKitAPI::subResourceRequest):
2875         (TestWebKitAPI::TEST_F):
2876         (TestWebKitAPI::checkCompilerError):
2877         Added tests for parsing and functionality of if-domain and unless-domain.
2878
2879 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2880
2881         run-benchmark should support Chrome Canary and Firefox Nightly
2882         https://bugs.webkit.org/show_bug.cgi?id=144850
2883
2884         Reviewed by Darin Adler.
2885
2886         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
2887
2888         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
2889
2890         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
2891         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
2892         (OSXBrowserDriver):
2893         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
2894         (OSXBrowserDriver.closeBrowsers): Ditto.
2895         (OSXBrowserDriver.launchProcess): Ditto.
2896         (OSXBrowserDriver.terminateProcesses): Ditto.
2897         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2898         (OSXChromeDriver): Removed the unused self.chromePreferences.
2899         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
2900         (OSXChromeDriver.closeBrowsers): Ditto.
2901         (OSXChromeDriver.launchUrl):
2902         (OSXChromeCanaryDriver): Added.
2903         (OSXChromeCanaryDriver.launchUrl):
2904         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
2905         (OSXFirefoxDriver): Added.
2906         (OSXFirefoxDriver.launchUrl):
2907         (OSXFirefoxNightlyDriver): Added.
2908         (OSXFirefoxNightlyDriver.launchUrl):
2909         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2910         (OSXSafariDriver):
2911         (OSXSafariDriver.closeBrowsers):
2912
2913 2015-05-11  Tim Horton  <timothy_horton@apple.com>
2914
2915         Page overlay action context override should indicate the source of the request
2916         https://bugs.webkit.org/show_bug.cgi?id=144832
2917         <rdar://problem/20562594>
2918
2919         Reviewed by Darin Adler.
2920
2921         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2922         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2923
2924 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
2925
2926         [GTK] fast/events/page-visibility-transition-test.html is timing out
2927         https://bugs.webkit.org/show_bug.cgi?id=114789
2928
2929         Reviewed by Darin Adler.
2930
2931         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2932         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
2933         requests visibility changes.
2934
2935 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2936
2937         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
2938         https://bugs.webkit.org/show_bug.cgi?id=144798
2939
2940         Reviewed by Darin Adler.
2941
2942         * efl/install-dependencies:
2943
2944 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
2945
2946         Make arguments of run-benchmark more user friendly
2947         https://bugs.webkit.org/show_bug.cgi?id=144835
2948
2949         Reviewed by Darin Adler.
2950
2951         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
2952         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
2953         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
2954         default values from --platform and --browser as they are required arguments.
2955
2956         * Scripts/run-benchmark:
2957         (main): Made --build-directory optional, and removed default values from --platform and --browser.
2958         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
2959         are not dynamically obtained via BrowserDriverFactory.
2960         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2961         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
2962         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
2963         run any benchmark in that case.
2964         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
2965         the specified file isn't a valid relative or an absolute path.
2966         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2967         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
2968         and browsers.
2969         (BrowserDriverFactory.available_browsers): Ditto.
2970         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2971         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
2972         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
2973         browserBuildPath was None.
2974         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2975         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
2976         so that we can use locally built WebKit to launch Safari.
2977
2978 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2979
2980         Remove the PICTURE_SIZES build flag
2981         https://bugs.webkit.org/show_bug.cgi?id=144679
2982
2983         Reviewed by Benjamin Poulain.
2984
2985         Removed the PICTURE_SIZES build time flag.
2986
2987         * Scripts/webkitperl/FeatureList.pm:
2988
2989 2015-05-09  David Kilzer  <ddkilzer@apple.com>
2990
2991         Layout tests broke due to unexpected simctl output
2992
2993         * Scripts/webkitpy/xcode/simulator.py:
2994         (Simulator._parse_devices): Handle new Device Pairs header.
2995         * Scripts/webkitpy/xcode/simulator_unittest.py:
2996         (test_device_pairs): Add unit test for Device Pairs header.
2997
2998 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2999
3000         Remove convenience constructors for TextRun
3001         https://bugs.webkit.org/show_bug.cgi?id=144752
3002
3003         Reviewed by Anders Carlsson.
3004
3005         Test the StringView which takes a StringImpl*.
3006
3007         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3008         (StringView8Bit): Testing is8Bit() on StringView
3009
3010 2015-05-07  Sam Weinig  <sam@webkit.org>
3011
3012         [Content Extensions] Add simple tester that takes an extension and compiles it
3013         https://bugs.webkit.org/show_bug.cgi?id=144781
3014
3015         Reviewed by Dan Bates.
3016
3017         * ContentExtensionTester: Added.
3018         * ContentExtensionTester/Configurations: Added.
3019         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
3020         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
3021         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
3022         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
3023         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
3024         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
3025         * ContentExtensionTester/main.m: Added.
3026         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
3027
3028 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
3029
3030         Build fix.
3031
3032         Reviewed by Dan Bernstein.
3033
3034         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3035         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3036         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
3037         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3038         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3039         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3040         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
3041         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3042
3043 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
3044
3045         [GTK] Some tests fail because they do not assume the popup menu captures click events
3046         https://bugs.webkit.org/show_bug.cgi?id=40601
3047
3048         Reviewed by Carlos Garcia Campos.
3049
3050         Popdown all attached menus when moving between tests and between each new
3051         event sent to the WebView. This prevents context and popup menus from eating
3052         events.
3053
3054         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3055         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3056         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3057         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3058         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3059         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3060         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3061         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3062         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3063         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3064         longer in the platform-independent file.
3065         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3066
3067 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3068
3069         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3070         https://bugs.webkit.org/show_bug.cgi?id=144746
3071
3072         Reviewed by Carlos Garcia Campos.
3073
3074         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3075
3076         * MiniBrowser/gtk/main.c:
3077         (main):
3078
3079 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3080
3081         Unreviewed, rolling out r183996.
3082         https://bugs.webkit.org/show_bug.cgi?id=144806
3083
3084         ASan detected use-after free (Requested by ap on #webkit).
3085
3086         Reverted changeset:
3087
3088         "Remove convenience constructors for TextRun"
3089         https://bugs.webkit.org/show_bug.cgi?id=144752
3090         http://trac.webkit.org/changeset/183996
3091
3092 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3093
3094         Remove convenience constructors for TextRun
3095         https://bugs.webkit.org/show_bug.cgi?id=144752
3096
3097         Reviewed by Anders Carlsson.
3098
3099         Test the StringView which takes a StringImpl*.
3100
3101         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3102         (StringView8Bit): Testing is8Bit() on StringView
3103
3104 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3105
3106         [GTK] WTR doesn't correctly handle the Escape key
3107         https://bugs.webkit.org/show_bug.cgi?id=144788
3108
3109         Reviewed by Martin Robinson.
3110
3111         Correctly handle 0x001B character code in GTK+ event sender to be
3112         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3113         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3114         to dismiss popup menus.
3115
3116         Fixes editing/selection/5354455-1.html.
3117
3118         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3119         (WTR::getGDKKeySymForKeyRef):
3120
3121 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3122
3123         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3124         https://bugs.webkit.org/show_bug.cgi?id=144748
3125
3126         Reviewed by Sergio Villar Senin.
3127
3128         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3129         (testWebKitSettings): Check the new setting is correctly
3130         initialized and updated.
3131         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3132         (testWebContextSecurityFileXHR): Check XHR to local files is
3133         allowed from file URLs after changing the setting.
3134         (beforeAll): Add new test.
3135
3136 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3137
3138         Unreviewed, rolling out r183945.
3139         https://bugs.webkit.org/show_bug.cgi?id=144789
3140
3141         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3142
3143         Reverted changeset:
3144
3145         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3146         https://bugs.webkit.org/show_bug.cgi?id=144746
3147         http://trac.webkit.org/changeset/183945
3148
3149 2015-05-07  Anders Carlsson  <andersca@apple.com>
3150
3151         Build fixes.
3152
3153         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3154         (TestWebKitAPI::TEST):
3155         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3156         (TestWebKitAPI::TEST):
3157         Add casts.
3158
3159 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3160
3161         GC has trouble with pathologically large array allocations
3162         https://bugs.webkit.org/show_bug.cgi?id=144609
3163
3164         Reviewed by Geoffrey Garen.
3165
3166         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3167         and it's a frequently requested feature.
3168
3169         Also add the ability to run a test pretending that your system has a particular RAM size.
3170         This is useful for GC tests, and the new GC test that I added uses this.
3171
3172         * Scripts/run-javascriptcore-tests:
3173         (runJSCStressTests):
3174         * Scripts/run-jsc-stress-tests:
3175
3176 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3177
3178         [EFL] Bump EFL version to 1.14.0
3179         https://bugs.webkit.org/show_bug.cgi?id=144743
3180
3181         Reviewed by Darin Adler.
3182
3183         Bump EFL and elementary version to 1.14.0 and removed
3184         md5sum, because it isn't used at all if hash is present.
3185
3186         * efl/jhbuild.modules:
3187
3188 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3189
3190         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3191         https://bugs.webkit.org/show_bug.cgi?id=144753
3192
3193         Reviewed by Mark Lam.
3194
3195         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3196
3197 2015-05-07  Beth Dakin  <bdakin@apple.com>
3198
3199         New force-related DOM events should fire in WK1 views
3200         https://bugs.webkit.org/show_bug.cgi?id=144663
3201         -and corresponding-
3202         rdar://problem/20281886
3203
3204         Reviewed by Sam Weinig.
3205
3206         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event
3207         now. Just send nil.
3208         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3209         (TestWebKitAPI::buildAndPerformTest):
3210
3211 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3212
3213         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3214         https://bugs.webkit.org/show_bug.cgi?id=144746
3215
3216         Reviewed by Martin Robinson.
3217
3218         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3219
3220         * MiniBrowser/gtk/main.c:
3221         (main):
3222
3223 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3224
3225         Revert "Introducing the Platform Abstraction Layer (PAL)"
3226         https://bugs.webkit.org/show_bug.cgi?id=144751
3227
3228         Unreviewed.
3229
3230         PAL should be a new target inside WebCore, rather than a top-level folder.
3231
3232         * Scripts/build-webkit: Add it to build-webkit.
3233
3234 2015-05-07  Ada Chan  <adachan@apple.com>
3235
3236         Add a test for WKPageCopySessionState() with filtering.
3237         https://bugs.webkit.org/show_bug.cgi?id=144666
3238
3239         Reviewed by Darin Adler.
3240
3241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3242         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3243         (TestWebKitAPI::didFinishLoadForFrame):
3244         (TestWebKitAPI::setPageLoaderClient):
3245         (TestWebKitAPI::filterFirstItemCallback):
3246         (TestWebKitAPI::filterAllItemsCallback):
3247         (TestWebKitAPI::createSessionStates):
3248         (TestWebKitAPI::TEST):
3249
3250 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3251
3252         iOS build fix attempt
3253
3254         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3255
3256         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3257
3258 2015-05-06  Matt Baker  <mattbaker@apple.com>
3259
3260         Unreviewed, updated my list of email addresses.
3261
3262         * Scripts/webkitpy/common/config/contributors.json:
3263
3264 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3265
3266         Do not link tools to WebKit2.framework
3267         https://bugs.webkit.org/show_bug.cgi?id=144699
3268
3269         Unreviewed build fix.
3270
3271         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3272         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3273         These linked to WebKit2 in two ways, eliminating the other one.
3274
3275 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3276
3277         Introducing the Platform Abstraction Layer (PAL)
3278         https://bugs.webkit.org/show_bug.cgi?id=143358
3279
3280         Reviewed by Simon Fraser.
3281
3282         * Scripts/build-webkit: Add it to build-webkit.
3283
3284 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3285
3286         Fix api tests after r183877.
3287
3288         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3289         (TestWebKitAPI::TEST_F):
3290         Generate all DFAs before compiling them.
3291
3292 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3293
3294         Do not link tools to WebKit2.framework
3295         https://bugs.webkit.org/show_bug.cgi?id=144699
3296
3297         Reviewed by Tim Horton.
3298
3299         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3301         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3302
3303 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3304
3305         [Content Extensions] Test splitting NFAs by max NFA size.
3306         https://bugs.webkit.org/show_bug.cgi?id=144659
3307
3308         Reviewed by Darin Adler.
3309
3310         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3311         (TestWebKitAPI::createNFAs):
3312         (TestWebKitAPI::TEST_F):
3313         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3314         (TestWebKitAPI::createNFAs):
3315
3316 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3317
3318         Remove the remaining vestiges of SVG feature define
3319         https://bugs.webkit.org/show_bug.cgi?id=144655
3320
3321         Reviewed by Alexey Proskuryakov.
3322
3323         * Scripts/webkitperl/FeatureList.pm:
3324
3325 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3326
3327         Add a layout mode for computing fixed layout size from a minimum size
3328         https://bugs.webkit.org/show_bug.cgi?id=144610
3329         <rdar://problem/19790341>
3330
3331         Reviewed by Simon Fraser.
3332
3333         * MiniBrowser/mac/BrowserWindow.xib:
3334         * MiniBrowser/mac/BrowserWindowController.h:
3335         * MiniBrowser/mac/WK1BrowserWindowController.m:
3336         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3337         * MiniBrowser/mac/WK2BrowserWindowController.m:
3338         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3339         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3340
3341 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3342
3343         [Content Extensions] Release input NSString when finished copying it.
3344         https://bugs.webkit.org/show_bug.cgi?id=144642
3345
3346         Reviewed by Brian Weinstein.
3347
3348         * WebKitTestRunner/mac/TestControllerMac.mm:
3349         (WTR::TestController::platformConfigureViewForTest):
3350         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3351
3352 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3353
3354         Unreviewed test fix after r183798.
3355
3356         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3357         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3358         so we can share results.
3359
3360 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3361
3362         [Content Extensions] Use less memory to store the json input.
3363         https://bugs.webkit.org/show_bug.cgi?id=144604
3364
3365         Reviewed by Benjamin Poulain.
3366
3367         * MiniBrowser/mac/ExtensionManagerWindowController.m:
3368         (-[ExtensionManagerWindowController add:]):
3369         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3370         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3371         * WebKitTestRunner/mac/TestControllerMac.mm:
3372         (WTR::TestController::platformConfigureViewForTest):
3373
3374 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3375
3376         Unreviewed. Make myself a WebKit reviewer.
3377
3378         * Scripts/webkitpy/common/config/contributors.json:
3379
3380 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
3381
3382         [GTK] r183783 breaks build
3383         https://bugs.webkit.org/show_bug.cgi?id=144632
3384
3385         Reviewed by Martin Robinson.
3386
3387         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
3388
3389         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3390         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3391
3392 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3393
3394         [Content Extensions] Combine NFAs properly and free memory as we compile.
3395         https://bugs.webkit.org/show_bug.cgi?id=144485
3396
3397         Reviewed by Benjamin Poulain.
3398
3399         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3400         (TestWebKitAPI::TEST_F):
3401         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
3402         Added tests for deep NFAs.
3403
3404 2015-05-04  Alex Christensen  <achristensen@webkit.org>
3405
3406         [Content Extensions] Use less memory when writing byte code to file
3407         https://bugs.webkit.org/show_bug.cgi?id=144602
3408
3409         Reviewed by Darin Adler.
3410
3411         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3412
3413 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3414
3415         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
3416         https://bugs.webkit.org/show_bug.cgi?id=144541
3417
3418         Reviewed by Žan Doberšek.
3419
3420         Add a test case to WorkQueue unit test, to check that sources of
3421         asynchronous IO operations running in the WorkQueue thread are
3422         dispatched by the WorkQueue main loop.
3423
3424         * TestWebKitAPI/PlatformGTK.cmake:
3425         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
3426         (TestWebKitAPI::TEST):
3427
3428 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3429
3430         Correct '--show-webview' option for Tiled Drawing tests
3431         https://bugs.webkit.org/show_bug.cgi?id=144621
3432
3433         Reviewed by Simon Fraser.
3434
3435         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3436         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3437
3438         * WebKitTestRunner/mac/TestControllerMac.mm:
3439         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3440         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3441
3442 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3443
3444         Large array shouldn't be slow
3445         https://bugs.webkit.org/show_bug.cgi?id=144617
3446
3447         Reviewed by Geoffrey Garen.
3448
3449         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3450         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3451         long-running. So, hash-map sort of belongs here.
3452
3453         * Scripts/run-jsc-benchmarks:
3454
3455 2015-05-04  Doug Russell  <d_russell@apple.com>
3456
3457         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3458         https://bugs.webkit.org/show_bug.cgi?id=144489
3459
3460         Reviewed by Chris Fleizach.
3461
3462         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3463         on the returned control.
3464         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3465         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3466         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3467         Add support for setSelectedVisibleTextRange() in accessibility tests.
3468
3469         * DumpRenderTree/AccessibilityUIElement.cpp:
3470         (setSelectedVisibleTextRangeCallback):
3471         (AccessibilityUIElement::setSelectedVisibleTextRange):
3472         (AccessibilityUIElement::getJSClass):
3473         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3474         * DumpRenderTree/AccessibilityUIElement.h:
3475         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3476         (AccessibilityUIElement::setSelectedVisibleTextRange):
3477         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3478         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3479         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3480         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3481         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3482         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3483         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3484         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3485         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3486         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3487         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3488
3489 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3490
3491         [Win] Implement the "--show-webview" option for Windows
3492         https://bugs.webkit.org/show_bug.cgi?id=144589
3493
3494         Reviewed by Alex Christensen.
3495
3496         Add another runtime flag (--show-webview) that causes DumpRenderTree
3497         to draw its view on-screen, rather than the standard offscreen mode.
3498
3499         * DumpRenderTree/win/DumpRenderTree.cpp:
3500         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3501         (initializeGlobalsFromCommandLineOptions): Recognize the new
3502         command-line argument, and set the global 'showWebView' state if
3503         appropriate.
3504
3505 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3506
3507         Remove dead code from TestInvocationCairo.cpp
3508         https://bugs.webkit.org/show_bug.cgi?id=144564
3509
3510         Reviewed by Gyuyoung Kim.
3511
3512         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3513
3514         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3515         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3516
3517 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3518
3519         [GTK] Add libnotify in gtk install-dependencies
3520         https://bugs.webkit.org/show_bug.cgi?id=144379
3521
3522         Reviewed by Csaba Osztrogonác.
3523
3524         * gtk/install-dependencies:
3525
3526 2015-05-01  Dan Bernstein  <mitz@apple.com>
3527
3528         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3529         https://bugs.webkit.org/show_bug.cgi?id=144501
3530
3531         Reviewed by Darin Adler.
3532
3533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3534         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3535         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3536         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3537
3538 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3539
3540         check-webkit-style fails due to system pylint
3541         https://bugs.webkit.org/show_bug.cgi?id=144360
3542
3543         Reviewed by Darin Adler.
3544
3545         Make sure that the directory containing third party autoinstalled modules
3546         is at the beginning of the search path, to avoid conflicts with other
3547         versions of the same modules installed in the system (e.g. pylint).
3548
3549         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3550         modules directory to sys.path, instead of appending it.
3551
3552 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3553
3554         Unreviewed, updated my list of email addresses.
3555
3556         * Scripts/webkitpy/common/config/contributors.json: Updated.
3557
3558 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3559
3560         USE(...) macro should expect unprefixed variables
3561         https://bugs.webkit.org/show_bug.cgi?id=144454
3562
3563         Reviewed by Daniel Bates.
3564
3565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3566         * DumpRenderTree/config.h: Ditto.
3567         * TestWebKitAPI/config.h: Ditto.
3568
3569 2015-05-01  Basile Clement  <basile_clement@apple.com>
3570
3571         Unreviewed. Add myself as a commiter in contributors.json.
3572
3573         * Scripts/webkitpy/common/config/contributors.json:
3574
3575 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3576
3577         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3578         https://bugs.webkit.org/show_bug.cgi?id=144487
3579
3580         Reviewed by Ryosuke Niwa.
3581
3582         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3583         (BenchmarkRunner.merge): Fix bug.
3584         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3585
3586 2015-05-01  Brady Eidson  <beidson@apple.com>
3587
3588         Add API to disable meta refreshes.
3589         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3590
3591         Reviewed by Alexey Proskuryakov.
3592
3593         * DumpRenderTree/mac/DumpRenderTree.mm:
3594         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3595
3596 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3597
3598         Provide a runtime flag to run-webkit-tests that shows the test view
3599         https://bugs.webkit.org/show_bug.cgi?id=144079.
3600
3601         Unreviewed correction to r183651.
3602
3603         * WebKitTestRunner/TestController.cpp:
3604         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3605         flag is included in the options dictionary passed to the PlatformWebView.
3606
3607 2015-05-01  Antti Koivisto  <antti@apple.com>
3608
3609         Remove network process load serialization code
3610         https://bugs.webkit.org/show_bug.cgi?id=144448
3611
3612         Reviewed by Alexey Proskuryakov.
3613
3614         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3615         (WTR::InjectedBundle::beginTesting):
3616         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3617         (WTR::TestRunner::setSerializeHTTPLoads):
3618         (WTR::TestRunner::dispatchPendingLoadRequests):
3619
3620 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3621
3622         [GTK] Add libhyphen-dev to the build dependencies
3623         https://bugs.webkit.org/show_bug.cgi?id=144452
3624
3625         Reviewed by Martin Robinson.
3626
3627         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3628         dependencies.
3629
3630 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3631
3632         Provide a runtime flag to run-webkit-tests that shows the test view
3633         https://bugs.webkit.org/show_bug.cgi?id=144079.
3634
3635         Reviewed by Dean Jackson.
3636
3637         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3638         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3639         option:
3640
3641         --additional-drt-flag="--show-webview"
3642
3643         * DumpRenderTree/mac/DumpRenderTree.mm:
3644         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
3645         '--show-webview' flag.
3646         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
3647         * WebKitTestRunner/Options.cpp:
3648         (WTR::Options::Options):
3649         (WTR::handleOptionShowWebView):
3650         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
3651         * WebKitTestRunner/Options.h:
3652         * WebKitTestRunner/TestController.cpp:
3653         (WTR::TestController::TestController):
3654         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the&n