bb7a87a7418af81d1ac4f06f78c222338f0bbfaa
[WebKit-https.git] / Tools / ChangeLog
1 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2
3         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
4         being the same as a "quick run", which is meant for genuinely slow tests).
5
6         * Scripts/run-jsc-stress-tests:
7
8 2014-04-21  Darin Adler  <darin@apple.com>
9
10         Add HashSet::takeAny
11         https://bugs.webkit.org/show_bug.cgi?id=131928
12
13         Reviewed by Benjamin Poulain.
14
15         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
16
17 2014-04-20  Dan Bernstein  <mitz@apple.com>
18
19         Fixed a test timing out after r167572.
20
21         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
22         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
23         -webView:didFinishLoadingNavigation:.
24
25 2014-04-20  Commit Queue  <commit-queue@webkit.org>
26
27         Unreviewed, rolling out r167510.
28         https://bugs.webkit.org/show_bug.cgi?id=131915
29
30         broke GTK Debug bot (Requested by philn on #webkit).
31
32         Reverted changeset:
33
34         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
35         it when running layout tests"
36         https://bugs.webkit.org/show_bug.cgi?id=131472
37         http://trac.webkit.org/changeset/167510
38
39 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
40
41         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
42         https://bugs.webkit.org/show_bug.cgi?id=131472
43
44         Reviewed by Philippe Normand.
45
46         * Scripts/webkitpy/port/gtk.py:
47         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
48         when running WebKitTestRunner with run-webkit-tests.
49         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
50         installed.
51         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
52         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
53         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
54         deal.
55
56 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
57
58         DownloadDecideDestinationCrash API test uses an incorrect value for path
59         https://bugs.webkit.org/show_bug.cgi?id=131845
60         <rdar://problem/15925560>
61
62         Reviewed by Enrica Casucci.
63
64         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
65         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
66
67 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
68
69         [Mac] AttributedStringTest API tests fail with async text input
70         https://bugs.webkit.org/show_bug.cgi?id=131833
71
72         Reviewed by Enrica Casucci.
73
74         Don't run sync NSTextInputClient tests where we don't implement these calls.
75
76         * TestWebKitAPI/Tests/mac/AttributedString.mm:
77         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
78         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
79         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
80         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
81         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
82         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
83
84 2014-04-18  Philippe Normand  <pnormand@igalia.com>
85
86         Remove NETWORK_INFO support
87         https://bugs.webkit.org/show_bug.cgi?id=131841
88
89         Reviewed by Gyuyoung Kim.
90
91         * Scripts/webkitperl/FeatureList.pm:
92
93 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
94
95         [GTK] YouCompleteMe doesn't work for cmake build system.
96         https://bugs.webkit.org/show_bug.cgi?id=131591
97
98         Reviewed by Martin Robinson.
99
100         Add cmake build system support for YouCompleteMe. It should work regardless of
101         using make or ninja. In addition, autotools related code is removed since it's
102         not used anymore in WebKit.
103
104         * Scripts/webkitdirs.pm:
105         (generateBuildSystemFromCMakeProject):
106         * gtk/ycm_extra_conf.py:
107         (transform_relative_paths_to_absolute_paths):
108         (FlagsForFile):
109
110 2014-04-17  Anders Carlsson  <andersca@apple.com>
111
112         Fix build.
113
114         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
115         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
116         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
117
118 2014-04-17  Anders Carlsson  <andersca@apple.com>
119
120         Remove unused API enums
121         https://bugs.webkit.org/show_bug.cgi?id=131836
122
123         Reviewed by Tim Horton.
124
125         * MiniBrowser/mac/WK2BrowserWindowController.m:
126         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
127
128 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
129
130         [Win] A few final cleanups to the DataObject classes.
131         https://bugs.webkit.org/show_bug.cgi?id=131784
132
133         Reviewed by Anders Carlsson.
134
135         * DumpRenderTree/win/DRTDataObject.cpp:
136         (DRTDataObject::clearData): Use 'last()' method.
137         * DumpRenderTree/win/UIDelegate.cpp:
138         (DRTUndoStack::pop): Use 'takeLast()' method.
139
140 2014-04-17  Andres Gomez  <agomez@igalia.com>
141
142         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
143         https://bugs.webkit.org/show_bug.cgi?id=131365
144
145         Reviewed by Brent Fulgham.
146
147         The cygwin installer is now downloading the wanted versions for
148         the local installation given to the setup wizard.
149
150         * CygwinDownloader/cygwin-downloader.py:
151         * CygwinDownloader/cygwin-downloader.zip:
152
153 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
154
155         [GTK] Make run-webkit-tests always use WKTR
156         https://bugs.webkit.org/show_bug.cgi?id=131737
157
158         Reviewed by Darin Adler.
159
160         Now that the GTK+ port only has support for WebKit2, instruct
161         run-webkit-tests to always use WKTR. This avoids needing to pass
162         flag "-2" every time.
163
164         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
165         (_set_up_derived_options): Always set webkit_test_runner when
166         the platform is GTK+.
167
168 2014-04-17  Brendan Long  <b.long@cablelabs.com>
169
170         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
171         https://bugs.webkit.org/show_bug.cgi?id=131760
172
173         Reviewed by Philippe Normand.
174
175         * gtk/install-dependencies: Install ninja-build when it's available.
176
177 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
178
179         [Win] run-javascriptcore-tests fails to run.
180         https://bugs.webkit.org/show_bug.cgi?id=131761
181
182         Reviewed by Brent Fulgham.
183
184         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
185
186 2014-04-16  Andres Gomez  <agomez@igalia.com>
187
188         [Win] Pass default parameters to cygwin setup wizard
189         https://bugs.webkit.org/show_bug.cgi?id=131361
190
191         Reviewed by Brent Fulgham.
192
193         Added some parameters to the cygwin setup wizard so the user
194         doesn't really have to do any interaction.
195
196         * CygwinDownloader/cygwin-downloader.py:
197         * CygwinDownloader/cygwin-downloader.zip:
198
199 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
200
201         [Win] Eliminate use of deleteAllValues in Windows Files
202         https://bugs.webkit.org/show_bug.cgi?id=131631
203
204         Reviewed by Darin Adler.
205
206         Switch to std::unique_ptr for memory lifetime. Get rid of
207         deleteAllValues now that it is no longer needed. Use ranged
208         for loops where possible.
209
210         * DumpRenderTree/win/DRTDataObject.cpp:
211         (WCEnumFormatEtc::WCEnumFormatEtc):
212         (DRTDataObject::~DRTDataObject):
213         (DRTDataObject::GetData):
214         (DRTDataObject::QueryGetData):
215         (DRTDataObject::SetData):
216         (DRTDataObject::clearData):
217         * DumpRenderTree/win/DRTDataObject.h:
218         * DumpRenderTree/win/UIDelegate.cpp:
219         (DRTUndoObject::DRTUndoObject):
220         (DRTUndoObject::~DRTUndoObject):
221         (DRTUndoStack::~DRTUndoStack):
222         (DRTUndoStack::clear):
223         (DRTUndoStack::pop):
224         (DRTUndoManager::DRTUndoManager):
225         (DRTUndoManager::redo):
226         (DRTUndoManager::undo):
227         (UIDelegate::UIDelegate):
228         (UIDelegate::resetUndoManager):
229         * DumpRenderTree/win/UIDelegate.h:
230
231 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
232
233         [GTK] Unreviewed GTK gardening.
234
235         Update list of skipped unit tests:
236
237           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
238
239           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
240           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
241
242         * Scripts/run-gtk-tests:
243         (TestRunner):
244
245 2014-04-16  Tim Horton  <timothy_horton@apple.com>
246
247         check-webkit-style doesn't check code style in .mm or .m files
248         https://bugs.webkit.org/show_bug.cgi?id=131708
249
250         Reviewed by Darin Adler.
251
252         * Scripts/webkitpy/style/checker.py:
253         * Scripts/webkitpy/style/checker_unittest.py:
254         (CheckerDispatcherDispatchTest.test_cpp_paths):
255         (CheckerDispatcherDispatchTest.test_text_paths):
256         Check .mm and .m files as C++.
257
258         * Scripts/webkitpy/style/checkers/cpp.py:
259         (check_spacing):
260         Add an override for our ordinary "missing spaces around =" for @synthesize,
261         which should look like "@synthesize propertyName=_varName;"
262
263         Add an override for "missing space before {" for blocks' "^{".
264
265         Don't follow the "extra space before [" rule for Objective-C, because
266         it breaks this rule in a multitude of ways because of method calls.
267
268         (check_braces):
269         Don't complain about { not being on the end of the previous line if
270         the previous line starts with "- (" or "+ (", which would indicate a
271         Objective-C method definition.
272
273 2014-04-16  Darin Adler  <darin@apple.com>
274
275         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
276         https://bugs.webkit.org/show_bug.cgi?id=131735
277
278         Reviewed by Alexey Proskuryakov.
279
280         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
281         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
282         is on the right. This can be confusing since our JavaScript test framework does it the opposite
283         way, but gtest works better this way.
284
285 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
286
287         [EFL] Fix problems with the pixel dump.
288         https://bugs.webkit.org/show_bug.cgi?id=131265
289
290         Reviewed by Gyuyoung Kim.
291
292         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
293         However pixel dump codes still call deprecated functions like ewk_view_paint(),
294         which causes that nothing is drawn.
295
296         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
297         One of new functions is AcceleratedCompositingContext::extractImageData(),
298         which replaces deprecated function calls. Besides the extractImageData() is invoked by
299         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
300
301         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
302         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
303
304 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
305
306         Update LLVM export scrpt to handle the build directory being different from the
307         source directory.
308
309         Rubber stamped by Geoffrey Garen.
310
311         * Scripts/export-llvm-build:
312
313 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
314
315         Update the hyperlink to waterfall views of perf bots on build.webkit.org
316         https://bugs.webkit.org/show_bug.cgi?id=131695
317
318         Reviewed by Antti Koivisto.
319
320         Updated.
321
322         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
323
324 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
325
326         [GTK] Reduce the binary size by compressing the text based web inspector resources
327         https://bugs.webkit.org/show_bug.cgi?id=121545
328
329         Reviewed by Gustavo Noronha Silva.
330
331         Compress text based files when compiling inspector resources. It
332         reduces the binary size in 3MB.
333
334         * gtk/generate-inspector-gresource-manifest.py:
335         (find_all_files_in_directory):
336         (is_compressible):
337
338 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
339
340         Remove Gtk WebKit1 tester.
341
342         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
343         results over and over as fast as it could.
344
345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
346         (WebKitBuildbot):
347
348 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
349
350         Wrong link for webkitpy tests results in dashboard popover
351         https://bugs.webkit.org/show_bug.cgi?id=131664
352
353         Reviewed by Timothy Hatcher.
354
355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
356         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
357         Use a correct link.
358
359 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
360
361         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
362
363         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
364
365         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
366         (CommitMessageForThisCommitTest):
367
368 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
369
370         Fix commit-log-editor bug revealed by r165447
371         https://bugs.webkit.org/show_bug.cgi?id=130676
372
373         Reviewed by Csaba Osztrogonác.
374
375         * Scripts/commit-log-editor:
376         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
377         Add \n before the first block too, because the longest common prefix now ends with only one newline.
378         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
379         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
380
381 2014-04-13  Darin Adler  <darin@apple.com>
382
383         userVisibleString should not try to "encode" host names
384         https://bugs.webkit.org/show_bug.cgi?id=131587
385         rdar://problem/14686849
386
387         Reviewed by Alexey Proskuryakov.
388
389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
390
391         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
392         Coverage is tiny at this point; we could add a lot more cases!
393
394 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
395
396         Use #include instead of #import
397         https://bugs.webkit.org/show_bug.cgi?id=131604
398
399         Reviewed by Darin Adler.
400
401         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
402
403         * TestWebKitAPI/Tests/WTF/StringView.cpp:
404
405 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
406
407         Make slow-stress tests run faster by running fewer VM variants.
408
409         Rubber stamped by Geoffrey Garen.
410
411         * Scripts/run-javascriptcore-tests:
412         * Scripts/run-jsc-stress-tests:
413
414 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
415
416         [CMake] Add missing WTF unit tests
417         https://bugs.webkit.org/show_bug.cgi?id=131459
418
419         Reviewed by Martin Robinson.
420
421         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
422         that should be compiled into the TestWTF binary.
423
424 2014-04-10  Brendan Long  <b.long@cablelabs.com>
425
426         [Gtk] run-launcher doesn't work by default
427         https://bugs.webkit.org/show_bug.cgi?id=131494
428
429         Reviewed by Philippe Normand.
430
431         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
432         * Scripts/webkitdirs.pm:
433         (launcherName): Same.
434         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
435         * gtk/common.py:
436         (get_build_path.is_valid_build_directory): Same.
437         * gtk/manifest.txt: Same.
438
439 2014-04-09  Commit Queue  <commit-queue@webkit.org>
440
441         Unreviewed, rolling out r167046.
442         https://bugs.webkit.org/show_bug.cgi?id=131479
443
444         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
445         on #webkit).
446
447         Reverted changeset:
448
449         "Remove "System Font" from whitelisted DRT fonts and char
450         width calculations"
451         https://bugs.webkit.org/show_bug.cgi?id=131411
452         http://trac.webkit.org/changeset/167046
453
454 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
455
456         Remove "System Font" from whitelisted DRT fonts and char width calculations
457         https://bugs.webkit.org/show_bug.cgi?id=131411
458
459         Reviewed by Tim Horton.
460
461         Covered by existing tests.
462
463         * DumpRenderTree/mac/DumpRenderTree.mm:
464         (allowedFontFamilySet):
465
466 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
467
468         systemHiddenFontFamilySet in DRT is unnecessary
469         https://bugs.webkit.org/show_bug.cgi?id=131414
470
471         Reviewed by Tim Horton.
472
473         It doesn't seem to affect test results on my machine.
474
475         * DumpRenderTree/mac/DumpRenderTree.mm:
476         (drt_NSFontManager_availableFonts):
477         (systemHiddenFontFamilySet): Deleted.
478
479 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
480
481         [Win] Unreviewed test fix: Don't double-release BSTR.
482
483         * DumpRenderTree/win/DumpRenderTree.cpp:
484         (dump): Remove unneeded call to SysFreeString now that we are
485         using _bstr_t for this variable.
486
487 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
488
489         [Win] Various DumpRenderTree Fixes.
490         https://bugs.webkit.org/show_bug.cgi?id=131446.
491
492         Reviewed by Tim Horton.
493
494         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
495         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
496         (AccessibilityUIElement::description): Ditto.
497         (AccessibilityUIElement::helpText): Ditto.
498         (AccessibilityUIElement::intValue): Ditto.
499         (AccessibilityUIElement::isPressActionSupported): Ditto.
500         (AccessibilityUIElement::accessibilityValue): Ditto.
501         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
502         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
503         (DRTDesktopNotificationPresenter::AddRef): Ditto.
504         (DRTDesktopNotificationPresenter::Release): Ditto.
505         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
506         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
507         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
508         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
509         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
510         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
511         * DumpRenderTree/win/DumpRenderTree.cpp:
512         (dumpFrameScrollPosition): Ditto.
513         (dumpFramesAsText): Ditto.
514         (compareHistoryItems): Ditto.
515         (dumpHistoryItem): Ditto.
516         (dump): Ditto.
517         (resetDefaultsToConsistentValues): Ditto.
518         (resetWebViewToConsistentStateBeforeTesting): Ditto.
519         (runTest): Ditto.
520         (createWebViewAndOffscreenWindow): Ditto.
521         * DumpRenderTree/win/EditingDelegate.cpp:
522         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
523         (EditingDelegate::AddRef): Ditto.
524         (EditingDelegate::Release): Ditto.
525         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
526         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
527         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
528         (EditingDelegate::shouldInsertNode): Ditto.
529         (EditingDelegate::shouldInsertText): Ditto.
530         (EditingDelegate::shouldDeleteDOMRange): Ditto.
531         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
532         (EditingDelegate::shouldApplyStyle): Ditto.
533         (EditingDelegate::shouldChangeTypingStyle): Ditto.
534         (EditingDelegate::doPlatformCommand): Ditto.
535         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
536         (EditingDelegate::webViewDidChange): Ditto.
537         (EditingDelegate::webViewDidEndEditing): Ditto.
538         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
539         (EditingDelegate::webViewDidChangeSelection): Ditto.
540         (EditingDelegate::checkSpellingOfString): Ditto.
541         * DumpRenderTree/win/FrameLoadDelegate.cpp:
542         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
543         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
544         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
545         (FrameLoadDelegate::AddRef): Ditto.
546         (FrameLoadDelegate::Release): Ditto.
547         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
548         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
549         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
550         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
551         (FrameLoadDelegate::didReceiveTitle): Ditto.
552         (FrameLoadDelegate::didChangeIcons): Ditto.
553         (delegatesWithDelayedWork): Ditto.
554         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
555         (FrameLoadDelegate::didFailLoadWithError): Ditto.
556         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
557         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
558         (FrameLoadDelegate::willCloseFrame): Ditto.
559         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
560         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
561         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
562         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
563         (FrameLoadDelegate::didRunInsecureContent): Ditto.
564         * DumpRenderTree/win/FrameLoadDelegate.h:
565         * DumpRenderTree/win/HistoryDelegate.cpp:
566         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
567         (HistoryDelegate::updateHistoryTitle): Ditto.
568         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
569         * DumpRenderTree/win/PolicyDelegate.cpp:
570         (dumpPath):
571         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
572         (PolicyDelegate::AddRef): Ditto.
573         (PolicyDelegate::Release): Ditto.
574         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
575         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
576         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
577         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
578         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
579         (ResourceLoadDelegate::AddRef): Ditto.
580         (ResourceLoadDelegate::Release): Ditto.
581         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
582         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
583         (ResourceLoadDelegate::willSendRequest): Ditto.
584         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
585         (ResourceLoadDelegate::didReceiveResponse): Ditto.
586         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
587         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
588         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
589         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
590         (TestRunner::setUserStyleSheetLocation): Ditto.
591         (TestRunner::execCommand): Ditto.
592         (TestRunner::overridePreference): Ditto.
593         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
594         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
595         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
596         (TextInputController::insertText): Ditto.
597         * DumpRenderTree/win/UIDelegate.cpp:
598         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
599         (UIDelegate::AddRef): Ditto.
600         (UIDelegate::Release): Ditto.
601         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
602         (UIDelegate::trackCustomPopupMenu): Ditto.
603         (UIDelegate::registerUndoWithTarget): Ditto.
604         (UIDelegate::removeAllActionsWithTarget): Ditto.
605         (UIDelegate::setActionTitle): Ditto.
606         (UIDelegate::undo): Ditto.
607         (UIDelegate::redo): Ditto.
608         (UIDelegate::canUndo): Ditto.
609         (UIDelegate::canRedo): Ditto.
610         (UIDelegate::printFrame): Ditto.
611         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
612         (UIDelegate::webViewHeaderHeight): Ditto.
613         (UIDelegate::webViewFooterHeight): Ditto.
614         (UIDelegate::drawHeaderInRect): Ditto.
615         (UIDelegate::drawFooterInRect): Ditto.
616         (UIDelegate::webViewPrintingMarginRect): Ditto.
617         (UIDelegate::canRunModal): Ditto.
618         (UIDelegate::createModalDialog): Ditto.
619         (UIDelegate::runModal): Ditto.
620         (UIDelegate::isMenuBarVisible): Ditto.
621         (UIDelegate::setMenuBarVisible): Ditto.
622         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
623         (UIDelegate::paintCustomScrollbar): Ditto.
624         (UIDelegate::paintCustomScrollCorner): Ditto.
625         (UIDelegate::setFrame): Ditto.
626         (UIDelegate::webViewFrame): Ditto.
627         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
628         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
629         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
630         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
631         (UIDelegate::webViewAddMessageToConsole): Ditto.
632         (UIDelegate::doDragDrop): Ditto.
633         (UIDelegate::webViewGetDlgCode): Ditto.
634         (UIDelegate::createWebViewWithRequest): Ditto.
635         (UIDelegate::webViewClose): Ditto.
636         (UIDelegate::webViewFocus): Ditto.
637         (UIDelegate::webViewUnfocus): Ditto.
638         (UIDelegate::webViewPainted): Ditto.
639         (UIDelegate::exceededDatabaseQuota): Ditto.
640         (UIDelegate::embeddedViewWithArguments): Ditto.
641         (UIDelegate::webViewClosing): Ditto.
642         (UIDelegate::webViewSetCursor): Ditto.
643         (UIDelegate::webViewDidInvalidate): Ditto.
644         (UIDelegate::setStatusText): Ditto.
645         (UIDelegate::desktopNotificationsDelegate): Ditto.
646         (UIDelegate::drawBackground): Ditto.
647         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
648         (UIDelegate::didPressMissingPluginButton): Ditto.
649         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
650         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
651         (LoadHTMLStringItem::invoke): Ditto.
652         (ScriptItem::invoke): Ditto.
653
654 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
655
656         Stylechecker: False positive on inline asm code.
657         https://bugs.webkit.org/show_bug.cgi?id=130570
658
659         Reviewed by Csaba Osztrogonác.
660
661         Disable stylechecking in asm blocks.
662
663         * Scripts/webkitpy/style/checkers/cpp.py:
664         (process_line):
665         (_InlineASMState):
666         (_InlineASMState.__init__):
667         (_InlineASMState.process_line):
668         (_InlineASMState.isInside):
669         (_process_lines):
670         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
671         (WebKitStyleTest.test_member_initialization_list):
672
673 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
674
675         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
676         https://bugs.webkit.org/show_bug.cgi?id=131029
677
678         Reviewed by Philippe Normand.
679
680         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
681         tests and remove the getWebKit1TestResoucesDir() method.
682
683         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
684         (testDownloadLocalFile): Use Test::getResourcesDir().
685         (testDownloadLocalFileError): Ditto.
686         (serverCallback): Ditto.
687         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
688         (serverCallback): Ditto.
689         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
690         (httpServerCallback): Ditto.
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
692         (serverCallback): Ditto.
693         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
694         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
695         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
696         (Test::getWebKit1TestResoucesDir): Deleted.
697
698 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
699
700         [WK2] HTTP authentication regression tests fail
701         https://bugs.webkit.org/show_bug.cgi?id=81627
702         <rdar://problem/11079296>
703
704         Reviewed by Anders Carlsson.
705
706         * WebKitTestRunner/TestController.h:
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
709         to pageLoaderClient structure.
710         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
711         for password based authentication (we do get server trust challenges on some tests,
712         which WKTR can't handle).
713         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
714         calls won't be made, at least on CFNetwork based platforms.
715         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
716         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
717         make sense to associate auth requests with individual resources - there can be
718         multiple resources loading at once from the same protection space, so WebKit1 API
719         that had a resource identifier was inherently racy.
720
721 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
722
723         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
724         https://bugs.webkit.org/show_bug.cgi?id=131427
725
726         Reviewed by Gyuyoung Kim.
727
728         Since r166973, font path was changed.
729
730         * DumpRenderTree/PlatformEfl.cmake:
731         * WebKitTestRunner/PlatformEfl.cmake:
732
733 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
734
735         Fix the build-jsc build
736         https://bugs.webkit.org/show_bug.cgi?id=131410
737
738         Reviewed by Michael Saboff.
739
740         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
741         WTF depends on it.
742
743 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
744
745         [GTK] Remove WebKit1 unit tests
746         https://bugs.webkit.org/show_bug.cgi?id=131359
747
748         Reviewed by Anders Carlsson.
749
750         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
751         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
752         they were inadvertently left in http://trac.webkit.org/changeset/166504.
753
754         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
755         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
756         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
757         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
758         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
759         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
760         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
761         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
762         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
763         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
764         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
765         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
766         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
767         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
768         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
769         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
770         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
771         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
772         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
773         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
774         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
775         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
776         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
777         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
778         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
779         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
780         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
781         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
782         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
783         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
784         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
785         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
786         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
787         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
788         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
789         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
790         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
791         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
792
793 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
794
795         Unreviewed gardening (Take 2): Prevent users from attempting
796         to build with known invalid cURL. 
797
798         * Scripts/webkitdirs.pm:
799         (checkInstalledTools): Check for 7.34.0 (the broken version), not
800         7.33.0 (the known good version).
801
802 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
803
804         [GTK] Remove DumpRenderTree and GtkLauncher
805         https://bugs.webkit.org/show_bug.cgi?id=131373
806
807         Reviewed by Andreas Kling.
808
809         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
810         no longer necessary now that WebKit1 GTK+ will be removed.
811
812         * CMakeLists.txt:
813         * DumpRenderTree/PlatformGTK.cmake: Removed.
814         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
815         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
816         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
817         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
818         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
819         * DumpRenderTree/gtk/EventSender.cpp: Removed.
820         * DumpRenderTree/gtk/EventSender.h: Removed.
821         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
822         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
823         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
824         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
825         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
826         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
827         * DumpRenderTree/gtk/TextInputController.h: Removed.
828         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
829         * GtkLauncher/CMakeLists.txt: Removed.
830         * GtkLauncher/LauncherInspectorWindow.c: Removed.
831         * GtkLauncher/LauncherInspectorWindow.h: Removed.
832         * GtkLauncher/main.c: Removed.
833         * GtkLauncher/simple.svg: Removed.
834         * GtkLauncher/text.html: Removed.
835         * WebKitTestRunner/PlatformGTK.cmake:
836         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
837         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
838         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
839
840 2014-04-08  Mark Rowe  <mrowe@apple.com>
841
842         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
843         <https://webkit.org/b/131388> / <rdar://problem/16291687>
844
845         Reviewed by Alexey Proskuryakov.
846
847         * Scripts/webkitdirs.pm:
848         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
849         (execMacWebKitAppForDebugging): Ditto.
850
851 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
852
853         Build bmalloc on iOS too
854         https://bugs.webkit.org/show_bug.cgi?id=131381
855
856         Reviewed by Andreas Kling.
857
858         * Scripts/build-webkit:
859
860 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
861
862         Unreviewed gardening: Prevent users from attempting
863         to build with known invalid cURL.
864
865         * Scripts/webkitdirs.pm:
866         (checkInstalledTools): Block build attempts with bad
867         Cygwin tool set.
868
869 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
870
871         Build bmalloc on Mac
872         https://bugs.webkit.org/show_bug.cgi?id=131333
873
874         Reviewed by Mark Rowe.
875
876         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
877         (Note: Just testing Mac is not good enough because in this
878         script 'Mac' means 'Mac or iOS'.)
879
880 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
881
882         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
883         https://bugs.webkit.org/show_bug.cgi?id=130951
884
885         Reviewed by Geoffrey Garen.
886
887         * Scripts/run-javascriptcore-tests:
888
889 2014-04-06  Darin Adler  <darin@apple.com>
890
891         Rework CSS calc logic, fixing some reference count mistakes in Length
892         https://bugs.webkit.org/show_bug.cgi?id=131280
893
894         Reviewed by Andreas Kling.
895
896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
897         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
898
899 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
900
901         Enable WEB_REPLAY for PLATFORM(MAC)
902         https://bugs.webkit.org/show_bug.cgi?id=130700
903
904         Reviewed by Timothy Hatcher.
905
906         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
907
908 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
909
910         [CMake] Include X11's include dirs in TestNetscapePlugin
911         https://bugs.webkit.org/show_bug.cgi?id=131270
912
913         Reviewed by Martin Robinson.
914
915         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
916         TestNetscapePlugin includes WebCore code that includes X headers.
917
918 2014-04-05  David Kilzer  <ddkilzer@apple.com>
919
920         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
921         <http://webkit.org/b/130986>
922
923         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
924         prefix to TileCache class names in exception list.
925
926 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
927
928         [GTK] kill-old-processes should kill dbus-daemon processes
929         https://bugs.webkit.org/show_bug.cgi?id=127352
930
931         Reviewed by Martin Robinson.
932
933         * BuildSlaveSupport/kill-old-processes:
934         (main):
935
936 2014-04-04  Andres Gomez  <agomez@igalia.com>
937
938         [Win] Update obsolete packages in cygwin
939         https://bugs.webkit.org/show_bug.cgi?id=126264
940
941         Reviewed by Brent Fulgham.
942
943         Removed "apache" and "minires" as the first has been replaced by
944         "lighttpd" and the second is now integrated into
945         "cygwin". Replaced the transitional and now obsolete "gcc" package
946         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
947         since the newer version available is "2.7.3" which breaks the
948         build due to some funniness with environment variable handling.
949
950         * CygwinDownloader/cygwin-downloader.py:
951         * CygwinDownloader/cygwin-downloader.zip:
952
953 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
954
955         check-webkit-style: Improve warnings on Objective-C @property syntax
956         https://bugs.webkit.org/show_bug.cgi?id=131200
957
958         Reviewed by Dan Bernstein.
959
960         * Scripts/webkitpy/style/checkers/cpp.py:
961         (check_spacing):
962         (CppChecker):
963         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
964         (CppStyleTest.test_spacing_in_objective_c_properties):
965
966 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
967
968         Unreviewed. Moving my name to commiter section
969
970         * Scripts/webkitpy/common/config/contributors.json:
971
972 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
973
974         Unreviewed. Add myself as a committer.
975
976         * Scripts/webkitpy/common/config/contributors.json:
977
978 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
979
980         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
981         https://bugs.webkit.org/show_bug.cgi?id=130391
982
983         Reviewed by Gyuyoung Kim.
984
985         Change the implementation of the zoom functionality from ewk_view_scale_set
986         to ewk_view_page_zoom_set.
987
988         * MiniBrowser/efl/main.c:
989
990 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
991
992         [webkitpy] perf profiler does not understand --call-graph argument
993         https://bugs.webkit.org/show_bug.cgi?id=131132
994
995         Reviewed by Ryosuke Niwa.
996
997         New versions of perf profiler have changed the argument from --call-graph to -g.
998
999         * Scripts/webkitpy/common/system/profiler.py:
1000         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1001         * Scripts/webkitpy/port/driver_unittest.py:
1002         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1003
1004 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1005
1006         Add EFL WK2 performance bot to build.webkit.org
1007         https://bugs.webkit.org/show_bug.cgi?id=131034
1008
1009         Fix after r166707, use "Perf" instead of "perf" for consistency.
1010
1011         Reviewed by Csaba Osztrogonác.
1012
1013         * BuildSlaveSupport/build.webkit.org-config/config.json:
1014
1015 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1016
1017         Add EFL WK2 performance bot to build.webkit.org
1018         https://bugs.webkit.org/show_bug.cgi?id=131034
1019
1020         Reviewed by Csaba Osztrogonác.
1021
1022         * BuildSlaveSupport/build.webkit.org-config/config.json:
1023
1024 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1025
1026         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1027         https://bugs.webkit.org/show_bug.cgi?id=131151
1028
1029         Reviewed by Gyuyoung Kim.
1030
1031         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1032         (TouchEventInfo::TouchEventInfo):
1033         (sendTouchEvent):
1034         (addTouchPointCallback):
1035         (updateTouchPointCallback):
1036         (cancelTouchPointCallback):
1037         (releaseTouchPointCallback):
1038
1039 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1040
1041         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1042         <http://webkit.org/b/131045>
1043
1044         Reviewed by Daniel Bates.
1045
1046         * Scripts/filter-build-webkit:
1047         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1048         of clang, plus debug data for all DVTAssertions.
1049
1050 2014-04-01  Dean Jackson  <dino@apple.com>
1051
1052         Load Media Controls js/css from bundle
1053         https://bugs.webkit.org/show_bug.cgi?id=131086
1054
1055         Reviewed by Eric Carlson.
1056
1057         We're now putting CSS files into the bundle, so remove the test for them.
1058
1059         * Scripts/check-for-inappropriate-files-in-framework:
1060
1061 2014-04-02  Martin Hock  <mhock@apple.com>
1062
1063         Unify private browsing with sessions.
1064         https://bugs.webkit.org/show_bug.cgi?id=130099
1065
1066         Reviewed by Alexey Proskuryakov.
1067
1068         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1070         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1071         (TestWebKitAPI::didNavigateWithNavigationData):
1072         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1073         (TestWebKitAPI::TEST):
1074
1075         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1076         (TestWebKitAPI::didNavigateWithoutNavigationData):
1077         (TestWebKitAPI::didNavigateWithNavigationData):
1078         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1079         (TestWebKitAPI::TEST):
1080
1081 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1082
1083         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1084         https://bugs.webkit.org/show_bug.cgi?id=130343
1085
1086         Reviewed by Gustavo Noronha Silva.
1087
1088         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1089         of directories on the command line and look for all appropriate files in those directories for the
1090         GResource archive. Also make archive paths relative to those directories.
1091         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1092         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1093
1094 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1095
1096         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1097         https://bugs.webkit.org/show_bug.cgi?id=131106
1098
1099         Reviewed by Csaba Osztrogonác.
1100
1101         * Scripts/webkitpy/tool/commands/download.py:
1102         (AbstractRolloutPrepCommand._prepare_state):
1103         * Scripts/webkitpy/tool/commands/download_unittest.py:
1104         (test_prepare_rollout):
1105         (test_create_rollout):
1106         (test_create_rollout_resolved):
1107         (test_rollout):
1108
1109 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1110
1111         [EFL] Add option to use separate web process for new window in MiniBrowser
1112         https://bugs.webkit.org/show_bug.cgi?id=130190
1113
1114         Reviewed by Gyuyoung Kim.
1115
1116         New created window (CTRL + n) will be open in separated web process.
1117         This option is enabled by adding a flag (S/separate-process) with launching
1118         MiniBrowser.
1119
1120         * MiniBrowser/efl/main.c:
1121         (elm_main):
1122
1123 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1124
1125         [GTK] Move NEWS file to a new location
1126         https://bugs.webkit.org/show_bug.cgi?id=130901
1127
1128         Reviewed by Brent Fulgham.
1129
1130         * gtk/manifest.txt: Update the NEWS file path.
1131
1132 2014-04-01  Anders Carlsson  <andersca@apple.com>
1133
1134         Fix build.
1135
1136         * MiniBrowser/mac/WK2BrowserWindowController.m:
1137         (-[WK2BrowserWindowController awakeFromNib]):
1138         (-[WK2BrowserWindowController dealloc]):
1139         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1140
1141 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1142
1143         Unreviewed test gardening.
1144
1145         * Scripts/webkitpy/port/base_unittest.py:
1146         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1147
1148 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1149
1150         [CSS Exclusions] Remove exclusions parsing support
1151         https://bugs.webkit.org/show_bug.cgi?id=131046
1152
1153         Reviewed by David Hyatt.
1154
1155         * Scripts/webkitperl/FeatureList.pm:
1156
1157 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1158
1159         [GTK] Remove last reference to GTK+ WK1 EWS
1160         https://bugs.webkit.org/show_bug.cgi?id=131058
1161
1162         Reviewed by Martin Robinson.
1163
1164         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1165
1166         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1167
1168 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1169
1170         Add a 32bit JSC builder/tester.
1171         https://bugs.webkit.org/show_bug.cgi?id=131054
1172         
1173         Reviewed by Michael Saboff.
1174
1175         * BuildSlaveSupport/build.webkit.org-config/config.json:
1176         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1177         (Compile32bitJSC):
1178         (Run32bitJSCTests):
1179         (Run32bitJSCTests.countFailures):
1180         (BuildAndTest32bitJSCFactory):
1181         (BuildAndTest32bitJSCFactory.__init__):
1182
1183 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1184
1185         [GTK] No longer build WebKit1 gtkdoc
1186         https://bugs.webkit.org/show_bug.cgi?id=130970
1187
1188         Reviewed by Anders Carlsson.
1189
1190         * gtk/common.py:
1191         (gtk_version_of_pkg_config_file): Deleted.
1192         * gtk/generate-gtkdoc:
1193         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1194         was only applicable for WebKit1.
1195         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1196
1197 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1198
1199         [GTK] Running minibrowser with url crashes in debug build
1200         https://bugs.webkit.org/show_bug.cgi?id=130492
1201
1202         Reviewed by Martin Robinson.
1203
1204         Update "uri-scheme" test not to use invalid URIs in it, so we
1205         don't get a mistmatch when comparing the original URI stored in
1206         the test class with the one returned by the WebKitWebView.
1207
1208         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1209         (testWebContextURIScheme): Update the test.
1210
1211 2014-04-01  Mihai Tica  <mitica@adobe.com>
1212
1213         Unreviewed: Add myself as a commiter to the contributors list.
1214
1215         * Scripts/webkitpy/common/config/contributors.json:
1216
1217 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1218
1219         [EFL][WK2] Extract the control of page background out of color_set
1220         https://bugs.webkit.org/show_bug.cgi?id=127539
1221
1222         Reviewed by Gyuyoung Kim.
1223
1224         Added an option(C) to change background color.
1225
1226         * MiniBrowser/efl/main.c:
1227         (window_create):
1228         (elm_main):
1229
1230 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1231
1232         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1233
1234         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1235
1236 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1237
1238         Unreviewed test correction after r166530.
1239
1240         * DumpRenderTree/mac/DumpRenderTree.mm:
1241         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1242         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1243
1244 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1245
1246         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1247         https://bugs.webkit.org/show_bug.cgi?id=130987
1248
1249         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1250         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1251
1252         Reviewed by Martin Robinson.
1253
1254         * BuildSlaveSupport/build.webkit.org-config/config.json:
1255
1256 2014-03-31  Dean Jackson  <dino@apple.com>
1257
1258         Remove WEB_ANIMATIONS
1259         https://bugs.webkit.org/show_bug.cgi?id=130989
1260
1261         Reviewed by Simon Fraser.
1262
1263         Remove this feature flag until we plan to implement.
1264
1265         * Scripts/webkitperl/FeatureList.pm:
1266
1267 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1268
1269         Reduced Latched Scroll Test Flakiness
1270         https://bugs.webkit.org/show_bug.cgi?id=130983
1271
1272         Reviewed by Darin Adler.
1273
1274         * DumpRenderTree/mac/DumpRenderTree.mm:
1275         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1276         * DumpRenderTree/mac/EventSendingController.mm:
1277         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1278         with high resolution flags turned on.
1279         * WebKitTestRunner/mac/EventSenderProxy.mm:
1280         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1281
1282 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1283
1284         run-webkit-tests should have a --no-timeout option
1285         https://bugs.webkit.org/show_bug.cgi?id=128286
1286
1287         Reviewed by Joseph Pecoraro.
1288
1289         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1290         (Worker._run_test): Renaming _run_test_with_timeout()
1291         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1292         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1293         (Worker._run_test_in_this_thread):
1294         (Worker._run_test_with_timeout): Deleted.
1295         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1296         (parse_args): Added the --no-timeout option
1297
1298 2014-03-31  Samuel White  <samuel_white@apple.com>
1299
1300         AX: Need ability to get line range for text marker.
1301         https://bugs.webkit.org/show_bug.cgi?id=130906
1302
1303         Reviewed by Chris Fleizach.
1304
1305         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1306
1307         * DumpRenderTree/AccessibilityUIElement.cpp:
1308         (lineTextMarkerRangeForTextMarkerCallback):
1309         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1310         (AccessibilityUIElement::getJSClass):
1311         * DumpRenderTree/AccessibilityUIElement.h:
1312         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1313         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1314         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1315         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1316         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1317         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1318         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1319         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1320         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1321         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1322         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1323         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1324
1325 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1326
1327         More validation for FTL inline caches
1328         https://bugs.webkit.org/show_bug.cgi?id=130948
1329
1330         Reviewed by Geoffrey Garen.
1331
1332         * Scripts/run-jsc-stress-tests:
1333
1334 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1335
1336         [GTK] Do not run WebKit1 unit tests by default
1337         https://bugs.webkit.org/show_bug.cgi?id=130968
1338
1339         Reviewed by Martin Robinson.
1340
1341         * Scripts/run-gtk-tests:
1342         (TestRunner):
1343
1344 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1345
1346         [GTK] Remove scripts code only applicable to autotools
1347         https://bugs.webkit.org/show_bug.cgi?id=130841
1348
1349         Reviewed by Anders Carlsson.
1350
1351         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1352         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1353         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1354         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1355         * gtk/find-make-dist-errors: Removed.
1356         * gtk/generate-feature-defines-files: Removed.
1357         * gtk/manifest.txt: No longer need to consider autotools files.
1358
1359 2014-03-30  Andy Estes  <aestes@apple.com>
1360
1361         Fix two failing layout tests on Mountain Lion after r166466.
1362
1363         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1364         (-[DownloadDelegate _downloadDidStart:]):
1365
1366 2014-03-30  Andy Estes  <aestes@apple.com>
1367
1368         [Cocoa] Add an originatingWebView property to _WKDownload
1369         https://bugs.webkit.org/show_bug.cgi?id=130945
1370
1371         Reviewed by Anders Carlsson.
1372
1373         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1374         (-[DownloadDelegate _downloadDidStart:]):
1375         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1376         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1377         (TEST):
1378
1379 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1380
1381         Land the stackmap register liveness glue with the uses of the liveness disabled
1382         https://bugs.webkit.org/show_bug.cgi?id=130924
1383
1384         Reviewed by Oliver Hunt.
1385
1386         * Scripts/run-jsc-stress-tests:
1387
1388 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1389
1390         Update WebKit1.StringTruncator for Mountain Lion.
1391
1392         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1393         due to different font metrics on 10.8.
1394
1395 2014-03-28  Darin Adler  <darin@apple.com>
1396
1397         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1398         https://bugs.webkit.org/show_bug.cgi?id=130889
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
1403         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
1404         WebStringTruncator methods; should be good for a start. These are dependent on the
1405         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
1406
1407 2014-03-28  Martin Hock  <mhock@apple.com>
1408
1409         Unreviewed. Add myself as a committer.
1410
1411         * Scripts/webkitpy/common/config/contributors.json:
1412
1413 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
1414
1415         Remove WebKit1 GTK+ bots
1416         https://bugs.webkit.org/show_bug.cgi?id=130904
1417
1418         Reviewed by Anders Carlsson.
1419
1420         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
1421         all bots are testing WebKit2 only.
1422         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
1423         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
1424         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1425         * Scripts/webkitpy/port/builders.py: Ditto.
1426         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1427         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
1428
1429 2014-03-28  Timothy Hatcher  <timothy@apple.com>
1430
1431         Remove Brian Burg's apple.com email address.
1432
1433         * Scripts/webkitpy/common/config/contributors.json:
1434
1435 2014-03-28  David Kilzer  <ddkilzer@apple.com>
1436
1437         bisect-builds should print Trac 'changeset' URL if only one build is detected
1438         <http://webkit.org/b/130903>
1439
1440         Reviewed by Dan Bernstein.
1441
1442         * Scripts/bisect-builds:
1443         (printTracLink): Print a direct link to the Trac 'changeset'
1444         URL if there is only one revision in the range.
1445
1446 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1447
1448         [EFL] Bump glib version from 2.36 to 2.38 
1449         https://bugs.webkit.org/show_bug.cgi?id=130886
1450
1451         Reviewed by Csaba Osztrogonác.
1452
1453         There is a build break on EFL port when using glib 2.36 ver. To fix it,
1454         we need to bump glib version up to 2.38 as gtk port.
1455
1456         * efl/jhbuild.modules:
1457
1458 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1459
1460         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
1461
1462         Provide an implementation of WKContextHistoryClient that logs when called for tests in
1463         the globalhistory directory.
1464
1465         Reviewed by Sam Weinig.
1466
1467         * WebKitTestRunner/TestController.cpp:
1468         (WTR::TestController::TestController):
1469         (WTR::TestController::initialize): Set the history client.
1470         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
1471         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
1472         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
1473         and we don't yet have API to access the data in question.
1474         (WTR::TestController::didPerformClientRedirect):
1475         (WTR::TestController::didPerformServerRedirect):
1476         (WTR::TestController::didUpdateHistoryTitle):
1477         * WebKitTestRunner/TestController.h:
1478         (WTR::TestController::setShouldLogHistoryClientCallbacks):
1479         * WebKitTestRunner/TestInvocation.cpp:
1480         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
1481         (WTR::TestInvocation::invoke):
1482
1483 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
1484
1485         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
1486
1487         * Scripts/build-webkit:
1488         * Scripts/copy-webkitlibraries-to-product-directory:
1489
1490 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
1491
1492         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1493         https://bugs.webkit.org/show_bug.cgi?id=130867
1494         <rdar://problem/16432456> 
1495
1496         Reviewed by Mark Hahnenberg.
1497
1498         * Scripts/build-webkit:
1499         * Scripts/copy-webkitlibraries-to-product-directory:
1500
1501 2014-03-26  Andy Estes  <aestes@apple.com>
1502
1503         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
1504         https://bugs.webkit.org/show_bug.cgi?id=130805
1505
1506         Reviewed by Dan Bernstein.
1507
1508         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1509         (-[DownloadDelegate _download:didReceiveResponse:]):
1510         (-[DownloadDelegate _downloadDidFinish:]):
1511         (runTest):
1512         (TEST):
1513         (-[FailingDownloadDelegate _downloadDidFinish:]):
1514         (-[FailingDownloadDelegate _download:didFailWithError:]):
1515         (-[FailingDownloadDelegate _downloadDidCancel:]):
1516         (-[CancelledDownloadDelegate _downloadDidStart:]):
1517         (-[CancelledDownloadDelegate _downloadDidFinish:]):
1518         (-[CancelledDownloadDelegate _download:didFailWithError:]):
1519         (-[CancelledDownloadDelegate _downloadDidCancel:]):
1520         (-[DownloadDelegate initWithSourceURL:]): Deleted.
1521         (-[DownloadDelegate sourceURL]): Deleted.
1522         (runTestWithNavigationDelegate): Deleted.
1523
1524 2014-03-26  Anders Carlsson  <andersca@apple.com>
1525
1526         Change MiniBrowser to hold on to window controllers instead of windows
1527         https://bugs.webkit.org/show_bug.cgi?id=130797
1528
1529         Reviewed by Oliver Hunt.
1530
1531         * MiniBrowser/mac/AppDelegate.h:
1532         * MiniBrowser/mac/AppDelegate.m:
1533         (-[BrowserAppDelegate init]):
1534         (-[BrowserAppDelegate newWindow:]):
1535         (-[BrowserAppDelegate browserWindowWillClose:]):
1536         (-[BrowserAppDelegate applicationWillTerminate:]):
1537         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1538
1539 2014-03-26  Commit Queue  <commit-queue@webkit.org>
1540
1541         Unreviewed, rolling out r166264.
1542         https://bugs.webkit.org/show_bug.cgi?id=130785
1543
1544         Broke some window.opener tests for WK2 Mavericks (Requested by
1545         brrian__ on #webkit).
1546
1547         Reverted changeset:
1548
1549         "Web Replay: resource unique identifiers should be unique-per-
1550         frame, not globally"
1551         https://bugs.webkit.org/show_bug.cgi?id=130632
1552         http://trac.webkit.org/changeset/166264
1553
1554 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
1555
1556         [CSS Shapes] Remove shape-inside support
1557         https://bugs.webkit.org/show_bug.cgi?id=130698
1558
1559         Reviewed by David Hyatt.
1560
1561         * Scripts/webkitperl/FeatureList.pm:
1562
1563 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
1564
1565         Unreviewed. Add myself as a committer.
1566
1567         * Scripts/webkitpy/common/config/contributors.json:
1568
1569 2014-03-26  Tomas Popela  <tpopela@redhat.com>
1570
1571         run-launcher is Perl script so use elsif and not elif
1572         https://bugs.webkit.org/show_bug.cgi?id=130771
1573
1574         Reviewed by Carlos Garcia Campos.
1575
1576         * Scripts/run-launcher:
1577
1578 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
1579
1580         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
1581         https://bugs.webkit.org/show_bug.cgi?id=130575
1582
1583         Reviewed by Mario Sanchez Prada.
1584
1585         Change ATK version to 2.11.92. Adjust current implementation.
1586
1587         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1588         (AccessibilityUIElement::intValue):
1589         (AccessibilityUIElement::minValue):
1590         (AccessibilityUIElement::maxValue):
1591         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1592         (WTR::AccessibilityUIElement::intValue):
1593         (WTR::AccessibilityUIElement::minValue):
1594         (WTR::AccessibilityUIElement::maxValue):
1595         * efl/jhbuild.modules:
1596         * gtk/jhbuild.modules:
1597
1598 2014-03-12  Philippe Normand  <pnormand@igalia.com>
1599
1600         [GTK] The gnumake package is no longer needed in jhbuild
1601         https://bugs.webkit.org/show_bug.cgi?id=130121
1602
1603         Reviewed by Martin Robinson.
1604
1605         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
1606         for a debug build cmake/system-gnumake worked just fine for me.
1607
1608         * gtk/jhbuild.modules: Removed gnumake.
1609         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
1610         * gtk/patches/make-3.82-parallel-build.patch: Removed.
1611
1612 2014-03-25  Andy Estes  <aestes@apple.com>
1613
1614         Fix a failing API test on Mountain Lion and remove temporary debug logging.
1615
1616         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1617         (-[DownloadDelegate _download:didReceiveData:]):
1618         (-[DownloadDelegate _downloadDidFinish:]):
1619
1620 2014-03-25  Brian Burg  <bburg@apple.com>
1621
1622         Web Replay: resource unique identifiers should be unique-per-frame, not globally
1623         https://bugs.webkit.org/show_bug.cgi?id=130623
1624
1625         Reviewed by Timothy Hatcher.
1626
1627         The resource loader callback dumping routines assumed that resource identifiers
1628         were globally unique. Its map of resource identifiers to URLs must also track the
1629         frame associated with the resource.
1630
1631         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1632         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
1633         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
1634         stable as long as the frame is valid.
1635         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1636         (WTR::InjectedBundlePage::willSendRequestForFrame):
1637         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1638         (WTR::InjectedBundlePage::didFinishLoadForResource):
1639         (WTR::InjectedBundlePage::didFailLoadForResource):
1640
1641 2014-03-25  Andy Estes  <aestes@apple.com>
1642
1643         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
1644
1645         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1646         (-[DownloadDelegate _download:didReceiveResponse:]):
1647         (-[DownloadDelegate _download:didReceiveData:]):
1648
1649 2014-03-25  Andy Estes  <aestes@apple.com>
1650
1651         Add some debug logging to an API test that's failing on Mountain Lion.
1652
1653         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1654         (-[DownloadDelegate _download:didReceiveResponse:]):
1655         (-[DownloadDelegate _downloadDidFinish:]):
1656
1657 2014-03-25  Anders Carlsson  <andersca@apple.com>
1658
1659         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
1660         https://bugs.webkit.org/show_bug.cgi?id=130732
1661
1662         Reviewed by Tim Horton.
1663
1664         * MiniBrowser/mac/WK2BrowserWindowController.m:
1665         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1666
1667 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
1668
1669         [GTK] Remove the autotools build
1670         https://bugs.webkit.org/show_bug.cgi?id=130717
1671
1672         Reviewed by Anders Carlsson.
1673
1674         * DumpRenderTree/config.h: Remove references to the autotools configure file.
1675         * GNUmakefile.am: Removed.
1676         * GtkLauncher/GNUmakefile.am: Removed.
1677         * GtkLauncher/main.c: Remove references to the autotools configure file.
1678         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
1679         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
1680         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
1681         * MiniBrowser/gtk/GNUmakefile.am: Removed.
1682         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
1683         * Scripts/build-webkit: No longer handle autotools.
1684         * Scripts/run-gtk-tests: Ditto.
1685         (TestRunner._setup_testing_environment):
1686         * Scripts/run-launcher: Ditto.
1687         * Scripts/webkitdirs.pm: Ditto.
1688         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
1689         * Scripts/webkitpy/common/config/contributors.json: Ditto.
1690         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
1691         * Scripts/webkitpy/style/checker.py:
1692         * TestWebKitAPI/GNUmakefile.am: Removed.
1693         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
1694         * WebKitTestRunner/GNUmakefile.am: Removed.
1695         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
1696         * gtk/GNUmakefile.am: Removed.
1697         * gtk/common.py: Remove checks for the autotools build.
1698         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
1699
1700 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
1701
1702         prepare-ChangeLog throws false positive warnings for modified files.
1703         https://bugs.webkit.org/show_bug.cgi?id=130687
1704
1705         Reviewed by Darin Adler.
1706
1707         * Scripts/prepare-ChangeLog:
1708         (originalFile): Ignore git commit paremeter.
1709         We don't need this to get the unmodified file.
1710         (extractLineRangeBeforeChange):
1711         Simplify the if statement. Follow-up after r166189.
1712
1713 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
1714
1715         [EFL] Add ARM64 build support
1716         https://bugs.webkit.org/show_bug.cgi?id=130506
1717
1718         Rubber stamped by Gyuyoung Kim.
1719
1720         * Scripts/webkitdirs.pm:
1721         (isARM): Detect aarch64 as ARM.
1722
1723 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1724
1725         [webkitpy] Improve _parse_bug_description to recognize more descriptions
1726         https://bugs.webkit.org/show_bug.cgi?id=130137
1727
1728         Reviewed by Csaba Osztrogonác.
1729
1730         * Scripts/webkitpy/common/checkout/changelog.py:
1731         (ChangeLogEntry._parse_bug_description):
1732         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1733         (test_parse_log_entries_from_changelog):
1734         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1735         (CheckoutTest.test_commit_info_for_revision):
1736
1737 2014-03-24  Andy Estes  <aestes@apple.com>
1738
1739         Fix the iOS build of TestWebKitAPI.
1740
1741         * TestWebKitAPI/Configurations/Base.xcconfig:
1742         * TestWebKitAPI/PlatformUtilities.h:
1743
1744 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
1745
1746         Fix prepare-ChangeLog after r166156.
1747         https://bugs.webkit.org/show_bug.cgi?id=130674
1748
1749         Reviewed by Darin Adler.
1750
1751         * Scripts/prepare-ChangeLog:
1752         (generateFunctionLists):
1753         (extractLineRangeBeforeChange):
1754
1755 2014-03-24  Andy Estes  <aestes@apple.com>
1756
1757         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
1758         https://bugs.webkit.org/show_bug.cgi?id=129322
1759
1760         Reviewed by Anders Carlsson.
1761
1762         Add an API test suite for _WKDownload.
1763
1764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1765         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
1766         (-[DownloadDelegate initWithSourceURL:]):
1767         (-[DownloadDelegate sourceURL]):
1768         (-[DownloadDelegate _downloadDidStart:]):
1769         (-[DownloadDelegate _download:didReceiveResponse:]):
1770         (-[DownloadDelegate _download:didReceiveData:]):
1771         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1772         (-[DownloadDelegate _downloadDidFinish:]):
1773         (TEST):
1774         (runTestWithNavigationDelegate):
1775         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1776         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1777
1778 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
1779
1780         filter-build-webkit: reduce unfiltered output
1781         https://bugs.webkit.org/show_bug.cgi?id=130485
1782
1783         Reviewed by Brent Fulgham.
1784
1785         * Scripts/filter-build-webkit:
1786         (shouldIgnoreLine):
1787
1788 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
1789
1790         prepare-ChangeLog should list functions that have been removed too.
1791         https://bugs.webkit.org/show_bug.cgi?id=130508
1792
1793         Reviewed by Darin Adler.
1794
1795         The prepare-ChangeLog does not list the deleted functions in the Changelog.
1796         We have to read the functions and the line ranges of them from the source
1797         before the change, then search for overlaps between them and the changed
1798         line ranges from diff.
1799
1800         * Scripts/prepare-ChangeLog:
1801         (originalFile): Get original source command.
1802         (generateFunctionLists): Collect deleted functions too.
1803         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
1804         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
1805         deleted functions ranges too.
1806         (extractLineRange): Renamed to extractLineRangeAfterChange.
1807
1808 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
1809
1810         Move all EFL typedefs into EflTypedefs.h.
1811         https://bugs.webkit.org/show_bug.cgi?id=130511
1812
1813         Reviewed by Gyuyoung Kim.
1814
1815         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
1816         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1817         * WebKitTestRunner/PlatformWebView.h: Ditto.
1818
1819 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1820
1821         Don't flush compositing layers within FrameView::willPaintContents()
1822         https://bugs.webkit.org/show_bug.cgi?id=130627
1823         <rdar://problem/16368869>
1824
1825         Reviewed by Sam Weinig.
1826         
1827         Fix DRT to correctly render tests with layers now that FrameView::paintContents
1828         does not flush.
1829         
1830         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
1831         into an explicit function called before dumping. 
1832         
1833         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
1834         are flushed to CA. They will be pushed to the window by snapshotting.
1835
1836         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1837         Fix weird path to IOKit.framework.
1838         * DumpRenderTree/mac/DumpRenderTree.mm:
1839         (updateDisplay):
1840         (dump):
1841         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1842         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
1843         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
1844
1845 2014-03-21  David Kilzer  <ddkilzer@apple.com>
1846
1847         fix-blink-patch: tool to fix up renamed directory paths in Blink
1848         <http://webkit.org/b/130609>
1849
1850         Reviewed by Ryosuke Niwa.
1851
1852         Usage: cat blink.patch | fix-blink-patch | svn-apply
1853
1854         * Scripts/fix-blink-patch: Added.
1855
1856 2014-03-21  Darin Adler  <darin@apple.com>
1857
1858         Remove use of deprecatedCharacters in WebKit API tests
1859         https://bugs.webkit.org/show_bug.cgi?id=130602
1860
1861         Reviewed by Antti Koivisto.
1862
1863         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1864         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
1865         (TestWebKitAPI::expectEmpty): Use characters8.
1866         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
1867
1868         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1869         Removed the test that is entirely about 16-bit conversion since that's basically a test of
1870         the deprecatedCharacters function itself, which we are about to delete.
1871
1872 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1873
1874         [webkitpy] Fix has_valid_reviewer()
1875         https://bugs.webkit.org/show_bug.cgi?id=130589
1876
1877         Reviewed by Csaba Osztrogonác.
1878
1879         * Scripts/webkitpy/common/checkout/changelog.py:
1880         (ChangeLogEntry.has_valid_reviewer):
1881         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1882         (test_has_valid_reviewer):
1883         * Scripts/webkitpy/common/config/committers.py:
1884         (CommitterList._reviewer_only):
1885         (CommitterList.committer_by_name):
1886         (CommitterList.reviewer_by_email):
1887         (CommitterList):
1888         (CommitterList.reviewer_by_name):
1889
1890 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1891
1892         Add cache support for jhbuild
1893         https://bugs.webkit.org/show_bug.cgi?id=130588
1894
1895         Reviewed by Csaba Osztrogonác.
1896
1897         * jhbuild/jhbuildrc_common.py:
1898         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
1899
1900 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1901
1902         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
1903         https://bugs.webkit.org/show_bug.cgi?id=130504
1904
1905         Reviewed by Martin Robinson.
1906
1907         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
1908         CMake if not specified.
1909         * Scripts/webkitdirs.pm:
1910         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
1911         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
1912
1913 2014-03-21  Andreas Kling  <akling@apple.com>
1914
1915         RetainPtr API test should use CFArray instead of CFString for testing.
1916         <rdar://problem/16384899>
1917
1918         Unreviewed bot fix.
1919
1920         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1921         (TestWebKitAPI::TEST):
1922         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1923         (TestWebKitAPI::TEST):
1924
1925 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
1926
1927         Move to using std::unique_ptr for EFL objects.
1928         https://bugs.webkit.org/show_bug.cgi?id=129853
1929
1930         Reviewed by Gyuyoung Kim.
1931
1932         EflUniquePtr is a template alias of std::unique_ptr
1933         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
1934         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
1935
1936         * DumpRenderTree/efl/DumpRenderTree.cpp:
1937         (main):
1938         * ImageDiff/efl/ImageDiff.cpp:
1939         (initEfl):
1940         (main):
1941
1942 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
1943
1944         Unreviewed buildfix after r165983 for non Cocoa platforms
1945
1946         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
1947
1948         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1949         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1950         * WebKitTestRunner/TestController.cpp:
1951
1952 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
1953
1954         [GTK][CMake] Add support for building with Clang
1955         https://bugs.webkit.org/show_bug.cgi?id=130260
1956
1957         Reviewed by Martin Robinson.
1958
1959         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
1960         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
1961         included GTest framework headers.
1962         * gtk/generate-gtkdoc:
1963         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
1964         in case of using Clang since that is now set by the CMake rule.
1965
1966 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
1967
1968         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
1969         https://bugs.webkit.org/show_bug.cgi?id=130476
1970
1971         Reviewed by Anders Carlsson.
1972         
1973         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
1974
1975         * MiniBrowser/mac/WK1BrowserWindowController.m:
1976         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1977         Remove log.
1978         * MiniBrowser/mac/WK2BrowserWindowController.m:
1979         (-[WK2BrowserWindowController awakeFromNib]):
1980         (-[WK2BrowserWindowController validateMenuItem:]):
1981         (-[WK2BrowserWindowController reload:]):
1982         Hook up reload.
1983         (-[WK2BrowserWindowController toggleZoomMode:]):
1984         (-[WK2BrowserWindowController resetZoom:]):
1985         (-[WK2BrowserWindowController canResetZoom]):
1986         (-[WK2BrowserWindowController currentZoomFactor]):
1987         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1988         (-[WK2BrowserWindowController canZoomIn]):
1989         (-[WK2BrowserWindowController canZoomOut]):
1990
1991 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
1992
1993         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
1994         https://bugs.webkit.org/show_bug.cgi?id=130463
1995
1996         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
1997
1998 2014-03-18  Samuel White  <samuel_white@apple.com>
1999
2000         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2001         https://bugs.webkit.org/show_bug.cgi?id=130250
2002
2003         Reviewed by Chris Fleizach.
2004
2005         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2006
2007         * DumpRenderTree/AccessibilityController.cpp:
2008         (enableEnhancedAccessibilityCallback):
2009         (getEnhancedAccessibilityEnabledCallback):
2010         (AccessibilityController::getJSClass):
2011         * DumpRenderTree/AccessibilityController.h:
2012         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2013         (AccessibilityController::enableEnhancedAccessibility):
2014         (AccessibilityController::enhancedAccessibilityEnabled):
2015         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2016         (AccessibilityController::enableEnhancedAccessibility):
2017         (AccessibilityController::enhancedAccessibilityEnabled):
2018         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2019         (AccessibilityController::enableEnhancedAccessibility):
2020         (AccessibilityController::enhancedAccessibilityEnabled):
2021         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2022         (AccessibilityController::enableEnhancedAccessibility):
2023         (AccessibilityController::enhancedAccessibilityEnabled):
2024         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2025         (WTR::AccessibilityController::enableEnhancedAccessibility):
2026         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2027         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2028         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2029
2030 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2031
2032         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2033         yet).
2034
2035         * Scripts/webkitpy/common/config/contributors.json:
2036
2037 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2038
2039         Web Inspector: Remove stale ReportMemoryUsagePlugin
2040         https://bugs.webkit.org/show_bug.cgi?id=130405
2041
2042         Reviewed by Andreas Kling.
2043
2044         This clang plugin looks like it was used for the old Inspector memory
2045         instrumentation that was removed. So the tool can be removed.
2046
2047         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2048         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2049         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2050         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2051
2052 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2053
2054         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2055         https://bugs.webkit.org/show_bug.cgi?id=130220
2056
2057         Reviewed by Csaba Osztrogonác.
2058
2059         * Scripts/webkitpy/common/checkout/changelog.py:
2060         (ChangeLog.set_reviewer):
2061         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2062         (test_set_reviewer):
2063
2064 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2065
2066         More FTL enabling.
2067
2068         Rubber stamped by Dan Bernstein.
2069
2070         * Tools/Scripts/build-webkit:
2071
2072 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2073
2074         Renable pagination mode in WK2 MiniBrowser
2075         https://bugs.webkit.org/show_bug.cgi?id=130374
2076
2077         Reviewed by Anders Carlsson.
2078         
2079         Put the implementation of togglePaginationMode: back, and correctly
2080         enable the menu item.
2081
2082         * MiniBrowser/mac/WK2BrowserWindowController.m:
2083         (-[WK2BrowserWindowController validateMenuItem:]):
2084         (-[WK2BrowserWindowController isPaginated]):
2085         (-[WK2BrowserWindowController togglePaginationMode:]):
2086
2087 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2088
2089         Add --reset option to Tools/Scripts/set-webkit-configuration script
2090         https://bugs.webkit.org/show_bug.cgi?id=130401
2091
2092         Reviewed by Csaba Osztrogonác.
2093
2094         * Scripts/set-webkit-configuration:
2095
2096 2014-03-18  Alberto Garcia  <berto@igalia.com>
2097
2098         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2099         https://bugs.webkit.org/show_bug.cgi?id=130388
2100
2101         Reviewed by Sergio Villar Senin.
2102
2103         * Scripts/webkitdirs.pm:
2104         (shouldRemoveCMakeCache): make sure that the build directory
2105         exists before attempting to create a file in it.
2106
2107 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2108
2109         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2110         https://bugs.webkit.org/show_bug.cgi?id=130336
2111
2112         Reviewed by Gyuyoung Kim.
2113
2114         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2115         requires a space between literal and string macro [-Wliteral-suffix]'
2116         warning treated as error.
2117
2118         This patch applies a solution from r162448 to the EFL port.
2119
2120         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2121         * efl/jhbuild.modules: Added appropriate patch section.
2122
2123 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2124
2125         webkitpy test rebaseline.
2126
2127         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2128         (MainTest.test_default_args):
2129
2130 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2131
2132         --profile should imply --test-runner-count=1 in run-perf-tests
2133         https://bugs.webkit.org/show_bug.cgi?id=130375
2134
2135         Reviewed by Benjamin Poulain.
2136
2137         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2138
2139         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2140         (PerfTestsRunner._parse_args): Use -1 as the default value.
2141         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2142         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2143         should be 1.
2144
2145 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2146
2147         Address some style nits.
2148
2149         * MiniBrowser/mac/WK2BrowserWindowController.m:
2150
2151 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2152
2153         Add transparent window support back into MiniBrowser
2154         https://bugs.webkit.org/show_bug.cgi?id=130363
2155
2156         Reviewed by Anders Carlsson.
2157         
2158         Re-enable transparent window support for WK2.
2159
2160         * MiniBrowser/mac/WK2BrowserWindowController.m:
2161         (-[WK2BrowserWindowController validateMenuItem:]):
2162         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2163
2164 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2165
2166         Fix the 32-bit build; make the open panel make a WK1 window.
2167
2168         * MiniBrowser/mac/AppDelegate.m:
2169         (-[BrowserAppDelegate openDocument:]):
2170
2171 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2172
2173         Convert MiniBrowser to use WKWebView API
2174         https://bugs.webkit.org/show_bug.cgi?id=130061
2175
2176         Reviewed by Anders Carlsson.
2177         
2178         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2179         as possible.
2180         
2181         Some functionality was removed temporarily:
2182             - text zoom, page zoom
2183             - reload
2184             - pagination mode
2185             - transparent window
2186             - dumping source
2187             - window.open support
2188             - beforeUnload panel
2189             - find in page
2190
2191         * MiniBrowser/mac/AppDelegate.h:
2192         * MiniBrowser/mac/AppDelegate.m:
2193         (-[BrowserAppDelegate init]):
2194         (-[BrowserAppDelegate newWindow:]):
2195         (-[BrowserAppDelegate applicationWillTerminate:]):
2196         (-[BrowserAppDelegate openDocument:]):
2197         * MiniBrowser/mac/WK2BrowserWindowController.h:
2198         * MiniBrowser/mac/WK2BrowserWindowController.m:
2199         (-[WK2BrowserWindowController awakeFromNib]):
2200         (-[WK2BrowserWindowController dealloc]):
2201         (-[WK2BrowserWindowController fetch:]):
2202         (-[WK2BrowserWindowController validateMenuItem:]):
2203         (-[WK2BrowserWindowController reload:]):
2204         (-[WK2BrowserWindowController goBack:]):
2205         (-[WK2BrowserWindowController goForward:]):
2206         (-[WK2BrowserWindowController toggleZoomMode:]):
2207         (-[WK2BrowserWindowController resetZoom:]):
2208         (-[WK2BrowserWindowController canResetZoom]):
2209         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2210         (-[WK2BrowserWindowController togglePaginationMode:]):
2211         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2212         (-[WK2BrowserWindowController windowShouldClose:]):
2213         (-[WK2BrowserWindowController applicationTerminating]):
2214         (-[WK2BrowserWindowController currentZoomFactor]):
2215         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2216         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2217         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2218         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2219         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2220         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2221         (-[WK2BrowserWindowController find:]):
2222         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2223         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2224         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2225         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2226         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2227         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2228         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2229         * WebKitTestRunner/PlatformWebView.h:
2230         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2231         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2232
2233 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2234
2235         Use RunLoop objects through references instead of pointers
2236         https://bugs.webkit.org/show_bug.cgi?id=130313
2237
2238         Reviewed by Andreas Kling.
2239
2240         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2241         return RunLoop reference instead of a pointer.
2242
2243         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2244         (loadedCallback):
2245         (clickedCallback):
2246
2247 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2248
2249         sort-export-file --help doesn't work (missing 'use')
2250         https://bugs.webkit.org/show_bug.cgi?id=130338
2251
2252         Reviewed by Anders Carlsson.
2253
2254         * Scripts/sort-export-file:
2255         Add a missing 'use', and fix a typo in an error message.
2256
2257 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2258
2259         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2260         https://bugs.webkit.org/show_bug.cgi?id=130155
2261
2262         Reviewed by Philippe Normand.
2263
2264         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2265
2266 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2267
2268         [GTK] MiniBrowser fails to load injected bundle lib
2269         https://bugs.webkit.org/show_bug.cgi?id=130332
2270
2271         Reviewed by Anders Carlsson.
2272
2273         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2274
2275         * MiniBrowser/gtk/main.c:
2276         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2277         process is spawn.
2278
2279 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2280
2281         [EFL] Enable TOUCH_SLIDER macro
2282         https://bugs.webkit.org/show_bug.cgi?id=130185
2283
2284         Reviewed by Gyuyoung Kim.
2285
2286         * Scripts/webkitperl/FeatureList.pm:
2287
2288 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2289
2290         [GTK][CMake] Build with -fno-rtti
2291         https://bugs.webkit.org/show_bug.cgi?id=130261
2292
2293         Reviewed by Martin Robinson.
2294
2295         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2296         defined to 0 to prevent typeid use in included GTest headers.
2297
2298 2014-03-16  Brian Burg  <bburg@apple.com>
2299
2300         Web Inspector: vended backend commands file should be generated as part of the build
2301         https://bugs.webkit.org/show_bug.cgi?id=130110
2302
2303         Reviewed by Timothy Hatcher.
2304
2305         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2306
2307 2014-03-16  Diego Pino García  <dpino@igalia.com>
2308
2309         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2310         https://bugs.webkit.org/show_bug.cgi?id=128999
2311
2312         Reviewed by Philippe Normand.
2313
2314         * MiniBrowser/gtk/BrowserWindow.c:
2315         (reloadPage):
2316         (reloadPageIgnoringCache):
2317         (browser_window_init):
2318
2319 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2320
2321         [GTK] Improve ninja detection in webkitdirs.pm
2322         https://bugs.webkit.org/show_bug.cgi?id=129902
2323
2324         Reviewed by Daniel Bates.
2325
2326         * Scripts/webkitdirs.pm:
2327         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2328         us to look for ninja-build as well.
2329
2330 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2331
2332         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2333         https://bugs.webkit.org/show_bug.cgi?id=130276
2334         <rdar://problem/16266927>
2335         
2336         Reviewed by Simon Fraser.
2337
2338         * BuildSlaveSupport/build-launcher-app:
2339         * BuildSlaveSupport/build-launcher-dmg:
2340         * DumpRenderTree/DumpRenderTree.h:
2341         * DumpRenderTree/DumpRenderTreePrefix.h:
2342         * DumpRenderTree/GCController.cpp:
2343         * DumpRenderTree/GCController.h:
2344         * DumpRenderTree/JavaScriptThreading.cpp:
2345         * DumpRenderTree/JavaScriptThreading.h:
2346         * DumpRenderTree/PixelDumpSupport.cpp:
2347         * DumpRenderTree/PixelDumpSupport.h:
2348         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2349         * DumpRenderTree/TestRunner.cpp:
2350         * DumpRenderTree/TestRunner.h:
2351         * DumpRenderTree/WorkQueue.cpp:
2352         * DumpRenderTree/WorkQueue.h:
2353         * DumpRenderTree/WorkQueueItem.h:
2354         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2355         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2356         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2357         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2358         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2359         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2360         * DumpRenderTree/efl/EditingCallbacks.cpp:
2361         * DumpRenderTree/efl/EditingCallbacks.h:
2362         * DumpRenderTree/efl/EventSender.cpp:
2363         * DumpRenderTree/efl/EventSender.h:
2364         * DumpRenderTree/efl/GCControllerEfl.cpp:
2365         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2366         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2367         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2368         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2369         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2370         * DumpRenderTree/gtk/EditingCallbacks.h:
2371         * DumpRenderTree/gtk/EventSender.cpp:
2372         * DumpRenderTree/gtk/EventSender.h:
2373         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2374         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2375         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2376         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2377         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2378         * DumpRenderTree/gtk/TextInputController.cpp:
2379         * DumpRenderTree/gtk/TextInputController.h:
2380         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2381         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2382         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2383         * DumpRenderTree/mac/AppleScriptController.h:
2384         * DumpRenderTree/mac/AppleScriptController.m:
2385         * DumpRenderTree/mac/CheckedMalloc.cpp:
2386         * DumpRenderTree/mac/CheckedMalloc.h:
2387         * DumpRenderTree/mac/DumpRenderTree.mm:
2388         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2389         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2390         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2391         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2392         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2393         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2394         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2395         * DumpRenderTree/mac/EditingDelegate.h:
2396         * DumpRenderTree/mac/EditingDelegate.mm:
2397         * DumpRenderTree/mac/EventSendingController.h:
2398         * DumpRenderTree/mac/EventSendingController.mm:
2399         * DumpRenderTree/mac/FrameLoadDelegate.h:
2400         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2401         * DumpRenderTree/mac/GCControllerMac.mm:
2402         * DumpRenderTree/mac/MockWebNotificationProvider.h:
2403         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2404         * DumpRenderTree/mac/NavigationController.h:
2405         * DumpRenderTree/mac/NavigationController.m:
2406         * DumpRenderTree/mac/ObjCController.h:
2407         * DumpRenderTree/mac/ObjCController.m:
2408         * DumpRenderTree/mac/ObjCPlugin.h:
2409         * DumpRenderTree/mac/ObjCPlugin.m:
2410         * DumpRenderTree/mac/ObjCPluginFunction.h:
2411         * DumpRenderTree/mac/ObjCPluginFunction.m:
2412         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2413         * DumpRenderTree/mac/PolicyDelegate.h:
2414         * DumpRenderTree/mac/PolicyDelegate.mm:
2415         * DumpRenderTree/mac/ResourceLoadDelegate.h:
2416         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2417         * DumpRenderTree/mac/TestRunnerMac.mm:
2418         * DumpRenderTree/mac/TextInputController.h:
2419         * DumpRenderTree/mac/TextInputController.m:
2420         * DumpRenderTree/mac/UIDelegate.h:
2421         * DumpRenderTree/mac/UIDelegate.mm:
2422         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2423         * DumpRenderTree/win/DRTDataObject.cpp:
2424         * DumpRenderTree/win/DRTDataObject.h:
2425         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2426         * DumpRenderTree/win/DRTDropSource.cpp:
2427         * DumpRenderTree/win/DRTDropSource.h:
2428         * DumpRenderTree/win/DraggingInfo.h:
2429         * DumpRenderTree/win/DumpRenderTree.cpp:
2430         * DumpRenderTree/win/DumpRenderTreeWin.h:
2431         * DumpRenderTree/win/EditingDelegate.cpp:
2432         * DumpRenderTree/win/EditingDelegate.h:
2433         * DumpRenderTree/win/EventSender.cpp:
2434         * DumpRenderTree/win/EventSender.h:
2435         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2436         * DumpRenderTree/win/FrameLoadDelegate.h:
2437         * DumpRenderTree/win/GCControllerWin.cpp:
2438         * DumpRenderTree/win/HistoryDelegate.cpp:
2439         * DumpRenderTree/win/HistoryDelegate.h:
2440         * DumpRenderTree/win/MD5.cpp:
2441         * DumpRenderTree/win/MD5.h:
2442         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2443         * DumpRenderTree/win/PolicyDelegate.cpp:
2444         * DumpRenderTree/win/PolicyDelegate.h:
2445         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2446         * DumpRenderTree/win/ResourceLoadDelegate.h:
2447         * DumpRenderTree/win/TestRunnerWin.cpp:
2448         * DumpRenderTree/win/TextInputController.cpp:
2449         * DumpRenderTree/win/TextInputController.h:
2450         * DumpRenderTree/win/TextInputControllerWin.cpp:
2451         * DumpRenderTree/win/UIDelegate.cpp:
2452         * DumpRenderTree/win/UIDelegate.h:
2453         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2454         * EWebLauncher/main.c:
2455         * GtkLauncher/main.c:
2456         * ImageDiff/efl/ImageDiff.cpp:
2457         * ImageDiff/gtk/ImageDiff.cpp:
2458         * MiniBrowser/gtk/main.c:
2459         * Scripts/SpacingHeuristics.pm:
2460         * Scripts/VCSUtils.pm:
2461         * Scripts/bisect-builds:
2462         * Scripts/build-dumprendertree:
2463         * Scripts/build-jsc:
2464         * Scripts/build-webkit:
2465         * Scripts/check-dom-results:
2466         * Scripts/check-for-exit-time-destructors:
2467         * Scripts/check-for-global-initializers:
2468         * Scripts/commit-log-editor:
2469         * Scripts/compare-timing-files:
2470         * Scripts/debug-minibrowser:
2471         * Scripts/debug-safari:
2472         * Scripts/do-file-rename:
2473         * Scripts/find-extra-includes:
2474         * Scripts/generate-coverage-data:
2475         * Scripts/make-script-test-wrappers:
2476         * Scripts/malloc-tree:
2477         * Scripts/old-run-webkit-tests:
2478         * Scripts/parse-malloc-history:
2479         * Scripts/report-include-statistics:
2480         * Scripts/resolve-ChangeLogs:
2481         * Scripts/run-bindings-tests:
2482         * Scripts/run-iexploder-tests:
2483         * Scripts/run-javascriptcore-tests:
2484         * Scripts/run-jsc:
2485         * Scripts/run-launcher:
2486         * Scripts/run-leaks:
2487         * Scripts/run-mangleme-tests:
2488         * Scripts/run-minibrowser:
2489         * Scripts/run-pageloadtest:
2490         * Scripts/run-regexp-tests:
2491         * Scripts/run-safari:
2492         * Scripts/run-sunspider:
2493         * Scripts/run-webkit-app:
2494         * Scripts/sampstat:
2495         * Scripts/set-webkit-configuration:
2496         * Scripts/sort-Xcode-project-file:
2497         * Scripts/sort-export-file:
2498         * Scripts/split-file-by-class:
2499         * Scripts/sunspider-compare-results:
2500         * Scripts/svn-apply:
2501         * Scripts/svn-create-patch:
2502         * Scripts/svn-unapply:
2503         * Scripts/test-webkit-scripts:
2504         * Scripts/update-javascriptcore-test-results:
2505         * Scripts/update-webkit:
2506         * Scripts/update-webkit-auxiliary-libs:
2507         * Scripts/update-webkit-dependency:
2508         * Scripts/update-webkit-localizable-strings:
2509         * Scripts/update-webkit-support-libs:
2510         * Scripts/update-webkit-wincairo-libs:
2511         * Scripts/webkit-build-directory:
2512         * Scripts/webkitdirs.pm:
2513         (installedSafariPath):
2514         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2515         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2516         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2517         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2518         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2519         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2520         * Scripts/webkitperl/features.pm:
2521         * Scripts/webkitperl/httpd.pm:
2522         * Scripts/webkitpy/bindings/main.py:
2523         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2524         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2525         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2526         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2527         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2528         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2529         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2530         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2531         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2532         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
2533         * WebKitTestRunner/PixelDumpSupport.cpp:
2534         * WebKitTestRunner/PixelDumpSupport.h:
2535         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2536         * WinLauncher/WinLauncher.cpp:
2537         * WinLauncher/WinLauncher.h:
2538         * WinLauncher/stdafx.cpp:
2539         * WinLauncher/stdafx.h:
2540
2541 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
2542
2543         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
2544         https://bugs.webkit.org/show_bug.cgi?id=130265
2545
2546         Reviewed by Michael Saboff.
2547
2548         * Scripts/build-webkit:
2549         * Scripts/copy-webkitlibraries-to-product-directory:
2550
2551 2014-03-14  Landry Breuil  <landry@openbsd.org>
2552
2553         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
2554         Also allow to set MAKE in the environment.
2555         https://bugs.webkit.org/show_bug.cgi?id=129991
2556
2557         Reviewed by Andreas Kling.
2558
2559         * Scripts/webkitdirs.pm:
2560         (determineArchitecture):
2561         (determineNumberOfCPUs):
2562         (isBSD):
2563         (buildAutotoolsProject):
2564         * Scripts/webkitpy/common/system/platforminfo.py:
2565         (PlatformInfo.__init__):
2566         (PlatformInfo.is_openbsd):
2567         (PlatformInfo):
2568         (PlatformInfo.is_netbsd):
2569         (PlatformInfo._determine_os_name):
2570
2571 2014-03-14  Dean Jackson  <dino@apple.com>
2572
2573         Remove libWebKitSystemInterfaceLion.a
2574         https://bugs.webkit.org/show_bug.cgi?id=130254
2575
2576         Reviewed by Geoffrey Garen and Andreas Kling.
2577
2578         No need to copy the Lion libraries into the build.
2579
2580         * Scripts/copy-webkitlibraries-to-product-directory:
2581
2582 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2583
2584         [EFL][MiniBrowser] Revise help messages of command line parameters
2585         https://bugs.webkit.org/show_bug.cgi?id=130222
2586
2587         Reviewed by Csaba Osztrogonác.
2588
2589         Correct the default value description and make help messages to be consistent.
2590
2591         * MiniBrowser/efl/main.c:
2592
2593 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
2594
2595         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
2596         https://bugs.webkit.org/show_bug.cgi?id=129612
2597
2598         Reviewed by Darin Adler.
2599
2600         For new code use static NeverDestroyed<T> instead.
2601
2602         * DumpRenderTree/JavaScriptThreading.cpp:
2603         (javaScriptThreadsMutex):
2604         (javaScriptThreads):
2605         * DumpRenderTree/efl/EventSender.cpp:
2606         (touchPointList):
2607         (delayedEventQueue):
2608         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2609         (delegatesWithDelayedWork):
2610         * Scripts/check-for-exit-time-destructors:
2611         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
2612         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2613         (testsMap):
2614
2615 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
2616
2617         [EFL][WK2] Fix compilation warning in Minibrowser
2618         https://bugs.webkit.org/show_bug.cgi?id=130132
2619
2620         Reviewed by Csaba Osztrogonác.
2621
2622         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
2623
2624         * MiniBrowser/efl/main.c:
2625         (on_download_request):
2626
2627 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
2628
2629         FTL should support IsBlah
2630         https://bugs.webkit.org/show_bug.cgi?id=130202
2631
2632         Reviewed by Geoffrey Garen.
2633         
2634         Running existing JSRegress tests with noInline gives us coverage for these
2635         changes. Chances are, this will also give coverage for other interesting things
2636         as well.
2637
2638         * Scripts/run-jsc-stress-tests:
2639
2640 2014-03-12  Brian Burg  <bburg@apple.com>
2641
2642         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
2643         https://bugs.webkit.org/show_bug.cgi?id=129744
2644
2645         Reviewed by Timothy Hatcher.
2646
2647         * DumpRenderTree/TestRunner.cpp:
2648         (evaluateInWebInspectorCallback):
2649         * DumpRenderTree/TestRunner.h:
2650         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2651         (TestRunner::evaluateInWebInspector):
2652         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2653         (TestRunner::evaluateInWebInspector):
2654         * DumpRenderTree/mac/TestRunnerMac.mm:
2655         (TestRunner::evaluateInWebInspector):
2656         * DumpRenderTree/win/TestRunnerWin.cpp:
2657         (TestRunner::evaluateInWebInspector):
2658         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2659         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2660         (WTR::TestRunner::evaluateInWebInspector):
2661         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2662
2663 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2664
2665         [GTK] build-webkit shouldn't show error message when ninja isn't installed
2666         https://bugs.webkit.org/show_bug.cgi?id=130129
2667
2668         Reviewed by Csaba Osztrogonác.
2669
2670         * Scripts/webkitdirs.pm:
2671         (canUseNinja): Redirecting stderr to /dev/null
2672
2673 2014-03-13  Andres Gomez  <agomez@igalia.com>
2674
2675         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
2676         https://bugs.webkit.org/show_bug.cgi?id=130092
2677
2678         Reviewed by Csaba Osztrogonác.
2679
2680         Added "python-dev" as dependency for deb based distros. It is
2681         already present for rpm based distros. This dependency will allow
2682         libxml2 to generate its python bindings, needed by gtk-doc.
2683
2684         * gtk/install-dependencies:
2685
2686 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         Unreviewed. Fix GTK+ cmake build after r165488.
2689
2690         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
2691
2692 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2693
2694         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
2695         https://bugs.webkit.org/show_bug.cgi?id=130014
2696
2697         Reviewed by Martin Robinson.
2698
2699         Include cmake or autotools config header.
2700
2701         * MiniBrowser/gtk/BrowserDownloadsBar.c:
2702         * MiniBrowser/gtk/BrowserSearchBar.c:
2703         * MiniBrowser/gtk/BrowserWindow.c:
2704         * MiniBrowser/gtk/main.c:
2705
2706 2014-03-12  Commit Queue  <commit-queue@webkit.org>
2707
2708         Unreviewed, rolling out r165471.
2709         https://bugs.webkit.org/show_bug.cgi?id=130139
2710
2711         Didn't really fix the issue and broke another bot (Requested
2712         by mrobinson on #webkit).
2713
2714         Reverted changeset:
2715
2716         "[CMake] Newer versions of CMake cannot find older versions of
2717         Freetype"
2718         https://bugs.webkit.org/show_bug.cgi?id=130107
2719         http://trac.webkit.org/changeset/165471
2720
2721 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
2722
2723         It should be possible to build WebKit with FTL on iOS
2724         https://bugs.webkit.org/show_bug.cgi?id=130116
2725
2726         Reviewed by Dan Bernstein.
2727
2728         * Scripts/build-webkit:
2729         * Scripts/copy-webkitlibraries-to-product-directory:
2730
2731 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
2732
2733         [Win] Remove use of QTSDK
2734         https://bugs.webkit.org/show_bug.cgi?id=130049
2735
2736         Reviewed by Darin Adler.
2737
2738         * DumpRenderTree/win/DumpRenderTree.cpp:
2739         (initialize): Remove QuickTime code.
2740         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
2741         building QTMovieWin.
2742
2743 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
2744
2745         [GTK][CMAKE] Too verbose build output
2746         https://bugs.webkit.org/show_bug.cgi?id=130076
2747
2748         Reviewed by Carlos Garcia Campos.
2749
2750         Instead of building with cmake --build which isn't smart about pretty printing and
2751         colors, we build with a script which calls the proper build command.
2752
2753         * Scripts/webkitdirs.pm:
2754         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
2755         the CMake configuration pass.
2756
2757 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
2758
2759         [CMake] Newer versions of CMake cannot find older versions of Freetype
2760         https://bugs.webkit.org/show_bug.cgi?id=130107
2761
2762         Reviewed by Gustavo Noronha Silva.
2763
2764         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
2765         to CMake during jhbuild initialization.
2766
2767 2014-03-12  Zalan Bujtas  <zalan@apple.com>
2768
2769         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
2770         https://bugs.webkit.org/show_bug.cgi?id=129961
2771
2772         Reviewed by Simon Fraser.
2773
2774         Now scaled content can go through the window capturing mechanism too for compositing content.
2775         AppleMagnifiedMode is redundant.
2776
2777         * DumpRenderTree/mac/DumpRenderTree.mm:
2778         (setDefaultsToConsistentValuesForTesting):
2779         (runTest):
2780         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2781         (createBitmapContextFromWebView):
2782         * WebKitTestRunner/PlatformWebView.h:
2783         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2784         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2785         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2786         (WTR::PlatformWebView::didInitializeClients):
2787         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2788         (WTR::PlatformWebView::forceWindowFramesChanged):
2789         * WebKitTestRunner/mac/main.mm:
2790         (setDefaultsToConsistentValuesForTesting):
2791
2792 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
2793
2794         Unreviewed. Add myself as a committer.
2795
2796         * Scripts/webkitpy/common/config/contributors.json:
2797
2798 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
2799
2800         Unreviewed build fix on the EFL port when used lower version of ATK
2801
2802         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2803         (WTR::AccessibilityUIElement::y): Fixed typo.
2804
2805 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2806
2807         Some images are blank in the rebaseline server UI
2808         https://bugs.webkit.org/show_bug.cgi?id=130104
2809
2810         Reviewed by Tim Horton.
2811
2812         Let the server check for images in the 'retries' directory
2813         if it can't find an image otherwise.
2814
2815         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2816         (RebaselineHTTPRequestHandler.test_result):
2817
2818 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2819
2820         [GTK][CMake] --update-gtk has no effect
2821         https://bugs.webkit.org/show_bug.cgi?id=130088
2822
2823         Reviewed by Philippe Normand.
2824
2825         * Scripts/webkitdirs.pm:
2826         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
2827         as an argument.
2828
2829 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2830
2831         Add "System Font" to the list of whitelisted DRT fonts
2832         https://bugs.webkit.org/show_bug.cgi?id=130046
2833
2834         Reviewed by Darin Adler.
2835
2836         * DumpRenderTree/mac/DumpRenderTree.mm:
2837         (allowedFontFamilySet):
2838         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2839
2840 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
2841
2842         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
2843         https://bugs.webkit.org/show_bug.cgi?id=130064
2844
2845         Reviewed by Philippe Normand.
2846
2847         * efl/jhbuildrc: Remove duplicated code.
2848         * gtk/jhbuildrc: Remove duplicated code.
2849         * jhbuild/jhbuildrc_common.py:
2850         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
2851         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
2852         and is apparently necessary for GTK+.
2853
2854 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
2855
2856         check-webkit-style failed to complain about missing braces
2857         https://bugs.webkit.org/show_bug.cgi?id=34189
2858
2859         Reviewed by Ryosuke Niwa.
2860
2861         * Scripts/webkitpy/style/checkers/cpp.py:
2862         (check_braces):
2863         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2864         (WebKitStyleTest.test_braces):
2865
2866 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
2867
2868         Remove Qt cruft from style checker.
2869         https://bugs.webkit.org/show_bug.cgi?id=130085
2870
2871         Reviewed by Csaba Osztrogonác.
2872
2873         There is no 'foreach' keyword in c++. That was a Qt feature
2874         added in: http://trac.webkit.org/changeset/46113
2875         Qt was removed from WebKit, so we should remove the checks
2876         of this keyword from check-webkit-style scripts.
2877
2878         * Scripts/webkitpy/style/checkers/cpp.py:
2879         (check_spacing_for_function_call):
2880         (check_spacing):
2881         (check_braces):
2882         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2883         (CppStyleTest.test_mismatching_spaces_in_parens):
2884         (CppStyleTest.test_spacing_for_fncall):
2885         (WebKitStyleTest.test_braces):
2886
2887 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
2888
2889         [GTK] update-webkitgtk-libs needs itstool
2890         https://bugs.webkit.org/show_bug.cgi?id=130082
2891
2892         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
2893         itstool is a dependency of building gtk-doc from version 1.19, so it should
2894         be added to Tools/gtk/install-dependencies script, too.
2895
2896         Reviewed by Philippe Normand.
2897
2898         * gtk/install-dependencies:
2899
2900 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2901
2902         webkitbot rollout ChangeLogs should be nicer
2903         https://bugs.webkit.org/show_bug.cgi?id=122654
2904
2905         Reviewed by Csaba Osztrogonác.
2906
2907         Added bug urls and descriptions of rolled out patches to the rollout changelog
2908         if they are present in the original changelog. Additionally removed the list of
2909         changed files and functions.
2910
2911         * Scripts/webkitpy/common/checkout/changelog.py:
2912         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
2913         * Scripts/webkitpy/common/checkout/checkout.py:
2914         (Checkout._changelog_data_for_revision): Store bug description.
2915         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2916         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2917         (CheckoutTest.test_commit_info_for_revision):
2918         * Scripts/webkitpy/common/checkout/commitinfo.py:
2919         (CommitInfo.bug_description): Added.
2920         (CommitInfo.to_json):
2921         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2922         (CommitInfoTest.test_commit_info_creation):
2923         * Scripts/webkitpy/tool/commands/download.py:
2924         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
2925         out patches for creating rollout changelog.
2926         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
2927         caused the regression is stored in state["bug_blocked"] now.
2928         * Scripts/webkitpy/tool/commands/download_unittest.py:
2929         (test_prepare_rollout):
2930         (test_create_rollout_multiple_revision):
2931         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2932         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
2933         rolled out patches to the changelog.
2934         (PrepareChangeLogForRevert.run):
2935         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2936         (UpdateChangeLogsForRevertTest):
2937         (test_message_for_revert):
2938         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2939         (ReopenBugAfterRollout.run):
2940
2941 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2942
2943         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
2944         https://bugs.webkit.org/show_bug.cgi?id=130021
2945
2946         Reviewed by Mario Sanchez Prada.
2947
2948         Replace deprecated functions to use new API from ATK 2.11.90.
2949
2950         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2951         (AccessibilityUIElement::x):
2952         (AccessibilityUIElement::y):
2953         (AccessibilityUIElement::width):
2954         (AccessibilityUIElement::height):
2955         (AccessibilityUIElement::clickPointX):
2956         (AccessibilityUIElement::clickPointY):
2957         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2958         (WTR::AccessibilityUIElement::x):
2959         (WTR::AccessibilityUIElement::y):
2960         (WTR::AccessibilityUIElement::width):
2961         (WTR::AccessibilityUIElement::height):
2962         (WTR::AccessibilityUIElement::clickPointX):
2963         (WTR::AccessibilityUIElement::clickPointY):
2964
2965 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2966
2967         [ATK] Expose aria-posinset and aria-setsize through object attributes
2968         https://bugs.webkit.org/show_bug.cgi?id=130011
2969
2970         Reviewed by Chris Fleizach.
2971
2972         Added missing implementation of numberAttributeValue both to WKTR and DRT.
2973
2974         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2975         (AccessibilityUIElement::numberAttributeValue):
2976         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2977         (WTR::AccessibilityUIElement::numberAttributeValue):
2978
2979 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
2980
2981         [Win] Unreviewed build fix.
2982
2983         Some bad Windows code was committed at some point that prevents the Apple Windows port
2984         from finding its runtime dependencies reliably.
2985
2986         * win/DLLLauncher/DLLLauncherMain.cpp:
2987         (appleApplicationSupportDirectory): Restored this function.
2988         (modifyPath): Update to use appleApplicationSupportDirectory function.
2989
2990 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
2991
2992         Let the user define the full address of the performance-site-server for uploading results
2993         https://bugs.webkit.org/show_bug.cgi?id=129819
2994
2995         Reviewed by Ryosuke Niwa.
2996
2997         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
2998         can be confusing. It's more straightforward, if you need to define explicitly the server's full
2999         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3000         protocol for now, in order to avoid breaking the perf bots.
3001
3002         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3003         (_upload_json):
3004         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3005         (MainTest.test_upload_json):
3006
3007 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3008
3009         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3010         https://bugs.webkit.org/show_bug.cgi?id=130023
3011
3012         Reviewed by Dean Jackson.
3013
3014         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3015         /SAFESEH flag to DLL launcher process.
3016
3017 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3018
3019         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3020         https://bugs.webkit.org/show_bug.cgi?id=129980
3021
3022         Reviewed by Carlos Garcia Campos.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3025
3026 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3027
3028         [GTK] Remove the WebView source-mode WebKit1 test
3029         https://bugs.webkit.org/show_bug.cgi?id=129976
3030
3031         Reviewed by Carlos Garcia Campos.
3032
3033         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3034
3035 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3036
3037         Unreviewed build fix for GTKbuild after the switch to CMake
3038
3039         * gtk/common.py:
3040         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3041         test-only bot doesn't have any build files.
3042
3043 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3044
3045         [GTK] built-product-archive does not handle GTK+ CMake build
3046         https://bugs.webkit.org/show_bug.cgi?id=129941
3047
3048         * BuildSlaveSupport/built-product-archive:
3049         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3050         the CMake build.
3051
3052 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3053
3054         [GTK] Include CMake into install-dependencies script
3055         https://bugs.webkit.org/show_bug.cgi?id=129909
3056
3057         Reviewed by Martin Robinson.
3058
3059         As since r165267 buid-webkit uses CMake by default, the dependency
3060         with 'cmake' package should be introduced.
3061
3062         * gtk/install-dependencies: Ditto.
3063
3064 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3065
3066         REGRESSION(165267): Broke a webkitpy unit tests
3067         https://bugs.webkit.org/show_bug.cgi?id=129904
3068
3069         Reviewed by Jon Honeycutt.
3070
3071         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3072         (GtkPort._is_cmake_build):
3073
3074 2014-03-07  Andres Gomez  <agomez@igalia.com>
3075
3076         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3077         https://bugs.webkit.org/show_bug.cgi?id=129893
3078
3079         Reviewed by Martin Robinson.
3080
3081         Added "git-svn" as dependency for deb based distros and,
3082         additionally, "subversion" for rpm based distros.
3083
3084         * gtk/install-dependencies:
3085
3086 2014-03-07  Roger Fong  <roger_fong@apple.com>
3087
3088         Remove dummy setSystemWebGLLoadPolicy client method.
3089         https://bugs.webkit.org/show_bug.cgi?id=129873.
3090
3091         Reviewed by Dean Jackson.
3092
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::TestController::createWebViewWithOptions):
3095
3096 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3097
3098         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3099         https://bugs.webkit.org/show_bug.cgi?id=129886
3100
3101         Reviewed by Mark Lam.
3102
3103         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3104         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3105         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3106         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3107         make it through when in non-verbose mode.
3108
3109 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3110
3111         [GTK] buid-webkit should use CMake by default
3112         https://bugs.webkit.org/show_bug.cgi?id=129855
3113
3114         Reviewed by Carlos Garcia Campos.
3115
3116         Make the CMake build the default GTK+ build when using build-webkit. This will
3117         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3118         so that we have --gtk and --gtkautotools.
3119
3120         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3121         * Scripts/webkitpy/port/gtk.py: Ditto.
3122
3123 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3124
3125         [CMake] [GTK] Build with ninja when it is available
3126         https://bugs.webkit.org/show_bug.cgi?id=129805
3127
3128         Reviewed by Philippe Normand.
3129
3130         * Scripts/webkitdirs.pm:
3131         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3132         if it's available on the system.
3133         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3134         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3135
3136 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3137
3138         If the FTL is build-time enabled then it should be run-time enabled.
3139
3140         Rubber stamped by Geoffrey Garen.
3141
3142         * Scripts/run-jsc-stress-tests:
3143
3144 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
3145
3146         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
3147         https://bugs.webkit.org/show_bug.cgi?id=129837
3148
3149         Reviewed by Michael Saboff.
3150
3151         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
3152         The fix is to use find instead of ls like we do in shell-runner.sh.
3153
3154         * Scripts/run-jsc-stress-tests:
3155
3156 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
3157
3158         filter-build-webkit should not strip .o
3159         https://bugs.webkit.org/show_bug.cgi?id=129614
3160
3161         Reviewed by Dean Jackson.
3162
3163         This makes it much easier to jump from the failing output at
3164         the end back up to the compile errors earlier in the output.
3165
3166         * Scripts/filter-build-webkit:
3167
3168 2014-03-06  Anders Carlsson  <andersca@apple.com>
3169
3170         Build WebKit2 before building WebKit
3171         https://bugs.webkit.org/show_bug.cgi?id=129831
3172         <rdar://problem/15920020>
3173
3174         Reviewed by Dan Bernstein.
3175
3176         * Scripts/build-webkit:
3177         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
3178
3179 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
3180
3181         make-3.82 fails to build on ARM/Linux
3182         https://bugs.webkit.org/show_bug.cgi?id=107926
3183
3184         Reviewed by Martin Robinson.
3185
3186         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
3187         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
3188         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
3189         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
3190
3191         * gtk/patches/make-3.82-arg-list-length.patch:
3192
3193 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3194
3195         [GTK] Close the page when the view is disposed instead of when finalized
3196         https://bugs.webkit.org/show_bug.cgi?id=129783
3197
3198         Reviewed by Sergio Villar Senin.
3199
3200         Add test case but disabled for now because it's affetected by bug #129684.
3201
3202         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3203         (testProcessPerWebView):
3204
3205 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3206
3207         [GTK] MiniBrowser crashes when opening several urls passed as command line options
3208         https://bugs.webkit.org/show_bug.cgi?id=129738
3209
3210         Reviewed by Sergio Villar Senin.
3211
3212         The problem is that we are calling g_object_unref() for the
3213         WebKitWebSettings everytime we set it to a WebKitWebView, but the
3214         view only increases the reference counter when the settings is not
3215         the same it currently has. We should release our reference once.
3216
3217         * MiniBrowser/gtk/main.c:
3218         (createBrowserWindow):
3219         (main):
3220
3221 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3222
3223         [GTK][CMake] Tarball is created with wrong tarball paths
3224         https://bugs.webkit.org/show_bug.cgi?id=129496
3225
3226         Reviewed by Daniel Bates.
3227
3228         * gtk/make-dist.py:
3229         (Manifest.__init__): I inadvertently inverted the logic of these checks when
3230         landing the original patch with some suggestions from the reviewer. With the
3231         checks corrected, the tarball path is constructed properly.
3232
3233 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
3234
3235         Unreviewed. Update my email in contributors.json
3236
3237         * Scripts/webkitpy/common/config/contributors.json:
3238
3239 2014-03-05  Dean Jackson  <dino@apple.com>
3240
3241         [WebGL] Use WKSI to see what the system policy for WebGL is
3242         https://bugs.webkit.org/show_bug.cgi?id=129722
3243         <rdar://problem/15790542>
3244
3245         Reviewed by Tim Horton.
3246
3247         Dummy entry for setSystemWebGLLoadPolicy.
3248
3249         * WebKitTestRunner/TestController.cpp:
3250         (WTR::TestController::createWebViewWithOptions):
3251
3252 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
3253
3254         [GTK][CMake] Generate documentation for the DOM bindings
3255         https://bugs.webkit.org/show_bug.cgi?id=126211
3256
3257         Reviewed by Carlos Garcia Campos.
3258
3259         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
3260         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
3261         * gtk/generate-webkitdom-doc-files: Removed.
3262         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
3263         that it can be called by generate-gtkdoc.
3264
3265 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3266
3267         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
3268         https://bugs.webkit.org/show_bug.cgi?id=129380
3269
3270         Reviewed by Philippe Normand.
3271
3272         * Scripts/webkitdirs.pm:
3273         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
3274         skipping CMake execution.
3275
3276 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3277
3278         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
3279         https://bugs.webkit.org/show_bug.cgi?id=129651
3280
3281         Reviewed by Philippe Normand.
3282
3283         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
3284
3285 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3286
3287         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
3288         https://bugs.webkit.org/show_bug.cgi?id=129637
3289
3290         Reviewed by Carlos Garcia Campos.
3291
3292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3293         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
3294         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
3295         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
3296         New API typically just requires a rebaseline and isn't necessarily a faiulre.
3297         (TestFactory.__init__): Add the test for GTK+.
3298         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
3299
3300 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
3301
3302         [ATK] Expose missing functionalities of AtkTableCell to AT
3303         https://bugs.webkit.org/show_bug.cgi?id=129492
3304
3305         Reviewed by Mario Sanchez Prada.
3306
3307         Reducing some code by using new API of AtkTableCell.
3308
3309         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3310         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3311
3312 2014-03-04  Alex Christensen  <achristensen@webkit.org>
3313
3314         Preparing to run layout tests on Wincairo.
3315         https://bugs.webkit.org/show_bug.cgi?id=129709
3316
3317         Reviewed by Brent Fulgham.
3318
3319         * Scripts/webkitdirs.pm:
3320         (setPathForRunningWebKitApp):
3321         Add GStreamer directory for WinCairo running layout tests.
3322         * win/DLLLauncher/DLLLauncherMain.cpp:
3323         (modifyPath):
3324         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
3325
3326 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
3327
3328         [GTK] Simplify the GObject DOM bindings API break check into one step
3329         https://bugs.webkit.org/show_bug.cgi?id=129571
3330
3331         Reviewed by Carlos Garcia Campos.
3332
3333         * GNUmakefile.am: Add the API break check to 'make check.'
3334         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
3335         * gtk/check-gdom-symbols: Removed.
3336         * gtk/webkitdom.py: Added.
3337         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
3338         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
3339
3340 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
3341
3342         Add Jeremy Jones to the contributors list as a contributor.
3343
3344         * Scripts/webkitpy/common/config/contributors.json:
3345
3346 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3347
3348         Unreviewed. Update contact email.
3349         https://bugs.webkit.org/show_bug.cgi?id=129610
3350
3351         * Scripts/webkitpy/common/config/contributors.json:
3352
3353 2014-03-02  Brian Burg  <bburg@apple.com>
3354
3355         Web Inspector model tests load wrong inspector page under WebKitTestRunner
3356         https://bugs.webkit.org/show_bug.cgi?id=129460
3357
3358         Reviewed by Dan Bernstein.
3359
3360         Don't unconditionally open the inspector before running an inspector test.
3361         Instead, the test should request that the inspector open when it's ready.
3362
3363         This change was lost during a rebase, but is the same change made to
3364         DumpRenderTree.
3365
3366         * WebKitTestRunner/TestInvocation.cpp:
3367         (WTR::TestInvocation::invoke): 
3368
3369 2014-03-02  Darin Adler  <darin@apple.com>
3370
3371         Split TextIteratorBehavior into a separate header
3372         https://bugs.webkit.org/show_bug.cgi?id=129578
3373
3374         Reviewed by Sam Weinig.
3375
3376         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
3377         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
3378         task easy, but the remove is still a bit of a pain.
3379
3380 2014-03-02  Darin Adler  <darin@apple.com>
3381
3382         Sort Mac platform export files so they merge better
3383         https://bugs.webkit.org/show_bug.cgi?id=129581
3384
3385         Reviewed by Sam Weinig.
3386
3387         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
3388         Mac export files in a "canonical" order for this project.
3389
3390 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3391
3392         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3393         https://bugs.webkit.org/show_bug.cgi?id=129438
3394
3395         Reviewed by Simon Fraser.
3396
3397         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3398         offscreen window. It makes testing subpixel rendering and positioning possible.
3399
3400         Both the offscreen window's and WebKit's scaling are set accordingly.
3401
3402         * DumpRenderTree/mac/DumpRenderTree.mm:
3403         (createWebViewAndOffscreenWindow): cleanup
3404         (destroyWebViewAndOffscreenWindow): cleanup
3405         (dumpRenderTree):
3406         (changeWindowScaleIfNeeded):
3407         (runTest):
3408         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3409         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3410         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
3411         * WebKitTestRunner/PlatformWebView.h:
3412         * WebKitTestRunner/TestInvocation.cpp:
3413         (WTR::changeWindowScaleIfNeeded):
3414         (WTR::TestInvocation::invoke):
3415         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3416         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3417         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3418         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3419         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3420         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3421         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3422         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3423
3424 2014-02-28  Anders Carlsson  <andersca@apple.com>
3425
3426         Remove logging.
3427
3428         Reviewed by Dan Bernstein.
3429
3430         * MiniBrowser/mac/WK2BrowserWindowController.m:
3431         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
3432
3433 2014-02-28  Daniel Bates  <dabates@apple.com>
3434
3435         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
3436         https://bugs.webkit.org/show_bug.cgi?id=129163
3437
3438         Reviewed by David Kilzer.
3439
3440         Fixes an issue where DumpRenderTree Perl Support may build with the specified
3441         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
3442         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
3443         bundle.
3444
3445         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
3446         which is specified either explicitly when building with MAKE(1) or implicitly by
3447         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
3448         the OS X SDK and toolchain since the built products are only applicable to OS X.
3449
3450         * DumpRenderTree/ios/PerlSupport/Makefile:
3451
3452 2014-02-28  Commit Queue  <commit-queue@webkit.org>
3453
3454         Unreviewed, rolling out r164859.
3455         http://trac.webkit.org/changeset/164859
3456         https://bugs.webkit.org/show_bug.cgi?id=129483
3457
3458         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
3459         #webkit).
3460
3461         * DumpRenderTree/mac/DumpRenderTree.mm:
3462         (createWebViewAndOffscreenWindow):
3463         (dumpRenderTree):
3464         (runTest):
3465         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3466         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3467         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3468         * WebKitTestRunner/PlatformWebView.h:
3469         * WebKitTestRunner/TestInvocation.cpp:
3470         (WTR::TestInvocation::invoke):
3471         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3472         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3473         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3474         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3475         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
3476
3477 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3478
3479         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3480         https://bugs.webkit.org/show_bug.cgi?id=129438
3481
3482         Reviewed by Simon Fraser.
3483
3484         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3485         offscreen window. It makes testing subpixel rendering and positioning possible.
3486
3487         Both the offscreen window's and WebKit's scaling are set accordingly.
3488
3489         * DumpRenderTree/mac/DumpRenderTree.mm:
3490         (createWebViewAndOffscreenWindow): unrelated cleanup.
3491         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
3492         (dumpRenderTree):
3493         (changeOffscreenWindowScaleIfNeeded):
3494         (runTest):
3495         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3496         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3497         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
3498         * WebKitTestRunner/PlatformWebView.h:
3499         * WebKitTestRunner/TestInvocation.cpp:
3500         (WTR::changeOffscreenWindowScaleIfNeeded):
3501         (WTR::TestInvocation::invoke):
3502         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3503         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
3504
3505 2014-02-27  Brian Burg  <bburg@apple.com>
3506
3507         Web Inspector: model tests should use a special Test.html inspector page
3508         https://bugs.webkit.org/show_bug.cgi?id=129190
3509
3510         Reviewed by Timothy Hatcher.
3511
3512         Remove code that immediately opens the Web Inspector based on the file path of the test.
3513         Instead, the test page should request that the inspector open inside its `test()` method.
3514
3515         This change is necessary because otherwise, the inspector would be opened too early for
3516         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
3517         will get loaded instead of the minimal test page.
3518
3519         * DumpRenderTree/efl/DumpRenderTree.cpp:
3520         (createTestRunner):
3521         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3522         (runTest):
3523         * DumpRenderTree/mac/DumpRenderTree.mm:
3524         (runTest):
3525         * DumpRenderTree/win/DumpRenderTree.cpp:
3526         (runTest):
3527
3528 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
3529
3530         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
3531         https://bugs.webkit.org/show_bug.cgi?id=127076
3532
3533         Reviewed by Anders Carlsson.
3534
3535         Avoid match for :: as start of a member initialization list. Modify expression to match
3536         after a colon either non-colon character or end of line.
3537
3538         * Scripts/webkitpy/style/checkers/cpp.py:
3539         (check_member_initialization_list):
3540         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3541         (WebKitStyleTest.test_member_initialization_list):
3542
3543 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
3544
3545         Unreviewed. Update my email addresses in contributors.json.
3546
3547         * Scripts/webkitpy/common/config/contributors.json:
3548
3549 2014-02-27  Alberto Garcia  <berto@igalia.com>
3550
3551         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
3552         https://bugs.webkit.org/show_bug.cgi?id=128927
3553
3554         Reviewed by Philippe Normand.
3555
3556         Encode manually the data for sys.{stdout,stderr}.write.
3557
3558         * gtk/gtkdoc.py:
3559         (GTKDoc._run_command):
3560
3561 2014-02-27  Andres Gomez  <agomez@igalia.com>
3562
3563         Unreviewed. Add myself to watchlists
3564
3565         * Scripts/webkitpy/common/config/watchlist: Add myself to
3566         watchlists.
3567
3568 2014-02-27  Andres Gomez  <agomez@igalia.com>
3569
3570         Unreviewed, rolling out r164790.
3571         http://trac.webkit.org/changeset/164790
3572
3573         Revert r164790 because of erroneous commit log
3574
3575         * Scripts/webkitpy/common/config/watchlist:
3576
3577 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
3578
3579         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
3580         https://bugs.webkit.org/show_bug.cgi?id=129250
3581
3582         Reviewed by Mario Sanchez Prada.
3583
3584         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
3585         Implementing methods so that we could test column/row headers represented as an array of cells.
3586
3587         * DumpRenderTree/AccessibilityUIElement.cpp:
3588         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3589         (AccessibilityUIElement::columnHeaders):
3590         (AccessibilityUIElement::rowHeaders):
3591         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
3592         (AccessibilityUIElement::columnHeaders):
3593         (AccessibilityUIElement::rowHeaders):
3594         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3595         (WTR::AccessibilityUIElement::rowHeaders):
3596         (WTR::AccessibilityUIElement::columnHeaders):
3597         * efl/jhbuild.modules:
3598         * gtk/jhbuild.modules:
3599
3600 2014-02-27  Andres Gomez  <agomez@igalia.com>
3601
3602         Unreviewed. Add myself to watchlists
3603
3604         * Scripts/webkitpy/common/config/watchlist: Add myself to
3605         watchlists.
3606
3607 2014-02-27  Andres Gomez  <agomez@igalia.com>
3608
3609         Unreviewed. Add myself as a committer.
3610
3611         * Scripts/webkitpy/common/config/contributors.json:
3612
3613 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3614
3615         Unreviewed. Add Víctor Jáquez and myself to watchlists
3616
3617         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
3618         myself to watchlists.
3619
3620 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
3621
3622         Unreviewed. Add myself as a committer.
3623
3624         * Scripts/webkitpy/common/config/contributors.json:
3625
3626 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
3627
3628         Unreviewed. Moved myself to the list of committers.
3629
3630         * Scripts/webkitpy/common/config/contributors.json:
3631
3632 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
3633
3634         [GTK] Reduplicate common.top_level_path in scripts
3635         https://bugs.webkit.org/show_bug.cgi?id=129291
3636
3637         Reviewed by Philippe Normand.
3638
3639         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
3640         path manipulation and weird dependencies on the jhbuild infrastructure.
3641
3642         * Scripts/run-gtk-tests: Use common again.
3643         (TestRunner._setup_testing_environment): Ditto.
3644         * gtk/check-gdom-symbols: Ditto.
3645         * gtk/common.py:
3646         (top_level_path): Re-add top_level_path..
3647         (get_build_path): Use the builtin top_level_path again.
3648         * gtk/find-make-dist-errors: Use common again.
3649         (get_missing_headers): Ditto.
3650         * gtk/generate-inspector-gresource-manifest.py: Ditto.
3651
3652 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3653
3654         runscript: line 42: /bin/ls: Argument list too long
3655         https://bugs.webkit.org/show_bug.cgi?id=129376
3656
3657         Reviewed by Michael Saboff.
3658
3659         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
3660         We should use find instead, which generates the list of files rather than expanding them all on 
3661         the command line and spitting them back out.
3662
3663         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
3664
3665 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
3666
3667         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
3668         https://bugs.webkit.org/show_bug.cgi?id=129377
3669
3670         Reviewed by Csaba Osztrogonác.
3671
3672         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
3673
3674 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
3675
3676         [GTK] Re-enable gtk-doc in EWS
3677         https://bugs.webkit.org/show_bug.cgi?id=128369
3678
3679         Reviewed by Carlos Garcia Campos.
3680
3681         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
3682
3683         * Scripts/webkitpy/common/config/ports.py:
3684         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
3685         (GtkWK2Port.build_webkit_command): Ditto.
3686         * Scripts/webkitpy/common/config/ports_unittest.py:
3687         (DeprecatedPortTest.test_gtk_port): Ditto.
3688         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
3689
3690 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
3691
3692         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
3693         https://bugs.webkit.org/show_bug.cgi?id=129319
3694
3695         Reviewed by Carlos Garcia Campos.
3696
3697         * gtk/generate-gtkdoc:
3698         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
3699
3700 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
3701
3702         Unreviewed. Add myself as a committer.
3703
3704         * Scripts/webkitpy/common/config/contributors.json:
3705
3706 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
3707
3708         [CSS Grid Layout] Add ENABLE flag
3709         https://bugs.webkit.org/show_bug.cgi?id=129153
3710
3711         Reviewed by Simon Fraser.
3712
3713         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
3714         all ports for developer builds.
3715
3716         * Scripts/webkitperl/FeatureList.pm:
3717
3718 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3719
3720         Added myself as a committer.
3721
3722         Unreviewed.
3723
3724         * Scripts/webkitpy/common/config/contributors.json:
3725
3726 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3727
3728         Unreviewed. Moved myself to the list of committers.
3729
3730         * Scripts/webkitpy/common/config/contributors.json:
3731
3732 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3733
3734         Move myself to the committers list.
3735
3736         Unreviewed.
3737
3738         * Scripts/webkitpy/common/config/contributors.json:
3739
3740 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
3741
3742         Unreviewed. Add myself as a committer.
3743
3744         * Scripts/webkitpy/common/config/contributors.json:
3745
3746 2014-02-25  Commit Queue  <commit-queue@webkit.org>
3747
3748         Unreviewed, rolling out r164639.
3749         http://trac.webkit.org/changeset/164639
3750         https://bugs.webkit.org/show_bug.cgi?id=129302
3751
3752         gtk-doc still have problems in EWS (Requested by rego on
3753         #webkit).
3754
3755         * Scripts/webkitpy/common/config/ports.py:
3756         (GtkPort.build_webkit_command):
3757         (GtkWK2Port.build_webkit_command):
3758         * Scripts/webkitpy/common/config/ports_unittest.py:
3759         (DeprecatedPortTest.test_gtk_port):
3760         (DeprecatedPortTest.test_gtk_wk2_port):
3761
3762 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
3763
3764         [GTK] Re-enable gtk-doc in EWS
3765         https://bugs.webkit.org/show_bug.cgi?id=128369
3766
3767         Reviewed by Carlos Garcia Campos.
3768
3769         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
3770
3771         * Scripts/webkitpy/common/config/ports.py:
3772         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
3773         (GtkWK2Port.build_webkit_command): Ditto.
3774         * Scripts/webkitpy/common/config/ports_unittest.py:
3775         (DeprecatedPortTest.test_gtk_port): Ditto.
3776         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
3777
3778 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3779
3780         [GTK] Mark view source mode methods as deprecated
3781         https://bugs.webkit.org/show_bug.cgi?id=128920
3782
3783         Reviewed by Martin Robinson.
3784
3785         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3786         (beforeAll): Remove view mode test.
3787
3788 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
3789
3790         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
3791         https://bugs.webkit.org/show_bug.cgi?id=128417
3792
3793         Reviewed by Carlos Garcia Campos.
3794
3795         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
3796         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
3797         a makefile. This allows accepting a header list from the build system, which can be used
3798         to dynamically build a list of ignored files. We can ignore any source file that doesn't
3799         have a corresponding header file on the header list. 
3800         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
3801         source directories to gtkdoc-scan.
3802
3803 2014-02-24  Anders Carlsson  <andersca@apple.com>
3804
3805         Add a DefaultVisitedLinkProvider and route visited link actions through it
3806         https://bugs.webkit.org/show_bug.cgi?id=129285
3807
3808         Reviewed by Dan Bernstein.
3809
3810         * MiniBrowser/mac/AppDelegate.m:
3811         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3812         Set a shared history so we'll get visited link tracking.
3813
3814         * MiniBrowser/mac/WK1BrowserWindowController.m:
3815         (-[WK1BrowserWindowController awakeFromNib]):
3816         Set a group name.
3817
3818 2014-02-24  Dan Bernstein  <mitz@apple.com>
3819
3820         iOS build fix after r164577.
3821
3822         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3823         (AccessibilityUIElement::selectedChildrenCount):
3824         (AccessibilityUIElement::selectedChildAtIndex):
3825
3826 2014-02-24  David Kilzer  <ddkilzer@apple.com>
3827
3828         [ASan] Remove methods from ignore list that no longer cause crashes
3829         <http://webkit.org/b/129257>
3830
3831         Reviewed by Anders Carlsson.
3832
3833         * asan/webkit-asan-ignore.txt: Remove old methods.
3834
3835 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3836
3837         Extract common parts from jhbuildrc files.
3838         https://bugs.webkit.org/show_bug.cgi?id=125986
3839
3840         Reviewed by Csaba Osztrogonác.
3841
3842         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
3843
3844         * Scripts/run-gtk-tests:
3845         (TestRunner._setup_testing_environment):
3846         * efl/common.py: Removed.
3847         * efl/jhbuildrc:
3848         * gtk/check-gdom-symbols:
3849         * gtk/common.py:
3850         (binary_build_path):
3851         (get_build_path):
3852         * gtk/find-make-dist-errors:
3853         (get_missing_headers):
3854         * gtk/generate-gtkdoc:
3855         (get_webkit2_options):
3856         (get_webkit1_options.src_path):
3857         (get_webkit1_options):
3858         (get_webkitdom_options.src_path):
3859         (get_webkitdom_options):
3860         * gtk/generate-inspector-gresource-manifest.py:
3861         * gtk/jhbuildrc:
3862         * jhbuild/jhbuildrc_common.py: Added.
3863         (script_path):
3864         (top_level_path):
3865         (init):
3866
3867 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
3868
3869         Unreviewed. Fix code indentation and spacing.
3870
3871         * Scripts/webkitpy/style/checkers/js.py:
3872         (SingleQuoteChecker.check):
3873
3874 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
3875
3876         [ATK] Wrong selected element at a given index in a list box.
3877         https://bugs.webkit.org/show_bug.cgi?id=129039
3878
3879         Reviewed by Chris Fleizach.
3880
3881         Added missing implementation and proposed some new function for testing selection
3882         in a list boxes.
3883
3884         * DumpRenderTree/AccessibilityUIElement.cpp:
3885         (setSelectedChildAtIndexCallback):
3886         (removeSelectionAtIndexCallback):
3887         (AccessibilityUIElement::getJSClass):
3888         * DumpRenderTree/AccessibilityUIElement.h:
3889         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3890         (AccessibilityUIElement::selectedChildrenCount):
3891         (AccessibilityUIElement::selectedChildAtIndex):
3892         (AccessibilityUIElement::setSelectedChildAtIndex):
3893         (AccessibilityUIElement::removeSelectionAtIndex):
3894         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3895         (AccessibilityUIElement::selectedChildrenCount):
3896         (AccessibilityUIElement::selectedChildAtIndex):
3897         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3898         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3899         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3900         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3901         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3902         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3903         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3904         (WTR::AccessibilityUIElement::selectedChildrenCount):
3905         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3906         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3907
3908 2014-02-23  Diego Pino García  <dpino@igalia.com>
3909
3910         [GTK] Fix build after Web Inspector code reorganization (r164543)
3911         https://bugs.webkit.org/show_bug.cgi?id=129231
3912
3913         Reviewed by Dean Jackson.
3914
3915         * gtk/generate-inspector-gresource-manifest.py:
3916         Modify paths to Web Inspector code.
3917
3918 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
3919
3920         [GTK] generate-gtkdoc should use argparse
3921         https://bugs.webkit.org/show_bug.cgi?id=128418
3922
3923         Reviewed by Carlos Garcia Campos.
3924
3925         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
3926         to all functions, and guard the main routine with a __name__ == __main__ check.
3927
3928 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
3929
3930         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
3931         https://bugs.webkit.org/show_bug.cgi?id=129191
3932
3933         Reviewed by Anders Carlsson.
3934
3935         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
3936         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
3937         name of the directory is "lib" and not "libs". Instead we should use the CMake
3938         variable specifically assigned to this task.
3939
3940 2014-02-23  David Kilzer  <ddkilzer@apple.com>
3941
3942         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
3943         <http://webkit.org/b/129209>
3944
3945         Reviewed by Geoffrey Garen.
3946
3947         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
3948         ignore list to make ASan builds usable again.  Follow-up
3949         investigation is tracked by <rdar://problem/16055903>.
3950
3951 2014-02-20  David Farler  <dfarler@apple.com>
3952
3953         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
3954         https://bugs.webkit.org/show_bug.cgi?id=128622
3955
3956         Reviewed by Simon Fraser.
3957
3958         With this change, we now have layout tests running in both DumpRenderTree
3959         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
3960         simulator.
3961
3962         * Scripts/old-run-webkit-tests:
3963         In general, make any specific reference to DumpRenderTree
3964         able to refer to WebKitTestRunner wherever possible:
3965         - Rename functions to remove DRT-specific naming.
3966         - Name FIFOs after the tool that is being used.
3967         -- Clean up FIFO creation code
3968         Other necessary changes:
3969         - Allow use of an ios-sim-wk2 platform.
3970         - Clean up platform hierarchy creation where the simulator platform behavior differed.
3971         * WebKitTestRunner/TestController.cpp:
3972         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
3973         (WTR::TestController::TestController):
3974         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3975         Copy the injected bundle into the app bundle.
3976
3977 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3978
3979         run-webkit-httpd fails to find httpd configuation file.
3980
3981         Reviewed by Ryosuke Niwa.
3982
3983         * Scripts/webkitperl/httpd.pm:
3984         (getHTTPDConfigPathForTestDirectory):
3985
3986 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
3987
3988         Fix TimeRanges layering violations
3989         https://bugs.webkit.org/show_bug.cgi?id=128717
3990
3991         Reviewed by Jer Noble.
3992
3993         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
3994         (TestWebKitAPI::TEST):
3995
3996 2014-02-21  Diego Pino García  <dpino@igalia.com>
3997
3998         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
3999         https://bugs.webkit.org/show_bug.cgi?id=128422
4000
4001         Reviewed by Joseph Pecoraro.
4002
4003         * Scripts/webkitpy/style/checkers/js.py:
4004         (JSChecker.__init__):
4005         (JSChecker.check):
4006         (SingleQuoteChecker):
4007         (SingleQuoteChecker.__init__):
4008         (SingleQuoteChecker.check):
4009         * Scripts/webkitpy/style/checkers/js_unittest.py:
4010         (JSTestCase.assertError.error_for_test):
4011         (JSTestCase.assertError):
4012         (JSTestCase.test_no_error):
4013         (JSTestCase.test_error):
4014
4015 == Rolled over to ChangeLog-2014-02-20 ==