Add Automator service to copy permalink to Clipboard
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-14  Daniel Bates  <dabates@apple.com>
2
3         Add Automator service to copy permalink to Clipboard
4         https://bugs.webkit.org/show_bug.cgi?id=170978
5
6         Reviewed by Joseph Pecoraro.
7
8         It is helpful to reference using a hyperlink a particular line of code when having
9         a discussion on IRC or in a bug. You can get such a link by navigating to the file
10         in the Trac Browse Source viewer and selecting the line your are interested in.
11         I found myself doing this often enough that I wrote an Automator service to do it
12         for me.
13
14         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
15
16         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
17         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
18         * CopyPermalink/README: Added.
19
20 2017-08-14  Chris Dumez  <cdumez@apple.com>
21
22         Address flakiness related to download tests
23         https://bugs.webkit.org/show_bug.cgi?id=175338
24         <rdar://problem/33865119>
25
26         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
27         between tests.
28
29         * WebKitTestRunner/TestController.cpp:
30         (WTR::TestController::resetStateToConsistentValues):
31
32 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
33
34         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
35         https://bugs.webkit.org/show_bug.cgi?id=175474
36         <rdar://problem/33844628>
37
38         Reviewed by Wenson Hsieh.
39
40         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
41
42         * DumpRenderTree/mac/DumpRenderTree.mm:
43         (resetWebPreferencesToConsistentValues):
44         * WebKitTestRunner/TestController.cpp:
45         (WTR::TestController::resetPreferencesToConsistentValues):
46
47 2017-08-12  Chris Dumez  <cdumez@apple.com>
48
49         Address flakiness related to download tests
50         https://bugs.webkit.org/show_bug.cgi?id=175338
51
52         Reviewed by Ryosuke Niwa.
53
54         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
55           is actually queried when a download completes. Previously, this would be
56           identical to a call to testRunner.waitUntilDone() because any download
57           completion would call testRunner.notifyDone().
58         - Disable logging of download callbacks by default and add a
59           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
60           enable such logging.
61
62         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
63         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
64         (WTR::InjectedBundle::didReceiveMessageToPage):
65         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
66         (WTR::TestRunner::setShouldLogDownloadCallbacks):
67         * WebKitTestRunner/InjectedBundle/TestRunner.h:
68         * WebKitTestRunner/TestController.cpp:
69         (WTR::TestController::downloadDidStart):
70         (WTR::TestController::decideDestinationWithSuggestedFilename):
71         (WTR::TestController::downloadDidFinish):
72         (WTR::TestController::downloadDidFail):
73         (WTR::TestController::downloadDidCancel):
74         * WebKitTestRunner/TestController.h:
75         (WTR::TestController::setShouldLogDownloadCallbacks):
76         * WebKitTestRunner/TestInvocation.cpp:
77         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
78
79 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
80
81         Create mock ITP data in testing to prevent grandfathering
82         https://bugs.webkit.org/show_bug.cgi?id=174720
83
84         Unreviewed follow-up fix for r220604.
85
86         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
87         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
88
89 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
90
91         Create mock ITP data in testing to prevent grandfathering
92         https://bugs.webkit.org/show_bug.cgi?id=174720
93         <rdar://problem/33457779>
94
95         Reviewed by Brent Fulgham.
96
97         We don't need to be triggering grandfathering when each test runner starts. On Mac,
98         this may launch plugins which can cause layout tests to fail later if the test
99         runner does not shut-down before the plugins unload.
100
101         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
102         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
103         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
104         prevent grandfathering from being triggered.
105         * WebKitTestRunner/ios/TestControllerIOS.mm:
106         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
107         * WebKitTestRunner/mac/TestControllerMac.mm:
108         (WTR::TestController::platformInitialize): Ditto.
109
110 2017-08-11  Sam Weinig  <sam@webkit.org>
111
112         WTF::Function does not allow for reference / non-default constructible return types
113         https://bugs.webkit.org/show_bug.cgi?id=175244
114         <rdar://problem/33801582>
115
116         Reviewed by Chris Dumez.
117
118         * TestWebKitAPI/Tests/WTF/Function.cpp:
119         (TestWebKitAPI::TEST):
120
121 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
122
123         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
124         https://bugs.webkit.org/show_bug.cgi?id=175378
125
126         Reviewed by Sergio Villar Senin.
127
128         Add two test cases to check proxy authentication.
129
130         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
131         (Tunnel::Tunnel):
132         (Tunnel::~Tunnel):
133         (Tunnel::connect):
134         (Tunnel::connected):
135         (serverCallback):
136         (ProxyAuthenticationTest::ProxyAuthenticationTest):
137         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
138         (ProxyAuthenticationTest::proxyServerPortAsString):
139         (testWebViewAuthenticationProxy):
140         (testWebViewAuthenticationProxyHTTPS):
141         (beforeAll):
142
143 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
144
145         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
146         https://bugs.webkit.org/show_bug.cgi?id=175428
147
148         Both ports share the GStreamer code as multimedia backend and till
149         not so long they were using different versions. Now they do use
150         the same versions and it does not make any sense anymore (and
151         neither had sense before) to have differences in the modulesets.
152
153         In this patch I created a GStreamer moduleset and referenced it
154         from both GTK+'s and WPE's. GStreamer patches were also moved there.
155
156         Reviewed by Žan Doberšek.
157
158         * gstreamer/jhbuild.modules: Added.
159         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
160         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
161         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
162         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
163         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
164         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
165         * gtk/jhbuild.modules:
166         * wpe/jhbuild.modules:
167         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
168         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
169         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
170         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
171         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
172
173 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
174
175         Unreviewed, adding Ross Kirsling to contributors.json
176
177         * Scripts/webkitpy/common/config/contributors.json:
178
179 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
180
181         Unreviewed, attempt to fix build failure with VC2017
182
183         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
184         (TEST):
185
186 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
187
188         Unreviewed, suppress warnings on GCC
189
190         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
191         (TestWebKitAPI::CheckedArithmeticTester::run):
192
193 2017-08-10  Dan Bernstein  <mitz@apple.com>
194
195         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
196         https://bugs.webkit.org/show_bug.cgi?id=173223
197
198         Reviewed by Tim Horton.
199
200         The rebuilds were happening due to a difference in the compiler options that the IDE and
201         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
202         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
203         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
204         Advanced when a Custom Absolute path is selected.
205
206         * Scripts/webkitdirs.pm:
207         (determineBaseProductDir):
208
209 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
210
211         Run more WTF tests
212         https://bugs.webkit.org/show_bug.cgi?id=174970
213
214         Reviewed by Michael Catanzaro.
215
216         Some of WTF tests are not executed in non Apple ports while they are generic ones.
217         This patch adds these tests to non-Apple port TestWebKitAPI.
218         Currently, we do not add Signals.cpp since it depends on signal functionality.
219
220         * TestWebKitAPI/CMakeLists.txt:
221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
222         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
223         (isHigherPriority):
224         (TEST):
225         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
226         (TEST):
227         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
228         (TEST):
229
230 2017-08-10  obinna obike  <oobike@apple.com>
231
232         Remove obsolete link from webkit-queues status page
233         https://bugs.webkit.org/show_bug.cgi?id=175337
234
235         Reviewed by Aakash Jain.
236
237         * QueueStatusServer/templates/recentstatus.html:
238         Removed the link to the ews-watcher server.
239
240 2017-08-10  Brian Burg  <bburg@apple.com>
241
242         WKPreferences should conform to NSCopying
243         https://bugs.webkit.org/show_bug.cgi?id=175303
244         <rdar://problem/33764939>
245
246         Reviewed by Dan Bernstein.
247
248         Add unit test to make sure a WKPreference and its copy are
249         not aliased to each other or affect each other's properties.
250
251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
252         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
253         (TEST):
254
255 2017-08-10  Tim Horton  <timothy_horton@apple.com>
256
257         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
258         https://bugs.webkit.org/show_bug.cgi?id=175436
259         <rdar://problem/33667497>
260
261         Reviewed by Simon Fraser.
262
263         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
264         (TestWebKitAPI::TEST_F):
265
266 2017-08-10  Lucas Forschler  <lforschler@apple.com>
267
268         Fix duplicated code in r220534.
269
270         Unreviewed cleanup.
271
272         * Scripts/bisect-builds:
273
274 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
275
276         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
277         https://bugs.webkit.org/show_bug.cgi?id=175344
278         <rdar://problem/28507240>
279
280         Reviewed by Alexey Proskuryakov.
281
282         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
283         Finally enable the existing tests for iOS.
284
285         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
286         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
288         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
289
290 2017-08-10  Lucas Forschler  <lforschler@apple.com>
291
292         Write a tool to bisect WebKit builds
293         https://bugs.webkit.org/show_bug.cgi?id=174596
294
295         Reviewed by Dean Johnson and Kocsen Chung.
296
297         * Scripts/bisect-builds: Added.
298         (bisect_builds): main bisection algorithm
299         (download_archive):download an archive from S3 using existing tools
300         (extract_archive):extract an archive using existing tools
301         (find_le):Find rightmost value less than or equal to x
302         (find_ge):Find leftmost item greater than or equal to x
303         (get_api_url):generate url for the rest api/database
304         (get_indices_from_revisions):convert revisions to list indexes for bisection
305         (get_sorted_revisions):retrieve sorted revision list
306         (get_s3_location_for_revision):calculate the S3 archive storage location
307         (parse_args):parse command line arguments
308         (pick_next_build):compute the next build to bisect
309         (prompt_did_reproduce):prompt user for direction for bisection
310         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
311         (test_archive):Platform specific logic to test downloaded archive
312         (minified_platforms):return a list of minified platforms in the database
313         (unminified_platforms):return a list of full platforms in the database
314         (is_supported_platform):check if platform is supported
315         (validate_options):validate command line options
316         (main):
317
318 2017-08-10  Lucas Forschler  <lforschler@apple.com>
319
320         Remove bisect-builds script.
321         https://bugs.webkit.org/show_bug.cgi?id=175433
322         
323         Reviewed by Aakash Jain.
324
325         * Scripts/bisect-builds: Removed.
326
327 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
328
329         Remove ENABLE_GAMEPAD_DEPRECATED
330         https://bugs.webkit.org/show_bug.cgi?id=175361
331
332         Reviewed by Carlos Garcia Campos.
333
334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
335
336 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
337
338         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
339         https://bugs.webkit.org/show_bug.cgi?id=175426
340
341         Reviewed by Carlos Garcia Campos.
342
343         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
344
345 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
346
347         Add Ms2ger as contributor.
348         https://bugs.webkit.org/show_bug.cgi?id=175325
349
350         Reviewed by Carlos Alberto Lopez Perez.
351
352         * Scripts/webkitpy/common/config/contributors.json:
353
354 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
355
356         Fix run-benchmark after r220483.
357         https://bugs.webkit.org/show_bug.cgi?id=175415
358         <rdar://problem/33803003>
359
360         Reviewed by Ryosuke Niwa.
361
362         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
363
364         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
365         (WebServerBenchmarkRunner._run_one_test):
366
367 2017-08-09  Chris Dumez  <cdumez@apple.com>
368
369         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
370         https://bugs.webkit.org/show_bug.cgi?id=175401
371
372         Reviewed by Brady Eidson.
373
374         * DumpRenderTree/mac/DumpRenderTree.mm:
375         (enableExperimentalFeatures):
376
377 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
378
379         [PAL] Move spi/cocoa and spi/cg directories into PAL
380         https://bugs.webkit.org/show_bug.cgi?id=175175
381
382         Reviewed by Myles C. Maxfield.
383
384         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
385         * DumpRenderTree/mac/DumpRenderTree.mm:
386         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
387         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
388
389         * Scripts/webkitpy/style/checker.py:
390         * Scripts/webkitpy/style/checker_unittest.py:
391         (GlobalVariablesTest.test_path_rules_specifier):
392
393         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
394
395         * Scripts/webkitpy/style/checkers/cpp.py:
396         (check_braces):
397         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
398         (WebKitStyleTest.test_braces.CF_OPTIONS):
399         (WebKitStyleTest.test_braces):
400
401         Prevent CF_OPTIONS() from being handled as funtion definition.
402
403 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
404
405         [WTF] Move TextStream into WTF
406         https://bugs.webkit.org/show_bug.cgi?id=175211
407
408         Reviewed by Myles C. Maxfield.
409
410         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
411
412 2017-08-09  Andy Estes  <aestes@apple.com>
413
414         Part 3 of: Rename DatabaseProcess to StorageProcess
415         https://bugs.webkit.org/show_bug.cgi?id=175034
416
417         Reviewed by Brady Eidson.
418
419         * WebKitTestRunner/TestController.cpp:
420         (WTR::TestController::databaseProcessName): Updated to return
421         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
422
423 2017-08-09  Commit Queue  <commit-queue@webkit.org>
424
425         Unreviewed, rolling out r220466, r220477, and r220487.
426         https://bugs.webkit.org/show_bug.cgi?id=175411
427
428         This change broke existing API tests and follow up fixes did
429         not resolve all the issues. (Requested by ryanhaddad on
430         #webkit).
431
432         Reverted changesets:
433
434         https://bugs.webkit.org/show_bug.cgi?id=175244
435         http://trac.webkit.org/changeset/220466
436
437         "WTF::Function does not allow for reference / non-default
438         constructible return types"
439         https://bugs.webkit.org/show_bug.cgi?id=175244
440         http://trac.webkit.org/changeset/220477
441
442         https://bugs.webkit.org/show_bug.cgi?id=175244
443         http://trac.webkit.org/changeset/220487
444
445 2017-08-09  Sam Weinig  <sam@webkit.org>
446
447         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
448
449         Remove one addition of null Function test.
450
451 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
452
453         Allow nested timeouts in webkitpy
454         https://bugs.webkit.org/show_bug.cgi?id=175390
455         <rdar://problem/33803003>
456
457         Reviewed by David Kilzer.
458
459         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
460         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
461         the executive to detect and recover from any issues connecting with devices.
462
463         * Scripts/webkitpy/benchmark_runner/utils.py:
464         (TimeoutError): Deleted.
465         (timeout): Deleted.
466         * Scripts/webkitpy/common/timeout_context.py: Added.
467         (Timeout): A timeout context designed to be nested.
468         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
469         (Timeout.TimeoutData.__init__):
470         (Timeout.default_handler): Timeout handler used if none is specified.
471         (Timeout.current): Access data about the most urgent timeout.
472         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
473         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
474         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
475         urgent timeout data.
476         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
477         most urgent timeout data, if such data exists.
478         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
479         (TimeoutContextTests):
480         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
481         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
482         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
483         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
484         over a less urgent outer timeout.
485         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
486         over a less urgent inner timeout.
487         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
488         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
489         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
490         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
491         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
492         * Scripts/webkitpy/port/simulator_process.py:
493         (SimulatorProcess._start): Use Timeout class.
494         * Scripts/webkitpy/xcode/simulated_device.py:
495         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
496         (SimulatedDevice.launch_app): Ditto.
497         (SimulatedDevice.launch_app._install_timeout): Deleted.
498         * Scripts/webkitpy/xcode/simulator.py:
499         (Simulator.wait_until_device_is_booted):Use Timeout class.
500         (Simulator.wait_until_device_is_in_state): Ditto.
501
502 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
503
504         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
505         https://bugs.webkit.org/show_bug.cgi?id=175392
506         <rdar://problem/33783207>
507
508         Reviewed by Tim Horton and Megan Gardner.
509
510         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
511
512         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
513
514 2017-08-09  Sam Weinig  <sam@webkit.org>
515
516         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
517
518         * TestWebKitAPI/Tests/WTF/Function.cpp:
519         Remove tests of null Functions, as they are no longer supported.
520
521 2017-08-09  Daniel Bates  <dabates@apple.com>
522
523         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
524         https://bugs.webkit.org/show_bug.cgi?id=175247
525         <rdar://problem/33679804>
526
527         Reviewed by Brady Eidson.
528
529         Add tests for redirects.
530
531         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
532         (TEST):
533         * TestWebKitAPI/cocoa/TestProtocol.mm:
534         (createRedirectURL):
535         (-[TestProtocol startLoading]):
536
537 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
538
539         Unreviewed, rolling out r220393.
540
541         This patch regresses the performance of WebPage::editorState.
542
543         Reverted changeset:
544
545         "[iOS WK2] WKWebView schedules nonstop layout after pressing
546         cmb+b,i,u inside a contenteditable div"
547         https://bugs.webkit.org/show_bug.cgi?id=175116
548         http://trac.webkit.org/changeset/220393
549
550 2017-08-08  obinna obike  <oobike@apple.com>
551
552         Created Individual EWS Pages
553         https://bugs.webkit.org/show_bug.cgi?id=174477
554
555         Reviewed by Aakash Jain.
556
557         Created individual pages for each EWS. Changed the link within each status bubble
558         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
559
560         * QueueStatusServer/handlers/patch.py:
561         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
562         * QueueStatusServer/handlers/statusbubble.py:
563         (StatusBubble._build_bubble): Updated url for specific EWS.
564         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
565         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
566         all ews queues.
567         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
568         takes you directly to the individual ews page.
569
570 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
571
572         Separate jsc stress test script writer from run-jsc-stress-tests
573         https://bugs.webkit.org/show_bug.cgi?id=175216
574
575         Reviewed by Mark Lam.
576
577         * Scripts/run-jsc-stress-tests:
578         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
579
580 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
581
582         Unreviewed, fix Ubuntu LTS build
583         https://bugs.webkit.org/show_bug.cgi?id=174490
584
585         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
586
587 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
590         https://bugs.webkit.org/show_bug.cgi?id=175302
591         <rdar://problem/33762116>
592
593         Reviewed by Tim Horton.
594
595         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
596         See WebKit ChangeLog for more details.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
600         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
601         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
602         (-[SlowTextInputContext handleEvent:completionHandler:]):
603         (-[SlowInputWebView inputContext]):
604         (-[SlowInputWebView _web_superInputContext]):
605         (TEST):
606
607 2017-08-08  John Wilander  <wilander@apple.com>
608
609         Resource Load Statistics: Clear web processes' state on history removal
610         https://bugs.webkit.org/show_bug.cgi?id=175271
611         <rdar://problem/33756560>
612
613         Reviewed by Chris Dumez.
614
615         Test infrastructure for asynchronous tests of website data
616         removal for _WKWebsiteDataTypeResourceLoadStatistics.
617
618         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
619         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
620         (WTR::InjectedBundle::didReceiveMessageToPage):
621         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
622         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
623         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
624         * WebKitTestRunner/InjectedBundle/TestRunner.h:
625         * WebKitTestRunner/TestController.cpp:
626         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
627         * WebKitTestRunner/TestController.h:
628         * WebKitTestRunner/TestInvocation.cpp:
629         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
630         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
631         * WebKitTestRunner/TestInvocation.h:
632         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
633         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
634
635 2017-08-08  Alicia Boya García  <aboya@igalia.com>
636
637         Add Alicia Boya García as contributor
638         https://bugs.webkit.org/show_bug.cgi?id=175326
639
640         Reviewed by Michael Catanzaro.
641
642         * Scripts/webkitpy/common/config/contributors.json:
643
644 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
645
646         [CMake] Properly test if compiler supports compiler flags
647         https://bugs.webkit.org/show_bug.cgi?id=174490
648
649         Reviewed by Konstantin Tokarev.
650
651         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
652         * MiniBrowser/gtk/CMakeLists.txt:
653         * TestRunnerShared/Bindings/JSWrapper.cpp:
654         (WTR::JSWrapper::initialize):
655         * TestWebKitAPI/CMakeLists.txt:
656         * TestWebKitAPI/PlatformGTK.cmake:
657         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
658         (TestWebKitAPI::CheckedArithmeticTester::run):
659         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
660         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
661         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
662         (formControlsAssociatedCallback):
663         * TestWebKitAPI/glib/CMakeLists.txt:
664         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
665         (Test::getResourcesDir):
666         * WebKitTestRunner/CMakeLists.txt:
667         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
668         (WTR::menuItemClickCallback):
669         (WTR::staticConvertMenuItemToType):
670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
671         (WTR::TestRunner::setUseDashboardCompatibilityMode):
672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
673         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
674         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
675         (WTR::AccessibilityUIElement::helpText const):
676         (WTR::AccessibilityUIElement::attributedStringForRange):
677         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
678         (WTR::EventSenderProxy::updateTouchPoint):
679         (WTR::EventSenderProxy::releaseTouchPoint):
680
681 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
682
683         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
684         https://bugs.webkit.org/show_bug.cgi?id=175116
685         <rdar://problem/28279301>
686
687         Reviewed by Darin Adler and Ryosuke Niwa.
688
689         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
690         EditorStateTests run on both iOS and Mac.
691
692         * TestWebKitAPI/EditingTestHarness.h: Added.
693         * TestWebKitAPI/EditingTestHarness.mm: Added.
694
695         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
696         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
697         the state of the latest observed EditorState.
698
699         (-[EditingTestHarness initWithWebView:]):
700         (-[EditingTestHarness dealloc]):
701         (-[EditingTestHarness webView]):
702         (-[EditingTestHarness latestEditorState]):
703         (-[EditingTestHarness editorStateHistory]):
704         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
705         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
706         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
707         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
708         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
709         (-[EditingTestHarness toggleBold]):
710         (-[EditingTestHarness toggleItalic]):
711         (-[EditingTestHarness toggleUnderline]):
712         (-[EditingTestHarness setForegroundColor:]):
713         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
714         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
715         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
716         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
717         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
718         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
719         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
720
721         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
722         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
723         keys and values.
724
725         (-[EditingTestHarness latestEditorStateContains:]):
726         (-[EditingTestHarness _webView:editorStateDidChange:]):
727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
728         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
729         (TestWebKitAPI::setUpEditorStateTestHarness):
730         (TestWebKitAPI::TEST):
731         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
732
733 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
734
735         Prevent domain from being set to a TLD
736         https://bugs.webkit.org/show_bug.cgi?id=175226
737         <rdar://problem/11079948>
738
739         Reviewed by Chris Dumez.
740
741         Extend the public suffix tests to include cases used by the
742         Public Domain 'Public Suffix List'.
743
744         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
745         (TestWebKitAPI::TEST):
746
747 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
748
749         [XCode] webkit-patch should run sort-Xcode-project-file
750         https://bugs.webkit.org/show_bug.cgi?id=174036
751         <rdar://problem/33732709>
752
753         Reviewed by Simon Fraser.
754
755         * Scripts/webkitpy/common/config/ports.py:
756         * Scripts/webkitpy/tool/commands/download.py:
757         * Scripts/webkitpy/tool/commands/download_unittest.py:
758         * Scripts/webkitpy/tool/commands/upload.py:
759         * Scripts/webkitpy/tool/commands/upload_unittest.py:
760         * Scripts/webkitpy/tool/steps/__init__.py:
761         * Scripts/webkitpy/tool/steps/options.py:
762         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
763
764 2017-08-07  Devin Rousso  <drousso@apple.com>
765
766         Web Inspector: Preview Canvas path when viewing a recording
767         https://bugs.webkit.org/show_bug.cgi?id=174967
768
769         Reviewed by Brian Burg.
770
771         * DumpRenderTree/TestOptions.h:
772         * DumpRenderTree/TestOptions.mm:
773         (TestOptions::TestOptions):
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (setWebPreferencesForTestOptions):
776         * WebKitTestRunner/TestController.cpp:
777         (WTR::TestController::resetPreferencesToConsistentValues):
778         (WTR::updateTestOptionsFromTestHeader):
779         * WebKitTestRunner/TestOptions.h:
780         (WTR::TestOptions::hasSameInitializationOptions const):
781         Add plumbing for new InspectorAdditions runtime flag.
782
783 2017-08-07  obinna obike  <oobike@apple.com>
784
785         Sorted EWS Queues on Patch page
786         https://bugs.webkit.org/show_bug.cgi?id=173667
787
788         Reviewed by Aakash Jain.
789
790         * QueueStatusServer/handlers/patch.py:
791         (Patch.get): Sorted queue_status.
792         * QueueStatusServer/templates/patch.html:
793         Changed queue_status.items to queue_status because it's a list.
794
795 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
796
797         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
798         https://bugs.webkit.org/show_bug.cgi?id=175286
799
800         Reviewed by Myles C. Maxfield.
801
802         * Scripts/webkitpy/style/checkers/cpp.py:
803         (check_braces):
804         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
805         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
806         (WebKitStyleTest.test_braces):
807         (WebKitStyleTest.test_braces.NS_OPTIONS):
808
809 2017-08-07  Brian Burg  <bburg@apple.com>
810
811         Remove CANVAS_PATH compilation guard
812         https://bugs.webkit.org/show_bug.cgi?id=175207
813
814         Reviewed by Sam Weinig.
815
816         * Scripts/webkitperl/FeatureList.pm:
817         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
818
819 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
820
821         [Win] Use Visual Studio 2017 if installed.
822         https://bugs.webkit.org/show_bug.cgi?id=175188
823
824         Reviewed by Sam Weinig.
825
826         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
827
828         * Scripts/webkitdirs.pm:
829         (visualStudioInstallDir):
830         (msBuildInstallDir):
831
832 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
833
834         [GTK][WPE] Add API to provide browser information required by automation
835         https://bugs.webkit.org/show_bug.cgi?id=175130
836
837         Reviewed by Michael Catanzaro.
838
839         * MiniBrowser/gtk/main.c:
840         (automationStartedCallback): Set browser information when a new automation session is started.
841         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
842         (testAutomationSessionApplicationInfo):
843         (beforeAll):
844
845 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
846
847         Unreviewed, rolling out r220295.
848
849         This change introduced 4 errors in webkitpy tests.
850
851         Reverted changeset:
852
853         "[XCode] webkit-patch should run sort-Xcode-project-file"
854         https://bugs.webkit.org/show_bug.cgi?id=174036
855         http://trac.webkit.org/changeset/220295
856
857 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
858
859         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
860
861         Unreviewed test gardening.
862
863         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
864         (TestWebKitAPI::TEST):
865
866 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
867
868         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
869         https://bugs.webkit.org/show_bug.cgi?id=175083
870
871         Reviewed by Oliver Hunt.
872         
873         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
874         to wait for VM destructions to finish before running the next test. This makes it easier to 
875         understand leaks results from workers tests, and leads to fewer reported leaks.
876
877         * DumpRenderTree/mac/DumpRenderTree.mm:
878         (runTest):
879
880 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
881
882         check-webkit-style: fix path-specific rules for WebKit2 rename
883         https://bugs.webkit.org/show_bug.cgi?id=175182
884
885         Reviewed by David Kilzer.
886
887         * Scripts/webkitpy/style/checker.py:
888
889 2017-08-04  Youenn Fablet  <youenn@apple.com>
890
891         [Cache API] Add Cache and CacheStorage IDL definitions
892         https://bugs.webkit.org/show_bug.cgi?id=175201
893
894         Reviewed by Brady Eidson.
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (enableExperimentalFeatures):
898         (resetWebPreferencesToConsistentValues):
899         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
900         (WTR::InjectedBundle::beginTesting):
901         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
902         (WTR::TestRunner::setCacheAPIEnabled):
903         * WebKitTestRunner/InjectedBundle/TestRunner.h:
904
905 2017-08-04  John Wilander  <wilander@apple.com>
906
907         Resource Load Statistics: Report user interaction immediately, but only when needed
908         https://bugs.webkit.org/show_bug.cgi?id=175090
909         <rdar://problem/33685546>
910
911         Reviewed by Chris Dumez.
912
913         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
914         (WTR::InjectedBundle::beginTesting):
915             Now calls WebCore::ResourceLoadObserver::clearState().
916
917 2017-08-04  Tim Horton  <timothy_horton@apple.com>
918
919         Add an API test for r220286
920         https://bugs.webkit.org/show_bug.cgi?id=175206
921
922         Reviewed by Simon Fraser.
923
924         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
925         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
926         (createAnimatedResizeWebView):
927         (TEST):
928         Add a test to ensure that we don't call
929         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
930         animated resize.
931
932 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
933
934         [XCode] webkit-patch should run sort-Xcode-project-file
935         https://bugs.webkit.org/show_bug.cgi?id=174036
936
937         Reviewed by Simon Fraser.
938
939         * Scripts/webkitpy/common/config/ports.py:
940         * Scripts/webkitpy/tool/commands/download.py:
941         * Scripts/webkitpy/tool/commands/upload.py:
942         * Scripts/webkitpy/tool/steps/__init__.py:
943         * Scripts/webkitpy/tool/steps/options.py:
944         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
945
946 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
947
948         REGRESSION(r219857): run-benchmark --allplans broken
949         https://bugs.webkit.org/show_bug.cgi?id=175186
950
951         Reviewed by Saam Barati.
952
953         r219857 forgot to update also the calls to BenchmarkRunner() that
954         is done when the script is run with --allplans.
955
956         To fix this (and avoid future issues like this), let's factorize
957         the calls to the benchhmark runner in a run_benchmark_plan()
958         function.
959
960         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
961         (run_benchmark_plan):
962         (start):
963
964 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
965
966         Dashboard bubbles sometimes show failure count instead of crash count
967         https://bugs.webkit.org/show_bug.cgi?id=175157
968         <rdar://problem/33709009>
969
970         Reviewed by Alexey Proskuryakov.
971
972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
973         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
974
975 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
976
977         Add tests for NeverDestroyed
978         https://bugs.webkit.org/show_bug.cgi?id=175146
979
980         Reviewed by Darin Adler.
981
982         * CMakeLists.txt:
983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
984         New files and sort.
985
986         * TestWebKitAPI/Tests/WTF/Logger.h:
987         * TestWebKitAPI/Tests/WTF/Logger.cpp:
988         (TestWebKitAPI::log):
989         (TestWebKitAPI::takeLogStr):
990         * TestWebKitAPI/Tests/WTF/RefLogger.h:
991         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
992         (TestWebKitAPI::log): Deleted.
993         (TestWebKitAPI::takeLogStr): Deleted.
994         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
995
996         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
997         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
998         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
999         (TestWebKitAPI::LifecycleLogger::operator=):
1000         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1001         (TestWebKitAPI::LifecycleLogger::setName):
1002         (TestWebKitAPI::TEST):
1003         Add a class that logs construction / assignment / modifications.
1004
1005         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1006         (TestWebKitAPI::TEST):
1007         (TestWebKitAPI::list):
1008         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1009
1010 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1011
1012         minification logic is not implemented for ios builds
1013         <rdar://problem/33726561>
1014
1015         Reviewed by Dean Johnson
1016
1017         * BuildSlaveSupport/built-product-archive:
1018         (minifyDirectory): refactor minifySource -> minifyDirectory
1019         (archiveBuiltProduct): add ios minification logic
1020         (minifySource): Deleted.
1021
1022 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1023
1024         Unreviewed, rolling out r220271.
1025
1026         Rolling out due to Layout Test failing on iOS Simulator.
1027
1028         Reverted changeset:
1029
1030         "Remove STREAMS_API compilation guard"
1031         https://bugs.webkit.org/show_bug.cgi?id=175165
1032         http://trac.webkit.org/changeset/220271
1033
1034 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1035
1036         Unreviewed, rolling out r220268.
1037
1038         This change caused assertion failures on macOS and iOS Debug
1039         WK2.
1040
1041         Reverted changeset:
1042
1043         "Resource Load Statistics: Report user interaction
1044         immediately, but only when needed"
1045         https://bugs.webkit.org/show_bug.cgi?id=175090
1046         http://trac.webkit.org/changeset/220268
1047
1048 2017-08-04  Youenn Fablet  <youenn@apple.com>
1049
1050         Remove STREAMS_API compilation guard
1051         https://bugs.webkit.org/show_bug.cgi?id=175165
1052
1053         Reviewed by Darin Adler.
1054
1055         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1056
1057 2017-08-04  John Wilander  <wilander@apple.com>
1058
1059         Resource Load Statistics: Report user interaction immediately, but only when needed
1060         https://bugs.webkit.org/show_bug.cgi?id=175090
1061         <rdar://problem/33685546>
1062
1063         Reviewed by Chris Dumez.
1064
1065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1066         (WTR::InjectedBundle::beginTesting):
1067             Now calls WebCore::ResourceLoadObserver::clearState().
1068
1069 2017-08-03  Brian Burg  <bburg@apple.com>
1070
1071         Remove ENABLE(WEB_SOCKET) guards
1072         https://bugs.webkit.org/show_bug.cgi?id=167044
1073
1074         Reviewed by Joseph Pecoraro.
1075
1076         * Scripts/webkitperl/FeatureList.pm:
1077         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1078
1079 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1080
1081         REGRESSION(r219850): run-benchmark script broken on Linux
1082         https://bugs.webkit.org/show_bug.cgi?id=175126
1083
1084         Reviewed by Stephanie Lewis.
1085
1086         The run-benchmark script dynamically generates the list of supported
1087         browsers and platforms (currently Linux and OSX) by loading all
1088         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1089         and getting the browser_name and platform variables from the
1090         classes defined there.
1091
1092         This means that this classes should not raise an exception when
1093         loaded on other platforms or otherwise they will broke the whole
1094         script. Its fine if they raise an exception when executing any of
1095         the methods they implement, but not when just loading/importing
1096         the class.
1097
1098         Move the argument variable definitions that call on the platform
1099         specific OSXBrowserDriver._screen_size() function from beeing
1100         variables that are evaluated when loading the file, to be functions
1101         that are only evaluated when the actual functionality needs to be
1102         executed.
1103
1104         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1105         (OSXChromeDriver.launch_url):
1106         (OSXChromeCanaryDriver.launch_url):
1107         (create_args):
1108         (create_chrome_options):
1109         (create_window_size_arg):
1110         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1111         (OSXFirefoxDriver.launch_url):
1112         (OSXFirefoxNightlyDriver.launch_url):
1113         (OSXFirefoxNightlyDriver.launch_driver):
1114         (create_args):
1115
1116 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1117
1118         [PAL] Move spi/cf directory into PAL
1119         https://bugs.webkit.org/show_bug.cgi?id=175057
1120
1121         Reviewed by Antti Koivisto.
1122
1123         * Scripts/webkitpy/style/checker.py:
1124         * Scripts/webkitpy/style/checker_unittest.py:
1125         (GlobalVariablesTest.test_path_rules_specifier):
1126
1127         Ignore "readability/naming/underscores" style errors for sources
1128         under the WebCore/PAL/pal/spi directory.
1129
1130         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1131
1132 2017-08-03  Youenn Fablet  <youenn@apple.com>
1133
1134         Remove FETCH_API compilation guard
1135         https://bugs.webkit.org/show_bug.cgi?id=175154
1136
1137         Reviewed by Chris Dumez.
1138
1139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1140
1141 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1142
1143         Enable archive minification on iOS builds
1144         https://bugs.webkit.org/show_bug.cgi?id=174718
1145         
1146         Reviewed by Aakash Jain.
1147
1148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1149         (BuildFactory.__init__):
1150
1151 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1152
1153         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1154         https://bugs.webkit.org/show_bug.cgi?id=175140
1155
1156         Reviewed by Alexey Proskuryakov.
1157
1158         We are having lately issues with JSC tests causing problems on
1159         the GTK+ and WPE bots due to the high amount of memory some tests
1160         need to run.
1161
1162         The best thing we can do now is to workaround this by disabling
1163         all the tests marked as memoryLimited on the GTK and WPE bots.
1164         We may revise this on the future.
1165
1166         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1167         (RunJavaScriptCoreTests.start):
1168
1169 2017-08-03  Brady Eidson  <beidson@apple.com>
1170
1171         Add SW IDLs and stub out basic functionality.
1172         https://bugs.webkit.org/show_bug.cgi?id=175115
1173
1174         Reviewed by Chris Dumez.
1175
1176         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1177
1178         * Scripts/webkitpy/bindings/main.py:
1179
1180 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1181
1182         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1183         https://bugs.webkit.org/show_bug.cgi?id=159510
1184
1185         Reviewed by Daniel Bates.
1186
1187         Allow any https certificate when running tests.
1188
1189         * DumpRenderTree/win/DumpRenderTree.cpp:
1190         (runTest):
1191
1192 2017-08-02  Youenn Fablet  <youenn@apple.com>
1193
1194         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1195         https://bugs.webkit.org/show_bug.cgi?id=175089
1196
1197         Reviewed by Chris Dumez.
1198
1199         * DumpRenderTree/TestOptions.mm:
1200         (TestOptions::TestOptions): Using absolutePath if available.
1201         * DumpRenderTree/mac/DumpRenderTree.mm:
1202         (computeTestURL): Removing http/tests/ specific URL computation.
1203         * Scripts/webkitpy/port/driver.py:
1204         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1205
1206 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1207
1208         download-built-product should allow for a proxy option
1209         https://bugs.webkit.org/show_bug.cgi?id=174875
1210
1211         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1212
1213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1214         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1215         
1216
1217 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1218
1219         check-webkit-style: deleting lines in a file runs the linter on the whole file
1220         https://bugs.webkit.org/show_bug.cgi?id=175078
1221
1222         Reviewed by David Kilzer.
1223
1224         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1225         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1226
1227         * Scripts/webkitpy/style/checkers/test_expectations.py:
1228         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1229         * Scripts/webkitpy/style/main_unittest.py:
1230         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1231         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1232         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1233
1234 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1235
1236         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1237         https://bugs.webkit.org/show_bug.cgi?id=175075
1238
1239         Reviewed by David Kilzer.
1240
1241         We have no way of handling text files with illegal unicode characters. Allow the callers of
1242         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1243         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1244
1245         * Scripts/webkitpy/common/system/filesystem.py:
1246         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1247         (FileSystem.write_text_file): Ditto.
1248         * Scripts/webkitpy/common/system/filesystem_mock.py:
1249         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1250         (MockFileSystem.write_text_file): Ditto.
1251         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1252         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1253         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1254
1255 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1256
1257         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1258         https://bugs.webkit.org/show_bug.cgi?id=175072
1259
1260         Reviewed by Alexey Proskuryakov.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1263         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1264
1265 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1266
1267         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1268         https://bugs.webkit.org/show_bug.cgi?id=175019
1269
1270         Reviewed by Darin Adler.
1271
1272         * TestWebKitAPI/CMakeLists.txt:
1273
1274 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1275
1276         Enabling uploading archives to S3
1277         https://bugs.webkit.org/show_bug.cgi?id=174198
1278
1279         Unreviewed unit test fix after r219235.
1280
1281         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1282
1283 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1284
1285         Fix JSCOnly ARM buildbots after r220047
1286         https://bugs.webkit.org/show_bug.cgi?id=174993
1287
1288         Unreviewed fix after r220087.
1289
1290         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1291         (BuildAndRemoteJSCTestsFactory.__init__):
1292
1293 2017-08-01  Chris Dumez  <cdumez@apple.com>
1294
1295         Add initial support for navigator.sendBeacon
1296         https://bugs.webkit.org/show_bug.cgi?id=175007
1297         <rdar://problem/33547728>
1298
1299         Reviewed by Sam Weinig.
1300
1301         Enable the Beacon API at runtime in the context of layout tests since the
1302         feature is currently disabled by default.
1303
1304         * DumpRenderTree/mac/DumpRenderTree.mm:
1305         (enableExperimentalFeatures):
1306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1307         (WTR::InjectedBundle::beginTesting):
1308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1309         (WTR::TestRunner::setModernMediaControlsEnabled):
1310         (WTR::TestRunner::setBeaconAPIEnabled):
1311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1312
1313 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1314
1315         Update Bot Watcher's Dashboard for Buildbot 0.9
1316         https://bugs.webkit.org/show_bug.cgi?id=174777
1317
1318         Reviewed by Daniel Bates.
1319
1320         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1321         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1322         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1323         in a dictionary.
1324         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1325         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1327         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1328         (parseRevisionProperty): Ditto.
1329         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1330         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1331         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1332         have changed in Buildbot 0.9.
1333         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1334         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1335         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1336         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1337         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1338         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1339         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1340         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1341         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1342         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1344         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1345         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1346         (BuildbotQueue.prototype.get overviewURL): Ditto.
1347         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1348         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1349         Buildbot 0.8 or 0.9.
1350         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1351         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1352         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1353         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1354         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1355         Therefore we are fetching information for fixed number of build. 
1356         Also iterating the loop incrementally since the build data is already reverse sorted.
1357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1358         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1359         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1361         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1362
1363 2017-08-01  Devin Rousso  <drousso@apple.com>
1364
1365         Web Inspector: simplify WebInspector with WI
1366         https://bugs.webkit.org/show_bug.cgi?id=175058
1367
1368         Reviewed by Joseph Pecoraro.
1369
1370         * Scripts/check-inspector-strings:
1371         (extract_ui_strings):
1372         * Scripts/extract-localizable-js-strings:
1373
1374 2017-08-01  Youenn Fablet  <youenn@apple.com>
1375
1376         Layout tests with 'https' suffix should be run over HTTPS
1377         https://bugs.webkit.org/show_bug.cgi?id=174992
1378
1379         Reviewed by Chris Dumez.
1380
1381         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1382         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1383         Covered by corresponding unit tests.
1384
1385         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1386         (run_server):
1387         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1388         (base_http_url):
1389         (base_https_url):
1390         (base_url): Deleted.
1391         * Scripts/webkitpy/port/base.py:
1392         (Port.to.web_platform_test_server_base_http_url):
1393         (Port.to):
1394         (Port.to.web_platform_test_server_base_https_url):
1395         (Port.to.web_platform_test_server_base_url): Deleted.
1396         * Scripts/webkitpy/port/driver.py:
1397         (Driver.__init__):
1398         (Driver.wpt_test_path_to_uri):
1399         (Driver):
1400         (Driver.http_test_path_to_uri):
1401         (Driver.test_to_uri):
1402         (Driver.uri_to_test):
1403         * Scripts/webkitpy/port/driver_unittest.py:
1404         (DriverTest.test_test_to_uri):
1405         (DriverTest.test_uri_to_test):
1406
1407 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1408
1409         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1410         https://bugs.webkit.org/show_bug.cgi?id=173998
1411
1412         Reviewed by Darin Adler.
1413
1414         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1415         detect mistakes in backward compatibility in the future when we change it.
1416
1417         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1418         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1419         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1420         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1421         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1422         internal key data slot.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1426         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1427         (getNextMessage):
1428         (TEST):
1429         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1430         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1431         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1432         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1433         These are the pre-baked databases.
1434         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1435         This is the actual test that do all the reads and comparisons.
1436         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1437         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1438         IndexedDB new stuffs. Then it can be used to bake the database again.
1439
1440 2017-08-01  Brady Eidson  <beidson@apple.com>
1441
1442         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1443         https://bugs.webkit.org/show_bug.cgi?id=175030
1444
1445         Reviewed by Andy Estes.
1446
1447         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1448         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1449
1450 2017-08-01  Brady Eidson  <beidson@apple.com>
1451
1452         Part 2 of: Rename DatabaseProcess to StorageProcess.
1453         https://bugs.webkit.org/show_bug.cgi?id=174880
1454
1455         Reviewed by Andy Estes.
1456
1457         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1458         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1459         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1460         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1461         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1462         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1463         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1464         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1465
1466 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1467
1468         Fix JSCOnly ARM buildbots after r220047
1469         https://bugs.webkit.org/show_bug.cgi?id=174993
1470
1471         Reviewed by Saam Barati.
1472
1473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1474         (BuildAndRemoteJSCTestsFactory.__init__):
1475
1476 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1477
1478         [WTF] Introduce Private Symbols
1479         https://bugs.webkit.org/show_bug.cgi?id=174935
1480
1481         Reviewed by Darin Adler.
1482
1483         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1484         (TestWebKitAPI::TEST):
1485
1486 2017-07-30  Darin Adler  <darin@apple.com>
1487
1488         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1489         https://bugs.webkit.org/show_bug.cgi?id=130653
1490
1491         Reviewed by Antti Koivisto.
1492
1493         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1494         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1495         when calling frameDidChangeLocation.
1496         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1497         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1498         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1499         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1500         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1501         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1502         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1503         loading, subframe starts loading. It would be good to clean that up some day, but for now
1504         this patch makes the two work identically rather than changing both.
1505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1506
1507 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1508
1509         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1510         https://bugs.webkit.org/show_bug.cgi?id=174963
1511
1512         Reviewed by Darin Adler.
1513
1514         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1515         RetainPtr<>. This patch changes them to all use auto.
1516
1517         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1518         (TestWebKitAPI::TEST):
1519
1520 2017-07-30  Brady Eidson  <beidson@apple.com>
1521
1522         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1523         https://bugs.webkit.org/show_bug.cgi?id=174958
1524
1525         Reviewed by Darin Adler.
1526
1527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1528         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1529         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1530         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1531         (runUntilTasksInFlight):
1532         (TEST):
1533
1534 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1535
1536         Unreviewed, rolling out r219990.
1537         https://bugs.webkit.org/show_bug.cgi?id=174961
1538
1539         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1540         estes on #webkit).
1541
1542         Reverted changeset:
1543
1544         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1545         https://bugs.webkit.org/show_bug.cgi?id=174880
1546         http://trac.webkit.org/changeset/219990
1547
1548 2017-07-28  Brady Eidson  <beidson@apple.com>
1549
1550         API tests that use URLSchemeHandler are failing.
1551         https://bugs.webkit.org/show_bug.cgi?id=174950
1552
1553         Reviewed by Alex Christensen.
1554
1555         Fix the NoMIMEType test to be correct.
1556
1557         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1558         (-[SchemeHandler initWithData:mimeType:]):
1559         (-[SchemeHandler webView:startURLSchemeTask:]):
1560         (TEST):
1561
1562 2017-07-28  Daniel Bates  <dabates@apple.com>
1563
1564         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1565         https://bugs.webkit.org/show_bug.cgi?id=174876
1566
1567         Reviewed by Alex Christensen.
1568
1569         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1570         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1571         they provide a more direct way to test the platform abstraction.
1572
1573         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1574
1575         * Scripts/prepare-ChangeLog:
1576         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1577         of the current working directory.
1578
1579 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1580
1581         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1582         https://bugs.webkit.org/show_bug.cgi?id=174930
1583
1584         Unreviewed test fix.
1585
1586         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1587
1588         * Scripts/prepare-ChangeLog:
1589         (get_function_line_ranges_for_cpp):
1590
1591 2017-07-28  JF Bastien  <jfbastien@apple.com>
1592
1593         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1594         https://bugs.webkit.org/show_bug.cgi?id=174930
1595
1596         Reviewed by Daniel Bates.
1597
1598         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1599         here also teach it about const and volatile overloads. I didn't do
1600         reference and rvalue reference overloads because we don't really
1601         use them, and the current parser throws away those characters and
1602         it doesn't seem worth making it more complex.
1603
1604         * Scripts/prepare-ChangeLog:
1605         (get_function_line_ranges_for_cpp):
1606         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1607         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1608         (Foo::Arrow::arrow):
1609         (Foo::Arrow::otherArrow):
1610         (Foo::Arrow::otherArrow const):
1611         (Foo::Arrow::otherArrow volatile):
1612         (Foo::Arrow::otherArrow const volatile):
1613
1614 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1615
1616         [GTK] Building with ENABLE_VIDEO=OFF fails
1617         https://bugs.webkit.org/show_bug.cgi?id=174940
1618
1619         Reviewed by Alex Christensen.
1620
1621         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
1622         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
1623
1624         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1625         (methodCallCallback): Add missing USE(GSTREAMER) guard.
1626
1627 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1628
1629         [WPE] Implement EventSenderProxy in WTR
1630         https://bugs.webkit.org/show_bug.cgi?id=173419
1631
1632         Reviewed by Žan Doberšek.
1633
1634         Add the implementation of EventSenderProxy to the WTR. This
1635         allows us to extend the coverage of the test suite in WKWPE.
1636
1637         * WebKitTestRunner/EventSenderProxy.h:
1638         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
1639         libxkbcommon needed to deal with key events.
1640         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1641         (WTR::EventSenderProxy::EventSenderProxy):
1642         (WTR::senderButtonToWPEButton):
1643         (WTR::EventSenderProxy::mouseDown):
1644         (WTR::EventSenderProxy::mouseUp):
1645         (WTR::EventSenderProxy::mouseMoveTo):
1646         (WTR::EventSenderProxy::mouseScrollBy):
1647         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1648         (WTR::EventSenderProxy::leapForward):
1649         (WTR::wkEventModifiersToWPE):
1650         (WTR::getXKBKeySymForKeyRef):
1651         (WTR::EventSenderProxy::keyDown):
1652         (WTR::EventSenderProxy::addTouchPoint):
1653         (WTR::EventSenderProxy::updateTouchPoint):
1654         (WTR::EventSenderProxy::setTouchModifier):
1655         (WTR::EventSenderProxy::setTouchPointRadius):
1656         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1657         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1658         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1659         (WTR::EventSenderProxy::touchStart):
1660         (WTR::EventSenderProxy::touchMove):
1661         (WTR::EventSenderProxy::touchEnd):
1662         (WTR::EventSenderProxy::touchCancel):
1663         (WTR::EventSenderProxy::clearTouchPoints):
1664         (WTR::EventSenderProxy::releaseTouchPoint):
1665         (WTR::EventSenderProxy::cancelTouchPoint):
1666
1667 2017-07-27  Brady Eidson  <beidson@apple.com>
1668
1669         Part 2 of: Rename DatabaseProcess to StorageProcess.
1670         https://bugs.webkit.org/show_bug.cgi?id=174880
1671
1672         Reviewed by Andy Estes.
1673
1674         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1676         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1677         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1678         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1679         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1680         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1681         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1682
1683 2017-07-26  Mark Lam  <mark.lam@apple.com>
1684
1685         Add ability to only run specific tests in run-javascriptcore-tests.
1686         https://bugs.webkit.org/show_bug.cgi?id=174884
1687
1688         Reviewed by Saam Barati.
1689
1690         For example, if we only want to run testapi, we can do so as follows:
1691             $ run-javascriptcore-tests --testapi
1692
1693         Previously, specifying --testapi effectively does nothing because we run all tests
1694         by default.  Only --no-testapi had the effect of disabling the test set.  This
1695         old behavior for --testapi is not very useful or meaningful.  We're now changing
1696         it to mean that we will only run that test.
1697
1698         With this change, we can also run more than one set of tests.  For example, if we
1699         only want to run testmasm and testair, we can do so as follows:
1700             $ run-javascriptcore-tests --testmasm --testair
1701
1702         By default, if no specific test option is specified, run-javascriptcore-tests will
1703         run all tests.
1704
1705         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1706         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1707         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1708         the other set will not run.  For example, the following only runs the mozilla tests:
1709             $ run-javascriptcore-tests --mozilla-tests
1710
1711         Note also that --jit-stress-tests is not for choosing a different set of tests.
1712         Instead, it is used for determining whether we run JIT'ed test configurations
1713         on the jsc stress tests and mozilla tests.  As a result, specifying
1714         --jit-stress-tests will not omit other tests.  For example, the following still
1715         runs all tests:
1716             $ run-javascriptcore-tests --jit-stress-tests
1717
1718         * Scripts/run-javascriptcore-tests:
1719         (defaultStringForTestState):
1720         (enableTestOrNot):
1721         (runJSCStressTests):
1722
1723 2017-07-26  Mark Lam  <mark.lam@apple.com>
1724
1725         Make run-javascriptcore-test run testair, testb3, and testmasm.
1726         https://bugs.webkit.org/show_bug.cgi?id=174837
1727         <rdar://problem/33522927>
1728
1729         Reviewed by Saam Barati and Filip Pizlo.
1730
1731         1. Refactors code for running testapi so that we can use it to run other tests.
1732         2. Added running of testmasm, testair, testb3.
1733
1734         Note: the existing testapi invocation code does not support remote invocation of
1735         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
1736         and testb3 also do not support remote invocation.  If we wish to add remote
1737         invocation support, we should do that in a separate patch.
1738
1739         * Scripts/run-javascriptcore-tests:
1740         (testPath):
1741         (runTest):
1742         (testapiPath): Deleted.
1743
1744 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
1745
1746         Remove duplicate code from Buildbot.js in dashboard
1747         https://bugs.webkit.org/show_bug.cgi?id=174870
1748
1749         Reviewed by Daniel Bates.
1750
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1752         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
1753         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
1754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
1755         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
1756
1757 2017-07-26  Brady Eidson  <beidson@apple.com>
1758
1759         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
1760         https://bugs.webkit.org/show_bug.cgi?id=174851
1761
1762         Reviewed by Chris Dumez.
1763
1764         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1765         (TEST):
1766
1767 2017-07-26  Brian Burg  <bburg@apple.com>
1768
1769         Remove WEB_TIMING feature flag
1770         https://bugs.webkit.org/show_bug.cgi?id=174795
1771
1772         Reviewed by Alex Christensen.
1773
1774         * Scripts/webkitperl/FeatureList.pm:
1775         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1776
1777 2017-07-26  Chris Dumez  <cdumez@apple.com>
1778
1779         Pressing the Escape key should not be a valid user gesture to enter fullscreen
1780         https://bugs.webkit.org/show_bug.cgi?id=174864
1781         <rdar://problem/33009088>
1782
1783         Reviewed by Geoffrey Garen.
1784
1785         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
1786         WKTR.
1787
1788         * DumpRenderTree/mac/EventSendingController.mm:
1789         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1790
1791 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1792
1793         Unreviewed, added Romain Bellessort to contributors.json.
1794
1795         * Scripts/webkitpy/common/config/contributors.json:
1796
1797 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
1798
1799         [WPE] WebGL2 support
1800         https://bugs.webkit.org/show_bug.cgi?id=174249
1801
1802         Reviewed by Alex Christensen.
1803
1804         * Scripts/webkitperl/FeatureList.pm:
1805         Enable WebGL2 for WPE when building through build-webkit.
1806
1807 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1808
1809         Unreviewed. Fix GTK distcheck.
1810
1811         * gtk/make-dist.py:
1812         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
1813
1814 2017-07-25  Brady Eidson  <beidson@apple.com>
1815
1816         ResourceLoadStatistics grandfathering happens much too often.
1817         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
1818
1819         Reviewed by Chris Dumez.
1820
1821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1822         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
1823         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
1824         (TEST):
1825
1826 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
1827
1828         Fix autoinstaller failing on autoinstall_everything
1829         https://bugs.webkit.org/show_bug.cgi?id=174830
1830
1831         Reviewed by Joseph Pecoraro.
1832
1833         * Scripts/webkitpy/thirdparty/__init__.py:
1834         (AutoinstallImportHook.find_module):
1835         (AutoinstallImportHook.install_chromedriver):
1836         (AutoinstallImportHook.install_geckodriver):
1837         (AutoinstallImportHook._install_chromedriver): Deleted.
1838         (AutoinstallImportHook._install_geckodriver): Deleted.
1839
1840 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
1841
1842         Replace --runtime with something for both ios-simulator and ios-device
1843         https://bugs.webkit.org/show_bug.cgi?id=173775
1844         <rdar://problem/32952164>
1845
1846         Reviewed by Aakash Jain.
1847
1848         Add --version flag for both iOS simulator and iOS device.
1849
1850         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1851         (parse_args): Add --version flag and move --no-install.
1852         * Scripts/webkitpy/port/factory.py:
1853         (platform_options): Move --no-intall to run_webkit_tests.py.
1854         * Scripts/webkitpy/port/ios.py:
1855         (IOSPort):
1856         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
1857         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
1858         * Scripts/webkitpy/port/ios_device.py:
1859         (IOSDevicePort.ios_version): Consult --version flag before checking connected
1860         devices for iOS version.
1861         * Scripts/webkitpy/port/ios_device_unittest.py:
1862         (IOSDeviceTest.make_port): Set --version option so that we can generate test
1863         expectation paths without devices connected.
1864         (IOSDeviceTest.test_additional_platform_directory): Deleted.
1865         (IOSDeviceTest.test_baseline_searchpath): Deleted.
1866         (IOSDeviceTest.test_expectations_ordering): Deleted.
1867         * Scripts/webkitpy/port/ios_simulator.py:
1868         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
1869         flag to specify a runtime.
1870         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
1871         flag and then use the default runtime.
1872
1873 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1874
1875         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
1876         https://bugs.webkit.org/show_bug.cgi?id=174815
1877
1878         Reviewed by Carlos Alberto Lopez Perez.
1879
1880         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
1881         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
1882         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
1883         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
1884         think), probably because of a newer CMake version.
1885
1886         * CMakeLists.txt:
1887         * TestWebKitAPI/CMakeLists.txt:
1888         * TestWebKitAPI/PlatformGTK.cmake:
1889
1890 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1891
1892         Fix BenchmarkRunner to only import selenium when needed
1893         https://bugs.webkit.org/show_bug.cgi?id=174808
1894
1895         Reviewed by Stephanie Lewis.
1896
1897         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1898         (LinuxChromeDriver.launch_driver):
1899         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1900         (LinuxFirefoxDriver.launch_driver):
1901         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1902         (OSXChromeDriver.launch_driver):
1903         (OSXChromeCanaryDriver.launch_driver):
1904         (create_chrome_options):
1905         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1906         (OSXFirefoxDriver.launch_driver):
1907         (OSXFirefoxNightlyDriver.launch_driver):
1908         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1909         (OSXSafariDriver.launch_driver):
1910         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1911         (WebDriverBenchmarkRunner._run_one_test):
1912
1913 2017-07-23  Darin Adler  <darin@apple.com>
1914
1915         More NeverDestroyed and related cleanup
1916         https://bugs.webkit.org/show_bug.cgi?id=174745
1917
1918         Reviewed by Alex Christensen.
1919
1920         * DumpRenderTree/JavaScriptThreading.cpp:
1921         (javaScriptThreadsMutex): Use NeverDestroyed instead of
1922         DEPRECATED_DEFINE_STATIC_LOCAL.
1923         (javaScriptThreads): Ditto.
1924
1925 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1926
1927         Subclass Benchmark Runner script for WebDriver support
1928         https://bugs.webkit.org/show_bug.cgi?id=174390
1929
1930         Reviewed by Dewei Zhu, Stephanie Lewis.
1931
1932         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
1933
1934         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1935         (BenchmarkBuilder.__init__):
1936         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1937         (BenchmarkRunner.__init__):
1938         (BenchmarkRunner._find_plan_file):
1939         (BenchmarkRunner._run_one_test.and):
1940         (BenchmarkRunner.execute):
1941         (BenchmarkRunner._get_result): Deleted.
1942         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1943         (parse_args):
1944         (start):
1945         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1946         (WebDriverBenchmarkRunner):
1947         (WebDriverBenchmarkRunner._get_result):
1948         (WebDriverBenchmarkRunner._run_one_test):
1949         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1950         (WebServerBenchmarkRunner):
1951         (WebServerBenchmarkRunner.__init__):
1952         (WebServerBenchmarkRunner._get_result):
1953         (WebServerBenchmarkRunner._run_one_test):
1954
1955 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1956
1957         Add BenchmarkRunner patches with WebDriver support for each testing plan
1958         https://bugs.webkit.org/show_bug.cgi?id=174443
1959
1960         Reviewed by Dewei Zhu, Stephanie Lewis.
1961
1962         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1963         (BenchmarkBuilder.__enter__):
1964         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1965         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1966         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1967         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1968         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1969         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1970         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1971         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1972         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1973         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1974         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1975         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1976         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1977         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1978         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1979         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1980         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1981         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1982         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1983         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1984         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1985         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1986         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1987         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1988         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1989         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1990         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1991         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1992         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1993         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1994         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1995         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1996         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1997
1998 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1999
2000         Add functions to autoinstaller needed for Benchmark Runner script
2001         https://bugs.webkit.org/show_bug.cgi?id=174331
2002
2003         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2004
2005         Adds autoinstaller functions to install selenium and webdriver binaries
2006         which will be used by the browser driver part of Benchmark Runner.
2007
2008         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2009         (BrowserDriver.restore_env):
2010         (BrowserDriver):
2011         (BrowserDriver.get_webdriver_binary_path):
2012         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2013         (LinuxChromeDriver.launch_driver):
2014         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2015         (LinuxFirefoxDriver.launch_driver):
2016         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2017         (OSXChromeDriver.launch_driver):
2018         (OSXChromeCanaryDriver.launch_driver):
2019         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2020         (OSXFirefoxDriver.launch_driver):
2021         (OSXFirefoxNightlyDriver.launch_driver):
2022         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2023         * Scripts/webkitpy/benchmark_runner/utils.py:
2024         (get_driver_binary_path):
2025         * Scripts/webkitpy/common/system/autoinstall.py:
2026         (AutoInstaller._unzip):
2027         * Scripts/webkitpy/thirdparty/__init__.py:
2028         (AutoinstallImportHook.find_module):
2029         (AutoinstallImportHook._install_selenium):
2030         (AutoinstallImportHook):
2031         (AutoinstallImportHook._install_chromedriver):
2032         (AutoinstallImportHook._install_geckodriver):
2033         (AutoinstallImportHook.get_latest_pypi_url):
2034         (AutoinstallImportHook.install_binary):
2035         (autoinstall_everything):
2036         (get_driver_filename):
2037         (get_os_info):
2038
2039 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2040
2041         Add WebDriver support in browser driver part of BenchmarkRunner
2042         https://bugs.webkit.org/show_bug.cgi?id=174445
2043
2044         Reviewed by Stephanie Lewis.
2045
2046         Adds a launch_driver function to each BrowserDriver subclass. This
2047         function sets up the arguments for the webdriver and launches the
2048         webdriver specific to that browser.
2049
2050         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2051         (BrowserDriver.launch_webdriver):
2052         (BrowserDriver):
2053         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2054         (LinuxBrowserDriver.launch_webdriver):
2055         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2056         (LinuxChromeDriver.launch_url):
2057         (LinuxChromeDriver):
2058         (LinuxChromeDriver.launch_driver):
2059         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2060         (EpiphanyBrowserDriver.launch_url):
2061         (EpiphanyBrowserDriver):
2062         (EpiphanyBrowserDriver.launch_driver):
2063         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2064         (LinuxFirefoxDriver):
2065         (LinuxFirefoxDriver.launch_url):
2066         (LinuxFirefoxDriver.launch_driver):
2067         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2068         (GTKMiniBrowserDriver.launch_url):
2069         (GTKMiniBrowserDriver):
2070         (GTKMiniBrowserDriver.launch_driver):
2071         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2072         (OSXBrowserDriver._launch_webdriver):
2073         (OSXBrowserDriver):
2074         (OSXBrowserDriver._screen_size):
2075         (OSXBrowserDriver._insert_url):
2076         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2077         (OSXChromeDriver):
2078         (OSXChromeDriver.launch_url):
2079         (OSXChromeDriver.launch_driver):
2080         (OSXChromeCanaryDriver):
2081         (OSXChromeCanaryDriver.launch_url):
2082         (OSXChromeCanaryDriver.launch_driver):
2083         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2084         (OSXFirefoxDriver):
2085         (OSXFirefoxDriver.launch_url):
2086         (OSXFirefoxDriver.launch_driver):
2087         (OSXFirefoxNightlyDriver):
2088         (OSXFirefoxNightlyDriver.launch_url):
2089         (OSXFirefoxNightlyDriver.launch_driver):
2090         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2091         (OSXSafariDriver.launch_driver):
2092
2093 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2094
2095         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2096         https://bugs.webkit.org/show_bug.cgi?id=174793
2097
2098         Reviewed by Tim Horton.
2099
2100         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2101         down. Without r219765, this test will dereference null and crash.
2102
2103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2104         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2105         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2106         (TEST):
2107
2108 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2109
2110         [Win] Implement Authentication dialog in MiniBrowser
2111         https://bugs.webkit.org/show_bug.cgi?id=174662
2112
2113         Reviewed by Alex Christensen.
2114
2115         * MiniBrowser/win/Common.cpp:
2116         (CustomUserAgent):
2117         (DisplayAuthDialog):
2118         (AuthDialogProc):
2119         * MiniBrowser/win/MiniBrowserLib.rc:
2120         * MiniBrowser/win/MiniBrowserLibResource.h:
2121         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2122         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2123
2124 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2125
2126         Handle case where line_numbers is None instead of an array of line numbers
2127         https://bugs.webkit.org/show_bug.cgi?id=174775
2128
2129         Reviewed by Aakash Jain.
2130
2131         Added files set line_numbers to None in process_file.
2132
2133         * Scripts/webkitpy/style/filereader.py:
2134         (TextFileReader.process_file): Handle case where line_number is set to None.
2135         * Scripts/webkitpy/style/main_unittest.py:
2136         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2137
2138 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2139
2140         [WPE] Add libepoxy to the Jhbuild moduleset
2141         https://bugs.webkit.org/show_bug.cgi?id=174711
2142
2143         Reviewed by Carlos Alberto Lopez Perez.
2144
2145         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2146
2147 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2148
2149         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2150         https://bugs.webkit.org/show_bug.cgi?id=174780
2151
2152         Reviewed by Carlos Garcia Campos.
2153
2154         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2155         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2156         in case the eglplatform.h header doesn't provide that macro. This replicates
2157         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2158
2159 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2160
2161         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2162         https://bugs.webkit.org/show_bug.cgi?id=174758
2163
2164         Reviewed by Dan Bernstein.
2165
2166         Migrate position-information-related unit tests from the PositionInformationTests suite to
2167         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2168
2169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2170         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2171         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2172         (TestWebKitAPI::TEST):
2173         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2174         * TestWebKitAPI/cocoa/TestWKWebView.h:
2175         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2176         (-[TestWKWebView activatedElementAtPosition:]):
2177
2178 2017-07-22  Chris Dumez  <cdumez@apple.com>
2179
2180         REGRESSION(r204565): WKObject is broken
2181         https://bugs.webkit.org/show_bug.cgi?id=174736
2182         <rdar://problem/33246169>
2183
2184         Reviewed by Dan Bernstein.
2185
2186         Add API test that used to crash.
2187
2188         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2189         (TestWebKitAPI::TEST):
2190
2191 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2192
2193         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2194         https://bugs.webkit.org/show_bug.cgi?id=174705
2195
2196         Reviewed by Mark Lam.
2197
2198         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2199         (TestWebKitAPI::testThreadGroup):
2200         (TestWebKitAPI::TEST):
2201
2202 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2203
2204         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2205         https://bugs.webkit.org/show_bug.cgi?id=174724
2206
2207         Reviewed by Aakash Jain.
2208
2209         * Scripts/webkitpy/port/ios_simulator.py:
2210         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2211         simulator. Errors here should be treated the same as no simulators found.
2212
2213 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2214
2215         [CMake] Add an option to stop build after generating project files
2216         https://bugs.webkit.org/show_bug.cgi?id=174664
2217
2218         Reviewed by Konstantin Tokarev.
2219
2220         Add "--generate-project-only" to stop build after generating project files.
2221
2222         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2223         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2224         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2225         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2226         (isGenerateProjectOnly): ditto
2227
2228 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2229
2230         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2231         https://bugs.webkit.org/show_bug.cgi?id=174501
2232
2233         Reviewed by Darin Adler.
2234
2235         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2236         (TestWebKitAPI::TEST):
2237
2238 2017-07-20  David Quesada  <david_quesada@apple.com>
2239
2240         Add SPI to notify WKNavigationDelegate about client redirects
2241         https://bugs.webkit.org/show_bug.cgi?id=174680
2242         rdar://problem/33184886
2243
2244         Reviewed by Brady Eidson.
2245
2246         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2247         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2248         (TEST):
2249         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2250
2251 2017-07-20  Brady Eidson  <beidson@apple.com>
2252
2253         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2254         https://bugs.webkit.org/show_bug.cgi?id=174685
2255
2256         Reviewed by Andy Estes.
2257
2258         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2259         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2260
2261 2017-07-20  Brady Eidson  <beidson@apple.com>
2262
2263         Deprecate WebIconDatabase in WebKitLegacy/mac.
2264         https://bugs.webkit.org/show_bug.cgi?id=174607
2265
2266         Reviewed by Alex Christensen.
2267
2268         * DumpRenderTree/mac/TestRunnerMac.mm:
2269
2270 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2271
2272         lint-test-expectations should be run during style checking
2273         https://bugs.webkit.org/show_bug.cgi?id=173559
2274         <rdar://problem/32854941>
2275
2276         Reviewed by Aakash Jain.
2277
2278         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2279         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2280         prevents identifying errors on specific lines in a file.
2281         * Scripts/webkitpy/style/main_unittest.py:
2282         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2283         case where a linter error is in the file modified, but the line modified is not related to
2284         the linter error.
2285
2286 2017-07-20  Brady Eidson  <beidson@apple.com>
2287
2288         Remove WebIconDatabase from WebKitLegacy/win.
2289         https://bugs.webkit.org/show_bug.cgi?id=174608
2290
2291         Reviewed by Alex Christensen.
2292
2293         * DumpRenderTree/win/DumpRenderTree.cpp:
2294         (main):
2295         * DumpRenderTree/win/TestRunnerWin.cpp:
2296         (TestRunner::setIconDatabaseEnabled):
2297
2298 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2299
2300         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2301         https://bugs.webkit.org/show_bug.cgi?id=174671
2302
2303         Reviewed by Carlos Garcia Campos.
2304
2305         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2306         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2307         priority for this source in order to have it dispatched on the same
2308         priority as the other WebKit-controlled GSource objects.
2309
2310 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2311
2312         lint-test-expectations should be run during style checking
2313         https://bugs.webkit.org/show_bug.cgi?id=173559
2314         <rdar://problem/32854941>
2315
2316         Reviewed by Daniel Bates.
2317
2318         Follow up fix addressing style and a few minor bugs.
2319
2320         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2321         (TestExpectationParser.__init__): Use lambda x: x instead of str
2322         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2323         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2324         reduce the calls of _shorten_filename, fix minor bug in appending the current
2325         expectation's line number instead of the previous ones, clarify treatment of None
2326         in file-to-line-number mapping.
2327         (TestExpectations._report_warnings): Collapse call.
2328         * Scripts/webkitpy/style/checkers/test_expectations.py:
2329         (TestExpectationsChecker.lint_test_expectations):
2330         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2331         (TextFileReader.process_file): Add comment explaining treatment of None in
2332         file-to-line-number mapping.
2333         (TextFileReader.delete_file): Collapse call.
2334
2335 2017-07-19  Chris Dumez  <cdumez@apple.com>
2336
2337         Unreviewed attempt to fix API test failure after r219663.
2338
2339         The test was hard-coding an exception string and the string has changed slightly
2340         in r219663.
2341
2342         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2343         (TEST):
2344
2345 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2346
2347         Don't write file URLs to iOS Pasteboard
2348         https://bugs.webkit.org/show_bug.cgi?id=174647
2349         <rdar://problem/33199730>
2350
2351         Reviewed by Wenson Hsieh.
2352
2353         Updating tests to reflect the lack of file URLs for images.
2354
2355         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2356         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2357         (checkEstimatedSize):
2358         (TestWebKitAPI::TEST):
2359
2360 2017-07-19  Brady Eidson  <beidson@apple.com>
2361
2362         iBooks sometimes crashes when closing a book.
2363         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2364
2365         Reviewed by Oliver Hunt.
2366
2367         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2368         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2369         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2370         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2371         (TestWebKitAPI::TEST):
2372
2373         Add a "spin the runloop X number of times" utility:
2374         * TestWebKitAPI/Utilities.h:
2375         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2376         (TestWebKitAPI::Util::spinRunLoop):
2377
2378 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2379
2380         lint-test-expectations should be run during style checking
2381         https://bugs.webkit.org/show_bug.cgi?id=173559
2382         <rdar://problem/32854941>
2383
2384         Reviewed by David Kilzer.
2385
2386         Running the test expectation linter requires reading both files and lines not in the
2387         patch because, for example, deletion of a test can cause a lint failure even though
2388         no test expectations where modified. This means that the linter will occasionally warn
2389         about lines which were not changed in a given patch but whose error is related to a
2390         change made in that patch.
2391
2392         * Scripts/webkitpy/common/system/filesystem_mock.py:
2393         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2394         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2395         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2396         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2397         content, description of the error and the name of the associated test.
2398         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2399         (TestExpectationParser.__init__): Pass shorten_filename function to
2400         TestExpectationsParser to add a deleted file to the related_files dictionary.
2401         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2402         missing path to the related_files dictionary.
2403         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2404         files and line numbers related to this test expectation line. This will allow
2405         tracking linter errors in the style checker occurring across multiple files.
2406         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2407         lines to related_files dictionary.
2408         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2409         (TestExpectations._report_warnings): Construct warning object instead of string
2410         when adding to warnings list.
2411         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2412         clean-up log.
2413         * Scripts/webkitpy/style/checker.py:
2414         (ProcessorBase.do_association_check): Add required function for processor classes.
2415         (StyleProcessor):
2416         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2417         checking for errors between associated files.
2418         * Scripts/webkitpy/style/checkers/test_expectations.py:
2419         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2420         (TestExpectationsChecker):
2421         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2422         of modified files, the current working directory and the host, determine if the linter
2423         warning is associated with the changes.
2424         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2425         style checker.
2426         * Scripts/webkitpy/style/filereader.py:
2427         (TextFileReader):
2428         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2429         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2430         (TextFileReader.process_file): Track both the number of files changed and which lines
2431         in those files were changed.
2432         (TextFileReader.do_association_check): Run the processor's association check on all
2433         modified or deleted files processed by TextFileReader.
2434         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2435         (TextFileReader.count_delete_only_file): Deleted.
2436         * Scripts/webkitpy/style/filereader_unittest.py:
2437         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2438         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2439         * Scripts/webkitpy/style/main.py:
2440         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2441         explicitly run the association check on the file reader.
2442         * Scripts/webkitpy/style/main_unittest.py:
2443         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2444         embedded in the style checker.
2445         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2446         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2447         construct the TextFileReader object with a StyleProcessor used to run style checks on
2448         specific files.
2449         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2450         testing the test expectation linter inside the style checker. This host must contain a
2451         mock file system with the basic structure of test expectations.
2452         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2453         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2454         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2455         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2456         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2457         * Scripts/webkitpy/style/patchreader.py:
2458         (PatchReader.check): Specify which file was deleted, run the association check.
2459         * Scripts/webkitpy/style/patchreader_unittest.py:
2460         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2461         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2462         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2463
2464 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2465
2466         [WTF] Implement WTF::ThreadGroup
2467         https://bugs.webkit.org/show_bug.cgi?id=174081
2468
2469         Reviewed by Mark Lam.
2470
2471         Add WTF::ThreadGroup tests.
2472
2473         * TestWebKitAPI/CMakeLists.txt:
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2476         (TestWebKitAPI::testThreadGroup):
2477         (TestWebKitAPI::TEST):
2478
2479 2017-07-18  Andy Estes  <aestes@apple.com>
2480
2481         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2482         https://bugs.webkit.org/show_bug.cgi?id=174631
2483
2484         Reviewed by Tim Horton.
2485
2486         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2487         * MiniBrowser/Configurations/Base.xcconfig:
2488         * MobileMiniBrowser/Configurations/Base.xcconfig:
2489         * TestWebKitAPI/Configurations/Base.xcconfig:
2490         * WebKitTestRunner/Configurations/Base.xcconfig:
2491
2492 2017-07-18  Andy Estes  <aestes@apple.com>
2493
2494         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2495         https://bugs.webkit.org/show_bug.cgi?id=174631
2496
2497         Reviewed by Sam Weinig.
2498
2499         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2500         * MiniBrowser/Configurations/Base.xcconfig:
2501         * MobileMiniBrowser/Configurations/Base.xcconfig:
2502         * TestWebKitAPI/Configurations/Base.xcconfig:
2503         * WebKitTestRunner/Configurations/Base.xcconfig:
2504
2505 2017-07-18  Daniel Bates  <dabates@apple.com>
2506
2507         lldb: Add type summary for StringView
2508         https://bugs.webkit.org/show_bug.cgi?id=174637
2509
2510         Reviewed by Sam Weinig.
2511
2512         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2513         StringView object will print output that has the form:
2514
2515             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2516               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2517               m_length = 2
2518               m_is8Bit = true
2519               m_underlyingString = 0x0000614000000a90
2520             }
2521
2522         * lldb/lldb_webkit.py:
2523         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2524         (WTFStringView_SummaryProvider):
2525         (WTFStringViewProvider):
2526         (WTFStringViewProvider.__init__):
2527         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2528         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2529         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2530         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2531
2532 2017-07-18  Andy Estes  <aestes@apple.com>
2533
2534         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2535         https://bugs.webkit.org/show_bug.cgi?id=174631
2536
2537         Reviewed by Dan Bernstein.
2538
2539         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2540         * MiniBrowser/Configurations/Base.xcconfig:
2541         * MobileMiniBrowser/Configurations/Base.xcconfig:
2542         * TestWebKitAPI/Configurations/Base.xcconfig:
2543         * WebKitTestRunner/Configurations/Base.xcconfig:
2544
2545 2017-07-18  Devin Rousso  <drousso@apple.com>
2546
2547         Web Inspector: Add memoryCost to Inspector Protocol objects
2548         https://bugs.webkit.org/show_bug.cgi?id=174478
2549
2550         Reviewed by Joseph Pecoraro.
2551
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2554         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2555         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2556         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2557         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2558         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2559         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2560         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2561         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2562         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2563         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2564         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2565         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2566         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2567         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2568         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2569
2570 2017-07-18  Andy Estes  <aestes@apple.com>
2571
2572         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2573         https://bugs.webkit.org/show_bug.cgi?id=174631
2574
2575         Reviewed by Darin Adler.
2576
2577         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2578         * MiniBrowser/Configurations/Base.xcconfig:
2579         * MobileMiniBrowser/Configurations/Base.xcconfig:
2580         * TestWebKitAPI/Configurations/Base.xcconfig:
2581         * WebKitTestRunner/Configurations/Base.xcconfig:
2582
2583 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2584
2585         Unreviewed, fix the iOS build.
2586
2587         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2588
2589         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2590         (TestWebKitAPI::TEST):
2591
2592 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2593
2594         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2595         https://bugs.webkit.org/show_bug.cgi?id=174585
2596         <rdar://problem/33302541>
2597
2598         Reviewed by Tim Horton.
2599
2600         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2601         being dragged when initiating a drag.
2602
2603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2604         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2605         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2606         (TestWebKitAPI::TEST):
2607         * TestWebKitAPI/cocoa/TestWKWebView.h:
2608
2609         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2610
2611         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2612         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2613
2614 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2615
2616         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
2617         https://bugs.webkit.org/show_bug.cgi?id=174547
2618
2619         Reviewed by Alex Christensen.
2620
2621         * DumpRenderTree/PlatformWin.cmake:
2622         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2623
2624 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2625
2626         Update style checker to deal with "final"
2627         https://bugs.webkit.org/show_bug.cgi?id=174528
2628
2629         Reviewed by Alex Christensen.
2630         
2631         check-webkit-style shouldn't complain about an open brace to start a
2632         line after a function definition with "final" or "const final".
2633
2634         * Scripts/webkitpy/style/checkers/cpp.py:
2635         (check_braces):
2636         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2637         (CppStyleTest.test_brace_at_begin_of_line):
2638
2639 2017-07-17  Alex Christensen  <achristensen@webkit.org>
2640
2641         Modernize content extension code
2642         https://bugs.webkit.org/show_bug.cgi?id=174588
2643
2644         Reviewed by Sam Weinig.
2645
2646         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2647         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2648         (TestWebKitAPI::testRequest):
2649         (TestWebKitAPI::makeBackend):
2650         (TestWebKitAPI::TEST_F):
2651
2652 2017-07-17  Brady Eidson  <beidson@apple.com>
2653
2654         WKHTTPCookieStore observing only works on the default cookie store.
2655         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2656
2657         Reviewed by Sam Weinig.
2658
2659         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2660         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2661           called for the default store, a non-persistent store, and a custom store.
2662         (TEST):
2663
2664 2017-07-16  Sam Weinig  <sam@webkit.org>
2665
2666         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2667         https://bugs.webkit.org/show_bug.cgi?id=174575
2668
2669         Reviewed by Brady Eidson.
2670
2671         * Scripts/svn-create-patch:
2672         (findModificationType):
2673         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2674         default value of "unknown".
2675
2676         (generateFileList):
2677         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2678         for untracked, which matches our old behavior.
2679
2680 2017-07-17  Charlie Turner  <cturner@igalia.com>
2681
2682         Add some missing build dependencies on Fedora
2683         https://bugs.webkit.org/show_bug.cgi?id=174578
2684
2685         Unreviewed dependency update.
2686
2687         * gtk/install-dependencies:
2688
2689 2017-07-16  Brady Eidson  <beidson@apple.com>
2690
2691         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2692         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2693
2694         Reviewed by Tim Horton.
2695
2696         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2697         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2698         (TEST):
2699
2700 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2701
2702         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2703         https://bugs.webkit.org/show_bug.cgi?id=174540
2704
2705         Reviewed by Michael Catanzaro.
2706
2707         * gtk/generate-inspector-gresource-manifest.py:
2708         (get_filenames): sort list of input files
2709
2710 2017-07-15  Brady Eidson  <beidson@apple.com>
2711
2712         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2713         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2714
2715         Reviewed by Tim Horton.
2716
2717         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2718         (TEST): Make this test more reliable by clearing everything beforehand.
2719
2720 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2721
2722         Make it possible to extend check-webkit-style with Apple-internal checkers
2723         <https://webkit.org/b/174464>
2724         <rdar://problem/25564402>
2725
2726         Reviewed by Darin Adler.
2727
2728         * Scripts/webkitpy/style/checker.py: Import apple_additions.
2729         (_all_categories): Add categories from apple_additions() if it
2730         exists.
2731         (CheckerDispatcher._create_checker): Create python checker
2732         from apple_additions() if it exists.
2733
2734 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2735
2736         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
2737         https://bugs.webkit.org/show_bug.cgi?id=174539
2738         <rdar://problem/33307395>
2739
2740         Reviewed by Darin Adler.
2741
2742         Adds a new unit test suite to cover action sheet popover presentation.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
2746         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
2747         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
2748
2749         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
2750
2751         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
2752         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2753
2754         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
2755
2756         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2757         (TestWebKitAPI::TEST):
2758
2759 2017-07-15  Sam Weinig  <sam@webkit.org>
2760
2761         [Scripts] Make svn-create-patch work better when called in sub directories
2762         https://bugs.webkit.org/show_bug.cgi?id=174551
2763
2764         Reviewed by Darin Adler.
2765
2766         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
2767           by ensuring that the prefix is applied as is done in generateDiff.
2768         - Silence output of explanatory lines from svn stat (" > move to ...")
2769           that show up in STDERR when running svn-create-patch.
2770         - Add verbose logging that I found useful while debugging this issue.
2771
2772         * Scripts/svn-create-patch:
2773         (findBaseUrl):
2774         (findMimeType):
2775         (findSourceFileAndRevision):
2776         (generateDiff):
2777         (generateFileList):
2778         (manufacturePatchForAdditionWithHistory):
2779
2780 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
2781
2782         Unreviewed build fix after r219537.
2783
2784         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2785
2786 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2787
2788         Add iOS 11 SPI
2789         https://bugs.webkit.org/show_bug.cgi?id=174430
2790         <rdar://problem/33269288>
2791
2792         Reviewed by Tim Horton.
2793
2794         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
2795         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
2796         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
2797
2798 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2799
2800         Failing to install on iPad simulators
2801         https://bugs.webkit.org/show_bug.cgi?id=174532
2802         <rdar://problem/33328347>
2803
2804         Reviewed by Stephanie Lewis.
2805
2806         * Scripts/webkitpy/xcode/simulated_device.py:
2807         (SimulatedDevice.install_app): Place install command in retry try-except block.
2808
2809 2017-07-14  Jeff Miller  <jeffm@apple.com>
2810
2811         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2812         https://bugs.webkit.org/show_bug.cgi?id=174524
2813
2814         Reviewed by Sam Weinig.
2815
2816         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2817         (TEST):
2818         Renamed TestParameter to TestParameter1.
2819         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2820
2821         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2822         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2823         Observe changes for two bundle parameters.
2824
2825         (-[BundleParametersPlugIn dealloc]):
2826         Remove observers for two bundle parameters.
2827
2828 2017-07-14  Commit Queue  <commit-queue@webkit.org>
2829
2830         Unreviewed, rolling out r219510.
2831         https://bugs.webkit.org/show_bug.cgi?id=174525
2832
2833         Need to revert length() == 0 check for null string (Requested
2834         by yusukesuzuki on #webkit).
2835
2836         Reverted changeset:
2837
2838         "[WTF] Newly added AtomicStringImpl should use BufferInternal
2839         static string if StringImpl is static"
2840         https://bugs.webkit.org/show_bug.cgi?id=174501
2841         http://trac.webkit.org/changeset/219510
2842
2843 2017-07-14  Jer Noble  <jer.noble@apple.com>
2844
2845         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
2846         https://bugs.webkit.org/show_bug.cgi?id=174514
2847
2848         Reviewed by Sam Weinig.
2849
2850         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
2851         (TestWebKitAPI::TEST_F):
2852
2853 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2854
2855         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2856         https://bugs.webkit.org/show_bug.cgi?id=174501
2857
2858         Reviewed by Darin Adler.
2859
2860         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2861         (TestWebKitAPI::TEST):
2862
2863 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2864
2865         Bring mac expectations in-line with other platforms
2866         https://bugs.webkit.org/show_bug.cgi?id=174472
2867         <rdar://problem/33297388>
2868
2869         Reviewed by David Kilzer.
2870
2871         The override order for Mac test expectations does not conform to the pattern used by iOS,
2872         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
2873
2874             platform/mac-wk2
2875             platform/wk2
2876             platform/mac-elcapitan
2877             platform/mac-sierra
2878             generic
2879
2880         After this change, El Capitan's baseline search path looks like this:
2881
2882             platform/mac-sierra-wk2
2883             platform/mac-sierra
2884             platform/mac-wk2
2885             platform/wk2
2886             generic
2887
2888         * Scripts/webkitpy/port/mac.py:
2889         (MacPort.__init__): If a specific version is specified in the port name, use that
2890         as the os version.
2891         (MacPort.default_baseline_search_path): Expectation search paths should work the
2892         same way they do on other ports. Port + version overrides port, port overrides generic
2893         and wk1/wk2 should override expectations for the two combined.
2894         * Scripts/webkitpy/port/mac_unittest.py:
2895         (MacTest.test_tests_for_other_platforms): Deleted.
2896         (MacTest._assert_search_path): Deleted.
2897         (MacTest.test_baseline_search_path): Deleted.
2898         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2899         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
2900         (test_rebaseline_test_and_print_scm_changes): Ditto.
2901         (test_rebaseline_and_copy_test): Ditto.
2902         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
2903         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
2904         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
2905
2906 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2907
2908         Fix style checker unit test
2909
2910         Unreviewed WebKit2 => WebKit fixup.
2911
2912         * Scripts/webkitpy/style/checker_unittest.py:
2913         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2914
2915 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2916
2917         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
2918
2919         Unreviewed build fix.
2920
2921         r219492 missed one hunk from its partial revert of r219489.
2922         This patch reverts that hunk.
2923
2924         * TestWebKitAPI/CMakeLists.txt:
2925
2926 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2927
2928         Use the old WebKit/WebKit2 targets for CMake builds.
2929
2930         Unreviewed build fix.
2931
2932         We can update the target names to match the Framework names in a future patch.
2933         This is a partial revert of r219489.
2934
2935         * TestWebKitAPI/CMakeLists.txt:
2936         WebKitLegacy => WebKit
2937         WebKit => WebKit2
2938
2939 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2940
2941         Fix TestWebKit API.
2942         https://bugs.webkit.org/show_bug.cgi?id=174164
2943         rdar://problem/33137595
2944
2945         Reviewed by Dan Bernstein.
2946
2947         * TestWebKitAPI/CMakeLists.txt:
2948         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2949         * TestWebKitAPI/PlatformGTK.cmake:
2950
2951 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2952
2953         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2954         https://bugs.webkit.org/show_bug.cgi?id=174164
2955         rdar://problem/33137595
2956
2957         Reviewed by Dan Bernstein.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2960         (ShouldBuildTest):
2961         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2962         * Scripts/build-webkit:
2963         * Scripts/do-file-rename:
2964         * Scripts/do-webcore-rename:
2965         * Scripts/update-webkit-localizable-strings:
2966         * Scripts/webkitpy/common/config/watchlist:
2967         * Scripts/webkitpy/style/checker.py:
2968         * Scripts/webkitpy/style/checkers/featuredefines.py:
2969         * gtk/make-dist.py:
2970         (ensure_version_if_possible):
2971         * gtk/manifest.txt.in:
2972
2973 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2974
2975         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2976         https://bugs.webkit.org/show_bug.cgi?id=174162
2977         rdar://problem/33137594
2978
2979         Reviewed by Dan Bernstein.
2980
2981         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2982
2983         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2984         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2985         * EWSTools/configure-clang-linux.sh:
2986         * Scripts/build-webkit:
2987         * Scripts/do-file-rename:
2988         * Scripts/do-webcore-rename:
2989         * Scripts/update-webkit-localizable-strings:
2990         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2991         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2992         * Scripts/webkitpy/style/checkers/featuredefines.py:
2993         * gtk/manifest.txt.in:
2994
2995 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2996
2997         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2998         https://bugs.webkit.org/show_bug.cgi?id=174438
2999         <rdar://problem/33277112>
3000
3001         Reviewed by Aakash Jain.
3002
3003         Given a patch, this will convert the changes from the path to the new directory structure.
3004
3005         * Scripts/rebase-patch-after-webkit-move: Added.
3006         (append_source): Append 'Source' to the provided path.
3007         (is_editable_line): Return true if a line the script expects to modify.
3008         (needs_rebase): Return if a line needs to be rebased based on it's content.
3009         (rebase_line): Rebase the provided line.
3010         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3011         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3012         were provided.
3013
3014 2017-07-12  Nan Wang  <n_wang@apple.com>
3015
3016         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3017         https://bugs.webkit.org/show_bug.cgi?id=174393
3018         <rdar://problem/33248006>
3019
3020         Reviewed by Chris Fleizach.
3021
3022         * DumpRenderTree/AccessibilityUIElement.cpp:
3023         (textMarkerRangeMatchesTextNearMarkersCallback):
3024         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3025         (AccessibilityUIElement::getJSClass):
3026         * DumpRenderTree/AccessibilityUIElement.h:
3027         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3028         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3029         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3030         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3031         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3032         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3033         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3034         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3035
3036 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3037
3038         Unreviewed, rolling out r219409.
3039
3040         The revision caused the Windows builds to fail.
3041
3042         Reverted changeset:
3043
3044         "AX: [iOS] Implement a way to retrieve a text marker range
3045         with desired text that is closest to a position"
3046         https://bugs.webkit.org/show_bug.cgi?id=174393
3047         http://trac.webkit.org/changeset/219409
3048
3049 2017-07-12  Nan Wang  <n_wang@apple.com>
3050
3051         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3052         https://bugs.webkit.org/show_bug.cgi?id=174393
3053         <rdar://problem/33248006>
3054
3055         Reviewed by Chris Fleizach.
3056
3057         * DumpRenderTree/AccessibilityUIElement.cpp:
3058         (textMarkerRangeMatchesTextNearMarkersCallback):
3059         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3060         (AccessibilityUIElement::getJSClass):
3061         * DumpRenderTree/AccessibilityUIElement.h:
3062         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3063         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3064         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3065         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3066         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3067         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3068         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3069         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3070
3071 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3072
3073         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3074         https://bugs.webkit.org/show_bug.cgi?id=174197
3075
3076         Reviewed by Darin Adler.
3077
3078         This bit me the first time I tried to submit a patch to WebKit, and still I have
3079         to manually edit the ChangeLog every time I use the script.
3080
3081         This generates a more convenient and standard ChangeLog entry.
3082
3083         * Scripts/prepare-ChangeLog:
3084         (generateNewChangeLogs):
3085
3086 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3087
3088         Unreviewed, rolling out r219401.
3089
3090         This revision rolled out the previous patch, but after talking
3091         with reviewer, a rebaseline is what was needed.Rolling back in
3092         before rebaseline.
3093
3094         Reverted changeset:
3095
3096         "Unreviewed, rolling out r219379."
3097         https://bugs.webkit.org/show_bug.cgi?id=174400
3098         http://trac.webkit.org/changeset/219401
3099
3100 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3101
3102         Unreviewed, rolling out r219379.
3103
3104         This revision caused a consistent failure in the test
3105         fast/dom/Window/property-access-on-cached-window-after-frame-
3106         removed.html.
3107
3108         Reverted changeset:
3109
3110         "Remove NAVIGATOR_HWCONCURRENCY"
3111         https://bugs.webkit.org/show_bug.cgi?id=174400
3112         http://trac.webkit.org/changeset/219379
3113
3114 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3115
3116         [WPE] Use libepoxy
3117         https://bugs.webkit.org/show_bug.cgi?id=172104
3118
3119         Reviewed by Michael Catanzaro.
3120
3121         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3122         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3123
3124 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3125
3126         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3127         https://bugs.webkit.org/show_bug.cgi?id=174363
3128
3129         Reviewed by Michael Catanzaro.
3130
3131         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3132         between the GTK+ and WPE port. There's no reason for the two ports to apply
3133         different patches over same versions of GStreamer releases.
3134
3135         This aligns the two ports on this specific issue. Next we'll look into
3136         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3137         to keep these patches in a single place, avoiding duplicate files.
3138
3139         * gtk/jhbuild.modules:
3140         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3141         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3142         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3143         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3144
3145 2017-07-11  Dean Jackson  <dino@apple.com>
3146
3147         Remove NAVIGATOR_HWCONCURRENCY
3148         https://bugs.webkit.org/show_bug.cgi?id=174400
3149
3150         Reviewed by Sam Weinig.
3151
3152         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3153
3154 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3155
3156         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3157         https://bugs.webkit.org/show_bug.cgi?id=174239
3158
3159         Reviewed by Brady Eidson.
3160
3161         Create windows with specific features set and make sure those are properly reflected in the
3162         WKWindowFeatures object.
3163
3164         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3165         (resetToConsistentState):
3166         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3167         (TEST):
3168
3169 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3170
3171         Do not duplicate files when deleting directories with svn 1.9
3172         https://bugs.webkit.org/show_bug.cgi?id=174339
3173         <rdar://problem/33226781>
3174
3175         Reviewed by David Kilzer.
3176
3177         * Scripts/svn-create-patch:
3178         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3179         (generateFileList): Determine which files are deleted because they are part of a
3180         directory being deleted.
3181
3182 2017-07-11  Dean Jackson  <dino@apple.com>
3183
3184         Rolling out r219372.
3185
3186         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3187
3188 2017-07-11  Dean Jackson  <dino@apple.com>
3189
3190         Remove NAVIGATOR_HWCONCURRENCY
3191         https://bugs.webkit.org/show_bug.cgi?id=174400
3192
3193         Reviewed by Sam Weinig.
3194
3195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3196
3197 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3198
3199         Teach build workers to fetch archives from S3.
3200         https://bugs.webkit.org/show_bug.cgi?id=174384
3201
3202         Reviewed by Aakash Jain.
3203
3204         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3205         (DownloadBuiltProduct):
3206
3207 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3208
3209         Configure buildbot to transfer all archives to S3.
3210         Previously this was Mac only, but it's time to expand!
3211         https://bugs.webkit.org/show_bug.cgi?id=174378
3212         
3213         Reviewed by Aakash Jain.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3216         (BuildFactory.__init__):
3217
3218 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3219
3220         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3221         https://bugs.webkit.org/show_bug.cgi?id=174350
3222
3223         Reviewed by Xabier Rodriguez-Calvar.
3224
3225         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3226         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3227         patches are removed. The patches for gst-plugins-good are updated, removing
3228         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3229         rtpbin elements that will help with the EMEv3 development.
3230
3231         * wpe/jhbuild.modules:
3232         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3233         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3234         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3235         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3236         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3237         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3238         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3239         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3240         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3241
3242 2017-07-10  John Wilander  <wilander@apple.com>
3243
3244         Resource Load Statistics: Prune statistics in orders of importance
3245         https://bugs.webkit.org/show_bug.cgi?id=174215
3246         <rdar://problem/33164403>
3247
3248         Reviewed by Chris Dumez.
3249
3250         Nest infrastructure. Adds these functions:
3251         1. testRunner.setStatisticsLastSeen()
3252         2. setStatisticsMaxStatisticsEntries()
3253         3. setStatisticsPruneEntriesDownTo()
3254
3255         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3256         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3257         (WTR::TestRunner::setStatisticsLastSeen):
3258         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3259         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3260         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3261         * WebKitTestRunner/TestController.cpp:
3262         (WTR::TestController::setStatisticsLastSeen):
3263         (WTR::TestController::setMaxStatisticsEntries):
3264         (WTR::TestController::setPruneEntriesDownTo):
3265         * WebKitTestRunner/TestController.h:
3266         * WebKitTestRunner/TestInvocation.cpp:
3267         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3268         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3269         (WTR::TestController::setStatisticsLastSeen):
3270         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3271         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3272
3273 2017-07-03  Brian Burg  <bburg@apple.com>
3274
3275         Web Replay: remove some unused code
3276         https://bugs.webkit.org/show_bug.cgi?id=173903
3277
3278         Rubber-stamped by Joseph Pecoraro.
3279
3280         * Scripts/run-input-generator-tests: Removed.
3281         * Scripts/webkitpy/replay/__init__.py: Removed.
3282         * Scripts/webkitpy/replay/main.py: Removed.
3283
3284 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3285
3286         [WPE] Fix layout test baseline and TestExpectations hierarchy
3287         https://bugs.webkit.org/show_bug.cgi?id=174092
3288
3289         Reviewed by Michael Catanzaro.
3290
3291         Like for the GTK+ port, override the default_baseline_search_path() and
3292         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3293         Both methods operate on a short list of search paths that defaults to 'wpe' and
3294         'wk2', along with any other user-specified platform directory.
3295
3296         The test_expectations_file_position() method is overridden for testing purposes,
3297         and relevant unit tests are added.
3298
3299         * Scripts/webkitpy/port/wpe.py:
3300         (WPEPort._search_paths):
3301         (WPEPort):
3302         (WPEPort.default_baseline_search_path):
3303         (WPEPort._port_specific_expectations_files):
3304         (WPEPort.test_expectations_file_position):
3305         * Scripts/webkitpy/port/wpe_unittest.py:
3306         (WPEPortTest.test_default_baseline_search_path):
3307         (WPEPortTest):
3308         (WPEPortTest.test_port_specific_expectations_files):
3309
3310 2017-07-10  Chris Dumez  <cdumez@apple.com>
3311
3312         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3313         https://bugs.webkit.org/show_bug.cgi?id=174301
3314
3315         Reviewed by Brent Fulgham.
3316
3317         Rename some of the testRunner API for clarity and to better match what it calls
3318         internally.
3319
3320         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3321         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3322         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
3323         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
3324         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3325         * WebKitTestRunner/TestController.cpp:
3326         (WTR::TestController::statisticsUpdateCookiePartitioning):
3327         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3328         * WebKitTestRunner/TestController.h:
3329         * WebKitTestRunner/TestInvocation.cpp:
3330         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3331         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3332         (WTR::TestController::statisticsUpdateCookiePartitioning):
3333         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3334
3335 2017-07-10  Charlie Turner  <cturner@igalia.com>
3336
3337         [GStreamer] Live twitch.tv videos do not play
3338         https://bugs.webkit.org/show_bug.cgi?id=174222
3339
3340         Reviewed by Michael Catanzaro.
3341
3342         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
3343         fixes videos not playing on twitch.tv.
3344
3345         * gtk/jhbuild.modules:
3346
3347 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
3348
3349         Add WebGL2 configuration option to build-webkit
3350         https://bugs.webkit.org/show_bug.cgi?id=174251
3351
3352         Reviewed by Michael Catanzaro.
3353
3354         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
3355         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
3356         is marked as enabled for the Apple Cocoa ports.
3357
3358 2017-07-08  Chris Dumez  <cdumez@apple.com>
3359
3360         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
3361         https://bugs.webkit.org/show_bug.cgi?id=174290
3362
3363         Reviewed by Brent Fulgham.
3364
3365         Rename testRunner API to match the new internal API names.
3366
3367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3369         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3370         (WTR::TestRunner::statisticsSubmitTelemetry):
3371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3372         * WebKitTestRunner/TestController.cpp:
3373         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3374         (WTR::TestController::statisticsSubmitTelemetry):
3375         * WebKitTestRunner/TestController.h:
3376         * WebKitTestRunner/TestInvocation.cpp:
3377         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3378         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3379         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3380         (WTR::TestController::statisticsSubmitTelemetry):
3381
3382 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3383
3384         Drop NOSNIFF compile flag
3385         https://bugs.webkit.org/show_bug.cgi?id=174289
3386
3387         Reviewed by Michael Catanzaro.
3388
3389         * Scripts/webkitperl/FeatureList.pm:
3390         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3391
3392 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3393
3394         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
3395         https://bugs.webkit.org/show_bug.cgi?id=174219
3396         <rdar://problem/32083177>
3397
3398         Reviewed by Ryosuke Niwa.
3399
3400         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
3401         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
3402         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
3403         place.
3404
3405         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
3406         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
3407         no action is taken when dropping.
3408
3409         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
3410         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3411         (TestWebKitAPI::TEST):
3412         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3413         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3414         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
3415         (-[MockDragDropSession allowsMoveOperation]):
3416         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
3417         (-[MockDataInteractionSession initWithWindow:allowMove:]):
3418         (-[DataInteractionSimulator initWithWebView:]):
3419         (-[DataInteractionSimulator runFrom:to:]):
3420         (-[DataInteractionSimulator _advanceProgress]):
3421         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
3422         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
3423         (-[MockDataInteractionSession initWithWindow:]): Deleted.
3424
3425 2017-07-07  Commit Queue  <commit-queue@webkit.org>
3426
3427         Unreviewed, rolling out r219238, r219239, and r219241.
3428         https://bugs.webkit.org/show_bug.cgi?id=174265
3429
3430         "fast/workers/dedicated-worker-lifecycle.html is flaky"
3431         (Requested by yusukesuzuki on #webkit).
3432
3433         Reverted changesets:
3434
3435         "[WTF] Implement WTF::ThreadGroup"
3436         https://bugs.webkit.org/show_bug.cgi?id=174081
3437         http://trac.webkit.org/changeset/219238
3438
3439         "Unreviewed, build fix after r219238"
3440         https://bugs.webkit.org/show_bug.cgi?id=174081
3441         http://trac.webkit.org/changeset/219239
3442
3443         "Unreviewed, CLoop build fix after r219238"
3444         https://bugs.webkit.org/show_bug.cgi?id=174081
3445         http://trac.webkit.org/changeset/219241
3446
3447 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3448
3449         [GTK][WPE] Enable X-Content-Type-Options: nosniff
3450         https://bugs.webkit.org/show_bug.cgi?id=174250
3451
3452         Reviewed by Carlos Alberto Lopez Perez.
3453
3454         * Scripts/webkitperl/FeatureList.pm:
3455
3456 2017-07-07  Charlie Turner  <cturner@igalia.com>
3457         [GStreamer] vid.me videos do not play
3458         https://bugs.webkit.org/show_bug.cgi?id=172240
3459
3460         Reviewed by Xabier Rodriguez-Calvar.
3461
3462         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3463         have the existing libsoup build against GNOME to avoid header drift
3464         against GStreamer's linked Soup library.
3465
3466         * gtk/jhbuild.modules:
3467
3468 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3469
3470         Write a support script to enable buildbot to upload to S3
3471         https://bugs.webkit.org/show_bug.cgi?id=174196
3472         
3473         Reviewed by Stephanie Lewis.
3474
3475         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
3476         (uploadToS3):
3477         (archiveExists):
3478
3479 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3480
3481         Enabling uploading archives to S3.
3482         https://bugs.webkit.org/show_bug.cgi?id=174198
3483         
3484         Reviewed by Stephanie Lewis.
3485
3486         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3487         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3488         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3489         (TransferToS3): Transfer full and minified archives to S3
3490
3491 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3492
3493         [WTF] Implement WTF::ThreadGroup
3494         https://bugs.webkit.org/show_bug.cgi?id=174081
3495
3496         Reviewed by Mark Lam.
3497
3498         Add WTF::ThreadGroup tests.
3499
3500         * TestWebKitAPI/CMakeLists.txt:
3501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3502         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3503         (TestWebKitAPI::TEST):
3504
3505 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3506
3507         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3508         https://bugs.webkit.org/show_bug.cgi?id=174150
3509
3510         Reviewed by Mark Lam.
3511
3512         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3513         (TestWebKitAPI::TEST):
3514         * TestWebKitAPI/TestsController.cpp:
3515         (TestWebKitAPI::TestsController::TestsController):
3516
3517 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3518
3519         Enabling uploading archives to S3.
3520         https://bugs.webkit.org/show_bug.cgi?id=174198
3521         
3522         Reviewed by Lucas Forschler.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3525         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3526         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3527         (TransferToS3): Transfer full and minified archives to S3
3528
3529 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3530
3531         [GTK][WPE] kill-old-process should kill more webkit related process
3532         https://bugs.webkit.org/show_bug.cgi?id=174220
3533
3534         Reviewed by Michael Catanzaro.
3535
3536         Generate list of possible webkit-related process names and add
3537         them to the list of process to kill.
3538         Also update the possible system related process for GTK+/WPE.
3539
3540         * BuildSlaveSupport/kill-old-processes:
3541         (listAllWebKitPrograms):
3542         (main):
3543
3544 2017-07-06  Chris Dumez  <cdumez@apple.com>
3545
3546         FileMonitor should not be ref counted
3547         https://bugs.webkit.org/show_bug.cgi?id=174166
3548
3549         Reviewed by Brent Fulgham.
3550
3551         Update the API tests to reflect the API change.
3552
3553         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3554         (TestWebKitAPI::TEST_F):
3555
3556 2017-07-06  Commit Queue  <commit-queue@webkit.org>
3557
3558         Unreviewed, rolling out r219194.
3559         https://bugs.webkit.org/show_bug.cgi?id=174207
3560
3561         it broke some layout tests (Requested by clopez on #webkit).
3562
3563         Reverted changeset:
3564
3565         "[GStreamer] vid.me videos do not play"
3566         https://bugs.webkit.org/show_bug.cgi?id=172240
3567         http://trac.webkit.org/changeset/219194
3568
3569 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3570
3571         Unreviewed, rolling out r219178.
3572
3573         This caused a consistent failure with the API test
3574         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3575
3576         Reverted changeset:
3577
3578         "[WTF] Clean up StringStatics.cpp by using
3579         LazyNeverDestroyed<> for Atoms"
3580         https://bugs.webkit.org/show_bug.cgi?id=174150
3581         http://trac.webkit.org/changeset/219178
3582
3583 2017-07-06  Alicia Boya García  <aboya@igalia.com>
3584
3585         Add CWD to Perl library path (no longer the default since 5.26.0)
3586         https://bugs.webkit.org/show_bug.cgi?id=174200
3587
3588         Reviewed by Michael Catanzaro.
3589
3590         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3591         (SetupGitClone._get_username_and_email):
3592
3593 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3594
3595         Unreviewed, update my email address.
3596
3597         * Scripts/webkitpy/common/config/contributors.json:
3598
3599 2017-07-06  Charlie Turner  <cturner@igalia.com>
3600         [GStreamer] vid.me videos do not play
3601         https://bugs.webkit.org/show_bug.cgi?id=172240
3602
3603         Reviewed by Xabier Rodriguez-Calvar.
3604
3605         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3606         have the existing libsoup build against GNOME to avoid header drift
3607         against GStreamer's linked Soup library.
3608
3609         * gtk/jhbuild.modules:
3610
3611 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3612
3613         [WTF] Move SoftLinking.h into WTF
3614         https://bugs.webkit.org/show_bug.cgi?id=174000
3615
3616         Reviewed by Alex Christensen.
3617
3618         * DumpRenderTree/mac/TestRunnerMac.mm: