baaa6605d06c9239454daa1dab3195e47c0968ce
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2
3         [ews] Reset simctl states on reboot
4         https://bugs.webkit.org/show_bug.cgi?id=196260
5
6         Rubber-stamped by Aakash Jain.
7
8         * EWSTools/start-queue-mac.sh:
9
10 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
11
12         [ews-build] Use PostgreSQL for ews-build database
13         https://bugs.webkit.org/show_bug.cgi?id=196229
14
15         Reviewed by Lucas Forschler.
16
17         * BuildSlaveSupport/ews-build/master.cfg:
18
19 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
20
21         [ews-build] Get master_hostname dynamically in master.cfg
22         https://bugs.webkit.org/show_bug.cgi?id=196255
23
24         Reviewed by Lucas Forschler.
25
26         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
27         send events data in test mode.
28
29 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
30
31         [ews-app] Set db_constraint to False for Foreign Keys
32         https://bugs.webkit.org/show_bug.cgi?id=196252
33
34         Reviewed by Lucas Forschler.
35
36         * BuildSlaveSupport/ews-app/ews/models/build.py:
37         * BuildSlaveSupport/ews-app/ews/models/step.py:
38
39 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
40
41         [ews-build] is_test_mode_enabled should default to True
42         https://bugs.webkit.org/show_bug.cgi?id=196248
43
44         Reviewed by Lucas Forschler.
45
46         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
47
48 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
49
50         [ews-app] Add webkitperl to ENABLED_QUEUES
51         https://bugs.webkit.org/show_bug.cgi?id=196253
52
53         Reviewed by Lucas Forschler.
54
55         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
56
57 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
58
59         Address NSWindow sometimes using WebKitTestRunnerEvent too early
60         https://bugs.webkit.org/show_bug.cgi?id=196211
61         rdar://problem/49110552
62
63         Reviewed by Tim Horton.
64
65         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
66         Make sure that EventSenderProxy always exists when running tests. We used to create
67         it when resetting before the first test, which is a bit too late.
68
69         * WebKitTestRunner/TestController.h:
70         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
71         (WTR::TestController::platformCreateWebView):
72         (WTR::TestController::platformCreateOtherPage):
73         (WTR::TestController::finishCreatingPlatformWebView):
74         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
75         (WTR::PlatformWebView::PlatformWebView):
76         Moved some code that made NSWindow use NSEvent during web view creation. We may
77         need to move more if some other case us found, but this is enough for now.
78
79 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
80
81         Unreviewed. Fix typo in GLib geolocation API after r243285.
82
83         gelocation -> geolocation.
84
85         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
86         (testGeolocationManagerWatchPosition):
87
88 2019-03-25  Alex Christensen  <achristensen@webkit.org>
89
90         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
91         https://bugs.webkit.org/show_bug.cgi?id=196213
92
93         Reviewed by Geoff Garen.
94
95         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
96         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
97         (credentialWithIdentityAndKeychainPath):
98         (-[ChallengeDelegate webView:didFinishNavigation:]):
99         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
100         (TestWebKitAPI::TEST):
101
102 2019-03-25  Alex Christensen  <achristensen@webkit.org>
103
104         Expected shouldn't assume its contained types are copyable
105         https://bugs.webkit.org/show_bug.cgi?id=195986
106
107         Reviewed by JF Bastien.
108
109         * TestWebKitAPI/Tests/WTF/Expected.cpp:
110         (TestWebKitAPI::NonCopyable::operator== const):
111         (TestWebKitAPI::NonCopyable::operator!= const):
112         (TestWebKitAPI::TEST):
113
114 2019-03-25  Tim Horton  <timothy_horton@apple.com>
115
116         Remove some now-unnecessary dynamic class lookup
117         https://bugs.webkit.org/show_bug.cgi?id=196237
118
119         Reviewed by Simon Fraser.
120
121         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
122         (makeRequest):
123         (TEST):
124
125 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
126
127         Unreviewed, rolling out r243450.
128
129         AppleWin and WinCairo port builds get broken.
130
131         Reverted changeset:
132
133         "Add test for fix of #196095"
134         https://bugs.webkit.org/show_bug.cgi?id=196097
135         https://trac.webkit.org/changeset/243450
136
137 2019-03-25  Commit Queue  <commit-queue@webkit.org>
138
139         Unreviewed, rolling out r243465.
140         https://bugs.webkit.org/show_bug.cgi?id=196226
141
142         the test doesn't build (Requested by thorton on #webkit).
143
144         Reverted changeset:
145
146         "Do not terminate the NetworkProcess if a third party
147         application sends a NSCredential with a SecIdentityRef"
148         https://bugs.webkit.org/show_bug.cgi?id=196213
149         https://trac.webkit.org/changeset/243465
150
151 2019-03-25  Alex Christensen  <achristensen@webkit.org>
152
153         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
154         https://bugs.webkit.org/show_bug.cgi?id=196213
155
156         Reviewed by Geoff Garen.
157
158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
159         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
160         (credentialWithIdentityAndKeychainPath):
161         (-[ChallengeDelegate webView:didFinishNavigation:]):
162         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
163         (TestWebKitAPI::TEST):
164
165 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
166
167         [ews-build] Gracefully handle missing patch_id in events
168         https://bugs.webkit.org/show_bug.cgi?id=196216
169
170         Reviewed by Lucas Forschler.
171
172         * BuildSlaveSupport/ews-build/events.py:
173
174 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
175
176         [ews-build] use lz4 compression for improving buildbot performance
177         https://bugs.webkit.org/show_bug.cgi?id=196155
178
179         Reviewed by Lucas Forschler.
180
181         * BuildSlaveSupport/ews-build/master.cfg:
182
183 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
184
185         Pull some API testing helper methods out of TestWKWebView
186         https://bugs.webkit.org/show_bug.cgi?id=196212
187
188         Reviewed by Tim Horton.
189
190         Refactor some more API testing utility methods, so that they can be used in
191         tests that do not use TestWKWebView.
192
193         * TestWebKitAPI/cocoa/TestWKWebView.h:
194         * TestWebKitAPI/cocoa/TestWKWebView.mm:
195         (-[WKWebView loadTestPageNamed:]):
196         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
197         (-[WKWebView synchronouslyLoadHTMLString:]):
198         (-[WKWebView synchronouslyLoadTestPageNamed:]):
199         (-[TestWKWebView loadTestPageNamed:]): Deleted.
200         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
201         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
202         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
203
204 2019-03-25  Jer Noble  <jer.noble@apple.com>
205
206         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
207         https://bugs.webkit.org/show_bug.cgi?id=196097
208
209         Reviewed by Eric Carlson.
210
211         Drive-by bug fix: allow tests to play audio without a user gesture by default.
212
213         * DumpRenderTree/mac/DumpRenderTree.mm:
214         (resetWebPreferencesToConsistentValues):
215         * WebKitTestRunner/TestController.cpp:
216         (WTR::TestController::resetPreferencesToConsistentValues):
217
218 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
219
220         Pull IPadUserInterfaceSwizzler out into a separate header file
221         https://bugs.webkit.org/show_bug.cgi?id=196193
222
223         Reviewed by Anders Carlsson.
224
225         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
226         be used in other API tests.
227
228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
229         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
230         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
231         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
232         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
233         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
234         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
235
236 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
237
238         Remove NavigatorContentUtils in WebCore/Modules
239         https://bugs.webkit.org/show_bug.cgi?id=196070
240
241         Reviewed by Alex Christensen.
242
243         NavigatorContentUtils was to support the custom scheme spec [1].
244         However, in WebKit side, no port has supported the feature in
245         WebKit layer after EFL port was removed. So there has been the
246         only IDL implementation of the NavigatorContentUtils in WebCore.
247         So we don't need to keep the implementation in WebCore anymore.
248
249         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
250
251         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
252
253 2019-03-24  Andy Estes  <aestes@apple.com>
254
255         [watchOS] Remove unused Proximity Networking code
256         https://bugs.webkit.org/show_bug.cgi?id=196188
257
258         Reviewed by Tim Horton.
259
260         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
261         (TEST):
262
263 2019-03-23  Keith Miller  <keith_miller@apple.com>
264
265         Refactor clz/ctz and fix getLSBSet.
266         https://bugs.webkit.org/show_bug.cgi?id=196162
267
268         Reviewed by Saam Barati.
269
270         Add tests for clz, ctz, getLSBSet, and getMSBSet.
271
272         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
273         (TestWebKitAPI::TEST):
274
275 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
276
277         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
278         https://bugs.webkit.org/show_bug.cgi?id=196143
279
280         Reviewed by Michael Catanzaro.
281
282         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
283         directories.
284
285         * Scripts/webkitpy/style/checkers/cpp.py:
286         (check_identifier_name_in_declaration):
287         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
288         (WebKitStyleTest.test_names):
289
290 2019-03-22  Philippe Normand  <pnormand@igalia.com>
291
292         [Flatpak] Manifest expanding fails for qt WPE extension
293         https://bugs.webkit.org/show_bug.cgi?id=196148
294
295         Reviewed by Alex Christensen.
296
297         * flatpak/flatpakutils.py:
298         (expand_submodules_recurse): The last recurse manifest expand
299         iteration might lead to a single module so take it into account
300         and don't try to recurse further.
301
302 2019-03-22  Chris Dumez  <cdumez@apple.com>
303
304         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
305         https://bugs.webkit.org/show_bug.cgi?id=195348
306         <rdar://problem/48622090>
307
308         Reviewed by Alex Christensen.
309
310         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
311         to NO when test.options().shouldIgnoreMetaViewport is false.
312
313         * WebKitTestRunner/ios/TestControllerIOS.mm:
314         (WTR::TestController::platformConfigureViewForTest):
315
316 2019-03-22  Chris Dumez  <cdumez@apple.com>
317
318         Prewarmed processes should be usable with any website data store
319         https://bugs.webkit.org/show_bug.cgi?id=196104
320
321         Reviewed by Alex Christensen.
322
323         Add API test coverage.
324
325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
326         (runInitialWarmedProcessUsedTest):
327         (TEST):
328
329 2019-03-22  David Kilzer  <ddkilzer@apple.com>
330
331         Back out local changes to Alex's Subversion working directory
332
333         They were accidentally committed.
334
335         * Scripts/webkitpy/common/system/abstractexecutive.py:
336         (AbstractExecutive.wait_newest):
337         * Scripts/webkitpy/common/system/executive.py:
338         (Executive.running_pids):
339         * Scripts/webkitpy/common/system/executive_mock.py:
340         (MockExecutive.running_pids):
341         * Scripts/webkitpy/common/system/executive_unittest.py:
342         (ExecutiveTest.serial_test_running_pids):
343         * Scripts/webkitpy/port/darwin.py:
344         (DarwinPort.check_for_leaks):
345         * Scripts/webkitpy/port/leakdetector.py:
346         (LeakDetector.check_for_leaks):
347         - This was the hack attached to Bug 193772.
348
349         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
350         (+[WebKitTestRunnerEvent mouseLocation]):
351         - This works around a crash on an internal build.
352
353 2019-03-22  Tim Horton  <timothy_horton@apple.com>
354
355         Fix the build after r243354
356         https://bugs.webkit.org/show_bug.cgi?id=196138
357         <rdar://problem/49145951>
358
359         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
360         (TEST):
361         * TestWebKitAPI/ios/UIKitSPI.h:
362
363 2019-03-21  Tim Horton  <timothy_horton@apple.com>
364
365         Adopt UIWKDocumentContext
366         https://bugs.webkit.org/show_bug.cgi?id=196040
367         <rdar://problem/48642440>
368
369         Reviewed by Ryosuke Niwa.
370
371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
372         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
373         (makeRequest):
374         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
375         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
376         (applyStyle):
377         (TEST):
378         Add tests for UIWKDocumentContext.
379
380         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
381         (TEST):
382         (recursiveFindWKContentView): Deleted.
383         * TestWebKitAPI/cocoa/TestWKWebView.h:
384         * TestWebKitAPI/cocoa/TestWKWebView.mm:
385         (recursiveFindWKContentView):
386         (-[TestWKWebView wkContentView]):
387         * TestWebKitAPI/ios/UIKitSPI.h:
388         Share the WKContentView finding code between tests.
389
390 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
391
392         [iOS WK2] Turn on async overflow scrolling by default
393         https://bugs.webkit.org/show_bug.cgi?id=196011
394         rdar://problem/48453859
395
396         Reviewed by Antti Koivisto.
397         
398         Explicitly turn off the async overflow scrolling internal feature for tests by default,
399         since so many basic layout tests have different results when compositing is triggered for
400         overflow.
401         
402         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
403
404         * WebKitTestRunner/TestController.cpp:
405         (WTR::TestController::resetPreferencesToConsistentValues):
406
407 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
408
409         [ews-build] Retry API test in case of failures
410         https://bugs.webkit.org/show_bug.cgi?id=196004
411
412         Reviewed by Lucas Forschler.
413
414         * BuildSlaveSupport/ews-build/steps.py:
415         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
416         (CompileWebKitToT.doStepIf): Ditto.
417         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
418         (ReRunAPITests): Re-run API tests.
419         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
420         (RunAPITestsWithoutPatch): Run API tests without patch.
421         (RunAPITestsWithoutPatch.doStepIf):
422         (RunAPITestsWithoutPatch.hideStepIf):
423         (RunAPITestsWithoutPatch.evaluateCommand):
424         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
425         (AnalyzeAPITestsResults.start):
426         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
427         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
428         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
429         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
430
431 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
432
433         [ews-build] Update queues configurations
434         https://bugs.webkit.org/show_bug.cgi?id=196074
435
436         Reviewed by Dewei Zhu.
437
438         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
439         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
440
441 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
444         https://bugs.webkit.org/show_bug.cgi?id=195680
445         <rdar://problem/48903534>
446
447         Unreviewed infrastructure fix.
448
449         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
450         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
451
452 2019-03-21  Andy Estes  <aestes@apple.com>
453
454         [iOS] Apple Pay should be available in documents with no user agent scripts
455         https://bugs.webkit.org/show_bug.cgi?id=196061
456         <rdar://problem/48649391>
457
458         Reviewed by Brady Eidson.
459
460         Added API tests and related infrastructure.
461
462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
463         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
464         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
465         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
466         (TestWebKitAPI::TEST):
467         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
468         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
469         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
470         * TestWebKitAPI/cocoa/TestProtocol.mm:
471         (-[TestProtocol startLoading]):
472         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
473         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
474         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
475         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
476
477 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
478
479         REGRESSSION (r243297): webkitpy tests broken
480         https://bugs.webkit.org/show_bug.cgi?id=196108
481
482         Reviewed by Aakash Jain.
483
484         r243297 updated contributors.json, which broke a few unit tests.
485
486         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
487         (IRCCommandTest.test_whois):
488         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
489
490 2019-03-21  Chris Dumez  <cdumez@apple.com>
491
492         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
493         https://bugs.webkit.org/show_bug.cgi?id=196041
494         <rdar://problem/49083230>
495
496         Reviewed by Alex Christensen.
497
498         Add API test coverage.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
501         (TEST):
502
503 2019-03-21  Alex Christensen  <achristensen@webkit.org>
504
505         Add SPI to inform applications of WKContentRuleList actions
506         https://bugs.webkit.org/show_bug.cgi?id=195965
507         <rdar://problem/42664365>
508
509         Reviewed by Geoff Garen.
510
511         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
512         (TestWebKitAPI::allActionsForResourceLoad):
513         (TestWebKitAPI::testRequest):
514         (TestWebKitAPI::TEST_F):
515         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
516         (Notification::description):
517         (Notification::operator== const):
518         (toVector):
519         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
520         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
521         (makeContentRuleList):
522         (TEST):
523         (makeWarnContentRuleList): Deleted.
524
525 2019-03-21  Timothy Hatcher  <timothy@apple.com>
526
527         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
528         https://bugs.webkit.org/show_bug.cgi?id=196088
529
530         Reviewed by Brian Burg.
531
532         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
533         Support checks when only one platform is specified. Also deprecate macosx() and
534         force the use of macos() instead.
535
536         * Scripts/webkitpy/style/checkers/cpp.py:
537         (check_min_versions_of_wk_api_available):
538         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
539         (WebKitStyleTest.test_min_versions_of_wk_api_available):
540
541 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
542
543         Update status inactive committers' status to 'contributor'.
544
545         * Scripts/webkitpy/common/config/contributors.json:
546
547 2019-03-21  Xan Lopez  <xan@igalia.com>
548
549         [JSC][x86] Drop support for x87 floating point
550         https://bugs.webkit.org/show_bug.cgi?id=194853
551
552         Reviewed by Don Olmstead.
553
554         Force SSE2 on x86/32bit builds.
555
556         * Scripts/webkitdirs.pm:
557         (generateBuildSystemFromCMakeProject):
558
559 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
560
561         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
562         https://bugs.webkit.org/show_bug.cgi?id=196073
563
564         Reviewed by Michael Catanzaro.
565
566         Add test cases to check functions and constructors with no arguments but receiving user data.
567
568         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
569         (checkUserData):
570         (testJSCFunction):
571         (fooCreateWithUserData):
572         (testJSCClass):
573
574 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
575
576         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
577
578         Add g_assert_cmpfloat_with_epsilon macro if not defined.
579
580         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
581
582 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
583
584         [GTK][WPE] Add API to provide geolocation information
585         https://bugs.webkit.org/show_bug.cgi?id=195940
586
587         Reviewed by Michael Catanzaro.
588
589         Add a new test to check the new API.
590
591         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
592         (testGeolocationManagerCurrentPosition):
593         (testGeolocationManagerWatchPosition):
594         (beforeAll):
595         (afterAll):
596         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
597         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
598         (beforeAll): Ditto.
599         * TestWebKitAPI/glib/CMakeLists.txt:
600
601 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
602
603         [GLib] Returning G_TYPE_OBJECT from a method does not work
604         https://bugs.webkit.org/show_bug.cgi?id=195574
605
606         Reviewed by Michael Catanzaro.
607
608         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
609
610         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
611         (getGFile):
612         (getParent):
613         (createGString):
614         (getGString):
615         (getGStringCopyWillRaise):
616         (getGStringCopy):
617         (getGStringStr):
618         (getGStringLen):
619         (freeGString):
620         (testJSCClass):
621
622 2019-03-20  Saam Barati  <sbarati@apple.com>
623
624         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
625         https://bugs.webkit.org/show_bug.cgi?id=195721
626
627         Reviewed by Filip Pizlo.
628
629         * Scripts/run-javascriptcore-tests:
630
631 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
632
633         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
634         https://bugs.webkit.org/show_bug.cgi?id=196049
635
636         Reviewed by Tim Horton.
637
638         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
639         overflow scrolling in general, so rename it.
640
641         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
642
643 2019-03-20  Daniel Bates  <dabates@apple.com>
644
645         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
646         https://bugs.webkit.org/show_bug.cgi?id=196031
647         <rdar://problem/49078172>
648
649         Reviewed by Tim Horton.
650
651         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
652         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
653         same code path used when the Done button is pressed to dismiss the <select> picker.
654
655         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
656         (TestWebKitAPI::TEST):
657
658 2019-03-20  Chris Dumez  <cdumez@apple.com>
659
660         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
661         https://bugs.webkit.org/show_bug.cgi?id=196029
662         <rdar://problem/48954651>
663
664         Reviewed by Tim Horton.
665
666         Add API test coverage.
667
668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
669
670 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
671
672         [ews-build] Improve failure summary string for ApplyPatch step
673         https://bugs.webkit.org/show_bug.cgi?id=195995
674
675         Reviewed by Alexey Proskuryakov.
676
677         * BuildSlaveSupport/ews-build/steps.py:
678         (ApplyPatch.getResultSummary): Override getResultSummary.
679
680 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
681
682         AX: Implement support for new meter ARIA role
683         https://bugs.webkit.org/show_bug.cgi?id=195966
684
685         Reviewed by Chris Fleizach.
686
687         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
688         to AXLevelIndicator.
689
690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
691
692 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
693
694         [WebAuthN] Implement FIDO AppID extension
695         https://bugs.webkit.org/show_bug.cgi?id=143491
696         <rdar://problem/48298273>
697
698         Reviewed by Brent Fulgham.
699
700         Add a test that covers the new flag of convertToU2fSignCommand.
701
702         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
703         (TestWebKitAPI::TEST):
704         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
705         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
706         (TestWebKitAPI::TEST):
707
708 2019-03-19  Keith Rollin  <krollin@apple.com>
709
710         Add support for more platforms to generate-xcfilelists
711         https://bugs.webkit.org/show_bug.cgi?id=195977
712
713         Reviewed by Alexey Proskuryakov.
714
715         generate-xcfilelists incorrectly complains when involved with building
716         WebKit for iphonesimulator:
717
718             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
719             …
720             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
721
722         Address this by teaching generate-xcfilelists about more platforms.
723
724         * Scripts/generate-xcfilelists:
725
726 2019-03-19  John Wilander  <wilander@apple.com>
727
728         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
729         https://bugs.webkit.org/show_bug.cgi?id=195923
730         <rdar://problem/49001272>
731
732         Reviewed by Alex Christensen.
733
734         This patch does the following to the TestRunner:
735         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
736         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
737         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
738
739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
741         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
743         * WebKitTestRunner/TestController.cpp:
744         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
745         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
746         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
747         * WebKitTestRunner/TestController.h:
748         * WebKitTestRunner/TestInvocation.cpp:
749         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
750
751 2019-03-19  Christopher Reid  <chris.reid@sony.com>
752
753         [CMake] Support more clang and gcc sanitizers
754         https://bugs.webkit.org/show_bug.cgi?id=195956
755
756         Reviewed by Michael Catanzaro.
757
758         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
759
760 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
761
762         [ews-build] Improve summary for PrintConfiguration step
763         https://bugs.webkit.org/show_bug.cgi?id=195945
764
765         Reviewed by Lucas Forschler.
766
767         * BuildSlaveSupport/ews-build/steps.py:
768         (PrintConfiguration.getResultSummary): Override getResultSummary.
769
770 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
771
772         [ews-build] Improve summary for CheckOutSource step
773         https://bugs.webkit.org/show_bug.cgi?id=195963
774
775         Reviewed by Lucas Forschler.
776
777         * BuildSlaveSupport/ews-build/steps.py:
778         (CheckOutSource.getResultSummary):
779
780 2019-03-19  Daniel Bates  <dabates@apple.com>
781
782         [iOS] Focus not preserved when switching between tabs
783         https://bugs.webkit.org/show_bug.cgi?id=195820
784         <rdar://problem/43614450>
785
786         Reviewed by Brent Fulgham.
787
788         Add tests to ensure that we restore focus when resigning and becoming first responder.
789
790         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
791         (TestWebKitAPI::TEST):
792
793 2019-03-19  Alex Christensen  <achristensen@webkit.org>
794
795         Make WTFLogChannelState and WTFLogLevel enum classes
796         https://bugs.webkit.org/show_bug.cgi?id=195904
797
798         Reviewed by Eric Carlson.
799
800         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
801         (TestWebKitAPI::TEST_F):
802
803 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
804
805         [GStreamer][EME] Backported mssdemux protection data crash fix
806         https://bugs.webkit.org/show_bug.cgi?id=195918
807
808         Reviewed by Philippe Normand.
809
810         * gstreamer/jhbuild.modules:
811         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
812
813 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
814
815         Unreviewed, rolling out r243132.
816
817         Broke GTK build
818
819         Reverted changeset:
820
821         "Make WTFLogChannelState and WTFLogLevel enum classes"
822         https://bugs.webkit.org/show_bug.cgi?id=195904
823         https://trac.webkit.org/changeset/243132
824
825 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
826
827         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
828
829         * Scripts/webkitdirs.pm:
830         (builtDylibPathForName): Adjust the shared library name that's changed
831         with the API version bump in r243073.
832
833 2019-03-18  Alex Christensen  <achristensen@webkit.org>
834
835         Make WTFLogChannelState and WTFLogLevel enum classes
836         https://bugs.webkit.org/show_bug.cgi?id=195904
837
838         Reviewed by Eric Carlson.
839
840         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
841         (TestWebKitAPI::TEST_F):
842
843 2019-03-18  Alex Christensen  <achristensen@webkit.org>
844
845         Disable flaky test added in r2431100
846         https://webkit.org/b/195785
847
848         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
849         (TestWebKitAPI::TEST):
850         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
851
852 2019-03-18  Timothy Hatcher  <timothy@apple.com>
853
854         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
855         https://bugs.webkit.org/show_bug.cgi?id=195916
856
857         Reviewed by Tim Horton.
858
859         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
860         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
861
862 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
863
864         Add a secondary e-mail address for Fujii Hironori to make tools happier.
865
866         * Scripts/webkitpy/common/config/contributors.json:
867
868 2019-03-18  Alex Christensen  <achristensen@webkit.org>
869
870         Implement DownloadMonitor to prevent long-running slow downloads from background apps
871         https://bugs.webkit.org/show_bug.cgi?id=195785
872
873         Reviewed by Geoffrey Garen.
874
875         * TestWebKitAPI/TCPServer.cpp: Added.
876         (TestWebKitAPI::TCPServer::TCPServer):
877         (TestWebKitAPI::TCPServer::~TCPServer):
878         (TestWebKitAPI::TCPServer::socketBindListen):
879         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
880         * TestWebKitAPI/TCPServer.h: Added.
881         (TestWebKitAPI::TCPServer::port const):
882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
883         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
884         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
885         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
886         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
887         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
888         (TestWebKitAPI::respondSlowly):
889         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
890         (TestWebKitAPI::downloadAtRate):
891         (TestWebKitAPI::TEST):
892
893 2019-03-18  Saam Barati  <sbarati@apple.com>
894
895         Add a plan file for JetStream 2
896         https://bugs.webkit.org/show_bug.cgi?id=190734
897
898         Reviewed by Mark Lam.
899
900         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
901
902 2019-03-18  Chris Dumez  <cdumez@apple.com>
903
904         Delay WebProcess launch until a load is triggered in a Web view
905         https://bugs.webkit.org/show_bug.cgi?id=195758
906         <rdar://problem/48126013>
907
908         Reviewed by Geoff Garen.
909
910         Add API test coverage. Also update some existing API tests to not expect
911         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
912
913         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
914         (TestWebKitAPI::TEST):
915         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
918         (TEST):
919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
920         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
921         (TEST):
922         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
923         (TEST):
924         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
925
926 2019-03-18  Xan Lopez  <xan@igalia.com>
927
928         [CMake] Prevent potential warning when determining $architecture
929         https://bugs.webkit.org/show_bug.cgi?id=195891
930
931         Reviewed by Michael Catanzaro.
932
933         It's possible for generateBuildSystemForCMakeProject to be called
934         before determineArchitecture() is ever called. This will make the
935         first eq check with $architecture to be bogus (and print a
936         warning). Change that to an eq check with architecture(), which
937         implicitly calls determineArchitecture() if needed, and change all
938         the other similar cases in the method in the same way to prevent
939         future bugs like this one.
940
941         * Scripts/webkitdirs.pm:
942         (generateBuildSystemFromCMakeProject):
943
944 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
945
946         [WPE] Tarballs generated with “make dist” cannot build documentation
947         https://bugs.webkit.org/show_bug.cgi?id=195885
948
949         Reviewed by Carlos Garcia Campos.
950
951         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
952
953 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
954
955         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
956         https://bugs.webkit.org/show_bug.cgi?id=195883
957
958         Reviewed by Carlos Garcia Campos.
959
960         * gtkdoc/gtkdoc.py:
961         (GTKDoc._run_command): When commands fail to run, include the full command line for
962         the program invocation and the output it has generated on the standard error stream.
963
964 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
965
966         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
967         https://bugs.webkit.org/show_bug.cgi?id=195786
968
969         Reviewed by Philippe Normand.
970
971         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
972         * wpe/jhbuild.modules: Ditto.
973
974 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-build] Don't run clean builds on EWS builders
977         https://bugs.webkit.org/show_bug.cgi?id=195851
978
979         Reviewed by Geoffrey Garen.
980
981         * BuildSlaveSupport/ews-build/factories.py:
982
983 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
984
985         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
986         https://bugs.webkit.org/show_bug.cgi?id=195849
987
988         Reviewed by Chris Dumez.
989
990         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
991
992         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
993         (runWebsiteDataStoreCustomPaths):
994
995 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
996
997         webkitpy: Upload test results
998         https://bugs.webkit.org/show_bug.cgi?id=195755
999         <rdar://problem/48896182>
1000
1001         Reviewed by Aakash Jain.
1002
1003         Establish a new format for uploading results that is not tied to layout tests, apply
1004         that format to webkitpy tests.
1005
1006         * Scripts/webkitpy/common/checkout/scm/git.py:
1007         (Git.native_branch): Return what branch the current checkout is on.
1008         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1009         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1010         * Scripts/webkitpy/common/checkout/scm/svn.py:
1011         (SVN.native_branch): Ditto.
1012         * Scripts/webkitpy/common/system/platforminfo.py:
1013         (PlatformInfo.build_version): Return a build version for Mac.
1014         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1015         (MockPlatformInfo.__init__):
1016         (MockPlatformInfo.build_version):
1017         * Scripts/webkitpy/results: Added.
1018         * Scripts/webkitpy/results/__init__.py: Added.
1019         * Scripts/webkitpy/results/options.py: Added.
1020         (upload_options): OptParse list for upload options.
1021         * Scripts/webkitpy/results/upload.py: Added.
1022         (Upload): Class which enforces the upload format expected by the results server.
1023         (Upload.Expectations):
1024         (Upload.create_configuration):
1025         (Upload.create_commit):
1026         (Upload.create_details):
1027         (Upload.create_run_stats):
1028         (Upload.create_test_result):
1029         (Upload.__init__):
1030         (Upload.Encoder): Encode Upload object as json.
1031         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1032         * Scripts/webkitpy/results/upload_unittest.py: Added.
1033         * Scripts/webkitpy/test/main.py:
1034         (Tester._parse_args): Add upload arguments.
1035         (Tester._run_tests): Allow results to be uploaded.
1036         * Scripts/webkitpy/test/runner.py:
1037         (Runner.__init__): Record which tests were run, rather than just counting them.
1038         (Runner.handle):
1039         * Scripts/webkitpy/test/runner_unittest.py:
1040         (RunnerTest.test_run):
1041         * Scripts/webkitpy/thirdparty/__init__.py:
1042         (AutoinstallImportHook.find_module): Add requests auto-install.
1043         (AutoinstallImportHook._install_requests):
1044         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1045         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1046
1047 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1048
1049         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1050         https://bugs.webkit.org/show_bug.cgi?id=195810
1051
1052         Reviewed by Tim Horton.
1053
1054         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1055         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1056         ending certain layout tests.
1057
1058         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1059         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1060         (-[TestRunnerWKWebView dealloc]):
1061         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1062
1063         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1064         helper method when destroying the web view, and when resetting state between tests.
1065
1066         * WebKitTestRunner/ios/TestControllerIOS.mm:
1067         (WTR::TestController::platformResetStateToConsistentValues):
1068
1069         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1070
1071 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1072
1073         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1074         https://bugs.webkit.org/show_bug.cgi?id=190350
1075         <rdar://problem/45089503>
1076
1077         Reviewed by Geoffrey Garen.
1078
1079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1080         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1081         (TEST):
1082         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1083         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1084         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1085         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1086         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1087         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1088         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1089         (runTest):
1090         (createDirectories):
1091         (TEST):
1092         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1093         (TEST):
1094         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1095         (TEST):
1096
1097 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1098
1099         Add support to WebPage for getting the contents as an attributed string.
1100         https://bugs.webkit.org/show_bug.cgi?id=195636
1101         rdar://problem/45055697
1102
1103         Reviewed by Tim Horton.
1104
1105         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1106         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1107
1108 2019-03-15  Chris Dumez  <cdumez@apple.com>
1109
1110         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1111         https://bugs.webkit.org/show_bug.cgi?id=195747
1112
1113         Reviewed by Geoff Garen.
1114
1115         Add API test coverage.
1116
1117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1118
1119 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1120
1121         Unreviewed, rolling out r242952.
1122
1123         Causing API failures on iOS Simulator
1124
1125         Reverted changeset:
1126
1127         "[PSON] Make sure the WebProcessCache is leverage when
1128         relaunching a process after termination"
1129         https://bugs.webkit.org/show_bug.cgi?id=195747
1130         https://trac.webkit.org/changeset/242952
1131
1132 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1133
1134         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1135         https://bugs.webkit.org/show_bug.cgi?id=195740
1136
1137         Reviewed by Ross Kirsling.
1138
1139         window.open doesn't work for WebKitBrowserWindow because it is not
1140         implemented yet.
1141
1142         1. Implemented createNewPage callback of WKPageUIClient.
1143         2. Changed MainWindow to take a BrowserWindow factory function
1144           instead of BrowserWindowType to be flexible to create
1145           BrowserWindow with extra settings.
1146         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1147           because it is not relevant with MainWindow anymore.
1148
1149         * MiniBrowser/win/Common.cpp:
1150         (parseCommandLine):
1151         * MiniBrowser/win/Common.h:
1152         (CommandLineOptions::CommandLineOptions):
1153         * MiniBrowser/win/MainWindow.cpp:
1154         (MainWindow::MainWindow):
1155         (MainWindow::create):
1156         (MainWindow::init):
1157         (MainWindow::WndProc):
1158         * MiniBrowser/win/MainWindow.h:
1159         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1160         (PrintWebUIDelegate::createWebViewWithRequest):
1161         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1162         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1163         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1164         (WebKitBrowserWindow::updateProxySettings):
1165         (WebKitBrowserWindow::createNewPage):
1166         * MiniBrowser/win/WebKitBrowserWindow.h:
1167         * MiniBrowser/win/WinMain.cpp:
1168         (wWinMain):
1169
1170 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1171
1172         Make it possible to test scrolling tree layer manipulation more easily
1173         https://bugs.webkit.org/show_bug.cgi?id=195780
1174
1175         Reviewed by Tim Horton.
1176         
1177         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1178         cuts off communication of scrolling tree scrolls back to the web process
1179         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1180         allows tests to trigger scrolls which run the scrolling tree layer positioning
1181         logic, but never get another commit from the web process that might mask
1182         scrolling tree bugs.
1183         
1184         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1185         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1186         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1187
1188         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1189         (WTR::UIScriptController::scrollUpdatesDisabled const):
1190         (WTR::UIScriptController::setScrollUpdatesDisabled):
1191         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1192         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1193         (WTR::UIScriptController::scrollUpdatesDisabled const):
1194         (WTR::UIScriptController::setScrollUpdatesDisabled):
1195         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1196         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1197         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1198         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1199         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1200         * WebKitTestRunner/ios/TestControllerIOS.mm:
1201         (WTR::TestController::platformResetStateToConsistentValues):
1202         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1203         (WTR::UIScriptController::scrollUpdatesDisabled const):
1204         (WTR::UIScriptController::setScrollUpdatesDisabled):
1205
1206 2019-03-14  Youenn Fablet  <youenn@apple.com>
1207
1208         Move IDB storage in private browsing mode to NetworkProcess
1209         https://bugs.webkit.org/show_bug.cgi?id=195602
1210
1211         Reviewed by Brady Eidson.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1214         (TEST):
1215
1216 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1217
1218         [ews-build] Make descriptionDone messages more readable
1219         https://bugs.webkit.org/show_bug.cgi?id=195760
1220
1221         Reviewed by Lucas Forschler.
1222
1223         * BuildSlaveSupport/ews-build/steps.py:
1224         * BuildSlaveSupport/ews-build/steps_unittest.py:
1225
1226 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1227
1228         [ews-build] Generate status-bubble hover-over messages
1229         https://bugs.webkit.org/show_bug.cgi?id=195680
1230
1231         Reviewed by Lucas Forschler.
1232
1233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1234         (StatusBubble):
1235         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1236         on hover-over.
1237         (StatusBubble._iso_time):
1238         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1239         hover-over message.
1240         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1241
1242 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1243
1244         [ews-app] Gracefully handle the case when state_string is None
1245         https://bugs.webkit.org/show_bug.cgi?id=195753
1246
1247         Reviewed by Lucas Forschler.
1248
1249         * BuildSlaveSupport/ews-app/ews/models/build.py:
1250         * BuildSlaveSupport/ews-app/ews/models/step.py:
1251
1252 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1253
1254         [ews-app] Status bubble display pending for currently running build step
1255         https://bugs.webkit.org/show_bug.cgi?id=195744
1256
1257         Reviewed by Lucas Forschler.
1258
1259         * BuildSlaveSupport/ews-build/events.py:
1260         (Events.stepStarted): If state_string is pending, replace it with step name.
1261
1262 2019-03-14  Chris Dumez  <cdumez@apple.com>
1263
1264         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1265         https://bugs.webkit.org/show_bug.cgi?id=195750
1266
1267         Reviewed by Geoffrey Garen.
1268
1269         Add API test coverage.
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1272         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1273         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1274         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1275
1276 2019-03-14  Chris Dumez  <cdumez@apple.com>
1277
1278         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1279         https://bugs.webkit.org/show_bug.cgi?id=195747
1280
1281         Reviewed by Geoff Garen.
1282
1283         Add API test coverage.
1284
1285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1286
1287 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1288
1289         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1290         https://bugs.webkit.org/show_bug.cgi?id=195725
1291         <rdar://problem/48545062>
1292
1293         Reviewed by Tim Horton.
1294
1295         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1296         handler is nil.
1297
1298         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1299         (TestWebKitAPI::TEST):
1300
1301 2019-03-13  Sam Weinig  <sam@webkit.org>
1302
1303         Add utility function to allow easy reverse range-based iteration of a container
1304         https://bugs.webkit.org/show_bug.cgi?id=195542
1305
1306         Reviewed by Antti Koivisto.
1307
1308         * TestWebKitAPI/CMakeLists.txt:
1309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1310         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1311         (TestWebKitAPI::TEST):
1312         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1313
1314 2019-03-13  Chris Dumez  <cdumez@apple.com>
1315
1316         Use a ServiceWorker process per registrable domain
1317         https://bugs.webkit.org/show_bug.cgi?id=195649
1318
1319         Reviewed by Youenn Fablet.
1320
1321         Update API test coverage.
1322
1323         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1324
1325 2019-03-13  Chris Dumez  <cdumez@apple.com>
1326
1327         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1328         https://bugs.webkit.org/show_bug.cgi?id=195684
1329         <rdar://problem/48294714>
1330
1331         Reviewed by Antti Koivisto.
1332
1333         Add API test coverage.
1334
1335         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1336
1337 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1338
1339         [ews-app] Remove unused patch view
1340         https://bugs.webkit.org/show_bug.cgi?id=195669
1341
1342         Reviewed by Lucas Forschler.
1343
1344         * BuildSlaveSupport/ews-app/ews/urls.py:
1345         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1346
1347 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-app] Use Buildbot result code variables
1350         https://bugs.webkit.org/show_bug.cgi?id=195668
1351
1352         Reviewed by Alexey Proskuryakov.
1353
1354         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1355         (Buildbot): Added Buildbot result code variables.
1356         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1357         (StatusBubble._build_bubble): Used Buildbot result code variables.
1358
1359 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1360
1361         [Flatpak] Expand submodule recursively
1362         https://bugs.webkit.org/show_bug.cgi?id=195672
1363
1364         Building WPE with flatpak was impossible without that as it was raising an exception.
1365         Also update wpebackend-fdo to match what is built in jhbuild
1366
1367         Reviewed by Philippe Normand.
1368
1369         * flatpak/flatpakutils.py:
1370         (expand_submodules_recurse):
1371         (expand_manifest):
1372         * flatpak/org.webkit.WPEModules.yaml:
1373
1374 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1375
1376         [ews-app] status bubble should be hidden for certain builds
1377         https://bugs.webkit.org/show_bug.cgi?id=194597
1378
1379         Reviewed by Dewei Zhu.
1380
1381         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1382         (StatusBubble._build_bubble):
1383         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1384         because the patch didn't have relevant changes.
1385         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1386         in production yet.
1387
1388 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1389
1390         [Win] Fix a slew of simple clang-cl warnings.
1391         https://bugs.webkit.org/show_bug.cgi?id=195652
1392
1393         Reviewed by Don Olmstead.
1394
1395         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1396         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1397
1398 2019-03-12  Justin Fan  <justin_fan@apple.com>
1399
1400         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1401         https://bugs.webkit.org/show_bug.cgi?id=195518
1402         <rdar://problem/46322356>
1403
1404         Reviewed by Myles C. Maxfield.
1405
1406         * DumpRenderTree/DerivedSources-input.xcfilelist:
1407         * DumpRenderTree/DerivedSources-output.xcfilelist:
1408
1409 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1410
1411         Unreviewed, rolling out r242825.
1412         https://bugs.webkit.org/show_bug.cgi?id=195648
1413
1414         "Broke webkitpy tests with my change to
1415         lldb_dump_class_layout.py" (Requested by rmorisset on
1416         #webkit).
1417
1418         Reverted changeset:
1419
1420         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1421         classes with suspicious padding"
1422         https://bugs.webkit.org/show_bug.cgi?id=195573
1423         https://trac.webkit.org/changeset/242825
1424
1425 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1426
1427         [ews-build] Show status bubbles while the patch is waiting in queue
1428         https://bugs.webkit.org/show_bug.cgi?id=195618
1429
1430         Reviewed by Lucas Forschler.
1431
1432         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1433         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1434         enabled in initial deployment.
1435         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1436         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1437         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1438         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1439         (StatusBubble._build_bubbles_for_patch):
1440
1441 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1442
1443         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1444         https://bugs.webkit.org/show_bug.cgi?id=195573
1445
1446         Reviewed by Simon Fraser.
1447
1448         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1449
1450         * Scripts/dump-class-layout:
1451         (main):
1452         * lldb/lldb_dump_class_layout.py:
1453         (ClassLayout.__init__):
1454         (ClassLayout._compute_padding_recursive):
1455         (LLDBDebuggerInstance.dump_layout_for_classname):
1456         (LLDBDebuggerInstance):
1457         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1458         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1459
1460 2019-03-12  Chris Dumez  <cdumez@apple.com>
1461
1462         Device Orientation access permission should be denied unless explicitly granted by the client
1463         https://bugs.webkit.org/show_bug.cgi?id=195625
1464
1465         Reviewed by Youenn Fablet.
1466
1467         add API test coverage.
1468
1469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1470         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1471         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1472         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1473         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1474         (runDeviceOrientationTest):
1475         (TEST):
1476         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1477         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1478
1479 2019-03-12  Jer Noble  <jer.noble@apple.com>
1480
1481         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1482         https://bugs.webkit.org/show_bug.cgi?id=195137
1483         <rdar://problem/48810307>
1484
1485         Reviewed by Eric Carlson.
1486
1487         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1488         (TestWebKitAPI::TEST):
1489
1490 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1491
1492         [ews-build] Change urls from uat to production
1493         https://bugs.webkit.org/show_bug.cgi?id=195566
1494
1495         Reviewed by Lucas Forschler.
1496
1497         * BuildSlaveSupport/ews-app/ews/config.py:
1498         * BuildSlaveSupport/ews-build/events.py:
1499         * BuildSlaveSupport/ews-build/steps.py:
1500
1501 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1502
1503         [ews-build] change max_builds for local-worker to 1
1504         https://bugs.webkit.org/show_bug.cgi?id=195568
1505
1506         Reviewed by Lucas Forschler.
1507
1508         * BuildSlaveSupport/ews-build/loadConfig.py:
1509
1510 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1511
1512         Fix the build
1513
1514         * TestRunnerShared/spi/PencilKitTestSPI.h:
1515         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1516
1517 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1518
1519         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1520         https://bugs.webkit.org/show_bug.cgi?id=194131
1521
1522         Reviewed by Michael Catanzaro.
1523
1524         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1525         (uriChanged):
1526         (testUnfinishedSubresourceLoad):
1527         (serverCallback):
1528         (beforeAll):
1529
1530 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1531
1532         WTF::Expected should use std::addressof instead of operator&
1533         https://bugs.webkit.org/show_bug.cgi?id=195604
1534
1535         Reviewed by Myles Maxfield.
1536
1537         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1538         (TestWebKitAPI::Unique::Unique):
1539         (TestWebKitAPI::Unique::operator&):
1540         (TestWebKitAPI::TEST):
1541
1542 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1543
1544         Add Optional to Forward.h.
1545         https://bugs.webkit.org/show_bug.cgi?id=195586
1546
1547         Reviewed by Darin Adler.
1548
1549         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1550         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1551         Remove unnecessary includes from headers.
1552
1553 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1554
1555         Add testing API to hit-test and scroll overflow scrollers
1556         https://bugs.webkit.org/show_bug.cgi?id=195278
1557
1558         Reviewed by Antti Koivisto.
1559         
1560         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1561         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1562         
1563         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1564
1565         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1566         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1567         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1568         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1569         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1570         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1571         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1572         (WTR::enclosingScrollViewIncludingSelf):
1573         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1574
1575 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1576
1577         API test WebKit.RequestTextInputContext fails on iOS
1578         https://bugs.webkit.org/show_bug.cgi?id=195585
1579
1580         Reviewed by Wenson Hsieh and Simon Fraser.
1581
1582         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1583         (applyStyle):
1584         (TEST):
1585         Add a viewport, so that the coordinates match up on iOS.
1586         Scroll by moving the UIScrollView's contentOffset.
1587
1588 2019-03-11  Chris Dumez  <cdumez@apple.com>
1589
1590         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1591         https://bugs.webkit.org/show_bug.cgi?id=195506
1592         <rdar://problem/48733477>
1593
1594         Reviewed by Alex Christensen.
1595
1596         Add API test coverage.
1597
1598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1599
1600 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1601
1602         Adding myself to contributors.json
1603
1604         Unreviewed, addming myself to contributors.json .
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1609
1610         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1611         https://bugs.webkit.org/show_bug.cgi?id=195511
1612         <rdar://problem/44873269>
1613
1614         Reviewed by Darin Adler.
1615
1616         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1617         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1618         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1619         (TEST_F):
1620
1621 2019-03-11  Chris Dumez  <cdumez@apple.com>
1622
1623         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1624         https://bugs.webkit.org/show_bug.cgi?id=195561
1625
1626         Reviewed by Youenn Fablet.
1627
1628         Make sure the JS in the test requests for permission to receive device orientation events.
1629
1630         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1631
1632 2019-03-11  Youenn Fablet  <youenn@apple.com>
1633
1634         Allow storage quota increase by default in WTR
1635         https://bugs.webkit.org/show_bug.cgi?id=195541
1636
1637         Reviewed by Geoffrey Garen.
1638
1639         Allow storage quota increase by default in WTR.
1640         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1641         Use this for tests that explicitly need cache increase.
1642
1643         Instead of increasing quota by 2, make sure the next request is
1644         granted by adding all given parameters.
1645
1646         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1647         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1648         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1649         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1650         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1651         * WebKitTestRunner/TestController.cpp:
1652         (WTR::TestController::setAllowStorageQuotaIncrease):
1653         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1654         * WebKitTestRunner/TestController.h:
1655         * WebKitTestRunner/TestInvocation.cpp:
1656         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1657         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1658         (WTR::TestController::cocoaResetStateToConsistentValues):
1659         (WTR::TestController::setAllowStorageQuotaIncrease):
1660         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1661         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1662         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1663
1664 2019-03-11  Xan Lopez  <xan@igalia.com>
1665
1666         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1667         https://bugs.webkit.org/show_bug.cgi?id=194147
1668
1669         Reviewed by Michael Saboff.
1670
1671         To make --32-bit work correctly on Linux/64bit we need to:
1672
1673         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1674         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1675         unfortunately CMake only allows us to do this during
1676         crosscompilation, which is overkill here.
1677         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1678         pkg-config detection module uses the x86 .pc files instead of the
1679         x86_64 ones.
1680         - Set the -m32 flags for the compiler.
1681
1682         * Scripts/webkitdirs.pm:
1683         (generateBuildSystemFromCMakeProject):
1684
1685 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1686
1687         Add MotionMark-1.1 plan file for run-benchmark script.
1688         https://bugs.webkit.org/show_bug.cgi?id=195481
1689
1690         Rubber-stamped by Darin Adler.
1691
1692         Run-benchmark script should support MontionMark-1.1.
1693
1694         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1695
1696 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1697
1698         [ews-app] Add support for submit-to-ews url
1699         https://bugs.webkit.org/show_bug.cgi?id=195477
1700
1701         Reviewed by Lucas Forschler.
1702
1703         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1704         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1705         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1706         * BuildSlaveSupport/ews-app/ews/urls.py:
1707         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1708
1709 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1710
1711         Unreviewed, rolling out r242688, r242643, r242624.
1712
1713         Caused multiple layout test failures and crashes on iOS and macOS.
1714
1715         Reverted changeset:
1716
1717         "requestAnimationFrame should execute before the next frame"
1718         https://bugs.webkit.org/show_bug.cgi?id=177484
1719         https://trac.webkit.org/changeset/242624/webkit
1720
1721         * Tracing/SystemTracePoints.plist:
1722
1723 2019-03-11  John Wilander  <wilander@apple.com>
1724
1725         Resource Load Statistics: Make it possible exclude localhost from classification
1726         https://bugs.webkit.org/show_bug.cgi?id=195474
1727         <rdar://problem/47520577>
1728
1729         Reviewed by Brent Fulgham.
1730
1731         This patch allows for localhost to be excluded from classification and
1732         treatment as a prevalent resource.
1733
1734         The WebKit Tools change adds a new function called
1735         testRunner.setStatisticsIsRunningTest() which can be used to control this
1736         behavior.
1737
1738         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1739         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1740         (WTR::TestRunner::setStatisticsIsRunningTest):
1741         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1742         * WebKitTestRunner/TestController.cpp:
1743         (WTR::TestController::setStatisticsIsRunningTest):
1744         * WebKitTestRunner/TestController.h:
1745         * WebKitTestRunner/TestInvocation.cpp:
1746         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1747
1748 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1749
1750         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1751         https://bugs.webkit.org/show_bug.cgi?id=195560
1752
1753         Reviewed by Lucas Forschler.
1754
1755         * BuildSlaveSupport/ews-build/master.cfg:
1756
1757 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1758
1759         Unreviewed, rolling out r242698.
1760
1761         API test crashes on bots.
1762
1763         Reverted changeset:
1764
1765         "Add a WKContentRuleList variant that uses copied memory
1766         instead of mmap'd shared memory for class A containerized
1767         apps"
1768         https://bugs.webkit.org/show_bug.cgi?id=195511
1769         https://trac.webkit.org/changeset/242698
1770
1771 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1772
1773         [WPE] Enable web process sandbox
1774         https://bugs.webkit.org/show_bug.cgi?id=195169
1775
1776         Reviewed by Daniel Bates.
1777
1778         * wpe/install-dependencies:
1779         * wpe/jhbuild.modules:
1780
1781 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-app] Use port 17000 for worker communication
1784         https://bugs.webkit.org/show_bug.cgi?id=195558
1785
1786         Reviewed by Lucas Forschler.
1787
1788         * BuildSlaveSupport/ews-build/master.cfg:
1789
1790 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1791
1792         [ews-build] unit-tests fail when passwords.json is missing
1793         https://bugs.webkit.org/show_bug.cgi?id=195557
1794
1795         Reviewed by Lucas Forschler.
1796
1797         * BuildSlaveSupport/ews-build/loadConfig.py:
1798         (loadBuilderConfig):
1799         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1800         (ConfigDotJSONTest.test_configuration):
1801         * BuildSlaveSupport/ews-build/master.cfg:
1802
1803 2019-03-11  Truitt Savell  <tsavell@apple.com>
1804
1805         Unreviewed, rolling out r242702.
1806
1807         Broke High Sierra builders.
1808
1809         Reverted changeset:
1810
1811         "Add utility function to allow easy reverse range-based
1812         iteration of a container"
1813         https://bugs.webkit.org/show_bug.cgi?id=195542
1814         https://trac.webkit.org/changeset/242702
1815
1816 2019-03-11  Sam Weinig  <sam@webkit.org>
1817
1818         Add utility function to allow easy reverse range-based iteration of a container
1819         https://bugs.webkit.org/show_bug.cgi?id=195542
1820
1821         Reviewed by Antti Koivisto.
1822
1823         * TestWebKitAPI/CMakeLists.txt:
1824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1825         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1826         (TestWebKitAPI::TEST):
1827         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1828
1829 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1830
1831         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1832         https://bugs.webkit.org/show_bug.cgi?id=195511
1833         <rdar://problem/44873269>
1834
1835         Reviewed by Darin Adler.
1836
1837         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1838         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1839         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1840         (TEST_F):
1841
1842 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1843
1844         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1845         https://bugs.webkit.org/show_bug.cgi?id=195499
1846
1847         Reviewed by Darin Adler.
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1851         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1852         (-[WKWebView synchronouslyFocusTextInputContext:]):
1853         (applyStyle):
1854         (applyIframe):
1855         (TEST):
1856         Add some tests for this SPI.
1857
1858 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1859
1860         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1861         https://bugs.webkit.org/show_bug.cgi?id=181151
1862
1863         Reviewed by Don Olmstead.
1864
1865         * TestWebKitAPI/CMakeLists.txt:
1866         * TestWebKitAPI/PlatformWin.cmake:
1867         Enable TestWTF RunLoop tests in all platforms.
1868
1869         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1870         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1871         (TestWebKitAPI::DerivedOneShotTimer::fired):
1872         (TestWebKitAPI::TEST):
1873         Only a few platforms support nested RunLoop.
1874
1875         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1876         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1877
1878 2019-03-10  David Quesada  <david_quesada@apple.com>
1879
1880         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1881         https://bugs.webkit.org/show_bug.cgi?id=152480
1882
1883         Reviewed by Chris Dumez.
1884
1885         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1886         there are no additional references to the process pool besides the one held by
1887         the download, waits for the download to finish (in the sense that the
1888         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1889         measure, also check that the process pool has been deallocated at the end of the
1890         test. The test wouldn't be meaningful if the process pool were still alive.
1891
1892         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1893         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1894         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1895             The download will be canceled because the delegate does not implement the
1896             method to decide the download's destination, so this is where we know the
1897             DownloadProxyMap is done with the DownloadProxy.
1898         (TEST):
1899
1900 2019-03-08  Chris Dumez  <cdumez@apple.com>
1901
1902         Add support for Device Orientation / Motion permission API
1903         https://bugs.webkit.org/show_bug.cgi?id=195329
1904         <rdar://problem/47645367>
1905
1906         Reviewed by Geoffrey Garen.
1907
1908         Add test infrastructure to help test the Device Orientation / Motion permission API.
1909
1910         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1911         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1912         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1914         * WebKitTestRunner/TestController.cpp:
1915         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1916         (WTR::TestController::createWebViewWithOptions):
1917         (WTR::TestController::resetStateToConsistentValues):
1918         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1919         * WebKitTestRunner/TestController.h:
1920         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1921         * WebKitTestRunner/TestInvocation.cpp:
1922         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1923
1924 2019-03-08  Saam barati  <sbarati@apple.com>
1925
1926         Add a compare-results script to compare benchmark results
1927         https://bugs.webkit.org/show_bug.cgi?id=195486
1928         <rdar://problem/48723397>
1929
1930         Reviewed by Geoffrey Garen.
1931
1932         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1933         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1934         to extend it to learn about our other benchmarks.
1935
1936         * Scripts/compare-results: Added.
1937         (readJSONFile):
1938         (detectJetStream2):
1939         (JetStream2Results):
1940         (detectSpeedometer2):
1941         (Speedometer2Results):
1942         (detectPLT5):
1943         (PLT5Results):
1944         (detectBenchmark):
1945         (biggerIsBetter):
1946         (ttest):
1947         (getOptions):
1948         (main):
1949
1950 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1951
1952         Ensure old tab state is cleared between iterations of run-benchmark
1953         https://bugs.webkit.org/show_bug.cgi?id=195393
1954         <rdar://problem/46885583>
1955
1956         Reviewed by Dewei Zhu.
1957
1958         a) ensure the default to restore state is not set
1959         b) terminate Safari correctly
1960         c) Set the system default to ignore Persistent State in Safari
1961
1962         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1963         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1964         (OSXBrowserDriver.prepare_env): 
1965         (OSXBrowserDriver.restore_env):
1966         (OSXBrowserDriver.close_browsers):
1967         (OSXBrowserDriver._terminate_processes):
1968         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1969         (OSXChromeDriver):
1970         (OSXChromeCanaryDriver):
1971         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1972         (OSXFirefoxDriver):
1973         (OSXFirefoxNightlyDriver):
1974         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1975         (OSXSafariDriver):
1976         (OSXSafariDriver.prepare_env):
1977
1978 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1979
1980         [GTK] Several InputMethodFilter tests are failing
1981         https://bugs.webkit.org/show_bug.cgi?id=195408
1982
1983         Reviewed by Carlos Garcia Campos.
1984
1985         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1986         Regressed in r241751.
1987         Hexadecimal values of keycodes are expressed now in upper letters.
1988         Composited characters should be cast to UTF8 strings.
1989
1990         (TestWebKitAPI::TEST):
1991
1992 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1993
1994         [GTK] Make Tools/gtkdoc python3 compatible
1995         https://bugs.webkit.org/show_bug.cgi?id=195359
1996
1997         Reviewed by Carlos Garcia Campos.
1998
1999         * gtkdoc/generate-gtkdoc:
2000         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2001         work with Python 2 and 3.
2002         (get_gtkdoc_module_paths):
2003         The iteritems() was removed in Python 3, so let's use items() that's
2004         available in Python 2 and 3.
2005         (get_generator_for_config):
2006         * gtkdoc/gtkdoc.py:
2007         (GTKDoc._run_command):
2008         The sys.stdout.write() is expecting str in Python 3 and not bytes
2009         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2010         for passing the bytes there.
2011
2012 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2013
2014         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2015         https://bugs.webkit.org/show_bug.cgi?id=195346
2016         <rdar://problem/48667048>
2017
2018         Unreviewed build fix for clang-cl.
2019
2020         * DumpRenderTree/win/DumpRenderTree.cpp:
2021         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2022
2023 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2024
2025         requestAnimationFrame should execute before the next frame
2026         https://bugs.webkit.org/show_bug.cgi?id=177484
2027
2028         Reviewed by Simon Fraser.
2029
2030         Add trace points for the page RenderingUpdate.
2031
2032         * Tracing/SystemTracePoints.plist:
2033
2034 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2035
2036         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2037         https://bugs.webkit.org/show_bug.cgi?id=195353
2038         <rdar://problem/48626394>
2039
2040         Reviewed by Simon Fraser.
2041
2042         * WebKitTestRunner/ios/TestControllerIOS.mm:
2043         (WTR::TestController::platformResetPreferencesToConsistentValues):
2044
2045 2019-03-07  John Wilander  <wilander@apple.com>
2046
2047         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2048         https://bugs.webkit.org/show_bug.cgi?id=195383
2049         <rdar://problem/48570136>
2050
2051         Reviewed by Brent Fulgham.
2052
2053         This patch adds test infrastructure to purge only script-accessible cookies,
2054         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2055
2056         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2057         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2058         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2059         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2060         * WebKitTestRunner/TestController.cpp:
2061         (WTR::TestController::statisticsDeleteCookiesForHost):
2062         * WebKitTestRunner/TestController.h:
2063         * WebKitTestRunner/TestInvocation.cpp:
2064         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2065
2066 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2067
2068         Unreviewed, rolling out r242354.
2069         https://bugs.webkit.org/show_bug.cgi?id=195402
2070
2071         breaks layout tests in all configurations (Requested by
2072         zdobersek on #webkit).
2073
2074         Reverted changeset:
2075
2076         "[WPE] Enable web process sandbox"
2077         https://bugs.webkit.org/show_bug.cgi?id=195169
2078         https://trac.webkit.org/changeset/242354
2079
2080 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2081
2082         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2083         https://bugs.webkit.org/show_bug.cgi?id=195346
2084
2085         Reviewed by Fujii Hironori.
2086
2087         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2088         (TestWebKitAPI::TEST):
2089         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2090
2091         * DumpRenderTree/win/DumpRenderTree.cpp:
2092         (findFontFallback):
2093         (addFontFallbackIfPresent):
2094         (removeFontFallbackIfPresent):
2095         (main):
2096         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2097         (TestWebKitAPI::Util::moduleDirectory):
2098         (TestWebKitAPI::Util::createInjectedBundlePath):
2099         Use wchar helpers as needed.
2100
2101 2019-03-06  Rob Buis  <rbuis@igalia.com>
2102
2103         Consider supporting the `referrerpolicy` attribute.
2104         https://bugs.webkit.org/show_bug.cgi?id=179053
2105
2106         Reviewed by Darin Adler.
2107
2108         Add a runtime flag for referrerpolicy attribute.
2109
2110         * DumpRenderTree/mac/DumpRenderTree.mm:
2111         (enableExperimentalFeatures):
2112
2113 2019-03-05  Daniel Bates  <dabates@apple.com>
2114
2115         Update expected API test result following r242379
2116         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2117
2118         Update expected x-coordinate of selection rect now that the left padding of
2119         a textarea is sized in ems (so dependent on the font size) just like the left
2120         padding of a text field.
2121
2122         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2123         (TestWebKitAPI::TEST):
2124
2125 2019-03-05  David Quesada  <david_quesada@apple.com>
2126
2127         [WK2] It should be possible to follow links with 'download' attributes
2128         https://bugs.webkit.org/show_bug.cgi?id=195145
2129         rdar://problem/48462642
2130
2131         Reviewed by Alex Christensen.
2132
2133         Add a unit test to verify that activating links with 'download' attributes now
2134         navigates to the linked resource, rather than starts downloading it. Add another
2135         to verify that it is still possible to explicitly download the link via the
2136         'Download' navigation action policy.
2137
2138         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2139         (-[DownloadAttributeTestDelegate init]):
2140         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2141         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2142         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2143         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2144         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2145         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2146         (TEST):
2147         * WebKitTestRunner/TestController.cpp:
2148         (WTR::TestController::decidePolicyForNavigationAction):
2149         * WebKitTestRunner/TestController.h:
2150
2151 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2152
2153         [Curl] Implement Cookie Accept Policy.
2154         https://bugs.webkit.org/show_bug.cgi?id=191645
2155
2156         Reviewed by Fujii Hironori.
2157
2158         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2159         (TestWebKitAPI::Curl::TEST_F):
2160
2161 2019-03-05  Youenn Fablet  <youenn@apple.com>
2162
2163         Rename requestCacheStorageSpace to requestStorageSpace
2164         https://bugs.webkit.org/show_bug.cgi?id=195282
2165
2166         Reviewed by Chris Dumez.
2167
2168         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2169         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2170         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2171
2172 2019-03-05  Brady Eidson  <beidson@apple.com>
2173
2174         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2175         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2176
2177         Reviewed by Tim Horton.
2178
2179         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2180         different directory into that same WKWebView should work.
2181
2182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2183         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2184
2185 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2186
2187         Add WeakHashSet
2188         https://bugs.webkit.org/show_bug.cgi?id=195152
2189
2190         Reviewed by Antti Koivisto.
2191
2192         Added tests for WeakHashSet.
2193
2194         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2195         (TestWebKitAPI::Base::Base): Moved.
2196         (TestWebKitAPI::Derived::foo): Moved.
2197         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2198         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2199         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2200         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2201
2202 2019-03-04  Chris Dumez  <cdumez@apple.com>
2203
2204         Do not share WebProcesses between private and regular sessions
2205         https://bugs.webkit.org/show_bug.cgi?id=195189
2206         <rdar://problem/48421064>
2207
2208         Reviewed by Alex Christensen.
2209
2210         Add API test coverage.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2213         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2214
2215 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2216
2217         [WPE] Enable web process sandbox
2218         https://bugs.webkit.org/show_bug.cgi?id=195169
2219
2220         Reviewed by Daniel Bates.
2221
2222         * wpe/install-dependencies:
2223         * wpe/jhbuild.modules:
2224
2225 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2226
2227         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2228         https://bugs.webkit.org/show_bug.cgi?id=195206
2229
2230         Reviewed by Žan Doberšek.
2231
2232         Add a new test case.
2233
2234         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2235         (testJSCClass):
2236
2237 2019-03-04  Charlie Turner  <cturner@igalia.com>
2238
2239         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2240         https://bugs.webkit.org/show_bug.cgi?id=194898
2241
2242         Reviewed by Žan Doberšek.
2243
2244         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2245         a GCC extension that permits arithmetic on void* pointer. Inline
2246         the macro until this issue is fixed upstream.
2247
2248 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2249
2250         Rid the world of WK_API_ENABLED
2251         https://bugs.webkit.org/show_bug.cgi?id=195263
2252
2253         Reviewed by Dan Bernstein.
2254
2255         List of changed files elided because it's useless.
2256
2257 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2258
2259         Unreviewed follow-up to r242292.
2260
2261         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2262
2263         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2264         (TestWebKitAPI::testStrip): Renamed from strip.
2265         (TestWebKitAPI::TEST):
2266
2267 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2268
2269         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2270
2271         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2272         and bug #194272 for details.
2273
2274         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2275
2276 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2277
2278         Remove some more unused 32-bit code
2279         https://bugs.webkit.org/show_bug.cgi?id=195255
2280
2281         Reviewed by Darin Adler.
2282
2283         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2284         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2285         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2286         (NPP_New):
2287         (NPP_HandleEvent):
2288         (handleEventCarbon): Deleted.
2289
2290 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2291
2292         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2293
2294         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2295         (TestWebKitAPI::TEST):
2296
2297 2019-03-01  Darin Adler  <darin@apple.com>
2298
2299         Finish removing String::format
2300         https://bugs.webkit.org/show_bug.cgi?id=194893
2301
2302         Reviewed by Daniel Bates.
2303 '
2304         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2305
2306 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2307
2308         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2309         https://bugs.webkit.org/show_bug.cgi?id=195229
2310         <rdar://problem/48520362>
2311
2312         Reviewed by Chris Dumez.
2313
2314         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2315         (TEST):
2316
2317 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2318
2319         Add a system trace scope for event region building
2320         https://bugs.webkit.org/show_bug.cgi?id=195226
2321
2322         Reviewed by Jon Lee.
2323
2324         This trace scope measures the time spend converting element rects into Region objects,
2325         which can be large on some pages.
2326
2327         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2328
2329         * Tracing/SystemTracePoints.plist:
2330
2331 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2332
2333         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2334         https://bugs.webkit.org/show_bug.cgi?id=194612
2335
2336         Reviewed by Alex Christensen.
2337
2338         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2339         Just test the new string-processing function and don't touch the actual environment.
2340         (Test cases are all as before, but based on operator== instead of strcmp.)
2341
2342 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2343
2344         [ews-app] Update primary keys for handling multiple Buildbot instances
2345         https://bugs.webkit.org/show_bug.cgi?id=195120
2346
2347         Reviewed by Stephanie Lewis.
2348
2349         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2350         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2351         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2352
2353         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2354         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2355         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2356         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2357         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2358         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2359
2360 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2361
2362         [WinCairo] Enable service worker
2363         https://bugs.webkit.org/show_bug.cgi?id=188318
2364
2365         Reviewed by Youenn Fablet.
2366
2367         * DumpRenderTree/DumpRenderTreePrefix.h:
2368         * TestWebKitAPI/PlatformWin.cmake:
2369         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2370         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2371         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2372
2373 2019-03-01  Justin Fan  <justin_fan@apple.com>
2374
2375         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2376         https://bugs.webkit.org/show_bug.cgi?id=195191
2377
2378         Rubber-stamped by Dean Jackson.
2379
2380         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2381
2382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2383
2384 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2385
2386         Unreviewed, fix lldb webkitpy tests
2387         https://bugs.webkit.org/show_bug.cgi?id=194375
2388
2389         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2390
2391         * lldb/lldb_webkit.py:
2392         (WTFStringImplProvider.is_8bit):
2393
2394 2019-02-28  David Quesada  <david_quesada@apple.com>
2395
2396         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2397         https://bugs.webkit.org/show_bug.cgi?id=195121
2398         rdar://problem/48450302
2399
2400         Reviewed by Alex Christensen.
2401
2402         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2403         configurations where the 'download' attribute is absent, blank, or populated
2404         with a filename, and where the anchor element is same-origin or cross-origin
2405         (meaning the 'download' attribute shouldn't be honored).
2406
2407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2408         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2409         (-[NavigationActionTestDelegate init]):
2410         (-[NavigationActionTestDelegate navigationAction]):
2411         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2412         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2413         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2414         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2415         (TEST):
2416
2417 2019-02-28  Antoine Quint  <graouts@apple.com>
2418
2419         Enable the Pointer Events runtime flag by default
2420         https://bugs.webkit.org/show_bug.cgi?id=195156
2421
2422         Reviewed by Dean Jackson.
2423
2424         * DumpRenderTree/mac/DumpRenderTree.mm:
2425         (enableExperimentalFeatures):
2426
2427 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2428
2429         Several PasteImage API tests are flaky
2430         https://bugs.webkit.org/show_bug.cgi?id=195160
2431
2432         Reviewed by Tim Horton.
2433
2434         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2435         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2436         listening for a "load" event after image load is already complete.
2437
2438         To address this, make these tests first register a "load" event handler, then run script to insert an image
2439         element into the document, and finally wait until the load event is observed before checking image size.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2442
2443 2019-02-28  Chris Dumez  <cdumez@apple.com>
2444
2445         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2446         https://bugs.webkit.org/show_bug.cgi?id=195107
2447
2448         Reviewed by Alex Christensen.
2449
2450         Give some time for the zoom level to get restored.
2451
2452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2453
2454 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2455
2456         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2457         https://bugs.webkit.org/show_bug.cgi?id=194958
2458
2459         Reviewed by Geoffrey Garen.
2460
2461         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2462         (TEST):
2463
2464 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2465
2466         [ews-app] Update method to save build to handle builder_display_name
2467         https://bugs.webkit.org/show_bug.cgi?id=195047
2468
2469         Reviewed by Dewei Zhu.
2470
2471         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2472         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2473
2474 2019-02-28  Justin Fan  <justin_fan@apple.com>
2475
2476         [Web GPU] Enable Web GPU only on 64-bit
2477         https://bugs.webkit.org/show_bug.cgi?id=195139
2478
2479         Because Metal is only supported on 64 bit apps.
2480
2481         Unreviewed build fix.
2482
2483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2484
2485 2019-02-27  Youenn Fablet  <youenn@apple.com>
2486
2487         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2488         https://bugs.webkit.org/show_bug.cgi?id=194959
2489
2490         Reviewed by Chris Dumez.
2491
2492         Spin loop until getting the condition to remove flakiness.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2495
2496 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2497
2498         [ews-build] Buildbot should include builder_display_name in the build events
2499         https://bugs.webkit.org/show_bug.cgi?id=195045
2500
2501         Reviewed by Dewei Zhu.
2502
2503         * BuildSlaveSupport/ews-build/events.py:
2504         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2505         buildername to builder_name to be consistent in naming style.
2506         (Events.buildFinished): Ditto.
2507
2508 2019-02-27  Chris Dumez  <cdumez@apple.com>
2509
2510         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2511         https://bugs.webkit.org/show_bug.cgi?id=194480
2512
2513         Reviewed by Brady Eidson.
2514
2515         Update existing API test to make it more likely to reproduce the issue.
2516
2517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2518
2519 2019-02-27  Brady Eidson  <beidson@apple.com>
2520
2521         Universal links from Google search results pages don't open the app.
2522         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2523
2524         Reviewed by Geoffrey Garen.
2525
2526         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2527         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2528         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2529         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2530
2531 2019-02-27  Chris Dumez  <cdumez@apple.com>
2532
2533         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2534         https://bugs.webkit.org/show_bug.cgi?id=195102
2535
2536         Reviewed by Geoffrey Garen.
2537
2538         If the number of processes is not yet what we expect, wait a bit and check again to give
2539         processes some time to exit.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2542
2543 2019-02-27  Chris Dumez  <cdumez@apple.com>
2544
2545         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2546         https://bugs.webkit.org/show_bug.cgi?id=194545
2547
2548         Reviewed by Brady Eidson.
2549
2550         Make sure the test navigates forward and then back only once. Previously, navigating
2551         back would trigger a navigation again in a timer.
2552
2553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2554
2555 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2556
2557         High Sierra Debug JSC test queue should use faster hardware
2558         https://bugs.webkit.org/show_bug.cgi?id=194603
2559
2560         Rubber-stamped by Alexey Proskuryakov.
2561
2562         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/config.json:
2565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2566         (BubbleQueueServer):
2567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2568         (WebKitBuildbot):
2569         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2570         * QueueStatusServer/config/queues.py:
2571         * Scripts/webkitpy/common/config/ews.json:
2572         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2573         (test_ews_name):
2574
2575 2019-02-27  John Wilander  <wilander@apple.com>
2576
2577         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2578         https://bugs.webkit.org/show_bug.cgi?id=195071
2579         <rdar://problem/48417690>
2580
2581         Reviewed by Alex Christensen and Brent Fulgham.
2582
2583         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2584         (TestWebKitAPI::createURL):
2585             Convenience function.
2586         (TestWebKitAPI::TEST):
2587             WebCore::AdClickAttribution now takes a URL when creating Source and
2588             Destination.
2589         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2590         (TestWebKitAPI::TEST):
2591             WebCore::AdClickAttribution now takes a URL when creating Source and
2592             Destination.
2593
2594 2019-02-27  Antoine Quint  <graouts@apple.com>
2595
2596         Support Pointer Events on macOS
2597         https://bugs.webkit.org/show_bug.cgi?id=195008
2598         <rdar://problem/47454419>
2599
2600         Reviewed by Dean Jackson.
2601
2602         * DumpRenderTree/mac/DumpRenderTree.mm:
2603         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2604         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2605
2606 2019-02-26  Mark Lam  <mark.lam@apple.com>
2607
2608         Remove remaining poisoning code.
2609         https://bugs.webkit.org/show_bug.cgi?id=194138
2610
2611         Reviewed by Saam Barati.
2612
2613         * TestWebKitAPI/CMakeLists.txt:
2614         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2615         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2616         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2617         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2618         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2619         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2620         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2621
2622 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2623
2624         Move ephemeral local storage from WebProcess to UIProcess
2625         https://bugs.webkit.org/show_bug.cgi?id=195074
2626         <rdar://problem/47937975>
2627
2628         Reviewed by Geoff Garen.
2629
2630         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2631
2632 2019-02-20  Jer Noble  <jer.noble@apple.com>
2633
2634         [Cocoa] Media elements will restart network buffering just before suspending
2635         https://bugs.webkit.org/show_bug.cgi?id=193691
2636
2637         Reviewed by Eric Carlson.
2638
2639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2641         (TEST):
2642
2643 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2644
2645         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2646         https://bugs.webkit.org/show_bug.cgi?id=191652
2647
2648         Reviewed by Alex Christensen.
2649
2650         Fix WinCairo MiniBrowser behavior of authentication dialog.
2651
2652         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2653         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2654
2655 2019-02-26  Youenn Fablet  <youenn@apple.com>
2656
2657         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2658         https://bugs.webkit.org/show_bug.cgi?id=195028
2659         <rdar://problem/48243733>
2660
2661         Reviewed by Eric Carlson.
2662
2663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2664
2665 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2666
2667         [WPE] Add API for webview background color configuration
2668         https://bugs.webkit.org/show_bug.cgi?id=192305
2669
2670         Reviewed by Michael Catanzaro.
2671
2672         * MiniBrowser/wpe/main.cpp:
2673         (main): Add a new option to configure the webview background
2674         color. Example: --bg-color=transparent.
2675         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2676         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2677         (beforeAll): Ditto.
2678
2679 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2680
2681         scalableNativeWebpageParameters() is not preserved on new page navigation.
2682         https://bugs.webkit.org/show_bug.cgi?id=194892
2683         <rdar://problem/47538280>
2684
2685         Reviewed by Wenson Hsieh.
2686         
2687         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2688
2689         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2690         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2691         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2692         (WTR::UIScriptController::allowsViewportShrinkToFit):
2693         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2694         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2695         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2696         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2697         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2698         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2699
2700 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2701
2702         [ews-app] Add model for handling multiple Buildbot instances
2703         https://bugs.webkit.org/show_bug.cgi?id=194863
2704
2705         Reviewed by Stephanie Lewis.
2706
2707         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2708
2709 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2710
2711         [ews-app] Remove BuilderMapping table
2712         https://bugs.webkit.org/show_bug.cgi?id=194961
2713
2714         Reviewed by Stephanie Lewis.
2715
2716         Store builder name directly in build table, instead of having a separate
2717         table for it.
2718
2719         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2720         * BuildSlaveSupport/ews-app/ews/models/build.py:
2721         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2722         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2723
2724 2019-02-25  John Wilander  <wilander@apple.com>
2725
2726         Introduce and adopt new class RegistrableDomain for eTLD+1
2727         https://bugs.webkit.org/show_bug.cgi?id=194791
2728         <rdar://problem/48179240>
2729
2730         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2731
2732         This patch adds an API test and replaces two instances of
2733         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2734
2735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2737         (TestWebKitAPI::TEST):
2738             Changed two strings to make sure the registrable domains are still considered
2739             invalid and pass the test.
2740         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2741         (TestWebKitAPI::TEST):
2742         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2743         (WTR::InjectedBundle::didReceiveMessageToPage):
2744
2745 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2746
2747         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2748         https://bugs.webkit.org/show_bug.cgi?id=195001
2749
2750         Reviewed by Carlos Garcia Campos.
2751
2752         API version 1.0 always includes the functionality previously guarded with
2753         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2754         unconditionally.
2755
2756         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2757         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2758         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2759         (WebViewTest::showInWindow): Ditto.
2760         (WebViewTest::hideView): Ditto.
2761         * wpe/backends/HeadlessViewBackend.cpp:
2762         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2763         * wpe/backends/ViewBackend.cpp:
2764         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2765         * wpe/backends/WindowViewBackend.cpp:
2766         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2767         WPE_BACKEND_CHECK_VERSION().
2768         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2769
2770 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2771
2772         [Flatpak] Add support for flatpak > 1.1.2
2773         https://bugs.webkit.org/show_bug.cgi?id=194088
2774
2775         Flatpak 1.2 is now out so we need to support that
2776         version now.
2777
2778         Reviewed by Michael Catanzaro.
2779
2780         * flatpak/flatpakutils.py:
2781         (check_flatpak):
2782         (FlatpakPackages.__init__):
2783         (FlatpakPackages.__detect_packages):
2784         (FlatpakPackages.__detect_packages.in):
2785         (FlatpakRepos.update):
2786
2787 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2788
2789         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2790         https://bugs.webkit.org/show_bug.cgi?id=194998
2791
2792         Reviewed by Carlos Garcia Campos.
2793
2794         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2795         to a Git checkout and using the latest commit containing various fixes
2796         and improvements.
2797
2798 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2799
2800         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2801         https://bugs.webkit.org/show_bug.cgi?id=194981
2802
2803         Reviewed by Žan Doberšek.
2804
2805         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2806         (TestWebKitAPI::TEST):
2807
2808 2019-02-23  Keith Miller  <keith_miller@apple.com>
2809
2810         Add new mac target numbers
2811         https://bugs.webkit.org/show_bug.cgi?id=194955
2812
2813         Reviewed by Tim Horton.
2814
2815         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2816         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2817         * MiniBrowser/Configurations/Base.xcconfig:
2818         * TestWebKitAPI/Configurations/Base.xcconfig:
2819         * WebKitTestRunner/Configurations/Base.xcconfig:
2820
2821 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2822
2823         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2824         https://bugs.webkit.org/show_bug.cgi?id=194846
2825
2826         Reviewed by Don Olmstead.
2827
2828         Added _search_paths() and _port_specific_expectations_files() for
2829         WinCairoPort.
2830
2831         * Scripts/webkitpy/port/win.py:
2832         (WinCairoPort.default_baseline_search_path):
2833         (WinCairoPort):
2834         (WinCairoPort._port_specific_expectations_files):
2835         (WinCairoPort._search_paths):
2836
2837 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2838
2839         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2840         https://bugs.webkit.org/show_bug.cgi?id=194963
2841
2842         Reviewed by Dean Jackson.
2843
2844         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2845         Do a `contains` check instead of `equals`, because in debug builds we
2846         put the GraphicsLayer pointer in a prefix.
2847
2848 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2849
2850         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2851         https://bugs.webkit.org/show_bug.cgi?id=194873
2852         <rdar://problem/46701974>
2853
2854         Reviewed by Tim Horton.
2855
2856         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2857
2858         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2859         (WTR::UIScriptController::menuRect const):
2860         (WTR::UIScriptController::isShowingMenu const):
2861         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2862         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2863         (WTR::UIScriptController::menuRect const):
2864
2865         Add a function to query the bounds of the callout menu in content coordinates.
2866
2867         (WTR::UIScriptController::isShowingMenu const):
2868
2869         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2870
2871         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2872         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2873         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2874         (WTR::UIScriptController::rectForMenuAction const):
2875         (WTR::UIScriptController::menuRect const):
2876         (WTR::UIScriptController::isShowingMenu const):
2877         (WTR::findViewInHierarchyOfType): Deleted.
2878
2879 2019-02-22  Chris Dumez  <cdumez@apple.com>
2880
2881         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2882         https://bugs.webkit.org/show_bug.cgi?id=194954
2883         <rdar://problem/48127957>
2884
2885         Reviewed by Alex Christensen.
2886
2887         Add API test coverage.
2888
2889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2890         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2891         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2892         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2893
2894 2019-02-22  Chris Dumez  <cdumez@apple.com>
2895
2896         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2897         https://bugs.webkit.org/show_bug.cgi?id=194924
2898         <rdar://problem/48216125>
2899
2900         Reviewed by Geoffrey Garen.
2901
2902         Add API test coverage.
2903
2904         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2905
2906 2019-02-22  Chris Dumez  <cdumez@apple.com>
2907
2908         Unreviewed, disable API test added in r241928 on iOS.
2909
2910         The cache is not enabled on devices with less than 3GB of RAM.
2911
2912         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2913
2914 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2915
2916         Hardcode Visual Viewports on everywhere except iOS WK1
2917         https://bugs.webkit.org/show_bug.cgi?id=194928
2918
2919         Reviewed by Zalan Bujtas.
2920
2921         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2922         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2923         set it to false. The setting has shipped for several years and there's no need to turn
2924         it off now.
2925
2926         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2927         Visual Viewports are not enabled.
2928         
2929         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2930         that only runs in WK2
2931
2932         * MiniBrowser/mac/SettingsController.h:
2933         * MiniBrowser/mac/SettingsController.m:
2934         (-[SettingsController init]):
2935         (-[SettingsController _populateMenu]):
2936         (-[SettingsController validateMenuItem:]):
2937         (-[SettingsController visualViewportEnabled]): Deleted.
2938         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2939         * MiniBrowser/mac/WK1BrowserWindowController.m:
2940         (-[WK1BrowserWindowController didChangeSettings]):
2941         * MiniBrowser/mac/WK2BrowserWindowController.m:
2942         (-[WK2BrowserWindowController didChangeSettings]):
2943
2944 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2945
2946         Discard cached processes when clearing website data store
2947         https://bugs.webkit.org/show_bug.cgi?id=194894
2948
2949         Reviewed by Chris Dumez.
2950
2951         Added a test case.
2952
2953         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2954         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2955
2956 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2957
2958         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2959         https://bugs.webkit.org/show_bug.cgi?id=194914
2960         <rdar://problem/47586889>
2961
2962         Reviewed by Geoffrey Garen.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2965         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2966         (TEST):
2967         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2968
2969 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2970
2971         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2972         <https://webkit.org/b/194761>
2973
2974         Reviewed by Myles Maxfield.
2975
2976         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2977         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2978         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2979         to use ARC-compliant cast.
2980         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2981         ARC-compliant cast.
2982         (WTR::installFakeHelvetica): Log `error` to console if
2983         CTFontManagerRegisterFontsForURL() fails, but only on supported
2984         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2985         Call CFRelease() on `error` to fix the leak.  Update to use
2986         ARC-compliant cast.
2987         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2988         cast.
2989
2990 2019-02-21  Chris Dumez  <cdumez@apple.com>
2991
2992         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2993         https://bugs.webkit.org/show_bug.cgi?id=194481
2994
2995         Reviewed by Alex Christensen.
2996
2997         Give the processes a chance to shutdown and wait until we reached the expected number
2998         of processes.
2999
3000         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3001
3002 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3003
3004         Fix the macOS build
3005
3006         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3007
3008 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3009
3010         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3011
3012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3013         I am a backwards.
3014
3015 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3016
3017         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3020         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3021         We could force on UI-side compositing, but I feel like the test might be more
3022         valuable exercising the normal path on each platform (though the original
3023         bug was also UI-side specific). Though we can't validate that the overlay
3024         layer was installed successfully, there are layout tests that do that.
3025
3026 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3027
3028         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3029         https://bugs.webkit.org/show_bug.cgi?id=194845
3030         <rdar://problem/47944579>
3031
3032         Reviewed by Antti Koivisto.
3033
3034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3036
3037 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3038
3039         [LFC][Floats] Add support for placing formatting roots in-between floats.
3040         https://bugs.webkit.org/show_bug.cgi?id=194902
3041
3042         Reviewed by Antti Koivisto.
3043
3044         * LayoutReloaded/misc/LFC-passing-tests.txt:
3045
3046 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3047
3048         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3049         https://bugs.webkit.org/show_bug.cgi?id=194901
3050
3051         Unreviewed build fix.
3052
3053         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3054         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3055         WPEBackend-fdo-0.1 as library name.
3056
3057 2019-02-21  Rob Buis  <rbuis@igalia.com>
3058
3059         Update MIME type parser
3060         https://bugs.webkit.org/show_bug.cgi?id=180526
3061
3062         Reviewed by Darin Adler.
3063
3064         Add tests involving leading and trailing whitespace, non-token
3065         characters and quoted strings.
3066
3067         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3068         (TestWebKitAPI::TEST):
3069
3070 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3071
3072         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3073         https://bugs.webkit.org/show_bug.cgi?id=194884
3074
3075         Reviewed by Michael Catanzaro.
3076
3077         * PlatformWin.cmake:
3078
3079 2019-02-20  Chris Dumez  <cdumez@apple.com>
3080
3081         Add API test for <rdar://problem/47471222>
3082         https://bugs.webkit.org/show_bug.cgi?id=194847
3083
3084         Reviewed by Alex Christensen.
3085
3086         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3087
3088 2019-02-20  Chris Dumez  <cdumez@apple.com>
3089
3090         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3091         https://bugs.webkit.org/show_bug.cgi?id=194872
3092         <rdar://problem/47924500>
3093
3094         Reviewed by Alex Christensen.
3095
3096         Add API test coverage.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3099
3100 2019-02-20  Jer Noble  <jer.noble@apple.com>
3101
3102         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3103         https://bugs.webkit.org/show_bug.cgi?id=191332
3104
3105         Reviewed by Dean Jackson.
3106
3107         * Scripts/git-is-in-range: Added.
3108
3109 2019-02-20  Andy Estes  <aestes@apple.com>
3110
3111         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3112         https://bugs.webkit.org/show_bug.cgi?id=194869
3113
3114         Rubber-stamped by Jer Noble.
3115
3116         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3117         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3118         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3119         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3121         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3122
3123 2019-02-20  Chris Dumez  <cdumez@apple.com>
3124
3125         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3126         https://bugs.webkit.org/show_bug.cgi?id=194857
3127         <rdar://problem/47759323>
3128
3129         Reviewed by Alex Christensen.
3130
3131         Add API test coverage.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3134
3135 2019-02-20  Chris Dumez  <cdumez@apple.com>
3136
3137         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3138         https://bugs.webkit.org/show_bug.cgi?id=194829
3139         <rdar://problem/47889906>
3140
3141         Reviewed by Alexey Proskuryakov.
3142
3143         Every time the TestOptions were changing we were creating both a new Web view and
3144         a new WKContext, which would start a new Network process. In most cases, we only
3145         need to contruct a new Web view and we do can keep reusing the same WKContext.
3146         This patch implements this optimization and thus avoids spinning a lot of new
3147         Network processes while running the layout tests.
3148
3149         * WebKitTestRunner/TestController.cpp:
3150         (WTR::TestController::generateContextConfiguration const):
3151         (WTR::TestController::generatePageConfiguration):
3152         (WTR::TestController::createWebViewWithOptions):
3153         (WTR::TestController::resetPreferencesToConsistentValues):
3154         (WTR::updateTestOptionsFromTestHeader):
3155         * WebKitTestRunner/TestController.h:
3156         * WebKitTestRunner/TestOptions.h:
3157         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3158         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3159         (WTR::TestOptions::hasSameInitializationOptions const):
3160         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3161         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3162         (WTR::TestController::platformAddTestOptions const):
3163
3164 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3165
3166         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3167         https://bugs.webkit.org/show_bug.cgi?id=167941
3168
3169         Reviewed by Carlos Garcia Campos.
3170
3171         * MiniBrowser/gtk/main.c:
3172         (filterSavedCallback): Added.
3173         (main): Support loading a JSON rule set file for content filtering.
3174         * MiniBrowser/wpe/main.cpp:
3175         (filterSavedCallback): Added.
3176         (main): Support loading a JSON rule set file for content filtering.
3177         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3178         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3179         (WTF::derefGPtr): Ditto.
3180         (testEmptyStore):
3181         (testSaveInvalidFilter):
3182         (testSaveLoadFilter):
3183         (testSavedFilterIdentifierMatch):
3184         (testRemoveFilter):
3185         (testSaveMultipleFilters):
3186         (testSaveFilterFromFile):
3187         (testFilterPersistence):
3188         (beforeAll):
3189         (afterAll):
3190         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3191         (removeOldInjectedContentAndResetLists): Also reset content filters.
3192         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3193         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3194         the element affected by the style sheet.
3195         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3196         and returns it to be used by tests.
3197         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3198         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3199         (serverCallback): Add support for serving a CSS style sheet for testing.
3200         (beforeAll): Add call to testUserContentManagerContentFilter().
3201         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3202
3203 2019-02-19  Keith Rollin  <krollin@apple.com>
3204
3205         Add timing information to build output
3206         https://bugs.webkit.org/show_bug.cgi?id=194839
3207         <rdar://problem/48219609>
3208
3209         Reviewed by Alexey Proskuryakov.
3210
3211         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3212         emit each project's build time to its output. E.g.,
3213
3214             ** BUILD SUCCEEDED ** [0.132 sec]
3215
3216         * Scripts/webkitdirs.pm:
3217         (XcodeOptions):
3218
3219 2019-02-19  Truitt Savell  <tsavell@apple.com>
3220
3221         Unreviewed, rolling out r241784.
3222
3223         Broke all OpenSource builds.
3224
3225         Reverted changeset:
3226
3227         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3228         instances view"
3229         https://bugs.webkit.org/show_bug.cgi?id=172848
3230         https://trac.webkit.org/changeset/241784
3231
3232 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3233
3234         [LFC][Floats] Remove redundant intersecting logic
3235         https://bugs.webkit.org/show_bug.cgi?id=194804
3236
3237         Reviewed by Antti Koivisto.
3238
3239         * LayoutReloaded/misc/LFC-passing-tests.txt:
3240
3241 2019-02-19  Dean Jackson  <dino@apple.com>
3242
3243         Clean-up output from generate-xcfilelists so it can be filtered
3244         https://bugs.webkit.org/show_bug.cgi?id=194795
3245
3246         Reviewed by Joseph Pecoraro (and Keith Rollin).
3247
3248         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3249         make a slight tweak to filter-build-webkit so such lines are marked
3250         as plain.
3251
3252         * Scripts/filter-build-webkit:
3253         * Scripts/generate-xcfilelists:
3254
3255 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3256
3257         pytest is not correctly auto-installed
3258         https://bugs.webkit.org/show_bug.cgi?id=194707
3259
3260         Reviewed by Carlos Garcia Campos.
3261
3262         * Scripts/webkitpy/thirdparty/__init__.py:
3263         (AutoinstallImportHook._install_pytest):
3264
3265 2019-02-18  Chris Dumez  <cdumez@apple.com>
3266
3267         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3268         https://bugs.webkit.org/show_bug.cgi?id=194797
3269         <rdar://problem/48055151>
3270
3271         Reviewed by Geoffrey Garen.
3272
3273         Add API test coverage.
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3276
3277 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3278
3279         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3280         https://bugs.webkit.org/show_bug.cgi?id=194670
3281         <rdar://problem/39066529>
3282
3283         Reviewed by Tim Horton.
3284
3285         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3286         pasted in an editable area as attachment elements.
3287
3288         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3289         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3290         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3291         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3292         (TestWebKitAPI::TEST):
3293         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3294         (WTR::InjectedBundlePage::InjectedBundlePage):
3295
3296 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3297
3298         Fix API test after r241728
3299        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3300
3301         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3302         (TEST):
3303         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3304
3305 2019-02-18  Daniel Bates  <dabates@apple.com>
3306
3307         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3308         https://bugs.webkit.org/show_bug.cgi?id=192824
3309         <rdar://problem/47100332>
3310
3311         Reviewed by Wenson Hsieh.
3312
3313         Fix a bug where the wrong usage code was used for F13 thru F24.
3314
3315         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3316         (keyCodeForDOMFunctionKey):
3317
3318 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3319
3320         Bytecode cache should a have a boot-specific validation
3321         https://bugs.webkit.org/show_bug.cgi?id=194769
3322         <rdar://problem/48149509>
3323
3324         Reviewed by Keith Miller.
3325
3326         Add test for WTF::bootSessionUUIDString()
3327
3328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3329         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3330         (TEST):
3331
3332 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3333
3334         Disable safe browsing in WKWebView and remove its WKPreferences API
3335         https://bugs.webkit.org/show_bug.cgi?id=194723
3336         <rdar://problem/48122993>
3337
3338         Reviewed by Geoffrey Garen.
3339
3340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3341         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3342         (TEST):
3343         (safeBrowsingView):
3344         Make tests use SPI instead of API.
3345
3346 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3347
3348         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3349         https://bugs.webkit.org/show_bug.cgi?id=194586
3350
3351         Reviewed by Ross Kirsling.
3352
3353         * DumpRenderTree/win/DumpRenderTree.cpp:
3354         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3355         * Scripts/webkitpy/port/driver.py:
3356         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3357
3358 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3359
3360         Unreviewed, rolling out r241620.
3361
3362         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3363         (Requested by ddkilzer on #webkit.)
3364
3365         Reverted changeset:
3366
3367         "[WTF] Add environment variable helpers"
3368         https://bugs.webkit.org/show_bug.cgi?id=192405
3369         https://trac.webkit.org/changeset/241620
3370
3371 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3372
3373         [LFC] RenderImage's default intrinsic size is 0.
3374         https://bugs.webkit.org/show_bug.cgi?id=194745
3375
3376         Reviewed by Antti Koivisto.
3377
3378         * LayoutReloaded/misc/LFC-passing-tests.txt:
3379
3380 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3381
3382         [LFC][BFC] Add support for block replaced intrinsic width.
3383         https://bugs.webkit.org/show_bug.cgi?id=194705
3384
3385         Reviewed by Simon Fraser.
3386
3387         * LayoutReloaded/misc/LFC-passing-tests.txt:
3388
3389 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3390
3391         [LFC] Apply min/max width constraints to preferred width computation
3392         https://bugs.webkit.org/show_bug.cgi?id=194739
3393
3394         Reviewed by Simon Fraser.
3395
3396         * LayoutReloaded/misc/LFC-passing-tests.txt:
3397
3398 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3399
3400         [WTF] Add environment variable helpers
3401         https://bugs.webkit.org/show_bug.cgi?id=192405
3402
3403         Reviewed by Michael Catanzaro.
3404
3405         * DumpRenderTree/mac/DumpRenderTree.mm:
3406         (libraryPathForDumpRenderTree):
3407         * DumpRenderTree/win/DumpRenderTree.cpp:
3408         (libraryPathForDumpRenderTree):
3409         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3410         (setUpIOSLayoutTestCommunication):
3411         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3412         (beforeAll):
3413         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3414         (main):
3415         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3416         (WebKitTestBus::run):
3417         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3418         (WTR::getOutputDir):
3419         (WTR::initializeFontConfigSetting):
3420         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3421         (WTR::InjectedBundle::platformInitialize):
3422         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3423         (WTR::topLevelPath):
3424         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3425         (WTR::topLevelPath):
3426         (WTR::getOutputDir):
3427         (WTR::activateFonts):
3428         * WebKitTestRunner/TestController.cpp:
3429         (WTR::TestController::libraryPathForTesting):
3430         (WTR::TestController::generateContextConfiguration const):
3431         (WTR::TestController::generatePageConfiguration):
3432         (WTR::TestController::decideDestinationWithSuggestedFilename):
3433         (WTR::TestController::platformAdjustContext):
3434         * WebKitTestRunner/TestController.h:
3435         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3436         (WTR::TestController::cocoaPlatformInitialize):
3437         (WTR::TestController::platformAdjustContext):
3438         * WebKitTestRunner/gtk/main.cpp:
3439         (main):
3440         * WebKitTestRunner/mac/TestControllerMac.mm:
3441         (WTR::TestController::configureContentExtensionForTest):
3442         * WebKitTestRunner/wpe/main.cpp:
3443         (main):
3444         Utilize WTF::Environment where possible.
3445
3446 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3447
3448         [iOS] WKWebView callout bar is missing Change Writing Direction item
3449         https://bugs.webkit.org/show_bug.cgi?id=190015
3450         <rdar://problem/44810366>
3451
3452         Reviewed by Tim Horton.
3453
3454         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3455         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3456
3457         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3458         (TestWebKitAPI::TEST):
3459
3460 2019-02-15  Chris Dumez  <cdumez@apple.com>
3461
3462         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3463         https://bugs.webkit.org/show_bug.cgi?id=194717
3464         <rdar://problem/47884404>
3465
3466         Reviewed by Brady Eidson.
3467
3468         Add API test coverage.
3469
3470         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3471
3472 2019-02-15  Youenn Fablet  <youenn@apple.com>
3473
3474         Make navigator.mediaDevices SecureContext
3475         https://bugs.webkit.org/show_bug.cgi?id=194666
3476
3477         Reviewed by Eric Carlson.
3478
3479         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3480         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3481         (TEST_F):
3482
3483 2019-02-15  Brian Burg  <bburg@apple.com>
3484
3485         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3486         https://bugs.webkit.org/show_bug.cgi?id=194411
3487         <rdar://problem/47787614>
3488
3489         Reviewed by Joseph Pecoraro.
3490
3491         Remove unnecessary soft linking macro usage.
3492
3493         * DumpRenderTree/mac/TestRunnerMac.mm:
3494         (TestRunner::inspectorTestStubURL):
3495         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3496         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3497         (WTR::TestRunner::inspectorTestStubURL):
3498
3499 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3500
3501         Unreviewed, rolling out r241559 and r241566.
3502         https://bugs.webkit.org/show_bug.cgi?id=194710
3503
3504         Causes layout test crashes under GuardMalloc (Requested by
3505         ryanhaddad on #webkit).
3506
3507         Reverted changesets:
3508
3509         "[WTF] Add environment variable helpers"
3510         https://bugs.webkit.org/show_bug.cgi?id=192405
3511         https://trac.webkit.org/changeset/241559
3512
3513         "Unreviewed build fix for WinCairo Debug after r241559."
3514         https://trac.webkit.org/changeset/241566
3515
3516 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3517
3518         [LFC] Out-of-flow box is never a float box
3519         https://bugs.webkit.org/show_bug.cgi?id=194704
3520
3521         Reviewed by Antti Koivisto.
3522
3523         * LayoutReloaded/misc/LFC-passing-tests.txt:
3524
3525 2019-02-10  Darin Adler  <darin@apple.com>
3526
3527         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3528         https://bugs.webkit.org/show_bug.cgi?id=194487
3529
3530         Reviewed by Daniel Bates.
3531
3532         * DumpRenderTree/win/DumpRenderTree.cpp:
3533         (applicationId): Use makeString instead of String::format.
3534         (main): Ditto.
3535         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3536         (TestWebKitAPI::Util::createURLForResource): Ditto.
3537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3538         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3539
3540         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3541         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3542         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3543         (WTR::createStringWithAttributes): Use appendLiteral.
3544         (WTR::AccessibilityUIElement::helpText const): Ditto.
3545         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3546         directly instead of using String::format.
3547         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3548         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3549
3550 2019-02-15  Truitt Savell  <tsavell@apple.com>
3551
3552         Unreviewed, rolling out r241564.
3553
3554         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3555
3556         Reverted changeset:
3557
3558         "[Mac] WebInspectorUI.framework does not need to be soft-
3559         linked anymore"
3560         https://bugs.webkit.org/show_bug.cgi?id=194411
3561         https://trac.webkit.org/changeset/241564
3562
3563 2019-02-15  Saam barati  <sbarati@apple.com>
3564
3565         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3566         https://bugs.webkit.org/show_bug.cgi?id=194036
3567
3568         Reviewed by Yusuke Suzuki.
3569
3570         * Scripts/run-jsc-stress-tests:
3571
3572 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3573
3574         Fix the build.
3575
3576         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3577         (WTR::UIScriptController::drawSquareInEditableImage):
3578         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3579         (TestWebKitAPI::drawSquareInEditableImage):
3580
3581 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3582
3583         Fix the build.
3584
3585         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3586         (WTR::UIScriptController::drawSquareInEditableImage):
3587         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3588         (TestWebKitAPI::drawSquareInEditableImage):
3589
3590 2019-02-14  Brian Burg  <bburg@apple.com>
3591
3592         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3593         https://bugs.webkit.org/show_bug.cgi?id=194411
3594         <rdar://problem/47787614>
3595
3596         Reviewed by Joseph Pecoraro.
3597
3598         Remove unnecessary soft linking macro usage.
3599
3600         * DumpRenderTree/mac/TestRunnerMac.mm:
3601         (TestRunner::inspectorTestStubURL):
3602         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3603         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3604         (WTR::TestRunner::inspectorTestStubURL):
3605
3606 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3607
3608         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3609         https://bugs.webkit.org/show_bug.cgi?id=194599
3610
3611         Reviewed by Lucas Forschler.
3612
3613         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3614         (StatusBubble._build_bubble):
3615
3616 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3617
3618         [ews-app] Set Foreign Key in Django build model
3619         https://bugs.webkit.org/show_bug.cgi?id=194667
3620
3621         Reviewed by Lucas Forschler.
3622
3623         * BuildSlaveSupport/ews-app/ews/models/build.py:
3624         (Build):
3625
3626 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3627
3628         [WTF] Add environment variable helpers
3629         https://bugs.webkit.org/show_bug.cgi?id=192405
3630
3631         Reviewed by Michael Catanzaro.
3632
3633         * DumpRenderTree/mac/DumpRenderTree.mm:
3634         (libraryPathForDumpRenderTree):
3635         * DumpRenderTree/win/DumpRenderTree.cpp:
3636         (libraryPathForDumpRenderTree):
3637         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3638         (setUpIOSLayoutTestCommunication):
3639         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3640         (TestWebKitAPI::strip):
3641         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3642         (beforeAll):
3643         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3644         (main):
3645         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3646         (WebKitTestBus::run):
3647         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3648         (WTR::getOutputDir):
3649         (WTR::initializeFontConfigSetting):
3650         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3651         (WTR::InjectedBundle::platformInitialize):
3652         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3653         (WTR::topLevelPath):
3654         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3655         (WTR::topLevelPath):
3656         (WTR::getOutputDir):
3657         (WTR::activateFonts):
3658         * WebKitTestRunner/TestController.cpp:
3659         (WTR::TestController::libraryPathForTesting):
3660         (WTR::TestController::generateContextConfiguration const):
3661         (WTR::TestController::generatePageConfiguration):
3662         (WTR::TestController::decideDestinationWithSuggestedFilename):
3663         (WTR::TestController::platformAdjustContext):
3664         * WebKitTestRunner/TestController.h:
3665         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3666         (WTR::TestController::cocoaPlatformInitialize):
3667         (WTR::TestController::platformAdjustContext):
3668         * WebKitTestRunner/gtk/main.cpp:
3669         (main):
3670         * WebKitTestRunner/mac/TestControllerMac.mm:
3671         (WTR::TestController::configureContentExtensionForTest):
3672         * WebKitTestRunner/wpe/main.cpp:
3673         (main):
3674         Utilize WTF::Environment where possible.
3675
3676 2019-02-14  Chris Dumez  <cdumez@apple.com>
3677
3678         [PSON] Introduce a WebContent Process cache
3679         https://bugs.webkit.org/show_bug.cgi?id=194594
3680         <rdar://problem/46793397>
3681
3682         Reviewed by Geoff Garen.
3683
3684         Update API tests to turn on the WebContent Process cache.
3685
3686         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3687
3688 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3689
3690         Unreviewed, build fix after r241480
3691
3692         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3693         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3694         (-[DragAndDropSimulator initWithWebView:]):
3695
3696 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3697
3698         AX: ARIA Reflection was disabled in error
3699         https://bugs.webkit.org/show_bug.cgi?id=194647
3700         <rdar://problem/48068336>
3701
3702         Reviewed by Ryosuke Niwa.
3703
3704         Remove test override now that this feature should be enabled by default.
3705
3706         * WebKitTestRunner/TestController.cpp:
3707         (WTR::TestController::resetPreferencesToConsistentValues):
3708
3709 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3710
3711         Unreviewed, rolling out r241486.
3712         https://bugs.webkit.org/show_bug.cgi?id=194655
3713
3714         causing API failures in builds (Requested by ShawnRoberts on
3715         #webkit).
3716
3717         Reverted changeset:
3718
3719         "[Cocoa] Media elements will restart network buffering just</