WebKit.ApplicationManifestBasic API test is failing when enabling PSON
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-14  Chris Dumez  <cdumez@apple.com>
2
3         WebKit.ApplicationManifestBasic API test is failing when enabling PSON
4         https://bugs.webkit.org/show_bug.cgi?id=191602
5
6         Reviewed by Alex Christensen.
7
8         Add API test coverage.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
11
12 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
13
14         webkitpy: Refactor port code for devices
15         https://bugs.webkit.org/show_bug.cgi?id=191568
16         <rdar://problem/46005821>
17
18         Reviewed by Alex Christensen.
19
20         watchOS and iOS device ports share many characteristics in testing, mostly due
21         to the fact that both are devices.
22
23         * Scripts/webkitpy/port/device_port.py: Added.
24         (DevicePort): Add base class that all simulated/physical device ports share.
25         (DevicePort.__init__):
26         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
27         (DevicePort._generate_all_test_configurations): Ditto.
28         (DevicePort.child_processes): Ditto.
29         (DevicePort.driver_name): Ditto.
30         (DevicePort.target_host): Generalize worker access to attached devices and
31         simulated devices based on the device manager.
32         (DevicePort.devices): Return a list of all devices associated with this port.
33         (DevicePort._create_devices):
34         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
35         (DevicePort._install): Moved from iOS port.
36         (DevicePort.setup_test_run): Ditto.
37         (DevicePort.clean_up_test_run): Ditto.
38         (DevicePort.did_spawn_worker): Ditto.
39         (DevicePort.setup_environ_for_server): Ditto.
40         * Scripts/webkitpy/port/ios.py:
41         (IOSPort):
42         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
43         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
44         (IOSPort.driver_name): Ditto.
45         (IOSPort._generate_all_test_configurations): Ditto.
46         (IOSPort.child_processes): Ditto.
47         (IOSPort._testing_device): Ditto.
48         (IOSPort.target_host): Ditto.
49         (IOSPort._create_devices): Ditto.
50         (IOSPort.setup_test_run): Ditto.
51         (IOSPort.clean_up_test_run): Ditto.
52         (IOSPort.did_spawn_worker): Ditto.
53         * Scripts/webkitpy/port/ios_device.py:
54         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
55         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
56         (IOSDevicePort._get_crash_log): Ditto.
57         (IOSDevicePort.ios_version): Ditto.
58         (IOSDevicePort._create_devices): Ditto.
59         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
60         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
61         * Scripts/webkitpy/port/ios_device_unittest.py:
62         (IOSDeviceTest.test_get_crash_log):
63         * Scripts/webkitpy/port/ios_simulator.py:
64         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
65         (IOSSimulatorPort._create_devices): Clean up logging statement.
66         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
67         across all devices.
68         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
69         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
70         * Scripts/webkitpy/port/ios_simulator_unittest.py:
71         (IOSSimulatorTest.test_32bit):
72         (IOSSimulatorTest.test_64bit):
73
74 2018-11-14  Chris Dumez  <cdumez@apple.com>
75
76         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
77         https://bugs.webkit.org/show_bug.cgi?id=191624
78
79         Reviewed by Alex Christensen.
80
81         Add API test coverage.
82
83         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
84         (runWKHTTPCookieStoreWithoutProcessPool):
85         (TEST):
86
87 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
88
89         [WebAuthN] Support CTAP HID authenticators on macOS
90         https://bugs.webkit.org/show_bug.cgi?id=188623
91         <rdar://problem/43353777>
92
93         Reviewed by Brent Fulgham and Chris Dumez.
94
95         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
96         to hid devices.
97
98         * MiniBrowser/MiniBrowser.entitlements:
99         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
100         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
101
102 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
103
104         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
105         https://bugs.webkit.org/show_bug.cgi?id=191616
106
107         Reviewed by Chris Dumez.
108
109         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
110         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
111         resulting in the use-after-free.
112
113         Made the tests more robust by clearing geolocation provider before exiting each test
114         since we can't really prevent WKView from entering an autorelease pool.
115
116         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
117         instead of simply the end of the navigation so that the test would continue to work
118         even if a web content process was created for the second web view (lowAccuracyWebView)
119
120         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
121         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
122         (TestWebKitAPI::clearGeolocationProvider): Added.
123         (TestWebKitAPI::runJavaScriptAlert): Added.
124         (TestWebKitAPI::didFinishNavigation): Deleted.
125         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
126
127 2018-11-13  Chris Dumez  <cdumez@apple.com>
128
129         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
130         https://bugs.webkit.org/show_bug.cgi?id=191618
131
132         Reviewed by Ryosuke Niwa.
133
134         Update API test to explicitly disable automatic process prewarning since it is testing
135         manual prewarming.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
138         (TEST):
139
140 2018-11-13  Chris Dumez  <cdumez@apple.com>
141
142         Several Service Worker API tests are failing when enabling PSON
143         https://bugs.webkit.org/show_bug.cgi?id=191619
144
145         Reviewed by Youenn Fablet.
146
147         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
148         not impacted by process prewarming.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
151
152 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
153
154         [iOS] Do not show selection UI for editable elements with opacity near zero
155         https://bugs.webkit.org/show_bug.cgi?id=191442
156         <rdar://problem/45958625>
157
158         Reviewed by Simon Fraser.
159
160         Add a couple of new testing helpers to UIScriptController.
161
162         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
163         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
164         (WTR::UIScriptController::textSelectionRangeRects const):
165         (WTR::UIScriptController::selectionCaretViewRect const):
166         (WTR::UIScriptController::selectionRangeViewRects const):
167         * TestRunnerShared/UIScriptContext/UIScriptController.h:
168         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
169         (WTR::UIScriptController::textSelectionRangeRects const):
170
171         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
172         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
173         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
174         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
175         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
176
177         Also, drive-by fix a leaked `NSMutableArray`.
178
179         (WTR::UIScriptController::selectionStartGrabberViewRect const):
180         (WTR::UIScriptController::selectionEndGrabberViewRect const):
181         (WTR::UIScriptController::selectionCaretViewRect const):
182         (WTR::UIScriptController::selectionRangeViewRects const):
183
184         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
185         rects are also clamped to WKContentView bounds.
186
187 2018-11-13  Daniel Bates  <dabates@apple.com>
188
189         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
190         https://bugs.webkit.org/show_bug.cgi?id=173341
191         <rdar://problem/32752890>
192
193         Reviewed by Simon Fraser.
194
195         There is little value to making a distinction between forward declarations
196         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
197         the contents of these two headers can conflict with each other following
198         r218275 as DumpRenderTree includes both headers. Instead we should remove
199         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
200
201         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
202         * DumpRenderTree/mac/DumpRenderTree.mm:
203         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
204         * WebKitTestRunner/Configurations/Base.xcconfig:
205         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
206         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
207         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
208         * WebKitTestRunner/ios/HIDEventGenerator.h:
209         * WebKitTestRunner/ios/HIDEventGenerator.mm:
210         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
211         * WebKitTestRunner/ios/TestControllerIOS.mm:
212         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
213         * WebKitTestRunner/ios/mainIOS.mm:
214
215 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
216
217         Remove WebKitTestRunnerLib's build warnings.
218         https://bugs.webkit.org/show_bug.cgi?id=191580
219
220         Reviewed by Fujii Hironori.
221
222         Include cmakeconfig.h in precompiled header.
223
224         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
225
226 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
227
228         Implement Cache API support for WPE/GTK
229         https://bugs.webkit.org/show_bug.cgi?id=178316
230
231         Reviewed by Michael Catanzaro.
232
233         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
234         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
235
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::generatePageConfiguration):
238         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
239         (WTR::initializeWebViewConfiguration):
240
241 2018-11-12  Christopher Reid  <chris.reid@sony.com>
242
243         [Curl] Reject entire cookie if the domain fails a tailmatch.
244         https://bugs.webkit.org/show_bug.cgi?id=191406
245
246         Reviewed by Youenn Fablet.
247
248         Added unittests for Curl cookie implementation.
249
250         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
251         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
252
253 2018-11-12  Alex Christensen  <achristensen@webkit.org>
254
255         [iOS] Implement safe browsing in WebKit
256         https://bugs.webkit.org/show_bug.cgi?id=191441
257
258         Reviewed by Tim Horton.
259
260         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
261         (checkTitleAndClick):
262         (TEST):
263
264 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
265
266         [Curl] Add API Test for Curl cookie backend.
267         https://bugs.webkit.org/show_bug.cgi?id=191493
268
269         Reviewed by Youenn Fablet.
270
271         Add unit test to TestWebCore.
272
273         * TestWebKitAPI/PlatformWin.cmake:
274         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
275
276 2018-11-12  Tim Horton  <timothy_horton@apple.com>
277
278         Make it possible to edit images inline
279         https://bugs.webkit.org/show_bug.cgi?id=191352
280         <rdar://problem/30107985>
281
282         Reviewed by Dean Jackson.
283
284         * WebKitTestRunner/TestController.cpp:
285         (WTR::updateTestOptionsFromTestHeader):
286         * WebKitTestRunner/TestOptions.h:
287         (WTR::TestOptions::hasSameInitializationOptions const):
288         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
289         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
290         (WTR::TestController::platformCreateWebView):
291         Add a test option to enable editable images.
292
293         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
294         (WTR::UIScriptController::drawSquareInEditableImage):
295         (WTR::UIScriptController::numberOfStrokesInEditableImage):
296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
298         (WTR::UIScriptController::drawSquareInEditableImage):
299         (WTR::UIScriptController::numberOfStrokesInEditableImage):
300         * TestRunnerShared/UIScriptContext/UIScriptController.h:
301         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
302         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
303         (WTR::findEditableImageCanvas):
304         (WTR::UIScriptController::drawSquareInEditableImage):
305         (WTR::UIScriptController::numberOfStrokesInEditableImage):
306         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
307         and also to retrieve the number of strokes currently on the PKCanvasView.
308         Currently this just takes the first canvas; we might need to make it
309         take an identifier or something in the future if we need tests with multiple
310         canvases. The indirect testing mechanism is required because PKCanvasView
311         can currently not actually paint its strokes in the Simulator.
312
313 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
314
315         [MediaStream] Screen capture should be an experimental feature on OSX only
316         https://bugs.webkit.org/show_bug.cgi?id=191552
317
318         Unreviewed test gardening.
319
320         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
321
322 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
323
324         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
325         https://bugs.webkit.org/show_bug.cgi?id=189230
326         <rdar://problem/44050379>
327
328         Reviewed by Joseph Pecoraro.
329
330         Runs all png images through zopflipng. This results in a smaller file
331         size and takes care of this issue as a byproduct.
332
333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
383
384 2018-11-12  Tim Horton  <timothy_horton@apple.com>
385
386         Modernize WebKit Tools Xcode projects for localization's sake
387         https://bugs.webkit.org/show_bug.cgi?id=191495
388
389         Reviewed by Alexey Proskuryakov.
390
391         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
393         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
394         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
395         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
396         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
397         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
399         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
400         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
401         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
402         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
403         These are less important because they're not localized, but since
404         I made the style checker complain, it now complains any time anyone
405         touches any of these projects... so upgrade them.
406
407 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
408
409         webkitpy: Check for specific process instead of using data migrator
410         https://bugs.webkit.org/show_bug.cgi?id=191551
411         <rdar://problem/45993156>
412
413         Rubber-stamped by Aakash Jain.
414
415         It's possible for the data migrator process to be stuck, but for a simulator to be
416         usable. Use device-specific processes to detect when a device is usable.
417
418         * Scripts/webkitpy/xcode/simulated_device.py:
419         (SimulatedDeviceManager._wait_until_device_is_usable):
420         (SimulatedDeviceManager):
421         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
422         since this implies that a device is booted.
423         (SimulatedDeviceManager.swap): Ditto.
424         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
425         process indicating the device is usable can be found.
426         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
427         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
428         it triggers the logic in is_usable()
429
430 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
431
432         Resurrect WebKitTestRunner for Windows port
433         https://bugs.webkit.org/show_bug.cgi?id=189257
434
435         Reviewed by Fujii Hironori.
436
437         Implement WebKitTestRunner for WinCairo.
438
439         * PlatformWin.cmake:
440         * Scripts/build-webkittestrunner:
441         * WebKitTestRunner/CMakeLists.txt:
442         * WebKitTestRunner/EventSenderProxy.h:
443         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
444         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
445         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
446         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
447         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
448         (WTR::rangeToStr):
449         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
450         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
451         (WTR::TestRunner::TestRunner):
452         * WebKitTestRunner/InjectedBundle/TestRunner.h:
453         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
454         (WTR::AccessibilityController::resetToConsistentState):
455         (WTR::AccessibilityController::accessibleElementById):
456         (WTR::AccessibilityController::platformName):
457         (WTR::AccessibilityController::rootElement):
458         (WTR::AccessibilityController::focusedElement):
459         (WTR::AccessibilityController::addNotificationListener):
460         (WTR::AccessibilityController::removeNotificationListener):
461         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
462         (WTR::AccessibilityUIElement::AccessibilityUIElement):
463         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
464         (WTR::AccessibilityUIElement::isEqual):
465         (WTR::AccessibilityUIElement::getChildren):
466         (WTR::AccessibilityUIElement::getChildrenWithRange):
467         (WTR::AccessibilityUIElement::childrenCount):
468         (WTR::AccessibilityUIElement::elementAtPoint):
469         (WTR::AccessibilityUIElement::indexOfChild):
470         (WTR::AccessibilityUIElement::childAtIndex):
471         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
472         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
473         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
474         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
475         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
476         (WTR::AccessibilityUIElement::rowAtIndex):
477         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
478         (WTR::AccessibilityUIElement::selectedChildrenCount const):
479         (WTR::AccessibilityUIElement::selectedRowAtIndex):
480         (WTR::AccessibilityUIElement::titleUIElement):
481         (WTR::AccessibilityUIElement::parentElement):
482         (WTR::AccessibilityUIElement::disclosedByRow):
483         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
484         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
485         (WTR::AccessibilityUIElement::attributesOfChildren):
486         (WTR::AccessibilityUIElement::allAttributes):
487         (WTR::AccessibilityUIElement::stringAttributeValue):
488         (WTR::AccessibilityUIElement::numberAttributeValue):
489         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
490         (WTR::AccessibilityUIElement::rowHeaders const):
491         (WTR::AccessibilityUIElement::columnHeaders const):
492         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
493         (WTR::AccessibilityUIElement::boolAttributeValue):
494         (WTR::AccessibilityUIElement::isAttributeSettable):
495         (WTR::AccessibilityUIElement::isAttributeSupported):
496         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
497         (WTR::AccessibilityUIElement::role):
498         (WTR::AccessibilityUIElement::subrole):
499         (WTR::AccessibilityUIElement::roleDescription):
500         (WTR::AccessibilityUIElement::computedRoleString):
501         (WTR::AccessibilityUIElement::title):
502         (WTR::AccessibilityUIElement::description):
503         (WTR::AccessibilityUIElement::orientation const):
504         (WTR::AccessibilityUIElement::stringValue):
505         (WTR::AccessibilityUIElement::language):
506         (WTR::AccessibilityUIElement::helpText const):
507         (WTR::AccessibilityUIElement::x):
508         (WTR::AccessibilityUIElement::y):
509         (WTR::AccessibilityUIElement::width):
510         (WTR::AccessibilityUIElement::height):
511         (WTR::AccessibilityUIElement::clickPointX):
512         (WTR::AccessibilityUIElement::clickPointY):
513         (WTR::AccessibilityUIElement::intValue const):
514         (WTR::AccessibilityUIElement::minValue):
515         (WTR::AccessibilityUIElement::maxValue):
516         (WTR::AccessibilityUIElement::valueDescription):
517         (WTR::AccessibilityUIElement::insertionPointLineNumber):
518         (WTR::AccessibilityUIElement::isPressActionSupported):
519         (WTR::AccessibilityUIElement::isIncrementActionSupported):
520         (WTR::AccessibilityUIElement::isDecrementActionSupported):
521         (WTR::AccessibilityUIElement::isEnabled):
522         (WTR::AccessibilityUIElement::isRequired const):
523         (WTR::AccessibilityUIElement::isFocused const):
524         (WTR::AccessibilityUIElement::isSelected const):
525         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
526         (WTR::AccessibilityUIElement::isExpanded const):
527         (WTR::AccessibilityUIElement::isChecked const):
528         (WTR::AccessibilityUIElement::isIndeterminate const):
529         (WTR::AccessibilityUIElement::hierarchicalLevel const):
530         (WTR::AccessibilityUIElement::speakAs):
531         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
532         (WTR::AccessibilityUIElement::ariaDropEffects const):
533         (WTR::AccessibilityUIElement::lineForIndex):
534         (WTR::AccessibilityUIElement::rangeForLine):
535         (WTR::AccessibilityUIElement::rangeForPosition):
536         (WTR::AccessibilityUIElement::boundsForRange):
537         (WTR::AccessibilityUIElement::stringForRange):
538         (WTR::AccessibilityUIElement::attributedStringForRange):
539         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
540         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
541         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
542         (WTR::AccessibilityUIElement::selectTextWithCriteria):
543         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
544         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
545         (WTR::AccessibilityUIElement::attributesOfColumns):
546         (WTR::AccessibilityUIElement::attributesOfRows):
547         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
548         (WTR::AccessibilityUIElement::attributesOfHeader):
549         (WTR::AccessibilityUIElement::rowCount):
550         (WTR::AccessibilityUIElement::columnCount):
551         (WTR::AccessibilityUIElement::indexInTable):
552         (WTR::AccessibilityUIElement::rowIndexRange):
553         (WTR::AccessibilityUIElement::columnIndexRange):
554         (WTR::AccessibilityUIElement::cellForColumnAndRow):
555         (WTR::AccessibilityUIElement::horizontalScrollbar const):
556         (WTR::AccessibilityUIElement::verticalScrollbar const):
557         (WTR::AccessibilityUIElement::selectedTextRange):
558         (WTR::AccessibilityUIElement::setSelectedTextRange):
559         (WTR::AccessibilityUIElement::increment):
560         (WTR::AccessibilityUIElement::decrement):
561         (WTR::AccessibilityUIElement::showMenu):
562         (WTR::AccessibilityUIElement::press):
563         (WTR::AccessibilityUIElement::setSelectedChild const):
564         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
565         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
566         (WTR::AccessibilityUIElement::clearSelectedChildren const):
567         (WTR::AccessibilityUIElement::accessibilityValue const):
568         (WTR::AccessibilityUIElement::documentEncoding):
569         (WTR::AccessibilityUIElement::documentURI):
570         (WTR::AccessibilityUIElement::url):
571         (WTR::AccessibilityUIElement::addNotificationListener):
572         (WTR::AccessibilityUIElement::removeNotificationListener):
573         (WTR::AccessibilityUIElement::isFocusable const):
574         (WTR::AccessibilityUIElement::isSelectable const):
575         (WTR::AccessibilityUIElement::isMultiSelectable const):
576         (WTR::AccessibilityUIElement::isVisible const):
577         (WTR::AccessibilityUIElement::isOffScreen const):
578         (WTR::AccessibilityUIElement::isCollapsed const):
579         (WTR::AccessibilityUIElement::isIgnored const):
580         (WTR::AccessibilityUIElement::isSingleLine const):
581         (WTR::AccessibilityUIElement::isMultiLine const):
582         (WTR::AccessibilityUIElement::hasPopup const):
583         (WTR::AccessibilityUIElement::takeFocus):
584         (WTR::AccessibilityUIElement::takeSelection):
585         (WTR::AccessibilityUIElement::addSelection):
586         (WTR::AccessibilityUIElement::removeSelection):
587         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
588         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
589         (WTR::AccessibilityUIElement::textMarkerRangeLength):
590         (WTR::AccessibilityUIElement::previousTextMarker):
591         (WTR::AccessibilityUIElement::nextTextMarker):
592         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
593         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
594         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
595         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
596         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
597         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
598         (WTR::AccessibilityUIElement::textMarkerForPoint):
599         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
600         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
601         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
602         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
603         (WTR::AccessibilityUIElement::indexForTextMarker):
604         (WTR::AccessibilityUIElement::isTextMarkerValid):
605         (WTR::AccessibilityUIElement::textMarkerForIndex):
606         (WTR::AccessibilityUIElement::startTextMarker):
607         (WTR::AccessibilityUIElement::endTextMarker):
608         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
609         (WTR::AccessibilityUIElement::scrollToMakeVisible):
610         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
611         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
612         (WTR::AccessibilityUIElement::supportedActions const):
613         (WTR::AccessibilityUIElement::pathDescription const):
614         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
615         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
616         (WTR::AccessibilityUIElement::classList const):
617         (WTR::AccessibilityUIElement::characterAtOffset):
618         (WTR::AccessibilityUIElement::wordAtOffset):
619         (WTR::AccessibilityUIElement::lineAtOffset):
620         (WTR::AccessibilityUIElement::sentenceAtOffset):
621         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
622         (WTR::activateFonts):
623         (WTR::installFakeHelvetica):
624         (WTR::uninstallFakeHelvetica):
625         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
626         (WTR::InjectedBundle::platformInitialize):
627         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
628         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
629         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
630         (WTR::TestRunner::pathToLocalResource):
631         (WTR::TestRunner::inspectorTestStubURL):
632         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
633         (WTR::TestRunner::platformInitialize):
634         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
635         (WTR::TestRunner::installFakeHelvetica):
636         * WebKitTestRunner/PlatformWebView.h:
637         * WebKitTestRunner/PlatformWin.cmake: Added.
638         * WebKitTestRunner/TestController.cpp:
639         (WTR::TestController::resetStateToConsistentValues):
640         (WTR::createTestURL):
641         * WebKitTestRunner/TestInvocation.cpp:
642         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
643         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
644         (WTR::EventSenderProxy::EventSenderProxy):
645         (WTR::EventSenderProxy::~EventSenderProxy):
646         (WTR::EventSenderProxy::mouseDown):
647         (WTR::EventSenderProxy::mouseUp):
648         (WTR::EventSenderProxy::mouseMoveTo):
649         (WTR::EventSenderProxy::mouseScrollBy):
650         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
651         (WTR::EventSenderProxy::continuousMouseScrollBy):
652         (WTR::EventSenderProxy::leapForward):
653         (WTR::EventSenderProxy::keyDown):
654         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
655         (WTR::registerWindowClass):
656         (WTR::PlatformWebView::PlatformWebView):
657         (WTR::PlatformWebView::~PlatformWebView):
658         (WTR::PlatformWebView::resizeTo):
659         (WTR::PlatformWebView::page):
660         (WTR::PlatformWebView::focus):
661         (WTR::PlatformWebView::windowFrame):
662         (WTR::PlatformWebView::setWindowFrame):
663         (WTR::PlatformWebView::didInitializeClients):
664         (WTR::PlatformWebView::addChromeInputField):
665         (WTR::PlatformWebView::removeChromeInputField):
666         (WTR::PlatformWebView::addToWindow):
667         (WTR::PlatformWebView::removeFromWindow):
668         (WTR::PlatformWebView::setWindowIsKey):
669         (WTR::PlatformWebView::makeWebViewFirstResponder):
670         (WTR::generateCairoSurfaceFromBitmap):
671         (WTR::PlatformWebView::windowSnapshotImage):
672         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
673         (WTR::PlatformWebView::setNavigationGesturesEnabled):
674         (WTR::PlatformWebView::forceWindowFramesChanged):
675         (WTR::PlatformWebView::drawsBackground const):
676         (WTR::PlatformWebView::setDrawsBackground):
677         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
678         (WTR::exceptionFilter):
679         (WTR::runRunLoopUntil):
680         (WTR::TestController::notifyDone):
681         (WTR::TestController::setHidden):
682         (WTR::TestController::platformInitialize):
683         (WTR::TestController::platformPreferences):
684         (WTR::TestController::platformDestroy):
685         (WTR::toWK):
686         (WTR::TestController::platformInitializeContext):
687         (WTR::TestController::platformRunUntil):
688         (WTR::TestController::platformDidCommitLoadForFrame):
689         (WTR::TestController::initializeInjectedBundlePath):
690         (WTR::TestController::initializeTestPluginDirectory):
691         (WTR::TestController::runModal):
692         (WTR::TestController::platformContext):
693         (WTR::TestController::platformLibraryPathForTesting):
694         (WTR::TestController::platformConfigureViewForTest):
695         (WTR::TestController::platformResetPreferencesToConsistentValues):
696         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
697         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
698         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
699         (dllLauncherEntryPoint):
700
701 2018-11-12  Alicia Boya García  <aboya@igalia.com>
702
703         [MSE][GStreamer] Introduce AbortableTaskQueue
704         https://bugs.webkit.org/show_bug.cgi?id=190902
705
706         Reviewed by Xabier Rodriguez-Calvar.
707
708         Tests for AbortableTaskQueue are included.
709
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
711         * TestWebKitAPI/PlatformGTK.cmake:
712         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
713         (TestWebKitAPI::TEST):
714         (TestWebKitAPI::FancyResponse::FancyResponse):
715         (TestWebKitAPI::FancyResponse::operator=):
716         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
717         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
718         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
719         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
720
721 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
722
723         run-bindings-tests is timing out in some WinCairo bots
724         https://bugs.webkit.org/show_bug.cgi?id=191348
725
726         Reviewed by Alex Christensen.
727
728         BuildBot kills run-bindings-tests if it outputs nothing for 20
729         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
730         and it takes more than 30 minutes to finish. And, Windows Python
731         buffers the progress output.
732
733         * Scripts/webkitpy/bindings/main.py:
734         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
735         test case result is output.
736
737 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
738
739         Implement a new edit command to change the enclosing list type
740         https://bugs.webkit.org/show_bug.cgi?id=191487
741         <rdar://problem/45955922>
742
743         Reviewed by Ryosuke Niwa.
744
745         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
746         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
747
748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
749         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
750         (-[TestWKWebView setPosition:offset:]):
751         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
752         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
753         (TestWebKitAPI::TEST):
754         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
755
756 2018-11-11  Dan Bernstein  <mitz@apple.com>
757
758         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
759         https://bugs.webkit.org/show_bug.cgi?id=191514
760
761         Reviewed by Geoffrey Garen.
762
763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
764         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
765         (TEST):
766
767 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
768
769         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
770         https://bugs.webkit.org/show_bug.cgi?id=191492
771
772         Reviewed by Alex Christensen.
773
774         Update file name.
775
776         * DumpRenderTree/mac/DumpRenderTree.mm:
777         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
778         * WebKitTestRunner/mac/TestControllerMac.mm:
779
780 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
781
782         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
783         https://bugs.webkit.org/show_bug.cgi?id=191492
784
785         Reviewed by Alex Christensen.
786
787         * DumpRenderTree/mac/DumpRenderTree.mm:
788         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
789         * WebKitTestRunner/mac/TestControllerMac.mm:
790
791 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
792
793         Unreviewed, rolling out r238065.
794
795         Breaks internal builds.
796
797         Reverted changeset:
798
799         "Make it possible to edit images inline"
800         https://bugs.webkit.org/show_bug.cgi?id=191352
801         https://trac.webkit.org/changeset/238065
802
803 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
804
805         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
806         https://bugs.webkit.org/show_bug.cgi?id=191221
807
808         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
809         that it is disabled, but we're testing that it is enabled, because I failed to update this
810         line.
811
812         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
813         (testWebKitSettings):
814
815 2018-11-10  Tim Horton  <timothy_horton@apple.com>
816
817         Make it possible to edit images inline
818         https://bugs.webkit.org/show_bug.cgi?id=191352
819         <rdar://problem/30107985>
820
821         Reviewed by Dean Jackson.
822
823         * WebKitTestRunner/TestController.cpp:
824         (WTR::updateTestOptionsFromTestHeader):
825         * WebKitTestRunner/TestOptions.h:
826         (WTR::TestOptions::hasSameInitializationOptions const):
827         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
828         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
829         (WTR::TestController::platformCreateWebView):
830         Add a test option to enable editable images.
831
832         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
833         (WTR::UIScriptController::drawSquareInEditableImage):
834         (WTR::UIScriptController::numberOfStrokesInEditableImage):
835         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
836         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
837         (WTR::UIScriptController::drawSquareInEditableImage):
838         (WTR::UIScriptController::numberOfStrokesInEditableImage):
839         * TestRunnerShared/UIScriptContext/UIScriptController.h:
840         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
841         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
842         (WTR::findEditableImageCanvas):
843         (WTR::UIScriptController::drawSquareInEditableImage):
844         (WTR::UIScriptController::numberOfStrokesInEditableImage):
845         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
846         and also to retrieve the number of strokes currently on the PKCanvasView.
847         Currently this just takes the first canvas; we might need to make it
848         take an identifier or something in the future if we need tests with multiple
849         canvases. The indirect testing mechanism is required because PKCanvasView
850         can currently not actually paint its strokes in the Simulator.
851
852 2018-11-09  Chris Dumez  <cdumez@apple.com>
853
854         Suspended page persists even after back/forward list item is gone
855         https://bugs.webkit.org/show_bug.cgi?id=191488
856         <rdar://problem/45953006>
857
858         Reviewed by Geoffrey Garen.
859
860         Add API test coverage.
861
862         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
863
864 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
867         https://bugs.webkit.org/show_bug.cgi?id=191471
868         <rdar://problem/45952472>
869
870         Reviewed by Tim Horton.
871
872         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
875         (TestWebKitAPI::webViewForEditActionTesting):
876         (TestWebKitAPI::TEST):
877
878 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
879
880         [Curl][WebKit] Implement Proxy configuration API.
881         https://bugs.webkit.org/show_bug.cgi?id=189053
882
883         Reviewed by Youenn Fablet.
884
885         Added Proxy Settings dialog to call newly added API.
886
887         * MiniBrowser/win/BrowserWindow.h:
888         * MiniBrowser/win/Common.cpp:
889         (askProxySettings):
890         (askCredential):
891         (authDialogProc): Deleted.
892         * MiniBrowser/win/Common.h:
893         * MiniBrowser/win/DialogHelper.h: Added.
894         (Dialog::run):
895         (Dialog::doalogProc):
896         (Dialog::handle):
897         (Dialog::setup):
898         (Dialog::update):
899         (Dialog::validate):
900         (Dialog::updateOkButton):
901         (Dialog::command):
902         (Dialog::ok):
903         (Dialog::cancel):
904         (Dialog::close):
905         (Dialog::hDlg):
906         (Dialog::item):
907         (Dialog::setEnabled):
908         (Dialog::setText):
909         (Dialog::getText):
910         (Dialog::getTextLength):
911         (Dialog::RadioGroup::RadioGroup):
912         (Dialog::RadioGroup::set):
913         (Dialog::RadioGroup::get):
914         (Dialog::radioGroup):
915         * MiniBrowser/win/MainWindow.cpp:
916         (MainWindow::WndProc):
917         * MiniBrowser/win/MiniBrowserLib.rc:
918         * MiniBrowser/win/MiniBrowserLibResource.h:
919         * MiniBrowser/win/WebKitBrowserWindow.cpp:
920         (createWKURL):
921         (WebKitBrowserWindow::WebKitBrowserWindow):
922         (WebKitBrowserWindow::updateProxySettings):
923         (WebKitBrowserWindow::loadURL):
924         (WebKitBrowserWindow::loadHTMLString):
925         (WebKitBrowserWindow::openProxySettings):
926         * MiniBrowser/win/WebKitBrowserWindow.h:
927         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
928         (WebKitLegacyBrowserWindow::openProxySettings):
929         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
930
931 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
932
933         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
934         https://bugs.webkit.org/show_bug.cgi?id=191410
935         <rdar://problem/45898610>
936
937         Reviewed by Dean Jackson.
938
939         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
940         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
941         hooked up to their respective editing commands.
942
943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
944         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
945         (-[TestWKWebView querySelectorExists:]):
946         (-[TestWKWebView insertString:]):
947
948         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
949         invoking the WKWebView directly on macOS and calling on the content view on iOS.
950
951         (TestWebKitAPI::webViewForEditActionTesting):
952         (TestWebKitAPI::TEST):
953
954 2018-11-09  Philippe Normand  <pnormand@igalia.com>
955
956         [Flatpak] Refactoring and drive-by fixes
957         https://bugs.webkit.org/show_bug.cgi?id=191421
958
959         Reviewed by Michael Catanzaro.
960
961         * Scripts/webkitdirs.pm:
962         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
963         the sandbox, so rely on this.
964         * flatpak/flatpakutils.py:
965         (expand_manifest): Pass explicit keywords to load_manifest() and
966         remove unused local variable.
967         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
968         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
969         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
970         build_type handling a bit.
971         * flatpak/org.webkit.CommonModules.yaml: Added.
972         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
973         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
974         declaration to CommonModules, so it can be reused later when we
975         add support for building extra libraries depending on WPE.
976
977 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
978
979 onal supported image formats
980         https://bugs.webkit.org/show_bug.cgi?id=190454
981
982         Reviewed by Simon Fraser.
983
984         Test opening a TGA image in WebView which is not allowed by default. The
985         TGA format will be allowed through WKWebViewConfiguration.
986
987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
988         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
989         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
990         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
991         (runTest):
992         (TEST):
993
994 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
995
996         Unreviewed, a proper build fix for r237983
997
998         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
999
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
1002         (TestWebKitAPI::TEST):
1003         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
1004         (TestWebKitAPI::getTestCorruptedSignResponse):
1005         (TestWebKitAPI::getTestCredentialRawIdBytes):
1006         (TestWebKitAPI::convertToVector):
1007         (TestWebKitAPI::TEST):
1008
1009 2018-11-08  Keith Rollin  <krollin@apple.com>
1010
1011         Create .xcfilelist files
1012         https://bugs.webkit.org/show_bug.cgi?id=191324
1013         <rdar://problem/45852819>
1014
1015         Reviewed by Alex Christensen.
1016
1017         As part of preparing for enabling XCBuild, create and use .xcfilelist
1018         files. These files are using during Run Script build phases in an
1019         Xcode project. If a Run Script build phase produces new files that are
1020         used later as inputs to subsequent build phases, XCBuild needs to know
1021         about these files. These files can be either specified in an "output
1022         files" section of the Run Script phase editor, or in .xcfilelist files
1023         that are associated with the Run Script build phase.
1024
1025         This patch takes the second approach. It consists of three sets of changes:
1026
1027         - Modify the DerivedSources.make files to have a
1028           'print_all_generated_files" target that produces a list of the files
1029           they create.
1030
1031         - Create a shell script that produces .xcfilelist files from the
1032           output of the previous step, as well as for the files created in the
1033           Generate Unified Sources build steps.
1034
1035         - Add the new .xcfilelist files to the associated projects.
1036
1037         Note that, with these changes, the Xcode workspace and projects can no
1038         longer be fully loaded into Xcode 9. Xcode will attempt to load the
1039         projects that have .xcfilelist files associated with them, but will
1040         fail and display a placeholder for those projects instead. It's
1041         expected that all developers are using Xcode 10 by now and that not
1042         being able to load into Xcode 9 is not a practical issue. Keep in mind
1043         that this is strictly an IDE issue, and that the projects can still be
1044         built with `xcodebuild`.
1045
1046         Also note that the shell script that creates the .xcfilelist files can
1047         also be used to verify that the set of files that's currently checked
1048         in is up-to-date. This checking can be used as part of a check-in hook
1049         or part of check-webkit-style to sooner catch cases where the
1050         .xcfilelist files need to be regenerated.
1051
1052         * DumpRenderTree/DerivedSources.make:
1053         * DumpRenderTree/DerivedSources.xcfilelist: Added.
1054         * Scripts/generate-xcfilelists: Added.
1055         * WebKitTestRunner/DerivedSources.make:
1056         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
1057
1058 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1059
1060         Unreviewed, a quick build fix for r237983
1061
1062         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
1063
1064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
1065         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
1066         (TestWebKitAPI::TEST):
1067         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
1068         (TestWebKitAPI::getTestCorruptedSignResponse):
1069         (TestWebKitAPI::getTestCredentialRawIdBytes):
1070         (TestWebKitAPI::convertToVector):
1071         (TestWebKitAPI::TEST):
1072
1073 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
1074
1075         Fix steps_unittest.py failures related to recent Win10/Win7 changes
1076         https://bugs.webkit.org/show_bug.cgi?id=191290
1077
1078         Reviewed by Alexey Proskuryakov.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
1081
1082 2018-11-08  Dean Jackson  <dino@apple.com>
1083
1084         Add a String literal that returns a String
1085         https://bugs.webkit.org/show_bug.cgi?id=191425
1086         <rdar://problem/45914556>
1087
1088         Reviewed by Sam Weinig.
1089
1090         Test _str.
1091
1092         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1093         (TestWebKitAPI::TEST):
1094
1095 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
1096
1097         webkitpy: Generalize trailing SDK specifier (Part 2)
1098         https://bugs.webkit.org/show_bug.cgi?id=191275
1099         <rdar://problem/45703660>
1100
1101         Rubber-stamped by Aakash Jain.
1102
1103         Re-landing this change, configuration issues have been resolved.
1104
1105         * Scripts/webkitpy/port/ios_device.py:
1106         (IOSDevicePort): Use normalized SDK.
1107         * Scripts/webkitpy/port/ios_simulator.py:
1108         (IOSSimulatorPort): Use normalized SDK.
1109         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1110
1111 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1112
1113         [WebAuthN] Import CTAP device request/response converters from Chromium
1114         https://bugs.webkit.org/show_bug.cgi?id=190784
1115         <rdar://problem/45460333>
1116
1117         Reviewed by Brent Fulgham.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1121         (TestWebKitAPI::TEST):
1122         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1123         (TestWebKitAPI::TEST):
1124         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1125         (TestWebKitAPI::getTestCorruptedSignResponse):
1126         (TestWebKitAPI::getTestCredentialRawIdBytes):
1127         (TestWebKitAPI::convertToVector):
1128         (TestWebKitAPI::TEST):
1129         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1130
1131 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1132
1133         [BigInt] Add support to BigInt into ValueAdd
1134         https://bugs.webkit.org/show_bug.cgi?id=186177
1135
1136         Reviewed by Keith Miller.
1137
1138         * Scripts/run-jsc-benchmarks:
1139
1140 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1141
1142         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1143         https://bugs.webkit.org/show_bug.cgi?id=191326
1144         <rdar://problem/45769269>
1145
1146         Reviewed by Geoffrey Garen.
1147
1148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1149         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1150         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1151         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1152         (TEST):
1153
1154 2018-11-07  Daniel Bates  <dabates@apple.com>
1155
1156         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1157         https://bugs.webkit.org/show_bug.cgi?id=190141
1158
1159         Reviewed by Darin Adler.
1160
1161         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1162         runs deterministic regardless of whether a hardware keyboard is attached.
1163
1164         * DumpRenderTree/mac/DumpRenderTree.mm:
1165         (overrideIsInHardwareKeyboardMode): Added.
1166         (prepareConsistentTestingEnvironment):
1167         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1168         * WebKitTestRunner/ios/TestControllerIOS.mm:
1169         (overrideIsInHardwareKeyboardMode): Added.
1170         (WTR::TestController::platformInitialize):
1171
1172 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1173
1174         Unreviewed, rolling out r237913.
1175
1176         Breaks running tests on Mac without iOS SDK installed
1177
1178         Reverted changeset:
1179
1180         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1181         https://bugs.webkit.org/show_bug.cgi?id=191275
1182         https://trac.webkit.org/changeset/237913
1183
1184 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1185
1186         Force a gregorian calendar to show for credit card expiration date inputs
1187         (autocomplete='cc-exp'*) regardless of default system settings.
1188         https://bugs.webkit.org/show_bug.cgi?id=191096
1189         rdar://problem/42640256
1190
1191         Reviewed by Tim Horton.
1192
1193         Implemented simulateForeignDefaultCalendar and calendarType to be used
1194         for changing the default calendar returned by the system (ie. [NSCalendar
1195         currentCalendar]) and getting the calendar type identifier of a presented date
1196         picker.
1197
1198         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1199         (WTR::UIScriptController::isShowingDataListSuggestions const):
1200         (WTR::UIScriptController::calendarType const):
1201         (WTR::UIScriptController::setDefaultCalendarType):
1202         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1203         (WTR::UIScriptController::calendarType const):
1204         (WTR::UIScriptController::setDefaultCalendarType):
1205         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1206         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1207         (WTR::UIScriptController::calendarType const): Deleted.
1208         * WebKitTestRunner/TestController.cpp:
1209         * WebKitTestRunner/TestController.h:
1210         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1211         (WTR::UIScriptController::calendarType const):
1212         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1213         (WTR::swizzledCalendar):
1214         (WTR::TestController::getOverriddenCalendarIdentifier const):
1215         (WTR::TestController::setDefaultCalendarType):
1216         (WTR::TestController::cocoaResetStateToConsistentValues):
1217         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1218         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1219         (WTR::UIScriptController::calendarType const): Deleted.
1220
1221 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1222
1223         webkitpy: Boot a single worker for custom devices
1224         https://bugs.webkit.org/show_bug.cgi?id=191312
1225         <rdar://problem/45848717>
1226
1227         Rubber-stamped by Aakash Jain.
1228
1229         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1230         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1231         simulators is expensive and unneeded for these tests.
1232         * Scripts/webkitpy/port/ios.py:
1233         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1234         overriding the number of child processes when booting custom devices.
1235
1236 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1237
1238         webkitpy: Generalize trailing SDK specifier (Part 2)
1239         https://bugs.webkit.org/show_bug.cgi?id=191275
1240         <rdar://problem/45703660>
1241
1242         Reviewed by Aakash Jain.
1243
1244         * Scripts/webkitpy/port/ios_device.py:
1245         (IOSDevicePort): Use normalized SDK.
1246         * Scripts/webkitpy/port/ios_simulator.py:
1247         (IOSSimulatorPort): Use normalized SDK.
1248         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1249
1250 2018-11-06  Justin Fan  <justin_fan@apple.com>
1251
1252         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1253         https://bugs.webkit.org/show_bug.cgi?id=191291
1254
1255         Reviewed by Myles Maxfield.
1256
1257         Properly disable WEBGPU on all non-Metal platforms for now.
1258
1259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1260
1261 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-app] Add URL configuration for OpenSource EWS Django app
1264         https://bugs.webkit.org/show_bug.cgi?id=191132
1265
1266         Rubber-stamped by Lucas Forschler.
1267
1268         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1269         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1270
1271 2018-11-06  Youenn Fablet  <youenn@apple.com>
1272
1273         Make mDNS ICE Candidate an experimental flag again
1274         https://bugs.webkit.org/show_bug.cgi?id=191262
1275
1276         Reviewed by Dean Jackson.
1277
1278         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1280         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1281         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
1282         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1283
1284 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1285
1286         [ews-app] Add views for OpenSource EWS Django app
1287         https://bugs.webkit.org/show_bug.cgi?id=191131
1288
1289         Rubber-stamped by Lucas Forschler.
1290
1291         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
1292         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1293         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
1294         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
1295
1296 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1297
1298         [ews-app] Add models for OpenSource EWS Django app
1299         https://bugs.webkit.org/show_bug.cgi?id=191123
1300
1301         Reviewed by Lucas Forschler.
1302
1303         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1304         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
1305         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
1306         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1307         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
1308
1309 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-app] Fix Invalid HTTP_HOST header
1312         https://bugs.webkit.org/show_bug.cgi?id=191325
1313
1314         Reviewed by Lucas Forschler.
1315
1316         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
1317
1318         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1319
1320 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1321
1322         [ews-app] Rename EWS_app to ews-app - part 2
1323         https://bugs.webkit.org/show_bug.cgi?id=191317
1324
1325         Reviewed by Lucas Forschler.
1326
1327         * BuildSlaveSupport/ews-app/EWS_app: Removed.
1328         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
1329         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1330         * BuildSlaveSupport/ews-app/ews-app/urls.py:
1331         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
1332         * BuildSlaveSupport/ews-app/manage.py:
1333
1334 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1335
1336         [ews-app] Rename EWS_app to ews-app - part 1
1337         https://bugs.webkit.org/show_bug.cgi?id=191317
1338
1339         Reviewed by Lucas Forschler.
1340
1341         * BuildSlaveSupport/EWS_app: Removed.
1342         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
1343
1344 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
1345
1346         Spelling dots are drawn in the wrong place
1347         https://bugs.webkit.org/show_bug.cgi?id=190764
1348
1349         Reviewed by Dean Jackson.
1350
1351         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1352         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1353         dots to be drawn.
1354
1355         * WebKitTestRunner/TestController.cpp:
1356         (WTR::TestController::resetStateToConsistentValues):
1357         (WTR::updateTestOptionsFromTestHeader):
1358         (WTR::TestController::platformResetStateToConsistentValues):
1359         * WebKitTestRunner/TestController.h:
1360         * WebKitTestRunner/TestOptions.h:
1361         (WTR::TestOptions::hasSameInitializationOptions const):
1362         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1363         (WTR::TestController::cocoaResetStateToConsistentValues):
1364         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1365         * WebKitTestRunner/ios/TestControllerIOS.mm:
1366         (WTR::TestController::platformResetStateToConsistentValues):
1367         * WebKitTestRunner/mac/TestControllerMac.mm:
1368         (WTR::TestController::platformResetStateToConsistentValues):
1369
1370 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
1371
1372         Feature flags not present for Visual Studio when using build-webkit
1373         https://bugs.webkit.org/show_bug.cgi?id=191288
1374
1375         Reviewed by Fujii Hironori.
1376
1377         Passes feature flags to Visual studio builds within build-webkit.
1378         Removes cmakeBasedPortArguments as it is no longer in use.
1379
1380         * Scripts/build-jsc:
1381         * Scripts/build-webkit:
1382         * Scripts/webkitdirs.pm:
1383         (cmakeBasedPortArguments): Deleted.
1384
1385 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
1386
1387         REGRESSION (r230523): Caps lock indicator not shown in password field
1388         https://bugs.webkit.org/show_bug.cgi?id=190056
1389
1390         Reviewed by Ryosuke Niwa.
1391
1392         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1393         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1394         (WTR::TestRunner::toggleCapsLock):
1395         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1396         * WebKitTestRunner/TestController.h:
1397         * WebKitTestRunner/TestInvocation.cpp:
1398         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1399         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1400         (WTR::TestController::toggleCapsLock):
1401
1402 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
1403
1404         IndexedDB: WAL file keeps growing
1405         https://bugs.webkit.org/show_bug.cgi?id=191294
1406         <rdar://problem/41333493>
1407
1408         Reviewed by Chris Dumez.
1409
1410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1411         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
1412         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
1413         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
1414         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
1415         (TEST):
1416
1417 2018-11-06  Alex Christensen  <achristensen@webkit.org>
1418
1419         Fix tests after r237863
1420         https://bugs.webkit.org/show_bug.cgi?id=191315
1421
1422         Reviewed by Chris Dumez.
1423
1424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1425         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
1426         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
1427         to verify that main2.html eventually loads, making this test less timing dependent.
1428
1429 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
1430
1431         Unreviewed, rolling out r237834.
1432
1433         Tests for this change crash on iOS Simulator
1434
1435         Reverted changeset:
1436
1437         "Spelling dots are drawn in the wrong place"
1438         https://bugs.webkit.org/show_bug.cgi?id=190764
1439         https://trac.webkit.org/changeset/237834
1440
1441 2018-11-05  Alex Christensen  <achristensen@webkit.org>
1442
1443         [Mac] Implement safe browsing in WebKit
1444         https://bugs.webkit.org/show_bug.cgi?id=188871
1445
1446         Reviewed by Tim Horton.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1449         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
1450         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
1451         (-[TestLookupContext lookUpURL:completionHandler:]):
1452         (simpleURL):
1453         (safeBrowsingView):
1454         (TEST):
1455         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
1456         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
1457         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
1458         * TestWebKitAPI/Utilities.h:
1459
1460 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
1461
1462         webkitpy: Generalize trailing SDK specifier (Part 1)
1463         https://bugs.webkit.org/show_bug.cgi?id=191275
1464         <rdar://problem/45703660>
1465
1466         Reviewed by Lucas Forschler.
1467
1468         * Scripts/webkitpy/common/system/platforminfo.py:
1469         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
1470         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1471         (TestPlatformInfo):
1472         (TestPlatformInfo.test_available_sdks):
1473
1474 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
1475
1476         Spelling dots are drawn in the wrong place
1477         https://bugs.webkit.org/show_bug.cgi?id=190764
1478
1479         Reviewed by Dean Jackson.
1480
1481         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1482         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1483         dots to be drawn.
1484
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::resetStateToConsistentValues):
1487         (WTR::updateTestOptionsFromTestHeader):
1488         (WTR::TestController::platformResetStateToConsistentValues):
1489         * WebKitTestRunner/TestController.h:
1490         * WebKitTestRunner/TestOptions.h:
1491         (WTR::TestOptions::hasSameInitializationOptions const):
1492         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1493         (WTR::TestController::cocoaResetStateToConsistentValues):
1494         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1495         * WebKitTestRunner/ios/TestControllerIOS.mm:
1496         (WTR::TestController::platformResetStateToConsistentValues):
1497         * WebKitTestRunner/mac/TestControllerMac.mm:
1498         (WTR::TestController::platformResetStateToConsistentValues):
1499
1500 2018-11-05  Chris Dumez  <cdumez@apple.com>
1501
1502         Use same limit for page cache and suspended pages
1503         https://bugs.webkit.org/show_bug.cgi?id=191266
1504
1505         Reviewed by Geoffrey Garen.
1506
1507         Update API tests accordingly.
1508
1509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1510
1511 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1512
1513         [style] Exclude style check for auto generated files.
1514         https://bugs.webkit.org/show_bug.cgi?id=191118
1515
1516         Reviewed by Eric Carlson.
1517
1518         Some files checked in to the repository are generated by other tools. In this patch,
1519         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
1520         VisualStudio.
1521
1522         There's no need to check these files because it's not practical to fix the style errors
1523         or it's hard to maintain those fixes.
1524
1525         * Scripts/webkitpy/style/checkers/cpp.py:
1526         (is_generated_file):
1527         (CppChecker.check):
1528
1529 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1530
1531         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
1532         https://bugs.webkit.org/show_bug.cgi?id=190680
1533
1534         Reviewed by Philippe Normand.
1535
1536         * flatpak/org.webkit.WebKit.yaml:
1537
1538 2018-11-05  Daniel Bates  <dabates@apple.com>
1539
1540         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
1541         https://bugs.webkit.org/show_bug.cgi?id=191094
1542
1543         Reviewed by Andy Estes.
1544
1545         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
1546         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
1547         Document summary and add closing brace '}' to both Frame and Document summary strings to make
1548         them look pretty.
1549
1550         * lldb/lldb_webkit.py:
1551         (WebCoreFrame_SummaryProvider):
1552         (WebCoreDocument_SummaryProvider):
1553
1554 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1555
1556         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
1557         https://bugs.webkit.org/show_bug.cgi?id=191240
1558         <rdar://problem/44872806>
1559
1560         Reviewed by Tim Horton.
1561
1562         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
1563         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
1564         overriding `-[WKWebView inputAssistantItem]`.
1565
1566         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1567         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
1568         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
1569         (+[InputAssistantItemTestingWebView barButtonIcon]):
1570         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
1571         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
1572         (-[InputAssistantItemTestingWebView inputAssistantItem]):
1573         (TestWebKitAPI::TEST):
1574
1575 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1576
1577         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
1578         https://bugs.webkit.org/show_bug.cgi?id=191226
1579         <rdar://problem/45781765>
1580
1581         Reviewed by Tim Horton.
1582
1583         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
1584         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
1585
1586         * WebKitTestRunner/TestOptions.h:
1587         (WTR::TestOptions::hasSameInitializationOptions const):
1588
1589 2018-11-05  Commit Queue  <commit-queue@webkit.org>
1590
1591         Unreviewed, rolling out r237784 and r237788.
1592         https://bugs.webkit.org/show_bug.cgi?id=191270
1593
1594         Caused mediastream layout test failures (Requested by
1595         ryanhaddad on #webkit).
1596
1597         Reverted changesets:
1598
1599         "[MediaStream] User should not be prompted again after denying
1600         getDisplayMedia request"
1601         https://bugs.webkit.org/show_bug.cgi?id=191227
1602         https://trac.webkit.org/changeset/237784
1603
1604         "[MediaStream] User should not be prompted again after denying
1605         getDisplayMedia request"
1606         https://bugs.webkit.org/show_bug.cgi?id=191227
1607         https://trac.webkit.org/changeset/237788
1608
1609 2018-11-05  Lucas Forschler  <lforschler@apple.com>
1610
1611         https://bugs.webkit.org/show_bug.cgi?id=191268
1612         Remove unused bots.
1613
1614         rubber-stamped by Alexey Proskuryakov.
1615
1616         * BuildSlaveSupport/build.webkit.org-config/config.json:
1617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1618         (WebKitBuildbot):
1619
1620 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1621
1622         [WPE][GTK] API test runner fails to respect default build type
1623         https://bugs.webkit.org/show_bug.cgi?id=190247
1624
1625         Reviewed by Carlos Garcia Campos.
1626
1627         Problem is it's looking for a release build, even though I've run set-webkit-configuration
1628         --debug. It should look for a debug build unless I explicitly pass --release.
1629
1630         * glib/api_test_runner.py:
1631         (TestRunner.__init__):
1632
1633 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1634
1635         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
1636         https://bugs.webkit.org/show_bug.cgi?id=190674
1637
1638         Reviewed by Philippe Normand.
1639
1640         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
1641         it can use to implement encoding for different formats exposing a trimmed down unified API.
1642
1643         It also adds proper handling of H264 profiles.
1644
1645         The added files follow GStreamer coding style as we aim at upstreaming the element
1646         in the future.
1647
1648         Reviewed by Philippe Normand.
1649
1650         * Scripts/webkitpy/style/checker.py:
1651
1652 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1653
1654         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1655         https://bugs.webkit.org/show_bug.cgi?id=191221
1656
1657         Reviewed by Carlos Garcia Campos.
1658
1659         This test ensures that MSE is disabled by default, but we now enable it by default, so
1660         reverse the semantics of the test.
1661
1662         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1663         (testWebKitSettings):
1664
1665 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1666
1667         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
1668         https://bugs.webkit.org/show_bug.cgi?id=191225
1669
1670         Reviewed by Alejandro G. Castro.
1671
1672         Fix a memory leak causing this test to fail.
1673
1674         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1675         (WebViewTest::initializeWebView):
1676
1677 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
1678
1679         [webkitpy] Support WPE in the run-web-platform-tests script
1680         https://bugs.webkit.org/show_bug.cgi?id=191183
1681
1682         Reviewed by Alex Christensen.
1683
1684         * Scripts/webkitpy/w3c/wpt_runner.py:
1685         (parse_args): Support `--wpe` as an argument that specifies WPE as the
1686         target port. Additionally, the `--display-server` flag now accepts
1687         `headless` as a valid value, enabling the WPE WebDriver to run in
1688         headless mode.
1689
1690 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
1691
1692         [Win] Use C++14, not C++17
1693         https://bugs.webkit.org/show_bug.cgi?id=191101
1694
1695         Reviewed by Alex Christensen.
1696
1697         std::basic_string::data() returns a read-only const buffer in
1698         C++14.
1699
1700         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1701         (createString): Use std::vector instead of std::wstring.
1702         (createUTF8String): Use std::vector instead of std::string.
1703
1704 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1705
1706         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
1707         https://bugs.webkit.org/show_bug.cgi?id=191231
1708
1709         Reviewed by Simon Fraser.
1710
1711         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
1712         it can be shared between iOS-family and macOS platforms. See below for more details.
1713
1714         No change in behavior.
1715
1716         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1717         (WTR::UIScriptController::overridePreference):
1718
1719         Add a method stub for DumpRenderTree.
1720
1721         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1722         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1723         (WTR::UIScriptController::doAsyncTask):
1724         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1725
1726         Unify these method implementations.
1727
1728         (WTR::UIScriptController::removeViewFromWindow):
1729         (WTR::UIScriptController::addViewToWindow):
1730
1731         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1732         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1733         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1734         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1735
1736         (WTR::UIScriptController::overridePreference):
1737         (WTR::UIScriptController::findString):
1738         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1739
1740         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1741
1742         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1743         (WTR::UIScriptController::doAsyncTask): Deleted.
1744         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1745         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1746         (WTR::UIScriptController::findString): Deleted.
1747         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1748         (WTR::UIScriptController::addViewToWindow): Deleted.
1749         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1750         (WTR::UIScriptController::doAsyncTask): Deleted.
1751         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1752         (WTR::UIScriptController::overridePreference): Deleted.
1753         (WTR::UIScriptController::findString): Deleted.
1754         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1755         (WTR::UIScriptController::addViewToWindow): Deleted.
1756         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1757
1758 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1759
1760         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1761         https://bugs.webkit.org/show_bug.cgi?id=191227
1762         <rdar://problem/45784512>
1763
1764         Reviewed by Youenn Fablet.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1767         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1768         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1769         (TestWebKitAPI::TEST_F):
1770
1771 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1772
1773         [LFC][BFC] Add support for percentage height in quirks mode.
1774         https://bugs.webkit.org/show_bug.cgi?id=191232
1775
1776         Reviewed by Antti Koivisto.
1777
1778         * LayoutReloaded/misc/LFC-passing-tests.txt:
1779
1780 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1781
1782         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1783         https://bugs.webkit.org/show_bug.cgi?id=191229
1784
1785         Reviewed by Antti Koivisto.
1786
1787         * LayoutReloaded/misc/LFC-passing-tests.txt:
1788
1789 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1790
1791         [LFC][BFC] Resolve percentage height values.
1792         https://bugs.webkit.org/show_bug.cgi?id=191224
1793
1794         Reviewed by Antti Koivisto.
1795
1796         * LayoutReloaded/misc/LFC-passing-tests.txt:
1797
1798 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1799
1800         Mac production builds should sign the network process xpc service with entitlements
1801         https://bugs.webkit.org/show_bug.cgi?id=191209
1802         <rdar://problem/45377609>
1803
1804         Reviewed by Geoff Garen.
1805
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1808         (TEST):
1809
1810 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1811
1812         Unreviewed, rolling out r237761.
1813
1814         Makes most API tests timeout and WK2 tests crash
1815
1816         Reverted changeset:
1817
1818         "Mac production builds should sign the network process xpc
1819         service with entitlements"
1820         https://bugs.webkit.org/show_bug.cgi?id=191209
1821         https://trac.webkit.org/changeset/237761
1822
1823 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1824
1825         Unreviewed API test gardening
1826
1827         * TestWebKitAPI/glib/TestExpectations.json:
1828
1829 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1830
1831         Add new global object and preliminary Worklets support for CSS painting api
1832         https://bugs.webkit.org/show_bug.cgi?id=190979
1833
1834         Reviewed by Chris Dumez.
1835
1836         * Scripts/webkitpy/bindings/main.py:
1837         (BindingsTests.generate_supplemental_dependency):
1838         (BindingsTests.main):
1839
1840 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1841
1842         Mac production builds should sign the network process xpc service with entitlements
1843         https://bugs.webkit.org/show_bug.cgi?id=191209
1844         <rdar://problem/45377609>
1845
1846         Reviewed by Geoff Garen.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1850         (TEST):
1851
1852 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1853
1854         Add Windows 10 archive bots
1855         https://bugs.webkit.org/show_bug.cgi?id=190964
1856         
1857         This Change updates the Apple Windows Buildbot configuration.
1858         - Add Windows 10 specific builders and testers for release and debug.
1859         - Refactor Windows -> Windows 7.
1860         - Remove Windows 7 Debug.
1861
1862         Reviewed by Aakash Jain.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/config.json:
1865
1866 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1867
1868         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1869
1870         Rubber-stamped by Michael Catanzaro.
1871
1872         This variable is useful to get rid of shell color escapes in tests stderr files.
1873
1874         * Scripts/webkitpy/port/gtk.py:
1875         (GtkPort.setup_environ_for_server):
1876         * Scripts/webkitpy/port/wpe.py:
1877         (WPEPort.setup_environ_for_server):
1878
1879 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1880
1881         Add Basic Django web app for OpenSource EWS
1882         https://bugs.webkit.org/show_bug.cgi?id=191091
1883
1884         Reviewed by Lucas Forschler.
1885
1886         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1887         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1888         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1889         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1890         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1891         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1892         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1893         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1894         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1895         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1896         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1897         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1898         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1899         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1900
1901 2018-11-02  Daniel Bates  <dabates@apple.com>
1902
1903         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1904         https://bugs.webkit.org/show_bug.cgi?id=190487
1905
1906         Reviewed by Tim Horton.
1907
1908         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1909         match my observations when using the simulator to simulate iOS 12 and add support for testing
1910         right-hand side modifiers.
1911
1912         * DumpRenderTree/mac/EventSendingController.mm:
1913         (modifierFlags):
1914         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1915         (-[EventSendingController setTouchModifier:value:]):
1916         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1917         (hidUsageCodeForCharacter):
1918
1919 2018-11-02  Chris Dumez  <cdumez@apple.com>
1920
1921         [PSON] Reuse SuspendedPages' process when possible, for performance
1922         https://bugs.webkit.org/show_bug.cgi?id=191166
1923
1924         Reviewed by Geoffrey Garen.
1925
1926         Add API test coverage.
1927
1928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1929
1930 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1931
1932         [LFC][IFC] Add support for intrinsic width calculation
1933         https://bugs.webkit.org/show_bug.cgi?id=191144
1934
1935         Reviewed by Antti Koivisto.
1936
1937         * LayoutReloaded/misc/LFC-passing-tests.txt:
1938
1939 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1940
1941         [Apache] Self-signed SSL certificate RSA key is considered too weak
1942         https://bugs.webkit.org/show_bug.cgi?id=191156
1943
1944         Reviewed by Michael Catanzaro.
1945
1946         * Scripts/webkitpy/common/system/pemfile.py:
1947
1948 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1949
1950         Unreviewed follow-up to r237678.
1951
1952         * wpe/jhbuild.modules: The patch element apparently has to be a child
1953         of the branch in order for Jhbuild to properly detect and apply the
1954         patch file.
1955
1956 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1957
1958         build-jsc --wincairo should update WinCairo libraries
1959         https://bugs.webkit.org/show_bug.cgi?id=191170
1960
1961         Reviewed by Fujii Hironori.
1962
1963         * Scripts/build-jsc:
1964
1965 2018-11-01  John Wilander  <wilander@apple.com>
1966
1967         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1968         https://bugs.webkit.org/show_bug.cgi?id=191119
1969         <rdar://problem/44176965>
1970
1971         Reviewed by Chris Dumez.
1972
1973         This is an API test for a WebKitLegacy WebView that is first closed and then
1974         JavaScript is handed a keyboard event.
1975
1976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1977         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1978         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1979         (-[KeyboardEventListener handleEvent:]):
1980         (TestWebKitAPI::TEST):
1981
1982 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1983
1984         Add a storage limit for IndexedDB
1985         https://bugs.webkit.org/show_bug.cgi?id=190598
1986         <rdar://problem/44654715>
1987
1988         Reviewed by Chris Dumez.
1989
1990         Add API for testing.
1991
1992         * DumpRenderTree/TestRunner.cpp:
1993         (setIDBPerOriginQuotaCallback):
1994         (TestRunner::staticFunctions):
1995         * DumpRenderTree/TestRunner.h:
1996         * DumpRenderTree/mac/TestRunnerMac.mm:
1997         (TestRunner::setIDBPerOriginQuota):
1998         * DumpRenderTree/win/TestRunnerWin.cpp:
1999         (TestRunner::setIDBPerOriginQuota):
2000         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2001         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2002         (WTR::TestRunner::setIDBPerOriginQuota):
2003         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::TestController::setIDBPerOriginQuota):
2006         * WebKitTestRunner/TestController.h:
2007         * WebKitTestRunner/TestInvocation.cpp:
2008         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2009
2010 2018-11-01  Chris Dumez  <cdumez@apple.com>
2011
2012         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
2013         https://bugs.webkit.org/show_bug.cgi?id=191076
2014
2015         Reviewed by Geoffrey Garen.
2016
2017         Add API test coverage.
2018
2019         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2020         (-[PSONNavigationDelegate init]):
2021         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2022
2023 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
2024
2025         Fix build with VIDEO and WEB_AUDIO disabled
2026         https://bugs.webkit.org/show_bug.cgi?id=191147
2027         <rdar://problem/45726710>
2028
2029         Unreviewed build fix.
2030
2031         This adds the missing compilation guards in the WPE MiniBrowser.
2032
2033         * MiniBrowser/wpe/main.cpp:
2034         (main): Condition GST includes and calls.
2035
2036 2018-10-31  Zalan Bujtas  <zalan@apple.com>
2037
2038         [LFC][IFC] Add support for inline-block elements.
2039         https://bugs.webkit.org/show_bug.cgi?id=191143
2040
2041         Reviewed by Antti Koivisto.
2042
2043         * LayoutReloaded/misc/LFC-passing-tests.txt:
2044
2045 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2046
2047         [WPE] Add missing libsoup patch to jhbuild
2048         https://bugs.webkit.org/show_bug.cgi?id=191149
2049
2050         Reviewed by Žan Doberšek.
2051
2052         * wpe/jhbuild.modules:
2053         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2054
2055 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2056
2057         Fix build with VIDEO and WEB_AUDIO disabled
2058         https://bugs.webkit.org/show_bug.cgi?id=191147
2059
2060         Reviewed by Philippe Normand.
2061
2062         * MiniBrowser/gtk/main.c:
2063         (main): Condition GST includes and calls
2064
2065 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
2066
2067         Add Justin Michaud to the list of WebKit Committers
2068         https://bugs.webkit.org/show_bug.cgi?id=191142
2069
2070         * Scripts/webkitpy/common/config/contributors.json:
2071
2072 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
2073
2074         Don't run JIT tests on 32-bit platforms
2075         https://bugs.webkit.org/show_bug.cgi?id=191074
2076
2077         Reviewed by Michael Catanzaro.
2078
2079         * Scripts/run-jsc-stress-tests:
2080
2081 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2082
2083         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
2084         https://bugs.webkit.org/show_bug.cgi?id=190530
2085         <rdar://problem/45232149>
2086
2087         Reviewed by Tim Horton.
2088
2089         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
2090         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
2091         is equivalent to the original file wrappers used to insert attachments in the first web view.
2092
2093         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
2094         is still backed by the same NSFileWrapper instance.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2097         (TestWebKitAPI::TEST):
2098
2099 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2100
2101         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2102         https://bugs.webkit.org/show_bug.cgi?id=190949
2103
2104         Reviewed by Alex Christensen.
2105
2106         Visual Studio 2017 Community is the alternative.
2107
2108         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2109         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2110         (buildVisualStudioProject): Ditto.
2111         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2112         (usingVisualStudioExpress): Deleted.
2113
2114 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2115
2116         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2117         https://bugs.webkit.org/show_bug.cgi?id=191093
2118         <rdar://problem/45685706>
2119
2120         Unreviewed build fix.
2121
2122         error C2065: 'renderTarget': undeclared identifier
2123
2124         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2125         (createBitmapContextFromWebView): Restored the previous implementation.
2126
2127 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2128
2129         [PlayStation] Enable JavaScriptCore
2130         https://bugs.webkit.org/show_bug.cgi?id=191072
2131
2132         Reviewed by Brent Fulgham.
2133
2134         Add platform scripts for building the PlayStation port.
2135         perl Tools/Scripts/build-webkit --playstation
2136
2137         * Scripts/build-webkit:
2138         * Scripts/build-webkittestrunner:
2139         * Scripts/webkitdirs.pm:
2140         (argumentsForConfiguration):
2141         (determineConfigurationProductDir):
2142         (isPlayStation): Added.
2143         (getMSBuildPlatformArgument): Added.
2144         (buildVisualStudioProject):
2145         (wrapperPrefixIfNeeded):
2146         (generateBuildSystemFromCMakeProject):
2147         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2148
2149 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2150
2151         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2152         https://bugs.webkit.org/show_bug.cgi?id=191093
2153         <rdar://problem/45685706>
2154
2155         Reviewed by Alex Christensen.
2156
2157         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2158         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2159         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2160         (pixelDumpSystemFactory): Added.
2161         (printPNG): Create stub.
2162         (computeMD5HashStringForBitmapContext): Ditto.
2163         (dumpBitmap): Ditto.
2164         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2165         (BitmapContext::createByAdoptingBitmapAndContext):
2166         (BitmapContext::~BitmapContext):
2167         (BitmapContext::platformContext const):
2168         (BitmapContext::BitmapContext):
2169         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2170         (createBitmapContextFromWebView): Update to support Direct2D.
2171         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2172         logo is no longer available at this location. Switch to the new logo.
2173
2174 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2175
2176         webkitpy: Support alternate simctl list outputs
2177         https://bugs.webkit.org/show_bug.cgi?id=191090
2178         <rdar://problem/45684255>
2179
2180         Rubber-stamped by Aakash Jain.
2181
2182         * Scripts/webkitpy/xcode/simulated_device.py:
2183         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2184         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2185         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2186         (test_available_devices): Add iOS 12 with alternative availability format.
2187
2188 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2189
2190         Clean up some obsolete MAX_ALLOWED macros
2191         https://bugs.webkit.org/show_bug.cgi?id=190916
2192
2193         Reviewed by Tim Horton.
2194
2195         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2196         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2197         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2198
2199 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2200
2201         [GTK][WPE] Fixes to the PublicSuffix implementation
2202         https://bugs.webkit.org/show_bug.cgi?id=191031
2203
2204         Reviewed by Michael Catanzaro.
2205
2206         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2207         (TestWebKitAPI::TEST_F): Remove a test for a domain
2208         that is not registrable and shouldn't be tested there.
2209
2210 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2211
2212         Modernize WebKit nibs and lprojs for localization's sake
2213         https://bugs.webkit.org/show_bug.cgi?id=190911
2214         <rdar://problem/45349466>
2215
2216         Reviewed by Dan Bernstein.
2217
2218         * Scripts/check-inspector-strings:
2219         * Scripts/update-webkit-localizable-strings:
2220         * gtk/manifest.txt.in:
2221         * wpe/manifest.txt.in:
2222         English->en
2223
2224 2018-10-29  Daniel Bates  <dabates@apple.com>
2225
2226         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2227         https://bugs.webkit.org/show_bug.cgi?id=191036
2228
2229         Reviewed by Andy Estes.
2230
2231         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2232         by an enum that contains two or more enumerators with the same value. For example, suppose
2233         you have the following enum:
2234
2235         enum Flag {
2236             A = 1 << 0,
2237             AAlias = A,
2238         };
2239
2240         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2241         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2242         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2243         tend to be used in bounds checks as opposed to code that adds to a set.
2244
2245         * lldb/lldbWebKitTester/main.cpp:
2246         (testSummaryProviders):
2247         * lldb/lldb_webkit.py:
2248         (WTFOptionSetProvider.update):
2249         * lldb/lldb_webkit_unittest.py:
2250         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2251         (TestSummaryProviders):
2252         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2253
2254 2018-10-29  Daniel Bates  <dabates@apple.com>
2255
2256         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2257         https://bugs.webkit.org/show_bug.cgi?id=191033
2258
2259         Reviewed by Andy Estes.
2260
2261         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2262         We display the same details in the summary for a Frame because its Document tends to be the most
2263         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2264         and whether the origin has universal access.
2265
2266         * lldb/lldb_webkit.py:
2267         (__lldb_init_module):
2268         Register new summary providers.
2269
2270         (WebCoreSecurityOrigin_SummaryProvider):
2271         (WebCoreFrame_SummaryProvider):
2272         (WebCoreDocument_SummaryProvider):
2273         Add new summary providers.
2274
2275         (StdOptionalWrapper):
2276         (StdOptionalWrapper.__init__):
2277         (StdOptionalWrapper.has_value):
2278         (StdOptionalWrapper.value):
2279         Convenience data type that provides access to the fields of a std::optional<>.
2280         
2281         (WebCoreSecurityOriginProvider):
2282         (WebCoreSecurityOriginProvider.__init__):
2283         (WebCoreSecurityOriginProvider.is_unique):
2284         (WebCoreSecurityOriginProvider.scheme):
2285         (WebCoreSecurityOriginProvider.host):
2286         (WebCoreSecurityOriginProvider.port):
2287         (WebCoreSecurityOriginProvider.domain):
2288         (WebCoreSecurityOriginProvider.has_universal_access):
2289         (WebCoreSecurityOriginProvider.to_string):
2290         (WebCoreFrameProvider):
2291         (WebCoreFrameProvider.__init__):
2292         (WebCoreFrameProvider.is_main_frame):
2293         (WebCoreFrameProvider.document):
2294         (WebCoreDocumentProvider):
2295         (WebCoreDocumentProvider.__init__):
2296         (WebCoreDocumentProvider.url):
2297         (WebCoreDocumentProvider.origin):
2298         (WebCoreDocumentProvider.page_cache_state):
2299         (WebCoreDocumentProvider.frame):
2300
2301 2018-10-29  Chris Dumez  <cdumez@apple.com>
2302
2303         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
2304         https://bugs.webkit.org/show_bug.cgi?id=190975
2305         <rdar://problem/45059256>
2306
2307         Reviewed by Antti Koivisto.
2308
2309         Add API test coverage.
2310
2311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2312
2313 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2314
2315         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
2316         https://bugs.webkit.org/show_bug.cgi?id=191018
2317
2318         Reviewed by Antti Koivisto.
2319
2320         * LayoutReloaded/misc/LFC-passing-tests.txt:
2321
2322 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2323
2324         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
2325         https://bugs.webkit.org/show_bug.cgi?id=191011
2326
2327         Reviewed by Antti Koivisto.
2328
2329         * LayoutReloaded/misc/LFC-passing-tests.txt:
2330
2331 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2332
2333         Missing from r237549
2334
2335         Reviewed by Antti Koivisto.
2336
2337         * LayoutReloaded/misc/LFC-passing-tests.txt:
2338
2339 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2340
2341         [LFC][IFC] Add support for simple intruding floats.
2342         https://bugs.webkit.org/show_bug.cgi?id=190998
2343
2344         Reviewed by Antti Koivisto.
2345
2346         * LayoutReloaded/misc/LFC-passing-tests.txt:
2347
2348 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2349
2350         [LFC][IFC] Inline layout produces separate runs when float is present.
2351         https://bugs.webkit.org/show_bug.cgi?id=190980
2352
2353         Reviewed by Antti Koivisto.
2354
2355         * LayoutReloaded/misc/LFC-passing-tests.txt:
2356
2357 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
2358
2359         New bytecode format for JSC
2360         https://bugs.webkit.org/show_bug.cgi?id=187373
2361         <rdar://problem/44186758>
2362
2363         Reviewed by Filip Pizlo.
2364
2365         Do not force ENABLE_JIT=true when $forceCLoop is false.
2366
2367         * Scripts/build-jsc:
2368
2369 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2370
2371         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
2372
2373         Unreviewed build fix
2374
2375         The build fails because of some array-bound check related
2376         to strcmp() macro optimizations. Disabling selective Werrors
2377         when building xserver-xorg might get past this.
2378
2379         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
2380         configuration.
2381
2382 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2383
2384         [GTK] Update API test expectations after r237383
2385         https://bugs.webkit.org/show_bug.cgi?id=186913
2386
2387         Unreviewed gardening.
2388
2389         * TestWebKitAPI/glib/TestExpectations.json: Remove
2390         passing TestSSL tests.
2391
2392 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
2393
2394         [WPE] Add the WebKitVersion.h header
2395         https://bugs.webkit.org/show_bug.cgi?id=191015
2396
2397         Reviewed by Michael Catanzaro.
2398
2399         * MiniBrowser/wpe/main.cpp:
2400         (automationStartedCallback): Remove the FIXME and finally enable the
2401         webkit_application_info_set_version() call.
2402         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
2403         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
2404
2405 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2406
2407         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
2408         https://bugs.webkit.org/show_bug.cgi?id=190948
2409
2410         Reviewed by Brent Fulgham.
2411
2412         vcxproj files have been removed in Bug 154388.
2413
2414         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
2415         * Scripts/build-jsc:
2416         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
2417         which is not used because Windows ports are using CMake.
2418
2419 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
2420
2421         HashMap should support selecting a random entry
2422         https://bugs.webkit.org/show_bug.cgi?id=190814
2423
2424         Reviewed by Ryosuke Niwa.
2425
2426         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
2427         IsEvenlyDistributed to reflect the fact that we're only testing the
2428         distribution. Added a test case that covers more table densities and
2429         the remove() operation.
2430
2431 2018-10-27  Charlie Turner  <cturner@igalia.com>
2432
2433         [GTK] Add bubblewrap feature option
2434         https://bugs.webkit.org/show_bug.cgi?id=190981
2435
2436         Reviewed by Xabier Rodriguez-Calvar.
2437
2438         Without this, it was not possible to disable the bubblewrap sandbox
2439         from the webkit build scripts.
2440
2441         * Scripts/webkitperl/FeatureList.pm:
2442
2443 2018-10-26  Commit Queue  <commit-queue@webkit.org>
2444
2445         Unreviewed, rolling out r237479 and r237484.
2446         https://bugs.webkit.org/show_bug.cgi?id=190978
2447
2448         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
2449
2450         Reverted changesets:
2451
2452         "New bytecode format for JSC"
2453         https://bugs.webkit.org/show_bug.cgi?id=187373
2454         https://trac.webkit.org/changeset/237479
2455
2456         "Gardening: Build fix after r237479."
2457         https://bugs.webkit.org/show_bug.cgi?id=187373
2458         https://trac.webkit.org/changeset/237484
2459
2460 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
2461
2462         New bytecode format for JSC
2463         https://bugs.webkit.org/show_bug.cgi?id=187373
2464         <rdar://problem/44186758>
2465
2466         Reviewed by Filip Pizlo.
2467
2468         Do not force ENABLE_JIT=true when $forceCLoop is false.
2469
2470         * Scripts/build-jsc:
2471
2472 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
2473
2474         HashMap should support selecting a random entry
2475         https://bugs.webkit.org/show_bug.cgi?id=190814
2476
2477         Reviewed by Antti Koivisto.
2478
2479         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
2480         more thoroughly test for randomness.
2481
2482 2018-10-26  Antti Koivisto  <antti@apple.com>
2483
2484         hashSet.remove(hashSet.random()) doesn't build
2485         https://bugs.webkit.org/show_bug.cgi?id=190953
2486
2487         Reviewed by Chris Dumez.
2488
2489         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2490         (TestWebKitAPI::TEST):
2491
2492 2018-10-26  Zalan Bujtas  <zalan@apple.com>
2493
2494         [LFC][IFC] Layout floats as part of the inline content
2495         https://bugs.webkit.org/show_bug.cgi?id=190942
2496
2497         Reviewed by Antti Koivisto.
2498
2499         * LayoutReloaded/misc/LFC-passing-tests.txt:
2500
2501 2018-10-26  Alicia Boya García  <aboya@igalia.com>
2502
2503         [MSE][WTF][Media] Invalid MediaTime should be falsy
2504         https://bugs.webkit.org/show_bug.cgi?id=190893
2505
2506         Reviewed by Jer Noble.
2507
2508         This patch adds additional API tests for the conversions from
2509         MediaTime to boolean.
2510
2511         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2512         (TestWebKitAPI::TEST):
2513
2514 2018-10-25  Chris Dumez  <cdumez@apple.com>
2515
2516         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
2517         https://bugs.webkit.org/show_bug.cgi?id=190915
2518         <rdar://problem/45059069>
2519
2520         Reviewed by Geoffrey Garen.
2521
2522         Add API test coverage.
2523
2524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2525
2526 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2527
2528         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
2529         https://bugs.webkit.org/show_bug.cgi?id=190896
2530
2531         Reviewed by Matt Baker.
2532
2533         * Scripts/webkitpy/common/config/watchlist:
2534
2535 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
2536
2537         HashMap should support selecting a random entry
2538         https://bugs.webkit.org/show_bug.cgi?id=190814
2539
2540         Reviewed by Antti Koivisto.
2541
2542         Unit testing is fun and easy!
2543
2544         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2545         (TestWebKitAPI::ZeroHash::hash):
2546         (TestWebKitAPI::TEST):
2547
2548 2018-10-24  Tim Horton  <timothy_horton@apple.com>
2549
2550         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
2551         https://bugs.webkit.org/show_bug.cgi?id=190897
2552
2553         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2554         (TestWebKitAPI::TEST):
2555         Disable the test for now.
2556
2557 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2558
2559         Clean up some obsolete macOS version guards
2560         https://bugs.webkit.org/show_bug.cgi?id=190887
2561
2562         Reviewed by Dan Bernstein.
2563
2564         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2565         (__simulated_forceClickAssociatedEventsMask):
2566         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2567         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2568         (WTR::initializeWebViewConfiguration):
2569         * WebKitTestRunner/mac/EventSenderProxy.mm:
2570         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2571
2572 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2573
2574         Turn on Conic Gradients
2575         https://bugs.webkit.org/show_bug.cgi?id=190810
2576
2577         Reviewed by Tim Horton.
2578
2579         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2580
2581 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
2582
2583         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
2584         https://bugs.webkit.org/show_bug.cgi?id=190328
2585
2586         Reviewed by Michael Catanzaro.
2587
2588         * TestWebKitAPI/CMakeLists.txt:
2589         * TestWebKitAPI/PlatformWPE.cmake:
2590
2591 2018-10-24  Chris Dumez  <cdumez@apple.com>
2592
2593         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
2594         https://bugs.webkit.org/show_bug.cgi?id=190846
2595         <rdar://problem/45058938>
2596
2597         Reviewed by Antti Koivisto.
2598
2599         Add API test coverage.
2600
2601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2602
2603 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
2604
2605         [GTK] TestSSL failing because of missing libsoup patch
2606         https://bugs.webkit.org/show_bug.cgi?id=190869
2607
2608         Reviewed by Michael Catanzaro.
2609
2610         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
2611         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2612
2613 2018-10-23  Justin Fan  <justin_fan@apple.com>
2614
2615         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
2616         https://bugs.webkit.org/show_bug.cgi?id=190817
2617
2618         Reviewed by Dean Jackson.
2619
2620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2621         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
2622         (TestWebKitAPI::TEST_F):
2623         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2624         (TestWebKitAPI::TEST_F):
2625         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
2626         (TestWebKitAPI::TEST_F):
2627         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2628         (TestWebKitAPI::TEST_F):
2629         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
2630         (TestWebKitAPI::TEST_F):
2631         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
2632
2633 2018-10-23  Chris Dumez  <cdumez@apple.com>
2634
2635         [PSON] Add support for cross-site client-side redirects
2636         https://bugs.webkit.org/show_bug.cgi?id=190806
2637         <rdar://problem/45047344>
2638
2639         Reviewed by Geoffrey Garen.
2640
2641         Add API test coverage.
2642
2643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2644         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
2645         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
2646
2647 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
2648
2649         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
2650         https://bugs.webkit.org/show_bug.cgi?id=190789
2651
2652         Reviewed by Michael Catanzaro.
2653
2654         When the network process serializes certificate data to other
2655         processes through the argument coders, the certificate chain, if
2656         present, is lost. In practice this means that applications using
2657         the public API to process certificate info have no details on the
2658         certificate chain, other than the very basics included in the
2659         certificate. Serialize the entire chain if available in the
2660         certificate.
2661
2662         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2663         (testSSL): Test that the self-signed certificate has no bogus
2664         issuer certificate.
2665
2666 2018-10-22  Tim Horton  <timothy_horton@apple.com>
2667
2668         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
2669         https://bugs.webkit.org/show_bug.cgi?id=190801
2670         <rdar://problem/43674361>
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2673         (TEST):
2674         Use a parented WKWebView for this test, otherwise none of the assertions
2675         about gesture recognizers work anymore.
2676
2677 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
2678
2679         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
2680         https://bugs.webkit.org/show_bug.cgi?id=187972
2681
2682         Unreviewed test gardening.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2685         (TestWebKitAPI::TEST): Disable the flaky test.
2686
2687 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2688
2689         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
2690         https://bugs.webkit.org/show_bug.cgi?id=190777
2691
2692         Reviewed by Tim Horton.
2693
2694         Implement isShowingDataListSuggestions on iOS. See below for more details.
2695
2696         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2697         (WTR::UIScriptController::isShowingDataListSuggestions const):
2698
2699         Add a stub implementation for DumpRenderTree.
2700
2701         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2702         (WTR::UIScriptController::isShowingDataListSuggestions const):
2703
2704         Move this stub implementation to !PLATFORM(COCOA).
2705
2706         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2707         (WTR::forEachViewInHierarchy):
2708
2709         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
2710
2711         (WTR::UIScriptController::isShowingDataListSuggestions const):
2712
2713         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
2714
2715 2018-10-19  Dan Bernstein  <mitz@apple.com>
2716
2717         [macOS] MiniBrowser has an unused injected bundle
2718         https://bugs.webkit.org/show_bug.cgi?id=190770
2719
2720         Reviewed by Tim Horton.
2721
2722         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2723         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2724           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2725         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2726         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2727         * MiniBrowser/mac/Bundle: Removed.
2728
2729 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2730
2731         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2732         https://bugs.webkit.org/show_bug.cgi?id=190621
2733         <rdar://problem/45310649>
2734
2735         Reviewed by Tim Horton.
2736
2737         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2738
2739         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2740         (WTR::UIScriptController::resignFirstResponder):
2741         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2742         (WTR::UIScriptController::resignFirstResponder):
2743         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2744         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2745         (WTR::UIScriptController::resignFirstResponder):
2746         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2747         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2748         (WTR::UIScriptController::resignFirstResponder):
2749         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2750         (WTR::PlatformWebView::makeWebViewFirstResponder):
2751
2752         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2753         responder on the WKWebView when running iOS layout tests.
2754
2755         * WebKitTestRunner/ios/TestControllerIOS.mm:
2756         (WTR::TestController::platformResetStateToConsistentValues):
2757
2758         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2759
2760 2018-10-19  Dean Jackson  <dino@apple.com>
2761
2762         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2763         https://bugs.webkit.org/show_bug.cgi?id=186946
2764         <rdar://problem/41724248>
2765
2766         Reviewed by Antoine Quint.
2767
2768         If the incoming test has different enableWebAnimationsCSSIntegration options,
2769         then we need to create a new WebView.
2770
2771         * DumpRenderTree/TestOptions.cpp:
2772         (TestOptions::webViewIsCompatibleWithOptions const):
2773
2774 2018-10-19  Charlie Turner  <cturner@igalia.com>
2775
2776         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2777         https://bugs.webkit.org/show_bug.cgi?id=190738
2778
2779         Reviewed by Xabier Rodriguez-Calvar.
2780
2781         Add a GStreamer patch to avoid crashing when the run-time logging
2782         level is TRACE. There was a missing null check which caused many
2783         tests to crash.
2784
2785         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2786
2787 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2788
2789         [Media] Use nanoseconds as MaximumTimeScale
2790         https://bugs.webkit.org/show_bug.cgi?id=190631
2791
2792         Rebased MediaTime tests covering timescales over the maximum.
2793
2794         Reviewed by Jer Noble.
2795
2796         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2797         (TestWebKitAPI::TEST):
2798
2799 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2800
2801         clean-webkit pulls in many unnecessary dependencies in webkitpy
2802         https://bugs.webkit.org/show_bug.cgi?id=190732
2803
2804         Reviewed by Alexey Proskuryakov.
2805
2806         * Scripts/webkitpy/common/host.py:
2807         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2808         (Host):
2809         (Host.bugs):
2810         (Host.bugzilla):
2811         (Host.web):
2812
2813 2018-10-18  Chris Dumez  <cdumez@apple.com>
2814
2815         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2816         https://bugs.webkit.org/show_bug.cgi?id=190721
2817         <rdar://problem/45059699>
2818
2819         Reviewed by Alex Christensen.
2820
2821         Add API test coverage.
2822
2823         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2824
2825 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2826
2827         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2828         https://bugs.webkit.org/show_bug.cgi?id=190729
2829
2830         Reviewed by Tim Horton.
2831
2832         * DumpRenderTree/AccessibilityController.h:
2833         * DumpRenderTree/AccessibilityTextMarker.h:
2834         * DumpRenderTree/AccessibilityUIElement.cpp:
2835         (AccessibilityUIElement::getJSClass):
2836         * DumpRenderTree/AccessibilityUIElement.h:
2837         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2838         * DumpRenderTree/TestRunner.cpp:
2839         (getSecureEventInputIsEnabledCallback):
2840         (TestRunner::staticFunctions):
2841         (TestRunner::callUIScriptCallback):
2842         * DumpRenderTree/TestRunner.h:
2843         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2844         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2845         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2846         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2847         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2848         * DumpRenderTree/ios/TextInputControllerIOS.m:
2849         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2850         * DumpRenderTree/mac/AppleScriptController.m:
2851         * DumpRenderTree/mac/DumpRenderTree.mm:
2852         (createWebViewAndOffscreenWindow):
2853         (destroyWebViewAndOffscreenWindow):
2854         (resetWebPreferencesToConsistentValues):
2855         (setDefaultsToConsistentValuesForTesting):
2856         (allocateGlobalControllers):
2857         (releaseGlobalControllers):
2858         (addTestPluginsToPluginSearchPath):
2859         (prepareConsistentTestingEnvironment):
2860         (dumpRenderTree):
2861         (DumpRenderTreeMain):
2862         (dumpFrameAsPDF):
2863         (dumpBackForwardListForAllWindows):
2864         (updateDisplay):
2865         (dump):
2866         (resetWebViewToConsistentStateBeforeTesting):
2867         (runTest):
2868         (displayWebView):
2869         (displayAndTrackRepaintsWebView):
2870         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2871         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2872         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2873         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2874         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2875         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2876         (-[DumpRenderTreeWindow close]):
2877         (-[DumpRenderTreeWindow webView]):
2878         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2879         * DumpRenderTree/mac/EventSendingController.h:
2880         * DumpRenderTree/mac/EventSendingController.mm:
2881         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2882         (+[EventSendingController webScriptNameForSelector:]):
2883         (-[EventSendingController dealloc]):
2884         (-[EventSendingController currentEventTime]):
2885         (-[EventSendingController clearKillRing]):
2886         (modifierFlags):
2887         (-[EventSendingController mouseDown:withModifiers:]):
2888         (-[EventSendingController scalePageBy:atX:andY:]):
2889         (-[EventSendingController mouseUp:withModifiers:]):
2890         (-[EventSendingController mouseMoveToX:Y:]):
2891         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2892         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2893         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2894         (-[FrameLoadDelegate init]):
2895         (-[FrameLoadDelegate dealloc]):
2896         (-[FrameLoadDelegate processWork:]):
2897         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2898         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2899         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2900         * DumpRenderTree/mac/LayoutTestHelper.m:
2901         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2902         (-[MockGeolocationProvider timerFired]):
2903         * DumpRenderTree/mac/TestRunnerMac.mm:
2904         (TestRunner::setMainFrameIsFirstResponder):
2905         (TestRunner::setAutomaticLinkDetectionEnabled):
2906         (TestRunner::setUseDashboardCompatibilityMode):
2907         (TestRunner::isCommandEnabled):
2908         (TestRunner::inspectorTestStubURL):
2909         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2910         (TestRunner::abortModal):
2911         (TestRunner::setTextDirection):
2912         (TestRunner::addChromeInputField):
2913         (TestRunner::removeChromeInputField):
2914         (TestRunner::focusWebView):
2915         (TestRunner::setBackingScaleFactor):
2916         (TestRunner::imageCountInGeneralPasteboard const):
2917         * DumpRenderTree/mac/UIDelegate.h:
2918         * DumpRenderTree/mac/UIDelegate.mm:
2919         (-[UIDelegate modalWindowWillClose:]):
2920         (-[UIDelegate webViewRunModal:]):
2921         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2922         (-[UIDelegate dealloc]):
2923         * Scripts/check-for-inappropriate-objc-class-names:
2924         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2925         * TestRunnerShared/spi/UIKitTestSPI.h:
2926         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2927         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2928         (WebCore::operator<<):
2929         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2930         (TestWebKitAPI::TEST):
2931         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2932         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2933         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2934         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2935         (TestWebKitAPI::TEST):
2936         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2937         (TestWebKitAPI::TEST):
2938         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2939         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2940         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2941         (TEST):
2942         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2943         (TEST):
2944         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2945         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2946         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2947         (TEST):
2948         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2949         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2950         (createWebViewWithCustomPasteboardDataEnabled):
2951         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2952         (TEST):
2953         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2954         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2955         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2956         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2957         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2958         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2959         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2960         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2961         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2962         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2963         (defaultWebsiteCacheDirectory):
2964         (defaultApplicationCacheDirectory):
2965         (TEST):
2966         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2967         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2968         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2969         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2970         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2971         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2972         (TestWebKitAPI::TEST):
2973         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2974         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2975         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2976         (runTestWithWidth):
2977         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2978         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2979         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2980         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2981         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2982         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2983         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2984         (platformCopyRichTextWithMultipleAttachments):
2985         (platformCopyRichTextWithImage):
2986         (platformCopyPNG):
2987         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2988         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2989         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2990         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2991         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2992         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2993         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2994         (TEST):
2995         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2996         (TEST):
2997         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2998         (TEST):
2999         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
3000         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3001         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
3002         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
3003         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3004         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3005         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3006         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3007         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3008         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
3009         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
3010         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3011         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
3012         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3013         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3014         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
3015         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3016         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
3017         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
3018         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3019         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
3020         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3021         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3022         (-[WKWebView _test_waitForDidFinishNavigation]):
3023         * TestWebKitAPI/cocoa/TestWKWebView.h:
3024         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3025         * TestWebKitAPI/config.h:
3026         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3027         * TestWebKitAPI/ios/TestWKWebViewController.h:
3028         * TestWebKitAPI/ios/TestWKWebViewController.mm:
3029         * TestWebKitAPI/ios/UIKitSPI.h:
3030         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3031         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3032         (WTR::InjectedBundle::beginTesting):
3033         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3034         (WTR::TestRunner::inspectorTestStubURL):
3035         * WebKitTestRunner/TestController.cpp:
3036         (WTR::TestController::webProcessName):
3037         (WTR::TestController::networkProcessName):
3038         * WebKitTestRunner/TestInvocation.cpp:
3039         (WTR::TestInvocation::invoke):
3040         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3041         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3042         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3043         (WTR::initializeWebViewConfiguration):
3044         (WTR::TestController::platformCreateWebView):
3045         (WTR::TestController::imageCountInGeneralPasteboard const):
3046         (WTR::TestController::addTestKeyToKeychain):
3047         (WTR::TestController::cleanUpKeychain):
3048         (WTR::TestController::keyExistsInKeychain):
3049         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3050         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3051         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3052
3053 2018-10-18  Chris Dumez  <cdumez@apple.com>
3054
3055         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
3056         https://bugs.webkit.org/show_bug.cgi?id=190688
3057         <rdar://problem/45354095>
3058
3059         Reviewed by Antti Koivisto.
3060
3061         Extended API test coverage to confirm that:
3062         - We do not accumulate more than 3 suspended processes.
3063         - We can navigate back 3 times and use the page cache for each of these loads.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3066
3067 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3068
3069         Enable the datalist element by default on iOS and macOS
3070         https://bugs.webkit.org/show_bug.cgi?id=190594
3071         <rdar://problem/45281159>
3072
3073         Reviewed by Ryosuke Niwa and Tim Horton.
3074
3075         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3076
3077 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
3078
3079         AX: Certain tags should identify their context to iOS API
3080         https://bugs.webkit.org/show_bug.cgi?id=190622
3081         <rdar://problem/45308194>
3082
3083         Reviewed by Zalan Bujtas.
3084
3085         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3086         (AccessibilityUIElement::stringAttributeValue):
3087         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3088         (WTR::AccessibilityUIElement::stringAttributeValue):
3089
3090 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
3091
3092         Add a switch for Web SQL
3093         https://bugs.webkit.org/show_bug.cgi?id=190271
3094
3095         Reviewed by Ryosuke Niwa.
3096
3097         * WebKitTestRunner/TestController.cpp:
3098         (WTR::TestController::resetPreferencesToConsistentValues):
3099
3100 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3101
3102         Remove InjectedBundleBackForwardList
3103         https://bugs.webkit.org/show_bug.cgi?id=190640
3104
3105         Reviewed by Chris Dumez.
3106
3107         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3108         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3109         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3110         (WTR::InjectedBundlePage::prepare):
3111         (WTR::InjectedBundlePage::dumpHistory):
3112         (WTR::hasPrefix): Deleted.
3113         (WTR::compareByTargetName): Deleted.
3114         (WTR::dumpBackForwardListItem): Deleted.
3115         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3117         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3118         (WTR::TestRunner::clearBackForwardList):
3119
3120 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3121
3122         Unreviewed, added myself to contributors.json.
3123
3124         * Scripts/webkitpy/common/config/contributors.json:
3125
3126 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3127
3128         Implement feature flag and bindings for CSS Painting API
3129         https://bugs.webkit.org/show_bug.cgi?id=190237
3130
3131         Reviewed by Ryosuke Niwa.
3132
3133         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3134
3135 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3136
3137         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
3138
3139         * gstreamer/jhbuild.modules:
3140
3141 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3142
3143         [GTK][JHBuild] Disable libmount support in glib
3144
3145         Rubber-stamped by Alejandro G. Castro.
3146
3147         This feature doesn't seem required for our setup.
3148
3149         * gtk/jhbuild.modules:
3150
3151 2018-10-15  Justin Fan  <justin_fan@apple.com>
3152
3153         Add WebGPU 2018 feature flag and experimental feature flag
3154         https://bugs.webkit.org/show_bug.cgi?id=190509
3155
3156         Reviewed by Dean Jackson.
3157
3158         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3159         for the 2018 WebGPU prototype.
3160
3161         * DumpRenderTree/TestOptions.cpp:
3162         (TestOptions::TestOptions):
3163         * DumpRenderTree/TestOptions.h:
3164         * DumpRenderTree/mac/DumpRenderTree.mm:
3165         (setWebPreferencesForTestOptions):
3166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3167
3168 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3169
3170         Update bot configuration for Sierra archive queues
3171         https://bugs.webkit.org/show_bug.cgi?id=190605
3172
3173         Reviewed by Aakash Jain.
3174
3175         * BuildSlaveSupport/build.webkit.org-config/config.json:
3176
3177 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3178
3179         Add support for prefers-color-scheme media query
3180         https://bugs.webkit.org/show_bug.cgi?id=190499
3181         rdar://problem/45212025
3182
3183         Reviewed by Dean Jackson.
3184
3185         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
3186         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3187
3188 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3189
3190         [JHBuild] Add xdg-dbus-proxy module
3191         https://bugs.webkit.org/show_bug.cgi?id=190589
3192
3193         Reviewed by Michael Catanzaro.
3194
3195         * gtk/jhbuild.modules:
3196
3197 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3198
3199         [GTK] Add new sandboxing dependencies to install-dependencies
3200         https://bugs.webkit.org/show_bug.cgi?id=190588
3201
3202         Reviewed by Michael Catanzaro.
3203
3204         * gtk/install-dependencies:
3205
3206 2018-10-15  Chris Dumez  <cdumez@apple.com>
3207
3208         Experiment: target=_blank on anchors should imply rel=noopener
3209         https://bugs.webkit.org/show_bug.cgi?id=190481
3210
3211         Reviewed by Alex Christensen.
3212
3213         Add API test coverage to make sure we can now swap process when target=_blank
3214         is specified on an anchor but rel=noopener is not.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3217
3218 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3219
3220         [iOS] Can't select text after dismissing the keyboard when changing focus
3221         https://bugs.webkit.org/show_bug.cgi?id=190563
3222         <rdar://problem/44613559>
3223
3224         Reviewed by Tim Horton.
3225
3226         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3227         (WTR::UIScriptController::isShowingKeyboard const):
3228
3229         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
3230         details.
3231
3232         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3233         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3234         (WTR::UIScriptController::isShowingKeyboard const):
3235         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3236         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3237         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3238
3239         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
3240         `isShowingKeyboard` as the getter method.
3241
3242         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3243         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3244         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3245         (WTR::UIScriptController::isShowingKeyboard const):
3246
3247 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3248
3249         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
3250
3251         * Scripts/run-javascriptcore-tests:
3252         (runJSCStressTests): Remove wsl-tests.yaml.
3253
3254 2018-10-15  Christopher Reid  <chris.reid@sony.com>
3255
3256         [Curl][WinCairo] Add Public Suffix support to WinCairo
3257         https://bugs.webkit.org/show_bug.cgi?id=183060
3258
3259         Reviewed by Alex Christensen.
3260
3261         Share mac's PublicSuffix tests with all ports.
3262
3263         * TestWebKitAPI/PlatformWin.cmake:
3264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3265         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3266         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
3267
3268 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
3269
3270         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
3271         https://bugs.webkit.org/show_bug.cgi?id=190555
3272
3273         Unreviewed.
3274
3275         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
3276
3277         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
3278         * WebGPUShadingLanguageRI/All.js: Removed.
3279         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
3280         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
3281         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
3282         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
3283         * WebGPUShadingLanguageRI/Assignment.js: Removed.
3284         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
3285         * WebGPUShadingLanguageRI/Block.js: Removed.
3286         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
3287         * WebGPUShadingLanguageRI/Break.js: Removed.
3288         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
3289         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
3290         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
3291         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
3292         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
3293         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
3294         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
3295         * WebGPUShadingLanguageRI/Casts.js: Removed.
3296         * WebGPUShadingLanguageRI/Check.js: Removed.
3297         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
3298         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
3299         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
3300         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
3301         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
3302         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
3303         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
3304         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
3305         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
3306         * WebGPUShadingLanguageRI/Checker.js: Removed.
3307         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
3308         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
3309         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
3310         * WebGPUShadingLanguageRI/Continue.js: Removed.
3311         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
3312         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
3313         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
3314         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
3315         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
3316         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
3317         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
3318         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
3319         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
3320         * WebGPUShadingLanguageRI/EPtr.js: Removed.
3321         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
3322         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
3323         * WebGPUShadingLanguageRI/EnumType.js: Removed.
3324         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
3325         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
3326         * WebGPUShadingLanguageRI/Expression.js: Removed.
3327         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
3328         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
3329         * WebGPUShadingLanguageRI/Field.js: Removed.
3330         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
3331         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
3332         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
3333         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
3334         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
3335         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
3336         * WebGPUShadingLanguageRI/Func.js: Removed.
3337         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
3338         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
3339         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
3340         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
3341         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
3342         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
3343         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
3344         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
3345         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
3346         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
3347         * WebGPUShadingLanguageRI/Inline.js: Removed.
3348         * WebGPUShadingLanguageRI/Inliner.js: Removed.
3349         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
3350         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
3351         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
3352         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
3353         * WebGPUShadingLanguageRI/Lexer.js: Removed.
3354         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
3355         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
3356         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
3357         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
3358         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
3359         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
3360         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
3361         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
3362         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
3363         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
3364         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
3365         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
3366         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
3367         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
3368         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
3369         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
3370         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
3371         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
3372         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
3373         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
3374         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
3375         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
3376         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
3377         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
3378         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
3379         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
3380         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
3381         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
3382         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
3383         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
3384         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
3385         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
3386         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
3387         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
3388         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
3389         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
3390         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
3391         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
3392         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
3393         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
3394         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
3395         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
3396         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
3397         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
3398         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
3399         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
3400         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
3401         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
3402         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
3403         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
3404         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
3405         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
3406         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
3407         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
3408         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
3409         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
3410         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
3411         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
3412         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
3413         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
3414         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
3415         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
3416         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
3417         * WebGPUShadingLanguageRI/NameContext.js: Removed.
3418         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
3419         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
3420         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
3421         * WebGPUShadingLanguageRI/NativeType.js: Removed.
3422         * WebGPUShadingLanguageRI/Node.js: Removed.
3423         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
3424         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
3425         * WebGPUShadingLanguageRI/NullType.js: Removed.
3426         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
3427         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
3428         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
3429         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
3430         * WebGPUShadingLanguageRI/Parse.js: Removed.
3431         * WebGPUShadingLanguageRI/Prepare.js: Removed.
3432         * WebGPUShadingLanguageRI/Program.js: Removed.
3433         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
3434         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
3435         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
3436         * WebGPUShadingLanguageRI/PtrType.js: Removed.
3437         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
3438         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
3439         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
3440         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
3441         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
3442         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
3443         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
3444         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
3445         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
3446         * WebGPUShadingLanguageRI/Return.js: Removed.
3447         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
3448         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
3449         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
3450         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
3451         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
3452         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
3453         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
3454         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
3455         * WebGPUShadingLanguageRI/Sampler.js: Removed.
3456         * WebGPUShadingLanguageRI/Semantic.js: Removed.
3457         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
3458         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
3459         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
3460         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
3461         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
3462         * WebGPUShadingLanguageRI/StructType.js: Removed.
3463         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
3464         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
3465         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
3466         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
3467         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
3468         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
3469         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
3470         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
3471         * WebGPUShadingLanguageRI/Test.html: Removed.
3472         * WebGPUShadingLanguageRI/Test.js: Removed.
3473         * WebGPUShadingLanguageRI/Texture.js: Removed.
3474         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
3475         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
3476         * WebGPUShadingLanguageRI/Type.js: Removed.
3477         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
3478         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
3479         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
3480         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
3481         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
3482         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
3483         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
3484         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
3485         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
3486         * WebGPUShadingLanguageRI/Value.js: Removed.
3487         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
3488         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
3489         * WebGPUShadingLanguageRI/VectorType.js: Removed.
3490         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
3491         * WebGPUShadingLanguageRI/Visitor.js: Removed.
3492         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
3493         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
3494         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
3495         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
3496         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
3497         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
3498         * WebGPUShadingLanguageRI/index.html: Removed.
3499         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
3500         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
3501
3502 2018-10-15  Philippe Normand  <pnormand@igalia.com>
3503
3504         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
3505         https://bugs.webkit.org/show_bug.cgi?id=190581
3506
3507         Reviewed by Michael Catanzaro.
3508
3509         These bots don't use JHBuild and their host GStreamer version is
3510         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
3511
3512         * BuildSlaveSupport/build.webkit.org-config/config.json:
3513
3514 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3515
3516         Use pragma once in WTF
3517         https://bugs.webkit.org/show_bug.cgi?id=190527
3518
3519         Reviewed by Chris Dumez.
3520
3521         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
3522
3523         * DumpRenderTree/TestRunner.cpp:
3524         (TestRunner::queueLoadHTMLString):
3525         (TestRunner::queueLoadAlternateHTMLString):
3526         (TestRunner::queueBackNavigation):
3527         (TestRunner::queueForwardNavigation):
3528         (TestRunner::queueLoadingScript):
3529         (TestRunner::queueNonLoadingScript):
3530         (TestRunner::queueReload):
3531         * DumpRenderTree/WorkQueue.cpp:
3532         (WorkQueue::singleton): Deleted.
3533         (WorkQueue::WorkQueue): Deleted.
3534         (WorkQueue::queue): Deleted.
3535         (WorkQueue::dequeue): Deleted.
3536         (WorkQueue::count): Deleted.
3537         (WorkQueue::clear): Deleted.
3538         (WorkQueue::processWork): Deleted.
3539         * DumpRenderTree/WorkQueue.h:
3540         (WorkQueue::setFrozen): Deleted.
3541         * DumpRenderTree/WorkQueueItem.h:
3542         * DumpRenderTree/mac/DumpRenderTree.mm:
3543         (runTest):
3544         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3545         (-[FrameLoadDelegate processWork:]):
3546         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3547         * DumpRenderTree/mac/TestRunnerMac.mm:
3548         (TestRunner::notifyDone):
3549         (TestRunner::forceImmediateCompletion):
3550         (TestRunner::queueLoad):
3551         * DumpRenderTree/win/DumpRenderTree.cpp:
3552         (runTest):
3553         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3554         (FrameLoadDelegate::processWork):
3555         (FrameLoadDelegate::locationChangeDone):
3556         * DumpRenderTree/win/TestRunnerWin.cpp:
3557         (TestRunner::notifyDone):
3558         (TestRunner::forceImmediateCompletion):
3559         (TestRunner::queueLoad):
3560
3561 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3562
3563         [JSC] Remove Option::useAsyncIterator
3564         https://bugs.webkit.org/show_bug.cgi?id=190567
3565
3566         Reviewed by Saam Barati.
3567
3568         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3569
3570 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
3571
3572         [WPE] Silence a unused-parameter warning
3573
3574         Unreviewed.
3575         * MiniBrowser/wpe/main.cpp:
3576         (decidePermissionRequest):
3577
3578 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
3579
3580         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
3581         https://bugs.webkit.org/show_bug.cgi?id=190537
3582
3583         Reviewed by Alexey Proskuryakov.
3584
3585         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
3586         needs to be split before adding it to the command since it is treated
3587         as a list of args.
3588
3589         * Scripts/webkitpy/common/config/ports.py:
3590         (DeprecatedPort.run_javascriptcore_tests_command):
3591
3592 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3593
3594         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
3595         https://bugs.webkit.org/show_bug.cgi?id=190504
3596         <rdar://problem/45117760>
3597
3598         Reviewed by Tim Horton.
3599
3600         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
3601         macOS and iOS.
3602
3603         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3604         (WTR::UIScriptController::setViewScale):
3605         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3606         (WTR::UIScriptController::setViewScale):
3607         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3608         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3609         (WTR::UIScriptController::setViewScale):
3610         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3611     &nbs