Fix API test after r241728
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2
3         Fix API test after r241728
4        ​https://bugs.webkit.org/show_bug.cgi?id=194723
5
6         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
7         (TEST):
8         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
9
10 2019-02-18  Daniel Bates  <dabates@apple.com>
11
12         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
13         https://bugs.webkit.org/show_bug.cgi?id=192824
14         <rdar://problem/47100332>
15
16         Reviewed by Wenson Hsieh.
17
18         Fix a bug where the wrong usage code was used for F13 thru F24.
19
20         * WebKitTestRunner/ios/HIDEventGenerator.mm:
21         (keyCodeForDOMFunctionKey):
22
23 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
24
25         Bytecode cache should a have a boot-specific validation
26         https://bugs.webkit.org/show_bug.cgi?id=194769
27         <rdar://problem/48149509>
28
29         Reviewed by Keith Miller.
30
31         Add test for WTF::bootSessionUUIDString()
32
33         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
34         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
35         (TEST):
36
37 2019-02-18  Alex Christensen  <achristensen@webkit.org>
38
39         Disable safe browsing in WKWebView and remove its WKPreferences API
40         https://bugs.webkit.org/show_bug.cgi?id=194723
41         <rdar://problem/48122993>
42
43         Reviewed by Geoffrey Garen.
44
45         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
46         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
47         (TEST):
48         (safeBrowsingView):
49         Make tests use SPI instead of API.
50
51 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
52
53         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
54         https://bugs.webkit.org/show_bug.cgi?id=194586
55
56         Reviewed by Ross Kirsling.
57
58         * DumpRenderTree/win/DumpRenderTree.cpp:
59         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
60         * Scripts/webkitpy/port/driver.py:
61         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
62
63 2019-02-17  David Kilzer  <ddkilzer@apple.com>
64
65         Unreviewed, rolling out r241620.
66
67         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
68         (Requested by ddkilzer on #webkit.)
69
70         Reverted changeset:
71
72         "[WTF] Add environment variable helpers"
73         https://bugs.webkit.org/show_bug.cgi?id=192405
74         https://trac.webkit.org/changeset/241620
75
76 2019-02-16  Zalan Bujtas  <zalan@apple.com>
77
78         [LFC] RenderImage's default intrinsic size is 0.
79         https://bugs.webkit.org/show_bug.cgi?id=194745
80
81         Reviewed by Antti Koivisto.
82
83         * LayoutReloaded/misc/LFC-passing-tests.txt:
84
85 2019-02-16  Zalan Bujtas  <zalan@apple.com>
86
87         [LFC][BFC] Add support for block replaced intrinsic width.
88         https://bugs.webkit.org/show_bug.cgi?id=194705
89
90         Reviewed by Simon Fraser.
91
92         * LayoutReloaded/misc/LFC-passing-tests.txt:
93
94 2019-02-16  Zalan Bujtas  <zalan@apple.com>
95
96         [LFC] Apply min/max width constraints to preferred width computation
97         https://bugs.webkit.org/show_bug.cgi?id=194739
98
99         Reviewed by Simon Fraser.
100
101         * LayoutReloaded/misc/LFC-passing-tests.txt:
102
103 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
104
105         [WTF] Add environment variable helpers
106         https://bugs.webkit.org/show_bug.cgi?id=192405
107
108         Reviewed by Michael Catanzaro.
109
110         * DumpRenderTree/mac/DumpRenderTree.mm:
111         (libraryPathForDumpRenderTree):
112         * DumpRenderTree/win/DumpRenderTree.cpp:
113         (libraryPathForDumpRenderTree):
114         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
115         (setUpIOSLayoutTestCommunication):
116         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
117         (beforeAll):
118         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
119         (main):
120         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
121         (WebKitTestBus::run):
122         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
123         (WTR::getOutputDir):
124         (WTR::initializeFontConfigSetting):
125         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
126         (WTR::InjectedBundle::platformInitialize):
127         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
128         (WTR::topLevelPath):
129         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
130         (WTR::topLevelPath):
131         (WTR::getOutputDir):
132         (WTR::activateFonts):
133         * WebKitTestRunner/TestController.cpp:
134         (WTR::TestController::libraryPathForTesting):
135         (WTR::TestController::generateContextConfiguration const):
136         (WTR::TestController::generatePageConfiguration):
137         (WTR::TestController::decideDestinationWithSuggestedFilename):
138         (WTR::TestController::platformAdjustContext):
139         * WebKitTestRunner/TestController.h:
140         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
141         (WTR::TestController::cocoaPlatformInitialize):
142         (WTR::TestController::platformAdjustContext):
143         * WebKitTestRunner/gtk/main.cpp:
144         (main):
145         * WebKitTestRunner/mac/TestControllerMac.mm:
146         (WTR::TestController::configureContentExtensionForTest):
147         * WebKitTestRunner/wpe/main.cpp:
148         (main):
149         Utilize WTF::Environment where possible.
150
151 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
152
153         [iOS] WKWebView callout bar is missing Change Writing Direction item
154         https://bugs.webkit.org/show_bug.cgi?id=190015
155         <rdar://problem/44810366>
156
157         Reviewed by Tim Horton.
158
159         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
160         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
161
162         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
163         (TestWebKitAPI::TEST):
164
165 2019-02-15  Chris Dumez  <cdumez@apple.com>
166
167         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
168         https://bugs.webkit.org/show_bug.cgi?id=194717
169         <rdar://problem/47884404>
170
171         Reviewed by Brady Eidson.
172
173         Add API test coverage.
174
175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
176
177 2019-02-15  Youenn Fablet  <youenn@apple.com>
178
179         Make navigator.mediaDevices SecureContext
180         https://bugs.webkit.org/show_bug.cgi?id=194666
181
182         Reviewed by Eric Carlson.
183
184         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
185         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
186         (TEST_F):
187
188 2019-02-15  Brian Burg  <bburg@apple.com>
189
190         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
191         https://bugs.webkit.org/show_bug.cgi?id=194411
192         <rdar://problem/47787614>
193
194         Reviewed by Joseph Pecoraro.
195
196         Remove unnecessary soft linking macro usage.
197
198         * DumpRenderTree/mac/TestRunnerMac.mm:
199         (TestRunner::inspectorTestStubURL):
200         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
201         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
202         (WTR::TestRunner::inspectorTestStubURL):
203
204 2019-02-15  Commit Queue  <commit-queue@webkit.org>
205
206         Unreviewed, rolling out r241559 and r241566.
207         https://bugs.webkit.org/show_bug.cgi?id=194710
208
209         Causes layout test crashes under GuardMalloc (Requested by
210         ryanhaddad on #webkit).
211
212         Reverted changesets:
213
214         "[WTF] Add environment variable helpers"
215         https://bugs.webkit.org/show_bug.cgi?id=192405
216         https://trac.webkit.org/changeset/241559
217
218         "Unreviewed build fix for WinCairo Debug after r241559."
219         https://trac.webkit.org/changeset/241566
220
221 2019-02-15  Zalan Bujtas  <zalan@apple.com>
222
223         [LFC] Out-of-flow box is never a float box
224         https://bugs.webkit.org/show_bug.cgi?id=194704
225
226         Reviewed by Antti Koivisto.
227
228         * LayoutReloaded/misc/LFC-passing-tests.txt:
229
230 2019-02-10  Darin Adler  <darin@apple.com>
231
232         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
233         https://bugs.webkit.org/show_bug.cgi?id=194487
234
235         Reviewed by Daniel Bates.
236
237         * DumpRenderTree/win/DumpRenderTree.cpp:
238         (applicationId): Use makeString instead of String::format.
239         (main): Ditto.
240         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
241         (TestWebKitAPI::Util::createURLForResource): Ditto.
242         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
243         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
244
245         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
246         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
247         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
248         (WTR::createStringWithAttributes): Use appendLiteral.
249         (WTR::AccessibilityUIElement::helpText const): Ditto.
250         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
251         directly instead of using String::format.
252         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
253         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
254
255 2019-02-15  Truitt Savell  <tsavell@apple.com>
256
257         Unreviewed, rolling out r241564.
258
259         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
260
261         Reverted changeset:
262
263         "[Mac] WebInspectorUI.framework does not need to be soft-
264         linked anymore"
265         https://bugs.webkit.org/show_bug.cgi?id=194411
266         https://trac.webkit.org/changeset/241564
267
268 2019-02-15  Saam barati  <sbarati@apple.com>
269
270         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
271         https://bugs.webkit.org/show_bug.cgi?id=194036
272
273         Reviewed by Yusuke Suzuki.
274
275         * Scripts/run-jsc-stress-tests:
276
277 2019-02-14  Tim Horton  <timothy_horton@apple.com>
278
279         Fix the build.
280
281         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
282         (WTR::UIScriptController::drawSquareInEditableImage):
283         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
284         (TestWebKitAPI::drawSquareInEditableImage):
285
286 2019-02-14  Tim Horton  <timothy_horton@apple.com>
287
288         Fix the build.
289
290         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
291         (WTR::UIScriptController::drawSquareInEditableImage):
292         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
293         (TestWebKitAPI::drawSquareInEditableImage):
294
295 2019-02-14  Brian Burg  <bburg@apple.com>
296
297         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
298         https://bugs.webkit.org/show_bug.cgi?id=194411
299         <rdar://problem/47787614>
300
301         Reviewed by Joseph Pecoraro.
302
303         Remove unnecessary soft linking macro usage.
304
305         * DumpRenderTree/mac/TestRunnerMac.mm:
306         (TestRunner::inspectorTestStubURL):
307         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
308         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
309         (WTR::TestRunner::inspectorTestStubURL):
310
311 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
312
313         [ews-app] status bubble should fetch builder name info from BuilderMapping table
314         https://bugs.webkit.org/show_bug.cgi?id=194599
315
316         Reviewed by Lucas Forschler.
317
318         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
319         (StatusBubble._build_bubble):
320
321 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
322
323         [ews-app] Set Foreign Key in Django build model
324         https://bugs.webkit.org/show_bug.cgi?id=194667
325
326         Reviewed by Lucas Forschler.
327
328         * BuildSlaveSupport/ews-app/ews/models/build.py:
329         (Build):
330
331 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
332
333         [WTF] Add environment variable helpers
334         https://bugs.webkit.org/show_bug.cgi?id=192405
335
336         Reviewed by Michael Catanzaro.
337
338         * DumpRenderTree/mac/DumpRenderTree.mm:
339         (libraryPathForDumpRenderTree):
340         * DumpRenderTree/win/DumpRenderTree.cpp:
341         (libraryPathForDumpRenderTree):
342         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
343         (setUpIOSLayoutTestCommunication):
344         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
345         (TestWebKitAPI::strip):
346         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
347         (beforeAll):
348         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
349         (main):
350         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
351         (WebKitTestBus::run):
352         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
353         (WTR::getOutputDir):
354         (WTR::initializeFontConfigSetting):
355         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
356         (WTR::InjectedBundle::platformInitialize):
357         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
358         (WTR::topLevelPath):
359         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
360         (WTR::topLevelPath):
361         (WTR::getOutputDir):
362         (WTR::activateFonts):
363         * WebKitTestRunner/TestController.cpp:
364         (WTR::TestController::libraryPathForTesting):
365         (WTR::TestController::generateContextConfiguration const):
366         (WTR::TestController::generatePageConfiguration):
367         (WTR::TestController::decideDestinationWithSuggestedFilename):
368         (WTR::TestController::platformAdjustContext):
369         * WebKitTestRunner/TestController.h:
370         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
371         (WTR::TestController::cocoaPlatformInitialize):
372         (WTR::TestController::platformAdjustContext):
373         * WebKitTestRunner/gtk/main.cpp:
374         (main):
375         * WebKitTestRunner/mac/TestControllerMac.mm:
376         (WTR::TestController::configureContentExtensionForTest):
377         * WebKitTestRunner/wpe/main.cpp:
378         (main):
379         Utilize WTF::Environment where possible.
380
381 2019-02-14  Chris Dumez  <cdumez@apple.com>
382
383         [PSON] Introduce a WebContent Process cache
384         https://bugs.webkit.org/show_bug.cgi?id=194594
385         <rdar://problem/46793397>
386
387         Reviewed by Geoff Garen.
388
389         Update API tests to turn on the WebContent Process cache.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
392
393 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
394
395         Unreviewed, build fix after r241480
396
397         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
398         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
399         (-[DragAndDropSimulator initWithWebView:]):
400
401 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
402
403         AX: ARIA Reflection was disabled in error
404         https://bugs.webkit.org/show_bug.cgi?id=194647
405         <rdar://problem/48068336>
406
407         Reviewed by Ryosuke Niwa.
408
409         Remove test override now that this feature should be enabled by default.
410
411         * WebKitTestRunner/TestController.cpp:
412         (WTR::TestController::resetPreferencesToConsistentValues):
413
414 2019-02-14  Commit Queue  <commit-queue@webkit.org>
415
416         Unreviewed, rolling out r241486.
417         https://bugs.webkit.org/show_bug.cgi?id=194655
418
419         causing API failures in builds (Requested by ShawnRoberts on
420         #webkit).
421
422         Reverted changeset:
423
424         "[Cocoa] Media elements will restart network buffering just
425         before suspending"
426         https://bugs.webkit.org/show_bug.cgi?id=193691
427         https://trac.webkit.org/changeset/241486
428
429 2019-02-14  Zalan Bujtas  <zalan@apple.com>
430
431         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
432         https://bugs.webkit.org/show_bug.cgi?id=194622
433
434         Reviewed by Antti Koivisto.
435
436         * LayoutReloaded/misc/LFC-passing-tests.txt:
437
438 2019-02-14  Zalan Bujtas  <zalan@apple.com>
439
440         [LFC] Shrink-to-fit-width should be constrained by min/max width
441         https://bugs.webkit.org/show_bug.cgi?id=194653
442
443         Reviewed by Antti Koivisto.
444
445         * LayoutReloaded/misc/LFC-passing-tests.txt:
446
447 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
448
449         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
450         https://bugs.webkit.org/show_bug.cgi?id=194641
451
452         Reviewed by Geoffrey Garen.
453
454         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
455         so that the test would fail without this fix.
456
457         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
458         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
459
460 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
461
462         [ews-app] Change log level for a log statement
463
464         Unreviewed minor fix.
465
466         * BuildSlaveSupport/ews-app/ews/models/patch.py:
467         (Patch.save_patch):
468
469 2019-02-13  Jer Noble  <jer.noble@apple.com>
470
471         [Cocoa] Media elements will restart network buffering just before suspending
472         https://bugs.webkit.org/show_bug.cgi?id=193691
473
474         Reviewed by Eric Carlson.
475
476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
478         (TEST):
479
480 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
481
482         [ews-app] Fetch builder id to name mapping
483         https://bugs.webkit.org/show_bug.cgi?id=194355
484
485         Reviewed by Lucas Forschler.
486
487         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
488         (Buildbot.get_builder_id_to_name_mapping):
489         (Buildbot._get_display_name_from_builder_name):
490
491 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
492
493         Further restricting webarchive loads
494         https://bugs.webkit.org/show_bug.cgi?id=194567
495         <rdar://problem/47610130>
496
497         Reviewed by Youenn Fablet.
498
499         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
500         navigations on drop.
501
502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
503         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
504         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
505         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
506         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
509         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
510         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
511         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
512         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
513         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
514         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
515
516 2019-02-13  John Wilander  <wilander@apple.com>
517
518         Store Ad Click Attribution requests in the network process
519         https://bugs.webkit.org/show_bug.cgi?id=194510
520         <rdar://problem/47650118>
521
522         Reviewed by Alex Christensen and Daniel Bates.
523
524         This patch adds two TestRunner functions:
525         - dumpAdClickAttribution()
526         - clearAdClickAttribution()
527
528         They call into the network process to dump and clear Ad Click
529         Attribution state, respectively.
530
531         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
532         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
533         (WTR::TestRunner::dumpAdClickAttribution):
534         (WTR::TestRunner::clearAdClickAttribution):
535         * WebKitTestRunner/InjectedBundle/TestRunner.h:
536         * WebKitTestRunner/TestController.cpp:
537         (WTR::TestController::resetStateToConsistentValues):
538         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
539         (WTR::adClickAttributionStringResultCallback):
540         (WTR::TestController::dumpAdClickAttribution):
541         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
542         (WTR::adClickAttributionVoidCallback):
543         (WTR::TestController::clearAdClickAttribution):
544         * WebKitTestRunner/TestController.h:
545         * WebKitTestRunner/TestInvocation.cpp:
546         (WTR::TestInvocation::dumpResults):
547         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
548         (WTR::TestInvocation::dumpAdClickAttribution):
549         * WebKitTestRunner/TestInvocation.h:
550
551 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
552
553         [ews-app] Generate status-bubble
554         https://bugs.webkit.org/show_bug.cgi?id=194572
555
556         Reviewed by Lucas Forschler.
557
558         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
559         (StatusBubble._build_bubble):
560         (StatusBubble._should_show_bubble_for):
561         (StatusBubble._build_bubbles_for_patch):
562
563 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
564
565         [ews-app] Add status bubble html template
566         https://bugs.webkit.org/show_bug.cgi?id=194571
567
568         Reviewed by Lucas Forschler.
569
570         * BuildSlaveSupport/ews-app/ews/templates: Added.
571         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
572
573 2019-02-12  Chris Dumez  <cdumez@apple.com>
574
575         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
576         https://bugs.webkit.org/show_bug.cgi?id=194568
577         <rdar://problem/47944490>
578
579         Reviewed by Ryosuke Niwa.
580
581         Add API test coverage.
582
583         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
584         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
585
586 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
587
588         webkitpy: Remove bug_dummy from parsed test expectations
589         https://bugs.webkit.org/show_bug.cgi?id=194562
590         <rdar://problem/47853999>
591
592         Reviewed by Lucas Forschler.
593
594         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
595         (TestExpectationParser):
596         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
597         skipped tests.
598         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
599
600 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
601
602         [ews-app] Add method to fetch patch
603         https://bugs.webkit.org/show_bug.cgi?id=194518
604
605         Reviewed by Lucas Forschler.
606
607         * BuildSlaveSupport/ews-app/ews/models/patch.py:
608         (Patch.get_patch):
609
610 2019-02-12  Zalan Bujtas  <zalan@apple.com>
611
612         [LFC] Expand tests coverage (60 new tests -> 860)
613
614         Unreviewed test gardening (run-singly, --child-processes=1).
615
616         * LayoutReloaded/misc/LFC-passing-tests.txt:
617
618 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
619
620         Allow pages to trigger programmatic paste from script on iOS
621         https://bugs.webkit.org/show_bug.cgi?id=194271
622         <rdar://problem/47808810>
623
624         Reviewed by Tim Horton.
625
626         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
627
628         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
629         (WTR::UIScriptController::platformSetDidShowMenuCallback):
630         (WTR::UIScriptController::platformSetDidHideMenuCallback):
631         (WTR::UIScriptController::rectForMenuAction const):
632
633         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
634         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
635         for when the menu is shown or hidden.
636
637         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
638         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
639         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
640         (WTR::UIScriptController::setDidShowMenuCallback):
641         (WTR::UIScriptController::didShowMenuCallback const):
642         (WTR::UIScriptController::setDidHideMenuCallback):
643         (WTR::UIScriptController::didHideMenuCallback const):
644         (WTR::UIScriptController::platformSetDidShowMenuCallback):
645         (WTR::UIScriptController::platformSetDidHideMenuCallback):
646         (WTR::UIScriptController::rectForMenuAction const):
647         * TestRunnerShared/UIScriptContext/UIScriptController.h:
648         * WebKitTestRunner/TestController.cpp:
649         (WTR::TestController::resetPreferencesToConsistentValues):
650         (WTR::updateTestOptionsFromTestHeader):
651         * WebKitTestRunner/TestOptions.h:
652
653         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
654         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
655
656         (WTR::TestOptions::hasSameInitializationOptions const):
657         * WebKitTestRunner/UIScriptControllerCocoa.mm:
658         (WTR::UIScriptController::calendarType const):
659         (WTR::UIScriptController::platformUndoManager const):
660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
661         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
662         (-[TestRunnerWKWebView initWithFrame:configuration:]):
663         (-[TestRunnerWKWebView dealloc]):
664         (-[TestRunnerWKWebView _didShowMenu]):
665         (-[TestRunnerWKWebView _didHideMenu]):
666
667         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
668
669         * WebKitTestRunner/ios/TestControllerIOS.mm:
670         (WTR::handleMenuWillHideNotification):
671         (WTR::handleMenuDidHideNotification):
672         (WTR::TestController::platformInitialize):
673         (WTR::TestController::platformDestroy):
674         (WTR::TestController::platformResetStateToConsistentValues):
675
676         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
677         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
678
679         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
680         (WTR::forEachViewInHierarchy):
681         (WTR::findViewInHierarchyOfType):
682
683         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
684         functions that dig through a given view's hierarchy in search of a view of a given class.
685
686         (WTR::UIScriptController::selectionStartGrabberViewRect const):
687         (WTR::UIScriptController::selectionEndGrabberViewRect const):
688         (WTR::UIScriptController::selectionCaretViewRect const):
689         (WTR::UIScriptController::selectionRangeViewRects const):
690         (WTR::UIScriptController::platformSetDidShowMenuCallback):
691         (WTR::UIScriptController::platformSetDidHideMenuCallback):
692
693         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
694
695         (WTR::UIScriptController::rectForMenuAction const):
696
697         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
698         callout bar) whose label matches the given string.
699
700         (WTR::UIScriptController::platformContentView const):
701
702         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
703         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
704         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
705
706         (WTR::UIScriptController::platformUndoManager const): Deleted.
707         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
708         (WTR::UIScriptController::platformContentView const):
709         (WTR::UIScriptController::platformUndoManager const): Deleted.
710
711 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
712
713         webkitpy: No option to only show unexpected failures in results.html for iPad
714         https://bugs.webkit.org/show_bug.cgi?id=194554
715         <rdar://problem/47922442>
716
717         Rubber-stamped by Aakash Jain.
718
719         Just because a TestExpecations file does not exist for a specific platform does not mean that
720         TestExpecations are not being used, given that platforms inherit test expectations.
721
722         * Scripts/webkitpy/port/base.py:
723         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
724         * Scripts/webkitpy/port/base_unittest.py:
725         (PortTest.test_uses_test_expectations_file):
726
727 2019-02-12  Alex Christensen  <achristensen@webkit.org>
728
729         Remove setDefersLoading infrastructure from WebKit2
730         https://bugs.webkit.org/show_bug.cgi?id=194506
731
732         Reviewed by Brady Eidson.
733
734         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::setDefersLoading): Deleted.
737         * WebKitTestRunner/InjectedBundle/TestRunner.h:
738
739 2019-02-12  Alex Christensen  <achristensen@webkit.org>
740
741         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
742         https://bugs.webkit.org/show_bug.cgi?id=194522
743         <rdar://problem/47789393>
744
745         Reviewed by Chris Dumez.
746
747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
748         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
749         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
751
752 2019-02-12  Andy Estes  <aestes@apple.com>
753
754         [iOSMac] Enable Parental Controls Content Filtering
755         https://bugs.webkit.org/show_bug.cgi?id=194521
756         <rdar://39732376>
757
758         Reviewed by Tim Horton.
759
760         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
761
762 2019-02-12  Zalan Bujtas  <zalan@apple.com>
763
764         [LFC][IFC] Add intrinsic width support for float boxes.
765         https://bugs.webkit.org/show_bug.cgi?id=194528
766
767         Reviewed by Antti Koivisto.
768
769         Expand tests coverage (2 new tests -> 800).
770         (This is the correct test ordering --runs-singly --child-processes=1)
771
772         * LayoutReloaded/misc/LFC-passing-tests.txt:
773
774 2019-02-12  Rob Buis  <rbuis@igalia.com>
775
776         Implement serializing in MIME type parser
777         https://bugs.webkit.org/show_bug.cgi?id=193909
778
779         Reviewed by Darin Adler.
780
781         Add various tests involving upper case, non-ASCII, control/null characters,
782         various HTTP whitespace, single quotes and an unpaired surrogate.
783
784         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
785         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
786         (TestWebKitAPI::serializeIfValid):
787         (TestWebKitAPI::TEST):
788
789 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
790
791         [Cocoa] Ask platform for generic font family mappings
792         https://bugs.webkit.org/show_bug.cgi?id=187723
793         <rdar://problem/41892438>
794
795         Reviewed by Brent Fulgham.
796
797         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
798
799         * DumpRenderTree/mac/DumpRenderTree.mm:
800         (allowedFontFamilySet):
801         * WebKitTestRunner/mac/TestControllerMac.mm:
802         (WTR::allowedFontFamilySet):
803
804 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
805
806         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
807         https://bugs.webkit.org/show_bug.cgi?id=193622
808
809         Reviewed by Michael Catanzaro.
810
811         This adds support for loading content extension rule sets from the JSON files which
812         accompany the corresponding layout test, using the C API. The Cocoa specific parts
813         of WKTR for this could be removed, but that is left for a follow-up patch with
814         cleanups.
815
816         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
817         * WebKitTestRunner/TestController.cpp:
818         (WTR::testPath): Subtract one from the length when constructing the result std::string to
819         avoid having the null-terminator copied into the result.
820         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
821         part of the preparations to run a test.
822         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
823         (WTR::contentExtensionStoreCallback): Added.
824         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
825         used for content extensions test.
826         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
827         extensions and compiling the JSON rule set for tests involving content extensions.
828         (WTR::TestController::resetContentExtensions): Removes the content extension built for
829         testing and disables content extensions.
830         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
831         resetContentExtensions().
832         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
833         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
834         configureContentExtensionForTest(), and userContentController().
835
836 2019-02-11  Daniel Bates  <dabates@apple.com>
837
838         [iOS] Mouse/Touch/Pointer events are missing modifier keys
839         https://bugs.webkit.org/show_bug.cgi?id=191446
840         <rdar://problem/45929460>
841
842         Reviewed by Tim Horton.
843
844         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
845
846         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
847         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
848         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
849         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
850         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
851         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
852         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
853         * TestRunnerShared/UIScriptContext/UIScriptController.h:
854         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
855         (WTR::arrayLength):
856         (WTR::parseModifierArray):
857         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
858         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
859         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
860         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
861
862 2019-02-11  Commit Queue  <commit-queue@webkit.org>
863
864         Unreviewed, rolling out r241272 and r241276.
865         https://bugs.webkit.org/show_bug.cgi?id=194514
866
867         Broke the Apple Internal build and the fix requires human
868         intervention :( (Requested by dydz on #webkit).
869
870         Reverted changesets:
871
872         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
873         https://bugs.webkit.org/show_bug.cgi?id=191446
874         https://trac.webkit.org/changeset/241272
875
876         "Fix internal iOS build after r241272"
877         https://bugs.webkit.org/show_bug.cgi?id=191446
878         https://trac.webkit.org/changeset/241276
879
880 2019-02-11  Truitt Savell  <tsavell@apple.com>
881
882         Unreviewed, rolling out r241269.
883
884         Caused 5 layout tests crashes on Mac WK1
885
886         Reverted changeset:
887
888         "DumpRenderTree should report unknown options"
889         https://bugs.webkit.org/show_bug.cgi?id=191303
890         https://trac.webkit.org/changeset/241269
891
892 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
893
894         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
895         https://bugs.webkit.org/show_bug.cgi?id=194313
896
897         Reviewed by Tim Horton.
898
899         Add a helper to determine whether the web view is presenting modal UI.
900
901         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
902         (WTR::UIScriptController::isPresentingModally const):
903         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
904         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
905         (WTR::UIScriptController::isPresentingModally const):
906         * TestRunnerShared/UIScriptContext/UIScriptController.h:
907         * WebKitTestRunner/UIScriptControllerCocoa.mm:
908         (WTR::UIScriptController::calendarType const): Deleted.
909         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
910         (WTR::UIScriptController::isPresentingModally const):
911         (WTR::UIScriptController::calendarType const):
912         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
913         (WTR::UIScriptController::calendarType const):
914
915 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
916
917         GCHeapInspector: Show the retained sizes in more places
918         https://bugs.webkit.org/show_bug.cgi?id=194464
919
920         Reviewed by Simon Fraser.
921
922         * GCHeapInspector/gc-heap-inspector.html:
923         * GCHeapInspector/script/interface.js:
924         (HeapInspectorUtils.humanReadableSize):
925         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
926         (HeapInspectorUtils.spanForNode.span.span):
927         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
928         (HeapSnapshotInspector.prototype.buildRoots):
929
930 2019-02-11  Daniel Bates  <dabates@apple.com>
931
932         [iOS] Mouse/Touch/Pointer events are missing modifier keys
933         https://bugs.webkit.org/show_bug.cgi?id=191446
934         <rdar://problem/45929460>
935
936         Reviewed by Tim Horton.
937
938         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
939
940         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
941         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
942         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
943         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
944         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
945         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
946         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
947         * TestRunnerShared/UIScriptContext/UIScriptController.h:
948         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
949         (WTR::arrayLength):
950         (WTR::parseModifierArray):
951         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
952         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
953         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
954         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
955
956 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
957
958         DumpRenderTree should report unknown options
959         https://bugs.webkit.org/show_bug.cgi?id=191303
960
961         Reviewed by Frédéric Wang.
962
963         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
964         to report unknown options.
965         Added and assigned test options which are currently used in tests.
966
967         * DumpRenderTree/TestOptions.cpp:
968         (TestOptions::TestOptions):
969
970 2019-02-11  Truitt Savell  <tsavell@apple.com>
971
972         Unreviewed, rolling out r241229.
973
974         Revision broke internal builds for watchOS.
975
976         Reverted changeset:
977
978         "[Cocoa] Ask platform for generic font family mappings"
979         https://bugs.webkit.org/show_bug.cgi?id=187723
980         https://trac.webkit.org/changeset/241229
981
982 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
983
984         [WinCairo][MiniBrowser] Basic authentication always fails.
985         https://bugs.webkit.org/show_bug.cgi?id=194496
986
987         Reviewed by Don Olmstead.
988
989         * MiniBrowser/win/DialogHelper.h:
990         (Dialog::getText):
991
992 2019-02-11  Philippe Normand  <pnormand@igalia.com>
993
994         [GStreamer] GstMappedBuffer testsuite build fails
995         https://bugs.webkit.org/show_bug.cgi?id=194495
996
997         Reviewed by Carlos Garcia Campos.
998
999         Fix the build by explicitely adding the gstreamer1.0-audio include
1000         directories to the include path.
1001
1002         * TestWebKitAPI/PlatformGTK.cmake:
1003         * TestWebKitAPI/PlatformWPE.cmake:
1004
1005 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         [GTK][WPE] Add enable-javascript-markup setting
1008         https://bugs.webkit.org/show_bug.cgi?id=193439
1009
1010         Reviewed by Michael Catanzaro.
1011
1012         Add test cases to check the new setting.
1013
1014         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1015         (testWebKitSettings):
1016         (testWebKitSettingsJavaScriptMarkup):
1017         (beforeAll):
1018
1019 2019-02-10  Darin Adler  <darin@apple.com>
1020
1021         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1022         https://bugs.webkit.org/show_bug.cgi?id=194485
1023
1024         Reviewed by Daniel Bates.
1025
1026         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1027
1028 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1029
1030         Add more tests for clampTo<>()
1031         https://bugs.webkit.org/show_bug.cgi?id=194462
1032
1033         Reviewed by Geoffrey Garen.
1034
1035         Darin suggested to test the very last floating point number
1036         at the boundaries when truncating to integer.
1037         I added test for max/min and max-1/min-1.
1038
1039         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1040         (TestWebKitAPI::TEST):
1041
1042 2019-02-09  Darin Adler  <darin@apple.com>
1043
1044         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1045         https://bugs.webkit.org/show_bug.cgi?id=194021
1046
1047         Reviewed by Geoffrey Garen.
1048
1049         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1050         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1051         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1052
1053 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1054
1055         [LFC][IFC] Add intrinsic width support for basic inline containers
1056         https://bugs.webkit.org/show_bug.cgi?id=194473
1057
1058         Reviewed by Antti Koivisto.
1059
1060         Expand tests coverage (11 new tests -> 798)
1061
1062         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1063
1064 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1065
1066         Fix MiniBrowser's entitlements
1067         https://bugs.webkit.org/show_bug.cgi?id=192431
1068
1069         Reviewed by Joseph Pecoraro.
1070
1071         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1072         files, making it impossible to load any extension.
1073
1074         * MiniBrowser/MiniBrowser.entitlements:
1075
1076 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1077
1078         [Cocoa] Ask platform for generic font family mappings
1079         https://bugs.webkit.org/show_bug.cgi?id=187723
1080         <rdar://problem/41892438>
1081
1082         Reviewed by Brent Fulgham.
1083
1084         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1085
1086         * DumpRenderTree/mac/DumpRenderTree.mm:
1087         (allowedFontFamilySet):
1088         * WebKitTestRunner/mac/TestControllerMac.mm:
1089         (WTR::allowedFontFamilySet):
1090
1091 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1092
1093         [GTK] Implement back/forward touchpad gesture
1094         https://bugs.webkit.org/show_bug.cgi?id=193919
1095
1096         Reviewed by Michael Catanzaro.
1097
1098         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1099         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1100
1101 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1102
1103         Add SPI to use networking daemon instead of XPC service
1104         https://bugs.webkit.org/show_bug.cgi?id=194427
1105
1106         Reviewed by Geoffrey Garen
1107
1108         * MiniBrowser/MiniBrowser.entitlements:
1109
1110 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1111
1112         [ews-build] Ensure that every builder in config.json has short name
1113         https://bugs.webkit.org/show_bug.cgi?id=194461
1114
1115         Reviewed by Lucas Forschler.
1116
1117         * BuildSlaveSupport/ews-build/loadConfig.py:
1118         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1119
1120 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1121
1122         [ews-build] Add short name to config.json
1123         https://bugs.webkit.org/show_bug.cgi?id=194456
1124
1125         Reviewed by Lucas Forschler.
1126
1127         * BuildSlaveSupport/ews-build/config.json: Added short name.
1128         * BuildSlaveSupport/ews-build/loadConfig.py:
1129         (loadBuilderConfig): Set the short name as the builder description.
1130
1131 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1132
1133         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1134         https://bugs.webkit.org/show_bug.cgi?id=194418
1135
1136         Reviewed by Lucas Forschler.
1137
1138         Do not include errors trying when finding crashlogs at the end of
1139         a run-webkit-tests run since we don't process those errors.
1140
1141         * Scripts/webkitpy/port/darwin.py:
1142         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1143         * Scripts/webkitpy/port/ios_device.py:
1144         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1145         * Scripts/webkitpy/port/watch_device.py:
1146         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1147
1148 2019-02-08  Beth Dakin  <bdakin@apple.com>
1149
1150         Add afterScreenUpdates to WKSnapshotConfiguration
1151         https://bugs.webkit.org/show_bug.cgi?id=194362
1152         -and corresponding-
1153         <rdar://problem/40655528> Please add an "after screen updates" property to 
1154         WKSnapshotConfiguration (to solve blank snapshots)
1155
1156         Reviewed by Tim Horton.
1157
1158         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1159         (TEST):
1160
1161 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1162
1163         clampTo(): do not convert the input to double when dealing with integers
1164         https://bugs.webkit.org/show_bug.cgi?id=194263
1165         <rdar://problem/47692312>
1166
1167         Reviewed by Darin Adler.
1168
1169         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1170         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1171         (TestWebKitAPI::testClampFloatingPointToInteger):
1172         (TestWebKitAPI::testClampSameSignIntegers):
1173         (TestWebKitAPI::testClampUnsignedToSigned):
1174         (TestWebKitAPI::testClampSignedToUnsigned):
1175
1176 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1177
1178         webkitpy: Respect --dedicated-simulators flag
1179         https://bugs.webkit.org/show_bug.cgi?id=194416
1180         <rdar://problem/47894722>
1181
1182         Reviewed by Lucas Forschler.
1183
1184         * Scripts/webkitpy/port/device_port.py:
1185         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1186         available devices can be safely ignored.
1187
1188 2019-02-07  Keith Rollin  <krollin@apple.com>
1189
1190         Remove extra copy of 100x100-red.tga
1191         https://bugs.webkit.org/show_bug.cgi?id=194371
1192         <rdar://problem/47873465>
1193
1194         Reviewed by Said Abou-Hallawa.
1195
1196         In order to help it pass its tests, Bug 194190 added a second copy of
1197         the file 100x100-red.tga. However, it turns out that this additional
1198         file wasn't actually needed, and that that sole previous copy was
1199         sufficient. At the same time, this second copy -- which was copied to
1200         the same location in the build output as the first copy -- now caused
1201         XCBuild to complain because there were two production rules for the
1202         same output file. Address this by removing the newly-added extra copy.
1203
1204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1205         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1206
1207 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1208
1209         Deprecate WKBundlePageSetDefersLoading
1210         https://bugs.webkit.org/show_bug.cgi?id=191394
1211
1212         Reviewed by Dean Jackson.
1213
1214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1215         (WTR::TestRunner::setDefersLoading):
1216
1217 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1218
1219         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1220         https://bugs.webkit.org/show_bug.cgi?id=194391
1221
1222         Reviewed by Antti Koivisto.
1223
1224         * LayoutReloaded/misc/LFC-passing-tests.txt:
1225
1226 2019-02-06  Keith Rollin  <krollin@apple.com>
1227
1228         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1229         https://bugs.webkit.org/show_bug.cgi?id=193975
1230         <rdar://problem/47643306>
1231
1232         Reviewed by Tim Horton.
1233
1234         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1235         the Info.plist file into the bundle. This step is not necessary as the
1236         implicit "bundle up all the build products into a framework" build
1237         phase does this already. Having the Copy Bundle Resources phase do
1238         this causes a conflict under XCBuild, which objects to two build
1239         phases producing the same file (Info.plist). Address this by removing
1240         Info.plist from the Copy Bundle Resources phase.
1241
1242         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1243
1244 2019-02-06  Keith Rollin  <krollin@apple.com>
1245
1246         Really enable the automatic checking and regenerations of .xcfilelists during builds
1247         https://bugs.webkit.org/show_bug.cgi?id=194357
1248         <rdar://problem/47861231>
1249
1250         Reviewed by Chris Dumez.
1251
1252         Bug 194124 was supposed to enable the automatic checking and
1253         regenerating of .xcfilelist files during the build. While related
1254         changes were included in that patch, the change to actually enable the
1255         operation somehow was omitted. This patch actually enables the
1256         operation. The check-xcfilelist.sh scripts now check
1257         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1258         from the checking.
1259
1260         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1261         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1262
1263 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1264
1265         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1266         <https://webkit.org/b/194286>
1267         <rdar://problem/47815558>
1268
1269         Reviewed by Alexey Proskuryakov.
1270
1271         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1272         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1273         WKRetainPtr<> to avoid leaking the WKDataRef.
1274
1275 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1276
1277         Unreviewed, fix a typo
1278
1279         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1280
1281 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1282
1283         [GTK][WPE] force libpsl build to use ICU in jhbuild
1284         https://bugs.webkit.org/show_bug.cgi?id=194288
1285
1286         Reviewed by Carlos Garcia Campos.
1287
1288         * gtk/jhbuild.modules:
1289         Require ICU for libpsl build in jhbuild, like done in WPE.
1290
1291 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1292
1293         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1294         https://bugs.webkit.org/show_bug.cgi?id=194209
1295
1296         Reviewed by Carlos Garcia Campos.
1297
1298         Enhance TestCookieManager to ensure this doesn't happen again.
1299
1300         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1301         (testCookieManagerPersistentStorage):
1302         (beforeAll):
1303
1304 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1305
1306         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1307         https://bugs.webkit.org/show_bug.cgi?id=194324
1308
1309         Reviewed by Andy Estes.
1310
1311         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1312         part of the name is already implicit, since this is in testing code in TestOptions.
1313
1314         * WebKitTestRunner/TestController.cpp:
1315         (WTR::TestController::generateContextConfiguration const):
1316         (WTR::updateTestOptionsFromTestHeader):
1317         * WebKitTestRunner/TestOptions.h:
1318         (WTR::TestOptions::hasSameInitializationOptions const):
1319
1320 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1321
1322         [ews-build] Allow * as platform for builders and workers
1323         https://bugs.webkit.org/show_bug.cgi?id=188533
1324
1325         Reviewed by Lucas Forschler.
1326
1327         * BuildSlaveSupport/ews-build/loadConfig.py:
1328         (checkWorkersAndBuildersForConsistency):
1329
1330 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1331
1332         [ews-build] Add few bots to config.json
1333         https://bugs.webkit.org/show_bug.cgi?id=194304
1334
1335         Reviewed by Lucas Forschler.
1336
1337         * BuildSlaveSupport/ews-build/config.json:
1338
1339 2019-02-05  Keith Rollin  <krollin@apple.com>
1340
1341         Enable the automatic checking and regenerations of .xcfilelists during builds
1342         https://bugs.webkit.org/show_bug.cgi?id=194124
1343         <rdar://problem/47721277>
1344
1345         Reviewed by Tim Horton.
1346
1347         Bug 193790 add a facility for checking -- during build time -- that
1348         any needed .xcfilelist files are up-to-date and for updating them if
1349         they are not. This facility was initially opt-in by setting
1350         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1351         the process seemed robust. Its now time to enable this facility and
1352         make it opt-out. If there is a need to disable this facility, set and
1353         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1354         running `make` or `build-webkit`, or before running Xcode from the
1355         command line.
1356
1357         Additionally, remove the step that generates a list of source files
1358         going into the UnifiedSources build step. It's only necessarily to
1359         specify Sources.txt and SourcesCocoa.txt as inputs.
1360
1361         * Scripts/generate-xcfilelists:
1362
1363 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1364
1365         [GTK][WPE] force libpsl build to use ICU in jhbuild
1366         https://bugs.webkit.org/show_bug.cgi?id=194288
1367
1368         Reviewed by Philippe Normand.
1369
1370         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1371         This can cause build failures if libidn is detected but libunistring is not available.
1372
1373         Make sure that ICU is used for runtime and builtin PSL data.
1374
1375         * gtk/jhbuild.modules:
1376         * wpe/jhbuild.modules:
1377
1378 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1379
1380         [ews-app] Modified timestamp should be updated on updating data
1381         https://bugs.webkit.org/show_bug.cgi?id=194295
1382
1383         Reviewed by Lucas Forschler.
1384
1385         * BuildSlaveSupport/ews-app/ews/models/build.py:
1386         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1387         * BuildSlaveSupport/ews-app/ews/models/step.py:
1388
1389 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1390
1391         Unreviewed, rolling out r240742.
1392
1393         Causes crashes on iOS simulator.
1394
1395         Reverted changeset:
1396
1397         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1398         not focused in a content-editable element"
1399         https://bugs.webkit.org/show_bug.cgi?id=192824
1400         https://trac.webkit.org/changeset/240742
1401
1402 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1403
1404         run-webkit-tests emits message "...running None" when running tests
1405         https://bugs.webkit.org/show_bug.cgi?id=194133
1406         <rdar://problem/47724738>
1407
1408         Reviewed by Lucas Forschler.
1409
1410         * Scripts/webkitpy/xcode/device_type.py:
1411         (DeviceType.__str__): Use both version mapping tables and use just the variant
1412         name if no version name is available.
1413         * Scripts/webkitpy/xcode/device_type_unittest.py:
1414         (DeviceTypeTest):
1415         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1416         an associated named.
1417
1418 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1419
1420         [WPE] require python3-setuptools for meson build in jhbuild
1421         https://bugs.webkit.org/show_bug.cgi?id=194287
1422
1423         Reviewed by Philippe Normand.
1424
1425         python3-setuptools is needed to build meson in jhbuild.
1426         It is already required by the GTK port.
1427
1428         * wpe/install-dependencies:
1429
1430 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1431
1432         [ews-app] Add method to save BuilderMapping to database
1433         https://bugs.webkit.org/show_bug.cgi?id=194264
1434
1435         Reviewed by Lucas Forschler.
1436
1437         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1438         (BuilderMapping.__str__):
1439         (BuilderMapping):
1440         (BuilderMapping.save_mapping):
1441         (BuilderMapping.update_mapping):
1442         (BuilderMapping.get_existing_mapping):
1443         (BuilderMapping.is_valid_mapping):
1444
1445 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-app] Add timestamp fields for BuilderMappings
1448         https://bugs.webkit.org/show_bug.cgi?id=194266
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1453         (BuilderMapping):
1454
1455 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1456
1457         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1458         https://bugs.webkit.org/show_bug.cgi?id=174816
1459
1460         Reviewed by Michael Catanzaro.
1461
1462         Add tests for webkit_uri_for_display().
1463
1464         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1465         (testURIForDisplayUnaffected):
1466         (testURIForDisplayAffected):
1467         (beforeAll):
1468         (afterAll):
1469         * TestWebKitAPI/glib/CMakeLists.txt:
1470
1471 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1472
1473         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1474         https://bugs.webkit.org/show_bug.cgi?id=194158
1475         <rdar://problem/47737268>
1476
1477         Rubber-stamped by Aakash Jain.
1478
1479         * Scripts/webkitpy/port/device_port.py:
1480         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1481
1482 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1483
1484         [CG] Enable setAdditionalSupportedImageTypes for WK1
1485         https://bugs.webkit.org/show_bug.cgi?id=194190
1486
1487         Reviewed by Tim Horton.
1488
1489         Add a test similar to the one under WebKit Cocoa but make it create a
1490         WebView instead of a WKWebView.
1491
1492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1493         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1494         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1495         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1496         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1497         (TestWebKitAPI::runTest):
1498         (TestWebKitAPI::TEST):
1499
1500 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1501
1502         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1503         https://bugs.webkit.org/show_bug.cgi?id=194168
1504
1505         Reviewed by Simon Fraser.
1506
1507         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1508
1509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1510         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1511         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1512         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1513         (TEST):
1514         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1515         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1516
1517 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1518
1519         REGRESSION (r237269): webkit-patch what-broke is broken 
1520         https://bugs.webkit.org/show_bug.cgi?id=193025
1521
1522         Reviewed by Aakash Jain.
1523
1524         * Scripts/webkitpy/common/host.py:
1525         (Host.buildbot):
1526         (Host.bugzilla): Renamed to 'buildbot'.
1527
1528 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1529
1530         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1531         https://bugs.webkit.org/show_bug.cgi?id=194207
1532
1533         Reviewed by Tim Horton.
1534
1535         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1536         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1537         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1538         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1539         start and delete forwards to remove the original attachment.
1540
1541         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1542         (TestWebKitAPI::TEST):
1543
1544 2019-02-04  Youenn Fablet  <youenn@apple.com>
1545
1546         Capture state should be managed consistently when doing process swapping
1547         https://bugs.webkit.org/show_bug.cgi?id=194122
1548         <rdar://problem/47609293>
1549
1550         Reviewed by Eric Carlson.
1551
1552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1553         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1554         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1555         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1556         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1557         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1558         (WTR::TestRunner::isDoingMediaCapture const):
1559         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1560         * WebKitTestRunner/TestController.cpp:
1561         (WTR::TestController::isDoingMediaCapture const):
1562         * WebKitTestRunner/TestController.h:
1563         * WebKitTestRunner/TestInvocation.cpp:
1564         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1565         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1566         (WTR::TestController::isDoingMediaCapture const):
1567
1568 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1569
1570         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1571         https://bugs.webkit.org/show_bug.cgi?id=194142
1572
1573         Reviewed by Ross Kirsling.
1574
1575         There three 'separator' variables in TestController.cpp. Renamed
1576         it 'pathSeparator', and unified them.
1577
1578         * WebKitTestRunner/TestController.cpp:
1579         (WTR::TestController::generateContextConfiguration const):
1580         (WTR::createTestURL):
1581         (WTR::TestController::platformAdjustContext):
1582
1583 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1584
1585         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1586         https://bugs.webkit.org/show_bug.cgi?id=194198
1587
1588         Reviewed by Antti Koivisto.
1589
1590         No need to set the banner heights on navigation now, since Page stores them.
1591
1592         * MiniBrowser/mac/WK2BrowserWindowController.m:
1593         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1594
1595 2019-02-03  John Wilander  <wilander@apple.com>
1596
1597         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1598         https://bugs.webkit.org/show_bug.cgi?id=194104
1599         <rdar://problem/47649991>
1600
1601         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1602
1603         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1604         (TestWebKitAPI::TEST):
1605             Changed numeric types from unsigned short to uint32_t.
1606
1607 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1608
1609         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1610         <https://webkit.org/b/194178>
1611         <rdar://problem/47753473>
1612
1613         Reviewed by Alexey Proskuryakov.
1614
1615         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1616         (WTR::uninstallFakeHelvetica): Pass nullptr into
1617         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1618
1619 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1620
1621         [LFC] Initialize ICB's style with fixed width/height.
1622         https://bugs.webkit.org/show_bug.cgi?id=194188
1623
1624         Reviewed by Antti Koivisto.
1625
1626         * LayoutReloaded/misc/LFC-passing-tests.txt:
1627
1628 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1629
1630         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1631         https://bugs.webkit.org/show_bug.cgi?id=194185
1632
1633         Reviewed by Antti Koivisto.
1634
1635         * LayoutReloaded/misc/LFC-passing-tests.txt:
1636
1637 2018-12-16  Darin Adler  <darin@apple.com>
1638
1639         Convert additional String::format clients to alternative approaches
1640         https://bugs.webkit.org/show_bug.cgi?id=192746
1641
1642         Reviewed by Alexey Proskuryakov.
1643
1644         * WebKitTestRunner/TestController.cpp:
1645         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1646         as an intermediate in code that ultimately constructs a WTF::String.
1647         (WTR::userMediaOriginHash): Use makeString.
1648         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1649         (WTR::TestController::didPerformClientRedirect): Ditto.
1650         (WTR::TestController::didPerformServerRedirect): Ditto.
1651         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1652
1653 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1654
1655         [ews-build] Add unit test to verify builder keys
1656         https://bugs.webkit.org/show_bug.cgi?id=194152
1657
1658         Reviewed by Lucas Forschler.
1659
1660         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1661         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1662
1663 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1664
1665         [LFC] Expand tests coverage (12 new tests -> 787)
1666
1667         Unreviewed test gardening.
1668
1669         * LayoutReloaded/misc/LFC-passing-tests.txt:
1670
1671 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1672
1673         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1674         https://bugs.webkit.org/show_bug.cgi?id=194163
1675
1676         Reviewed by Simon Fraser.
1677
1678         775
1679
1680         * LayoutReloaded/misc/LFC-passing-tests.txt:
1681
1682 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1683
1684         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1685         https://bugs.webkit.org/show_bug.cgi?id=194140
1686         <rdar://problem/47728098>
1687
1688         Reviewed by Tim Horton.
1689
1690         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1691         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1692         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1693
1694         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1695         test to induce an IPC deadlock when presenting a modal alert during touch start.
1696
1697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1698         * WebKitTestRunner/TestController.cpp:
1699         (WTR::runJavaScriptAlert):
1700
1701         Add a client callback function for running JavaScript alerts.
1702
1703         (WTR::TestController::createOtherPage):
1704         (WTR::TestController::generateContextConfiguration const):
1705
1706         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1707         the fix in this patch.
1708
1709         (WTR::TestController::createWebViewWithOptions):
1710
1711         Plumb TestOptions to generateContextConfiguration.
1712
1713         (WTR::TestController::resetPreferencesToConsistentValues):
1714         (WTR::TestController::resetStateToConsistentValues):
1715         (WTR::updateTestOptionsFromTestHeader):
1716         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1717         (WTR::TestController::handleJavaScriptAlert):
1718         * WebKitTestRunner/TestController.h:
1719         * WebKitTestRunner/TestInvocation.cpp:
1720         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1721         * WebKitTestRunner/TestOptions.h:
1722         (WTR::TestOptions::hasSameInitializationOptions const):
1723
1724 2019-02-01  Chris Dumez  <cdumez@apple.com>
1725
1726         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1727         https://bugs.webkit.org/show_bug.cgi?id=193740
1728         <rdar://problem/47527267>
1729
1730         Reviewed by Alex Christensen.
1731
1732         Add API test coverage.
1733
1734         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1735
1736 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-app] Add display name field to BuilderMapping model
1739         https://bugs.webkit.org/show_bug.cgi?id=194153
1740
1741         Reviewed by Lucas Forschler.
1742
1743         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1744         (BuilderMapping):
1745
1746 2019-02-01  Youenn Fablet  <youenn@apple.com>
1747
1748         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1749         https://bugs.webkit.org/show_bug.cgi?id=194155
1750
1751         Reviewed by Eric Carlson.
1752
1753         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1754         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1755         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1756
1757 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1758
1759         [LFC] Adjust replaced element's intrinsic ratio
1760         https://bugs.webkit.org/show_bug.cgi?id=194154
1761
1762         Reviewed by Antti Koivisto.
1763
1764         761
1765
1766         * LayoutReloaded/misc/LFC-passing-tests.txt:
1767
1768 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         [WPE] Show test results in minibrowser
1771         https://bugs.webkit.org/show_bug.cgi?id=194150
1772
1773         Reviewed by Žan Doberšek.
1774
1775         * Scripts/webkitpy/port/wpe.py:
1776         (WPEPort.show_results_html_file):
1777
1778 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1779
1780         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1781         https://bugs.webkit.org/show_bug.cgi?id=194151
1782
1783         Reviewed by Žan Doberšek.
1784
1785         ALT + <- go back
1786         ALT + -> go forward
1787
1788         * MiniBrowser/wpe/main.cpp:
1789         (main):
1790
1791 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1792
1793         [LFC] Set intrinsic size on Layout::Replaced
1794         https://bugs.webkit.org/show_bug.cgi?id=194139
1795
1796         Reviewed by Antti Koivisto.
1797
1798         744
1799
1800         * LayoutReloaded/misc/LFC-passing-tests.txt:
1801
1802 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1805         https://bugs.webkit.org/show_bug.cgi?id=194146
1806
1807         Reviewed by Xabier Rodriguez-Calvar.
1808
1809         It allows to open relative paths.
1810
1811         * MiniBrowser/wpe/main.cpp:
1812         (main):
1813
1814 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1815
1816         Update flakiness dashboard configuration after recent queue changes
1817         https://bugs.webkit.org/show_bug.cgi?id=194127
1818
1819         Rubber-stamped by Aakash Jain.
1820
1821         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1822
1823         * TestResultServer/static-dashboards/builders.jsonp:
1824
1825 2019-01-31  Youenn Fablet  <youenn@apple.com>
1826
1827         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1828         https://bugs.webkit.org/show_bug.cgi?id=194106
1829         <rdar://problem/47676333>
1830
1831         Reviewed by Ryosuke Niwa.
1832
1833         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1834         (TestWebKitAPI::didFinishNavigation):
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1837
1838 2019-01-31  Chris Dumez  <cdumez@apple.com>
1839
1840         Page zoom level is lost after a process swap or a crash
1841         https://bugs.webkit.org/show_bug.cgi?id=194105
1842         <rdar://problem/47610781>
1843
1844         Reviewed by Alex Christensen.
1845
1846         Add API test coverage.
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1849         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1850
1851 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1852
1853         Revert r238819 which is unneeded and caused a performance regression.
1854         https://bugs.webkit.org/show_bug.cgi?id=192272
1855         <rdar://problem/46664625>
1856
1857         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1858         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1859         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1860
1861 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1862
1863         Formalize WebKitAdditions mechanism of LoadOptimizer
1864         https://bugs.webkit.org/show_bug.cgi?id=193886
1865         <rdar://problem/47696809>
1866
1867         Reviewed by Brent Fulgham.
1868
1869         * MiniBrowser/MiniBrowser.entitlements:
1870         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1871
1872 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1873
1874         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1875         https://bugs.webkit.org/show_bug.cgi?id=194090
1876
1877         Reviewed by Antti Koivisto.
1878
1879         * LayoutReloaded/misc/LFC-passing-tests.txt:
1880
1881 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1882
1883         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1884         https://bugs.webkit.org/show_bug.cgi?id=194074
1885
1886         Reviewed by Antti Koivisto.
1887
1888         * LayoutReloaded/misc/LFC-passing-tests.txt:
1889
1890 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1891
1892         [LFC][BFC] Add support for block level replaced box.
1893         https://bugs.webkit.org/show_bug.cgi?id=194071
1894
1895         Reviewed by Antti Koivisto.
1896
1897         * LayoutReloaded/misc/LFC-passing-tests.txt:
1898
1899 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1900
1901         Fix WebKitTestRunner's testPath with Windows full paths
1902         https://bugs.webkit.org/show_bug.cgi?id=194012
1903
1904         Reviewed by Alex Christensen.
1905
1906         updateTestOptionsFromTestHeader failed to open test files because
1907         testPath returned wrong file paths. It returned a path "/C:/..."
1908         if a URL "file:///C:/..." was given.
1909
1910         * WebKitTestRunner/TestController.cpp:
1911         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1912
1913 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1914
1915         [WPE] Bump font related dependencies to match the GTK+ port
1916         https://bugs.webkit.org/show_bug.cgi?id=194017
1917
1918         Reviewed by Žan Doberšek.
1919
1920         * wpe/jhbuild.modules:
1921         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1922         * wpe/patches/icudata-stdlibs.patch: Added.
1923
1924 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1925
1926         Enable swipe tests on iOS
1927         https://bugs.webkit.org/show_bug.cgi?id=194076
1928
1929         Reviewed by Geoffrey Garen.
1930
1931         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1932         it causes a debug assertion failure in runUIScript.
1933
1934         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1935         (WTR::UIScriptController::beginBackSwipe):
1936         (WTR::UIScriptController::completeBackSwipe):
1937
1938 2019-01-30  Keith Rollin  <krollin@apple.com>
1939
1940         Use correct printf format specifier
1941         https://bugs.webkit.org/show_bug.cgi?id=194062
1942         <rdar://problem/47686167>
1943
1944         Reviewed by Alexey Proskuryakov.
1945
1946         LayoutTestSpellChecker.mm is trying to format a variable of type
1947         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1948         actually an unsigned long long. Fix this by formatting with %llu.
1949
1950         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1951         (-[LayoutTestTextCheckingResult description]):
1952
1953 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1954
1955         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1956         https://bugs.webkit.org/show_bug.cgi?id=193979
1957
1958         Reviewed by Wenson Hsieh.
1959
1960         Fix the test for iOS. Make the test work with iOS UA string.
1961
1962         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1963
1964 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1965
1966         Replace High Sierra LLINT CLoop bot due to hardware failure
1967         https://bugs.webkit.org/show_bug.cgi?id=194066
1968
1969         Reviewed by Aakash Jain.
1970
1971         * BuildSlaveSupport/build.webkit.org-config/config.json:
1972
1973 2019-01-30  Keith Rollin  <krollin@apple.com>
1974
1975         [NSDragItem init] is unavailable
1976         https://bugs.webkit.org/show_bug.cgi?id=194059
1977         <rdar://problem/47685715>
1978
1979         Reviewed by Wenson Hsieh.
1980
1981         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1982         DumpRenderTree and TestWebKitAPI, which both try to create an
1983         NSDragItem in a manner that invokes this method. Address this by using
1984         -initWithPasteboardWriter instead.
1985
1986         Note that the parameter passed to initWithPasteboardWriter is likely
1987         incorrect. In both cases, the object passed does not conform to
1988         NSPasteboardWriting. However, with this fix, we're no worse off than
1989         before, and can now perform builds with newer compilers and SDKs until
1990         a real fix can be crafted. That work is tracked in
1991         https://bugs.webkit.org/show_bug.cgi?id=194060
1992
1993         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1994         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1995         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1996         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1997
1998 2019-01-30  Daniel Bates  <dabates@apple.com>
1999
2000         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2001         https://bugs.webkit.org/show_bug.cgi?id=192824
2002         <rdar://problem/47100332>
2003
2004         Reviewed by Wenson Hsieh.
2005
2006         Fix a bug where the wrong usage code was used for F13 thru F24.
2007
2008         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2009         (keyCodeForDOMFunctionKey):
2010
2011 2019-01-30  Chris Dumez  <cdumez@apple.com>
2012
2013         Regression(PSON) Load hang can occur on history navigation
2014         https://bugs.webkit.org/show_bug.cgi?id=194030
2015         <rdar://problem/47656939>
2016
2017         Reviewed by Antti Koivisto.
2018
2019         Add API test coverage.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2022
2023 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2024
2025         [LFC] Expand tests coverage.
2026
2027         Unreviewed test gardening.
2028
2029         * LayoutReloaded/misc/LFC-passing-tests.txt:
2030
2031 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2032
2033         [Flatpak] Add openjpeg support
2034         https://bugs.webkit.org/show_bug.cgi?id=194019
2035
2036         Reviewed by Michael Catanzaro.
2037
2038         * flatpak/org.webkit.CommonModules.yaml:
2039
2040 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2041
2042         Unreviewed, rolling out r240708.
2043         https://bugs.webkit.org/show_bug.cgi?id=194022
2044
2045         It broke WPE build (Requested by KaL on #webkit).
2046
2047         Reverted changeset:
2048
2049         "[WPE] Bump font related dependencies to match the GTK+ port"
2050         https://bugs.webkit.org/show_bug.cgi?id=194017
2051         https://trac.webkit.org/changeset/240708
2052
2053 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2054
2055         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2056         https://bugs.webkit.org/show_bug.cgi?id=194001
2057
2058         Reviewed by Antti Koivisto.
2059
2060         * LayoutReloaded/misc/LFC-passing-tests.txt:
2061
2062 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2063
2064         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2065         https://bugs.webkit.org/show_bug.cgi?id=194020
2066
2067         Reviewed by Antti Koivisto.
2068
2069         * LayoutReloaded/misc/LFC-passing-tests.txt:
2070
2071 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2072
2073         AX: Support color well on iOS
2074         https://bugs.webkit.org/show_bug.cgi?id=194010
2075
2076         Reviewed by Joanmarie Diggs.
2077
2078         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2079         (WTR::AccessibilityUIElement::stringAttributeValue):
2080
2081 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2082
2083         [WPE] Bump font related dependencies to match the GTK+ port
2084         https://bugs.webkit.org/show_bug.cgi?id=194017
2085
2086         Reviewed by Žan Doberšek.
2087
2088         * wpe/jhbuild.modules:
2089         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2090         * wpe/patches/icudata-stdlibs.patch: Added.
2091
2092 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2093
2094         [Mac] Update window scale API usage
2095         https://bugs.webkit.org/show_bug.cgi?id=193991
2096         rdar://problem/47614795
2097
2098         Reviewed by Tim Horton.
2099
2100         * DumpRenderTree/mac/DumpRenderTree.mm:
2101         (changeWindowScaleIfNeeded):
2102         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2103         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2104         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2105
2106 2019-01-29  Chris Dumez  <cdumez@apple.com>
2107
2108         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2109         https://bugs.webkit.org/show_bug.cgi?id=193977
2110         <rdar://problem/47643716>
2111
2112         Reviewed by Geoff Garen.
2113
2114         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2115         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2116         to the previous provisional committing *before* we make the last load. 
2117
2118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2119
2120 2019-01-29  Youenn Fablet  <youenn@apple.com>
2121
2122         Adopt new SPI to evaluate server certificate trust
2123         https://bugs.webkit.org/show_bug.cgi?id=193355
2124
2125         Reviewed by Alex Christensen.
2126
2127         Add infrastructure to handle HTTPS server trust evaluation testing.
2128
2129         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2131         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2132         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2133         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2134         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2135         * WebKitTestRunner/TestController.cpp:
2136         (WTR::TestController::resetPreferencesToConsistentValues):
2137         (WTR::TestController::didReceiveAuthenticationChallenge):
2138         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2139         * WebKitTestRunner/TestController.h:
2140         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2141         * WebKitTestRunner/TestInvocation.cpp:
2142         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2143         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2144         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2145
2146 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2147
2148         [ews-build] Add build step to print bot Configuration
2149         https://bugs.webkit.org/show_bug.cgi?id=193887
2150
2151         Reviewed by Lucas Forschler.
2152
2153         * BuildSlaveSupport/ews-build/steps.py:
2154         (PrintConfiguration): Build step to print configuration.
2155         * BuildSlaveSupport/ews-build/factories.py:
2156
2157 2019-01-29  Chris Dumez  <cdumez@apple.com>
2158
2159         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2160         https://bugs.webkit.org/show_bug.cgi?id=193967
2161         <rdar://problem/47635348>
2162
2163         Reviewed by Alex Christensen.
2164
2165         Add API test coverage.
2166
2167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2168         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2169
2170 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2171
2172         [ews-app] Handle incoming results data
2173         https://bugs.webkit.org/show_bug.cgi?id=193973
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/ews-app/ews/views/results.py:
2178
2179 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2180
2181         [ews-app] Make the results url generic
2182         https://bugs.webkit.org/show_bug.cgi?id=193928
2183
2184         Reviewed by Lucas Forschler.
2185
2186         * BuildSlaveSupport/ews-app/ews/urls.py:
2187
2188 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2189
2190         [ews-build] Configure buildbot to send events to ews-app
2191         https://bugs.webkit.org/show_bug.cgi?id=193968
2192
2193         Reviewed by Lucas Forschler.
2194
2195         * BuildSlaveSupport/ews-build/events.py: Added.
2196         * BuildSlaveSupport/ews-build/master.cfg:
2197
2198 2019-01-29  Keith Rollin  <krollin@apple.com>
2199
2200         Add .xcfilelists to Run Script build phases
2201         https://bugs.webkit.org/show_bug.cgi?id=193792
2202         <rdar://problem/47201785>
2203
2204         Reviewed by Alex Christensen.
2205
2206         As part of supporting XCBuild, update the necessary Run Script build
2207         phases in their Xcode projects to refer to their associated
2208         .xcfilelist files.
2209
2210         Note that the addition of these files bumps the Xcode project version
2211         number to something that's Xcode 10 compatible. This change means that
2212         older versions of the Xcode IDE can't read these projects. Nor can it
2213         fully load workspaces that refer to these projects (the updated
2214         projects are shown as non-expandable placeholders). `xcodebuild` can
2215         still build these projects; it's just that the IDE can't open them.
2216
2217         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2218         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2219
2220 2019-01-29  John Wilander  <wilander@apple.com>
2221
2222         Add data abstraction and validation for Ad Click Attribution
2223         https://bugs.webkit.org/show_bug.cgi?id=193916
2224         <rdar://problem/47603481>
2225
2226         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2227
2228         Ad click attribution has two steps. First, the storage of an ad
2229         campaign ID for a click that takes the user to a destination
2230         site. Second, a conversion on the destination site that can be
2231         attributed to the ad click.
2232
2233         This patch adds a class that represents a request for ad click
2234         attribution. Validation makes sure that the bits of entropy
2235         reported through this mechanism is limited.
2236
2237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2238         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2239         (TestWebKitAPI::TEST):
2240
2241 2019-01-29  Chris Dumez  <cdumez@apple.com>
2242
2243         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2244         https://bugs.webkit.org/show_bug.cgi?id=193932
2245         <rdar://problem/47598947>
2246
2247         Reviewed by Brady Eidson.
2248
2249         Add API test coverage.
2250
2251         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2252
2253 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2254
2255         Adding new passing LFC tests.
2256
2257         Unreviewed test gardening.
2258
2259         * LayoutReloaded/misc/LFC-passing-tests.txt:
2260
2261 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2262
2263         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2264         https://bugs.webkit.org/show_bug.cgi?id=193964
2265
2266         Reviewed by Antti Koivisto.
2267
2268         * LayoutReloaded/misc/LFC-passing-tests.txt:
2269
2270 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2271
2272         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2273         https://bugs.webkit.org/show_bug.cgi?id=193954
2274
2275         Reviewed by Antti Koivisto.
2276
2277         * LayoutReloaded/misc/LFC-passing-tests.txt:
2278
2279 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2280
2281         WebDriver: add support for running subtests
2282         https://bugs.webkit.org/show_bug.cgi?id=193904
2283
2284         Reviewed by Michael Catanzaro.
2285
2286         pytest already supports it by passing test.py::subtest, so we can do the same.
2287
2288         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2289         (get_item_name): Made this global.
2290         (CollectRecorder.__init__): Receive the parameter to ignore.
2291         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2292         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2293         (collect): Add parameter to ignore.
2294         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2295         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2296         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2297         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2298         (WebDriverTestRunnerSelenium.run): Ditto.
2299         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2300         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2301         (WebDriverTestRunnerW3C.run): Ditto.
2302
2303 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2304
2305         User agent string override for navigator.userAgent should be site specific quirks
2306         https://bugs.webkit.org/show_bug.cgi?id=193950
2307
2308         Reviewed by Brent Fulgham.
2309
2310         Updated per the _WKWebsitePolicies rename.
2311
2312         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2313         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2314
2315 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2316
2317         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2318         https://bugs.webkit.org/show_bug.cgi?id=193941
2319
2320         Reviewed by Alex Christensen.
2321
2322         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2323         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2324         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2325         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2326         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2327         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2328         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2329         * TestWebKitAPI/Tests/WTF/Time.cpp:
2330         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2331         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2332         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2333         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2334
2335 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2336
2337         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2338
2339         * Scripts/webkitpy/common/config/contributors.json:
2340
2341 2019-01-28  Andy Estes  <aestes@apple.com>
2342
2343         [watchOS] Enable Parental Controls content filtering
2344         https://bugs.webkit.org/show_bug.cgi?id=193939
2345         <rdar://problem/46641912>
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2350
2351 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2352
2353         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2354         <https://webkit.org/b/193884>
2355
2356         Reviewed by Jiewen Tan.
2357
2358         * Scripts/webkitpy/style/checkers/cpp.py:
2359         (check_language): Add LocalAuthentication to
2360         `frameworks_with_soft_links`.
2361
2362 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2363
2364         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2365         https://bugs.webkit.org/show_bug.cgi?id=193891
2366
2367         Reviewed by Ross Kirsling.
2368
2369         There were three problems in window sizes of WebView and the host window.
2370         1. The sizes of pixel image output were incorrect.
2371         2. The host window is going to appear after window.resize was invoked.
2372         3. window.resize resized only the host window, not WebView.
2373
2374         This change solves them with a following approach.
2375         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2376         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2377            as well as DumpRenderTree in order to match the client area and the window area.
2378         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2379         d. PlatformWebView::setWindowFrame changes both window sizes.
2380         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2381
2382         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2383         (WTR::PlatformWebView::PlatformWebView): Create the host window
2384         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2385         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2386         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2387
2388 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2389
2390         [ews-app] Add method to save Step data to database
2391         https://bugs.webkit.org/show_bug.cgi?id=193890
2392
2393         Reviewed by Lucas Forschler.
2394
2395         * BuildSlaveSupport/ews-app/ews/models/step.py:
2396         (Step.save_step): Method to save step data.
2397         (Step.update_step): Method to update step data.
2398         (Step.get_existing_step): Method to fetch existing step from database.
2399         (Step.is_valid_result): Method to validate valid step result.
2400
2401 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2402
2403         [ews-app] Add method to save Build data to database
2404         https://bugs.webkit.org/show_bug.cgi?id=193735
2405
2406         Reviewed by Lucas Forschler.
2407
2408         * BuildSlaveSupport/ews-app/ews/models/build.py:
2409         (Build.save_build): Method to save build information to database.
2410         (Build.get_existing_build): Method to fetch existing build from database.
2411         (Build.is_valid_result): Method to validate build result.
2412         * BuildSlaveSupport/ews-app/ews/common/util.py:
2413         (is_valid_int_id): Method to validate valid id.
2414
2415 2019-01-28  Chris Dumez  <cdumez@apple.com>
2416
2417         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2418         https://bugs.webkit.org/show_bug.cgi?id=193915
2419         <rdar://problem/47560907>
2420
2421         Reviewed by Alex Christensen.
2422
2423         Add API test coverage.
2424
2425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2426
2427 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2428
2429         [ews-app] Rename id variables
2430         https://bugs.webkit.org/show_bug.cgi?id=193883
2431
2432         Reviewed by Lucas Forschler.
2433
2434         * BuildSlaveSupport/ews-app/ews/models/build.py:
2435         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2436         * BuildSlaveSupport/ews-app/ews/models/step.py:
2437         * BuildSlaveSupport/ews-app/ews/urls.py:
2438         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2439         * BuildSlaveSupport/ews-app/ews/views/results.py:
2440         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2441
2442 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2443
2444         [ews-app] Allow certain fields to be empty
2445         https://bugs.webkit.org/show_bug.cgi?id=193892
2446
2447         Reviewed by Lucas Forschler.
2448
2449         * BuildSlaveSupport/ews-app/ews/models/build.py:
2450         * BuildSlaveSupport/ews-app/ews/models/step.py:
2451
2452 2019-01-28  Rob Buis  <rbuis@igalia.com>
2453
2454         Update MIME type parser
2455         https://bugs.webkit.org/show_bug.cgi?id=180526
2456
2457         Reviewed by Frédéric Wang.
2458
2459         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2460         (TestWebKitAPI::TEST):
2461
2462 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2463
2464         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2465         https://bugs.webkit.org/show_bug.cgi?id=193896
2466
2467         Reviewed by Antti Koivisto.
2468
2469         * LayoutReloaded/misc/LFC-passing-tests.txt:
2470
2471 2018-12-15  Darin Adler  <darin@apple.com>
2472
2473         Replace many uses of String::format with more type-safe alternatives
2474         https://bugs.webkit.org/show_bug.cgi?id=192742
2475
2476         Reviewed by Mark Lam.
2477
2478         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2479         (WTR::cacheTestRunnerCallback): Use makeString.
2480         * WebKitTestRunner/TestController.cpp:
2481         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2482         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2483
2484 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2485
2486         Use a load optimizer for some sites
2487         https://bugs.webkit.org/show_bug.cgi?id=193881
2488         <rdar://problem/46325455>
2489
2490         Reviewed by Brent Fulgham.
2491
2492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2493         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2494
2495 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2496
2497         AX: Introduce a static accessibility tree
2498         https://bugs.webkit.org/show_bug.cgi?id=193348
2499         <rdar://problem/47203295>
2500
2501         Reviewed by Ryosuke Niwa.
2502
2503         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2504
2505 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2506
2507         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2508         https://bugs.webkit.org/show_bug.cgi?id=193867
2509
2510         Reviewed by Antti Koivisto.
2511
2512         * LayoutReloaded/misc/LFC-passing-tests.txt:
2513
2514 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2515
2516         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2517         https://bugs.webkit.org/show_bug.cgi?id=193865
2518
2519         Reviewed by Antti Koivisto.
2520
2521         * LayoutReloaded/misc/LFC-passing-tests.txt:
2522
2523 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2524
2525         Need a mechanism to override navigator.userAgent
2526         https://bugs.webkit.org/show_bug.cgi?id=193762
2527         <rdar://problem/47504939>
2528
2529         Reviewed by Brent Fulgham.
2530
2531         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2532
2533         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2534         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2535         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2536
2537 2019-01-25  Dean Jackson  <dino@apple.com>
2538
2539         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2540         https://bugs.webkit.org/show_bug.cgi?id=193831
2541         <rdar://problem/47399263>
2542
2543         Reviewed by Chris Dumez.
2544
2545         Two new tests that exercise cross-origin and same-origin System
2546         Previews.
2547
2548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2549
2550 2019-01-25  Keith Rollin  <krollin@apple.com>
2551
2552         Update Xcode projects with "Check .xcfilelists" build phase
2553         https://bugs.webkit.org/show_bug.cgi?id=193790
2554         <rdar://problem/47201374>
2555
2556         Reviewed by Alex Christensen.
2557
2558         Support for XCBuild includes specifying inputs and outputs to various
2559         Run Script build phases. These inputs and outputs are specified as
2560         .xcfilelist files. Once created, these .xcfilelist files need to be
2561         kept up-to-date. In order to check that they are up-to-date or not,
2562         add an Xcode build step that invokes an external script that performs
2563         the checking. If the .xcfilelists are found to be out-of-date, update
2564         them, halt the build, and instruct the developer to restart the build
2565         with up-to-date files.
2566
2567         At this time, the checking and regenerating is performed only if the
2568         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2569         who want to use this facility can set this variable and test out the
2570         checking/regenerating. Once it seems like there are no egregious
2571         issues that upset a developer's workflow, we'll unconditionally enable
2572         this facility.
2573
2574         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2575         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2576         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2577         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2578
2579 2019-01-25  Keith Rollin  <krollin@apple.com>
2580
2581         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2582         https://bugs.webkit.org/show_bug.cgi?id=193781
2583         <rdar://problem/47201153>
2584
2585         Reviewed by Alex Christensen.
2586
2587         Part of generating the .xcfilelists used as part of adopting XCBuild
2588         includes running `make DerivedSources.make` from a standalone script.
2589         It’s important for this invocation to have the same environment as
2590         when the actual build invokes `make DerivedSources.make`. If the
2591         environments are different, then the two invocations will provide
2592         different results. In order to get the same environment in the
2593         standalone script, have the script launch xcodebuild targeting the
2594         "Apply Configuration to XCFileLists" build target, which will then
2595         re-invoke our standalone script. The script is now running again, this
2596         time in an environment with all workspace, project, target, xcconfig
2597         and other environment variables established.
2598
2599         The "Apply Configuration to XCFileLists" build target accomplishes
2600         this task via a small embedded shell script that consists only of:
2601
2602             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2603
2604         The process that invokes "Apply Configuration to XCFileLists" first
2605         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2606         evaluated and exports it into the shell environment. When xcodebuild
2607         is invoked, it inherits the value of this variable and can `eval` the
2608         contents of that variable. Our external standalone script can then set
2609         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2610         of command-line parameters needed to restart itself in the appropriate
2611         state.
2612
2613         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2614         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2615
2616 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2617
2618         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2619         https://bugs.webkit.org/show_bug.cgi?id=193802
2620         <rdar://problem/46010580>
2621
2622         Reviewed by Andy Estes.
2623
2624         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2625         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2626         (TEST):
2627
2628 2019-01-25  Daniel Bates  <dabates@apple.com>
2629
2630         [iOS] uiController.keyDown() does not translate Control modified key
2631         https://bugs.webkit.org/show_bug.cgi?id=192898
2632
2633         Reviewed by Wenson Hsieh.
2634
2635         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2636         key translation, as applicable. Among other cases, key translation occurs when performing
2637         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2638         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2639         human pressing down and releasing key(s) using a hardware keyboard.
2640
2641         * WebKitTestRunner/ios/HIDEventGenerator.h:
2642         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2643         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2644
2645         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2646         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2647         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2648         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2649         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2650         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2651         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2652         (-[HIDEventGenerator longPress:completionBlock:]):
2653         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2654         Update code for above renaming.
2655
2656         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2657         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2658
2659         (-[HIDEventGenerator keyDown:]): Added.
2660         (-[HIDEventGenerator keyUp:]): Added.
2661         (-[HIDEventGenerator keyPress:completionBlock:]):
2662         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2663         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2664         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2665         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2666         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2667         (WTR::parseModifier): Deleted.
2668
2669 2019-01-25  Keith Rollin  <krollin@apple.com>
2670
2671         Complete the implementation of generate-xcfilelists
2672         https://bugs.webkit.org/show_bug.cgi?id=193782
2673
2674         Reviewed by Alex Christensen.
2675
2676         A preliminary version of generate-xcfilelists was added in r238008.
2677         This patch updates that script in order to:
2678
2679         - Support checking of .xcfilelists
2680         - Perform better execution of `make DerivedSources.make` by
2681           relaunching generate-xcfilelists under xcodebuild
2682         - Support incremental generation and checking of .xcfilelists
2683         - Support supplementary .xcfilelists files from WebKitAdditions
2684         - Support being wrapped by parallel version of generate-xcfilelists in
2685           Internal that adds support for (re)generating WebKit projects in
2686           that repo.
2687         - Support builds that have been performed in WebKitBuild as well as
2688           ~/Library/Developer/code/DerivedData
2689         - Increase robustness and debugging facilities.
2690
2691         * Scripts/generate-xcfilelists:
2692
2693 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2694
2695         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2696         https://bugs.webkit.org/show_bug.cgi?id=193297
2697         <rdar://problem/47158841>
2698
2699         Unreviewed test case fix.
2700
2701         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2702         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2705         (TEST):
2706
2707 2019-01-25  Keith Rollin  <krollin@apple.com>
2708
2709         Update existing .xcfilelists
2710         https://bugs.webkit.org/show_bug.cgi?id=193791
2711         <rdar://problem/47201706>
2712
2713         Reviewed by Alex Christensen.
2714
2715         Many .xcfilelist files were added in r238824 in order to support
2716         XCBuild. Update these with recent changes to the set of build files
2717         and with the current generate-xcfilelist script.
2718
2719         * DumpRenderTree/DerivedSources-input.xcfilelist:
2720         * DumpRenderTree/DerivedSources-output.xcfilelist:
2721         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2722         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2723
2724 2019-01-25  Keith Rollin  <krollin@apple.com>
2725
2726         Fix missing dependencies in extract-dependencies-from-makefile
2727         https://bugs.webkit.org/show_bug.cgi?id=193783
2728         <rdar://problem/47201571>
2729
2730         Reviewed by Alex Christensen.
2731
2732         The extract-dependencies-from-makefile script generates .xcfilelists
2733         for XCBuild by invoking a makefile in --debug mode, parsing the
2734         dependency information in the output, and extracting information
2735         regarding targets and dependents. However, the way `make` emits this
2736         dependency information is not rigorous, and so we need to determine
2737         what lines to look for and parse by trial and error. This approach
2738         didn't coriginally atch all the information we needed to collect, so
2739         update the script to look for the additional lines we now know to look
2740         for.
2741
2742         * Scripts/extract-dependencies-from-makefile:
2743         (Parser):
2744         (Parser.addTarget):
2745         (Parser.addPrereq):
2746         (Parser.doParse):
2747
2748 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2749
2750         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2751         https://bugs.webkit.org/show_bug.cgi?id=193297
2752         <rdar://problem/47158841>
2753
2754         Reviewed by Alex Christensen.
2755
2756         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2757             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2758         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2759         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2760         activating the message used to trigger the callback when it is set.
2761
2762 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2763
2764         WKWebView.goBack should reload if there is a safe browsing warning
2765         https://bugs.webkit.org/show_bug.cgi?id=193805
2766         <rdar://problem/46908216>
2767
2768         Reviewed by Geoff Garen.
2769
2770         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2771         (+[Simple3LookupContext sharedLookupContext]):
2772         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2773         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2774         (TEST):
2775
2776 2019-01-25  Chris Dumez  <cdumez@apple.com>
2777
2778         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2779         https://bugs.webkit.org/show_bug.cgi?id=193788
2780         <rdar://problem/47531231>
2781
2782         Reviewed by Alex Christensen.
2783
2784         Add API test coverage.
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2787         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2788
2789 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2790
2791         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2792         https://bugs.webkit.org/show_bug.cgi?id=193771
2793
2794         Unreviewed infrastructure fix.
2795
2796         * Scripts/webkitpy/port/darwin.py:
2797         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2798
2799 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2800
2801         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2802
2803 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2804
2805         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2806
2807         * Scripts/webkitpy/common/config/contributors.json:
2808
2809 2019-01-25  Chris Dumez  <cdumez@apple.com>
2810
2811         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2812         https://bugs.webkit.org/show_bug.cgi?id=193779
2813         <rdar://problem/46170903>
2814
2815         Reviewed by Antti Koivisto.
2816
2817         Add API test that quickly navigates forward to a previous process without waiting for it to
2818         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2819         the process' previous page when reconnecting the it for the forward navigation.
2820
2821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2822
2823 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2824
2825         Need a way for JavaScript (or bundle) code to participate in undo
2826         https://bugs.webkit.org/show_bug.cgi?id=190009
2827         <rdar://problem/44807048>
2828
2829         Reviewed by Ryosuke Niwa.
2830
2831         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2832         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2833
2834         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2835         (WTR::UIScriptController::lastUndoLabel const):
2836         (WTR::UIScriptController::firstRedoLabel const):
2837         (WTR::UIScriptController::platformUndoManager const):
2838         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2839         (WTR::UIScriptController::lastUndoLabel const):
2840         (WTR::UIScriptController::firstRedoLabel const):
2841         (WTR::UIScriptController::platformUndoManager const):
2842         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2843         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2844         (WTR::UIScriptController::lastUndoLabel const):
2845         (WTR::UIScriptController::firstRedoLabel const):
2846         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2847         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2848         (WTR::UIScriptController::lastUndoLabel const):
2849         (WTR::UIScriptController::firstRedoLabel const):
2850         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2851         (WTR::UIScriptController::platformUndoManager const):
2852         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2853         (WTR::UIScriptController::platformUndoManager const):
2854
2855 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2856
2857         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2858         https://bugs.webkit.org/show_bug.cgi?id=193824
2859
2860         Reviewed by Antti Koivisto.
2861
2862         * LayoutReloaded/misc/LFC-passing-tests.txt:
2863
2864 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2865
2866         Update macOS JSC bot configurations
2867         https://bugs.webkit.org/show_bug.cgi?id=193739
2868
2869         Reviewed by Alexey Proskuryakov.
2870
2871         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2873         (BubbleQueueServer): Move JSC EWS to Mojave section.
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2875         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2876         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2877
2878 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2879
2880         [Win][WebKitTestRunner] Implement EventSenderProxy
2881         https://bugs.webkit.org/show_bug.cgi?id=193755
2882
2883         Reviewed by Don Olmstead.
2884
2885         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2886         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2887         (WTR::EventSenderProxy::dispatchMessage):
2888         (WTR::EventSenderProxy::EventSenderProxy):
2889         (WTR::EventSenderProxy::mouseDown):
2890         (WTR::EventSenderProxy::mouseUp):
2891         (WTR::EventSenderProxy::mouseMoveTo):
2892         (WTR::EventSenderProxy::mouseScrollBy):
2893         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2894
2895 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2896
2897         Unreviewed fix for API test failure after r240437.
2898
2899         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2900
2901         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2902
2903 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2904
2905         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2906         https://bugs.webkit.org/show_bug.cgi?id=193787
2907         <rdar://problem/47497634>
2908
2909         Reviewed by Alexey Proskuryakov.
2910
2911         * Scripts/webkitdirs.pm:
2912         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2913
2914 2019-01-24  Truitt Savell  <tsavell@apple.com>
2915
2916         Unreviewed, rolling out r240446.
2917
2918         Casued 5 API failures
2919
2920         Reverted changeset:
2921
2922         "Activate the WebResourceLoadStatisticsStore in the
2923         NetworkProcess and deactivate it in the UIProcess."
2924         https://bugs.webkit.org/show_bug.cgi?id=193297
2925         https://trac.webkit.org/changeset/240446
2926
2927 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2928
2929         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2930         https://bugs.webkit.org/show_bug.cgi?id=193741
2931         <rdar://problem/47135030>
2932
2933         Reviewed by Antti Koivisto and Simon Fraser.
2934
2935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2936         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2937         (TestWebKitAPI::TEST):
2938
2939 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2940
2941         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2942         https://bugs.webkit.org/show_bug.cgi?id=193297
2943         <rdar://problem/47158841>
2944
2945         Reviewed by Alex Christensen.
2946
2947         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2948         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2949         activating the message used to trigger the callback when it is set.
2950
2951 2019-01-24  John Wilander  <wilander@apple.com>
2952
2953         Add Ad Click Attribution as an internal/experimental feature
2954         https://bugs.webkit.org/show_bug.cgi?id=193685
2955         <rdar://problem/47450399>
2956
2957         Reviewed by Brent Fulgham.
2958
2959         Added test option adClickAttributionEnabled.
2960
2961         * DumpRenderTree/TestOptions.cpp:
2962         (TestOptions::TestOptions):
2963         * DumpRenderTree/TestOptions.h:
2964         * DumpRenderTree/mac/DumpRenderTree.mm:
2965         (setWebPreferencesForTestOptions):
2966
2967 2019-01-24  Antti Koivisto  <antti@apple.com>
2968
2969         [PSON] Flash on back navigation on Mac
2970         https://bugs.webkit.org/show_bug.cgi?id=193716
2971         <rdar://problem/47148458>
2972
2973         Reviewed by Chris Dumez.
2974
2975         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2976
2977         Closing of the previous page is delayed so waiting for didFinishNavigation is
2978         not sufficient to guarantee we have received all the messages. Wait for them.
2979
2980 2019-01-24  Chris Dumez  <cdumez@apple.com>
2981
2982         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2983         https://bugs.webkit.org/show_bug.cgi?id=193761
2984         <rdar://problem/47456405>
2985
2986         Reviewed by Alex Christensen.
2987
2988         Add API test coverage.
2989
2990         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2991
2992 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2993
2994         webkitpy: Missing PID in crashlog name should not be fatal
2995         https://bugs.webkit.org/show_bug.cgi?id=193771
2996
2997         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2998         of raising an exception.
2999
3000         Reviewed by Lucas Forschler.
3001
3002         * Scripts/webkitpy/port/darwin.py:
3003         (DarwinPort._merge_crash_logs):
3004
3005 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3006
3007         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3008         https://bugs.webkit.org/show_bug.cgi?id=193746
3009
3010         Reviewed by Youenn Fablet.
3011
3012         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3013         so we'd best just not call it.
3014
3015         * Scripts/webkitpy/w3c/test_exporter.py:
3016         (WebPlatformTestExporter.create_branch_with_patch):
3017
3018 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3019
3020         Move FileSystem to WTF
3021         https://bugs.webkit.org/show_bug.cgi?id=193602
3022
3023         Reviewed by Yusuke Suzuki.
3024
3025         * DumpRenderTree/win/DumpRenderTree.cpp:
3026         * TestWebKitAPI/CMakeLists.txt:
3027         * TestWebKitAPI/PlatformGTK.cmake:
3028         * TestWebKitAPI/PlatformJSCOnly.cmake:
3029         * TestWebKitAPI/PlatformPlayStation.cmake:
3030         * TestWebKitAPI/PlatformWPE.cmake:
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3033         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3034         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3035         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3036         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3037         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3038         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3039         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3040         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3041
3042 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3043
3044         [WPE] Remove hard dependency on subprocess32 for the API tests
3045
3046         Rubber-stamped by Carlos Garcia Campos.
3047
3048         * glib/api_test_runner.py:
3049         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3050         its presence only when running WPEQt tests.
3051
3052 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3053
3054         [GLIB] Expose JavaScriptCore options in GLib public API
3055         https://bugs.webkit.org/show_bug.cgi?id=188742
3056
3057         Reviewed by Michael Catanzaro.
3058
3059         Add a test for the new API.
3060
3061         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3062         (testsJSCOptions):
3063         (main):
3064
3065 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3066
3067         [GTK][WPE] Support JPEG 2000 images
3068         https://bugs.webkit.org/show_bug.cgi?id=186272
3069
3070         Reviewed by Žan Doberšek.
3071
3072         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3073
3074         * gtk/jhbuild.modules:
3075         * wpe/jhbuild.modules:
3076
3077 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3078
3079         check-webkit-style should warn when using soft-linking macros in a header
3080         <https://webkit.org/b/193750>
3081
3082         Reviewed by Darin Adler.
3083
3084         * Scripts/webkitpy/style/checkers/cpp.py:
3085         (check_language): Add softlink/header check by refactoring the
3086         softlink/framework check.
3087         (CppChecker): Enable softlink/header check by default.
3088         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3089         (CppStyleTest.test_softlink_framework): Rename from
3090         CppStyleTest.test_softlink() and change test framework name in
3091         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3092         files. Set file_name for macros that only appear in headers.
3093         (CppStyleTest.test_softlink_header): Add tests for using
3094         soft-link macros in headers.
3095
3096 2019-01-23  Chris Dumez  <cdumez@apple.com>
3097
3098         Deprecate API to limit the maximum number of WebProcesses
3099         https://bugs.webkit.org/show_bug.cgi?id=193725
3100         <rdar://problem/47464879>
3101
3102         Reviewed by Geoff Garen.
3103
3104         Update existing API tests to stop using deprecated API.
3105
3106         * MiniBrowser/mac/AppDelegate.m:
3107         (defaultConfiguration):
3108         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3111         (TestWebKitAPI::TEST):
3112         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3113         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3114         (TEST):
3115         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3116         (TEST):
3117
3118 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3119
3120         [ews-app] Rename ews model buildermappings to buildermapping
3121         https://bugs.webkit.org/show_bug.cgi?id=193729
3122
3123         Reviewed by Lucas Forschler.
3124
3125         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3126         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3127         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3128
3129 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-app] Rename ews model steps to step
3132         https://bugs.webkit.org/show_bug.cgi?id=193697
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3137         (Step): Renamed Steps to Step.
3138
3139 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3140
3141         Clean up IndexedDB files between tests
3142         https://bugs.webkit.org/show_bug.cgi?id=192796
3143         <rdar://problem/46824999>
3144
3145         Reviewed by Geoffrey Garen.
3146
3147         * DumpRenderTree/mac/DumpRenderTree.mm:
3148         (runTest):
3149         * WebKitTestRunner/TestController.cpp:
3150         (WTR::TestController::resetStateToConsistentValues):
3151         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3152         (WTR::RemoveAllIndexedDatabasesCallback):
3153         (WTR::TestController::ClearIndexedDatabases):
3154         * WebKitTestRunner/TestController.h:
3155         * WebKitTestRunner/TestInvocation.cpp:
3156         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3157
3158 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3159
3160         [ews-app] Rename ews model Builds to Build
3161         https://bugs.webkit.org/show_bug.cgi?id=193695
3162
3163         Reviewed by Lucas Forschler.
3164
3165         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3166         (Build): Renamed Builds to Build.
3167
3168 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3169
3170         webkitpy: Wait longer when launching WebKitTestRunner
3171         https://bugs.webkit.org/show_bug.cgi?id=193734
3172
3173         Reviewed by Aakash Jain.
3174
3175         * Scripts/webkitpy/port/simulator_process.py:
3176         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3177
3178 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3179
3180         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3181         https://bugs.webkit.org/show_bug.cgi?id=193182
3182         <rdar://problem/47452154>
3183
3184         Reviewed by Tim Horton.
3185
3186         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3187         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3188         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3189
3190         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3191         preventing later tests from recognizing gestures.
3192
3193         * WebKitTestRunner/ios/TestControllerIOS.mm:
3194         (WTR::TestController::platformResetStateToConsistentValues):
3195
3196         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3197
3198 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3199
3200         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3201         https://bugs.webkit.org/show_bug.cgi?id=193722
3202         <rdar://problem/47481475>
3203
3204         Reviewed by Lucas Forschler.
3205
3206         iPhone and iPad ports should both use the iOS config.
3207
3208         * Scripts/webkitpy/port/ios_simulator.py:
3209         (IPhoneSimulatorPort.__init__):
3210         (IPadSimulatorPort.__init__):
3211
3212 2019-01-23  Rob Buis  <rbuis@igalia.com>
3213
3214         Update MIME type parser
3215         https://bugs.webkit.org/show_bug.cgi?id=180526
3216
3217         Reviewed by Frédéric Wang.
3218
3219         Add unit tests for both parse modes of ParsedContentType.
3220
3221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3222         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3223         (TestWebKitAPI::TEST):
3224
3225 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3226
3227         [ews-app] fetch loop should not stop on network issues
3228         https://bugs.webkit.org/show_bug.cgi?id=193666
3229
3230         Reviewed by Lucas Forschler.
3231
3232         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3233         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3234
3235 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3236
3237         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3238         https://bugs.webkit.org/show_bug.cgi?id=189165
3239         <rdar://problem/47433765>
3240
3241         Reviewed by Tim Horton.
3242
3243         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3244         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3245         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3246         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3247         would make its way to the UI process by the time the layer tree commit is finished.
3248
3249         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3250         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3251         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3252         will fail because it asks for -_autofillContext too early.
3253
3254         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3255         is handled in the UI process.
3256
3257         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3258
3259         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3260         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3261         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3262         input session.
3263
3264         (-[AutofillTestView textInputHasAutofillContext]):
3265
3266         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3267
3268         * TestWebKitAPI/cocoa/TestWKWebView.h:
3269         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3270         (nextInputSessionChangeCount):
3271
3272         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3273         This includes changing the focused element from one to another.
3274
3275         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3276         (-[TestWKWebView didStartFormControlInteraction]):
3277         (-[TestWKWebView didEndFormControlInteraction]):
3278         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3279
3280         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3281         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3282         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3283         that doesn't require an input session to one that doesn't.
3284
3285 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3286
3287         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3288         <https://webkit.org/b/193676>
3289
3290         Reviewed by Alexey Proskuryakov.
3291
3292         * Scripts/webkitpy/style/checkers/cpp.py:
3293         (check_member_initialization_list):
3294         - Don't report missing whitespace around colon if the colon at
3295           the start of the line is formatted correctly.
3296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3297         (WebKitStyleTest.test_member_initialization_list):
3298         - Add a test for a missing permutation of existing tests.
3299         - Add a test this false-positive.
3300         - Add blank lines between subtests to make them easier to read.
3301
3302 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3303
3304         [build.webkit.org] Unit-test failure after r237113
3305         https://bugs.webkit.org/show_bug.cgi?id=193669
3306
3307         Reviewed by Michael Catanzaro.
3308
3309         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3310         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3311         multiple or zero flags.
3312
3313 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3314
3315         Cache bytecode to disk
3316         https://bugs.webkit.org/show_bug.cgi?id=192782
3317         <rdar://problem/46084932>
3318
3319         Reviewed by Keith Miller.
3320
3321         Add test helper to execute bytecode-cache tests: it executes each test
3322         twice, the first with JSC_diskCachePath set to a temporary directory
3323         and second with JSC_forceDiskCache=true (in addition to the cache path)
3324         to guarantee that only the disk cache is being used and no new
3325         UnlinkedCodeBlocks are being created.
3326
3327         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3328         * Scripts/run-jsc-stress-tests:
3329
3330 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3331
3332         [css-logical] Implement flow-relative margin, padding and border shorthands
3333         https://bugs.webkit.org/show_bug.cgi?id=188697
3334
3335         Reviewed by Simon Fraser and Antti Koivisto.
3336
3337         * DumpRenderTree/TestOptions.cpp:
3338         (TestOptions::TestOptions):
3339         * DumpRenderTree/TestOptions.h:
3340         * DumpRenderTree/mac/DumpRenderTree.mm:
3341         (setWebPreferencesForTestOptions):
3342         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3343
3344         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3345         (JSONCSSPropertiesChecker.check_codegen_properties):
3346         Allow CSS property definitions to have a 'runtime-flag' parameter which
3347         disables the property when the specified runtime flag is disabled.
3348
3349 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3350
3351         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3352         https://bugs.webkit.org/show_bug.cgi?id=193643
3353
3354         Reviewed by Michael Catanzaro.
3355
3356         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3357         * wpe/jhbuild.modules: Ditto.
3358
3359 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3360
3361         [LFC][Floats] Take float top position into account when computing containing block height.
3362         https://bugs.webkit.org/show_bug.cgi?id=193655
3363
3364         Reviewed by Antti Koivisto.
3365
3366         * LayoutReloaded/misc/LFC-passing-tests.txt:
3367
3368 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3369
3370         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3371         <https://webkit.org/b/193645>
3372         <rdar://problem/47421574>
3373
3374         Reviewed by Alex Christensen.
3375
3376         - Now checks for local soft-linking of all frameworks that have
3377           their own *SoftLinking.{cpp,h,mm} files.
3378         - Changes softlink/uikit warning to softlink/framework.
3379
3380         * Scripts/webkitpy/style/checkers/cpp.py:
3381         (check_language):
3382         (CppChecker):
3383         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3384         (CppStyleTest):
3385
3386 2019-01-20  Saam Barati  <sbarati@apple.com>
3387
3388         Rollout r240210: It broke tests on iOS
3389         https://bugs.webkit.org/show_bug.cgi?id=193640
3390
3391         Unreviewed.
3392
3393         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3394         * Scripts/run-jsc-stress-tests:
3395
3396 2019-01-20  chris fleizach  <cfleizach@apple.com>
3397
3398         AX: Support returning relative frames for accessibility
3399         https://bugs.webkit.org/show_bug.cgi?id=193414
3400         <rdar://problem/47268501>
3401
3402         Reviewed by Zalan Bujtas.
3403
3404         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3405         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3406         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3407         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3408         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3409         (WTR::attributesOfElement):
3410         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3411
3412 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3413
3414         Unreviewed, add my new email address
3415
3416         * Scripts/webkitpy/common/config/contributors.json:
3417
3418 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3419
3420         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3421         https://bugs.webkit.org/show_bug.cgi?id=193617
3422
3423         Reviewed by Antti Koivisto.
3424
3425         * LayoutReloaded/misc/LFC-passing-tests.txt:
3426
3427 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3428
3429         Unreviewed, rolling out r240209.
3430
3431         Broke GTK/WPE injected bundle
3432
3433         Reverted changeset:
3434
3435         "AX: Support returning relative frames for accessibility"
3436         https://bugs.webkit.org/show_bug.cgi?id=193414
3437         https://trac.webkit.org/changeset/240209
3438
3439 2019-01-12  Dan Bernstein  <mitz@apple.com>
3440
3441         [Cocoa] Avoid importing directly from subumbrella frameworks
3442         https://bugs.webkit.org/show_bug.cgi?id=186016
3443         <rdar://problem/40591038>
3444
3445         Reviewed by Sam Weinig.
3446
3447         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3448           LaunchServices header.
3449         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3450           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3451         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3452           when using SDKs earlier than 10.13.
3453         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3454           and OTHER_CPLUSPLUSFLAGS.
3455         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3456           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3457         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3458           LaunchServices header.
3459
3460 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3461
3462         Cache bytecode to disk
3463         https://bugs.webkit.org/show_bug.cgi?id=192782
3464         <rdar://problem/46084932>
3465
3466         Reviewed by Keith Miller.
3467
3468         Add test helper to execute bytecode-cache tests: it executes each test
3469         twice, the first with JSC_diskCachePath set to a temporary directory
3470         and second with JSC_forceDiskCache=true (in addition to the cache path)
3471         to guarantee that only the disk cache is being used and no new
3472         UnlinkedCodeBlocks are being created.
3473
3474         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3475         * Scripts/run-jsc-stress-tests:
3476
3477 2019-01-20  chris fleizach  <cfleizach@apple.com>
3478
3479         AX: Support returning relative frames for accessibility
3480         https://bugs.webkit.org/show_bug.cgi?id=193414
3481         <rdar://problem/47268501>
3482
3483         Reviewed by Zalan Bujtas.
3484
3485         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3486         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3487         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3488         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3489         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3490         (WTR::attributesOfElement):
3491         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3492
3493 2019-01-20  Antoine Quint  <graouts@apple.com>
3494
3495         Add a POINTER_EVENTS feature flag
3496         https://bugs.webkit.org/show_bug.cgi?id=193577
3497         <rdar://problem/47408511>
3498
3499         Unreviewed. Also enable Pointer Events for iosmac.
3500
3501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3502
3503 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3504
3505         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3506         https://bugs.webkit.org/show_bug.cgi?id=193613
3507
3508         Reviewed by Antti Koivisto.
3509
3510         * LayoutReloaded/misc/LFC-passing-tests.txt:
3511
3512 2019-01-19  Antoine Quint  <graouts@apple.com>
3513
3514         Add a POINTER_EVENTS feature flag
3515         https://bugs.webkit.org/show_bug.cgi?id=193577
3516
3517         Reviewed by Dean Jackson.
3518
3519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3520
3521 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3522
3523         Disable the run-jsc-stress-test remote host key check [second round].
3524         https://bugs.webkit.org/show_bug.cgi?id=192988
3525
3526         Reviewed by Dewei Zhu.
3527
3528         * Scripts/run-jsc-stress-tests:
3529
3530 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3531
3532         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3533         https://bugs.webkit.org/show_bug.cgi?id=193597
3534
3535         Reviewed by Lucas Forschler.
3536
3537         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3538
3539 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3540
3541         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3542         https://bugs.webkit.org/show_bug.cgi?id=193595
3543
3544         Reviewed by Lucas Forschler.
3545
3546         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3547         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3548         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3549
3550 2019-01-18  Chris Dumez  <cdumez@apple.com>
3551
3552         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3553         https://bugs.webkit.org/show_bug.cgi?id=193588
3554         <rdar://problem/47131566>
3555
3556         Reviewed by Alex Christensen.
3557
3558         Add layout test coverage.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3561
3562 2019-01-18  Jer Noble  <jer.noble@apple.com>
3563
3564         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3565         https://bugs.webkit.org/show_bug.cgi?id=189553
3566
3567         Reviewed by Tim Horton.
3568
3569         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3570
3571         * ContentExtensionTester/Configurations/Base.xcconfig:
3572         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3573         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3574         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3575         * ImageDiff/cg/Configurations/Base.xcconfig:
3576         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3577         * MiniBrowser/Configurations/Base.xcconfig:
3578         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3579         * MobileMiniBrowser/Configurations/Base.xcconfig:
3580         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3581         * Scripts/webkitpy/style/checker.py:
3582         (_all_categories):
3583         (FileType):
3584         (CheckerDispatcher._file_type):
3585         (CheckerDispatcher._create_checker):
3586         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3587         (SDKVariantChecker):
3588         (SDKVariantChecker.__init__):
3589         (SDKVariantChecker.check):
3590         * TestWebKitAPI/Configurations/Base.xcconfig:
3591         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3592         * WebEditingTester/Configurations/Base.xcconfig:
3593         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3594         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3595         * WebKitTestRunner/Configurations/Base.xcconfig:
3596         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3597         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3598         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3599
3600 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3601
3602         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3603         <https://webkit.org/b/193568>
3604         <rdar://problem/47381130>
3605
3606         Reviewed by Alex Christensen.
3607
3608         Make sure no one re-introduces UIKit soft-linking by adding a
3609         style rule.
3610
3611         * Scripts/webkitpy/style/checkers/cpp.py:
3612         (check_language): Add softlink/uikit check.
3613         (CppChecker): Enable softlink/uikit check.
3614         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3615         (CppStyleTest): Add test for softlink/uikit.
3616
3617 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3618
3619         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3620         https://bugs.webkit.org/show_bug.cgi?id=193584
3621
3622         Change "-dev" to "-devel".
3623
3624         Reviewed by Michael Catanzaro.
3625
3626         * gtk/install-dependencies:
3627
3628 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3629
3630         webkitpy: Add iPhone and iPad ports
3631         https://bugs.webkit.org/show_bug.cgi?id=193537
3632         <rdar://problem/47353390>
3633
3634         Reviewed by Lucas Forschler.
3635
3636         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3637         ports. Note that this separation is optional, the --ios-simulator command remains.
3638
3639         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3640         (RunTest.test_device_type_test_division): Drive-by fix.
3641         (RunTest.test_device_type_specific_listing): Ditto.
3642         (RunTest.test_ipad_test_division):
3643         (RunTest):
3644         (RunTest.test_ipad_listing):
3645         * Scripts/webkitpy/port/factory.py:
3646         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3647         (PortFactory):
3648         * Scripts/webkitpy/port/ios_simulator.py:
3649         (IPhoneSimulatorPort):
3650         (IPadSimulatorPort):
3651
3652 2019-01-18  Chris Dumez  <cdumez@apple.com>
3653
3654         Regression(PSON) Scroll position is not always restored properly when navigating back
3655         https://bugs.webkit.org/show_bug.cgi?id=193578
3656         <rdar://problem/47386331>
3657
3658         Reviewed by Tim Horton.
3659
3660         Add API test coverage.
3661
3662         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3663
3664 2019-01-18  Youenn Fablet  <youenn@apple.com>
3665
3666         Add a new SPI to request for cache storage quota increase
3667         https://bugs.webkit.org/show_bug.cgi?id=193323
3668
3669         Reviewed by Alex Christensen.
3670
3671         Implement WebsiteDataStore quota delegate to handle quota requests.
3672         By default, do not update quota.
3673         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3674
3675         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3677         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3678         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3679         * WebKitTestRunner/TestController.cpp:
3680         (WTR::TestController::allowCacheStorageQuotaIncrease):
3681         * WebKitTestRunner/TestController.h:
3682         * WebKitTestRunner/TestInvocation.cpp:
3683         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3684         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3685         (-[CacheStorageQuotaManager init]):
3686         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3687         (WTR::initializeWebViewConfiguration):
3688         (WTR::TestController::cocoaResetStateToConsistentValues):
3689         (WTR::TestController::allowCacheStorageQuotaIncrease):
3690
3691 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3692
3693         [ews-build] Pass owner to the triggered builds
3694         https://bugs.webkit.org/show_bug.cgi?id=193574
3695