Tools/ChangeLog

   1 2012-06-21  Yong Li  <yoli@rim.com>
   2
   3         Unreviewed. Moving myself from committer to reviewer.
   4
   5         * Scripts/webkitpy/common/config/committers.py:
   6
   7 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
   8
   9         [GTK] Add a new webkit2 tests slave bot
  10         https://bugs.webkit.org/show_bug.cgi?id=89336
  11
  12         Reviewed by Philippe Normand.
  13
  14         Slave configuration for a new GTK bot that will run WebKit2 tests.
  15
  16         * BuildSlaveSupport/build.webkit.org-config/config.json:
  17
  18 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
  19
  20         [Qt] Add a custom Color Chooser widget to MiniBrowser
  21         https://bugs.webkit.org/show_bug.cgi?id=87988
  22
  23         Reviewed by Alexis Menard.
  24
  25         Added custom color chooser example for the MiniBrowser.
  26
  27         * MiniBrowser/qt/MiniBrowser.qrc:
  28         * MiniBrowser/qt/qml/BrowserWindow.qml:
  29         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
  30
  31 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
  32
  33         Remove the warning "File not found" in MiniBrowser post-build event
  34         https://bugs.webkit.org/show_bug.cgi?id=89601
  35
  36         Reviewed by Adam Roben.
  37
  38         * MiniBrowser/MiniBrowserPostBuild.cmd:
  39
  40 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
  41
  42         [Qt] DRT in standalone mode hangs after the first test
  43         https://bugs.webkit.org/show_bug.cgi?id=89613
  44
  45         Reviewed by Csaba Osztrogonác.
  46
  47         Break an inline signal slot chain that ends up in setting
  48         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
  49         we emit done() which starts the chain that finishes in DumpRenderTree::open().
  50         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
  51         these two lines but it seems to be wrong in general to start the next load
  52         from this call chain. The server mode (when DRT is runned by the test harness)
  53         also uses a queued connection to read the next test from stdin.
  54
  55         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  56         (WebCore::DumpRenderTree::processArgsLine):
  57
  58 2012-06-20  Hans Wennborg  <hans@chromium.org>
  59
  60         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
  61         https://bugs.webkit.org/show_bug.cgi?id=89217
  62
  63         Reviewed by Adam Barth.
  64
  65         Add a method for checking whether the mock speech
  66         recognition was aborted.
  67
  68         Also redo the way the mock posts tasks. Instead of posting them all at once,
  69         maintain an internal queue of task objects, and call postTask() for them
  70         once at the time. This means that for example when the page is navigated
  71         away and abort() is called, that call doesn't end up after a bunch
  72         of previously posted events on the event loop.
  73
  74         * DumpRenderTree/chromium/LayoutTestController.cpp:
  75         (LayoutTestController::LayoutTestController):
  76         (LayoutTestController::wasMockSpeechRecognitionAborted):
  77         * DumpRenderTree/chromium/LayoutTestController.h:
  78         (LayoutTestController):
  79         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  80         (WebKit::ClientCallTask::ClientCallTask):
  81         (WebKit::ResultTask::ResultTask):
  82         (WebKit::NoMatchTask::NoMatchTask):
  83         (WebKit::ErrorTask::ErrorTask):
  84         (MockWebSpeechRecognizer::start):
  85         (MockWebSpeechRecognizer::abort):
  86         (MockWebSpeechRecognizer::setError):
  87         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
  88         (MockWebSpeechRecognizer::startTaskQueue):
  89         (MockWebSpeechRecognizer::StepTask::runIfValid):
  90         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
  91         (MockWebSpeechRecognizer::hasBeenAborted):
  92         (MockWebSpeechRecognizer):
  93         (MockWebSpeechRecognizer::taskList):
  94         (Task):
  95         (MockWebSpeechRecognizer::Task::Task):
  96         (MockWebSpeechRecognizer::Task::~Task):
  97         (StepTask):
  98         (MockWebSpeechRecognizer::StepTask::StepTask):
  99
 100 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
 101
 102         [GTK] Add support for window.showModalDialog in WebKit2GTK+
 103         https://bugs.webkit.org/show_bug.cgi?id=79500
 104
 105         Reviewed by Carlos Garcia Campos.
 106
 107         Add support for modal dialogs in GTK's MiniBrowser.
 108
 109         * MiniBrowser/gtk/BrowserWindow.c:
 110         (webViewRunAsModal):
 111         (webViewCreate):
 112         (webViewDecidePolicy):
 113         (browser_window_new):
 114         * MiniBrowser/gtk/BrowserWindow.h:
 115         * MiniBrowser/gtk/main.c:
 116         (createBrowserWindow):
 117
 118 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
 119
 120         [WinCairo] Unreviewed build fix.
 121         The wrapper script that launched new- and old-run-webkit-tests
 122         was discarding the --wincairo argument needed to get the proper
 123         test infrastructure to build under WinCairo.
 124
 125         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
 126         behavior to chain the --wincairo flag through to the new build
 127         and test scripts.
 128
 129 2012-06-20  Mark Rowe  <mrowe@apple.com>
 130
 131         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
 132
 133         Reviewed by Dan Bernstein.
 134
 135         * Scripts/webkitdirs.pm:
 136         (executableHasEntitlements):
 137         (safariPathFromSafariBundle):
 138
 139 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 140
 141         Unreviewed, rolling out r120821.
 142         http://trac.webkit.org/changeset/120821
 143         https://bugs.webkit.org/show_bug.cgi?id=89605
 144
 145         It made duplicated reviewer entries (Requested by Ossy on
 146         #webkit).
 147
 148         * Scripts/webkitpy/common/checkout/changelog.py:
 149         (ChangeLog.set_reviewer):
 150         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 151         (test_set_reviewer):
 152         (test_set_short_description_and_bug_url):
 153
 154 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 155
 156         nrwt outputs empty files for wdiff output if wdiff is not installed
 157         https://bugs.webkit.org/show_bug.cgi?id=88709
 158
 159         Reviewed by Tony Chang.
 160
 161         Reviewed by Tony Chang.
 162
 163         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
 164         aren't available, and clean up the handling for them in the port
 165         code.
 166
 167         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
 168         (MainTest.test_output_diffs):
 169         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
 170         (TestResultWriter.create_text_diff_and_write_result):
 171         * Scripts/webkitpy/layout_tests/port/base.py:
 172         (Port.check_pretty_patch):
 173         (Port.check_wdiff):
 174         (Port._wdiff_missing_message):
 175         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 176         (ChromiumLinuxPort.check_build):
 177         (ChromiumLinuxPort._wdiff_missing_message):
 178         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 179         (ChromiumMacPort.check_build):
 180         (ChromiumMacPort):
 181         (ChromiumMacPort._wdiff_missing_message):
 182         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
 183         (ChromiumMacPortTest):
 184
 185 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 186
 187         nrwt: fix unit tests for ensuring svn revision is correct
 188         https://bugs.webkit.org/show_bug.cgi?id=89498
 189
 190         Reviewed by Eric Seidel.
 191
 192         Reviewed by Eric Seidel.
 193
 194         Fix the unit tests for testing that we are embedding the SVN
 195         revision in the results json for NRWT properly; this was broken
 196         in r120646 but because the MockHost worked differently than the
 197         real one (by always initializing the MockSCM object) we didn't
 198         notice. Unfortunately, just changing the default breaks all
 199         sorts of unit tests ...
 200
 201         * Scripts/webkitpy/common/host_mock.py:
 202         (MockHost.__init__):
 203         (MockHost._initialize_scm):
 204         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 205         (ResultSummaryTest.test_no_svn_revision):
 206         (ResultSummaryTest.test_svn_revision):
 207
 208 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 209
 210         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
 211         https://bugs.webkit.org/show_bug.cgi?id=69360
 212
 213         Reviewed by Eric Seidel.
 214
 215         Reviewed by Eric Seidel.
 216
 217         Propagate the 'port_implementation' part of the platform (i.e.,
 218         gtk,qt,chromium) to webkit-build-directory so that we can pick
 219         up the gtk-specific handling of WEBKITOUTPUTDIR ...
 220
 221         I didn't write any additional tests for this; testing it
 222         properly is an integration test between the python code and the
 223         perl code, which I verified by hand.
 224
 225         * Scripts/webkitpy/layout_tests/port/base.py:
 226         (Port.__init__):
 227         * Scripts/webkitpy/layout_tests/port/config.py:
 228         (Config.__init__):
 229         (Config.build_directory):
 230         * Scripts/webkitpy/layout_tests/port/config_mock.py:
 231         (MockConfig.__init__):
 232         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
 233         (ConfigTest.test_build_directory_passes_port_implementation):
 234
 235 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 236
 237         Fix import sorting missed in r120846
 238
 239         Reviewed by Tony Chang.
 240
 241         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
 242
 243 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 244
 245         Fix chromium win http servers after breakage introduced in r120846.
 246
 247         Unreviewed, build fix.
 248
 249         * Scripts/webkitpy/layout_tests/port/base.py:
 250         (Port.to.start_http_server):
 251         * Scripts/webkitpy/layout_tests/servers/http_server.py:
 252         (Lighttpd.__init__):
 253
 254 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 255
 256         tweak output of webkit-patch print-{baselines,expectations}
 257         https://bugs.webkit.org/show_bug.cgi?id=89588
 258
 259         Reviewed by Tony Chang.
 260
 261         Minor tweaks to the output to make it more readable, including
 262         turning off csv by default for print-baselines with multiple ports.
 263
 264         * Scripts/webkitpy/layout_tests/port/test.py:
 265         (TestPort):
 266         * Scripts/webkitpy/tool/commands/queries.py:
 267         (PrintExpectations.execute):
 268         (PrintBaselines.execute):
 269         * Scripts/webkitpy/tool/commands/queries_unittest.py:
 270         (PrintExpectationsTest.run_test):
 271         (PrintExpectationsTest.test_multiple):
 272         (PrintBaselinesTest.setUp):
 273         (PrintBaselinesTest.test_multiple):
 274
 275 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
 276
 277         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
 278         https://bugs.webkit.org/show_bug.cgi?id=88134
 279
 280         Reviewed by Tony Chang.
 281
 282         Change NRWT to spin up 2*min(child_processes, locked_shards)
 283         http servers by default so that we are less likely to get a
 284         bunch of http timeouts at the beginning of a test run.
 285
 286         Note that I had to tweak executive_mock to support mocked stderr
 287         because the apache_http_server code reads stderr when starting a
 288         process to ensure it started okay.
 289
 290         * Scripts/webkitpy/common/system/executive_mock.py:
 291         (MockProcess.__init__):
 292         * Scripts/webkitpy/common/system/outputcapture.py:
 293         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 294         (Manager._run_tests):
 295         (Manager.start_servers_with_lock):
 296         * Scripts/webkitpy/layout_tests/port/base.py:
 297         (Port.to.start_http_server):
 298         * Scripts/webkitpy/layout_tests/port/test.py:
 299         (TestPort.start_http_server):
 300         (TestPort._path_to_apache):
 301         (TestPort):
 302         (TestPort._path_to_apache_config_file):
 303         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
 304         (LayoutTestApacheHttpd.__init__):
 305         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
 306         (LayoutTestApacheHttpd.__init__):
 307         * Scripts/webkitpy/layout_tests/servers/http_server.py:
 308         (Lighttpd.__init__):
 309         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
 310         (HttpServerBase.__init__):
 311
 312 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
 313
 314         Unreviewed: Back out accidentally checked in debug print which broke a test
 315
 316         * Scripts/webkitpy/performance_tests/perftest.py:
 317         (PerfTest.parse_output):
 318
 319 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
 320
 321         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
 322         https://bugs.webkit.org/show_bug.cgi?id=78789
 323
 324         Reviewed by Ryosuke Niwa.
 325
 326         Updated parser to include fps as a valid unit.
 327
 328         * Scripts/webkitpy/performance_tests/perftest.py:
 329         (PerfTest):
 330         (PerfTest.parse_output):
 331
 332 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
 333
 334         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
 335         https://bugs.webkit.org/show_bug.cgi?id=67935
 336
 337         Reviewed by Ryosuke Niwa.
 338
 339         * Scripts/webkitpy/common/checkout/changelog.py:
 340         (ChangeLog.set_reviewer):
 341         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 342         (test_set_reviewer):
 343         (test_set_short_description_and_bug_url):
 344
 345 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
 346
 347         Unreviewed trivial permissions fix.
 348
 349         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
 350
 351 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
 352
 353         [EFL][Regression] Build break after r120786
 354         https://bugs.webkit.org/show_bug.cgi?id=89549
 355
 356         Unreviewed build fix for Efl port.
 357
 358         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
 359
 360 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 361
 362         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
 363         https://bugs.webkit.org/show_bug.cgi?id=64489
 364
 365         Reviewed by Tony Chang.
 366
 367         This change changes NRWT so that we don't start the websocket
 368         server if we aren't running websocket tests and don't start the
 369         HTTP server if we aren't running http tests.
 370
 371         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 372         (Manager._websocket_tests):
 373         (Manager.start_servers_with_lock):
 374         (Manager.stop_servers_with_lock):
 375         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 376         (ManagerTest.test_servers_started):
 377
 378 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 379
 380         test-webkitpy: add a -p flag to pass through captured output to enable debugging
 381         https://bugs.webkit.org/show_bug.cgi?id=89158
 382
 383         Reviewed by Eric Seidel.
 384
 385         Normally when outputcapture runs it intercepts stdout/stderr,
 386         which makes running under the debugger difficult and mostly
 387         pointless (since you can't see any output). This change adds a
 388         flag to test-webkitpy (-p) that will cause outputcapture to pass
 389         through the output as well as capture it.
 390
 391         * Scripts/webkitpy/common/system/outputcapture.py:
 392         (OutputCapture.stream_wrapper):
 393         (OutputCapture._capture_output_with_name):
 394         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
 395         (OutputCaptureTest.setUp):
 396         * Scripts/webkitpy/test/main.py:
 397         (Tester._parse_args):
 398         (Tester._run_tests):
 399         (Tester._log_exception):
 400         (_CaptureAndPassThroughStream):
 401         (_CaptureAndPassThroughStream.__init__):
 402         (_CaptureAndPassThroughStream.write):
 403         (_CaptureAndPassThroughStream._message_is_from_pdb):
 404         (_CaptureAndPassThroughStream.flush):
 405         (_CaptureAndPassThroughStream.getvalue):
 406
 407 2012-06-19  Adam Barth  <abarth@webkit.org>
 408
 409         garden-o-matic fails to rebaseline tests with MISSING results
 410         https://bugs.webkit.org/show_bug.cgi?id=89521
 411
 412         Reviewed by Kenneth Russell.
 413
 414         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
 415
 416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
 417
 418 2012-06-19  Adam Barth  <abarth@webkit.org>
 419
 420         svn.delete_list fails to delete empty parent directories
 421         https://bugs.webkit.org/show_bug.cgi?id=89520
 422
 423         Reviewed by Dirk Pranke.
 424
 425         These functions were calling scm.delete and scm.add, which already
 426         delete the parent directory. We'd get an exception when we tried to
 427         delete the parent directory again.
 428
 429         * Scripts/webkitpy/common/checkout/scm/svn.py:
 430         (SVN._add_parent_directories):
 431         (SVN._delete_parent_directories):
 432
 433 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 434
 435         webkitpy: Simplify fetch_bugs_matching_search()
 436         https://bugs.webkit.org/show_bug.cgi?id=89497
 437
 438         Reviewed by Adam Barth.
 439
 440         Removed parameter with default value. It's not being used
 441         and the handling of the parameter was wrong. Saves a check.
 442
 443         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 444         (BugzillaQueries.fetch_bugs_matching_search):
 445         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
 446         (MockBugzillaQueries.fetch_bugs_matching_search):
 447
 448 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 449
 450         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
 451         https://bugs.webkit.org/show_bug.cgi?id=89522
 452
 453         Reviewed by Eric Seidel.
 454
 455         They were no longer being used. No tests necessary.
 456
 457         * Scripts/webkitpy/layout_tests/port/chromium.py:
 458
 459 2012-06-19  Adam Barth  <abarth@webkit.org>
 460
 461         Missing results aren't shown in garden-o-matic
 462
 463         Reviewed by Kenneth Russell.
 464
 465         Previously we didn't know to look for text and image results when the
 466         bot told us that results were missing.
 467
 468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
 469
 470 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 471
 472         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
 473
 474         Unreviewed, build fix.
 475
 476         It turns out that we store the svn revision two different ways
 477         in the JSON, and I only caught one of them :(. This should fix
 478         the other.
 479
 480         Also, this part of the code is poorly tested. I will investigate
 481         adding at least a basic test for this in a separate fix.
 482
 483         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 484         (summarize_results):
 485
 486 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 487
 488         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
 489         https://bugs.webkit.org/show_bug.cgi?id=78127
 490
 491         Reviewed by Ryosuke Niwa.
 492
 493         Add the --add-platform-exceptions flag from ORWT, and ensure
 494         that --new-baseline is equivalent to --reset-results
 495         --add-platform-exceptions. Also fix the default logic for where to
 496         put PNGs and render tree dumps if --new-test-results is true:
 497         if --add-platform-exceptions is False, baselines should go in
 498         the least-specific platform directory (e.g., platform/mac)
 499         rather than the most-specific (platform/mac-snowleopard).
 500
 501         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
 502         (SingleTestRunner):
 503         (SingleTestRunner.run):
 504         (SingleTestRunner._run_rebaseline):
 505         (SingleTestRunner._add_missing_baselines):
 506         (SingleTestRunner._location_for_new_baseline):
 507         (SingleTestRunner._overwrite_baselines):
 508         (SingleTestRunner._save_baseline_data):
 509         * Scripts/webkitpy/layout_tests/port/base.py:
 510         (Port.baseline_path):
 511         (Port):
 512         (Port.baseline_platform_dir):
 513         (Port.baseline_version_dir):
 514         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 515         (_set_up_derived_options):
 516         (parse_args):
 517         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 518         (RebaselineTest.assertBaselines):
 519         (RebaselineTest.test_reset_results):
 520         (RebaselineTest.test_missing_results):
 521         (RebaselineTest.test_new_baseline):
 522
 523 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 524
 525         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
 526         https://bugs.webkit.org/show_bug.cgi?id=81379
 527
 528         Reviewed by Eric Seidel.
 529
 530         The 'free memory' calculation we were running on the mac seemed
 531         to underestimate how many children we can run in parallel, and
 532         it was complex. This patch replaces that calculation with a
 533         simpler one that reserves 2GB for overhead and assumes 256MB per
 534         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
 535
 536         Also, there was a bug where we were truncating the memory
 537         installed on the machine to 4GB by casting to an int instead of
 538         a long; this was probably the source of some of the earlier
 539         problems when using total memory.
 540
 541         This patch also removes the no-longer-needed restrictions on the
 542         number of workers on beefy Lion boxes for both Apple Mac and Chromium
 543         Mac; we should now use all of the cores by default.
 544
 545         The memory calculations have only been implemented on the mac;
 546         having the calculation in base.default_child_processes() was IMO
 547         misleading, and so this patch also moves the computation into
 548         the MacPort. I have not heard of the # of workers being an issue
 549         on any other ports, so this should be fine.
 550
 551         * Scripts/webkitpy/common/system/platforminfo.py:
 552         (PlatformInfo.total_bytes_memory):
 553         * Scripts/webkitpy/common/system/platforminfo_mock.py:
 554         (PlatformInfo.total_bytes_memory):
 555         (PlatformInfo.total_bytes_memory):
 556         (PlatformInfo._win_version_tuple_from_cmd):
 557         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
 558         (TestPlatformInfo.test_total_bytes_memory):
 559         * Scripts/webkitpy/layout_tests/port/base.py:
 560         (Port.default_child_processes):
 561         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 562         (PortTest.test_default_child_processes):
 563         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 564         (ChromiumMacPort.operating_system):
 565         * Scripts/webkitpy/layout_tests/port/mac.py:
 566         (MacPort.default_child_processes):
 567         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
 568         (TestMacPort.test_default_child_processes):
 569
 570 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
 571
 572         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
 573         https://bugs.webkit.org/show_bug.cgi?id=85446
 574
 575         Reviewed by Simon Fraser.
 576
 577         Embed whether pixel testing was enabled into the results.json.
 578
 579         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 580         (summarize_results):
 581
 582 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
 583
 584         [Qt] Modify HTTPS port to 8443 for performance tests
 585         https://bugs.webkit.org/show_bug.cgi?id=89442
 586
 587         Reviewed by Ryosuke Niwa.
 588
 589         We should be consistent with the default HTTPS port and with the changelog of r119188.
 590
 591         * Scripts/webkitpy/performance_tests/perftest.py:
 592         (ReplayServer.__init__):
 593
 594 2012-06-19  Mike West  <mkwst@chromium.org>
 595
 596         Introduce ENABLE_CSP_NEXT configuration flag.
 597         https://bugs.webkit.org/show_bug.cgi?id=89300
 598
 599         Reviewed by Adam Barth.
 600
 601         The 1.0 draft of the Content Security Policy spec is just about to
 602         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
 603         this ENABLE flag, disabled by default.
 604
 605         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
 606
 607         * Scripts/webkitperl/FeatureList.pm:
 608         * qmake/mkspecs/features/features.pri:
 609
 610 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
 611
 612         [EFL] EFL's LayoutTestController does not support setTextDirection
 613         https://bugs.webkit.org/show_bug.cgi?id=87481
 614
 615         Reviewed by Hajime Morita.
 616
 617         Implement setTextDirection in EFL's LayoutTestController and
 618         properly reset its value between test cases to avoid flakiness.
 619
 620         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 621         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 622         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 623         (LayoutTestController::setTextDirection):
 624
 625 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 626
 627         [Qt] Temporarily disable xvfb driver in nrwt
 628         https://bugs.webkit.org/show_bug.cgi?id=88414
 629
 630         Reviewed by Csaba Osztrogonác.
 631
 632         * Scripts/webkitpy/layout_tests/port/qt.py:
 633         (QtPort._build_driver):
 634
 635 2012-06-18  Joone Hur  <joone.hur@intel.com>
 636
 637         [EFL] Fontconfig can't be linked properly
 638         https://bugs.webkit.org/show_bug.cgi?id=89418
 639
 640         Unreviewed build fix.
 641
 642         Make Fontconfig be linked correctly.
 643
 644         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
 645
 646 2012-06-18  Joone Hur  <joone.hur@intel.com>
 647
 648         Unreviewed. Updating email for committers.py script.
 649
 650         * Scripts/webkitpy/common/config/committers.py:
 651
 652 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
 653
 654         Fix a typo that caused TestFailures to have a syntax error.
 655
 656         Sadly TestFailures is broken for another reason now too:
 657         https://bugs.webkit.org/show_bug.cgi?id=89419
 658
 659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
 660         (ViewController.prototype._domForBuildName):
 661
 662 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
 663
 664         Provide bug links for suspicious commits
 665         https://bugs.webkit.org/show_bug.cgi?id=89408
 666
 667         Reviewed by Adam Barth.
 668
 669         Add links to bugs for the suspicious commits if we have bug data.
 670
 671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
 672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
 673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
 674         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
 675         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
 676
 677 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
 678
 679         [Chromium] DeviceOrientation Cleanup
 680         https://bugs.webkit.org/show_bug.cgi?id=89354
 681
 682         Reviewed by Kent Tamura.
 683
 684         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
 685         (WebViewHost):
 686
 687 2012-06-18  James Robinson  <jamesr@chromium.org>
 688
 689         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
 690         https://bugs.webkit.org/show_bug.cgi?id=89254
 691
 692         Reviewed by Adrienne Walker.
 693
 694         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
 695         upstream.
 696
 697         * DumpRenderTree/chromium/WebViewHost.cpp:
 698         (WebViewHost::createGraphicsContext3D):
 699
 700 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
 701
 702         Minor fix suggested by Adam Barth.
 703
 704         Use $(this._what).empty(); rather than removing children one at a time.
 705         For some reason removeAllChildren() is undefined on this node.
 706
 707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
 708
 709 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
 710
 711         Show TOT revision in garden-o-matic, and make the revisions into links
 712         https://bugs.webkit.org/show_bug.cgi?id=89396
 713
 714         Reviewed by Adam Barth.
 715
 716         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
 717         where the revisions are links to trac.
 718
 719         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
 720         the knock-on effect of flipping the target and href attributes for anchors in some test output.
 721
 722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
 723         (ViewController.prototype._displayTesters.updateList.list):
 724         (ViewController.prototype._displayTesters.updateList):
 725         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
 726         (ViewController.prototype._domForRegressionRange):
 727         (ViewController.prototype._domForAuxiliaryUIElements):
 728         (ViewController.prototype._domForBuildName):
 729         (ViewController.prototype):
 730         (ViewController.prototype.):
 731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
 732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
 733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
 734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
 735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
 736
 737 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
 738
 739         REGRESSION(r100558): NRWT should work without SVN or GIT
 740         https://bugs.webkit.org/show_bug.cgi?id=76630
 741
 742         Reviewed by Dirk Pranke.
 743
 744         NRWT is not supposed to have a requirement that we have an
 745         actual SVN or Git checkout, and we were unnecessarily
 746         initializing the checkout. This patch removes that line :).
 747
 748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 749         (main):
 750
 751 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
 752
 753         [garden-o-matic] Add support for the GTK builders
 754         https://bugs.webkit.org/show_bug.cgi?id=89360
 755
 756         Reviewed by Adam Barth.
 757
 758         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
 759         both get their data from build.webkit.org.
 760
 761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 762         (.):
 763
 764 2012-06-18  Nico Weber  <thakis@chromium.org>
 765
 766         [chromium/mac] Unbreak smooth scrolling.
 767         https://bugs.webkit.org/show_bug.cgi?id=89327
 768
 769         Reviewed by Dimitri Glazkov.
 770
 771         Broken by Sam in r115589 / r115591.
 772
 773         * DumpRenderTree/mac/DumpRenderTree.mm:
 774         (resetDefaultsToConsistentValues):
 775         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
 776         (TestWebKitAPI::InjectedBundleController::platformInitialize):
 777         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
 778         (WTR::InjectedBundle::platformInitialize):
 779
 780 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
 781
 782         Unreviewed, rolling out r120541, r120547, and r120548.
 783         http://trac.webkit.org/changeset/120541
 784         http://trac.webkit.org/changeset/120547
 785         http://trac.webkit.org/changeset/120548
 786         https://bugs.webkit.org/show_bug.cgi?id=89383
 787
 788         This approach doesn't work for WebKit2 (Requested by abarth on
 789         #webkit).
 790
 791         * DumpRenderTree/LayoutTestController.cpp:
 792         (setBackingScaleFactorCallback):
 793         (LayoutTestController::staticFunctions):
 794         * DumpRenderTree/LayoutTestController.h:
 795         (LayoutTestController):
 796         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 797         (LayoutTestController::setBackingScaleFactor):
 798         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 799         (LayoutTestController::setBackingScaleFactor):
 800         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 801         (LayoutTestController::setBackingScaleFactor):
 802         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 803         (LayoutTestController::setBackingScaleFactor):
 804         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 805         (LayoutTestController::setBackingScaleFactor):
 806         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 807         (LayoutTestController::setBackingScaleFactor):
 808         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 809         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 810         (WTR::InjectedBundle::didReceiveMessage):
 811         (WTR::InjectedBundle::postSetBackingScaleFactor):
 812         (WTR):
 813         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 814         (InjectedBundle):
 815         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 816         (WTR::LayoutTestController::setBackingScaleFactor):
 817         (WTR):
 818         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
 819         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 820         (LayoutTestController):
 821         * WebKitTestRunner/TestInvocation.cpp:
 822         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 823
 824 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
 825
 826         REGRESSION(r120546): It made 3 webkitpy tests fail
 827         https://bugs.webkit.org/show_bug.cgi?id=89332
 828
 829         Reviewed by Adam Barth.
 830
 831         Update the BaselineOptimizer unittest after r120546.
 832
 833         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 834         (BaselineOptimizerTest.test_no_add_mac_future):
 835         (BaselineOptimizerTest.test_mac_future):
 836         (BaselineOptimizerTest.test_complex_shadowing):
 837
 838 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
 839
 840         new-run-webkit-tests output gets confused when logging
 841         https://bugs.webkit.org/show_bug.cgi?id=63793
 842
 843         Reviewed by Adam Barth.
 844
 845         Ship all of the log messages generated in the worker back
 846         to the manager; this allows the messages to be properly
 847         serialized to stderr and for the meter to flush its output correctly.
 848
 849         Note however that this will likely result in messages to be
 850         logged out of order between workers; I'm not sure that there's
 851         an easy way to fix this short of buffering a potentially
 852         unbounded amount of data. It might be better to just log through
 853         stderr unless we're in 'metering' mode, but it's also worth
 854         noting that we already get messages out of order through stderr
 855         on Windows.
 856
 857         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 858         (Manager.handle_done):
 859         (Manager.handle_finished_test):
 860         (Manager._log_messages):
 861         * Scripts/webkitpy/layout_tests/controllers/worker.py:
 862         (Worker.__init__):
 863         (Worker._set_up_logging):
 864         (Worker.run):
 865         (Worker._run_test):
 866         (Worker.cleanup):
 867         (Worker.run_single_test):
 868         (_WorkerLogHandler):
 869         (_WorkerLogHandler.__init__):
 870         (_WorkerLogHandler.emit):
 871         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
 872         (MeteredStream.write):
 873         (MeteredStream.writeln):
 874         * Scripts/webkitpy/layout_tests/views/printing.py:
 875         (Printer.writeln):
 876
 877 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
 878
 879         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
 880         https://bugs.webkit.org/show_bug.cgi?id=89362
 881
 882         Reviewed by Simon Fraser.
 883
 884         Replace white spaces, braces and dots in the builder name with underscores. This
 885         way the JQuery tabs will be properly matched with the according container.
 886
 887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
 888
 889 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
 890
 891         nrwt: metered output doesn't handle ^C cleanly
 892         https://bugs.webkit.org/show_bug.cgi?id=89249
 893
 894         Reviewed by Tony Chang.
 895
 896         If you ctrl-c a running nrwt (w/o --verbose), then all but
 897         two characters of the last update are erased, and then we print
 898         "interrupted, exiting" as an update, which itself then gets
 899         erased. Fix this so that we flush the meter (making the last
 900         update persistent, so that we print the ^C for a visual clue),
 901         print the interrupt message, and move on ...
 902
 903         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 904         (Manager._run_tests):
 905         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
 906         (MeteredStream.flush):
 907         * Scripts/webkitpy/layout_tests/views/printing.py:
 908         (Printer._write):
 909         (Printer):
 910         (Printer.flush):
 911
 912 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
 913
 914         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
 915         https://bugs.webkit.org/show_bug.cgi?id=89228
 916
 917         Reviewed by Tony Chang.
 918
 919         * DumpRenderTree/chromium/LayoutTestController.cpp:
 920         * DumpRenderTree/chromium/TestShellAndroid.cpp:
 921
 922 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
 923
 924         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
 925         https://bugs.webkit.org/show_bug.cgi?id=89226
 926
 927         Reviewed by Martin Robinson.
 928
 929         Implement increment() and decrement() functions in term of the AtkValue interface,
 930         instead of using DumpRenderTreeSupportGtk helper class.
 931
 932         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 933         (AccessibilityUIElement::intValue):
 934         (AccessibilityUIElement::minValue):
 935         (AccessibilityUIElement::maxValue):
 936         (alterCurrentValue):
 937         (AccessibilityUIElement::increment):
 938         (AccessibilityUIElement::decrement):
 939
 940 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
 941
 942         garden-o-matic 'Results' panel is broken for the Apple platform
 943         https://bugs.webkit.org/show_bug.cgi?id=89310
 944
 945         Reviewed by Adam Barth.
 946
 947         For platforms that don't use accumulated build directories on the server,
 948         carry along buildLocation data with buildInfo, so that we know where to
 949         look for the test results files for a given test.
 950
 951         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
 952         it now returns an array of objects with buildNumber, revision and url info.
 953
 954         Fixed results.fetchResultsURLs() to use this data to find results.
 955
 956         Fixed the results display to not scroll when you click on a test to see the results.
 957         Made the h3s look less ugly
 958
 959         Don't try to show the flakiness dashboard for the Apple platform.
 960
 961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
 962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
 964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
 965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
 966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
 967         (.results-view .top-panel):
 968         (.results-view h3):
 969
 970 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
 971
 972         Make garden-o-matic work for the Apple Mac port
 973         https://bugs.webkit.org/show_bug.cgi?id=84642
 974
 975         Reviewed by Adam Barth.
 976
 977         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
 978         educating the scripts in various ways:
 979         * Wrap up platform-related differences in config.kPlatforms[]
 980         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
 981         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
 982           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
 983           recent build with valid results.
 984         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
 985           try to test a build that has already been deleted). Make walkHistory() more robust here.
 986         * webkit.org uses differently named test result directories, that include the SVN revision as
 987           well as the build number. That forces us to fetch more build info before we can get the
 988           result directory URL.
 989         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
 990           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
 991           dirs.
 992         * Various URLs differ between webkit.org and chromium.org
 993         * Better UI for the failures info, so that some info is visible even when not hovered.
 994
 995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
 997         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
 998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
 999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1011         (ol.notifications>li table.failures):
1012         (ol.notifications>li:hover table.failures):
1013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1014         (#onebar #platform-picker):
1015         * Scripts/webkitpy/layout_tests/port/builders.py:
1016
1017 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1018
1019         Unreviewed, rolling out r120536.
1020         http://trac.webkit.org/changeset/120536
1021         https://bugs.webkit.org/show_bug.cgi?id=89296
1022
1023         Does not compile on chromium-linux (Requested by abarth on
1024         #webkit).
1025
1026         * DumpRenderTree/chromium/LayoutTestController.cpp:
1027         (LayoutTestController::reset):
1028         (LayoutTestController::setTextSubpixelPositioning):
1029         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1030
1031 2012-06-16  Adam Barth  <abarth@webkit.org>
1032
1033         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1034         https://bugs.webkit.org/show_bug.cgi?id=89274
1035
1036         Reviewed by Levi Weintraub.
1037
1038         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1039         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1040         tested by API-level tests.
1041
1042         * DumpRenderTree/LayoutTestController.cpp:
1043         (LayoutTestController::staticFunctions):
1044         * DumpRenderTree/LayoutTestController.h:
1045         (LayoutTestController):
1046         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1047         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1048         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1049         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1050         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1051         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1052         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1053         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1054         (WTR::InjectedBundle::didReceiveMessage):
1055         (WTR):
1056         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1057         (InjectedBundle):
1058         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1059         (WTR):
1060         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1061         (LayoutTestController):
1062         * WebKitTestRunner/TestInvocation.cpp:
1063         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1064
1065 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1066
1067         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1068         https://bugs.webkit.org/show_bug.cgi?id=89228
1069
1070         Reviewed by Tony Chang.
1071
1072         * DumpRenderTree/chromium/LayoutTestController.cpp:
1073         (LayoutTestController::reset):
1074         (LayoutTestController::setTextSubpixelPositioning):
1075         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1076
1077 2012-06-15  Adam Barth  <abarth@webkit.org>
1078
1079         garden-o-matic's results.js should use RequestTracker
1080         https://bugs.webkit.org/show_bug.cgi?id=89257
1081
1082         Reviewed by Dimitri Glazkov.
1083
1084         We wrote results.js before we recognized the RequestTracker pattern.
1085         This patch replaces the manual implementations of RequestTracker with
1086         the real deal.
1087
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1089
1090 2012-06-15  Darin Adler  <darin@apple.com>
1091
1092         * Scripts/webkitpy/bindings: Added property svn:ignore.
1093
1094 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1095
1096         Unreviewed, rolling out r120511.
1097         http://trac.webkit.org/changeset/120511
1098         https://bugs.webkit.org/show_bug.cgi?id=89255
1099
1100         Breaks at least Android builder (Requested by wangxianzhu on
1101         #webkit).
1102
1103         * DumpRenderTree/chromium/LayoutTestController.cpp:
1104         (LayoutTestController::reset):
1105         (LayoutTestController::setTextSubpixelPositioning):
1106
1107 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1108
1109         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1110         https://bugs.webkit.org/show_bug.cgi?id=89228
1111
1112         Reviewed by Tony Chang.
1113
1114         * DumpRenderTree/chromium/LayoutTestController.cpp:
1115         (LayoutTestController::reset):
1116         (LayoutTestController::setTextSubpixelPositioning):
1117
1118 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1119
1120         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1121         https://bugs.webkit.org/show_bug.cgi?id=89135
1122
1123         Re-land change in r120370 with fix in
1124         PortFactory.get_from_builder_name() that changes BuilderOptions
1125         to an actual optparse.Values object.
1126
1127         * Scripts/webkitpy/layout_tests/port/base.py:
1128         (Port.__init__):
1129         (Port.get_option):
1130         (Port.set_option_default):
1131         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1132         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1133         * Scripts/webkitpy/layout_tests/port/factory.py:
1134         (_builder_options):
1135         (PortFactory.get_from_builder_name):
1136         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1137         (FactoryTest.test_get_from_builder_name):
1138         * Scripts/webkitpy/style/checkers/test_expectations.py:
1139         (TestExpectationsChecker._determine_port_from_expectations_path):
1140         * Scripts/webkitpy/tool/mocktool.py:
1141         (MockOptions.ensure_value):
1142
1143 2012-06-15  Bill Budge  <bbudge@chromium.org>
1144
1145         Add bbudge@chromium.org to committers.py
1146
1147         Unreviewed.
1148
1149         * Scripts/webkitpy/common/config/committers.py:
1150
1151 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1152
1153         Unreviewed style fix after r120351.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1156         (body.interface):
1157
1158 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1159
1160         master.cfg cleanup, remove unnecessary workaround
1161         https://bugs.webkit.org/show_bug.cgi?id=88994
1162
1163         Reviewed by Lucas Forschler.
1164
1165         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1166         (loadBuilderConfig):
1167
1168 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1169
1170         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1171         https://bugs.webkit.org/show_bug.cgi?id=88581
1172
1173         Reviewed by Adam Barth.
1174
1175         Make sure we only optimize the suffixes we rebaselined during
1176         rebaseline-expectations, and not all suffixes for a test.
1177         While optimizing is somewhere between harmless and good, it's also confusing :)
1178
1179         * Scripts/webkitpy/tool/commands/rebaseline.py:
1180         (RebaselineExpectations._rebaseline_port):
1181         (RebaselineExpectations.execute):
1182         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1183
1184 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1185
1186         Update builder.html template for newer buildmaster
1187         https://bugs.webkit.org/show_bug.cgi?id=89207
1188
1189         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1190
1191         Reviewed by Zoltan Herczeg.
1192
1193         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1194
1195 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1196
1197         Add ForceScheduler to build.webkit.org
1198         https://bugs.webkit.org/show_bug.cgi?id=88982
1199
1200         Reviewed by Ryosuke Niwa.
1201
1202         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1203         (loadBuilderConfig):
1204
1205 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1206
1207         [EFL][WK2] Add title support to Ewk_View
1208         https://bugs.webkit.org/show_bug.cgi?id=89095
1209
1210         Reviewed by Kenneth Rohde Christiansen.
1211
1212         Update the MiniBrowser so it listens for the "title,change"
1213         signal on the view and keeps the browser window title
1214         up-to-date.
1215
1216         * MiniBrowser/efl/main.c:
1217         (on_title_changed):
1218         (browserCreate):
1219
1220 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1221
1222         [WK2][EFL] Implement navigation back/forward in Ewk_View
1223         https://bugs.webkit.org/show_bug.cgi?id=89173
1224
1225         Reviewed by Kenneth Rohde Christiansen.
1226
1227         Implement navigation back / forward in MiniBrowser. Use
1228         'F1' to navigate back and 'F2' to navigate forward.
1229
1230         * MiniBrowser/efl/main.c:
1231         (on_key_down):
1232
1233 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1234
1235         [EFL] EFL's LayoutTestController does not support titleTextDirection
1236         https://bugs.webkit.org/show_bug.cgi?id=86475
1237
1238         Reviewed by Hajime Morita.
1239
1240         Add titleTextDirection getter and setter to LayoutTestController and
1241         expose its value to JavaScript.
1242         Update the titleTextDirection value from EFL's "title,changed"
1243         callback in DumpRenderTree.
1244
1245         * DumpRenderTree/LayoutTestController.cpp:
1246         (LayoutTestController::LayoutTestController):
1247         (getTitleTextDirectionCallback):
1248         (LayoutTestController::staticValues):
1249         * DumpRenderTree/LayoutTestController.h:
1250         (LayoutTestController::titleTextDirection):
1251         (LayoutTestController::setTitleTextDirection):
1252         (LayoutTestController):
1253         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1254         (DumpRenderTreeChrome::onFrameTitleChanged):
1255
1256 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1257
1258         [EFL][WK2] Implement reload / stop in Ewk_View
1259         https://bugs.webkit.org/show_bug.cgi?id=89168
1260
1261         Reviewed by Kenneth Rohde Christiansen.
1262
1263         Implement view reload / stop loading in MiniBrowser.
1264         Use 'F5' for reload and 'F6' for stopping the load.
1265
1266         * MiniBrowser/efl/main.c:
1267         (on_key_down):
1268         (browserCreate):
1269
1270 2012-06-15  Hironori Bono  <hbono@chromium.org>
1271
1272         Allow platforms to choose whether to remove markers on editing
1273         https://bugs.webkit.org/show_bug.cgi?id=88838
1274
1275         Reviewed by Hajime Morita.
1276
1277         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1278         run grammar tests.
1279
1280         * DumpRenderTree/chromium/WebViewHost.cpp:
1281         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1282         * DumpRenderTree/chromium/WebViewHost.h:
1283         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1284
1285 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1286
1287         Unreviewed, rolling out r120370.
1288         http://trac.webkit.org/changeset/120370
1289         https://bugs.webkit.org/show_bug.cgi?id=89183
1290
1291         Broke webkit-patch rebaseline (Requested by zdobersek on
1292         #webkit).
1293
1294         * Scripts/webkitpy/layout_tests/port/base.py:
1295         (DummyOptions):
1296         (DummyOptions.__init__):
1297         (DummyOptions.__init__.this):
1298         (Port.__init__):
1299         (Port.get_option):
1300         (Port.set_option_default):
1301         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1302         (ChromiumWinTest.RegisterCygwinOption):
1303         (ChromiumWinTest.RegisterCygwinOption.__init__):
1304         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1305         * Scripts/webkitpy/style/checkers/test_expectations.py:
1306         (TestExpectationsChecker._determine_port_from_expectations_path):
1307         * Scripts/webkitpy/tool/mocktool.py:
1308         (MockOptions.update):
1309
1310 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1311
1312         [Chromium-Android] Initialize font rendering in DumpRenderTree
1313         https://bugs.webkit.org/show_bug.cgi?id=89133
1314
1315         Reviewed by Adam Barth.
1316
1317         * DumpRenderTree/chromium/LayoutTestController.cpp:
1318         (LayoutTestController::reset):
1319         (LayoutTestController::setTextSubpixelPositioning):
1320         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1321         (platformInit):
1322
1323 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
1324
1325         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
1326         https://bugs.webkit.org/show_bug.cgi?id=88622
1327
1328         Reviewed by Philippe Normand.
1329
1330         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
1331         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1332
1333 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1334
1335         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
1336         https://bugs.webkit.org/show_bug.cgi?id=89124
1337
1338         Reviewed by Dirk Pranke.
1339
1340         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1341         (ChromiumAndroidDriver._start):
1342         (ChromiumAndroidDriver):
1343         (ChromiumAndroidDriver._start_once):
1344
1345 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
1346
1347         Update webpagereplay to 1.1.2
1348         https://bugs.webkit.org/show_bug.cgi?id=89118
1349
1350         This includes the following patch which avoids pkg_resources import errors:
1351         http://code.google.com/p/web-page-replay/source/detail?r=476
1352
1353         Reviewed by Dirk Pranke.
1354
1355         * Scripts/webkitpy/thirdparty/__init__.py:
1356         (AutoinstallImportHook._install_webpagereplay):
1357
1358 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
1359
1360         Get rid of FAIL test expectation
1361         https://bugs.webkit.org/show_bug.cgi?id=89137
1362
1363         Reviewed by Dirk Pranke.
1364
1365         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1366         (ResultSummaryTest.test_summarized_results_wontfix):
1367         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1368         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1369         (JSONLayoutResultsGenerator):
1370         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1371         (result_was_expected):
1372         (suffixes_for_expectations):
1373         (TestExpectationsModel._add_test):
1374         (TestExpectations):
1375         (TestExpectations.get_rebaselining_failures):
1376         (TestExpectations.remove_configuration_from_test):
1377         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1378         (FunctionsTest.test_result_was_expected):
1379         (FunctionsTest.test_suffixes_for_expectations):
1380         (TestExpectationSerializerTests.test_parsed_expectations_string):
1381         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1382         (test_test_expectations):
1383         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1384         (TestExpectationsTestCase.test_valid_expectations):
1385
1386 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1387
1388         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1389         https://bugs.webkit.org/show_bug.cgi?id=89135
1390
1391         Reviewed by Ryosuke Niwa.
1392
1393         This patch is just some minor cleanup and simplification. There
1394         should be no functional changes here.
1395
1396         * Scripts/webkitpy/layout_tests/port/base.py:
1397         (Port.__init__):
1398         (Port.get_option):
1399         (Port.set_option_default):
1400         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1401         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1402         * Scripts/webkitpy/style/checkers/test_expectations.py:
1403         (TestExpectationsChecker._determine_port_from_expectations_path):
1404         * Scripts/webkitpy/tool/mocktool.py:
1405         (MockOptions.ensure_value):
1406
1407 2012-06-14  Ian Vollick  <vollick@chromium.org>
1408
1409         [chromium] Certain settings in CCSettings could be global
1410         https://bugs.webkit.org/show_bug.cgi?id=88384
1411
1412         Reviewed by James Robinson.
1413
1414         * DumpRenderTree/chromium/TestShell.cpp:
1415         (TestShell::TestShell):
1416         (TestShell::resetWebSettings):
1417         (TestShell::setPerTilePaintingEnabled):
1418         * DumpRenderTree/chromium/TestShell.h:
1419         (TestShell):
1420         * DumpRenderTree/chromium/WebPreferences.cpp:
1421         (WebPreferences::reset):
1422         (WebPreferences::applyTo):
1423         * DumpRenderTree/chromium/WebPreferences.h:
1424         (WebPreferences):
1425
1426 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1427
1428         Unreviewed, rolling out r120352.
1429         http://trac.webkit.org/changeset/120352
1430         https://bugs.webkit.org/show_bug.cgi?id=89120
1431
1432         It seems something is still wrong with it :/ (Requested by
1433         Ossy on #webkit).
1434
1435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1436         (Factory.__init__):
1437         (BuildFactory.__init__):
1438         (TestFactory.__init__):
1439         (BuildAndTestFactory.__init__):
1440         (BuildAndPerfTestFactory.__init__):
1441         (BuildAndPerfTestWebKit2Factory.__init__):
1442         (DownloadAndPerfTestFactory.__init__):
1443         (DownloadAndPerfTestWebKit2Factory.__init__):
1444
1445 2012-06-14  Jia Pu  <jpu@apple.com>
1446
1447         Mark text with text alternative with blue underline.
1448         https://bugs.webkit.org/show_bug.cgi?id=83047
1449
1450         Reviewed by NOBODY Enrica Casucci.
1451
1452         * DumpRenderTree/mac/TextInputController.m:
1453         (+[TextInputController isSelectorExcludedFromWebScript:]):
1454         (+[TextInputController webScriptNameForSelector:]):
1455         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1456
1457 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1458
1459         Unreviewed, rolling out r120353.
1460         http://trac.webkit.org/changeset/120353
1461         https://bugs.webkit.org/show_bug.cgi?id=89119
1462
1463         It seems we still need this workaround (Requested by Ossy on
1464         #webkit).
1465
1466         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1467         (loadBuilderConfig):
1468
1469 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1470
1471         master.cfg cleanup, remove unnecessary workaround
1472         https://bugs.webkit.org/show_bug.cgi?id=88994
1473
1474         Reviewed by Lucas Forschler.
1475
1476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1477         (loadBuilderConfig):
1478
1479 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1480
1481         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
1482         https://bugs.webkit.org/show_bug.cgi?id=89001
1483
1484         Reviewed by Lucas Forschler.
1485
1486         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1487         (Factory.__init__):
1488         (BuildFactory.__init__):
1489         (TestFactory.__init__):
1490         (BuildAndTestFactory.__init__):
1491         (BuildAndPerfTestFactory.__init__):
1492         (BuildAndPerfTestWebKit2Factory.__init__):
1493         (DownloadAndPerfTestFactory.__init__):
1494         (DownloadAndPerfTestWebKit2Factory.__init__):
1495
1496 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1497
1498         Unhide login form on the build.webkit.org
1499         https://bugs.webkit.org/show_bug.cgi?id=88981
1500
1501         Reviewed by Lucas Forschler.
1502
1503         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1504
1505 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
1506
1507         [Gtk] Add support in DumpRenderTree for tracking repaints
1508         https://bugs.webkit.org/show_bug.cgi?id=87658
1509
1510         Reviewed by Martin Robinson.
1511
1512         Reimplement the displayWebView method in DumpRenderTree - force a
1513         repaint before starting tracking repaints and resetting them.
1514
1515         When gathering pixel output from a web view, if tracking repaints,
1516         paint an overlay over the output with the overlay being clear in the
1517         areas where the repaints occurred.
1518
1519         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1520         (displayWebView):
1521         (resetDefaultsToConsistentValues):
1522         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1523         (paintOverlay):
1524         (fillRepaintOverlayIntoContext):
1525         (createBitmapContextFromWebView):
1526
1527 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1528
1529         new-run-webkit-tests doesn't find similar platform tests for a keyword
1530         https://bugs.webkit.org/show_bug.cgi?id=37956
1531
1532         Reviewed by Ryosuke Niwa.
1533
1534         This patches adds support for NRWT so that if you type
1535         "new-run-webkit-tests foo" it will run all the tests in foo as
1536         well as platform/foo for all of the platforms that are normally
1537         searched (this only applies to directories, not to individual tests).
1538
1539         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1540         (Manager.collect_tests):
1541         * Scripts/webkitpy/layout_tests/port/base.py:
1542         (Port.tests):
1543         (Port):
1544         (Port._expanded_paths):
1545         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1546         (MainTest.test_no_http_tests):
1547         (MainTest):
1548         (MainTest.test_platform_tests_are_found):
1549
1550 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1551
1552         NRWT should honor --skipped=[default|ignore|only], like ORWT does
1553         https://bugs.webkit.org/show_bug.cgi?id=66308
1554
1555         Reviewed by Ryosuke Niwa.
1556
1557         This patch adds support for ORWT's --skipped=(default|ignore|only)
1558         flag and cleans up the interaction between that and --ignore.
1559
1560         Individual tests (but not directories) explicitly listed on the
1561         command line will always be run regardless of what is passed
1562         for --skipped and --ignore.
1563
1564         This patch also changes the "found" and "running" log messages
1565         since it wasn't clear how the skipped tests were included in those numbers.
1566
1567         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1568         (Manager.__init__):
1569         (Manager.collect_tests):
1570         (Manager.prepare_lists_and_print_output):
1571         * Scripts/webkitpy/layout_tests/port/test.py:
1572         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1573         (_set_up_derived_options):
1574         (parse_args):
1575         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1576         (MainTest.test_ignore_flag):
1577         (MainTest):
1578         (MainTest.test_skipped_flag):
1579
1580 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1581
1582         new-run-webkit-websocketserver must handle TLS related arguments
1583         https://bugs.webkit.org/show_bug.cgi?id=89079
1584
1585         Reviewed by Dirk Pranke.
1586
1587         PyWebSocket class must accept private_key, certificate, and
1588         ca_certificate arguments and pass them to launching pywebsocket.
1589         Also add ca_certificate handling to new-run-webkit-websocketserver.
1590
1591         * Scripts/new-run-webkit-websocketserver:
1592         (main):
1593         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1594         (PyWebSocket.__init__):
1595         (PyWebSocket._prepare_config):
1596
1597 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1598
1599         Unreviewed. Update my email.
1600
1601         * Scripts/webkitpy/common/config/committers.py:
1602
1603 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1604
1605         Update pywebsocket to 0.7.6 from 0.7.4
1606         https://bugs.webkit.org/show_bug.cgi?id=88975
1607
1608         Reviewed by Kent Tamura.
1609
1610         This new version of pywebsocket introduce following features.
1611          - Allow handlers to send a close frame with empty body in response of
1612              a client initiated closing handshake
1613          - Implement perframe compression extension
1614          - Support client certificate authentication
1615
1616         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
1617         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1618         (_create_control_frame):
1619         (Stream._receive_frame):
1620         (Stream.send_message):
1621         (Stream.receive_message):
1622         (Stream._send_closing_handshake):
1623         (Stream.close_connection):
1624         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1625         (ExtensionParsingException):
1626         (ExtensionParsingException.__init__):
1627         (_parse_extension_param):
1628         (_parse_extension):
1629         (parse_extensions):
1630         (format_extension):
1631         (format_extensions):
1632         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1633         (_parse_compression_method):
1634         (_create_accepted_method_desc):
1635         (PerFrameCompressionExtensionProcessor):
1636         (PerFrameCompressionExtensionProcessor.__init__):
1637         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
1638         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
1639         (PerFrameCompressionExtensionProcessor.get_extension_response):
1640         (PerFrameCompressionExtensionProcessor.setup_stream_options):
1641         (PerFrameCompressionExtensionProcessor.get_compression_processor):
1642         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1643         (parse_token_list):
1644         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1645         (Handshaker._parse_extensions):
1646         (Handshaker._send_handshake):
1647         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1648         (WebSocketServer._create_sockets):
1649         (_get_logger_from_class):
1650         (_configure_logging):
1651         (_build_option_parser):
1652         (_main.if):
1653         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1654         (RepeatedXorMasker.mask):
1655
1656 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
1657
1658         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
1659
1660         Reviewed by Noam Rosenthal.
1661
1662         * qmake/mkspecs/features/features.prf:
1663
1664 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
1665
1666         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
1667         https://bugs.webkit.org/show_bug.cgi?id=88399
1668
1669         Reviewed by Kenneth Rohde Christiansen.
1670
1671         Update initialization of WKPageLoaderClient.
1672
1673         * MiniBrowser/mac/BrowserWindowController.m:
1674         (-[BrowserWindowController awakeFromNib]):
1675         * WebKitTestRunner/TestController.cpp:
1676         (WTR::TestController::initialize):
1677
1678 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1679
1680         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
1681         https://bugs.webkit.org/show_bug.cgi?id=84577
1682
1683         Reviewed by Ryosuke Niwa.
1684
1685         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
1686         LayoutTestController.
1687
1688         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1689         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1690
1691 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
1692
1693         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
1694         https://bugs.webkit.org/show_bug.cgi?id=88340
1695
1696         Reviewed by Kenneth Rohde Christiansen.
1697
1698         Update initialization of WKPageLoaderClient.
1699
1700         * MiniBrowser/mac/BrowserWindowController.m:
1701         (-[BrowserWindowController awakeFromNib]):
1702         * WebKitTestRunner/TestController.cpp:
1703         (WTR::TestController::initialize):
1704
1705 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1706
1707         Unreviewed, rolling out r120268.
1708         http://trac.webkit.org/changeset/120268
1709         https://bugs.webkit.org/show_bug.cgi?id=89060
1710
1711         WebCompositor::setPerTilePaintingEnabled hits an assertion in
1712         DEBUG (Requested by dominicc|work on #webkit).
1713
1714         * DumpRenderTree/chromium/WebPreferences.cpp:
1715         (WebPreferences::applyTo):
1716
1717 2012-06-13  Tim Horton  <timothy_horton@apple.com>
1718
1719         REGRESSION (r120252): run-webkit-tests on Mac fails
1720         https://bugs.webkit.org/show_bug.cgi?id=89057
1721
1722         Reviewed by Dan Bernstein.
1723
1724         get_option will happily return None (the default only kicks in if
1725         the option is actually *not set*). We should instead check get_option's
1726         return value and default to "x86_64" architecture ourselves.
1727
1728         * Scripts/webkitpy/layout_tests/port/mac.py:
1729         (MacPort.__init__):
1730
1731 2012-06-13  Ian Vollick  <vollick@chromium.org>
1732
1733         [chromium] Certain settings in CCSettings could be global
1734         https://bugs.webkit.org/show_bug.cgi?id=88384
1735
1736         Reviewed by James Robinson.
1737
1738         * DumpRenderTree/chromium/WebPreferences.cpp:
1739         (WebPreferences::applyTo):
1740
1741 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1742
1743         new-run-webkit-tests does not support --32-bit like ORWT did
1744         https://bugs.webkit.org/show_bug.cgi?id=71634
1745
1746         Reviewed by Ojan Vafai.
1747
1748         This patch adds support for 32-bit apple mac builds, adding the
1749         --32-bit flag for compatibility with ORWT and fixing the port
1750         architecture() definition to actually return the correct values.
1751
1752         * Scripts/webkitpy/layout_tests/port/apple.py:
1753         (ApplePort._generate_all_test_configurations):
1754         * Scripts/webkitpy/layout_tests/port/factory.py:
1755         (port_options):
1756         * Scripts/webkitpy/layout_tests/port/mac.py:
1757         (MacPort):
1758         (MacPort.__init__):
1759         (MacPort._build_driver_flags):
1760         (MacPort.setup_environ_for_server):
1761         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1762         (test_sample_process_throws_exception):
1763         (test_32bit):
1764         (test_32bit.run_script):
1765         (test_64bit):
1766         (test_64bit.run_script):
1767         * Scripts/webkitpy/layout_tests/port/webkit.py:
1768         (WebKitPort._build_driver):
1769         (WebKitPort._build_driver_flags):
1770         * Scripts/webkitpy/layout_tests/port/win.py:
1771         (WinPort):
1772
1773 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
1774
1775         Remove webkitpy code to support legacy test_expectations.txt files
1776         https://bugs.webkit.org/show_bug.cgi?id=89038
1777
1778         Reviewed by Dirk Pranke.
1779
1780         * Scripts/webkitpy/layout_tests/port/base.py:
1781         (Port.path_to_test_expectations_file):
1782         (Port.expectations_dict):
1783         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1784         (PortTest.test_uses_test_expectations_file):
1785         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1786         (WebKitPortTest.test_path_to_test_expectations_file):
1787         (test_test_expectations):
1788         * Scripts/webkitpy/style/checker.py:
1789         (CheckerDispatcher.should_skip_without_warning):
1790         (CheckerDispatcher._create_checker):
1791         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1792         (TestExpectationsTestCase._expect_port_for_expectations_path):
1793         * Scripts/webkitpy/tool/steps/commit.py:
1794         (Commit._check_test_expectations):
1795         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1796         (CommitTest.test_check_test_expectations):
1797
1798 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1799
1800         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
1801         https://bugs.webkit.org/show_bug.cgi?id=88948
1802
1803         Reviewed by Ojan Vafai.
1804
1805         In the final patch of this run, we remove the
1806         test_expectations() and test_expectation_overrides() methods
1807         from the Port class - callers must now use just
1808         expectations_dict().
1809
1810         Note that support for the cascade in new-run-webkit-tests is
1811         complete but only Chromium uses it; webkit-patch
1812         rebaseline-expectations still does not support updating entries
1813         in any file other than the first expectations file, however.
1814
1815         * Scripts/webkitpy/layout_tests/port/base.py:
1816         (Port.path_to_test_expectations_file):
1817         (Port.uses_test_expectations_file):
1818         (Port.expectations_files):
1819         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1820         (PortTest.test_additional_expectations):
1821         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1822         (ChromiumPortTest.test_expectations_files):
1823         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1824         (TestGoogleChromePort.test_get_google_chrome_port):
1825         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1826         (test_test_expectations):
1827         (test_legacy_test_expectations):
1828
1829 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1830
1831         nrwt: implement the actual cascade of TestExpectations
1832         https://bugs.webkit.org/show_bug.cgi?id=88947
1833
1834         Reviewed by Ojan Vafai.
1835
1836         This change implements the actual cascade by removing the
1837         concept of 'overrides' from the TestExpectations object and
1838         parsing each file separately.
1839
1840         There is an actual semantic change in this patch, in that
1841         setting an expectation on a directory in one file will override
1842         the expectations on any individual tests set in prior files. The
1843         test_overrides__directory() unit test verifies this.
1844
1845         Otherwise, this patch mostly consists of deleting code :).
1846
1847         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1848         (TestExpectationsModel.__init__):
1849         (TestExpectationsModel.add_expectation_line):
1850         (TestExpectationsModel._add_test):
1851         (TestExpectationsModel._already_seen_better_match):
1852         (TestExpectations.__init__):
1853         (TestExpectations._add_expectations):
1854         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1855         (test_overrides__directory):
1856
1857 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1858
1859         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
1860         https://bugs.webkit.org/show_bug.cgi?id=88946
1861
1862         Reviewed by Ojan Vafai.
1863
1864         In preparation for fully supporting cascading expectations files
1865         and removing the 'overrides' concept.
1866
1867         There should be no functional changes in this patch.
1868
1869         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1870         (ManagerTest.test_update_summary_with_result):
1871         (ResultSummaryTest.get_result_summary):
1872         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1873         (TestExpectations.__init__):
1874         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1875         (parse_exp):
1876         (SkippedTests.check):
1877         (RemoveConfigurationsTest.test_remove):
1878         (test_remove_line):
1879         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1880         (LintTest.test_all_configurations.FakePort.__init__):
1881         (LintTest.test_all_configurations.FakePort.expectations_dict):
1882         (LintTest.test_lint_test_files__errors):
1883         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1884         (test_overrides_are_included_correctly):
1885
1886 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1887
1888         webkitpy: rework the TestExpectations style checker in preparation for the cascade
1889         https://bugs.webkit.org/show_bug.cgi?id=88945
1890
1891         Reviewed by Ojan Vafai.
1892
1893         This patch changes the style checker to call the
1894         TestExpectations parser directly and be oblivious as to what the
1895         port's actual expectations are.
1896
1897         * Scripts/webkitpy/style/checkers/test_expectations.py:
1898         (TestExpectationsChecker.__init__):
1899         (TestExpectationsChecker.check_test_expectations):
1900
1901 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1902
1903         nrwt: restructure the port classes to handle multiple expectations files
1904         https://bugs.webkit.org/show_bug.cgi?id=88944
1905
1906         Reviewed by Ojan Vafai.
1907
1908         This patch restructures the Port classes so that each port
1909         returns a list of TestExpectations files to be used (in a new, public,
1910         expectations_files() method), and the base implementation rolls them
1911         up into the ordered expectations_dict(), which becomes a public
1912         method.
1913
1914         port.path_to_test_expectations_file(), port.test_expectations(),
1915         and port.test_expectations_overrides() are then reimplemented as
1916         wrappers around port.expectations_dict().
1917         port.test_expectations() and port.test_expectations_overrides()
1918         will eventually be removed when the cascade is fully completed,
1919         and port.path_to_test_expectations_file() will be removed when
1920         the rebaselining tool supports the cascade
1921         (expectations_files() may also become private at that point).
1922
1923         There should be no functional changes in this patch, but a bunch
1924         of custom logic gets deleted!
1925
1926         * Scripts/webkitpy/layout_tests/port/base.py:
1927         (Port.expectations_dict):
1928         (Port):
1929         (Port.expectations_files):
1930         (Port.test_expectations):
1931         (Port.test_expectations_overrides):
1932         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1933         (PortTest.test_additional_expectations):
1934         (PortTest.test_uses_test_expectations_file):
1935         * Scripts/webkitpy/layout_tests/port/chromium.py:
1936         (ChromiumPort.all_baseline_variants):
1937         (ChromiumPort.expectations_files):
1938         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1939         (ChromiumPortTest.test_overrides_and_builder_names):
1940         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1941         (_expectations_files):
1942         (GoogleChromeLinux32Port.expectations_files):
1943         (GoogleChromeLinux64Port.expectations_files):
1944         (GoogleChromeMacPort.expectations_files):
1945         (GoogleChromeWinPort.expectations_files):
1946         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1947         (TestGoogleChromePort._verify_expectations_overrides):
1948         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1949         (PortTestCase.test_expectations_ordering):
1950         * Scripts/webkitpy/layout_tests/port/webkit.py:
1951         (WebKitPort._skipped_file_search_paths):
1952         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1953         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1954         (test_rebaseline_updates_expectations_file):
1955         (test_rebaseline_does_not_include_overrides):
1956         (test_rebaseline_expectations):
1957         (test_overrides_are_included_correctly):
1958
1959 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
1960
1961         [WinCairo] Update URL of WinCairoRequirements.zip download.
1962         https://bugs.webkit.org/show_bug.cgi?id=89009
1963
1964         Reviewed by Martin Robinson.
1965
1966         * Tools/Scripts/update-webkit-dependency: Put fallback code
1967         to download a "last update" time from servers that don't properly
1968         report Last-Modified in their HTTP header.
1969         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
1970         for the WinCairo build requirements bundle.
1971
1972 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1973
1974         nrwt: preliminary cleanup before supporting cascading expectations files
1975         https://bugs.webkit.org/show_bug.cgi?id=88942
1976
1977         Reviewed by Ojan Vafai.
1978
1979         This change just prepares the TestExpectations parser to get filenames
1980         along with the expectations, and improves the warning messages so that
1981         they contain the filenames along with the line numbers.
1982
1983         There should be no functional changes in this patch.
1984
1985         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1986         (TestExpectationEditorTests.make_parsed_expectation_lines):
1987         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1988         (TestExpectationParser.parse):
1989         (TestExpectationParser.expectation_for_skipped_test):
1990         (TestExpectationParser._tokenize):
1991         (TestExpectationParser._tokenize_list):
1992         (TestExpectationLine):
1993         (TestExpectationsModel.__init__):
1994         (TestExpectationsModel._already_seen_better_match):
1995         (TestExpectations.__init__):
1996         (TestExpectations._shorten_filename):
1997         (TestExpectations._report_warnings):
1998         (TestExpectations._add_skipped_tests):
1999         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2000         (TestExpectationParserTests._tokenize):
2001         (TestExpectationParserTests.test_tokenize_blank):
2002         (TestExpectationParserTests.test_tokenize_missing_colon):
2003         (TestExpectationParserTests.test_tokenize_extra_colon):
2004         (TestExpectationParserTests.test_tokenize_empty_comment):
2005         (TestExpectationParserTests.test_tokenize_comment):
2006         (TestExpectationParserTests.test_tokenize_missing_equal):
2007         (TestExpectationParserTests.test_tokenize_extra_equal):
2008         (TestExpectationParserTests.test_tokenize_valid):
2009         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2010         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2011         (TestExpectationParserTests.test_parse_empty_string):
2012         (TestExpectationSerializerTests._tokenize):
2013         (TestExpectationSerializerTests.assert_round_trip):
2014         (TestExpectationSerializerTests.assert_list_round_trip):
2015         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2016         (GardeningExpectationsUpdater.update_expectations):
2017
2018 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2019
2020         [Gtk] Enable link prefetch support in the developer builds
2021         https://bugs.webkit.org/show_bug.cgi?id=89011
2022
2023         Reviewed by Martin Robinson.
2024
2025         Enable the link prefetch support for Gtk by default in developer
2026         builds.
2027
2028         * Scripts/webkitperl/FeatureList.pm:
2029
2030 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2031
2032         Update buildbot master in autoinstaller to match build.webkit.org
2033         https://bugs.webkit.org/show_bug.cgi?id=88992
2034
2035         Reviewed by Adam Barth.
2036
2037         * Scripts/webkitpy/thirdparty/__init__.py:
2038         (AutoinstallImportHook._install_buildbot):
2039
2040 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2041
2042         Unreviewed, rolling out r120209.
2043         http://trac.webkit.org/changeset/120209
2044         https://bugs.webkit.org/show_bug.cgi?id=89007
2045
2046         Broke the WebKit2 mac build. (Requested by andersca on
2047         #webkit).
2048
2049         * MiniBrowser/mac/BrowserWindowController.m:
2050         (-[BrowserWindowController awakeFromNib]):
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::initialize):
2053
2054 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2055
2056         check-webkit-style needs to respect Qt API coding style
2057         https://bugs.webkit.org/show_bug.cgi?id=88995
2058
2059         Reviewed by Csaba Osztrogonác.
2060
2061         Add -whitespace/declaration exception to Qt API files.
2062
2063         * Scripts/webkitpy/style/checker.py:
2064
2065 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2066
2067         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2068         https://bugs.webkit.org/show_bug.cgi?id=88340
2069
2070         Reviewed by Kenneth Rohde Christiansen.
2071
2072         Update initialization of WKPageLoaderClient.
2073
2074         * MiniBrowser/mac/BrowserWindowController.m:
2075         (-[BrowserWindowController awakeFromNib]):
2076         * WebKitTestRunner/TestController.cpp:
2077         (WTR::TestController::initialize):
2078
2079 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2080
2081         [Qt] Handle multiple held buttons in touch mocking.
2082         https://bugs.webkit.org/show_bug.cgi?id=88865
2083
2084         Reviewed by Kenneth Rohde Christiansen.
2085
2086         Add handling for multiple held mouse-buttons in the appropiate places.
2087         To do this last-pos and start-pos are now also read from the last recorded
2088         touch-point instead from object-global variables.
2089
2090         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2091         (MiniBrowserApplication::notify):
2092         (MiniBrowserApplication::updateTouchPoint):
2093         * MiniBrowser/qt/MiniBrowserApplication.h:
2094         (MiniBrowserApplication):
2095
2096 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2097
2098         [Qt] Make it possible to disable -Werror in production builds
2099
2100         Reviewed by Tor Arne Vestbø.
2101
2102         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2103         something qt5.git's qtwebkit.pri will soon do.
2104
2105         * qmake/mkspecs/features/unix/default_post.prf:
2106
2107 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2108
2109         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2110         https://bugs.webkit.org/show_bug.cgi?id=85790
2111
2112         Reviewed by Gustavo Noronha Silva.
2113
2114         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2115         code in webkitdirs.pm.
2116
2117         * Scripts/webkitdirs.pm:
2118         (jhbuildConfigurationChanged):
2119         (saveJhbuildMd5):
2120         (cleanJhbuild):
2121         (buildAutotoolsProject):
2122         (generateBuildSystemFromCMakeProject):
2123
2124 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2125
2126         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2127         https://bugs.webkit.org/show_bug.cgi?id=88763
2128
2129         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2130         extension.
2131
2132         Reviewed by Simon Hausmann.
2133
2134         * qmake/config.tests/libzlib: Added.
2135         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2136         (main):
2137         * qmake/config.tests/libzlib/libzlib.pro: Added.
2138         * qmake/mkspecs/features/features.prf:
2139         * qmake/sync.profile:
2140
2141 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2142
2143         [BlackBerry] Enable MEDIA_STREAM by default
2144         https://bugs.webkit.org/show_bug.cgi?id=88849
2145
2146         Reviewed by Antonio Gomes.
2147
2148         * Scripts/webkitperl/FeatureList.pm:
2149
2150 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2151
2152         Prevent stderr output from messing up detection of build path
2153
2154         https://bugs.webkit.org/show_bug.cgi?id=88075
2155
2156         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2157         end up as the build path when calling out to webkit-build-directory.
2158
2159         Reviewed by Ojan Vafai.
2160
2161         * Scripts/webkitpy/layout_tests/port/config.py:
2162         (Config.build_directory):
2163
2164 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2165
2166         Update the builder name for Apple Lion builders.
2167
2168         * Scripts/webkitpy/layout_tests/port/builders.py:
2169
2170 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2171
2172         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2173         https://bugs.webkit.org/show_bug.cgi?id=88874
2174
2175         Reviewed by Simon Hausmann.
2176
2177         Rename main.cpp in QtTestBrowser because on Windows
2178         it conflicts with main.cpp from DumpRenderTree.
2179
2180         * QtTestBrowser/QtTestBrowser.pro:
2181         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2182         (launcherMain):
2183         (LauncherApplication):
2184         (LauncherApplication::urls):
2185         (LauncherApplication::isRobotized):
2186         (LauncherApplication::robotTimeout):
2187         (LauncherApplication::robotExtraTime):
2188         (LauncherApplication::applyDefaultSettings):
2189         (LauncherApplication::LauncherApplication):
2190         (requiresGraphicsView):
2191         (LauncherApplication::handleUserOptions):
2192         (main):
2193
2194 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2195
2196         Wrap bot types inside ().
2197         https://bugs.webkit.org/show_bug.cgi?id=88893
2198
2199         Reviewed by Stephanie Lewis.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/config.json:
2202
2203 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2204
2205         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2206         https://bugs.webkit.org/show_bug.cgi?id=88760
2207
2208         Reviewed by Gustavo Noronha Silva.
2209
2210         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2211         to v2.33.2 for both GTK and EFL ports.
2212
2213         * efl/jhbuild.modules:
2214         * gtk/jhbuild.modules:
2215
2216 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2217
2218         [EFL] Enable SHADOW_DOM flag
2219         https://bugs.webkit.org/show_bug.cgi?id=87732
2220
2221         Reviewed by Kentaro Hara.
2222
2223         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2224         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2225         SHADOW_DOM by default in DRT.
2226         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2227         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2228         Chromium and Mac ports.
2229         (drtViewAdd):
2230         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2231         at compile time for EFL port.
2232
2233 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2234
2235         WinLauncher should show loading errors
2236         https://bugs.webkit.org/show_bug.cgi?id=80760
2237
2238         Reviewed by Brent Fulgham.
2239
2240         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2241         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2242         * WinLauncher/WinLauncher.h:
2243         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2244         (WinLauncherWebHost):
2245
2246 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2247
2248         [EFL][WK2] Add MiniBrowserEfl.
2249         https://bugs.webkit.org/show_bug.cgi?id=61850
2250
2251         Reviewed by Chang Shu.
2252
2253         Implement MiniBrowser for EFL.
2254
2255         * CMakeLists.txt:
2256         * MiniBrowser/efl/CMakeLists.txt: Added.
2257         * MiniBrowser/efl/main.c: Added.
2258         (_MiniBrowser):
2259         (main_signal_exit):
2260         (on_ecore_evas_resize):
2261         (browserCreate):
2262         (main):
2263
2264 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2265
2266         Unreviewed. Update my email address in committers.py.
2267
2268         * Scripts/webkitpy/common/config/committers.py:
2269
2270 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2271
2272         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2273         https://bugs.webkit.org/show_bug.cgi?id=84707
2274
2275         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2276         use_lib64 variable is preconfigured to True by jhbuild.
2277
2278         Reviewed by Dirk Pranke.
2279
2280         * efl/jhbuildrc:
2281
2282 2012-06-12  Dana Jansens  <danakj@chromium.org>
2283
2284         Add zlieber@chromium.org to contributors list
2285         https://bugs.webkit.org/show_bug.cgi?id=88904
2286
2287         Unreviewed.
2288
2289         * Scripts/webkitpy/common/config/committers.py:
2290
2291 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2292
2293         Rename Apple bots to a standard convention.
2294         https://bugs.webkit.org/show_bug.cgi?id=88893
2295
2296         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
2297
2298         Reviewed by Simon Fraser.
2299
2300         * BuildSlaveSupport/build.webkit.org-config/config.json:
2301
2302 2012-06-12  Mike West  <mkwst@chromium.org>
2303
2304         Make document.documentURI readonly from JavaScript
2305         https://bugs.webkit.org/show_bug.cgi?id=65187
2306
2307         Reviewed by Alexey Proskuryakov.
2308
2309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
2311         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
2312         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
2313         (TestWebKitAPI):
2314         (TestWebKitAPI::TEST):
2315
2316 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2317
2318         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
2319         https://bugs.webkit.org/show_bug.cgi?id=88715
2320
2321         Reviewed by Noam Rosenthal.
2322
2323         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
2324
2325         * Scripts/webkitperl/FeatureList.pm:
2326
2327 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2328
2329         [Qt] Fix -Werror for the buildbots
2330         https://bugs.webkit.org/show_bug.cgi?id=88223
2331
2332         Rubber-stamped by Tor Arne Vestbø.
2333
2334         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
2335
2336         * qmake/mkspecs/features/unix/default_post.prf:
2337
2338 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
2339
2340         [REGRESSION][WTR] Build fail with werror after r120054
2341         https://bugs.webkit.org/show_bug.cgi?id=88862
2342
2343         Reviewed by Csaba Osztrogonác.
2344
2345         Some static helpers become unused after counterValueForElementById
2346         has moved to Internals. Let's remove them.
2347
2348         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2349         (WTR):
2350
2351 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2352
2353         [Qt] Slave losts cause build break on bots
2354         https://bugs.webkit.org/show_bug.cgi?id=38980
2355
2356         Minor fix after r59261.
2357
2358         Reviewed by Tor Arne Vestbø.
2359
2360         * Scripts/build-webkit:
2361         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
2362
2363 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2364
2365         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
2366         https://bugs.webkit.org/show_bug.cgi?id=84406
2367
2368         Reviewed by Hajime Morita.
2369
2370         Move the counterValueForElementById from LayoutTestCotroller to Internals and
2371         remove the old platform specific implementations as it exclusively tests WebCore functionality.
2372
2373         * DumpRenderTree/LayoutTestController.cpp:
2374         (LayoutTestController::staticFunctions):
2375         * DumpRenderTree/LayoutTestController.h:
2376         (LayoutTestController):
2377         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2378         * DumpRenderTree/chromium/LayoutTestController.cpp:
2379         (LayoutTestController::LayoutTestController):
2380         (LayoutTestController::setPOSIXLocale):
2381         * DumpRenderTree/chromium/LayoutTestController.h:
2382         (LayoutTestController):
2383         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2384         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2385         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2386         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2387         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2388         (LayoutTestController):
2389         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2390         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2391         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2392         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2393         (WTR):
2394         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2395         (LayoutTestController):
2396
2397 2012-06-11  Hans Wennborg  <hans@chromium.org>
2398
2399         Speech JavaScript API: Make SpeechRecognitionError an Event
2400         https://bugs.webkit.org/show_bug.cgi?id=88784
2401
2402         Reviewed by Adam Barth.
2403
2404         Make it possible to have MockWebSpeechRecognizer fire error events.
2405
2406         * DumpRenderTree/chromium/LayoutTestController.cpp:
2407         (LayoutTestController::LayoutTestController):
2408         (LayoutTestController::setMockSpeechRecognitionError):
2409         * DumpRenderTree/chromium/LayoutTestController.h:
2410         (LayoutTestController):
2411         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2412         (WebKit):
2413         (ErrorTask):
2414         (WebKit::ErrorTask::ErrorTask):
2415         (MockWebSpeechRecognizer::addMockResult):
2416         (MockWebSpeechRecognizer::setError):
2417         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2418         (MockWebSpeechRecognizer):
2419
2420 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2421
2422         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
2423         https://bugs.webkit.org/show_bug.cgi?id=88836
2424
2425         Reviewed by Dirk Pranke.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2429
2430 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
2431
2432         [EFL] Remove CMakeCache.txt before building
2433         https://bugs.webkit.org/show_bug.cgi?id=88717
2434
2435         Reviewed by Antonio Gomes.
2436
2437         Remove CMake cache file before every build to avoid using outdated
2438         build flags when new features get enabled. This will avoid unexpected
2439         failures on the bots due to outdated build flags.
2440
2441         * Scripts/webkitdirs.pm:
2442         (generateBuildSystemFromCMakeProject):
2443
2444 2012-06-11  Vincent Scheib  <scheib@chromium.org>
2445
2446         Add new Pointer Lock spec attribute webkitPointerLockElement.
2447         https://bugs.webkit.org/show_bug.cgi?id=88799
2448
2449         Reviewed by Dimitri Glazkov.
2450
2451         Part of a series of refactoring changes to update pointer lock API to
2452         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
2453
2454         New attribute webkitPointerLockElement added. Follow up patches
2455         will remove the previous isLocked attribute. Tests updated to use
2456         the new attribute.
2457
2458         WebViewHost logic required modification to correctly repond to
2459         a lock, unlock, pointerLockElement call series. Specifically,
2460         unlocking must be queued after a lock command is issued always
2461         as the lock state may not be set yet with a lock request in flight.
2462
2463         * DumpRenderTree/chromium/WebViewHost.cpp:
2464         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
2465         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
2466
2467 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
2468
2469         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
2470         https://bugs.webkit.org/show_bug.cgi?id=88804
2471
2472         Reviewed by Tony Chang.
2473
2474         Protect box-decoration-break behind a feature flag enabled by default.
2475
2476         * Scripts/webkitperl/FeatureList.pm:
2477         * qmake/mkspecs/features/features.pri:
2478
2479 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2480
2481         [CMAKE][EFL] Remove duplicated executable output path
2482         https://bugs.webkit.org/show_bug.cgi?id=88765
2483
2484         Reviewed by Daniel Bates.
2485
2486         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
2487         need to define again because it is already defined in top-level CMake file.
2488
2489         * DumpRenderTree/efl/CMakeLists.txt:
2490         * EWebLauncher/CMakeLists.txt:
2491
2492 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2493
2494         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
2495         https://bugs.webkit.org/show_bug.cgi?id=88816
2496
2497         Reviewed by Dirk Pranke.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2500         Expose a way to clear AsynchronousCaches.
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2503         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
2504
2505 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
2506
2507         nrwt exits early too frequently
2508         https://bugs.webkit.org/show_bug.cgi?id=73843
2509
2510         Reviewed by Ryosuke Niwa.
2511
2512         Change the defaults for new-run-webkit-tests for both
2513         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
2514         to zero (i.e., we will never exit early by default).
2515
2516         If people want their buildbots to exit early it is their
2517         responsibility to update their buildbot configs appropriately.
2518
2519         Note that we have tests that ensure that these flags work for
2520         non-zero numbers, but we don't have tests that either test the
2521         default or ensure that zero means "run all of the tests". I
2522         think that's okay but can add tests if others disagree.
2523
2524         Also note that it looks like no changes on the build.webkit.org
2525         master.cfg are necessary; all of the bots seem to be using the
2526         RunWebKitTests wrapper which is already setting the flags. There
2527         is a NewRunWebKitTests wrapper, but that looks to be unused; I
2528         will delete that in a separate patch.
2529
2530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2531         (parse_args):
2532
2533 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2534
2535         [EFL] [DRT] Reset CacheModel before running each test
2536         https://bugs.webkit.org/show_bug.cgi?id=87534
2537
2538         Reviewed by Gustavo Noronha Silva.
2539
2540         Reset cache model to default before running each test to fix some
2541         flaky tests on EFL build bots. Also fix case value in setCacheModel.
2542
2543         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2544         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2545         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2546         (LayoutTestController::setCacheModel):
2547
2548 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2549
2550         [GTK] Memory leaks in DRT EventSender.cpp
2551         https://bugs.webkit.org/show_bug.cgi?id=88774
2552
2553         Reviewed by Martin Robinson.
2554
2555         Fix a few possible memory leaks in EventSender code.
2556
2557         * DumpRenderTree/gtk/EventSender.cpp:
2558         (contextClickCallback): Free the event returned by gdk_event_new().
2559         (mouseDownCallback): Ditto.
2560         (mouseUpCallback): Ditto.
2561
2562 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2563
2564         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
2565         https://bugs.webkit.org/show_bug.cgi?id=88661
2566
2567         Reviewed by Dirk Pranke.
2568
2569         Pass string length explicitly when creating String object from
2570         non-null-terminated UChar* returned by characters().
2571
2572         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2573         (LayoutTestController::pathToLocalResource):
2574
2575 2012-06-11  David Dorwin  <ddorwin@chromium.org>
2576
2577         [chromium] Provide access to the WebPlugin created by the helper plugin widget
2578         https://bugs.webkit.org/show_bug.cgi?id=88028
2579
2580         Reviewed by Adam Barth.
2581
2582         Added isPlaceholder() to WebPlugin.
2583
2584         * DumpRenderTree/chromium/TestWebPlugin.h:
2585         (TestWebPlugin::isPlaceholder):
2586
2587 2012-06-11  Tony Chang  <tony@chromium.org>
2588
2589         rebaseline from garden-o-matic leaves N processes each time it is run
2590         https://bugs.webkit.org/show_bug.cgi?id=88586
2591
2592         Reviewed by Dirk Pranke.
2593
2594         This appears to only be a problem on python 2.7. Maybe a bug causing
2595         pools to not be garbage collected?
2596
2597         * Scripts/webkitpy/common/system/executive.py:
2598         (Executive.run_in_parallel): close() and join() the process pool.
2599         * Scripts/webkitpy/common/system/executive_unittest.py:
2600         (ExecutiveTest.test_run_in_parallel):
2601
2602 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
2603
2604         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
2605         https://bugs.webkit.org/show_bug.cgi?id=87841
2606
2607         Reviewed by Simon Hausmann.
2608
2609         * qmake/config.tests/libwebp/libwebp.cpp: Added.
2610         (main):
2611         * qmake/config.tests/libwebp/libwebp.pro: Added.
2612         * qmake/sync.profile:
2613
2614 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2615
2616         Expose layoutTestController as testRunner
2617         https://bugs.webkit.org/show_bug.cgi?id=88210
2618
2619         Reviewed by Darin Adler.
2620
2621         * DumpRenderTree/LayoutTestController.cpp:
2622         (LayoutTestController::makeWindowObject):
2623         * DumpRenderTree/chromium/TestShell.cpp:
2624         (TestShell::bindJSObjectsToWindow):
2625         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2626         (WebCore::DumpRenderTree::initJSObjects):
2627         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2628         (WTR::LayoutTestController::makeWindowObject):
2629
2630 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
2631
2632         [Chromium] Remove JavaScriptCore dependencies from gyp
2633         https://bugs.webkit.org/show_bug.cgi?id=88510
2634
2635         Reviewed by Adam Barth.
2636
2637         Chromium doesn't support JSC any more and there doesn't seem to be
2638         a strong interest in using GYP as the common build system in other
2639         ports.
2640
2641         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2642         * Scripts/generate-project-files: Removed.
2643
2644 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
2645
2646         Add UNDO_MANAGER flag
2647         https://bugs.webkit.org/show_bug.cgi?id=87908
2648
2649         Reviewed by Tony Chang.
2650
2651         * Scripts/webkitperl/FeatureList.pm:
2652         * qmake/mkspecs/features/features.pri:
2653
2654 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2655
2656         webkit-patch land-safely should set cq? if the patch author is not in committers.py
2657         https://bugs.webkit.org/show_bug.cgi?id=88689
2658
2659         Reviewed by Dirk Pranke.
2660
2661         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
2662         in committers.py or the contributor cannot commit. If anything, the contributor can still
2663         set cq+ on thier patches manually so I don't think this will be an issue for people who
2664         don't list their Bugzille email on committers.py.
2665
2666         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2667         (Bugzilla._commit_queue_flag):
2668         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2669         (test_commit_queue_flag):
2670         (test_commit_queue_flag.assert_commit_queue_flag):
2671
2672 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
2673
2674         remove obsolete NewRunWebKitTests buildbot master factory classes
2675         https://bugs.webkit.org/show_bug.cgi?id=88693
2676
2677         Reviewed by Ryosuke Niwa.
2678
2679         I believe these aren't used any more ...
2680
2681         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2682         (RunWebKitTests.getText2):
2683         (BuildAndTestLeaksFactory):
2684
2685 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2686
2687         [Chromium-Android] Build DumpRenderTree with Android SDK
2688         https://bugs.webkit.org/show_bug.cgi?id=88598
2689
2690         Change WebKit side of DRT related code according to some recent changes at chromium side.
2691
2692         Reviewed by Adam Barth.
2693
2694         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2695         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2696         (ChromiumAndroidPort.__init__):
2697         (ChromiumAndroidPort._path_to_driver):
2698
2699 2012-06-08  Wei James  <james.wei@intel.com>
2700
2701         Add app_abi option for DumpRenderTree_apk
2702         https://bugs.webkit.org/show_bug.cgi?id=88626
2703
2704         Reviewed by Adam Barth.
2705
2706         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2707
2708 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2709
2710         [GTK] Add API to get the library version to WebKit2 GTK+
2711         https://bugs.webkit.org/show_bug.cgi?id=88426
2712
2713         Reviewed by Martin Robinson.
2714
2715         * gtk/generate-gtkdoc:
2716         (get_webkit2_options): Add built sources to the list of files, but
2717         ignore enum types and marshallers.
2718
2719 2012-06-07  Vincent Scheib  <scheib@chromium.org>
2720
2721         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
2722         https://bugs.webkit.org/show_bug.cgi?id=88604
2723
2724         Reviewed by Kent Tamura.
2725
2726         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
2727         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
2728
2729         * DumpRenderTree/chromium/WebViewHost.cpp:
2730         (WebViewHost::requestPointerUnlock):
2731
2732 2012-06-08  Hans Wennborg  <hans@chromium.org>
2733
2734         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
2735         https://bugs.webkit.org/show_bug.cgi?id=87976
2736
2737         Reviewed by Kent Tamura.
2738
2739         Provide a mock implementation of WebSpeechRecognizer for
2740         DumpRenderTree. This will allow better testing of the API via layout
2741         tests.
2742
2743         * DumpRenderTree/DumpRenderTree.gypi:
2744         * DumpRenderTree/chromium/LayoutTestController.cpp:
2745         (LayoutTestController::LayoutTestController):
2746         (LayoutTestController::addMockSpeechRecognitionResult):
2747         * DumpRenderTree/chromium/LayoutTestController.h:
2748         (LayoutTestController):
2749         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
2750         (MockWebSpeechRecognizer::create):
2751         (MockWebSpeechRecognizer::start):
2752         (MockWebSpeechRecognizer::stop):
2753         (MockWebSpeechRecognizer::abort):
2754         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2755         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2756         (MockWebSpeechRecognizer::ResultTask::runIfValid):
2757         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
2758         (WebKit):
2759         (MockWebSpeechRecognizer):
2760         (MockWebSpeechRecognizer::addMockResult):
2761         (MockWebSpeechRecognizer::taskList):
2762         (ClientCallTask):
2763         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
2764         (ResultTask):
2765         (MockWebSpeechRecognizer::ResultTask::ResultTask):
2766         (NoMatchTask):
2767         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
2768         * DumpRenderTree/chromium/WebViewHost.cpp:
2769         (WebViewHost::speechRecognizer):
2770         * DumpRenderTree/chromium/WebViewHost.h:
2771         (WebViewHost):
2772         (WebViewHost::mockSpeechRecognizer):
2773
2774 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
2775
2776         check-webkit-style needs to be taught about <public/Foo.h>
2777         https://bugs.webkit.org/show_bug.cgi?id=88524
2778
2779         Reviewed by David Levin.
2780
2781         * Scripts/webkitpy/style/checkers/cpp.py:
2782         (_classify_include):
2783         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2784         (OrderOfIncludesTest.test_public_primary_header):
2785         (OrderOfIncludesTest.test_classify_include):
2786
2787 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
2788
2789         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2790         https://bugs.webkit.org/show_bug.cgi?id=67255
2791
2792         Reviewed by Dirk Pranke.
2793
2794         Implement pathToLocalResource to redirect file:///tmp URL's to
2795         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
2796         LayoutTests sub-directory of the WebKit source tree.
2797
2798         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2799         (LayoutTestController::pathToLocalResource):
2800
2801 2012-06-07  Tony Payne  <tpayne@chromium.org>
2802
2803         [chromium] Allow LayoutTests under new git workflow
2804         https://bugs.webkit.org/show_bug.cgi?id=88575
2805
2806         On Windows, chromium indirects through git.bat. Adds the same hack that
2807         is currently used for discovering svn.bat to support the new git
2808         workflow.
2809
2810         Reviewed by Dirk Pranke.
2811
2812         * Scripts/webkitpy/common/checkout/scm/git.py:
2813         (Git): Replaces all hard-coded references to 'git' with the class
2814         variable executable_name.
2815         (Git._check_git_architecture):
2816         (Git.in_working_directory):
2817         (Git.find_checkout_root):
2818         (Git.read_git_config):
2819         (Git.discard_local_commits):
2820         (Git.local_commits):
2821         (Git.working_directory_is_clean):
2822         (Git.clean_working_directory):
2823         (Git.status_command):
2824         (Git.add_list):
2825         (Git.delete_list):
2826         (Git.exists):
2827         (Git._current_branch):
2828         (Git.changed_files):
2829         (Git._changes_files_for_commit):
2830         (Git.revisions_changing_file):
2831         (Git.conflicted_files):
2832         (Git.svn_revision):
2833         (Git.create_patch):
2834         (Git._run_git_svn_find_rev):
2835         (Git.contents_at_revision):
2836         (Git.diff_for_file):
2837         (Git.show_head):
2838         (Git.committer_email_for_revision):
2839         (Git.apply_reverse_diff):
2840         (Git.revert_files):
2841         (Git.commit_with_message):
2842         (Git._commit_on_branch):
2843         (Git.svn_commit_log):
2844         (Git.last_svn_commit_log):
2845         (Git.svn_blame):
2846         (Git._branch_ref_exists):
2847         (Git.delete_branch):
2848         (Git.remote_merge_base):
2849         (Git.commit_locally_with_message):
2850         (Git.push_local_commits_to_server):
2851         (Git.commit_ids_from_commitish_arguments):
2852         (Git.commit_message_for_local_commit):
2853         (Git.files_changed_summary_for_commit):
2854         * Scripts/webkitpy/common/host.py:
2855         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
2856         that duplicates the logic in the existing 'svn.bat' hack.
2857
2858 2012-06-07  Ojan Vafai  <ojan@chromium.org>
2859
2860         Style build architectures like build versions for non-layout test failures
2861         https://bugs.webkit.org/show_bug.cgi?id=88590
2862
2863         Reviewed by Tony Chang.
2864
2865         Since we show the list of failing tests after the architecture, we want the
2866         buildtype and architecture to be grouped together visually.
2867
2868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2869         (.effects a.failing-builder>span.architecture):
2870
2871 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2872
2873         [Chromium] Remove header dependency of ImageDiff to WTF
2874         https://bugs.webkit.org/show_bug.cgi?id=88422
2875
2876         Reviewed by Ryosuke Niwa.
2877
2878         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2879         * DumpRenderTree/chromium/ImageDiff.cpp:
2880         (untestedCompareImages):
2881
2882 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
2883
2884         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
2885         https://bugs.webkit.org/show_bug.cgi?id=88491
2886
2887         Reviewed by Dirk Pranke.
2888
2889         DRT should enable WebAudio when WebAudio feature is enabled,
2890         so that the WebAudio feature could be tested by the Layouttest.
2891
2892         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
2893         (LayoutTestController::overridePreference):
2894
2895 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
2896
2897         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
2898         https://bugs.webkit.org/show_bug.cgi?id=88581
2899
2900         Reviewed by Ojan Vafai.
2901
2902         webkit-paptch rebaseline-expectations was ignoring what the
2903         expected results for a test were and pulling down all the result
2904         files from a bot. This could lead to us pulling down old,
2905         incorrect .txt or .png files. With this patch we will now only
2906         pull down expectations of the appropriate file types (so an
2907         IMAGE failure will only pull the png and not the txt file).
2908
2909         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2910         (has_pixel_failures):
2911         (suffixes_for_expectations):
2912         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2913         (FunctionsTest.test_suffixes_for_expectations):
2914         * Scripts/webkitpy/tool/commands/rebaseline.py:
2915         (AbstractRebaseliningCommand.__init__):
2916         (RebaselineExpectations._is_supported_port):
2917         (RebaselineExpectations._update_expectations_file):
2918         (RebaselineExpectations._tests_to_rebaseline):
2919         (RebaselineExpectations._rebaseline_port):
2920         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2921         (test_overrides_are_included_correctly):
2922
2923 2012-06-07  Ojan Vafai  <ojan@chromium.org>
2924
2925         Fix recent null pointer error regression in the flakiness dashboard
2926         https://bugs.webkit.org/show_bug.cgi?id=88573
2927
2928         Reviewed by Dirk Pranke.
2929
2930         * TestResultServer/static-dashboards/builders.js:
2931         (requestBuilderList):
2932         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2933
2934 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
2935
2936         Add Konrad Piascik to committers.py
2937         https://bugs.webkit.org/show_bug.cgi?id=88560
2938
2939         Unreviewed.
2940
2941         * Scripts/webkitpy/common/config/committers.py:
2942
2943 2012-06-07  Tony Chang  <tony@chromium.org>
2944
2945         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
2946         https://bugs.webkit.org/show_bug.cgi?id=77368
2947
2948         Reviewed by Ojan Vafai.
2949
2950         It doesn't look like we ever get a rect with width or height of 0.
2951         I ran css1, css2.1, fast/forms, and tables without any crashes.
2952
2953         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2954         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
2955
2956 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
2957
2958         run-webkit-tests --lint-test-files gives an error when run on linux
2959         https://bugs.webkit.org/show_bug.cgi?id=88551
2960
2961         Reviewed by Ojan Vafai.
2962
2963         We weren't mapping the expectations properly for the
2964         google-chrome ports.
2965
2966         * Scripts/webkitpy/layout_tests/port/base.py:
2967         (Port.path_to_test_expectations_file):
2968         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2969         (TestGoogleChromePort.test_path_to_expectations):
2970
2971 2012-06-07  Daniel Erat  <derat@chromium.org>
2972
2973         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
2974         https://bugs.webkit.org/show_bug.cgi?id=88263
2975
2976         Reviewed by Tony Chang.
2977
2978         * DumpRenderTree/chromium/LayoutTestController.cpp:
2979         (LayoutTestController::LayoutTestController):
2980         (LayoutTestController::reset):
2981         (LayoutTestController::setTextSubpixelPositioning):
2982         * DumpRenderTree/chromium/LayoutTestController.h:
2983         (LayoutTestController):
2984         * DumpRenderTree/chromium/fonts.conf:
2985
2986 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
2987
2988         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
2989         https://bugs.webkit.org/show_bug.cgi?id=88060
2990
2991         Reviewed by Martin Robinson.
2992
2993         Spin the main loop before acquiring the pixel content. This ensures things
2994         like late size allocations are finished before calling gtk_widget_draw,
2995         avoiding assertions and subsequent empty pixel results.
2996
2997         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2998         (createBitmapContextFromWebView):
2999
3000 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3001
3002         [Qt] Improve the visual of the viewport info box
3003         https://bugs.webkit.org/show_bug.cgi?id=88410
3004
3005         Reviewed by Tor Arne Vestbø.
3006
3007         Improve the visual and make it possible to see the content more easy.
3008
3009         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3010
3011 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
3012
3013         [EFL][WK2] Compile webkit1 and webkit2 by default.
3014         https://bugs.webkit.org/show_bug.cgi?id=85041
3015
3016         Reviewed by Chang Shu.
3017
3018         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
3019         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
3020
3021         * Scripts/build-webkit:
3022
3023 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3024
3025         Unreviewed, rolling out r119662.
3026         http://trac.webkit.org/changeset/119662
3027         https://bugs.webkit.org/show_bug.cgi?id=88487
3028
3029         Broke builds (Requested by rniwa on #webkit).
3030
3031         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3032         * DumpRenderTree/chromium/ImageDiff.cpp:
3033         (untestedCompareImages):
3034
3035 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3036
3037         [Chromium] Remove header dependency of ImageDiff to WTF
3038         https://bugs.webkit.org/show_bug.cgi?id=88422
3039
3040         Reviewed by Adam Barth.
3041
3042         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3043         * DumpRenderTree/chromium/ImageDiff.cpp:
3044         (untestedCompareImages):
3045
3046 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
3047
3048         [WebKit] DeviceOrientation cleanup
3049         https://bugs.webkit.org/show_bug.cgi?id=88406
3050
3051         Reviewed by Kent Tamura.
3052
3053         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
3054
3055         * DumpRenderTree/chromium/LayoutTestController.cpp:
3056         (LayoutTestController::setMockDeviceOrientation):
3057
3058 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3059
3060         webkitpy: add support for an ordered dict of test expectations
3061         https://bugs.webkit.org/show_bug.cgi?id=87802
3062
3063         Reviewed by Ojan Vafai.
3064
3065         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
3066         support a cascaded list of test expectations files. An easy way
3067         to think of this is as an ordered dictionary of name -> contents
3068         for files, where the name is usually a path on disk (I say
3069         usually because we want to support other kinds of expectations
3070         like the compile-time skips for unsupported features in
3071         webkit.py, and we want to continue to support "in-memory" test
3072         expectations that don't require a filesystem).
3073
3074         Conveniently there is an OrderedDict implementation in Python
3075         2.7+ and it is available as a backport, so the first step in
3076         adding this support is to use that implementation. Subsequent
3077         patches will update the test_expectations.py module (and other
3078         callers) to access the dict directly.
3079
3080         This patch just changes the base internal implementation and
3081         provides wrappers for compatibility. The derived ports
3082         (WebKitPort, TestPort, etc.) still need to be updated.
3083
3084         * Scripts/webkitpy/layout_tests/port/base.py:
3085         (Port._expectations_dict):
3086         (Port.test_expectations):
3087         (Port):
3088         (Port._expectations_overrides_dict):
3089         (Port.test_expectations_overrides):
3090         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3091         (PortTestCase.test_expectations_ordering):
3092         (PortTestCase):
3093         (PortTestCase.test_expectations_overrides_ordering):
3094         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
3095         (OrderedDict):
3096         (OrderedDict.__init__):
3097         (OrderedDict.clear):
3098         (OrderedDict.__setitem__):
3099         (OrderedDict.__delitem__):
3100         (OrderedDict.__iter__):
3101         (OrderedDict.__reversed__):
3102         (OrderedDict.popitem):
3103         (OrderedDict.__reduce__):
3104         (OrderedDict.__repr__):
3105         (OrderedDict.copy):
3106         (OrderedDict.fromkeys):
3107
3108 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
3109
3110         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
3111
3112         * gtk/run-api-tests:
3113         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
3114
3115 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3116
3117         nrwt should look in 'out' for binaries on chromium win to support ninja
3118         https://bugs.webkit.org/show_bug.cgi?id=88273
3119
3120         Reviewed by Tony Chang.
3121
3122         This patch standardizes the search algorithm the chromium ports
3123         use to figure out which driver to run. We will look in a
3124         chromium location before a webkit location (e.g., in
3125         Source/WebKit/chromium/out before out/) and we will look in the
3126         "legacy" directory (xcodebuild) before the directory ninja uses
3127         (out).
3128
3129         Unfortunately due to the way the test code is set up testing the
3130         properly requires some duplication of test code. I will fix that
3131         in a followup patch.
3132
3133         * Scripts/webkitpy/layout_tests/port/chromium.py:
3134         (ChromiumPort):
3135         (ChromiumPort._static_build_path):
3136         (ChromiumPort._build_path):
3137         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3138         (ChromiumLinuxPort):
3139         (ChromiumLinuxPort._determine_driver_path_statically):
3140         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3141         (ChromiumLinuxPortTest.test_build_path):
3142         (ChromiumLinuxPortTest):
3143         (ChromiumLinuxPortTest.test_driver_name_option):
3144         (ChromiumLinuxPortTest.path_to_image_diff):
3145         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3146         (ChromiumMacPort):
3147         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3148         (ChromiumMacPortTest.test_build_path):
3149         (ChromiumMacPortTest):
3150         (ChromiumMacPortTest.test_driver_name_option):
3151         (ChromiumMacPortTest.path_to_image_diff):
3152         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3153         (ChromiumPortTest.test_overrides_and_builder_names):
3154         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3155         (ChromiumWinPort):
3156         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3157         (ChromiumWinTest.test_build_path):
3158         (ChromiumWinTest.test_operating_system):
3159         (ChromiumWinTest):
3160         (ChromiumWinTest.test_driver_name_option):
3161         (ChromiumWinPortTest.path_to_image_diff):
3162         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3163         (PortTestCase.assert_build_path):
3164
3165 2012-06-06  Jessie Berlin  <jberlin@apple.com>
3166
3167         Remove very red Windows WebKit2 testers
3168         https://bugs.webkit.org/show_bug.cgi?id=88452
3169
3170         Reviewed by Steve Falkenburg.
3171
3172         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
3173         need to focus on getting the WK1 testers green.
3174
3175         * BuildSlaveSupport/build.webkit.org-config/config.json:
3176
3177 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3178
3179         get rebaselining tools to kinda work with the skia overrides file
3180         https://bugs.webkit.org/show_bug.cgi?id=88456
3181
3182         Reviewed by Ryosuke Niwa.
3183
3184         Update rebaseline-expectations so that we read in the overrides
3185         when looking for tests to rebaseline, but don't read in the
3186         overrides when we are writing the expectations file back out.
3187         This prevents the overrides from getting written into the main
3188         file. This is kind of a hack but will have to do until we
3189         support multiple expectations files properly.
3190
3191         * Scripts/webkitpy/tool/commands/rebaseline.py:
3192         (RebaselineExpectations._expectations):
3193         (RebaselineExpectations._update_expectations_file):
3194         (RebaselineExpectations._tests_to_rebaseline):
3195         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3196         (test_overrides_are_included_correctly):
3197
3198 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3199
3200         webkitpy: two manager_worker_broker_unittest tests are broken
3201         https://bugs.webkit.org/show_bug.cgi?id=88445
3202
3203         Reviewed by Ojan Vafai.
3204
3205         These tests were never updated when we removed the
3206         --worker-model argument, and we were passing 'inline' instead of
3207         1 (for the number of workers) :(. As a result we were creating
3208         multiprocessing queues unnecessarily and that was failing on cygwin.
3209
3210         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3211         (InterfaceTest.test_managerconnection_is_abstract):
3212         (InterfaceTest.test_workerconnection_is_abstract):
3213
3214 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3215
3216         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
3217         https://bugs.webkit.org/show_bug.cgi?id=87406
3218
3219         Reviewed by Dirk Pranke.
3220
3221         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3222         (TestExpectations.__init__):
3223         * Scripts/webkitpy/tool/commands/rebaseline.py:
3224         (RebaselineTest._update_expectations_file):
3225         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3226         (test_rebaseline_does_not_include_overrides):
3227
3228 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3229
3230         webkitpy: perf tests unit tests fail on chromium win
3231         https://bugs.webkit.org/show_bug.cgi?id=88279
3232
3233         Reviewed by Ryosuke Niwa.
3234
3235         I'm seeing weird failures running the unit tests in my win32
3236         checkout, and we don't really expect webpagereplay to work on
3237         win32 anyway, so I'm skipping the import of that module for now
3238         and adding a warning.
3239
3240         * Scripts/run-perf-tests:
3241         * Scripts/webkitpy/performance_tests/perftest.py:
3242
3243 2012-06-06  Yong Li <yoli@rim.com>
3244
3245         Unreviewed. Update my email address in committers.py.
3246
3247         * Scripts/webkitpy/common/config/committers.py:
3248
3249 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
3250
3251         Add Robert Kroeger  to commiters.py
3252         https://bugs.webkit.org/show_bug.cgi?id=88415
3253
3254         Unreviewed.
3255
3256         * Scripts/webkitpy/common/config/committers.py:
3257
3258 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3259
3260         [EFL][DRT] http/tests/globalhistory testcases do not pass
3261         https://bugs.webkit.org/show_bug.cgi?id=82579
3262
3263         Reviewed by Csaba Osztrogonác.
3264
3265         DRT has provided callbacks for ewk_view "global history delegate" signals.
3266
3267         * DumpRenderTree/efl/DumpRenderTree.cpp:
3268         (isGlobalHistoryTest): Aux function to ident global history testcase.
3269         (createLayoutTestController):
3270         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3271         (DumpRenderTreeChrome::createView):
3272         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
3273         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
3274         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
3275         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
3276         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
3277         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3278         (DumpRenderTreeChrome):
3279
3280 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
3281
3282         [Qt] run-qtwebkit-tests hangs with -j1
3283         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
3284         This could happen due to an uncancelled timer after results were returned. This timer was
3285         started only if --timeout was set.
3286         https://bugs.webkit.org/show_bug.cgi?id=85475
3287
3288         Reviewed by Csaba Osztrogonác.
3289
3290         * Scripts/run-qtwebkit-tests:
3291         (run_test):
3292
3293 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
3294
3295         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
3296         https://bugs.webkit.org/show_bug.cgi?id=88327
3297
3298         Reviewed by Kenneth Rohde Christiansen.
3299
3300         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
3301         * MiniBrowser/qt/icons/contents_width.png: Added.
3302         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
3303         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
3304
3305 2012-06-05  Jon Lee  <jonlee@apple.com>
3306
3307         Buildbot fix.
3308
3309         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
3310         in the function. Store in a local variable.
3311         (loadBuilderConfig):
3312
3313 2012-06-05  Jon Lee  <jonlee@apple.com>
3314
3315         Buildbot fix.
3316
3317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3318         (loadBuilderConfig):
3319
3320 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3321
3322         webkitpy: clean up win-specific path handling and tests
3323         https://bugs.webkit.org/show_bug.cgi?id=88281
3324
3325         Reviewed by Adam Barth.
3326
3327         There was a bunch of inconsistent logic for handling path
3328         conversions for win32 and cygwin paths due to us sometimes
3329         looking at sys.platform and sometimes using mock hosts. This
3330         patch cleans everything up so that we are required to pass
3331         PlatformInfo objects to the path module and stop trying to do
3332         different things when running on cygwin or win32 hosts (except
3333         in the path_unittest module itself).
3334
3335         This may slightly reduce test coverage for the win32 code paths
3336         but will be a lot easier to follow and maintain.
3337
3338         * Scripts/webkitpy/common/system/path.py:
3339         (abspath_to_uri):
3340         (_convert_path):
3341         * Scripts/webkitpy/common/system/path_unittest.py:
3342         (AbspathTest.platforminfo):
3343         (AbspathTest.test_abspath_to_uri_cygwin):
3344         (AbspathTest.test_abspath_to_uri_unixy):
3345         (AbspathTest.test_abspath_to_uri_win):
3346         (AbspathTest.test_abspath_to_uri_escaping_unixy):
3347         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
3348         (AbspathTest.test_stop_cygpath_subprocess):
3349         * Scripts/webkitpy/common/system/platforminfo.py:
3350         (PlatformInfo.__init__):
3351         (PlatformInfo.is_cygwin):
3352         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3353         (MockPlatformInfo.is_cygwin):
3354         * Scripts/webkitpy/layout_tests/port/base.py:
3355         (Port.to.show_results_html_file):
3356         * Scripts/webkitpy/layout_tests/port/driver.py:
3357         (Driver.test_to_uri):
3358         (Driver.uri_to_test):
3359         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3360         (DriverTest.test_test_to_uri):
3361         (DriverTest.test_uri_to_test):
3362         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3363         (MockDRTPortTest.make_port):
3364         (MockDRTTest.input_line):
3365         (MockChromiumDRTTest.test_pixeltest__fails):
3366         * Scripts/webkitpy/layout_tests/port/test.py:
3367         * Scripts/webkitpy/layout_tests/port/win.py:
3368         (WinPort.show_results_html_file):
3369         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3370         (MainTest.test_unexpected_failures):
3371         (MainTest.test_results_directory_absolute):
3372         (MainTest.test_results_directory_default):
3373         (MainTest.test_results_directory_relative):
3374
3375 2012-06-05  Jon Lee  <jonlee@apple.com>
3376
3377         Workaround buildbot bug when merging build requests.
3378         https://bugs.webkit.org/show_bug.cgi?id=88158
3379
3380         Reviewed by Mark Rowe.
3381
3382         For expediency, we still want testers to pick the latest build to test, but to ensure
3383         that the builders are reporting the correct revision number, we should let the building bots
3384         run as they normally would. That is, the builder picks the oldest revision, and merges
3385         subsequent requests. Because merged requests get appended to the list of changes for a given
3386         build, the last change in that list is also the latest change. When we used pickLatestBuild
3387         for the builders, this was not the case (it would always report the penultimate change).
3388
3389         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
3392         for all Apple builders.
3393         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
3394         the latest build to run.
3395         (loadBuilderConfig):
3396
3397 2012-06-05  Jessie Berlin  <jberlin@apple.com>
3398
3399         [Win] DumpRenderTree should call resetInternalsObject
3400         https://bugs.webkit.org/show_bug.cgi?id=88346
3401
3402         Reviewed by Simon Fraser.
3403
3404         Invoke it on Windows in the same place it is invoked on Mac.
3405
3406         * DumpRenderTree/win/DumpRenderTree.cpp:
3407         (resetWebViewToConsistentStateBeforeTesting):
3408
3409 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3410
3411         [GTK] Fix two more memory leaks in DRT
3412         https://bugs.webkit.org/show_bug.cgi?id=88255
3413
3414         Reviewed by Martin Robinson.
3415
3416         Fixed memory leaks in GTK's DRT code.
3417
3418         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3419         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
3420         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
3421         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3422         (createBitmapContextFromWebView): Free the cairo surface.
3423
3424 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3425
3426         [Qt] Building when a top directory is named Source
3427         https://bugs.webkit.org/show_bug.cgi?id=77727
3428
3429         Reviewed by Tor Arne Vestbø.
3430
3431         Change regex to only replace the last instance of OUT_PWD.
3432
3433         * qmake/mkspecs/features/default_pre.prf:
3434
3435 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
3436
3437         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
3438         https://bugs.webkit.org/show_bug.cgi?id=73176
3439
3440         Reviewed by Adam Barth.
3441
3442         Two more APIs are added in Custom Scheme Handler specification.
3443         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
3444         One is 'isProtocolHandlerRegistered' to query whether the specific URL
3445         is registered or not.
3446         The other is 'unregisterProtocolHandler' to remove the registered URL.
3447
3448         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
3449
3450 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
3451
3452         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
3453         https://bugs.webkit.org/show_bug.cgi?id=83879
3454
3455         Reviewed by Carlos Garcia Campos.
3456
3457         Make minibrowser connect to the new 'permission requests' signal
3458         to allow users handle the Geolocation permission requests.
3459
3460         * MiniBrowser/gtk/BrowserWindow.c:
3461         (geolocationRequestDialogCallback): Callback for the dialog asking
3462         the user for allowing or not geolocation permission requests.
3463         (webViewDecidePermissionRequest): Launch a dialog to ask the user
3464         whether to allow or deny geolocation permission requests.
3465         (browserWindowConstructed): Connect to 'permission-request' signal.
3466
3467 2012-06-04  Chase Phillips  <cmp@google.com>
3468
3469         Make a builder group support+expect multiple loads.
3470         https://bugs.webkit.org/show_bug.cgi?id=88260
3471
3472         Change BuilderGroup to allow expecting multiple
3473         loads.  This allows merging results for a given set
3474         of builders into one group.
3475
3476         Add a test that verifies that the group count
3477         increments correctly based on successful and failed
3478         list loads.
3479
3480         Reviewed by Ojan Vafai.
3481
3482         * TestResultServer/static-dashboards/builders.js:
3483         (BuilderGroup):
3484         (BuilderGroup.prototype.setbuilder):
3485         (BuilderGroup.prototype.append):
3486         (BuilderGroup.prototype.loaded):
3487         (requestBuilderList.xhr.onload):
3488         (requestBuilderList.xhr.onerror):
3489         (onErrorLoadingBuilderList):
3490         (loadBuildersList):
3491         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3492         (test):
3493         * TestResultServer/static-dashboards/run-unittests.html:
3494
3495 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
3496
3497         Python test fix attempt for Chromium Windows.
3498
3499         * Scripts/webkitpy/layout_tests/port/driver.py:
3500         (Driver.uri_to_test):
3501
3502 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
3503
3504         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
3505         https://bugs.webkit.org/show_bug.cgi?id=88243
3506
3507         Reviewed by Adam Barth.
3508
3509         * qmake/mkspecs/features/features.prf:
3510
3511 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3512
3513         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
3514         https://bugs.webkit.org/show_bug.cgi?id=88280
3515
3516         Unreviewed, build fix.
3517
3518         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3519         (TestServerProcess.test_basic):
3520
3521 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3522
3523         test-webkitpy is hanging under cygwin
3524         https://bugs.webkit.org/show_bug.cgi?id=88269
3525
3526         Reviewed by Ryosuke Niwa.
3527
3528         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
3529         so we need to skip any tests that use it.
3530
3531         * Scripts/webkitpy/common/system/executive.py:
3532         (Executive.run_in_parallel):
3533         * Scripts/webkitpy/common/system/executive_unittest.py:
3534         (ExecutiveTest.test_run_in_parallel):
3535
3536 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3537
3538         test-webkitpy is failing on win32 after r115054
3539         https://bugs.webkit.org/show_bug.cgi?id=88264
3540
3541         Reviewed by Ryosuke Niwa.
3542
3543         The failing http_server test was improperly suppressed (the
3544         tuple was missing a comma, and so wasn't a tuple at all, just a
3545         string) and so we were skipping *all* tests on win32. The right
3546         way to skip a single test is to disable it inside the test
3547         itself.
3548
3549         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3550         (TestHttpServer.test_start_cmd):
3551         * Scripts/webkitpy/test/test_finder.py:
3552         (TestFinder._default_names):
3553         * Scripts/webkitpy/test/main.py:
3554         (Tester.run): Add error message if we don't find any tests to run.
3555         * Scripts/webkitpy/test/main_unittest.py:
3556
3557
3558 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3559
3560         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
3561         https://bugs.webkit.org/show_bug.cgi?id=88215
3562
3563         Reviewed by Martin Robinson.
3564
3565         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
3566         for newly allocated strings.
3567
3568         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3569         (attributeSetToString):
3570         (AccessibilityUIElement::allAttributes):
3571
3572 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3573
3574         [GTK] Memory leaks in DumpRenderTree.cpp
3575         https://bugs.webkit.org/show_bug.cgi?id=88213
3576
3577         Reviewed by Martin Robinson.
3578
3579         Fixed memory leaks in DumpRenderTree.
3580
3581         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3582         (appendString): Accepts const gchar* as the second argument.
3583         (dumpFramesAsText): Free the string returned by g_strdup_printf().
3584         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
3585
3586 2012-06-04  David Dorwin  <ddorwin@chromium.org>
3587
3588         Enable Chromium media player to instantiate a plugin
3589         https://bugs.webkit.org/show_bug.cgi?id=87399
3590
3591         Reviewed by Kent Tamura.
3592
3593         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
3594
3595         * DumpRenderTree/chromium/WebViewHost.cpp:
3596         (WebViewHost::createPopupMenu):
3597
3598 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
3599
3600         [GTK][WK2] Implement geolocation provider for the GTK port
3601         https://bugs.webkit.org/show_bug.cgi?id=83877
3602
3603         Reviewed by Carlos Garcia Campos.
3604
3605         * gtk/generate-gtkdoc:
3606         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
3607
3608 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3609
3610         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
3611         https://bugs.webkit.org/show_bug.cgi?id=87668
3612
3613         Reviewed by Ryosuke Niwa.
3614
3615         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
3616         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
3617         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).
3618
3619         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3620         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3621
3622 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
3623
3624         [EFL] Refactor ewk_view_context_paint code.
3625         https://bugs.webkit.org/show_bug.cgi?id=85588
3626
3627         Reviewed by Hajime Morita.
3628
3629         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
3630
3631 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
3632
3633         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
3634         https://bugs.webkit.org/show_bug.cgi?id=87869
3635
3636         Reviewed by Andreas Kling.
3637
3638         Replace %lld by PRId64 macro to print an int64_t value and silent a
3639         compilation warning on 64-Bit.
3640
3641         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3642         (onExceededApplicationCacheQuota):
3643
3644 2012-06-03  Varun Jain  <varunjain@google.com>
3645
3646         [chromium] Add new gesture type (two finger tap) that triggers context menu.
3647         https://bugs.webkit.org/show_bug.cgi?id=88173
3648
3649         Reviewed by Adam Barth.
3650
3651         * DumpRenderTree/chromium/EventSender.cpp:
3652         (EventSender::EventSender):
3653         (EventSender::gestureTwoFingerTap):
3654         (EventSender::gestureEvent):
3655         * DumpRenderTree/chromium/EventSender.h:
3656         (EventSender):
3657
3658 2012-06-02  Zeno Albisser  <zeno@webkit.org>
3659
3660         Fix and enable WebGL for WebKit2 on Qt.
3661         https://bugs.webkit.org/show_bug.cgi?id=86214
3662
3663         Enable WebGL by default for Qt MiniBrowser.
3664
3665         Reviewed by Noam Rosenthal.
3666
3667         * MiniBrowser/qt/qml/BrowserWindow.qml:
3668
3669 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
3670
3671         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
3672         https://bugs.webkit.org/show_bug.cgi?id=88164
3673
3674         Reviewed by Kentaro Hara.
3675
3676         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
3677         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
3678
3679         * Scripts/VCSUtils.pm:
3680         (adjustPathForRecentRenamings):
3681         (fixChangeLogPatch):
3682
3683 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
3684
3685         Rename test_expectations.txt to TestExpectations
3686         https://bugs.webkit.org/show_bug.cgi?id=86690
3687
3688         Reviewed by Dirk Pranke.
3689
3690         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
3691         We can the code to read test_expectations.txt once we've successfully transitioned.
3692
3693         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3694         (TestExpectationParser._check_path_does_not_exist):
3695         (TestExpectationParser._tokenize):
3696         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
3697         * Scripts/webkitpy/layout_tests/port/base.py:
3698         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
3699         test_expectations.txt if one exists and the path to TestExpectations otherwise.
3700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3701         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
3702         virtual.
3703         * Scripts/webkitpy/layout_tests/port/chromium.py:
3704         (ChromiumPort.path_from_chromium_base):
3705         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3706         (ChromiumAndroidPort.test_expectations):
3707         * Scripts/webkitpy/layout_tests/port/test.py:
3708         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
3709         (TestPort.__init__):
3710         * Scripts/webkitpy/layout_tests/port/webkit.py:
3711         (WebKitPort.baseline_search_path):
3712         (WebKitPort.test_expectations):
3713         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
3714         tests to base as a follow up.
3715         (WebKitPortTest.test_path_to_test_expectations_file):
3716         (test_test_expectations):
3717         (test_legacy_test_expectations):
3718         * Scripts/webkitpy/style/checker.py:
3719         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
3720         with one for TestExpectations.
3721         * Scripts/webkitpy/style/checkers/test_expectations.py:
3722         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
3723         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3724         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
3725         test_expectations.txt.
3726         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3727         (TestExpectationsTestCase.assert_lines_lint):
3728         * Scripts/webkitpy/tool/commands/queries.py:
3729         (PrintExpectations.__init__):
3730         * Scripts/webkitpy/tool/commands/rebaseline.py:
3731         (RebaselineExpectations):
3732         * Scripts/webkitpy/tool/steps/commit.py:
3733         (Commit._check_test_expectations):
3734         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3735         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
3736         (CommitTest.test_check_test_expectations): For TestExpectations.
3737         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
3738         * TestResultServer/static-dashboards/dashboard_base.js:
3739         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
3740         Error only when neither exists.
3741         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3742         (processMissingAndExtraExpectations):
3743         (htmlForTestsWithExpectationsButNoFailures):
3744         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3745
3746 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3747
3748         Remove dependency from ImageDiff to WTF
3749         https://bugs.webkit.org/show_bug.cgi?id=88147
3750
3751         Reviewed by Adam Barth.
3752
3753         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3754
3755 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
3756
3757         NRWT seems to leak (more?) temp dirs
3758         https://bugs.webkit.org/show_bug.cgi?id=88126
3759
3760         Re-land r119297 with chromium fix (weren't calling the
3761         super() method if not in --test-shell mode in start().
3762         Add unit tests to chromium_unittest as well to check.
3763
3764         * Scripts/webkitpy/layout_tests/port/chromium.py:
3765         (ChromiumDriver.start):
3766         * Scripts/webkitpy/layout_tests/port/webkit.py:
3767         (WebKitDriver.__del__):
3768         (WebKitDriver._start):
3769         (WebKitDriver.run_test):
3770         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3771         (WebKitDriverTest.test_check_for_driver_crash):
3772         (WebKitDriverTest.test_stop_cleans_up_properly):
3773         (WebKitDriverTest):
3774         (WebKitDriverTest.test_two_starts_cleans_up_properly):
3775         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3776         (ChromiumDriverTest.test_stop_cleans_up_properly):
3777         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
3778
3779 2012-06-01  Tim Horton  <timothy_horton@apple.com>
3780
3781         Lots of "failed download-built-product" on Apple bots
3782         https://bugs.webkit.org/show_bug.cgi?id=88158
3783
3784         Reviewed by Jessie Berlin.
3785
3786         Disable mergeRequests on all Apple builders. This is a speculative fix.
3787
3788         * BuildSlaveSupport/build.webkit.org-config/config.json:
3789
3790 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3791
3792         Unreviewed, rolling out r119297.
3793         http://trac.webkit.org/changeset/119297
3794         https://bugs.webkit.org/show_bug.cgi?id=88156
3795
3796         May have broken Chromium bots (Requested by rniwa on #webkit).
3797
3798         * Scripts/webkitpy/layout_tests/port/webkit.py:
3799         (WebKitDriver.__del__):
3800         (WebKitDriver.run_test):
3801         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3802         (WebKitDriverTest.test_check_for_driver_crash):
3803         (WebKitDriverTest.test_stop_cleans_up_properly):
3804
3805 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
3806
3807         nrwt seems to leak tmpdirs
3808         https://bugs.webkit.org/show_bug.cgi?id=88126
3809
3810         Reviewed by Ojan Vafai.
3811
3812         Fix leak possibly introduced in r118979 - we now will
3813         make sure we clean up any stale temp directories during the
3814         start routine and attempt to clean up again in __del__. It
3815         turns out that asserting in __del__ logs a message but is
3816         caught by the runtime, so it's mostly useless.
3817
3818         * Scripts/webkitpy/layout_tests/port/webkit.py:
3819         (WebKitDriver.__del__):
3820         (WebKitDriver._start):
3821         (WebKitDriver.run_test):
3822         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3823         (WebKitDriverTest.test_check_for_driver_crash):
3824         (WebKitDriverTest.test_stop_cleans_up_properly):
3825         (WebKitDriverTest):
3826         (WebKitDriverTest.test_two_starts_cleans_up_properly):
3827
3828 2012-06-01  Michael Saboff  <msaboff@apple.com>
3829
3830         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
3831         https://bugs.webkit.org/show_bug.cgi?id=88109
3832
3833         Reviewed by Geoffrey Garen.
3834
3835         Additional test case.
3836
3837         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
3838         (TestWebKitAPI::TEST):
3839
3840 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
3841
3842         [Qt] Use -Werror only in developer builds
3843
3844         Rubber-stamped by Tor Arne Vestbø.
3845
3846         In production builds -Werror with custom toolchains and wierd system
3847         headers, -Werror is of no use and just creates confusion. So use it
3848         only if Qt is configured with -developer-build.
3849
3850         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
3851         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
3852         only if qt_developer_build is set.
3853
3854 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
3855
3856         [watchlist] Add myself to loader and v8 bindings changes
3857         https://bugs.webkit.org/show_bug.cgi?id=88112
3858
3859         Reviewed by Adam Barth.
3860
3861         * Scripts/webkitpy/common/config/watchlist:
3862
3863 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
3864
3865         Adding Jacky Jiang to committers.py
3866         https://bugs.webkit.org/show_bug.cgi?id=88122
3867
3868         Reviewed by Rob Buis.
3869
3870         Adding myself to committers.py as a Committer.
3871
3872         * Scripts/webkitpy/common/config/committers.py:
3873
3874 2012-06-01  Jessie Berlin  <jberlin@apple.com>
3875
3876         Fix Windows build.
3877
3878         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3879
3880 2012-06-01  Jessie Berlin  <jberlin@apple.com>
3881
3882         Windows WK2 MouseMoveAfterCrash API test failing
3883         https://bugs.webkit.org/show_bug.cgi?id=69982
3884
3885         Disable the test on Windows to get the bots greener.
3886
3887         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3888         (TestWebKitAPI::TEST):
3889
3890 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
3891
3892         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
3893         https://bugs.webkit.org/show_bug.cgi?id=86866
3894
3895         Reviewed by Adam Barth.
3896
3897         Catch new "intent,service,register" signal on the frame and print out
3898         information about the Web Intent service in EFL's DumpRenderTree.
3899
3900         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3901         (DumpRenderTreeChrome::createView):
3902         (DumpRenderTreeChrome::onFrameCreated):
3903         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
3904         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3905         (DumpRenderTreeChrome):
3906
3907 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
3908
3909         The ChangeLog parser cannot handle reviewers with initials in their name
3910         https://bugs.webkit.org/show_bug.cgi?id=87864
3911
3912         Reviewed by Ryosuke Niwa.
3913
3914         Add support in the ChangeLog parser for reviewer names that have
3915         initials in them.
3916
3917         * Scripts/webkitpy/common/checkout/changelog.py:
3918         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
3919         in the replacement string. This allows for matching the word characters before a
3920         period, without totally throwing them away.
3921         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
3922         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3923         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
3924
3925 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
3926
3927         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
3928         https://bugs.webkit.org/show_bug.cgi?id=86865
3929
3930         Reviewed by Adam Barth.
3931
3932         Add deliverWebIntent method to LayoutTestController and provide
3933         implementation for EFL port.
3934
3935         * DumpRenderTree/LayoutTestController.cpp:
3936         (deliverWebIntentCallback):
3937         (LayoutTestController::staticFunctions):
3938         * DumpRenderTree/LayoutTestController.h:
3939         (LayoutTestController):
3940         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3941         (LayoutTestController::deliverWebIntent):
3942         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3943         (LayoutTestController::deliverWebIntent):
3944         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3945         (LayoutTestController::deliverWebIntent):
3946         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3947         (LayoutTestController::deliverWebIntent):
3948         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3949         (LayoutTestController::deliverWebIntent):
3950         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3951         (LayoutTestController::deliverWebIntent):
3952
3953 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3954
3955         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
3956
3957         Reviewed by Simon Hausmann.
3958
3959         * Tools.pro:
3960
3961 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
3962
3963         Add public page loading performance tests using web-page-replay
3964         https://bugs.webkit.org/show_bug.cgi?id=84008
3965
3966         Reviewed by Dirk Pranke.
3967
3968         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
3969         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
3970         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
3971
3972         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
3973         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
3974         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
3975         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
3976
3977         * Scripts/webkitpy/layout_tests/port/driver.py:
3978         (Driver.is_external_http_test): Added.
3979         * Scripts/webkitpy/layout_tests/port/webkit.py:
3980         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
3981         * Scripts/webkitpy/performance_tests/perftest.py:
3982         (PerfTest.__init__): Takes port.
3983         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
3984         (PerfTest):
3985         (PerfTest.run): Calls run_single.
3986         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
3987         (ChromiumStylePerfTest.__init__):
3988         (PageLoadingPerfTest.__init__):
3989         (PageLoadingPerfTest.run):
3990         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
3991         (ReplayServer.__init__):
3992         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
3993         but it caused a dead lock on some web pages.
3994         (ReplayServer.stop):
3995         (ReplayServer.__del__):
3996         (ReplayPerfTest):
3997         (ReplayPerfTest.__init__):
3998         (ReplayPerfTest._start_replay_server):
3999         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
4000         The subsequent runs of the same test will just use test.wpr.
4001         (ReplayPerfTest.run_single):
4002         (PerfTestFactory):
4003         (PerfTestFactory.create_perf_test):
4004         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4005         (MainTest.test_parse_output):
4006         (MainTest.test_parse_output_with_failing_line):
4007         (TestPageLoadingPerfTest.test_run):
4008         (TestPageLoadingPerfTest.test_run_with_bad_output):
4009         (TestReplayPerfTest):
4010         (TestReplayPerfTest.ReplayTestPort):
4011         (TestReplayPerfTest.ReplayTestPort.__init__):
4012         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
4013         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
4014         (TestReplayPerfTest.ReplayTestPort._driver_class):
4015         (TestReplayPerfTest.MockReplayServer):
4016         (TestReplayPerfTest.MockReplayServer.__init__):
4017         (TestReplayPerfTest.MockReplayServer.stop):
4018         (TestReplayPerfTest._add_file):
4019         (TestReplayPerfTest._setup_test):
4020         (TestReplayPerfTest.test_run_single):
4021         (TestReplayPerfTest.test_run_single.run_test):
4022         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
4023         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
4024         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
4025         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
4026         (TestReplayPerfTest.test_prepare):
4027         (TestReplayPerfTest.test_prepare.run_test):
4028         (TestReplayPerfTest.test_prepare_calls_run_single):
4029         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
4030         (TestPerfTestFactory.test_regular_test):
4031         (TestPerfTestFactory.test_inspector_test):
4032         (TestPerfTestFactory.test_page_loading_test):
4033         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4034         (PerfTestsRunner):
4035         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
4036         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
4037         (PerfTestsRunner._collect_tests._is_test_file):
4038         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
4039         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4040         (create_runner):
4041         (run_test):
4042         (_tests_for_runner):
4043         (test_run_test_set):
4044         (test_run_test_set_kills_drt_per_run):
4045         (test_run_test_pause_before_testing):
4046         (test_run_test_set_for_parser_tests):
4047         (test_run_test_set_with_json_output):
4048         (test_run_test_set_with_json_source):
4049         (test_run_test_set_with_multiple_repositories):
4050         (test_run_with_upload_json):
4051         (test_upload_json):
4052         (test_upload_json.MockFileUploader.upload_single_text_file):
4053         (_add_file):
4054         (test_collect_tests):
4055         (test_collect_tests_with_multile_files):
4056         (test_collect_tests_with_multile_files.add_file):
4057         (test_collect_tests_with_skipped_list):
4058         (test_collect_tests_with_page_load_svg):
4059         (test_collect_tests_should_ignore_replay_tests_by_default):
4060         (test_collect_tests_with_replay_tests):
4061         (test_parse_args):
4062         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
4063         (AutoinstallImportHook.find_module):
4064         (AutoinstallImportHook._install_webpagereplay):
4065
4066 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
4067
4068         Support building the Android port of chromium with Ninja
4069         https://bugs.webkit.org/show_bug.cgi?id=87545
4070
4071         Reviewed by Adam Barth.
4072
4073         Ensures that shared libraries are looked up in a generator-agnostic
4074         way and that output is placed in the correct directory.
4075
4076         Depends on http://codereview.chromium.org/10386188/
4077
4078         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4079
4080 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
4081
4082         [Chromium] Chromium DRT should be able to load external resources
4083         https://bugs.webkit.org/show_bug.cgi?id=87893
4084
4085         Reviewed by Dirk Pranke.
4086
4087         Allow external resources to be loaded when the main frame's URL is also an external resource.
4088         This change is analogous to r118231 for Mac port.
4089
4090         * DumpRenderTree/chromium/WebViewHost.cpp:
4091         (blockRequest):
4092         (isLocalhost):
4093         (hostIsUsedBySomeTestsToGenerateError):
4094         (WebViewHost::willSendRequest):
4095
4096 2012-05-31  Anders Carlsson  <andersca@apple.com>
4097
4098         Build fixes.
4099
4100         Disable the C++11 extensions warning.
4101
4102         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4103         * TestWebKitAPI/Configurations/Base.xcconfig:
4104         * WebKitTestRunner/Configurations/Base.xcconfig:
4105
4106 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
4107
4108         [WK2] window.internals settings are not reset between tests
4109         https://bugs.webkit.org/show_bug.cgi?id=87783
4110
4111         Reviewed by Mihai Parparita.
4112
4113         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4114         (WTR::InjectedBundle::done): Call resetAfterTest().
4115
4116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4117         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
4118         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
4119         This needs to be done after a tets, because the code assumes that there is an object
4120         with this name in global scope.
4121
4122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4123
4124 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4125
4126         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
4127         https://bugs.webkit.org/show_bug.cgi?id=85006
4128
4129         Reviewed by Tor Arne Vestbø.
4130
4131         Added navigation_policy_decision implementation for DumpRenderTreeView.
4132         Added LayoutTestController::setCustomPolicyDelegate implementation.
4133         Modified LayoutTestController::waitForPolicyDelegate.
4134
4135         * DumpRenderTree/efl/DumpRenderTree.cpp:
4136         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4137         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4138         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
4139         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
4140         (navigationTypeToString): aux function
4141         (onNavigationPolicyDecision): navigation_policy_decision implementation
4142         (drtViewAdd):
4143         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4144         (LayoutTestController::setCustomPolicyDelegate):
4145         (LayoutTestController::waitForPolicyDelegate):
4146
4147 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
4148
4149         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
4150         https://bugs.webkit.org/show_bug.cgi?id=86195
4151
4152         Reviewed by Gustavo Noronha Silva.
4153
4154         Implement clearApplicationCacheForOrigin in EFL
4155         LayoutTestController.
4156
4157         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4158         (LayoutTestController::clearApplicationCacheForOrigin):
4159
4160 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4161
4162         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
4163         https://bugs.webkit.org/show_bug.cgi?id=87955
4164
4165         Reviewed by Simon Hausmann.
4166
4167         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4168         * DumpRenderTree/qt/EventSenderQt.cpp:
4169         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
4170         * DumpRenderTree/qt/main.cpp:
4171         * QtTestBrowser/cookiejar.cpp:
4172         * QtTestBrowser/launcherwindow.cpp:
4173         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
4174         * qmake/mkspecs/features/default_post.prf:
4175
4176 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
4177
4178         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
4179
4180         Rubber-stamped by Kenneth Rohde Christiansen.
4181
4182         * qmake/config.tests/libpng/libpng.pro:
4183
4184 2012-05-30  Peter Beverloo  <peter@chromium.org>
4185
4186         [Chromium] Automatically install 64-bit linker for Android
4187         https://bugs.webkit.org/show_bug.cgi?id=79780
4188
4189         Reviewed by Adam Barth.
4190
4191         Change the update-webkit-chromium script to check whether the 64-bit
4192         linker needs to be installed as part of the update process. The actual
4193         code for doing these checks and "installing" it has been added to the
4194         webkitdirs.pm script.
4195
4196         The linker itself is part of the third_party/aosp repository, which
4197         will be pulled in through the DEPS change.
4198
4199         * Scripts/update-webkit-chromium:
4200         * Scripts/webkitdirs.pm:
4201         (chromiumInstall64BitAndroidLinkerIfNeeded):
4202         (chromiumReplaceAndroidLinkerIfNeeded):
4203
4204 2012-05-30  Stephanie Lewis  <slewis@apple.com>
4205
4206         https://bugs.webkit.org/show_bug.cgi?id=87803
4207         Layout tests often fail trying to stat nonexistent logs
4208
4209         Reviewed by Dirk Pranke.
4210
4211         CrashReporter removes logs using a heuristic to conserve space.  Wrap a
4212         try/catch block around accessing the logs as a precaution.
4213
4214         * Scripts/webkitpy/common/system/crashlogs.py:
4215         (CrashLogs._find_newest_log_darwin):
4216
4217 2012-05-30  Gavin Peters  <gavinp@chromium.org>
4218
4219         Add a LayoutTest for prerender remove after stop.
4220         https://bugs.webkit.org/show_bug.cgi?id=87860
4221
4222         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
4223         can be tested by LayoutTests now.
4224
4225         Reviewed by Adam Barth.
4226
4227         * DumpRenderTree/DumpRenderTree.gypi:
4228         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
4229         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
4230         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
4231         (MockWebPrerenderingSupport::add):
4232         (MockWebPrerenderingSupport::cancel):
4233         (MockWebPrerenderingSupport::abandon):
4234         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
4235         (MockWebPrerenderingSupport):
4236         * DumpRenderTree/chromium/TestShell.cpp:
4237         (TestShell::initialize):
4238         * DumpRenderTree/chromium/TestShell.h:
4239         (TestShell):
4240         * DumpRenderTree/chromium/WebViewHost.cpp:
4241         (WebViewHost::willAddPrerender):
4242         (WebViewHost::setWebWidget):
4243         * DumpRenderTree/chromium/WebViewHost.h:
4244         (WebViewHost):
4245
4246 2012-05-30  Stephanie Lewis  <slewis@apple.com>
4247
4248         https://bugs.webkit.org/show_bug.cgi?id=87717
4249         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
4250
4251         Reviewed by Dirk Pranke.
4252
4253         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
4254         If there isn't a crash log found for the process add a message saying
4255         the process was unresponsive.
4256
4257         * Scripts/webkitpy/layout_tests/port/webkit.py:
4258         (WebKitDriver.__init__):
4259         (WebKitDriver._check_for_driver_crash):
4260         (WebKitDriver.run_test):
4261         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4262         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
4263         (WebKitDriverTest):
4264         (WebKitDriverTest.test_check_for_driver_crash):
4265         * WebKitTestRunner/TestController.cpp:
4266         (WTR):
4267         (WTR::TestController::runTest):
4268
4269 2012-05-30  Stephanie Lewis  <slewis@apple.com>
4270
4271         https://bugs.webkit.org/show_bug.cgi?id=87714
4272         Mac crash logs can take a really long time to be written out.
4273
4274         Reviewed by Dirk Pranke.
4275
4276         Make a second pass looking for crash logs after the tests have completed running.
4277
4278         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4279         (use_trac_links_in_results_html):
4280         (Manager.run):
4281         * Scripts/webkitpy/layout_tests/port/base.py:
4282         (Port.repository_paths):
4283         (Port.look_for_new_crash_logs):
4284         * Scripts/webkitpy/layout_tests/port/mac.py:
4285         (MacPort.look_for_new_crash_logs):
4286         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4287         (test_get_crash_log):
4288         (test_look_for_new_crash_logs):
4289         (test_look_for_new_crash_logs.fake_time_cb):
4290
4291 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
4292
4293         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
4294
4295         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
4296         (LayoutWebViewEventHandler::OnAlertEvent):
4297         (LayoutWebViewEventHandler::OnConfirmEvent):
4298         (LayoutWebViewEventHandler):
4299         (LayoutWebViewEventHandler::OnPromptEvent):
4300         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
4301         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
4302
4303 2012-05-30  Ojan Vafai  <ojan@chromium.org>
4304
4305         Only give lint errors for -expected.png png files that lack a checksum
4306         https://bugs.webkit.org/show_bug.cgi?id=87875
4307
4308         Reviewed by Tony Chang.
4309
4310         We have other pngs in the tree, e.g. for the inspector, that legitimately
4311         lack a checksum.
4312
4313         * Scripts/webkitpy/style/checkers/png.py:
4314         (PNGChecker.check):
4315         * Scripts/webkitpy/style/checkers/png_unittest.py:
4316         (PNGCheckerTest.test_check):
4317
4318 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
4319
4320         nrwt: seems to leak temp dirs
4321         https://bugs.webkit.org/show_bug.cgi?id=87795
4322
4323         Reviewed by Ojan Vafai.
4324
4325         There appears to be a bug where the chromium bots are creating
4326         temporary directories and not cleaning them up that started
4327         after the switch to WebKitDriver. It's possible that __del__
4328         wasn't getting called in a timely manner (or at all), and it's
4329         generally bad style to rely on __del__ being called, so this
4330         code changes things so that we create a temp dir in
4331         driver.start() and remove it in driver.stop(). We could be
4332         paranoid and leave the __del__ code in, but there doesn't seem
4333         to be much advantage to it. If there are bugs that result in
4334         drivers being started but not stopped, we have other problems.
4335
4336         * Scripts/webkitpy/common/system/filesystem_mock.py:
4337         (MockFileSystem.__init__):
4338         (MockFileSystem._mktemp):
4339         (MockFileSystem.mkdtemp):
4340         * Scripts/webkitpy/layout_tests/port/webkit.py:
4341         (WebKitDriver.__init__):
4342         (WebKitDriver._start):
4343         (WebKitDriver.stop):
4344         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4345         (WebKitDriverTest.test_check_for_driver_crash):
4346         (WebKitDriverTest):