[GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2
3         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
4         https://bugs.webkit.org/show_bug.cgi?id=174816
5
6         Reviewed by Michael Catanzaro.
7
8         Add tests for webkit_uri_for_display().
9
10         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
11         (testURIForDisplayUnaffected):
12         (testURIForDisplayAffected):
13         (beforeAll):
14         (afterAll):
15         * TestWebKitAPI/glib/CMakeLists.txt:
16
17 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
18
19         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
20         https://bugs.webkit.org/show_bug.cgi?id=194158
21         <rdar://problem/47737268>
22
23         Rubber-stamped by Aakash Jain.
24
25         * Scripts/webkitpy/port/device_port.py:
26         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
27
28 2019-02-04  Said Abou-Hallawa  <said@apple.com>
29
30         [CG] Enable setAdditionalSupportedImageTypes for WK1
31         https://bugs.webkit.org/show_bug.cgi?id=194190
32
33         Reviewed by Tim Horton.
34
35         Add a test similar to the one under WebKit Cocoa but make it create a
36         WebView instead of a WKWebView.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
40         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
41         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
42         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
43         (TestWebKitAPI::runTest):
44         (TestWebKitAPI::TEST):
45
46 2019-02-04  Zalan Bujtas  <zalan@apple.com>
47
48         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
49         https://bugs.webkit.org/show_bug.cgi?id=194168
50
51         Reviewed by Simon Fraser.
52
53         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
54
55         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
56         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
57         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
58         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
59         (TEST):
60         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
61         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
62
63 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
64
65         REGRESSION (r237269): webkit-patch what-broke is broken 
66         https://bugs.webkit.org/show_bug.cgi?id=193025
67
68         Reviewed by Aakash Jain.
69
70         * Scripts/webkitpy/common/host.py:
71         (Host.buildbot):
72         (Host.bugzilla): Renamed to 'buildbot'.
73
74 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
75
76         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
77         https://bugs.webkit.org/show_bug.cgi?id=194207
78
79         Reviewed by Tim Horton.
80
81         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
82         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
83         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
84         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
85         start and delete forwards to remove the original attachment.
86
87         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
88         (TestWebKitAPI::TEST):
89
90 2019-02-04  Youenn Fablet  <youenn@apple.com>
91
92         Capture state should be managed consistently when doing process swapping
93         https://bugs.webkit.org/show_bug.cgi?id=194122
94         <rdar://problem/47609293>
95
96         Reviewed by Eric Carlson.
97
98         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
99         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
100         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
101         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
102         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
104         (WTR::TestRunner::isDoingMediaCapture const):
105         * WebKitTestRunner/InjectedBundle/TestRunner.h:
106         * WebKitTestRunner/TestController.cpp:
107         (WTR::TestController::isDoingMediaCapture const):
108         * WebKitTestRunner/TestController.h:
109         * WebKitTestRunner/TestInvocation.cpp:
110         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
112         (WTR::TestController::isDoingMediaCapture const):
113
114 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
115
116         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
117         https://bugs.webkit.org/show_bug.cgi?id=194142
118
119         Reviewed by Ross Kirsling.
120
121         There three 'separator' variables in TestController.cpp. Renamed
122         it 'pathSeparator', and unified them.
123
124         * WebKitTestRunner/TestController.cpp:
125         (WTR::TestController::generateContextConfiguration const):
126         (WTR::createTestURL):
127         (WTR::TestController::platformAdjustContext):
128
129 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
130
131         Make setNeedsLayout on the root more explicitly about triggering its side-effects
132         https://bugs.webkit.org/show_bug.cgi?id=194198
133
134         Reviewed by Antti Koivisto.
135
136         No need to set the banner heights on navigation now, since Page stores them.
137
138         * MiniBrowser/mac/WK2BrowserWindowController.m:
139         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
140
141 2019-02-03  John Wilander  <wilander@apple.com>
142
143         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
144         https://bugs.webkit.org/show_bug.cgi?id=194104
145         <rdar://problem/47649991>
146
147         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
148
149         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
150         (TestWebKitAPI::TEST):
151             Changed numeric types from unsigned short to uint32_t.
152
153 2019-02-02  David Kilzer  <ddkilzer@apple.com>
154
155         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
156         <https://webkit.org/b/194178>
157         <rdar://problem/47753473>
158
159         Reviewed by Alexey Proskuryakov.
160
161         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
162         (WTR::uninstallFakeHelvetica): Pass nullptr into
163         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
164
165 2019-02-02  Zalan Bujtas  <zalan@apple.com>
166
167         [LFC] Initialize ICB's style with fixed width/height.
168         https://bugs.webkit.org/show_bug.cgi?id=194188
169
170         Reviewed by Antti Koivisto.
171
172         * LayoutReloaded/misc/LFC-passing-tests.txt:
173
174 2019-02-02  Zalan Bujtas  <zalan@apple.com>
175
176         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
177         https://bugs.webkit.org/show_bug.cgi?id=194185
178
179         Reviewed by Antti Koivisto.
180
181         * LayoutReloaded/misc/LFC-passing-tests.txt:
182
183 2018-12-16  Darin Adler  <darin@apple.com>
184
185         Convert additional String::format clients to alternative approaches
186         https://bugs.webkit.org/show_bug.cgi?id=192746
187
188         Reviewed by Alexey Proskuryakov.
189
190         * WebKitTestRunner/TestController.cpp:
191         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
192         as an intermediate in code that ultimately constructs a WTF::String.
193         (WTR::userMediaOriginHash): Use makeString.
194         (WTR::TestController::didNavigateWithNavigationData): More of the same.
195         (WTR::TestController::didPerformClientRedirect): Ditto.
196         (WTR::TestController::didPerformServerRedirect): Ditto.
197         (WTR::TestController::didUpdateHistoryTitle): Ditto.
198
199 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
200
201         [ews-build] Add unit test to verify builder keys
202         https://bugs.webkit.org/show_bug.cgi?id=194152
203
204         Reviewed by Lucas Forschler.
205
206         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
207         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
208
209 2019-02-01  Zalan Bujtas  <zalan@apple.com>
210
211         [LFC] Expand tests coverage (12 new tests -> 787)
212
213         Unreviewed test gardening.
214
215         * LayoutReloaded/misc/LFC-passing-tests.txt:
216
217 2019-02-01  Zalan Bujtas  <zalan@apple.com>
218
219         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
220         https://bugs.webkit.org/show_bug.cgi?id=194163
221
222         Reviewed by Simon Fraser.
223
224         775
225
226         * LayoutReloaded/misc/LFC-passing-tests.txt:
227
228 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
229
230         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
231         https://bugs.webkit.org/show_bug.cgi?id=194140
232         <rdar://problem/47728098>
233
234         Reviewed by Tim Horton.
235
236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
238         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
239
240         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
241         test to induce an IPC deadlock when presenting a modal alert during touch start.
242
243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
244         * WebKitTestRunner/TestController.cpp:
245         (WTR::runJavaScriptAlert):
246
247         Add a client callback function for running JavaScript alerts.
248
249         (WTR::TestController::createOtherPage):
250         (WTR::TestController::generateContextConfiguration const):
251
252         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
253         the fix in this patch.
254
255         (WTR::TestController::createWebViewWithOptions):
256
257         Plumb TestOptions to generateContextConfiguration.
258
259         (WTR::TestController::resetPreferencesToConsistentValues):
260         (WTR::TestController::resetStateToConsistentValues):
261         (WTR::updateTestOptionsFromTestHeader):
262         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
263         (WTR::TestController::handleJavaScriptAlert):
264         * WebKitTestRunner/TestController.h:
265         * WebKitTestRunner/TestInvocation.cpp:
266         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
267         * WebKitTestRunner/TestOptions.h:
268         (WTR::TestOptions::hasSameInitializationOptions const):
269
270 2019-02-01  Chris Dumez  <cdumez@apple.com>
271
272         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
273         https://bugs.webkit.org/show_bug.cgi?id=193740
274         <rdar://problem/47527267>
275
276         Reviewed by Alex Christensen.
277
278         Add API test coverage.
279
280         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
281
282 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
283
284         [ews-app] Add display name field to BuilderMapping model
285         https://bugs.webkit.org/show_bug.cgi?id=194153
286
287         Reviewed by Lucas Forschler.
288
289         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
290         (BuilderMapping):
291
292 2019-02-01  Youenn Fablet  <youenn@apple.com>
293
294         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
295         https://bugs.webkit.org/show_bug.cgi?id=194155
296
297         Reviewed by Eric Carlson.
298
299         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
300         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
301         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
302
303 2019-02-01  Zalan Bujtas  <zalan@apple.com>
304
305         [LFC] Adjust replaced element's intrinsic ratio
306         https://bugs.webkit.org/show_bug.cgi?id=194154
307
308         Reviewed by Antti Koivisto.
309
310         761
311
312         * LayoutReloaded/misc/LFC-passing-tests.txt:
313
314 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
315
316         [WPE] Show test results in minibrowser
317         https://bugs.webkit.org/show_bug.cgi?id=194150
318
319         Reviewed by Žan Doberšek.
320
321         * Scripts/webkitpy/port/wpe.py:
322         (WPEPort.show_results_html_file):
323
324 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
325
326         [WPE] MiniBrowser: add ky bindings for back/forward navigation
327         https://bugs.webkit.org/show_bug.cgi?id=194151
328
329         Reviewed by Žan Doberšek.
330
331         ALT + <- go back
332         ALT + -> go forward
333
334         * MiniBrowser/wpe/main.cpp:
335         (main):
336
337 2019-02-01  Zalan Bujtas  <zalan@apple.com>
338
339         [LFC] Set intrinsic size on Layout::Replaced
340         https://bugs.webkit.org/show_bug.cgi?id=194139
341
342         Reviewed by Antti Koivisto.
343
344         744
345
346         * LayoutReloaded/misc/LFC-passing-tests.txt:
347
348 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
349
350         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
351         https://bugs.webkit.org/show_bug.cgi?id=194146
352
353         Reviewed by Xabier Rodriguez-Calvar.
354
355         It allows to open relative paths.
356
357         * MiniBrowser/wpe/main.cpp:
358         (main):
359
360 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
361
362         Update flakiness dashboard configuration after recent queue changes
363         https://bugs.webkit.org/show_bug.cgi?id=194127
364
365         Rubber-stamped by Aakash Jain.
366
367         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
368
369         * TestResultServer/static-dashboards/builders.jsonp:
370
371 2019-01-31  Youenn Fablet  <youenn@apple.com>
372
373         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
374         https://bugs.webkit.org/show_bug.cgi?id=194106
375         <rdar://problem/47676333>
376
377         Reviewed by Ryosuke Niwa.
378
379         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
380         (TestWebKitAPI::didFinishNavigation):
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
383
384 2019-01-31  Chris Dumez  <cdumez@apple.com>
385
386         Page zoom level is lost after a process swap or a crash
387         https://bugs.webkit.org/show_bug.cgi?id=194105
388         <rdar://problem/47610781>
389
390         Reviewed by Alex Christensen.
391
392         Add API test coverage.
393
394         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
395         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
396
397 2019-01-31  Alex Christensen  <achristensen@webkit.org>
398
399         Revert r238819 which is unneeded and caused a performance regression.
400         https://bugs.webkit.org/show_bug.cgi?id=192272
401         <rdar://problem/46664625>
402
403         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
404         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
405         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
406
407 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
408
409         Formalize WebKitAdditions mechanism of LoadOptimizer
410         https://bugs.webkit.org/show_bug.cgi?id=193886
411         <rdar://problem/47696809>
412
413         Reviewed by Brent Fulgham.
414
415         * MiniBrowser/MiniBrowser.entitlements:
416         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
417
418 2019-01-31  Zalan Bujtas  <zalan@apple.com>
419
420         [LFC] Margin before/after/start/end initial value is 0 and not auto.
421         https://bugs.webkit.org/show_bug.cgi?id=194090
422
423         Reviewed by Antti Koivisto.
424
425         * LayoutReloaded/misc/LFC-passing-tests.txt:
426
427 2019-01-31  Zalan Bujtas  <zalan@apple.com>
428
429         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
430         https://bugs.webkit.org/show_bug.cgi?id=194074
431
432         Reviewed by Antti Koivisto.
433
434         * LayoutReloaded/misc/LFC-passing-tests.txt:
435
436 2019-01-31  Zalan Bujtas  <zalan@apple.com>
437
438         [LFC][BFC] Add support for block level replaced box.
439         https://bugs.webkit.org/show_bug.cgi?id=194071
440
441         Reviewed by Antti Koivisto.
442
443         * LayoutReloaded/misc/LFC-passing-tests.txt:
444
445 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
446
447         Fix WebKitTestRunner's testPath with Windows full paths
448         https://bugs.webkit.org/show_bug.cgi?id=194012
449
450         Reviewed by Alex Christensen.
451
452         updateTestOptionsFromTestHeader failed to open test files because
453         testPath returned wrong file paths. It returned a path "/C:/..."
454         if a URL "file:///C:/..." was given.
455
456         * WebKitTestRunner/TestController.cpp:
457         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
458
459 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
460
461         [WPE] Bump font related dependencies to match the GTK+ port
462         https://bugs.webkit.org/show_bug.cgi?id=194017
463
464         Reviewed by Žan Doberšek.
465
466         * wpe/jhbuild.modules:
467         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
468         * wpe/patches/icudata-stdlibs.patch: Added.
469
470 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
471
472         Enable swipe tests on iOS
473         https://bugs.webkit.org/show_bug.cgi?id=194076
474
475         Reviewed by Geoffrey Garen.
476
477         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
478         it causes a debug assertion failure in runUIScript.
479
480         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
481         (WTR::UIScriptController::beginBackSwipe):
482         (WTR::UIScriptController::completeBackSwipe):
483
484 2019-01-30  Keith Rollin  <krollin@apple.com>
485
486         Use correct printf format specifier
487         https://bugs.webkit.org/show_bug.cgi?id=194062
488         <rdar://problem/47686167>
489
490         Reviewed by Alexey Proskuryakov.
491
492         LayoutTestSpellChecker.mm is trying to format a variable of type
493         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
494         actually an unsigned long long. Fix this by formatting with %llu.
495
496         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
497         (-[LayoutTestTextCheckingResult description]):
498
499 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
500
501         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
502         https://bugs.webkit.org/show_bug.cgi?id=193979
503
504         Reviewed by Wenson Hsieh.
505
506         Fix the test for iOS. Make the test work with iOS UA string.
507
508         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
509
510 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
511
512         Replace High Sierra LLINT CLoop bot due to hardware failure
513         https://bugs.webkit.org/show_bug.cgi?id=194066
514
515         Reviewed by Aakash Jain.
516
517         * BuildSlaveSupport/build.webkit.org-config/config.json:
518
519 2019-01-30  Keith Rollin  <krollin@apple.com>
520
521         [NSDragItem init] is unavailable
522         https://bugs.webkit.org/show_bug.cgi?id=194059
523         <rdar://problem/47685715>
524
525         Reviewed by Wenson Hsieh.
526
527         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
528         DumpRenderTree and TestWebKitAPI, which both try to create an
529         NSDragItem in a manner that invokes this method. Address this by using
530         -initWithPasteboardWriter instead.
531
532         Note that the parameter passed to initWithPasteboardWriter is likely
533         incorrect. In both cases, the object passed does not conform to
534         NSPasteboardWriting. However, with this fix, we're no worse off than
535         before, and can now perform builds with newer compilers and SDKs until
536         a real fix can be crafted. That work is tracked in
537         https://bugs.webkit.org/show_bug.cgi?id=194060
538
539         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
540         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
541         * TestWebKitAPI/mac/TestDraggingInfo.mm:
542         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
543
544 2019-01-30  Daniel Bates  <dabates@apple.com>
545
546         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
547         https://bugs.webkit.org/show_bug.cgi?id=192824
548         <rdar://problem/47100332>
549
550         Reviewed by Wenson Hsieh.
551
552         Fix a bug where the wrong usage code was used for F13 thru F24.
553
554         * WebKitTestRunner/ios/HIDEventGenerator.mm:
555         (keyCodeForDOMFunctionKey):
556
557 2019-01-30  Chris Dumez  <cdumez@apple.com>
558
559         Regression(PSON) Load hang can occur on history navigation
560         https://bugs.webkit.org/show_bug.cgi?id=194030
561         <rdar://problem/47656939>
562
563         Reviewed by Antti Koivisto.
564
565         Add API test coverage.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
568
569 2019-01-30  Zalan Bujtas  <zalan@apple.com>
570
571         [LFC] Expand tests coverage.
572
573         Unreviewed test gardening.
574
575         * LayoutReloaded/misc/LFC-passing-tests.txt:
576
577 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
578
579         [Flatpak] Add openjpeg support
580         https://bugs.webkit.org/show_bug.cgi?id=194019
581
582         Reviewed by Michael Catanzaro.
583
584         * flatpak/org.webkit.CommonModules.yaml:
585
586 2019-01-30  Commit Queue  <commit-queue@webkit.org>
587
588         Unreviewed, rolling out r240708.
589         https://bugs.webkit.org/show_bug.cgi?id=194022
590
591         It broke WPE build (Requested by KaL on #webkit).
592
593         Reverted changeset:
594
595         "[WPE] Bump font related dependencies to match the GTK+ port"
596         https://bugs.webkit.org/show_bug.cgi?id=194017
597         https://trac.webkit.org/changeset/240708
598
599 2019-01-30  Zalan Bujtas  <zalan@apple.com>
600
601         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
602         https://bugs.webkit.org/show_bug.cgi?id=194001
603
604         Reviewed by Antti Koivisto.
605
606         * LayoutReloaded/misc/LFC-passing-tests.txt:
607
608 2019-01-30  Zalan Bujtas  <zalan@apple.com>
609
610         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
611         https://bugs.webkit.org/show_bug.cgi?id=194020
612
613         Reviewed by Antti Koivisto.
614
615         * LayoutReloaded/misc/LFC-passing-tests.txt:
616
617 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
618
619         AX: Support color well on iOS
620         https://bugs.webkit.org/show_bug.cgi?id=194010
621
622         Reviewed by Joanmarie Diggs.
623
624         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
625         (WTR::AccessibilityUIElement::stringAttributeValue):
626
627 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
628
629         [WPE] Bump font related dependencies to match the GTK+ port
630         https://bugs.webkit.org/show_bug.cgi?id=194017
631
632         Reviewed by Žan Doberšek.
633
634         * wpe/jhbuild.modules:
635         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
636         * wpe/patches/icudata-stdlibs.patch: Added.
637
638 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
639
640         [Mac] Update window scale API usage
641         https://bugs.webkit.org/show_bug.cgi?id=193991
642         rdar://problem/47614795
643
644         Reviewed by Tim Horton.
645
646         * DumpRenderTree/mac/DumpRenderTree.mm:
647         (changeWindowScaleIfNeeded):
648         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
649         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
650         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
651
652 2019-01-29  Chris Dumez  <cdumez@apple.com>
653
654         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
655         https://bugs.webkit.org/show_bug.cgi?id=193977
656         <rdar://problem/47643716>
657
658         Reviewed by Geoff Garen.
659
660         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
661         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
662         to the previous provisional committing *before* we make the last load. 
663
664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
665
666 2019-01-29  Youenn Fablet  <youenn@apple.com>
667
668         Adopt new SPI to evaluate server certificate trust
669         https://bugs.webkit.org/show_bug.cgi?id=193355
670
671         Reviewed by Alex Christensen.
672
673         Add infrastructure to handle HTTPS server trust evaluation testing.
674
675         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
677         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
678         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
679         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
681         * WebKitTestRunner/TestController.cpp:
682         (WTR::TestController::resetPreferencesToConsistentValues):
683         (WTR::TestController::didReceiveAuthenticationChallenge):
684         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
685         * WebKitTestRunner/TestController.h:
686         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
687         * WebKitTestRunner/TestInvocation.cpp:
688         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
689         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
690         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
691
692 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
693
694         [ews-build] Add build step to print bot Configuration
695         https://bugs.webkit.org/show_bug.cgi?id=193887
696
697         Reviewed by Lucas Forschler.
698
699         * BuildSlaveSupport/ews-build/steps.py:
700         (PrintConfiguration): Build step to print configuration.
701         * BuildSlaveSupport/ews-build/factories.py:
702
703 2019-01-29  Chris Dumez  <cdumez@apple.com>
704
705         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
706         https://bugs.webkit.org/show_bug.cgi?id=193967
707         <rdar://problem/47635348>
708
709         Reviewed by Alex Christensen.
710
711         Add API test coverage.
712
713         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
714         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
715
716 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
717
718         [ews-app] Handle incoming results data
719         https://bugs.webkit.org/show_bug.cgi?id=193973
720
721         Reviewed by Lucas Forschler.
722
723         * BuildSlaveSupport/ews-app/ews/views/results.py:
724
725 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
726
727         [ews-app] Make the results url generic
728         https://bugs.webkit.org/show_bug.cgi?id=193928
729
730         Reviewed by Lucas Forschler.
731
732         * BuildSlaveSupport/ews-app/ews/urls.py:
733
734 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
735
736         [ews-build] Configure buildbot to send events to ews-app
737         https://bugs.webkit.org/show_bug.cgi?id=193968
738
739         Reviewed by Lucas Forschler.
740
741         * BuildSlaveSupport/ews-build/events.py: Added.
742         * BuildSlaveSupport/ews-build/master.cfg:
743
744 2019-01-29  Keith Rollin  <krollin@apple.com>
745
746         Add .xcfilelists to Run Script build phases
747         https://bugs.webkit.org/show_bug.cgi?id=193792
748         <rdar://problem/47201785>
749
750         Reviewed by Alex Christensen.
751
752         As part of supporting XCBuild, update the necessary Run Script build
753         phases in their Xcode projects to refer to their associated
754         .xcfilelist files.
755
756         Note that the addition of these files bumps the Xcode project version
757         number to something that's Xcode 10 compatible. This change means that
758         older versions of the Xcode IDE can't read these projects. Nor can it
759         fully load workspaces that refer to these projects (the updated
760         projects are shown as non-expandable placeholders). `xcodebuild` can
761         still build these projects; it's just that the IDE can't open them.
762
763         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
764         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
765
766 2019-01-29  John Wilander  <wilander@apple.com>
767
768         Add data abstraction and validation for Ad Click Attribution
769         https://bugs.webkit.org/show_bug.cgi?id=193916
770         <rdar://problem/47603481>
771
772         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
773
774         Ad click attribution has two steps. First, the storage of an ad
775         campaign ID for a click that takes the user to a destination
776         site. Second, a conversion on the destination site that can be
777         attributed to the ad click.
778
779         This patch adds a class that represents a request for ad click
780         attribution. Validation makes sure that the bits of entropy
781         reported through this mechanism is limited.
782
783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
784         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
785         (TestWebKitAPI::TEST):
786
787 2019-01-29  Chris Dumez  <cdumez@apple.com>
788
789         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
790         https://bugs.webkit.org/show_bug.cgi?id=193932
791         <rdar://problem/47598947>
792
793         Reviewed by Brady Eidson.
794
795         Add API test coverage.
796
797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
798
799 2019-01-29  Zalan Bujtas  <zalan@apple.com>
800
801         Adding new passing LFC tests.
802
803         Unreviewed test gardening.
804
805         * LayoutReloaded/misc/LFC-passing-tests.txt:
806
807 2019-01-29  Zalan Bujtas  <zalan@apple.com>
808
809         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
810         https://bugs.webkit.org/show_bug.cgi?id=193964
811
812         Reviewed by Antti Koivisto.
813
814         * LayoutReloaded/misc/LFC-passing-tests.txt:
815
816 2019-01-29  Zalan Bujtas  <zalan@apple.com>
817
818         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
819         https://bugs.webkit.org/show_bug.cgi?id=193954
820
821         Reviewed by Antti Koivisto.
822
823         * LayoutReloaded/misc/LFC-passing-tests.txt:
824
825 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
826
827         WebDriver: add support for running subtests
828         https://bugs.webkit.org/show_bug.cgi?id=193904
829
830         Reviewed by Michael Catanzaro.
831
832         pytest already supports it by passing test.py::subtest, so we can do the same.
833
834         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
835         (get_item_name): Made this global.
836         (CollectRecorder.__init__): Receive the parameter to ignore.
837         (CollectRecorder.pytest_collectreport): Collect also the subtests.
838         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
839         (collect): Add parameter to ignore.
840         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
841         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
842         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
843         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
844         (WebDriverTestRunnerSelenium.run): Ditto.
845         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
846         (WebDriverTestRunnerW3C.collect_tests): Ditto.
847         (WebDriverTestRunnerW3C.run): Ditto.
848
849 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
850
851         User agent string override for navigator.userAgent should be site specific quirks
852         https://bugs.webkit.org/show_bug.cgi?id=193950
853
854         Reviewed by Brent Fulgham.
855
856         Updated per the _WKWebsitePolicies rename.
857
858         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
859         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
860
861 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
862
863         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
864         https://bugs.webkit.org/show_bug.cgi?id=193941
865
866         Reviewed by Alex Christensen.
867
868         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
869         * TestWebKitAPI/Tests/WTF/Condition.cpp:
870         * TestWebKitAPI/Tests/WTF/Lock.cpp:
871         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
872         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
873         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
874         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
875         * TestWebKitAPI/Tests/WTF/Time.cpp:
876         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
877         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
878         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
879         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
880
881 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
882
883         Unreviewed, reorder my emails to fix autocomplete in bugzilla
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2019-01-28  Andy Estes  <aestes@apple.com>
888
889         [watchOS] Enable Parental Controls content filtering
890         https://bugs.webkit.org/show_bug.cgi?id=193939
891         <rdar://problem/46641912>
892
893         Reviewed by Ryosuke Niwa.
894
895         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
896
897 2019-01-28  David Kilzer  <ddkilzer@apple.com>
898
899         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
900         <https://webkit.org/b/193884>
901
902         Reviewed by Jiewen Tan.
903
904         * Scripts/webkitpy/style/checkers/cpp.py:
905         (check_language): Add LocalAuthentication to
906         `frameworks_with_soft_links`.
907
908 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
909
910         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
911         https://bugs.webkit.org/show_bug.cgi?id=193891
912
913         Reviewed by Ross Kirsling.
914
915         There were three problems in window sizes of WebView and the host window.
916         1. The sizes of pixel image output were incorrect.
917         2. The host window is going to appear after window.resize was invoked.
918         3. window.resize resized only the host window, not WebView.
919
920         This change solves them with a following approach.
921         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
922         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
923            as well as DumpRenderTree in order to match the client area and the window area.
924         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
925         d. PlatformWebView::setWindowFrame changes both window sizes.
926         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
927
928         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
929         (WTR::PlatformWebView::PlatformWebView): Create the host window
930         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
931         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
932         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
933
934 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
935
936         [ews-app] Add method to save Step data to database
937         https://bugs.webkit.org/show_bug.cgi?id=193890
938
939         Reviewed by Lucas Forschler.
940
941         * BuildSlaveSupport/ews-app/ews/models/step.py:
942         (Step.save_step): Method to save step data.
943         (Step.update_step): Method to update step data.
944         (Step.get_existing_step): Method to fetch existing step from database.
945         (Step.is_valid_result): Method to validate valid step result.
946
947 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
948
949         [ews-app] Add method to save Build data to database
950         https://bugs.webkit.org/show_bug.cgi?id=193735
951
952         Reviewed by Lucas Forschler.
953
954         * BuildSlaveSupport/ews-app/ews/models/build.py:
955         (Build.save_build): Method to save build information to database.
956         (Build.get_existing_build): Method to fetch existing build from database.
957         (Build.is_valid_result): Method to validate build result.
958         * BuildSlaveSupport/ews-app/ews/common/util.py:
959         (is_valid_int_id): Method to validate valid id.
960
961 2019-01-28  Chris Dumez  <cdumez@apple.com>
962
963         Regression(PSON) Crash under WebPageProxy::didStartProgress()
964         https://bugs.webkit.org/show_bug.cgi?id=193915
965         <rdar://problem/47560907>
966
967         Reviewed by Alex Christensen.
968
969         Add API test coverage.
970
971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
972
973 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
974
975         [ews-app] Rename id variables
976         https://bugs.webkit.org/show_bug.cgi?id=193883
977
978         Reviewed by Lucas Forschler.
979
980         * BuildSlaveSupport/ews-app/ews/models/build.py:
981         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
982         * BuildSlaveSupport/ews-app/ews/models/step.py:
983         * BuildSlaveSupport/ews-app/ews/urls.py:
984         * BuildSlaveSupport/ews-app/ews/views/patch.py:
985         * BuildSlaveSupport/ews-app/ews/views/results.py:
986         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
987
988 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
989
990         [ews-app] Allow certain fields to be empty
991         https://bugs.webkit.org/show_bug.cgi?id=193892
992
993         Reviewed by Lucas Forschler.
994
995         * BuildSlaveSupport/ews-app/ews/models/build.py:
996         * BuildSlaveSupport/ews-app/ews/models/step.py:
997
998 2019-01-28  Rob Buis  <rbuis@igalia.com>
999
1000         Update MIME type parser
1001         https://bugs.webkit.org/show_bug.cgi?id=180526
1002
1003         Reviewed by Frédéric Wang.
1004
1005         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1006         (TestWebKitAPI::TEST):
1007
1008 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1009
1010         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1011         https://bugs.webkit.org/show_bug.cgi?id=193896
1012
1013         Reviewed by Antti Koivisto.
1014
1015         * LayoutReloaded/misc/LFC-passing-tests.txt:
1016
1017 2018-12-15  Darin Adler  <darin@apple.com>
1018
1019         Replace many uses of String::format with more type-safe alternatives
1020         https://bugs.webkit.org/show_bug.cgi?id=192742
1021
1022         Reviewed by Mark Lam.
1023
1024         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1025         (WTR::cacheTestRunnerCallback): Use makeString.
1026         * WebKitTestRunner/TestController.cpp:
1027         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1028         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1029
1030 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1031
1032         Use a load optimizer for some sites
1033         https://bugs.webkit.org/show_bug.cgi?id=193881
1034         <rdar://problem/46325455>
1035
1036         Reviewed by Brent Fulgham.
1037
1038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1039         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1040
1041 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1042
1043         AX: Introduce a static accessibility tree
1044         https://bugs.webkit.org/show_bug.cgi?id=193348
1045         <rdar://problem/47203295>
1046
1047         Reviewed by Ryosuke Niwa.
1048
1049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1050
1051 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1052
1053         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1054         https://bugs.webkit.org/show_bug.cgi?id=193867
1055
1056         Reviewed by Antti Koivisto.
1057
1058         * LayoutReloaded/misc/LFC-passing-tests.txt:
1059
1060 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1061
1062         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1063         https://bugs.webkit.org/show_bug.cgi?id=193865
1064
1065         Reviewed by Antti Koivisto.
1066
1067         * LayoutReloaded/misc/LFC-passing-tests.txt:
1068
1069 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1070
1071         Need a mechanism to override navigator.userAgent
1072         https://bugs.webkit.org/show_bug.cgi?id=193762
1073         <rdar://problem/47504939>
1074
1075         Reviewed by Brent Fulgham.
1076
1077         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1078
1079         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1080         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1081         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1082
1083 2019-01-25  Dean Jackson  <dino@apple.com>
1084
1085         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1086         https://bugs.webkit.org/show_bug.cgi?id=193831
1087         <rdar://problem/47399263>
1088
1089         Reviewed by Chris Dumez.
1090
1091         Two new tests that exercise cross-origin and same-origin System
1092         Previews.
1093
1094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1095
1096 2019-01-25  Keith Rollin  <krollin@apple.com>
1097
1098         Update Xcode projects with "Check .xcfilelists" build phase
1099         https://bugs.webkit.org/show_bug.cgi?id=193790
1100         <rdar://problem/47201374>
1101
1102         Reviewed by Alex Christensen.
1103
1104         Support for XCBuild includes specifying inputs and outputs to various
1105         Run Script build phases. These inputs and outputs are specified as
1106         .xcfilelist files. Once created, these .xcfilelist files need to be
1107         kept up-to-date. In order to check that they are up-to-date or not,
1108         add an Xcode build step that invokes an external script that performs
1109         the checking. If the .xcfilelists are found to be out-of-date, update
1110         them, halt the build, and instruct the developer to restart the build
1111         with up-to-date files.
1112
1113         At this time, the checking and regenerating is performed only if the
1114         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1115         who want to use this facility can set this variable and test out the
1116         checking/regenerating. Once it seems like there are no egregious
1117         issues that upset a developer's workflow, we'll unconditionally enable
1118         this facility.
1119
1120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1121         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1122         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1123         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1124
1125 2019-01-25  Keith Rollin  <krollin@apple.com>
1126
1127         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1128         https://bugs.webkit.org/show_bug.cgi?id=193781
1129         <rdar://problem/47201153>
1130
1131         Reviewed by Alex Christensen.
1132
1133         Part of generating the .xcfilelists used as part of adopting XCBuild
1134         includes running `make DerivedSources.make` from a standalone script.
1135         It’s important for this invocation to have the same environment as
1136         when the actual build invokes `make DerivedSources.make`. If the
1137         environments are different, then the two invocations will provide
1138         different results. In order to get the same environment in the
1139         standalone script, have the script launch xcodebuild targeting the
1140         "Apply Configuration to XCFileLists" build target, which will then
1141         re-invoke our standalone script. The script is now running again, this
1142         time in an environment with all workspace, project, target, xcconfig
1143         and other environment variables established.
1144
1145         The "Apply Configuration to XCFileLists" build target accomplishes
1146         this task via a small embedded shell script that consists only of:
1147
1148             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1149
1150         The process that invokes "Apply Configuration to XCFileLists" first
1151         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1152         evaluated and exports it into the shell environment. When xcodebuild
1153         is invoked, it inherits the value of this variable and can `eval` the
1154         contents of that variable. Our external standalone script can then set
1155         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1156         of command-line parameters needed to restart itself in the appropriate
1157         state.
1158
1159         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1160         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1161
1162 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1163
1164         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1165         https://bugs.webkit.org/show_bug.cgi?id=193802
1166         <rdar://problem/46010580>
1167
1168         Reviewed by Andy Estes.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1171         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1172         (TEST):
1173
1174 2019-01-25  Daniel Bates  <dabates@apple.com>
1175
1176         [iOS] uiController.keyDown() does not translate Control modified key
1177         https://bugs.webkit.org/show_bug.cgi?id=192898
1178
1179         Reviewed by Wenson Hsieh.
1180
1181         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1182         key translation, as applicable. Among other cases, key translation occurs when performing
1183         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1184         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1185         human pressing down and releasing key(s) using a hardware keyboard.
1186
1187         * WebKitTestRunner/ios/HIDEventGenerator.h:
1188         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1189         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1190
1191         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1192         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1193         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1194         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1195         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1196         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1197         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1198         (-[HIDEventGenerator longPress:completionBlock:]):
1199         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1200         Update code for above renaming.
1201
1202         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1203         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1204
1205         (-[HIDEventGenerator keyDown:]): Added.
1206         (-[HIDEventGenerator keyUp:]): Added.
1207         (-[HIDEventGenerator keyPress:completionBlock:]):
1208         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1209         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1210         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1211         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1212         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1213         (WTR::parseModifier): Deleted.
1214
1215 2019-01-25  Keith Rollin  <krollin@apple.com>
1216
1217         Complete the implementation of generate-xcfilelists
1218         https://bugs.webkit.org/show_bug.cgi?id=193782
1219
1220         Reviewed by Alex Christensen.
1221
1222         A preliminary version of generate-xcfilelists was added in r238008.
1223         This patch updates that script in order to:
1224
1225         - Support checking of .xcfilelists
1226         - Perform better execution of `make DerivedSources.make` by
1227           relaunching generate-xcfilelists under xcodebuild
1228         - Support incremental generation and checking of .xcfilelists
1229         - Support supplementary .xcfilelists files from WebKitAdditions
1230         - Support being wrapped by parallel version of generate-xcfilelists in
1231           Internal that adds support for (re)generating WebKit projects in
1232           that repo.
1233         - Support builds that have been performed in WebKitBuild as well as
1234           ~/Library/Developer/code/DerivedData
1235         - Increase robustness and debugging facilities.
1236
1237         * Scripts/generate-xcfilelists:
1238
1239 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1240
1241         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1242         https://bugs.webkit.org/show_bug.cgi?id=193297
1243         <rdar://problem/47158841>
1244
1245         Unreviewed test case fix.
1246
1247         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1248         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1249
1250         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1251         (TEST):
1252
1253 2019-01-25  Keith Rollin  <krollin@apple.com>
1254
1255         Update existing .xcfilelists
1256         https://bugs.webkit.org/show_bug.cgi?id=193791
1257         <rdar://problem/47201706>
1258
1259         Reviewed by Alex Christensen.
1260
1261         Many .xcfilelist files were added in r238824 in order to support
1262         XCBuild. Update these with recent changes to the set of build files
1263         and with the current generate-xcfilelist script.
1264
1265         * DumpRenderTree/DerivedSources-input.xcfilelist:
1266         * DumpRenderTree/DerivedSources-output.xcfilelist:
1267         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1268         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1269
1270 2019-01-25  Keith Rollin  <krollin@apple.com>
1271
1272         Fix missing dependencies in extract-dependencies-from-makefile
1273         https://bugs.webkit.org/show_bug.cgi?id=193783
1274         <rdar://problem/47201571>
1275
1276         Reviewed by Alex Christensen.
1277
1278         The extract-dependencies-from-makefile script generates .xcfilelists
1279         for XCBuild by invoking a makefile in --debug mode, parsing the
1280         dependency information in the output, and extracting information
1281         regarding targets and dependents. However, the way `make` emits this
1282         dependency information is not rigorous, and so we need to determine
1283         what lines to look for and parse by trial and error. This approach
1284         didn't coriginally atch all the information we needed to collect, so
1285         update the script to look for the additional lines we now know to look
1286         for.
1287
1288         * Scripts/extract-dependencies-from-makefile:
1289         (Parser):
1290         (Parser.addTarget):
1291         (Parser.addPrereq):
1292         (Parser.doParse):
1293
1294 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1295
1296         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1297         https://bugs.webkit.org/show_bug.cgi?id=193297
1298         <rdar://problem/47158841>
1299
1300         Reviewed by Alex Christensen.
1301
1302         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1303             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1304         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1305         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1306         activating the message used to trigger the callback when it is set.
1307
1308 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1309
1310         WKWebView.goBack should reload if there is a safe browsing warning
1311         https://bugs.webkit.org/show_bug.cgi?id=193805
1312         <rdar://problem/46908216>
1313
1314         Reviewed by Geoff Garen.
1315
1316         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1317         (+[Simple3LookupContext sharedLookupContext]):
1318         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1319         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1320         (TEST):
1321
1322 2019-01-25  Chris Dumez  <cdumez@apple.com>
1323
1324         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1325         https://bugs.webkit.org/show_bug.cgi?id=193788
1326         <rdar://problem/47531231>
1327
1328         Reviewed by Alex Christensen.
1329
1330         Add API test coverage.
1331
1332         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1333         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1334
1335 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1336
1337         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1338         https://bugs.webkit.org/show_bug.cgi?id=193771
1339
1340         Unreviewed infrastructure fix.
1341
1342         * Scripts/webkitpy/port/darwin.py:
1343         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1344
1345 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1346
1347         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1348
1349 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1350
1351         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1352
1353         * Scripts/webkitpy/common/config/contributors.json:
1354
1355 2019-01-25  Chris Dumez  <cdumez@apple.com>
1356
1357         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1358         https://bugs.webkit.org/show_bug.cgi?id=193779
1359         <rdar://problem/46170903>
1360
1361         Reviewed by Antti Koivisto.
1362
1363         Add API test that quickly navigates forward to a previous process without waiting for it to
1364         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1365         the process' previous page when reconnecting the it for the forward navigation.
1366
1367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1368
1369 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1370
1371         Need a way for JavaScript (or bundle) code to participate in undo
1372         https://bugs.webkit.org/show_bug.cgi?id=190009
1373         <rdar://problem/44807048>
1374
1375         Reviewed by Ryosuke Niwa.
1376
1377         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1378         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1379
1380         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1381         (WTR::UIScriptController::lastUndoLabel const):
1382         (WTR::UIScriptController::firstRedoLabel const):
1383         (WTR::UIScriptController::platformUndoManager const):
1384         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1385         (WTR::UIScriptController::lastUndoLabel const):
1386         (WTR::UIScriptController::firstRedoLabel const):
1387         (WTR::UIScriptController::platformUndoManager const):
1388         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1389         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1390         (WTR::UIScriptController::lastUndoLabel const):
1391         (WTR::UIScriptController::firstRedoLabel const):
1392         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1393         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1394         (WTR::UIScriptController::lastUndoLabel const):
1395         (WTR::UIScriptController::firstRedoLabel const):
1396         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1397         (WTR::UIScriptController::platformUndoManager const):
1398         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1399         (WTR::UIScriptController::platformUndoManager const):
1400
1401 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1402
1403         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1404         https://bugs.webkit.org/show_bug.cgi?id=193824
1405
1406         Reviewed by Antti Koivisto.
1407
1408         * LayoutReloaded/misc/LFC-passing-tests.txt:
1409
1410 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1411
1412         Update macOS JSC bot configurations
1413         https://bugs.webkit.org/show_bug.cgi?id=193739
1414
1415         Reviewed by Alexey Proskuryakov.
1416
1417         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1419         (BubbleQueueServer): Move JSC EWS to Mojave section.
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1421         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1422         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1423
1424 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1425
1426         [Win][WebKitTestRunner] Implement EventSenderProxy
1427         https://bugs.webkit.org/show_bug.cgi?id=193755
1428
1429         Reviewed by Don Olmstead.
1430
1431         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1432         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1433         (WTR::EventSenderProxy::dispatchMessage):
1434         (WTR::EventSenderProxy::EventSenderProxy):
1435         (WTR::EventSenderProxy::mouseDown):
1436         (WTR::EventSenderProxy::mouseUp):
1437         (WTR::EventSenderProxy::mouseMoveTo):
1438         (WTR::EventSenderProxy::mouseScrollBy):
1439         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1440
1441 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1442
1443         Unreviewed fix for API test failure after r240437.
1444
1445         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1446
1447         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1448
1449 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1450
1451         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1452         https://bugs.webkit.org/show_bug.cgi?id=193787
1453         <rdar://problem/47497634>
1454
1455         Reviewed by Alexey Proskuryakov.
1456
1457         * Scripts/webkitdirs.pm:
1458         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1459
1460 2019-01-24  Truitt Savell  <tsavell@apple.com>
1461
1462         Unreviewed, rolling out r240446.
1463
1464         Casued 5 API failures
1465
1466         Reverted changeset:
1467
1468         "Activate the WebResourceLoadStatisticsStore in the
1469         NetworkProcess and deactivate it in the UIProcess."
1470         https://bugs.webkit.org/show_bug.cgi?id=193297
1471         https://trac.webkit.org/changeset/240446
1472
1473 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1474
1475         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1476         https://bugs.webkit.org/show_bug.cgi?id=193741
1477         <rdar://problem/47135030>
1478
1479         Reviewed by Antti Koivisto and Simon Fraser.
1480
1481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1482         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1483         (TestWebKitAPI::TEST):
1484
1485 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1486
1487         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1488         https://bugs.webkit.org/show_bug.cgi?id=193297
1489         <rdar://problem/47158841>
1490
1491         Reviewed by Alex Christensen.
1492
1493         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1494         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1495         activating the message used to trigger the callback when it is set.
1496
1497 2019-01-24  John Wilander  <wilander@apple.com>
1498
1499         Add Ad Click Attribution as an internal/experimental feature
1500         https://bugs.webkit.org/show_bug.cgi?id=193685
1501         <rdar://problem/47450399>
1502
1503         Reviewed by Brent Fulgham.
1504
1505         Added test option adClickAttributionEnabled.
1506
1507         * DumpRenderTree/TestOptions.cpp:
1508         (TestOptions::TestOptions):
1509         * DumpRenderTree/TestOptions.h:
1510         * DumpRenderTree/mac/DumpRenderTree.mm:
1511         (setWebPreferencesForTestOptions):
1512
1513 2019-01-24  Antti Koivisto  <antti@apple.com>
1514
1515         [PSON] Flash on back navigation on Mac
1516         https://bugs.webkit.org/show_bug.cgi?id=193716
1517         <rdar://problem/47148458>
1518
1519         Reviewed by Chris Dumez.
1520
1521         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1522
1523         Closing of the previous page is delayed so waiting for didFinishNavigation is
1524         not sufficient to guarantee we have received all the messages. Wait for them.
1525
1526 2019-01-24  Chris Dumez  <cdumez@apple.com>
1527
1528         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1529         https://bugs.webkit.org/show_bug.cgi?id=193761
1530         <rdar://problem/47456405>
1531
1532         Reviewed by Alex Christensen.
1533
1534         Add API test coverage.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1537
1538 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1539
1540         webkitpy: Missing PID in crashlog name should not be fatal
1541         https://bugs.webkit.org/show_bug.cgi?id=193771
1542
1543         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1544         of raising an exception.
1545
1546         Reviewed by Lucas Forschler.
1547
1548         * Scripts/webkitpy/port/darwin.py:
1549         (DarwinPort._merge_crash_logs):
1550
1551 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1552
1553         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1554         https://bugs.webkit.org/show_bug.cgi?id=193746
1555
1556         Reviewed by Youenn Fablet.
1557
1558         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1559         so we'd best just not call it.
1560
1561         * Scripts/webkitpy/w3c/test_exporter.py:
1562         (WebPlatformTestExporter.create_branch_with_patch):
1563
1564 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1565
1566         Move FileSystem to WTF
1567         https://bugs.webkit.org/show_bug.cgi?id=193602
1568
1569         Reviewed by Yusuke Suzuki.
1570
1571         * DumpRenderTree/win/DumpRenderTree.cpp:
1572         * TestWebKitAPI/CMakeLists.txt:
1573         * TestWebKitAPI/PlatformGTK.cmake:
1574         * TestWebKitAPI/PlatformJSCOnly.cmake:
1575         * TestWebKitAPI/PlatformPlayStation.cmake:
1576         * TestWebKitAPI/PlatformWPE.cmake:
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1579         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1580         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1581         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1582         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1583         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1584         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1585         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1586         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1587
1588 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1589
1590         [WPE] Remove hard dependency on subprocess32 for the API tests
1591
1592         Rubber-stamped by Carlos Garcia Campos.
1593
1594         * glib/api_test_runner.py:
1595         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1596         its presence only when running WPEQt tests.
1597
1598 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1599
1600         [GLIB] Expose JavaScriptCore options in GLib public API
1601         https://bugs.webkit.org/show_bug.cgi?id=188742
1602
1603         Reviewed by Michael Catanzaro.
1604
1605         Add a test for the new API.
1606
1607         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1608         (testsJSCOptions):
1609         (main):
1610
1611 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1612
1613         [GTK][WPE] Support JPEG 2000 images
1614         https://bugs.webkit.org/show_bug.cgi?id=186272
1615
1616         Reviewed by Žan Doberšek.
1617
1618         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1619
1620         * gtk/jhbuild.modules:
1621         * wpe/jhbuild.modules:
1622
1623 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1624
1625         check-webkit-style should warn when using soft-linking macros in a header
1626         <https://webkit.org/b/193750>
1627
1628         Reviewed by Darin Adler.
1629
1630         * Scripts/webkitpy/style/checkers/cpp.py:
1631         (check_language): Add softlink/header check by refactoring the
1632         softlink/framework check.
1633         (CppChecker): Enable softlink/header check by default.
1634         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1635         (CppStyleTest.test_softlink_framework): Rename from
1636         CppStyleTest.test_softlink() and change test framework name in
1637         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1638         files. Set file_name for macros that only appear in headers.
1639         (CppStyleTest.test_softlink_header): Add tests for using
1640         soft-link macros in headers.
1641
1642 2019-01-23  Chris Dumez  <cdumez@apple.com>
1643
1644         Deprecate API to limit the maximum number of WebProcesses
1645         https://bugs.webkit.org/show_bug.cgi?id=193725
1646         <rdar://problem/47464879>
1647
1648         Reviewed by Geoff Garen.
1649
1650         Update existing API tests to stop using deprecated API.
1651
1652         * MiniBrowser/mac/AppDelegate.m:
1653         (defaultConfiguration):
1654         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1657         (TestWebKitAPI::TEST):
1658         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1659         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1660         (TEST):
1661         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1662         (TEST):
1663
1664 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-app] Rename ews model buildermappings to buildermapping
1667         https://bugs.webkit.org/show_bug.cgi?id=193729
1668
1669         Reviewed by Lucas Forschler.
1670
1671         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1672         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1673         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1674
1675 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1676
1677         [ews-app] Rename ews model steps to step
1678         https://bugs.webkit.org/show_bug.cgi?id=193697
1679
1680         Reviewed by Lucas Forschler.
1681
1682         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1683         (Step): Renamed Steps to Step.
1684
1685 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1686
1687         Clean up IndexedDB files between tests
1688         https://bugs.webkit.org/show_bug.cgi?id=192796
1689         <rdar://problem/46824999>
1690
1691         Reviewed by Geoffrey Garen.
1692
1693         * DumpRenderTree/mac/DumpRenderTree.mm:
1694         (runTest):
1695         * WebKitTestRunner/TestController.cpp:
1696         (WTR::TestController::resetStateToConsistentValues):
1697         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1698         (WTR::RemoveAllIndexedDatabasesCallback):
1699         (WTR::TestController::ClearIndexedDatabases):
1700         * WebKitTestRunner/TestController.h:
1701         * WebKitTestRunner/TestInvocation.cpp:
1702         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1703
1704 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-app] Rename ews model Builds to Build
1707         https://bugs.webkit.org/show_bug.cgi?id=193695
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1712         (Build): Renamed Builds to Build.
1713
1714 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1715
1716         webkitpy: Wait longer when launching WebKitTestRunner
1717         https://bugs.webkit.org/show_bug.cgi?id=193734
1718
1719         Reviewed by Aakash Jain.
1720
1721         * Scripts/webkitpy/port/simulator_process.py:
1722         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1723
1724 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1725
1726         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1727         https://bugs.webkit.org/show_bug.cgi?id=193182
1728         <rdar://problem/47452154>
1729
1730         Reviewed by Tim Horton.
1731
1732         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1733         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1734         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1735
1736         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1737         preventing later tests from recognizing gestures.
1738
1739         * WebKitTestRunner/ios/TestControllerIOS.mm:
1740         (WTR::TestController::platformResetStateToConsistentValues):
1741
1742         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1743
1744 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1745
1746         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1747         https://bugs.webkit.org/show_bug.cgi?id=193722
1748         <rdar://problem/47481475>
1749
1750         Reviewed by Lucas Forschler.
1751
1752         iPhone and iPad ports should both use the iOS config.
1753
1754         * Scripts/webkitpy/port/ios_simulator.py:
1755         (IPhoneSimulatorPort.__init__):
1756         (IPadSimulatorPort.__init__):
1757
1758 2019-01-23  Rob Buis  <rbuis@igalia.com>
1759
1760         Update MIME type parser
1761         https://bugs.webkit.org/show_bug.cgi?id=180526
1762
1763         Reviewed by Frédéric Wang.
1764
1765         Add unit tests for both parse modes of ParsedContentType.
1766
1767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1768         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1769         (TestWebKitAPI::TEST):
1770
1771 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1772
1773         [ews-app] fetch loop should not stop on network issues
1774         https://bugs.webkit.org/show_bug.cgi?id=193666
1775
1776         Reviewed by Lucas Forschler.
1777
1778         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1779         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1780
1781 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1782
1783         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1784         https://bugs.webkit.org/show_bug.cgi?id=189165
1785         <rdar://problem/47433765>
1786
1787         Reviewed by Tim Horton.
1788
1789         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1790         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1791         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1792         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1793         would make its way to the UI process by the time the layer tree commit is finished.
1794
1795         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1796         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1797         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1798         will fail because it asks for -_autofillContext too early.
1799
1800         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1801         is handled in the UI process.
1802
1803         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1804
1805         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1806         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1807         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1808         input session.
1809
1810         (-[AutofillTestView textInputHasAutofillContext]):
1811
1812         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1813
1814         * TestWebKitAPI/cocoa/TestWKWebView.h:
1815         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1816         (nextInputSessionChangeCount):
1817
1818         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1819         This includes changing the focused element from one to another.
1820
1821         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1822         (-[TestWKWebView didStartFormControlInteraction]):
1823         (-[TestWKWebView didEndFormControlInteraction]):
1824         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1825
1826         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1827         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1828         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1829         that doesn't require an input session to one that doesn't.
1830
1831 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1832
1833         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1834         <https://webkit.org/b/193676>
1835
1836         Reviewed by Alexey Proskuryakov.
1837
1838         * Scripts/webkitpy/style/checkers/cpp.py:
1839         (check_member_initialization_list):
1840         - Don't report missing whitespace around colon if the colon at
1841           the start of the line is formatted correctly.
1842         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1843         (WebKitStyleTest.test_member_initialization_list):
1844         - Add a test for a missing permutation of existing tests.
1845         - Add a test this false-positive.
1846         - Add blank lines between subtests to make them easier to read.
1847
1848 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1849
1850         [build.webkit.org] Unit-test failure after r237113
1851         https://bugs.webkit.org/show_bug.cgi?id=193669
1852
1853         Reviewed by Michael Catanzaro.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1856         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1857         multiple or zero flags.
1858
1859 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1860
1861         Cache bytecode to disk
1862         https://bugs.webkit.org/show_bug.cgi?id=192782
1863         <rdar://problem/46084932>
1864
1865         Reviewed by Keith Miller.
1866
1867         Add test helper to execute bytecode-cache tests: it executes each test
1868         twice, the first with JSC_diskCachePath set to a temporary directory
1869         and second with JSC_forceDiskCache=true (in addition to the cache path)
1870         to guarantee that only the disk cache is being used and no new
1871         UnlinkedCodeBlocks are being created.
1872
1873         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1874         * Scripts/run-jsc-stress-tests:
1875
1876 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1877
1878         [css-logical] Implement flow-relative margin, padding and border shorthands
1879         https://bugs.webkit.org/show_bug.cgi?id=188697
1880
1881         Reviewed by Simon Fraser and Antti Koivisto.
1882
1883         * DumpRenderTree/TestOptions.cpp:
1884         (TestOptions::TestOptions):
1885         * DumpRenderTree/TestOptions.h:
1886         * DumpRenderTree/mac/DumpRenderTree.mm:
1887         (setWebPreferencesForTestOptions):
1888         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1889
1890         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1891         (JSONCSSPropertiesChecker.check_codegen_properties):
1892         Allow CSS property definitions to have a 'runtime-flag' parameter which
1893         disables the property when the specified runtime flag is disabled.
1894
1895 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1896
1897         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1898         https://bugs.webkit.org/show_bug.cgi?id=193643
1899
1900         Reviewed by Michael Catanzaro.
1901
1902         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1903         * wpe/jhbuild.modules: Ditto.
1904
1905 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1906
1907         [LFC][Floats] Take float top position into account when computing containing block height.
1908         https://bugs.webkit.org/show_bug.cgi?id=193655
1909
1910         Reviewed by Antti Koivisto.
1911
1912         * LayoutReloaded/misc/LFC-passing-tests.txt:
1913
1914 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1915
1916         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1917         <https://webkit.org/b/193645>
1918         <rdar://problem/47421574>
1919
1920         Reviewed by Alex Christensen.
1921
1922         - Now checks for local soft-linking of all frameworks that have
1923           their own *SoftLinking.{cpp,h,mm} files.
1924         - Changes softlink/uikit warning to softlink/framework.
1925
1926         * Scripts/webkitpy/style/checkers/cpp.py:
1927         (check_language):
1928         (CppChecker):
1929         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1930         (CppStyleTest):
1931
1932 2019-01-20  Saam Barati  <sbarati@apple.com>
1933
1934         Rollout r240210: It broke tests on iOS
1935         https://bugs.webkit.org/show_bug.cgi?id=193640
1936
1937         Unreviewed.
1938
1939         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1940         * Scripts/run-jsc-stress-tests:
1941
1942 2019-01-20  chris fleizach  <cfleizach@apple.com>
1943
1944         AX: Support returning relative frames for accessibility
1945         https://bugs.webkit.org/show_bug.cgi?id=193414
1946         <rdar://problem/47268501>
1947
1948         Reviewed by Zalan Bujtas.
1949
1950         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1951         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1952         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1953         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1954         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1955         (WTR::attributesOfElement):
1956         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1957
1958 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1959
1960         Unreviewed, add my new email address
1961
1962         * Scripts/webkitpy/common/config/contributors.json:
1963
1964 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1965
1966         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1967         https://bugs.webkit.org/show_bug.cgi?id=193617
1968
1969         Reviewed by Antti Koivisto.
1970
1971         * LayoutReloaded/misc/LFC-passing-tests.txt:
1972
1973 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1974
1975         Unreviewed, rolling out r240209.
1976
1977         Broke GTK/WPE injected bundle
1978
1979         Reverted changeset:
1980
1981         "AX: Support returning relative frames for accessibility"
1982         https://bugs.webkit.org/show_bug.cgi?id=193414
1983         https://trac.webkit.org/changeset/240209
1984
1985 2019-01-12  Dan Bernstein  <mitz@apple.com>
1986
1987         [Cocoa] Avoid importing directly from subumbrella frameworks
1988         https://bugs.webkit.org/show_bug.cgi?id=186016
1989         <rdar://problem/40591038>
1990
1991         Reviewed by Sam Weinig.
1992
1993         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1994           LaunchServices header.
1995         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1996           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1997         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1998           when using SDKs earlier than 10.13.
1999         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2000           and OTHER_CPLUSPLUSFLAGS.
2001         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2002           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2003         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2004           LaunchServices header.
2005
2006 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2007
2008         Cache bytecode to disk
2009         https://bugs.webkit.org/show_bug.cgi?id=192782
2010         <rdar://problem/46084932>
2011
2012         Reviewed by Keith Miller.
2013
2014         Add test helper to execute bytecode-cache tests: it executes each test
2015         twice, the first with JSC_diskCachePath set to a temporary directory
2016         and second with JSC_forceDiskCache=true (in addition to the cache path)
2017         to guarantee that only the disk cache is being used and no new
2018         UnlinkedCodeBlocks are being created.
2019
2020         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2021         * Scripts/run-jsc-stress-tests:
2022
2023 2019-01-20  chris fleizach  <cfleizach@apple.com>
2024
2025         AX: Support returning relative frames for accessibility
2026         https://bugs.webkit.org/show_bug.cgi?id=193414
2027         <rdar://problem/47268501>
2028
2029         Reviewed by Zalan Bujtas.
2030
2031         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2032         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2033         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2034         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2035         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2036         (WTR::attributesOfElement):
2037         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2038
2039 2019-01-20  Antoine Quint  <graouts@apple.com>
2040
2041         Add a POINTER_EVENTS feature flag
2042         https://bugs.webkit.org/show_bug.cgi?id=193577
2043         <rdar://problem/47408511>
2044
2045         Unreviewed. Also enable Pointer Events for iosmac.
2046
2047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2048
2049 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2050
2051         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2052         https://bugs.webkit.org/show_bug.cgi?id=193613
2053
2054         Reviewed by Antti Koivisto.
2055
2056         * LayoutReloaded/misc/LFC-passing-tests.txt:
2057
2058 2019-01-19  Antoine Quint  <graouts@apple.com>
2059
2060         Add a POINTER_EVENTS feature flag
2061         https://bugs.webkit.org/show_bug.cgi?id=193577
2062
2063         Reviewed by Dean Jackson.
2064
2065         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2066
2067 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2068
2069         Disable the run-jsc-stress-test remote host key check [second round].
2070         https://bugs.webkit.org/show_bug.cgi?id=192988
2071
2072         Reviewed by Dewei Zhu.
2073
2074         * Scripts/run-jsc-stress-tests:
2075
2076 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2077
2078         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2079         https://bugs.webkit.org/show_bug.cgi?id=193597
2080
2081         Reviewed by Lucas Forschler.
2082
2083         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2084
2085 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2086
2087         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2088         https://bugs.webkit.org/show_bug.cgi?id=193595
2089
2090         Reviewed by Lucas Forschler.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2093         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2094         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2095
2096 2019-01-18  Chris Dumez  <cdumez@apple.com>
2097
2098         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2099         https://bugs.webkit.org/show_bug.cgi?id=193588
2100         <rdar://problem/47131566>
2101
2102         Reviewed by Alex Christensen.
2103
2104         Add layout test coverage.
2105
2106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2107
2108 2019-01-18  Jer Noble  <jer.noble@apple.com>
2109
2110         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2111         https://bugs.webkit.org/show_bug.cgi?id=189553
2112
2113         Reviewed by Tim Horton.
2114
2115         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2116
2117         * ContentExtensionTester/Configurations/Base.xcconfig:
2118         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2119         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2120         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2121         * ImageDiff/cg/Configurations/Base.xcconfig:
2122         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2123         * MiniBrowser/Configurations/Base.xcconfig:
2124         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2125         * MobileMiniBrowser/Configurations/Base.xcconfig:
2126         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2127         * Scripts/webkitpy/style/checker.py:
2128         (_all_categories):
2129         (FileType):
2130         (CheckerDispatcher._file_type):
2131         (CheckerDispatcher._create_checker):
2132         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2133         (SDKVariantChecker):
2134         (SDKVariantChecker.__init__):
2135         (SDKVariantChecker.check):
2136         * TestWebKitAPI/Configurations/Base.xcconfig:
2137         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2138         * WebEditingTester/Configurations/Base.xcconfig:
2139         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2140         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2141         * WebKitTestRunner/Configurations/Base.xcconfig:
2142         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2143         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2144         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2145
2146 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2147
2148         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2149         <https://webkit.org/b/193568>
2150         <rdar://problem/47381130>
2151
2152         Reviewed by Alex Christensen.
2153
2154         Make sure no one re-introduces UIKit soft-linking by adding a
2155         style rule.
2156
2157         * Scripts/webkitpy/style/checkers/cpp.py:
2158         (check_language): Add softlink/uikit check.
2159         (CppChecker): Enable softlink/uikit check.
2160         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2161         (CppStyleTest): Add test for softlink/uikit.
2162
2163 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2164
2165         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2166         https://bugs.webkit.org/show_bug.cgi?id=193584
2167
2168         Change "-dev" to "-devel".
2169
2170         Reviewed by Michael Catanzaro.
2171
2172         * gtk/install-dependencies:
2173
2174 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2175
2176         webkitpy: Add iPhone and iPad ports
2177         https://bugs.webkit.org/show_bug.cgi?id=193537
2178         <rdar://problem/47353390>
2179
2180         Reviewed by Lucas Forschler.
2181
2182         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2183         ports. Note that this separation is optional, the --ios-simulator command remains.
2184
2185         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2186         (RunTest.test_device_type_test_division): Drive-by fix.
2187         (RunTest.test_device_type_specific_listing): Ditto.
2188         (RunTest.test_ipad_test_division):
2189         (RunTest):
2190         (RunTest.test_ipad_listing):
2191         * Scripts/webkitpy/port/factory.py:
2192         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2193         (PortFactory):
2194         * Scripts/webkitpy/port/ios_simulator.py:
2195         (IPhoneSimulatorPort):
2196         (IPadSimulatorPort):
2197
2198 2019-01-18  Chris Dumez  <cdumez@apple.com>
2199
2200         Regression(PSON) Scroll position is not always restored properly when navigating back
2201         https://bugs.webkit.org/show_bug.cgi?id=193578
2202         <rdar://problem/47386331>
2203
2204         Reviewed by Tim Horton.
2205
2206         Add API test coverage.
2207
2208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2209
2210 2019-01-18  Youenn Fablet  <youenn@apple.com>
2211
2212         Add a new SPI to request for cache storage quota increase
2213         https://bugs.webkit.org/show_bug.cgi?id=193323
2214
2215         Reviewed by Alex Christensen.
2216
2217         Implement WebsiteDataStore quota delegate to handle quota requests.
2218         By default, do not update quota.
2219         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2220
2221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2223         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2225         * WebKitTestRunner/TestController.cpp:
2226         (WTR::TestController::allowCacheStorageQuotaIncrease):
2227         * WebKitTestRunner/TestController.h:
2228         * WebKitTestRunner/TestInvocation.cpp:
2229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2230         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2231         (-[CacheStorageQuotaManager init]):
2232         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2233         (WTR::initializeWebViewConfiguration):
2234         (WTR::TestController::cocoaResetStateToConsistentValues):
2235         (WTR::TestController::allowCacheStorageQuotaIncrease):
2236
2237 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2238
2239         [ews-build] Pass owner to the triggered builds
2240         https://bugs.webkit.org/show_bug.cgi?id=193574
2241
2242         Reviewed by Lucas Forschler.
2243
2244         * BuildSlaveSupport/ews-build/factories.py:
2245         (BuildFactory.propertiesToPassToTriggers):
2246
2247 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2248
2249         [ews-app] Send patch author as a build property
2250         https://bugs.webkit.org/show_bug.cgi?id=193560
2251
2252         Reviewed by Lucas Forschler.
2253
2254         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2255         (BugzillaPatchFetcher.fetch):
2256
2257 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2258
2259         webkitpy: Implement device type specific expected results (Follow-up fix)
2260         https://bugs.webkit.org/show_bug.cgi?id=192162
2261         <rdar://problem/46345449>
2262
2263         Unreviewed infrastructure fix.
2264
2265         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2266         (Manager.run): Don't boot a device if no tests are available to run on it.
2267
2268 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2269
2270         webkitpy: Implement device type specific expected results (Follow-up fix)
2271         https://bugs.webkit.org/show_bug.cgi?id=192162
2272         <rdar://problem/46345449>
2273
2274         Unreviewed infrastructure fix.
2275
2276         * Scripts/webkitpy/api_tests/manager.py:
2277         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2278
2279 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2280
2281         webkitpy: Implement device type specific expected results (Part 2)
2282         https://bugs.webkit.org/show_bug.cgi?id=192162
2283         <rdar://problem/46345449>
2284
2285         Rubber-stamped by Aakash Jain.
2286
2287         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2288         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2289         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2290
2291         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2292         (LayoutTestFinder.find_tests): Pass device_type through.
2293         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2294         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2295         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2296         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2297         (Manager._collect_tests): Pass device type to test finder.
2298         (Manager._needs_web_platform_test):
2299         (Manager._prepare_lists): Index _expectations by device type.
2300         (Manager._test_input_for_file):
2301         (Manager._test_is_slow): Ditto.
2302         (Manager._test_should_dump_jsconsolelog_in_stderr):
2303         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2304         (Manager._get_test_inputs):
2305         (Manager._update_worker_count):
2306         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2307         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2308         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2309         the one which runs the test.
2310         (Manager._run_test_subset):
2311         (Manager._run_tests): Index _expectations by current_device_type.
2312         (Manager._print_expectation_line_for_test): Ditto.
2313         (Manager._print_expectations_for_subset): Ditto.
2314         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2315         Unlike run, this function will behave the same regardless of what devices are available.
2316         (Manager._custom_device_for_test): Deleted.
2317         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2318         (ManagerTest.test_uses_custom_device): Deleted.
2319         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2320         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2321         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2322         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2323         all of the expectations.
2324         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2325         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2326         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2327         (TestExpectations.__init__): Allow device_type to be passed through.
2328         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2329         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2330         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2331         (summarize_results):
2332         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2333         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2334         a test ran with, one must check all expectations to find the first non-skip expectation.
2335         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2336         (RunTest.test_device_type_test_division):
2337         (RunTest):
2338         (RunTest.test_device_type_specific_listing):
2339         * Scripts/webkitpy/port/base.py:
2340         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2341         (Port.supported_device_types): The result of this function will change based on what devices are available.
2342         * Scripts/webkitpy/port/device_port.py:
2343         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2344         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2345         can be used.
2346         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2347         any, or the DEFAULT_DEVICE_TYPES of the port.
2348         * Scripts/webkitpy/port/ios.py:
2349         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2350         * Scripts/webkitpy/port/ios_simulator.py:
2351         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2352         * Scripts/webkitpy/port/watch.py:
2353         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2354         * Scripts/webkitpy/port/watch_simulator.py:
2355         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2356         * Scripts/webkitpy/xcode/device_type.py:
2357         (DeviceType):
2358         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2359
2360 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2361
2362         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2363         https://bugs.webkit.org/show_bug.cgi?id=193575
2364
2365         Reviewed by Michael Catanzaro.
2366
2367         Allow the script to run without explicit port argument because
2368         it's specific to the WPE port anyway.
2369
2370         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2371         and simplify the rest of the code accordingly.
2372
2373 2019-01-18  Charlie Turner  <cturner@igalia.com>
2374
2375         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2376         https://bugs.webkit.org/show_bug.cgi?id=192229
2377
2378         Reviewed by Xabier Rodriguez-Calvar.
2379
2380         * MiniBrowser/wpe/main.cpp:
2381         (main): Enable encrypted-media by default.
2382
2383 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2384
2385         [Flatpak] Missing KeyboardInterrupt exception handler
2386         https://bugs.webkit.org/show_bug.cgi?id=193570
2387
2388         Reviewed by Michael Catanzaro.
2389
2390         * flatpak/flatpakutils.py:
2391         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2392
2393 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2394
2395         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2396         https://bugs.webkit.org/show_bug.cgi?id=193564
2397
2398         Reviewed by Antti Koivisto.
2399
2400         * LayoutReloaded/misc/LFC-passing-tests.txt:
2401
2402 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2403
2404         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2405         https://bugs.webkit.org/show_bug.cgi?id=193562
2406
2407         Reviewed by Antti Koivisto.
2408
2409         * LayoutReloaded/misc/LFC-passing-tests.txt:
2410
2411 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2412
2413         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2414         https://bugs.webkit.org/show_bug.cgi?id=193555
2415
2416         Reviewed by Antti Koivisto.
2417
2418         * LayoutReloaded/misc/LFC-passing-tests.txt:
2419
2420 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2421
2422         [WPE] Add Qt extension
2423         https://bugs.webkit.org/show_bug.cgi?id=191464
2424
2425         Reviewed by Carlos Garcia Campos.
2426
2427         MiniBrowser and API tests for the WPE Qt API. To run the
2428         MiniBrowser a new script is introduced. Example invocation:
2429
2430         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2431
2432         Also note-worthy is the introduction of the python2-subprocess32
2433         dependency to run the GLib API tests.
2434
2435         * MiniBrowser/wpe/CMakeLists.txt:
2436         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2437         * MiniBrowser/wpe/qt/main.cpp: Added.
2438         (main):
2439         * MiniBrowser/wpe/qt/main.qml: Added.
2440         * MiniBrowser/wpe/qt/qml.qrc: Added.
2441         * Scripts/run-gtk-tests:
2442         (GtkTestRunner.is_google_test):
2443         (GtkTestRunner):
2444         (GtkTestRunner.is_qt_test):
2445         * Scripts/run-qt-wpe-minibrowser: Added.
2446         * Scripts/run-wpe-tests:
2447         (WPETestRunner):
2448         (WPETestRunner.is_google_test):
2449         (WPETestRunner.is_qt_test):
2450         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2451         (TestLoad::main):
2452         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2453         (TestLoadHtml::main):
2454         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2455         (TestLoadRequest::main):
2456         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2457         (TestRunJavaScript::main):
2458         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2459         (waitForSignal):
2460         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2461         (LoadSpy::LoadSpy):
2462         (LoadSpy::~LoadSpy):
2463         (LoadSpy::onLoadingChanged):
2464         (LoadStartedCatcher::LoadStartedCatcher):
2465         (LoadStartedCatcher::~LoadStartedCatcher):
2466         (LoadStartedCatcher::onLoadingChanged):
2467         (waitForLoadSucceeded):
2468         (waitForLoadFailed):
2469         * TestWebKitAPI/glib/CMakeLists.txt:
2470         * flatpak/flatpakutils.py:
2471         (WebkitFlatpak.load_from_args):
2472         (WebkitFlatpak.__init__):
2473         (WebkitFlatpak.clean_args):
2474         (WebkitFlatpak.run_in_sandbox):
2475         * flatpak/org.webkit.CommonModules.yaml:
2476         * flatpak/org.webkit.WPE.yaml:
2477         * flatpak/org.webkit.WPEModules.yaml:
2478         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2479         * flatpak/org.webkit.WebKit.yaml:
2480         * glib/api_test_runner.py:
2481         (TestRunner._run_test_qt):
2482         (TestRunner.is_qt_test):
2483         (TestRunner._run_test):
2484
2485 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2486
2487         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2488         https://bugs.webkit.org/show_bug.cgi?id=193494
2489         <rdar://problem/46859627>
2490
2491         Reviewed by Simon Fraser and Tim Horton.
2492
2493         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2494         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2495
2496         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2497         (WTR::UIScriptController::contentOffsetX const):
2498         (WTR::UIScriptController::contentOffsetY const):
2499         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2500         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2501         (WTR::UIScriptController::contentOffsetX const):
2502         (WTR::UIScriptController::contentOffsetY const):
2503         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2504
2505         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2506
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::updateTestOptionsFromTestHeader):
2509         * WebKitTestRunner/TestOptions.h:
2510         (WTR::TestOptions::hasSameInitializationOptions const):
2511         * WebKitTestRunner/ios/TestControllerIOS.mm:
2512         (WTR::TestController::platformResetStateToConsistentValues):
2513         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2514         (WTR::UIScriptController::contentOffsetX const):
2515         (WTR::UIScriptController::contentOffsetY const):
2516
2517 2019-01-17  Truitt Savell  <tsavell@apple.com>
2518
2519         Unreviewed, rolling out r240124.
2520
2521         This commit broke an internal build.
2522
2523         Reverted changeset:
2524
2525         "SDK_VARIANT build destinations should be separate from non-
2526         SDK_VARIANT builds"
2527         https://bugs.webkit.org/show_bug.cgi?id=189553
2528         https://trac.webkit.org/changeset/240124
2529
2530 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2531
2532         Fix string concatenation API test after r239920
2533         https://bugs.webkit.org/show_bug.cgi?id=193551
2534         <rdar://problem/47359304>
2535
2536         Reviewed by Youenn Fablet.
2537
2538         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2539         (TestWebKitAPI::TEST):
2540         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2541         in WebKit's build configuration like it apparently is on Linux.
2542
2543 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2544
2545         [ews-build] validate-patch should handle the case when bug_id is None
2546         https://bugs.webkit.org/show_bug.cgi?id=193547
2547
2548         Reviewed by Lucas Forschler.
2549
2550         * BuildSlaveSupport/ews-build/steps.py:
2551         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2552         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2553
2554 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2555
2556         [ews-build] Add patch author information in build
2557         https://bugs.webkit.org/show_bug.cgi?id=193465
2558
2559         Reviewed by Lucas Forschler.
2560
2561         * BuildSlaveSupport/ews-build/steps.py:
2562         (ValidatePatch._is_patch_obsolete):
2563
2564 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2565
2566         [ews-build] Pass bug_id to the triggered builds
2567         https://bugs.webkit.org/show_bug.cgi?id=193548
2568
2569         Reviewed by Lucas Forschler.
2570
2571         * BuildSlaveSupport/ews-build/factories.py:
2572         (BuildFactory.propertiesToPassToTriggers):
2573
2574 2019-01-17  Jer Noble  <jer.noble@apple.com>
2575
2576         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2577         https://bugs.webkit.org/show_bug.cgi?id=189553
2578
2579         Reviewed by Tim Horton.
2580
2581         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2582
2583         * ContentExtensionTester/Configurations/Base.xcconfig:
2584         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2585         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2586         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2587         * ImageDiff/cg/Configurations/Base.xcconfig:
2588         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2589         * MiniBrowser/Configurations/Base.xcconfig:
2590         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2591         * MobileMiniBrowser/Configurations/Base.xcconfig:
2592         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2593         * Scripts/webkitpy/style/checker.py:
2594         (_all_categories):
2595         (FileType):
2596         (CheckerDispatcher._file_type):
2597         (CheckerDispatcher._create_checker):
2598         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2599         (SDKVariantChecker):
2600         (SDKVariantChecker.__init__):
2601         (SDKVariantChecker.check):
2602         * TestWebKitAPI/Configurations/Base.xcconfig:
2603         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2604         * WebEditingTester/Configurations/Base.xcconfig:
2605         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2606         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2607         * WebKitTestRunner/Configurations/Base.xcconfig:
2608         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2609         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2610         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2611
2612 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2613
2614         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2615         https://bugs.webkit.org/show_bug.cgi?id=193534
2616
2617         Reviewed by Antti Koivisto.
2618
2619         * LayoutReloaded/misc/LFC-passing-tests.txt:
2620
2621 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2622
2623         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2624         https://bugs.webkit.org/show_bug.cgi?id=193528
2625
2626         Reviewed by Antti Koivisto.
2627
2628         * LayoutReloaded/misc/LFC-passing-tests.txt:
2629
2630 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2631
2632         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2633         https://bugs.webkit.org/show_bug.cgi?id=193520
2634
2635         Reviewed by Antti Koivisto.
2636
2637         * LayoutReloaded/misc/LFC-passing-tests.txt:
2638
2639 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-build] unapply-patch step should not update source
2642         https://bugs.webkit.org/show_bug.cgi?id=193234
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-build/steps.py:
2647         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2648         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2649
2650 2019-01-16  Youenn Fablet  <youenn@apple.com>
2651
2652         Add a new SPI for controlling getUserMedia
2653         https://bugs.webkit.org/show_bug.cgi?id=192793
2654
2655         Reviewed by Eric Carlson.
2656
2657         * MiniBrowser/mac/WK2BrowserWindowController.m:
2658         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2659         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2660         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2661         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2662         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2663         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2664         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2665         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2666         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2667         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2668         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2669         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2670         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2671         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2672
2673 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2674
2675         [LFC][BFC] Inflow non-replaced used width should not be negative.
2676         https://bugs.webkit.org/show_bug.cgi?id=193495
2677
2678         Reviewed by Antti Koivisto.
2679
2680         * LayoutReloaded/misc/LFC-passing-tests.txt:
2681
2682 2019-01-16  Chris Dumez  <cdumez@apple.com>
2683
2684         Regression(PSON) View becomes blank after click a cross-site download link
2685         https://bugs.webkit.org/show_bug.cgi?id=193361
2686         <rdar://problem/47099573>
2687
2688         Reviewed by Geoffrey Garen.
2689
2690         Add API test coverage.
2691
2692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2693         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2694
2695 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2696
2697         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2698         https://bugs.webkit.org/show_bug.cgi?id=193470
2699
2700         Reviewed by Antti Koivisto.
2701
2702         * LayoutReloaded/misc/LFC-passing-tests.txt:
2703
2704 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2705
2706         [LFC] Adjust margin box verification.
2707         https://bugs.webkit.org/show_bug.cgi?id=193482
2708
2709         Reviewed by Antti Koivisto.
2710
2711         * LayoutReloaded/misc/LFC-passing-tests.txt:
2712
2713 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2714
2715         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2716         https://bugs.webkit.org/show_bug.cgi?id=193451
2717
2718         Reviewed by Geoffrey Garen.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2721         (TEST):
2722         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2723         (runWebsiteDataStoreCustomPaths):
2724
2725 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2726
2727         webkitpy: Support boolean simctl isAvailable
2728         https://bugs.webkit.org/show_bug.cgi?id=193472
2729         <rdar://problem/47296150>
2730
2731         Reviewed by Ryosuke Niwa.
2732
2733         * Scripts/webkitpy/xcode/simulated_device.py:
2734         (SimulatedDeviceManager._create_runtimes):
2735         (SimulatedDeviceManager._create_device_with_runtime):
2736
2737 2019-01-15  Chris Dumez  <cdumez@apple.com>
2738
2739         Unreviewed, rolling out r239993, r239995, r239997, and
2740         r239999.
2741
2742         Caused assertions under
2743         ViewGestureController::disconnectFromProcess()
2744
2745         Reverted changesets:
2746
2747         "Regression(PSON) View becomes blank after click a cross-site
2748         download link"
2749         https://bugs.webkit.org/show_bug.cgi?id=193361
2750         https://trac.webkit.org/changeset/239993
2751
2752         "Unreviewed iOS build fix after r239993."
2753         https://trac.webkit.org/changeset/239995
2754
2755         "Fix iOS build after r239993"
2756         https://bugs.webkit.org/show_bug.cgi?id=193361
2757         https://trac.webkit.org/changeset/239997
2758
2759         "Unreviewed, revert part of r239997 as it is not needed to fix
2760         the build."
2761         https://trac.webkit.org/changeset/239999
2762
2763 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2764
2765         Cannot tab out of WKWebView on macOS
2766         https://bugs.webkit.org/show_bug.cgi?id=161448
2767         <rdar://problem/28100085>
2768
2769         Reviewed by Dean Jackson.
2770
2771         Add a test that tabbing into and out of WKWebView works correctly.
2772
2773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2774         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2775         (WebKit2_CommandBackForwardTest::SetUp):
2776         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2777         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2778         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2779         (-[FocusableView canBecomeKeyView]):
2780         (TEST):
2781         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2782         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2783         (-[OffscreenWindow initWithSize:]):
2784         (-[OffscreenWindow isKeyWindow]):
2785         (-[OffscreenWindow isVisible]):
2786         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2787         (TestWebKitAPI::PlatformWebView::initialize):
2788         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2789         (-[ActiveOffscreenWindow isVisible]): Deleted.
2790         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2791
2792 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2793
2794         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2795         https://bugs.webkit.org/show_bug.cgi?id=193459
2796
2797         Reviewed by Mark Lam.
2798
2799         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2800         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2801
2802 2019-01-15  Chris Dumez  <cdumez@apple.com>
2803
2804         Regression(PSON) View becomes blank after click a cross-site download link
2805         https://bugs.webkit.org/show_bug.cgi?id=193361
2806         <rdar://problem/47099573>
2807
2808         Reviewed by Geoff Garen.
2809
2810         Add API test coverage.
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2813         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2814
2815 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2816
2817         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2818         https://bugs.webkit.org/show_bug.cgi?id=193448
2819
2820         Reviewed by Antti Koivisto.
2821
2822         * LayoutReloaded/misc/LFC-passing-tests.txt:
2823
2824 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2825
2826         webkitpy: Implement device type specific expected results (Part 1)
2827         https://bugs.webkit.org/show_bug.cgi?id=192162
2828
2829         Reviewed by Lucas Forschler.
2830
2831         Device type specific expected results covers two related ideas. The first (covered by this change)
2832         is where to search for -expected.* files. The second is which tests to run based on the
2833         TestExpectations.txt file.
2834
2835         After this change, the baseline search path will be determined by the type of device running a
2836         test. Device type will be passed into any function which picks a file based on the baseline search
2837         path.
2838
2839         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2840         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2841         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2842         (Manager.run): Print baseline search path for each round of devices.
2843         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2844         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2845         (SingleTestRunner._expected_driver_output): Ditto.
2846         (SingleTestRunner._driver_input): Ditto.
2847         * Scripts/webkitpy/layout_tests/views/printing.py:
2848         (Printer.print_config): Move printing of baseline search path to a separate function.
2849         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2850         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2851         (Testprinter.test_print_config):
2852         (Testprinter.test_print_baseline_search_path):
2853         * Scripts/webkitpy/port/base.py:
2854         (Port.baseline_search_path): Pass device_type through.
2855         (Port._expected_baselines_for_suffixes): Ditto.
2856         (Port.expected_baselines): Ditto.
2857         (Port.expected_filename): Ditto.
2858         (Port.expected_checksum): Ditto.
2859         (Port.expected_image): Ditto.
2860         (Port.expected_audio): Ditto.
2861         (Port.expected_text): Ditto.
2862         (Port.reference_files): Ditto.
2863         (Port.tests): Ditto.
2864         (Port._expanded_paths): Ditto.
2865         (Port.skipped_layout_tests): Ditto.
2866         (Port.expectations_dict): Ditto.
2867         (Port._port_specific_expectations_files): Ditto.
2868         (Port.expectations_files): Ditto.
2869         (Port.test_search_path): Ditto.
2870         (Port._tests_for_other_platforms): Ditto.
2871         * Scripts/webkitpy/port/base_unittest.py:
2872         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2873         (PortTest.test_nonexistant_expectations): Ditto.
2874         (test_ref_tests_platform_directory): Ditto.
2875         * Scripts/webkitpy/port/darwin.py:
2876         (DarwinPort._port_specific_expectations_files): Accept device_type.
2877         * Scripts/webkitpy/port/driver.py:
2878         (DriverProxy):
2879         (DriverProxy.host): Expose _target_host for device_type information.
2880         * Scripts/webkitpy/port/gtk.py:
2881         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2882         * Scripts/webkitpy/port/ios.py:
2883         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2884         * Scripts/webkitpy/port/mac.py:
2885         (MacPort. default_baseline_search_path): Ditto.
2886         * Scripts/webkitpy/port/port_testcase.py:
2887         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2888         * Scripts/webkitpy/port/test.py:
2889         * Scripts/webkitpy/port/watch.py:
2890         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2891         * Scripts/webkitpy/port/win.py:
2892         (WinPort.test_search_path): Accept, but do not use, device_type.
2893         * Scripts/webkitpy/port/wpe.py:
2894         (WPEPort._port_specific_expectations_files): Ditto.
2895         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2896         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2897
2898 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2899
2900         [LFC] Use the containing block's padding box to position out-of-flow elements.
2901         https://bugs.webkit.org/show_bug.cgi?id=193431
2902
2903         Reviewed by Antti Koivisto.
2904
2905         * LayoutReloaded/misc/LFC-passing-tests.txt:
2906
2907 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2908
2909         Move a test implementation file that got misplaced in the Xcode project
2910
2911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2912
2913 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2914
2915         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2916         r239913, and r239914.
2917         https://bugs.webkit.org/show_bug.cgi?id=193407
2918
2919         These revisions caused an internal failure (Requested by
2920         Truitt on #webkit).
2921
2922         Reverted changesets:
2923
2924         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2925         https://bugs.webkit.org/show_bug.cgi?id=186016
2926         https://trac.webkit.org/changeset/239901
2927
2928         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2929         https://trac.webkit.org/changeset/239909
2930
2931         "Tried to fix the build."
2932         https://trac.webkit.org/changeset/239910
2933
2934         "Fixed iOS builds after r239910."
2935         https://trac.webkit.org/changeset/239912
2936
2937         "More build fixing."
2938         https://trac.webkit.org/changeset/239913
2939
2940         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2941         https://trac.webkit.org/changeset/239914
2942
2943 2019-01-14  Mark Lam  <mark.lam@apple.com>
2944
2945         Re-enable ability to build --cloop builds.
2946         https://bugs.webkit.org/show_bug.cgi?id=192955
2947         <rdar://problem/46882363>
2948
2949         Reviewed by Saam barati and Keith Miller.
2950
2951         The --cloop build option was being ignored this whole time since r236381.
2952         This patch makes it possible to build CLoop builds again.
2953
2954         * Scripts/build-jsc:
2955         * Scripts/webkitperl/FeatureList.pm:
2956         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2957
2958 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2959
2960         webkitpy: Expose device_type from host-like objects
2961         https://bugs.webkit.org/show_bug.cgi?id=193406
2962         <rdar://problem/47262305>
2963
2964         Reviewed by Lucas Forschler.
2965
2966         Devices should expose device_type. As a result, all host objects should
2967         provide a device_type property, even if they do not yet define a device_type.
2968
2969         * Scripts/webkitpy/common/system/systemhost.py:
2970         (SystemHost):
2971         (SystemHost.device_type):
2972         * Scripts/webkitpy/common/system/systemhost_mock.py:
2973         (MockSystemHost):
2974         (MockSystemHost.device_type):
2975         * Scripts/webkitpy/port/device.py:
2976         (Device):
2977         (Device.device_type):
2978         * Scripts/webkitpy/xcode/simulated_device.py:
2979         (SimulatedDeviceManager._find_exisiting_device_for_request):
2980         (SimulatedDeviceManager._disambiguate_device_type):
2981         (SimulatedDeviceManager._does_fulfill_request):
2982         (SimulatedDeviceManager.device_count_for_type):
2983         (SimulatedDeviceManager.initialize_devices):
2984         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2985         (test_available_devices):
2986         (test_swapping_devices):
2987
2988 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2989
2990         webkitpy: Support alternate simctl device list output (Follow-up fix)
2991         https://bugs.webkit.org/show_bug.cgi?id=193362
2992         <rdar://problem/47122965>
2993
2994         Rubber-stamped by Lucas Forschler.
2995
2996         * Scripts/webkitpy/xcode/simulated_device.py:
2997         (SimulatedDeviceManager.populate_available_devices):
2998
2999 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3000
3001         [iOS] Expose SPI to access the current sentence boundary and selection state
3002         https://bugs.webkit.org/show_bug.cgi?id=193398
3003         <rdar://problem/45893108>
3004
3005         Reviewed by Dean Jackson.
3006
3007         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3008         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3009         expected.
3010
3011         * TestWebKitAPI/EditingTestHarness.h:
3012         * TestWebKitAPI/EditingTestHarness.mm:
3013         (-[EditingTestHarness moveBackward]):
3014         (-[EditingTestHarness moveForward]):
3015         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3016
3017         Add a couple of new helper methods on EditingTestHarness.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3020         (-[SelectionChangeObserver initWithWebView:]):
3021         (-[SelectionChangeObserver webView]):
3022         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3023         (-[SelectionChangeObserver currentSelectionAttributes]):
3024
3025 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3026
3027         [LFC][BFC] Add basic box-sizing support.
3028         https://bugs.webkit.org/show_bug.cgi?id=193392
3029
3030         Reviewed by Antti Koivisto.
3031
3032         * LayoutReloaded/misc/LFC-passing-tests.txt:
3033
3034 2019-01-14  Charlie Turner  <cturner@igalia.com>
3035
3036         [WPE] API test gardening
3037         https://bugs.webkit.org/show_bug.cgi?id=193319
3038
3039         Reviewed by Michael Catanzaro.
3040
3041         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3042         passing tests.
3043
3044 2019-01-14  Charlie Turner  <cturner@igalia.com>
3045
3046         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3047         https://bugs.webkit.org/show_bug.cgi?id=192977
3048
3049         Reviewed by Carlos Garcia Campos.
3050
3051         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3052         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3053         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3054         (TestWebKitAPI::GStreamerTest::SetUp):
3055         (TestWebKitAPI::GStreamerTest::TearDown):
3056         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3057         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3058         (TestWebKitAPI::TEST_F):
3059
3060 2019-01-14  Charlie Turner  <cturner@igalia.com>
3061
3062         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3063         https://bugs.webkit.org/show_bug.cgi?id=193332
3064
3065         Reviewed by Michael Catanzaro.
3066
3067         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3068         defined as a char16_t, which changed in ICU 59, the
3069         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3070         unsigned short. This test is relying on the behaviour that
3071         UChar=unsigned short, which doesn't hold across platforms and ICU
3072         library versions. The full fix would be a special syntax for
3073         literal characters so that these ambiguities do not arise. That
3074         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3075         (TestWebKitAPI::TEST):
3076
3077 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3078
3079         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3080
3081         * Scripts/make-dist:
3082         (Distcheck.configure):
3083
3084 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3085
3086         [ews-build] Update macOS queue configurations
3087         https://bugs.webkit.org/show_bug.cgi?id=193365
3088         <rdar://problem/47221073>
3089
3090         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3091
3092         * BuildSlaveSupport/ews-build/config.json:
3093
3094 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3095
3096         [LFC] Adjust assert for statically positioned fixed elements
3097         https://bugs.webkit.org/show_bug.cgi?id=193385
3098
3099         Reviewed by Antti Koivisto.
3100
3101         * LayoutReloaded/misc/LFC-passing-tests.txt:
3102
3103 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3104
3105         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3106         https://bugs.webkit.org/show_bug.cgi?id=193387
3107
3108         Reviewed by Carlos Garcia Campos.
3109
3110         * MiniBrowser/wpe/main.cpp:
3111         (main):
3112
3113 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3114
3115         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3116         https://bugs.webkit.org/show_bug.cgi?id=191655
3117         rdar://problem/46074680
3118
3119         Reviewed by Megan Gardner.
3120
3121         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3122         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3123
3124 2019-01-12  Dan Bernstein  <mitz@apple.com>
3125
3126         [Cocoa] Avoid importing directly from subumbrella frameworks
3127         https://bugs.webkit.org/show_bug.cgi?id=186016
3128         <rdar://problem/40591038>
3129
3130         Reviewed by Sam Weinig.
3131
3132         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3133           LaunchServices header.
3134         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3135           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3136         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3137           when using SDKs earlier than 10.13.
3138         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3139           and OTHER_CPLUSPLUSFLAGS.
3140         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3141           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3142         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3143           LaunchServices header.
3144
3145 2019-01-11  John Wilander  <wilander@apple.com>
3146
3147         Compile out Web API Statistics Collection
3148         https://bugs.webkit.org/show_bug.cgi?id=193370
3149         <rdar://problem/45388584>
3150
3151         Reviewed by Brent Fulgham.
3152
3153         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3154             Defined ENABLE_WEB_API_STATISTICS, off by default.
3155
3156 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3157
3158         [WPE] Add gtk-doc
3159         https://bugs.webkit.org/show_bug.cgi?id=178900
3160
3161         Reviewed by Michael Catanzaro.
3162
3163         Add Tools/gtkdoc to manifest.txt.in files.
3164         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3165
3166         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3167         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3168
3169 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3170
3171         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3172         https://bugs.webkit.org/show_bug.cgi?id=193364
3173         <rdar://problem/47214117>
3174
3175         Reviewed by Tim Horton.
3176
3177         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3178         precise, whereas dragging near the middle of the textarea does.
3179
3180         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3181         (TestWebKitAPI::TEST):
3182
3183 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3184
3185         webkitpy: Support alternate simctl device list output
3186         https://bugs.webkit.org/show_bug.cgi?id=193362
3187         <rdar://problem/47122965>
3188
3189         Reviewed by Lucas Forschler.
3190
3191         * Scripts/webkitpy/xcode/simulated_device.py:
3192         (SimulatedDeviceManager.populate_available_devices):
3193
3194 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3195
3196         [ews-build] Update macOS queue configurations
3197         https://bugs.webkit.org/show_bug.cgi?id=193365
3198
3199         Reviewed by Lucas Forschler.
3200
3201         * BuildSlaveSupport/ews-build/config.json:
3202
3203 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3204
3205         webkitpy: Incorporate device type into baseline search path
3206         https://bugs.webkit.org/show_bug.cgi?id=193356
3207         <rdar://problem/47215515>
3208
3209         Reviewed by Lucas Forschler.
3210
3211         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3212
3213         * Scripts/webkitpy/port/base.py:
3214         (Port.default_baseline_search_path): Allow device type to be passed in.
3215         * Scripts/webkitpy/port/gtk.py:
3216         (GtkPort.default_baseline_search_path): Ignore device type.
3217         * Scripts/webkitpy/port/ios.py:
3218         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3219         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3220         * Scripts/webkitpy/port/ios_device_unittest.py:
3221         (IOSDeviceTest):
3222         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3223         (IOSSimulatorTest):
3224         * Scripts/webkitpy/port/mac.py:
3225         (MacPort.default_baseline_search_path): Ignore device type.
3226         * Scripts/webkitpy/port/watch.py:
3227         (WatchPort.default_baseline_search_path): Ditto.
3228         * Scripts/webkitpy/port/win.py:
3229         (WinPort.default_baseline_search_path): Ditto.
3230         (WinCairoPort.default_baseline_search_path): Ditto.
3231         * Scripts/webkitpy/port/wpe.py:
3232         (WPEPort.default_baseline_search_path): Ditto.
3233
3234 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3235
3236         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3237         https://bugs.webkit.org/show_bug.cgi?id=193352
3238         <rdar://problem/47210736>
3239
3240         Reviewed by Lucas Forschler.
3241
3242         * Scripts/webkitpy/layout_tests/views/printing.py:
3243         (Printer.print_config): Print list on only baseline search paths which exist. 
3244         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3245         (Testprinter.test_print_config):
3246
3247 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3248
3249         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3250         https://bugs.webkit.org/show_bug.cgi?id=193340
3251
3252         Reviewed by David Kilzer.
3253
3254         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3255         (WTR::InjectedBundle::didReceiveMessageToPage):
3256         Pull the strings out into a WKRetainPtr.
3257
3258         * WebKitTestRunner/WebNotificationProvider.cpp:
3259         (WTR::WebNotificationProvider::closeWebNotification):
3260         Adopt the created value into the WKRetainPtr.
3261
3262         * WebKitTestRunner/mac/TestControllerMac.mm:
3263         (WTR::generateWhitelist):
3264         Immediately adopt a created value to avoid potential mistakes.
3265
3266 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3267
3268         Enable DFG on ARM/Linux again
3269         https://bugs.webkit.org/show_bug.cgi?id=192496
3270
3271         Reviewed by Yusuke Suzuki.
3272
3273         After changing the bytecode format DFG was disabled on all 32-bit
3274         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3275         on ARM by default.
3276
3277         * Scripts/run-jsc-stress-tests:
3278
3279 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3280
3281         Unreviewed, fix #ifdef in API test added in r239851.
3282         https://bugs.webkit.org/show_bug.cgi?id=193327
3283         rdar://problem/47093222
3284
3285         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3286
3287 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3288
3289         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3290         https://bugs.webkit.org/show_bug.cgi?id=193109
3291         <rdar://problem/44807048>
3292
3293         Reviewed by Ryosuke Niwa.
3294
3295         Introduce and respect a test option to enable the UndoManager API.
3296
3297         * WebKitTestRunner/TestController.cpp:
3298         (WTR::updateTestOptionsFromTestHeader):
3299         * WebKitTestRunner/TestOptions.h:
3300         (WTR::TestOptions::hasSameInitializationOptions const):
3301         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3302         (WTR::TestController::platformCreateWebView):
3303
3304 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3305
3306         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3307         https://bugs.webkit.org/show_bug.cgi?id=193346
3308
3309         Reviewed by Antti Koivisto.
3310
3311         * LayoutReloaded/misc/LFC-passing-tests.txt:
3312
3313 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3314
3315         Unreviewed, fix typo that breaks dashboard link.
3316
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3318         (WebKitBuildbot):
3319
3320 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3321
3322         Update macOS queue configurations
3323         https://bugs.webkit.org/show_bug.cgi?id=193329
3324
3325         Reviewed by Alexey Proskuryakov.
3326
3327         * BuildSlaveSupport/build.webkit.org-config/config.json:
3328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3329         (BubbleQueueServer):
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3332         (WebKitBuildbot):
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3334         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3335         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3336
3337 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3338
3339         MiniBrowser should be able to navigate to about:blank
3340         https://bugs.webkit.org/show_bug.cgi?id=193345
3341
3342         Reviewed by Simon Fraser.
3343
3344         * MiniBrowser/mac/BrowserWindowController.m:
3345         (-[BrowserWindowController addProtocolIfNecessary:]):
3346         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3347
3348         * MiniBrowser/mac/WK1BrowserWindowController.m:
3349         (-[WK1BrowserWindowController fetch:]):
3350         * MiniBrowser/mac/WK2BrowserWindowController.m:
3351         (-[WK2BrowserWindowController fetch:]):
3352         Clean up the code that uses this to match style.
3353
3354 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3355
3356         Remove MiniBrowser custom "Process Swap" menu item which does not work
3357         https://bugs.webkit.org/show_bug.cgi?id=193344
3358
3359         Reviewed by Simon Fraser.
3360
3361         There is a menu item under the Experimental menu that does work.
3362
3363         * MiniBrowser/mac/AppDelegate.m:
3364         (defaultConfiguration):
3365         * MiniBrowser/mac/SettingsController.h:
3366         * MiniBrowser/mac/SettingsController.m:
3367         (-[SettingsController _populateMenu]):
3368         (-[SettingsController validateMenuItem:]):
3369         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3370         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3371
3372 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3373
3374         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3375         https://bugs.webkit.org/show_bug.cgi?id=193327
3376         rdar://problem/47093222
3377
3378         Reviewed by Tim Horton.
3379
3380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3381         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3382         (TestWebKitAPI::didFinishNavigation):
3383         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3384         (TestWebKitAPI::TEST):
3385         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3386         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3387         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3388         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3389         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3390
3391 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3392
3393         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3394         https://bugs.webkit.org/show_bug.cgi?id=193338
3395         <rdar://problem/46664774>
3396
3397         Reviewed by David Kilzer.
3398
3399         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3400         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3401
3402 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3403
3404         Unreviewed, rolling out r239825.
3405         https://bugs.webkit.org/show_bug.cgi?id=193330
3406
3407         Broke tests on armv7/linux bots (Requested by guijemont on
3408         #webkit).
3409
3410         Reverted changeset:
3411
3412         "Enable DFG on ARM/Linux again"
3413         https://bugs.webkit.org/show_bug.cgi?id=192496
3414         https://trac.webkit.org/changeset/239825
3415
3416 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3417
3418         Disable the run-jsc-stress-test remote host key check.
3419         https://bugs.webkit.org/show_bug.cgi?id=192988
3420
3421         Reviewed by Alexey Proskuryakov.
3422
3423         * Scripts/run-jsc-stress-tests:
3424
3425 2019-01-10  John Wilander  <wilander@apple.com>
3426
3427         Override the session configuration for cookieAcceptPolicy
3428         https://bugs.webkit.org/show_bug.cgi?id=190925
3429         <rdar://problem/45497382>
3430
3431         Reviewed by Alexey Proskuryakov and Alex Christensen.
3432
3433         Test infrastructure for setting a first-party-only cookie policy.
3434
3435         * DumpRenderTree/TestRunner.cpp:
3436         (setOnlyAcceptFirstPartyCookiesCallback):
3437         (TestRunner::staticFunctions):
3438         * DumpRenderTree/TestRunner.h:
3439         * DumpRenderTree/mac/TestRunnerMac.mm:
3440         (TestRunner::setOnlyAcceptFirstPartyCookies):
3441         * DumpRenderTree/win/TestRunnerWin.cpp:
3442         (TestRunner::setOnlyAcceptFirstPartyCookies):
3443         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3444         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3445         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3446         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3447         * WebKitTestRunner/TestInvocation.cpp:
3448         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3449
3450 2019-01-09  Matt Rajca  <mrajca@apple.com>
3451
3452         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3453         https://bugs.webkit.org/show_bug.cgi?id=193301
3454
3455         Reviewed by Jer Noble.
3456         
3457         Added API tests.
3458
3459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3460         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3461         (TEST):
3462         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3463
3464 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3465
3466         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3467         https://bugs.webkit.org/show_bug.cgi?id=193310
3468
3469         Reviewed by Antti Koivisto.
3470
3471         * LayoutReloaded/misc/LFC-passing-tests.txt:
3472
3473 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3474
3475         Enable DFG on ARM/Linux again
3476         https://bugs.webkit.org/show_bug.cgi?id=192496
3477
3478         Reviewed by Yusuke Suzuki.
3479
3480         After changing the bytecode format DFG was disabled on all 32-bit
3481         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3482         on ARM by default.
3483
3484         * Scripts/run-jsc-stress-tests:
3485
3486 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3487
3488         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3489         https://bugs.webkit.org/show_bug.cgi?id=193271
3490
3491         Reviewed by Brent Fulgham.
3492
3493         BSTR is a special data structure created by SysAllocString, not a
3494         wchar_t null-terminated string.
3495
3496         * DumpRenderTree/win/TestRunnerWin.cpp:
3497         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3498         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3499         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3500         BSTR from wide string literals.
3501
3502 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3503
3504         Tweak wording for build/version_check style checker error
3505         https://bugs.webkit.org/show_bug.cgi?id=193256
3506
3507         Reviewed by Tim Horton.
3508
3509         * Scripts/webkitpy/style/checkers/cpp.py:
3510         (check_os_version_checks):
3511         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3512         (WebKitStyleTest.test_os_version_checks):
3513
3514 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3515
3516         [ews-build] Add link to bug along with bug title
3517         https://bugs.webkit.org/show_bug.cgi?id=193293
3518
3519         Reviewed by Lucas Forschler.
3520
3521         * BuildSlaveSupport/ews-build/steps.py:
3522         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3523         (ConfigureBuild.add_bug_id_url): Deleted.
3524         (ConfigureBuild.getBugURL): Deleted.
3525
3526 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3527
3528         [ews-build] Use https for ews-build server
3529         https://bugs.webkit.org/show_bug.cgi?id=193193
3530
3531         Reviewed by Lucas Forschler.
3532
3533         * BuildSlaveSupport/ews-build/steps.py:
3534
3535 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3536
3537         [ews-build] Parse and display number of style failures
3538         https://bugs.webkit.org/show_bug.cgi?id=193280
3539
3540         Reviewed by Lucas Forschler.
3541
3542         * BuildSlaveSupport/ews-build/steps.py:
3543         (CheckStyle): Use TestWithFailureCount as base class.
3544         (CheckStyle.countFailures): Count the number of style failures.
3545
3546 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3547
3548         [ews-build] use patch_id instead of ewspatchid
3549         https://bugs.webkit.org/show_bug.cgi?id=193235
3550
3551         Reviewed by Lucas Forschler.
3552
3553         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3554         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3555         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3556
3557 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3558
3559         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3560         https://bugs.webkit.org/show_bug.cgi?id=192625
3561
3562         Reviewed by Antti Koivisto.
3563
3564         * LayoutReloaded/misc/LFC-passing-tests.txt:
3565
3566 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3567
3568         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3569         https://bugs.webkit.org/show_bug.cgi?id=192841
3570
3571         Reviewed by Carlos Garcia Campos.
3572
3573         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3574         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3575         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3576
3577         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3578
3579         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3580         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3581         (WebKitWebEditorTest::testSelectionChanged):
3582         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3583         (WebKitFrameTest::testMainFrame):
3584         (WebKitFrameTest::testURI):
3585         (WebKitFrameTest::testJavaScriptContext):
3586         (WebKitFrameTest::testJavaScriptValues):
3587         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3588         (testWebViewAuthenticationRequest):
3589         (testWebViewAuthenticationLoadCancelled):
3590         (testWebViewAuthenticationFailure):
3591         (testWebViewAuthenticationStorage):
3592         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3593         (testWebViewAuthenticationProxy):
3594         (testWebViewAuthenticationProxyHTTPS):
3595         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3596         (testAutomationSessionRequestSession):
3597         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3598         (testBackForwardListNavigation):
3599         (testWebKitWebViewSessionState):
3600         (testWebKitWebViewSessionStateWithFormData):
3601         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3602         (ConsoleMessageTest::consoleMessageReceivedCallback):
3603         (testWebKitConsoleMessageConsoleAPI):
3604         (testWebKitConsoleMessageJavaScriptException):
3605         (testWebKitConsoleMessageNetworkError):
3606         (testWebKitConsoleMessageSecurityError):
3607         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3608         (testCookieManagerAcceptPolicy):
3609         (testCookieManagerCookiesChanged):
3610         (testCookieManagerPersistentStorage):
3611         (testCookieManagerPersistentStorageDeleteAll):
3612         (testCookieManagerEphemeral):
3613         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3614         (testWebKitDOMElementAutoFill):
3615         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3616         (downloadLocalFileSuccessfully):
3617         (createFileAtDestination):
3618         (testDownloadOverwriteDestinationDisallowed):
3619         (testDownloadLocalFileError):
3620         (testDownloadRemoteFile):
3621         (testDownloadRemoteFileError):
3622         (testWebViewDownloadURI):
3623         (testPolicyResponseDownload):
3624         (testPolicyResponseDownloadCancel):
3625         (testDownloadMIMEType):
3626         (contextMenuCallback):
3627         (testContextMenuDownloadActions):
3628         (testBlobDownload):
3629         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3630         (testWebKitWebEditorSelectionChanged):
3631         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3632         (testWebKitFrameMainFrame):
3633         (testWebKitFrameURI):
3634         (testWebKitFrameJavaScriptContext):
3635         (testWebKitFrameJavaScriptValues):
3636         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3637         (LoadStopTrackingTest::loadFailed):
3638         (testWebViewTitle):
3639         (testURIRequestHTTPHeaders):
3640         (testURIRequestHTTPMethod):
3641         (testURIResponseHTTPHeaders):
3642         (testRedirectToDataURI):
3643         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3644         (testProcessPerWebView):
3645         (testWebProcessLimit):
3646         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3647         (testWebViewResources):
3648         (testWebResourceLoading):
3649         (testWebResourceSuggestedFilename):
3650         (testWebResourceGetData):
3651         (testWebResourceGetDataError):
3652         (testWebViewResourcesHistoryCache):
3653         (testWebResourceSendRequest):
3654         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3655         (testSSL):
3656         (testInsecureContent):
3657         (testTLSErrorsPolicy):
3658         (testTLSErrorsRedirect):
3659         (testTLSErrorsHTTPAuth):
3660         (testLoadFailedWithTLSErrors):
3661         (testSubresourceLoadFailedWithTLSErrors):
3662         (httpsServerCallback):
3663         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3664         (testWebViewCreateNavigationData):
3665         (testWebViewJavaScriptDialogs):
3666         (testWebViewWindowProperties):
3667         (testWebViewMouseTarget):
3668         (testWebViewFileChooserRequest):
3669         (testWebViewColorChooserRequest):
3670         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3671         (testWebExtensionGetTitle):
3672         (testDocumentLoadedSignal):
3673         (testWebKitWebViewProcessCrashed):
3674         (testWebExtensionWindowObjectCleared):