Tools/ChangeLog

   1 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
   2
   3         results.webkit.org: Move legend into sidebar
   4         https://bugs.webkit.org/show_bug.cgi?id=201258
   5
   6         Rubber-stamped by Aakash Jain.
   7
   8         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
   9         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
  10         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
  11         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
  12         (isPointInElement): Make bound check include borders.
  13         (_ToolTip.toString): Add left/right cases.
  14         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
  15         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
  16         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
  17
  18 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
  19
  20         results.webkit.org: Increase default limit for LimitSlider
  21         https://bugs.webkit.org/show_bug.cgi?id=201424
  22
  23         Reviewed by Aakash Jain.
  24
  25         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
  26         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
  27
  28 2019-09-03  Antoine Quint  <graouts@apple.com>
  29
  30         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
  31         https://bugs.webkit.org/show_bug.cgi?id=201420
  32         <rdar://problem/53207786>
  33
  34         Reviewed by Simon Fraser.
  35
  36         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
  37         -[HIDEventGenerator twoFingerTap:completionBlock:].
  38
  39         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  40         * TestRunnerShared/UIScriptContext/UIScriptController.h:
  41         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
  42         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
  43         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
  44         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
  45
  46 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
  47
  48         [WPE] MiniBrowser should handle the WebKitWebView::create signal
  49         https://bugs.webkit.org/show_bug.cgi?id=201417
  50
  51         Reviewed by Carlos Garcia Campos.
  52
  53         WPE's MiniBrowser should connect to and handle the
  54         WebKitWebView::create signal, constructing a new bit related
  55         WebKitWebView object upon invocation.
  56
  57         * MiniBrowser/wpe/main.cpp:
  58         (webViewClose):
  59         (createWebView):
  60         (main):
  61
  62 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
  63
  64         [WPE] Make view backends multi-view-friendly
  65         https://bugs.webkit.org/show_bug.cgi?id=201415
  66
  67         Reviewed by Carlos Garcia Campos.
  68
  69         Have the Wayland EGL connection for WindowViewBackend instances managed
  70         through a per-process singleton, allowing multiple backend objects
  71         use it for different views. HeadlessViewBackend already does this, but
  72         the code there is refurbished into a singleton structure.
  73
  74         The ViewBackend classes are adjusted to work with the backend-specific
  75         EGLDisplay objects (as constructed through the backend-specific EGL
  76         connection approach).
  77
  78         * wpe/backends/HeadlessViewBackend.cpp:
  79         (WPEToolingBackends::HeadlessEGLConnection::singleton):
  80         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
  81         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
  82         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
  83         (WPEToolingBackends::getEGLDisplay): Deleted.
  84         * wpe/backends/ViewBackend.cpp:
  85         (WPEToolingBackends::ViewBackend::initialize):
  86         (WPEToolingBackends::ViewBackend::deinitialize):
  87         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
  88         * wpe/backends/ViewBackend.h:
  89         * wpe/backends/WindowViewBackend.cpp:
  90         (WPEToolingBackends::WaylandEGLConnection::singleton):
  91         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
  92         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
  93         (WPEToolingBackends::WindowViewBackend::displayBuffer):
  94
  95 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
  96
  97         [WPE][GTK] Deprecate nonfunctional process limit APIs
  98         https://bugs.webkit.org/show_bug.cgi?id=193749
  99
 100         Reviewed by Žan Doberšek.
 101
 102         * MiniBrowser/gtk/main.c:
 103         (main):
 104         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
 105         (beforeAll):
 106         (testWebProcessLimit): Deleted.
 107
 108 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
 109
 110         [WPE] WindowBackend should do resizing properly
 111         https://bugs.webkit.org/show_bug.cgi?id=201386
 112
 113         Reviewed by Carlos Garcia Campos.
 114
 115         The WindowBackend implementation is resized via the XDG protocol. The
 116         initial size is stored for the object's lifetime and fallen back to when
 117         the XDG protocol reports (0,0) configuration size.
 118
 119         Upon each resize, we have to recreate the texture. We also have to size
 120         the GL viewport accordingly.
 121
 122         * wpe/backends/WindowViewBackend.cpp:
 123         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
 124         (WPEToolingBackends::WindowViewBackend::createViewTexture):
 125         (WPEToolingBackends::WindowViewBackend::resize):
 126         (WPEToolingBackends::WindowViewBackend::displayBuffer):
 127         * wpe/backends/WindowViewBackend.h:
 128
 129 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
 130
 131         Unreviewed, rolling out r249366.
 132
 133         WinCairo WebKit2 crashes in some websites and the device scale
 134         factor is not correct in high DPI.
 135
 136         Reverted changeset:
 137
 138         "[WinCairo, FTW] Properly handle device scale factor"
 139         https://bugs.webkit.org/show_bug.cgi?id=201361
 140         https://trac.webkit.org/changeset/249366
 141
 142 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
 143
 144         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
 145         https://bugs.webkit.org/show_bug.cgi?id=201346
 146         <rdar://problem/54885784>
 147
 148         Reviewed by Dean Jackson.
 149
 150         Add a new test option to allow tests to disable link previews.
 151
 152         * WebKitTestRunner/TestController.cpp:
 153         (WTR::updateTestOptionsFromTestHeader):
 154         * WebKitTestRunner/TestOptions.h:
 155
 156         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
 157
 158         (WTR::TestOptions::hasSameInitializationOptions const):
 159         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 160         (WTR::TestController::platformCreateWebView):
 161
 162 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
 163
 164         [WinCairo, FTW] Properly handle device scale factor
 165         https://bugs.webkit.org/show_bug.cgi?id=201361
 166
 167         Reviewed by Don Olmstead.
 168
 169         Reset zoom to 1.0; device scale is handled elsewhere.
 170
 171         * MiniBrowser/win/WebKitBrowserWindow.cpp:
 172         (WebKitBrowserWindow::resetZoom):
 173
 174 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
 175
 176         [results.webkit.org Timeline] Add notify rerender API for timeline
 177         https://bugs.webkit.org/show_bug.cgi?id=201363
 178
 179         Reviewed by Jonathan Bedard.
 180
 181         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
 182         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
 183         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render
 184         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
 185         (prototype.Timeline.CanvasContainer):
 186
 187 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
 188
 189         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
 190         https://bugs.webkit.org/show_bug.cgi?id=201350
 191
 192         Reviewed by Jonathan Bedard.
 193
 194         * BuildSlaveSupport/ews-build/steps.py:
 195         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
 196         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
 197
 198 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
 199
 200         results.webkit.org: Add endpoints to upload and download archives
 201         https://bugs.webkit.org/show_bug.cgi?id=201100
 202
 203         Reviewed by Aakash Jain.
 204
 205         Add the endpoint to upload and download a zip archive associated with a test run.
 206
 207         * resultsdbpy/resultsdbpy/controller/api_routes.py:
 208         (APIRoutes.__init__): Add archive endpoint.
 209         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
 210         (ArchiveController):
 211         (ArchiveController.__init__):
 212         (ArchiveController.endpoint):
 213         (ArchiveController.download):
 214         (ArchiveController.upload):
 215         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
 216         (ArchiveControllerUnittest):
 217         * resultsdbpy/resultsdbpy/model/configuration_context.py:
 218         (ClusteredByConfiguration.register_configuration): Make error message more clear.
 219
 220 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
 221
 222         Add system tracing points for compositing updates, and touch-event dispatching
 223         https://bugs.webkit.org/show_bug.cgi?id=201327
 224
 225         Reviewed by Alex Christensen.
 226
 227         * Tracing/SystemTracePoints.plist:
 228
 229 2019-08-30  Keith Rollin  <krollin@apple.com>
 230
 231         Simplify PLATFORM expression
 232         https://bugs.webkit.org/show_bug.cgi?id=201286
 233         <rdar://problem/54822347>
 234
 235         Reviewed by Alexey Proskuryakov.
 236
 237         The preprocessor expression conditionalizing the inclusion of the body
 238         of ExitFullscreenOnEnterPiP.mm evolved into:
 239
 240             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
 241
 242         Simplify this to just:
 243
 244             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
 245
 246         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
 247
 248 2019-08-30  Keith Rollin  <krollin@apple.com>
 249
 250         Remove AppKitCompatibilityDeclarations.h
 251         https://bugs.webkit.org/show_bug.cgi?id=201283
 252         <rdar://problem/54822042>
 253
 254         Reviewed by Alexey Proskuryakov.
 255
 256         The two copies of these files -- on in WTF, one in MiniBrowser -- are
 257         empty and can be removed.
 258
 259         * DumpRenderTree/mac/EventSendingController.mm:
 260         * DumpRenderTree/mac/TextInputControllerMac.m:
 261         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
 262         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 263         * MiniBrowser/mac/SettingsController.m:
 264         * MiniBrowser/mac/WK1BrowserWindowController.m:
 265         * MiniBrowser/mac/WK2BrowserWindowController.m:
 266         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
 267         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
 268         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
 269         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
 270         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
 271         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
 272         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
 273         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
 274         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
 275         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
 276         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
 277         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
 278         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
 279         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
 280         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
 281         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
 282         * TestWebKitAPI/cocoa/TestWKWebView.mm:
 283         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
 284         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 285         * WebKitTestRunner/mac/EventSenderProxy.mm:
 286         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 287         * WebKitTestRunner/mac/TestControllerMac.mm:
 288
 289 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
 290
 291         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
 292         https://bugs.webkit.org/show_bug.cgi?id=200479
 293
 294         Reviewed by Carlos Garcia Campos.
 295
 296         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
 297         (testUserContentManagerContentFilter): Test also the new
 298         webkit_user_content_manager_remove_filter_by_id() public API function.
 299
 300 2019-08-30  Philippe Normand  <pnormand@igalia.com>
 301
 302         [WPE][Qt] loadingChanged signal parameter is unusable
 303         https://bugs.webkit.org/show_bug.cgi?id=201301
 304
 305         Reviewed by Carlos Garcia Campos.
 306
 307         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
 308         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
 309         readablity/parameter_name code styl checker rule.
 310
 311 2019-08-29  Keith Rollin  <krollin@apple.com>
 312
 313         Update .xcconfig symbols to reflect the current set of past and future product versions.
 314         https://bugs.webkit.org/show_bug.cgi?id=200720
 315         <rdar://problem/54305032>
 316
 317         Reviewed by Alex Christensen.
 318
 319         Remove version symbols related to old OS's we no longer support,
 320         ensure that version symbols are defined for OS's we do support.
 321
 322         * ContentExtensionTester/Configurations/Base.xcconfig:
 323         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
 324         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 325         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 326         * ImageDiff/cg/Configurations/Base.xcconfig:
 327         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
 328         * MiniBrowser/Configurations/Base.xcconfig:
 329         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 330         * TestWebKitAPI/Configurations/Base.xcconfig:
 331         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 332         * WebEditingTester/Configurations/Base.xcconfig:
 333         * WebEditingTester/Configurations/DebugRelease.xcconfig:
 334         * WebKitTestRunner/Configurations/Base.xcconfig:
 335         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 336         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
 337         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
 338
 339 2019-08-29  Keith Rollin  <krollin@apple.com>
 340
 341         Remove empty FontCache.cpp file in TestWebKitAPI
 342         https://bugs.webkit.org/show_bug.cgi?id=201277
 343         <rdar://problem/54820726>
 344
 345         Reviewed by Alex Christensen.
 346
 347         Bug 200694 emptied out the contents of FontCache.cpp. This patch
 348         removes the file from the project.
 349
 350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 351         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
 352
 353 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
 354
 355         [ews-app] Status bubble should only display important messages in pop-over
 356         https://bugs.webkit.org/show_bug.cgi?id=201308
 357
 358         Reviewed by Jonathan Bedard.
 359
 360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
 361         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
 362
 363 2019-08-29  Keith Rollin  <krollin@apple.com>
 364
 365         Remove support for macOS < 10.13 (part 3)
 366         https://bugs.webkit.org/show_bug.cgi?id=201224
 367         <rdar://problem/54795934>
 368
 369         Reviewed by Darin Adler.
 370
 371         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
 372         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
 373         like _MACOS_SINCE_1013.
 374
 375         Also added some macOS target numbers.
 376
 377         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
 378
 379 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
 380
 381         results.webkit.org: Remove border from tooltip
 382         https://bugs.webkit.org/show_bug.cgi?id=201239
 383
 384         Reviewed by Alex Christensen.
 385
 386         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
 387         (.tooltip-content): Remove border.
 388
 389 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
 390
 391         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
 392         https://bugs.webkit.org/show_bug.cgi?id=201215
 393
 394         Reviewed by Don Olmstead.
 395
 396         MiniBrowser crashed if it was going to go to a unreachable page
 397         because WKPageCopyActiveURL returned a nullptr.
 398
 399         * MiniBrowser/win/WebKitBrowserWindow.cpp:
 400         (createString): Added null checking of the argument.
 401
 402 2019-08-28  Tim Horton  <timothy_horton@apple.com>
 403
 404         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
 405         https://bugs.webkit.org/show_bug.cgi?id=201256
 406         <rdar://problem/54809509>
 407
 408         Reviewed by Simon Fraser.
 409
 410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 411         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
 412         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
 413         (TestWebKitAPI::TEST):
 414         Add a test. I left many comments because I had a great deal of trouble
 415         writing this test and wanted to document my findings.
 416
 417 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
 418
 419         results.webkit.org: Do not display branch selector if only one branches available
 420         https://bugs.webkit.org/show_bug.cgi?id=201244
 421
 422         Rubber-stamped by Aakash Jain.
 423
 424         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
 425         container if there aren't multiple branches to choose from.
 426
 427 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
 428
 429         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
 430         https://bugs.webkit.org/show_bug.cgi?id=201241
 431         <rdar://problem/54317588>
 432
 433         Reviewed by Tim Horton.
 434
 435         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
 436         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
 437         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
 438         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
 439         it believes that the web view has rejected the drop from being handled.
 440
 441         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
 442         to make sure that the web process has had time to send a response after each update.
 443
 444         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
 445         (-[DragAndDropSimulator _advanceProgress]):
 446
 447 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
 448
 449         Null check webFrame when creating a print preview to prevent a crash.
 450         https://bugs.webkit.org/show_bug.cgi?id=201237
 451         <rdar://problem/51618863>
 452
 453         Reviewed by Tim Horton.
 454
 455         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
 456
 457         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
 458         (TEST):
 459
 460 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
 461
 462         results.webkit.org: Move drawer to the right, open by default
 463         https://bugs.webkit.org/show_bug.cgi?id=200977
 464
 465         Rubber-stamped by Aakash Jain.
 466
 467         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
 468         moving the drawer to the right side of the screen, opening it by default and have it displace
 469         instead of hide the main content.
 470
 471         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
 472         (CommitViewUnittest.test_drawer): Support new drawer style.
 473         (CommitViewUnittest.test_range_slider): Ditto.
 474         (CommitViewUnittest.test_one_line_switch): Ditto.
 475         (CommitViewUnittest.test_branch_selection): Ditto.
 476         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
 477         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
 478         (setEnableRecursive): Disable all elements underneath this one
 479         (Drawer): Make drawer a sidebar.
 480         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
 481         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
 482         (:root): Move boldInverseColor into webkit.css.
 483         (@media (prefers-color-scheme: dark)):
 484         (.sidebar): Sidebars on mobile should behave like drawers.
 485         (.sidebar.hidden): Add concept of hidden sidebar.
 486         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
 487         (.mobile-sidebar-control.display):
 488         (.main.under-topbar-with-actions):
 489         (@media screen and (min-width: 600px) and (orientation: landscape)):
 490         (.sidebar.left.hidden):
 491         (.sidebar.right.hidden):
 492         (.main.right.hidden):
 493         (.main.left.hidden):
 494         (@media screen and (min-width: 768px) and (orientation: landscape)):
 495         (.sidebar.right):
 496         (a.disabled): Add ability to disable a link.
 497         (.desktop-control): Add a control which only exists on desktop.
 498         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
 499         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
 500         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
 501         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
 502         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
 503         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
 504         (WebSiteTestCase.toggle_drawer): Support new drawer style.
 505         (WebSiteTestCase.find_input_with_name): Ditto.
 506
 507 2019-08-28  Keith Rollin  <krollin@apple.com>
 508
 509         Remove support for macOS < 10.13 (part 2)
 510         https://bugs.webkit.org/show_bug.cgi?id=201197
 511         <rdar://problem/54759985>
 512
 513         Reviewed by Darin Adler.
 514
 515         Update conditionals that reference WK_MACOS_1013 and suffixes like
 516         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
 517         later and that these conditionals are always True or False.
 518
 519         See Bug 200694 for earlier changes in this area.
 520
 521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 522
 523 2019-08-28  Alicia Boya García  <aboya@igalia.com>
 524
 525         [MSE][GStreamer] WebKitMediaSrc rework
 526         https://bugs.webkit.org/show_bug.cgi?id=199719
 527
 528         Reviewed by Xabier Rodriguez-Calvar.
 529
 530         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
 531         whitelist.
 532
 533         * Scripts/webkitpy/style/checker.py:
 534
 535 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
 536
 537         Updating inactive contributors in contributors.json.
 538
 539         * Scripts/webkitpy/common/config/contributors.json:
 540
 541 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
 542
 543         results.webkit.org: Auto-expand single configurations
 544         https://bugs.webkit.org/show_bug.cgi?id=201218
 545
 546         Rubber-stamped by Aakash Jain.
 547
 548         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
 549         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
 550         configuration has been specified.
 551         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
 552         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
 553         is expanded or collapsed by default.
 554
 555 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
 556
 557         results.webkit.org: Sanitize all commit arguments on upload
 558         https://bugs.webkit.org/show_bug.cgi?id=201189
 559         <rdar://problem/54564837>
 560
 561         Reviewed by Aakash Jain.
 562
 563         * resultsdbpy/resultsdbpy/controller/commit.py:
 564         (Commit.__init__): Only allow commits to be constructed with valid values.
 565         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
 566         (CommitController.register): Strip potential API key.
 567         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
 568         (CommitUnittest.test_invalid): Test that commits which contain html inside the
 569         repository_id, branch or commit id are rejected.
 570
 571 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
 572
 573         [GTK][WPE] Implement HSTS for the soup network backend
 574         https://bugs.webkit.org/show_bug.cgi?id=192074
 575
 576         Reviewed by Carlos Garcia Campos.
 577
 578         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
 579         Add support to the soup network backend by adding the feature to
 580         SoupNetworkSession and handling HSTS protocol upgrades, by
 581         propagating the scheme change further to clients. This patch adds
 582         the HSTS feature unconditionally, but it still possible to add
 583         a boolean property to the web context class if desired.
 584
 585         Additionally, add API to the WebKitWebsiteDataManager to specify
 586         the directory where the HSTS database is saved. If the directory
 587         is not set or if the data manager is ephemeral, use a
 588         non-persistent, memory only HSTS enforcer.
 589
 590         Implement as well the methods needed to clean-up and delete HSTS
 591         policies from the storage and expose the feature in GTK+
 592         MiniBrowser's about:data.
 593
 594         * MiniBrowser/gtk/main.c:
 595         (gotWebsiteDataCallback):
 596         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
 597         (serverCallback):
 598         (testWebsiteDataConfiguration):
 599         (testWebsiteDataEphemeral):
 600         (prepopulateHstsData):
 601         (testWebsiteDataHsts):
 602         (beforeAll):
 603         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
 604         (Test::Test):
 605         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
 606         * wpe/jhbuild.modules: Ditto
 607         * MiniBrowser/gtk/main.c:
 608         (gotWebsiteDataCallback):
 609
 610 2019-08-27  James Darpinian  <jdarpinian@google.com>
 611
 612         Fix applying diffs that only change file mode
 613         https://bugs.webkit.org/show_bug.cgi?id=201191
 614
 615         Reviewed by Daniel Bates.
 616
 617         * Scripts/svn-apply:
 618         (patch): Handle case of file mode change without content change
 619
 620 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
 621
 622         [ews] Status bubble should be red for CANCELLED builds
 623         https://bugs.webkit.org/show_bug.cgi?id=201204
 624
 625         Reviewed by Jonathan Bedard.
 626
 627         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
 628         (StatusBubble._build_bubble):
 629
 630 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
 631
 632         [results.webkit.org Webkit.css] Center the legend symbols
 633         https://bugs.webkit.org/show_bug.cgi?id=201187
 634
 635         Reviewed by Jonathan Bedard.
 636
 637         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
 638         (.lengend>.item .dot .text): center the dot symbol vertically
 639
 640 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
 641
 642         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
 643         https://bugs.webkit.org/show_bug.cgi?id=201000
 644         <rdar://problem/53778938>
 645
 646         Unreviewed follow-up fix.
 647
 648         * Scripts/webkitpy/port/darwin.py:
 649         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
 650         spindump call failed.
 651         * Scripts/webkitpy/port/darwin_testcase.py:
 652         * Scripts/webkitpy/port/ios_device_unittest.py:
 653
 654 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
 655
 656         [ews-build] Use update-webkit script in Apply-WatchList EWS
 657         https://bugs.webkit.org/show_bug.cgi?id=201179
 658
 659         Reviewed by Jonathan Bedard.
 660
 661         * BuildSlaveSupport/ews-build/factories.py:
 662         (WatchListFactory): Updated to use CheckOutSource step as well.
 663
 664 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 665
 666         W3C test importer should be able to handle expected references with an absolute path.
 667         https://bugs.webkit.org/show_bug.cgi?id=200717
 668
 669         Reviewed by Youenn Fablet.
 670
 671         This patch implements the logic to resolve test references with absolute paths
 672         when importing w3c tests (like web-platform-tests).
 673         When an absolute path is found for a test reference, the parser now
 674         tries to find the right file by looking for a relative path inside
 675         the root directory of the source test repository.
 676         It works when the tool is run in download-mode as well as when the
 677         tool is run to import the tests from a local directory.
 678
 679         This fixes the import of test references for tests like
 680         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
 681
 682         * Scripts/webkitpy/w3c/test_importer.py:
 683         (TestImporter._source_root_directory_for_path):
 684         (TestImporter.find_importable_tests):
 685         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 686         (TestImporterTest.import_directory):
 687         (test_webkit_test_runner_options):
 688         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
 689         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
 690         * Scripts/webkitpy/w3c/test_parser.py:
 691         (TestParser.__init__):
 692         (TestParser.analyze_test):
 693
 694 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 695
 696         Remove UIHelper.activateElementAtHumanSpeed
 697         https://bugs.webkit.org/show_bug.cgi?id=201147
 698
 699         Reviewed by Tim Horton.
 700
 701         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
 702         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
 703         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
 704
 705         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
 706         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 707         (WTR::UIScriptController::doAfterDoubleTapDelay):
 708         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
 709         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 710         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
 711
 712 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
 713
 714         [results.webkit.org Timline] Add symbols to the timeline dot
 715         https://bugs.webkit.org/show_bug.cgi?id=201105
 716
 717         Reviewed by Jonathan Bedard.
 718
 719         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
 720         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
 721         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
 722         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
 723
 724 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
 725
 726         Unreviewed, remove useMaximalFlushInsertionPhase use
 727         https://bugs.webkit.org/show_bug.cgi?id=201036
 728
 729         * Scripts/run-jsc-stress-tests:
 730
 731 2019-08-26  David Kilzer  <ddkilzer@apple.com>
 732
 733         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
 734         <https://webkit.org/b/201144>
 735         <rdar://problem/54689399>
 736
 737         Reviewed by Brent Fulgham.
 738
 739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
 740         DataDetectorsTestIOS.mm to the project.
 741         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
 742         test for Data Detectors for phone numbers.
 743
 744 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 745
 746         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
 747         https://bugs.webkit.org/show_bug.cgi?id=201129
 748         <rdar://problem/51857277>
 749
 750         Reviewed by Tim Horton.
 751
 752         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
 753         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
 754         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
 755         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
 756         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
 757         capable of recognizing further touches yet.
 758
 759         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
 760         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
 761         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
 762         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
 763         allows both of them to be reset.
 764
 765         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
 766         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
 767         immediately after sending the first tap. This change in dependencies is caused by the introduction of
 768         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
 769         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
 770         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
 771         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
 772
 773         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
 774         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
 775         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
 776         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
 777         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
 778         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
 779         requiring arbitrary 120 ms "human speed" delays.
 780
 781         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
 782
 783         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
 784         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 785         (WTR::UIScriptController::doubleTapAtPoint):
 786
 787         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
 788         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
 789         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
 790         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
 791         recognized only as a single tap instead of a double tap.
 792
 793         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
 794         gestures use instead to wait after simulating the first tap.
 795
 796         * WebKitTestRunner/ios/HIDEventGenerator.h:
 797         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 798         (-[HIDEventGenerator _waitFor:]):
 799         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
 800
 801         Plumb the tap gesture delay through to this helper method.
 802
 803         (-[HIDEventGenerator tap:completionBlock:]):
 804         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
 805         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
 806         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
 807         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
 808         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
 809         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 810         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
 811
 812         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
 813         attempting to simulate single taps (either using a stylus, or with a regular touch).
 814
 815         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
 816         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
 817         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
 818
 819 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
 820
 821         results.webkit.org: Allow clicking on the tooltip arrow
 822         https://bugs.webkit.org/show_bug.cgi?id=201103
 823
 824         Rubber-stamped by Aakash Jain.
 825
 826         By design, the arrow sits above the canvas and intercepts mouse events from it.
 827         This will often make an element that has a tooltip unclickable.
 828
 829         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
 830         (xAxisFromScale):
 831         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
 832         (TimelineFromEndpoint.prototype.render):
 833         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
 834         (_ToolTip):
 835         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
 836         (_ToolTip.prototype.set): Set the onClick callback.
 837
 838 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
 839
 840         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
 841         https://bugs.webkit.org/show_bug.cgi?id=201140
 842
 843         Reviewed by Jonathan Bedard.
 844
 845         * BuildSlaveSupport/ews-build/steps.py:
 846         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
 847         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
 848
 849 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
 850
 851         run-webkit-tests: Cap the number of automatically booted simulators at 12
 852         https://bugs.webkit.org/show_bug.cgi?id=201139
 853
 854         Reviewed by Aakash Jain.
 855
 856         To make local development with simulators more pleasant, machines should
 857         never automatically boot more than 12 simulators.
 858
 859         * Scripts/webkitpy/xcode/simulated_device.py:
 860         (SimulatedDeviceManager.max_supported_simulators):
 861
 862 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
 863
 864         [ews] Add EWS queue for applying watchlist
 865         https://bugs.webkit.org/show_bug.cgi?id=201072
 866
 867         Reviewed by Jonathan Bedard.
 868
 869         * BuildSlaveSupport/ews-build/steps.py:
 870         (ApplyWatchList): Build step to apply watchlist.
 871         (ApplyWatchList.__init__): Set logEnviron to False.
 872         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
 873         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
 874         * BuildSlaveSupport/ews-build/factories.py:
 875         (WatchListFactory): Build factory for WatchList.
 876         * BuildSlaveSupport/ews-build/loadConfig.py:
 877         * BuildSlaveSupport/ews-build/config.json:
 878
 879 2019-08-26  Youenn Fablet  <youenn@apple.com>
 880
 881         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
 882         https://bugs.webkit.org/show_bug.cgi?id=196870
 883
 884         Reviewed by Alex Christensen.
 885
 886         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
 887         Accept any server certificate by default.
 888
 889         * WebKitTestRunner/TestController.cpp:
 890         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 891         (WTR::TestController::cocoaResetStateToConsistentValues):
 892         (WTR::TestController::setAllowsAnySSLCertificate):
 893         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
 894         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
 895         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
 896         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
 897
 898 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
 899
 900         Increase log level for watchlist result
 901         https://bugs.webkit.org/show_bug.cgi?id=201081
 902
 903         Reviewed by Jonathan Bedard.
 904
 905         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
 906         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
 907         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
 908
 909 2019-08-23  Chris Dumez  <cdumez@apple.com>
 910
 911         [geolocation] Rename interfaces and remove [NoInterfaceObject]
 912         https://bugs.webkit.org/show_bug.cgi?id=200885
 913
 914         Reviewed by Alex Christensen.
 915
 916         * DumpRenderTree/mac/TestRunnerMac.mm:
 917         (TestRunner::setMockGeolocationPosition):
 918
 919 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
 920
 921         Unreviewed, rolling out r249001.
 922
 923         Caused one layout test to fail on all configurations and
 924         another to time out on Catalina / iOS 13.
 925
 926         Reverted changeset:
 927
 928         "Add a WebsiteDataStore delegate to handle
 929         AuthenticationChallenge that do not come from pages"
 930         https://bugs.webkit.org/show_bug.cgi?id=196870
 931         https://trac.webkit.org/changeset/249001
 932
 933 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
 934
 935         results.webkit.org: Escape html in changelog
 936         https://bugs.webkit.org/show_bug.cgi?id=201025
 937         <rdar://problem/54564837>
 938
 939         Reviewed by Darin Adler.
 940
 941         * resultsdbpy/resultsdbpy/view/commit_view.py:
 942         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
 943         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
 944         directly into a JavaScript dictionary.
 945
 946 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
 947
 948         [WebAuthn] Support NFC authenticators for iOS
 949         https://bugs.webkit.org/show_bug.cgi?id=188624
 950         <rdar://problem/43354214>
 951
 952         Reviewed by Chris Dumez.
 953
 954         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 955         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
 956         Setup NFC mock testing configuration.
 957
 958 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
 959
 960         [ews] Enable Style queue on new EWS
 961         https://bugs.webkit.org/show_bug.cgi?id=201071
 962
 963         Reviewed by Jonathan Bedard.
 964
 965         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
 966         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
 967         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
 968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 969         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
 970
 971 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
 972
 973         [Win][MiniBrowser] URL bar should be updated for in-page navigations
 974         https://bugs.webkit.org/show_bug.cgi?id=201032
 975
 976         Reviewed by Darin Adler.
 977
 978         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
 979         * MiniBrowser/win/MainWindow.cpp:
 980         (MainWindow::init):
 981         (MainWindow::activeURLChanged): Added.
 982         * MiniBrowser/win/MainWindow.h:
 983         * MiniBrowser/win/MiniBrowserWebHost.cpp:
 984         (MiniBrowserWebHost::didCommitLoadForFrame):
 985         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
 986         (MiniBrowserWebHost::updateAddressBar): Deleted.
 987         (MiniBrowserWebHost::loadURL): Deleted.
 988         * MiniBrowser/win/MiniBrowserWebHost.h:
 989         (MiniBrowserWebHost::MiniBrowserWebHost):
 990         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
 991         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
 992         * MiniBrowser/win/PrintWebUIDelegate.cpp:
 993         * MiniBrowser/win/WebKitBrowserWindow.cpp:
 994         (WebKitBrowserWindow::create):
 995         (WebKitBrowserWindow::WebKitBrowserWindow):
 996         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
 997         (WebKitBrowserWindow::didChangeActiveURL): Added.
 998         (WebKitBrowserWindow::createNewPage):
 999         (WebKitBrowserWindow::didCommitNavigation): Deleted.
1000         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
1001         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1002         (WebKitLegacyBrowserWindow::create):
1003         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1004         (WebKitLegacyBrowserWindow::init):
1005         (WebKitLegacyBrowserWindow::navigateToHistory):
1006         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
1007
1008 2019-08-22  Andy Estes  <aestes@apple.com>
1009
1010         [watchOS] Disable Content Filtering in the simulator build
1011         https://bugs.webkit.org/show_bug.cgi?id=201047
1012
1013         Reviewed by Tim Horton.
1014
1015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1016
1017 2019-08-22  Chris Dumez  <cdumez@apple.com>
1018
1019         Try to recover nicely when getting an unexpected schema in the service workers database
1020         https://bugs.webkit.org/show_bug.cgi?id=201002
1021         <rdar://problem/54574991>
1022
1023         Reviewed by Youenn Fablet.
1024
1025         Add API test coverage.
1026
1027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1028         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1029
1030 2019-08-22  Keith Rollin  <krollin@apple.com>
1031
1032         Remove support for tvOS < 13.0
1033         https://bugs.webkit.org/show_bug.cgi?id=200963
1034         <rdar://problem/54541355>
1035
1036         Reviewed by Tim Horton.
1037
1038         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
1039         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
1040         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
1041         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
1042         130000" are always True.
1043
1044         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1045         (TestWebKitAPI::TEST):
1046
1047 2019-08-22  Daniel Bates  <dabates@apple.com>
1048
1049         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
1050         https://bugs.webkit.org/show_bug.cgi?id=200742
1051
1052         Reviewed by Simon Fraser.
1053
1054         The OptionSet synthetic provider must respond to requests for the value of m_storage
1055         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
1056         of the type summary.
1057
1058         Synthetic providers substitute alternative debug information (children) for the default
1059         information for a variable. The OptionSet type summary is implemented in terms of the
1060         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
1061         before invoking the type summary handler then evaluating GetChildMemberWithName() on
1062         the SBValue passed to the type summary handler will access the substitute information
1063         instead of the original debug information. As a result OptionSet's synthetic provider's
1064         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
1065         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
1066         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
1067         should return a valid value.
1068
1069         * lldb/lldb_webkit.py:
1070         (FlagEnumerationProvider.__init__):
1071         (FlagEnumerationProvider):
1072         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
1073         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
1074         (FlagEnumerationProvider.size): Added.
1075         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
1076         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
1077         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
1078         and removed self.size. For the latter we can just expose a getter that returns the size of
1079         the list self._elements.
1080         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
1081         value of m_storage.
1082         (WTFOptionSetProvider):
1083         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
1084         matches the specified index.
1085         * lldb/lldb_webkit_unittest.py:
1086         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
1087         that we return the value of m_storage as the last synthetic child.
1088
1089 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
1090
1091         results.webkit.org: Remove branch and repository information from commit tooltip
1092         https://bugs.webkit.org/show_bug.cgi?id=201035
1093
1094         Reviewed by Aakash Jain.
1095
1096         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1097         (xAxisFromScale): Remove branch and repository information from tooltip.
1098
1099 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
1100
1101         run-webkit-tests: Use -noBulkSymbolication when calling spindump
1102         https://bugs.webkit.org/show_bug.cgi?id=201000
1103         <rdar://problem/53778938>
1104
1105         Reviewed by Alexey Proskuryakov.
1106
1107         * Scripts/webkitpy/port/darwin.py:
1108         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
1109         * Scripts/webkitpy/port/darwin_testcase.py:
1110         (DarwinTest.test_tailspin):
1111         (DarwinTest.test_get_crash_log): Deleted.
1112         * Scripts/webkitpy/port/ios_device_unittest.py:
1113         (IOSDeviceTest.test_tailspin):
1114
1115 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
1116
1117         [results.webkit.org Webkit.css] Change input's disable style
1118         The disable input style will always show the label like it has a value
1119         https://bugs.webkit.org/show_bug.cgi?id=200998
1120
1121         Reviewed by Jonathan Bedard.
1122
1123         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
1124         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
1125         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1126         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1127         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
1128         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
1129         (@media (prefers-color-scheme: dark)):
1130
1131 2019-08-17  Darin Adler  <darin@apple.com>
1132
1133         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
1134         https://bugs.webkit.org/show_bug.cgi?id=200862
1135
1136         Reviewed by Ryosuke Niwa.
1137
1138         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1139         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
1140         * WebKitTestRunner/TestController.cpp:
1141         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
1142         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
1143         (WTR::TestController::downloadDidFail): Ditto.
1144
1145 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
1146
1147         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
1148         https://bugs.webkit.org/show_bug.cgi?id=200978
1149
1150         Unreviewed follow-up fix.
1151
1152         Update the string format specifier for unsigned it.
1153
1154         * MiniBrowser/gtk/main.c:
1155         (main):
1156         * MiniBrowser/wpe/main.cpp:
1157         (main):
1158
1159 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1160
1161         [GTK][WPE] Support for command "--version" on the MiniBrowser
1162         https://bugs.webkit.org/show_bug.cgi?id=200978
1163
1164         Reviewed by Žan Doberšek.
1165
1166         Printing the engine version used from the MiniBrowser is useful.
1167         For example, the test scripts on WPT can use this info to better
1168         tag the generated results.
1169
1170         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
1171         (main):
1172         * MiniBrowser/wpe/main.cpp: Ditto.
1173         (main):
1174
1175 2019-08-22  Youenn Fablet  <youenn@apple.com>
1176
1177         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
1178         https://bugs.webkit.org/show_bug.cgi?id=196870
1179
1180         Reviewed by Alex Christensen.
1181
1182         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
1183         Accept any server certificate by default.
1184
1185         * WebKitTestRunner/TestController.cpp:
1186         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1187         (WTR::TestController::cocoaResetStateToConsistentValues):
1188         (WTR::TestController::setAllowsAnySSLCertificate):
1189         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
1190         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1191         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
1192         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
1193
1194 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
1195
1196         results.webkit.org: Fix drawer style
1197         https://bugs.webkit.org/show_bug.cgi?id=200988
1198
1199         Rubber-stamped by Aakash Jain.
1200
1201         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1202         (Drawer): Nothing in the drawer should be selectable.
1203         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
1204         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1205         (.action:hover): Disable underline on 'links' which are actually actions
1206         (.unselectable): Make a div unselectable.
1207         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1208         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
1209
1210 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1211
1212         [Win][MiniBrowser] Add a progress indicator to the main window
1213         https://bugs.webkit.org/show_bug.cgi?id=200970
1214
1215         Reviewed by Alex Christensen.
1216
1217         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
1218         * MiniBrowser/win/MainWindow.cpp:
1219         (MainWindow::init):
1220         (MainWindow::resizeSubViews):
1221         (MainWindow::progressChanged):
1222         (MainWindow::progressFinished):
1223         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
1224         Added m_hProgressIndicator.
1225         (MainWindow::hwnd const): Deleted.
1226         (MainWindow::browserWindow const): Deleted.
1227         (): Deleted.
1228         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1229         (MiniBrowserWebHost::onNotify):
1230         * MiniBrowser/win/MiniBrowserWebHost.h:
1231         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1232         (WebKitBrowserWindow::create):
1233         (WebKitBrowserWindow::WebKitBrowserWindow):
1234         (WebKitBrowserWindow::didChangeIsLoading):
1235         (WebKitBrowserWindow::didChangeEstimatedProgress):
1236         (WebKitBrowserWindow::createNewPage):
1237         * MiniBrowser/win/WebKitBrowserWindow.h:
1238         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1239         (WebKitLegacyBrowserWindow::create):
1240         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1241         (WebKitLegacyBrowserWindow::init):
1242         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1243
1244 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
1245
1246         Unreviewed, rolling out r248970.
1247
1248         Caused
1249         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
1250         to fail.
1251
1252         Reverted changeset:
1253
1254         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
1255         non-empty set"
1256         https://bugs.webkit.org/show_bug.cgi?id=200742
1257         https://trac.webkit.org/changeset/248970
1258
1259 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
1260
1261         results.webkit.org: Add database table to save zip archives to
1262         https://bugs.webkit.org/show_bug.cgi?id=200718
1263
1264         Rubber-stamped by Aakash Jain.
1265
1266         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
1267         (ArchiveContext):
1268         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
1269         (ArchiveContext.ArchivesByCommit.unpack):
1270         (ArchiveContext.assert_zipfile):
1271         (ArchiveContext.open_zipfile):
1272         (ArchiveContext.__init__):
1273         (ArchiveContext.__enter__):
1274         (ArchiveContext.__exit__):
1275         (ArchiveContext.register): Save the provided archive to Cassandra.
1276         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
1277         (ArchiveContext._files_for_archive):
1278         (ArchiveContext.ls): List all files in the matching archives.
1279         (ArchiveContext.file): Extract a file from the matching archives.
1280         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
1281         (ArchiveContextTest):
1282         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
1283         (MockModelFactory):
1284         (MockModelFactory.process_results):
1285         (MockModelFactory.add_mock_archives):
1286         * resultsdbpy/resultsdbpy/model/model.py:
1287         (Model.__init__): Add an ArchiveContext to the model.
1288
1289 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1290
1291         [ews-build] view layout test results option should be displayed next to layout-test build step
1292         https://bugs.webkit.org/show_bug.cgi?id=200048
1293
1294         Reviewed by Jonathan Bedard.
1295
1296         * BuildSlaveSupport/ews-build/steps.py:
1297         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
1298         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
1299
1300 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews] Fix capitalization in Found x new Test failure message
1303         https://bugs.webkit.org/show_bug.cgi?id=201004
1304
1305         Reviewed by Alexey Proskuryakov.
1306
1307         * BuildSlaveSupport/ews-build/steps.py:
1308         (AnalyzeLayoutTestsResults.report_failure):
1309         (AnalyzeAPITestsResults.analyzeResults):
1310         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1311
1312 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1313
1314         Assign ews117 to EWS High-Sierra Debug queues
1315         https://bugs.webkit.org/show_bug.cgi?id=200993
1316
1317         Reviewed by Jonathan Bedard.
1318
1319         * BuildSlaveSupport/ews-build/config.json:
1320
1321 2019-08-21  Daniel Bates  <dabates@apple.com>
1322
1323         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
1324         https://bugs.webkit.org/show_bug.cgi?id=200742
1325
1326         Reviewed by Simon Fraser.
1327
1328         The OptionSet synthetic provider must respond to requests for the value of m_storage
1329         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
1330         of the type summary.
1331
1332         Synthetic providers substitute alternative debug information (children) for the default
1333         information for a variable. The OptionSet type summary is implemented in terms of the
1334         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
1335         before invoking the type summary handler then evaluating GetChildMemberWithName() on
1336         the SBValue passed to the type summary handler will access the substitute information
1337         instead of the original debug information. As a result OptionSet's synthetic provider's
1338         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
1339         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
1340         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
1341         should return a valid value.
1342
1343         * lldb/lldb_webkit.py:
1344         (FlagEnumerationProvider.__init__):
1345         (FlagEnumerationProvider):
1346         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
1347         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
1348         (FlagEnumerationProvider.size): Added.
1349         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
1350         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
1351         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
1352         and removed self.size. For the latter we can just expose a getter that returns the size of
1353         the list self._elements.
1354         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
1355         value of m_storage.
1356         (WTFOptionSetProvider):
1357         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
1358         matches the specified index.
1359
1360 2019-08-21  Alex Christensen  <achristensen@webkit.org>
1361
1362         Disabling text autosizing should prevent text autosizing
1363         https://bugs.webkit.org/show_bug.cgi?id=200955
1364         <rdar://problem/48095374>
1365
1366         Reviewed by Simon Fraser.
1367
1368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1369         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
1370         (TEST):
1371
1372 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
1373
1374         [GTK][WPE] Make debug-test-runner work
1375         https://bugs.webkit.org/show_bug.cgi?id=193576
1376
1377         Reviewed by Michael Catanzaro.
1378
1379         * Scripts/webkitdirs.pm:
1380         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
1381         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
1382         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
1383         (execUnixAppForDebugging): Added.
1384         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
1385
1386 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
1387
1388         Put keygen element behind a runtime flag and disable it by default
1389         https://bugs.webkit.org/show_bug.cgi?id=200850
1390
1391         Reviewed by Antti Koivisto.
1392
1393         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
1394
1395         * DumpRenderTree/TestOptions.cpp:
1396         (TestOptions::TestOptions):
1397         * DumpRenderTree/TestOptions.h:
1398         * DumpRenderTree/mac/DumpRenderTree.mm:
1399         (setWebPreferencesForTestOptions):
1400         * DumpRenderTree/win/DumpRenderTree.cpp:
1401         (setWebPreferencesForTestOptions):
1402         * WebKitTestRunner/TestController.cpp:
1403         (WTR::TestController::resetPreferencesToConsistentValues):
1404         (WTR::updateTestOptionsFromTestHeader):
1405         * WebKitTestRunner/TestOptions.h:
1406         (WTR::TestOptions::hasSameInitializationOptions const):
1407
1408 2019-08-21  Chris Dumez  <cdumez@apple.com>
1409
1410         Add internal setting to disable SecureContext checks
1411         https://bugs.webkit.org/show_bug.cgi?id=200980
1412         <rdar://problem/54438512>
1413
1414         Reviewed by Alex Christensen.
1415
1416         Add API test coverage.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1419         (log):
1420         (requestPermission):
1421
1422 2019-08-21  Keith Rollin  <krollin@apple.com>
1423
1424         Remove support for watchOS < 6.0
1425         https://bugs.webkit.org/show_bug.cgi?id=200937
1426         <rdar://problem/54524009>
1427
1428         Reviewed by Darin Adler.
1429
1430         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
1431         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
1432         60000. This means that expressions like
1433         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
1434         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
1435
1436         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1437         (TestWebKitAPI::TEST):
1438
1439 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
1440
1441         [results.webkit.org Webkit.css] Add right sidebar
1442         https://bugs.webkit.org/show_bug.cgi?id=200946
1443
1444         Reviewed by Jonathan Bedard.
1445
1446         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1447         (@media screen and (min-width: 600px) and (orientation: landscape)):
1448         (.main.left):
1449         (@media screen and (min-width: 768px) and (orientation: landscape)):
1450         (.sidebar.right):
1451
1452 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
1453
1454         results.webkit.org: Add ToolTips
1455         https://bugs.webkit.org/show_bug.cgi?id=200801
1456
1457         Rubber-stamped by Aakash Jain.
1458
1459         When dots or scale labels are hovered over, we should display a tool tip with additional information about
1460         The specific element.
1461
1462         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
1463         (.tooltip): Add class for ToolTip text box.
1464         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
1465         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
1466         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
1467         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
1468         repositories at a given time.
1469         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1470         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
1471         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
1472         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
1473         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
1474         (_ToolTip):
1475         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
1476         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
1477         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
1478         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
1479         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1480         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
1481         dot and scale elements.
1482         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
1483         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1484
1485 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
1486
1487         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
1488         https://bugs.webkit.org/show_bug.cgi?id=200782
1489
1490         Reviewed by Saam Barati.
1491
1492         * Scripts/run-jsc-stress-tests:
1493
1494 2019-08-20  Darin Adler  <darin@apple.com>
1495
1496         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
1497         https://bugs.webkit.org/show_bug.cgi?id=200921
1498
1499         Reviewed by Saam Barati.
1500
1501         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1502         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
1503         need to abort after the first failure. Added three new tests to the VariadicAppend
1504         test to cover various cases of upconverting from 8-bit to 16-bit strings.
1505
1506 2019-08-20  Dean Jackson  <dino@apple.com>
1507
1508         REGRESSION: Open in New Tab is missing from context menu
1509         https://bugs.webkit.org/show_bug.cgi?id=200909
1510         <rdar://problem/54476169>
1511
1512         Reviewed by Simon Fraser.
1513
1514         Add a new test that runs through the legacy context menu
1515         flow, and verifies that it will be called if there aren't
1516         appropriate delegates for the new API.
1517
1518         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1519         (contextMenuWebViewDriver):
1520         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1521         (TEST):
1522         (-[LegacyPreviewViewController previewActionItems]):
1523         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
1524         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
1525         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1526         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
1527         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
1528
1529 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1530
1531         [JSC] OSR entry to Wasm OMG
1532         https://bugs.webkit.org/show_bug.cgi?id=200362
1533
1534         Reviewed by Michael Saboff.
1535
1536         * Scripts/run-jsc-stress-tests:
1537
1538 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
1539
1540         [results.webkit.org Timeline] Disable back gesture
1541         https://bugs.webkit.org/show_bug.cgi?id=200839
1542
1543         Reviewed by Jonathan Bedard.
1544
1545         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1546         * resultsdbpy/resultsdbpy/view/templates/base.html:
1547
1548 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
1549
1550         results-webkit.org: Add timeout to Redis locks
1551         https://bugs.webkit.org/show_bug.cgi?id=200890
1552
1553         Reviewed by Aakash Jain.
1554
1555         * resultsdbpy/resultsdbpy/model/upload_context.py:
1556         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
1557
1558 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
1559
1560         Remove IDB-specific quota
1561         https://bugs.webkit.org/show_bug.cgi?id=196545
1562         <rdar://problem/54201783>
1563
1564         Reviewed by Youenn Fablet.
1565
1566         * DumpRenderTree/TestRunner.cpp:
1567         (TestRunner::staticFunctions):
1568         (setIDBPerOriginQuotaCallback): Deleted.
1569         * DumpRenderTree/TestRunner.h:
1570         * DumpRenderTree/mac/DumpRenderTree.mm:
1571         (runTest):
1572         * DumpRenderTree/mac/TestRunnerMac.mm:
1573         (TestRunner::setIDBPerOriginQuota): Deleted.
1574         * DumpRenderTree/win/TestRunnerWin.cpp:
1575         (TestRunner::setIDBPerOriginQuota): Deleted.
1576         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1577         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1578         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1579         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1580         * WebKitTestRunner/TestController.cpp:
1581         (WTR::TestController::resetStateToConsistentValues):
1582         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1583         * WebKitTestRunner/TestController.h:
1584         * WebKitTestRunner/TestInvocation.cpp:
1585         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1586
1587 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1588
1589         [WTF] Style checker should tell errors when it finds std::make_unique
1590         https://bugs.webkit.org/show_bug.cgi?id=200878
1591
1592         Reviewed by Ross Kirsling.
1593
1594         * Scripts/webkitpy/style/checkers/cpp.py:
1595         (check_wtf_make_unique):
1596         (check_style):
1597         (CppChecker):
1598
1599 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
1600
1601         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
1602         https://bugs.webkit.org/show_bug.cgi?id=200620
1603
1604         Reviewed by Geoffrey Garen.
1605
1606         * DumpRenderTree/TestRunner.cpp:
1607         (addURLToRedirectCallback):
1608         (setWillSendRequestClearHeaderCallback):
1609         (TestRunner::setAccummulateLogsForChannel):
1610         (TestRunner::runUIScript):
1611         (TestRunner::setOpenPanelFiles):
1612         * DumpRenderTree/mac/DumpRenderTree.mm:
1613         (dumpFramesAsText):
1614         * DumpRenderTree/mac/EventSendingController.mm:
1615         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1616         * DumpRenderTree/win/DRTDataObject.cpp:
1617         (DRTDataObject::SetData):
1618         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1619         (FrameLoadDelegate::FrameLoadDelegate):
1620         * DumpRenderTree/win/UIDelegate.cpp:
1621         (DRTUndoManager::DRTUndoManager):
1622         (UIDelegate::UIDelegate):
1623         (UIDelegate::resetUndoManager):
1624         * TestWebKitAPI/JavaScriptTest.cpp:
1625         (TestWebKitAPI::runJSTest):
1626         * TestWebKitAPI/PlatformUtilities.cpp:
1627         (TestWebKitAPI::Util::toSTD):
1628         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1629         (TestWebKitAPI::TEST):
1630         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1633         (TestWebKitAPI::TEST):
1634         (TestWebKitAPI::testMovingUsingEnsure):
1635         (TestWebKitAPI::testMovingUsingAdd):
1636         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1637         (TestWebKitAPI::TEST):
1638         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1641         (TestWebKitAPI::runLockTest):
1642         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1643         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1644         (TestWebKitAPI::TEST):
1645         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1646         (TestWebKitAPI::TEST):
1647         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1648         (TestWebKitAPI::TEST):
1649         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
1652         (TestWebKitAPI::CARingBufferTest::SetUp):
1653         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1654         (TestWebKitAPI::createTestValue):
1655         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1658         (TestWebKitAPI::TEST_F):
1659         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1660         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1661         (TestWebKitAPI::createNewPage):
1662         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1663         (TestWebKitAPI::createNewPage):
1664         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
1665         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
1666         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
1667         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
1668         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
1669         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1670         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1671         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1672         (serverCallback):
1673         (testWebViewAuthenticationProxyHTTPS):
1674         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1675         (WebKitDOMDOMWindowTest::create):
1676         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
1677         (TestWebKitAPI::Util::toSTD):
1678         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1679         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1680         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1681         * TestWebKitAPI/mac/TestFontOptions.mm:
1682         (-[TestFontOptions initWithFontOptions:]):
1683         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1684         (WTR::EventSendingController::callAfterScrollingCompletes):
1685         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1686         (WTR::InjectedBundle::didCreatePage):
1687         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1688         (WTR::TestRunner::setOpenPanelFiles):
1689         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1690         * WebKitTestRunner/StringFunctions.h:
1691         (WTR::toSTD):
1692         (WTR::toWTFString):
1693         * WebKitTestRunner/TestController.cpp:
1694         (WTR::TestController::initialize):
1695         (WTR::TestController::generatePageConfiguration):
1696         (WTR::TestController::resetStateToConsistentValues):
1697         (WTR::createTestURL):
1698         (WTR::TestController::runTest):
1699         (WTR::TestController::platformCreateWebView):
1700         * WebKitTestRunner/TestInvocation.cpp:
1701         (WTR::TestInvocation::runUISideScript):
1702         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1703         (WTR::TestController::platformCreateWebView):
1704         (WTR::TestController::setDefaultCalendarType):
1705         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1706         (WTR::getGDKKeySymForKeyRef):
1707         * WebKitTestRunner/ios/TestControllerIOS.mm:
1708         (WTR::TestController::platformResetStateToConsistentValues):
1709         (WTR::TestController::setKeyboardInputModeIdentifier):
1710         * WebKitTestRunner/mac/EventSenderProxy.mm:
1711         (WTR::EventSenderProxy::mouseDown):
1712         (WTR::EventSenderProxy::mouseUp):
1713         (WTR::EventSenderProxy::mouseMoveTo):
1714         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1715         (WTR::wpeKeySymForKeyRef):
1716
1717 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
1718
1719         [ESNext] Implement optional chaining
1720         https://bugs.webkit.org/show_bug.cgi?id=200199
1721
1722         Reviewed by Yusuke Suzuki.
1723
1724         * Scripts/run-jsc-stress-tests:
1725
1726 2019-08-17  Tim Horton  <timothy_horton@apple.com>
1727
1728         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
1729         https://bugs.webkit.org/show_bug.cgi?id=200866
1730         <rdar://problem/50254021>
1731
1732         Reviewed by Simon Fraser.
1733
1734         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1735         (WTR::PlatformWebView::windowSnapshotImage):
1736         Replace some logging with release assertions that we are snapshotting a reasonable
1737         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
1738         "silently" failing with just a log that will be ignored is not helpful.
1739
1740 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
1741
1742         [WTF] ThreadGroupRemove test is flaky
1743         https://bugs.webkit.org/show_bug.cgi?id=200763
1744
1745         Reviewed by Mark Lam.
1746
1747         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
1748         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
1749         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
1750         and releasing the lock after that.
1751
1752         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1753         (TestWebKitAPI::TEST):
1754
1755 2019-08-17  Eric Liang  <ericliang@apple.com>
1756
1757         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
1758         https://bugs.webkit.org/show_bug.cgi?id=200367
1759
1760         Reviewed by Darin Adler.
1761
1762         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView.
1763
1764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1765         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
1766         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
1767         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
1768         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
1769         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1770         (TestWebKitAPI::TEST):
1771
1772 2019-08-17  Sam Weinig  <weinig@apple.com>
1773
1774         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
1775         https://bugs.webkit.org/show_bug.cgi?id=200756
1776
1777         Reviewed by Darin Adler.
1778
1779         Update call sites for rename from StringBuilder::flexibleAppend(...) to
1780         StringBuilder::append(...).
1781
1782         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1783         (TestWebKitAPI::TEST):
1784
1785 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
1786
1787         [iOS WK2] Scroll indicators disappear sometimes
1788         https://bugs.webkit.org/show_bug.cgi?id=200791
1789
1790         Reviewed by Tim Horton.
1791
1792         Tests that test that scroll indicators survive subview replacement, and that
1793         a custom view also survives subview replacement.
1794
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/cocoa/TestWKWebView.h:
1799         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1800         (-[TestWKWebView performAfterLoading:]):
1801         (-[UIView wkFirstSubviewWithClass:]):
1802         (-[UIView wkFirstSubviewWithBoundsSize:]):
1803         * TestWebKitAPI/ios/composited.html: Added.
1804         * TestWebKitAPI/ios/overflow-scroll.html: Added.
1805
1806 2019-08-16  John Wilander  <wilander@apple.com>
1807
1808         Add John Wilander as WebKit Reviewer
1809         https://bugs.webkit.org/show_bug.cgi?id=200837
1810
1811         Unreviewed update to contributors.json to change my status to reviewer.
1812         See email on reviewers mailing list for proof of granted privileges.
1813
1814         * Scripts/webkitpy/common/config/contributors.json:
1815
1816 2019-08-16  Timothy Hatcher  <timothy@apple.com>
1817
1818         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
1819         https://bugs.webkit.org/show_bug.cgi?id=200802
1820         rdar://problem/54357818
1821
1822         Reviewed by Tim Horton.
1823
1824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
1825         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
1826         (-[OpaqueTestWKWebView isOpaque]): Added.
1827         (-[NonOpaqueTestWKWebView isOpaque]): Added.
1828         (isOpaque): Added.
1829         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
1830         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
1831         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
1832
1833 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1834
1835         [ews] Add build steps for Windows Factory
1836         https://bugs.webkit.org/show_bug.cgi?id=200813
1837
1838         Reviewed by Jonathan Bedard.
1839
1840         * BuildSlaveSupport/ews-build/factories.py:
1841         (WindowsFactory.__init__):
1842
1843 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1844
1845         [ews] Report machine uptime in PrintConfiguration
1846         https://bugs.webkit.org/show_bug.cgi?id=200812
1847
1848         Reviewed by Jonathan Bedard.
1849
1850         * BuildSlaveSupport/ews-build/steps.py:
1851         (PrintConfiguration): Added uptime command.
1852         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1853
1854 2019-08-16  Chris Lord  <clord@igalia.com>
1855
1856         Add shared-mime-info to WPE WebKit jhbuild
1857         https://bugs.webkit.org/show_bug.cgi?id=200768
1858
1859         Reviewed by Carlos Alberto Lopez Perez.
1860
1861         * wpe/jhbuild.modules:
1862
1863 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
1864
1865         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
1866         https://bugs.webkit.org/show_bug.cgi?id=200620
1867
1868         Reviewed by Geoffrey Garen.
1869
1870         * DumpRenderTree/AccessibilityController.h:
1871         * DumpRenderTree/GCController.h:
1872         * DumpRenderTree/win/DRTDataObject.cpp:
1873         * DumpRenderTree/win/DRTDataObject.h:
1874         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1875         * DumpRenderTree/win/DRTDropSource.h:
1876         * DumpRenderTree/win/DraggingInfo.h:
1877         * DumpRenderTree/win/EditingDelegate.h:
1878         * DumpRenderTree/win/EventSender.cpp:
1879         * DumpRenderTree/win/FrameLoadDelegate.h:
1880         * DumpRenderTree/win/HistoryDelegate.h:
1881         * DumpRenderTree/win/MD5.h:
1882         * DumpRenderTree/win/PolicyDelegate.h:
1883         * DumpRenderTree/win/ResourceLoadDelegate.h:
1884         * DumpRenderTree/win/TextInputController.h:
1885         * DumpRenderTree/win/UIDelegate.cpp:
1886         * DumpRenderTree/win/UIDelegate.h:
1887         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1888         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
1889         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
1890         * TestWebKitAPI/Counters.h:
1891         * TestWebKitAPI/PlatformWebView.h:
1892         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1893         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1894         (TestWebKitAPI::DerefObserver::ref):
1895         (TestWebKitAPI::DerefObserver::deref):
1896         (TestWebKitAPI::TEST):
1897         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1898         (TestWebKitAPI::DerefObserver::ref):
1899         (TestWebKitAPI::DerefObserver::deref):
1900         (TestWebKitAPI::TEST):
1901         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
1902         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1903         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1904         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1905         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1906         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1907         * WebKitTestRunner/EventSenderProxy.h:
1908         * WebKitTestRunner/GeolocationProviderMock.h:
1909         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1910         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1911         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1912         * WebKitTestRunner/PlatformWebView.h:
1913         * WebKitTestRunner/TestInvocation.h:
1914
1915 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
1916
1917         Some improvements on web storage
1918         https://bugs.webkit.org/show_bug.cgi?id=200373
1919
1920         Reviewed by Geoffrey Garen.
1921
1922         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1923         (TEST): update expectation for behavior change.
1924
1925         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to
1926         database file.
1927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1928         (WTR::TestRunner::syncLocalStorage):
1929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1930
1931         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
1932         (WTR::TestController::resetStateToConsistentValues):
1933         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
1934         (WTR::StorageVoidCallback):
1935         (WTR::TestController::clearIndexedDatabases):
1936         (WTR::TestController::clearLocalStorage):
1937         (WTR::TestController::syncLocalStorage):
1938         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
1939         with StorageVoidCallbackContext for general usage.
1940         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
1941         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
1942         * WebKitTestRunner/TestController.h:
1943
1944         * WebKitTestRunner/TestInvocation.cpp:
1945         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message
1946         SyncLocalStorage.
1947
1948 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
1949
1950         results.webkit.org: Add content hook to FlaskRequestsResponse
1951         https://bugs.webkit.org/show_bug.cgi?id=200721
1952
1953         Rubber-stamped by Aakash Jain.
1954
1955         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
1956         (FlaskRequestsResponse):
1957         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
1958         Response, conforming to request's API.
1959
1960 2019-08-15  Alex Christensen  <achristensen@webkit.org>
1961
1962         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
1963         https://bugs.webkit.org/show_bug.cgi?id=200750
1964         <rdar://problem/54232261> and <rdar://problem/52355829>
1965
1966         Reviewed by Tim Horton.
1967
1968         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1969         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1970         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1971         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1972         (contextMenuWebViewDriver):
1973         (TEST):
1974
1975 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1976
1977         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
1978         https://bugs.webkit.org/show_bug.cgi?id=200726
1979
1980         Reviewed by Simon Fraser.
1981
1982         To get the pixels as an array of colors, draw the image into a memory
1983         context. The backing memory buffer can then be accessed to get the image
1984         pixels' colors.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1987         (TestWebKitAPI::TEST):
1988
1989 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
1990
1991         Unreviewed, rolling out r248526.
1992
1993         Caused two IndexedDB perf tests to fail
1994
1995         Reverted changeset:
1996
1997         "Remove IDB-specific quota"
1998         https://bugs.webkit.org/show_bug.cgi?id=196545
1999         https://trac.webkit.org/changeset/248526
2000
2001 2019-08-14  Keith Rollin  <krollin@apple.com>
2002
2003         Remove support for macOS < 10.13
2004         https://bugs.webkit.org/show_bug.cgi?id=200694
2005         <rdar://problem/54278851>
2006
2007         Reviewed by Youenn Fablet.
2008
2009         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
2010         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
2011         101300. This means that expressions like
2012         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
2013         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
2014
2015         * MiniBrowser/AppKitCompatibilityDeclarations.h:
2016         * MiniBrowser/mac/SettingsController.m:
2017         (-[SettingsController init]):
2018         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
2019         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
2020         (TestWebKitAPI::createPlatformFont): Deleted.
2021         (TestWebKitAPI::compareFonts): Deleted.
2022         (TestWebKitAPI::TEST_F): Deleted.
2023         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2024         (TestWebKitAPI::TEST):
2025         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2026         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2027         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2028         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2029         (runWebsiteDataStoreCustomPaths):
2030         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
2031
2032 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
2033
2034         [JSC] Less contended MetaAllocator
2035         https://bugs.webkit.org/show_bug.cgi?id=200278
2036
2037         Reviewed by Mark Lam.
2038
2039         Update the interface.
2040
2041         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2042
2043 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
2044
2045         results.webkit.org: 500 errors on API endpoints don't return JSON
2046         https://bugs.webkit.org/show_bug.cgi?id=200722
2047
2048         Reviewed by Aakash Jain.
2049
2050         * resultsdbpy/resultsdbpy/controller/api_routes.py:
2051         (APIRoutes.response_500): We should return the response, instead of abort.
2052
2053 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
2054
2055         results.webkit.org: Don't save configuration multiple times in upload
2056         https://bugs.webkit.org/show_bug.cgi?id=200719
2057
2058         Reviewed by Aakash Jain.
2059
2060         * resultsdbpy/resultsdbpy/model/upload_context.py:
2061         (UploadContext.upload_test_results): Move registering of the configuration out
2062         of the branch loop.
2063
2064 2019-08-14  Youenn Fablet  <youenn@apple.com>
2065
2066         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
2067         https://bugs.webkit.org/show_bug.cgi?id=200706
2068
2069         Reviewed by Alex Christensen.
2070
2071         Libwebrtc is now soft-linked so we can reenable this test.
2072
2073         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
2074         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
2075
2076 2019-08-13  Sam Weinig  <weinig@apple.com>
2077
2078         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
2079         https://bugs.webkit.org/show_bug.cgi?id=200675
2080
2081         Reviewed by Darin Adler.
2082
2083         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2084         (TestWebKitAPI::TEST):
2085         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
2086
2087 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
2088
2089         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
2090         https://bugs.webkit.org/show_bug.cgi?id=200456
2091
2092         Reviewed by Jonathan Bedard.
2093
2094         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
2095
2096         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
2097
2098         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
2099         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2100         (pointPolygonCollisionDetect): Detact
2101         (pointRightRayLineSegmentCollisionDetect):
2102         (ColorBatchRender):
2103         (ColorBatchRender.prototype.lazyCreateColorSeqs):
2104         (ColorBatchRender.prototype.addSeq):
2105         (ColorBatchRender.prototype.batchRender):
2106         (ColorBatchRender.prototype.clear):
2107         (xScrollStreamRenderFactory):
2108         (Timeline.CanvasSeriesComponent):
2109         (offscreenCachedRenderFactory): Deleted.
2110
2111 2019-08-13  John Wilander  <wilander@apple.com>
2112
2113         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
2114         https://bugs.webkit.org/show_bug.cgi?id=200642
2115         <rdar://problem/53962073>
2116
2117         Reviewed by Alex Christensen.
2118
2119         This patch adds test infrastructure to query whether an origin has an
2120         isolated NSURLSession or not.
2121
2122         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2124         (WTR::TestRunner::hasStatisticsIsolatedSession):
2125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::hasStatisticsIsolatedSession):
2128         * WebKitTestRunner/TestController.h:
2129         * WebKitTestRunner/TestInvocation.cpp:
2130         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2131
2132 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
2133
2134         Update my status in contributors.json to committer.
2135
2136         Reviewed by Unreviewed
2137
2138         * Scripts/webkitpy/common/config/contributors.json:
2139
2140 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
2141
2142         Adds WebAuthn and AppSSO into watchlist
2143         https://bugs.webkit.org/show_bug.cgi?id=200647
2144
2145         Reviewed by Dewei Zhu.
2146
2147         * Scripts/webkitpy/common/config/watchlist:
2148
2149 2019-08-13  Chris Dumez  <cdumez@apple.com>
2150
2151         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
2152         https://bugs.webkit.org/show_bug.cgi?id=200674
2153         <rdar://problem/50692748>
2154
2155         Reviewed by Geoff Garen.
2156
2157         Add API test coverage.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2160
2161 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
2162
2163         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
2164         https://bugs.webkit.org/show_bug.cgi?id=199857
2165
2166         Reviewed by Yusuke Suzuki.
2167
2168         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2169         (TestWebKitAPI::countThreadGroups):
2170         (TestWebKitAPI::TEST):
2171
2172 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
2173
2174         AX: Homebrew is not allowed to run any script under sudo.
2175         https://bugs.webkit.org/show_bug.cgi?id=173801
2176
2177         Reviewed by Carlos Alberto Lopez Perez.
2178
2179         Latest versions of Homebrew throw an error when run as root.
2180         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
2181
2182         * gtk/install-dependencies:
2183
2184 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
2185
2186         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
2187         https://bugs.webkit.org/show_bug.cgi?id=200644
2188
2189         Reviewed by Aakash Jain.
2190
2191         * Scripts/webkitpy/port/simulator_process.py:
2192         (SimulatorProcess._start): Define system PID after launching app.
2193
2194 2019-08-12  Sam Weinig  <weinig@apple.com>
2195
2196         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
2197         https://bugs.webkit.org/show_bug.cgi?id=200614
2198
2199         Reviewed by Darin Adler.
2200
2201         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and
2202         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
2203
2204         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to
2205         StringBuilder::appendSubstring(...).
2206
2207         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2208         (TestWebKitAPI::TEST):
2209         Update for renames.
2210
2211 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
2212
2213         Fix Crash in Mail Search
2214         https://bugs.webkit.org/show_bug.cgi?id=200589
2215
2216         Reviewed by Tim Horton.
2217
2218         If you search backwards first in mail, we would crash,
2219         this tests that codepath.
2220
2221         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2222         (TEST):
2223
2224 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2225
2226         [iPadOS] Web pages sometimes load at half width in Safari
2227         https://bugs.webkit.org/show_bug.cgi?id=200624
2228         <rdar://problem/52694257>
2229
2230         Reviewed by Simon Fraser.
2231
2232         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
2233         web page is created using the post-animated-resize web view dimensions, rather than the original layout
2234         dimensions.
2235
2236         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2237
2238 2019-08-12  Daniel Bates  <dabates@apple.com>
2239
2240         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
2241         https://bugs.webkit.org/show_bug.cgi?id=200548
2242
2243         Reviewed by Darin Adler.
2244
2245         Expose infrastructure to simulate a literal raw key down and a literal key up event.
2246
2247         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2248         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2249         (WTR::UIScriptController::rawKeyDown):
2250         (WTR::UIScriptController::rawKeyUp):
2251         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2252         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2253         (WTR::UIScriptControllerIOS::rawKeyDown):
2254         (WTR::UIScriptControllerIOS::rawKeyUp):
2255
2256 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
2257
2258         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
2259         https://bugs.webkit.org/show_bug.cgi?id=200584
2260
2261         Reviewed by Philippe Normand.
2262
2263         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
2264         Ignore style libwebrtc optionnal 'style issue'
2265
2266         * Scripts/webkitpy/style/checker.py:
2267         * gstreamer/jhbuild.modules:
2268         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
2269
2270 2019-08-12  Youenn Fablet  <youenn@apple.com>
2271
2272         Remove IDB-specific quota
2273         https://bugs.webkit.org/show_bug.cgi?id=196545
2274
2275         Reviewed by Alex Christensen.
2276
2277         * DumpRenderTree/TestRunner.cpp:
2278         (TestRunner::staticFunctions):
2279         (setIDBPerOriginQuotaCallback): Deleted.
2280         * DumpRenderTree/TestRunner.h:
2281         * DumpRenderTree/mac/DumpRenderTree.mm:
2282         (runTest):
2283         * DumpRenderTree/mac/TestRunnerMac.mm:
2284         (TestRunner::setIDBPerOriginQuota): Deleted.
2285         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2287         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
2288         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2289         * WebKitTestRunner/TestController.cpp:
2290         (WTR::TestController::resetStateToConsistentValues):
2291         (WTR::TestController::setIDBPerOriginQuota): Deleted.
2292         * WebKitTestRunner/TestController.h:
2293         * WebKitTestRunner/TestInvocation.cpp:
2294         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2295
2296 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
2297
2298         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
2299         https://bugs.webkit.org/show_bug.cgi?id=200621
2300
2301         Reviewed by Dan Bernstein.
2302
2303         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2304
2305 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2306
2307         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
2308         https://bugs.webkit.org/show_bug.cgi?id=200604
2309         <rdar://problem/51273130>
2310
2311         Reviewed by Megan Gardner.
2312
2313         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
2314         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
2315         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
2316         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
2317         remains the same.
2318
2319         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
2320         the caret rect at initial scale 1.
2321
2322         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2323
2324 2019-08-09  Ali Juma  <ajuma@chromium.org>
2325
2326         Don't allow cross-origin iframes to autofocus
2327         https://bugs.webkit.org/show_bug.cgi?id=200515
2328         <rdar://problem/54092988>
2329
2330         Reviewed by Ryosuke Niwa.
2331
2332         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
2333         of cross-origin iframes, since it depends on focusing one of the
2334         frames.
2335
2336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2337         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2338         (TestWebKitAPI::TEST):
2339         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
2340
2341 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2342
2343         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
2344         https://bugs.webkit.org/show_bug.cgi?id=200591
2345         <rdar://problem/54102238>
2346
2347         Reviewed by Ryosuke Niwa and Tim Horton.
2348
2349         Add a new API test to exercise -supportsImagePaste.
2350
2351         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2352         (TestWebKitAPI::TEST):
2353         * TestWebKitAPI/ios/UIKitSPI.h:
2354
2355 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2356
2357         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
2358         [ews-build] Set svn:ignore to various EWS Buildbot files
2359         https://bugs.webkit.org/show_bug.cgi?id=200581
2360
2361         Reviewed by Jonathan Bedard.
2362
2363         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2364
2365 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2366
2367         [ews-build] Set svn:ignore to various EWS Buildbot files
2368         https://bugs.webkit.org/show_bug.cgi?id=200581
2369
2370         Reviewed by Jonathan Bedard.
2371
2372         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2373
2374 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2375
2376         [ews] Add buildbot.tac to repository
2377         https://bugs.webkit.org/show_bug.cgi?id=200580
2378
2379         Reviewed by Jonathan Bedard.
2380
2381         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
2382
2383 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
2384
2385         [GTK] Add missing spellchecking packages to dependencies script
2386         https://bugs.webkit.org/show_bug.cgi?id=200574
2387
2388         Reviewed by Philippe Normand.
2389
2390         These are needed for the spellchecking test in WebContext API tests.
2391
2392         * gtk/install-dependencies:
2393
2394 2019-08-08  Jon Lee  <jonlee@apple.com>
2395
2396         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
2397
2398 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2399
2400         webkitpy: Disable shared clipboard between Simulators
2401         https://bugs.webkit.org/show_bug.cgi?id=200546
2402
2403         Reviewed by Aakash Jain.
2404
2405         * Scripts/webkitpy/xcode/simulated_device.py:
2406         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
2407         managed by run-webkit-tests.
2408
2409 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
2410
2411         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
2412         https://bugs.webkit.org/show_bug.cgi?id=200539
2413         <rdar://problem/54082550>
2414
2415         Reviewed by Dean Jackson.
2416
2417         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2418         * PlatformFTW.cmake: Added.
2419
2420 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2421
2422         [iOS] Position image information should respect the image orientation
2423         https://bugs.webkit.org/show_bug.cgi?id=200487
2424
2425         Reviewed by Simon Fraser.
2426
2427         Add an API test to verify the position image information is drawn rotated
2428         because of respecting its image orientation.
2429
2430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2431         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2432         (TestWebKitAPI::TEST):
2433         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
2434         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
2435
2436 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2437
2438         [GTK] Fix WebContext languages test
2439         https://bugs.webkit.org/show_bug.cgi?id=200538
2440
2441         Reviewed by Alex Christensen.
2442
2443         This test broke after the format of Accepted-Languages
2444         was changed in r238236, update.
2445
2446         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2447         (testWebContextLanguages):
2448
2449 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2450
2451         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
2452         https://bugs.webkit.org/show_bug.cgi?id=200536
2453
2454         Reviewed by Carlos Alberto Lopez Perez.
2455
2456         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2457         (testWebsiteDataDatabases): Databases take a moment to be written,
2458         wait before fetching the data as it's done in other tests.
2459
2460 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2461
2462         results.webkit.org: Use canvas for timeline
2463         https://bugs.webkit.org/show_bug.cgi?id=200172
2464
2465         Rubber-stamped by Aakash Jain.
2466
2467         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2468         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
2469         (Commit.compare): Ditto.
2470         (_CommitBank.commitByUuid): Ditto.
2471         (_CommitBank._loadSiblings): Ditto.
2472         (_CommitBank._load): Ditto.
2473         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2474         (tickForCommit): Deleted.
2475         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
2476         which encompasses all results. Crucially, this function must exclude an UUIDs which may
2477         refer to results excluded because of the limit argument.
2478         (renderTimeline): Deleted.
2479         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
2480         with those results.
2481         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
2482         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
2483         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
2484         (inPlaceCombine): Combine result objects together.
2485         (statsForSingleResult): Turn a single result into a stat object.
2486         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
2487         (Dot): Deleted.
2488         (TimelineFromEndpoint): Renamed from Timeline.
2489         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
2490         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
2491         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
2492         cache contents.
2493         (TimelineFromEndpoint.reload): Remove management of nested timelines.
2494         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
2495         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
2496         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2497
2498 2019-08-08  Brady Eidson  <beidson@apple.com>
2499
2500         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
2501         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
2502
2503         Reviewed by Geoff Garen.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
2507
2508 2019-08-08  Rob Buis  <rbuis@igalia.com>
2509
2510         Add runtime flag for lazy image loading
2511         https://bugs.webkit.org/show_bug.cgi?id=199794
2512
2513         Reviewed by Darin Adler.
2514
2515         Set lazyImageLoading preference as part of experimental features. Add
2516         TestOption for lazy image loading.
2517
2518         * DumpRenderTree/TestOptions.cpp:
2519         (TestOptions::TestOptions):
2520         * DumpRenderTree/TestOptions.h:
2521         * DumpRenderTree/mac/DumpRenderTree.mm:
2522         (enableExperimentalFeatures):
2523         (setWebPreferencesForTestOptions):
2524         * DumpRenderTree/win/DumpRenderTree.cpp:
2525         (enableExperimentalFeatures):
2526
2527 2019-08-08  Rob Buis  <rbuis@igalia.com>
2528
2529         Import lazy loading WPT tests
2530         https://bugs.webkit.org/show_bug.cgi?id=199795
2531
2532         Reviewed by Darin Adler.
2533
2534         Only do loading/ exception for WebKit specific, non WPT tests.
2535
2536         * DumpRenderTree/mac/DumpRenderTree.mm:
2537         (shouldLogFrameLoadDelegates):
2538         * WebKitTestRunner/TestInvocation.cpp:
2539         (WTR::TestInvocation::TestInvocation):
2540
2541 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2542
2543         [Win][MiniBrowser] Add key accelerators for reload and close window
2544         https://bugs.webkit.org/show_bug.cgi?id=200497
2545
2546         Reviewed by Brent Fulgham.
2547
2548         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
2549
2550         * MiniBrowser/win/MainWindow.cpp:
2551         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
2552         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
2553         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
2554
2555 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
2556
2557         Add WHLSL and WebGPU to the watchlist file
2558         https://bugs.webkit.org/show_bug.cgi?id=200509
2559
2560         Reviewed by Robin Morisset.
2561
2562         * Scripts/webkitpy/common/config/watchlist:
2563
2564 2019-08-07  Keith Rollin  <krollin@apple.com>
2565
2566         Unreviewed build fix after r248317 -- disable XCBuild because it
2567         breaks incremental builds.
2568
2569         * Scripts/webkitdirs.pm:
2570         (canUseXCBuild):
2571
2572 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2573
2574         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
2575         https://bugs.webkit.org/show_bug.cgi?id=200465
2576
2577         Reviewed by Alex Christensen.
2578
2579         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
2580         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
2581         finishing the test.
2582         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2583         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
2584
2585 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2586
2587         Unreviewed, a build fix after r248308
2588
2589         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
2590
2591         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2592
2593 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2594
2595         Unreviewed, a build fix after r248319
2596
2597         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
2598
2599         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2600         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2601         (WTR::TestController::addTestKeyToKeychain):
2602         (WTR::TestController::cleanUpKeychain):
2603         (WTR::TestController::keyExistsInKeychain):
2604
2605 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2606
2607         Unreviewed, a build fix after r248308
2608
2609         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
2610
2611         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2612         (WTR::TestController::addTestKeyToKeychain):
2613         (WTR::TestController::cleanUpKeychain):
2614         (WTR::TestController::keyExistsInKeychain):
2615
2616 2019-08-06  Keith Rollin  <krollin@apple.com>
2617
2618         Enable XCBuild for `make` and `build-webkit` builds
2619         https://bugs.webkit.org/show_bug.cgi?id=200476
2620         <rdar://problem/50771065>
2621
2622         Reviewed by Jonathan Bedard.
2623
2624         All projects have now been tested under XCBuild and successfully
2625         build. Enable the use of XCBuild when performing builds with `make` or
2626         `build-webkit` and when using a sufficient version of Xcode. We set
2627         this version to Xcode 11 since Xcode 10 -- even though it supports
2628         XCBuild -- does not support a build facility needed to build WebKit
2629         (Bug 197072, Bug 197116, Bug 197340).
2630
2631         Do not enable XCBuild in the Xcode projects themselves since these
2632         projects may need to be used under older versions of Xcode and there's
2633         no way to make those project changes sensitive to the version of Xcode
2634         being used. This means that builds performed in the Xcode IDE will not
2635         use XCBuild.
2636
2637         * Scripts/webkitdirs.pm:
2638         (canUseXCBuild):
2639
2640 2019-08-06  Chris Dumez  <cdumez@apple.com>
2641
2642         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
2643         https://bugs.webkit.org/show_bug.cgi?id=200475
2644
2645         Reviewed by Darin Adler.
2646
2647         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2648         (TestWebKitAPI::stringViewFromLiteral):
2649         (TestWebKitAPI::stringViewFromUTF8):
2650
2651 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2652
2653         Update my status in contributors.json to reviewer.
2654
2655         Regained the status after following the procedure for inactive contributors.
2656         See r247136 for further explanation.
2657
2658         * Scripts/webkitpy/common/config/contributors.json:
2659
2660 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2661
2662         [WebAuthN] Enable LocalAuthenticator for macOS
2663         https://bugs.webkit.org/show_bug.cgi?id=182772
2664         <rdar://problem/43347920>
2665
2666         Reviewed by Brent Fulgham.
2667
2668         Add an entitlement file to WebKitTestRunner such that it can access
2669         the modern macOS keychain.
2670
2671         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
2672         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2673         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2674         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2675         (WTR::TestController::addTestKeyToKeychain):
2676         (WTR::TestController::cleanUpKeychain):
2677         (WTR::TestController::keyExistsInKeychain):
2678
2679 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
2680
2681         [results.webkit.org Timeline] Performance improvements
2682         https://bugs.webkit.org/show_bug.cgi?id=200406
2683
2684         Reviewed by Jonathan Bedard.
2685
2686         1. Unhook the scroll event when a series/axis have been removed from the container
2687         2. Fix the axis's cache data structure out of sync.
2688         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
2689         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
2690
2691
2692         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2693         (Signal.prototype.removeListener):
2694         (prototype.stopAction): Unregsiter an action handler
2695         (Ref):
2696         (Ref.prototype.apply):
2697         (Ref.prototype.destory):
2698         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
2699         (ApplyNewChildren):
2700         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2701         (Timeline.CanvasSeriesComponent):
2702
2703 2019-08-06  Jer Noble  <jer.noble@apple.com>
2704
2705         Add test for behavior introduced in r248174
2706         https://bugs.webkit.org/show_bug.cgi?id=200446
2707
2708         Reviewed by Eric Carlson.
2709
2710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2711         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
2712         (WebKit::configureSecheuristic):
2713         (WebKit::TEST):
2714
2715 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2716
2717         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
2718         https://bugs.webkit.org/show_bug.cgi?id=200464
2719
2720         Reviewed by Ross Kirsling.
2721
2722         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
2723         menu, Alt-F4 to close window, and etc) don't work.
2724
2725         WK1 WebView doesn't have this issue because it processes key events
2726         properly.
2727
2728         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2729         (WebKitBrowserWindow::WebKitBrowserWindow):
2730         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
2731         unhandled key events to the main window.
2732         * MiniBrowser/win/WebKitBrowserWindow.h:
2733
2734 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
2735
2736         iOS 13: Overflow:hidden on body prevents PDF scroll
2737         https://bugs.webkit.org/show_bug.cgi?id=200435
2738         rdar://problem/53942888
2739
2740         Reviewed by Tim Horton.
2741
2742         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
2743         to make sure that the scroll view is scrollable.
2744
2745         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
2746         (TestWebKitAPI::TEST):
2747
2748 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
2749
2750         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
2751         https://bugs.webkit.org/show_bug.cgi?id=200400
2752
2753         Reviewed by Jonathan Bedard.
2754
2755         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2756         (StatusBubble._build_bubble):
2757         (StatusBubble._queue_position):
2758
2759 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
2760
2761         run-webkit-tests asserts when the iPhone XR simulator is running
2762         https://bugs.webkit.org/show_bug.cgi?id=200404
2763         <rdar://problem/53878739>
2764
2765         Reviewed by Dean Jackson.
2766
2767         Support unicode in all logging statements tied to device model.
2768
2769         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2770         (Manager.run):
2771         * Scripts/webkitpy/layout_tests/views/printing.py:
2772         (Printer.print_baseline_search_path):
2773         * Scripts/webkitpy/port/device.py:
2774         (Device.__repr__):
2775         * Scripts/webkitpy/port/device_port.py:
2776         (DevicePort._install):
2777         (DevicePort.setup_test_run):
2778         (DevicePort.clean_up_test_run):
2779         (DevicePort.configuration_for_upload):
2780         * Scripts/webkitpy/port/ios.py:
2781         (IOSPort.default_baseline_search_path):
2782         * Scripts/webkitpy/xcode/device_type.py:
2783         (DeviceType.__str__):
2784         * Scripts/webkitpy/xcode/simulated_device.py:
2785         (SimulatedDeviceManager.populate_available_devices):
2786         (SimulatedDeviceManager._find_available_name):
2787         (SimulatedDeviceManager._get_device_identifier_for_type):
2788         (SimulatedDeviceManager._create_or_find_device_for_request):
2789         (SimulatedDeviceManager._does_fulfill_request):
2790         (SimulatedDeviceManager._wait_until_device_in_state):
2791         (SimulatedDeviceManager._wait_until_device_is_usable):
2792         (SimulatedDeviceManager._boot_device):
2793         (SimulatedDeviceManager.initialize_devices):
2794         (SimulatedDeviceManager.max_supported_simulators):
2795         (SimulatedDeviceManager.swap):
2796         (SimulatedDevice.is_usable):
2797         (SimulatedDevice._shut_down):
2798         (SimulatedDevice._delete):
2799         (SimulatedDevice.launch_app):
2800         (SimulatedDevice.__repr__):
2801
2802 2019-08-04  Chris Dumez  <cdumez@apple.com>
2803
2804         Ping loads should not prevent page caching
2805         https://bugs.webkit.org/show_bug.cgi?id=200418
2806         <rdar://problem/53901632>
2807
2808         Reviewed by Darin Adler.
2809
2810         Add TestOption to enable PageCache at UIProcess-level so that we can test
2811         page caching when navigating cross-origin with PSON enabled.
2812
2813         * WebKitTestRunner/TestController.cpp:
2814         (WTR::TestController::resetPreferencesToConsistentValues):
2815         (WTR::updateTestOptionsFromTestHeader):
2816         * WebKitTestRunner/TestOptions.h:
2817         (WTR::TestOptions::hasSameInitializationOptions const):
2818
2819 2019-08-02  Keith Rollin  <krollin@apple.com>
2820
2821         Consistently use Obj-C boolean literals
2822         https://bugs.webkit.org/show_bug.cgi?id=200405
2823         <rdar://problem/53880043>
2824
2825         Reviewed by Simon Fraser, Joseph Pecoraro.
2826
2827         There are places where we use equivalent but different expressions for
2828         Obj-C boolean objects. For example, we use both [NSNumber
2829         numberWithBool:YES] and @YES. There are places where both are used in
2830         the same function, such as -[WebPreferences initialize]. The boolean
2831         literal is in greater use and is more succinct, so standardize on
2832         that. Also, change @(YES/NO) to @YES/NO.
2833
2834         * DumpRenderTree/mac/ObjCController.m:
2835         (-[ObjCController objectOfClass:]):
2836         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2837         (TEST):
2838         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2839         (overrideAddObserverForName):
2840         * TestWebKitAPI/ios/mainIOS.mm:
2841         (main):
2842         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2843         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2844         * TestWebKitAPI/mac/mainMac.mm:
2845         (main):
2846         * WebKitLauncher/WebKitNightlyEnabler.m:
2847         (enableWebKitNightlyBehaviour):
2848
2849 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2850
2851         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
2852         https://bugs.webkit.org/show_bug.cgi?id=200402
2853         <rdar://problem/53823368>
2854
2855         Reviewed by Tim Horton.
2856
2857         Make it possible to run this test using the iPad simulator.
2858
2859         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2860
2861         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
2862         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
2863         since this would result in differently sized text.
2864
2865         (mainScreenReferenceBoundsOverride):
2866         * TestWebKitAPI/ios/UIKitSPI.h:
2867
2868 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
2869
2870         API tests using permanent credentials should clear credentials left by previous tests
2871         https://bugs.webkit.org/show_bug.cgi?id=199729
2872
2873         Reviewed by Alex Christensen.
2874
2875         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
2876         credentials will not affect tests running after. There is a case where permanent credentials were left on the
2877         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
2878         failure. To prevent this from happening again, add cleanup at the begining of the tests.
2879
2880         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2881         (TEST):
2882         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2883         (TestWebKitAPI::TEST):
2884
2885 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
2886
2887         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
2888         https://bugs.webkit.org/show_bug.cgi?id=200394
2889         <rdar://problem/52914964>
2890
2891         Reviewed by Chris Fleizach.
2892
2893         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
2894
2895         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2896         (WTR::AccessibilityUIElement::isInTableCell const):
2897         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2898         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2899         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2900         (WTR::AccessibilityUIElement::isInTableCell const):
2901
2902 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
2903
2904         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
2905         https://bugs.webkit.org/show_bug.cgi?id=200397
2906
2907         Reviewed by Jonathan Bedard.
2908
2909         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2910
2911 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2912
2913         [macOS 10.15] Image dragged from Safari does not appear in Notes
2914         https://bugs.webkit.org/show_bug.cgi?id=188490
2915         <rdar://problem/39462717>
2916
2917         Reviewed by Andy Estes.
2918
2919         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
2920
2921         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2922
2923 2019-08-02  Alex Christensen  <achristensen@webkit.org>
2924
2925         Fix API test after r248139
2926         https://bugs.webkit.org/show_bug.cgi?id=200102
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
2929         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2930         This was supposed to be removed as part of reverting r245322.
2931
2932 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2933
2934         results.webkit.org: Force update cache when timeline updated
2935         https://bugs.webkit.org/show_bug.cgi?id=200363
2936
2937         Reviewed by Jonathan Bedard.
2938
2939         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2940         (offscreenCachedRenderFactory): Add ability to force the redraw.
2941         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
2942         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
2943
2944 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2945
2946         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
2947         https://bugs.webkit.org/show_bug.cgi?id=200360
2948
2949         Reviewed by Tim Horton.
2950
2951         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2952         (cleanupITPDatabase):
2953         (TEST):
2954
2955 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2956
2957         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
2958         https://bugs.webkit.org/show_bug.cgi?id=200102
2959         <rdar://problem/53275114>
2960
2961         Reviewed by Darin Adler.
2962
2963         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
2964         and because clicking on a TestWKWebView only works on Mac.
2965
2966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2967         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
2968         (-[UploadDelegate initWithDirectory:]):
2969         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2970         (-[UploadDelegate sentDirectory]):
2971         (TEST):
2972         * TestWebKitAPI/cocoa/TestWKWebView.h:
2973         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2974         (-[TestWKWebView sendClickAtPoint:]):
2975
2976 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2977
2978         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
2979         https://bugs.webkit.org/show_bug.cgi?id=200321
2980
2981         Reviewed by Jonathan Bedard.
2982
2983         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2984         Let the axis' height be defined in the option. Timeine component will use this value as
2985         padding-top for headers which allows headers start in the right position, even with multiple
2986         top axises.
2987         (Timeline.CanvasSeriesComponent):
2988         (prototype.Timeline.CanvasContainer):
2989
2990 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2991
2992         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
2993         https://bugs.webkit.org/show_bug.cgi?id=200347
2994
2995         Reviewed by Jonathan Bedard.
2996
2997         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2998         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
2999
3000 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
3001
3002         Improve flakiness of SOAuthorizationRedirect tests
3003         https://bugs.webkit.org/show_bug.cgi?id=200320
3004         <rdar://problem/53767057>
3005
3006         Reviewed by Alex Christensen.
3007
3008         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
3009         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
3010         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
3011         is executed.
3012
3013         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3014         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3015         (resetState):
3016         (TestWebKitAPI::TEST):
3017
3018 2019-08-01  Keith Rollin  <krollin@apple.com>
3019
3020         Update TestWebKitAPI for XCBuild
3021         https://bugs.webkit.org/show_bug.cgi?id=200311
3022         <rdar://problem/53773804>
3023
3024         Reviewed by Alex Christensen.
3025
3026         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
3027         technique. Now update WebKitLegacy to build under XCBuild after those
3028         changes. This work involves adding an "Apply Configuration to
3029         XCFileLists" build target, adding a check-xcfilelists.sh script,
3030         adding a "Check xcfilelists" build phase that calls that script,
3031         adding knowledge of the project to the generate-xcfilelists script,
3032         creating new .xcfilelist files, and adding those to the project.
3033
3034         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
3035         (Application.__init__):
3036         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3037         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
3038         (TestWebKitAPIGenerator):
3039         (TestWebKitAPIGenerator._get_project_file_path):
3040         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
3041         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
3042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3043         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
3044
3045 2019-08-01  Youenn Fablet  <youenn@apple.com>
3046
3047         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
3048         https://bugs.webkit.org/show_bug.cgi?id=200317
3049
3050         Reviewed by Eric Carlson.
3051
3052         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
3053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3054         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3055         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
3056         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3057         (TestWebKitAPI::TEST):
3058
3059 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
3060
3061         New EWS: Cannot see build status page when patch is waiting for tester
3062         https://bugs.webkit.org/show_bug.cgi?id=200333
3063
3064         Reviewed by Jonathan Bedard.
3065
3066         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3067         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
3068
3069 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3070
3071         [SOUP] Switch to use libsoup WebSockets API
3072         https://bugs.webkit.org/show_bug.cgi?id=200162
3073
3074         Reviewed by Michael Catanzaro.
3075
3076         Update libsoup version to 2.67.90.
3077
3078         * gtk/jhbuild.modules:
3079         * wpe/jhbuild.modules:
3080
3081 2019-07-31  Andy Estes  <aestes@apple.com>
3082
3083         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
3084         https://bugs.webkit.org/show_bug.cgi?id=200293
3085         <rdar://problem/52937749>
3086
3087         Reviewed by Alex Christensen.
3088
3089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3090         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
3091         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3092         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3093         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
3094         (TEST):
3095
3096 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
3097
3098         [ews-build] Enable all macOS queues on new EWS
3099         https://bugs.webkit.org/show_bug.cgi?id=199944
3100
3101         Reviewed by Jonathan Bedard.
3102
3103         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
3104         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3105         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
3106         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
3107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
3108         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
3109
3110 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
3111
3112         Unreviewed test gardening, disable failing test for rdar://51752593.
3113
3114         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3115
3116 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
3117
3118         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
3119         https://bugs.webkit.org/show_bug.cgi?id=200318
3120
3121         Reviewed by Aakash Jain.
3122
3123         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3124         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
3125         (Timeline.CanvasXAxisComponent): Use getLabel function.
3126
3127 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
3128
3129         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
3130         https://bugs.webkit.org/show_bug.cgi?id=200306
3131
3132         Reviewed by Michael Catanzaro.
3133
3134         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
3135         jsc-glib-4.0-scan for example).
3136
3137         * Scripts/webkitdirs.pm:
3138         (generateBuildSystemFromCMakeProject):
3139
3140 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
3141
3142         Unreviewed test gardening, disable failing test for rdar://52355829.
3143
3144         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3145         (TEST):
3146
3147 2019-07-31  Keith Rollin  <krollin@apple.com>
3148
3149         Update WebKitLegacy for XCBuild
3150         https://bugs.webkit.org/show_bug.cgi?id=200310
3151         <rdar://problem/53773708>
3152
3153         Reviewed by Alex Christensen.
3154
3155         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
3156         technique. Now update WebKitLegacy to build under XCBuild after those
3157         changes. This work involves adding an "Apply Configuration to
3158         XCFileLists" build target, adding a check-xcfilelists.sh script,
3159         adding a "Check xcfilelists" build phase that calls that script,
3160         adding knowledge of the project to the generate-xcfilelists script,
3161         creating new .xcfilelist files, and adding those to the project.
3162
3163         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
3164         (Application.__init__):
3165         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3166         (JavaScriptCoreGenerator):
3167         (WebCoreGenerator):
3168         (WebKitGenerator):
3169         (WebKitGenerator._get_generate_unified_sources_script):
3170         (WebKitLegacyGenerator):
3171         (WebKitLegacyGenerator._get_project_file_path):
3172         (WebKitLegacyGenerator._get_generate_unified_sources_script):
3173
3174 2019-07-31  Chris Dumez  <cdumez@apple.com>
3175
3176         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
3177         https://bugs.webkit.org/show_bug.cgi?id=200086
3178         <rdar://problem/53501721>
3179
3180         Reviewed by Alex Christensen.
3181
3182         re-enable the API test.
3183
3184         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3185         (TEST):
3186
3187 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3188
3189         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
3190         https://bugs.webkit.org/show_bug.cgi?id=200291
3191         <rdar://problem/53717946>
3192
3193         Reviewed by Megan Gardner.
3194
3195         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
3196         after closing the web view, while the web view's content view isn't the first responder.
3197
3198         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
3199         * TestWebKitAPI/ios/UIKitSPI.h:
3200
3201 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3202
3203         [GTK] Datalist element support for TextFieldInputType
3204         https://bugs.webkit.org/show_bug.cgi?id=98934
3205
3206         Reviewed by Michael Catanzaro.
3207
3208         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
3209
3210         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3211         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
3212         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
3213
3214 2019-07-30  Tim Horton  <timothy_horton@apple.com>
3215
3216         Remove some needless comments that snuck into the tree
3217
3218         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3219         (WTR::UIScriptController::setHardwareKeyboardAttached):
3220         (WTR::UIScriptController::playBackEventStream):
3221
3222 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3223
3224         [WebKit] Add PageLoadState::Observer C API
3225         https://bugs.webkit.org/show_bug.cgi?id=199848
3226
3227         Reviewed by Alex Christensen.
3228
3229         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3230         (WebKitBrowserWindow::WebKitBrowserWindow):
3231         (WebKitBrowserWindow::didChangeTitle):
3232         (WebKitBrowserWindow::didFinishNavigation): Deleted.
3233         * MiniBrowser/win/WebKitBrowserWindow.h:
3234         * TestWebKitAPI/CMakeLists.txt:
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
3237         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
3238         (TestWebKitAPI::didChangeActiveURL):
3239         (TestWebKitAPI::didChangeCanGoBack):
3240         (TestWebKitAPI::didChangeCanGoForward):
3241         (TestWebKitAPI::didChangeCertificateInfo):
3242         (TestWebKitAPI::didChangeEstimatedProgress):
3243         (TestWebKitAPI::didChangeHasOnlySecureContent):
3244         (TestWebKitAPI::didChangeIsLoading):
3245         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
3246         (TestWebKitAPI::didChangeTitle):
3247         (TestWebKitAPI::didChangeWebProcessIsResponsive):
3248         (TestWebKitAPI::didSwapWebProcesses):
3249         (TestWebKitAPI::willChangeActiveURL):
3250         (TestWebKitAPI::willChangeCanGoBack):
3251         (TestWebKitAPI::willChangeCanGoForward):
3252         (TestWebKitAPI::willChangeCertificateInfo):
3253         (TestWebKitAPI::willChangeEstimatedProgress):
3254         (TestWebKitAPI::willChangeHasOnlySecureContent):
3255         (TestWebKitAPI::willChangeIsLoading):
3256         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
3257         (TestWebKitAPI::willChangeTitle):
3258         (TestWebKitAPI::willChangeWebProcessIsResponsive):
3259         (TestWebKitAPI::didFinishNavigation):
3260         (TestWebKitAPI::TEST):
3261
3262 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
3263
3264         DumpRenderTree.app: Add CFBundleShortVersionString
3265         https://bugs.webkit.org/show_bug.cgi?id=200269
3266         <rdar://problem/53412596>
3267
3268         Rubber-stamped by Aakash Jain.
3269
3270         * DumpRenderTree/ios/Info.plist:
3271
3272 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3273
3274         Add layout test coverage for <https://webkit.org/b/200215>
3275         https://bugs.webkit.org/show_bug.cgi?id=200245
3276         <rdar://problem/52976965>
3277
3278         Reviewed by Tim Horton.
3279
3280         Add new testing infrastructure. See below for more details.
3281
3282         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3283         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3284         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3285         (WTR::UIScriptController::setWillCreateNewPageCallback):
3286         (WTR::UIScriptController::willCreateNewPageCallback const):
3287
3288         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
3289         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
3290
3291         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3292         (WTR::UIScriptController::becomeFirstResponder):
3293
3294         Add and implement a Cocoa platform hook to make the web view first responder.
3295
3296         * WebKitTestRunner/TestController.cpp:
3297         (WTR::TestController::createOtherPage):
3298         * WebKitTestRunner/TestInvocation.cpp:
3299         (WTR::TestInvocation::willCreateNewPage):
3300         * WebKitTestRunner/TestInvocation.h:
3301         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3302         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3303         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
3304
3305 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3306
3307         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
3308         https://bugs.webkit.org/show_bug.cgi?id=200217
3309
3310         Reviewed by Alex Christensen.
3311
3312         * MiniBrowser/win/BrowserWindow.h:
3313         * MiniBrowser/win/MainWindow.cpp:
3314         (MainWindow::init):
3315         (MainWindow::resizeSubViews):
3316         (MainWindow::WndProc):
3317         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
3318         * MiniBrowser/win/MiniBrowserLib.rc:
3319         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
3320         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3321         (WebKitBrowserWindow::reload):
3322         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
3323         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3324         (WebKitLegacyBrowserWindow::reload):
3325         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3326
3327 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3328
3329         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
3330         https://bugs.webkit.org/show_bug.cgi?id=200218
3331
3332         Reviewed by Alex Christensen.
3333
3334         Moved the scheme supplementing logic from
3335         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
3336
3337         * MiniBrowser/win/MainWindow.cpp:
3338         (MainWindow::loadURL):
3339         (MainWindow::onURLBarEnter):
3340         * MiniBrowser/win/MainWindow.h:
3341         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3342         (WebKitLegacyBrowserWindow::loadURL):
3343
3344 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
3345
3346         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
3347         https://bugs.webkit.org/show_bug.cgi?id=200254
3348
3349         Unreviewed infrastructure fix.
3350
3351         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
3352
3353 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
3354
3355         [Canvas Timeline] Compact canvas timeline
3356         https://bugs.webkit.org/show_bug.cgi?id=200177
3357
3358         Reviewed by Jonathan Bedard.
3359
3360         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
3361         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3362         (Timeline.CanvasSeriesComponent):
3363
3364 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3365
3366         Multiple context menu actions broken for YouTube videos
3367         https://bugs.webkit.org/show_bug.cgi?id=199999
3368
3369         Reviewed by Eric Carlson.
3370
3371         Add a test case to check copy link address, open in new window and download options are not included in the
3372         context menu for non-downloadable media.
3373
3374         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3375         (writeNextChunk):
3376         (serverCallback):
3377         (testContextMenuLiveStream):
3378         (beforeAll):
3379         (afterAll):
3380
3381 2019-07-28  Tim Horton  <timothy_horton@apple.com>
3382
3383         Reorganize UIScriptController into platform-specific subclasses
3384         https://bugs.webkit.org/show_bug.cgi?id=200027
3385
3386         Reviewed by Simon Fraser.
3387
3388         Instead of a mishmash of #ifdefs and extraneous empty functions,
3389         reorganize UIScriptController so that we have a base class
3390         with functions that assert if called (to make it harder to
3391         accidentally write a test that depends on unimplemented
3392         functionality), and override them in platform specific subclasses
3393         as functionality is added.
3394
3395         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3396         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
3397         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3398         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
3399         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3400         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3401         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3402         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3403         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
3404         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
3405         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3406         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
3407         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
3408         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3409         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
3410         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3411
3412 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3413
3414         [Win][MiniBrowser] Remove PageLoadTestClient
3415         https://bugs.webkit.org/show_bug.cgi?id=200155
3416
3417         Reviewed by Brent Fulgham.
3418
3419         It is not used nowadays.
3420
3421         * MiniBrowser/win/CMakeLists.txt:
3422         * MiniBrowser/win/Common.cpp:
3423         (parseCommandLine):
3424         * MiniBrowser/win/Common.h:
3425         * MiniBrowser/win/MainWindow.cpp:
3426         (MainWindow::init):
3427         * MiniBrowser/win/MainWindow.h:
3428         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3429         (MiniBrowserWebHost::updateAddressBar):
3430         (MiniBrowserWebHost::didFinishLoadForFrame):
3431         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
3432         (MiniBrowserWebHost::didFailLoadWithError):
3433         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
3434         (MiniBrowserWebHost::didFirstLayoutInFrame):
3435         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
3436         * MiniBrowser/win/PageLoadTestClient.h: Removed.
3437         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3438         (ResourceLoadDelegate::identifierForInitialRequest):
3439         (ResourceLoadDelegate::willSendRequest):
3440         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3441         (ResourceLoadDelegate::didFailLoadingWithError):
3442         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3443         (WebKitBrowserWindow::create):
3444         (WebKitBrowserWindow::createNewPage):
3445         * MiniBrowser/win/WebKitBrowserWindow.h:
3446         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3447         (WebKitLegacyBrowserWindow::create):
3448         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
3449         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
3450         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3451         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
3452         * MiniBrowser/win/WinMain.cpp:
3453         (wWinMain):
3454
3455 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
3456
3457         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
3458         https://bugs.webkit.org/show_bug.cgi?id=200150
3459         <rdar://problem/53280170>
3460
3461         Reviewed by Brent Fulgham.
3462
3463         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3464         (TestWebKitAPI::TEST):
3465
3466 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3467
3468         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
3469         https://bugs.webkit.org/show_bug.cgi?id=200090
3470
3471         Unreviewed follow-up fix.
3472
3473         * resultsdbpy/resultsdbpy/view/view_routes.py:
3474         (ViewRoutes.__init__): Keep /search endpoint for existing links
3475
3476 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3477
3478         results.webkit.org: Add switch to filter results by expectation
3479         https://bugs.webkit.org/show_bug.cgi?id=200134
3480
3481         Rubber-stamped by Aakash Jain.
3482
3483         Users of the results database should be able to easily differentiate tests which are expected
3484         to fail verse tests which are unexpectedly failing.
3485
3486         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3487         (Timeline.render): Respect the willFilterExpected variable.
3488         (LegendLabel): Generates html for label in the legend.
3489         (Legend): Add switch for filter results.
3490         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
3491         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3492
3493 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
3494
3495         [ews-build] Use update-webkit script in Style EWS
3496         https://bugs.webkit.org/show_bug.cgi?id=193196
3497
3498         Reviewed by Jonathan Bedard.
3499
3500         * BuildSlaveSupport/ews-build/factories.py:
3501         (StyleFactory): Updated to use CheckOutSource step as well.
3502         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
3503         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3504
3505 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3506
3507         results.webkit.org: Support buildbot 0.8 CI links
3508         https://bugs.webkit.org/show_bug.cgi?id=200146
3509
3510         Reviewed by Aakash Jain.
3511
3512         * resultsdbpy/resultsdbpy/model/ci_context.py:
3513         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
3514         (BuildbotEightURLFactory.__init__):
3515         (BuildbotEightURLFactory.url):
3516         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
3517         (URLFactoryTest.test_old_builder_url):
3518         (URLFactoryTest):
3519         (URLFactoryTest.test_old_worker_url):
3520
3521 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3522
3523         results.webkit.org: Suite results shouldn't be the landing page
3524         https://bugs.webkit.org/show_bug.cgi?id=200090
3525
3526         Reviewed by Aakash Jain.
3527
3528         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
3529         * resultsdbpy/resultsdbpy/view/view_routes.py:
3530         (ViewRoutes.__init__): Make search the landing page instead of suite results.
3531         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
3532         (WebSiteUnittest.test_main):
3533
3534 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3535
3536         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
3537         https://bugs.webkit.org/show_bug.cgi?id=200127
3538
3539         Unreviewed follow-up fix.
3540
3541         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3542         (Dot.toString): Use self instead of this in render callback.
3543
3544 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
3545
3546         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
3547         https://bugs.webkit.org/show_bug.cgi?id=200108
3548         <rdar://problem/53521238>
3549
3550         Reviewed by Chris Dumez.
3551
3552         Added an API test.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3555         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3556         (TEST):
3557
3558 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
3559
3560         results.webkit.org: Color should be the worst result, count should include all results
3561         https://bugs.webkit.org/show_bug.cgi?id=200127
3562
3563         Rubber-stamped by Aakash Jain.
3564
3565         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3566         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
3567
3568 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
3569
3570         [Timeline]: Make timeline header width automatic, instead of fixed width
3571         https://bugs.webkit.org/show_bug.cgi?id=200059
3572
3573         Reviewed by Jonathan Bedard.
3574
3575         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3576         (.dot.crash):
3577         (.timeline>.header): Deleted.
3578         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3579         (.timeline>.content):
3580         (.timeline>.header):
3581
3582 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
3583
3584         [ESNext] Implement nullish coalescing
3585         https://bugs.webkit.org/show_bug.cgi?id=200072
3586
3587         Reviewed by Darin Adler.
3588
3589         * Scripts/run-jsc-stress-tests:
3590
3591 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3592
3593         Add Takashi Komori and Tomoki Imai as contributors
3594
3595         Unreviewed.
3596
3597         * Scripts/webkitpy/common/config/contributors.json:
3598
3599 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
3600
3601         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
3602         https://bugs.webkit.org/show_bug.cgi?id=200103
3603
3604         Reviewed by Mark Lam.
3605
3606         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
3607         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
3608
3609         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
3610         to the future implementation changes while it catches the severe issues we had.
3611
3612         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3613         (assertEmptyPointerSet):
3614         (assertHasOnlyObjects):
3615         (assertClean):
3616         (TEST):