b6233633cc8661eb75ba149f81db2b87e9a7a751
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2
3         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
4         https://bugs.webkit.org/show_bug.cgi?id=114342
5
6         Reviewed by Gyuyoung Kim.
7
8         Commit 148033 only added an implementation for the Mac port, which made
9         other ports fail most tests since loading the injected bundle failed
10         with a missing symbol.
11
12         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
13         (WTR::AccessibilityUIElement::pathDescription):
14
15 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
16
17         [EFL] Add spell checking option to MiniBrowser
18         https://bugs.webkit.org/show_bug.cgi?id=114282
19
20         Reviewed by Ryosuke Niwa.
21
22         Spell checking is enabled by adding a flag (t/text-checking)
23         with launching MiniBrowser.
24
25         * MiniBrowser/efl/main.c:
26         (window_create):
27         (elm_main):
28
29 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
30
31         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
32         https://bugs.webkit.org/show_bug.cgi?id=113281
33
34         Reviewed by Darin Adler.
35
36         * Scripts/run-gtk-tests:
37         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
38
39 2013-04-09  Glenn Adams  <glenn@skynav.com>
40
41         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
42
43         Unreviewed.
44
45         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
46         (RunTest.test_build_check):
47
48 2013-04-09  Glenn Adams  <glenn@skynav.com>
49
50         [webkitpy] Remove chromium ports.
51         https://bugs.webkit.org/show_bug.cgi?id=114326
52
53         Reviewed by Dirk Pranke.
54
55         As a side effect, also:
56
57         - remove chromium builders from webkitpy.layout_tests.port.builders
58         - remove chromium builders from rebaseline
59         - rewrite chromium dependent tests in rebaseline_unittest
60         - remove chromium platform from garden-o-matic
61         - select apple platform as default platform in garden-o-matic
62         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
63
64         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
65         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
66         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
67         (BaselineOptimizerTest.test_move_baselines):
68         (BaselineOptimizerTest.test_efl):
69         (BaselineOptimizerTest.test_no_add_mac_future):
70         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
71         (BaselineOptimizerTest.test_common_directory_includes_root):
72         (BaselineOptimizerTest.test_complex_shadowing):
73         (BaselineOptimizerTest.test_virtual_ports_filtered):
74         * Scripts/webkitpy/layout_tests/port/builders.py:
75         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
76         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
77         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
78         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
79         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
80         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
81         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
82         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
83         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
84         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
85         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
86         * Scripts/webkitpy/layout_tests/port/factory.py:
87         (platform_options):
88         (PortFactory):
89         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
90         (FactoryTest.test_qt):
91         (FactoryTest.test_get_from_builder_name):
92         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
93         (RunTest.test_build_check):
94         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
95         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
96         * Scripts/webkitpy/tool/commands/rebaseline.py:
97         (Rebaseline._builders_to_pull_from):
98         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
99         (_BaseTestCase):
100         (_BaseTestCase.setUp):
101         (TestRebaselineTest.setUp):
102         (TestRebaselineTest.test_baseline_directory):
103         (test_rebaseline_updates_expectations_file):
104         (test_rebaseline_does_not_include_overrides):
105         (test_rebaseline_test):
106         (test_rebaseline_test_and_print_scm_changes):
107         (test_rebaseline_and_copy_test):
108         (test_rebaseline_and_copy_test_no_existing_result):
109         (test_rebaseline_and_copy_test_with_lion_result):
110         (test_rebaseline_and_copy_no_overwrite_test):
111         (TestRebaselineExpectations.test_rebaseline_expectations):
112
113 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
114
115         newcommitbot (WKR) requires a subversion checkout
116         https://bugs.webkit.org/show_bug.cgi?id=114309
117
118         Reviewed by Benjamin Poulain.
119
120         Directly talk to the subversion server instead of relying on a local checkout.
121         This allows us to run WKR off of a git clone.
122
123         * Scripts/webkitpy/tool/commands/newcommitbot.py:
124         (NewCommitBot.next_work_item):
125         (NewCommitBot.process_work_item):
126
127 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
128
129         webkitbot refers to sheriffbot in help
130         https://bugs.webkit.org/show_bug.cgi?id=114307
131
132         Reviewed by Benjamin Poulain.
133
134         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
135
136         * Scripts/webkitpy/tool/bot/irc_command.py:
137         (Help):
138         (Help.execute):
139         (RollChromiumDEPS.execute):
140         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
141         (IRCBotTest.test_help):
142         * Scripts/webkitpy/tool/bot/sheriff.py:
143         (Sheriff.name):
144
145 2013-04-06  Roger Fong  <roger_fong@apple.com>
146
147         Kill old processes between runs on WinEWS bots.
148         Temporarily disable tests to let bots catch up again.
149
150         * EWSTools/start-queue-win.sh:
151         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
152         (WinEWS):
153
154 2013-04-09  Glenn Adams  <glenn@skynav.com>
155
156         [webkitpy] Remove chromium deprecated port support.
157         https://bugs.webkit.org/show_bug.cgi?id=114228
158
159         Reviewed by Ryosuke Niwa.
160
161         * Scripts/webkitpy/common/config/ports.py:
162         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
163         (ChromiumPort): Removed.
164         (ChromiumAndroidPort): Removed.
165         (ChromiumXVFBPort): Removed.
166         * Scripts/webkitpy/common/config/ports_unittest.py:
167         (DeprecatedPortTest.test_chromium_port): Removed.
168         (DeprecatedPortTest.test_chromium_android_port): Removed.
169         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
170         * Scripts/webkitpy/tool/steps/update_unittest.py:
171         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
172         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
173
174 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
175
176         AX: The bounding paths should be made available through accessibility
177         https://bugs.webkit.org/show_bug.cgi?id=113817
178
179         Reviewed by David Kilzer.
180
181         Add a pathDescription property for testing so that it's possible
182         to verify that a path is being returned correctly.
183
184         * DumpRenderTree/AccessibilityUIElement.cpp:
185         (getPathDescriptionCallback):
186         (AccessibilityUIElement::pathDescription):
187         (AccessibilityUIElement::getJSClass):
188         * DumpRenderTree/AccessibilityUIElement.h:
189         (AccessibilityUIElement):
190         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
191         (_CGPathEnumerationIteration):
192         (AccessibilityUIElement::pathDescription):
193         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
194         (AccessibilityUIElement::pathDescription):
195         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
196         (WTR::AccessibilityUIElement::pathDescription):
197         (WTR):
198         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
199         (AccessibilityUIElement):
200         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
201         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
202         (WTR::AccessibilityUIElement::pathDescription):
203         (WTR):
204
205 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
206
207         [EFL] Declare TEST_THEME_DIR in a single place.
208         https://bugs.webkit.org/show_bug.cgi?id=114285
209
210         Reviewed by Anders Carlsson.
211
212         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
213
214         * DumpRenderTree/efl/CMakeLists.txt:
215         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
216         (DumpRenderTreeChrome::createView):
217         (DumpRenderTreeChrome::createInspectorView):
218         (DumpRenderTreeChrome::initialize):
219         (DumpRenderTreeChrome::onDownloadRequest):
220         * EWebLauncher/CMakeLists.txt:
221         * EWebLauncher/main.c:
222         (findThemePath):
223         * EWebLauncher/url_bar.c:
224         (url_bar_add):
225         * MiniBrowser/efl/CMakeLists.txt:
226         * MiniBrowser/efl/main.c:
227         (window_create):
228         * TestWebKitAPI/PlatformEfl.cmake:
229         * TestWebKitAPI/efl/PlatformWebView.cpp:
230         (TestWebKitAPI::PlatformWebView::PlatformWebView):
231         * WebKitTestRunner/PlatformEfl.cmake:
232         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
233         (WTR::PlatformWebView::PlatformWebView):
234
235 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
236
237         [GTK][AC] upversion of clutter and its dependecy
238         https://bugs.webkit.org/show_bug.cgi?id=114016
239
240         Reviewed by Gustavo Noronha Silva.
241
242         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
243
244         * gtk/jhbuild-optional.modules:
245
246 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
247
248         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
249         https://bugs.webkit.org/show_bug.cgi?id=89875
250
251         Reviewed by Maciej Stachowiak.
252
253         Add unit tests to verify if the handling of the open, openat, creat syscall
254         is being done right. We check if the Read/Write/ReadAndWrite permissions
255         are respected, if the canonical path is being resolved and if
256         the permissions are falling back to the topmost parent directory with a
257         policy set when the directory being opened has no policy.
258
259         We also test if any attempt of blocking SIGSYS is silently ignored.
260         SIGSYS cannot be blocked because in it's handler is where we hook
261         syscalls to the broker process.
262
263         Also added libseccomp to EFL's jhbuild to make the life of developers
264         willing to help easier.
265
266         * Scripts/webkitperl/FeatureList.pm:
267         * TestWebKitAPI/PlatformEfl.cmake:
268         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
269         (TestWebKitAPI):
270         (SeccompEnvironment):
271         (TestWebKitAPI::SeccompEnvironment::SetUp):
272         (TestWebKitAPI::SeccompEnvironment::TearDown):
273         (TestWebKitAPI::dummyHandler):
274         (TestWebKitAPI::TEST):
275         (TestWebKitAPI::stressTest):
276         * efl/jhbuild.modules:
277         * qmake/mkspecs/features/features.pri:
278
279 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
280
281         REGRESSION: Autocorrection doesn't work in DumpRenderTree
282         https://bugs.webkit.org/show_bug.cgi?id=113846
283
284         Reviewed by Alexey Proskuryakov.
285
286         The problem was that we were replacing NSSpellCheck's dictionary with our own
287         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
288
289         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
290         and "would" respectively in DumpRenderTree.
291
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         (resetDefaultsToConsistentValues):
294
295 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
296
297         Remove the gyp files for Tools
298         https://bugs.webkit.org/show_bug.cgi?id=114248
299
300         Reviewed by Ryosuke Niwa.
301
302         * DumpRenderTree/DumpRenderTree.gyp: Removed.
303         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
304         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
305         * DumpRenderTree/DumpRenderTree.gypi: Removed.
306         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
307         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
308         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
309         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
310
311 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
312
313         WKR (new-commit-bot) is too slow
314         https://bugs.webkit.org/show_bug.cgi?id=110087
315
316         Reviewed by Geoffrey Garen.
317
318         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
319         Just run "svn log -r <revision>" instead to cut down the delay.
320
321         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
322
323         * Scripts/webkitpy/tool/commands/newcommitbot.py:
324         (NewCommitBot):
325         (NewCommitBot.next_work_item):
326         (NewCommitBot._is_empty_log):
327         (NewCommitBot._update_checkout):
328
329 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
330
331         Build fix. Can't remove appendCustomBuildFlags.
332
333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
334         (appendCustomBuildFlags):
335
336 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
337
338         Remove Chromium builders from build.webkit.org
339         https://bugs.webkit.org/show_bug.cgi?id=113990
340
341         Reviewed by Benjamin Poulain.
342
343         Removed.
344
345         * BuildSlaveSupport/build.webkit.org-config/config.json:
346         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
347         (InstallGtkDependencies):
348         (RunUnitTests.start):
349         (RunWebKit2Tests.start):
350         (Factory.__init__):
351         (unitTestsSupported):
352         (TestFactory.__init__):
353         (BuildAndTestFactory.__init__):
354         (BuildAndPerfTestFactory.__init__):
355         (BuildAndPerfTestWebKit2Factory.__init__):
356         (DownloadAndPerfTestFactory.__init__):
357         (loadBuilderConfig):
358         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
359
360 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
361
362         Remove HTML Notification
363         https://bugs.webkit.org/show_bug.cgi?id=114231
364
365         Reviewed by Ryosuke Niwa.
366
367         * qmake/mkspecs/features/features.pri:
368
369 2013-04-08  Glenn Adams  <glenn@skynav.com>
370
371         Remove chromium EWS support, and fix broken test.
372         https://bugs.webkit.org/show_bug.cgi?id=114221
373
374         Reviewed by Ryosuke Niwa.
375
376         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
377         (AbstractChromiumEWS): Removed.
378         (ChromiumLinuxEWS): Removed.
379         (ChromiumLinuxDebugEWS): Removed.
380         (ChromiumWindowsEWS): Removed.
381         (ChromiumAndroidEWS): Removed.
382         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
383         (EarlyWarningSystemTest): Fix misspelled class name.
384         (test_ewses): Fix entry point name to ensure test is run.
385
386 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
387
388         [WIN] Remove WebKit2 source code
389         https://bugs.webkit.org/show_bug.cgi?id=114096
390
391         Reviewed by Anders Carlsson.
392
393         Remove the windows specific parts of the MiniBrowser.
394
395         * MiniBrowser/MiniBrowser.vcproj: Removed.
396         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
397         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
398         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
399         * MiniBrowser/win/BrowserView.cpp: Removed.
400         * MiniBrowser/win/BrowserView.h: Removed.
401         * MiniBrowser/win/BrowserWindow.cpp: Removed.
402         * MiniBrowser/win/BrowserWindow.h: Removed.
403         * MiniBrowser/win/MiniBrowser.cpp: Removed.
404         * MiniBrowser/win/MiniBrowser.h: Removed.
405         * MiniBrowser/win/MiniBrowser.rc: Removed.
406         * MiniBrowser/win/main.cpp: Removed.
407         * MiniBrowser/win/resource.h: Removed.
408         * MiniBrowser/win/stdafx.cpp: Removed.
409         * MiniBrowser/win/stdafx.h: Removed.
410
411 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
412
413         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
414
415         * Scripts/webkitpy/common/config/irc.py:
416
417 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
418
419         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
420         https://bugs.webkit.org/show_bug.cgi?id=113139
421
422         Reviewed by Anders Carlsson.
423
424         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
425         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
426         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
427         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
428         (ToStringAndValueOfObject):
429         (ToStringAndValueOfObject::ToStringAndValueOfObject):
430         (ScriptableObject):
431         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
432         (ToStringAndValueOfObject::ScriptableObject::invoke):
433         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
434         (ToStringAndValueOfObject::NPP_GetValue):
435         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
436         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
437         * GNUmakefile.am:
438
439 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
440
441         [GTK] Bump gnome-themes-standard to 3.6.0
442         https://bugs.webkit.org/show_bug.cgi?id=114155
443
444         Reviewed by Martin Robinson.
445
446         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
447         dependency of gnome-themes-standard accordingly.
448
449 2013-04-08  David Levin  <levin@chromium.org>
450
451         Remove my watchlist entries.
452         https://bugs.webkit.org/show_bug.cgi?id=114180
453
454         Reviewed by Adam Barth.
455
456         * Scripts/webkitpy/common/config/committers.py:
457         * Scripts/webkitpy/common/config/watchlist:
458
459 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
460
461         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
462         https://bugs.webkit.org/show_bug.cgi?id=114161
463
464         Reviewed by Gyuyoung Kim.
465
466         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
467         as it is crashing due to Bug 111074.
468
469         * TestWebKitAPI/PlatformEfl.cmake:
470
471 2013-04-07  David Kilzer  <ddkilzer@apple.com>
472
473         Remove the rest of SVG_DOM_OBJC_BINDINGS
474         <http://webkit.org/b/114112>
475
476         Reviewed by Geoffrey Garen.
477
478         * Scripts/webkitperl/FeatureList.pm:
479         - Remove --svg-dom-objc-bindings switch.
480         * qmake/mkspecs/features/features.pri:
481         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
482
483 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
484
485         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
486         https://bugs.webkit.org/show_bug.cgi?id=114089
487
488         Reviewed by Chris Fleizach.
489
490         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
491         * DumpRenderTree/AccessibilityController.cpp:
492         * DumpRenderTree/AccessibilityUIElement.cpp:
493         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
494         (DumpRenderTreeChrome::DumpRenderTreeChrome):
495         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
496         (DumpRenderTreeChrome):
497
498 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
499
500         Build fix after r147857, remove remaining USE(JSC) guards.
501
502         Unreviewed.
503
504         * DumpRenderTree/config.h:
505         * TestWebKitAPI/config.h:
506         * WebKitTestRunner/config.h:
507
508 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
509
510         Rename sheriffbot to webkitbot
511         https://bugs.webkit.org/show_bug.cgi?id=114109
512
513         Reviewed by Benjamin Poulain.
514
515         Renamed since sheriffbot will be used in Blink.
516
517         * Scripts/webkitpy/tool/commands/sheriffbot.py:
518         (SheriffBot):
519         (SheriffBot.begin_work_queue):
520
521 2013-04-06  Oliver Hunt  <oliver@apple.com>
522
523         Unify the many and varied stack trace mechanisms, and make the result sane.
524         https://bugs.webkit.org/show_bug.cgi?id=114072
525
526         Reviewed by Filip Pizlo.
527
528         The commandline jsc executable no longer requires arguments, so
529         I've made run-jsc work without them.
530
531         * Scripts/run-jsc:
532
533 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
534
535         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
536         https://bugs.webkit.org/show_bug.cgi?id=114086
537
538         Reviewed by Tim Horton.
539
540         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
541
542 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
543
544         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
545         https://bugs.webkit.org/show_bug.cgi?id=114083
546
547         Reviewed by Ryosuke Niwa.
548
549         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
550         in TestWebKitAPI and WebKitTestRunner.
551
552         * TestWebKitAPI/config.h:
553         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
554         (TestWebKitAPI::InjectedBundleController::platformInitialize):
555         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
556         (WTR::InjectedBundle::platformInitialize):
557
558 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
559
560         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
561         https://bugs.webkit.org/show_bug.cgi?id=114094
562
563         Reviewed by Anders Carlsson.
564
565         * Scripts/run-jsc:
566
567 2013-04-05  Ojan Vafai  <ojan@chromium.org>
568
569         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
570         https://bugs.webkit.org/show_bug.cgi?id=114080
571
572         Reviewed by Ryosuke Niwa.
573
574         This way, the WebKit and Blink dashboard code can change as appropriate without
575         needing to consider the other project's needs. This still doesn't update the
576         buildbots to upload to the new location, or the dashboard code to pull the
577         results.json files from the new location, but it at least allows for changing the
578         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
579
580         * TestResultServer/app.yaml:
581
582 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
583
584         Re-enable testing on the commit queue
585         https://bugs.webkit.org/show_bug.cgi?id=114078
586
587         Reviewed by Darin Adler.
588
589         Re-enabled the feature and the associated tests.
590
591         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
592         (CommitQueueTask.run):
593         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
594         (CommitQueueTaskTest._run_through_task):
595         * Scripts/webkitpy/tool/commands/queues_unittest.py:
596         (CommitQueueTest._mock_test_result):
597
598 2013-04-05  Oliver Hunt  <oliver@apple.com>
599
600         Unify the many and varied stack trace mechanisms, and make the result sane.
601         https://bugs.webkit.org/show_bug.cgi?id=114072
602
603         Reviewed by Filip Pizlo.
604
605         The commandline jsc executable no longer requires arguments, so
606         I've made run-jsc work without them.
607
608         * Scripts/run-jsc:
609
610 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
611
612         AX: Make SVG Group containers accessible elements
613         https://bugs.webkit.org/show_bug.cgi?id=113939
614
615         Reviewed by Simon Fraser.
616
617         Implement axController.elementAtPoint for iOS.
618         Implement a correct version of clickPoint for iOS.
619
620         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
621         (AccessibilityController::elementAtPoint):
622         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
623         (AccessibilityUIElement::clickPointX):
624         (AccessibilityUIElement::clickPointY):
625
626 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
627
628         Unreviewed, rolling out r147773 and r147774.
629         http://trac.webkit.org/changeset/147773
630         http://trac.webkit.org/changeset/147774
631         https://bugs.webkit.org/show_bug.cgi?id=114056
632
633         Causing some exceptions on AppEngine I don't understand
634         (Requested by rniwa on #webkit).
635
636         * QueueStatusServer/config/queues.py:
637         * QueueStatusServer/model/queues.py:
638         (Queue.short_name):
639         (Queue.display_name):
640         * QueueStatusServer/model/queues_unittest.py:
641         (QueueTest.test_short_name):
642         (QueueTest.test_display_name):
643         (QueueTest.test_name_with_underscores):
644
645 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
646
647         Fixed run-bindings-tests by removing V8
648         https://bugs.webkit.org/show_bug.cgi?id=114053
649
650         Reviewed by Benjamin Poulain.
651
652         * Scripts/run-bindings-tests:
653         (main):
654
655 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Build fix.
658
659         * QueueStatusServer/model/queues.py:
660         (Queue.short_name):
661         (Queue.display_name):
662
663 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
664
665         Remove Chromium EWS bots from the queue status server
666         https://bugs.webkit.org/show_bug.cgi?id=113988
667
668         Reviewed by Benjamin Poulain.
669
670         Removed Chromium EWS bots.
671
672         * QueueStatusServer/config/queues.py:
673         * QueueStatusServer/model/queues.py:
674         (Queue.short_name):
675         (Queue.display_name):
676         * QueueStatusServer/model/queues_unittest.py:
677         (QueueTest.test_short_name):
678         (QueueTest.test_display_name):
679         (QueueTest.test_name_with_underscores):
680
681 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
682
683         [EFL] Enable indexed database
684         https://bugs.webkit.org/show_bug.cgi?id=107248
685
686         Reviewed by Alexis Menard.
687
688         * Scripts/webkitperl/FeatureList.pm:
689
690 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
691
692         Remove vestiges of Chromium bits from watchlists.
693         https://bugs.webkit.org/show_bug.cgi?id=114047
694
695         Reviewed by Ryosuke Niwa.
696
697         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
698
699 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
700
701         Add James Craig to the contributors list.
702
703         * Scripts/webkitpy/common/config/committers.py:
704
705 2013-04-04  Kent Tamura  <tkent@chromium.org>
706
707         Remove ChromiumPublicApi pattern, and cc/message rules for it.
708
709         * Scripts/webkitpy/common/config/watchlist:
710
711 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
712
713         Temporarily disable the Python unittests broken by the commit queue not running layout tests
714         https://bugs.webkit.org/show_bug.cgi?id=113997
715
716         Reviewed by Ryosuke Niwa.
717
718         Disable the tests until Ryosuke gets the time and hardware to have
719         a testing commit-queue.
720
721         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
722         (CommitQueueTaskTest):
723         * Scripts/webkitpy/tool/commands/queues_unittest.py:
724         (CommitQueueTest):
725
726 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
727
728         Remove Chromium builders from build.webkit.org
729         https://bugs.webkit.org/show_bug.cgi?id=113990
730
731         Reviewed by Benjamin Poulain.
732
733         Land the part to disable triggering of Chromium builders first so that we may start
734         deleting more Chromium code that breaks the update step.
735
736         * BuildSlaveSupport/build.webkit.org-config/config.json:
737
738 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
739
740         Remove Chromium's DumpRenderTree
741         https://bugs.webkit.org/show_bug.cgi?id=113989
742
743         Reviewed by Kent Tamura.
744
745         On second thought, let's not go to Camelot. It is a silly place.
746
747         * DumpRenderTree/mac/DumpRenderTree.mm:
748         (resetDefaultsToConsistentValues):
749
750 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
751
752         Nixed the defunct chromium folder from DumpRenderTree
753         https://bugs.webkit.org/show_bug.cgi?id=113993
754
755         Reviewed by Ryosuke Niwa.
756
757         * DumpRenderTree/chromium: Removed.
758         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
759         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
760         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
761         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
762         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
763         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
764         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
765         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
766         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
767         * DumpRenderTree/chromium/MockPlatform.h: Removed.
768         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
769         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
770         * DumpRenderTree/chromium/Task.cpp: Removed.
771         * DumpRenderTree/chromium/Task.h: Removed.
772         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
773         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
774         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
775         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
776         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
777         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
778         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
779         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
780         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
781         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
782         * DumpRenderTree/chromium/TestRunner: Removed.
783         * DumpRenderTree/chromium/TestRunner/public: Removed.
784         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
785         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
786         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
787         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
788         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
789         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
790         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
791         * DumpRenderTree/chromium/TestRunner/src: Removed.
792         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
793         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
794         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
795         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
796         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
797         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
798         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
799         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
800         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
801         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
802         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
803         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
804         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
805         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
806         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
807         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
808         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
809         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
810         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
811         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
812         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
813         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
814         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
815         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
816         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
817         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
818         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
819         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
820         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
821         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
822         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
823         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
824         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
825         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
826         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
827         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
828         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
829         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
830         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
831         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
832         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
833         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
834         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
835         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
836         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
837         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
838         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
839         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
840         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
841         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
842         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
843         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
844         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
845         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
846         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
847         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
848         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
849         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
850         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
851         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
852         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
853         * DumpRenderTree/chromium/TestShell.cpp: Removed.
854         * DumpRenderTree/chromium/TestShell.h: Removed.
855         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
856         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
857         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
858         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
859         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
860         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
861         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
862         * DumpRenderTree/chromium/WebViewHost.h: Removed.
863         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
864         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
865         * DumpRenderTree/chromium/config.h: Removed.
866         * DumpRenderTree/chromium/fonts.conf: Removed.
867
868 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
869
870         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
871
872         Rubber stamped by Benjamin Poulain.
873
874         * RebaselineQueueServer: Removed.
875         * RebaselineQueueServer/app.yaml: Removed.
876         * RebaselineQueueServer/handlers: Removed.
877         * RebaselineQueueServer/handlers/__init__.py: Removed.
878         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
879         * RebaselineQueueServer/handlers/pages.py: Removed.
880         * RebaselineQueueServer/index.yaml: Removed.
881         * RebaselineQueueServer/main.py: Removed.
882         * RebaselineQueueServer/model: Removed.
883         * RebaselineQueueServer/model/__init__.py: Removed.
884         * RebaselineQueueServer/model/queueentry.py: Removed.
885         * RebaselineQueueServer/static: Removed.
886         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
887         * RebaselineQueueServer/static/styles.css: Removed.
888         * RebaselineQueueServer/templates: Removed.
889         * RebaselineQueueServer/templates/builder-picker.html: Removed.
890         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
891         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
892         * RebaselineQueueServer/templates/home.html: Removed.
893
894 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
895
896         Fix setup-commit-queue and temporarily disable testing on commit-queue
897         https://bugs.webkit.org/show_bug.cgi?id=113979
898
899         Reviewed by Benjamin Poulain.
900
901         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
902         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
903
904         * EWSTools/setup-commit-queue.sh:
905         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
906         (CommitQueueTask.run):
907
908 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
909
910         temporarily make flakiness dashboard work again webkit.org bots
911         https://bugs.webkit.org/show_bug.cgi?id=113972
912
913         Reviewed by Ojan Vafai.
914
915         This patch disables the chromium.org layout test bots TestExpectations
916         parsing temporarily until we can work out the right way to split into
917         two instances for webkit.org and chromium.org and figure out which
918         code to delete where :).
919
920         * TestResultServer/static-dashboards/flakiness_dashboard.js:
921
922 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
923
924         Fix webkitpy tests after r147678.
925
926         * Scripts/webkitpy/tool/commands/queues_unittest.py:
927         (CommitQueueTest.test_commit_queue):
928         (test_manual_reject_during_processing):
929
930 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
931
932         The commit queue should use Mac MountainLion port
933         https://bugs.webkit.org/show_bug.cgi?id=113971
934
935         Reviewed by Lucas Forschler.
936
937         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
938         * Scripts/webkitpy/tool/commands/queues.py:
939         (CommitQueue):
940
941 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
942
943         turn off running tests on chromium linux EWS bots
944         https://bugs.webkit.org/show_bug.cgi?id=113959
945
946         Reviewed by Geoffrey Garen.
947
948         Now that the Chromium port is no longer being maintained
949         there's little point in running the tests. Soon we should
950         just shut this bot off altogether.
951
952         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
953         (ChromiumLinuxEWS):
954
955 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
956
957         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
958
959         * Scripts/webkitpy/common/config/watchlist:
960
961 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
962
963         Indentation fix to get webkit-patch working again after r147625
964
965         Unreviewed.
966
967         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
968         (MacEWS):
969         (MacWK2EWS):
970
971 2013-04-04  Lucas Forschler  <lforschler@apple.com>
972
973         Turn tests back on for Mac WK1/WK2 EWS.
974         
975         Unreviewed.
976         
977         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
978         (MacEWS):
979         (MacWK2EWS):
980
981 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
982
983         [GTK][WK2] MiniBrowser custom URI scheme support
984         https://bugs.webkit.org/show_bug.cgi?id=112419
985
986         Reviewed by Carlos Garcia Campos.
987
988         Add support for about URIs in MiniBrowser. An example about page is show
989         with URI "about:minibrowser", the rest of the cases it will show a
990         proper message explaining that the about page didn't exist.
991
992         Internally it uses "minibrowser-about" prefix instead of "about", but
993         from the user point of view it works with "about" prefix.
994
995         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
996         (getInternalURI): Method to convert URIs from "about" prefix to
997         "minibrowser-about".
998         (getExternalURI): Opposite method.
999         (webViewURIChanged): Use "about" prefix to show the URI to users.
1000         (webViewEnterFullScreen): Ditto.
1001         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1002         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1003         (aboutURISchemeRequestCallback): Callback to manage about calls.
1004         (main): Register the URI scheme to manage about URIs.
1005
1006 2013-04-03  Roger Fong  <roger_fong@apple.com>
1007
1008         Re-enable WinEWS tests.
1009
1010         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1011         (WinEWS):
1012
1013 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1014
1015         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1016         https://bugs.webkit.org/show_bug.cgi?id=113883
1017
1018         Reviewed by Martin Robinson.
1019
1020         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1021         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1022         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1023
1024 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1025
1026         [GTK] Include Pango in jhbuild-optional.modules
1027         https://bugs.webkit.org/show_bug.cgi?id=113878
1028
1029         Reviewed by Martin Robinson.
1030
1031         Since r147547 Pango 1.32.0 is required. Including the module in the
1032         JHBuild optional moduleset.
1033
1034         * gtk/jhbuild-optional.modules: Add Pango module.
1035
1036 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1037
1038         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1039         https://bugs.webkit.org/show_bug.cgi?id=113864
1040
1041         Moving setDefersLoading from TestRunnerQt to TestRunner
1042         requires access to the non-Qt TestRunner.
1043         As long as we instantiate both TestRunner and TestRunnerQt,
1044         we need a separate getter for the non-Qt TestRunner instance.
1045
1046         Reviewed by Simon Hausmann.
1047
1048         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1049         (WebPage::resetSettings):
1050         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1051         (DumpRenderTree::jscTestRunner):
1052         * DumpRenderTree/qt/TestRunnerQt.cpp:
1053         (TestRunner::setDefersLoading):
1054             Moving setDefersLoading from TestRunnerQt
1055             to TestRunner.
1056         * DumpRenderTree/qt/TestRunnerQt.h:
1057         (TestRunnerQt):
1058
1059 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1060
1061         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1062         https://bugs.webkit.org/show_bug.cgi?id=104779
1063
1064         Reviewed by Carlos Garcia Campos.
1065
1066         * Scripts/run-gtk-tests:
1067         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1068         passing in current trunk.
1069
1070 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1071
1072         Fix HAVE(QTTESTSUPPORT) logic
1073
1074         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1075         resulting in HAVE(QTTESTSUPPORT) never being true.
1076         Move that logic down in sanitizeFeatures.
1077
1078         Rubber-stamped by Tor Arne Vestbø.
1079
1080         * qmake/mkspecs/features/features.prf:
1081
1082 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1083
1084         [GTK] Bump required versions of some dependencies
1085         https://bugs.webkit.org/show_bug.cgi?id=113282
1086
1087         Reviewed by Martin Robinson.
1088
1089         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1090
1091 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1092
1093         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1094         https://bugs.webkit.org/show_bug.cgi?id=113809
1095
1096         Reviewed by Philippe Normand.
1097
1098         Newer Linux kernels have removed some deprecated macros from v4l2
1099         headers, causing gst-plugins-good's build to break. We don't need it
1100         right now, so just disable it.
1101
1102         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1103
1104 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1105
1106         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1107         https://bugs.webkit.org/show_bug.cgi?id=113535
1108
1109         Reviewed by Simon Hausmann.
1110
1111         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1112
1113         * qmake/mkspecs/features/features.prf:
1114
1115 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1116
1117         [Qt] Move logic of simple forwarding functions to TestRunner.
1118         https://bugs.webkit.org/show_bug.cgi?id=113863
1119
1120         Reviewed by Simon Hausmann.
1121
1122         * DumpRenderTree/qt/TestRunnerQt.cpp:
1123         (TestRunner::setTextDirection):
1124         (TestRunner::goBack):
1125         (TestRunner::evaluateScriptInIsolatedWorld):
1126         (TestRunner::addUserStyleSheet):
1127         * DumpRenderTree/qt/TestRunnerQt.h:
1128         (TestRunnerQt):
1129
1130 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1131
1132         [Qt] Disable media support using QuickTime if deployment target != SDK
1133
1134         We link to a single libWebKitSystemInterface static lib, so unless the
1135         deployment target matches the SDK let's not pretend like we'll be able
1136         to run on anything lower than the SDK version.
1137
1138         Reviewed by Simon Hausmann.
1139
1140         * qmake/mkspecs/features/features.prf:
1141
1142 2013-04-02  James Craig  <james@cookiecrook.com>
1143
1144         AXRoleDescripton for DL is "list"; should be "description list"
1145         https://bugs.webkit.org/show_bug.cgi?id=111665
1146
1147         Reviewed by Chris Fleizach.
1148
1149         Defining the role and description strings.
1150
1151         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1152
1153 2013-04-02  Roger Fong  <roger_fong@apple.com>
1154
1155         Unreviewed. Disable running tests on Win EWS queue.
1156
1157         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1158         (WinEWS):
1159
1160 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1161
1162         Disable running tests on the MAC WK2 EWS queue.
1163         
1164         Unreviewed.
1165         
1166         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1167         (MacWK2EWS):
1168
1169 2013-04-02  Julie Parent  <jparent@chromium.org>
1170
1171         Dashboard refactor: Move dashboard specific history related features to History.
1172         https://bugs.webkit.org/show_bug.cgi?id=113717
1173
1174         Reviewed by Ojan Vafai.
1175         
1176         Each dashboard now creates its own History object, with a custom
1177         configuration. This changes from just overriding global functions
1178         to passing in callbacks for generatePage, handleValidHashParameter,
1179         and handleQueryParameterChange. Same with passing in defaultStateValues
1180         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1181         variables.
1182         
1183         All functions related to these features are now (mostly) private
1184         function on History. 
1185         
1186         Loader no longer needs a loadingComplete callback, since it can just
1187         initialize the history object itself.
1188
1189         * TestResultServer/static-dashboards/aggregate_results.js:
1190         (handleValidHashParameter):
1191         * TestResultServer/static-dashboards/dashboard_base.js:
1192         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1193         (generatePage):
1194         (.switch.return):
1195         (handleQueryParameterChange):
1196         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1197         (resetGlobals):
1198         * TestResultServer/static-dashboards/history.js:
1199         (.):
1200         * TestResultServer/static-dashboards/loader.js:
1201         (.):
1202         * TestResultServer/static-dashboards/loader_unittests.js:
1203         * TestResultServer/static-dashboards/timeline_explorer.js:
1204         (generatePage):
1205         (initCurrentBuilderTestResults):
1206         * TestResultServer/static-dashboards/treemap.js:
1207         (generatePage):
1208         (.switch.return):
1209         (handleQueryParameterChange):
1210
1211 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1212
1213         Unreviewed, rolling out r147401.
1214         http://trac.webkit.org/changeset/147401
1215         https://bugs.webkit.org/show_bug.cgi?id=113767
1216
1217         The patch makes it extremely hard to set up the dependencies
1218         properly on the GTK builders (Requested by zdobersek on
1219         #webkit).
1220
1221         * gtk/jhbuild.modules:
1222
1223 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1224
1225         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1226         https://bugs.webkit.org/show_bug.cgi?id=113382
1227
1228         Reviewed by Gyuyoung Kim.
1229
1230         Do not show the empty tooltip box if the text is null.
1231
1232         * MiniBrowser/efl/main.c:
1233         (popup_menu_populate):
1234
1235 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         [GTK] Bump required versions of some dependencies
1238         https://bugs.webkit.org/show_bug.cgi?id=113282
1239
1240         Reviewed by Martin Robinson.
1241
1242         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1243
1244 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1245
1246         Unreviewed, rolling out r147319.
1247         http://trac.webkit.org/changeset/147319
1248         https://bugs.webkit.org/show_bug.cgi?id=113707
1249
1250         The unit test is still failing on the buildbot (Requested by
1251         zdobersek on #webkit).
1252
1253         * Scripts/run-gtk-tests:
1254         (TestRunner):
1255
1256 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1257
1258         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1259         https://bugs.webkit.org/show_bug.cgi?id=104779
1260
1261         Reviewed by Carlos Garcia Campos.
1262
1263         * Scripts/run-gtk-tests:
1264         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1265         passing in current trunk.
1266
1267 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1268
1269         Unreviewed, rolling out r147289.
1270         http://trac.webkit.org/changeset/147289
1271         https://bugs.webkit.org/show_bug.cgi?id=113678
1272
1273         broke Win7 (dbg) build (Requested by shinyak|gardener on
1274         #webkit).
1275
1276         * DumpRenderTree/DumpRenderTree.gypi:
1277         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1278         (WebTestRunner):
1279         (WebUserMediaClientMock):
1280         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1281         (WebTestRunner::WebUserMediaClientMock::taskList):
1282         * Scripts/webkitpy/style/checkers/cpp.py:
1283         (check_function_definition):
1284
1285 2013-03-31  Adam Barth  <abarth@webkit.org>
1286
1287         configure-svn-config.sh fails
1288         https://codereview.chromium.org/13392007/
1289
1290         Reviewed by Eric Seidel.
1291
1292         This script was trying to use "svn checkout" to dowload a file from
1293         svn.webkit.org, but "svn checkout" only works with directories.
1294         Instead, we should use "svn export".
1295
1296         * EWSTools/configure-svn-config.sh:
1297
1298 2013-03-31  Wei Jia  <wjia@chromium.org>
1299
1300         Allow WebUserMediaClientMock to be used by client
1301         https://bugs.webkit.org/show_bug.cgi?id=113633
1302
1303         Reviewed by Adam Barth.
1304
1305         Export WebUserMediaClientMock.
1306         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1307
1308         * DumpRenderTree/DumpRenderTree.gypi:
1309         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1310         (WebUserMediaClientMock):
1311         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1312         * Scripts/webkitpy/style/checkers/cpp.py:
1313         (check_function_definition):
1314
1315 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1316
1317         Expose FeatureObserver data to WebKit clients
1318         https://bugs.webkit.org/show_bug.cgi?id=113613
1319
1320         Reviewed by Sam Weinig.
1321
1322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1323         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1324
1325 2013-03-29  Greg Hughes  <ghughes@apple.com>
1326
1327         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1328         https://bugs.webkit.org/show_bug.cgi?id=112276
1329
1330         Reviewed by Chris Fleizach.
1331
1332         Added support to test accessibility search predicates with multiple keys.  
1333
1334         * DumpRenderTree/AccessibilityUIElement.cpp:
1335         (uiElementForSearchPredicateCallback):
1336         * DumpRenderTree/AccessibilityUIElement.h:
1337         (AccessibilityUIElement):
1338         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1339         (AccessibilityUIElement::uiElementForSearchPredicate):
1340         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1341         (AccessibilityUIElement::uiElementForSearchPredicate):
1342         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1343         (AccessibilityUIElement::uiElementForSearchPredicate):
1344         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1345         (AccessibilityUIElement::uiElementForSearchPredicate):
1346         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1347         (AccessibilityUIElement::uiElementForSearchPredicate):
1348         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1349         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1350         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1351         (AccessibilityUIElement):
1352         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1353         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1354         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1355         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1356         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1357
1358 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1359
1360         Fix a typo in r147147 to fix Mac EWS.
1361
1362         * Scripts/webkitpy/tool/commands/queues.py:
1363         (PatchProcessingQueue._new_port_name_from_old):
1364
1365 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1366
1367         [EFL] Build break with latest EFL libraries after r146265
1368         https://bugs.webkit.org/show_bug.cgi?id=113558
1369
1370         Unreviewed build fix.
1371
1372         * TestWebKitAPI/PlatformWebView.h:
1373         * WebKitTestRunner/PlatformWebView.h:
1374
1375 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1376
1377         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1378
1379         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1380         in libgcrypt build.
1381
1382 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1383
1384         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1385
1386         Unreviewed.
1387
1388         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1389         (MacEWS):
1390
1391 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1392
1393         Use the right OS name on Mac EWS instead of mac-future.
1394
1395         Rubber-stamped by Dirk Pranke.
1396
1397         * Scripts/webkitpy/tool/commands/queues.py:
1398         (PatchProcessingQueue._new_port_name_from_old):
1399         (PatchProcessingQueue.begin_work_queue):
1400         (PatchProcessingQueue._upload_results_archive_for_patch):
1401
1402 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1403
1404         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1405         https://bugs.webkit.org/show_bug.cgi?id=112546
1406
1407         Reviewed by Martin Robinson.
1408
1409         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1410         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1411
1412 2013-03-28  Ming Xie  <mxie@blackberry.com>
1413
1414         [BlackBerry] Committer Email Updates
1415         https://bugs.webkit.org/show_bug.cgi?id=113435
1416
1417         Reviewed by Rob Buis.
1418
1419         Add the @blackberry.com email address for all our BlackBerry
1420         WebKit committers. This is the first step for our email address
1421         migration.
1422
1423         * Scripts/webkitpy/common/config/committers.py:
1424
1425 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1426
1427         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1428         https://bugs.webkit.org/show_bug.cgi?id=113508
1429
1430         Reviewed by Martin Robinson.
1431
1432         Prevent the GStreamer plugin scanner to load system-wide
1433         plugins. Only the ones built in JHBuild should be loaded and used
1434         at runtime.
1435
1436         * efl/jhbuildrc:
1437         * gtk/jhbuildrc:
1438
1439 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1440
1441         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1442         https://bugs.webkit.org/show_bug.cgi?id=113386
1443
1444         Reviewed by Carlos Garcia Campos.
1445
1446         * Scripts/webkitdirs.pm:
1447         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1448         version to 3.0. Reflect this change so the builtDylibPathForName
1449         function doesn't fail to report the library as found.
1450
1451 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1452
1453         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1454         https://bugs.webkit.org/show_bug.cgi?id=113484
1455
1456         Unreviewed build fix.
1457
1458         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1459
1460         * TestWebKitAPI/CMakeLists.txt:
1461         * WebKitTestRunner/CMakeLists.txt:
1462
1463 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1464
1465         Revision for the internal jhbuild is too old
1466         https://bugs.webkit.org/show_bug.cgi?id=113324
1467
1468         Reviewed by Martin Robinson.
1469
1470         Update the minimum required version to a point where jhbuild won't
1471         fail installing packages when trying to remove a symlink to a directory.
1472
1473         * jhbuild/jhbuild-wrapper: Updated revision.
1474
1475 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1476
1477         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1478         https://bugs.webkit.org/show_bug.cgi?id=113203
1479
1480         Reviewed by Philippe Normand.
1481
1482         We build our libsoup without GNOME support. gst-plugins-good does separate
1483         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1484         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1485         build failures as the headers of those diverge. We do not use souphttpsrc, so
1486         disable it when building gst-plugins-good.
1487
1488         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1489
1490 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1491
1492         Build fix after r146852. Please another reference to the Lion leaks builder.
1493
1494         * BuildSlaveSupport/build.webkit.org-config/config.json:
1495
1496 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1497
1498         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1499         https://bugs.webkit.org/show_bug.cgi?id=113421
1500
1501         Reviewed by Dirk Pranke.
1502
1503         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1504         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1505         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1506         in the GTK-specific TestExpectations files.
1507
1508         To avoid this only enable the warnings only when not using WKTR.
1509
1510         * Scripts/webkitpy/layout_tests/port/gtk.py:
1511         (GtkPort.warn_if_bug_missing_in_test_expectations):
1512
1513 2013-03-27  Antti Koivisto  <antti@apple.com>
1514
1515         Fix Zalan's email.
1516
1517         * Scripts/webkitpy/common/config/committers.py:
1518
1519 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1520
1521         master.cfg cleanup
1522         https://bugs.webkit.org/show_bug.cgi?id=113195
1523
1524         Reviewed by Ryosuke Niwa.
1525
1526         * BuildSlaveSupport/build.webkit.org-config/config.json:
1527         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1528
1529 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1530
1531         master.cfg fine-tuning for Qt Mountain Lion Release bot
1532         https://bugs.webkit.org/show_bug.cgi?id=113191
1533
1534         Reviewed by Ryosuke Niwa.
1535
1536         * BuildSlaveSupport/build.webkit.org-config/config.json:
1537           - Rename the slave due to its location change.
1538           - Update the platform of the slave.
1539         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1540         (RunQtAPITests): Enable running WK2 API tests on Qt.
1541         (RunQtAPITests.start):
1542         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1543         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1544
1545 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1546
1547         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1548         https://bugs.webkit.org/show_bug.cgi?id=113403
1549
1550         Reviewed by Kenneth Rohde Christiansen.
1551
1552         As of Evas 1.7.5, when Wayland is detected on the system, support for
1553         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1554         The code, however, seems to depend on a few other flags which must be
1555         explicitly enabled.
1556
1557         If those additional GL-related options are passed, we end up
1558         having issues on the WebKit side, so disable Wayland support for
1559         now.
1560
1561         * efl/jhbuild.modules:
1562
1563 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1564
1565         Unreviewed, rolling out r146864.
1566         http://trac.webkit.org/changeset/146864
1567         https://bugs.webkit.org/show_bug.cgi?id=113391
1568
1569         causes crashes on Wk2 EFL release bot (Requested by drott on
1570         #webkit).
1571
1572         * Scripts/webkitperl/FeatureList.pm:
1573
1574 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1575
1576         [jhbuild] Correctly specify an alternate number of make jobs.
1577         https://bugs.webkit.org/show_bug.cgi?id=113396
1578
1579         Reviewed by Philippe Normand.
1580
1581         So far, we were using the `MAKEFLAGS' environment variable to pass the
1582         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1583         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1584
1585         We now behave more closely to the rest of the WebKit tools by first
1586         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1587         not set, just letting jhbuild itself figure out how many jobs to use.
1588
1589         * efl/jhbuildrc:
1590         * gtk/jhbuildrc:
1591
1592 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1593
1594         [Qt] Remove Qt specific WorkQueueItem definitions.
1595         https://bugs.webkit.org/show_bug.cgi?id=112891
1596
1597         This patch is preparation work for removing
1598         WorkQueue related code from TestRunnerQt and
1599         replacing it with generic TestRunner code.
1600
1601         Reviewed by Benjamin Poulain.
1602
1603         * DumpRenderTree/qt/TestRunnerQt.cpp:
1604         (TestRunnerQt::queueBackNavigation):
1605         (TestRunnerQt::queueForwardNavigation):
1606         (TestRunnerQt::queueLoadHTMLString):
1607         (TestRunnerQt::queueReload):
1608         (TestRunnerQt::queueLoadingScript):
1609         (TestRunnerQt::queueNonLoadingScript):
1610         (TestRunner::queueLoad):
1611         * DumpRenderTree/qt/TestRunnerQt.h:
1612         (TestRunnerQt):
1613         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1614         (LoadItem::invoke):
1615         (LoadHTMLStringItem::invoke):
1616         (LoadAlternateHTMLStringItem::invoke):
1617         (ReloadItem::invoke):
1618         (ScriptItem::invoke):
1619         (BackForwardItem::invoke):
1620         * DumpRenderTree/qt/WorkQueueItemQt.h:
1621         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1622         (LoadAlternateHTMLStringItem):
1623
1624 2013-03-26  Julie Parent  <jparent@chromium.org>
1625
1626         Flakiness dashboard: simplify logic around which tests to show.
1627         https://bugs.webkit.org/show_bug.cgi?id=113250
1628
1629         Reviewed by Ojan Vafai.
1630         
1631         The different filters for showing results are only used for layout
1632         tests, otherwise, we show everything.
1633         
1634         Change the defaults to false (what layout tests used), and only
1635         look at the values when viewing layout tests.
1636
1637         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1638         (htmlForTestsWithExpectationsButNoFailures):
1639         (shouldHideTest):
1640
1641 2013-03-26  Isaac Levy  <ilevy@google.com>
1642
1643         Update bots on test-results.appspot
1644         https://bugs.webkit.org/show_bug.cgi?id=113333
1645
1646         Reviewed by Ojan Vafai.
1647
1648         * TestResultServer/static-dashboards/builders.jsonp:
1649
1650 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1651
1652         Unreviewed GTK gardening.
1653
1654         * Scripts/run-gtk-tests:
1655         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1656
1657 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1658
1659         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1660         https://bugs.webkit.org/show_bug.cgi?id=113287
1661
1662         Reviewed by Jocelyn Turcotte.
1663
1664         * Scripts/run-qtwebkit-tests:
1665         (Options.__init__):
1666
1667 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1668
1669         [EFL] Enable IndexedDB by default
1670         https://bugs.webkit.org/show_bug.cgi?id=107248
1671
1672         Reviewed by Laszlo Gombos.
1673
1674         * Scripts/webkitperl/FeatureList.pm:
1675         Enable IndexedDB by default on EFL.
1676
1677 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1678
1679         Sheriffbot should explain rollout failures in a human readable form.
1680         https://bugs.webkit.org/show_bug.cgi?id=107092
1681
1682         Reviewed by Ryosuke Niwa.
1683
1684         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1685
1686         * Scripts/webkitpy/tool/bot/irc_command.py:
1687         (Rollout._check_diff_failure):
1688         (Rollout.execute):
1689         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1690         (IRCCommandTest.test_rollout):
1691
1692 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1693
1694         Unreviewed GTK gardening.
1695
1696         * Scripts/run-gtk-tests:
1697         (TestRunner): Skipping a failing unit test after r146518.
1698
1699 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1700
1701         Remove Lion leaks builder
1702         https://bugs.webkit.org/show_bug.cgi?id=113252
1703
1704         Reviewed by Andreas Kling.
1705
1706         Removed.
1707
1708         * BuildSlaveSupport/build.webkit.org-config/config.json:
1709
1710 2013-03-25  Kent Tamura  <tkent@chromium.org>
1711
1712         Rename ENABLE_INPUT_TYPE_DATETIME
1713         https://bugs.webkit.org/show_bug.cgi?id=113254
1714
1715         Reviewed by Kentaro Hara.
1716
1717         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1718         Actually I'd like to remove the code, but we shouldn't remove it yet
1719         because we shipped products with it on some platforms.
1720
1721         * Scripts/webkitperl/FeatureList.pm:
1722         * qmake/mkspecs/features/features.pri:
1723
1724 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1725
1726         Remove one more line that was intended to be removed in r146657.
1727
1728         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1729         (summarize_results):
1730
1731 2013-03-25  Roger Fong  <roger_fong@apple.com>
1732
1733         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1734         Re-enable WinEWS tests.
1735
1736         * Scripts/webkitpy/common/config/ports.py:
1737         (WinPort.run_bindings_tests_command):
1738         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1739         (WinEWS):
1740
1741 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1742
1743         Unreviewed, rolling out r146793.
1744         http://trac.webkit.org/changeset/146793
1745         https://bugs.webkit.org/show_bug.cgi?id=113248
1746
1747         Fix did not work (Requested by rfong on #webkit).
1748
1749         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1750         (WinEWS):
1751
1752 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1753
1754         REGRESSION(r146657): Test failures reported incorrectly
1755         https://bugs.webkit.org/show_bug.cgi?id=113223
1756
1757         Reviewed by Dirk Pranke.
1758
1759         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1760
1761         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1762         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1763
1764         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1765         (Manager.run):
1766
1767         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1768         (RunDetails.__init__):
1769         (summarize_results): Remove the line I intended to remove in r146657.
1770
1771         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1772         (logging_run): Return details instead of the exit code.
1773         (run_and_capture): Ditto.
1774
1775         (RunTest.test_full_results_html):
1776         (RunTest.test_hung_thread):
1777         (RunTest.test_no_tests_found):
1778         (RunTest.test_no_tests_found_2):
1779         (RunTest.test_repeat_each_iterations_num_tests):
1780         (RunTest.test_run_singly_actually_runs_tests):
1781         (RunTest.test_test_list):
1782         (RunTest.test_missing_and_unexpected_results):
1783         (RunTest.test_pixel_test_directories):
1784         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1785         (RunTest.test_crash_with_stderr):
1786         (RunTest.test_no_image_failure_with_image_diff):
1787         (RunTest.test_crash_log):
1788         (RunTest.test_exit_after_n_failures_upload):
1789         (RunTest.test_results_directory_absolute):
1790         (RunTest.test_results_directory_relative):
1791         (RunTest.test_retrying_and_flaky_tests):
1792         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1793         (RunTest.test_retrying_uses_retries_directory):
1794         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1795         (RunTest.test_output_diffs):
1796         (EndToEndTest.test_reftest_with_two_notrefs):
1797         (RebaselineTest.test_reset_results):
1798         (RebaselineTest.test_missing_results):
1799         (RebaselineTest.test_new_baseline):
1800
1801         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1802         (BuildBotPrinter.print_results):
1803         (BuildBotPrinter.print_unexpected_results):
1804         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1805         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1806
1807 2013-03-25  Julie Parent  <jparent@chromium.org>
1808
1809         Dashboard refactor: Move cross dashboard history related code into history.js.
1810         https://bugs.webkit.org/show_bug.cgi?id=113104
1811
1812         Reviewed by Ojan Vafai.
1813
1814         All functions relating to cross dashboard behavior move from being
1815         globals to methods on the history.History object. Names stay the same,
1816         except many are made private, ones that should have been constants now
1817         are, and the long standing TODO to change "currentState" to 
1818         dashboardSpecificState is done.
1819         
1820         We now create a global history object in dashboard_base, as an 
1821         intermediate measure.  Once the dashboard specific code is
1822         added to history, each DB will need to create its own, and this
1823         global will be eliminated.
1824         
1825         * TestResultServer/static-dashboards/aggregate_results.js:
1826         (handleValidHashParameter):
1827         (htmlForBuilder):
1828         (rawValuesHTML):
1829         * TestResultServer/static-dashboards/dashboard_base.js:
1830         (parseDashboardSpecificParameters):
1831         (defaultValue):
1832         (currentBuilderGroupCategory):
1833         (currentBuilderGroupName):
1834         (handleLocationChange):
1835         (expectationsMap):
1836         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1837         (generatePage):
1838         (.switch.return):
1839         (platformAndBuildType):
1840         (individualTests):
1841         (substringList):
1842         (processMissingAndExtraExpectations):
1843         (pathToFailureLog):
1844         (showPopupForBuild):
1845         (htmlForTestsWithExpectationsButNoFailures):
1846         (shouldHideTest):
1847         (isCrossBuilderView):
1848         (tableHeaders):
1849         (htmlForSingleTestRow):
1850         (htmlForTableColumnHeader):
1851         (generatePageForExpectationsUpdate):
1852         (handleUpdate):
1853         (nextUpdate):
1854         (setUpdateIndex):
1855         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1856         (.appendExpectationsItem):
1857         (loadExpectations):
1858         (.dummyNode.onload):
1859         (loadExpectationsLayoutTests):
1860         (appendExpectations):
1861         (htmlForNavBar):
1862         (checkBoxToToggleState):
1863         (linkHTMLToToggleState):
1864         (generatePageForBuilder):
1865         (isInvalidKeyForCrossBuilderView):
1866         (handleQueryParameterChange):
1867         (showLegend):
1868         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1869         (resetGlobals):
1870         (test):
1871         * TestResultServer/static-dashboards/history.js:
1872         (.):
1873         * TestResultServer/static-dashboards/history_unittests.js:
1874         * TestResultServer/static-dashboards/loader.js:
1875         (.):
1876         * TestResultServer/static-dashboards/loader_unittests.js:
1877         * TestResultServer/static-dashboards/timeline_explorer.js:
1878         (generatePage):
1879         (initCurrentBuilderTestResults):
1880         (selectBuild):
1881         (showResultsDelta):
1882         * TestResultServer/static-dashboards/treemap.js:
1883         (generatePage):
1884         (.switch.return):
1885         (handleFocus):
1886         * TestResultServer/static-dashboards/ui.js:
1887
1888 2013-03-25  Roger Fong  <roger_fong@apple.com>
1889
1890         Unreviewed. Enable WinEWS tests again.
1891
1892         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1893         (WinEWS):
1894
1895 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1896
1897         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1898         https://bugs.webkit.org/show_bug.cgi?id=112166
1899
1900         HarfBuzz 0.9.14 merged my patch for icu detection without
1901         pkg-config files, as needed by for example Ubuntu 12.04.
1902         This obsoletes our local workaround. Removed it for GTK and EFL.
1903
1904         Reviewed by Martin Robinson.
1905
1906         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1907         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1908         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1909         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1910
1911 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1912
1913         Unreviewed.  Move self from contributor to committer list.
1914
1915         * Scripts/webkitpy/common/config/committers.py:
1916
1917 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1918
1919         EWS should use a human readable port name when uploading layout test archives
1920         https://bugs.webkit.org/show_bug.cgi?id=113099
1921
1922         Reviewed by Dirk Pranke.
1923
1924         Use new port's object's name() method to report human readable port names.
1925         This will also help us resolving the bug to apply layout test results posted by EWS.
1926
1927         * Scripts/webkitpy/tool/bot/botinfo.py:
1928         (BotInfo.__init__): Take port's name.
1929         (BotInfo.summary_text):
1930
1931         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1932         (BotInfoTest.test_summary_text):
1933
1934         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1935         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1936
1937         * Scripts/webkitpy/tool/commands/queues.py:
1938         (PatchProcessingQueue.__init__): Initialize self._port.
1939         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1940         and use that for the attachment filename and the comment posted.
1941
1942         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1943         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1944         "mac-snowleopard" as expected for TestPort.
1945
1946 2013-03-22  Roger Fong  <roger_fong@apple.com>
1947
1948         Unreviewed. Turn off EWS test on Win again.
1949         The battle continues.
1950
1951         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1952         (WinEWS):
1953
1954 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1955
1956         NRWT: Enable pixel tests when retrying tests
1957         https://bugs.webkit.org/show_bug.cgi?id=112898
1958
1959         Reviewed by Dirk Pranke.
1960
1961         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1962         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1963         if we've forced pixel tests in the retry.
1964         (Manager._run_tests):
1965         (Manager._clean_up_run): Fixed the capitalizations.
1966         (Manager._force_pixel_tests_if_needed): Added.
1967
1968         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1969         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1970         'image_diff_percent' if it doesn't already exist.
1971
1972         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1973         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1974         treat this as a regular regression instead of a flakiness.
1975
1976         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1977         run had image diffs.
1978
1979         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1980         (summarized_results):
1981
1982         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1983         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1984         Also removed some dead code.
1985
1986         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1987         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1988         is set and pixel_tests_enabled is set to false.
1989         (EndToEndTest.test_reftest_with_two_notrefs):
1990
1991 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1992
1993         Make it possible to run layout tests on Retina MBP
1994         https://bugs.webkit.org/show_bug.cgi?id=93673
1995
1996         Reviewed by Ryosuke Niwa.
1997
1998         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1999         windows on 2x machines still run at 1x.
2000
2001         * DumpRenderTree/mac/DumpRenderTree.mm:
2002         (createWebViewAndOffscreenWindow):
2003         Reset the window resolution to 1x on creation.
2004         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2005         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2006         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2007         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2008         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2009         (WTR::PlatformWebView::PlatformWebView):
2010         Add NSWindow details, reset the window resolution to 1x on creation.
2011
2012 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2013
2014         Leak bots shouldn't build
2015         https://bugs.webkit.org/show_bug.cgi?id=112774
2016
2017         Reviewed by Simon Fraser.
2018
2019         Since leak bots use regular debug builds, there is no need to build on these bots.
2020         Simply downloading builds will dramatically improve the cycle time of these bots.
2021
2022         * BuildSlaveSupport/build.webkit.org-config/config.json:
2023         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2024         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2025         TestFactory instead of BuildAndTestFactory.
2026
2027 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2028
2029         [Qt] Fix the TestWebKitAPI build
2030         https://bugs.webkit.org/show_bug.cgi?id=113044
2031
2032         Reviewed by Tor Arne Vestbø.
2033
2034         The generate-forwarding-headers script would only be run
2035         after the targets in InjectedBundle.pri since the second
2036         addStrictSubdirOrderBetween call in
2037         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2038         the derived_sources -> injected_bundle order in SUBDIRS.
2039
2040         Fix it by only moving the dependent target at the end of
2041         SUBDIRS, don't touch its dependency.
2042
2043         * qmake/mkspecs/features/functions.prf:
2044
2045 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2046
2047         [EFL][WK2] View is not focused when fullscreen mode toggled
2048         https://bugs.webkit.org/show_bug.cgi?id=113009
2049
2050         Reviewed by Laszlo Gombos.
2051
2052         Set focus on view when fullscreen mode enabled/disabled
2053         by FullScreen API.
2054
2055         * MiniBrowser/efl/main.c:
2056         (on_fullscreen_accept):
2057         (on_fullscreen_deny):
2058
2059 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2060
2061         nrwt is no longer saving retry results in the retries/ subdirectory
2062         https://bugs.webkit.org/show_bug.cgi?id=112995
2063
2064         Reviewed by Ojan Vafai.
2065
2066         I think this has been broken a long time, unfortunately. This
2067         patch should fix that.
2068
2069         In order to do so, I had to pass the directory to use from
2070         the Worker object through the SingleTestWriter to the
2071         TestResultWriter. While I was plumbing that through, I rationalized
2072         the order of the parameter arguments a bit ...
2073
2074         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2075         (Worker._run_single_test):
2076         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2077         (run_single_test):
2078         (SingleTestRunner.__init__):
2079         (SingleTestRunner._run_compare_test):
2080         (SingleTestRunner._run_rebaseline):
2081         (SingleTestRunner._run_reftest):
2082         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2083         (write_test_result):
2084         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2085         (TestResultWriterTest.test_reftest_diff_image):
2086         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2087         (RunTest.test_retrying_uses_retries_directory):
2088
2089 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2090
2091         JSC profiler should have an at-a-glance report of the success of DFG optimization
2092         https://bugs.webkit.org/show_bug.cgi?id=112988
2093
2094         Reviewed by Geoffrey Garen.
2095
2096         * Scripts/display-profiler-output:
2097
2098 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2099
2100         [chromium] Linux ASAN WebKit canary is running out of memory
2101         https://bugs.webkit.org/show_bug.cgi?id=112978
2102
2103         Reviewed by Tony Chang.
2104
2105         Running the AddressSanitizer on a crash takes a lot of
2106         memory, so we should serialize access to it to avoid running
2107         out of memory on a machine.
2108
2109         * Scripts/webkitpy/layout_tests/port/chromium.py:
2110         (ChromiumPort._get_crash_log):
2111         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2112         (HttpLock.__init__):
2113         (HttpLock.wait_for_httpd_lock):
2114
2115 2013-03-21  Min Qin  <qinmin@chromium.org>
2116
2117         Cleanup android media layout test code
2118         https://bugs.webkit.org/show_bug.cgi?id=112944
2119
2120         Reviewed by Adam Barth.
2121
2122         Chromium change: https://codereview.chromium.org/12892010/
2123         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2124         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2125         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2126         Instead, we should switch to use content shell for layout tests.
2127
2128         * DumpRenderTree/chromium/TestShell.cpp:
2129         (TestShell::resetTestController):
2130
2131 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2132
2133         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2134         https://bugs.webkit.org/show_bug.cgi?id=112953
2135
2136         Reviewed by Tony Chang.
2137
2138         When I created the DumpRenderTree_resources target in r144863 I
2139         forgot to declare the needed dependencies on the other resource
2140         targets. Due to a quirk of ordering, this appears to have been fine
2141         w/ ninja but not w/ Xcode (which is still being used on the chromium
2142         mac valgrind bots). Declaring the dependencies fixes the build
2143         failures.
2144
2145         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2146
2147 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2148
2149         [WinCairo] Correct assert in Empty BitmapImage Test.
2150         https://bugs.webkit.org/show_bug.cgi?id=112934
2151
2152         Reviewed by Tim Horton.
2153
2154         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2155         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2156         to avoid ref counting assertion when leaving test scope.
2157
2158 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2159
2160         [GTK] generate-feature-defines-files is incompatible with Python3
2161         https://bugs.webkit.org/show_bug.cgi?id=112956
2162
2163         Reviewed by Martin Robinson.
2164
2165         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2166         method on the dictionary objects when iterating through said dictionaries.
2167
2168         * gtk/generate-feature-defines-files:
2169         (write_feature_defines_header):
2170         (write_flattened_feature_defines_file):
2171
2172 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2173
2174         kill-old-processes spits out error messages on Mac
2175         https://bugs.webkit.org/show_bug.cgi?id=112878
2176
2177         Reviewed by Jessie Berlin.
2178
2179         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2180         included in the list of options grep --help shows.
2181
2182         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2183
2184         * BuildSlaveSupport/kill-old-processes:
2185         (main):
2186
2187 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2188
2189         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2190         https://bugs.webkit.org/show_bug.cgi?id=112597
2191
2192         Reviewed by Xan Lopez.
2193
2194         These were introduced for the Chromium port in r105295. We need
2195         dummy implementations in order to compile the BlackBerry port.
2196
2197         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2198         (AccessibilityUIElement::scrollToMakeVisible):
2199         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2200         (AccessibilityUIElement::scrollToGlobalPoint):
2201
2202 2013-03-21  Roger Fong  <roger_fong@apple.com>
2203
2204         Re-enable WinEWS tests following r146376.
2205
2206         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2207         (WinEWS):
2208
2209 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2210
2211         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2212
2213         * Scripts/webkitpy/common/config/committers.py:
2214
2215 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2216
2217         [GTK] Missing atk in install-dependencies script
2218         https://bugs.webkit.org/show_bug.cgi?id=112272
2219
2220         Reviewed by Gustavo Noronha Silva.
2221
2222         * gtk/install-dependencies: Add missing atk dependency.
2223
2224 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2225
2226         [GTK] Missing backslash in install-dependencies script
2227         https://bugs.webkit.org/show_bug.cgi?id=112907
2228
2229         Reviewed by Philippe Normand.
2230
2231         * gtk/install-dependencies: Add missing backslash to dependencies
2232         list.
2233
2234 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2235
2236         EWS bots have stopped uploading results to bugzilla
2237         https://bugs.webkit.org/show_bug.cgi?id=101091
2238
2239         Reviewed by Adam Barth.
2240
2241         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2242         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2243         this relative file path resoled to a file inside a non-existent directory for "zip".
2244
2245         Fixed the bug by resolving both test results directory and zip archive paths in
2246         LayoutTestResultsReader.archive.
2247
2248         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2249         in the future.
2250
2251         * Scripts/webkitpy/common/system/filesystem_mock.py:
2252         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2253
2254         * Scripts/webkitpy/common/system/workspace.py:
2255         (Workspace.create_zip): Log the source path when "zip" failed.
2256
2257         * Scripts/webkitpy/common/system/workspace_mock.py:
2258         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2259
2260         * Scripts/webkitpy/common/system/workspace_unittest.py:
2261         (WorkspaceTest.test_create_zip_exception): Test that.
2262
2263         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2264         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2265         This is the actual bug fix.
2266
2267         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2268         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2269
2270 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2271
2272         [chromium] move WebThemeEngine implementations to TestRunner library
2273         https://bugs.webkit.org/show_bug.cgi?id=112751
2274
2275         Reviewed by Adam Barth.
2276
2277         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2278         * DumpRenderTree/DumpRenderTree.gypi:
2279         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2280         (WebKit):
2281         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2282         (WebTestRunner::TestInterfaces::themeEngine):
2283         (WebTestRunner):
2284         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2285         (WebKit):
2286         (TestInterfaces):
2287         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2288         (WebTestRunner::WebTestInterfaces::themeEngine):
2289         (WebTestRunner):
2290         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2291         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2292         (WebTestRunner):
2293         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2294         (WebTestRunner::WebTestThemeControlWin::box):
2295         (WebTestRunner::WebTestThemeControlWin::line):
2296         (WebTestRunner::WebTestThemeControlWin::triangle):
2297         (WebTestRunner::WebTestThemeControlWin::roundRect):
2298         (WebTestRunner::WebTestThemeControlWin::oval):
2299         (WebTestRunner::WebTestThemeControlWin::circle):
2300         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2301         (WebTestRunner::WebTestThemeControlWin::markState):
2302         (WebTestRunner::WebTestThemeControlWin::draw):
2303         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2304         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2305         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2306         (WebTestRunner):
2307         (WebTestThemeControlWin):
2308         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2309         (WebTestRunner):
2310         (WebTestThemeEngineMac):
2311         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2312         (+[FakeActiveWindow alwaysActiveWindow]):
2313         (+[FakeActiveWindow alwaysInactiveWindow]):
2314         (-[FakeActiveWindow initWithActiveControls:]):
2315         (-[FakeActiveWindow _hasActiveControls]):
2316         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2317         (WebTestRunner):
2318         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2319         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2320         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2321         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2322         (WebTestRunner):
2323         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2324         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2325         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2326         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2327         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2328         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2329         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2330         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2331         (WebTestRunner::WebTestThemeEngineWin::getSize):
2332         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2333         (WebTestRunner):
2334         (WebTestThemeEngineWin):
2335         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2336         * DumpRenderTree/chromium/TestShell.cpp:
2337         (TestShell::initialize):
2338         * DumpRenderTree/chromium/TestShell.h:
2339         (WebKit):
2340         * DumpRenderTree/chromium/TestShellMac.mm:
2341         (platformInit):
2342         * DumpRenderTree/chromium/TestShellWin.cpp:
2343         (platformInit):
2344         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2345
2346 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2347
2348         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2349
2350         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2351         New property sheet that does not link against CoreFoundation and
2352         CFNetwork.
2353         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2354         Use new TestWebKitAPICommonWinCairo property sheet.
2355         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2356         Ditto.
2357
2358 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2359
2360         [WinCairo] Unreviewed build fix for VS2010.
2361
2362         Had to add WinCairo-specific property sheets to deal with some
2363         library and path differences with the main Apple port.
2364
2365         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2366         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2367         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2368         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2369         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2370         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2371
2372 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2373
2374         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2375         https://bugs.webkit.org/show_bug.cgi?id=112849
2376
2377         Reviewed by Sam Weinig.
2378
2379         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2380         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2381         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2382
2383 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2384
2385         [WinCairo] Build WebKit Tools under VS2010
2386         https://bugs.webkit.org/show_bug.cgi?id=112821
2387
2388         Reviewed by Tim Horton.
2389
2390         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2391         Add WinCairo-specific build target.
2392         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2393         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2394         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2395         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2396         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2397         Add WinCairo-specific build target.
2398         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2399         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2400         Add WinCairo-specific build target.
2401         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2402         WinCairo-specific build target.
2403         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2404         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2405         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2406         specific build target.
2407         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2408         WinCairo-specific build target.
2409         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2410         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2411         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2412
2413 2013-03-20  Roger Fong  <roger_fong@apple.com>
2414
2415         API test gardening AppleWin port.
2416
2417         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2418
2419         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2420         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2421
2422 2013-03-20  Roger Fong  <roger_fong@apple.com>
2423
2424         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2425
2426         * EWSTools/start-queue-win.sh:
2427
2428 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2429
2430         Unreviewed, add myself to committers.py.
2431
2432 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2433
2434         Unreviewed. Adding another email for me.
2435
2436         * Scripts/webkitpy/common/config/committers.py:
2437
2438 2013-03-20  Justin Novosad  <junov@google.com>
2439
2440         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2441         https://bugs.webkit.org/show_bug.cgi?id=112605
2442
2443         Reviewed by James Robinson.
2444
2445         Deleting all the code that was used for propagating and supporting
2446         the Chromium setting for disabling deferred 2d canvas rendering.
2447
2448         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2449         (main):
2450         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2451         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2452         (WebTestRunner::WebPreferences::reset):
2453         (WebTestRunner::WebPreferences::applyTo):
2454         * DumpRenderTree/chromium/TestShell.cpp:
2455         (TestShell::TestShell):
2456         (TestShell::resetWebSettings):
2457         (TestShell::runFileTest):
2458         * DumpRenderTree/chromium/TestShell.h:
2459         (TestShell):
2460
2461 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2462
2463         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2464         https://bugs.webkit.org/show_bug.cgi?id=112699.
2465
2466         Reviewed by Adam Barth.
2467
2468         * Scripts/webkitpy/layout_tests/port/qt.py:
2469         (QtPort._search_paths):
2470         (QtPort._port_specific_expectations_files):
2471         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2472         (QtPortTest):
2473         (QtPortTest._assert_search_path):
2474         (QtPortTest._assert_expectations_files):
2475
2476 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2477
2478         [Qt] Enable kerning by default
2479         https://bugs.webkit.org/show_bug.cgi?id=112704
2480
2481         Reviewed by Jocelyn Turcotte.
2482
2483         Disable kerning by default, since some reference test expectations
2484         expect kerning to be default off.
2485
2486         * DumpRenderTree/qt/TestRunnerQt.cpp:
2487         (TestRunnerQt::reset):
2488         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2489         (WTR::activateFonts):
2490
2491 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2492
2493         [Qt] Remove empty function stubs from TestRunnerQt.
2494         https://bugs.webkit.org/show_bug.cgi?id=112799
2495
2496         We are reducing the code in TestRunnerQt step by step,
2497         in order to finally replace all of it with the generic
2498         TestRunner implementation.
2499         This patch removes several simple function stubs that
2500         currently do not implement any actual functionality.
2501
2502         Reviewed by Kenneth Rohde Christiansen.
2503
2504         * DumpRenderTree/qt/TestRunnerQt.cpp:
2505         * DumpRenderTree/qt/TestRunnerQt.h:
2506         (TestRunnerQt):
2507
2508 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2509
2510         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2511         https://bugs.webkit.org/show_bug.cgi?id=112687
2512
2513         Reviewed by Kenneth Rohde Christiansen.
2514
2515         Hide the SearchBar by default on window creation.
2516
2517         * MiniBrowser/efl/main.c:
2518         (window_create):
2519
2520 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2521
2522         Unreviewed, rolling out r146304.
2523         http://trac.webkit.org/changeset/146304
2524         https://bugs.webkit.org/show_bug.cgi?id=112788
2525
2526         to many expectations to update (Requested by antonm on
2527         #webkit).
2528
2529         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2530         * DumpRenderTree/DumpRenderTree.gypi:
2531         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2532         (WebKit):
2533         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2534         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2535         (TestInterfaces):
2536         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2537         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2538         * DumpRenderTree/chromium/TestShell.cpp:
2539         (TestShell::initialize):
2540         * DumpRenderTree/chromium/TestShell.h:
2541         (WebKit):
2542         * DumpRenderTree/chromium/TestShellMac.mm:
2543         (platformInit):
2544         * DumpRenderTree/chromium/TestShellWin.cpp:
2545         (platformInit):
2546         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2547         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2548         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2549         (WebThemeControlDRTWin::box):
2550         (WebThemeControlDRTWin::line):
2551         (WebThemeControlDRTWin::triangle):
2552         (WebThemeControlDRTWin::roundRect):
2553         (WebThemeControlDRTWin::oval):
2554         (WebThemeControlDRTWin::circle):
2555         (WebThemeControlDRTWin::nestedBoxes):
2556         (WebThemeControlDRTWin::markState):
2557         (WebThemeControlDRTWin::draw):
2558         (WebThemeControlDRTWin::drawTextField):
2559         (WebThemeControlDRTWin::drawProgressBar):
2560         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2561         (WebThemeControlDRTWin):
2562         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2563         (WebThemeEngineDRTMac):
2564         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2565         (+[FakeActiveWindow alwaysActiveWindow]):
2566         (+[FakeActiveWindow alwaysInactiveWindow]):
2567         (-[FakeActiveWindow initWithActiveControls:]):
2568         (-[FakeActiveWindow _hasActiveControls]):
2569         (WebThemeEngineDRTMac::paintScrollbarThumb):
2570         (stateToHIEnableState):
2571         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2572         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2573         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2574         (webRectToSkIRect):
2575         (drawControl):
2576         (drawTextField):
2577         (drawProgressBar):
2578         (WebThemeEngineDRTWin::paintButton):
2579         (WebThemeEngineDRTWin::paintMenuList):
2580         (WebThemeEngineDRTWin::paintScrollbarArrow):
2581         (WebThemeEngineDRTWin::paintScrollbarThumb):
2582         (WebThemeEngineDRTWin::paintScrollbarTrack):
2583         (WebThemeEngineDRTWin::paintSpinButton):
2584         (WebThemeEngineDRTWin::paintTextField):
2585         (WebThemeEngineDRTWin::paintTrackbar):
2586         (WebThemeEngineDRTWin::paintProgressBar):
2587         (WebThemeEngineDRTWin::getSize):
2588         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2589         (WebThemeEngineDRTWin):
2590         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2591
2592 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2593
2594         [Qt] Support -webkit-font-smoothing
2595         https://bugs.webkit.org/show_bug.cgi?id=106009
2596
2597         Reviewed by Jocelyn Turcotte.
2598
2599         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2600
2601         * DumpRenderTree/qt/TestRunnerQt.cpp:
2602         (TestRunnerQt::reset):
2603
2604 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2605
2606         [GTK] accessibility/aria-scrollbar-role.html is failing
2607         https://bugs.webkit.org/show_bug.cgi?id=98358
2608
2609         Reviewed by Martin Robinson.
2610
2611         Adds support for checking accessibility object's orientation.
2612         Orientation is checked by retrieving proper state of accessibility object.
2613
2614         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2615         (checkElementState):
2616         (AccessibilityUIElement::orientation):
2617         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2618         (WTR::AccessibilityUIElement::orientation):
2619
2620 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2621
2622         [chromium] move WebThemeEngine implementations to TestRunner library
2623         https://bugs.webkit.org/show_bug.cgi?id=112751
2624
2625         Reviewed by Adam Barth.
2626
2627         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2628         * DumpRenderTree/DumpRenderTree.gypi:
2629         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2630         (WebKit):
2631         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2632         (WebTestRunner::TestInterfaces::themeEngine):
2633         (WebTestRunner):
2634         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2635         (WebKit):
2636         (TestInterfaces):
2637         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2638         (WebTestRunner::WebTestInterfaces::themeEngine):
2639         (WebTestRunner):
2640         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2641         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2642         (WebTestRunner):
2643         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2644         (WebTestRunner::WebTestThemeControlWin::box):
2645         (WebTestRunner::WebTestThemeControlWin::line):
2646         (WebTestRunner::WebTestThemeControlWin::triangle):
2647         (WebTestRunner::WebTestThemeControlWin::roundRect):
2648         (WebTestRunner::WebTestThemeControlWin::oval):
2649         (WebTestRunner::WebTestThemeControlWin::circle):
2650         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2651         (WebTestRunner::WebTestThemeControlWin::markState):
2652         (WebTestRunner::WebTestThemeControlWin::draw):
2653         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2654         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2655         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2656         (WebTestRunner):
2657         (WebTestThemeControlWin):
2658         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2659         (WebTestRunner):
2660         (WebTestThemeEngineMac):
2661         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2662         (+[FakeActiveWindow alwaysActiveWindow]):
2663         (+[FakeActiveWindow alwaysInactiveWindow]):
2664         (-[FakeActiveWindow initWithActiveControls:]):
2665         (-[FakeActiveWindow _hasActiveControls]):
2666         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2667         (WebTestRunner):
2668         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2669         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2670         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2671         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2672         (WebTestRunner):
2673         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2674         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2675         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2676         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2677         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2678         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2679         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2680         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2681         (WebTestRunner::WebTestThemeEngineWin::getSize):
2682         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2683         (WebTestRunner):
2684         (WebTestThemeEngineWin):
2685         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2686         * DumpRenderTree/chromium/TestShell.cpp:
2687         (TestShell::initialize):
2688         * DumpRenderTree/chromium/TestShell.h:
2689         (WebKit):
2690         * DumpRenderTree/chromium/TestShellMac.mm:
2691         (platformInit):
2692         * DumpRenderTree/chromium/TestShellWin.cpp:
2693         (platformInit):
2694         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2695
2696 2013-03-19  Tony Chang  <tony@chromium.org>
2697
2698         Move testRunner.setTouchDragDropEnabled to internals.settings
2699         https://bugs.webkit.org/show_bug.cgi?id=112739
2700
2701         Reviewed by Adam Barth.
2702
2703         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2704         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2705         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2706         (TestRunner): Remove unnecessary code.
2707         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2708         (WebTestRunner::WebPreferences::reset):
2709         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2710
2711 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2712
2713         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2714         https://bugs.webkit.org/show_bug.cgi?id=112754
2715
2716         Reviewed by Darin Fisher.
2717
2718         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2719         now that it's always defined.
2720
2721         * DumpRenderTree/chromium/WebViewHost.cpp:
2722         * DumpRenderTree/chromium/WebViewHost.h:
2723         (WebViewHost):
2724
2725 2013-03-19  Kenneth Russell  <kbr@google.com>
2726
2727         Unreviewed, rolling out r146290.
2728         http://trac.webkit.org/changeset/146290
2729         https://bugs.webkit.org/show_bug.cgi?id=112751
2730
2731         Broke Chromium Mac build.
2732
2733         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2734         * DumpRenderTree/DumpRenderTree.gypi:
2735         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2736         (WebKit):
2737         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2738         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2739         (TestInterfaces):
2740         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2741         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2742         * DumpRenderTree/chromium/TestShell.cpp:
2743         (TestShell::initialize):
2744         * DumpRenderTree/chromium/TestShell.h:
2745         (WebKit):
2746         * DumpRenderTree/chromium/TestShellMac.mm:
2747         (platformInit):
2748         * DumpRenderTree/chromium/TestShellWin.cpp:
2749         (platformInit):
2750         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2751         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2752         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2753         (WebThemeControlDRTWin::box):
2754         (WebThemeControlDRTWin::line):
2755         (WebThemeControlDRTWin::triangle):
2756         (WebThemeControlDRTWin::roundRect):
2757         (WebThemeControlDRTWin::oval):
2758         (WebThemeControlDRTWin::circle):
2759         (WebThemeControlDRTWin::nestedBoxes):
2760         (WebThemeControlDRTWin::markState):
2761         (WebThemeControlDRTWin::draw):
2762         (WebThemeControlDRTWin::drawTextField):
2763         (WebThemeControlDRTWin::drawProgressBar):
2764         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2765         (WebThemeControlDRTWin):
2766         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2767         (WebThemeEngineDRTMac):
2768         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2769         (+[FakeActiveWindow alwaysActiveWindow]):
2770         (+[FakeActiveWindow alwaysInactiveWindow]):
2771         (-[FakeActiveWindow initWithActiveControls:]):
2772         (-[FakeActiveWindow _hasActiveControls]):
2773         (WebThemeEngineDRTMac::paintScrollbarThumb):
2774         (stateToHIEnableState):
2775         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2776         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2777         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2778         (webRectToSkIRect):
2779         (drawControl):
2780         (drawTextField):
2781         (drawProgressBar):
2782         (WebThemeEngineDRTWin::paintButton):
2783         (WebThemeEngineDRTWin::paintMenuList):
2784         (WebThemeEngineDRTWin::paintScrollbarArrow):
2785         (WebThemeEngineDRTWin::paintScrollbarThumb):
2786         (WebThemeEngineDRTWin::paintScrollbarTrack):
2787         (WebThemeEngineDRTWin::paintSpinButton):
2788         (WebThemeEngineDRTWin::paintTextField):
2789         (WebThemeEngineDRTWin::paintTrackbar):
2790         (WebThemeEngineDRTWin::paintProgressBar):
2791         (WebThemeEngineDRTWin::getSize):
2792         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2793         (WebThemeEngineDRTWin):
2794         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2795
2796 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2797
2798         [EFL] canvas-fallback-content.html is failing
2799         https://bugs.webkit.org/show_bug.cgi?id=111998
2800
2801         Reviewed by Chris Fleizach.
2802
2803         Adds support for getting platform name.
2804
2805         * DumpRenderTree/TestRunner.cpp:
2806         (TestRunner::staticValues):
2807         * DumpRenderTree/TestRunner.h:
2808         (TestRunner):
2809         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2810         (TestRunner::platformName):
2811
2812 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2813
2814         [chromium] move WebThemeEngine implementations to TestRunner library
2815         https://bugs.webkit.org/show_bug.cgi?id=112751
2816
2817         Reviewed by Adam Barth.
2818
2819         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2820         * DumpRenderTree/DumpRenderTree.gypi:
2821         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2822         (WebKit):
2823         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2824         (WebTestRunner::TestInterfaces::themeEngine):
2825         (WebTestRunner):
2826         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2827         (WebKit):
2828         (TestInterfaces):
2829         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2830         (WebTestRunner::WebTestInterfaces::themeEngine):
2831         (WebTestRunner):
2832         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2833         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2834         (WebTestRunner):
2835         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2836         (WebTestRunner::WebTestThemeControlWin::box):
2837         (WebTestRunner::WebTestThemeControlWin::line):
2838         (WebTestRunner::WebTestThemeControlWin::triangle):
2839         (WebTestRunner::WebTestThemeControlWin::roundRect):
2840         (WebTestRunner::WebTestThemeControlWin::oval):
2841         (WebTestRunner::WebTestThemeControlWin::circle):
2842         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2843         (WebTestRunner::WebTestThemeControlWin::markState):
2844         (WebTestRunner::WebTestThemeControlWin::draw):
2845         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2846         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2847         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2848         (WebTestRunner):
2849         (WebTestThemeControlWin):
2850         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2851         (WebTestRunner):
2852         (WebTestThemeEngineMac):
2853         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2854         (+[FakeActiveWindow alwaysActiveWindow]):
2855         (+[FakeActiveWindow alwaysInactiveWindow]):
2856         (-[FakeActiveWindow initWithActiveControls:]):
2857         (-[FakeActiveWindow _hasActiveControls]):
2858         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2859         (WebTestRunner):
2860         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2861         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2862         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2863         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2864         (WebTestRunner):
2865         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2866         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2867         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2868         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2869         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2870         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2871         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2872         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2873         (WebTestRunner::WebTestThemeEngineWin::getSize):
2874         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2875         (WebTestRunner):
2876         (WebTestThemeEngineWin):
2877         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2878         * DumpRenderTree/chromium/TestShell.cpp:
2879         (TestShell::initialize):
2880         * DumpRenderTree/chromium/TestShell.h:
2881         (WebKit):
2882         * DumpRenderTree/chromium/TestShellMac.mm:
2883         (platformInit):
2884         * DumpRenderTree/chromium/TestShellWin.cpp:
2885         (platformInit):
2886         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2887
2888 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2889
2890         [EFL][WK2] Separate WebView further from EwkView
2891         https://bugs.webkit.org/show_bug.cgi?id=111591
2892
2893         Reviewed by Caio Marcelo de Oliveira Filho.
2894
2895         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2896         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2897         since we can afford it having EWKViewGetWKView() private API to access WKView.
2898
2899         * TestWebKitAPI/PlatformWebView.h:
2900         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2901         (TestWebKitAPI::TEST):
2902         * TestWebKitAPI/efl/PlatformWebView.cpp:
2903         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2904         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2905         (TestWebKitAPI::PlatformWebView::resizeTo):
2906         (TestWebKitAPI::PlatformWebView::page):
2907         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2908         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2909         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2910         * WebKitTestRunner/PlatformWebView.h:
2911         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2912         (WTR::EventSenderProxy::dispatchEvent):
2913         (WTR::EventSenderProxy::keyDown):
2914         (WTR::EventSenderProxy::sendTouchEvent):
2915         (WTR::EventSenderProxy::setTouchModifier):
2916         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2917         (WTR::PlatformWebView::PlatformWebView):
2918         (WTR::PlatformWebView::~PlatformWebView):
2919         (WTR::PlatformWebView::resizeTo):
2920         (WTR::PlatformWebView::page):
2921         (WTR::PlatformWebView::focus):
2922         (WTR::PlatformWebView::windowSnapshotImage):
2923
2924 2013-03-19  Roger Fong  <roger_fong@apple.com>
2925
2926         Changes to VS2010 project files should only trigger builds on Windows bots.
2927         https://bugs.webkit.org/show_bug.cgi?id=112731
2928
2929         Reviewed by Timothy Horton.
2930
2931         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2932         (_should_file_trigger_build):
2933
2934 2013-03-19  Roger Fong  <roger_fong@apple.com>
2935
2936         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2937
2938         * Scripts/webkitpy/tool/steps/runtests.py:
2939         (RunTests.run):
2940         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2941         (RunTestsTest.test_webkit_run_unit_tests):
2942
2943 2013-03-19  Julie Parent  <jparent@chromium.org>
2944
2945         Dashboards: Introduce history namespace and unit tests.
2946         https://bugs.webkit.org/show_bug.cgi?id=112645
2947
2948         Reviewed by Ojan Vafai.
2949         
2950         Laying the framework for introducing the new history object and
2951         namespace.  This moves only static functions into the history
2952         namespace, and moves corresponding unit tests into seperate
2953         unit test file.
2954
2955         * TestResultServer/static-dashboards/aggregate_results.html:
2956         * TestResultServer/static-dashboards/dashboard_base.js:
2957         (parseCrossDashboardParameters):
2958         (parseDashboardSpecificParameters):
2959         (parseParameters):
2960         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2961         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2962         (.switch.return):
2963         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2964         * TestResultServer/static-dashboards/history.js: Added.
2965         * TestResultServer/static-dashboards/history_unittests.js: Added.
2966         * TestResultServer/static-dashboards/loader.js:
2967         (.):
2968         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2969         * TestResultServer/static-dashboards/run-unittests.html:
2970         * TestResultServer/static-dashboards/timeline_explorer.html:
2971         * TestResultServer/static-dashboards/timeline_explorer.js:
2972         * TestResultServer/static-dashboards/treemap.html:
2973         * TestResultServer/static-dashboards/treemap.js:
2974         (.switch.return):
2975         * TestResultServer/static-dashboards/ui.js:
2976
2977 2013-03-19  Daniel Bates  <dbates@webkit.org>
2978
2979         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2980         https://bugs.webkit.org/show_bug.cgi?id=112732
2981
2982         Reviewed by Eric Seidel.
2983
2984         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2985         of an existing file cannot be applied.
2986
2987         In particular, svn-{apply, unapply} compensate for differences in line endings
2988         by converting the line endings in a diff to match the line endings in the target
2989         file. The diff(1) command precedes the last line of a diff that adds a newline
2990         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2991         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2992         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2993         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2994         the newline characters in this special character sequence to match the line endings
2995         in the target file.
2996
2997         * Scripts/VCSUtils.pm:
2998         (parseDiff):
2999         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3000         Added tests:
3001             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3002             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3003             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3004             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3005         (escapeNewLineCharacters): Added.
3006         (toMacLineEndings): Added.
3007
3008 2013-03-19  James Robinson  <jamesr@chromium.org>
3009
3010         [chromium] Remove compositor settings that don't go through WebKit
3011         https://bugs.webkit.org/show_bug.cgi?id=112718
3012
3013         Reviewed by Adam Barth.
3014
3015         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3016         (main):
3017         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3018         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3019         (WebTestRunner::WebPreferences::reset):
3020         (WebTestRunner::WebPreferences::applyTo):
3021         * DumpRenderTree/chromium/TestShell.cpp:
3022         (TestShell::TestShell):
3023         (TestShell::resetWebSettings):
3024         * DumpRenderTree/chromium/TestShell.h:
3025         (TestShell):
3026
3027 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3028
3029         Unreviewed, rolling out r146101.
3030         https://bugs.webkit.org/show_bug.cgi?id=111884
3031
3032         re-enable custom freetype on asan; this needs to be on
3033         now that the bot is running lucid.
3034
3035         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3036
3037 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3038
3039         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3040         https://bugs.webkit.org/show_bug.cgi?id=112365
3041
3042         Reviewed by Benjamin Poulain.
3043
3044         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3045         harcoding it in wtf/Platform.h
3046
3047         * Scripts/webkitperl/FeatureList.pm:
3048
3049 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3050
3051         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3052         https://bugs.webkit.org/show_bug.cgi?id=94782
3053
3054         Based on patch by Csaba Osztrogonác.
3055         Reviewed by Jocelyn Turcotte.
3056
3057         The diff image is generated with bright red indicating errors, but letting the base image
3058         shine through so the context of the error-pixel can be identified.
3059
3060         * DumpRenderTree/qt/ImageDiff.cpp:
3061         (main):
3062
3063 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3064
3065         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3066
3067         Rubber-stamped by Csaba Osztrogonác.
3068
3069         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3070         since the latter might not cover the former.
3071
3072         * QtTestBrowser/launcherwindow.cpp:
3073         (LauncherWindow::print):
3074
3075 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3076
3077         Style tweeks to default.css.
3078         
3079         Rubber-stamped by David Kilzer.
3080         
3081         Give visited links a different color to other links, so you can
3082         see which builds you've viewed.
3083         
3084         Make the <small> text less tiny.
3085
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3087         (small):
3088         (a:link,a:visited,a:active):
3089         (a:visited):
3090
3091 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3092
3093         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3094         https://bugs.webkit.org/show_bug.cgi?id=112494
3095
3096         Reviewed by Dirk Pranke.
3097
3098         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3099         Also merged two pairs of methods to cleanup the code.
3100
3101         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3102         (PerfTestsRunner.run): Merged _upload_and_show_results.
3103         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3104
3105 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3106
3107         [chromium] build xdisplaycheck when building DRT
3108         https://bugs.webkit.org/show_bug.cgi?id=112636
3109
3110         Reviewed by Tony Chang.
3111
3112         It appears that we need xdisplaycheck to be built in order for
3113         Xvfb to be started correctly on the bots, and DRT was missing
3114         a dependency on it. This may be the cause of the ASAN bot not
3115         starting up properly (it only builds DRT).
3116
3117         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3118
3119 2013-03-18  David Levin  <levin@chromium.org>
3120
3121         Implement icon change notification dump for Chromium's test shell.
3122         https://bugs.webkit.org/show_bug.cgi?id=112614
3123
3124         This was previously implemented for some other platforms in r58111
3125         and r116547.
3126
3127         In r122806, fast/dom/icon-url-property.html stopped using it, but
3128         it is useful for tests, so I plan to re-add it to that test again.
3129
3130         Reviewed by Jochen Eisinger.
3131
3132         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3133         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3134          icon change notifications from WebKit may be logged in test output.
3135         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3136         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3137         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3138         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3139         (WebTestRunner):
3140         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3141         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3142         (TestRunner):
3143         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3144         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3145         (WebTestRunner):
3146         * DumpRenderTree/chromium/WebViewHost.cpp:
3147         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3148         * DumpRenderTree/chromium/WebViewHost.h:
3149         (WebViewHost):
3150
3151 2013-03-18  Julie Parent  <jparent@chromium.org>
3152
3153         Cleanup: Move js for treemap and aggregate_results into own js files.
3154         https://bugs.webkit.org/show_bug.cgi?id=112618
3155
3156         Reviewed by Dirk Pranke.
3157         
3158         No functional changes, just moving the code into separate js file
3159         rather than inlined in the html, so we can test it, make it more
3160         modular, etc.  Other dashboard types are already done this way.
3161
3162         * TestResultServer/static-dashboards/aggregate_results.html:
3163         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3164         (generatePage):
3165         (handleValidHashParameter):
3166         (htmlForBuilder):
3167         (rawValuesHTML):
3168         (chartHTML):
3169         (filteredValues):
3170         (chart):
3171         (htmlForRevisionRows):
3172         (wrapHTMLInTable):
3173         (htmlForSummaryTable):
3174         (valuesPerExpectation):
3175         (htmlForTestType):
3176         (htmlForTableRow):
3177         (extendedEncode):
3178         * TestResultServer/static-dashboards/treemap.html:
3179         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3180         (humanReadableTime):
3181         (convertToWebTreemapFormat):
3182         (reverseSortByAverage):
3183         (generatePage):
3184         (focusPath):
3185         (.switch.return):
3186         (handleQueryParameterChange):
3187         (extractName):
3188         (fullName):
3189         (handleFocus.):
3190         (handleFocus):
3191
3192 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3193
3194         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3195         https://bugs.webkit.org/show_bug.cgi?id=112622
3196
3197         Reviewed by Dirk Pranke.
3198
3199         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3200         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3201
3202 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3203
3204         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3205         https://bugs.webkit.org/show_bug.cgi?id=112619
3206
3207         Reviewed by Dirk Pranke.
3208
3209         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3210         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3211
3212         * Scripts/webkitpy/layout_tests/port/gtk.py:
3213         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3214         Port._webkit_baseline_path method.
3215         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3216         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3217         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3218         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3219         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3220         that are expected based on the builder name.
3221
3222 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3223
3224         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3225         https://bugs.webkit.org/show_bug.cgi?id=112571
3226
3227         Reviewed by Adam Barth.
3228
3229         Update function declarations for new WebFileSystemType enum. (All
3230         changes are behind an #ifdef so we can sync required changes in embedders.)
3231
3232         * DumpRenderTree/chromium/WebViewHost.cpp:
3233         (WebViewHost::openFileSystem):
3234         (WebViewHost::deleteFileSystem):
3235         * DumpRenderTree/chromium/WebViewHost.h:
3236         (WebViewHost):
3237
3238 2013-03-18  Julie Parent  <jparent@chromium.org>
3239
3240         Cleanup: Move timeline_exporer js out of html file into js.
3241         https://bugs.webkit.org/show_bug.cgi?id=112188
3242
3243         Reviewed by Dirk Pranke.
3244         
3245         Moves the javascript out of the html file and into a new js file.
3246         This follows the format of flakiness_dashboard.{html|js}.
3247         
3248         Also moves code from dashboard_base that is used only by this one
3249         dashboard, and makes it private to the dashboard.
3250
3251         * TestResultServer/static-dashboards/dashboard_base.js:
3252         * TestResultServer/static-dashboards/timeline_explorer.html:
3253         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3254         (generatePage):
3255         (initCurrentBuilderTestResults):
3256         (shouldShowWebKitRevisionsOnly):
3257         (updateTimelineForBuilder.):
3258         (updateTimelineForBuilder):
3259         (selectBuild):
3260         (updateBuildIndicator):
3261         (.addRow):
3262         (.addNumberRow):
3263         (.inspectorNode.getElementsByTagName.0.onclick):
3264         (.inspectorNode.getElementsByTagName.1.onclick):
3265         (.inspectorNode.getElementsByTagName.2.onclick):
3266         (updateBuildInspector):
3267         (showResultsDelta):
3268         (decompressResults.addFlakyDelta):
3269         (decompressResults):
3270
3271 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3272
3273         Unreviewed, rolling out r145272.
3274         http://trac.webkit.org/changeset/145272
3275         https://bugs.webkit.org/show_bug.cgi?id=111884
3276
3277         Turns out the ASAN build is still broken; possibly there's
3278         something still setting LD_LIBRARY_PATH, or possibly there's
3279         something else wrong. In the meantime, we need it to work again.
3280
3281         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3282
3283 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3284
3285         delete-stale-build-files is too aggressive
3286         https://bugs.webkit.org/show_bug.cgi?id=112595
3287
3288         Reviewed by Tim Horton.
3289
3290         It appears that whitelisting file extensions to keep is not a good idea.
3291         Blacklist files to delete instead, and only delete .o files for now.
3292         We can add more file extensions as needed.
3293
3294         * BuildSlaveSupport/delete-stale-build-files:
3295
3296 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3297
3298         Disable accessibility notifications after each test
3299         https://bugs.webkit.org/show_bug.cgi?id=112579
3300
3301         Reviewed by Tim Horton.
3302         
3303         In WebKitTestRunner, if any tests triggered accessibility notifications,
3304         the global notification handler would thereafter be active, and fire
3305         notifications for all subsequent tests.
3306         
3307         Fix by implementing AccessibilityController::resetToConsistentState() for
3308         Mac, and using it to clear the global notification handler.
3309
3310         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3311         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3312         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3313         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3314         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3315         (e.g. because of -autorelease).
3316         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3317         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3318         if there is one.
3319         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3320         Add -stopObserving
3321         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3322         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3323         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3324         center.
3325
3326 2013-03-18  Dana Jansens  <danakj@chromium.org>
3327
3328         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3329         https://bugs.webkit.org/show_bug.cgi?id=112392
3330
3331         Reviewed by James Robinson.
3332
3333         Removes the command line flag option from DRT.
3334
3335         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3336         (main):
3337
3338 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3339
3340         [GTK] plugins/plugin-clip-subframe.html is failing
3341         https://bugs.webkit.org/show_bug.cgi?id=112570
3342
3343         Reviewed by Martin Robinson.
3344
3345         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3346
3347 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3348
3349         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3350         https://bugs.webkit.org/show_bug.cgi?id=112442
3351
3352         Reviewed by Gustavo Noronha Silva.
3353
3354         * GtkLauncher/main.c:
3355         (reloadCb):
3356         (createToolbar):
3357         (createWindow):
3358
3359 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3360
3361         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3362         https://bugs.webkit.org/show_bug.cgi?id=112205
3363
3364         Disable this API test until Geoff can fix it.
3365
3366         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3367         (TestWebKitAPI::TEST):
3368
3369 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3370
3371         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3372         https://bugs.webkit.org/show_bug.cgi?id=112478
3373
3374         Reviewed by Tony Chang.
3375
3376         There is nothing that ensures that the log messages from the plugin
3377         come in before the layout test finished loading.
3378
3379         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3380         (PassDifferentNPPStruct::NPP_SetWindow):
3381         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3382         (NPP_SetWindow):
3383
3384 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3385
3386         Have the mac port support per_test_timeout in webkitpy
3387         https://bugs.webkit.org/show_bug.cgi?id=112466
3388
3389         Reviewed by Dirk Pranke.
3390         
3391         Both WTR and DRT handle --timeout arguments, so we can
3392         have the scripts pass the timeout values down to the tools.
3393
3394         * Scripts/webkitpy/layout_tests/port/mac.py:
3395         (MacPort.supports_per_test_timeout):
3396
3397 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3398
3399         Remove setAsynchronousSpellCheckingEnabled from test runners
3400         https://bugs.webkit.org/show_bug.cgi?id=112362
3401
3402         Reviewed by Tony Chang.
3403
3404         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3405         in internals.settings, so all ports can share it.
3406
3407         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3408         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3409         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3410         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3411         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3412         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3413         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3414         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3415         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3416         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3417         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3418         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3419
3420 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3421
3422         Fix the stupid unit tests.
3423
3424         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3425         (test_sample_process):
3426
3427 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3428
3429         Collect samples for unresponsive web processes
3430         https://bugs.webkit.org/show_bug.cgi?id=112409
3431
3432         Reviewed by Tim Horton.
3433         
3434         When we detect that a subprocess was unresponsive, run the 'sample'
3435         tool on that process, for the Mac port.
3436         
3437         The sample will be linked to from the results.html page, next
3438         to the crash log link.
3439
3440         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3441         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3442         look for samples on disk.
3443         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3444         (TestResultWriter):
3445         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3446         -sample.txt files, and have it copy their contents to a new file
3447         next to the test that spawned them (as we do for crash logs).
3448         * Scripts/webkitpy/layout_tests/port/base.py:
3449         (Port.look_for_new_samples): Base class does nothing for sampling.
3450         * Scripts/webkitpy/layout_tests/port/driver.py:
3451         (Driver._check_for_driver_crash): Kick off a sample if we detected
3452         that the subprocess was unresponsive.
3453         * Scripts/webkitpy/layout_tests/port/mac.py:
3454         (MacPort.sample_file_path): Utility to generate the file path
3455         to the generated sample files at the top level of layout-test-results.
3456         (MacPort.look_for_new_crash_logs): Fix typo
3457         (MacPort.look_for_new_samples): New function to find sample files.
3458         (MacPort.sample_process): Use the utility function to get the file path.
3459
3460 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3461
3462         [Qt] Remove simple getters and setters from TestRunnerQt
3463         https://bugs.webkit.org/show_bug.cgi?id=112343
3464
3465         Reviewed by Benjamin Poulain.
3466
3467         The removed functions and boolean members
3468         are being replaced by the implementations in the
3469         generic TestRunner.h.
3470
3471         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3472         (DumpRenderTree::dumpFrameScrollPosition):
3473         (DumpRenderTree::dumpFramesAsText):
3474         (DumpRenderTree::dump):
3475         (DumpRenderTree::titleChanged):
3476         (DumpRenderTree::dumpDatabaseQuota):
3477         (DumpRenderTree::dumpApplicationCacheQuota):
3478         (DumpRenderTree::statusBarMessage):
3479         (DumpRenderTree::createWindow):
3480         * DumpRenderTree/qt/TestRunnerQt.cpp:
3481         (TestRunnerQt::reset):
3482         * DumpRenderTree/qt/TestRunnerQt.h:
3483         (TestRunnerQt):
3484
3485 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3486
3487         Update the link on build.webkit.org to refer to perf.webkit.org
3488         https://bugs.webkit.org/show_bug.cgi?id=112416
3489
3490         Reviewed by Philip Rogers.
3491
3492         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3495
3496 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3497
3498         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3499         https://bugs.webkit.org/show_bug.cgi?id=112394
3500
3501         Reviewed by Philippe Normand.
3502
3503         * GtkLauncher/main.c:
3504         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3505
3506 2013-03-14  Andreas Kling  <akling@apple.com>
3507
3508         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3509         <http://webkit.org/b/111815>
3510         <rdar://problem/13380145>
3511
3512         Reviewed by Anders Carlsson.
3513
3514         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3515         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3516         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3517
3518         * WebKitTestRunner/PlatformWebView.h:
3519         (PlatformWebView):
3520         * WebKitTestRunner/TestController.cpp:
3521         (WTR::TestController::createOtherPage):
3522         (WTR::TestController::createWebViewWithOptions):
3523         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3524         (WTR::PlatformWebView::didInitializeClients):
3525
3526 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3527
3528         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3529         https://bugs.webkit.org/show_bug.cgi?id=112122
3530
3531         Reviewed by Kenneth Rohde Christiansen.
3532
3533         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3534
3535         * MiniBrowser/efl/main.c:
3536         (_Browser_Window):
3537         (search_box_show):
3538         (search_box_hide):
3539         (on_key_down):
3540         (on_url_changed):
3541         (on_search_field_aborted):
3542         (on_search_field_activated):
3543         (on_search_field_clicked):
3544         (on_search_backward_button_clicked):
3545         (on_search_forward_button_clicked):
3546         (window_create):
3547
3548 2013-03-14  Julie Parent  <jparent@chromium.org>
3549
3550         Cleanup: Remove g_resourceLoader.
3551         https://bugs.webkit.org/show_bug.cgi?id=112305
3552
3553         Reviewed by Dirk Pranke.
3554         
3555         Removing another global.
3556         
3557         Now, each dashboard creates its own loader, rather than having
3558         a general global one.
3559         
3560         Remove usage of g_resourceLoader.isLoadingComplete from 
3561         handleLocationChange by ensuring that handleLocationChange is
3562         never called before the loader is done.  It was called in two
3563         places before: 1 was from the callback when the loader is done,
3564         so that was obviously true, and the other was from onhashchange,
3565         where it would just return rather than running.  Instead, lets
3566         only register the onhashchange handler once the loader is
3567         setup, so the check is no longer necessary.
3568         
3569         Remove isLoadingComplete since it is now unused.
3570         
3571         Callback for loader is now initializeHistory, rather than just
3572         handleLocationChange which will set up the hashchange handler now.
3573         This will all eventually be moving to a new History object.
3574
3575         * TestResultServer/static-dashboards/aggregate_results.html:
3576         * TestResultServer/static-dashboards/dashboard_base.js:
3577         (handleLocationChange):
3578         (intializeHistory):
3579         (decompressResults):
3580         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3581         (generatePage):
3582         * TestResultServer/static-dashboards/loader.js:
3583         (.):
3584         * TestResultServer/static-dashboards/loader_unittests.js:
3585         * TestResultServer/static-dashboards/timeline_explorer.html:
3586         * TestResultServer/static-dashboards/treemap.html:
3587
3588 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3589
3590         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3591         https://bugs.webkit.org/show_bug.cgi?id=109404
3592
3593         Reviewed by Tony Chang.
3594
3595         Removes all the code related to smartInsertDeleteEnabled and
3596         selectTrailingWhitespaceEnabled settings as they will be managed from
3597         internals from now on.
3598
3599         * DumpRenderTree/TestRunner.cpp:
3600         (TestRunner::staticFunctions):
3601         * DumpRenderTree/TestRunner.h:
3602         (TestRunner):
3603         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3604         (WebKit):
3605         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3606         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3607         (DumpRenderTree):
3608         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3609         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3610         (WebTestRunner::WebTestProxy::didStopLoading):
3611         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3612         (WebTestRunner::TestRunner::TestRunner):
3613         (WebTestRunner::TestRunner::reset):
3614         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3615         (TestRunner):
3616         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3617         (WebTestRunner::WebPreferences::applyTo): Set default values for
3618         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3619         Chromium DRT default values are different from Chromium browser.
3620         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3621         * DumpRenderTree/chromium/WebViewHost.cpp:
3622         * DumpRenderTree/chromium/WebViewHost.h:
3623         (WebViewHost):
3624         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3625         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3626         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3627         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3628         (resetDefaultsToConsistentValues):
3629         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3630         * DumpRenderTree/mac/DumpRenderTree.mm:
3631         (resetWebViewToConsistentStateBeforeTesting):
3632         * DumpRenderTree/mac/TestRunnerMac.mm:
3633         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3634         (WebCore::WebPage::resetSettings):
3635         * DumpRenderTree/qt/TestRunnerQt.cpp:
3636         * DumpRenderTree/qt/TestRunnerQt.h:
3637         (TestRunnerQt):
3638         * DumpRenderTree/win/DumpRenderTree.cpp:
3639         (resetWebViewToConsistentStateBeforeTesting):
3640         * DumpRenderTree/win/TestRunnerWin.cpp:
3641         * DumpRenderTree/wx/TestRunnerWx.cpp:
3642
3643 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>