Crash-only queues on bot watcher's dashboard should not have non-crashing tests in...
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
2
3         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
4         https://bugs.webkit.org/show_bug.cgi?id=149848
5
6         Reviewed by Darin Adler.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
9
10 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
11
12         [Win] Support 64-bit Build and Testing
13         https://bugs.webkit.org/show_bug.cgi?id=149904
14
15         Reviewed by Daniel Bates.
16
17         Extend our existing scripts to support 64-bit build and test operations on
18         Windows.
19
20         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
21         Windows always builds the whole stack.
22         * Scripts/webkit-build-directory: Add an option to return the location of
23         the executable files produced by a specific configuration. This change is
24         actually useful for Gtk and EFL, too.
25         * Scripts/webkitdirs.pm:
26         (executableProductDir): Added. This function appends the proper binary
27         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
28         (jscProductDir): Use the new 'executableProductDir' method.
29         (setPathForRunningWebKitApp): Ditto.
30         (runSafari): Ditto.
31         (runMiniBrowser): Ditto.
32         * Scripts/webkitpy/port/factory.py:
33         (configuration_options): Add a 64-bit option, used on Windows to specify
34         which binary target should be used for testing.
35         * Scripts/webkitpy/port/win.py:
36         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
37         processes when needed.
38         (WinPort._build_path): Add the correct binary target path to _build_path.
39         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
40         64-bit paths for 64-bit tests.
41         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
42         NTSD debugger does not understand this argument.
43
44 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
45
46         Test font-variant-* and font-feature-settings with TrueType fonts
47         https://bugs.webkit.org/show_bug.cgi?id=149776
48
49         Reviewed by Simon Fraser.
50
51         This test extends our existing FontWithFeatures project to be able to generate a
52         TrueType font. This font is conceptually similar as the existing OpenType font,
53         except the feature -> character mapping is different.
54
55         The font itself only supports the following characters:
56         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
57         However, the shape of these letters are either an X or a check mark.
58         The letter "A" always is a check mark.
59         The letter "B" always is an X.
60         Each font feature has an letter associated with it. When the font feature is enabled,
61         that letter is shown as a check mark. For example, when
62         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
63         mark.
64
65         Here are the mappings of font features to letters:
66         kLigaturesType / kCommonLigaturesOnSelector: C
67         kLigaturesType / kContextualLigaturesOnSelector: D
68         kLigaturesType / kRareLigaturesOnSelector: G
69         kLigaturesType / kHistoricalLigaturesOnSelector: I
70         kContextualAlternatesType / kContextualAlternatesOnSelector: L
71         kVerticalPositionType / kInferiorsSelector: O
72         kVerticalPositionType / kSuperiorsSelector: P
73         kLowerCaseType / kLowerCaseSmallCapsSelector: S
74         kUpperCaseType / kUpperCaseSmallCapsSelector: V
75         kLowerCaseType / kLowerCasePetiteCapsSelector: T
76         kUpperCaseType / kUpperCasePetiteCapsSelector: W
77         kLetterCaseType / 14: Y
78         kStyleOptionsType / kTitlingCapsSelector: a
79         kNumberCaseType / kUpperCaseNumbersSelector: c
80         kNumberCaseType / kLowerCaseNumbersSelector: d
81         kNumberSpacingType / kProportionalNumbersSelector: f
82         kNumberSpacingType / kMonospacedNumbersSelector: g
83         kFractionsType / kDiagonalFractionsSelector: i
84         kFractionsType / kVerticalFractionsSelector: j
85         kVerticalPositionType / kOrdinalsSelector: Q
86         kTypographicExtrasType / kSlashedZeroOnSelector: k
87         kLigaturesType / kHistoricalLigaturesOnSelector: K
88         kCharacterShapeType / kJIS1978CharactersSelector: m
89         kCharacterShapeType / kJIS1983CharactersSelector: n
90         kCharacterShapeType / kJIS1990CharactersSelector: o
91         kCharacterShapeType / kJIS2004CharactersSelector: p
92         kCharacterShapeType / kSimplifiedCharactersSelector: q
93         kCharacterShapeType / kTraditionalCharactersSelector: r
94         kTextSpacingType / kMonospacedTextSelector: t
95         kTextSpacingType / kProportionalTextSelector: u
96         kRubyKanaType / kRubyKanaOnSelector: v
97
98         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
99         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
100         (CFFBuilder::moveTo):
101         (CFFBuilder::lineTo):
102         (GLYFBuilder::GLYFBuilder):
103         (GLYFBuilder::takeResult):
104         (GLYFBuilder::moveTo):
105         (GLYFBuilder::lineTo):
106         (GLYFBuilder::closePath):
107         (GLYFBuilder::writePoint):
108         (GLYFBuilder::append16):
109         (generateBoxCharString):
110         (generateCheckCharString):
111         (generateXCharString):
112         (itemForGlyph):
113         (Generator::generate):
114         (Generator::insertSelector):
115         (Generator::insertFeature):
116         (Generator::generateFeatureDescription):
117         (Generator::appendCFFTable):
118         (Generator::appendGLYFTable):
119         (Generator::appendLOCATable):
120         (Generator::appendFEATTable):
121         (Generator::appendMetamorphosisChain):
122         (Generator::appendMORXTable):
123         (Generator::appendHEADTable):
124         (Generator::appendHMTXTable):
125         (Generator::appendNameSubtable):
126         (Generator::append2ByteASCIIString):
127         (Generator::appendNAMETable):
128         (generateFont):
129         (CFFBuilder::curveToCubic): Deleted.
130         (charStringForGlyph): Deleted.
131         * FontWithFeatures/FontWithFeatures/FontCreator.h:
132         * FontWithFeatures/FontWithFeatures/main.cpp:
133         (constructFontWithTrueTypeFeature):
134         (constructFontWithOpenTypeFeature):
135         (drawText):
136         (main):
137         (drawTextWithFeature): Deleted.
138
139 2015-10-07  Commit Queue  <commit-queue@webkit.org>
140
141         Unreviewed, rolling out r190572, r190593, r190594, and
142         r190639.
143         https://bugs.webkit.org/show_bug.cgi?id=149897
144
145         Breaks Mavericks build (Requested by litherum on #webkit).
146
147         Reverted changesets:
148
149         "Allow WKRetainPtrs to be used as keys in hashing data
150         structures"
151         https://bugs.webkit.org/show_bug.cgi?id=149762
152         http://trac.webkit.org/changeset/190572
153
154         "REGRESSION(189668?): http/tests/notifications/events.html
155         flakily asserts or times out"
156         https://bugs.webkit.org/show_bug.cgi?id=149218
157         http://trac.webkit.org/changeset/190593
158
159         "Prospective Mavericks build fix."
160         http://trac.webkit.org/changeset/190594
161
162         "Post-review cleanup after r190572."
163         http://trac.webkit.org/changeset/190639
164
165 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
166
167         [GTK] Add autocleanups
168         https://bugs.webkit.org/show_bug.cgi?id=149588
169
170         Reviewed by Darin Adler.
171
172         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
173         (AutocleanupsTest::create):
174         (AutocleanupsTest::testWebProcessAutocleanups):
175         (registerTests):
176         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
177         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
178         (testUIProcessAutocleanups):
179         (testWebProcessAutocleanups):
180         (beforeAll):
181         (afterAll):
182
183 2015-10-06  Brian Burg  <bburg@apple.com>
184
185         Unreviewed, try to fix the iOS 8 build after r190368.
186
187         On older versions, IOHIDEventCreateForceEvent is not available.
188
189         * WebKitTestRunner/ios/HIDEventGenerator.mm:
190         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
191
192 2015-10-06  Keith Miller  <keith_miller@apple.com>
193
194         Add gmalloc option to run-javascriptcore-tests.
195         https://bugs.webkit.org/show_bug.cgi?id=149858
196
197         Reviewed by Geoffrey Garen.
198
199         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
200         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
201
202         * Scripts/run-javascriptcore-tests:
203
204 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
205
206         Post-review cleanup after r190572.
207
208         Unreviewed.
209
210         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
211
212 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
213
214         [Win] Unreviewed build correction.
215
216         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
217         are soft-linked at runtime.
218
219 2015-10-06  Keith Miller  <keith_miller@apple.com>
220
221         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
222         https://bugs.webkit.org/show_bug.cgi?id=149815
223
224         Reviewed by Filip Pizlo.
225
226         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
227         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
228         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
229         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
230         so should just use one test runner.
231
232         * Scripts/run-javascriptcore-tests:
233         (runJSCStressTests):
234         (runMozillaTests): Deleted.
235         (defaultJsDriverArgsForMozillaTests): Deleted.
236         * Scripts/run-jsc-stress-tests:
237
238 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
239
240         [GTK] Make update-webkitgtk-libs work behind firewall
241
242         update-webkitgtk-libs can work behind a firewall with changes to
243         a few packages.  Where outbound git and active FTP connections
244         fail, using http protocol succeeds.  Most packages are
245         already accessed using http.
246
247         https://bugs.webkit.org/show_bug.cgi?id=148941
248
249         Reviewed by Martin Robinson.
250
251         Tools
252         * gtk/jhbuild.modules:
253             Replace git URLs with http.  Remove no longer used ftp repositories.
254             Update argument for libxml2's autogen.sh script (--without-python
255             is ignored; --with-python=no is correct).
256         * jhbuild/jhbuild-wrapper:
257             Instead of connecting to git://git.gnome.org/jhbuild, connect to
258             http://git.gnome.org/browse/jhbuild.
259
260 2015-10-06  Daniel Bates  <dbates@webkit.org>
261
262         Enable XSLT when building WebKit for iOS using the public iOS SDK
263         https://bugs.webkit.org/show_bug.cgi?id=149827
264
265         Reviewed by Alexey Proskuryakov.
266
267         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
268         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
269         run this script before building WebKit for iOS or the build will fail because one or more XSLT
270         headers cannot be found.
271
272         * Scripts/configure-xcode-for-ios-development:
273         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
274
275 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
276
277         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
278         https://bugs.webkit.org/show_bug.cgi?id=149218
279
280         Reviewed by Alexey Proskuryakov.
281
282         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
283         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
284         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
285         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
286         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
287         WebNotificationProvider must be updated to appropriately handle multiple
288         WKNotificationManagerRefs in flight at the same time.
289
290         * WebKitTestRunner/WebNotificationProvider.cpp:
291         (WTR::WebNotificationProvider::~WebNotificationProvider):
292         (WTR::WebNotificationProvider::showWebNotification):
293         (WTR::WebNotificationProvider::closeWebNotification):
294         (WTR::WebNotificationProvider::addNotificationManager):
295         (WTR::WebNotificationProvider::removeNotificationManager):
296         (WTR::WebNotificationProvider::simulateWebNotificationClick):
297         (WTR::WebNotificationProvider::reset):
298         * WebKitTestRunner/WebNotificationProvider.h:
299
300 2015-10-05  Daniel Bates  <dabates@apple.com>
301
302         Disable Bitcode when building for iOS device
303         https://bugs.webkit.org/show_bug.cgi?id=149818
304
305         Reviewed by Alexey Proskuryakov.
306
307         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
308         when building for iOS device.
309
310         * Scripts/webkitdirs.pm:
311         (XcodeOptions):
312
313 2015-10-05  Daniel Bates  <dabates@apple.com>
314
315         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
316         https://bugs.webkit.org/show_bug.cgi?id=140828
317         <rdar://problem/19520599>
318
319         Reviewed by Alexey Proskuryakov.
320
321         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
322         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
323         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
324         to build-webkit.
325
326         * Scripts/webkitdirs.pm:
327         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
328         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
329         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
330         (hasIOSDevelopmentCertificate): Added.
331
332 2015-10-05  Daniel Bates  <dabates@apple.com>
333
334         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
335         https://bugs.webkit.org/show_bug.cgi?id=149766
336
337         Reviewed by Alexey Proskuryakov.
338
339         Create network storage testing session on iOS.
340
341         Currently we do not create a network storage testing session on iOS. A network storage testing session always
342         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
343         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
344         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
345         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
346         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
347         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
348         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
349         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
350
351         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
352         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
353         returns a non-null pointer to a cookie store.
354
355         * DumpRenderTree/mac/DumpRenderTree.mm:
356         (prepareConsistentTestingEnvironment):
357
358 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
359
360         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
361         available.
362
363         * WebKitTestRunner/ios/HIDEventGenerator.mm:
364         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
365
366 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
367
368         Allow WKRetainPtrs to be used as keys in hashing data structures
369         https://bugs.webkit.org/show_bug.cgi?id=149762
370
371         Reviewed by Anders Carlsson.
372
373         * TestWebKitAPI/PlatformGTK.cmake:
374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
375         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
376         (TestWebKitAPI::TEST):
377
378 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
379
380         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
381         available, and tidy up the #ifdefs in the UIKitSPI header.
382
383         * WebKitTestRunner/ios/HIDEventGenerator.mm:
384         (-[HIDEventGenerator _sendHIDEvent:]):
385         * WebKitTestRunner/ios/UIKitSPI.h:
386
387 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
388
389         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
390         https://bugs.webkit.org/show_bug.cgi?id=149792
391
392         Reviewed by Martin Robinson.
393
394         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
395         for WebKitTestRunner multiple times.
396
397 2015-10-04  Daniel Bates  <dabates@apple.com>
398
399         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
400         (https://bugs.webkit.org/show_bug.cgi?id=149753)
401
402         For now, support calling build-layouttestrelay without --ios-simulator so long
403         as we are building on a Mac.
404
405         * Scripts/build-layouttestrelay:
406
407 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
408
409         Support Trac 1.0.x XML timeline link format
410         https://bugs.webkit.org/show_bug.cgi?id=149786
411
412         Reviewed by Lucas Forschler.
413
414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
415         (Trac.prototype._convertCommitInfoElementToObject):
416
417 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
418
419         Fix some errors on bot watcher's dashboard
420         https://bugs.webkit.org/show_bug.cgi?id=149789
421
422         Reviewed by Lucas Forschler.
423
424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
425         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
426         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
427
428 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
429
430         Bot watcher's dashboard builders should turn yellow when svn fails
431         https://bugs.webkit.org/show_bug.cgi?id=149791
432
433         Reviewed by Lucas Forschler.
434
435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
436         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
437         (BuildbotBuilderQueueView.prototype.update):
438
439 2015-10-02  Daniel Bates  <dabates@apple.com>
440
441         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
442         https://bugs.webkit.org/show_bug.cgi?id=149769
443
444         Reviewed by Alexey Proskuryakov.
445
446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
450         (WebKitBuildbot):
451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
452         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
453
454 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
455
456         REGRESSION(r190370): Speedometer spits out an extra console message
457         https://bugs.webkit.org/show_bug.cgi?id=149720
458
459         Unreviewed. Temporarily ignore the console error message.
460
461         * Scripts/webkitpy/performance_tests/perftest.py:
462         (PerfTest._filter_output):
463
464 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
465
466         Provide "--no-ninja" option to avoid using Ninja
467         https://bugs.webkit.org/show_bug.cgi?id=149757
468
469         Reviewed by Alex Christensen.
470
471         Add a new command line argument understood by webkitdirs.pm so
472         that we can conditionally avoid using Ninja. This is an
473         'opt-out' argument, so no existing Ninja users should be affected.
474         
475         * Scripts/webkitdirs.pm:
476         (canUseNinja): Check for option and block ninja if present.
477
478 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
479
480         Flakiness dashboard should support OS X El Capitan
481         https://bugs.webkit.org/show_bug.cgi?id=149648
482
483         Reviewed by Alexey Proskuryakov.
484
485         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
486
487 2015-10-02  Daniel Bates  <dabates@apple.com>
488
489         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
490         (https://bugs.webkit.org/show_bug.cgi?id=149753)
491
492         For now, pass --ios-simulator.
493
494         * Scripts/webkitpy/port/ios.py:
495         (IOSSimulatorPort._build_relay):
496
497 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
498
499         Remove a "nullable" that breaks the iOS 8 build.
500
501         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
502         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
503
504 2015-10-02  Daniel Bates  <dabates@apple.com>
505
506         LayoutTestRelay is not built and archived when building for iOS Simulator
507         https://bugs.webkit.org/show_bug.cgi?id=149753
508
509         Reviewed by Alexey Proskuryakov and Andy Estes.
510
511         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
512         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
513         product archive when building for iOS Simulator, respectively.
514
515         * BuildSlaveSupport/built-product-archive:
516         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
517         differentiate between iOS device and iOS Simulator platforms.
518         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
519         from determineWebKitBuildDirectories() into this function so that it can be used by both
520         determineWebKitBuildDirectories() and archiveBuiltProduct().
521         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
522         webkitBuildDirectoryForConfigurationAndPlatform().
523         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
524         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
525         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
526         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
527         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
528         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
529         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
530         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
531         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
532         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
533         * Scripts/build-layouttestrelay:
534             - Remove unnecessary include of Perl module POSIX.
535             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
536         * Scripts/build-webkit:
537             - Invoke script build-layouttestrelay when building for iOS Simulator.
538
539 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
540
541         [Win] Unreviewed test fix.
542
543         You cannot run 'run-webkit-tests' from the command line because it does not know
544         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
545         because they explicitly set use the 'root' argument to provide the full path to
546         the test binaries.
547
548         * Scripts/webkitpy/port/win.py:
549         (WinPort._build_path): Added.
550
551 2015-10-02  Alex Christensen  <achristensen@webkit.org>
552
553         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
554         https://bugs.webkit.org/show_bug.cgi?id=149430
555         rdar://problem/22742222
556
557         Reviewed by Geoffrey Garen.
558
559         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
560         (WTR::TestController::cocoaResetStateToConsistentValues):
561         * WebKitTestRunner/mac/TestControllerMac.mm:
562         (WTR::TestController::platformConfigureViewForTest):
563         Test what happens when you disable content blockers from the SPI.
564
565 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
566
567         [Win] Unreviewed build fix for run-api-tests
568
569         * Scripts/run-api-tests:
570         (testToolPaths): Windows run needs to specify the binary path.
571
572 2015-10-01  Daniel Bates  <dabates@apple.com>
573
574         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
575         (https://bugs.webkit.org/show_bug.cgi?id=149695)
576
577         Following r190424 we can now rely on webkit-build-directory to return the path to
578         the correct configuration-specific build directory on Windows.
579
580         * BuildSlaveSupport/built-product-archive:
581         (archiveBuiltProduct):
582
583 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
584
585         [Win] Unreviewed build fix.
586
587         * Scripts/webkitdirs.pm:
588         (setupAppleWinEnv): Use 64-bit build tools if available
589
590 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
591
592         [Win] Fix TestWebKitAPI build under CMake.
593
594         Reviewed by Alex Christensen.
595
596         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
597         for Psapi.lib.
598
599 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
600
601         [Win] Fix behavior of webkit-build-directory script
602         https://bugs.webkit.org/show_bug.cgi?id=149718
603
604         Reviewed by Alex Christensen.
605
606         * Scripts/webkitdirs.pm:
607         (determineConfigurationProductDir): Do not include the binary
608         sub-directory in the configuration product directory output.
609         (jscProductDir): Append correct binary path for Windows build.
610         (setPathForRunningWebKitApp): Include properly binary subdirectories.
611         (runSafari): Update for revised productDir behavior.
612         (runMiniBrowser): Ditto.
613
614 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
615
616         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
617         use iOS SDK, like with all the others.
618
619         * Scripts/build-webkit:
620
621 2015-10-01  Daniel Bates  <dabates@apple.com>
622
623         Attempt to fix the iOS 9 Simulator testers
624
625         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
626         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
627         LayoutTestRelay when building for iOS Simulator.
628
629         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
630         * Scripts/build-webkit:
631
632 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
633
634         [GTK] Websites with invalid auth header keep loading forever
635         https://bugs.webkit.org/show_bug.cgi?id=149710
636
637         Reviewed by Martin Robinson.
638
639         Add test case to check that we can authenticate sites with an
640         empty realm.
641
642         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
643         (testWebViewAuthenticationEmptyRealm):
644         (serverCallback):
645         (beforeAll):
646
647 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
648
649         [Mac] Make run-api-tests work with System Integrity Protection
650         https://bugs.webkit.org/show_bug.cgi?id=149711
651         rdar://problem/22928202
652
653         Reviewed by Dan Bernstein.
654
655         * Scripts/run-api-tests:
656         (runTest):
657         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
658
659 2015-10-01  Daniel Bates  <dabates@apple.com>
660
661         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
662         (https://bugs.webkit.org/show_bug.cgi?id=149695)
663
664         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
665         For now, use the path to the top-level WebKit build directory instead of using the configuration-
666         specific build directory.
667
668         * BuildSlaveSupport/built-product-archive:
669         (archiveBuiltProduct):
670
671 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
672
673         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
674         https://bugs.webkit.org/show_bug.cgi?id=145837
675
676         Reviewed by Philippe Normand.
677
678         * efl/jhbuild.modules:
679         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
680         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
681
682 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
683
684         Unreviewed. Fix the iOS build after r190407.
685
686         * WebKitTestRunner/ios/IOKitSPI.h:
687
688 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
689
690         Implement keyboard event sending for iOS in WebKitTestRunner
691         https://bugs.webkit.org/show_bug.cgi?id=149676
692
693         Reviewed by Simon Fraser.
694
695         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
696         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
697         allows us to run code when the keyboard is shown or hidden.
698
699         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
700         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
701         (WTR::UIScriptController::setDidShowKeyboardCallback):
702         (WTR::UIScriptController::didShowKeyboardCallback):
703         (WTR::UIScriptController::setDidHideKeyboardCallback):
704         (WTR::UIScriptController::didHideKeyboardCallback):
705         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
706         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
707         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
708         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
709         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
710         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
711         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
712                 the notifications that the keyboard has been raised or lowered.
713         (-[TestRunnerWKWebView _keyboardDidShow:]):
714         (-[TestRunnerWKWebView _keyboardDidHide:]):
715         * WebKitTestRunner/ios/HIDEventGenerator.h:
716         * WebKitTestRunner/ios/HIDEventGenerator.m:
717         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
718         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
719         (hidUsageCodeForCharacter): Ditto.
720         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
721                 a keyDown event in WebKit.
722         * WebKitTestRunner/ios/IOKitSPI.h:
723         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
724
725 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
726
727         Unreviewed, rolling out r190399.
728
729         Tests are still failing even after r190362
730
731         Reverted changeset:
732
733         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
734         http://trac.webkit.org/changeset/190399
735
736 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
737
738         [jhbuild] switch to new upstream usrsctp library
739         https://bugs.webkit.org/show_bug.cgi?id=149494
740
741         Reviewed by Philippe Normand.
742
743         * efl/jhbuild.modules:
744         * gtk/jhbuild.modules:
745
746 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
747
748         Unreviewed. Unskip GTK+ user media unit tests after r190362.
749
750         They should pass now.
751
752         * Scripts/run-gtk-tests:
753         (TestRunner):
754
755 2015-09-30  Daniel Bates  <dabates@apple.com>
756
757         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
758         (https://bugs.webkit.org/show_bug.cgi?id=149695)
759
760         * BuildSlaveSupport/built-product-archive:
761         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
762         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
763
764 2015-09-30  Daniel Bates  <dabates@apple.com>
765
766         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
767         (https://bugs.webkit.org/show_bug.cgi?id=149695)
768
769         Actually, we need to pass --configuration to script webkit-build-directory to have
770         it return the path to the configuration-specific build directory.
771
772         * BuildSlaveSupport/built-product-archive:
773         (determineWebKitBuildDirectories):
774
775 2015-09-30  Daniel Bates  <dabates@apple.com>
776
777         built-product-archive archives incorrect build directory for iOS port
778         https://bugs.webkit.org/show_bug.cgi?id=149695
779
780         Reviewed by Darin Adler.
781
782         Fixes an issue where the script built-product-archive archives a non-existent
783         build directory for the iOS port. Without loss of generality, the script assumes
784         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
785         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
786
787         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
788         to determine the top-level build directory and computes the configuration-specific
789         build directory to be the concatenation of the the top-level build directory and
790         the configuration (e.g. Release). This is incorrect. Instead we should call
791         webkit-build-directory omitting the flag --top-level to compute the path to the
792         configuration-specific build directory.
793
794         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
795         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
796         its purpose and added global variable _configurationBuildDirectory to store the path
797         to the configuration-specific build directory. Ensure that we have a non-empty string
798         for both the top-level and configuration-specific build directories.
799         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
800         Compute the configuration-specific build directory and store it in the global variable
801         _configurationBuildDirectory.
802         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
803         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
804         as needed.
805         (determineWebKitBuildDirectory): Deleted.
806
807 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
808
809         [EFL] css3/device-adapt/* tests failed after r190335.
810         https://bugs.webkit.org/show_bug.cgi?id=149655
811
812         Reviewed by Simon Fraser.
813
814         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
815         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
816
817         * WebKitTestRunner/efl/TestControllerEfl.cpp:
818         (WTR::shouldUseFixedLayout):
819
820 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
821
822         Extend JetStream timeout for slow devices.
823
824         Reviewed by Chris Dumez.
825
826         Extend JetStream timeout to 20 minutes.
827
828         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
829
830 2015-09-30  Daniel Bates  <dabates@apple.com>
831
832         Rename iOS builders/testers to include version
833         https://bugs.webkit.org/show_bug.cgi?id=149685
834
835         Reviewed by Simon Fraser.
836
837         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
838         make it clear to a reader the version of iOS these builders/testers are using.
839
840         * BuildSlaveSupport/build.webkit.org-config/config.json:
841         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
842
843 2015-09-30  Daniel Bates  <dabates@apple.com>
844
845         Add iOS criterion for triggering a build
846         https://bugs.webkit.org/show_bug.cgi?id=149679
847
848         Rubber-stamped by Alexey Proskuryakov.
849
850         First pass at defining criterion for triggering an iOS build.
851
852         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
853         (_should_file_trigger_build):
854         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
855         (ShouldBuildTest):
856         (ShouldBuildTest.test_should_build):
857
858 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
859
860         [iOS] Allow tests to generate user gestures for UI testing
861         https://bugs.webkit.org/show_bug.cgi?id=149653
862
863         Reviewed by Tim Horton.
864
865         Expose functionality in UIScriptController to allow for testing single- and double-tap,
866         and to listen for completion of scrolling and zooming in the WKWebView.
867         
868         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
869         which hides the complexity of creating these events. Event dispatch is asynchronous.
870         We detect when the last event has been handled by dispatching a vendor-specific event,
871         which is detected via -_handleHIDEvent: in our UIApplication subclass.
872         
873         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
874         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
875         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
876         single and double taps.
877         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
878         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
879         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
880         (UIScriptContext::unregisterCallback):
881         (UIScriptContext::callbackWithID):
882         (UIScriptContext::fireCallback):
883         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
884         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
885         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
886         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
887         (WTR::UIScriptController::setDidEndZoomingCallback):
888         (WTR::UIScriptController::didEndZoomingCallback):
889         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
890         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
891         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
892         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
893         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
894         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
895         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
896         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
897         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
898         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
899         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
900         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
901         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
902         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
903         (simpleDragCurve):
904         (calculateNextLocation):
905         (delayBetweenMove):
906         (+[HIDEventGenerator sharedHIDEventGenerator]):
907         (+[HIDEventGenerator nextEventCallbackID]):
908         (-[HIDEventGenerator init]):
909         (-[HIDEventGenerator _createIOHIDEventType:]):
910         (-[HIDEventGenerator _sendHIDEvent:]):
911         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
912         (-[HIDEventGenerator _updateTouchPoints:count:]):
913         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
914         (-[HIDEventGenerator touchDown:touchCount:]):
915         (-[HIDEventGenerator touchDown:]):
916         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
917         (-[HIDEventGenerator liftUp:touchCount:]):
918         (-[HIDEventGenerator liftUp:]):
919         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
920         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
921         (-[HIDEventGenerator tap:completionBlock:]):
922         (-[HIDEventGenerator doubleTap:completionBlock:]):
923         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
924         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
925         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
926         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
927         (-[HIDEventGenerator markerEventReceived:]):
928         * WebKitTestRunner/ios/IOKitSPI.h: Added.
929         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
930         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
931         (WTR::globalToContentCoordinates):
932         (WTR::UIScriptController::singleTapAtPoint):
933         (WTR::UIScriptController::doubleTapAtPoint):
934         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
935         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
936         * WebKitTestRunner/ios/mainIOS.mm:
937         (-[WebKitTestRunnerApp _handleHIDEvent:]):
938
939 2015-09-30  Dana Burkart  <dburkart@apple.com>
940
941         git-add-reviewer should trim trailing spaces/newlines
942         https://bugs.webkit.org/show_bug.cgi?id=149513
943
944         Reviewed by Darin Adler.
945
946         * Scripts/git-add-reviewer:
947         (nonInteractive):
948
949 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
950
951         REGRESSION(r190262): User media unit test failures after r190262
952         https://bugs.webkit.org/show_bug.cgi?id=149580
953
954         Reviewed by Darin Adler.
955
956         * WebKitTestRunner/TestController.cpp:
957         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
958           order to WKUserMediaPermissionRequestAllow.
959
960 2015-09-30  Daniel Bates  <dabates@apple.com>
961
962         Add iOS builders and testers
963         https://bugs.webkit.org/show_bug.cgi?id=149549
964
965         Reviewed by Alexey Proskuryakov.
966
967         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
968         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
969
970         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
971         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
972
973 2015-09-30  Timothy Hatcher  <timothy@apple.com>
974
975         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
976         https://bugs.webkit.org/show_bug.cgi?id=149674
977
978         Reviewed by Lucas Forschler.
979
980         * WebKitLauncher/WebKitLauncher.entitlements: Added.
981         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
982
983 2015-09-30  Jason Marcell  <jmarcell@apple.com>
984
985         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
986         have an associated trac instance.
987         https://bugs.webkit.org/show_bug.cgi?id=149673
988
989         Reviewed by Alexey Proskuryakov.
990
991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
992         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
993         have an associated trac instance.
994
995 2015-09-30  Daniel Bates  <dabates@apple.com>
996
997         Prioritize testing latest build request on iOS test bots
998         https://bugs.webkit.org/show_bug.cgi?id=149669
999
1000         Reviewed by Darin Adler.
1001
1002         We should prioritize testing of the latest build request on the iOS test bots
1003         as we do for Mac and Windows test bots.
1004
1005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1006         (loadBuilderConfig):
1007
1008 2015-09-30  Daniel Bates  <dabates@apple.com>
1009
1010         Add buildbot category for iOS builders and testers
1011         https://bugs.webkit.org/show_bug.cgi?id=149667
1012
1013         Reviewed by Darin Adler.
1014
1015         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1016         for iOS to the build.webkit.org home page.
1017
1018         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1019         (loadBuilderConfig):
1020         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1021
1022 2015-09-30  Daniel Bates  <dabates@apple.com>
1023
1024         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1025         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1026
1027         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1028         in <http://trac.webkit.org/changeset/190351>.
1029
1030         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1031         (CompileWebKit.start):
1032
1033 2015-09-30  Daniel Bates  <dabates@apple.com>
1034
1035         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1036         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1037
1038         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1039         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1042         (CompileWebKit.start):
1043
1044 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1045
1046         bot210 was configured for a queue instead of bot126.
1047         
1048         Unreviewed config.json fix.
1049         
1050         * BuildSlaveSupport/build.webkit.org-config/config.json:
1051
1052 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1053
1054         Bring El Capitan buildbot infrastructure online.
1055         https://bugs.webkit.org/show_bug.cgi?id=149605
1056         
1057         Reviewed by Darin Adler.
1058
1059         * BuildSlaveSupport/build.webkit.org-config/config.json:
1060
1061 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1062
1063         [GTK] Deprecation warnings in DOMNodeTest
1064         https://bugs.webkit.org/show_bug.cgi?id=149663
1065
1066         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1067         need to update the tests to use webkit_dom_document_query_selector_all
1068         to avoid compilation warnings.
1069
1070         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1071         (the suggested replacement for the deprecated function).
1072
1073         Reviewed by Carlos Garcia Campos.
1074
1075         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1076         (WebKitDOMNodeTest::testTagNamesNodeList):
1077         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1078         (registerTests):
1079         (WebKitDOMNodeTest::testTagNames): Deleted.
1080         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1081         (prepareDOMForTagNamesTests):
1082         (testWebKitDOMNodeTagNamesNodeList):
1083         (testWebKitDOMNodeTagNamesHTMLCollection):
1084         (beforeAll):
1085         (testWebKitDOMNodeTagNames): Deleted.
1086
1087 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1088
1089         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1090         https://bugs.webkit.org/show_bug.cgi?id=149650
1091
1092         Reviewed by Tim Horton.
1093         
1094         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1095         looks at the file path, and not the custom options that come from file comments.
1096         
1097         Fix by computing TestOptions before making the TestInvocation, and setting them
1098         as const TestInvocation data. This meant changing various call sites to take
1099         the std::string pathOrURL, rather than the TestInvocation itself.
1100         
1101         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1102
1103         * WebKitTestRunner/CMakeLists.txt:
1104         * WebKitTestRunner/TestController.cpp:
1105         (WTR::TestController::ensureViewSupportsOptionsForTest):
1106         (WTR::testPath):
1107         (WTR::createTestURL):
1108         (WTR::updateTestOptionsFromTestHeader):
1109         (WTR::TestController::testOptionsForTest):
1110         (WTR::TestController::updateWebViewSizeForTest):
1111         (WTR::TestController::updateWindowScaleForTest):
1112         (WTR::TestController::runTest):
1113         * WebKitTestRunner/TestController.h:
1114         * WebKitTestRunner/TestInvocation.cpp:
1115         (WTR::TestInvocation::TestInvocation):
1116         (WTR::TestInvocation::invoke):
1117         (WTR::createWKURL): Deleted.
1118         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1119         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1120         * WebKitTestRunner/TestInvocation.h:
1121         (WTR::TestInvocation::options):
1122         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1123         (WTR::pathContains):
1124         (WTR::shouldMakeViewportFlexible):
1125         (WTR::shouldUseFixedLayout):
1126         (WTR::isSVGTestPath):
1127         (WTR::isHiDPITestPath):
1128         (WTR::TestOptions::TestOptions):
1129         * WebKitTestRunner/TestOptions.h:
1130         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1131         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1132         (WTR::pathContains):
1133         (WTR::shouldUseFixedLayout):
1134         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1135         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1136         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1137         * WebKitTestRunner/ios/TestControllerIOS.mm:
1138         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1139         * WebKitTestRunner/mac/TestControllerMac.mm:
1140         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1141
1142 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1143
1144         Flakiness dashboard should support OS X El Capitan
1145         https://bugs.webkit.org/show_bug.cgi?id=149648
1146
1147         Reviewed by Alexey Proskuryakov.
1148
1149         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
1150         difference between new appscale and old Google App Engine implementation.
1151         * TestResultServer/app.yaml: Same.
1152         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1153
1154 2015-09-29  Daniel Bates  <dabates@apple.com>
1155
1156         configure-xcode-for-ios-development does not work with Xcode 7
1157         https://bugs.webkit.org/show_bug.cgi?id=149640
1158
1159         Reviewed by Alexey Proskuryakov.
1160
1161         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1162         because it cannot find the Xcode specification files for iOS simulator and device. These
1163         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1164         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1165         new specification files with the added definitions (as we did in older versions of Xcode)
1166         in order for Xcode 7 to honor these definitions.
1167
1168         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1169         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1170         (updateXcode7SpecificationFile): Added.
1171         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1172         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1173         appropriate success message.
1174         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1175         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1176         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1177
1178 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1179
1180         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1181         https://bugs.webkit.org/show_bug.cgi?id=149639
1182
1183         Reviewed by Alex Christensen.
1184
1185         * Scripts/VCSUtils.pm:
1186         (exitStatus): Use 'isWindows()' method.
1187         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1188         an error. This method could probably just go away.
1189         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1190         always changing to Unix style. 
1191         (unixPath): Added. Needed so Windows can always show a Unix path in the
1192         ChangeLog file.
1193         (changeLogName): Work around the fact that 'getpwuid' is not available on
1194         a pure Windows build of Perl.
1195         * Scripts/prepare-ChangeLog:
1196         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1197         path on Windows.
1198         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1199         support using arrays for 'open' arguments.
1200         (resolveChangeLogsPath): Ditto.
1201         (resolveConflictedChangeLogs): Use new helper functions.
1202         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1203         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1204         quotes. Unix systems are happy either way.
1205         (statusCommand): Ditto.
1206         * Scripts/webkitdirs.pm:
1207         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1208
1209 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1210
1211         [Win] Unreviewed 64-bit build fix after switch to CMake.
1212
1213         * Scripts/webkitdirs.pm:
1214         (determineIsWin64FromArchitecture): Added.
1215
1216 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1217
1218         printing does not use minimum page zoom factor
1219         https://bugs.webkit.org/show_bug.cgi?id=108507
1220
1221         Reviewed by Darin Adler.
1222
1223         WebKitTestRunner always takes the snapshots from the UI process
1224         (expect for IOS), so in the case of printing, the layout in the
1225         web view is not the expected one. When printing, we need to take
1226         the snapshot in the web process and ensure it's rendered with a
1227         PrintContext.
1228
1229         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1230         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1231         kWKSnapshotOptionsPrinting option to
1232         WKBundlePageCreateSnapshotWithOptions() when printing.
1233
1234 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1235
1236         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1237         https://bugs.webkit.org/show_bug.cgi?id=149595
1238
1239         Reviewed by Tim Horton.
1240
1241         All ports except IOS implement
1242         PlatformWebView::windowSnapshotImage() to generate the snapshot
1243         for the pixel tests in the UI process. But we are still generating
1244         a snapshot for pixel tests in the Web process too, that is passed
1245         to the UI process but ignored.
1246         Whether a pixel result is needed or not, is only known by the web
1247         process depending on whether the test called dumpAsText with
1248         dumpPixels == true or not. Since the pixels are now dump in the UI
1249         process, we need to pass that information to the UI process when
1250         the test is done. For that we set a PixelResultIsPending bool
1251         parameter to the Done message, and we only add the PixelResult
1252         when UI process doesn't need to generate the pixels dump.
1253
1254         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1255         (WTR::InjectedBundle::didReceiveMessageToPage): Set
1256         m_pixelResultIsPending to false on reset.
1257         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
1258         Done message, and set the PixelResult if m_pixelResultIsPending is false.
1259         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1260         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
1261         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
1262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1263         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
1264         port.
1265         * WebKitTestRunner/TestInvocation.cpp:
1266         (WTR::TestInvocation::dumpResults): Use either the pixel result
1267         from the web process or generate a pixel result from the web view
1268         if need it.
1269         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1270         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1271         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1272         is created by the caller now, but the CG implementation needs to
1273         know if it's a Web or UI process snapshot.
1274         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1275         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1276         cairo surface for the given image.
1277         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1278         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1279         CGContext for the given image.
1280
1281 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
1282
1283         Fix JS errors on dashboard metrics page
1284         https://bugs.webkit.org/show_bug.cgi?id=149608
1285
1286         Reviewed by Alexey Proskuryakov.
1287
1288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
1289         (initPlatformsByFamily): 
1290         (updateHiddenPlatforms):
1291         (parsePlatformFamily): Deleted.
1292         (updateToggleButtons): Deleted.
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1294         (updateHiddenPlatforms): Added to remove errors.
1295         (initPlatformsByFamily): Added to remove errors.
1296         (unhiddenQueues): Updated to use Settings.
1297         (documentReady): Added logic to add toggle buttons to the settings menu.
1298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1299         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
1300         MetricsMain.js to Settings.
1301         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
1302         MetricsMain.js to Settings.
1303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1304         (QueueView.prototype._updateHiddenState): Updated to use Settings.
1305
1306 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
1307
1308         Appscale query fails because of missing index
1309         https://bugs.webkit.org/show_bug.cgi?id=149609
1310
1311         Reviewed by Darin Adler.
1312
1313         * QueueStatusServer/index.yaml: Added the required index.
1314
1315 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1316
1317         [Win] Fix the 64-bit build after switch to cmake.
1318
1319         Reviewed by Alex Christensen.
1320
1321         * Scripts/webkitdirs.pm:
1322         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
1323         run a 64-bit build.
1324
1325 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1326
1327         [Win] Allow Windows to run test-webkitpy without Cygwin
1328         https://bugs.webkit.org/show_bug.cgi?id=149602
1329
1330         Reviewed by Alex Christensen.
1331
1332         These changes mostly shift from hard-coded paths using UNIX-style
1333         separators to Python's "os.path.join" syntax that uses the correct
1334         path separator for each platform.
1335         
1336         * Scripts/webkitpy/common/system/path.py:
1337         (cygpath): Don't pass paths through Cygpath on native Windows.
1338         * Scripts/webkitpy/port/win.py:
1339         (WinPort._path_to_apache): Use os.path.join.
1340         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
1341         in 64-bit environments).
1342         * Scripts/webkitpy/style/checker.py: Use os.path.join.
1343         * Scripts/webkitpy/style/checker_unittest.py:
1344         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
1345         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
1346         (GlobalVariablesTest): Ditto.
1347         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
1348         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
1349         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
1350         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
1351         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
1352         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
1353         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
1354         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
1355         (StyleProcessor_CodeCoverageTest): Ditto.
1356         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
1357         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
1358         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
1359         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
1360         manual string concatenation of paths.
1361
1362 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1363
1364         Add bugzilla addresses of committers to contributors.json
1365         https://bugs.webkit.org/show_bug.cgi?id=149520
1366
1367         Reviewed by Darin Adler.
1368
1369         * Scripts/webkitpy/common/config/contributors.json:
1370
1371 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1372
1373         validate-committer-lists -b shouldn't need edituser privileges
1374         https://bugs.webkit.org/show_bug.cgi?id=149519
1375
1376         Reviewed by Darin Adler.
1377
1378         * Scripts/validate-committer-lists:
1379         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
1380         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1381         (BugzillaQueries.is_invalid_bugzilla_email):
1382         (BugzillaQueries): Deleted.
1383         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
1384
1385 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1386
1387         Unreviewed. Gardening: skip media stream tests failing after r190262.
1388
1389         * Scripts/run-gtk-tests:
1390         (TestRunner):
1391
1392 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1393
1394         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
1395         https://bugs.webkit.org/show_bug.cgi?id=149571
1396
1397         Reviewed by Dan Bernstein.
1398
1399         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
1400
1401         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1402         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1403         * LayoutTestRelay/Configurations/Base.xcconfig:
1404         * MiniBrowser/Configurations/Base.xcconfig:
1405         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1406         * TestWebKitAPI/Configurations/Base.xcconfig:
1407         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1408         * WebEditingTester/Configurations/Base.xcconfig:
1409         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1410         * WebKitTestRunner/Configurations/Base.xcconfig:
1411         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1412         * WebKitTestRunner/iOS.xcconfig: Removed.
1413
1414 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
1415
1416         Clean up user media request internal API
1417         https://bugs.webkit.org/show_bug.cgi?id=149527
1418
1419         Reviewed by Tim Horton.
1420
1421         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1422         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1423
1424         * WebKitTestRunner/TestController.cpp:
1425         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1426
1427 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1428
1429         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1430         https://bugs.webkit.org/show_bug.cgi?id=149577
1431
1432         Reviewed by Tim Horton.
1433         
1434         When calling testRunner.runUIScript() from a page load event, the script could run
1435         in the UI process before the current remote layer tree transaction had been handled
1436         there. This meant that runUIScript() could query state which was about to change.
1437         
1438         Fix by delaying the execution of the UI script until a layer tree transaction has
1439         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1440
1441         * WebKitTestRunner/TestInvocation.cpp:
1442         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1443         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1444         * WebKitTestRunner/TestInvocation.h:
1445
1446 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1447
1448         [Mac] Media tests start to time out after a few days of bot uptime
1449         https://bugs.webkit.org/show_bug.cgi?id=149468
1450
1451         Reviewed by Darin Adler.
1452
1453         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1454         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1455         all temporary and cache files go to a custom location.
1456
1457         * Scripts/webkitpy/port/base.py:
1458         * Scripts/webkitpy/port/driver.py:
1459         * Scripts/webkitpy/port/mac.py:
1460         * Scripts/webkitpy/port/win.py:
1461         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1462
1463 2015-09-25  Dan Bernstein  <mitz@apple.com>
1464
1465         Removed MiniBrowser.entitlements.
1466
1467         Rubber-stamped by Anders Carlsson.
1468
1469         The entitlements weren’t used anyway.
1470
1471         * MiniBrowser/MiniBrowser.entitlements: Removed.
1472         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1473
1474 2015-09-24  Daniel Bates  <dabates@apple.com>
1475
1476         Add WebKitSystemInterface for iOS 9.0
1477         https://bugs.webkit.org/show_bug.cgi?id=149550
1478
1479         Rubber-stamped by Alexey Proskuryakov.
1480
1481         * Scripts/copy-webkitlibraries-to-product-directory:
1482
1483 2015-09-24  Daniel Bates  <dabates@apple.com>
1484
1485         Support building for arbitrary architectures
1486         https://bugs.webkit.org/show_bug.cgi?id=149539
1487
1488         Reviewed by Alexey Proskuryakov.
1489
1490         Teach buildbot to pass the architectures associated with the builder to build-webkit
1491         when building on OS X and iOS. As a side effect of this change we now support building
1492         universal binaries when multiples architectures are specified.
1493
1494         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1495         (CompileWebKit.start):
1496
1497 2015-09-24  Daniel Bates  <dabates@apple.com>
1498
1499         Fix the build after <http://trac.webkit.org/changeset/190212>
1500         (http://trac.webkit.org/changeset/190212)
1501
1502         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1503
1504         * BuildSlaveSupport/built-product-archive:
1505         (main):
1506
1507 2015-09-24  Daniel Bates  <dabates@apple.com>
1508
1509         Support running unit tests on iOS Simulator test bot
1510         https://bugs.webkit.org/show_bug.cgi?id=149536
1511
1512         Reviewed by Alexey Proskuryakov.
1513
1514         Implements support for running unit tests on a iOS test bot. At the time of writing,
1515         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1516
1517         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1518         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1519         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1520
1521 2015-09-24  Daniel Bates  <dabates@apple.com>
1522
1523         Add support infrastructure for OpenSource iOS builders and testers
1524         https://bugs.webkit.org/show_bug.cgi?id=149534
1525
1526         Reviewed by Darin Adler.
1527
1528         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1529         scripts about iOS.
1530
1531         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1532         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1533         --ios-simulator or --device for a builder/tester whose full platform name begins with
1534         "ios-simulator" or "ios", respectively.
1535         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1536         * BuildSlaveSupport/built-product-archive:
1537         (main): Pass the full platform name to determineWebKitBuildDirectory().
1538         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1539         command line flag when building for iOS.
1540         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1541         parameter fullPlatform. This parameter was originally added in r125066 to support the
1542         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1543         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1544         * BuildSlaveSupport/clean-build:
1545         (main): Call script webkit-build-directory with the appropriate command line flag when
1546         building for iOS.
1547         * BuildSlaveSupport/delete-stale-build-files:
1548         (main): Use the same logic for iOS as we do for Mac.
1549         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1550         flag when building for iOS.
1551         * BuildSlaveSupport/test-result-archive:
1552         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1553
1554 2015-09-24  Daniel Bates  <dabates@apple.com>
1555
1556         Remove Chromium-specific changes to script built-product-archive
1557         https://bugs.webkit.org/show_bug.cgi?id=149530
1558
1559         Rubber-stamped by Csaba Osztrogonác.
1560
1561         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1562         Chromium code has long since been removed from the OpenSource WebKit Project.
1563
1564         * BuildSlaveSupport/built-product-archive:
1565         (createZipManually):
1566         (createZip):
1567         (archiveBuiltProduct):
1568
1569 2015-09-24  Dan Bernstein  <mitz@apple.com>
1570
1571         Build fix.
1572
1573         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1574
1575 2015-09-24  Mark Lam  <mark.lam@apple.com>
1576
1577         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1578
1579         * Scripts/webkitpy/common/config/contributors.json:
1580
1581 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1582
1583         Unreviewed. Fix GObject DOM API breaks after r190120.
1584
1585         Bring back code removed in r169931 to handle documentation of
1586         deleted classes.
1587
1588         * gtk/webkitdom.py:
1589         (WebKitDOMDocGenerator):
1590         (WebKitDOMDocGenerator.write_deleted_classes):
1591         (WebKitDOMDocGenerator.generate):
1592         (write_deleted_classes):
1593         (WebKitDOMDocGeneratorSections._deleted_class):
1594         (WebKitDOMDocGeneratorSections._deleted_class.in):
1595         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1596         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1597
1598 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1599
1600         [Cocoa] [Font Features] Implement font-variant-*
1601         https://bugs.webkit.org/show_bug.cgi?id=148413
1602
1603         Reviewed by Darin Adler.
1604
1605         Update test font to use "lnum" feature.
1606
1607         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1608         (Generator::appendGSUBTable):
1609
1610 2015-09-22  Andy Estes  <aestes@apple.com>
1611
1612         ContentFiltering.AllowDownloadAfterAddData is very flaky
1613         https://bugs.webkit.org/show_bug.cgi?id=148885
1614         <rdar://problem/22729563>
1615
1616         Reviewed by Alexey Proskuryakov.
1617
1618         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1619         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1620         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1621
1622         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1623         (downloadTest):
1624
1625 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1626
1627         Mavericks: Media tests start to time out after a few days of bot uptime
1628         https://bugs.webkit.org/show_bug.cgi?id=149468
1629
1630         Reviewed by Chris Dumez.
1631
1632         * Scripts/webkitpy/port/base.py:
1633         * Scripts/webkitpy/port/driver.py:
1634         * Scripts/webkitpy/port/mac.py:
1635
1636 2015-09-22  Nan Wang  <n_wang@apple.com>
1637
1638         Unreviewed, add myself to the committers list.
1639
1640         * Scripts/webkitpy/common/config/contributors.json:
1641
1642 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1643
1644         Remove 'nullable' to fix older iOS builds.
1645
1646         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1647         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1648
1649 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1650
1651         [Win] Show tiled drawing debug overlay on Windows
1652         https://bugs.webkit.org/show_bug.cgi?id=149426
1653
1654         Reviewed by Dean Jackson.
1655
1656         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1657         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1658         * MiniBrowser/win/Common.cpp:
1659         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1660         flag if needed.
1661         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1662
1663 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1664
1665         [Win] Use command-line argument to launch in regular or High DPI mode.
1666         https://bugs.webkit.org/show_bug.cgi?id=149417
1667
1668         Reviewed by Dean Jackson.
1669
1670         * MiniBrowser/win/Common.cpp:
1671         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1672         very start of execution, before the MiniBrowser.dll is loaded.
1673         * win/DLLLauncher/DLLLauncherMain.cpp:
1674         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1675         present. On WinCairo, always use High DPI.
1676
1677 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1678
1679         32-bit Mac build fix attempt after r190065.
1680
1681         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1682
1683 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1684
1685         [OS X] Update for Xcode 7.0 on Yosemite
1686         https://bugs.webkit.org/show_bug.cgi?id=149389
1687
1688         Reviewed by Dan Bernstein.
1689
1690         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1691         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1692         Removed unneeded declarations - conforming to a protocol is sufficient.
1693
1694         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1695         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1696         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1697         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1698
1699 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1700
1701         Add the ability for tests to run script in the UI process in WebKitTestRunner
1702         https://bugs.webkit.org/show_bug.cgi?id=149356
1703
1704         Reviewed by Tim Horton.
1705
1706         This change adds testRunner.runUIScript(script, callback), which allows a test
1707         to execute script in a JSContext which runs in the UI process. That context
1708         has bindings exposed through the UIScriptController interface; currently one test
1709         function, and some iOS-specific functions are included. UIScriptController can be
1710         async with a callback, and runUIScript() itself is asynchronous. When the UI 
1711         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1712         is a string passed back to the web process, and given to the runUIScript()
1713         callback function.
1714         
1715         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1716
1717         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1718         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1719         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1720         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1721         complete, call back into TestRunner.
1722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1723         (WTR::nextUIScriptCallbackID):
1724         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1725         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1726         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1727         * WebKitTestRunner/PlatformWebView.h:
1728         * WebKitTestRunner/TestController.cpp:
1729         (WTR::updateTestOptionsFromTestHeader):
1730         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1731         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1732         * WebKitTestRunner/TestInvocation.cpp:
1733         (WTR::TestInvocation::shouldUseFixedLayout):
1734         (WTR::TestInvocation::shouldUseThreadedScrolling):
1735         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1736         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1737         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1738         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1739         * WebKitTestRunner/TestInvocation.h:
1740         * WebKitTestRunner/TestOptions.h:
1741         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1742         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1743         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1744         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1745         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1746         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1747         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1748         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1749         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1750         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1751         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1752         (WTR::UIScriptController::doAsyncTask):
1753         (WTR::UIScriptController::zoomToScale):
1754         (WTR::UIScriptController::zoomScale):
1755         (WTR::UIScriptController::minimumZoomScale):
1756         (WTR::UIScriptController::maximumZoomScale):
1757         (WTR::UIScriptController::contentVisibleRect):
1758         * WebKitTestRunner/mac/EventSenderProxy.mm:
1759         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1760         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1761         * WebKitTestRunner/mac/TestControllerMac.mm:
1762         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1763         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1764         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1765         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1766         (UIScriptContext::UIScriptContext):
1767         (UIScriptContext::~UIScriptContext):
1768         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1769         asynchronous, call the callback.
1770         (UIScriptContext::nextTaskCallbackID):
1771         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1772         that has a callback). Has to store the callbackID of the script, so code called from the completion
1773         callback knows which UI script invoked it.
1774         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1775         (UIScriptContext::uiScriptComplete):
1776         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1777         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1778         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1779         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1780         (WTR::UIScriptController::UIScriptController):
1781         (WTR::UIScriptController::makeWindowObject):
1782         (WTR::UIScriptController::wrapperClass):
1783         (WTR::UIScriptController::doAsyncTask):
1784         (WTR::UIScriptController::zoomToScale):
1785         (WTR::UIScriptController::zoomScale):
1786         (WTR::UIScriptController::minimumZoomScale):
1787         (WTR::UIScriptController::maximumZoomScale):
1788         (WTR::UIScriptController::contentVisibleRect):
1789         (WTR::UIScriptController::uiScriptComplete):
1790         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1791         (WTR::UIScriptController::create):
1792         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1793
1794 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1795
1796         Turn on threaded scrolling by default in the tests
1797         https://bugs.webkit.org/show_bug.cgi?id=149377
1798
1799         Reviewed by Simon Fraser.
1800
1801         * WebKitTestRunner/mac/TestControllerMac.mm:
1802         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1803         (WTR::shouldUseThreadedScrolling): Deleted.
1804         Turn on threaded scrolling by default.
1805
1806 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1807
1808         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1809         https://bugs.webkit.org/show_bug.cgi?id=149252
1810
1811         Reviewed by Darin Adler.
1812
1813         In case of glib tests the test runner notifies about tests
1814         crashing, but for google tests we don't get any feedback, which
1815         means that in case of a test crashing we get a list of **PASS**
1816         messages and at the summary we are notified that the test suite
1817         has failed, but it's impossible to know which test cases have failed.
1818
1819         * Scripts/run-gtk-tests:
1820         (TestRunner._run_google_test): Add a **CRASH** message if test
1821         case crashed.
1822
1823 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1824
1825         WebKitTestRunner can leak user content script results between tests
1826         https://bugs.webkit.org/show_bug.cgi?id=149391
1827
1828         Reviewed by Sam Weinig.
1829
1830         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1831         about:blank, and thus about:blank doesn't have unintended side effects.
1832
1833         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1834         (WTR::InjectedBundle::beginTesting):
1835         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1836         (WTR::InjectedBundlePage::resetAfterTest):
1837
1838 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1839
1840         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1841         https://bugs.webkit.org/show_bug.cgi?id=149384
1842
1843         Reviewed by Chris Fleizach.
1844
1845         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1846         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1847         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1848         regardless of whether someone else holds a reference (we also call -stopListening in
1849         -dealloc).
1850
1851         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1852         (AccessibilityController::platformResetToConsistentState):
1853         (AccessibilityController::addNotificationListener):
1854         Ditto.
1855
1856 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1857
1858         Remove XHR_TIMEOUT compilation guard
1859         https://bugs.webkit.org/show_bug.cgi?id=149260
1860
1861         Reviewed by Benjamin Poulain.
1862
1863         * Scripts/webkitperl/FeatureList.pm:
1864
1865 2015-09-19  Dan Bernstein  <mitz@apple.com>
1866
1867         Attempted build fix.
1868
1869         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1870
1871 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1872
1873         Unreviewed, rolling out r189908.
1874         https://bugs.webkit.org/show_bug.cgi?id=149368
1875
1876         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1877
1878         Reverted changeset:
1879
1880         "printing does not use minimum page zoom factor"
1881         https://bugs.webkit.org/show_bug.cgi?id=108507
1882         http://trac.webkit.org/changeset/189908
1883
1884 2015-09-18  Andy Estes  <aestes@apple.com>
1885
1886         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1887         https://bugs.webkit.org/show_bug.cgi?id=149360
1888
1889         Reviewed by Tim Horton.
1890
1891         Added an API test.
1892
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1895         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1896         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1897         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1898         (TEST):
1899         * TestWebKitAPI/ios/pages.pages: Added.
1900
1901 2015-09-18  Nan Wang  <n_wang@apple.com>
1902
1903         AX: Implement ARIA 1.1 @aria-current on iOS
1904         https://bugs.webkit.org/show_bug.cgi?id=149297
1905
1906         Reviewed by Chris Fleizach.
1907
1908         Added support to test aria-current on iOS.
1909
1910         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1911         (AccessibilityUIElement::stringAttributeValue):
1912         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1913         (WTR::AccessibilityUIElement::stringAttributeValue):
1914
1915 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1916
1917         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1918         https://bugs.webkit.org/show_bug.cgi?id=149352
1919
1920         Reviewed by Simon Fraser.
1921
1922         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1923         m_context can be null. This may indicate a bug in webkitpy too, but
1924         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1925         wrong with opening and immediately closing it.
1926
1927 2015-09-18  Daniel Bates  <dabates@apple.com>
1928
1929         isGitSVNDirectory() returns true when Git is not installed
1930         https://bugs.webkit.org/show_bug.cgi?id=149351
1931
1932         Reviewed by Alexey Proskuryakov.
1933
1934         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1935         Git is not installed on the machine.
1936
1937         * Scripts/VCSUtils.pm:
1938         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1939         status code 0 (success).
1940
1941 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1942
1943         Prevent build-webkit from building four times on Windows 
1944         https://bugs.webkit.org/show_bug.cgi?id=149336
1945
1946         Reviewed by Brent Fulgham.
1947
1948         * Scripts/build-webkit:
1949         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1950         They're built all at once.
1951         * Scripts/webkitdirs.pm:
1952         (buildVisualStudioProject):
1953         (cmakeGeneratedBuildfile):
1954         Don't generate the Visual Studio solution if it already exists.
1955         It will run CMake again if necessary.
1956
1957 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1958
1959         [iOS WK2] WTR fails to set the key window in the UIKit sense
1960         https://bugs.webkit.org/show_bug.cgi?id=149325
1961
1962         Reviewed by Tim Horton.
1963
1964         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1965         This causes UIKit to bypass code that actually sets the key window, resulting in
1966         [UIAppliation sharedApplication].keyWindow always being nil.
1967
1968         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1969         -[WebKitTestRunnerWindow isKeyWindow] call super.
1970
1971         * WebKitTestRunner/PlatformWebView.h:
1972         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1973         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1974         (WTR::PlatformWebView::setWindowIsKey):
1975         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1976         (WTR::PlatformWebView::setWindowIsKey):
1977         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1978         (-[WebKitTestRunnerWindow isKeyWindow]):
1979         (WTR::PlatformWebView::PlatformWebView):
1980         (WTR::PlatformWebView::~PlatformWebView):
1981         (WTR::PlatformWebView::setWindowIsKey):
1982         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1983         (WTR::PlatformWebView::setWindowIsKey):
1984
1985 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1986
1987         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1988         https://bugs.webkit.org/show_bug.cgi?id=149321
1989
1990         Reviewed by Tim Horton.
1991         
1992         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
1993         enabled the "testing" viewport configuration, which disables page scaling.
1994         
1995         If we're running viewport tests, we want the normal web page configuration.
1996         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1997         based on whether the test is in a "viewport" directory.
1998
1999         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2000         (WTR::InjectedBundle::beginTesting):
2001         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2002         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2003         * WebKitTestRunner/TestInvocation.cpp:
2004         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2005         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2006         (WTR::TestInvocation::shouldMakeViewportFlexible):
2007         (WTR::TestInvocation::invoke):
2008         * WebKitTestRunner/TestInvocation.h:
2009         * WebKitTestRunner/ios/TestControllerIOS.mm:
2010         (WTR::TestController::platformConfigureViewForTest):
2011         (WTR::shouldMakeViewportFlexible): Deleted.
2012
2013 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2014
2015         Give iOS WebKitTestRunner a launch storyboard
2016         https://bugs.webkit.org/show_bug.cgi?id=149314
2017
2018         Reviewed by Dan Bates.
2019         
2020         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2021         that it's been built for specific device configurations, and puts the window
2022         at the top of the screen. This simplifies coordinate conversions in a future patch.
2023
2024         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2025         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2026         * WebKitTestRunner/ios/Launch.storyboard: Added.
2027
2028 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2029
2030         Update licence in r189890
2031         https://bugs.webkit.org/show_bug.cgi?id=149306
2032
2033         Reviewed by Dean Jackson.
2034
2035         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2036         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2037         * FontWithFeatures/FontWithFeatures/main.cpp:
2038
2039 2015-09-17  Mark Lam  <mark.lam@apple.com>
2040
2041         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2042         https://bugs.webkit.org/show_bug.cgi?id=149285
2043
2044         Reviewed by Saam Barati.
2045
2046         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2047
2048         * Scripts/run-javascriptcore-tests:
2049         (runJSCStressTests):
2050
2051 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2052
2053         Switch AppleWin build to use CMake
2054         https://bugs.webkit.org/show_bug.cgi?id=149163
2055
2056         Reviewed by Brent Fulgham.
2057
2058         * Scripts/build-webkit:
2059         * Scripts/run-api-tests:
2060         (runTest):
2061         (listAllTests):
2062         (prepareEnvironmentForRunningTestTool):
2063         (testToolPaths):
2064         (testToolPath): Deleted.
2065         Run the API tests as separate executables on Windows.
2066         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2067         * Scripts/webkitdirs.pm:
2068         (checkRequiredSystemConfig):
2069         (jhbuildWrapperPrefixIfNeeded):
2070         (generateBuildSystemFromCMakeProject):
2071         Fix configuration quirks.
2072
2073 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2074
2075         Added toggle options for hiding and showing certain platform families on the dashboard.
2076         https://bugs.webkit.org/show_bug.cgi?id=148403
2077
2078         Reviewed by David Kilzer.
2079
2080         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2081         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2082         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2083         in lieu of an "all" button in the toggle menu.
2084
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2086         (parsePlatformFamily): Helper function to parse out a platform family.
2087         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2088         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2089         (updateToggleButtons): Updates the status of the toggle buttons.
2090         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2091         (documentReady): Added creation of toggle buttons.
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2093         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2094         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2095         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
2096         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2098         (QueueView): Updated to use hiddenPlatformFamilies.
2099         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2101         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2102         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2103         (Settings.prototype.toggleHiddenPlatform): Deleted.
2104         (Settings.prototype.clearHiddenPlatforms): Deleted.
2105         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2107         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2108         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2109         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2110         (table.queue-grid tr.headers th):
2111         (div.settingsWrapper.hide):
2112         (div.settingsWrapper):
2113         (div.familyToggleWrapper):
2114         (div.platformFamilyToggleButton):
2115         (div.platformFamilyShowToggleButton:not(:last-child)):
2116         (div.familyShown):
2117         (div.accessibilityButton):
2118         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2119         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2120         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2121         platformFamilyToggleButton and settingsWrapper class.
2122         (.accessibilityButton): Deleted.
2123
2124 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2125
2126         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2127         https://bugs.webkit.org/show_bug.cgi?id=148904
2128
2129         Reviewed by Myles Maxfield.
2130
2131         * WebKitTestRunner/TestController.cpp:
2132         (WTR::parseBooleanTestHeaderValue):
2133         (WTR::updateViewOptionsFromTestHeader):
2134         Check for the key "useThreadedScrolling".
2135         Add some code to check for "true" and "false" for boolean options.
2136
2137         (WTR::TestController::viewOptionsForTest):
2138         Apply the test's overrides last, even after the platform's.
2139
2140 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2141
2142         printing does not use minimum page zoom factor
2143         https://bugs.webkit.org/show_bug.cgi?id=108507
2144
2145         Reviewed by Darin Adler.
2146
2147         WebKitTestRunner always takes the snapshots from the UI process
2148         (expect for IOS), so in the case of printing, the layout in the
2149         web view is not the expected one. When printing, we need to take
2150         the snapshot in the web process and ensure it's rendered with a
2151         PrintContext.
2152
2153         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2154         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2155         kWKSnapshotOptionsPrinting option to
2156         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2157         printing, don't even create the snapshot, since it will be ignored
2158         by the UI process that always creates its own from the WebView (expect for IOS platform)
2159         * WebKitTestRunner/TestInvocation.cpp:
2160         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2161         received from the web process if any when comparing pixel
2162         results. Now we only receive a snapshot from the web process in
2163         case of printing, or when platform is IOS. Otherwhise, generate
2164         the snapshot from the WebView as usual.
2165         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2166         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2167         is created by the caller now, but the CG implementation needs to
2168         know if it's a Web or UI process snapshot.
2169         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2170         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2171         cairo surface for the given image.
2172         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2173         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2174         CGContext for the given image.
2175
2176 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2177
2178         Create a font which can be used for testing font features
2179         https://bugs.webkit.org/show_bug.cgi?id=149237
2180
2181         Reviewed by Simon Fraser.
2182
2183         This patch adds a new project in the Tools/ directory which generates a font which can
2184         be used for testing font features. This is a standalone project consisting of two files:
2185         1. A file which actually generates the byte vector representing the font. This file has
2186         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2187         specific, and only relies on the C++ STL.
2188         2. A file with a main() which calls generateFont() and writes out the font, as well as
2189         uses the font to render some demonstration text into a .png file. This file is platform
2190         specific.
2191
2192         The font itself only supports the following characters:
2193         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2194         However, the shape of these letters are either an X or a check mark.
2195
2196         The letter "A" always is a check mark.
2197         The letter "B" always is an X.
2198         Without any font features turned on, the rest of the letters are shown as X.
2199
2200         Each font feature has an letter associated with it. When the font feature is enabled,
2201         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2202         as a check mark.
2203
2204         Here are the mappings of font features to letters:
2205         liga: C
2206         clig: D
2207         dlig: E
2208         hlig: F
2209         calt: G
2210         subs: H
2211         sups: I
2212         smcp: J
2213         c2sc: K
2214         pcap: L
2215         c2pc: M
2216         unic: N
2217         titl: O
2218         onum: P
2219         pnum: Q
2220         tnum: R
2221         frac: S
2222         afrc: T
2223         ordn: U
2224         zero: V
2225         hist: W
2226         jp78: X
2227         jp83: Y
2228         jp90: Z
2229         jp04: a
2230         smpl: b
2231         trad: c
2232         fwid: d
2233         pwid: e
2234         ruby: f
2235
2236         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2237         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2238         (integralLog2):
2239         (roundDownToPowerOfTwo):
2240         (isFourByteAligned):
2241         (clampTo):
2242         (append32):
2243         (writeCFFEncodedNumber):
2244         (CFFBuilder::CFFBuilder):
2245         (CFFBuilder::takeResult):
2246         (CFFBuilder::moveTo):
2247         (CFFBuilder::lineTo):
2248         (CFFBuilder::curveToCubic):
2249         (CFFBuilder::closePath):
2250         (CFFBuilder::writePoint):
2251         (generateBoxCharString):
2252         (generateCheckCharString):
2253         (generateXCharString):
2254         (charStringForGlyph):
2255         (Generator::generate):
2256         (Generator::Placeholder::Placeholder):
2257         (Generator::Placeholder::populate):
2258         (Generator::Placeholder::~Placeholder):
2259         (Generator::placeholder):
2260         (Generator::append16):
2261         (Generator::append32):
2262         (Generator::append32BitCode):
2263         (Generator::overwrite16):
2264         (Generator::overwrite32):
2265         (Generator::appendCFFTable):
2266         (Generator::appendSubstitutionSubtable):
2267         (Generator::appendScriptSubtable):
2268         (Generator::appendGSUBTable):
2269         (Generator::appendOS2Table):
2270         (Generator::appendFormat12CMAPTable):
2271         (Generator::appendFormat4CMAPTable):
2272         (Generator::appendCMAPTable):
2273         (Generator::appendHEADTable):
2274         (Generator::appendHHEATable):
2275         (Generator::appendHMTXTable):
2276         (Generator::appendMAXPTable):
2277         (Generator::appendNAMETable):
2278         (Generator::appendPOSTTable):
2279         (Generator::calculateChecksum):
2280         (Generator::appendTable):
2281         (generateFont):
2282         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
2283         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
2284         (drawTextWithFeature):
2285         (main):
2286
2287 2015-09-16  Commit Queue  <commit-queue@webkit.org>
2288
2289         Unreviewed, rolling out r189875 and r189878.
2290         https://bugs.webkit.org/show_bug.cgi?id=149235
2291
2292         cygwin cmake build not ready yet (Requested by alexchristensen
2293         on #webkit).
2294
2295         Reverted changesets:
2296
2297         "Switch AppleWin build to use CMake"
2298         https://bugs.webkit.org/show_bug.cgi?id=149163
2299         http://trac.webkit.org/changeset/189875
2300
2301         "Cygwin build fix after r189875"
2302         http://trac.webkit.org/changeset/189878
2303
2304 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2305
2306         Cygwin build fix after r189875
2307
2308         * Scripts/build-webkit:
2309         * Scripts/webkitdirs.pm:
2310         (jhbuildWrapperPrefixIfNeeded):
2311         (generateBuildSystemFromCMakeProject):
2312         Make things work with cygwin and cmake.
2313
2314 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2315
2316         Switch AppleWin build to use CMake
2317         https://bugs.webkit.org/show_bug.cgi?id=149163
2318
2319         Reviewed by Brent Fulgham.
2320
2321         * Scripts/build-webkit:
2322         Build with CMake.
2323         * Scripts/run-api-tests:
2324         (runTest):
2325         (listAllTests):
2326         (prepareEnvironmentForRunningTestTool):
2327         (testToolPaths):
2328         (testToolPath): Deleted.
2329         Run the API tests as separate executables on Windows.
2330         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2331
2332 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
2333
2334         Add newer build.webkit.org pages to robots.txt
2335         https://bugs.webkit.org/show_bug.cgi?id=149219
2336
2337         Reviewed by Darin Adler.
2338
2339         Indexing bot watcher's dashboard can't be good.
2340
2341         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
2342
2343 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2344
2345         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
2346
2347         * BuildSlaveSupport/built-product-archive:
2348         (unzipArchive):
2349
2350 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2351
2352         [EFL] Fix the help message of separated web process option of MiniBrowser
2353         https://bugs.webkit.org/show_bug.cgi?id=149212
2354
2355         Reviewed by Gyuyoung Kim.
2356
2357         * MiniBrowser/efl/main.c:
2358
2359 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2360
2361         Fix python syntax after r189851.
2362
2363         * BuildSlaveSupport/built-product-archive:
2364         (unzipArchive):
2365         For loops need a colon.
2366
2367 2015-09-15  Alex Christensen  <achristensen@webkit.org>
2368
2369         Fix Windows test bots after changing to non-cygwin build
2370         https://bugs.webkit.org/show_bug.cgi?id=149196
2371
2372         Reviewed by Daniel Bates.
2373
2374         * BuildSlaveSupport/built-product-archive:
2375         (unzipArchive):
2376         Using different versions of python makes what I think is https://bugs.python.org/issue15795
2377         prevent us from executing files from the archive on the test bots.
2378
2379 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
2380
2381         Add ShadowRoot interface and Element.prototype.attachShadow
2382         https://bugs.webkit.org/show_bug.cgi?id=149187
2383
2384         Reviewed by Antti Koivisto.
2385
2386         * Scripts/webkitperl/FeatureList.pm:
2387
2388 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
2389
2390         Appscale queue status json output lacks bots
2391         https://bugs.webkit.org/show_bug.cgi?id=149194
2392         <rdar://problem/22171089>
2393
2394         Reviewed by Alexey Proskuryakov.
2395
2396         * QueueStatusServer/handlers/queuestatusjson.py:
2397         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
2398         * QueueStatusServer/index.yaml: Index according to appscale requirements.
2399
2400 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
2401
2402         [Win] Provide a means for viewing the layer tree
2403         https://bugs.webkit.org/show_bug.cgi?id=149165
2404
2405         Reviewed by Simon Fraser.
2406
2407         Update MiniBrowser with a new Debug menu option that will
2408         dump the current layer tree to the debug console.
2409         
2410         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
2411         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
2412         * MiniBrowser/win/Common.cpp:
2413         (WndProc): Add handler for 'Print Layer Tree' menu option.
2414         * MiniBrowser/win/MiniBrowser.cpp:
2415         (MiniBrowser::printLayerTree): Added Handler.
2416         * MiniBrowser/win/MiniBrowser.h:
2417
2418 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2419
2420         WebKitTestRunner declarative language setting is broken for iOS
2421         https://bugs.webkit.org/show_bug.cgi?id=149119
2422
2423         Unreviewed.
2424
2425         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2426         lost in the final version which got committed. This simply implements the existing
2427         OS X behavior on iOS.
2428
2429         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2430         (WTR::InjectedBundle::platformInitialize):
2431
2432 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2433
2434         Unreviewed, add myself to committers list.
2435
2436         * Scripts/webkitpy/common/config/contributors.json:
2437
2438 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2439
2440         [Cocoa] Allow testing with the system language
2441         https://bugs.webkit.org/show_bug.cgi?id=148671
2442
2443         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2444
2445         React to tests marked with language=lang1,lang2,etc in their header.
2446         Once this information is parsed, pass it to
2447         WKContextConfigurationSetOverrideLanguages().
2448
2449         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2450         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2451         list.
2452         * WebKitTestRunner/TestController.cpp:
2453         (WTR::TestController::createWebViewWithOptions): Call
2454         WKContextConfigurationSetOverrideLanguages().
2455         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2456         * WebKitTestRunner/TestOptions.h:
2457         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2458         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2459         option to restart the web process.
2460         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2461         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2462
2463 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2464
2465         [WKTR] Allow changing the WKContextConfiguration between successive tests
2466         https://bugs.webkit.org/show_bug.cgi?id=148833
2467
2468         Reviewed by Tim Horton.
2469
2470         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2471         However, there are certain tests which require specifying options in this object. This patch makes
2472         our existing code for recreating the test runner web view also recreate the WKContext.
2473
2474         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2475         class.
2476
2477         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2478         * WebKitTestRunner/PlatformWebView.h:
2479         (WTR::PlatformWebView::options):
2480         * WebKitTestRunner/TestController.cpp:
2481         (WTR::TestController::initialize):
2482         (WTR::TestController::generateContextConfiguration):
2483         (WTR::TestController::generatePageConfiguration):
2484         (WTR::TestController::createWebViewWithOptions):
2485         (WTR::TestController::ensureViewSupportsOptionsForTest):
2486         (WTR::updateContextConfigurationOptionsFromTestHeader):
2487         (WTR::TestController::contextConfigurationOptionsForTest):
2488         (WTR::TestController::platformCreateWebView):
2489         (WTR::TestController::platformCreateOtherPage):
2490         (WTR::updateViewOptionsFromTestHeader): Deleted.
2491         (WTR::TestController::viewOptionsForTest): Deleted.
2492         * WebKitTestRunner/TestController.h:
2493         (WTR::TestController::injectedBundlePath):
2494         (WTR::TestController::testPluginDirectory):
2495         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2496         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2497         (WTR::TestController::platformCreateWebView):
2498         (WTR::TestController::platformCreateOtherPage):
2499         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2500         (WTR::PlatformWebView::PlatformWebView):
2501         (WTR::PlatformWebView::viewSupportsOptions):
2502         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2503         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2504         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2505         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2506         (WTR::PlatformWebView::PlatformWebView):
2507         (WTR::PlatformWebView::viewSupportsOptions):
2508         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2509         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2510         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2511         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2512         (WTR::PlatformWebView::PlatformWebView):
2513         (WTR::PlatformWebView::viewSupportsOptions):
2514         * WebKitTestRunner/ios/TestControllerIOS.mm:
2515         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2516         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2517         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2518         (WTR::PlatformWebView::PlatformWebView):
2519         (WTR::PlatformWebView::viewSupportsOptions):
2520         * WebKitTestRunner/mac/TestControllerMac.mm:
2521         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2522         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2523
2524 2015-09-11  Michael Saboff  <msaboff@apple.com>
2525
2526         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2527         https://bugs.webkit.org/show_bug.cgi?id=149083
2528
2529         Reviewed by Alexey Proskuryakov.
2530
2531         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2532
2533         * DumpRenderTree/mac/LayoutTestHelper.m:
2534         (colorProfileURLForDisplay):
2535
2536 2015-09-11  Saam barati  <sbarati@apple.com>
2537
2538         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2539         https://bugs.webkit.org/show_bug.cgi?id=149058
2540
2541         Reviewed by Geoffrey Garen.
2542
2543         * Scripts/run-jsc-stress-tests:
2544
2545 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2546
2547         Unreviewed, rolling out r189595.
2548         https://bugs.webkit.org/show_bug.cgi?id=149052
2549
2550         The tests still fail (Requested by ap on #webkit).
2551
2552         Reverted changeset:
2553
2554         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2555         error -1"
2556         https://bugs.webkit.org/show_bug.cgi?id=142929
2557         http://trac.webkit.org/changeset/189595
2558
2559 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2560
2561         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2562         https://bugs.webkit.org/show_bug.cgi?id=142929
2563
2564         Reviewed by Brent Fulgham.
2565
2566         Silence the logging. We'll track fixing the root cause in Radar.
2567
2568         * Scripts/webkitpy/port/mac.py:
2569         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2570
2571         * Scripts/webkitpy/port/win.py:
2572         (WinPort.logging_patterns_to_strip): Added.
2573
2574 2015-09-09  Andy Estes  <aestes@apple.com>
2575
2576         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2577         https://bugs.webkit.org/show_bug.cgi?id=149022
2578
2579         Reviewed by Daniel Bates.
2580
2581         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2582         did not account for this.
2583
2584         * Scripts/webkitpy/xcode/simulator.py:
2585         (Simulator): Optionally matched a revision at the end of a runtime version number.
2586         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2587
2588 2015-09-09  Andy Estes  <aestes@apple.com>
2589
2590         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2591         https://bugs.webkit.org/show_bug.cgi?id=149029
2592         <rdar://problem/22432624>
2593
2594         Reviewed by Daniel Bates.
2595
2596         * Scripts/webkitpy/xcode/simulator.py:
2597         (Simulator): Taught to parse tvOS runtimes.
2598         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2599
2600 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2601
2602         Fix bit rot on bot watcher's dashboard page
2603         https://bugs.webkit.org/show_bug.cgi?id=149012
2604
2605         Reviewed by Tim Horton.
2606
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2608         The code path used by the metrics page was trying to add properties to an undefined.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2611         Silence an expection that would occur when the step has no logs. This should never
2612         happen, but it did (perhaps buildbot was misconfigured for a while).
2613
2614 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2615
2616         Update LayoutTestRelay xcconfig file.
2617
2618         Rubber-stamped by Dan Bernstein.
2619
2620         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2621
2622 2015-09-09  Saam barati  <sbarati@apple.com>
2623
2624         DFG should have a debugging option that runs a phase that flushes all locals
2625         https://bugs.webkit.org/show_bug.cgi?id=148916
2626
2627         Reviewed by Filip Pizlo.
2628
2629         * Scripts/run-jsc-stress-tests:
2630
2631 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2632
2633         Unreviewed, rolling out r189530 and r189534.
2634         https://bugs.webkit.org/show_bug.cgi?id=148996
2635
2636         Caused assertion failures on Yosemite (Requested by litherum
2637         on #webkit).
2638
2639         Reverted changesets:
2640
2641         "[WKTR] Allow changing the WKContextConfiguration between
2642         successive tests"
2643         https://bugs.webkit.org/show_bug.cgi?id=148833
2644         http://trac.webkit.org/changeset/189530
2645
2646         "[Cocoa] Fix the tests after r189530"
2647         http://trac.webkit.org/changeset/189534
2648
2649 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2650
2651         [Cocoa] Fix the tests after r189530
2652
2653         Unreviewed.
2654
2655         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2656         (WTR::initializeWebViewConfiguration):
2657
2658 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2659
2660         [WKTR] Allow changing the WKContextConfiguration between successive tests
2661         https://bugs.webkit.org/show_bug.cgi?id=148833
2662
2663         Reviewed by Tim Horton.
2664
2665         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2666         However, there are certain tests which require specifying options in this object. This patch makes
2667         our existing code for recreating the test runner web view also recreate the WKContext.
2668
2669         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2670         class.
2671
2672         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2673         * WebKitTestRunner/PlatformWebView.h:
2674         (WTR::PlatformWebView::options):
2675         * WebKitTestRunner/TestController.cpp:
2676         (WTR::TestController::initialize):
2677         (WTR::TestController::generateContextConfiguration):
2678         (WTR::TestController::generatePageConfiguration):
2679         (WTR::TestController::createWebViewWithOptions):
2680         (WTR::TestController::ensureViewSupportsOptionsForTest):
2681         (WTR::updateContextConfigurationOptionsFromTestHeader):
2682         (WTR::TestController::contextConfigurationOptionsForTest):
2683         (WTR::TestController::platformCreateWebView):
2684         (WTR::TestController::platformCreateOtherPage):
2685         (WTR::updateViewOptionsFromTestHeader): Deleted.
2686         (WTR::TestController::viewOptionsForTest): Deleted.
2687         * WebKitTestRunner/TestController.h:
2688         (WTR::TestController::injectedBundlePath):
2689         (WTR::TestController::testPluginDirectory):
2690         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2691         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2692         (WTR::TestController::platformCreateWebView):
2693         (WTR::TestController::platformCreateOtherPage):
2694         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2695         (WTR::PlatformWebView::PlatformWebView):
2696         (WTR::PlatformWebView::viewSupportsOptions):
2697         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2698         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2699         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2700         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2701         (WTR::PlatformWebView::PlatformWebView):
2702         (WTR::PlatformWebView::viewSupportsOptions):
2703         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2704         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2705         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2706         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2707         (WTR::PlatformWebView::PlatformWebView):
2708         (WTR::PlatformWebView::viewSupportsOptions):
2709         * WebKitTestRunner/ios/TestControllerIOS.mm:
2710         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2711         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2712         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2713         (WTR::PlatformWebView::PlatformWebView):
2714         (WTR::PlatformWebView::viewSupportsOptions):
2715         * WebKitTestRunner/mac/TestControllerMac.mm:
2716         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2717         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2718
2719 2015-09-08  Daniel Bates  <dabates@apple.com>
2720
2721         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2722         https://bugs.webkit.org/show_bug.cgi?id=148980
2723
2724         Reviewed by Alexey Proskuryakov.
2725
2726         Add setting to enable/disable accelerated drawing so as to support testing
2727         this feature in MiniBrowser on Mac.
2728
2729         * MiniBrowser/mac/SettingsController.h:
2730         * MiniBrowser/mac/SettingsController.m:
2731         (-[SettingsController _populateMenu]): Add menu item.
2732         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2733         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2734         (-[SettingsController acceleratedDrawingEnabled]): Added.
2735         * MiniBrowser/mac/WK1BrowserWindowController.m:
2736         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2737         * MiniBrowser/mac/WK2BrowserWindowController.m:
2738         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2739
2740 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2741
2742         Unreviewed. Added myself as a commiter in contributors.json.
2743
2744         * Scripts/webkitpy/common/config/contributors.json:
2745
2746 2015-09-08  Keith Miller  <keith_miller@apple.com>
2747
2748         Unreviewed, added myself to the list of contributors.
2749
2750         * Scripts/webkitpy/common/config/contributors.json:
2751
2752 2015-09-08  Daniel Bates  <dabates@apple.com>
2753
2754         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2755         https://bugs.webkit.org/show_bug.cgi?id=148921
2756
2757         Reviewed by Alexey Proskuryakov.
2758
2759         The ring image is positioned above the platform icon in markup and we specify the CSS
2760         property z-index for the ring image so that it is painted on top of the platform icon
2761         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2762         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2763         property z-index to achieve a similar effect.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2766         (documentReady): Create the platform icon image element before the ring image such that
2767         the ring image is painted on top of the platform icon.
2768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2769         (table.queue-grid td.logo img.ring): Removed property z-index.
2770
2771 2015-09-08  Daniel Bates  <dabates@apple.com>
2772
2773         Dashboard: Remove duplicate gear icon data URLs
2774         https://bugs.webkit.org/show_bug.cgi?id=148920
2775
2776         Reviewed by Alexey Proskuryakov.
2777
2778         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2779         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2780         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2781         as a mask and make use of the CSS background-color to define the fill color for each of these three
2782         states.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2785         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
2786         (.settings:hover): Override CSS background-color for hover state.
2787         (.settings-visible .settings): Override CSS background-color for expanded state.
2788
2789 2015-09-07  Andy Estes  <aestes@apple.com>
2790
2791         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2792         https://bugs.webkit.org/show_bug.cgi?id=148946
2793         <rdar://problem/22603981>
2794
2795         Reviewed by Dan Bernstein.
2796
2797         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2798         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2799
2800 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2801
2802         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2803         https://bugs.webkit.org/show_bug.cgi?id=148927
2804
2805         Reviewed by Csaba Osztrogonác.
2806
2807         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2808         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2809
2810         * WebKitTestRunner/TestController.cpp:
2811         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2812         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2813         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2814
2815 2015-09-07  Andy Estes  <aestes@apple.com>
2816
2817         Fix the Production build after r189455.
2818
2819         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2820         In-App Purchase template instead of the Aggregate template. Whoops.
2821
2822 2015-09-06  Andy Estes  <aestes@apple.com>
2823
2824         WebKit.xcworkspace should be be able to build iOS platforms
2825         https://bugs.webkit.org/show_bug.cgi?id=148881
2826
2827         Reviewed by Daniel Bates.
2828
2829         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2830         for all supported platforms.
2831
2832         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2833         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2834         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2835         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2836
2837 2015-09-06  Andy Estes  <aestes@apple.com>
2838
2839         WebKitTestRunner should build for iOS using the default target
2840         https://bugs.webkit.org/show_bug.cgi?id=148918
2841
2842         Reviewed by Daniel Bates.
2843
2844         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2845         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2846         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2847
2848         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2849         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2850         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2851         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2852         WebKitTestRunner is skipped when installing on iOS.
2853
2854         The target dependency graph now looks like this:
2855
2856             All
2857                 WebKitTestRunnerApp
2858                     WebKitTestRunner (Library)
2859                         WebKitTestRunnerInjectedBundle
2860                             Derived Sources
2861                 WebKitTestRunner
2862                     WebKitTestRunner (Library)
2863                         WebKitTestRunnerInjectedBundle
2864                             Derived Sources
2865
2866         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2867         * Scripts/build-webkittestrunner: Ditto.
2868         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2869         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2870         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2871         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2872         excluded iOS-only files, and skipped installing on iOS.
2873         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2874         excluded Mac-only files, and skipped installing on Mac.
2875         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2876         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2877         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2878         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2879         new configuration files.
2880
2881 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2882
2883         Web Inspector: Improve prepare-ChangeLog for multiple cases
2884         https://bugs.webkit.org/show_bug.cgi?id=148875
2885
2886         Reviewed by Timothy Hatcher.
2887
2888         * Scripts/prepare-ChangeLog:
2889         (get_function_line_ranges_for_javascript):
2890         - We were ignoring everything inside of an anonymous function expression,
2891           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2892           Better handle this by inserting a few tweaks.
2893         - Allow method syntax outside of classes as long as they are at the global level.
2894         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2895
2896         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2897         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2898         (Foo.prototype.method1):
2899         (Foo.prototype.method2):
2900         (Foo.prototype.method3.innerFunction):
2901         (Foo.prototype.method3):
2902         (insideGlobalAnonymousFunctionExpression):
2903         (foo.insideGlobalFunctionExpression):
2904         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2905         (IssueWithMapGetAndSet.prototype.method1):
2906         (IssueWithMapGetAndSet.prototype.method2):
2907         (IssueWithMapGetAndSet.prototype.method3):
2908         (IssueWithMapGetAndSet):
2909
2910 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2911
2912         [ES6] Enable ES6 Module in JSC shell by default
2913         https://bugs.webkit.org/show_bug.cgi?id=148689
2914
2915         Reviewed by Geoffrey Garen.
2916
2917         * Scripts/run-javascriptcore-tests:
2918         (runJSCStressTests):
2919         * Scripts/run-jsc-stress-tests:
2920
2921 2015-09-04  Basile Clement  <basile_clement@apple.com>
2922
2923         Unreviewed, change my email address.
2924
2925         * Scripts/webkitpy/common/config/contributors.json:
2926
2927 2015-09-04  Beth Dakin  <bdakin@apple.com>
2928
2929         Should have a test to make sure links don't navigate after a cancelled force 
2930         click
2931         https://bugs.webkit.org/show_bug.cgi?id=148846
2932
2933         Reviewed by Tim Horton.
2934
2935         New EventSender function for a started then cancelled force click.
2936         * WebKitTestRunner/EventSenderProxy.h:
2937         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2938         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2939         (WTR::EventSendingController::mouseForceClick):
2940         (WTR::EventSendingController::startAndCancelMouseForceClick):
2941         (WTR::EventSendingController::mouseForceDown):
2942         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2943         * WebKitTestRunner/TestController.cpp:
2944         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2945         * WebKitTestRunner/mac/EventSenderProxy.mm:
2946         (WTR::EventSenderProxy::mouseForceClick):
2947         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2948         (WTR::EventSenderProxy::mouseForceDown):
2949         (WTR::EventSenderProxy::mouseMoveTo):
2950
2951 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2952
2953         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2954         https://bugs.webkit.org/show_bug.cgi?id=148830
2955
2956         Reviewed by Beth Dakin.
2957
2958         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2959         (WTR::InjectedBundle::beginTesting):
2960         Make sure that TestRunner callbacks don't leak between tests!
2961
2962 2015-09-04  Anders Carlsson  <andersca@apple.com>
2963
2964         It should be possible to pass relative HTTP test paths to DumpRenderTree
2965         https://bugs.webkit.org/show_bug.cgi?id=148825
2966         <rdar://problem/22583866>
2967
2968         Reviewed by Tim Horton.
2969
2970         Convert the path to an absolute path if needed.
2971
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (computeTestURL):
2974
2975 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2976
2977         Fix Swift unit tests for prepare-ChangeLog.
2978         https://bugs.webkit.org/show_bug.cgi?id=148817
2979
2980         Reviewed by Alexey Proskuryakov.
2981
2982         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2983         Swift unit tests for prepare-ChangeLog.
2984
2985 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2986
2987         Modifications to the webkit-nightly logic.
2988         
2989         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2990         (updateAlertPanel):
2991         * WebKitLauncher/main.m:
2992         (displayErrorAndQuit):
2993
2994 2015-09-04  Beth Dakin  <bdakin@apple.com>
2995
2996         Speculative build fix.
2997
2998         * WebKitTestRunner/mac/EventSenderProxy.mm:
2999
3000 2015-09-04  Brian Burg  <bburg@apple.com>
3001
3002         Web Inspector: InspectorController should support multiple frontend channels
3003         https://bugs.webkit.org/show_bug.cgi?id=148538
3004
3005         Reviewed by Joseph Pecoraro.
3006
3007         InspectorClients must explicitly disconnect their frontend channel(s) from the
3008         inspected page's InspectorController.
3009
3010         To make this possible, DumpRenderTree should not destroy non-primary views until
3011         it has tried to close any abandoned Web Inspector instances. Performing teardown
3012         in the reverse order prevents disconnection of the frontend channel because that
3013         prematurely destroys the inspector frontend client.
3014
3015         * DumpRenderTree/mac/DumpRenderTree.mm:
3016         (runTest):
3017         * DumpRenderTree/win/DumpRenderTree.cpp:
3018         (runTest):
3019
3020 2015-09-04  Beth Dakin  <bdakin@apple.com>
3021
3022         Need to be able to test default behaviors on force click
3023         https://bugs.webkit.org/show_bug.cgi?id=148758
3024
3025         Reviewed by Tim Horton.
3026
3027         This patch adds a new eventSender method to do a full, completed force click, 
3028         and it re-works all of the existing force methods to dispatch their events in 
3029         such a way that they will trigger the NSImmediateAction gesture recognizer. 
3030         To do this, first we need to send the events to the app rather than straight 
3031         to the view, and also needed to tweak some state and send the events in a 
3032         delayed fashion.
3033
3034         New public function mouseForceClick() and private helper functions to make 
3035         NSEvents.
3036         * WebKitTestRunner/EventSenderProxy.h:
3037
3038         New public function mouseForceClick().
3039         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3040         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3041         (WTR::EventSendingController::mouseMoveTo):
3042         (WTR::EventSendingController::mouseForceClick):
3043         (WTR::EventSendingController::mouseForceDown):
3044         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3045         * WebKitTestRunner/TestController.cpp:
3046         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3047
3048         initPressureEventAtLocation needs to take a stageTransition and a window.
3049         * WebKitTestRunner/mac/EventSenderProxy.mm:
3050         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3051         (-[EventSenderSyntheticEvent stageTransition]):
3052         (-[EventSenderSyntheticEvent timestamp]):
3053         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3054         (-[EventSenderSyntheticEvent window]):
3055
3056         In order to enter the gesture recognizer, we need to start with a mouse down 
3057         that has a NSEventMaskPressure modifier.
3058         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3059
3060         This ensures that the events queue properly for the force monitor in AppKit.
3061         (WTR::spinRunLoopForForce):
3062
3063          We need to start the pressure change events with a began.
3064         (WTR::EventSenderProxy::beginPressureEvent):
3065
3066         These functions can be used to create the NSEvent for a pressure change every 
3067         time we need one.
3068         (WTR::EventSenderProxy::pressureChangeEvent):
3069
3070         Send the right series of events to emulate a full, completed force click.
3071         (WTR::EventSenderProxy::mouseForceClick):
3072
3073         Use all of the new things for these existing functions.
3074         (WTR::EventSenderProxy::mouseForceDown):
3075         (WTR::EventSenderProxy::mouseForceUp):
3076         (WTR::EventSenderProxy::mouseForceChanged):
3077
3078         Set NSFakeForceTouchDevice to YES.
3079         * WebKitTestRunner/mac/main.mm:
3080         (setDefaultsToConsistentValuesForTesting):
3081
3082 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3083
3084         prepare-ChangeLog needs to know how to parse Swift files.
3085         https://bugs.webkit.org/show_bug.cgi?id=148784
3086         <rdar://problem/22510062>
3087
3088         Reviewed by Darin Adler.
3089
3090         * Scripts/prepare-ChangeLog:
3091         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
3092         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
3093         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
3094         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3095         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
3096         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
3097         (freeFunction): Ditto.
3098         (MyClass.function): Ditto.
3099         (MyClass.functionWithArgument(_:)): Ditto.
3100         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
3101         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
3102         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
3103         (MyClass.classFunction): Ditto.
3104         (MyClass.readWriteComputedVariable): Ditto.
3105         (MyClass.readOnlyComputedVariable): Ditto.
3106
3107 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
3108
3109         Import css/css-color-3
3110         https://bugs.webkit.org/show_bug.cgi?id=148803
3111
3112         Reviewed by Chris Dumez.
3113
3114         Fixed a bug that the imported reference files used the same extention as tests.
3115         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
3116
3117         * Scripts/webkitpy/w3c/test_importer.py:
3118         (TestImporter.find_importable_tests):
3119
3120 2015-09-03  Commit Queue  <commit-queue@webkit.org>
3121
3122         Unreviewed, rolling out r189338.
3123         https://bugs.webkit.org/show_bug.cgi?id=148785
3124
3125         Caused tons of crashes (Requested by cdumez on #webkit).
3126
3127         Reverted changeset:
3128
3129         "Web Inspector: InspectorController should support multiple
3130         frontend channels"
3131         https://bugs.webkit.org/show_bug.cgi?id=148538
3132         http://trac.webkit.org/changeset/189338
3133
3134 2015-09-03  Brian Burg  <bburg@apple.com>
3135
3136         Web Inspector: InspectorController should support multiple frontend channels
3137         https://bugs.webkit.org/show_bug.cgi?id=148538
3138
3139         Reviewed by Joseph Pecoraro.
3140
3141         InspectorClients must explicitly disconnect their frontend channel(s) from the
3142         inspected page's InspectorController.
3143
3144         To make this possible, DumpRenderTree should not destroy non-primary views until
3145         it has tried to close any abandoned Web Inspector instances. Performing teardown
3146         in the reverse order prevents disconnection of the frontend channel because that
3147         prematurely destroys the inspector frontend client.
3148
3149         * DumpRenderTree/mac/DumpRenderTree.mm:
3150         (runTest):
3151         * DumpRenderTree/win/DumpRenderTree.cpp:
3152         (runTest):
3153
3154 2015-09-03  Timothy Hatcher  <timothy@apple.com>
3155
3156         Update WebKit nightly icon to be more like Safari
3157         https://bugs.webkit.org/show_bug.cgi?id=148768
3158
3159         Reviewed by Joseph Pecoraro.
3160
3161         * WebKitLauncher/webkit.icns:
3162
3163 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
3164
3165         JavaScriptCore should have some ES6 conformance tests
3166         https://bugs.webkit.org/show_bug.cgi?id=148771
3167
3168         Reviewed by Chris Dumez.
3169
3170         * Scripts/run-javascriptcore-tests:
3171         (runJSCStressTests): Added es6 as a test suite.
3172
3173         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
3174
3175         Some of these tests currently fail, so I also added a way to expect
3176         failure for now. We'll migrate failing tests to expected passes as we
3177         fix them.
3178
3179 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3180
3181         Add a test for swipe-start hysteresis
3182         https://bugs.webkit.org/show_bug.cgi?id=148756
3183
3184         Reviewed by Anders Carlsson.
3185
3186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3187         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3188         (WTR::cacheTestRunnerCallback):
3189         (WTR::TestRunner::clearTestRunnerCallbacks):
3190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3191         Make sure that we log if a client tries to install a callback twice
3192         (since we use .add, the second call would not work).
3193
3194         Also, add clearTestRunnerCallbacks so tests can swap out installed
3195         callbacks.
3196
3197 2015-09-03  Anders Carlsson  <andersca@apple.com>
3198
3199         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
3200         https://bugs.webkit.org/show_bug.cgi?id=148746
3201         rdar://problem/22568073
3202
3203         Reviewed by Tim Horton.
3204
3205         * DumpRenderTree/mac/DumpRenderTree.mm:
3206         (computeTestURL):
3207         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
3208
3209         (runTest):
3210         Call computeTestURL.
3211
3212         (testPathFromURL):
3213         Get rid of this; computeTestURL does this for us now.
3214
3215         * Scripts/webkitpy/port/driver.py:
3216         (Driver._command_from_driver_input):
3217         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
3218
3219 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3220
3221         Swipe tests fail on Mavericks
3222         https://bugs.webkit.org/show_bug.cgi?id=148752
3223
3224         Reviewed by Beth Dakin.
3225
3226         * WebKitTestRunner/mac/EventSenderProxy.mm:
3227
3228 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3229
3230         Fix the 32-bit build
3231
3232         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3233         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3234
3235 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3236
3237         Remove some logging that wasn't meant to be in the tree
3238
3239         * WebKitTestRunner/mac/EventSenderProxy.mm:
3240         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3241
3242 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3243
3244         [Mac] Add support for testing swipes
3245         https://bugs.webkit.org/show_bug.cgi?id=148700
3246
3247         Reviewed by Beth Dakin.
3248
3249         * WebKitTestRunner/EventSenderProxy.h:
3250         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3251         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3252         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3253         (WTR::cgEventPhaseFromString):
3254         (WTR::cgEventMomentumPhaseFromString):
3255         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3256         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
3257         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3258         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3259         (WTR::InjectedBundle::didReceiveMessageToPage):
3260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3261         (WTR::TestRunner::installDidBeginSwipeCallback):
3262         (WTR::TestRunner::installWillEndSwipeCallback):
3263         (WTR::TestRunner::installDidEndSwipeCallback):
3264         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
3265         (WTR::TestRunner::callDidBeginSwipeCallback):
3266         (WTR::TestRunner::callWillEndSwipeCallback):
3267         (WTR::TestRunner::callDidEndSwipeCallback):
3268         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
3269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3270         * WebKitTestRunner/TestController.cpp:
3271         (WTR::TestController::createOtherPage):
3272         (WTR::TestController::createWebViewWithOptions):
3273         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3274         (WTR::TestController::didBeginNavigationGesture):
3275         (WTR::TestController::willEndNavigationGesture):
3276         (WTR::TestController::didEndNavigationGesture):
3277         (WTR::TestController::didRemoveNavigationGestureSnapshot):
3278         * WebKitTestRunner/TestController.h:
3279         * WebKitTestRunner/TestInvocation.cpp:
3280         (WTR::TestInvocation::didBeginSwipe):
3281         (WTR::TestInvocation::willEndSwipe):
3282         (WTR::TestInvocation::didEndSwipe):
3283         (WTR::TestInvocation::didRemoveSwipeSnapshot):
3284         * WebKitTestRunner/TestInvocation.h:
3285         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
3286         when the snapshot is removed.
3287
3288         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
3289         mouseScrollBy function.
3290
3291         * WebKitTestRunner/mac/EventSenderProxy.mm:
3292         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3293         (-[EventSenderSyntheticEvent type]):
3294         (-[EventSenderSyntheticEvent subtype]):
3295         (-[EventSenderSyntheticEvent locationInWindow]):
3296         (-[EventSenderSyntheticEvent location]):
3297         (-[EventSenderSyntheticEvent momentumPhase]):
3298         (-[EventSenderSyntheticEvent _isTouchesEnded]):
3299         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3300         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
3301         more adjustable values.
3302
3303         (WTR::EventSenderProxy::mouseForceDown):
3304         (WTR::EventSenderProxy::mouseForceUp):
3305         (WTR::EventSenderProxy::mouseForceChanged):
3306         Adopt EventSenderSyntheticEvent.
3307
3308         (WTR::nsEventPhaseFromCGEventPhase):
3309         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3310         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
3311
3312         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3313         (WTR::PlatformWebView::PlatformWebView):
3314         Enable swipe.
3315
3316 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
3317
3318         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
3319         https://bugs.webkit.org/show_bug.cgi?id=148723
3320
3321         Reviewed by Anders Carlsson.
3322
3323         * WebKitTestRunner/TestController.cpp:
3324         (WTR::testPath):
3325         (WTR::updateViewOptionsFromTestHeader):
3326         (WTR::TestController::viewOptionsForTest):
3327
3328 2015-09-03  Lucas Forschler  <lforschler@apple.com>
3329
3330         Test commit.
3331
3332 2015-09-02  Tim Horton  <timothy_horton@apple.com>
3333
3334         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
3335         https://bugs.webkit.org/show_bug.cgi?id=148693
3336
3337         Reviewed by Anders Carlsson.
3338
3339         * WebKitTestRunner/TestController.cpp:
3340         (WTR::TestController::createOtherPage):
3341         (WTR::TestController::createWebViewWithOptions):
3342
3343 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3344
3345         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
3346         https://bugs.webkit.org/show_bug.cgi?id=148529
3347
3348         Reviewed by Darin Adler.
3349
3350         When there are pending EventSender messages after a test finishes,
3351         they could be processed in the main loop started by the
3352         resetStateToConsistentValues(), but the old EventSender has been
3353         replaced by a new one at that point. The new Eventsender can crash
3354         when processing messages that were sent to the old one. To avoid
3355         this, we return early when receiving an EventSender message and
3356         the TestController state is not RunningTest.
3357
3358         * WebKitTestRunner/TestController.cpp:
3359         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3360         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3361
3362 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3363
3364         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
3365         https://bugs.webkit.org/show_bug.cgi?id=148528
3366
3367         Reviewed by Darin Adler.
3368
3369         Before r188548 resetStateToConsistentValues() was called in
3370         TestController::run(), before tests are run, but now it's called
3371         for every test in TestInvocation::invoke(), after m_status has
3372         changed to RunningTest.
3373
3374         * WebKitTestRunner/TestController.cpp:
3375         (WTR::TestController::resetStateToConsistentValues): Use
3376         TemporaryChange to reset m_state ot its previous value after reset
3377         is done.
3378
3379 2015-08-31  Jason Marcell  <jmarcell@apple.com>
3380
3381         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
3382         that are marked as requiring corresponding tests.
3383         https://bugs.webkit.org/show_bug.cgi?id=148498
3384         <rdar://problem/21555314>
3385
3386         Reviewed by Dan Bernstein and David Kilzer.
3387
3388         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
3389         simulate Git's attribute behevaior.
3390         (main): Added "requiresTests" array to contain files that require tests.
3391         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
3392         section in ChangeLog.
3393         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
3394         however, we check if the file or any containing folder has the given property set to "1" and
3395         return 1 if so; return 0 otherwise.
3396         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
3397         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
3398
3399 2015-08-26  Andy Estes  <aestes@apple.com>
3400
3401         [Content Filtering] Determine navigation and content policy before continuing to filter a load
3402         https://bugs.webkit.org/show_bug.cgi?id=148506
3403
3404         Reviewed by Brady Eidson.
3405
3406         Added download API tests covering every decision and decision point.
3407         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
3408
3409         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
3410         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
3411         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3412         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
3413         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
3414         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
3415         decision and decision point as a bundle parameter.
3416         (+[MockContentFilterEnabler supportsSecureCoding]):
3417         (-[MockContentFilterEnabler copyWithZone:]):
3418         (-[MockContentFilterEnabler initWithCoder:]):
3419         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
3420         (-[MockContentFilterEnabler encodeWithCoder:]):
3421         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
3422         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
3423         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
3424         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
3425         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
3426         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
3427         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
3428         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
3429         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
3430         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
3431         (+[MockContentFilterEnabler supportsSecureCoding]):
3432         (-[MockContentFilterEnabler copyWithZone:]):
3433         (-[MockContentFilterEnabler initWithCoder:]):
3434         (-[MockContentFilterEnabler dealloc]):
3435         (-[MockContentFilterEnabler encodeWithCoder:]):
3436         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
3437         (-[ContentFilteringPlugIn dealloc]): Stop observing.
3438         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
3439         (+[ServerRedirectPlugIn initialize]): Deleted.
3440         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3441         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3442         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
3443         (TEST): Deleted.
3444
3445 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
3446
3447         Skip slow lock tests on Windows/debug
3448         https://bugs.webkit.org/show_bug.cgi?id=148643
3449
3450         Reviewed by Alexey Proskuryakov.
3451
3452         The lock tests simulate a critical section by doing some floating point math, and then either
3453         make those critical sections very long or invoke them many times. This appears to be
3454         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
3455         that kind of computation slow.
3456
3457         These tests are almost as useful in release as they are in debug, so it's probably better to
3458         just skip the in debug on platforms where this causes timeouts.
3459
3460         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3461         (TestWebKitAPI::runLockTest):
3462         (TestWebKitAPI::skipSlow):
3463         (TestWebKitAPI::TEST):
3464
3465 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
3466
3467         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
3468         https://bugs.webkit.org/show_bug.cgi?id=125720
3469
3470         Reviewed by Daniel Bates.
3471
3472         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
3473
3474         * DumpRenderTree/AccessibilityUIElement.cpp:
3475         (pressCallback):
3476         (scrollToMakeVisibleWithSubFocusCallback):
3477         (scrollToGlobalPointCallback):
3478         (scrollToMakeVisibleCallback):
3479         (AccessibilityUIElement::getJSClass):
3480         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3481         (AccessibilityUIElement::scrollToMakeVisible):
3482         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3483         (AccessibilityUIElement::scrollToGlobalPoint):
3484         (AccessibilityUIElement::selectedTextRange):
3485         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3486         (AccessibilityUIElement::AccessibilityUIElement):
3487         (AccessibilityUIElement::mathPrescriptsDescription):
3488         (AccessibilityUIElement::scrollToMakeVisible):
3489         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3490         (AccessibilityUIElement::scrollToGlobalPoint):
3491         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3492         (WTR::AccessibilityUIElement::isTextMarkerValid):
3493         (WTR::AccessibilityUIElement::textMarkerForIndex):
3494         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3495         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3496         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3497         (WTR::AccessibilityUIElement::supportedActions):
3498         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3499         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3500         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3501         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3502         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3503         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3504         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3505         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3506         (WTR::AccessibilityUIElement::selectedTextRange):
3507         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3508         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3509         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3510         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3511         (WTR::AccessibilityUIElement::selectedTextRange):
3512
3513 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3514
3515         Add a mysteriously nonproblematic missing comma.
3516
3517         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3518         (TestExpectationParser._collect_matching_tests):
3519         (TestExpectationParser):
3520
3521 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3522
3523         Remove an old temporary script that has served its purpose
3524
3525         * Scripts/convert-test-expectations: Removed.
3526
3527 2015-08-28  Jer Noble  <jer.noble@apple.com>
3528
3529         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3530         https://bugs.webkit.org/show_bug.cgi?id=148579
3531
3532         Reviewed by Anders Carlsson.
3533
3534         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3535
3536         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3537         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3538
3539         * DumpRenderTree/mac/DumpRenderTree.mm:
3540         (resetWebPreferencesToConsistentValues):
3541         (resetWebViewToConsistentStateBeforeTesting): 
3542         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3543         (WTR::initializeWebViewConfiguration):
3544
3545 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3546
3547         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3548         https://bugs.webkit.org/show_bug.cgi?id=148592
3549
3550         Reviewed by Tim Horton.
3551
3552         * Scripts/webkitpy/port/base.py:
3553         (Port.to.setup_environ_for_server):
3554         (Port.to):
3555         (Port.to._append_value_colon_separated):
3556         (Port.to.show_results_html_file):
3557         * Scripts/webkitpy/port/ios.py:
3558         (IOSSimulatorPort.setup_environ_for_server):