b57e420cbfed1049b991ed2d5a70a04d72b23f8a
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Move Windows build target to Windows 7 (or newer)
4         https://bugs.webkit.org/show_bug.cgi?id=144890
5         <rdar://problem/20707307>
6
7         Reviewed by Anders Carlsson.
8
9         Update linked SDK and minimal Windows level to be compatible with
10         Windows 7 or newer.
11
12         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
13         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
14         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
15         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
16         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
17         * DumpRenderTree/config.h:
18         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
19         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
20         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
21         * WinLauncher/stdafx.h:
22
23 2015-05-11  Commit Queue  <commit-queue@webkit.org>
24
25         Unreviewed, rolling out r184119.
26         https://bugs.webkit.org/show_bug.cgi?id=144888
27
28         broke JSC tests on Apple Windows bots (Requested by kling on
29         #webkit).
30
31         Reverted changeset:
32
33         "Fix run-javascriptcore-tests step on the WinCairo bot"
34         https://bugs.webkit.org/show_bug.cgi?id=144866
35         http://trac.webkit.org/changeset/184119
36
37 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
38
39         run-benchmark should support Dromaeo
40         https://bugs.webkit.org/show_bug.cgi?id=144849
41
42         Reviewed by Chris Dumez.
43
44         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
45         they can take as much as 15 minutes to run each.
46
47         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
48         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
49         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
50         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
51
52 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
53
54         Build fix. jetstream has a local copy, not remote archive.
55
56         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
57
58 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
59
60         run-benchmark should support SunSpider, Kraken and Octane
61         https://bugs.webkit.org/show_bug.cgi?id=144840
62
63         Reviewed by Darin Adler.
64
65         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
66         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
67         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
68         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
69
70         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
71         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
72
73         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
74         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
75
76         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
77         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
78         now has the ability to run an arbitrary "create script".
79
80         * Scripts/run-benchmark:
81         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
82         This also overrides the remote archive URL specified in the plan.
83
84         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
85
86         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
87         JetStreamBenchmarkBuilder.
88
89         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
90         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
91         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
92         _runCreateScript and _applyPatch to clean after themselves.
93         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
94         JetStream, SunSpider, Kraken all use this feature.
95         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
96         the leaf directory name since the latter is not available when a remote ZIP file is used.
97         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
98         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
99         the benchmark name in the patches.
100
101         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
102
103         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
104         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
105         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
106         the browser opens by planName as the plan file no longer contains that.
107
108         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
109         the top directory of JetStream instead of its parent.
110         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
111         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
112         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
113         the top directory of JetStream instead of its parent.
114         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
115         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
116         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
117         done in JetStream.patch.
118         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
119         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
120         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
121         path from the top directory of JetStream as done in JetStream.patch.
122         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
123
124 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
125
126         Fix run-javascriptcore-tests step on the WinCairo bot
127         https://bugs.webkit.org/show_bug.cgi?id=144866
128
129         Reviewed by Darin Adler.
130
131         * Scripts/run-jsc-stress-tests:
132
133 2015-05-11  Alex Christensen  <achristensen@webkit.org>
134
135         [Content Extensions] Support domain-specific rules and exceptions.
136         https://bugs.webkit.org/show_bug.cgi?id=144833
137
138         Reviewed by Darin Adler.
139
140         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
141         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
142         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
143         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
144         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
145         (TestWebKitAPI::mainDocumentRequest):
146         (TestWebKitAPI::subResourceRequest):
147         (TestWebKitAPI::TEST_F):
148         (TestWebKitAPI::checkCompilerError):
149         Added tests for parsing and functionality of if-domain and unless-domain.
150
151 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
152
153         run-benchmark should support Chrome Canary and Firefox Nightly
154         https://bugs.webkit.org/show_bug.cgi?id=144850
155
156         Reviewed by Darin Adler.
157
158         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
159
160         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
161
162         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
163         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
164         (OSXBrowserDriver):
165         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
166         (OSXBrowserDriver.closeBrowsers): Ditto.
167         (OSXBrowserDriver.launchProcess): Ditto.
168         (OSXBrowserDriver.terminateProcesses): Ditto.
169         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
170         (OSXChromeDriver): Removed the unused self.chromePreferences.
171         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
172         (OSXChromeDriver.closeBrowsers): Ditto.
173         (OSXChromeDriver.launchUrl):
174         (OSXChromeCanaryDriver): Added.
175         (OSXChromeCanaryDriver.launchUrl):
176         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
177         (OSXFirefoxDriver): Added.
178         (OSXFirefoxDriver.launchUrl):
179         (OSXFirefoxNightlyDriver): Added.
180         (OSXFirefoxNightlyDriver.launchUrl):
181         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
182         (OSXSafariDriver):
183         (OSXSafariDriver.closeBrowsers):
184
185 2015-05-11  Tim Horton  <timothy_horton@apple.com>
186
187         Page overlay action context override should indicate the source of the request
188         https://bugs.webkit.org/show_bug.cgi?id=144832
189         <rdar://problem/20562594>
190
191         Reviewed by Darin Adler.
192
193         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
194         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
195
196 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
197
198         [GTK] fast/events/page-visibility-transition-test.html is timing out
199         https://bugs.webkit.org/show_bug.cgi?id=114789
200
201         Reviewed by Darin Adler.
202
203         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
204         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
205         requests visibility changes.
206
207 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
208
209         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
210         https://bugs.webkit.org/show_bug.cgi?id=144798
211
212         Reviewed by Darin Adler.
213
214         * efl/install-dependencies:
215
216 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
217
218         Make arguments of run-benchmark more user friendly
219         https://bugs.webkit.org/show_bug.cgi?id=144835
220
221         Reviewed by Darin Adler.
222
223         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
224         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
225         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
226         default values from --platform and --browser as they are required arguments.
227
228         * Scripts/run-benchmark:
229         (main): Made --build-directory optional, and removed default values from --platform and --browser.
230         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
231         are not dynamically obtained via BrowserDriverFactory.
232         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
233         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
234         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
235         run any benchmark in that case.
236         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
237         the specified file isn't a valid relative or an absolute path.
238         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
239         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
240         and browsers.
241         (BrowserDriverFactory.available_browsers): Ditto.
242         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
243         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
244         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
245         browserBuildPath was None.
246         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
247         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
248         so that we can use locally built WebKit to launch Safari.
249
250 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
251
252         Remove the PICTURE_SIZES build flag
253         https://bugs.webkit.org/show_bug.cgi?id=144679
254
255         Reviewed by Benjamin Poulain.
256
257         Removed the PICTURE_SIZES build time flag.
258
259         * Scripts/webkitperl/FeatureList.pm:
260
261 2015-05-09  David Kilzer  <ddkilzer@apple.com>
262
263         Layout tests broke due to unexpected simctl output
264
265         * Scripts/webkitpy/xcode/simulator.py:
266         (Simulator._parse_devices): Handle new Device Pairs header.
267         * Scripts/webkitpy/xcode/simulator_unittest.py:
268         (test_device_pairs): Add unit test for Device Pairs header.
269
270 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
271
272         Remove convenience constructors for TextRun
273         https://bugs.webkit.org/show_bug.cgi?id=144752
274
275         Reviewed by Anders Carlsson.
276
277         Test the StringView which takes a StringImpl*.
278
279         * TestWebKitAPI/Tests/WTF/StringView.cpp:
280         (StringView8Bit): Testing is8Bit() on StringView
281
282 2015-05-07  Sam Weinig  <sam@webkit.org>
283
284         [Content Extensions] Add simple tester that takes an extension and compiles it
285         https://bugs.webkit.org/show_bug.cgi?id=144781
286
287         Reviewed by Dan Bates.
288
289         * ContentExtensionTester: Added.
290         * ContentExtensionTester/Configurations: Added.
291         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
292         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
293         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
294         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
295         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
296         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
297         * ContentExtensionTester/main.m: Added.
298         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
299
300 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
301
302         Build fix.
303
304         Reviewed by Dan Bernstein.
305
306         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
307         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
308         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
309         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
310         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
311         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
312         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
313         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
314
315 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
316
317         [GTK] Some tests fail because they do not assume the popup menu captures click events
318         https://bugs.webkit.org/show_bug.cgi?id=40601
319
320         Reviewed by Carlos Garcia Campos.
321
322         Popdown all attached menus when moving between tests and between each new
323         event sent to the WebView. This prevents context and popup menus from eating
324         events.
325
326         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
327         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
328         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
329         (WTR::dispatchEvent): Popdown all menus between dispatching events.
330         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
331         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
332         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
333         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
334         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
335         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
336         longer in the platform-independent file.
337         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
338
339 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
340
341         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
342         https://bugs.webkit.org/show_bug.cgi?id=144746
343
344         Reviewed by Carlos Garcia Campos.
345
346         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
347
348         * MiniBrowser/gtk/main.c:
349         (main):
350
351 2015-05-08  Commit Queue  <commit-queue@webkit.org>
352
353         Unreviewed, rolling out r183996.
354         https://bugs.webkit.org/show_bug.cgi?id=144806
355
356         ASan detected use-after free (Requested by ap on #webkit).
357
358         Reverted changeset:
359
360         "Remove convenience constructors for TextRun"
361         https://bugs.webkit.org/show_bug.cgi?id=144752
362         http://trac.webkit.org/changeset/183996
363
364 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
365
366         Remove convenience constructors for TextRun
367         https://bugs.webkit.org/show_bug.cgi?id=144752
368
369         Reviewed by Anders Carlsson.
370
371         Test the StringView which takes a StringImpl*.
372
373         * TestWebKitAPI/Tests/WTF/StringView.cpp:
374         (StringView8Bit): Testing is8Bit() on StringView
375
376 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
377
378         [GTK] WTR doesn't correctly handle the Escape key
379         https://bugs.webkit.org/show_bug.cgi?id=144788
380
381         Reviewed by Martin Robinson.
382
383         Correctly handle 0x001B character code in GTK+ event sender to be
384         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
385         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
386         to dismiss popup menus.
387
388         Fixes editing/selection/5354455-1.html.
389
390         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
391         (WTR::getGDKKeySymForKeyRef):
392
393 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
394
395         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
396         https://bugs.webkit.org/show_bug.cgi?id=144748
397
398         Reviewed by Sergio Villar Senin.
399
400         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
401         (testWebKitSettings): Check the new setting is correctly
402         initialized and updated.
403         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
404         (testWebContextSecurityFileXHR): Check XHR to local files is
405         allowed from file URLs after changing the setting.
406         (beforeAll): Add new test.
407
408 2015-05-08  Commit Queue  <commit-queue@webkit.org>
409
410         Unreviewed, rolling out r183945.
411         https://bugs.webkit.org/show_bug.cgi?id=144789
412
413         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
414
415         Reverted changeset:
416
417         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
418         https://bugs.webkit.org/show_bug.cgi?id=144746
419         http://trac.webkit.org/changeset/183945
420
421 2015-05-07  Anders Carlsson  <andersca@apple.com>
422
423         Build fixes.
424
425         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
426         (TestWebKitAPI::TEST):
427         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
428         (TestWebKitAPI::TEST):
429         Add casts.
430
431 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
432
433         GC has trouble with pathologically large array allocations
434         https://bugs.webkit.org/show_bug.cgi?id=144609
435
436         Reviewed by Geoffrey Garen.
437         
438         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
439         and it's a frequently requested feature.
440         
441         Also add the ability to run a test pretending that your system has a particular RAM size.
442         This is useful for GC tests, and the new GC test that I added uses this.
443
444         * Scripts/run-javascriptcore-tests:
445         (runJSCStressTests):
446         * Scripts/run-jsc-stress-tests:
447
448 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
449
450         [EFL] Bump EFL version to 1.14.0
451         https://bugs.webkit.org/show_bug.cgi?id=144743
452
453         Reviewed by Darin Adler.
454
455         Bump EFL and elementary version to 1.14.0 and removed
456         md5sum, because it isn't used at all if hash is present.
457
458         * efl/jhbuild.modules:
459
460 2015-05-07  Saam Barati  <saambarati1@gmail.com>
461
462         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
463         https://bugs.webkit.org/show_bug.cgi?id=144753
464
465         Reviewed by Mark Lam.
466
467         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
468
469 2015-05-07  Beth Dakin  <bdakin@apple.com>
470
471         New force-related DOM events should fire in WK1 views
472         https://bugs.webkit.org/show_bug.cgi?id=144663
473         -and corresponding-
474         rdar://problem/20281886
475
476         Reviewed by Sam Weinig.
477
478         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
479         now. Just send nil. 
480         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
481         (TestWebKitAPI::buildAndPerformTest):
482
483 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
484
485         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
486         https://bugs.webkit.org/show_bug.cgi?id=144746
487
488         Reviewed by Martin Robinson.
489
490         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
491
492         * MiniBrowser/gtk/main.c:
493         (main):
494
495 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
496
497         Revert "Introducing the Platform Abstraction Layer (PAL)"
498         https://bugs.webkit.org/show_bug.cgi?id=144751
499
500         Unreviewed.
501
502         PAL should be a new target inside WebCore, rather than a top-level folder.
503
504         * Scripts/build-webkit: Add it to build-webkit.
505
506 2015-05-07  Ada Chan  <adachan@apple.com>
507
508         Add a test for WKPageCopySessionState() with filtering.
509         https://bugs.webkit.org/show_bug.cgi?id=144666
510
511         Reviewed by Darin Adler.
512
513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
514         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
515         (TestWebKitAPI::didFinishLoadForFrame):
516         (TestWebKitAPI::setPageLoaderClient):
517         (TestWebKitAPI::filterFirstItemCallback):
518         (TestWebKitAPI::filterAllItemsCallback):
519         (TestWebKitAPI::createSessionStates):
520         (TestWebKitAPI::TEST):
521
522 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
523
524         iOS build fix attempt
525
526         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
527
528         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
529
530 2015-05-06  Matt Baker  <mattbaker@apple.com>
531
532         Unreviewed, updated my list of email addresses.
533
534         * Scripts/webkitpy/common/config/contributors.json:
535
536 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
537
538         Do not link tools to WebKit2.framework
539         https://bugs.webkit.org/show_bug.cgi?id=144699
540
541         Unreviewed build fix.
542
543         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
544         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
545         These linked to WebKit2 in two ways, eliminating the other one.
546
547 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
548
549         Introducing the Platform Abstraction Layer (PAL)
550         https://bugs.webkit.org/show_bug.cgi?id=143358
551
552         Reviewed by Simon Fraser.
553
554         * Scripts/build-webkit: Add it to build-webkit.
555
556 2015-05-06  Alex Christensen  <achristensen@webkit.org>
557
558         Fix api tests after r183877.
559
560         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
561         (TestWebKitAPI::TEST_F):
562         Generate all DFAs before compiling them.
563
564 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
565
566         Do not link tools to WebKit2.framework
567         https://bugs.webkit.org/show_bug.cgi?id=144699
568
569         Reviewed by Tim Horton.
570
571         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
573         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
574
575 2015-05-06  Alex Christensen  <achristensen@webkit.org>
576
577         [Content Extensions] Test splitting NFAs by max NFA size.
578         https://bugs.webkit.org/show_bug.cgi?id=144659
579
580         Reviewed by Darin Adler.
581
582         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
583         (TestWebKitAPI::createNFAs):
584         (TestWebKitAPI::TEST_F):
585         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
586         (TestWebKitAPI::createNFAs):
587
588 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
589
590         Remove the remaining vestiges of SVG feature define
591         https://bugs.webkit.org/show_bug.cgi?id=144655
592
593         Reviewed by Alexey Proskuryakov.
594
595         * Scripts/webkitperl/FeatureList.pm:
596
597 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
598
599         Add a layout mode for computing fixed layout size from a minimum size
600         https://bugs.webkit.org/show_bug.cgi?id=144610
601         <rdar://problem/19790341>
602
603         Reviewed by Simon Fraser.
604
605         * MiniBrowser/mac/BrowserWindow.xib:
606         * MiniBrowser/mac/BrowserWindowController.h:
607         * MiniBrowser/mac/WK1BrowserWindowController.m:
608         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
609         * MiniBrowser/mac/WK2BrowserWindowController.m:
610         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
611         Add a optional toolbar item to toggle a minimum view size of 1024x0.
612
613 2015-05-05  Alex Christensen  <achristensen@webkit.org>
614
615         [Content Extensions] Release input NSString when finished copying it.
616         https://bugs.webkit.org/show_bug.cgi?id=144642
617
618         Reviewed by Brian Weinstein.
619
620         * WebKitTestRunner/mac/TestControllerMac.mm:
621         (WTR::TestController::platformConfigureViewForTest):
622         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
623
624 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
625
626         Unreviewed test fix after r183798.
627
628         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
629         (convertToDRTLabel): Mimic behavior of Mac accessibility output
630         so we can share results.
631
632 2015-05-05  Alex Christensen  <achristensen@webkit.org>
633
634         [Content Extensions] Use less memory to store the json input.
635         https://bugs.webkit.org/show_bug.cgi?id=144604
636
637         Reviewed by Benjamin Poulain.
638
639         * MiniBrowser/mac/ExtensionManagerWindowController.m:
640         (-[ExtensionManagerWindowController add:]):
641         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
642         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
643         * WebKitTestRunner/mac/TestControllerMac.mm:
644         (WTR::TestController::platformConfigureViewForTest):
645
646 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
647
648         Unreviewed. Make myself a WebKit reviewer.
649
650         * Scripts/webkitpy/common/config/contributors.json:
651
652 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
653
654         [GTK] r183783 breaks build
655         https://bugs.webkit.org/show_bug.cgi?id=144632
656
657         Reviewed by Martin Robinson.
658
659         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
660
661         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
662         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
663
664 2015-05-05  Alex Christensen  <achristensen@webkit.org>
665
666         [Content Extensions] Combine NFAs properly and free memory as we compile.
667         https://bugs.webkit.org/show_bug.cgi?id=144485
668
669         Reviewed by Benjamin Poulain.
670
671         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
672         (TestWebKitAPI::TEST_F):
673         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
674         Added tests for deep NFAs.
675
676 2015-05-04  Alex Christensen  <achristensen@webkit.org>
677
678         [Content Extensions] Use less memory when writing byte code to file
679         https://bugs.webkit.org/show_bug.cgi?id=144602
680
681         Reviewed by Darin Adler.
682
683         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
684
685 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
686
687         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
688         https://bugs.webkit.org/show_bug.cgi?id=144541
689
690         Reviewed by Žan Doberšek.
691
692         Add a test case to WorkQueue unit test, to check that sources of
693         asynchronous IO operations running in the WorkQueue thread are
694         dispatched by the WorkQueue main loop.
695
696         * TestWebKitAPI/PlatformGTK.cmake:
697         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
698         (TestWebKitAPI::TEST):
699
700 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
701
702         Correct '--show-webview' option for Tiled Drawing tests
703         https://bugs.webkit.org/show_bug.cgi?id=144621
704
705         Reviewed by Simon Fraser.
706
707         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
708         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
709
710         * WebKitTestRunner/mac/TestControllerMac.mm:
711         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
712         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
713
714 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
715
716         Large array shouldn't be slow
717         https://bugs.webkit.org/show_bug.cgi?id=144617
718
719         Reviewed by Geoffrey Garen.
720         
721         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
722         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
723         long-running. So, hash-map sort of belongs here.
724
725         * Scripts/run-jsc-benchmarks:
726
727 2015-05-04  Doug Russell  <d_russell@apple.com>
728
729         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
730         https://bugs.webkit.org/show_bug.cgi?id=144489
731
732         Reviewed by Chris Fleizach.
733
734         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
735         on the returned control.
736         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
737         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
738         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
739         Add support for setSelectedVisibleTextRange() in accessibility tests.
740
741         * DumpRenderTree/AccessibilityUIElement.cpp:
742         (setSelectedVisibleTextRangeCallback):
743         (AccessibilityUIElement::setSelectedVisibleTextRange):
744         (AccessibilityUIElement::getJSClass):
745         (AccessibilityUIElement::textMarkerForIndex): Deleted.
746         * DumpRenderTree/AccessibilityUIElement.h:
747         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
748         (AccessibilityUIElement::setSelectedVisibleTextRange):
749         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
750         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
751         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
752         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
753         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
754         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
755         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
756         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
757         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
758         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
759         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
760
761 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
762
763         [Win] Implement the "--show-webview" option for Windows
764         https://bugs.webkit.org/show_bug.cgi?id=144589
765
766         Reviewed by Alex Christensen.
767
768         Add another runtime flag (--show-webview) that causes DumpRenderTree
769         to draw its view on-screen, rather than the standard offscreen mode.
770
771         * DumpRenderTree/win/DumpRenderTree.cpp:
772         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
773         (initializeGlobalsFromCommandLineOptions): Recognize the new
774         command-line argument, and set the global 'showWebView' state if
775         appropriate.
776
777 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
778
779         Remove dead code from TestInvocationCairo.cpp
780         https://bugs.webkit.org/show_bug.cgi?id=144564
781
782         Reviewed by Gyuyoung Kim.
783
784         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
785
786         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
787         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
788
789 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
790
791         [GTK] Add libnotify in gtk install-dependencies
792         https://bugs.webkit.org/show_bug.cgi?id=144379
793
794         Reviewed by Csaba Osztrogonác.
795
796         * gtk/install-dependencies:
797
798 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
799
800         check-webkit-style fails due to system pylint
801         https://bugs.webkit.org/show_bug.cgi?id=144360
802
803         Reviewed by Darin Adler.
804
805         Make sure that the directory containing third party autoinstalled modules
806         is at the beginning of the search path, to avoid conflicts with other
807         versions of the same modules installed in the system (e.g. pylint).
808
809         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
810         modules directory to sys.path, instead of appending it.
811
812 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
813
814         Unreviewed, updated my list of email addresses.
815
816         * Scripts/webkitpy/common/config/contributors.json: Updated.
817
818 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
819
820         USE(...) macro should expect unprefixed variables
821         https://bugs.webkit.org/show_bug.cgi?id=144454
822
823         Reviewed by Daniel Bates.
824
825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
826         * DumpRenderTree/config.h: Ditto.
827         * TestWebKitAPI/config.h: Ditto.
828
829 2015-05-01  Basile Clement  <basile_clement@apple.com>
830
831         Unreviewed. Add myself as a commiter in contributors.json.
832
833         * Scripts/webkitpy/common/config/contributors.json:
834
835 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
836
837         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
838         https://bugs.webkit.org/show_bug.cgi?id=144487
839
840         Reviewed by Ryosuke Niwa.
841
842         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
843         (BenchmarkRunner.merge): Fix bug.
844         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
845
846 2015-05-01  Brady Eidson  <beidson@apple.com>
847
848         Add API to disable meta refreshes.
849         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
850
851         Reviewed by Alexey Proskuryakov.
852
853         * DumpRenderTree/mac/DumpRenderTree.mm:
854         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
855
856 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
857
858         Provide a runtime flag to run-webkit-tests that shows the test view
859         https://bugs.webkit.org/show_bug.cgi?id=144079.
860
861         Unreviewed correction to r183651.
862
863         * WebKitTestRunner/TestController.cpp:
864         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
865         flag is included in the options dictionary passed to the PlatformWebView.
866
867 2015-05-01  Antti Koivisto  <antti@apple.com>
868
869         Remove network process load serialization code
870         https://bugs.webkit.org/show_bug.cgi?id=144448
871
872         Reviewed by Alexey Proskuryakov.
873
874         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
875         (WTR::InjectedBundle::beginTesting):
876         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
877         (WTR::TestRunner::setSerializeHTTPLoads):
878         (WTR::TestRunner::dispatchPendingLoadRequests):
879
880 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
881
882         [GTK] Add libhyphen-dev to the build dependencies
883         https://bugs.webkit.org/show_bug.cgi?id=144452
884
885         Reviewed by Martin Robinson.
886
887         * gtk/install-dependencies: Added hyphen as Fedora and Arch
888         dependencies.
889
890 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
891
892         Provide a runtime flag to run-webkit-tests that shows the test view
893         https://bugs.webkit.org/show_bug.cgi?id=144079.
894
895         Reviewed by Dean Jackson.
896
897         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
898         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
899         option:
900         
901         --additional-drt-flag="--show-webview"
902
903         * DumpRenderTree/mac/DumpRenderTree.mm:
904         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
905         '--show-webview' flag.
906         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
907         * WebKitTestRunner/Options.cpp:
908         (WTR::Options::Options):
909         (WTR::handleOptionShowWebView):
910         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
911         * WebKitTestRunner/Options.h:
912         * WebKitTestRunner/TestController.cpp:
913         (WTR::TestController::TestController):
914         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
915         * WebKitTestRunner/TestController.h:
916         (WTR::TestController::shouldShowWebView):
917         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
918         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
919         options dictionary. If it is true, display the web view while running the test.
920
921 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
922
923         r183355 didn't trigger Mac tests
924         https://bugs.webkit.org/show_bug.cgi?id=144464
925
926         Reviewed by Simon Fraser.
927
928         Update badly neglected filters and unit tests.
929
930         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
931         (_should_file_trigger_build):
932         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
933         (ShouldBuildTest):
934         (ShouldBuildTest.test_should_build):
935
936 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
937
938         [GTK] Add libhyphen-dev to the build dependencies
939         https://bugs.webkit.org/show_bug.cgi?id=144452
940
941         Reviewed by Martin Robinson.
942
943         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
944         build dependencies.
945
946 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
947
948         [GTK] Testing dictionaries are not installed automatically
949         https://bugs.webkit.org/show_bug.cgi?id=144460
950
951         Reviewed by Carlos Garcia Campos.
952
953         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
954
955 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
956
957         Fix return code issue, check return code of safari process and dump results to log
958         https://bugs.webkit.org/show_bug.cgi?id=144436
959
960         Reviewed by Ryosuke Niwa.
961
962         * Scripts/run-benchmark:
963         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
964         (BenchmarkRunner.dump): Correct typo.
965         (BenchmarkRunner.wrap): Add results to console.
966         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
967         (OSXSafariDriver.prepareEnv):
968         (OSXSafariDriver.launchUrl):
969         (OSXSafariDriver.closeBrowsers):
970
971 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
972
973         Should no longer need to worry about very old versions of Xcode
974         https://bugs.webkit.org/show_bug.cgi?id=144437
975
976         Reviewed by Dan Bernstein.
977
978         * Scripts/check-for-exit-time-destructors:
979         * Scripts/check-for-global-initializers:
980         * Scripts/check-for-weak-vtables-and-externals:
981
982 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
983
984         REGRESSION(183583): [Mac] make without SDKROOT has issues
985         https://bugs.webkit.org/show_bug.cgi?id=144431
986
987         Reviewed by Dan Bernstein.
988
989         * Makefile:
990         * WebKitTestRunner/Makefile:
991         Assume an empty SDKROOT means an macosx variant, so only
992         enable settings if the SDKROOT is not empty and does not
993         contain "macosx".
994
995 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
996
997         Expand test infrastructure to support scrolling tests
998         https://bugs.webkit.org/show_bug.cgi?id=143684
999         <rdar://problem/20375516>
1000
1001         Reviewed by Simon Fraser.
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
1005         reset before the next test run.
1006         * WebKitTestRunner/TestController.cpp:
1007         (WTR::TestController::resetStateToConsistentValues): Ditto."
1008
1009 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1010
1011         Run javascriptcore tests on Windows without cygwin
1012         https://bugs.webkit.org/show_bug.cgi?id=144419
1013
1014         Reviewed by Brent Fulgham.
1015
1016         * Scripts/run-javascriptcore-tests:
1017         (runJSCStressTests):
1018         Just call ruby, not /usr/bin/env ruby.
1019
1020 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
1021
1022         [GTK] Add --enable-shared option to LLVM to build mesa
1023         https://bugs.webkit.org/show_bug.cgi?id=144393
1024
1025         Reviewed by Martin Robinson.
1026
1027         The updated mesa requires the shared LLVM libraries.
1028         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
1029         to LLVM configure script. It will provide shared libraries in addition to static libraries.
1030
1031         * gtk/jhbuild-optional.modules:
1032
1033 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
1034
1035         [GTK] Add support for automatic hyphenation
1036         https://bugs.webkit.org/show_bug.cgi?id=44478
1037
1038         Reviewed by Carlos Garcia Campos.
1039
1040         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
1041         all systems will use the same dictionaries for testing purposes.
1042
1043 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
1044
1045         Failure when building WebKit for appletvsimulator.
1046         https://bugs.webkit.org/show_bug.cgi?id=144356
1047
1048         Reviewed by Alexey Proskuryakov.
1049
1050         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
1051         make TVOS and WatchOS behave correctly.
1052
1053         * Makefile:
1054         * WebKitTestRunner/Makefile:
1055
1056 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1057
1058         Use-after-free when invalidating WKPageForceRepaint callback
1059         https://bugs.webkit.org/show_bug.cgi?id=144401
1060         rdar://problem/20741111
1061
1062         Reviewed by Tim Horton.
1063
1064         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
1065
1066         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
1067         Don't do anything on error, because the context may be a stale pointer now.
1068
1069 2015-04-29  David Kilzer  <ddkilzer@apple.com>
1070
1071         check-webkit-style: Don't complain about returning value from Objective-C method call in header
1072         <http://webkit.org/b/144395>
1073
1074         Reviewed by Andy Estes.
1075
1076         * Scripts/webkitpy/style/checkers/cpp.py:
1077         (check_spacing): Update regex so 'return' is ignored if it
1078         precedes the whitespace and bracket.  Change category name to
1079         'whitespace/brackets'.  Add period to error message.
1080         (CppChecker): Add 'whitespace/brackets' as a category.
1081         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1082         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
1083         'CppChecker.categories' since that's where the list lives now.
1084         (CppStyleTest.test_spacing_before_brackets): Add tests for
1085         'whitespace/brackets' issues and non-issues.
1086
1087 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1088
1089         Fix WinCairo bot.
1090
1091         * Scripts/webkitdirs.pm:
1092         (determinePassedConfiguration):
1093         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
1094
1095 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
1096
1097         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
1098         https://bugs.webkit.org/show_bug.cgi?id=132159
1099
1100         Reviewed by Darin Adler.
1101
1102         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
1103         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
1104
1105         * DumpRenderTree/mac/DumpRenderTree.mm:
1106         (fontWhitelist):
1107         (adjustFonts):
1108         (createWebViewAndOffscreenWindow):
1109         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1110         (WTR::activateFonts):
1111         * WebKitTestRunner/mac/TestControllerMac.mm:
1112         (WTR::allowedFontFamilySet):
1113         (WTR::systemHiddenFontFamilySet):
1114         (WTR::generateWhitelist):
1115         (WTR::TestController::platformInitializeContext):
1116
1117 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1118
1119         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1120         https://bugs.webkit.org/show_bug.cgi?id=144155
1121
1122         Reviewed by Andreas Kling.
1123
1124         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1125         Make sure that test window is "visible" before each test. While there is no concrete
1126         evidence that this is the problem indeed, the behavior is consistent with what would
1127         happen for an invisible window. Also, WKTR obviously needs to do this to protect
1128         against potential buggy tests that hide the window and don't show it.
1129
1130 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1131
1132         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
1133
1134         Latest changes in the inspector UI made this test fail. We were
1135         relying that the sidebar was always visible and the first 'li'
1136         element of the inspector was the one containing the title. This is
1137         no longer true, so better use document title that is not likely
1138         to change.
1139
1140         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1141         (openRemoteDebuggingSession):
1142
1143 2015-04-29  Andres Gomez  <agomez@igalia.com>
1144
1145         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
1146
1147         * Scripts/webkitpy/common/config/contributors.json:
1148
1149 2015-04-29  Andres Gomez  <agomez@igalia.com>
1150
1151         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
1152
1153         * Scripts/webkitpy/common/config/watchlist:
1154
1155 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
1156
1157         [EFL] Allow to run the tests on the native X display
1158         https://bugs.webkit.org/show_bug.cgi?id=144247
1159
1160         Reviewed by Gyuyoung Kim.
1161
1162         Added the USE_NATIVE_XDISPLAY option for the WTR.
1163         We can select the Xorg driver if environment variable is set up before running the tests.
1164
1165         * Scripts/webkitpy/port/efl.py:
1166         (EflPort._driver_class):
1167
1168 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
1169
1170         [GTK] Add libnotify-dev in gtk install-dependencies
1171         https://bugs.webkit.org/show_bug.cgi?id=144379
1172
1173         Reviewed by Žan Doberšek.
1174
1175         * gtk/install-dependencies:
1176
1177 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
1178
1179         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
1180         https://bugs.webkit.org/show_bug.cgi?id=143001
1181
1182         Reviewed by Gyuyoung Kim.
1183
1184         * WebKitTestRunner/TestController.cpp:
1185         (WTR::shouldUseFixedLayout):
1186
1187 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
1188
1189         Increase stablility of run-benchmark script
1190         https://bugs.webkit.org/show_bug.cgi?id=144361
1191
1192         Reviewed by Ryosuke Niwa.
1193
1194         * Scripts/run-benchmark:
1195         (main):
1196         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
1197         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1198         (GenericBenchmarkBuilder.clean):
1199         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
1200         (BenchmarkRunner.__init__):
1201         (BenchmarkRunner.execute):
1202         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1203         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
1204         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
1205         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
1206         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
1207         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
1208         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
1209         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1210         (HTTPServerDriver.fetchResult):
1211         (HTTPServerDriver):
1212         (HTTPServerDriver.killServer): Add kill server interface.
1213         (HTTPServerDriver.getReturnCode): Add get return code interface.
1214         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
1215         (SimpleHTTPServerDriver.serve):
1216         (SimpleHTTPServerDriver.fetchResult):
1217         (SimpleHTTPServerDriver):
1218         (SimpleHTTPServerDriver.killServer):
1219         (SimpleHTTPServerDriver.getReturnCode):
1220         * Scripts/webkitpy/benchmark_runner/utils.py:
1221         (forceRemove): Provide python version of 'rm -rf'.
1222
1223 2015-04-28  Sam Weinig  <sam@webkit.org>
1224
1225         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
1226         https://bugs.webkit.org/show_bug.cgi?id=144363
1227
1228         Reviewed by Alex Christensen.
1229
1230         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1231         (TestWebKitAPI::createNFAs):
1232         (TestWebKitAPI::TEST_F):
1233         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1234         (TestWebKitAPI::countLiveNodes):
1235         (TestWebKitAPI::createNFAs):
1236         (TestWebKitAPI::buildDFAFromPatterns):
1237         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
1238
1239 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1240
1241         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1242         https://bugs.webkit.org/show_bug.cgi?id=144304
1243
1244         Reviewed by Geoffrey Garen.
1245
1246         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
1247         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1248         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1249
1250 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1251
1252         Unreviewed, rolling out r183514.
1253         https://bugs.webkit.org/show_bug.cgi?id=144359
1254
1255         It broke cloop test bots (Requested by mcatanzaro on #webkit).
1256
1257         Reverted changeset:
1258
1259         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
1260         https://bugs.webkit.org/show_bug.cgi?id=144304
1261         http://trac.webkit.org/changeset/183514
1262
1263 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1264
1265         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1266         https://bugs.webkit.org/show_bug.cgi?id=144304
1267
1268         Reviewed by Geoffrey Garen.
1269
1270         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
1271         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
1272         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1273         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1274
1275 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1276
1277         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
1278         https://bugs.webkit.org/show_bug.cgi?id=144319
1279
1280         Reviewed by Csaba Osztrogonác.
1281
1282         * TestWebKitAPI/CMakeLists.txt:
1283         * TestWebKitAPI/PlatformEfl.cmake:
1284
1285 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
1286
1287         Fix common typo "targetting" => "targeting"
1288         https://bugs.webkit.org/show_bug.cgi?id=144349
1289
1290         Reviewed by Daniel Bates.
1291
1292         * Scripts/webkitdirs.pm:
1293         (execMacWebKitAppForDebugging):
1294
1295 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1296
1297         [GTK][jhbuild] Mesa build failure with llvm 3.6
1298         https://bugs.webkit.org/show_bug.cgi?id=144250
1299
1300         Reviewed by Žan Doberšek.
1301
1302         Bump the version of Mesa to 10.5.4
1303
1304         * gtk/jhbuild.modules:
1305
1306 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
1307
1308         Disable App Nap in WebKitTestRunner UI process
1309         https://bugs.webkit.org/show_bug.cgi?id=144308
1310
1311         Reviewed by Daniel Bates.
1312
1313         * WebKitTestRunner/mac/main.mm:
1314         (disableAppNapInUIProcess):
1315         (main):
1316
1317 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1318
1319         [GTK] Update JHBuild Mesa download directory
1320         https://bugs.webkit.org/show_bug.cgi?id=144318
1321
1322         Update the download directory of Mesa module since the previous one
1323         doesn't exist any more.
1324
1325         Reviewed by Žan Doberšek.
1326
1327         * gtk/jhbuild.modules:
1328
1329 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1330
1331         Unreviewed, rolling out r183477.
1332         https://bugs.webkit.org/show_bug.cgi?id=144334
1333
1334         Roll back the Mesa dependency bump in fear of uncaught
1335         regressions while the testing bots are no-op. (Requested by
1336         zdobersek on #webkit).
1337
1338         Reverted changeset:
1339
1340         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
1341         https://bugs.webkit.org/show_bug.cgi?id=144250
1342         http://trac.webkit.org/changeset/183477
1343
1344 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1345
1346         [GTK][jhbuild] Mesa build failure with llvm 3.6
1347         https://bugs.webkit.org/show_bug.cgi?id=144250
1348
1349         Reviewed by Žan Doberšek.
1350
1351         Bump the version of Mesa to 10.5.4
1352
1353         * gtk/jhbuild.modules:
1354
1355 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
1356
1357         Add '__init__.py' and fix known bug in benchmark runner.
1358         https://bugs.webkit.org/show_bug.cgi?id=144296
1359
1360         Reviewed by Ryosuke Niwa
1361
1362         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
1363         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
1364         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1365         (BenchmarkRunner.__init__):
1366         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
1367         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
1368         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
1369
1370 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1371
1372         More build fix.
1373
1374         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1375         (-[AccessibilityNotificationHandler _notificationReceived:]):
1376         Use -objectForKey:, not array subscript.
1377
1378 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1379
1380         Catch unexpected exits in DumpRenderTree
1381         https://bugs.webkit.org/show_bug.cgi?id=144288
1382
1383         Reviewed by Tim Horton.
1384
1385         * DumpRenderTree/mac/DumpRenderTree.mm:
1386         (atexitFunction):
1387         (DumpRenderTreeMain):
1388
1389 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1390
1391         Build fix
1392
1393         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1394         (-[AccessibilityNotificationHandler _notificationReceived:]):
1395         Use -objectForKey:, not array subscript.
1396
1397 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1398
1399         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1400         https://bugs.webkit.org/show_bug.cgi?id=144155
1401
1402         Reviewed by Tim Horton.
1403
1404         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1405         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
1406         and we clearly don't want App Nap while testing.
1407
1408 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
1409
1410         [CMake] Autogenerate cmakeconfig.h.cmake
1411         https://bugs.webkit.org/show_bug.cgi?id=143997
1412
1413         Reviewed by Csaba Osztrogonác.
1414
1415         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
1416         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
1417
1418 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
1419
1420         REGRESSION(r182879): Images and video can no longer be downloaded
1421         https://bugs.webkit.org/show_bug.cgi?id=144267
1422         <rdar://problem/20702844>
1423
1424         Reviewed by Simon Fraser.
1425
1426         Revise tests to check for proper download menu state.
1427         1. Downloading a loal image should be disabled.
1428         2. Downloading a local media file should be disabled.
1429         3. Downloading non-downloadable media should be disabled.
1430
1431         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1432         (TestWebKitAPI::TEST):
1433
1434 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1435
1436         Merge run-launcher into run-minibrowser
1437         https://bugs.webkit.org/show_bug.cgi?id=141928
1438
1439         Reviewed by Darin Adler.
1440
1441         * Scripts/run-iexploder-tests:
1442         (runSafariWithIExploder):
1443         * Scripts/run-launcher: Removed.
1444         * Scripts/run-minibrowser:
1445         * Scripts/webkitdirs.pm:
1446         (launcherPath):
1447         * Scripts/webkitpy/port/efl.py:
1448         (EflPort.show_results_html_file):
1449         * Scripts/webkitpy/port/efl_unittest.py:
1450         (EflPortTest.test_show_results_html_file):
1451         * Scripts/webkitpy/port/gtk.py:
1452         (GtkPort.print_leaks_summary):
1453         (GtkPort.show_results_html_file):
1454         (GtkPort): Deleted.
1455         * Scripts/webkitpy/port/gtk_unittest.py:
1456         (GtkPortTest.test_show_results_html_file):
1457
1458 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1459
1460         [buildbot] Fix the output of perf-test buildstep on timeout
1461         https://bugs.webkit.org/show_bug.cgi?id=144097
1462
1463         Reviewed by Ryosuke Niwa.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1466         (RunAndUploadPerfTests.getText2):
1467         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1468         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
1469         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1470
1471 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1472
1473         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
1474         https://bugs.webkit.org/show_bug.cgi?id=143874
1475
1476         Reviewed by Gyuyoung Kim.
1477
1478         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
1479
1480 2015-04-24  Philippe Normand  <pnormand@igalia.com>
1481
1482         [JHBuild] Move to upstream OpenWebRTC
1483         https://bugs.webkit.org/show_bug.cgi?id=144145
1484
1485         Reviewed by Carlos Garcia Campos.
1486
1487         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
1488         and add a new simple patch to gst-plugins-base, required for
1489         OpenWebRTC build.
1490         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1491         * gtk/jhbuild.modules: Ditto.
1492         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1493
1494 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1495
1496         [ES6] Implement ES6 template literals
1497         https://bugs.webkit.org/show_bug.cgi?id=142691
1498
1499         Reviewed by Darin Adler.
1500
1501         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1502
1503         * Scripts/webkitperl/FeatureList.pm:
1504
1505 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1506
1507         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
1508         https://bugs.webkit.org/show_bug.cgi?id=144217
1509
1510         Reviewed by Darin Adler.
1511
1512         * WebKitTestRunner/PlatformEfl.cmake:
1513
1514 2015-04-26  Doug Russell  <d_russell@apple.com>
1515
1516         AX: richer text change notifications (142719)
1517         https://bugs.webkit.org/show_bug.cgi?id=142719
1518
1519         Reviewed by Darin Adler.
1520
1521         Richer accessibility value change notifications. Introduce AXTextEditType,
1522         postTextStateChangeNotification and postTextReplacementNotification to give assistive
1523         tech apps more reliable context for responding to changes in web content. Also implement
1524         a mechanism to post value changes in password form fields in coalesced ticks to thwart
1525         analyzing the cadence of changes.
1526
1527         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1528         and an overload of postTextReplacementNotification to give assistive tech apps more
1529         reliable context for responding to changes in web content selection. Also block posting
1530         selection changes on password fields.
1531
1532         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1533         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1534         (-[AccessibilityNotificationHandler stopObserving]):
1535         (-[AccessibilityNotificationHandler _notificationReceived:]):
1536         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1537         (AccessibilityUIElement::removeNotificationListener):
1538         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1539         (-[AccessibilityNotificationHandler _notificationReceived:]):
1540         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1541         (WTR::AccessibilityUIElement::removeNotificationListener):
1542
1543 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
1544
1545         Add myself to contributors.json
1546         https://bugs.webkit.org/show_bug.cgi?id=144204
1547
1548         Reviewed by Darin Adler.
1549
1550         * Scripts/webkitpy/common/config/contributors.json:
1551
1552 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
1553
1554         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1555         https://bugs.webkit.org/show_bug.cgi?id=144182
1556
1557         Reviewed by Simon Fraser.
1558
1559         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1560
1561 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
1562
1563         https://bugs.webkit.org/show_bug.cgi?id=144038
1564
1565         Reviewed by Ryosuke Niwa
1566
1567         Add a script to run Speedometer and JetStream on a browser.
1568
1569         * Scripts/run-benchmark: Wrapper script to run benchmark.
1570         (main):
1571         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1572         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1573         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1574         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1575         (BenchmarkBuilderFactory):
1576         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1577         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1578         (GenericBenchmarkBuilder):
1579         (GenericBenchmarkBuilder.prepare):
1580         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1581         (GenericBenchmarkBuilder._applyPatch):
1582         (GenericBenchmarkBuilder.clean):
1583         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1584         (JetStreamBenchmarkBuilder):
1585         (JetStreamBenchmarkBuilder.prepare):
1586         (JetStreamBenchmarkBuilder._runCreateScript):
1587         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1588         (BenchmarkRunner):
1589         (BenchmarkRunner.__init__):
1590         (BenchmarkRunner.execute):
1591         (BenchmarkRunner.dump):
1592         (BenchmarkRunner.wrap):
1593         (BenchmarkRunner.merge):
1594         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1595         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1596         (BrowserDriver):
1597         (BrowserDriver.prepareEnv):
1598         (BrowserDriver.launchUrl):
1599         (BrowserDriver.closeBrowser):
1600         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1601         (BrowserDriverFactory):
1602         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1603         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1604         (OSXChromeDriver):
1605         (OSXChromeDriver.prepareEnv):
1606         (OSXChromeDriver.launchUrl):
1607         (OSXChromeDriver.closeBrowsers):
1608         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1609         (OSXSafariDriver):
1610         (OSXSafariDriver.prepareEnv):
1611         (OSXSafariDriver.launchUrl):
1612         (OSXSafariDriver.closeBrowsers):
1613         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1614         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1615         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1616         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1617         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1618         (GenericFactory):
1619         (GenericFactory.iterateGetItem):
1620         (GenericFactory.create):
1621         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1622         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1623         (ServerControl):
1624         (ServerControl.render_GET):
1625         (ServerControl.render_POST):
1626         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1627         (HTTPServerDriver):
1628         (HTTPServerDriver.serve):
1629         (HTTPServerDriver.fetchResult):
1630         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1631         (HTTPServerDriverFactory):
1632         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1633         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1634         (SimpleHTTPServerDriver):
1635         (SimpleHTTPServerDriver.depends):
1636         (SimpleHTTPServerDriver.__init__):
1637         (SimpleHTTPServerDriver.serve):
1638         (SimpleHTTPServerDriver.baseUrl):
1639         (SimpleHTTPServerDriver.fetchResult):
1640         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1641         (ModuleNotFoundError):
1642         (loadModule):
1643         (getPathFromProjectRoot):
1644         (loadJSONFromFile):
1645         (TimeoutError):
1646         (timeout):
1647         (timeout.__init__):
1648         (timeout.handle_timeout):
1649         (timeout.__enter__):
1650         (timeout.__exit__):
1651
1652 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1653
1654         Unreviewed, rolling out r183303.
1655         https://bugs.webkit.org/show_bug.cgi?id=144181
1656
1657         Change was incorrect, broke builds (Requested by smfr on
1658         #webkit).
1659
1660         Reverted changeset:
1661
1662         "Fix the build."
1663         http://trac.webkit.org/changeset/183303
1664
1665 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
1666
1667         Fix the build.
1668
1669         * MiniBrowser/mac/WK2BrowserWindowController.m:
1670         (-[WK2BrowserWindowController initWithConfiguration:]):
1671
1672 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1673
1674         Disable ActionMenusPDFTest due to timeout on test bot
1675
1676         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1677         (TestWebKitAPI::TEST):
1678
1679 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1680
1681         Unreviewed, rolling out r183266.
1682         https://bugs.webkit.org/show_bug.cgi?id=144164
1683
1684         Broke 32-bit build and a test. (Requested by ap on #webkit).
1685
1686         Reverted changeset:
1687
1688         "AX: richer text change notifications (142719)"
1689         https://bugs.webkit.org/show_bug.cgi?id=142719
1690         http://trac.webkit.org/changeset/183266
1691
1692 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1693
1694         REGRESSION: WebKit2.ActionMenusTest API test fails
1695         https://bugs.webkit.org/show_bug.cgi?id=144149
1696         <rdar://problem/20677770>
1697
1698         Reviewed by Tim Horton.
1699
1700         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1701         as the 'ActionMenusPDFTest'.
1702         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1703         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1704         to match the hit test on the 'action-menu-target.pdf' test file.
1705
1706 2015-04-24  Daniel Bates  <dabates@apple.com>
1707
1708         Cleanup: Use @memoized for property IOSSimulator.testing_device
1709         https://bugs.webkit.org/show_bug.cgi?id=141715
1710
1711         Reviewed by Darin Adler.
1712
1713         Simplify the caching of the result of IOSSimulator.testing_device
1714         and make the code more readable by making use of the @memoized declarator
1715         instead of explicitly managing a private instance variable,
1716         IOSSimulator._testing_device, for the cached result.
1717
1718         * Scripts/webkitpy/port/ios.py:
1719         (IOSPort.determine_full_port_name):
1720         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1721         (IOSSimulatorPort):
1722         (IOSSimulatorPort.testing_device): No need to cache the created device object in
1723         IOSSimulatorPort._testing_device since we are marking this function @memoized.
1724         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1725         of caching in local variable since we only make use of this value exactly once in this function.
1726         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1727         been used since being added in r178622. So, we can remove this constructor since
1728         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1729
1730 2015-04-24  Anders Carlsson  <andersca@apple.com>
1731
1732         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1733         https://bugs.webkit.org/show_bug.cgi?id=144158
1734
1735         Reviewed by Beth Dakin.
1736
1737         * MiniBrowser/mac/WK2BrowserWindowController.m:
1738         (-[WK2BrowserWindowController initWithConfiguration:]):
1739
1740 2015-04-24  Doug Russell  <d_russell@apple.com>
1741
1742         AX: richer text change notifications (142719)
1743         https://bugs.webkit.org/show_bug.cgi?id=142719
1744
1745         Reviewed by Darin Adler.
1746
1747         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1748
1749         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1750
1751         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1752         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1753         (-[AccessibilityNotificationHandler stopObserving]):
1754         (-[AccessibilityNotificationHandler _notificationReceived:]):
1755         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1756         (AccessibilityUIElement::removeNotificationListener):
1757         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1758         (-[AccessibilityNotificationHandler _notificationReceived:]):
1759         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1760         (WTR::AccessibilityUIElement::removeNotificationListener):
1761
1762 2015-04-24  Darin Adler  <darin@apple.com>
1763
1764         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1765         https://bugs.webkit.org/show_bug.cgi?id=128007
1766
1767         Reviewed by Anders Carlsson.
1768
1769         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1770         * DumpRenderTree/win/UIDelegate.h: Ditto.
1771
1772         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1773         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1774
1775         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1776
1777         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1778         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1779         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1780         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1781         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1782         (WebKitDOMDOMWindowTest::create): Ditto.
1783         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1784         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1785         of smart pointers to DelayedSIgnal objects.
1786         (uriChangedCallback): Ditto.
1787
1788 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1789
1790         [Mac] Unreviewed test fix.
1791         https://bugs.webkit.org/show_bug.cgi?id=144149
1792
1793         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1794         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1795         test.
1796
1797 2015-04-23  Darin Adler  <darin@apple.com>
1798
1799         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1800         https://bugs.webkit.org/show_bug.cgi?id=144090
1801
1802         Reviewed by Anders Carlsson.
1803
1804         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1805
1806 2015-04-23  Michael Saboff  <msaboff@apple.com>
1807
1808         lldb macro btjs sometimes can't get a frame description
1809         https://bugs.webkit.org/show_bug.cgi?id=144130
1810
1811         Reviewed by Filip Pizlo.
1812
1813         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1814         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1815         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1816
1817         * lldb/lldb_webkit.py:
1818         (btjs):
1819
1820 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1821
1822         Use less memory when compiling content extensions.
1823         https://bugs.webkit.org/show_bug.cgi?id=144051
1824
1825         Reviewed by Darin Adler and Benjamin Poulain.
1826
1827         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1828         (TestWebKitAPI::TEST_F):
1829         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1830         (TestWebKitAPI::countLiveNodes):
1831
1832 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1833
1834         [CMake] Clean up JSC JIT options
1835         https://bugs.webkit.org/show_bug.cgi?id=143998
1836
1837         Reviewed by Filip Pizlo.
1838
1839         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1840         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1841
1842 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1843
1844         [Mac] Extend action menus to support PDF
1845         https://bugs.webkit.org/show_bug.cgi?id=143895
1846         <rdar://problem/19003333>
1847
1848         Reviewed by Tim Horton.
1849
1850         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1851         of PDF content works.
1852
1853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1854         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1855         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1856         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1857         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1858         Update to support PDF tests.
1859         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1860         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1861
1862 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1865
1866         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1867         (beforeAll):
1868         (testWebViewAudioOnlyUserMediaPermissionRequests):
1869
1870 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1871
1872         Add myself to watchlist
1873         https://bugs.webkit.org/show_bug.cgi?id=144041
1874
1875         Reviewed by Alex Christensen.
1876
1877         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1878
1879         * Scripts/webkitpy/common/config/watchlist:
1880
1881 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1882
1883         [GTK] MiniBrowser should use NetworkProcess by default
1884         https://bugs.webkit.org/show_bug.cgi?id=143948
1885
1886         Reviewed by Sergio Villar Senin.
1887
1888         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1889         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1890
1891         * MiniBrowser/gtk/main.c:
1892         (main):
1893
1894 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1895
1896         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1897
1898         Unreviewed build fix.
1899
1900         * Scripts/prepare-ChangeLog:
1901         (get_function_line_ranges_for_cpp):
1902         Use grep instead of any to determine if a string is an element of an array.
1903
1904 2015-04-21  Anders Carlsson  <andersca@apple.com>
1905
1906         Fix block signatures
1907         https://bugs.webkit.org/show_bug.cgi?id=144002
1908
1909         Reviewed by Andreas Kling.
1910
1911         * MiniBrowser/mac/WK2BrowserWindowController.m:
1912         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1913
1914 2015-04-21  Philippe Normand  <pnormand@igalia.com>
1915
1916         [GTK] jhbuild should not use a branch for openwebrtc
1917         https://bugs.webkit.org/show_bug.cgi?id=143981
1918
1919         Reviewed by Carlos Garcia Campos.
1920
1921         * gtk/jhbuild.modules:
1922
1923 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
1924
1925         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1926
1927         Unreviewed build fix.
1928
1929         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1930         However, it has been exposed by List::MoreUtils since its inception. This patch uses
1931         the any function exposed by List::MoreUtils for greater compatibility.
1932
1933         * Scripts/prepare-ChangeLog:
1934         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1935         the any function in all of versions of Perl used by our infrastructure.
1936
1937 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1938
1939         Remove unnecessary logs when resetting tests.
1940
1941         * WebKitTestRunner/mac/TestControllerMac.mm:
1942         (WTR::TestController::platformResetPreferencesToConsistentValues):
1943         In r183020 I added some logs when compiling or removing content extensions fails.
1944         We often try to remove a content extension that does not exist, and that is not a problem.
1945
1946 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1947
1948         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1949         https://bugs.webkit.org/show_bug.cgi?id=143897
1950
1951         Reviewed by David Kilzer.
1952
1953         This is a speculative fix that addresses two issues:
1954
1955         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1956         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1957
1958         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1959         Before: (723, 729)
1960         After: (721, 720)
1961
1962         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1963         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1964
1965         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1966         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1967
1968         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1969
1970         2. Creating git diffs from HEAD and not origin/master by default.
1971
1972         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1973         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1974
1975         * Scripts/prepare-ChangeLog:
1976         (originalFile):
1977         Use HEAD instead of origin/master in default Git case.
1978
1979         (generateFunctionLists):
1980         Ensure that the end line is not less than the start line.
1981
1982         (extractLineRangeAfterChange):
1983         Set the end line to the start line if the end line is less than the start line.
1984
1985         (extractLineRangeBeforeChange):
1986         Ditto.
1987
1988 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1989
1990         Suppress warning in prepare-ChangeLog.
1991         https://bugs.webkit.org/show_bug.cgi?id=143882
1992
1993         Reviewed by David Kilzer.
1994
1995         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1996         instead of the deprecated smartmatch operator.
1997
1998         * Scripts/prepare-ChangeLog:
1999         Import the List::Util::any function.
2000
2001         (get_function_line_ranges_for_cpp):
2002         Use the any function instead of smartmatch.
2003
2004 2015-04-20  Anders Carlsson  <andersca@apple.com>
2005
2006         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
2007         https://bugs.webkit.org/show_bug.cgi?id=143966
2008
2009         Reviewed by Dan Bernstein.
2010
2011         * MiniBrowser/mac/WK2BrowserWindowController.m:
2012         (dataTypes):
2013         (-[WK2BrowserWindowController fetchWebsiteData:]):
2014         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2015         (-[WK2BrowserWindowController clearWebsiteData:]):
2016
2017 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2018
2019         Fix content extension test flakiness.
2020         https://bugs.webkit.org/show_bug.cgi?id=143950
2021
2022         Reviewed by Brady Eidson.
2023
2024         * WebKitTestRunner/mac/TestControllerMac.mm:
2025         (WTR::TestController::platformResetPreferencesToConsistentValues):
2026         Remove the TestContentExtensions if it exists.
2027         (WTR::TestController::platformConfigureViewForTest):
2028         Log errors in case there are any.
2029
2030 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2031
2032         Properly report errors from _WKUserContentExtensionStore.
2033         https://bugs.webkit.org/show_bug.cgi?id=143808
2034
2035         Reviewed by Darin Adler.
2036
2037         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2038         (TEST_F):
2039
2040 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2041
2042         Add a rule for NetworkCache to watchlist file
2043         https://bugs.webkit.org/show_bug.cgi?id=143945
2044
2045         Reviewed by Sergio Villar Senin.
2046
2047         And add myself to the list of watchers.
2048
2049         * Scripts/webkitpy/common/config/watchlist:
2050
2051 2015-04-19  Darin Adler  <darin@apple.com>
2052
2053         Update RefPtr documentation and deprecation
2054         https://bugs.webkit.org/show_bug.cgi?id=143936
2055
2056         Reviewed by Andreas Kling.
2057
2058         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
2059
2060 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2061
2062         Introduce bytecode intrinsics
2063         https://bugs.webkit.org/show_bug.cgi?id=143926
2064
2065         Reviewed by Filip Pizlo.
2066
2067         Change cpplint to accept emit_intrinsic_XXX.
2068
2069         * Scripts/webkitpy/style/checkers/cpp.py:
2070         (check_identifier_name_in_declaration):
2071
2072 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
2073
2074         Fix lldb_webkit.py to show StringImpls correctly
2075         https://bugs.webkit.org/show_bug.cgi?id=143920
2076
2077         Reviewed by Andreas Kling.
2078         
2079         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
2080
2081         * lldb/lldb_webkit.py:
2082         (WTFStringImplProvider.is_8bit):
2083
2084 2015-04-17  Daniel Bates  <dabates@apple.com>
2085
2086         Not able to build WebKit against iOS Simulator 8.3 SDK
2087         https://bugs.webkit.org/show_bug.cgi?id=143883
2088
2089         Reviewed by David Kilzer.
2090
2091         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
2092         so that Xcode uses them.
2093
2094         * Scripts/copy-webkitlibraries-to-product-directory:
2095
2096 2015-04-17  Beth Dakin  <bdakin@apple.com>
2097
2098         Force mouse events should go through normal mouse event handling code paths
2099         https://bugs.webkit.org/show_bug.cgi?id=143749
2100         -and corresponding-
2101         rdar://problem/20472895
2102
2103         Reviewed by Dean Jackson.
2104
2105         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2106         Since there is not a way to create an NSEventTypePressure from scratch, we 
2107         subclass NSEvent and override all of the critical methods.
2108
2109         * WebKitTestRunner/EventSenderProxy.h:
2110         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2111         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2112         (WTR::EventSendingController::mouseForceDown):
2113         (WTR::EventSendingController::mouseForceUp):
2114         (WTR::EventSendingController::mouseForceChanged):
2115         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2116         * WebKitTestRunner/TestController.cpp:
2117         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2118         * WebKitTestRunner/mac/EventSenderProxy.mm:
2119         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2120         (-[EventSenderPressureEvent timestamp]):
2121         (-[EventSenderPressureEvent type]):
2122         (-[EventSenderPressureEvent locationInWindow]):
2123         (-[EventSenderPressureEvent location]):
2124         (-[EventSenderPressureEvent stage]):
2125         (-[EventSenderPressureEvent pressure]):
2126         (-[EventSenderPressureEvent phase]):
2127         (-[EventSenderPressureEvent eventNumber]):
2128         (WTR::EventSenderProxy::mouseForceDown):
2129         (WTR::EventSenderProxy::mouseForceUp):
2130         (WTR::EventSenderProxy::mouseForceChanged):
2131
2132 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
2133
2134         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
2135         https://bugs.webkit.org/show_bug.cgi?id=143885
2136
2137         Reviewed by Tim Horton.
2138
2139         Fixed a case where we have two builds with the same revision(s). An in order build
2140         is one for which the revision is strictly higher.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2143         (BuildbotQueue.prototype._checkForInOrderResult):
2144         (BuildbotQueue.prototype.compareIterationsByRevisions):
2145
2146 2015-04-17  Commit Queue  <commit-queue@webkit.org>
2147
2148         Unreviewed, rolling out r182912 and r182920.
2149         https://bugs.webkit.org/show_bug.cgi?id=143881
2150
2151         Build breakage in some configurations (Requested by ap on
2152         #webkit).
2153
2154         Reverted changesets:
2155
2156         "Force mouse events should go through normal mouse event
2157         handling code paths"
2158         https://bugs.webkit.org/show_bug.cgi?id=143749
2159         http://trac.webkit.org/changeset/182912
2160
2161         http://trac.webkit.org/changeset/182920
2162
2163 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
2164
2165         [GTK] One more unreviewed fix after r182882.
2166
2167         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
2168
2169 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
2170
2171         [GTK] Unreviewed speculative clean build fix after r182882.
2172
2173         TestWebKitAPI's forwarding header generator depended on WeKit2's
2174         which generated SOUP related forwarding headers too.
2175
2176         This dependency isn't necessary and was removed by r182882 to make
2177         forwarding header generators parallelizable. But in this case
2178         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
2179         should generate SOUP related forwarding headers too similar to EFL.
2180
2181         * TestWebKitAPI/PlatformGTK.cmake:
2182         * WebKitTestRunner/PlatformGTK.cmake:
2183
2184 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2185
2186         [SOUP] Redirect to non HTTP destination is broken
2187         https://bugs.webkit.org/show_bug.cgi?id=143866
2188
2189         Reviewed by Sergio Villar Senin.
2190
2191         Add a unit test to check that redirect to a data URI works.
2192
2193         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2194         (testRedirectToDataURI):
2195         (serverCallback):
2196         (beforeAll):
2197
2198 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2199
2200         Changes method of quitting iOS Simulator to be more correct.
2201         https://bugs.webkit.org/show_bug.cgi?id=143847
2202         <rdar://problem/20530344>
2203
2204         Reviewed by Darin Adler.
2205
2206         Fixes by addressing the app by ID rather than by name.
2207
2208         * Scripts/webkitdirs.pm:
2209         (quitIOSSimulator):
2210         * Scripts/webkitpy/port/ios.py:
2211         (IOSSimulatorPort.check_sys_deps):
2212
2213 2015-04-16  Anders Carlsson  <andersca@apple.com>
2214
2215         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
2216         https://bugs.webkit.org/show_bug.cgi?id=143844
2217
2218         Reviewed by Dan Bernstein.
2219
2220         * MiniBrowser/mac/AppDelegate.m:
2221         (-[BrowserAppDelegate newPrivateWindow:]):
2222         * MiniBrowser/mac/WK2BrowserWindowController.m:
2223         (-[WK2BrowserWindowController initWithConfiguration:]):
2224         (-[WK2BrowserWindowController fetchWebsiteData:]):
2225         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2226         (-[WK2BrowserWindowController clearWebsiteData:]):
2227
2228 2015-04-16  Alex Christensen  <achristensen@webkit.org>
2229
2230         32-bit build fix.
2231
2232         * WebKitTestRunner/mac/TestControllerMac.mm:
2233         (WTR::TestController::platformResetPreferencesToConsistentValues):
2234         (WTR::TestController::platformConfigureViewForTest):
2235         Added WK_API_ENABLED.
2236
2237 2015-04-16  Alex Christensen  <achristensen@webkit.org>
2238
2239         Removed unused WKUserContentFilterRef.
2240         https://bugs.webkit.org/show_bug.cgi?id=143852
2241
2242         Reviewed by Sam Weinig.
2243
2244         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2245         * WebKitTestRunner/mac/TestControllerMac.mm:
2246         (WTR::TestController::platformResetPreferencesToConsistentValues):
2247         (WTR::TestController::platformConfigureViewForTest):
2248
2249 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2250
2251         Unreviewed. Adding myself as a commiter in contributers.json.
2252
2253         * Scripts/webkitpy/common/config/contributors.json:
2254
2255 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
2256
2257         It is very hard to attach a debugger to WebProcess to debug tests
2258         https://bugs.webkit.org/show_bug.cgi?id=143837
2259
2260         Reviewed by Chris Dumez.
2261
2262         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
2263         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
2264
2265         Now it disables all timeouts in tools, as is best for debugging tests.
2266
2267         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
2268         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
2269
2270         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
2271         now has the same functionality.
2272
2273 2015-04-16  Beth Dakin  <bdakin@apple.com>
2274
2275         Force mouse events should go through normal mouse event handling code paths
2276         https://bugs.webkit.org/show_bug.cgi?id=143749
2277         -and corresponding-
2278         rdar://problem/20472895
2279
2280         Reviewed by Dean Jackson.
2281
2282         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2283         Since there is not a way to create an NSEventTypePressure from scratch, we 
2284         subclass NSEvent and override all of the critical methods.
2285
2286         * WebKitTestRunner/EventSenderProxy.h:
2287         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2288         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2289         (WTR::EventSendingController::mouseForceDown):
2290         (WTR::EventSendingController::mouseForceUp):
2291         (WTR::EventSendingController::mouseForceChanged):
2292         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2293         * WebKitTestRunner/TestController.cpp:
2294         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2295         * WebKitTestRunner/mac/EventSenderProxy.mm:
2296         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2297         (-[EventSenderPressureEvent timestamp]):
2298         (-[EventSenderPressureEvent type]):
2299         (-[EventSenderPressureEvent locationInWindow]):
2300         (-[EventSenderPressureEvent location]):
2301         (-[EventSenderPressureEvent stage]):
2302         (-[EventSenderPressureEvent pressure]):
2303         (-[EventSenderPressureEvent phase]):
2304         (-[EventSenderPressureEvent eventNumber]):
2305         (WTR::EventSenderProxy::mouseForceDown):
2306         (WTR::EventSenderProxy::mouseForceUp):
2307         (WTR::EventSenderProxy::mouseForceChanged):
2308
2309 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2310
2311         [EFL] Bump LLVM to version 3.6.0 on X86_64
2312         https://bugs.webkit.org/show_bug.cgi?id=143604
2313
2314         Reviewed by Gyuyoung Kim.
2315
2316         * efl/jhbuild.modules:
2317         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
2318         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
2319         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
2320         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
2321
2322 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2323
2324         [EFL] Remove an unnecessary workaround from jhbuildrc
2325         https://bugs.webkit.org/show_bug.cgi?id=143823
2326
2327         Reviewed by Gyuyoung Kim.
2328
2329         * efl/jhbuildrc:
2330
2331 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2332
2333         [GTK] Run forwarding headers generator unconditionally
2334         https://bugs.webkit.org/show_bug.cgi?id=143819
2335
2336         Reviewed by Carlos Garcia Campos.
2337
2338         * TestWebKitAPI/PlatformGTK.cmake:
2339         * WebKitTestRunner/PlatformGTK.cmake:
2340
2341 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2342
2343         [EFL] Add gnutls to jhbuild.module
2344         https://bugs.webkit.org/show_bug.cgi?id=143777
2345
2346         Reviewed by Csaba Osztrogonác.
2347
2348         EFL port has required at least 3.0.0 version of gnutls since r176712.
2349         However some old linux distributions don't support 3.0.0 version. Besides
2350         other projects sometimes need to use lower version of gnutls.
2351
2352         This patch supports to download gnutls through jhbuild, and use it.
2353
2354         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
2355         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
2356
2357 2015-04-15  Mark Lam  <mark.lam@apple.com>
2358
2359         Remove obsolete VMInspector debugging tool.
2360         https://bugs.webkit.org/show_bug.cgi?id=143798
2361
2362         Reviewed by Michael Saboff.
2363
2364         * TestWebKitAPI/CMakeLists.txt:
2365         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2366         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2368         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
2369
2370 2015-04-15  Jer Noble  <jer.noble@apple.com>
2371
2372         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
2373
2374         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2375
2376 2015-04-15  Jer Noble  <jer.noble@apple.com>
2377
2378         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
2379
2380         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2381         (TestWebKitAPI::TEST_F):
2382
2383 2015-04-15  Chris Dumez  <cdumez@apple.com>
2384
2385         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
2386         https://bugs.webkit.org/show_bug.cgi?id=143779
2387
2388         Reviewed by Brent Fulgham.
2389
2390         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
2391         similarly to what is done on Mac / WK1. Without this, PageCache could
2392         stay enabled after page cache tests and cause weird behaviors.
2393
2394         * DumpRenderTree/win/DumpRenderTree.cpp:
2395         (resetWebPreferencesToConsistentValues):
2396
2397 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
2398
2399         Re-enable custom dilation for antialiased fonts
2400         https://bugs.webkit.org/show_bug.cgi?id=143738
2401
2402         Reviewed by Tim Horton.
2403         
2404         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
2405         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
2406         a private WebKit pref. This pref defaults to YES, enabling the feature by default
2407         in WK1 as we do for WK2.
2408
2409         * DumpRenderTree/mac/DumpRenderTree.mm:
2410         (resetWebPreferencesToConsistentValues):
2411         * WebKitTestRunner/TestController.cpp:
2412         (WTR::TestController::resetPreferencesToConsistentValues):
2413
2414 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
2415
2416         Correct layering violation in DumpRenderTree Build
2417         https://bugs.webkit.org/show_bug.cgi?id=143732
2418
2419         Reviewed by Simon Fraser.
2420
2421         Correct a layering violation in DumpRenderTree by calling functions on the
2422         WebCoreTestSupport library, rather than attempting to work with WebCore
2423         types directly.
2424
2425         * DumpRenderTree/mac/EventSendingController.mm:
2426         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
2427         than WebCore itself.,
2428         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
2429
2430 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
2431
2432         Add a conservative DFA minimizer for the content extension matcher
2433         https://bugs.webkit.org/show_bug.cgi?id=143501
2434
2435         Reviewed by Alex Christensen.
2436
2437         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2438         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2439
2440 2015-04-14  Daniel Bates  <dabates@apple.com>
2441
2442         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
2443         https://bugs.webkit.org/show_bug.cgi?id=143693
2444         <rdar://problem/20530316>
2445
2446         Reviewed by Tim Horton.
2447
2448         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
2449         to use the fixed layout code on iOS at this time.
2450
2451         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
2452
2453 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2454
2455         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
2456         https://bugs.webkit.org/show_bug.cgi?id=143705
2457
2458         Unreviewed change to watchlist file.
2459
2460         * Scripts/webkitpy/common/config/watchlist:
2461
2462 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
2463
2464         [EFL] favicon wasn't updated for google.com sometimes.
2465         https://bugs.webkit.org/show_bug.cgi?id=141940
2466
2467         Reviewed by Gyuyoung Kim.
2468
2469         As elm_entry_utf8_to_markup can include additional characters, parameter for the
2470         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
2471
2472         * MiniBrowser/efl/main.c:
2473         (on_url_changed):
2474
2475 2015-04-13  Tim Horton  <timothy_horton@apple.com>
2476
2477         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
2478         https://bugs.webkit.org/show_bug.cgi?id=143560
2479         <rdar://problem/16302047>
2480
2481         Reviewed by Darin Adler.
2482
2483         * MiniBrowser/mac/BrowserWindowController.h:
2484         * MiniBrowser/mac/MainMenu.xib:
2485         * MiniBrowser/mac/WK1BrowserWindowController.m:
2486         (-[WK1BrowserWindowController setScale:]):
2487         * MiniBrowser/mac/WK2BrowserWindowController.m:
2488         (viewScaleForMenuItemTag):
2489         (-[WK2BrowserWindowController setScale:]):
2490         (-[WK2BrowserWindowController validateMenuItem:]):
2491         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
2492         When in use, we resize the window so that the view fits correctly, and
2493         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2494         layout size will not change when scaling down (but will update appropriately
2495         when the view is resized).
2496
2497 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2498
2499         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2500         https://bugs.webkit.org/show_bug.cgi?id=138630
2501
2502         Reviewed by Tim Horton.
2503
2504         Make sure that we always load at least one in order productive iteration.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2507         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2508         is done loading at least one iteration that wasn't an out of order build.
2509         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2510         when that's needed to check for out of order builds.
2511         (BuildbotQueue.prototype.update): Ditto.
2512         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2513         result, and if it does not, load more iterations.
2514         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2515         an in order iteration loaded too.
2516         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2517         corrected to always sort loaded iterations before unloaded ones.
2518
2519 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
2520
2521         Expand test infrastructure to support scrolling tests
2522         https://bugs.webkit.org/show_bug.cgi?id=143286
2523         <rdar://problem/20375516>
2524
2525         Reviewed by Simon Fraser.
2526
2527         Extend the WK1 and WK2 test programs to support two new EventSender commands:
2528         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2529         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2530         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2531         relevant rubberband, scroll, and scroll-snap animations are finished.
2532
2533         * DumpRenderTree/mac/EventSendingController.mm:
2534         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2535         and 'monitorWheelEvents'.
2536         (+[EventSendingController webScriptNameForSelector:]): Ditto.
2537         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2538         debugging test failures.
2539         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2540         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2541         function, then passes it to WebCore to be called once the test deferrals have been cleared.
2542         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2543         'callAfterScrollingCompletes' method.
2544         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2545         and 'monitorWheelEvents'.
2546         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2547         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2548         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2549         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2550         'callAfterScrollingComplates' method.
2551         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2552
2553 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2554
2555         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2556         https://bugs.webkit.org/show_bug.cgi?id=143656
2557
2558         Reviewed by Darin Adler.
2559
2560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2561         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2562
2563 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
2564
2565         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2566         https://bugs.webkit.org/show_bug.cgi?id=142387
2567
2568         Reviewed by Carlos Garcia Campos.
2569
2570         Running mixed content is blocked by default since r181134. Updated
2571         the test case to reflect the new default settings.
2572
2573         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2574         (testInsecureContent):
2575
2576 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2577
2578         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2579         https://bugs.webkit.org/show_bug.cgi?id=143667
2580
2581         Reviewed by Csaba Osztrogonác.
2582
2583         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2584         since r169017. Added $hardwareConcurrencySupport for it.
2585
2586         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2587
2588         * Scripts/webkitperl/FeatureList.pm:
2589
2590 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
2591
2592         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2593         https://bugs.webkit.org/show_bug.cgi?id=143664
2594
2595         Reviewed by Gyuyoung Kim.
2596
2597         * Scripts/webkitperl/FeatureList.pm:
2598
2599 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2600
2601         [EFL] Enable Media Source
2602         https://bugs.webkit.org/show_bug.cgi?id=143635
2603
2604         Reviewed by Csaba Osztrogonác.
2605
2606         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2607
2608 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
2609
2610         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2611         https://bugs.webkit.org/show_bug.cgi?id=143646
2612
2613         Reviewed by David Kilzer.
2614
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2616         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2617
2618 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
2619
2620         Use en_US spell checker for tests on Mac instead of Multilingual
2621         https://bugs.webkit.org/show_bug.cgi?id=143641
2622
2623         Reviewed by Dan Bernstein.
2624
2625         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2626         While at it, override NSUserDictionaryReplacementItems, so that user replacements
2627         cannot affect tests.
2628
2629         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2630         Made this more like WebKit1 version.
2631
2632 2015-04-10  Tim Horton  <timothy_horton@apple.com>
2633
2634         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2635         https://bugs.webkit.org/show_bug.cgi?id=143576
2636
2637         Reviewed by Simon Fraser.
2638
2639         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2640         (TEST):
2641         Adopt.
2642
2643 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2644
2645         Update my email address and expertise.
2646         https://bugs.webkit.org/show_bug.cgi?id=143586
2647
2648         Unreviewed, just update my info.
2649
2650         * Scripts/webkitpy/common/config/contributors.json:
2651
2652 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2653
2654         Flakiness Dashboard not loading insecure content if loaded with https URL
2655         https://bugs.webkit.org/show_bug.cgi?id=143570
2656
2657         Reviewed by Alexey Proskuryakov.
2658
2659         * TestResultServer/app.yaml:
2660         * TestResultServer/static-dashboards/loader.js:
2661         Switch to https scheme.
2662
2663 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
2664
2665         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2666         https://bugs.webkit.org/show_bug.cgi?id=142907
2667
2668         Reviewed by Carlos Garcia Campos.
2669
2670         * TestWebKitAPI/PlatformEfl.cmake:
2671         * TestWebKitAPI/PlatformGTK.cmake:
2672         * WebKitTestRunner/PlatformEfl.cmake:
2673         * WebKitTestRunner/PlatformGTK.cmake:
2674
2675 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2676
2677         [Mac] Unreviewed test fix after r182584
2678         https://bugs.webkit.org/show_bug.cgi?id=143452
2679
2680         Put both of these tests back to their original state now that the underlying
2681         problem is fixed.
2682
2683         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2684         (TestWebKitAPI::TEST):
2685         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2686         (TestWebKitAPI::TEST):
2687
2688 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
2689
2690         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2691         https://bugs.webkit.org/show_bug.cgi?id=143553
2692
2693         Reviewed by Ryosuke Niwa.
2694         
2695         Remove the spurious printVMs left over from an earlier change.
2696
2697         * Scripts/run-jsc-benchmarks:
2698
2699 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2700
2701         [Mac] Unreviewed test fix after r182581
2702
2703         The behavior of control-left-click is controlled by a system preference.
2704         Our test bots have this turned off.
2705
2706         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2707         (TestWebKitAPI::TEST):
2708         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2709         (TestWebKitAPI::TEST):
2710
2711 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2712
2713         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2714         https://bugs.webkit.org/show_bug.cgi?id=143452
2715         <rdar://problem/20437483>
2716
2717         Reviewed by Tim Horton.
2718
2719         Add a new API test to confirm that Cocoa mouse button press events are properly
2720         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2721
2722         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2723         some registered event handlers that the expected button press and context menu
2724         events are received.
2725
2726         The WK1 unit test creates an NSEvent with the desired button press state, and then
2727         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2728         We check the resulting PlatformMouseEvent for proper state.
2729
2730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2731         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2732         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2733         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2734         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2735         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2736         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2737         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2738         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2739         mouse down events.
2740         * TestWebKitAPI/mac/PlatformWebViewMac.h:
2741
2742 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2743
2744         [GTK] Add pango to jhbuild-optional.modules
2745         https://bugs.webkit.org/show_bug.cgi?id=143537
2746
2747         Reviewed by Martin Robinson.
2748
2749         * gtk/jhbuild-optional.modules: Add pango.
2750
2751 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2752
2753         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2754         https://bugs.webkit.org/show_bug.cgi?id=143530
2755
2756         Reviewed by Žan Doberšek.
2757
2758         Assume that the default value for display (:0) is reserved and start checking on :1
2759         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2760         and for X server named Xorg.bin (previous bug 1376599)
2761
2762         * Scripts/webkitpy/port/xvfbdriver.py:
2763         (XvfbDriver._next_free_display)
2764         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2765         (XvfbDriverTest.test_start_no_pixel_tests):
2766         (XvfbDriverTest.test_start_pixel_tests):
2767         (XvfbDriverTest.test_start_arbitrary_worker_number):
2768         (XvfbDriverTest.test_next_free_display):
2769         (XvfbDriverTest.test_start_next_worker):
2770 2015-04-08  Alex Christensen  <achristensen@webkit.org>
2771
2772         Block popups from content extensions.
2773         https://bugs.webkit.org/show_bug.cgi?id=143497
2774
2775         Reviewed by Brady Eidson.
2776
2777         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2778         (TestWebKitAPI::TEST_F):
2779         Added popup test.
2780
2781 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2782
2783         Add CMake build system for WinCairo port.
2784         https://bugs.webkit.org/show_bug.cgi?id=115944
2785
2786         Reviewed by Chris Dumez.
2787
2788         * CMakeLists.txt:
2789         * WinLauncher/CMakeLists.txt: Added.
2790
2791 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2792
2793         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2794         https://bugs.webkit.org/show_bug.cgi?id=143521
2795
2796         Reviewed by Martin Robinson.
2797
2798         Add a way to detect unexpected web process crashes to WebViewTest,
2799         and a test case to testDOMCache to trigger the crash.
2800
2801         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2802         (WebKitDOMNodeTest::testDOMCache):
2803         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2804         (testWebKitWebViewProcessCrashed):
2805         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2806         (WebViewTest::WebViewTest):
2807         (WebViewTest::webProcessCrashed):
2808         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2809
2810 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2811
2812         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2813         rdar://problem/20461342
2814
2815         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2816
2817 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2818
2819         Unreviewed, rolling out r182511.
2820         https://bugs.webkit.org/show_bug.cgi?id=143507
2821
2822         caused debug test failures (Requested by alexchristensen on
2823         #webkit).
2824
2825         Reverted changeset:
2826
2827         "Block popups from content extensions."
2828         https://bugs.webkit.org/show_bug.cgi?id=143497
2829         http://trac.webkit.org/changeset/182511
2830
2831 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2832
2833         Block popups from content extensions.
2834         https://bugs.webkit.org/show_bug.cgi?id=143497
2835
2836         Reviewed by Brady Eidson.
2837
2838         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2839         (TestWebKitAPI::TEST_F):
2840         Added popup test.
2841
2842 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2843
2844         Get the features.json files ready for open contributions
2845         https://bugs.webkit.org/show_bug.cgi?id=143436
2846
2847         Reviewed by Darin Adler.
2848
2849         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2850         (JSONFeaturesChecker.check):
2851         Extend the syntax checking a bit, but leave everything non-mandatory
2852         very loose until we figure what fields are important.
2853
2854 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2855
2856         Expose and test fixedLayoutSize via modern WebKit SPI
2857         https://bugs.webkit.org/show_bug.cgi?id=143500
2858
2859         Reviewed by Simon Fraser.
2860
2861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2862         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2863         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2864         (TEST):
2865         Add a test that verifies that fixedLayoutSize works at all, that
2866         it persists through a navigation, and that turning it back off reverts to
2867         laying out at the size of the view.
2868
2869 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2870
2871         Unreviewed. Add myself as a committer.
2872
2873         * Scripts/webkitpy/common/config/contributors.json:
2874
2875 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2876
2877         [Win] Bots complain about missing /etc/catalog
2878         https://bugs.webkit.org/show_bug.cgi?id=143484
2879
2880         Reviewed by Chris Dumez.
2881
2882         The libxml2 build on Mac, iOS, and Windows does not provide the set
2883         of default catalog files. We do not actually need these for our
2884         purposes, but we get warnings and some bot flakiness because they
2885         are not present.
2886
2887         We can avoid both problems the same way the Mac and iOS ports do,
2888         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2889         which avoid the warnings and bot problems.
2890
2891         * Scripts/webkitpy/port/win.py:
2892         (WinPort.setup_environ_for_server): Added.
2893
2894 2015-04-06  Sam Weinig  <sam@webkit.org>
2895
2896         Use content extensions in MiniBrowser.
2897         https://bugs.webkit.org/show_bug.cgi?id=143446
2898
2899         Reviewed by Alex Christensen.
2900
2901         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2902         * MiniBrowser/mac/AppDelegate.h:
2903         * MiniBrowser/mac/AppDelegate.m:
2904         (-[BrowserAppDelegate init]):
2905         (-[BrowserAppDelegate showExtensionsManager:]):
2906         (-[BrowserAppDelegate userContentContoller]):
2907         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2908         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2909         (-[ExtensionManagerWindowController init]):
2910         (-[ExtensionManagerWindowController windowDidLoad]):
2911         (-[ExtensionManagerWindowController add:]):
2912         (-[ExtensionManagerWindowController remove:]):
2913         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2914         * MiniBrowser/mac/MainMenu.xib:
2915
2916 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2917
2918         web-platform-tests server should retrieve the modules file relatively to its docroot path
2919         https://bugs.webkit.org/show_bug.cgi?id=142742
2920
2921         Reviewed by Darin Adler.
2922
2923         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2924         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2925
2926 2015-04-06  Commit Queue  <commit-queue@webkit.org>
2927
2928         Unreviewed, rolling out r182445.
2929         https://bugs.webkit.org/show_bug.cgi?id=143459
2930
2931         broke 32 bit build (Requested by alexchristensen on #webkit).
2932
2933         Reverted changeset:
2934
2935         "Use content extensions in MiniBrowser."
2936         https://bugs.webkit.org/show_bug.cgi?id=143446
2937         http://trac.webkit.org/changeset/182445
2938
2939 2015-04-06  Sam Weinig  <sam@webkit.org>
2940
2941         Use content extensions in MiniBrowser.
2942         https://bugs.webkit.org/show_bug.cgi?id=143446
2943
2944         Reviewed by Alex Christensen.
2945
2946         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2947         * MiniBrowser/mac/AppDelegate.h:
2948         * MiniBrowser/mac/AppDelegate.m:
2949         (-[BrowserAppDelegate init]):
2950         (-[BrowserAppDelegate showExtensionsManager:]):
2951         (-[BrowserAppDelegate userContentContoller]):
2952         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2953         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2954         (-[ExtensionManagerWindowController init]):
2955         (-[ExtensionManagerWindowController windowDidLoad]):
2956         (-[ExtensionManagerWindowController add:]):
2957         (-[ExtensionManagerWindowController remove:]):
2958         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2959         * MiniBrowser/mac/MainMenu.xib:
2960
2961 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2962
2963         [GTK] install-dependencies should prefer dnf to yum
2964         https://bugs.webkit.org/show_bug.cgi?id=143441
2965
2966         Reviewed by Martin Robinson.
2967
2968         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2969
2970         * gtk/install-dependencies:
2971
2972 2015-04-06  Andy Estes  <aestes@apple.com>
2973
2974         [iOS] 'make clean' fails in Tools/WebKitTestRunner
2975         https://bugs.webkit.org/show_bug.cgi?id=143455
2976
2977         Reviewed by Dan Bernstein.
2978
2979         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2980         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2981
2982         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2983
2984 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2985
2986         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2987         https://bugs.webkit.org/show_bug.cgi?id=143450
2988
2989         Reviewed by Anders Carlsson.
2990
2991         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2992         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2993         Also, removed unnecessary get() calls.
2994
2995 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2996
2997         Reduce the dependency on Flash in regression tests
2998         https://bugs.webkit.org/show_bug.cgi?id=143391
2999
3000         Reviewed by Anders Carlsson.
3001
3002         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
3003         Only allow QuickTime and the test plug-in.
3004
3005 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3006
3007         W3C test importer should generate the modules installed dynamically to run wpt tests
3008         https://bugs.webkit.org/show_bug.cgi?id=142738
3009
3010         Reviewed by Ryosuke Niwa.
3011
3012         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
3013         The implementation is done within TestDownloader and it is activated for the WPT repository.
3014         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
3015
3016         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3017         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
3018         * Scripts/webkitpy/w3c/test_downloader.py:
3019         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
3020         (TestDownloader):
3021         (TestDownloader._git_submodules_description): Computes submodule description.
3022         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
3023         * Scripts/webkitpy/w3c/test_importer.py:
3024         (TestImporter.do_import): Added the possibility to post process the tests.
3025         (TestImporter):
3026         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
3027         (TestImporter.should_convert_test_harness_links): Updated according new options format.
3028         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3029         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
3030         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
3031         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
3032         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
3033         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
3034
3035 2015-04-05  Antti Koivisto  <antti@apple.com>
3036
3037         Bloom filter should support longer hashes
3038         https://bugs.webkit.org/show_bug.cgi?id=143419
3039
3040         Reviewed by Dan Bernstein.
3041
3042         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
3043         (TestWebKitAPI::generateRandomDigests):
3044         (TestWebKitAPI::TEST):
3045
3046 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3047
3048         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
3049         https://bugs.webkit.org/show_bug.cgi?id=143372
3050
3051         Reviewed by Darin Adler.
3052
3053         * Scripts/run-jsc-stress-tests:
3054
3055 2015-04-03  Antti Koivisto  <antti@apple.com>
3056
3057         Add non-counting bloom filter class
3058         https://bugs.webkit.org/show_bug.cgi?id=143366
3059
3060         Reviewed by Sam Weinig.
3061
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3063         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
3064         (TestWebKitAPI::generateRandomHashes):
3065         (TestWebKitAPI::TEST):
3066
3067 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3068
3069         FTL JIT tests should fail if LLVM library isn't available
3070         https://bugs.webkit.org/show_bug.cgi?id=143374
3071
3072         Reviewed by Mark Lam.
3073
3074         * Scripts/run-jsc-stress-tests:
3075
3076 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3077
3078         [EFL] Speedup jhbuild with disable running autogen.sh
3079         https://bugs.webkit.org/show_bug.cgi?id=143369
3080
3081         Reviewed by Gyuyoung Kim.
3082
3083         * efl/jhbuild.modules:
3084
3085 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3086
3087         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
3088         https://bugs.webkit.org/show_bug.cgi?id=143282
3089
3090         Reviewed by Daniel Bates.
3091
3092         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
3093
3094 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3095
3096         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
3097         https://bugs.webkit.org/show_bug.cgi?id=143240
3098         rdar://problem/19990425
3099
3100         Reviewed by Tim Horton.
3101
3102         * DumpRenderTree/mac/LayoutTestHelper.m:
3103         (colorProfileURLForDisplay):
3104         (saveDisplayColorProfiles):
3105         Gracefully handle it when the current profile cannot be retrieved, fixing at
3106         least one case when LayoutTestHelper couldn't start.
3107
3108         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3109         (Manager._set_up_run):
3110         (Manager._force_pixel_tests_if_needed):
3111         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
3112         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
3113         Return and check an error from start_helper().
3114
3115 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
3116
3117         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
3118         https://bugs.webkit.org/show_bug.cgi?id=143321
3119
3120         Reviewed by Alexey Proskuryakov.
3121
3122         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
3123
3124 2015-04-01  Enrica Casucci  <enrica@apple.com>
3125
3126         Injected bundle messages should be at the page level.
3127         https://bugs.webkit.org/show_bug.cgi?id=143283
3128
3129         Reviewed by Alexey Proskuryakov.
3130
3131         Updating WebKitTestRunner to use the new page level messaging.
3132         The author of this patch is Tim Horton, I just finished it.
3133
3134         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3135         (WTR::EventSendingController::mouseDown):
3136         (WTR::EventSendingController::mouseUp):
3137         (WTR::EventSendingController::mouseMoveTo):
3138         (WTR::EventSendingController::leapForward):
3139         (WTR::EventSendingController::scheduleAsynchronousClick):
3140         (WTR::EventSendingController::keyDown):
3141         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3142         (WTR::EventSendingController::mouseScrollBy):
3143         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3144         (WTR::EventSendingController::continuousMouseScrollBy):
3145         (WTR::EventSendingController::addTouchPoint):
3146         (WTR::EventSendingController::updateTouchPoint):
3147         (WTR::EventSendingController::setTouchModifier):
3148         (WTR::EventSendingController::setTouchPointRadius):
3149         (WTR::EventSendingController::touchStart):
3150         (WTR::EventSendingController::touchMove):
3151         (WTR::EventSendingController::touchEnd):
3152         (WTR::EventSendingController::touchCancel):
3153         (WTR::EventSendingController::clearTouchPoints):
3154         (WTR::EventSendingController::releaseTouchPoint):
3155         (WTR::EventSendingController::cancelTouchPoint):
3156         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3157         (WTR::InjectedBundle::didReceiveMessage):
3158         (WTR::InjectedBundle::didReceiveMessageToPage):
3159         (WTR::InjectedBundle::done):
3160         (WTR::InjectedBundle::outputText):
3161         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3162         (WTR::InjectedBundle::postAddChromeInputField):
3163         (WTR::InjectedBundle::postRemoveChromeInputField):
3164         (WTR::InjectedBundle::postFocusWebView):
3165         (WTR::InjectedBundle::postSetBackingScaleFactor):
3166         (WTR::InjectedBundle::postSetWindowIsKey):
3167         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3168         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3169         (WTR::InjectedBundle::setGeolocationPermission):
3170         (WTR::InjectedBundle::setMockGeolocationPosition):
3171         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3172         (WTR::InjectedBundle::setUserMediaPermission):
3173         (WTR::InjectedBundle::setCustomPolicyDelegate):
3174         (WTR::InjectedBundle::setHidden):
3175         (WTR::InjectedBundle::setCacheModel):
3176         (WTR::InjectedBundle::shouldProcessWorkQueue):
3177         (WTR::InjectedBundle::processWorkQueue):
3178         (WTR::InjectedBundle::queueBackNavigation):
3179         (WTR::InjectedBundle::queueForwardNavigation):
3180         (WTR::InjectedBundle::queueLoad):
3181         (WTR::InjectedBundle::queueLoadHTMLString):
3182         (WTR::InjectedBundle::queueReload):
3183         (WTR::InjectedBundle::queueLoadingScript):
3184         (WTR::InjectedBundle::queueNonLoadingScript):
3185         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3186         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3187         (WTR::TestRunner::setAuthenticationUsername):
3188         (WTR::TestRunner::setAuthenticationPassword):
3189         (WTR::TestRunner::secureEventInputIsEnabled):
3190         (WTR::TestRunner::setBlockAllPlugins):
3191         * WebKitTestRunner/TestController.cpp:
3192         (WTR::TestController::createWebViewWithOptions):
3193         (WTR::TestController::resetStateToConsistentValues):
3194         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
3195         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
3196         * WebKitTestRunner/TestController.h:
3197         * WebKitTestRunner/TestInvocation.cpp:
3198         (WTR::TestInvocation::invoke):
3199         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3200
3201 2015-04-01  Commit Queue  <commit-queue@webkit.org>
3202
3203         Unreviewed, rolling out r182174 and r182177.
3204         https://bugs.webkit.org/show_bug.cgi?id=143314
3205
3206         Try to correct EWS failures (Requested by bfulgham on
3207         #webkit).
3208
3209         Reverted changesets:
3210
3211         "Python SCM should be able to retrieve untracked files"
3212         https://bugs.webkit.org/show_bug.cgi?id=143135
3213         http://trac.webkit.org/changeset/182174
3214
3215         "[buildbot] clean-build script should remove untracked files
3216         and revert local changes too"
3217         https://bugs.webkit.org/show_bug.cgi?id=142400
3218         http://trac.webkit.org/changeset/182177
3219
3220 2015-04-01  Alex Christensen  <achristensen@webkit.org>
3221
3222         [Content Extensions] Properly handle regexes that match everything.
3223         https://bugs.webkit.org/show_bug.cgi?id=143281
3224
3225         Reviewed by Benjamin Poulain.
3226
3227         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3228         (TestWebKitAPI::testRequest):
3229         (TestWebKitAPI::makeBackend):
3230         (TestWebKitAPI::TEST_F):
3231         Removed duplicate code and added test.
3232
3233 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
3234
3235         Content Extensions: split the state machines to minimize prefix states
3236         https://bugs.webkit.org/show_bug.cgi?id=143253
3237
3238         Reviewed by Alex Christensen.
3239
3240         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3241         (TestWebKitAPI::TEST_F):
3242         (TestWebKitAPI::testPatternStatus):
3243
3244 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3245
3246         Clean up Identifier factories to clarify the meaning of StringImpl*
3247         https://bugs.webkit.org/show_bug.cgi?id=143146
3248
3249         Reviewed by Filip Pizlo.
3250
3251         Simple API tests for StringImpl are added.
3252
3253         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3254         (TestWebKitAPI::TEST):
3255
3256 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
3257
3258         [EFL] Add AArch64 builder and tester bot to build.webkit.org
3259         https://bugs.webkit.org/show_bug.cgi?id=143092
3260
3261         Reviewed by Gyuyoung Kim.
3262
3263         * BuildSlaveSupport/build.webkit.org-config/config.json:
3264         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3265         (Factory.__init__):
3266         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3267
3268 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3269
3270         [buildbot] clean-build script should remove untracked files and revert local changes too
3271         https://bugs.webkit.org/show_bug.cgi?id=142400
3272
3273         Reviewed by Ryosuke Niwa.
3274
3275         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3276         A helper routine SCM.discard_untracked_files is added for that purpose.
3277
3278         * BuildSlaveSupport/clean-build:
3279         (main): Making call to Scripts/clean-webkit
3280         * Scripts/clean-webkit: Added.
3281         (main): Revert changes and delete untracked files.
3282         * Scripts/webkitpy/common/checkout/scm/scm.py:
3283         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3284         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3285         (SCMTest._shared_test_discard_untracked_files):
3286         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3287
3288 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3289
3290         Python SCM should be able to retrieve untracked files
3291         https://bugs.webkit.org/show_bug.cgi?id=143135
3292
3293         Reviewed by Ryosuke Niwa.
3294
3295         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3296         Ignored files may be included or not in this list according boolean passed to the function.
3297
3298         * Scripts/webkitpy/common/checkout/scm/git.py:
3299         (Git.untracked_files):
3300         * Scripts/webkitpy/common/checkout/scm/scm.py:
3301         (SCM.untracked_files):
3302         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3303         (SCMTest._shared_test_untracked_files):
3304         (test_untracked_files):
3305         (GitSVNTest.test_untracked_files):
3306         * Scripts/webkitpy/common/checkout/scm/svn.py:
3307         (SVN.untracked_files):
3308
3309 2015-03-30  Alex Christensen  <achristensen@webkit.org>
3310
3311         [Content Extensions] Correctly handle regular expressions matching everything
3312         https://bugs.webkit.org/show_bug.cgi?id=143235
3313
3314         Reviewed by Benjamin Poulain.
3315
3316         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3317         (TestWebKitAPI::checkCompilerError):
3318         (TestWebKitAPI::TEST_F):
3319         Test ContentExtensionErrors.
3320
3321 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
3322
3323         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
3324         https://bugs.webkit.org/show_bug.cgi?id=143241
3325         rdar://problem/20351297
3326
3327         Reviewed by Mark Lam.
3328
3329         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3330
3331 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3332
3333         [CMake][EFL] Remove redundant library link and include path
3334         https://bugs.webkit.org/show_bug.cgi?id=143221
3335
3336         Reviewed by Csaba Osztrogonác.
3337
3338         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
3339
3340 2015-03-30  Sam Weinig  <sam@webkit.org>
3341
3342         [Content Extensions] Flesh out the UserContentExtensionStore
3343         https://bugs.webkit.org/show_bug.cgi?id=143123
3344
3345         Reviewed by Benjamin Poulain.
3346
3347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3348         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
3349         Add tests for _WKUserContentExtensionStore.
3350
3351 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3352
3353         Update install-dependencies Fedora packages after r181624
3354         https://bugs.webkit.org/show_bug.cgi?id=143215
3355
3356         Add json-glib, libv4l, openssl and pulseaudio development packages to
3357         the Fedora list providing we need them to build WebKit dependencies
3358         for this distribution.
3359
3360         Reviewed by Philippe Normand.
3361
3362         * gtk/install-dependencies:
3363
3364 2015-03-30  Commit Queue  <commit-queue@webkit.org>
3365
3366         Unreviewed, rolling out r182119.
3367         https://bugs.webkit.org/show_bug.cgi?id=143196
3368
3369         problem with syntax (Requested by youenn on #webkit).
3370
3371         Reverted changeset:
3372
3373         "[buildbot] clean-build script should remove untracked files
3374         and revert local changes too"
3375         https://bugs.webkit.org/show_bug.cgi?id=142400
3376         http://trac.webkit.org/changeset/182119
3377
3378 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
3379
3380         Start the features.json files
3381         https://bugs.webkit.org/show_bug.cgi?id=143207
3382
3383         Reviewed by Darin Adler.
3384
3385         I kept the style checking light. We'll have to figure
3386         what is the best format for each field.
3387
3388         * Scripts/webkitpy/style/checker.py:
3389         (CheckerDispatcher._create_checker):
3390         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3391         (JSONContributorsChecker.check):
3392         (JSONFeaturesChecker):
3393         (JSONFeaturesChecker.check):
3394
3395 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3396
3397         [buildbot] clean-build script should remove untracked files and revert local changes too
3398         https://bugs.webkit.org/show_bug.cgi?id=142400
3399
3400         Reviewed by Ryosuke Niwa.
3401
3402         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
3403
3404         * BuildSlaveSupport/clean-build:
3405         (main): Adding call to Tools/Scripts/clean-webkit.
3406         * Scripts/clean-webkit: Added.
3407         (main): Removes untracked and changed files.
3408         * Scripts/webkitpy/common/checkout/scm/git.py:
3409         (Git.untracked_files): Retrieves GIT untracked files.
3410         * Scripts/webkitpy/common/checkout/scm/scm.py:
3411         (SCM.untracked_files): Retrieves SVN untracked files.
3412         (SCM):
3413         (SCM.discard_untracked_files): Deletes untracked files/folders.
3414         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3415         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
3416         (test_untracked_files):
3417         (GitSVNTest.test_untracked_files):
3418         * Scripts/webkitpy/common/checkout/scm/svn.py:
3419         (SVN.untracked_files):
3420
3421 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3422
3423         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
3424         https://bugs.webkit.org/show_bug.cgi?id=143138
3425
3426         Reviewed by Csaba Osztrogonác.
3427
3428         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
3429         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
3430
3431         * ImageDiff/CMakeLists.txt:
3432         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
3433         * WebKitTestRunner/CMakeLists.txt: ditto.
3434
3435 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
3436
3437         Support building WTF on Windows without Cygwin
3438         https://bugs.webkit.org/show_bug.cgi?id=143084
3439
3440         Reviewed by Brent Fulgham.
3441
3442         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
3443         This patch also migrates to using File::Spec->catfile() for directory separators.
3444
3445         * Scripts/update-webkit-dependency:
3446         (wanted):
3447         * Scripts/update-webkit-support-libs:
3448         (wanted):
3449         (downloadExpectedVersionNumber):
3450         (zipFileVersion):
3451         (toUnixPath): Deleted.
3452         * Scripts/webkitdirs.pm:
3453         (determineSourceDir):
3454         (windowsSourceSourceDir):
3455         (windowsLibrariesDir):
3456         (windowsOutputDir):
3457         (checkInstalledTools):
3458         (buildVisualStudioProject):
3459
3460 2015-03-27  Alex Christensen  <achristensen@webkit.org>
3461
3462         Fix WinCairo bot.
3463         https://bugs.webkit.org/show_bug.cgi?id=143086
3464
3465         Reviewed by Brent Fulgham.
3466
3467         * Scripts/webkitdirs.pm:
3468         (buildVisualStudioProject):
3469         (runSvnUpdateAndResolveChangeLogs):
3470         Use ActivePerl-friendly perl.
3471
3472 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3473
3474         URTBF after r182059 to fix the EFL build.
3475
3476         * TestWebKitAPI/CMakeLists.txt:
3477
3478 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
3479
3480         Layout test results URL loads in WK1 but not WK2 minibrowser
3481         https://bugs.webkit.org/show_bug.cgi?id=143117
3482
3483         Reviewed by Tim Horton.
3484
3485         * MiniBrowser/mac/WK2BrowserWindowController.m:
3486         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
3487         everything.
3488         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
3489
3490 2015-03-26  Jer Noble  <jer.noble@apple.com>
3491
3492         Add --allowed-host support to run-webkit-tests
3493         https://bugs.webkit.org/show_bug.cgi?id=142938
3494
3495         Reviewed by Brent Fulgham.
3496
3497         Accept --allowed-host arguments from run-webkit-tests and pass them through to
3498         DumpRenderTree and WebKitTestRunner.
3499
3500         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3501         are placed in the wrong location. The argument is compared with each tests's path, and if a
3502         relative path or a path with '..' was used, results are placed alongside the test. Take the
3503         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3504
3505         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3506         (parse_args):
3507         * Scripts/webkitpy/port/base.py:
3508         (Port.__init__):
3509         (Port.allowed_hosts):
3510         * Scripts/webkitpy/port/driver.py:
3511         (Driver.cmd_line):
3512
3513 2015-03-26  Jer Noble  <jer.noble@apple.com>
3514
3515         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3516         https://bugs.webkit.org/show_bug.cgi?id=142931
3517
3518         Reviewed by Brent Fulgham.
3519
3520         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3521         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3522         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3523         runtime.
3524
3525         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
3526         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
3527
3528         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
3529         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
3530         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
3531         the top loading frame from the page, as we do elsewhere in this class.
3532
3533         * DumpRenderTree/TestRunner.h:
3534         (TestRunner::allowedHosts):
3535         (TestRunner::setAllowedHosts):
3536         * DumpRenderTree/mac/DumpRenderTree.mm:
3537         (initializeGlobalsFromCommandLineOptions):
3538         (runTest):
3539         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3540         (isAllowedHost):
3541         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3543         (WTR::InjectedBundle::didReceiveMessage):
3544         (WTR::InjectedBundle::isAllowedHost):
3545         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3546         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3547         (WTR::isAllowedHost):
3548         (WTR::InjectedBundlePage::willSendRequestForFrame):
3549         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3550         * WebKitTestRunner/Options.cpp:
3551         (WTR::handleOptionAllowedHost):
3552         (WTR::OptionsHandler::OptionsHandler):
3553         * WebKitTestRunner/Options.h:
3554         * WebKitTestRunner/TestController.cpp:
3555         (WTR::TestController::initialize):
3556         (WTR::TestController::resetStateToConsistentValues):
3557         * WebKitTestRunner/TestController.h:
3558
3559 2015-03-26  Brady Eidson  <beidson@apple.com>
3560
3561         Apply ContentExtension actions after redirects.
3562         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
3563
3564         Reviewed by Alex Christensen.
3565
3566         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3567         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
3568           which is specifically interesting to a new test.
3569
3570 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3571
3572         [EFL] Disable building libseccomp on AArch64
3573         https://bugs.webkit.org/show_bug.cgi?id=143094
3574
3575         Reviewed by Gyuyoung Kim.
3576
3577         * efl/jhbuildrc:
3578
3579 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3580
3581         [jhbuild] git should use only 1 thread for cloning jhbuild
3582         https://bugs.webkit.org/show_bug.cgi?id=143095
3583
3584         Reviewed by Gyuyoung Kim.
3585
3586         * jhbuild/jhbuild-wrapper:
3587         (clone_jhbuild):
3588
3589 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
3590
3591         Update prepare-ChangeLog to work with ES6 Class syntax
3592         https://bugs.webkit.org/show_bug.cgi?id=143069
3593
3594         Reviewed by Timothy Hatcher.
3595
3596         * Scripts/prepare-ChangeLog:
3597         (get_function_line_ranges_for_javascript):
3598         Better handle ES6 Class syntax.
3599
3600         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3601         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3602         (BaseClass):
3603         (DerivedClass):
3604         (DerivedClass.staticMethod):
3605         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
3606         (DerivedClass.prototype.method):
3607         (DerivedClass.prototype.get getter):
3608         (namespace.MyClass):
3609         (namespace.MyClass.staticMethod):
3610         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
3611         (namespace.MyClass.prototype.method):
3612         (namespace.MyClass.prototype.get getter):
3613         Proof!
3614
3615 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
3616
3617         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
3618         https://bugs.webkit.org/show_bug.cgi?id=142993
3619
3620         Reviewed by Mark Lam.
3621         
3622         Bunch of support for testing executable allocation failure.
3623
3624         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
3625         (fail):
3626         * Scripts/run-javascriptcore-tests:
3627         (runJSCStressTests):
3628         * Scripts/run-jsc-stress-tests:
3629
3630 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3631
3632         Fix Windows build from r181977.
3633
3634         Unreviewed.
3635
3636         * Scripts/update-webkit-dependency:
3637
3638 2015-03-25  Sam Weinig  <sam@webkit.org>
3639
3640         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
3641
3642         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3643         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3644
3645 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3646
3647         Migrate update-webkit for Windows to not require Cygwin
3648         https://bugs.webkit.org/show_bug.cgi?id=143040
3649
3650         Reviewed by Brent Fulgham.
3651
3652         * Scripts/update-webkit-dependency:
3653         (wanted):
3654         (toUnixPath): Deleted.
3655         * Scripts/webkitdirs.pm:
3656         (fontExists):
3657         (checkInstalledTools):
3658         (setupAppleWinEnv):
3659
3660 2015-03-25  Sam Weinig  <sam@webkit.org>
3661
3662         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
3663         https://bugs.webkit.org/show_bug.cgi?id=143059
3664
3665         Reviewed by Alex Christensen.
3666
3667         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3668         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3669         Update for new interface of compileRuleList().
3670
3671 2015-03-25  Alex Christensen  <achristensen@webkit.org>
3672
3673         [Content Extensions] Add multi-DFA compiling and interpreting.
3674         https://bugs.webkit.org/show_bug.cgi?id=143010
3675
3676         Reviewed by Benjamin Poulain.
3677
3678         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3679         (TestWebKitAPI::testRequest):
3680         (TestWebKitAPI::TEST_F):
3681         Add some tests for ignore-previous-rules and large rulesets.
3682
3683 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
3684
3685         Mavericks WK1 still runs JSC tests
3686         https://bugs.webkit.org/show_bug.cgi?id=143035
3687
3688         Reviewed by Csaba Osztrogonác.
3689
3690         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
3691         with other bots.
3692
3693         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
3694         accordingly.
3695
3696 2015-03-25  Commit Queue  <commit-queue@webkit.org>
3697
3698         Unreviewed, rolling out r181932.
3699         https://bugs.webkit.org/show_bug.cgi?id=143041
3700
3701         The test fails most of the time on bots (Requested by ap on
3702         #webkit).
3703
3704         Reverted changeset:
3705
3706         "[Content Extensions] Add multi-DFA compiling and
3707         interpreting."
3708         https://bugs.webkit.org/show_bug.cgi?id=143010
3709         http://trac.webkit.org/changeset/181932
3710
3711 2015-03-24  Alex Christensen  <achristensen@webkit.org>
3712
3713         [Content Extensions] Add multi-DFA compiling and interpreting.
3714         https://bugs.webkit.org/show_bug.cgi?id=143010
3715
3716         Reviewed by Benjamin Poulain.
3717
3718         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3719         (TestWebKitAPI::testRequest):
3720         (TestWebKitAPI::TEST_F):
3721         Add some tests for ignore-previous-rules and large rulesets.
3722
3723 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
3724
3725         Make URL filter patterns matching consistent and add a simple canonicalization step
3726         https://bugs.webkit.org/show_bug.cgi?id=142998
3727
3728         Reviewed by Alex Christensen.
3729
3730         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3731
3732 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
3733
3734         [EFL] Add OpenWebRTC in jhbuild
3735         https://bugs.webkit.org/show_bug.cgi?id=142778
3736
3737         Reviewed by Gyuyoung Kim.
3738
3739         Original patch by Philippe Normand <pnormand@igalia.com>
3740
3741         * efl/install-dependencies: Dependencies for OpenWebRTC.
3742         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
3743         the openwebrtc gst plugins.
3744
3745 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
3746
3747         Regression(r181257): WTF_WorkQueue.Simple is flaky
3748         https://bugs.webkit.org/show_bug.cgi?id=142560
3749
3750         Remove the check that the refCount has returned to one after the
3751         individual tasks have completed. It's too nondeterministic when
3752         the reference count will be reduced.
3753
3754         Reviewed by Alexey Proskuryakov
3755
3756         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3757         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
3758
3759 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3760
3761         [CMake][EFL] Put failure API test excutables into failure directory
3762         https://bugs.webkit.org/show_bug.cgi?id=142965
3763
3764         Reviewed by Csaba Osztrogonác.
3765
3766         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
3767
3768         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
3769         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
3770
3771 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
3772
3773         CSS Selectors: fix attribute case-insensitive matching of Contain and List
3774         https://bugs.webkit.org/show_bug.cgi?id=142932
3775
3776         Reviewed by Darin Adler.
3777
3778         Add tests for the new features and fix some existing tests using the 
3779         stringFromUTF8() utility recently added by Dhi.
3780
3781         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3782         (TestWebKitAPI::stringFromUTF8):
3783         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3784
3785 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3786
3787         [GTK] install-dependencies should install orc
3788         https://bugs.webkit.org/show_bug.cgi?id=142955
3789
3790         Reviewed by Martin Robinson.
3791
3792         Install orc, needed by openwebrtc
3793
3794         * gtk/install-dependencies:
3795
3796 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
3797
3798         Detect when url filter pattern with groups match the empty string
3799         https://bugs.webkit.org/show_bug.cgi?id=142930
3800
3801         Reviewed by Sam Weinig.
3802
3803         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3804
3805 2015-03-22  Anders Carlsson  <andersca@apple.com>
3806
3807         _WKWebsiteDataStore should clear WebSQL databases
3808         https://bugs.webkit.org/show_bug.cgi?id=142947
3809
3810         Reviewed by Sam Weinig.
3811
3812         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3813
3814         * MiniBrowser/mac/WK2BrowserWindowController.m:
3815         (-[WK2BrowserWindowController fetchWebsiteData:]):
3816         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3817         (-[WK2BrowserWindowController clearWebsiteData:]):
3818
3819 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
3820
3821         GCTimer should know keep track of nested GC phases
3822         https://bugs.webkit.org/show_bug.cgi?id=142675
3823
3824         Reviewed by Darin Adler.
3825
3826         Adds a tool to aid in parsing the GC phase timing output into a
3827         tree-like structure based on the parent-child relationships
3828         of nested GC phases.
3829
3830         * Scripts/parse-gc-phase-timings: Added.
3831         (Timing):
3832         (Timing.__init__):
3833         (Timing.__unicode__):
3834         (Timing.__str__):
3835         (Timing.__repr__):
3836         (parse_input):
3837         (print_timing_node):
3838         (print_timing_tree):
3839         (link_parents):
3840         (main):
3841
3842 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
3843
3844         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3845
3846         * Scripts/webkitpy/common/config/ews.json:
3847
3848 2015-03-20  Philippe Normand  <pnormand@igalia.com>
3849
3850         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3851         https://bugs.webkit.org/show_bug.cgi?id=142867
3852
3853         Rubber-stamped by Csaba Osztrogon.
3854
3855         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3856         a fixed revision for the openwebrtc-gst-plugins.
3857
3858 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3859
3860         Unreviewed build fix. Don't try to report stats for all benchmarks.
3861         Just report the geometric mean of preferred means.
3862
3863         * Scripts/run-jsc-benchmarks:
3864
3865 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3866
3867         run-jsc-benchmarks should only report preferred mean
3868         https://bugs.webkit.org/show_bug.cgi?id=142874
3869
3870         Reviewed by Geoffrey Garen.
3871
3872         Just collect statistics for the preferred mean.
3873
3874         * Scripts/run-jsc-benchmarks:
3875
3876 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3877
3878         [Content Extensions] Test regular expression parse failures.
3879         https://bugs.webkit.org/show_bug.cgi?id=142872
3880
3881         Reviewed by Benjamin Poulain.
3882
3883         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3884         (TestWebKitAPI::testPatternStatus):
3885         (TestWebKitAPI::TEST_F):
3886         Added tests for each parsing status.
3887
3888 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3889
3890         Fix API tests after r181754.
3891
3892         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3893         (TestWebKitAPI::testRequest):
3894
3895 2015-03-19  Brady Eidson  <beidson@apple.com>
3896
3897         Part of content extensions should apply css selectors
3898         https://bugs.webkit.org/show_bug.cgi?id=142604
3899
3900         Reviewed by Alex Christensen.
3901
3902         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3903         (WebCore::ContentExtensions::operator<<):
3904
3905 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
3906
3907         [Win] Activate tests on EWS
3908         https://bugs.webkit.org/show_bug.cgi?id=142850
3909
3910         Reviewed by Alexey Proskuryakov.
3911
3912         * Scripts/webkitpy/common/config/ews.json: Add me as
3913         the EWS bot watcher, and activate tests.
3914
3915 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
3916
3917         [GTK] Fix inspector userinterface related incremental build issue
3918         https://bugs.webkit.org/show_bug.cgi?id=142849
3919
3920         Reviewed by Carlos Garcia Campos.
3921
3922         * Scripts/webkitdirs.pm:
3923         (shouldRemoveCMakeCache):
3924
3925 2015-03-18  Alex Christensen  <achristensen@webkit.org>
3926
3927         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3928         https://bugs.webkit.org/show_bug.cgi?id=142799
3929
3930         Reviewed by Brady Eidson.
3931
3932         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3933         (TestWebKitAPI::testPattern):
3934         (TestWebKitAPI::TEST_F):
3935         Start testing regex failures.
3936
3937 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
3938
3939         Fix StringView typos after r181525 and r181558
3940         https://bugs.webkit.org/show_bug.cgi?id=142772
3941
3942         Reviewed by Darin Adler.
3943
3944         Add some tests in [1] to cover the StringView::startsWith, 
3945         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
3946         StringView::endsWithIgnoringASCIICase implementations.
3947
3948         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3949         (TestWebKitAPI::TEST):
3950
3951 2015-03-18  Dana Burkart  <dburkart@apple.com>
3952
3953         Remove extraneous import to fix the build.
3954
3955         Unreviewed.
3956
3957         * Scripts/webkitpy/port/driver.py:
3958
3959 2015-03-18  Dana Burkart  <dburkart@apple.com>
3960
3961         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
3962         https://bugs.webkit.org/show_bug.cgi?id=142547
3963
3964         Reviewed by Alexey Proskuryakov.
3965
3966         * Scripts/webkitpy/port/driver.py:
3967         (Driver._setup_environ_for_driver):
3968
3969 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
3970
3971         Tweak how AppleSystemFontOSSubversion default is added
3972         https://bugs.webkit.org/show_bug.cgi?id=142835
3973
3974         Reviewed by Dan Bernstein.
3975
3976         * DumpRenderTree/mac/DumpRenderTree.mm:
3977         (setDefaultsToConsistentValuesForTesting):
3978
3979 2015-03-18  Dan Bernstein  <mitz@apple.com>
3980
3981         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3982         https://bugs.webkit.org/show_bug.cgi?id=142815
3983
3984         Reviewed by Darin Adler.
3985
3986         * Scripts/prepare-ChangeLog:
3987         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3988         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3989         keep consuming the quoted text until the matching quotation mark is reached. Emit the
3990         warning only if a line ends without a backslash before the matching quotation mark was found.
3991
3992 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3993
3994         Remove unused "preprocessor" parameter to sub-CodeGenerators
3995         https://bugs.webkit.org/show_bug.cgi?id=142793
3996
3997         Reviewed by Darin Adler.
3998
3999         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
4000         (new):
4001
4002 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
4003
4004         [EFL] Bump gstreamer version to 1.4.4
4005         https://bugs.webkit.org/show_bug.cgi?id=142782
4006
4007         Reviewed by Philippe Normand.
4008
4009         * efl/jhbuild.modules:
4010         * efl/patches/gst-libav.patch:
4011         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
4012         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
4013
4014 2015-03-17  Tim Horton  <timothy_horton@apple.com>
4015
4016         Fix the iOS build.
4017
4018         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4019         (WTR::InjectedBundle::platformInitialize):
4020
4021 2015-03-17  Dean Jackson  <dino@apple.com>
4022
4023         check-webkit-style should allow "bool a : 1"
4024         https://bugs.webkit.org/show_bug.cgi?id=142794
4025
4026         Reviewed by Brent Fulgham.
4027
4028         We should allow member bitfields of the form:
4029
4030         bool m_var : 1;
4031
4032         It seems that Visual Studio 8 was the last compiler that
4033         wasn't happy about not using unsigned here. We already have
4034         about 500 cases (in WebCore) where people were ignoring this rule.
4035
4036         * Scripts/webkitpy/style/checkers/cpp.py:
4037         (check_language): Allow "bool".
4038         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
4039         (CppStyleTest.test_enum_bitfields):
4040         (CppStyleTest.test_plain_integral_bitfields):
4041
4042 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
4043
4044         Compile character ranges targeting the same state as range check in the bytecode
4045         https://bugs.webkit.org/show_bug.cgi?id=142759
4046
4047         Reviewed by Alex Christensen.
4048
4049         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4050         (TestWebKitAPI::TEST_F):
4051
4052 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4053
4054         W3C test parser and converter should use test importer host
4055         https://bugs.webkit.org/show_bug.cgi?id=142729
4056
4057         Reviewed by Bem Jones-Bey.
4058
4059         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
4060         This enables adding more TestImporter unit testing.
4061         This patch also ensures that the git object instantiated by TestDownloader is using the
4062         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
4063
4064         * Scripts/webkitpy/common/system/filesystem_mock.py:
4065         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
4066         * Scripts/webkitpy/w3c/test_downloader.py:
4067         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
4068         (TestDownloader.checkout_test_repository): Making use of the new git function.
4069         * Scripts/webkitpy/w3c/test_importer.py:
4070         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
4071         (TestImporter.import_tests): Adding host as parameter to the converter.
4072         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4073         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
4074         (TestImporterTest):
4075         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
4076         * Scripts/webkitpy/w3c/test_parser.py:
4077         (TestParser.__init__): Adding host as parameter constructor.
4078
4079 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4080
4081         [GTK] WebKitDOM objects leaking
4082         https://bugs.webkit.org/show_bug.cgi?id=118788
4083
4084         Reviewed by Darin Adler and Sergio Villar Senin.
4085
4086         Update DOMObjectCache unit test to check that DOM objects are also
4087         released when new contents are loaded in the web view, and the old
4088         document is detached from the frame.
4089
4090         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
4091         (testWebKitDOMObjectCache):
4092         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
4093         (runTest):
4094
4095 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4096
4097         W3C test importer default import folder should be LayoutTests/imported/w3c
4098         https://bugs.webkit.org/show_bug.cgi?id=142728
4099
4100         Reviewed by Bem Jones-Bey.
4101
4102         * Scripts/webkitpy/w3c/test_importer.py:
4103         (parse_args): Updating the default destination option value to 'imported/w3c'.
4104
4105 2015-03-17  Philippe Normand  <pnormand@igalia.com>
4106
4107         [GTK] basic OpenWebRTC build support
4108         https://bugs.webkit.org/show_bug.cgi?id=142393
4109
4110         Reviewed by Carlos Garcia Campos.
4111
4112         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
4113         is not the upstream OpenWebRTC repository. This temporary fork
4114         contains a few patches needed by WebKit for audio/video rendering.
4115
4116 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4117
4118         [CMake][EFL] Build test tools only for developer mode
4119         https://bugs.webkit.org/show_bug.cgi?id=142761
4120
4121         Reviewed by Csaba Osztrogonác.
4122
4123         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
4124
4125         * CMakeLists.txt:
4126
4127 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
4128
4129         Remove never used "useLayerOnTop" bindings generator argument
4130         https://bugs.webkit.org/show_bug.cgi?id=142773
4131
4132         Reviewed by Darin Adler.
4133
4134         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
4135         (new):
4136
4137 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
4138
4139         Enable ES6 classes by default
4140         https://bugs.webkit.org/show_bug.cgi?id=142774
4141
4142         Reviewed by Gavin Barraclough.
4143
4144         * Scripts/webkitperl/FeatureList.pm:
4145
4146 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
4147
4148         Fix webkitpy tests after r181585.
4149
4150         Looks like "me" cannot be anyone's email, it's a special case.
4151
4152         * Scripts/webkitpy/common/config/contributors.json:
4153
4154 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
4155
4156         Add tolerance to WebAudio tests
4157         https://bugs.webkit.org/show_bug.cgi?id=142676
4158
4159         Reviewed by Tim Horton.
4160
4161         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
4162
4163         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4164         (TestResultWriter.create_audio_diff_and_write_result):
4165         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4166         (FailureAudio.write_failure):
4167         * Scripts/webkitpy/port/base.py:
4168         (Port.do_audio_results_differ):
4169         Diff audio failures.
4170
4171         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
4172         tests to use real parseable WAV data, and got rid of base64, which there didn't
4173         seem to have been any reason for.
4174
4175 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
4176
4177         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
4178         https://bugs.webkit.org/show_bug.cgi?id=142720
4179
4180         Reviewed by Myles C. Maxfield.
4181
4182         Activate system copies of Microsoft fonts for the current process, thus overriding
4183         any other ones that could be preferred by the system otherwise.
4184
4185         * DumpRenderTree/mac/DumpRenderTree.mm:
4186         (activateSystemCoreWebFonts):
4187         (adjustFonts):
4188         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4189         (WTR::activateSystemCoreWebFonts):
4190         (WTR::activateFonts):
4191
4192 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4193
4194         Created Streams API watchlist
4195         https://bugs.webkit.org/show_bug.cgi?id=142684
4196
4197         Reviewed by Benjamin Poulain.
4198
4199         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
4200         watchlist and added Benjamin, Youenn and me to it.
4201
4202 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
4203
4204         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
4205         https://bugs.webkit.org/show_bug.cgi?id=142715
4206
4207         Reviewed by Brent Fulgham.
4208
4209         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4210         (TestWebKitAPI::TEST):
4211
4212 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
4213
4214         Change the exact attribute matching to be ASCII case-insensitive
4215         https://bugs.webkit.org/show_bug.cgi?id=142609
4216
4217         Reviewed by Darin Adler.
4218
4219         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4220         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4221
4222 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4223
4224         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
4225         https://bugs.webkit.org/show_bug.cgi?id=134764
4226
4227         Reviewed by Ryosuke Niwa.
4228
4229         TestDownloader is introduced to download W3C tests from the official
4230         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
4231         and https://github.com/w3c/csswg-test.git).
4232         TestDownloader clones the repositories and checkouts revisions of the tests
4233         defined in LayoutTests/imported/w3c/resources/TestRepositories.
4234
4235         Similarly to https://codereview.chromium.org/148173016,
4236         TestDownloader copies part of the files based on the rules
4237         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
4238
4239         TestDownloader is used by TestImporter when no source directory is provided.
4240
4241         * Scripts/webkitpy/w3c/test_downloader.py: Added.
4242         (TestDownloader):
4243         (TestDownloader.default_options):
4244         (TestDownloader.load_test_repositories):
4245         (TestDownloader.__init__):
4246         (TestDownloader.checkout_test_repository):
4247         (TestDownloader._init_paths_from_expectations):
4248         (TestDownloader._add_test_suite_paths):
4249         (TestDownloader._empty_directory):
4250         (TestDownloader.copy_tests):
4251         (TestDownloader.download_tests):
4252         * Scripts/webkitpy/w3c/test_importer.py:
4253         (main):
4254         (parse_args):
4255         (TestImporter.__init__):
4256         (TestImporter.do_import):
4257         (TestImporter.test_downloader):
4258         (TestImporter.find_importable_tests.should_keep_subdir):
4259         (TestImporter.should_convert_test_harness_links):
4260         (TestImporter.import_tests):
4261         (TestImporter.write_import_log):
4262
4263 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
4264
4265         [Mavericks] Test snapshots are 1600x1200 on Retina devices
4266         https://bugs.webkit.org/show_bug.cgi?id=142630
4267
4268         Reviewed by Tim Horton.
4269
4270         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
4271         Removed an ifdef that disabled the fix on Mavericks.
4272
4273 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
4274
4275         Remove isWK2 cruft from webkitdirs.pm after r170426
4276         https://bugs.webkit.org/show_bug.cgi?id=142618
4277
4278         Reviewed by Daniel Bates.
4279
4280         * Scripts/webkitdirs.pm:
4281         (isWK2): Deleted.
4282
4283 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
4284
4285         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
4286         https://bugs.webkit.org/show_bug.cgi?id=138687
4287
4288         Reviewed by Carlos Garcia Campos.
4289
4290         Always change cookie policy from UI process, as changing it from WebProcess doesn't
4291         affect other processes.
4292
4293         The implementation is imperfect, because the change happens asynchronously, but I
4294         don't expect it to be a problem in practice.
4295
4296         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4297         (WTR::InjectedBundle::beginTesting):
4298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4299         (WTR::TestRunner::setAlwaysAcceptCookies):
4300         * WebKitTestRunner/TestInvocation.cpp:
4301         (WTR::TestInvocation::invoke):
4302         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4303
4304 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
4305
4306         [EFL] Enable building EFL 1.13 with NEON support
4307         https://bugs.webkit.org/show_bug.cgi?id=142619
4308
4309         Reviewed by Gyuyoung Kim.
4310
4311         * efl/jhbuild.modules:
4312
4313 2015-03-11  Alex Christensen  <achristensen@webkit.org>
4314
4315         [Content Extensions] Add resource type and load type triggers.
4316         https://bugs.webkit.org/show_bug.cgi?id=142422
4317
4318         Reviewed by Benjamin Poulain.
4319
4320         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4321         (TestWebKitAPI::testRequest):
4322         (TestWebKitAPI::mainDocumentRequest):
4323         (TestWebKitAPI::TEST_F):
4324         (TestWebKitAPI::testURL): Deleted.
4325
4326 2015-03-10  Sam Weinig  <sam@webkit.org>
4327
4328         Allow adding a button in input elements for auto fill related functionality
4329         <rdar://problem/19782066>
4330         https://bugs.webkit.org/show_bug.cgi?id=142564
4331
4332         Reviewed by Anders Carlsson.
4333
4334         * WebKitTestRunner/TestController.cpp:
4335         (WTR::TestController::createOtherPage):
4336         (WTR::TestController::createWebViewWithOptions):
4337         Update for new callback.
4338
4339 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
4340
4341         Add basic support for BOL and EOL assertions to the URL Filter parser
4342         https://bugs.webkit.org/show_bug.cgi?id=142568
4343
4344         Reviewed by Alex Christensen.
4345
4346         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4347         (TestWebKitAPI::TEST_F):
4348
4349 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
4350
4351         [GTK] Add support for handling TLS errors to MiniBrowser
4352         https://bugs.webkit.org/show_bug.cgi?id=142576
4353
4354         Reviewed by Sergio Villar Senin.
4355
4356         It's useful for testing TLS errors handling itself, but also to
4357         allow ignoring TLS errors when testing.
4358
4359      &n