Unreviewed, rolling out r214932.
[WebKit-https.git] / Tools / ChangeLog
1 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed, rolling out r214932.
4
5         This change broke an internal build.
6
7         Reverted changeset:
8
9         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
10         timing out"
11         https://bugs.webkit.org/show_bug.cgi?id=161967
12         http://trac.webkit.org/changeset/214932
13
14 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
15
16         Unreviewed, rolling out r214962.
17
18         Roll r214937 back in because it wasn't at fault for the build
19         breakage.
20
21         Reverted changeset:
22
23         "Unreviewed, rolling out r214937."
24         https://bugs.webkit.org/show_bug.cgi?id=170365
25         http://trac.webkit.org/changeset/214962
26
27 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
28
29         Unreviewed, rolling out r214937.
30
31         This change broke an internal build.
32
33         Reverted changeset:
34
35         "REGRESSION (r202472): Data Detection overwrites existing
36         links in detected ranges"
37         https://bugs.webkit.org/show_bug.cgi?id=170365
38         http://trac.webkit.org/changeset/214937
39
40 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
41
42         Increase timeouts for simulator testing
43         Unreviewed infrastructure fix.
44
45         r214895 was not sufficient, increasing timeouts again.
46
47         * Scripts/webkitpy/xcode/simulated_device.py:
48         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
49
50 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
51
52         Formatting fix to remove extra space.
53
54         Unreviewed formatting fix.
55
56         * Scripts/webkitdirs.pm:
57         (isEmbeddedWebKit): Remove extra space.
58
59 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
60
61         Rename isIOSLikeWebKit to isEmbeddedWebKit.
62
63         Rubber-stamped by Alexey Proskuryakov. 
64
65         * Scripts/webkitdirs.pm:
66         (isEmbeddedWebKit): Added
67         (isIOSLikeWebKit): Deleted.
68
69 2017-04-05  Alex Christensen  <achristensen@webkit.org>
70
71         Fix CMake build.
72
73         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
74         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
75         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
76         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
77         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
78         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
79         * WebKitTestRunner/PlatformMac.cmake:
80         Add some missing files.
81         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
82
83 2017-04-05  Keith Miller  <keith_miller@apple.com>
84
85         Add debug option to run-jsc script
86         https://bugs.webkit.org/show_bug.cgi?id=170503
87
88         Reviewed by Yusuke Suzuki.
89
90         Adds a new option to the run-jsc script so that when passed
91         "--debug" it will wrap the jsc call with an lldb invocation. If
92         someone wishes to use a different debugger they can set the
93         DEBUGGER environment variable. Additionally, run-jsc now exits
94         with the exit status of the jsc call.
95
96         * Scripts/run-jsc:
97
98 2017-04-05  Andy Estes  <aestes@apple.com>
99
100         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
101         https://bugs.webkit.org/show_bug.cgi?id=170365
102         <rdar://problem/29205721>
103
104         Reviewed by Tim Horton.
105
106         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
107         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
108         (TEST): Re-enabled the test, which now passes.
109
110 2017-04-05  Andy Estes  <aestes@apple.com>
111
112         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
113         https://bugs.webkit.org/show_bug.cgi?id=167594
114
115         Re-enabled this API test now that webkit.org/b/161967 is fixed.
116
117         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
118         (TEST):
119
120 2017-04-05  Andy Estes  <aestes@apple.com>
121
122         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
123         https://bugs.webkit.org/show_bug.cgi?id=161967
124
125         Reviewed by Alexey Proskuryakov.
126
127         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
128         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
129
130 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
131
132         Various settings in Minibrowser are off by default, and should be on
133         https://bugs.webkit.org/show_bug.cgi?id=170465
134         rdar://problem/31421543
135
136         Reviewed by Tim Horton.
137
138         Explicitly set preferences that should be on by default to enabled, if they have not been
139         set previously.
140
141         * MiniBrowser/mac/SettingsController.m:
142         (-[SettingsController init]):
143
144 2017-04-04  JF Bastien  <jfbastien@apple.com>
145
146         Add JF Bastien as reviewer
147         https://bugs.webkit.org/show_bug.cgi?id=170481
148
149         Reviewed by Mark Lam.
150
151         * Scripts/webkitpy/common/config/contributors.json:
152
153 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
154
155         Increase timeouts for simulator testing
156
157         Unreviewed infrastructure fix.
158
159         * Scripts/webkitpy/port/simulator_process.py:
160         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
161         * Scripts/webkitpy/xcode/simulated_device.py:
162         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
163
164 2017-04-04  Tim Horton  <timothy_horton@apple.com>
165
166         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
167         https://bugs.webkit.org/show_bug.cgi?id=165801
168         <rdar://problem/29649535>
169
170         Reviewed by Wenson Hsieh.
171
172         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
173         (TEST):
174         Add some tests for wrapping finds.
175
176 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
177
178         Add some new patterns to filter-build-webkit
179         https://bugs.webkit.org/show_bug.cgi?id=170429
180
181         Reviewed by Alexey Proskuryakov.
182
183         * Scripts/filter-build-webkit:
184         (setOutputFormatOption):
185
186 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
187
188         Data interaction should register type identifiers in order of priority
189         https://bugs.webkit.org/show_bug.cgi?id=170428
190         <rdar://problem/30633296>
191
192         Reviewed by Tim Horton.
193
194         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
195         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
196         test for data interaction from a textarea to an input.
197
198         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
199         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
200         (TestWebKitAPI::TEST):
201         * TestWebKitAPI/ios/DataInteractionSimulator.h:
202         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
203         (-[DataInteractionSimulator _advanceProgress]):
204         (-[DataInteractionSimulator sourceItemProviders]):
205         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
206
207 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
208
209         [GTK][JHBuild] Update mesa repository url for tarballs
210         https://bugs.webkit.org/show_bug.cgi?id=170431
211
212         Reviewed by Michael Catanzaro.
213
214         * gtk/jhbuild.modules:
215
216 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
217
218         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
219         https://bugs.webkit.org/show_bug.cgi?id=170430
220
221         Reviewed by Alexey Proskuryakov.
222
223         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
224         Eliminate one of the copies of Ahem.ttf.
225
226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
227         Once eliminated, there is now only one Ahem.ttf that is copied
228         to the Resources bundle. Drive-by sort the project file.
229
230 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
231
232         Allow MiniBrowser windows to receive local file drags again
233         https://bugs.webkit.org/show_bug.cgi?id=170422
234
235         Reviewed by Wenson Hsieh.
236
237         Adopt the new UIDelegate SPI to allow drops.
238
239         * MiniBrowser/mac/WK2BrowserWindowController.m:
240         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
241
242 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
243
244         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
245         https://bugs.webkit.org/show_bug.cgi?id=170426
246
247         Reviewed by Michael Catanzaro.
248
249         * gtk/jhbuild.modules:
250
251 2017-04-03  Nan Wang  <n_wang@apple.com>
252
253         AX: Expose link children when doing search predication on iOS
254         https://bugs.webkit.org/show_bug.cgi?id=170424
255         <rdar://problem/31413335>
256
257         Reviewed by Chris Fleizach.
258
259         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
260         (AccessibilityUIElement::uiElementForSearchPredicate):
261         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
262         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
263
264 2017-04-03  Brian Burg  <bburg@apple.com>
265
266         run-safari should support launching with custom language and locale
267         https://bugs.webkit.org/show_bug.cgi?id=170397
268
269         Reviewed by Alexey Proskuryakov.
270
271         Hook up -AppleLanguages and -AppleLocale to command line options.
272
273         * Scripts/webkitdirs.pm:
274         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
275         (argumentsForRunAndDebugMacWebKitApp):
276
277 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
278
279         webkitpy: Provide option to skip install
280         https://bugs.webkit.org/show_bug.cgi?id=170344
281
282         Reviewed by Alexey Proskuryakov.
283
284         Installing can take time for on device testing.  Provide an option to skip install
285         and use whatever driver is currently installed on the device or simulator.
286
287         * Scripts/webkitpy/port/base.py:
288         (Port.check_build): Do not check driver if skipping install.
289         * Scripts/webkitpy/port/factory.py:
290         (platform_options): Add '--no-install' option.
291         * Scripts/webkitpy/port/ios.py:
292         (IOSPort.setup_test_run): Check install option before installing.
293
294 2017-04-03  Keith Miller  <keith_miller@apple.com>
295
296         WebAssembly: Update spec tests
297         https://bugs.webkit.org/show_bug.cgi?id=170361
298
299         Rubber-stamped by Saam Barati.
300
301         Update the runner to know the new wasm spec test harness code.
302
303         * Scripts/run-jsc-stress-tests:
304
305 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
306
307         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
308
309         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
310         https://bugs.webkit.org/show_bug.cgi?id=170365
311
312         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
313
314 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
315
316         Mac cmake buildfix after 214586.
317         https://bugs.webkit.org/show_bug.cgi?id=170381
318
319         Unreviewed speculative buildfix.
320
321         * WebKitTestRunner/PlatformMac.cmake:
322
323 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
324
325         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
326         https://bugs.webkit.org/show_bug.cgi?id=161675
327
328         * WebKitTestRunner/PlatformMac.cmake:
329
330 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
331
332         webkitpy: Add target host concept
333         https://bugs.webkit.org/show_bug.cgi?id=170186
334         <rdar://problem/31301797>
335
336         Reviewed by Alexey Proskuryakov.
337
338         Adding the idea of a target host. Target hosts are objects conforming to the
339         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
340         Target hosts are the hosts associated with a worker process.
341
342         * Scripts/webkitpy/common/system/filesystem.py:
343         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
344         host to an absolute path on this host.
345         (FileSystem.move_to_base_host): Move file from this host to the base host.
346         (FileSystem.move_from_base_host): Move file from the base host to this host.
347         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
348         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
349         * Scripts/webkitpy/common/system/filesystem_mock.py:
350         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
351         host to an absolute path on this host.
352         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
353         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
354         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
355         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
356         * Scripts/webkitpy/port/base.py:
357         (Port.target_host): Return host determined by worker number.
358         (Port.abspath_for_test): Accept optional target_host argument to return location
359         of test on a target host.
360         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
361         directory on a target host.
362         (Port.sample_process): Accept optional target_host argument to sample process on
363         a target host.
364         * Scripts/webkitpy/port/darwin.py:
365         (DarwinPort.sample_process): Run sample process on target host.
366         (DarwinPort.sample_file_path): Accept directory for file.
367         (DarwinPort.spindump_file_path): Ditto.
368         * Scripts/webkitpy/port/darwin_testcase.py:
369         (DarwinTest.test_spindump): Check file movement.
370         (DarwinTest.test_sample_process): Ditto.
371         (DarwinTest.test_sample_process_exception):
372         * Scripts/webkitpy/port/driver.py:
373         (Driver.__init__): Add and set self._target_host variable.
374         (Driver._start): Pass target host to _driver_tempdir().
375         (Driver.stop): Call the target host's rmtree.
376         (Driver._check_for_driver_timeout): Pass target host to sample_process.
377         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
378         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
379         layout test directory to target host.
380         * Scripts/webkitpy/port/ios.py:
381         (IOSPort):
382         (IOSPort.target_host): Replaced device_for_worker_number.
383         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
384         (IOSPort.device_for_worker_number): Replaced with target_host.
385         * Scripts/webkitpy/port/server_process.py:
386         (ServerProcess.__init__): Accept target_host instead of worker_number.
387         (ServerProcess._start): Replace _host with _target_host.
388         (ServerProcess._handle_timeout): Ditto.
389         (ServerProcess._kill): Ditto.
390         * Scripts/webkitpy/port/simulator_process.py:
391         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
392         (SimulatorProcess._start): Replace _device with _target_host.
393         (SimulatorProcess.stop): Ditto.
394         (SimulatorProcess._kill): Deleted.
395
396 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
397
398         Unreviewed fix after r214569
399         https://bugs.webkit.org/show_bug.cgi?id=170255
400
401         Unreviewed infrastructure fix.
402
403         * Scripts/webkitpy/port/ios.py:
404         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
405
406 2017-03-31  Andy Estes  <aestes@apple.com>
407
408         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
409         https://bugs.webkit.org/show_bug.cgi?id=170365
410         <rdar://problem/29205721>
411
412         Reviewed by Tim Horton.
413
414         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
415         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
416         (TEST): Re-enabled the test, which now passes.
417
418 2017-03-31  Tim Horton  <timothy_horton@apple.com>
419
420         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
421         https://bugs.webkit.org/show_bug.cgi?id=170326
422         <rdar://problem/30330395>
423
424         Reviewed by Simon Fraser.
425
426         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
427         (TEST):
428
429 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
430
431         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
432
433         Fixes: http/tests/ssl/upgrade-origin-usage.html
434                http/tests/websocket/tests/hybi/network-process-crash-error.html
435                http/tests/websocket/tests/hybi/simple-wss.html
436
437         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
438         (WTR::TestController::platformContext): Return the context.
439
440 2017-03-30  Sam Weinig  <sam@webkit.org>
441
442         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
443         https://bugs.webkit.org/show_bug.cgi?id=170315
444
445         Reviewed by Simon Fraser.
446
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
449         Add test showing the completion handler is called.
450
451 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
452
453         Air should support linear scan for optLevel<2
454         https://bugs.webkit.org/show_bug.cgi?id=170161
455
456         Reviewed by Saam Barati.
457         
458         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
459         pipeline.
460
461         * Scripts/run-jsc-stress-tests:
462
463 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
464
465         Support tvOS and watchOS in webkitdirs.pm
466         https://bugs.webkit.org/show_bug.cgi?id=170267
467
468         Reviewed by Alexey Proskuryakov.
469
470         * Scripts/webkitdirs.pm:
471         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
472         (xcodeSDKPlatformName): Added support for tvos and watchos.
473         (determinePortName): Same.
474         (isAppleCocoaWebKit): Same.
475         (willUseAppleTVDeviceSDK): Added.
476         (willUseAppleTVSimulatorSDK): Added.
477         (willUseWatchDeviceSDK): Added.
478         (willUseWatchSimulatorSDK): Added.
479         (isTVOSWebKit): Added.
480         (isWATCHOSWebKit): Added.
481         (isIOSLikeWebKit): Added.
482
483 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
484
485         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
486         https://bugs.webkit.org/show_bug.cgi?id=170291
487         <rdar://problem/31301388>
488
489         Reviewed by Tim Horton.
490
491         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
492         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
493         shared UIApplication, and verify that data interaction completes successfully.
494
495         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
496         (TestWebKitAPI::TEST):
497         * TestWebKitAPI/ios/DataInteractionSimulator.h:
498         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
499         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
500         (-[DataInteractionSimulator initWithWebView:]):
501         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
502         (-[DataInteractionSimulator runFrom:to:]):
503         (-[DataInteractionSimulator _advanceProgress]):
504         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
505
506 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
507
508         [Win] Pass close_fds = True in Python popen call.
509         https://bugs.webkit.org/show_bug.cgi?id=170172
510
511         Reviewed by Brent Fulgham.
512
513         This was previously not supported on Windows, but in Python 2.7.10 it is.
514
515         * Scripts/webkitpy/common/system/executive.py:
516         (Executive._should_close_fds):
517         * Scripts/webkitpy/port/server_process.py:
518         (ServerProcess._start):
519
520 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
521
522         Change my status to be a WebKit reviewer.
523
524         Unreviewed status update edit.
525
526         * Scripts/webkitpy/common/config/contributors.json:
527
528 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
529
530         Change my status to be a WebKit reviewer.
531
532         Unreviewed status update edit.
533
534         * Scripts/webkitpy/common/config/contributors.json:
535
536 2017-03-29  Tim Horton  <timothy_horton@apple.com>
537
538         Swipe gesture tests don't work on macOS Sierra
539         https://bugs.webkit.org/show_bug.cgi?id=161675
540         <rdar://problem/23379930>
541
542         Reviewed by Darin Adler.
543
544         * DumpRenderTree/mac/UIScriptControllerMac.mm:
545         (WTR::UIScriptController::platformPlayBackEventStream):
546         (WTR::UIScriptController::beginBackSwipe):
547         (WTR::UIScriptController::completeBackSwipe):
548         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
549         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
550         (eventIsOfType):
551         (eventIsOfTypes):
552         (eventIsOfGestureType):
553         (eventIsOfGestureTypes):
554         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
555         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
556         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
557         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
558         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
559         (beginSwipeBackEventStream):
560         (completeSwipeBackEventStream):
561         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
562         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
563         (WTR::UIScriptController::playBackEventStream):
564         (WTR::UIScriptController::beginBackSwipe):
565         (WTR::UIScriptController::completeBackSwipe):
566         (WTR::UIScriptController::platformPlayBackEventStream):
567         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
568         * TestRunnerShared/UIScriptContext/UIScriptController.h:
569         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
570         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
571         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
572         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
573         (WTR::playBackEvents):
574         (WTR::UIScriptController::beginBackSwipe):
575         (WTR::UIScriptController::completeBackSwipe):
576         (WTR::UIScriptController::platformPlayBackEventStream):
577
578 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
579
580         webkitpy: Robust test clean-up
581         https://bugs.webkit.org/show_bug.cgi?id=170255
582
583         Reviewed by Alexey Proskuryakov.
584
585         On-device testing is the motivation for this change.  Failure to run clean-up functions can
586         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
587         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
588
589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
590         (Manager._set_up_run): Clean up test run if set-up fails.
591         * Scripts/webkitpy/port/ios.py:
592         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
593
594 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
595
596         Simulator testing stops after the first crash
597         <rdar://problem/31325362>
598
599         Unreviewed infrastructure fix.
600
601         * Scripts/webkitpy/xcode/simulated_device.py:
602         (SimulatedDevice):
603         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
604
605 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
606
607         webkitpy: Standardize web-server port definitions
608         https://bugs.webkit.org/show_bug.cgi?id=170144
609         <rdar://problem/31284026>
610
611         Reviewed by Daniel Bates.
612
613         Default web-server ports should be declared in global variables.
614         Add functions to web-servers which return the ports these servers
615         are using so that other tools can forward them.
616
617         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
618         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
619         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
620         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
621         * Scripts/webkitpy/layout_tests/servers/http_server.py:
622         (Lighttpd.__init__): Use shared constants in http_server_base.py.
623         (Lighttpd._prepare_config): Ditto.
624         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
625         (HttpServerBase): Add default port constants.
626         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
627         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
628         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
629         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
630          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
631         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
632         (PyWebSocket): Make default port values public.
633         (PyWebSocket.__init__): Use public default port.
634         (PyWebSocket.ports_to_forward): Return port used in an array.
635         * Scripts/webkitpy/port/base.py:
636         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
637         (Port.to.start_websocket_server): Use PyWebSocket port constants.
638
639 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
640
641         Links with empty hrefs should not be drag sources
642         https://bugs.webkit.org/show_bug.cgi?id=170241
643         <rdar://problem/31305505>
644
645         Reviewed by Tim Horton.
646
647         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
648
649         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
650         (TestWebKitAPI::TEST):
651         * TestWebKitAPI/ios/DataInteractionSimulator.h:
652
653         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
654
655         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
656         (-[DataInteractionSimulator phase]):
657
658 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
659
660         Use TCP instead of FIFOs for Simulator/Device communication
661         https://bugs.webkit.org/show_bug.cgi?id=169419
662         <rdar://problem/30949615>
663
664         Reviewed by Alexey Proskuryakov.
665
666         Using TCP instead of FIFOs when communicating with devices allows the device being tested
667         to be on a different machine then the one handling the management of the test run.
668
669         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
670         * DumpRenderTree/mac/DumpRenderTree.mm:
671         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
672         * Scripts/webkitpy/port/device.py:
673         (Device.__init__): Initialize the listening_socket.
674         (Device.listening_port): Return port of listening socket.
675         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
676         fro testing.
677         (Device.finished_testing): Close listening socket associated with this device, call the
678         platform device's finished_testing function if it exists.
679         * Scripts/webkitpy/port/ios.py:
680         (IOSPort.setup_test_run): Prepare each device for testing.
681         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
682         * Scripts/webkitpy/port/ios_simulator.py:
683         (IOSSimulatorPort): Work around device persistence bug.
684         (IOSSimulatorPort.__init__): Ditto.
685         * Scripts/webkitpy/port/simulator_process.py:
686         (SimulatorProcess):
687         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
688         Python 2’s makefile.
689         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
690         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
691         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
692         (SimulatorProcess.__getattr__): Expose all file attributes.
693         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
694         create and return a file-like object from the incoming connection.
695         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
696         (SimulatorProcess._start.handler): Output server port in timeout exception.
697         (SimulatorProcess._reset): Deleted.
698         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
699         (connectToServer): Return socket connected to the provided server address.
700         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
701         TCP server running on localhost.
702         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
703         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
704         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
705         * WebKitTestRunner/ios/TestControllerIOS.mm:
706         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
707         instead of using FIFOs.
708         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
709
710 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
711
712         webkitpy: Add IOSDevicePort and IOSPort tests
713         https://bugs.webkit.org/show_bug.cgi?id=170206
714         <rdar://problem/31308364>
715
716         Reviewed by Alexey Proskuryakov.
717
718         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
719         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
720         (iosDeviceTest): Contains tests for the IOSDevicePort.
721         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
722         (iosDeviceTest.test_operating_system): Check for the correct operating system.
723         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
724         (iosSimulatorTest): Inherit from ios_testcase.
725         (iosSimulatorTest.make_port): Ditto.
726         (iosSimulatorTest.test_get_crash_log): Ditto.
727         * Scripts/webkitpy/port/ios_testcase.py: Added.
728         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
729         (iOSTest.test_driver_name): Tests for iOS app driver.
730         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
731         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
732         * Scripts/webkitpy/port/port_testcase.py:
733         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
734         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
735         (PortTestCase.test_diff_image_crashed): Ditto.
736
737 2017-03-28  Jason Marcell  <jmarcell@apple.com>
738
739         Fix `index-expected.txt` for dashboard test results.
740         https://bugs.webkit.org/show_bug.cgi?id=170214
741
742         Reviewed by Alexey Proskuryakov.
743
744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
745
746 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
747
748         Bot watcher's dashboard has separate settings for "mac" and "macos"
749         https://bugs.webkit.org/show_bug.cgi?id=170164
750
751         Reviewed by Tim Horton.
752
753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
754         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
755
756 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
757
758         Fix dashboard test results on the dashboard
759         https://bugs.webkit.org/show_bug.cgi?id=170158
760
761         Reviewed by Tim Horton.
762
763         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
764         further improved, as it's not super readable, but stdio is entirely useless in this context.
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
767         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
768
769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
770         Fixed a typo in step name, so that it's actually treated as productive.
771
772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
773         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
774         (BuildbotTesterQueueView.prototype.update):
775         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
776         Added special handling for dashboard test results.
777
778 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
779
780         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
781         https://bugs.webkit.org/show_bug.cgi?id=170193
782
783         Reviewed by Alexey Proskuryakov.
784
785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
786         Fixed the order of arguments.
787
788 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
789
790         Dashboard tests fails to fetch the revision from commits
791         https://bugs.webkit.org/show_bug.cgi?id=170191
792
793         Reviewed by Alexey Proskuryakov.
794
795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
796         Added recordedCommitIndicesByRevisionNumber.
797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
798         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
799
800 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
801
802         Safari crashes when attempting to close tab that is displaying PDF
803         https://bugs.webkit.org/show_bug.cgi?id=170201
804         <rdar://problem/31242019>
805
806         Reviewed by Wenson Hsieh.
807
808         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
809         (TEST):
810         Add a test for doAfterNextStablePresentationUpdate just like the existing
811         non-stable one.
812
813 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
814
815         webkitpy: Use host pattern for devices
816         https://bugs.webkit.org/show_bug.cgi?id=170121
817
818         Reviewed by Daniel Bates.
819
820         Devices should be treated like hosts throughout webkitpy
821         so that more code can be re-used.  Add the needed properties
822         and use executive over custom implemented polling/killing
823         functions.
824
825         * Scripts/webkitpy/port/device.py:
826         (Device):
827         (Device.executive): Add optional executive property.
828         (Device.filesystem): Add optional filesystem property.
829         (Device.user): Add optional user property.
830         (Device.platform): Add optional platform property.
831         (Device.workspace): Add optional workspace property.
832         (Device.poll): Deleted.
833         * Scripts/webkitpy/port/simulator_process.py:
834         (SimulatorProcess.Popen.poll): Use the devices executive.
835         (SimulatorProcess.stop): Ditto.
836         (SimulatorProcess._kill): Ditto.
837         * Scripts/webkitpy/xcode/simulated_device.py:
838         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
839         and workspace to the platform device.
840         (SimulatedDevice.poll): Deleted.
841
842 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
843
844         Dashboard test fails with error: latestIterationGetter is not a function
845         https://bugs.webkit.org/show_bug.cgi?id=170167
846
847         Reviewed by Alexey Proskuryakov.
848
849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
850         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
851
852 2017-03-27  Lucas Forschler  <lforschler@apple.com>
853
854         Another test v8.
855
856 2017-03-27  Lucas Forschler  <lforschler@apple.com>
857
858         Another test v7.
859
860 2017-03-27  Lucas Forschler  <lforschler@apple.com>
861
862         Another test v6.
863
864 2017-03-27  Lucas Forschler  <lforschler@apple.com>
865
866         Another test v5.
867
868 2017-03-27  Lucas Forschler  <lforschler@apple.com>
869
870         Another test v4.
871
872 2017-03-27  Lucas Forschler  <lforschler@apple.com>
873
874         Another test v3.
875
876 2017-03-27  Lucas Forschler  <lforschler@apple.com>
877
878         Another test v2.
879
880 2017-03-27  Lucas Forschler  <lforschler@apple.com>
881
882         Another test.
883
884 2017-03-27  Lucas Forschler  <lforschler@apple.com>
885
886         <rdar://problem/30949128>
887         Update build.webkit.org to use port 16000 for PBChangeSource.
888         
889         Reviewed by Alexey Proskuryakov.
890
891         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
892
893 2017-03-27  Jason Marcell  <jmarcell@apple.com>
894
895         Bots should run the dashboard tests
896         https://bugs.webkit.org/show_bug.cgi?id=168994
897
898         Reviewed by Daniel Bates and David Kilzer.
899
900         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
901
902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
903         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
904         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
905         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
906         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
907         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
908         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
909         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
911
912 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
913
914         webkitpy: Look for 'ios' test expectations for IOSPorts
915         https://bugs.webkit.org/show_bug.cgi?id=169413
916
917         Reviewed by Alexey Proskuryakov.
918
919         Test expectations for iOS tests should include the 'ios' folder.  Modify
920         default_baseline_search_path to include 'ios' folder and derivatives for
921         IOSPort.
922
923         * Scripts/webkitpy/port/ios.py:
924         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
925         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
926         (IOSPort.test_expectations_file_position): Added for testing.
927         * Scripts/webkitpy/port/ios_simulator.py:
928         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
929         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
930
931 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
932
933         REGRESSION: Reseting _device_map on each child process
934         <rdar://problem/31274476>
935
936         Unreviewed infrastructure fix.
937
938         * Scripts/webkitpy/port/ios_simulator.py:
939         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
940         (IOSSimulatorPort.__init__): Use shared class variable
941         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
942         (IOSSimulatorPort._create_devices): Ditto.
943         (IOSSimulatorPort._quit_ios_simulator): Ditto.
944         (IOSSimulatorPort.clean_up_test_run): Ditto.
945
946 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
947
948         REGRESSION: Failing to iterate over Simulator.managed_devices map
949         <rdar://problem/31274476>
950
951         Unreviewed infrastructure fix.
952
953         * Scripts/webkitpy/port/ios_simulator.py:
954         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
955
956 2017-03-27  Alex Christensen  <achristensen@webkit.org>
957
958         Make WebSockets work in network process
959         https://bugs.webkit.org/show_bug.cgi?id=169930
960
961         Reviewed by Youenn Fablet.
962
963         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
964         Add terminateNetworkProcess for the new test
965         http/tests/websocket/tests/hybi/network-process-crash-error.html
966         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
967         (WTR::TestRunner::setAllowsAnySSLCertificate):
968         (WTR::TestRunner::terminateNetworkProcess):
969         * WebKitTestRunner/InjectedBundle/TestRunner.h:
970         * WebKitTestRunner/TestController.cpp:
971         (WTR::TestController::setAllowsAnySSLCertificate):
972         (WTR::TestController::terminateNetworkProcess):
973         * WebKitTestRunner/TestController.h:
974         * WebKitTestRunner/TestInvocation.cpp:
975         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
976         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
977         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
978         (WTR::TestController::platformContext):
979         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
980         (WTR::TestController::platformContext):
981         (WTR::TestController::platformLibraryPathForTesting):
982         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
983         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
984         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
985         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
986         which tests that wss works, but our test certificate has an invalid certificate chain.
987         We want production software to not have the ability to have its security weakened, so this
988         is a test code path that is only implemented in WebKitTestRunner.
989
990 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
991
992         webkitpy: Use generalized device instead of platform specific one
993         https://bugs.webkit.org/show_bug.cgi?id=170078
994
995         Reviewed by Daniel Bates.
996
997         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
998         should remain persistent.  Changing Device to a more explicit interface.
999         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
1000         wrapping SimulatedDevices.
1001
1002         * Scripts/webkitpy/port/device.py: Added.
1003         (Device):
1004         (Device.__init__): Construct with platform device.
1005         (Device.install_app): Install app at app path on platform device.
1006         (Device.launch_app): Launch app with bundle ID on platform device.
1007         (Device.poll): Poll platform device.
1008         (Device.udid): Access platform device UDID.
1009         (Device.__nonzero__): Check if instantiated with a valid platform device.
1010         (Device.__eq__): Compare by udid.
1011         (Device.__ne__): Ditto.
1012         (Device.__repr__): Print out platform_device representation.
1013         * Scripts/webkitpy/port/ios_simulator.py:
1014         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
1015         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
1016         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
1017         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
1018         device map.
1019         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
1020         * Scripts/webkitpy/xcode/device.py: Removed.
1021         * Scripts/webkitpy/xcode/simulated_device.py:
1022         (SimulatedDevice):
1023         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
1024         (SimulatedDevice.__eq__): Compare two simulated devices.
1025         (SimulatedDevice.__ne__): Ditto.
1026         (SimulatedDevice.__repr__): Print name and udid.
1027
1028 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
1029
1030         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
1031         https://bugs.webkit.org/show_bug.cgi?id=170059
1032
1033         Reviewed by Carlos Garcia Campos.
1034
1035         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
1036         the only use of the method in this same file ignores the returned value anyway.
1037
1038 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1039
1040         webkitpy should be able to run API tests
1041         https://bugs.webkit.org/show_bug.cgi?id=170028
1042
1043         Reviewed by Alexey Proskuryakov.
1044
1045         * Scripts/webkitpy/common/config/ports.py:
1046         (DeprecatedPort.run_api_tests_command): Added.
1047         * Scripts/webkitpy/port/base.py:
1048         (Port.api_results_directory): Added.
1049         * Scripts/webkitpy/tool/steps/runtests.py:
1050         (RunTests.run): Check if we should be running API tests.
1051         (RunTests._run_api_tests): Generate script to run API tests with json output.
1052         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
1053
1054 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1055
1056         Add JSON results for API tests
1057         https://bugs.webkit.org/show_bug.cgi?id=170021
1058
1059         Reviewed by Alexey Proskuryakov.
1060
1061         * Scripts/run-api-tests:
1062         (runTestsBySuite): Appends failures and timeouts to JSON data.
1063         (writeJsonDataIfApplicable): Writes JSON data to a file.
1064
1065 2017-03-24  Lucas Forschler  <lforschler@apple.com>
1066
1067         update committer_auth.py to be python 2.7 compliant
1068         https://bugs.webkit.org/show_bug.cgi?id=170063
1069         
1070         Reviewed by Alexey Proskuryakov.
1071
1072         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
1073         (CommitterAuth.authenticate):
1074             convert e.message to e.args[0]
1075
1076 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1077
1078         webkitpy: Parse JSON results from run-api-tests
1079         https://bugs.webkit.org/show_bug.cgi?id=170062
1080
1081         Reviewed by Alexey Proskuryakov.
1082
1083         * Scripts/webkitpy/common/net/apitestresults.py: Added.
1084         (APITestResults): Structure to represent API test results.
1085         (APITestResults.__init__):
1086         (APITestResults.intersection): Return the failures common to both sets of results.
1087         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
1088         (APITestResults.equals): Return True if both results were the same.
1089         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
1090         (APITestResults.all_passed): Return True if everything passed.
1091         (APITestResults.failing_tests): List of tests that didn't pass.
1092         (APITestResults.did_exceed_test_failure_limit): Always False.
1093         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
1094         (APITestResultsTest): Unit tests.
1095         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
1096         (APITestResultsReader): Read contents of JSON results file.
1097
1098 2017-03-24  Alex Christensen  <achristensen@webkit.org>
1099
1100         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
1101         https://bugs.webkit.org/show_bug.cgi?id=169167
1102
1103         Reviewed by Simon Fraser.
1104
1105         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1106         (TestWebKitAPI::TEST_F):
1107         Test an example of a selector that was incorrectly determined to be invalid.
1108
1109 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
1110
1111         Increase timeout for booting simulators.
1112         <rdar://problem/31080009>
1113
1114         Unreviewed infrastructure fix.
1115
1116         * Scripts/webkitpy/xcode/simulator.py:
1117         (Simulator.wait_until_device_is_booted): Increase timeout.
1118         (Simulator.wait_until_device_is_in_state): Increase timeout.
1119
1120 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1121
1122         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
1123
1124         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
1125         in our unit tests to work.
1126
1127         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1128         (testWebViewJavaScriptDialogs):
1129
1130 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1131
1132         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
1133         https://bugs.webkit.org/show_bug.cgi?id=170001
1134
1135         Reviewed by Michael Catanzaro.
1136
1137         Ignore style of xdgmime sources.
1138
1139         * Scripts/webkitpy/tool/steps/checkstyle.py:
1140
1141 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1142
1143         Dragging on a large image should not revert to a file icon if data interaction is enabled
1144         https://bugs.webkit.org/show_bug.cgi?id=170018
1145         <rdar://problem/31184508>
1146
1147         Reviewed by Tim Horton.
1148
1149         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
1150         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
1151
1152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1153         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
1154         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1155         (TestWebKitAPI::TEST):
1156
1157 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1158
1159         Update WinCairoRequirements.zip
1160         https://bugs.webkit.org/show_bug.cgi?id=169950
1161
1162         Reviewed by Alex Christensen.
1163
1164         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
1165
1166 == Rolled over to ChangeLog-2017-03-23 ==