[EFL] Fix a crash on MiniBrowser when running on debug mode
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2
3         Unreviewed, updated my list of email addresses.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
8
9         [cmake] Fix the style issues in cmake project files
10         https://bugs.webkit.org/show_bug.cgi?id=145755
11
12         Reviewed by Darin Adler.
13
14         * TestWebKitAPI/CMakeLists.txt:
15         * TestWebKitAPI/PlatformEfl.cmake:
16
17 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
18
19         Fix a typo in r185345.
20
21         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
22         (OSXSafariDriver.closeBrowsers):
23
24 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
25
26         Yet another unreviewed build fix :(
27
28         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
29         (OSXSafariDriver):
30         (OSXSafariDriver.launchUrl):
31         (OSXSafariDriver.closeBrowsers):
32
33 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
34
35         Unreviewed build fix. Initialize result in the case things blow up below.
36
37         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
38         (BenchmarkRunner.execute):
39
40 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
41
42         Partially revert and fix after r185243.
43
44         * Scripts/benchmark_runner/benchmark_runner.py:
45         * Scripts/run-benchmark:
46
47 2015-06-08  Daniel Bates  <dabates@apple.com>
48
49         Many LayoutTests/http tests time out in DumpRenderTree
50         https://bugs.webkit.org/show_bug.cgi?id=145770
51         <rdar://problem/19593910>
52
53         Reviewed by Alexey Proskuryakov.
54
55         * DumpRenderTree/ios/Info.plist: Add ATS key.
56         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
57         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
58         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
59         that make use of testRunner.pathToLocalResource().
60
61 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
62
63         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
64         https://bugs.webkit.org/show_bug.cgi?id=145759
65
66         Reviewed by Carlos Garcia Campos.
67
68         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
69         (testWebViewSave):
70
71 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
72
73         [GTK] Add editor mode to MiniBrowser
74         https://bugs.webkit.org/show_bug.cgi?id=145595
75
76         Reviewed by Sergio Villar Senin.
77
78         It loads an empty editable web view with an edit toolbar. It makes
79         easier to test the editor, editing commands and input methods.
80
81         * MiniBrowser/gtk/BrowserWindow.c:
82         (editingCommandCallback):
83         (browserWindowSetupEditorToolbar):
84         (browserWindowConstructed):
85         * MiniBrowser/gtk/main.c:
86         (createBrowserWindow):
87
88 2015-06-05  Zalan Bujtas  <zalan@apple.com>
89
90         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
91
92         Reviewed by Dan Bernstein.
93
94         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
95         (TestWebKitAPI::TEST):
96
97 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
98
99         [EFL] API test has been broken since r184357
100         https://bugs.webkit.org/show_bug.cgi?id=145635
101
102         Reviewed by Darin Adler.
103
104         r184357 suppress cmake build warning using TARGET_FILE property. However
105         many EFL API test cases have been broken after applying it.
106
107         * TestWebKitAPI/CMakeLists.txt:
108
109 2015-06-05  Anders Carlsson  <andersca@apple.com>
110
111         Make the network cache directory part of WKContextConfigurationRef
112         https://bugs.webkit.org/show_bug.cgi?id=145711
113
114         Reviewed by Antti Koivisto.
115
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::initialize):
118
119 2015-06-05  Anders Carlsson  <andersca@apple.com>
120
121         Make the application cache directory part of WKContextConfigurationRef
122         https://bugs.webkit.org/show_bug.cgi?id=145704
123
124         Reviewed by Geoffrey Garen.
125
126         * WebKitTestRunner/TestController.cpp:
127         (WTR::TestController::initialize):
128
129 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
130
131         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
132         https://bugs.webkit.org/show_bug.cgi?id=145680
133
134         Reviewed by Brent Fulgham.
135
136         * Scripts/webkitpy/style/checkers/cpp.py:
137         (check_for_null):
138         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
139         (WebKitStyleTest.test_null_false_zero):
140
141 2015-06-05  Stephanie Lewis  <slewis@apple.com>
142
143         Make the web server more robust to timing issues..
144
145         Reviewed by Ryosuke Niwa.
146
147         Cleaned up exception handling.
148         Test server is actually serving pages before returning.
149         Clean up some style issues.
150
151         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
152         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
153         (SimpleHTTPServerDriver.__init__):
154         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
155         (SimpleHTTPServerDriver.baseUrl): 
156         (SimpleHTTPServerDriver.fetchResult):
157         (SimpleHTTPServerDriver.killServer):
158         (SimpleHTTPServerDriver.getReturnCode):
159
160 2015-06-05  Stephanie Lewis  <slewis@apple.com>
161
162
163         Add errors to run-benchmark exception handling.
164
165         Reviewed by Ryosuke Niwa.
166
167         * Scripts/run-benchmark:
168         (main):
169         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
170         (GenericBenchmarkBuilder.prepare):
171         (GenericBenchmarkBuilder._runCreateScript):
172         (GenericBenchmarkBuilder._applyPatch):
173         (GenericBenchmarkBuilder.clean):
174         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
175         (BenchmarkRunner.__init__):
176         (BenchmarkRunner.execute):
177         (BenchmarkRunner):
178         (BenchmarkRunner.cleanup):
179         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
180         (GenericFactory.iterateGetItem):
181         (GenericFactory.create):
182         * Scripts/webkitpy/benchmark_runner/utils.py:
183         (loadModule):
184         (loadJSONFromFile):
185         (forceRemove):
186
187 2015-06-05  Stephanie Lewis  <slewis@apple.com>
188
189         Streamline run-benchmark browser
190
191         Reviewed by Ryosuke Niwa.
192
193         Add Caffeinate so computer won't sleep while running.
194         Remove calls to collect output since we were just dumping to stdout anyway.
195         Add xpc dyld_path.
196         Default to system safari.
197
198         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
199         (OSXBrowserDriver.launchProcess):
200         (OSXBrowserDriver.terminateProcesses):
201         (OSXBrowserDriver):
202         (OSXBrowserDriver.launchCaffeinateForProcess):
203         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
204         (OSXSafariDriver.launchUrl):
205         (OSXSafariDriver.closeBrowsers):
206
207 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
208
209         Combine tiny DFAs into slightly larger ones
210         https://bugs.webkit.org/show_bug.cgi?id=145572
211
212         Reviewed by Alex Christensen.
213
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
216         (TestWebKitAPI::DFACombinerTest::SetUp):
217         (TestWebKitAPI::combine):
218         (TestWebKitAPI::TEST_F):
219         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
220         (TestWebKitAPI::countLiveNodes):
221         (TestWebKitAPI::createNFAs):
222         (TestWebKitAPI::buildDFAFromPatterns):
223         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
224         (TestWebKitAPI::countLiveNodes): Deleted.
225         (TestWebKitAPI::createNFAs): Deleted.
226         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
227
228 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
229
230         WebKitTestRunner leaks strings in generateWhitelist()
231         https://bugs.webkit.org/show_bug.cgi?id=145665
232
233         Reviewed by Myles C. Maxfield.
234
235         * WebKitTestRunner/mac/TestControllerMac.mm:
236         (WTR::generateWhitelist):
237
238 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
239
240         Fix options in build-jsc for CMake builds
241         https://bugs.webkit.org/show_bug.cgi?id=145636
242
243         Reviewed by Gyuyoung Kim.
244
245         CMake only accepts -DXXX=YYY style options.
246         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
247
248         * Scripts/build-jsc:
249
250 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
251
252         Added a patch so that the colors displayed on the page could be toggled
253         in case people need accessibility colors displayed in their browser.
254         https://bugs.webkit.org/show_bug.cgi?id=145570
255         <rdar://problem/20994468>
256
257         Added in CSS colors and toggle buttons for checkmarks in the page, so that
258         the page could be rendered in a specific way for accessibility needs if needed.
259
260         Reviewed by Alexey Proskuryakov.
261
262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
263         (updateHiddenPlatforms):
264         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
265         (toggleAccessibilityColors): Toggle colors on and off
266         (documentReady): Needed to make changes to the initialization
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
268         (a:hover):
269         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
270         (div.cellButton.hide, div.accessibilityButton.hide):
271         (div.cellButton.unhide, div.accessibilityButton.unhide):
272         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
273         (.popover-tracking:hover):
274         (.accessibilityButton):
275         (div.cellButton): Deleted.
276         (div.cellButton.hide): Deleted.
277         (div.cellButton.unhide): Deleted.
278         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
280         (.status-line.neutral .bubble):
281         (.status-line.unauthorized .bubble):
282         (.status-line.danger .bubble.pictogram):
283         (.status-line.bad .bubble.pictogram):
284         (.status-line.no-bubble .message):
285         (.status-line.bad .bubble):
286         (.status-line.good .bubble):
287         (.status-line.good .message):
288         (.status-line.bad .message):
289         (body.accessibility-colors .status-line.good .bubble):
290         (body.accessibility-colors .status-line.bad .bubble):
291         (body.accessibility-colors .status-line.good .message):
292         (body.accessibility-colors .status-line.bad .message):
293         (.status-line.danger .message):
294         (.status-line.unauthorized .message):
295
296 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
297
298         Unreviewed build fix for Dromaeo.
299
300         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
301         (BenchmarkResults._aggregate_results_for_test):
302
303 2015-06-03  Anders Carlsson  <andersca@apple.com>
304
305         Fix build.
306
307         * DumpRenderTree/mac/TestRunnerMac.mm:
308
309 2015-06-03  Daniel Bates  <dabates@apple.com>
310
311         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
312         https://bugs.webkit.org/show_bug.cgi?id=145616
313
314         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
315         of the test. Further investigation is needed.
316
317         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
318         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
319
320 2015-06-03  Brady Eidson  <beidson@apple.com>
321
322         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
323         https://bugs.webkit.org/show_bug.cgi?id=145580
324
325         Reviewed by Mark Lam.
326
327         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
328         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
329
330 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
331
332         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
333
334         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
335         (TestWebKitAPI::TEST): Update the syntax.
336
337 2015-06-02  Mark Lam  <mark.lam@apple.com>
338
339         build-jsc's --cloop option is broken.
340         https://bugs.webkit.org/show_bug.cgi?id=145516
341
342         Reviewed by Darin Adler.
343
344         * Scripts/build-jsc:
345         - Make sure to disable the JIT when --cloop is specified.
346           Did analogous fix for --ftljit.
347
348 2015-06-02  Daniel Bates  <dabates@apple.com>
349
350         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
351
352         Rubber-stamped by Alexey Proskuryakov.
353
354         * MiniBrowser/mac/Info.plist:
355         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
356
357 2015-06-01  Commit Queue  <commit-queue@webkit.org>
358
359         Unreviewed, rolling out r185066.
360         https://bugs.webkit.org/show_bug.cgi?id=145543
361
362         it breaks the FTL JIT builds with a local checkout of llvm
363         (Requested by pizlo on #webkit).
364
365         Reverted changeset:
366
367         "build-jsc's --cloop option is broken."
368         https://bugs.webkit.org/show_bug.cgi?id=145516
369         http://trac.webkit.org/changeset/185066
370
371 2015-06-01  Daniel Bates  <dabates@apple.com>
372
373         Notify client that we began editing when text field is focused
374         https://bugs.webkit.org/show_bug.cgi?id=145439
375         <rdar://problem/21142108>
376
377         Reviewed by Anders Carlsson.
378
379         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
380         a text field is focused and defocused.
381
382         * TestWebKitAPI/CMakeLists.txt:
383         * TestWebKitAPI/PlatformEfl.cmake:
384         * TestWebKitAPI/PlatformGTK.cmake:
385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
386         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
387         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
388         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
389         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
390         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
391         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
392         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
393         (TestWebKitAPI::TEST_F):
394         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
395         (TestWebKitAPI::textFieldDidBeginEditing):
396         (TestWebKitAPI::textFieldDidEndEditing):
397         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
398         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
399         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
400
401 2015-06-01  Alex Christensen  <achristensen@webkit.org>
402
403         [Content Extensions] resource-type and load-type should be independent.
404         https://bugs.webkit.org/show_bug.cgi?id=145528
405         rdar://problem/21190765
406
407         Reviewed by Benjamin Poulain.
408
409         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
410         (TestWebKitAPI::TEST_F):
411
412 2015-06-01  Daniel Bates  <dabates@apple.com>
413
414         Add ATS keys to WebKitTestRunnerApp
415         https://bugs.webkit.org/show_bug.cgi?id=145519
416
417         Reviewed by Alexey Proskuryakov.
418
419         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
420
421         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
422
423 2015-06-01  Brady Eidson  <beidson@apple.com>
424
425         Add WKTR support for "should open external URLs".
426         https://bugs.webkit.org/show_bug.cgi?id=145505
427
428         Reviewed by Darin Adler.
429
430         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
431           "should open external URLs" bit set.
432         
433         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
434           the policy delegate, including whether or not the bit was set.
435         
436         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
437         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
438         (WTR::TestRunner::queueLoad):
439         * WebKitTestRunner/InjectedBundle/TestRunner.h:
440         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
441         (WTR::TestRunner::shouldDumpPolicyCallbacks):
442         
443         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
444         (WTR::InjectedBundle::queueLoad):
445         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
446
447         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
448         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
449
450         * WebKitTestRunner/TestInvocation.cpp:
451         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
452
453         * WebKitTestRunner/WorkQueueManager.cpp:
454         (WTR::WorkQueueManager::queueLoad):
455         * WebKitTestRunner/WorkQueueManager.h:
456
457 2015-06-01  Mark Lam  <mark.lam@apple.com>
458
459         build-jsc's --cloop option is broken.
460         https://bugs.webkit.org/show_bug.cgi?id=145516
461
462         Reviewed by Darin Adler.
463
464         * Scripts/build-jsc:
465         - Make sure to disable the JIT when --cloop is specified.
466           Did analogous fix for --ftljit.
467
468 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
469
470         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
471         https://bugs.webkit.org/show_bug.cgi?id=144959
472
473         Reviewed by Darin Adler.
474
475         * Scripts/webkitpy/style/checkers/cmake.py:
476         (CMakeChecker.check): Use enumerate instead of xrange.
477         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
478         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
479         (CMakeCheckerTest.test_check): Update the expected results.
480
481 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
482
483         Fix the webkitpy scm unittests after r174051
484         https://bugs.webkit.org/show_bug.cgi?id=145511
485
486         Reviewed by Darin Adler.
487
488         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
489         (GitTestWithMock.make_scm):
490
491 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
492
493         EWS provides misleading information for not applyable patches
494         https://bugs.webkit.org/show_bug.cgi?id=145307
495
496         Reviewed by Alexey Proskuryakov.
497
498         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
499
500 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
501
502         Further tweak results of WebKit1.StringTruncator after r184965.
503
504         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
505
506 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
507
508         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
509         https://bugs.webkit.org/show_bug.cgi?id=145264
510
511         Reviewed by Carlos Garcia Campos.
512
513         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
514
515 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
516
517         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
518
519         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
520         (BenchmarkResults._lint_subtest_results):
521         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
522         (test_aggregate_nested_results):
523         (test_lint_results):
524         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
525
526 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
527
528         run-benchmark should print out the results
529         https://bugs.webkit.org/show_bug.cgi?id=145398
530
531         Reviewed by Antti Koivisto.
532
533         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
534         of the output to catch early errors.
535
536         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
537         (BenchmarkResults): Added.
538         (BenchmarkResults.__init__): Added.
539         (BenchmarkResults.format): Added.
540         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
541         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
542         Uses the sample standard deviation to compute the significant figures for the value.
543         (BenchmarkResults._unit_from_metric): Added.
544         (BenchmarkResults._aggregate_results): Added.
545         (BenchmarkResults._aggregate_results_for_test): Added.
546         (BenchmarkResults._flatten_list): Added.
547         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
548         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
549         (BenchmarkResults._aggregate_values): Added.
550         (BenchmarkResults._lint_results): Added.
551         (BenchmarkResults._lint_subtest_results): Added.
552         (BenchmarkResults._lint_aggregator_list): Added.
553         (BenchmarkResults._lint_configuration): Added.
554         (BenchmarkResults._lint_values): Added.
555         (BenchmarkResults._is_numeric): Added.
556         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
557         (BenchmarkResultsTest):
558         (BenchmarkResultsTest.test_init):
559         (BenchmarkResultsTest.test_format):
560         (test_format_values_with_large_error):
561         (test_format_values_with_small_error):
562         (test_format_values_with_time):
563         (test_format_values_with_no_error):
564         (test_format_values_with_small_difference):
565         (test_aggregate_results):
566         (test_aggregate_results_with_gropus):
567         (test_aggregate_nested_results):
568         (test_lint_results):
569         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
570         (BenchmarkRunner.execute): Added a call to show_results
571         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
572         (BenchmarkRunner.show_results): Added.
573
574 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
575
576         run_benchmark should have an option to specify the number of runs
577         https://bugs.webkit.org/show_bug.cgi?id=145091
578
579         Reviewed by Antti Koivisto.
580
581         Added --count option.
582
583         * Scripts/run-benchmark:
584         (main):
585         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
586         (BenchmarkRunner.__init__):
587
588 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
589
590         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
591
592         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
593
594 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
595
596         Update results of WebKit1.StringTruncator after r184965.
597
598         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
599
600 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
601
602         Unreviewed, updated my list of email addresses.
603
604         * Scripts/webkitpy/common/config/contributors.json:
605
606 2015-05-27  Dean Jackson  <dino@apple.com>
607
608         img.currentSrc problem in strict mode with old picturefill
609         https://bugs.webkit.org/show_bug.cgi?id=144095
610         <rdar://problem/21087013>
611
612         Reviewed by Simon Fraser.
613
614         Add a PICTURE_SIZES flag.
615
616         * Scripts/webkitperl/FeatureList.pm:
617
618 2015-05-26  Dana Burkart  <dburkart@apple.com>
619
620         Fixes compatibility issues with recent dashboard cleanup.
621         https://bugs.webkit.org/show_bug.cgi?id=144814
622
623         Reviewed by Alexey Proskuryakov.
624
625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
626         (BuildbotStaticAnalyzerQueueView):
627         (BuildbotStaticAnalyzerQueueView.prototype.update):
628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
629         (documentReady):
630
631 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
632
633         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
634         https://bugs.webkit.org/show_bug.cgi?id=143091
635         rdar://problem/19330328
636
637         Reviewed by Darin Adler and Timothy Hatcher.
638
639         We have many of these, which are hard to fit on the dashboard. Added a view that
640         collapses to a single green bubble when everything is good, and expands when there
641         are failures (or manually).
642
643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
644
645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
646         (Buildbot.prototype.set isAuthenticated):
647         (Buildbot.prototype._normalizeQueueInfo):
648         (Buildbot.prototype._normalizeQueuesInfo):
649         (Buildbot.prototype.updateQueues):
650         Moved queue info normalization here from BuildbitQueue. The latter is a model class
651         that shouldn't have to know about presentation, and this lets us leep the knowledge
652         about combined queues out if it. Later, we can refactor existing code, and move out
653         all knowledge about headings and such.
654
655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
656         Added the new view. It's not quite universal, and doesn't have as helpful popovers
657         as other views, but we can extend it when/if we use it for more than JSC.
658
659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
660         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
661
662         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
663         (documentReady): Added support for combined queues. These are currently always ending up
664         in Other column, but it's easy to customize in the future if we need to.
665
666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
667         (WebKitBuildbot): Added JSC queus.
668
669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
670         (.combined-queue-popover):
671         (.combined-queue-popover .revision):
672         Added styles for the combined view.
673
674 2015-05-26  Dan Bernstein  <mitz@apple.com>
675
676         Changed a file to use Unix line endings.
677
678         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
679
680 2015-05-26  Dan Bernstein  <mitz@apple.com>
681
682         <rdar://problem/21104551> Update build settings
683
684         Reviewed by Anders Carlsson.
685
686         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
687         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
688         * MiniBrowser/Configurations/DebugRelease.xcconfig:
689         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
690         * WebEditingTester/Configurations/DebugRelease.xcconfig:
691         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
692         * asan/asan.xcconfig:
693
694 2015-05-26  Anders Carlsson  <andersca@apple.com>
695
696         Fix build.
697
698         * WebKitTestRunner/mac/EventSenderProxy.mm:
699         (WTR::EventSenderProxy::mouseForceDown):
700         (WTR::EventSenderProxy::mouseForceUp):
701         (WTR::EventSenderProxy::mouseForceChanged):
702
703 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
704
705         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
706         https://bugs.webkit.org/show_bug.cgi?id=145342
707
708         Reviewed by Darin Adler.
709
710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
711         (BuildbotIteration.prototype._parseData):
712
713 2015-05-26  Milan Crha  <mcrha@redhat.com>
714
715         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
716         https://bugs.webkit.org/show_bug.cgi?id=138134
717
718         Reviewed by Žan Doberšek.
719
720         * gtk/generate-inspector-gresource-manifest.py:
721         (get_filenames): Command line with expanded resources exceeds 32KB, which
722         is a limit on Windows. It's better to expand wildcards inside the python script.
723
724 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
727         https://bugs.webkit.org/show_bug.cgi?id=140882
728
729         Reviewed by Gustavo Noronha Silva.
730
731         Make sure unit tests write IndexedDB databases to the temporary
732         directory, and add a test case to check that the directory is
733         correctly created at the expected path.
734
735         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
736         (testWebContextConfiguration):
737         (serverCallback):
738         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
739         (Test::Test):
740
741 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
742
743         [GTK] Enable IndexedDB
744         https://bugs.webkit.org/show_bug.cgi?id=98932
745
746         Reviewed by Žan Doberšek.
747
748         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
749
750 2015-05-24  Sam Weinig  <sam@webkit.org>
751
752         Crash when using a removed ScriptMessageHandler
753         <rdar://problem/20888499>
754         https://bugs.webkit.org/show_bug.cgi?id=145359
755
756         Reviewed by Dan Bernstein.
757
758         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
759         Add tests for removing script message handlers.
760
761 2015-05-23  Dan Bernstein  <mitz@apple.com>
762
763         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
764         https://bugs.webkit.org/show_bug.cgi?id=145345
765
766         Reviewed by Sam Weinig.
767
768         * DumpRenderTree/mac/Configurations/Base.xcconfig:
769         * LayoutTestRelay/Configurations/Base.xcconfig:
770         * TestWebKitAPI/Configurations/Base.xcconfig:
771         * WebKitTestRunner/Configurations/Base.xcconfig:
772
773 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
774
775         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
776         https://bugs.webkit.org/show_bug.cgi?id=144848
777
778         Reviewed by Darin Adler.
779
780         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
781
782         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
783
784 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
785
786         Fix one more merge error in static analyzer support.
787
788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
789         (BuildbotStaticAnalyzerQueueView):
790
791 2015-05-22  Dana Burkart  <dburkart@apple.com>
792
793         Fix internal dashboard breakage from recent commit.
794         https://bugs.webkit.org/show_bug.cgi?id=144814
795
796         Unreviewed build fix.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
799         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
800         (BuildbotStaticAnalyzerQueueView.prototype.update):
801
802 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
803
804         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
805         https://bugs.webkit.org/show_bug.cgi?id=130463
806         rdar://problem/20461342
807
808         Reviewed by Tim Horton.
809
810         This was more of a timing related flakiness than an actual OS version specific bug,
811         we weren't getting window visibility notifications.
812         
813         I will look into adding this function call to DumpRenderTree separately, layout tests
814         might actually rely on the broken behavior.
815
816         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
817         (TestWebKitAPI::TEST_F):
818         * TestWebKitAPI/mac/mainMac.mm:
819         (main):
820
821 2015-05-22  Dana Burkart  <dburkart@apple.com>
822
823         Add missing file from r184804 (mis-applied diff).
824         https://bugs.webkit.org/show_bug.cgi?id=144814
825
826         Reviewed by Alexey Proskuryakov.
827
828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
829         (BuildbotStaticAnalyzerQueueView):
830         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
831         (BuildbotStaticAnalyzerQueueView.prototype.update):
832
833 2015-05-22  Dana Burkart  <dburkart@apple.com>
834
835         Add support to the botwatchers dashboard for a static analyzer bot.
836         https://bugs.webkit.org/show_bug.cgi?id=144814
837
838         Reviewed by Alexey Proskuryakov.
839
840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
841         scan-build should be considered a productive step.
842
843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
844         (BuildbotQueue):
845         Adds support for the staticAnalyzer property
846
847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
848         (BuildbotTestResults.prototype._parseResults):
849         Get bug count from the scan-build step output
850
851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
852         (documentReady):
853         Rename the performance column 'Other', and merge the current 'Other' column with it.
854
855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
856         (WebKitBuildbot):
857         Now that performance bots are part of the 'Other' column, give them better headings.
858
859 2015-05-22  Tim Horton  <timothy_horton@apple.com>
860
861         Turn on autosaving of toolbar configuration in MiniBrowser
862
863         Rubber-stamped by Dan Bernstein.
864
865         * MiniBrowser/mac/BrowserWindow.xib:
866
867 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
868
869         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
870         https://bugs.webkit.org/show_bug.cgi?id=145297
871
872         Reviewed by Tim Horton.
873
874         This is a refactoring to simplify code, and to make it more logical.
875
876         It is up to the view to decide how to present the queues, and whether to split
877         them into debug and release, or in some different way.
878
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
880         (BuildbotBuilderQueueView.filterQueues):
881         (BuildbotBuilderQueueView):
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
883         (BuildbotLeaksQueueView):
884         (BuildbotLeaksQueueView.prototype.update):
885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
886         (BuildbotPerformanceQueueView):
887         (BuildbotPerformanceQueueView.prototype.update):
888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
889         (BuildbotQueueView):
890         (BuildbotQueueView.prototype._updateQueues):
891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
892         (BuildbotTesterQueueView):
893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
894         (documentReady):
895
896 2015-05-22  Tim Horton  <timothy_horton@apple.com>
897
898         Remove action menu support
899         https://bugs.webkit.org/show_bug.cgi?id=145305
900         <rdar://problem/21070771>
901
902         Reviewed by Anders Carlsson.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
905         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
906         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
907         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
908         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
909         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
910         Remove the tests.
911
912 2015-05-22  Dan Bernstein  <mitz@apple.com>
913
914         Removed the Use Shrink To Fit button from the toolbar’s default set.
915
916         Rubber-stamped by Tim Horton.
917
918         * MiniBrowser/mac/BrowserWindow.xib:
919
920 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
921
922         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
923         https://bugs.webkit.org/show_bug.cgi?id=128420
924
925         Reviewed by Chris Fleizach.
926
927         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
928         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
929
930 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
931
932         [EFL] Bump libsoup version to 2.50.0
933         https://bugs.webkit.org/show_bug.cgi?id=145127
934
935         Reviewed by Gyuyoung Kim.
936
937         * efl/jhbuild.modules:
938         * efl/patches/soup-clang-warning-fix1.patch: Removed.
939         * efl/patches/soup-clang-warning-fix2.patch: Removed.
940
941 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
942
943         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
944         https://bugs.webkit.org/show_bug.cgi?id=145117
945
946         Reviewed by Csaba Osztrogonác.
947
948         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
949         Tools/TestWebKitAPI/Tests/WTF/glib/.
950
951         * TestWebKitAPI/PlatformGTK.cmake:
952         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
953         (TestWebKitAPI::TEST):
954
955 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
956
957         [EFL] fix efreet error
958         https://bugs.webkit.org/show_bug.cgi?id=143670
959
960         Reviewed by Gyuyoung Kim.
961
962         Fix efreet error by using external variable efreet_cache_update.
963         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
964         efreet error for efreet_cache does not occur.
965
966         * MiniBrowser/efl/main.c:
967         (elm_main):
968
969 2015-05-20  Michael Saboff  <msaboff@apple.com>
970
971         Add option to run_jsc_stress_tests to disable JIT testing
972         https://bugs.webkit.org/show_bug.cgi?id=145233
973
974         Reviewed by Mark Lam.
975
976         Added --no-jit option.
977
978         * Scripts/run-jsc-stress-tests:
979
980 2015-05-20  Alex Christensen  <achristensen@webkit.org>
981
982         Use correct String for StringView in WTF API tests
983         https://bugs.webkit.org/show_bug.cgi?id=145226
984         rdar://problem/20361786
985
986         Reviewed by Benjamin Poulain.
987
988         * TestWebKitAPI/Tests/WTF/StringView.cpp:
989         (TestWebKitAPI::TEST):
990         Use patternHolder for pattern.
991
992 2015-05-20  Alex Christensen  <achristensen@webkit.org>
993
994         [Content Extensions] Relax restrictions on triggers that match everything.
995         https://bugs.webkit.org/show_bug.cgi?id=145069
996
997         Reviewed by Benjamin Poulain.
998
999         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1000         (TestWebKitAPI::TEST_F):
1001         Update and add tests for new possibilities with .*
1002
1003 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
1004
1005         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
1006         https://bugs.webkit.org/show_bug.cgi?id=144992
1007
1008         Reviewed by Gyuyoung Kim.
1009
1010         * MiniBrowser/efl/main.c:
1011         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
1012         (on_key_down):
1013         (on_fullscreen_enter):
1014         (on_fullscreen_exit):
1015         (window_create):
1016
1017 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1018
1019         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
1020         https://bugs.webkit.org/show_bug.cgi?id=145109
1021
1022         Reviewed by Darin Adler.
1023
1024         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1025         (TestWebKitAPI::TEST):
1026
1027 2015-05-19  Anders Carlsson  <andersca@apple.com>
1028
1029         Add alternate menu items for performing operations on the default data store
1030         https://bugs.webkit.org/show_bug.cgi?id=145184
1031
1032         Reviewed by Sam Weinig.
1033
1034         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
1035         associated with a data store.
1036
1037         * MiniBrowser/mac/AppDelegate.m:
1038         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
1039         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
1040         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
1041         * MiniBrowser/mac/MainMenu.xib:
1042
1043 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1044
1045         Fix tautological-compare warning in AtomicString.cpp
1046         https://bugs.webkit.org/show_bug.cgi?id=145120
1047
1048         Reviewed by Alexey Proskuryakov.
1049
1050         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1051         (TestWebKitAPI::TEST): Removed always true assert.
1052
1053 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
1054
1055         [EFL] Fix unsequenced warning in MiniBrowser's main.c
1056         https://bugs.webkit.org/show_bug.cgi?id=145123
1057
1058         Reviewed by Gyuyoung Kim.
1059
1060         * MiniBrowser/efl/main.c:
1061         (on_key_down):
1062
1063 2015-05-18  Daniel Bates  <dabates@apple.com>
1064
1065         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
1066         when staged non-empty file for commit
1067         https://bugs.webkit.org/show_bug.cgi?id=145082
1068
1069         Reviewed by Darin Adler.
1070
1071         Fixes two issues when running prepare-ChangeLog:
1072             1. The function above a deleted function is reported as changed.
1073             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
1074             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
1075             included in this patch).
1076
1077         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
1078         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
1079         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
1080         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
1081         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
1082         VCSUtil::parseChunkRange() has existing test coverage.
1083
1084         * Scripts/prepare-ChangeLog:
1085         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
1086         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
1087         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
1088         examine files that only have deletions. Currently this works as a side effect of the behavior of
1089         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
1090         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
1091         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
1092         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
1093         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1094         We return (-1, -1) when the change represents a deletion.
1095         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
1096         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1097         We return (-1, -1) when the change represents an addition.
1098         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
1099         unit tests.
1100
1101 2015-05-18  Anders Carlsson  <andersca@apple.com>
1102
1103         Add ATS keys to MiniBrowser
1104         https://bugs.webkit.org/show_bug.cgi?id=145141
1105
1106         Reviewed by Sam Weinig.
1107
1108         * MiniBrowser/mac/Info.plist:
1109
1110 2015-05-17  David Kilzer  <ddkilzer@apple.com>
1111
1112         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
1113         <http://webkit.org/b/145100>
1114
1115         Reviewed by Darin Adler.
1116
1117         * Scripts/bisect-builds:
1118         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
1119         - Switch to using PROMPT_RESPONSE_* constants when testing the
1120           value of $didReproduceBug.
1121         - Add do { } while loops to implement 'retry' mode.
1122         (promptForTest):
1123         - Switch to returning PROMPT_RESPONSE_* constants.
1124         - Add support for 'retry' response.
1125
1126 2015-05-16  Tanay C  <tanay.c@samsung.com>
1127
1128         [EFL][WK2] Minibrowser : Add search icon to search bar
1129         https://bugs.webkit.org/show_bug.cgi?id=139773
1130
1131         Reviewed by Gyuyoung Kim.
1132
1133         * MiniBrowser/efl/main.c: 
1134         (search_icon_show): Added.
1135         (search_box_show): Modified.
1136
1137 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1138
1139         run_benchmark should have an option to specify the number of runs
1140         https://bugs.webkit.org/show_bug.cgi?id=145091
1141
1142         Reviewed by Stephanie Lewis.
1143
1144         Added --count option.
1145
1146         * Scripts/run-benchmark:
1147         (main):
1148         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1149         (BenchmarkRunner.__init__):
1150
1151 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
1152
1153         Temporarily disable failing API test.
1154
1155         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1156         (TestWebKitAPI::TEST):
1157
1158 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
1159
1160         User interruption while running of run-webkit-tests should also generate results.html
1161         https://bugs.webkit.org/show_bug.cgi?id=122154
1162
1163         Reviewed by Csaba Osztrogonác.
1164
1165         Generation of results.html on execution of run-webkit-tests happens only
1166         on completion of entire layout tests run. It should be created even when
1167         the execution has been interrupted - either by user (by pressing Ctrl+C)
1168         or because of other interruptions (like exit-after-n-failures option).
1169
1170         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1171         (LayoutTestRunner.run_tests):
1172         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1173         (Manager.run):
1174         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1175         (TestRunResults.__init__):
1176         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1177         (main):
1178         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1179         (RunTest.test_keyboard_interrupt):
1180         (MainTest.test_exception_handling):
1181
1182 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
1183
1184         [buildbot] Fix the URL of the performance bots
1185         https://bugs.webkit.org/show_bug.cgi?id=145043
1186
1187         Reviewed by Ryosuke Niwa.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1190
1191 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
1192
1193         Add a layout mode that scales down the view to try to fit the document
1194         https://bugs.webkit.org/show_bug.cgi?id=145022
1195         <rdar://problem/19790341>
1196
1197         Reviewed by Dean Jackson.
1198
1199         * MiniBrowser/mac/BrowserWindow.xib:
1200         * MiniBrowser/mac/BrowserWindowController.h:
1201         * MiniBrowser/mac/WK2BrowserWindowController.m:
1202         (-[WK2BrowserWindowController toggleShrinkToFit:]):
1203         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
1204         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
1205
1206 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
1207
1208         [CMake] Don't read the LOCATION property of targets
1209         https://bugs.webkit.org/show_bug.cgi?id=145018
1210
1211         Reviewed by Martin Robinson.
1212
1213         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
1214         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
1215         be the same at configure-time as it is at generate-time.
1216
1217         * TestWebKitAPI/CMakeLists.txt:
1218
1219 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
1220
1221         Add String literal overloads to equalIgnoringASCIICase()
1222         https://bugs.webkit.org/show_bug.cgi?id=145008
1223
1224         Reviewed by Benjamin Poulain.
1225
1226         Test changes to WTF.
1227
1228         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1229         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
1230         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1231         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1232         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
1233         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1234
1235 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1236
1237         SharedBuffer::createWithContentsOfFile should use map file routines
1238         https://bugs.webkit.org/show_bug.cgi?id=144192
1239
1240         Reviewed by Darin Adler.
1241
1242         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
1243
1244         * TestWebKitAPI/PlatformGTK.cmake:
1245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1246         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
1247         (TestWebKitAPI::FileSystemTest::tempFilePath):
1248         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
1249         (TestWebKitAPI::TEST_F):
1250         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
1251         (TestWebKitAPI::SharedBufferTest::tempFilePath):
1252         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
1253         (TestWebKitAPI::TEST_F):
1254
1255 2015-05-13  Alex Christensen  <achristensen@webkit.org>
1256
1257         [Content Extensions] Test interactions between multiple extensions and multiple domains.
1258         https://bugs.webkit.org/show_bug.cgi?id=144967
1259
1260         Reviewed by Benjamin Poulain.
1261
1262         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1263         Xcode wanted to fix an alphabetization issue.
1264         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1265         (TestWebKitAPI::TEST_F):
1266         Test interactions that worked but were not explicitly tested before.
1267
1268 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1269
1270         Unreviewed build fix.
1271
1272         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
1273
1274         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
1275
1276 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1277
1278         Fix the previous commit, which made both bubbles green.
1279
1280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1281         (.status-line.good .bubble):
1282         (.status-line.bad .bubble):
1283         (.status-line.good .message):
1284
1285 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1286
1287         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
1288         https://bugs.webkit.org/show_bug.cgi?id=144929
1289
1290         Reviewed by Eric Carlson.
1291
1292         Tweaked colors as I see fit.
1293
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1295         (.status-line.good .bubble):
1296         (.status-line.bad .bubble):
1297
1298 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
1299
1300         [Mac] Share cookie storage between UI process and secondary processes
1301         https://bugs.webkit.org/show_bug.cgi?id=144820
1302         rdar://problem/20572830
1303
1304         Reviewed by Darin Adler.
1305
1306         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1307         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
1308         for testing.
1309
1310 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
1311
1312         Fix internal build configuration issues
1313         https://bugs.webkit.org/show_bug.cgi?id=144762
1314
1315         Reviewed by David Kilzer.
1316
1317         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
1318
1319         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1320         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1321         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1322         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1323         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1324         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1325         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1326         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1327
1328 2015-05-12  David Kilzer  <ddkilzer@apple.com>
1329
1330         Switch to launching iOS Simulator using bundle ID
1331         <rdar://problem/20916096>
1332
1333         This is required to fix the layout tests on internal bots.
1334
1335         * Scripts/webkitdirs.pm:
1336         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
1337         Simulator.  Add FIXME.
1338         (quitIOSSimulator): Add FIXME.
1339         * Scripts/webkitpy/port/ios.py:
1340         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
1341         launch iOS Simulator.  Add FIXME.
1342         (IOSSimulatorPort.check_sys_deps): Add FIXME.
1343
1344 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
1345
1346         Fix run-javascriptcore-tests step on the WinCairo bot
1347         https://bugs.webkit.org/show_bug.cgi?id=144866
1348
1349         Reviewed by Csaba Osztrogonác.
1350
1351         Catch exception when failing to create soft link, so we can fall back to copy.
1352
1353         * Scripts/run-jsc-stress-tests:
1354
1355 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
1356
1357         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
1358         https://bugs.webkit.org/show_bug.cgi?id=116971
1359
1360         Reviewed by Chris Fleizach.
1361
1362         Implement rowAtIndex for ATK.
1363
1364         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1365         (WTR::AccessibilityUIElement::rowAtIndex):
1366
1367 2015-05-11  Dan Bernstein  <mitz@apple.com>
1368
1369         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1374         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
1375         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
1376         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
1377
1378 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
1379
1380         Fix internal build configuration issues
1381         https://bugs.webkit.org/show_bug.cgi?id=144762
1382
1383         Reviewed by Darin Adler.
1384
1385         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
1386
1387         * TestWebKitAPI/Configurations/Base.xcconfig:
1388         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1389         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1390         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1391         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1392         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1393         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1394
1395 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1396
1397         [Win] Move Windows build target to Windows 7 (or newer)
1398         https://bugs.webkit.org/show_bug.cgi?id=144890
1399         <rdar://problem/20707307>
1400
1401         Reviewed by Anders Carlsson.
1402
1403         Update linked SDK and minimal Windows level to be compatible with
1404         Windows 7 or newer.
1405
1406         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1407         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1408         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1409         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1410         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1411         * DumpRenderTree/config.h:
1412         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1413         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1414         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1415         * WinLauncher/stdafx.h:
1416
1417 2015-05-11  Commit Queue  <commit-queue@webkit.org>
1418
1419         Unreviewed, rolling out r184119.
1420         https://bugs.webkit.org/show_bug.cgi?id=144888
1421
1422         broke JSC tests on Apple Windows bots (Requested by kling on
1423         #webkit).
1424
1425         Reverted changeset:
1426
1427         "Fix run-javascriptcore-tests step on the WinCairo bot"
1428         https://bugs.webkit.org/show_bug.cgi?id=144866
1429         http://trac.webkit.org/changeset/184119
1430
1431 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1432
1433         run-benchmark should support Dromaeo
1434         https://bugs.webkit.org/show_bug.cgi?id=144849
1435
1436         Reviewed by Chris Dumez.
1437
1438         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
1439         they can take as much as 15 minutes to run each.
1440
1441         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
1442         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
1443         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
1444         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
1445
1446 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1447
1448         Build fix. jetstream has a local copy, not remote archive.
1449
1450         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1451
1452 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1453
1454         run-benchmark should support SunSpider, Kraken and Octane
1455         https://bugs.webkit.org/show_bug.cgi?id=144840
1456
1457         Reviewed by Darin Adler.
1458
1459         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
1460         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
1461         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
1462         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
1463
1464         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
1465         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
1466
1467         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
1468         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
1469
1470         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
1471         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
1472         now has the ability to run an arbitrary "create script".
1473
1474         * Scripts/run-benchmark:
1475         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
1476         This also overrides the remote archive URL specified in the plan.
1477
1478         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
1479
1480         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
1481         JetStreamBenchmarkBuilder.
1482
1483         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
1484         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
1485         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
1486         _runCreateScript and _applyPatch to clean after themselves.
1487         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
1488         JetStream, SunSpider, Kraken all use this feature.
1489         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
1490         the leaf directory name since the latter is not available when a remote ZIP file is used.
1491         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
1492         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
1493         the benchmark name in the patches.
1494
1495         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
1496
1497         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1498         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
1499         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
1500         the browser opens by planName as the plan file no longer contains that.
1501
1502         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
1503         the top directory of JetStream instead of its parent.
1504         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
1505         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
1506         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
1507         the top directory of JetStream instead of its parent.
1508         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
1509         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
1510         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
1511         done in JetStream.patch.
1512         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
1513         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1514         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1515         path from the top directory of JetStream as done in JetStream.patch.
1516         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1517
1518 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
1519
1520         Fix run-javascriptcore-tests step on the WinCairo bot
1521         https://bugs.webkit.org/show_bug.cgi?id=144866
1522
1523         Reviewed by Darin Adler.
1524
1525         * Scripts/run-jsc-stress-tests:
1526
1527 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1528
1529         [Content Extensions] Support domain-specific rules and exceptions.
1530         https://bugs.webkit.org/show_bug.cgi?id=144833
1531
1532         Reviewed by Darin Adler.
1533
1534         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1535         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1536         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1537         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1538         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1539         (TestWebKitAPI::mainDocumentRequest):
1540         (TestWebKitAPI::subResourceRequest):
1541         (TestWebKitAPI::TEST_F):
1542         (TestWebKitAPI::checkCompilerError):
1543         Added tests for parsing and functionality of if-domain and unless-domain.
1544
1545 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1546
1547         run-benchmark should support Chrome Canary and Firefox Nightly
1548         https://bugs.webkit.org/show_bug.cgi?id=144850
1549
1550         Reviewed by Darin Adler.
1551
1552         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1553
1554         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1555
1556         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1557         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1558         (OSXBrowserDriver):
1559         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1560         (OSXBrowserDriver.closeBrowsers): Ditto.
1561         (OSXBrowserDriver.launchProcess): Ditto.
1562         (OSXBrowserDriver.terminateProcesses): Ditto.
1563         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1564         (OSXChromeDriver): Removed the unused self.chromePreferences.
1565         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1566         (OSXChromeDriver.closeBrowsers): Ditto.
1567         (OSXChromeDriver.launchUrl):
1568         (OSXChromeCanaryDriver): Added.
1569         (OSXChromeCanaryDriver.launchUrl):
1570         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1571         (OSXFirefoxDriver): Added.
1572         (OSXFirefoxDriver.launchUrl):
1573         (OSXFirefoxNightlyDriver): Added.
1574         (OSXFirefoxNightlyDriver.launchUrl):
1575         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1576         (OSXSafariDriver):
1577         (OSXSafariDriver.closeBrowsers):
1578
1579 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1580
1581         Page overlay action context override should indicate the source of the request
1582         https://bugs.webkit.org/show_bug.cgi?id=144832
1583         <rdar://problem/20562594>
1584
1585         Reviewed by Darin Adler.
1586
1587         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1588         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1589
1590 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1591
1592         [GTK] fast/events/page-visibility-transition-test.html is timing out
1593         https://bugs.webkit.org/show_bug.cgi?id=114789
1594
1595         Reviewed by Darin Adler.
1596
1597         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1598         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1599         requests visibility changes.
1600
1601 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1602
1603         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1604         https://bugs.webkit.org/show_bug.cgi?id=144798
1605
1606         Reviewed by Darin Adler.
1607
1608         * efl/install-dependencies:
1609
1610 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1611
1612         Make arguments of run-benchmark more user friendly
1613         https://bugs.webkit.org/show_bug.cgi?id=144835
1614
1615         Reviewed by Darin Adler.
1616
1617         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1618         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1619         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1620         default values from --platform and --browser as they are required arguments.
1621
1622         * Scripts/run-benchmark:
1623         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1624         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1625         are not dynamically obtained via BrowserDriverFactory.
1626         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1627         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1628         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1629         run any benchmark in that case.
1630         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1631         the specified file isn't a valid relative or an absolute path.
1632         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1633         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1634         and browsers.
1635         (BrowserDriverFactory.available_browsers): Ditto.
1636         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1637         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1638         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1639         browserBuildPath was None.
1640         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1641         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1642         so that we can use locally built WebKit to launch Safari.
1643
1644 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
1645
1646         Remove the PICTURE_SIZES build flag
1647         https://bugs.webkit.org/show_bug.cgi?id=144679
1648
1649         Reviewed by Benjamin Poulain.
1650
1651         Removed the PICTURE_SIZES build time flag.
1652
1653         * Scripts/webkitperl/FeatureList.pm:
1654
1655 2015-05-09  David Kilzer  <ddkilzer@apple.com>
1656
1657         Layout tests broke due to unexpected simctl output
1658
1659         * Scripts/webkitpy/xcode/simulator.py:
1660         (Simulator._parse_devices): Handle new Device Pairs header.
1661         * Scripts/webkitpy/xcode/simulator_unittest.py:
1662         (test_device_pairs): Add unit test for Device Pairs header.
1663
1664 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1665
1666         Remove convenience constructors for TextRun
1667         https://bugs.webkit.org/show_bug.cgi?id=144752
1668
1669         Reviewed by Anders Carlsson.
1670
1671         Test the StringView which takes a StringImpl*.
1672
1673         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1674         (StringView8Bit): Testing is8Bit() on StringView
1675
1676 2015-05-07  Sam Weinig  <sam@webkit.org>
1677
1678         [Content Extensions] Add simple tester that takes an extension and compiles it
1679         https://bugs.webkit.org/show_bug.cgi?id=144781
1680
1681         Reviewed by Dan Bates.
1682
1683         * ContentExtensionTester: Added.
1684         * ContentExtensionTester/Configurations: Added.
1685         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1686         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1687         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1688         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1689         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1690         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1691         * ContentExtensionTester/main.m: Added.
1692         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1693
1694 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
1695
1696         Build fix.
1697
1698         Reviewed by Dan Bernstein.
1699
1700         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1701         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1702         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
1703         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1704         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1705         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1706         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
1707         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1708
1709 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
1710
1711         [GTK] Some tests fail because they do not assume the popup menu captures click events
1712         https://bugs.webkit.org/show_bug.cgi?id=40601
1713
1714         Reviewed by Carlos Garcia Campos.
1715
1716         Popdown all attached menus when moving between tests and between each new
1717         event sent to the WebView. This prevents context and popup menus from eating
1718         events.
1719
1720         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
1721         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
1722         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1723         (WTR::dispatchEvent): Popdown all menus between dispatching events.
1724         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
1725         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
1726         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1727         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
1728         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1729         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
1730         longer in the platform-independent file.
1731         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
1732
1733 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
1734
1735         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1736         https://bugs.webkit.org/show_bug.cgi?id=144746
1737
1738         Reviewed by Carlos Garcia Campos.
1739
1740         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1741
1742         * MiniBrowser/gtk/main.c:
1743         (main):
1744
1745 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1746
1747         Unreviewed, rolling out r183996.
1748         https://bugs.webkit.org/show_bug.cgi?id=144806
1749
1750         ASan detected use-after free (Requested by ap on #webkit).
1751
1752         Reverted changeset:
1753
1754         "Remove convenience constructors for TextRun"
1755         https://bugs.webkit.org/show_bug.cgi?id=144752
1756         http://trac.webkit.org/changeset/183996
1757
1758 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1759
1760         Remove convenience constructors for TextRun
1761         https://bugs.webkit.org/show_bug.cgi?id=144752
1762
1763         Reviewed by Anders Carlsson.
1764
1765         Test the StringView which takes a StringImpl*.
1766
1767         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1768         (StringView8Bit): Testing is8Bit() on StringView
1769
1770 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1771
1772         [GTK] WTR doesn't correctly handle the Escape key
1773         https://bugs.webkit.org/show_bug.cgi?id=144788
1774
1775         Reviewed by Martin Robinson.
1776
1777         Correctly handle 0x001B character code in GTK+ event sender to be
1778         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
1779         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
1780         to dismiss popup menus.
1781
1782         Fixes editing/selection/5354455-1.html.
1783
1784         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1785         (WTR::getGDKKeySymForKeyRef):
1786
1787 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
1790         https://bugs.webkit.org/show_bug.cgi?id=144748
1791
1792         Reviewed by Sergio Villar Senin.
1793
1794         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1795         (testWebKitSettings): Check the new setting is correctly
1796         initialized and updated.
1797         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1798         (testWebContextSecurityFileXHR): Check XHR to local files is
1799         allowed from file URLs after changing the setting.
1800         (beforeAll): Add new test.
1801
1802 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1803
1804         Unreviewed, rolling out r183945.
1805         https://bugs.webkit.org/show_bug.cgi?id=144789
1806
1807         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
1808
1809         Reverted changeset:
1810
1811         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
1812         https://bugs.webkit.org/show_bug.cgi?id=144746
1813         http://trac.webkit.org/changeset/183945
1814
1815 2015-05-07  Anders Carlsson  <andersca@apple.com>
1816
1817         Build fixes.
1818
1819         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1820         (TestWebKitAPI::TEST):
1821         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1822         (TestWebKitAPI::TEST):
1823         Add casts.
1824
1825 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
1826
1827         GC has trouble with pathologically large array allocations
1828         https://bugs.webkit.org/show_bug.cgi?id=144609
1829
1830         Reviewed by Geoffrey Garen.
1831         
1832         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
1833         and it's a frequently requested feature.
1834         
1835         Also add the ability to run a test pretending that your system has a particular RAM size.
1836         This is useful for GC tests, and the new GC test that I added uses this.
1837
1838         * Scripts/run-javascriptcore-tests:
1839         (runJSCStressTests):
1840         * Scripts/run-jsc-stress-tests:
1841
1842 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
1843
1844         [EFL] Bump EFL version to 1.14.0
1845         https://bugs.webkit.org/show_bug.cgi?id=144743
1846
1847         Reviewed by Darin Adler.
1848
1849         Bump EFL and elementary version to 1.14.0 and removed
1850         md5sum, because it isn't used at all if hash is present.
1851
1852         * efl/jhbuild.modules:
1853
1854 2015-05-07  Saam Barati  <saambarati1@gmail.com>
1855
1856         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
1857         https://bugs.webkit.org/show_bug.cgi?id=144753
1858
1859         Reviewed by Mark Lam.
1860
1861         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1862
1863 2015-05-07  Beth Dakin  <bdakin@apple.com>
1864
1865         New force-related DOM events should fire in WK1 views
1866         https://bugs.webkit.org/show_bug.cgi?id=144663
1867         -and corresponding-
1868         rdar://problem/20281886
1869
1870         Reviewed by Sam Weinig.
1871
1872         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
1873         now. Just send nil. 
1874         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1875         (TestWebKitAPI::buildAndPerformTest):
1876
1877 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1878
1879         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1880         https://bugs.webkit.org/show_bug.cgi?id=144746
1881
1882         Reviewed by Martin Robinson.
1883
1884         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1885
1886         * MiniBrowser/gtk/main.c:
1887         (main):
1888
1889 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1890
1891         Revert "Introducing the Platform Abstraction Layer (PAL)"
1892         https://bugs.webkit.org/show_bug.cgi?id=144751
1893
1894         Unreviewed.
1895
1896         PAL should be a new target inside WebCore, rather than a top-level folder.
1897
1898         * Scripts/build-webkit: Add it to build-webkit.
1899
1900 2015-05-07  Ada Chan  <adachan@apple.com>
1901
1902         Add a test for WKPageCopySessionState() with filtering.
1903         https://bugs.webkit.org/show_bug.cgi?id=144666
1904
1905         Reviewed by Darin Adler.
1906
1907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1908         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
1909         (TestWebKitAPI::didFinishLoadForFrame):
1910         (TestWebKitAPI::setPageLoaderClient):
1911         (TestWebKitAPI::filterFirstItemCallback):
1912         (TestWebKitAPI::filterAllItemsCallback):
1913         (TestWebKitAPI::createSessionStates):
1914         (TestWebKitAPI::TEST):
1915
1916 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1917
1918         iOS build fix attempt
1919
1920         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
1921
1922         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1923
1924 2015-05-06  Matt Baker  <mattbaker@apple.com>
1925
1926         Unreviewed, updated my list of email addresses.
1927
1928         * Scripts/webkitpy/common/config/contributors.json:
1929
1930 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1931
1932         Do not link tools to WebKit2.framework
1933         https://bugs.webkit.org/show_bug.cgi?id=144699
1934
1935         Unreviewed build fix.
1936
1937         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1938         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1939         These linked to WebKit2 in two ways, eliminating the other one.
1940
1941 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1942
1943         Introducing the Platform Abstraction Layer (PAL)
1944         https://bugs.webkit.org/show_bug.cgi?id=143358
1945
1946         Reviewed by Simon Fraser.
1947
1948         * Scripts/build-webkit: Add it to build-webkit.
1949
1950 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1951
1952         Fix api tests after r183877.
1953
1954         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1955         (TestWebKitAPI::TEST_F):
1956         Generate all DFAs before compiling them.
1957
1958 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1959
1960         Do not link tools to WebKit2.framework
1961         https://bugs.webkit.org/show_bug.cgi?id=144699
1962
1963         Reviewed by Tim Horton.
1964
1965         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1967         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1968
1969 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1970
1971         [Content Extensions] Test splitting NFAs by max NFA size.
1972         https://bugs.webkit.org/show_bug.cgi?id=144659
1973
1974         Reviewed by Darin Adler.
1975
1976         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1977         (TestWebKitAPI::createNFAs):
1978         (TestWebKitAPI::TEST_F):
1979         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1980         (TestWebKitAPI::createNFAs):
1981
1982 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
1983
1984         Remove the remaining vestiges of SVG feature define
1985         https://bugs.webkit.org/show_bug.cgi?id=144655
1986
1987         Reviewed by Alexey Proskuryakov.
1988
1989         * Scripts/webkitperl/FeatureList.pm:
1990
1991 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
1992
1993         Add a layout mode for computing fixed layout size from a minimum size
1994         https://bugs.webkit.org/show_bug.cgi?id=144610
1995         <rdar://problem/19790341>
1996
1997         Reviewed by Simon Fraser.
1998
1999         * MiniBrowser/mac/BrowserWindow.xib:
2000         * MiniBrowser/mac/BrowserWindowController.h:
2001         * MiniBrowser/mac/WK1BrowserWindowController.m:
2002         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
2003         * MiniBrowser/mac/WK2BrowserWindowController.m:
2004         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
2005         Add a optional toolbar item to toggle a minimum view size of 1024x0.
2006
2007 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2008
2009         [Content Extensions] Release input NSString when finished copying it.
2010         https://bugs.webkit.org/show_bug.cgi?id=144642
2011
2012         Reviewed by Brian Weinstein.
2013
2014         * WebKitTestRunner/mac/TestControllerMac.mm:
2015         (WTR::TestController::platformConfigureViewForTest):
2016         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
2017
2018 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
2019
2020         Unreviewed test fix after r183798.
2021
2022         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2023         (convertToDRTLabel): Mimic behavior of Mac accessibility output
2024         so we can share results.
2025
2026 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2027
2028         [Content Extensions] Use less memory to store the json input.
2029         https://bugs.webkit.org/show_bug.cgi?id=144604
2030
2031         Reviewed by Benjamin Poulain.
2032
2033         * MiniBrowser/mac/ExtensionManagerWindowController.m:
2034         (-[ExtensionManagerWindowController add:]):
2035         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2036         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2037         * WebKitTestRunner/mac/TestControllerMac.mm:
2038         (WTR::TestController::platformConfigureViewForTest):
2039
2040 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2041
2042         Unreviewed. Make myself a WebKit reviewer.
2043
2044         * Scripts/webkitpy/common/config/contributors.json:
2045
2046 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
2047
2048         [GTK] r183783 breaks build
2049         https://bugs.webkit.org/show_bug.cgi?id=144632
2050
2051         Reviewed by Martin Robinson.
2052
2053         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
2054
2055         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2056         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2057
2058 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2059
2060         [Content Extensions] Combine NFAs properly and free memory as we compile.
2061         https://bugs.webkit.org/show_bug.cgi?id=144485
2062
2063         Reviewed by Benjamin Poulain.
2064
2065         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2066         (TestWebKitAPI::TEST_F):
2067         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
2068         Added tests for deep NFAs.
2069
2070 2015-05-04  Alex Christensen  <achristensen@webkit.org>
2071
2072         [Content Extensions] Use less memory when writing byte code to file
2073         https://bugs.webkit.org/show_bug.cgi?id=144602
2074
2075         Reviewed by Darin Adler.
2076
2077         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2078
2079 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
2082         https://bugs.webkit.org/show_bug.cgi?id=144541
2083
2084         Reviewed by Žan Doberšek.
2085
2086         Add a test case to WorkQueue unit test, to check that sources of
2087         asynchronous IO operations running in the WorkQueue thread are
2088         dispatched by the WorkQueue main loop.
2089
2090         * TestWebKitAPI/PlatformGTK.cmake:
2091         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
2092         (TestWebKitAPI::TEST):
2093
2094 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2095
2096         Correct '--show-webview' option for Tiled Drawing tests
2097         https://bugs.webkit.org/show_bug.cgi?id=144621
2098
2099         Reviewed by Simon Fraser.
2100
2101         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
2102         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
2103
2104         * WebKitTestRunner/mac/TestControllerMac.mm:
2105         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
2106         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
2107
2108 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
2109
2110         Large array shouldn't be slow
2111         https://bugs.webkit.org/show_bug.cgi?id=144617
2112
2113         Reviewed by Geoffrey Garen.
2114         
2115         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
2116         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
2117         long-running. So, hash-map sort of belongs here.
2118
2119         * Scripts/run-jsc-benchmarks:
2120
2121 2015-05-04  Doug Russell  <d_russell@apple.com>
2122
2123         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
2124         https://bugs.webkit.org/show_bug.cgi?id=144489
2125
2126         Reviewed by Chris Fleizach.
2127
2128         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
2129         on the returned control.
2130         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
2131         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
2132         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
2133         Add support for setSelectedVisibleTextRange() in accessibility tests.
2134
2135         * DumpRenderTree/AccessibilityUIElement.cpp:
2136         (setSelectedVisibleTextRangeCallback):
2137         (AccessibilityUIElement::setSelectedVisibleTextRange):
2138         (AccessibilityUIElement::getJSClass):
2139         (AccessibilityUIElement::textMarkerForIndex): Deleted.
2140         * DumpRenderTree/AccessibilityUIElement.h:
2141         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2142         (AccessibilityUIElement::setSelectedVisibleTextRange):
2143         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2144         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2145         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2146         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2147         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2148         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2149         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2150         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2151         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2152         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2153         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2154
2155 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2156
2157         [Win] Implement the "--show-webview" option for Windows
2158         https://bugs.webkit.org/show_bug.cgi?id=144589
2159
2160         Reviewed by Alex Christensen.
2161
2162         Add another runtime flag (--show-webview) that causes DumpRenderTree
2163         to draw its view on-screen, rather than the standard offscreen mode.
2164
2165         * DumpRenderTree/win/DumpRenderTree.cpp:
2166         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
2167         (initializeGlobalsFromCommandLineOptions): Recognize the new
2168         command-line argument, and set the global 'showWebView' state if
2169         appropriate.
2170
2171 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
2172
2173         Remove dead code from TestInvocationCairo.cpp
2174         https://bugs.webkit.org/show_bug.cgi?id=144564
2175
2176         Reviewed by Gyuyoung Kim.
2177
2178         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
2179
2180         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2181         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2182
2183 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
2184
2185         [GTK] Add libnotify in gtk install-dependencies
2186         https://bugs.webkit.org/show_bug.cgi?id=144379
2187
2188         Reviewed by Csaba Osztrogonác.
2189
2190         * gtk/install-dependencies:
2191
2192 2015-05-01  Dan Bernstein  <mitz@apple.com>
2193
2194         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
2195         https://bugs.webkit.org/show_bug.cgi?id=144501
2196
2197         Reviewed by Darin Adler.
2198
2199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2200         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
2201         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2202         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
2203
2204 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2205
2206         check-webkit-style fails due to system pylint
2207         https://bugs.webkit.org/show_bug.cgi?id=144360
2208
2209         Reviewed by Darin Adler.
2210
2211         Make sure that the directory containing third party autoinstalled modules
2212         is at the beginning of the search path, to avoid conflicts with other
2213         versions of the same modules installed in the system (e.g. pylint).
2214
2215         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
2216         modules directory to sys.path, instead of appending it.
2217
2218 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2219
2220         Unreviewed, updated my list of email addresses.
2221
2222         * Scripts/webkitpy/common/config/contributors.json: Updated.
2223
2224 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
2225
2226         USE(...) macro should expect unprefixed variables
2227         https://bugs.webkit.org/show_bug.cgi?id=144454
2228
2229         Reviewed by Daniel Bates.
2230
2231         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
2232         * DumpRenderTree/config.h: Ditto.
2233         * TestWebKitAPI/config.h: Ditto.
2234
2235 2015-05-01  Basile Clement  <basile_clement@apple.com>
2236
2237         Unreviewed. Add myself as a commiter in contributors.json.
2238
2239         * Scripts/webkitpy/common/config/contributors.json:
2240
2241 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
2242
2243         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
2244         https://bugs.webkit.org/show_bug.cgi?id=144487
2245
2246         Reviewed by Ryosuke Niwa.
2247
2248         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2249         (BenchmarkRunner.merge): Fix bug.
2250         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
2251
2252 2015-05-01  Brady Eidson  <beidson@apple.com>
2253
2254         Add API to disable meta refreshes.
2255         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
2256
2257         Reviewed by Alexey Proskuryakov.
2258
2259         * DumpRenderTree/mac/DumpRenderTree.mm:
2260         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
2261
2262 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
2263
2264         Provide a runtime flag to run-webkit-tests that shows the test view
2265         https://bugs.webkit.org/show_bug.cgi?id=144079.
2266
2267         Unreviewed correction to r183651.
2268
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
2271         flag is included in the options dictionary passed to the PlatformWebView.
2272
2273 2015-05-01  Antti Koivisto  <antti@apple.com>
2274
2275         Remove network process load serialization code
2276         https://bugs.webkit.org/show_bug.cgi?id=144448
2277
2278         Reviewed by Alexey Proskuryakov.
2279
2280         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2281         (WTR::InjectedBundle::beginTesting):
2282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2283         (WTR::TestRunner::setSerializeHTTPLoads):
2284         (WTR::TestRunner::dispatchPendingLoadRequests):
2285
2286 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2287
2288         [GTK] Add libhyphen-dev to the build dependencies
2289         https://bugs.webkit.org/show_bug.cgi?id=144452
2290
2291         Reviewed by Martin Robinson.
2292
2293         * gtk/install-dependencies: Added hyphen as Fedora and Arch
2294         dependencies.
2295
2296 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
2297
2298         Provide a runtime flag to run-webkit-tests that shows the test view
2299         https://bugs.webkit.org/show_bug.cgi?id=144079.
2300
2301         Reviewed by Dean Jackson.
2302
2303         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
2304         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
2305         option:
2306         
2307         --additional-drt-flag="--show-webview"
2308
2309         * DumpRenderTree/mac/DumpRenderTree.mm:
2310         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
2311         '--show-webview' flag.
2312         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
2313         * WebKitTestRunner/Options.cpp:
2314         (WTR::Options::Options):
2315         (WTR::handleOptionShowWebView):
2316         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
2317         * WebKitTestRunner/Options.h:
2318         * WebKitTestRunner/TestController.cpp:
2319         (WTR::TestController::TestController):
2320         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
2321         * WebKitTestRunner/TestController.h:
2322         (WTR::TestController::shouldShowWebView):
2323         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2324         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
2325         options dictionary. If it is true, display the web view while running the test.
2326
2327 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
2328
2329         r183355 didn't trigger Mac tests
2330         https://bugs.webkit.org/show_bug.cgi?id=144464
2331
2332         Reviewed by Simon Fraser.
2333
2334         Update badly neglected filters and unit tests.
2335
2336         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2337         (_should_file_trigger_build):
2338         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2339         (ShouldBuildTest):
2340         (ShouldBuildTest.test_should_build):
2341
2342 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2343
2344         [GTK] Add libhyphen-dev to the build dependencies
2345         https://bugs.webkit.org/show_bug.cgi?id=144452
2346
2347         Reviewed by Martin Robinson.
2348
2349         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
2350         build dependencies.
2351
2352 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
2353
2354         [GTK] Testing dictionaries are not installed automatically
2355         https://bugs.webkit.org/show_bug.cgi?id=144460
2356
2357         Reviewed by Carlos Garcia Campos.
2358
2359         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
2360
2361 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
2362
2363         Fix return code issue, check return code of safari process and dump results to log
2364         https://bugs.webkit.org/show_bug.cgi?id=144436
2365
2366         Reviewed by Ryosuke Niwa.
2367
2368         * Scripts/run-benchmark:
2369         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2370         (BenchmarkRunner.dump): Correct typo.
2371         (BenchmarkRunner.wrap): Add results to console.
2372         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
2373         (OSXSafariDriver.prepareEnv):
2374         (OSXSafariDriver.launchUrl):
2375         (OSXSafariDriver.closeBrowsers):
2376
2377 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2378
2379         Should no longer need to worry about very old versions of Xcode
2380         https://bugs.webkit.org/show_bug.cgi?id=144437
2381
2382         Reviewed by Dan Bernstein.
2383
2384         * Scripts/check-for-exit-time-destructors:
2385         * Scripts/check-for-global-initializers:
2386         * Scripts/check-for-weak-vtables-and-externals:
2387
2388 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2389
2390         REGRESSION(183583): [Mac] make without SDKROOT has issues
2391         https://bugs.webkit.org/show_bug.cgi?id=144431
2392
2393         Reviewed by Dan Bernstein.
2394
2395         * Makefile:
2396         * WebKitTestRunner/Makefile:
2397         Assume an empty SDKROOT means an macosx variant, so only
2398         enable settings if the SDKROOT is not empty and does not
2399         contain "macosx".
2400
2401 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
2402
2403         Expand test infrastructure to support scrolling tests
2404         https://bugs.webkit.org/show_bug.cgi?id=143684
2405         <rdar://problem/20375516>
2406
2407         Reviewed by Simon Fraser.
2408
2409         * DumpRenderTree/mac/DumpRenderTree.mm:
2410         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
2411         reset before the next test run.
2412         * WebKitTestRunner/TestController.cpp:
2413         (WTR::TestController::resetStateToConsistentValues): Ditto."
2414
2415 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2416
2417         Run javascriptcore tests on Windows without cygwin
2418         https://bugs.webkit.org/show_bug.cgi?id=144419
2419
2420         Reviewed by Brent Fulgham.
2421
2422         * Scripts/run-javascriptcore-tests:
2423         (runJSCStressTests):
2424         Just call ruby, not /usr/bin/env ruby.
2425
2426 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
2427
2428         [GTK] Add --enable-shared option to LLVM to build mesa
2429         https://bugs.webkit.org/show_bug.cgi?id=144393
2430
2431         Reviewed by Martin Robinson.
2432
2433         The updated mesa requires the shared LLVM libraries.
2434         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
2435         to LLVM configure script. It will provide shared libraries in addition to static libraries.
2436
2437         * gtk/jhbuild-optional.modules:
2438
2439 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
2440
2441         [GTK] Add support for automatic hyphenation
2442         https://bugs.webkit.org/show_bug.cgi?id=44478
2443
2444         Reviewed by Carlos Garcia Campos.
2445
2446         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
2447         all systems will use the same dictionaries for testing purposes.
2448
2449 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
2450
2451         Failure when building WebKit for appletvsimulator.
2452         https://bugs.webkit.org/show_bug.cgi?id=144356
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
2457         make TVOS and WatchOS behave correctly.
2458
2459         * Makefile:
2460         * WebKitTestRunner/Makefile:
2461
2462 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2463
2464         Use-after-free when invalidating WKPageForceRepaint callback
2465         https://bugs.webkit.org/show_bug.cgi?id=144401
2466         rdar://problem/20741111
2467
2468         Reviewed by Tim Horton.
2469
2470         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
2471
2472         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
2473         Don't do anything on error, because the context may be a stale pointer now.
2474
2475 2015-04-29  David Kilzer  <ddkilzer@apple.com>
2476
2477         check-webkit-style: Don't complain about returning value from Objective-C method call in header
2478         <http://webkit.org/b/144395>
2479
2480         Reviewed by Andy Estes.
2481
2482         * Scripts/webkitpy/style/checkers/cpp.py:
2483         (check_spacing): Update regex so 'return' is ignored if it
2484         precedes the whitespace and bracket.  Change category name to
2485         'whitespace/brackets'.  Add period to error message.
2486         (CppChecker): Add 'whitespace/brackets' as a category.
2487         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2488         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
2489         'CppChecker.categories' since that's where the list lives now.
2490         (CppStyleTest.test_spacing_before_brackets): Add tests for
2491         'whitespace/brackets' issues and non-issues.
2492
2493 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2494
2495         Fix WinCairo bot.
2496
2497         * Scripts/webkitdirs.pm:
2498         (determinePassedConfiguration):
2499         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
2500
2501 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
2502
2503         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
2504         https://bugs.webkit.org/show_bug.cgi?id=132159
2505
2506         Reviewed by Darin Adler.
2507
2508         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
2509         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
2510
2511         * DumpRenderTree/mac/DumpRenderTree.mm:
2512         (fontWhitelist):
2513         (adjustFonts):
2514         (createWebViewAndOffscreenWindow):
2515         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2516         (WTR::activateFonts):
2517         * WebKitTestRunner/mac/TestControllerMac.mm:
2518         (WTR::allowedFontFamilySet):
2519         (WTR::systemHiddenFontFamilySet):
2520         (WTR::generateWhitelist):
2521         (WTR::TestController::platformInitializeContext):
2522
2523 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2524
2525         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2526         https://bugs.webkit.org/show_bug.cgi?id=144155
2527
2528         Reviewed by Andreas Kling.
2529
2530         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2531         Make sure that test window is "visible" before each test. While there is no concrete
2532         evidence that this is the problem indeed, the behavior is consistent with what would
2533         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2534         against potential buggy tests that hide the window and don't show it.
2535
2536 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2537
2538         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2539
2540         Latest changes in the inspector UI made this test fail. We were
2541         relying that the sidebar was always visible and the first 'li'
2542         element of the inspector was the one containing the title. This is
2543         no longer true, so better use document title that is not likely
2544         to change.
2545
2546         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2547         (openRemoteDebuggingSession):
2548
2549 2015-04-29  Andres Gomez  <agomez@igalia.com>
2550
2551         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2552
2553         * Scripts/webkitpy/common/config/contributors.json:
2554
2555 2015-04-29  Andres Gomez  <agomez@igalia.com>
2556
2557         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2558
2559         * Scripts/webkitpy/common/config/watchlist:
2560
2561 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2562
2563         [EFL] Allow to run the tests on the native X display
2564         https://bugs.webkit.org/show_bug.cgi?id=144247
2565
2566         Reviewed by Gyuyoung Kim.
2567
2568         Added the USE_NATIVE_XDISPLAY option for the WTR.
2569         We can select the Xorg driver if environment variable is set up before running the tests.
2570
2571         * Scripts/webkitpy/port/efl.py:
2572         (EflPort._driver_class):
2573
2574 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2575
2576         [GTK] Add libnotify-dev in gtk install-dependencies
2577         https://bugs.webkit.org/show_bug.cgi?id=144379
2578
2579         Reviewed by Žan Doberšek.
2580
2581         * gtk/install-dependencies:
2582
2583 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2584
2585         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2586         https://bugs.webkit.org/show_bug.cgi?id=143001
2587
2588         Reviewed by Gyuyoung Kim.
2589
2590         * WebKitTestRunner/TestController.cpp:
2591         (WTR::shouldUseFixedLayout):
2592
2593 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2594
2595         Increase stablility of run-benchmark script
2596         https://bugs.webkit.org/show_bug.cgi?id=144361
2597
2598         Reviewed by Ryosuke Niwa.
2599
2600         * Scripts/run-benchmark:
2601         (main):
2602         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2603         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2604         (GenericBenchmarkBuilder.clean):
2605         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2606         (BenchmarkRunner.__init__):
2607         (BenchmarkRunner.execute):
2608         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2609         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2610         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2611         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2612         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2613         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2614         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2615         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2616         (HTTPServerDriver.fetchResult):
2617         (HTTPServerDriver):
2618         (HTTPServerDriver.killServer): Add kill server interface.
2619         (HTTPServerDriver.getReturnCode): Add get return code interface.
2620         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2621         (SimpleHTTPServerDriver.serve):
2622         (SimpleHTTPServerDriver.fetchResult):
2623         (SimpleHTTPServerDriver):
2624         (SimpleHTTPServerDriver.killServer):
2625         (SimpleHTTPServerDriver.getReturnCode):
2626         * Scripts/webkitpy/benchmark_runner/utils.py:
2627         (forceRemove): Provide python version of 'rm -rf'.
2628
2629 2015-04-28  Sam Weinig  <sam@webkit.org>
2630
2631         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2632         https://bugs.webkit.org/show_bug.cgi?id=144363
2633
2634         Reviewed by Alex Christensen.
2635
2636         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2637         (TestWebKitAPI::createNFAs):
2638         (TestWebKitAPI::TEST_F):
2639         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2640         (TestWebKitAPI::countLiveNodes):
2641         (TestWebKitAPI::createNFAs):
2642         (TestWebKitAPI::buildDFAFromPatterns):
2643         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2644
2645 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2646
2647         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2648         https://bugs.webkit.org/show_bug.cgi?id=144304
2649
2650         Reviewed by Geoffrey Garen.
2651
2652         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2653         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2654         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2655
2656 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2657
2658         Unreviewed, rolling out r183514.
2659         https://bugs.webkit.org/show_bug.cgi?id=144359
2660
2661         It broke cloop test bots (Requested by mcatanzaro on #webkit).
2662
2663         Reverted changeset:
2664
2665         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2666         https://bugs.webkit.org/show_bug.cgi?id=144304
2667         http://trac.webkit.org/changeset/183514
2668
2669 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2670
2671         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2672         https://bugs.webkit.org/show_bug.cgi?id=144304
2673
2674         Reviewed by Geoffrey Garen.
2675
2676         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2677         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2678         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2679         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2680
2681 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2682
2683         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2684         https://bugs.webkit.org/show_bug.cgi?id=144319
2685
2686         Reviewed by Csaba Osztrogonác.
2687
2688         * TestWebKitAPI/CMakeLists.txt:
2689         * TestWebKitAPI/PlatformEfl.cmake:
2690
2691 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
2692
2693         Fix common typo "targetting" => "targeting"
2694         https://bugs.webkit.org/show_bug.cgi?id=144349
2695
2696         Reviewed by Daniel Bates.
2697
2698         * Scripts/webkitdirs.pm:
2699         (execMacWebKitAppForDebugging):
2700
2701 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2702
2703         [GTK][jhbuild] Mesa build failure with llvm 3.6
2704         https://bugs.webkit.org/show_bug.cgi?id=144250
2705
2706         Reviewed by Žan Doberšek.
2707
2708         Bump the version of Mesa to 10.5.4
2709
2710         * gtk/jhbuild.modules:
2711
2712 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
2713
2714         Disable App Nap in WebKitTestRunner UI process
2715         https://bugs.webkit.org/show_bug.cgi?id=144308
2716
2717         Reviewed by Daniel Bates.
2718
2719         * WebKitTestRunner/mac/main.mm:
2720         (disableAppNapInUIProcess):
2721         (main):
2722
2723 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2724
2725         [GTK] Update JHBuild Mesa download directory
2726         https://bugs.webkit.org/show_bug.cgi?id=144318
2727
2728         Update the download directory of Mesa module since the previous one
2729         doesn't exist any more.
2730
2731         Reviewed by Žan Doberšek.
2732
2733         * gtk/jhbuild.modules:
2734
2735 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2736
2737         Unreviewed, rolling out r183477.
2738         https://bugs.webkit.org/show_bug.cgi?id=144334
2739
2740         Roll back the Mesa dependency bump in fear of uncaught
2741         regressions while the testing bots are no-op. (Requested by
2742         zdobersek on #webkit).
2743
2744         Reverted changeset:
2745
2746         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
2747         https://bugs.webkit.org/show_bug.cgi?id=144250
2748         http://trac.webkit.org/changeset/183477
2749
2750 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2751
2752         [GTK][jhbuild] Mesa build failure with llvm 3.6
2753         https://bugs.webkit.org/show_bug.cgi?id=144250
2754
2755         Reviewed by Žan Doberšek.
2756
2757         Bump the version of Mesa to 10.5.4
2758
2759         * gtk/jhbuild.modules:
2760
2761 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
2762
2763         Add '__init__.py' and fix known bug in benchmark runner.
2764         https://bugs.webkit.org/show_bug.cgi?id=144296
2765
2766         Reviewed by Ryosuke Niwa
2767
2768         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
2769         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
2770         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2771         (BenchmarkRunner.__init__):
2772         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
2773         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
2774         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
2775
2776 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2777
2778         More build fix.
2779
2780         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2781         (-[AccessibilityNotificationHandler _notificationReceived:]):
2782         Use -objectForKey:, not array subscript.
2783
2784 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2785
2786         Catch unexpected exits in DumpRenderTree
2787         https://bugs.webkit.org/show_bug.cgi?id=144288
2788
2789         Reviewed by Tim Horton.
2790
2791         * DumpRenderTree/mac/DumpRenderTree.mm:
2792         (atexitFunction):
2793         (DumpRenderTreeMain):
2794
2795 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2796
2797         Build fix
2798
2799         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2800         (-[AccessibilityNotificationHandler _notificationReceived:]):
2801         Use -objectForKey:, not array subscript.
2802
2803 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2804
2805         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2806         https://bugs.webkit.org/show_bug.cgi?id=144155
2807
2808         Reviewed by Tim Horton.
2809
2810         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2811         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
2812         and we clearly don't want App Nap while testing.
2813
2814 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
2815
2816         [CMake] Autogenerate cmakeconfig.h.cmake
2817         https://bugs.webkit.org/show_bug.cgi?id=143997
2818
2819         Reviewed by Csaba Osztrogonác.
2820
2821         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
2822         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
2823
2824 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
2825
2826         REGRESSION(r182879): Images and video can no longer be downloaded
2827         https://bugs.webkit.org/show_bug.cgi?id=144267
2828         <rdar://problem/20702844>
2829
2830         Reviewed by Simon Fraser.
2831
2832         Revise tests to check for proper download menu state.
2833         1. Downloading a loal image should be disabled.
2834         2. Downloading a local media file should be disabled.
2835         3. Downloading non-downloadable media should be disabled.
2836
2837         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2838         (TestWebKitAPI::TEST):
2839
2840 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2841
2842         Merge run-launcher into run-minibrowser
2843         https://bugs.webkit.org/show_bug.cgi?id=141928
2844
2845         Reviewed by Darin Adler.
2846
2847         * Scripts/run-iexploder-tests:
2848         (runSafariWithIExploder):
2849         * Scripts/run-launcher: Removed.
2850         * Scripts/run-minibrowser:
2851         * Scripts/webkitdirs.pm:
2852         (launcherPath):
2853         * Scripts/webkitpy/port/efl.py:
2854         (EflPort.show_results_html_file):
2855         * Scripts/webkitpy/port/efl_unittest.py:
2856         (EflPortTest.test_show_results_html_file):
2857         * Scripts/webkitpy/port/gtk.py:
2858         (GtkPort.print_leaks_summary):
2859         (GtkPort.show_results_html_file):
2860         (GtkPort): Deleted.
2861         * Scripts/webkitpy/port/gtk_unittest.py:
2862         (GtkPortTest.test_show_results_html_file):
2863
2864 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2865
2866         [buildbot] Fix the output of perf-test buildstep on timeout
2867         https://bugs.webkit.org/show_bug.cgi?id=144097
2868
2869         Reviewed by Ryosuke Niwa.
2870
2871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2872         (RunAndUploadPerfTests.getText2):
2873         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2874         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
2875         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
2876
2877 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2878
2879         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
2880         https://bugs.webkit.org/show_bug.cgi?id=143874
2881
2882         Reviewed by Gyuyoung Kim.
2883
2884         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
2885
2886 2015-04-24  Philippe Normand  <pnormand@igalia.com>
2887
2888         [JHBuild] Move to upstream OpenWebRTC
2889         https://bugs.webkit.org/show_bug.cgi?id=144145
2890
2891         Reviewed by Carlos Garcia Campos.
2892
2893         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
2894         and add a new simple patch to gst-plugins-base, required for
2895         OpenWebRTC build.
2896         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2897         * gtk/jhbuild.modules: Ditto.
2898         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2899
2900 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2901
2902         [ES6] Implement ES6 template literals
2903         https://bugs.webkit.org/show_bug.cgi?id=142691
2904
2905         Reviewed by Darin Adler.
2906
2907         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
2908
2909         * Scripts/webkitperl/FeatureList.pm:
2910
2911 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2912
2913         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
2914         https://bugs.webkit.org/show_bug.cgi?id=144217
2915
2916         Reviewed by Darin Adler.
2917
2918         * WebKitTestRunner/PlatformEfl.cmake:
2919
2920 2015-04-26  Doug Russell  <d_russell@apple.com>
2921
2922         AX: richer text change notifications (142719)
2923         https://bugs.webkit.org/show_bug.cgi?id=142719
2924
2925         Reviewed by Darin Adler.
2926
2927         Richer accessibility value change notifications. Introduce AXTextEditType,
2928         postTextStateChangeNotification and postTextReplacementNotification to give assistive
2929         tech apps more reliable context for responding to changes in web content. Also implement
2930         a mechanism to post value changes in password form fields in coalesced ticks to thwart
2931         analyzing the cadence of changes.
2932
2933         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
2934         and an overload of postTextReplacementNotification to give assistive tech apps more
2935         reliable context for responding to changes in web content selection. Also block posting
2936         selection changes on password fields.
2937
2938         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2939         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2940         (-[AccessibilityNotificationHandler stopObserving]):
2941         (-[AccessibilityNotificationHandler _notificationReceived:]):
2942         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2943         (AccessibilityUIElement::removeNotificationListener):
2944         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2945         (-[AccessibilityNotificationHandler _notificationReceived:]):
2946         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2947         (WTR::AccessibilityUIElement::removeNotificationListener):
2948
2949 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
2950
2951         Add myself to contributors.json
2952         https://bugs.webkit.org/show_bug.cgi?id=144204
2953
2954         Reviewed by Darin Adler.
2955
2956         * Scripts/webkitpy/common/config/contributors.json:
2957
2958 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
2959
2960         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
2961         https://bugs.webkit.org/show_bug.cgi?id=144182
2962
2963         Reviewed by Simon Fraser.
2964
2965         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
2966
2967 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
2968
2969         https://bugs.webkit.org/show_bug.cgi?id=144038
2970
2971         Reviewed by Ryosuke Niwa
2972
2973         Add a script to run Speedometer and JetStream on a browser.
2974
2975         * Scripts/run-benchmark: Wrapper script to run benchmark.
2976         (main):
2977         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
2978         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
2979         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
2980         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
2981         (BenchmarkBuilderFactory):
2982         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
2983         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
2984         (GenericBenchmarkBuilder):
2985         (GenericBenchmarkBuilder.prepare):
2986         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
2987         (GenericBenchmarkBuilder._applyPatch):
2988         (GenericBenchmarkBuilder.clean):
2989         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
2990         (JetStreamBenchmarkBuilder):
2991         (JetStreamBenchmarkBuilder.prepare):
2992         (JetStreamBenchmarkBuilder._runCreateScript):
2993         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
2994         (BenchmarkRunner):
2995         (BenchmarkRunner.__init__):
2996         (BenchmarkRunner.execute):
2997         (BenchmarkRunner.dump):
2998         (BenchmarkRunner.wrap):
2999         (BenchmarkRunner.merge):
3000         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
3001         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
3002         (BrowserDriver):
3003         (BrowserDriver.prepareEnv):
3004         (BrowserDriver.launchUrl):
3005         (BrowserDriver.closeBrowser):
3006         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
3007         (BrowserDriverFactory):
3008         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
3009         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
3010         (OSXChromeDriver):
3011         (OSXChromeDriver.prepareEnv):
3012         (OSXChromeDriver.launchUrl):
3013         (OSXChromeDriver.closeBrowsers):
3014         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
3015         (OSXSafariDriver):
3016         (OSXSafariDriver.prepareEnv):
3017         (OSXSafariDriver.launchUrl):
3018         (OSXSafariDriver.closeBrowsers):
3019         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
3020         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
3021         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
3022         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
3023         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
3024         (GenericFactory):
3025         (GenericFactory.iterateGetItem):
3026         (GenericFactory.create):
3027         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
3028         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
3029         (ServerControl):
3030         (ServerControl.render_GET):
3031         (ServerControl.render_POST):
3032         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
3033         (HTTPServerDriver):
3034         (HTTPServerDriver.serve):
3035         (HTTPServerDriver.fetchResult):
3036         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
3037         (HTTPServerDriverFactory):
3038         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
3039         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
3040         (SimpleHTTPServerDriver):
3041         (SimpleHTTPServerDriver.depends):
3042         (SimpleHTTPServerDriver.__init__):
3043         (SimpleHTTPServerDriver.serve):
3044         (SimpleHTTPServerDriver.baseUrl):
3045         (SimpleHTTPServerDriver.fetchResult):
3046         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
3047         (ModuleNotFoundError):
3048         (loadModule):
3049         (getPathFromProjectRoot):
3050         (loadJSONFromFile):
3051         (TimeoutError):
3052         (timeout):
3053         (timeout.__init__):
3054         (timeout.handle_timeout):
3055         (timeout.__enter__):
3056         (timeout.__exit__):
3057
3058 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3059
3060         Unreviewed, rolling out r183303.
3061         https://bugs.webkit.org/show_bug.cgi?id=144181
3062
3063         Change was incorrect, broke builds (Requested by smfr on
3064         #webkit).
3065
3066         Reverted changeset:
3067
3068         "Fix the build."
3069         http://trac.webkit.org/changeset/183303
3070
3071 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
3072
3073         Fix the build.
3074
3075         * MiniBrowser/mac/WK2BrowserWindowController.m:
3076         (-[WK2BrowserWindowController initWithConfiguration:]):
3077
3078 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3079
3080         Disable ActionMenusPDFTest due to timeout on test bot
3081
3082         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3083         (TestWebKitAPI::TEST):
3084
3085 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3086
3087         Unreviewed, rolling out r183266.
3088         https://bugs.webkit.org/show_bug.cgi?id=144164
3089
3090         Broke 32-bit build and a test. (Requested by ap on #webkit).
3091
3092         Reverted changeset:
3093
3094         "AX: richer text change notifications (142719)"
3095         https://bugs.webkit.org/show_bug.cgi?id=142719
3096         http://trac.webkit.org/changeset/183266
3097
3098 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3099
3100         REGRESSION: WebKit2.ActionMenusTest API test fails
3101         https://bugs.webkit.org/show_bug.cgi?id=144149
3102         <rdar://problem/20677770>
3103
3104         Reviewed by Tim Horton.
3105
3106         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
3107         as the 'ActionMenusPDFTest'.
3108         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3109         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
3110         to match the hit test on the 'action-menu-target.pdf' test file.
3111
3112 2015-04-24  Daniel Bates  <dabates@apple.com>
3113
3114         Cleanup: Use @memoized for property IOSSimulator.testing_device
3115         https://bugs.webkit.org/show_bug.cgi?id=141715
3116
3117         Reviewed by Darin Adler.
3118
3119         Simplify the caching of the result of IOSSimulator.testing_device
3120         and make the code more readable by making use of the @memoized declarator
3121         instead of explicitly managing a private instance variable,
3122         IOSSimulator._testing_device, for the cached result.
3123
3124         * Scripts/webkitpy/port/ios.py:
3125         (IOSPort.determine_full_port_name):
3126         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
3127         (IOSSimulatorPort):
3128         (IOSSimulatorPort.testing_device): No need to cache the created device object in
3129         IOSSimulatorPort._testing_device since we are marking this function @memoized.
3130         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
3131         of caching in local variable since we only make use of this value exactly once in this function.
3132         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
3133         been used since being added in r178622. So, we can remove this constructor since
3134         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
3135
3136 2015-04-24  Anders Carlsson  <andersca@apple.com>
3137
3138         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
3139         https://bugs.webkit.org/show_bug.cgi?id=144158
3140
3141         Reviewed by Beth Dakin.
3142
3143         * MiniBrowser/mac/WK2BrowserWindowController.m:
3144         (-[WK2BrowserWindowController initWithConfiguration:]):
3145
3146 2015-04-24  Doug Russell  <d_russell@apple.com>
3147
3148         AX: richer text change notifications (142719)
3149         https://bugs.webkit.org/show_bug.cgi?id=142719
3150
3151         Reviewed by Darin Adler.
3152
3153         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
3154
3155         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
3156
3157         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3158         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3159         (-[AccessibilityNotificationHandler stopObserving]):
3160         (-[AccessibilityNotificationHandler _notificationReceived:]):
3161         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3162         (AccessibilityUIElement::removeNotificationListener):
3163         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3164         (-[AccessibilityNotificationHandler _notificationReceived:]):
3165         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3166         (WTR::AccessibilityUIElement::removeNotificationListener):
3167
3168 2015-04-24  Darin Adler  <darin@apple.com>
3169
3170         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
3171         https://bugs.webkit.org/show_bug.cgi?id=128007
3172
3173         Reviewed by Anders Carlsson.
3174
3175         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
3176         * DumpRenderTree/win/UIDelegate.h: Ditto.
3177
3178         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
3179         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
3180
3181         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
3182
3183         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
3184         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
3185         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
3186         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
3187         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3188         (WebKitDOMDOMWindowTest::create): Ditto.
3189         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3190         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
3191         of smart pointers to DelayedSIgnal objects.
3192         (uriChangedCallback): Ditto.
3193
3194 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3195
3196         [Mac] Unreviewed test fix.
3197         https://bugs.webkit.org/show_bug.cgi?id=144149
3198
3199         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3200         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
3201         test.
3202
3203 2015-04-23  Darin Adler  <darin@apple.com>
3204
3205         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
3206         https://bugs.webkit.org/show_bug.cgi?id=144090
3207
3208         Reviewed by Anders Carlsson.
3209
3210         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
3211
3212 2015-04-23  Michael Saboff  <msaboff@apple.com>
3213
3214         lldb macro btjs sometimes can't get a frame description
3215         https://bugs.webkit.org/show_bug.cgi?id=144130
3216
3217         Reviewed by Filip Pizlo.
3218
3219         We look to execute ExecState::describeFrame().  It appears that in some contexts the
3220         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
3221         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
3222
3223         * lldb/lldb_webkit.py:
3224         (btjs):
3225
3226 2015-04-23  Alex Christensen  <achristensen@webkit.org>
3227
3228         Use less memory when compiling content extensions.
3229         https://bugs.webkit.org/show_bug.cgi?id=144051
3230
3231         Reviewed by Darin Adler and Benjamin Poulain.
3232
3233         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3234         (TestWebKitAPI::TEST_F):
3235         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3236         (TestWebKitAPI::countLiveNodes):
3237
3238 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3239
3240         [CMake] Clean up JSC JIT options
3241         https://bugs.webkit.org/show_bug.cgi?id=143998
3242
3243         Reviewed by Filip Pizlo.
3244
3245         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
3246         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
3247
3248 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
3249
3250         [Mac] Extend action menus to support PDF
3251         https://bugs.webkit.org/show_bug.cgi?id=143895
3252         <rdar://problem/19003333>
3253
3254         Reviewed by Tim Horton.
3255
3256         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
3257         of PDF content works.
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
3260         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
3261         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
3262         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3263         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3264         Update to support PDF tests.
3265         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
3266         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
3267
3268 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3269
3270         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
3271
3272         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3273         (beforeAll):
3274         (testWebViewAudioOnlyUserMediaPermissionRequests):
3275
3276 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3277
3278         Add myself to watchlist
3279         https://bugs.webkit.org/show_bug.cgi?id=144041
3280
3281         Reviewed by Alex Christensen.
3282
3283         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
3284
3285         * Scripts/webkitpy/common/config/watchlist:
3286
3287 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3288
3289         [GTK] MiniBrowser should use NetworkProcess by default
3290         https://bugs.webkit.org/show_bug.cgi?id=143948
3291
3292         Reviewed by Sergio Villar Senin.
3293
3294         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
3295         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
3296
3297         * MiniBrowser/gtk/main.c:
3298         (main):
3299
3300 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
3301
3302         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
3303
3304         Unreviewed build fix.
3305
3306         * Scripts/prepare-ChangeLog:
3307         (get_function_line_ranges_for_cpp):
3308         Use grep instead of any to determine if a string is an element of an array.
3309
3310 2015-04-21  Anders Carlsson  <andersca@apple.com>
3311
3312         Fix block signatures
3313         https://bugs.webkit.org/show_bug.cgi?id=144002
3314
3315         Reviewed by Andreas Kling.
3316
3317         * MiniBrowser/mac/WK2BrowserWindowController.m:
3318         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3319
3320 2015-04-21  Philippe Normand  <pnormand@igalia.com>
3321
3322         [GTK] jhbuild should not use a branch for openwebrtc
3323         https://bugs.webkit.org/show_bug.cgi?id=143981
3324
3325         Reviewed by Carlos Garcia Campos.
3326
3327         * gtk/jhbuild.modules:
3328
3329 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
3330
3331         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
3332
3333         Unreviewed build fix.
3334
3335         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
3336         However, it has been exposed by List::MoreUtils since its inception. This patch uses
3337         the any function exposed by List::MoreUtils for greater compatibility.
3338
3339         * Scripts/prepare-ChangeLog:
3340         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
3341         the any function in all of versions of Perl used by our infrastructure.
3342
3343 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3344
3345         Remove unnecessary logs when resetting tests.
3346
3347         * WebKitTestRunner/mac/TestControllerMac.mm:
3348         (WTR::TestController::platformResetPreferencesToConsistentValues):
3349         In r183020 I added some logs when compiling or removing content extensions fails.
3350         We often try to remove a content extension that does not exist, and that is not a problem.
3351
3352 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3353
3354         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
3355         https://bugs.webkit.org/show_bug.cgi?id=143897
3356
3357         Reviewed by David Kilzer.
3358
3359         This is a speculative fix that addresses two issues:
3360
3361         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
3362         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
3363
3364         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
3365         Before: (723, 729)
3366         After: (721, 720)
3367
3368         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
3369         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
3370
3371         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
3372         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
3373
3374         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
3375
3376         2. Creating git diffs from HEAD and not origin/master by default.
3377
3378         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
3379         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
3380
3381         * Scripts/prepare-ChangeLog:
3382         (originalFile):
3383         Use HEAD instead of origin/master in default Git case.
3384
3385         (generateFunctionLists):
3386         Ensure that the end line is not less than the start line.
3387
3388         (extractLineRangeAfterChange):
3389         Set the end line to the start line if the end line is less than the start line.
3390
3391         (extractLineRangeBeforeChange):
3392         Ditto.
3393
3394 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3395
3396         Suppress warning in prepare-ChangeLog.
3397         https://bugs.webkit.org/show_bug.cgi?id=143882
3398
3399         Reviewed by David Kilzer.
3400
3401         Prune noisy prepare-ChangeLog output by using the List::Util::any function
3402         instead of the deprecated smartmatch operator.
3403
3404         * Scripts/prepare-ChangeLog:
3405         Import the List::Util::any function.
3406
3407         (get_function_line_ranges_for_cpp):
3408         Use the any function instead of smartmatch.
3409
3410 2015-04-20  Anders Carlsson  <andersca@apple.com>
3411
3412         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
3413         https://bugs.webkit.org/show_bug.cgi?id=143966
3414
3415         Reviewed by Dan Bernstein.
3416
3417         * MiniBrowser/mac/WK2BrowserWindowController.m:
3418         (dataTypes):
3419         (-[WK2BrowserWindowController fetchWebsiteData:]):
3420         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3421         (-[WK2BrowserWindowController clearWebsiteData:]):
3422
3423 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3424
3425         Fix content extension test flakiness.
3426         https://bugs.webkit.org/show_bug.cgi?id=143950
3427
3428         Reviewed by Brady Eidson.
3429
3430         * WebKitTestRunner/mac/TestControllerMac.mm:
3431         (WTR::TestController::platformResetPreferencesToConsistentValues):
3432         Remove the TestContentExtensions if it exists.
3433         (WTR::TestController::platformConfigureViewForTest):
3434         Log errors in case there are any.
3435
3436 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3437
3438         Properly report errors from _WKUserContentExtensionStore.
3439         https://bugs.webkit.org/show_bug.cgi?id=143808
3440
3441         Reviewed by Darin Adler.
3442
3443         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3444         (TEST_F):
3445
3446 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3447
3448         Add a rule for NetworkCache to watchlist file
3449         https://bugs.webkit.org/show_bug.cgi?id=143945
3450
3451         Reviewed by Sergio Villar Senin.
3452
3453         And add myself to the list of watchers.
3454
3455         * Scripts/webkitpy/common/config/watchlist:
3456
3457 2015-04-19  Darin Adler  <darin@apple.com>
3458
3459         Update RefPtr documentation and deprecation
3460         https://bugs.webkit.org/show_bug.cgi?id=143936
3461
3462         Reviewed by Andreas Kling.
3463
3464         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
3465
3466 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3467
3468         Introduce bytecode intrinsics
3469         https://bugs.webkit.org/show_bug.cgi?id=143926
3470
3471         Reviewed by Filip Pizlo.
3472
3473         Change cpplint to accept emit_intrinsic_XXX.
3474
3475         * Scripts/webkitpy/style/checkers/cpp.py:
3476         (check_identifier_name_in_declaration):
3477
3478 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
3479
3480         Fix lldb_webkit.py to show StringImpls correctly
3481         https://bugs.webkit.org/show_bug.cgi?id=143920
3482
3483         Reviewed by Andreas Kling.
3484         
3485         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
3486
3487         * lldb/lldb_webkit.py:
3488         (WTFStringImplProvider.is_8bit):
3489
3490 2015-04-17  Daniel Bates  <dabates@apple.com>
3491
3492         Not able to build WebKit against iOS Simulator 8.3 SDK
3493         https://bugs.webkit.org/show_bug.cgi?id=143883
3494
3495         Reviewed by David Kilzer.
3496
3497         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
3498         so that Xcode uses them.
3499
3500         * Scripts/copy-webkitlibraries-to-product-directory:
3501
3502 2015-04-17  Beth Dakin  <bdakin@apple.com>
3503
3504         Force mouse events should go through normal mouse event handling code paths
3505         https://bugs.webkit.org/show_bug.cgi?id=143749
3506         -and corresponding-
3507         rdar://problem/20472895
3508
3509         Reviewed by Dean Jackson.
3510
3511         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3512         Since there is not a way to create an NSEventTypePressure from scratch, we 
3513         subclass NSEvent and override all of the critical methods.
3514
3515         * WebKitTestRunner/EventSenderProxy.h:
3516         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3517         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3518         (WTR::EventSendingController::mouseForceDown):
3519         (WTR::EventSendingController::mouseForceUp):
3520         (WTR::EventSendingController::mouseForceChanged):
3521         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3522         * WebKitTestRunner/TestController.cpp:
3523         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3524         * WebKitTestRunner/mac/EventSenderProxy.mm:
3525         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3526         (-[EventSenderPressureEvent timestamp]):
3527         (-[EventSenderPressureEvent type]):
3528         (-[EventSenderPressureEvent locationInWindow]):
3529         (-[EventSenderPressureEvent location]):
3530         (-[EventSenderPressureEvent stage]):
3531         (-[EventSenderPressureEvent pressure]):
3532         (-[EventSenderPressureEvent phase]):
3533         (-[EventSenderPressureEvent eventNumber]):
3534         (WTR::EventSenderProxy::mouseForceDown):
3535         (WTR::EventSenderProxy::mouseForceUp):
3536         (WTR::EventSenderProxy::mouseForceChanged):
3537
3538 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
3539
3540         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3541         https://bugs.webkit.org/show_bug.cgi?id=143885
3542
3543         Reviewed by Tim Horton.
3544
3545         Fixed a case where we have two builds with the same revision(s). An in order build
3546         is one for which the revision is strictly higher.
3547
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3549         (BuildbotQueue.prototype._checkForInOrderResult):
3550         (BuildbotQueue.prototype.compareIterationsByRevisions):
3551
3552 2015-04-17  Commit Queue  <commit-queue@webkit.org>
3553
3554         Unreviewed, rolling out r182912 and r182920.
3555         https://bugs.webkit.org/show_bug.cgi?id=143881
3556
3557         Build breakage in some configurations (Requested by ap on
3558         #webkit).
3559
3560         Reverted changesets:
3561
3562         "Force mouse events should go through normal mouse event
3563         handling code paths"
3564         https://bugs.webkit.org/show_bug.cgi?id=143749
3565         http://trac.webkit.org/changeset/182912
3566
3567         http://trac.webkit.org/changeset/182920
3568
3569 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3570
3571         [GTK] One more unreviewed fix after r182882.
3572
3573         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3574
3575 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3576
3577         [GTK] Unreviewed speculative clean build fix after r182882.
3578
3579         TestWebKitAPI's forwarding header generator depended on WeKit2's
3580         which generated SOUP related forwarding headers too.
3581
3582         This dependency isn't necessary and was removed by r182882 to make
3583         forwarding header generators parallelizable. But in this case
3584         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3585         should generate SOUP related forwarding headers too similar to EFL.
3586
3587         * TestWebKitAPI/PlatformGTK.cmake:
3588         * WebKitTestRunner/PlatformGTK.cmake:
3589
3590 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3591
3592         [SOUP] Redirect to non HTTP destination is broken
3593         https://bugs.webkit.org/show_bug.cgi?id=143866
3594
3595         Reviewed by Sergio Villar Senin.
3596
3597         Add a unit test to check that redirect to a data URI works.
3598
3599         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3600         (testRedirectToDataURI):
3601         (serverCallback):
3602         (beforeAll):
3603
3604 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3605
3606         Changes method of quitting iOS Simulator to be more correct.
3607         https://bugs.webkit.org/show_bug.cgi?id=143847
3608         <rdar://problem/20530344>
3609
3610         Reviewed by Darin Adler.
3611
3612         Fixes by addressing the app by ID rather than by name.
3613
3614         * Scripts/webkitdirs.pm:
3615         (quitIOSSimulator):
3616         * Scripts/webkitpy/port/ios.py:
3617         (IOSSimulatorPort.check_sys_deps):
3618
3619 2015-04-16  Anders Carlsson  <andersca@apple.com>
3620
3621         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3622         https://bugs.webkit.org/show_bug.cgi?id=143844
3623
3624         Reviewed by Dan Bernstein.
3625
3626         * MiniBrowser/mac/AppDelegate.m:
3627         (-[BrowserAppDelegate newPrivateWindow:]):
3628         * MiniBrowser/mac/WK2BrowserWindowController.m:
3629         (-[WK2BrowserWindowController initWithConfiguration:]):
3630         (-[WK2BrowserWindowController fetchWebsiteData:]):
3631         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3632         (-[WK2BrowserWindowController clearWebsiteData:]):
3633
3634 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3635
3636         32-bit build fix.
3637
3638         * WebKitTestRunner/mac/TestControllerMac.mm:
3639         (WTR::TestController::platformResetPreferencesToConsistentValues):
3640         (WTR::TestController::platformConfigureViewForTest):
3641         Added WK_API_ENABLED.
3642
3643 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3644
3645         Removed unused WKUserContentFilterRef.
3646         https://bugs.webkit.org/show_bug.cgi?id=143852
3647
3648         Reviewed by Sam Weinig.
3649
3650         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3651         * WebKitTestRunner/mac/TestControllerMac.mm:
3652         (WTR::TestController::platformResetPreferencesToConsistentValues):
3653         (WTR::TestController::platformConfigureViewForTest):
3654
3655 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3656
3657         Unreviewed. Adding myself as a commiter in contributers.json.
3658
3659         * Scripts/webkitpy/common/config/contributors.json:
3660
3661 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
3662
3663         It is very hard to attach a debugger to WebProcess to debug tests
3664         https://bugs.webkit.org/show_bug.cgi?id=143837
3665
3666         Reviewed by Chris Dumez.
3667
3668         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
3669         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
3670
3671         Now it disables all timeouts in tools, as is best for debugging tests.
3672
3673         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
3674         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
3675
3676         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout