[GTK][WPE] Add enable-media websetting
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2
3         [GTK][WPE] Add enable-media websetting
4         https://bugs.webkit.org/show_bug.cgi?id=196863
5
6         Reviewed by Michael Catanzaro.
7
8         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
9         (testWebKitSettings): Add test for the enable-media web-setting.
10
11 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
12
13         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
14         https://bugs.webkit.org/show_bug.cgi?id=196905
15         <rdar://problem/49886096>
16
17         Reviewed by Tim Horton.
18
19         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
20         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
21         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
22         delay timer, we end up with this sequence of events in the problematic (failure) case:
23
24         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
25             ...IPC from UI to web process...
26         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
27             ...IPC from web to UI process...
28         (c) [UI]    Invoke completion handler for script #1
29         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
30             ...IPC from UI to web process...
31         (e) [Web]   Evaluate script #2 in the web process
32         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
33
34         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
35         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
36         #2 is run in step (e).
37
38         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
39         the UI process by waiting on a script message posted by the web process, after attachment updates are
40         dispatched.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
43         (TestWebKitAPI::TEST):
44
45 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
46
47         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
48         https://bugs.webkit.org/show_bug.cgi?id=196909
49
50         Reviewed by Wenson Hsieh.
51
52         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
53         (TestWebKitAPI::TEST):
54
55 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
56
57         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
58         https://bugs.webkit.org/show_bug.cgi?id=196880
59
60         Reviewed by Yusuke Suzuki.
61
62         Add a new function for bytecode cache tests that does not forceDiskCache
63         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
64         test added in this patch, since the code is invalid and therefore won't be
65         cached. It should also be useful for tests that evaluate dynamically
66         generated code.
67
68         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
69         * Scripts/run-jsc-stress-tests:
70
71 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
72
73         Update AudioSession route sharing policy
74         https://bugs.webkit.org/show_bug.cgi?id=196776
75         <rdar://problem/46501611>
76
77         Reviewed by Jer Noble.
78
79         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
80         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
81         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
82         (TestWebKitAPI::TEST):
83
84 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
85
86         [iOS] Software keyboard is shown too frequently on some websites
87         https://bugs.webkit.org/show_bug.cgi?id=195856
88         <rdar://problem/49191395>
89
90         Reviewed by Darin Adler.
91
92         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
93
94         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
95         (WTR::UIScriptController::setHardwareKeyboardAttached):
96         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
97         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
98         (WTR::UIScriptController::setHardwareKeyboardAttached):
99         * TestRunnerShared/UIScriptContext/UIScriptController.h:
100         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
101
102         Additionally link against GraphicsServices in WebKitTestRunner.
103
104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
105         (WTR::TestController::platformResetStateToConsistentValues):
106         (WTR::UIScriptController::setHardwareKeyboardAttached):
107
108 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
109
110         [GTK][WPE] Fix pacman install-dependencies packages
111         https://bugs.webkit.org/show_bug.cgi?id=196817
112
113         Reviewed by Žan Doberšek.
114         
115         python3-setuptools is called python-setuptools
116         ruby-highline is only available on AUR
117         libv4l-devel is incorporated in v4l-utils
118
119         * gtk/install-dependencies:
120         * wpe/install-dependencies:
121
122 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
123
124         [GTK] REGRESSION(r243860): Many tests failing
125         https://bugs.webkit.org/show_bug.cgi?id=196791
126
127         Reviewed by Joanmarie Diggs.
128
129         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
130         multiple documents and check that accessibility hierarchy is updated after a navigation.
131
132         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
133         (loadChangedCallback):
134         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
135         (AccessibilityTest::AccessibilityTest):
136         (AccessibilityTest::~AccessibilityTest):
137         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
138         (AccessibilityTest::findTestServerApplication):
139         (AccessibilityTest::findDocumentWeb):
140         (AccessibilityTest::findRootObject):
141         (AccessibilityTest::waitUntilChildrenRemoved):
142         (AccessibilityTest::ensureProxy):
143         (testAtspiBasicHierarchy):
144         (beforeAll):
145         (afterAll):
146
147 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
148
149         [ews-build] Handle bug titles with unicode characters
150         https://bugs.webkit.org/show_bug.cgi?id=196802
151
152         Reviewed by Dewei Zhu.
153
154         * BuildSlaveSupport/ews-build/steps.py:
155         (ValidatePatch._is_bug_closed):
156
157 2019-04-11  Michael Saboff  <msaboff@apple.com>
158
159         Improve the Inline Cache Stats code
160         https://bugs.webkit.org/show_bug.cgi?id=196836
161
162         Reviewed by Saam Barati.
163
164         Added a new script to consolidate and arrange the output of --useICStats option.
165
166         This script merges the output from every group into one large table and sorts it from most common to
167         least common.  It also counts the slow path GetById and PutById variants and then calculates the
168         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
169         Put together, this is useful to see what property accesses are not getting cached.
170
171         * Scripts/ic-stats.py: Added.
172         (ICStats):
173         (ICStats.__init__):
174         (ICStats.parse):
175         (ICStats.dumpStats):
176         (usage):
177
178 2019-04-10  Alex Christensen  <achristensen@webkit.org>
179
180         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
181         https://bugs.webkit.org/show_bug.cgi?id=196809
182         <rdar://49800762>
183
184         Reviewed by Brady Eidson.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
187         (TEST):
188
189 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
190
191         requestAnimationFrame should execute before the next frame
192         https://bugs.webkit.org/show_bug.cgi?id=177484
193
194         Reviewed by Simon Fraser.
195
196         Add trace points for the page RenderingUpdate.
197
198         * Tracing/SystemTracePoints.plist:
199
200 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
201
202         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
203         https://bugs.webkit.org/show_bug.cgi?id=196760
204
205         Reviewed by Don Olmstead.
206
207         vswhere.exe has been bundled since Visual Studio 2017 version
208         15.2. We shouldn't download vswhere.exe.
209
210         * Scripts/build-jsc: Do not call update-vswhere.py.
211         * Scripts/build-webkit: Ditto.
212         * Scripts/update-vswhere.py: Removed.
213         * Scripts/webkitdirs.pm:
214         (requireModulesForVSWhere): Deleted.
215         (pickCurrentVisualStudioInstallation): Deleted.
216         (visualStudioInstallDirVSWhere): Return the latest installed VS
217         installation path by using the bundled vswhere.exe.
218         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
219         (visualStudioInstallDirFallback): Removed.
220
221 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
222
223         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
224         https://bugs.webkit.org/show_bug.cgi?id=196780
225
226         Reviewed by Alexey Proskuryakov.
227
228         * BuildSlaveSupport/ews-build/steps.py:
229         * BuildSlaveSupport/ews-build/steps_unittest.py:
230
231 2019-04-10  Alex Christensen  <achristensen@webkit.org>
232
233         Add SPI WKNavigationResponse._downloadAttribute
234         https://bugs.webkit.org/show_bug.cgi?id=196755
235         <rdar://49587365>
236
237         Reviewed by Brady Eidson.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
240         (-[NavigationResponseTestDelegate navigationResponse]):
241         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
242         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
243         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
244         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
245         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
246         (readRequest):
247         (writeResponse):
248         (TEST):
249
250 2019-04-10  Tim Horton  <timothy_horton@apple.com>
251
252         Add modern API for overriding the page's specified viewport configuration
253         https://bugs.webkit.org/show_bug.cgi?id=167734
254         <rdar://problem/30331795>
255
256         Reviewed by Simon Fraser.
257
258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
260
261 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
262
263         Add support for incremental bytecode cache updates
264         https://bugs.webkit.org/show_bug.cgi?id=195000
265
266         Reviewed by Filip Pizlo.
267
268         Exit when the initial run to generate bytecode fails.
269
270         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
271
272 2019-04-10  Alex Christensen  <achristensen@webkit.org>
273
274         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
275         https://bugs.webkit.org/show_bug.cgi?id=196744
276         <rdar://49415309>
277
278         Reviewed by Chris Dumez.
279
280         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
281         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
282
283 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
284
285         Add a way to opt into modern compatibility mode in layout tests
286         https://bugs.webkit.org/show_bug.cgi?id=196770
287         <rdar://problem/49777550>
288
289         Reviewed by Antoine Quint.
290
291         Add a new test option to enable modern compatibility mode in layout tests.
292
293         * WebKitTestRunner/TestController.cpp:
294         (WTR::updateTestOptionsFromTestHeader):
295         * WebKitTestRunner/TestController.h:
296         * WebKitTestRunner/TestOptions.h:
297         (WTR::TestOptions::hasSameInitializationOptions const):
298         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
299         (WTR::TestController::platformCreateWebView):
300         (WTR::TestController::enableModernCompatibilityMode):
301
302 2019-04-10  Andy Estes  <aestes@apple.com>
303
304         Try to fix the 32-bit watchOS build.
305
306         * TestWebKitAPI/cocoa/TestWKWebView.mm:
307         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
308
309 2019-04-10  Antoine Quint  <graouts@apple.com>
310
311         Enable Pointer Events on watchOS
312         https://bugs.webkit.org/show_bug.cgi?id=196771
313         <rdar://problem/49040909>
314
315         Reviewed by Dean Jackson.
316
317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
318
319 2019-04-10  Philippe Normand  <pnormand@igalia.com>
320
321         Unreviewed. Fix WPE accessibility tests after r244059.
322
323         We are failing to load the injected bundle due to undefined symbol
324         AccessibilityUIElement::replaceTextInRange().
325
326         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
327         (WTR::AccessibilityUIElement::replaceTextInRange):
328
329 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
330
331         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
332         https://bugs.webkit.org/show_bug.cgi?id=196727
333
334         Reviewed by Fujii Hironori.
335
336         * MiniBrowser/win/WebKitBrowserWindow.cpp:
337         (WebKitBrowserWindow::create):
338
339 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
340
341         [ews-build] Add unit tests for PrintConfiguration
342         https://bugs.webkit.org/show_bug.cgi?id=196752
343
344         Reviewed by Dewei Zhu.
345
346         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
347
348 2019-04-09  Keith Rollin  <krollin@apple.com>
349
350         Unreviewed build maintenance -- update .xcfilelists.
351
352         * DumpRenderTree/DerivedSources-input.xcfilelist:
353         * DumpRenderTree/DerivedSources-output.xcfilelist:
354
355 2019-04-09  Zalan Bujtas  <zalan@apple.com>
356
357         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
358         https://bugs.webkit.org/show_bug.cgi?id=196743
359         <rdar://problem/43897551>
360
361         Reviewed by Tim Horton.
362
363         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
364         (TEST):
365
366 2019-04-09  Youenn Fablet  <youenn@apple.com>
367
368         Close service worker database on network process suspension
369         https://bugs.webkit.org/show_bug.cgi?id=196623
370         <rdar://problem/48930869>
371
372         Reviewed by Alex Christensen.
373
374         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
375
376 2019-04-09  Daniel Bates  <dabates@apple.com>
377
378         [iPad] Should open popover when the spacebar is pressed
379         https://bugs.webkit.org/show_bug.cgi?id=196360
380         <rdar://problem/49389129>
381
382         Reviewed by Brent Fulgham.
383
384         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
385
386         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
387         (WTR::UIScriptController::isShowingPopover const): Added.
388         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
389         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
390         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
391         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
392         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
393         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
394         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
395         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
396         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
397         (WTR::UIScriptController::isShowingPopover const): Added.
398         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
399         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
400         * TestRunnerShared/UIScriptContext/UIScriptController.h:
401         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
402         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
403         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
404         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
405         (-[TestRunnerWKWebView _willPresentPopover]): Added.
406         (-[TestRunnerWKWebView _didDismissPopover]): Added.
407         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
408         (WTR::UIScriptController::isShowingPopover const): Added.
409         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
410         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
411
412 2019-04-09  Alex Christensen  <achristensen@webkit.org>
413
414         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
415         https://bugs.webkit.org/show_bug.cgi?id=196665
416         <rdar://45115669>
417
418         Reviewed by Geoff Garen.
419
420         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
421         (goBack):
422         (+[SimpleLookupContext sharedLookupContext]):
423         (-[SimpleLookupContext lookUpURL:completionHandler:]):
424         (TEST):
425         (+[Simple3LookupContext sharedLookupContext]): Deleted.
426         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
427
428 2019-04-09  John Wilander  <wilander@apple.com>
429
430         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
431         https://bugs.webkit.org/show_bug.cgi?id=196558
432         <rdar://problem/47650245>
433
434         Reviewed by Youenn Fablet.
435
436         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
437         (TestWebKitAPI::TEST):
438             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
439
440 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
441
442         [CMake] Apple builds should use ICU_INCLUDE_DIRS
443         https://bugs.webkit.org/show_bug.cgi?id=196720
444
445         Reviewed by Konstantin Tokarev.
446
447         * TestWebKitAPI/PlatformMac.cmake:
448
449 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
450
451         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
452         https://bugs.webkit.org/show_bug.cgi?id=196694
453         <rdar://problem/48388734>
454
455         Rubber-stamped by Aakash Jain.
456
457         * Scripts/webkitpy/port/image_diff.py:
458         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
459         * Scripts/webkitpy/port/server_process.py:
460         (ServerProcess.has_available_stdout): Check if stdout has data in it.
461         (ServerProcess._wait_for_data_and_update_buffers_using_select):
462         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
463         * Scripts/webkitpy/port/server_process_mock.py:
464         (MockServerProcess.has_available_stdout):
465         * Scripts/webkitpy/port/server_process_unittest.py:
466         (TestServerProcess.serial_test_basic):
467
468 2019-04-09  Jer Noble  <jer.noble@apple.com>
469
470         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
471         https://bugs.webkit.org/show_bug.cgi?id=196097
472
473         Reviewed by Eric Carlson.
474
475         Drive-by bug fix: allow tests to play audio without a user gesture by default.
476
477         * DumpRenderTree/mac/DumpRenderTree.mm:
478         (resetWebPreferencesToConsistentValues):
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::resetPreferencesToConsistentValues):
481
482 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
483
484         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
485         https://bugs.webkit.org/show_bug.cgi?id=196690
486
487         Reviewed by Michael Catanzaro.
488
489         * QueueStatusServer/config/queues.py:
490         * Scripts/webkitpy/common/config/ews.json:
491         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
492         (test_ews_name):
493
494 2019-04-09  Chris Dumez  <cdumez@apple.com>
495
496         Loads using loadHTMLString() cause flashing when process-swapping
497         https://bugs.webkit.org/show_bug.cgi?id=196714
498         <rdar://problem/49637354>
499
500         Reviewed by Antti Koivisto.
501
502         Add API test coverage.
503
504         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
505
506 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
507
508         Unreviewed. Fix ATK accessibility tests after r244059.
509
510         We are failing to load the injected bundle due to undefined symbol
511         AccessibilityUIElement::replaceTextInRange().
512
513         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
514         (WTR::AccessibilityUIElement::replaceTextInRange):
515
516 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
517
518         AX: Support API: accessibilityReplaceRange:withText
519         https://bugs.webkit.org/show_bug.cgi?id=196636
520
521         Unreviewed build fix for Windows port.
522
523         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
524         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
525
526 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
527
528         [CMake][WinCairo] Separate copied headers into different directories
529         https://bugs.webkit.org/show_bug.cgi?id=196655
530
531         Reviewed by Michael Catanzaro.
532
533         * DumpRenderTree/CMakeLists.txt:
534         * MiniBrowser/win/CMakeLists.txt:
535         * TestWebKitAPI/CMakeLists.txt:
536         * TestWebKitAPI/PlatformWin.cmake:
537
538 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
539
540         Log stack-trace for run-webkit-tests when interrupted
541         https://bugs.webkit.org/show_bug.cgi?id=176393
542         <rdar://problem/34262310>
543
544         Reviewed by Lucas Forschler.
545
546         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
547         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
548         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
549         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
550         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
552         (main): Set handlers to log stack trace on interruption.
553
554 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
555
556         AX: Support API: accessibilityReplaceRange:withText
557         https://bugs.webkit.org/show_bug.cgi?id=196636
558
559         Unreviewed build fix for Windows port.
560
561         * DumpRenderTree/AccessibilityUIElement.cpp:
562         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
563
564 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews-build] Scripts using Buildbot API have CORS error
567         https://bugs.webkit.org/show_bug.cgi?id=196709
568
569         Reviewed by Alexey Proskuryakov.
570
571         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
572
573 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
574
575         AX: Support API: accessibilityReplaceRange:withText
576         https://bugs.webkit.org/show_bug.cgi?id=196636
577
578         Reviewed by Daniel Bates.
579
580         * DumpRenderTree/AccessibilityUIElement.cpp:
581         (replaceTextInRangeCallback):
582         (AccessibilityUIElement::replaceTextInRange):
583         (AccessibilityUIElement::getJSClass):
584         * DumpRenderTree/AccessibilityUIElement.h:
585         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
586         (AccessibilityUIElement::replaceTextInRange):
587         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
588         (AccessibilityUIElement::replaceTextInRange):
589         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
590         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
591         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
592         (WTR::AccessibilityUIElement::replaceTextInRange):
593         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
594         (WTR::AccessibilityUIElement::replaceTextInRange):
595
596 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
597
598         [iOS] Do not allow starting selection drags when selection views are not visible
599         https://bugs.webkit.org/show_bug.cgi?id=196686
600         <rdar://problem/49399192>
601
602         Reviewed by Tim Horton.
603
604         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
605         also add some new API tests to cover scenarios where the web view is not first responder.
606
607         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
608         (TestWebKitAPI::TEST):
609         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
610
611         Add a switch to optionally make the web view first responder when starting the simulated drag.
612
613         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
614         (-[DragAndDropSimulator initWithWebView:]):
615         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
616
617 2019-04-08  Justin Fan  <justin_fan@apple.com>
618
619         [Web GPU] Fix Web GPU experimental feature on iOS
620         https://bugs.webkit.org/show_bug.cgi?id=196632
621
622         Reviewed by Myles C. Maxfield.
623
624         Properly make Web GPU available on iOS 11+.
625
626         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
627
628 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
629
630         [ews-build] Do not upload archive when Compile Fails
631         https://bugs.webkit.org/show_bug.cgi?id=196674
632
633         Reviewed by Alexey Proskuryakov.
634
635         * BuildSlaveSupport/ews-build/factories.py:
636         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
637         * BuildSlaveSupport/ews-build/steps.py:
638         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
639         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
640         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
641
642 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
643
644         Enable DFG on MIPS
645         https://bugs.webkit.org/show_bug.cgi?id=196689
646
647         Reviewed by Žan Doberšek.
648
649         Since the bytecode change, we enabled the baseline JIT on mips in
650         r240432, but DFG is still missing. With this change, all tests are
651         passing on a ci20 board.
652
653         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
654
655 2019-04-08  Philippe Normand  <pnormand@igalia.com>
656
657         [Flatpak] Second run update-webkitwpe-flatpak fails
658         https://bugs.webkit.org/show_bug.cgi?id=192702
659
660         Reviewed by Carlos Garcia Campos.
661
662         * flatpak/flatpakutils.py:
663         (FlatpakObject.flatpak): Fix typo.
664         (FlatpakPackage.install): When installing, also update to the configured remote commit.
665         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
666
667 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
668
669         [GTK][WPE] outlook.live.com displays old-fashioned UI
670         https://bugs.webkit.org/show_bug.cgi?id=196642
671
672         Reviewed by Carlos Garcia Campos.
673
674         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
675         (TestWebKitAPI::TEST): New Mac platform quirk test.
676
677 2019-04-07  Commit Queue  <commit-queue@webkit.org>
678
679         Unreviewed, rolling out r243956.
680         https://bugs.webkit.org/show_bug.cgi?id=196688
681
682         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
683         by aakashjain on #webkit).
684
685         Reverted changeset:
686
687         "Clicking "Go Back" from a safe browsing warning from an
688         iframe should navigate the WKWebView back to the previous
689         page"
690         https://bugs.webkit.org/show_bug.cgi?id=196665
691         https://trac.webkit.org/changeset/243956
692
693 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
694
695         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
696         https://bugs.webkit.org/show_bug.cgi?id=196669
697
698         Reviewed by Geoffrey Garen.
699
700         Added three new unit tests for WeakHashSet.
701
702         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
703         (WTF_WeakPtr.WeakHashSetConstObjects):
704         (WTF_WeakPtr.WeakHashSetComputesEmpty):
705         (WTF_WeakPtr.WeakHashSetComputeSize):
706
707 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
708
709         Hide next and previous form control buttons when WKWebView is editable
710         https://bugs.webkit.org/show_bug.cgi?id=196672
711         <rdar://problem/35625321>
712
713         Reviewed by Tim Horton.
714
715         Add a new API test.
716
717         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
718         (-[TestWKWebView lastTrailingBarButtonGroup]):
719         (TestWebKitAPI::TEST):
720         * TestWebKitAPI/ios/UIKitSPI.h:
721
722 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
723
724         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
725         https://bugs.webkit.org/show_bug.cgi?id=196077
726         <rdar://problem/49108202>
727
728         Reviewed by Chris Dumez.
729
730         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
731         on new web view.
732
733         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
734
735 2019-04-05  Saam Barati  <sbarati@apple.com>
736
737         Make compare-results understand MotionMark
738         https://bugs.webkit.org/show_bug.cgi?id=196666
739
740         Reviewed by Yusuke Suzuki.
741
742         * Scripts/compare-results:
743         (PLT5Results):
744         (detectMotionMark):
745         (detectMotionMark1_1):
746         (motionMarkResults):
747         (motionMark1_1Results):
748         (detectBenchmark):
749         (biggerIsBetter):
750         (main):
751
752 2019-04-05  Alex Christensen  <achristensen@webkit.org>
753
754         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
755         https://bugs.webkit.org/show_bug.cgi?id=196665
756         <rdar://45115669>
757
758         Reviewed by Geoff Garen.
759
760         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
761         (goBack):
762         (+[SimpleLookupContext sharedLookupContext]):
763         (-[SimpleLookupContext lookUpURL:completionHandler:]):
764         (TEST):
765         (+[Simple3LookupContext sharedLookupContext]): Deleted.
766         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
767
768 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
769
770         [ews-build] Add configuration and architecture for windows builders
771         https://bugs.webkit.org/show_bug.cgi?id=196660
772
773         Reviewed by Lucas Forschler.
774
775         * BuildSlaveSupport/ews-build/config.json:
776
777 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
778
779         webkitpy: Don't run subsequent rounds if interrupted
780         https://bugs.webkit.org/show_bug.cgi?id=196646
781
782         Reviewed by Aakash Jain.
783
784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
785         (Manager.run): Bail out if interrupted.
786
787 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
788
789         Test sessionStorage in PSON private browsing mode
790         https://bugs.webkit.org/show_bug.cgi?id=196561
791
792         Reviewed by Alex Christensen.
793
794         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
795
796 2019-04-05  Commit Queue  <commit-queue@webkit.org>
797
798         Unreviewed, rolling out r243833.
799         https://bugs.webkit.org/show_bug.cgi?id=196645
800
801         This change breaks build of WPE and GTK ports (Requested by
802         annulen on #webkit).
803
804         Reverted changeset:
805
806         "[CMake][WTF] Mirror XCode header directories"
807         https://bugs.webkit.org/show_bug.cgi?id=191662
808         https://trac.webkit.org/changeset/243833
809
810 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
811
812         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
813         https://bugs.webkit.org/show_bug.cgi?id=196635
814
815         Reviewed by Antti Koivisto.
816         
817         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
818         for a test to enable async frame scrolling via:
819             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
820         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
821         
822         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
823
824         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
825         (WTR::InjectedBundle::beginTesting):
826         * WebKitTestRunner/TestController.cpp:
827         (WTR::TestController::resetPreferencesToConsistentValues):
828
829 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
830
831         Use a correct LC_RPATH when building with ASan
832         https://bugs.webkit.org/show_bug.cgi?id=196576
833
834         Reviewed by David Kilzer.
835
836         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
837         so that ../Frameworks is checked. This is simpler and more reliable than updating
838         each SPC service xcconfig.
839
840 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
841
842         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
843         https://bugs.webkit.org/show_bug.cgi?id=196629
844
845         Reviewed by Lucas Forschler.
846
847         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
848
849 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
850
851         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
852         https://bugs.webkit.org/show_bug.cgi?id=196618
853
854         Reviewed by Lucas Forschler.
855
856         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
857         (StatusBubble): Added QUEUE_TRIGGERS.
858         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
859         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
860         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
861         its parent(builder).
862
863 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
864
865         [ews-app] Status-bubble steps are sometimes displayed in reverse order
866         https://bugs.webkit.org/show_bug.cgi?id=196625
867
868         Reviewed by Lucas Forschler.
869
870         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
871         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
872
873 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
874
875         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
876         https://bugs.webkit.org/show_bug.cgi?id=196630
877
878         Reviewed by Wenson Hsieh.
879
880         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
881
882 2019-04-04  Youenn Fablet  <youenn@apple.com>
883
884         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
885         https://bugs.webkit.org/show_bug.cgi?id=196543
886
887         Reviewed by Alex Christensen.
888
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::generatePageConfiguration):
891
892 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
893
894         [ews-app] Status bubble should not display skipped buildbot steps
895         https://bugs.webkit.org/show_bug.cgi?id=196584
896
897         Reviewed by Lucas Forschler.
898
899         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
900
901 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
902
903         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
904         https://bugs.webkit.org/show_bug.cgi?id=196620
905
906         Reviewed by Lucas Forschler.
907
908         * BuildSlaveSupport/ews-app/ews/config.py:
909
910 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
911
912         [Win] DumpRenderTreeWatchDog.py is not checked into source
913         https://bugs.webkit.org/show_bug.cgi?id=196567
914         <rdar://problem/49525901>
915
916         Reviewed by Lucas Forschler.
917
918         This script is used on Win EWS bots to terminate hanging DRT processes.
919
920         * EWSTools/dumprendertreewatchdog.py: Added.
921
922 2019-04-04  Chris Dumez  <cdumez@apple.com>
923
924         Unreviewed, roll out r243858 which made tests time out.
925
926         Disable new API tests on Windows instead.
927
928         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
929         (TestWebKitAPI::TEST):
930
931 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
932
933         [ATK] Cleanup WebPageAccessibilityObjectAtk
934         https://bugs.webkit.org/show_bug.cgi?id=196537
935
936         Reviewed by Michael Catanzaro.
937
938         Also consider files under atk directories as exceptions for GObject conventions.
939
940         * Scripts/webkitpy/style/checkers/cpp.py:
941         (check_identifier_name_in_declaration):
942
943 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
944
945         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
946         https://bugs.webkit.org/show_bug.cgi?id=196588
947         <rdar://problem/49365787>
948
949         Unreviewed build fix for Windows port.
950
951         error C3861: 'kill': identifier not found
952
953         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
954         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
955
956 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-build] Cancel build and similar operations should have authentication
959         https://bugs.webkit.org/show_bug.cgi?id=196520
960
961         Reviewed by Dewei Zhu.
962
963         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
964         environment variables.
965
966 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
967
968         [ews-build] Do not trigger queues which are not in production yet
969         https://bugs.webkit.org/show_bug.cgi?id=196581
970
971         Reviewed by Dewei Zhu.
972
973         * BuildSlaveSupport/ews-build/config.json:
974
975 2019-04-03  Chris Dumez  <cdumez@apple.com>
976
977         Unreviewed, fix typo in the name of API test added in r243848.
978
979         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
980         (TestWebKitAPI::TEST):
981
982 2019-04-03  Chris Dumez  <cdumez@apple.com>
983
984         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
985         https://bugs.webkit.org/show_bug.cgi?id=196588
986         <rdar://problem/49365787>
987
988         Reviewed by Ryosuke Niwa.
989
990         Add API test coverage.
991
992         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
993         (TestWebKitAPI::nullJavaScriptCallback):
994         (TestWebKitAPI::didCrashCheckFrames):
995         (TestWebKitAPI::TEST):
996
997 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
998
999         run-webkit-tests: Upload test results (new results database)
1000         https://bugs.webkit.org/show_bug.cgi?id=196577
1001         <rdar://problem/34841155>
1002
1003         Reviewed by Lucas Forschler.
1004
1005         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1006         (Manager.run): Upload results after each device shard, since the configuration will be
1007         different for each device.
1008         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1009         uploaded to a results database.
1010         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1011         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1012
1013 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1014
1015         -apple-trailing-word is needed for browser detection
1016         https://bugs.webkit.org/show_bug.cgi?id=196575
1017
1018         Unreviewed.
1019
1020         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1021
1022 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1023
1024         [CMake][WTF] Mirror XCode header directories
1025         https://bugs.webkit.org/show_bug.cgi?id=191662
1026
1027         Reviewed by Konstantin Tokarev.
1028
1029         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1030         builds.
1031
1032         * CMakeLists.txt:
1033         * DumpRenderTree/CMakeLists.txt:
1034         * DumpRenderTree/PlatformWin.cmake:
1035         * MiniBrowser/win/CMakeLists.txt:
1036         * TestWebKitAPI/CMakeLists.txt:
1037         * TestWebKitAPI/PlatformWin.cmake:
1038         * WebKitTestRunner/PlatformGTK.cmake:
1039         * WebKitTestRunner/PlatformWin.cmake:
1040
1041 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1042
1043         [ews-app] Status bubble should not display certain infrastructure status messages
1044         https://bugs.webkit.org/show_bug.cgi?id=196550
1045
1046         Reviewed by Lucas Forschler.
1047
1048         Do not display the steps which are un-needed for end-user. This information is still avaiable
1049         if the user click on the bubble and look at the Buildbot build.
1050         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1051         (StatusBubble._steps_messages):
1052         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1053
1054 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1055
1056         [ews-build] Use https for sending data to ews-app
1057         https://bugs.webkit.org/show_bug.cgi?id=196492
1058
1059         Reviewed by Lucas Forschler.
1060
1061         * BuildSlaveSupport/ews-build/events.py:
1062
1063 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1064
1065         Remove support for -apple-trailing-word
1066         https://bugs.webkit.org/show_bug.cgi?id=196525
1067
1068         Reviewed by Zalan Bujtas.
1069
1070         This CSS property is nonstandard and not used.
1071
1072         * Scripts/webkitperl/FeatureList.pm:
1073         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1074
1075 2019-04-03  Youenn Fablet  <youenn@apple.com>
1076
1077         Add a test for DOMCache on multiple browsing in case of private browsing
1078         https://bugs.webkit.org/show_bug.cgi?id=196524
1079
1080         Reviewed by Alex Christensen.
1081
1082         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1083         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1084
1085 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1086
1087         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1088         https://bugs.webkit.org/show_bug.cgi?id=196540
1089
1090         Reviewed by Aakash Jain.
1091
1092         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1093
1094 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1095
1096         Add plumbing for a compatibility mode preference in WebKit
1097         https://bugs.webkit.org/show_bug.cgi?id=196005
1098
1099         Reviewed by Tim Horton.
1100
1101         Add new API tests.
1102
1103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1104         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1105
1106 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1107
1108         [WPE][GTK] Update libsrtp dependency package for Debian
1109         https://bugs.webkit.org/show_bug.cgi?id=196528
1110
1111         Reviewed by Frédéric Wang.
1112
1113         * gtk/install-dependencies:
1114         * wpe/install-dependencies:
1115
1116 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1117
1118         [WK2] Add support for Window's beforeprint / afterprint events
1119         https://bugs.webkit.org/show_bug.cgi?id=196478
1120         <rdar://problem/49535124>
1121
1122         Unreviewed build fix for MSVC.
1123
1124         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1125
1126         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1127
1128         * WebKitTestRunner/TestController.cpp:
1129         (WTR::printFrame): Use int and float literals.
1130
1131 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1132
1133         [ews-build] Reassign bots to queues
1134
1135         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1136
1137 2019-04-02  Chris Dumez  <cdumez@apple.com>
1138
1139         [WK2] Add support for Window's beforeprint / afterprint events
1140         https://bugs.webkit.org/show_bug.cgi?id=196478
1141
1142         Reviewed by Alex Christensen.
1143
1144         Add minimal implementation for printFrame in WebKitTestRunner.
1145
1146         * WebKitTestRunner/TestController.cpp:
1147         (WTR::printFrame):
1148         (WTR::TestController::createOtherPage):
1149         (WTR::TestController::createWebViewWithOptions):
1150
1151 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1152
1153         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1154         https://bugs.webkit.org/show_bug.cgi?id=196491
1155
1156         Reviewed by Lucas Forschler.
1157
1158         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1159
1160 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1161
1162         [ews-build] Configure buildbot try credentials in environment variables
1163         https://bugs.webkit.org/show_bug.cgi?id=196501
1164
1165         Reviewed by Lucas Forschler.
1166
1167         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1168         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1169         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1170
1171 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1172
1173         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1174         https://bugs.webkit.org/show_bug.cgi?id=196496
1175         <rdar://problem/49521634>
1176
1177         Reviewed by Chris Dumez.
1178
1179         Add new API tests (see WebKit ChangeLog for more detail).
1180
1181         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1182         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1183         (TEST):
1184
1185 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1186
1187         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1188         <https://webkit.org/b/196499>
1189
1190         Reviewed by Alexey Proskuryakov.
1191
1192         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1193         ENABLE_ADDRESS_SANITIZER.
1194
1195 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1196
1197         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1198         https://bugs.webkit.org/show_bug.cgi?id=182757
1199
1200         Reviewed by Don Olmstead.
1201
1202         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1203         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1204
1205 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1206
1207         run-api-tests: Upload test results
1208         https://bugs.webkit.org/show_bug.cgi?id=196323
1209         <rdar://problem/49356714>
1210
1211         Reviewed by Lucas Forschler.
1212
1213         * Scripts/webkitpy/api_tests/manager.py:
1214         (Manager):
1215         (Manager.run): Upload results to a results database.
1216         * Scripts/webkitpy/api_tests/run_api_tests.py:
1217         (parse_args): Add upload arguments.
1218         * Scripts/webkitpy/port/base.py:
1219         (Port):
1220         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1221         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1222         with commits from any other associated repositories.
1223         * Scripts/webkitpy/port/device.py:
1224         (Device):
1225         (Device.build_version): Access build_versoin of underlying platform device.
1226         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1227         (IOSSimulatorTest):
1228         (IOSSimulatorTest.test_configuration_for_upload):
1229         * Scripts/webkitpy/port/device_port.py:
1230         (DevicePort):
1231         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1232         the same as the machine uploading results.
1233         * Scripts/webkitpy/port/mac.py:
1234         (MacPort):
1235         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1236         * Scripts/webkitpy/port/mac_unittest.py:
1237         (MacTest):
1238         (MacTest.test_configuration_for_upload):
1239         * Scripts/webkitpy/xcode/simulated_device.py:
1240         (SimulatedDeviceManager._create_device_with_runtime):
1241         (SimulatedDevice.__init__): Create simulated device with a build_version.
1242         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1243         (test_existing_simulator):
1244
1245 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1246
1247         Remove extra newline characters (Follow-up fix to r243707)
1248
1249         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1250
1251 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1252
1253         [ews-app] Use API_KEY to accept results data
1254         https://bugs.webkit.org/show_bug.cgi?id=196461
1255
1256         Reviewed by Dewei Zhu.
1257
1258         * BuildSlaveSupport/ews-app/ews/views/results.py:
1259         (Results.post): Validate EWS_API_KEY before accepting any data.
1260         * BuildSlaveSupport/ews-build/events.py:
1261         (Events.sendData): Send EWS_API_KEY if available along with event data.
1262
1263 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1264
1265         Unable to copy and paste a PDF from Notes into Mail compose body
1266         https://bugs.webkit.org/show_bug.cgi?id=196442
1267         <rdar://problem/48573098>
1268
1269         Reviewed by Tim Horton.
1270
1271         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1272         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1273         to be specified on the item providers.
1274
1275         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1276         (TestWebKitAPI::mapItemForTesting):
1277         (TestWebKitAPI::contactItemForTesting):
1278
1279 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1280
1281         Make UIWKDocumentContext rects per-character instead of per-word
1282         https://bugs.webkit.org/show_bug.cgi?id=196459
1283
1284         Reviewed by Wenson Hsieh.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1287         (TEST):
1288         Adjust test results due to switching to per-character rects.
1289
1290 2019-04-01  Chris Dumez  <cdumez@apple.com>
1291
1292         UIProcess crash when a prewarmed process is terminated
1293         https://bugs.webkit.org/show_bug.cgi?id=196451
1294         <rdar://problem/49245471>
1295
1296         Reviewed by Geoffrey Garen.
1297
1298         Add API test coverage.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1301         (TEST):
1302
1303 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1304
1305         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1306         https://bugs.webkit.org/show_bug.cgi?id=196449
1307
1308         Reviewed by Lucas Forschler.
1309
1310         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1311         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1312         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1313         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1314
1315 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1316
1317         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1318         https://bugs.webkit.org/show_bug.cgi?id=196444
1319
1320         Reviewed by Lucas Forschler.
1321
1322         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1323
1324 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1325
1326         Add SPI to canonicalize NSURLs with WTF::URL
1327         https://bugs.webkit.org/show_bug.cgi?id=196415
1328         <rdar://problem/44980271>
1329
1330         Reviewed by Darin Adler.
1331
1332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1333         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1334         (TestWebKitAPI::TEST):
1335
1336 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1337
1338         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1339         https://bugs.webkit.org/show_bug.cgi?id=196441
1340
1341         Reviewed by Carlos Garcia Campos.
1342
1343         Don't cache the wpe_view_backend object that might not exist yet at the
1344         time of EventSenderProxy constructor invocation, but instead retrieve
1345         that object whenever it's required for event dispatching. This should
1346         avoid crashes in this constructor now that it's invoked before any
1347         PlatformWindow has been set up (as changed in r243496).
1348
1349         * WebKitTestRunner/EventSenderProxy.h:
1350         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1351         (WTR::viewBackend):
1352         (WTR::EventSenderProxy::EventSenderProxy):
1353         (WTR::EventSenderProxy::mouseDown):
1354         (WTR::EventSenderProxy::mouseUp):
1355         (WTR::EventSenderProxy::mouseMoveTo):
1356         (WTR::EventSenderProxy::mouseScrollBy):
1357         (WTR::EventSenderProxy::keyDown):
1358         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1359
1360 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1361
1362         [Win][WebKit] MiniBrowser should support high DPI display
1363         https://bugs.webkit.org/show_bug.cgi?id=196391
1364
1365         Reviewed by Alex Christensen.
1366
1367         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1368         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1369         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1370         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1371
1372 2019-03-31  Sam Weinig  <weinig@apple.com>
1373
1374         Remove more i386 specific configurations
1375         https://bugs.webkit.org/show_bug.cgi?id=196430
1376
1377         Reviewed by Alexey Proskuryakov.
1378
1379         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1380         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1381
1382 2019-03-31  Andy Estes  <aestes@apple.com>
1383
1384         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1385         https://bugs.webkit.org/show_bug.cgi?id=196433
1386         <rdar://problem/49293305>
1387
1388         Reviewed by Tim Horton.
1389
1390         Enhanced API test coverage to include all navigation response policy decisions in both
1391         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1392
1393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1394         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1395         (TestWebKitAPI::TEST):
1396         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1397         (readFile):
1398         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1399         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1400         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1401         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1402         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1403         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1404         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1405         (-[QuickLookDelegate _downloadDidStart:]):
1406         (-[QuickLookDelegate _download:didReceiveResponse:]):
1407         (-[QuickLookDelegate _download:didReceiveData:]):
1408         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1409         (-[QuickLookDelegate _downloadDidFinish:]):
1410         (-[QuickLookDelegate _download:didFailWithError:]):
1411         (-[QuickLookDelegate _downloadDidCancel:]):
1412         (-[QuickLookDelegate verifyDownload]):
1413         (runTest):
1414         (runTestDecideBeforeLoading):
1415         (runTestDecideAfterLoading):
1416         (TEST):
1417         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1418         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1419         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1420         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1421         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1422         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1423         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1424         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1425         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1426         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1427         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1428         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1429         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1430         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1431
1432 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1433
1434         [CMake] add testdfg as target with build-jsc
1435         https://bugs.webkit.org/show_bug.cgi?id=196393
1436
1437         Reviewed by Saam Barati.
1438
1439         Added testdfg as one of the targets to build when
1440         using CMake.
1441
1442         * Scripts/build-jsc:
1443
1444 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1445
1446         Delete WebMetal implementation in favor of WebGPU
1447         https://bugs.webkit.org/show_bug.cgi?id=195418
1448
1449         Reviewed by Dean Jackson.
1450
1451         * DumpRenderTree/mac/DumpRenderTree.mm:
1452         (enableExperimentalFeatures):
1453         (resetWebPreferencesToConsistentValues):
1454         * Scripts/webkitperl/FeatureList.pm:
1455         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1457         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1458         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1459         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1460         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1461         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1462         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1463         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1464         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1465         (WTR::InjectedBundle::beginTesting):
1466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1467         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1468         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1469
1470 2019-03-29  Chris Dumez  <cdumez@apple.com>
1471
1472         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1473         https://bugs.webkit.org/show_bug.cgi?id=196405
1474         <rdar://problem/49428130>
1475
1476         Reviewed by Wenson Hsieh.
1477
1478         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1479         the popover presentation methods to be no-ops. Use this in the new test added in
1480         r243523 so that we do not swizzle those methods for all tests. This is needed because
1481         those WatchOS tests rely on the popover getting presented and interactive.
1482
1483         * WebKitTestRunner/TestController.cpp:
1484         (WTR::updateTestOptionsFromTestHeader):
1485         * WebKitTestRunner/TestController.h:
1486         * WebKitTestRunner/TestOptions.h:
1487         (WTR::TestOptions::hasSameInitializationOptions const):
1488         * WebKitTestRunner/ios/TestControllerIOS.mm:
1489         (WTR::TestController::platformInitialize):
1490         (WTR::TestController::platformResetStateToConsistentValues):
1491
1492 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1493
1494         [Curl] Add Server Trust Evaluation Support.
1495         https://bugs.webkit.org/show_bug.cgi?id=191646
1496
1497         Reviewed by Fujii Hironori.
1498
1499         Implemented MiniBrowser UI for asking if user trusts the server.
1500
1501         * MiniBrowser/win/Common.cpp:
1502         (askServerTrustEvaluation):
1503         (replaceString):
1504         * MiniBrowser/win/Common.h:
1505         * MiniBrowser/win/MiniBrowserLib.rc:
1506         * MiniBrowser/win/MiniBrowserLibResource.h:
1507         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1508         (createPEMString):
1509         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1510         (WebKitBrowserWindow::canTrustServerCertificate):
1511         * MiniBrowser/win/WebKitBrowserWindow.h:
1512
1513 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1514
1515         Implement ResizeObserver.
1516         https://bugs.webkit.org/show_bug.cgi?id=157743
1517
1518         Reviewed by Simon Fraser.
1519
1520         Support resizeObserverEnabled webPreferences.
1521
1522         * DumpRenderTree/TestOptions.cpp:
1523         (TestOptions::TestOptions):
1524         * DumpRenderTree/TestOptions.h:
1525         * DumpRenderTree/mac/DumpRenderTree.mm:
1526         (setWebPreferencesForTestOptions):
1527         * DumpRenderTree/win/DumpRenderTree.cpp:
1528         (enableExperimentalFeatures):
1529         * Scripts/webkitperl/FeatureList.pm:
1530         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1531
1532 2019-03-28  John Wilander  <wilander@apple.com>
1533
1534         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1535         https://bugs.webkit.org/show_bug.cgi?id=196281
1536         <rdar://problem/48938748>
1537
1538         Reviewed by Alex Christensen.
1539
1540         This patch adds the function isStatisticsHasLocalStorage() to the
1541         TestRunner. With it, the page can query the WebsiteDataStore in the
1542         UI process to make sure that it sees LocalStorage.
1543
1544         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1546         (WTR::TestRunner::isStatisticsHasLocalStorage):
1547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1548         * WebKitTestRunner/TestController.cpp:
1549         (WTR::TestController::isStatisticsHasLocalStorage):
1550         * WebKitTestRunner/TestController.h:
1551         * WebKitTestRunner/TestInvocation.cpp:
1552         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1553
1554 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1555
1556         API::Data::createWithoutCopying should do a null check before calling CFRelease
1557         https://bugs.webkit.org/show_bug.cgi?id=196276
1558         <rdar://problem/48059859>
1559
1560         Reviewed by Alex Christensen.
1561
1562         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1566         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1567         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1568         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1569         (TestWebKitAPI::TEST):
1570
1571 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1572
1573         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1574         https://bugs.webkit.org/show_bug.cgi?id=186276
1575
1576         Reviewed by Carlos Garcia Campos.
1577
1578         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1579         (webViewLoadChanged):
1580         (testWebResourceGetDataError):
1581         (testWebResourceGetDataEmpty):
1582         (beforeAll):
1583         (webViewloadChanged): Deleted.
1584
1585 2019-03-27  Andy Estes  <aestes@apple.com>
1586
1587         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1588         https://bugs.webkit.org/show_bug.cgi?id=196317
1589
1590         Reviewed by Dan Bernstein.
1591
1592         package-root copies built products into a staging directory using ditto(1), which does not
1593         follow symbolic links as it traverses a directory. Now that the files in
1594         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1595         itself, these become broken links when ditto'd into the staging directory.
1596
1597         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1598
1599         * Scripts/package-root:
1600
1601 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1602
1603         [ews-app] Update display text of Submit for ews analysis
1604         https://bugs.webkit.org/show_bug.cgi?id=196309
1605
1606         Reviewed by Dewei Zhu.
1607
1608         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1609
1610 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1611
1612         run-webkit-tests should check for leaks in WebKit processes
1613         <https://webkit.org/b/193772>
1614         <rdar://problem/46526680>
1615
1616         Reviewed by Ryosuke Niwa.
1617
1618         This works by doing the following:
1619         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1620           The list of child processes are returned one per line:
1621           process.name: pid
1622         - Run the "#LIST CHILD PROCESSES" command just before the
1623           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1624           processes on the ServerProcess object.
1625         - When the `--leaks` switch is handled, run check_for_leaks() on
1626           each child process after the main test harness.
1627
1628         * DumpRenderTree/mac/DumpRenderTree.mm:
1629         (handleControlCommand):
1630         - Use strncmp() instead of strcmp().
1631         - Add support for handling "#LIST CHILD PROCESSES" command.
1632
1633         * Scripts/webkitpy/port/base.py:
1634         (Port.check_for_leaks):
1635         * Scripts/webkitpy/port/darwin.py:
1636         (DarwinPort.check_for_leaks):
1637         - Rename redundant 'process_pid' argument to 'process_id'.
1638
1639         * Scripts/webkitpy/port/driver.py:
1640         (Driver.do_post_tests_work):
1641         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1642           longer the only command this sends to WebKitTestRunner.
1643         - If the `--leaks` switch is present, send the
1644           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1645           result using Port.set_webkit_processes().
1646         (Driver._parse_child_processes_output):
1647         - Add helper method to parse list of child process names and
1648           process IDs returned from WebKitTestRunner.
1649
1650         * Scripts/webkitpy/port/ios_device.py:
1651         (IOSDevicePort.check_for_leaks):
1652         - Rename redundant 'process_pid' argument to 'process_id'.
1653
1654         * Scripts/webkitpy/port/leakdetector.py:
1655         (LeakDetector._parse_leaks_output):
1656         - Return early if there is no leaks_output.
1657         (LeakDetector.check_for_leaks):
1658         - Rename redundant 'process_pid' argument to 'process_id'.
1659
1660         * Scripts/webkitpy/port/server_process.py:
1661         (ServerProcess.__init__):
1662         (ServerProcess.child_processes):
1663         (ServerProcess.set_child_processes):
1664         - Add instance variable to Port to store list of child process
1665           names and process IDs returned from WebKitTestRunner.
1666         (ServerProcess._start):
1667         - Clear self._child_processes.
1668         (ServerProcess.stop):
1669         - If self._child_processes is set, call
1670           self._port.check_for_leaks() for each child process.
1671
1672         * Scripts/webkitpy/port/server_process_unittest.py:
1673         (TrivialMockPort.check_for_leaks):
1674         - Rename redundant 'process_pid' argument to 'process_id'.
1675
1676         * Scripts/webkitpy/port/simulator_process.py:
1677         (SimulatorProcess.stop):
1678         - If self._child_processes is set, call
1679           self._port.check_for_leaks() for each child process.
1680
1681         * Scripts/webkitpy/port/watch_device.py:
1682         (WatchDevicePort.check_for_leaks):
1683         - Rename redundant 'process_pid' argument to 'process_id'.
1684
1685         * WebKitTestRunner/TestController.cpp:
1686         (WTR::TestController::dumpResponse):
1687         - Extract method from findAndDumpWorldLeaks() so that it may be
1688           reused by findAndDumpWebKitProcessIdentifiers().
1689         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1690         - Add method to output process name and process ID of both the
1691           WebContent and Networking processes.
1692         (WTR::TestController::findAndDumpWorldLeaks):
1693         - Fix missing newline in output when there were no abandoned
1694           documents.
1695         - Call dumpResponse() for extracted code.
1696         (WTR::TestController::handleControlCommand):
1697         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1698         - Use strncmp() instead of strcmp().
1699         - Call findAndDumpWebKitProcessIdentifiers() when
1700           "#LIST CHILD PROCESSES" command is sent.
1701         * WebKitTestRunner/TestController.h:
1702         (WTR::TestController::dumpResponse):
1703         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1704         - Declare methods.
1705
1706 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         Unreviewed. Add GLib API test cases after r243434.
1709
1710         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1711         (testWebViewActiveURI):
1712         (serverCallback):
1713         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1714         (sendRequestCallback):
1715
1716 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         Geolocation request not complete when watch request was started in a different web process
1719         https://bugs.webkit.org/show_bug.cgi?id=195996
1720
1721         Reviewed by Alex Christensen.
1722
1723         Add a test case.
1724
1725         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1726         (TestWebKitAPI::runJavaScriptAlert):
1727         (TestWebKitAPI::TEST):
1728
1729 2019-03-26  Keith Rollin  <krollin@apple.com>
1730
1731         Update the way generate-xcfilelists returns strings from functions
1732         https://bugs.webkit.org/show_bug.cgi?id=195975
1733         <rdar://problem/49040807>
1734
1735         Reviewed by Dean Jackson.
1736
1737         There are places where generate-xcfilelists executes assignments with
1738         statements like:
1739
1740             FOO=$(some_function)
1741
1742         where "some_function" return a string by echoing it. E.g.
1743
1744             some_function()
1745             {
1746                 echo "Hello, World"
1747             }
1748
1749         This is a common idiom, but it has a problem if "some_function" needs
1750         to call "exit" in an attempt to halt the entire script right then and
1751         there. Since "some_function" is called inside of $(), it's being
1752         executed in a sub-shell. Calling exit in that sub-shell simply exits
1753         that shell; it doesn't not exit the outer shell in which the main part
1754         of the script is still running. As such, the main script keeps
1755         executing when the intent was for the script to halt.
1756
1757         The solution to this is to use a different idiom for returning
1758         strings. The one we now is to pass in the name of the variable to
1759         receive the string result:
1760
1761             some_function()
1762             {
1763                 variable_name=$1
1764                 eval $variable_name ="Hello, World"
1765             }
1766
1767         The call site now looks like
1768
1769             some_function FOO
1770
1771         Because there's no invocation of a sub-shell, some_function can now
1772         call "exit" if it wants to, and the entire script will exit at that
1773         point.
1774
1775         * Scripts/generate-xcfilelists:
1776
1777 2019-03-26  Chris Dumez  <cdumez@apple.com>
1778
1779         Add basic layout test coverage for File Picker on iOS
1780         https://bugs.webkit.org/show_bug.cgi?id=196265
1781
1782         Reviewed by Wenson Hsieh.
1783
1784         Add layout test infrastructure to test the file picker on iOS.
1785
1786         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1787         (WTR::UIScriptController::dismissFilePicker):
1788         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1789         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1790         (WTR::UIScriptController::dismissFilePicker):
1791         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1792         * WebKitTestRunner/TestController.cpp:
1793         (WTR::TestController::createWebViewWithOptions):
1794         (WTR::updateTestOptionsFromTestHeader):
1795         * WebKitTestRunner/TestOptions.h:
1796         (WTR::TestOptions::hasSameInitializationOptions const):
1797         * WebKitTestRunner/ios/TestControllerIOS.mm:
1798         (overridePresentViewController):
1799         (WTR::TestController::platformInitialize):
1800         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1801         (WTR::UIScriptController::dismissFilePicker):
1802
1803 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1804
1805         Implement async paste method on UIWKInteractionViewProtocol
1806         https://bugs.webkit.org/show_bug.cgi?id=196267
1807         <rdar://problem/49236346>
1808
1809         Reviewed by Tim Horton.
1810
1811         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1812         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1813         are now a part of all iOS 12 internal SDKs.
1814
1815         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1816
1817         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1818         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1819
1820         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1821         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1822         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1823         * TestWebKitAPI/ios/UIKitSPI.h:
1824
1825 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1826
1827         [ews-build] Use PostgreSQL for ews.webkit.org database
1828         https://bugs.webkit.org/show_bug.cgi?id=196270
1829
1830         Reviewed by Lucas Forschler.
1831
1832         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1833
1834 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1835
1836         [ews] Reset simctl states on reboot
1837         https://bugs.webkit.org/show_bug.cgi?id=196260
1838
1839         Rubber-stamped by Aakash Jain.
1840
1841         * EWSTools/start-queue-mac.sh:
1842
1843 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1844
1845         [ews-build] Use PostgreSQL for ews-build database
1846         https://bugs.webkit.org/show_bug.cgi?id=196229
1847
1848         Reviewed by Lucas Forschler.
1849
1850         * BuildSlaveSupport/ews-build/master.cfg:
1851
1852 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-build] Get master_hostname dynamically in master.cfg
1855         https://bugs.webkit.org/show_bug.cgi?id=196255
1856
1857         Reviewed by Lucas Forschler.
1858
1859         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1860         send events data in test mode.
1861
1862 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1863
1864         [ews-app] Set db_constraint to False for Foreign Keys
1865         https://bugs.webkit.org/show_bug.cgi?id=196252
1866
1867         Reviewed by Lucas Forschler.
1868
1869         * BuildSlaveSupport/ews-app/ews/models/build.py:
1870         * BuildSlaveSupport/ews-app/ews/models/step.py:
1871
1872 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1873
1874         [ews-build] is_test_mode_enabled should default to True
1875         https://bugs.webkit.org/show_bug.cgi?id=196248
1876
1877         Reviewed by Lucas Forschler.
1878
1879         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1880
1881 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1882
1883         [ews-app] Add webkitperl to ENABLED_QUEUES
1884         https://bugs.webkit.org/show_bug.cgi?id=196253
1885
1886         Reviewed by Lucas Forschler.
1887
1888         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1889
1890 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1891
1892         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1893         https://bugs.webkit.org/show_bug.cgi?id=196211
1894         rdar://problem/49110552
1895
1896         Reviewed by Tim Horton.
1897
1898         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1899         Make sure that EventSenderProxy always exists when running tests. We used to create
1900         it when resetting before the first test, which is a bit too late.
1901
1902         * WebKitTestRunner/TestController.h:
1903         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1904         (WTR::TestController::platformCreateWebView):
1905         (WTR::TestController::platformCreateOtherPage):
1906         (WTR::TestController::finishCreatingPlatformWebView):
1907         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1908         (WTR::PlatformWebView::PlatformWebView):
1909         Moved some code that made NSWindow use NSEvent during web view creation. We may
1910         need to move more if some other case us found, but this is enough for now.
1911
1912 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1913
1914         Unreviewed. Fix typo in GLib geolocation API after r243285.
1915
1916         gelocation -> geolocation.
1917
1918         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1919         (testGeolocationManagerWatchPosition):
1920
1921 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1922
1923         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1924         https://bugs.webkit.org/show_bug.cgi?id=196213
1925
1926         Reviewed by Geoff Garen.
1927
1928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1929         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1930         (credentialWithIdentityAndKeychainPath):
1931         (-[ChallengeDelegate webView:didFinishNavigation:]):
1932         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1933         (TestWebKitAPI::TEST):
1934
1935 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1936
1937         Expected shouldn't assume its contained types are copyable
1938         https://bugs.webkit.org/show_bug.cgi?id=195986
1939
1940         Reviewed by JF Bastien.
1941
1942         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1943         (TestWebKitAPI::NonCopyable::operator== const):
1944         (TestWebKitAPI::NonCopyable::operator!= const):
1945         (TestWebKitAPI::TEST):
1946
1947 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1948
1949         Remove some now-unnecessary dynamic class lookup
1950         https://bugs.webkit.org/show_bug.cgi?id=196237
1951
1952         Reviewed by Simon Fraser.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1955         (makeRequest):
1956         (TEST):
1957
1958 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1959
1960         Unreviewed, rolling out r243450.
1961
1962         AppleWin and WinCairo port builds get broken.
1963
1964         Reverted changeset:
1965
1966         "Add test for fix of #196095"
1967         https://bugs.webkit.org/show_bug.cgi?id=196097
1968         https://trac.webkit.org/changeset/243450
1969
1970 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1971
1972         Unreviewed, rolling out r243465.
1973         https://bugs.webkit.org/show_bug.cgi?id=196226
1974
1975         the test doesn't build (Requested by thorton on #webkit).
1976
1977         Reverted changeset:
1978
1979         "Do not terminate the NetworkProcess if a third party
1980         application sends a NSCredential with a SecIdentityRef"
1981         https://bugs.webkit.org/show_bug.cgi?id=196213
1982         https://trac.webkit.org/changeset/243465
1983
1984 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1985
1986         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1987         https://bugs.webkit.org/show_bug.cgi?id=196213
1988
1989         Reviewed by Geoff Garen.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1993         (credentialWithIdentityAndKeychainPath):
1994         (-[ChallengeDelegate webView:didFinishNavigation:]):
1995         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1996         (TestWebKitAPI::TEST):
1997
1998 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-build] Gracefully handle missing patch_id in events
2001         https://bugs.webkit.org/show_bug.cgi?id=196216
2002
2003         Reviewed by Lucas Forschler.
2004
2005         * BuildSlaveSupport/ews-build/events.py:
2006
2007 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2008
2009         [ews-build] use lz4 compression for improving buildbot performance
2010         https://bugs.webkit.org/show_bug.cgi?id=196155
2011
2012         Reviewed by Lucas Forschler.
2013
2014         * BuildSlaveSupport/ews-build/master.cfg:
2015
2016 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2017
2018         Pull some API testing helper methods out of TestWKWebView
2019         https://bugs.webkit.org/show_bug.cgi?id=196212
2020
2021         Reviewed by Tim Horton.
2022
2023         Refactor some more API testing utility methods, so that they can be used in
2024         tests that do not use TestWKWebView.
2025
2026         * TestWebKitAPI/cocoa/TestWKWebView.h:
2027         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2028         (-[WKWebView loadTestPageNamed:]):
2029         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2030         (-[WKWebView synchronouslyLoadHTMLString:]):
2031         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2032         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2033         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2034         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2035         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2036
2037 2019-03-25  Jer Noble  <jer.noble@apple.com>
2038
2039         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2040         https://bugs.webkit.org/show_bug.cgi?id=196097
2041
2042         Reviewed by Eric Carlson.
2043
2044         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2045
2046         * DumpRenderTree/mac/DumpRenderTree.mm:
2047         (resetWebPreferencesToConsistentValues):
2048         * WebKitTestRunner/TestController.cpp:
2049         (WTR::TestController::resetPreferencesToConsistentValues):
2050
2051 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2052
2053         Pull IPadUserInterfaceSwizzler out into a separate header file
2054         https://bugs.webkit.org/show_bug.cgi?id=196193
2055
2056         Reviewed by Anders Carlsson.
2057
2058         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2059         be used in other API tests.
2060
2061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2062         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2063         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2064         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2065         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2066         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2067         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2068
2069 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2070
2071         Remove NavigatorContentUtils in WebCore/Modules
2072         https://bugs.webkit.org/show_bug.cgi?id=196070
2073
2074         Reviewed by Alex Christensen.
2075
2076         NavigatorContentUtils was to support the custom scheme spec [1].
2077         However, in WebKit side, no port has supported the feature in
2078         WebKit layer after EFL port was removed. So there has been the
2079         only IDL implementation of the NavigatorContentUtils in WebCore.
2080         So we don't need to keep the implementation in WebCore anymore.
2081
2082         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2083
2084         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2085
2086 2019-03-24  Andy Estes  <aestes@apple.com>
2087
2088         [watchOS] Remove unused Proximity Networking code
2089         https://bugs.webkit.org/show_bug.cgi?id=196188
2090
2091         Reviewed by Tim Horton.
2092
2093         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2094         (TEST):
2095
2096 2019-03-23  Keith Miller  <keith_miller@apple.com>
2097
2098         Refactor clz/ctz and fix getLSBSet.
2099         https://bugs.webkit.org/show_bug.cgi?id=196162
2100
2101         Reviewed by Saam Barati.
2102
2103         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2104
2105         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2106         (TestWebKitAPI::TEST):
2107
2108 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2109
2110         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2111         https://bugs.webkit.org/show_bug.cgi?id=196143
2112
2113         Reviewed by Michael Catanzaro.
2114
2115         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2116         directories.
2117
2118         * Scripts/webkitpy/style/checkers/cpp.py:
2119         (check_identifier_name_in_declaration):
2120         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2121         (WebKitStyleTest.test_names):
2122
2123 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2124
2125         [Flatpak] Manifest expanding fails for qt WPE extension
2126         https://bugs.webkit.org/show_bug.cgi?id=196148
2127
2128         Reviewed by Alex Christensen.
2129
2130         * flatpak/flatpakutils.py:
2131         (expand_submodules_recurse): The last recurse manifest expand
2132         iteration might lead to a single module so take it into account
2133         and don't try to recurse further.
2134
2135 2019-03-22  Chris Dumez  <cdumez@apple.com>
2136
2137         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2138         https://bugs.webkit.org/show_bug.cgi?id=195348
2139         <rdar://problem/48622090>
2140
2141         Reviewed by Alex Christensen.
2142
2143         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2144         to NO when test.options().shouldIgnoreMetaViewport is false.
2145
2146         * WebKitTestRunner/ios/TestControllerIOS.mm:
2147         (WTR::TestController::platformConfigureViewForTest):
2148
2149 2019-03-22  Chris Dumez  <cdumez@apple.com>
2150
2151         Prewarmed processes should be usable with any website data store
2152         https://bugs.webkit.org/show_bug.cgi?id=196104
2153
2154         Reviewed by Alex Christensen.
2155
2156         Add API test coverage.
2157
2158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2159         (runInitialWarmedProcessUsedTest):
2160         (TEST):
2161
2162 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2163
2164         Back out local changes to Alex's Subversion working directory
2165
2166         They were accidentally committed.
2167
2168         * Scripts/webkitpy/common/system/abstractexecutive.py:
2169         (AbstractExecutive.wait_newest):
2170         * Scripts/webkitpy/common/system/executive.py:
2171         (Executive.running_pids):
2172         * Scripts/webkitpy/common/system/executive_mock.py:
2173         (MockExecutive.running_pids):
2174         * Scripts/webkitpy/common/system/executive_unittest.py:
2175         (ExecutiveTest.serial_test_running_pids):
2176         * Scripts/webkitpy/port/darwin.py:
2177         (DarwinPort.check_for_leaks):
2178         * Scripts/webkitpy/port/leakdetector.py:
2179         (LeakDetector.check_for_leaks):
2180         - This was the hack attached to Bug 193772.
2181
2182         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2183         (+[WebKitTestRunnerEvent mouseLocation]):
2184         - This works around a crash on an internal build.
2185
2186 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2187
2188         Fix the build after r243354
2189         https://bugs.webkit.org/show_bug.cgi?id=196138
2190         <rdar://problem/49145951>
2191
2192         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2193         (TEST):
2194         * TestWebKitAPI/ios/UIKitSPI.h:
2195
2196 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2197
2198         Adopt UIWKDocumentContext
2199         https://bugs.webkit.org/show_bug.cgi?id=196040
2200         <rdar://problem/48642440>
2201
2202         Reviewed by Ryosuke Niwa.
2203
2204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2205         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2206         (makeRequest):
2207         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2208         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2209         (applyStyle):
2210         (TEST):
2211         Add tests for UIWKDocumentContext.
2212
2213         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2214         (TEST):
2215         (recursiveFindWKContentView): Deleted.
2216         * TestWebKitAPI/cocoa/TestWKWebView.h:
2217         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2218         (recursiveFindWKContentView):
2219         (-[TestWKWebView wkContentView]):
2220         * TestWebKitAPI/ios/UIKitSPI.h:
2221         Share the WKContentView finding code between tests.
2222
2223 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2224
2225         [iOS WK2] Turn on async overflow scrolling by default
2226         https://bugs.webkit.org/show_bug.cgi?id=196011
2227         rdar://problem/48453859
2228
2229         Reviewed by Antti Koivisto.
2230         
2231         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2232         since so many basic layout tests have different results when compositing is triggered for
2233         overflow.
2234         
2235         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2236
2237         * WebKitTestRunner/TestController.cpp:
2238         (WTR::TestController::resetPreferencesToConsistentValues):
2239
2240 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2241
2242         [ews-build] Retry API test in case of failures
2243         https://bugs.webkit.org/show_bug.cgi?id=196004
2244
2245         Reviewed by Lucas Forschler.
2246
2247         * BuildSlaveSupport/ews-build/steps.py:
2248         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2249         (CompileWebKitToT.doStepIf): Ditto.
2250         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2251         (ReRunAPITests): Re-run API tests.
2252         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2253         (RunAPITestsWithoutPatch): Run API tests without patch.
2254         (RunAPITestsWithoutPatch.doStepIf):
2255         (RunAPITestsWithoutPatch.hideStepIf):
2256         (RunAPITestsWithoutPatch.evaluateCommand):
2257         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2258         (AnalyzeAPITestsResults.start):
2259         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2260         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2261         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2262         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2263
2264 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2265
2266         [ews-build] Update queues configurations
2267         https://bugs.webkit.org/show_bug.cgi?id=196074
2268
2269         Reviewed by Dewei Zhu.
2270
2271         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2272         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2273
2274 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2275
2276         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2277         https://bugs.webkit.org/show_bug.cgi?id=195680
2278         <rdar://problem/48903534>
2279
2280         Unreviewed infrastructure fix.
2281
2282         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2283         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2284
2285 2019-03-21  Andy Estes  <aestes@apple.com>
2286
2287         [iOS] Apple Pay should be available in documents with no user agent scripts
2288         https://bugs.webkit.org/show_bug.cgi?id=196061
2289         <rdar://problem/48649391>
2290
2291         Reviewed by Brady Eidson.
2292
2293         Added API tests and related infrastructure.
2294
2295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2296         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2297         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2298         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2299         (TestWebKitAPI::TEST):
2300         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2301         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2302         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2303         * TestWebKitAPI/cocoa/TestProtocol.mm:
2304         (-[TestProtocol startLoading]):
2305         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2306         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2307         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2308         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2309
2310 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2311
2312         REGRESSSION (r243297): webkitpy tests broken
2313         https://bugs.webkit.org/show_bug.cgi?id=196108
2314
2315         Reviewed by Aakash Jain.
2316
2317         r243297 updated contributors.json, which broke a few unit tests.
2318
2319         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2320         (IRCCommandTest.test_whois):
2321         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2322
2323 2019-03-21  Chris Dumez  <cdumez@apple.com>
2324
2325         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2326         https://bugs.webkit.org/show_bug.cgi?id=196041
2327         <rdar://problem/49083230>
2328
2329         Reviewed by Alex Christensen.
2330
2331         Add API test coverage.
2332
2333         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2334         (TEST):
2335
2336 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2337
2338         Add SPI to inform applications of WKContentRuleList actions
2339         https://bugs.webkit.org/show_bug.cgi?id=195965
2340         <rdar://problem/42664365>
2341
2342         Reviewed by Geoff Garen.
2343
2344         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2345         (TestWebKitAPI::allActionsForResourceLoad):
2346         (TestWebKitAPI::testRequest):
2347         (TestWebKitAPI::TEST_F):
2348         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2349         (Notification::description):
2350         (Notification::operator== const):
2351         (toVector):
2352         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2353         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2354         (makeContentRuleList):
2355         (TEST):
2356         (makeWarnContentRuleList): Deleted.
2357
2358 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2359
2360         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2361         https://bugs.webkit.org/show_bug.cgi?id=196088
2362
2363         Reviewed by Brian Burg.
2364
2365         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2366         Support checks when only one platform is specified. Also deprecate macosx() and
2367         force the use of macos() instead.
2368
2369         * Scripts/webkitpy/style/checkers/cpp.py:
2370         (check_min_versions_of_wk_api_available):
2371         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2372         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2373
2374 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2375
2376         Update status inactive committers' status to 'contributor'.
2377
2378         * Scripts/webkitpy/common/config/contributors.json:
2379
2380 2019-03-21  Xan Lopez  <xan@igalia.com>
2381
2382         [JSC][x86] Drop support for x87 floating point
2383         https://bugs.webkit.org/show_bug.cgi?id=194853
2384
2385         Reviewed by Don Olmstead.
2386
2387         Force SSE2 on x86/32bit builds.
2388
2389         * Scripts/webkitdirs.pm:
2390         (generateBuildSystemFromCMakeProject):
2391
2392 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2393
2394         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2395         https://bugs.webkit.org/show_bug.cgi?id=196073
2396
2397         Reviewed by Michael Catanzaro.
2398
2399         Add test cases to check functions and constructors with no arguments but receiving user data.
2400
2401         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2402         (checkUserData):
2403         (testJSCFunction):
2404         (fooCreateWithUserData):
2405         (testJSCClass):
2406
2407 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2408
2409         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2410
2411         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2412
2413         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2414
2415 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2416
2417         [GTK][WPE] Add API to provide geolocation information
2418         https://bugs.webkit.org/show_bug.cgi?id=195940
2419
2420         Reviewed by Michael Catanzaro.
2421
2422         Add a new test to check the new API.
2423
2424         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2425         (testGeolocationManagerCurrentPosition):
2426         (testGeolocationManagerWatchPosition):
2427         (beforeAll):
2428         (afterAll):
2429         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2430         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2431         (beforeAll): Ditto.
2432         * TestWebKitAPI/glib/CMakeLists.txt:
2433
2434 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2435
2436         [GLib] Returning G_TYPE_OBJECT from a method does not work
2437         https://bugs.webkit.org/show_bug.cgi?id=195574
2438
2439         Reviewed by Michael Catanzaro.
2440
2441         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2442
2443         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2444         (getGFile):
2445         (getParent):
2446         (createGString):
2447         (getGString):
2448         (getGStringCopyWillRaise):
2449         (getGStringCopy):
2450         (getGStringStr):
2451         (getGStringLen):
2452         (freeGString):
2453         (testJSCClass):
2454
2455 2019-03-20  Saam Barati  <sbarati@apple.com>
2456
2457         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2458         https://bugs.webkit.org/show_bug.cgi?id=195721
2459
2460         Reviewed by Filip Pizlo.
2461
2462         * Scripts/run-javascriptcore-tests:
2463
2464 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2465
2466         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2467         https://bugs.webkit.org/show_bug.cgi?id=196049
2468
2469         Reviewed by Tim Horton.
2470
2471         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2472         overflow scrolling in general, so rename it.
2473
2474         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2475
2476 2019-03-20  Daniel Bates  <dabates@apple.com>
2477
2478         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2479         https://bugs.webkit.org/show_bug.cgi?id=196031
2480         <rdar://problem/49078172>
2481
2482         Reviewed by Tim Horton.
2483
2484         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2485         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2486         same code path used when the Done button is pressed to dismiss the <select> picker.
2487
2488         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2489         (TestWebKitAPI::TEST):
2490
2491 2019-03-20  Chris Dumez  <cdumez@apple.com>
2492
2493         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2494         https://bugs.webkit.org/show_bug.cgi?id=196029
2495         <rdar://problem/48954651>
2496
2497         Reviewed by Tim Horton.
2498
2499         Add API test coverage.
2500
2501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2502
2503 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2504
2505         [ews-build] Improve failure summary string for ApplyPatch step
2506         https://bugs.webkit.org/show_bug.cgi?id=195995
2507
2508         Reviewed by Alexey Proskuryakov.
2509
2510         * BuildSlaveSupport/ews-build/steps.py:
2511         (ApplyPatch.getResultSummary): Override getResultSummary.
2512
2513 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2514
2515         AX: Implement support for new meter ARIA role
2516         https://bugs.webkit.org/show_bug.cgi?id=195966
2517
2518         Reviewed by Chris Fleizach.
2519
2520         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2521         to AXLevelIndicator.
2522
2523         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2524
2525 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2526
2527         [WebAuthN] Implement FIDO AppID extension
2528         https://bugs.webkit.org/show_bug.cgi?id=143491
2529         <rdar://problem/48298273>
2530
2531         Reviewed by Brent Fulgham.
2532
2533         Add a test that covers the new flag of convertToU2fSignCommand.
2534
2535         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2536         (TestWebKitAPI::TEST):
2537         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2538         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2539         (TestWebKitAPI::TEST):
2540
2541 2019-03-19  Keith Rollin  <krollin@apple.com>
2542
2543         Add support for more platforms to generate-xcfilelists
2544         https://bugs.webkit.org/show_bug.cgi?id=195977
2545
2546         Reviewed by Alexey Proskuryakov.
2547
2548         generate-xcfilelists incorrectly complains when involved with building
2549         WebKit for iphonesimulator:
2550
2551             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2552             …
2553             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2554
2555         Address this by teaching generate-xcfilelists about more platforms.
2556
2557         * Scripts/generate-xcfilelists:
2558
2559 2019-03-19  John Wilander  <wilander@apple.com>
2560
2561         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2562         https://bugs.webkit.org/show_bug.cgi?id=195923
2563         <rdar://problem/49001272>
2564
2565         Reviewed by Alex Christensen.
2566
2567         This patch does the following to the TestRunner:
2568         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2569         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2570         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2571
2572         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2573         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2574         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2575         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2576         * WebKitTestRunner/TestController.cpp:
2577         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2578         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2579         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2580         * WebKitTestRunner/TestController.h:
2581         * WebKitTestRunner/TestInvocation.cpp:
2582         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2583
2584 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2585
2586         [CMake] Support more clang and gcc sanitizers
2587         https://bugs.webkit.org/show_bug.cgi?id=195956
2588
2589         Reviewed by Michael Catanzaro.
2590
2591         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2592
2593 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2594
2595         [ews-build] Improve summary for PrintConfiguration step
2596         https://bugs.webkit.org/show_bug.cgi?id=195945
2597
2598         Reviewed by Lucas Forschler.
2599
2600         * BuildSlaveSupport/ews-build/steps.py:
2601         (PrintConfiguration.getResultSummary): Override getResultSummary.
2602
2603 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2604
2605         [ews-build] Improve summary for CheckOutSource step
2606         https://bugs.webkit.org/show_bug.cgi?id=195963
2607
2608         Reviewed by Lucas Forschler.
2609
2610         * BuildSlaveSupport/ews-build/steps.py:
2611         (CheckOutSource.getResultSummary):
2612
2613 2019-03-19  Daniel Bates  <dabates@apple.com>
2614
2615         [iOS] Focus not preserved when switching between tabs
2616         https://bugs.webkit.org/show_bug.cgi?id=195820
2617         <rdar://problem/43614450>
2618
2619         Reviewed by Brent Fulgham.
2620
2621         Add tests to ensure that we restore focus when resigning and becoming first responder.
2622
2623         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2624         (TestWebKitAPI::TEST):
2625
2626 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2627
2628         Make WTFLogChannelState and WTFLogLevel enum classes
2629         https://bugs.webkit.org/show_bug.cgi?id=195904
2630
2631         Reviewed by Eric Carlson.
2632
2633         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2634         (TestWebKitAPI::TEST_F):
2635
2636 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2637
2638         [GStreamer][EME] Backported mssdemux protection data crash fix
2639         https://bugs.webkit.org/show_bug.cgi?id=195918
2640
2641         Reviewed by Philippe Normand.
2642
2643         * gstreamer/jhbuild.modules:
2644         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2645
2646 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2647
2648         Unreviewed, rolling out r243132.
2649
2650         Broke GTK build
2651
2652         Reverted changeset:
2653
2654         "Make WTFLogChannelState and WTFLogLevel enum classes"
2655         https://bugs.webkit.org/show_bug.cgi?id=195904
2656         https://trac.webkit.org/changeset/243132
2657
2658 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2659
2660         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2661
2662         * Scripts/webkitdirs.pm:
2663         (builtDylibPathForName): Adjust the shared library name that's changed
2664         with the API version bump in r243073.
2665
2666 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2667
2668         Make WTFLogChannelState and WTFLogLevel enum classes
2669         https://bugs.webkit.org/show_bug.cgi?id=195904
2670
2671         Reviewed by Eric Carlson.
2672
2673         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2674         (TestWebKitAPI::TEST_F):
2675
2676 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2677
2678         Disable flaky test added in r2431100
2679         https://webkit.org/b/195785
2680
2681         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2682         (TestWebKitAPI::TEST):
2683         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2684
2685 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2686
2687         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2688         https://bugs.webkit.org/show_bug.cgi?id=195916
2689
2690         Reviewed by Tim Horton.
2691
2692         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2693         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2694
2695 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2696
2697         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2698
2699         * Scripts/webkitpy/common/config/contributors.json:
2700
2701 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2702
2703         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2704         https://bugs.webkit.org/show_bug.cgi?id=195785
2705
2706         Reviewed by Geoffrey Garen.
2707
2708         * TestWebKitAPI/TCPServer.cpp: Added.
2709         (TestWebKitAPI::TCPServer::TCPServer):
2710         (TestWebKitAPI::TCPServer::~TCPServer):
2711         (TestWebKitAPI::TCPServer::socketBindListen):
2712         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2713         * TestWebKitAPI/TCPServer.h: Added.
2714         (TestWebKitAPI::TCPServer::port const):
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2716         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2717         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2718         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2719         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2720         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2721         (TestWebKitAPI::respondSlowly):
2722         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2723         (TestWebKitAPI::downloadAtRate):
2724         (TestWebKitAPI::TEST):
2725
2726 2019-03-18  Saam Barati  <sbarati@apple.com>
2727
2728         Add a plan file for JetStream 2
2729         https://bugs.webkit.org/show_bug.cgi?id=190734
2730
2731         Reviewed by Mark Lam.
2732
2733         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2734
2735 2019-03-18  Chris Dumez  <cdumez@apple.com>
2736
2737         Delay WebProcess launch until a load is triggered in a Web view
2738         https://bugs.webkit.org/show_bug.cgi?id=195758
2739         <rdar://problem/48126013>
2740
2741         Reviewed by Geoff Garen.
2742
2743         Add API test coverage. Also update some existing API tests to not expect
2744         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2745
2746         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2747         (TestWebKitAPI::TEST):
2748         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2749         (TestWebKitAPI::TEST):
2750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2751         (TEST):
2752         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2753         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2754         (TEST):
2755         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2756         (TEST):
2757         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2758
2759 2019-03-18  Xan Lopez  <xan@igalia.com>
2760
2761         [CMake] Prevent potential warning when determining $architecture
2762         https://bugs.webkit.org/show_bug.cgi?id=195891
2763
2764         Reviewed by Michael Catanzaro.
2765
2766         It's possible for generateBuildSystemForCMakeProject to be called
2767         before determineArchitecture() is ever called. This will make the
2768         first eq check with $architecture to be bogus (and print a
2769         warning). Change that to an eq check with architecture(), which
2770         implicitly calls determineArchitecture() if needed, and change all
2771         the other similar cases in the method in the same way to prevent
2772         future bugs like this one.
2773
2774         * Scripts/webkitdirs.pm:
2775         (generateBuildSystemFromCMakeProject):
2776
2777 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2778
2779         [WPE] Tarballs generated with “make dist” cannot build documentation
2780         https://bugs.webkit.org/show_bug.cgi?id=195885
2781
2782         Reviewed by Carlos Garcia Campos.
2783
2784         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2785
2786 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2787
2788         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2789         https://bugs.webkit.org/show_bug.cgi?id=195883
2790
2791         Reviewed by Carlos Garcia Campos.
2792
2793         * gtkdoc/gtkdoc.py:
2794         (GTKDoc._run_command): When commands fail to run, include the full command line for
2795         the program invocation and the output it has generated on the standard error stream.
2796
2797 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2798
2799         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2800         https://bugs.webkit.org/show_bug.cgi?id=195786
2801
2802         Reviewed by Philippe Normand.
2803
2804         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2805         * wpe/jhbuild.modules: Ditto.
2806
2807 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2808
2809         [ews-build] Don't run clean builds on EWS builders
2810         https://bugs.webkit.org/show_bug.cgi?id=195851
2811
2812         Reviewed by Geoffrey Garen.
2813
2814         * BuildSlaveSupport/ews-build/factories.py:
2815
2816 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2817
2818         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2819         https://bugs.webkit.org/show_bug.cgi?id=195849
2820
2821         Reviewed by Chris Dumez.
2822
2823         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2824
2825         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2826         (runWebsiteDataStoreCustomPaths):
2827
2828 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2829
2830         webkitpy: Upload test results
2831         https://bugs.webkit.org/show_bug.cgi?id=195755
2832         <rdar://problem/48896182>
2833
2834         Reviewed by Aakash Jain.
2835
2836         Establish a new format for uploading results that is not tied to layout tests, apply
2837         that format to webkitpy tests.
2838
2839         * Scripts/webkitpy/common/checkout/scm/git.py:
2840         (Git.native_branch): Return what branch the current checkout is on.
2841         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2842         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2843         * Scripts/webkitpy/common/checkout/scm/svn.py:
2844         (SVN.native_branch): Ditto.
2845         * Scripts/webkitpy/common/system/platforminfo.py:
2846         (PlatformInfo.build_version): Return a build version for Mac.
2847         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2848         (MockPlatformInfo.__init__):
2849         (MockPlatformInfo.build_version):
2850         * Scripts/webkitpy/results: Added.
2851         * Scripts/webkitpy/results/__init__.py: Added.
2852         * Scripts/webkitpy/results/options.py: Added.
2853         (upload_options): OptParse list for upload options.
2854         * Scripts/webkitpy/results/upload.py: Added.
2855         (Upload): Class which enforces the upload format expected by the results server.
2856         (Upload.Expectations):
2857         (Upload.create_configuration):
2858         (Upload.create_commit):
2859         (Upload.create_details):
2860         (Upload.create_run_stats):
2861         (Upload.create_test_result):
2862         (Upload.__init__):
2863         (Upload.Encoder): Encode Upload object as json.
2864         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2865         * Scripts/webkitpy/results/upload_unittest.py: Added.
2866         * Scripts/webkitpy/test/main.py:
2867         (Tester._parse_args): Add upload arguments.
2868         (Tester._run_tests): Allow results to be uploaded.
2869         * Scripts/webkitpy/test/runner.py:
2870         (Runner.__init__): Record which tests were run, rather than just counting them.
2871         (Runner.handle):
2872         * Scripts/webkitpy/test/runner_unittest.py:
2873         (RunnerTest.test_run):
2874         * Scripts/webkitpy/thirdparty/__init__.py:
2875         (AutoinstallImportHook.find_module): Add requests auto-install.
2876         (AutoinstallImportHook._install_requests):
2877         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2878         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2879
2880 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2881
2882         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2883         https://bugs.webkit.org/show_bug.cgi?id=195810
2884
2885         Reviewed by Tim Horton.
2886
2887         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2888         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2889         ending certain layout tests.
2890
2891         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2892         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2893         (-[TestRunnerWKWebView dealloc]):
2894         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2895
2896         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2897         helper method when destroying the web view, and when resetting state between tests.
2898
2899         * WebKitTestRunner/ios/TestControllerIOS.mm:
2900         (WTR::TestController::platformResetStateToConsistentValues):
2901
2902         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2903
2904 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2905
2906         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2907         https://bugs.webkit.org/show_bug.cgi?id=190350
2908         <rdar://problem/45089503>
2909
2910         Reviewed by Geoffrey Garen.
2911
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2913         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2914         (TEST):
2915         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2916         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2917         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2918         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2919         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2920         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2921         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2922         (runTest):
2923         (createDirectories):
2924         (TEST):
2925         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2926         (TEST):
2927         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2928         (TEST):
2929
2930 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2931
2932         Add support to WebPage for getting the contents as an attributed string.
2933         https://bugs.webkit.org/show_bug.cgi?id=195636
2934         rdar://problem/45055697
2935
2936         Reviewed by Tim Horton.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2939         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2940
2941 2019-03-15  Chris Dumez  <cdumez@apple.com>
2942
2943         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2944         https://bugs.webkit.org/show_bug.cgi?id=195747
2945
2946         Reviewed by Geoff Garen.
2947
2948         Add API test coverage.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2951
2952 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2953
2954         Unreviewed, rolling out r242952.
2955
2956         Causing API failures on iOS Simulator
2957
2958         Reverted changeset:
2959
2960         "[PSON] Make sure the WebProcessCache is leverage when
2961         relaunching a process after termination"
2962         https://bugs.webkit.org/show_bug.cgi?id=195747
2963         https://trac.webkit.org/changeset/242952
2964
2965 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2966
2967         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2968         https://bugs.webkit.org/show_bug.cgi?id=195740
2969
2970         Reviewed by Ross Kirsling.
2971
2972         window.open doesn't work for WebKitBrowserWindow because it is not
2973         implemented yet.
2974
2975         1. Implemented createNewPage callback of WKPageUIClient.
2976         2. Changed MainWindow to take a BrowserWindow factory function
2977           instead of BrowserWindowType to be flexible to create
2978           BrowserWindow with extra settings.
2979         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2980           because it is not relevant with MainWindow anymore.
2981
2982         * MiniBrowser/win/Common.cpp:
2983         (parseCommandLine):
2984         * MiniBrowser/win/Common.h:
2985         (CommandLineOptions::CommandLineOptions):
2986         * MiniBrowser/win/MainWindow.cpp:
2987         (MainWindow::MainWindow):
2988         (MainWindow::create):
2989         (MainWindow::init):
2990         (MainWindow::WndProc):
2991         * MiniBrowser/win/MainWindow.h:
2992         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2993         (PrintWebUIDelegate::createWebViewWithRequest):
2994         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2995         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2996         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2997         (WebKitBrowserWindow::updateProxySettings):
2998         (WebKitBrowserWindow::createNewPage):
2999         * MiniBrowser/win/WebKitBrowserWindow.h:
3000         * MiniBrowser/win/WinMain.cpp:
3001         (wWinMain):
3002
3003 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3004
3005         Make it possible to test scrolling tree layer manipulation more easily
3006         https://bugs.webkit.org/show_bug.cgi?id=195780
3007
3008         Reviewed by Tim Horton.
3009         
3010         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3011         cuts off communication of scrolling tree scrolls back to the web process
3012         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3013         allows tests to trigger scrolls which run the scrolling tree layer positioning
3014         logic, but never get another commit from the web process that might mask
3015         scrolling tree bugs.
3016         
3017         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3018         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3019         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3020
3021         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3022         (WTR::UIScriptController::scrollUpdatesDisabled const):
3023         (WTR::UIScriptController::setScrollUpdatesDisabled):
3024         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3025         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3026         (WTR::UIScriptController::scrollUpdatesDisabled const):
3027         (WTR::UIScriptController::setScrollUpdatesDisabled):
3028         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3029         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3030         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3031         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3032         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3033         * WebKitTestRunner/ios/TestControllerIOS.mm:
3034         (WTR::TestController::platformResetStateToConsistentValues):
3035         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3036         (WTR::UIScriptController::scrollUpdatesDisabled const):
3037         (WTR::UIScriptController::setScrollUpdatesDisabled):
3038
3039 2019-03-14  Youenn Fablet  <youenn@apple.com>
3040
3041         Move IDB storage in private browsing mode to NetworkProcess
3042         https://bugs.webkit.org/show_bug.cgi?id=195602
3043
3044         Reviewed by Brady Eidson.
3045
3046         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3047         (TEST):
3048
3049 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-build] Make descriptionDone messages more readable
3052         https://bugs.webkit.org/show_bug.cgi?id=195760
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-build/steps.py:
3057         * BuildSlaveSupport/ews-build/steps_unittest.py:
3058
3059 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3060
3061         [ews-build] Generate status-bubble hover-over messages
3062         https://bugs.webkit.org/show_bug.cgi?id=195680
3063
3064         Reviewed by Lucas Forschler.
3065
3066         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3067         (StatusBubble):
3068         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3069         on hover-over.
3070         (StatusBubble._iso_time):
3071         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3072         hover-over message.
3073         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3074
3075 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3076
3077         [ews-app] Gracefully handle the case when state_string is None
3078         https://bugs.webkit.org/show_bug.cgi?id=195753
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * BuildSlaveSupport/ews-app/ews/models/build.py:
3083         * BuildSlaveSupport/ews-app/ews/models/step.py:
3084
3085 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3086
3087         [ews-app] Status bubble display pending for currently running build step
3088         https://bugs.webkit.org/show_bug.cgi?id=195744
3089
3090         Reviewed by Lucas Forschler.
3091
3092         * BuildSlaveSupport/ews-build/events.py:
3093         (Events.stepStarted): If state_string is pending, replace it with step name.
3094
3095 2019-03-14  Chris Dumez  <cdumez@apple.com>
3096
3097         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3098         https://bugs.webkit.org/show_bug.cgi?id=195750
3099
3100         Reviewed by Geoffrey Garen.
3101
3102         Add API test coverage.
3103
3104         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3105         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3106         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3107         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3108
3109 2019-03-14  Chris Dumez  <cdumez@apple.com>
3110
3111         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3112         https://bugs.webkit.org/show_bug.cgi?id=195747
3113
3114         Reviewed by Geoff Garen.
3115
3116         Add API test coverage.
3117
3118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3119
3120 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3121
3122         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3123         https://bugs.webkit.org/show_bug.cgi?id=195725
3124         <rdar://problem/48545062>
3125
3126         Reviewed by Tim Horton.
3127
3128         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3129         handler is nil.
3130
3131         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3132         (TestWebKitAPI::TEST):
3133
3134 2019-03-13  Sam Weinig  <sam@webkit.org>
3135
3136         Add utility function to allow easy reverse range-based iteration of a container
3137         https://bugs.webkit.org/show_bug.cgi?id=195542
3138
3139         Reviewed by Antti Koivisto.
3140
3141         * TestWebKitAPI/CMakeLists.txt:
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3144         (TestWebKitAPI::TEST):
3145         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3146
3147 2019-03-13  Chris Dumez  <cdumez@apple.com>
3148
3149         Use a ServiceWorker process per registrable domain
3150         https://bugs.webkit.org/show_bug.cgi?id=195649
3151
3152         Reviewed by Youenn Fablet.
3153
3154         Update API test coverage.
3155
3156         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3157
3158 2019-03-13  Chris Dumez  <cdumez@apple.com>
3159
3160         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3161         https://bugs.webkit.org/show_bug.cgi?id=195684
3162         <rdar://problem/48294714>
3163
3164         Reviewed by Antti Koivisto.
3165
3166         Add API test coverage.
3167
3168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3169
3170 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3171
3172         [ews-app] Remove unused patch view
3173         https://bugs.webkit.org/show_bug.cgi?id=195669
3174
3175         Reviewed by Lucas Forschler.
3176
3177         * BuildSlaveSupport/ews-app/ews/urls.py:
3178         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3179
3180 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3181
3182         [ews-app] Use Buildbot result code variables
3183         https://bugs.webkit.org/show_bug.cgi?id=195668
3184
3185         Reviewed by Alexey Proskuryakov.
3186
3187         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3188         (Buildbot): Added Buildbot result code variables.
3189         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3190         (StatusBubble._build_bubble): Used Buildbot result code variables.
3191
3192 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3193
3194         [Flatpak] Expand submodule recursively
3195         https://bugs.webkit.org/show_bug.cgi?id=195672
3196
3197         Building WPE with flatpak was impossible without that as it was raising an exception.
3198         Also update wpebackend-fdo to match what is built in jhbuild
3199
3200         Reviewed by Philippe Normand.
3201
3202         * flatpak/flatpakutils.py:
3203         (expand_submodules_recurse):
3204         (expand_manifest):
3205         * flatpak/org.webkit.WPEModules.yaml:
3206
3207 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3208
3209         [ews-app] status bubble should be hidden for certain builds
3210         https://bugs.webkit.org/show_bug.cgi?id=194597
3211
3212         Reviewed by Dewei Zhu.
3213
3214         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3215         (StatusBubble._build_bubble):
3216         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3217         because the patch didn't have relevant changes.
3218         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3219         in production yet.
3220
3221 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3222
3223         [Win] Fix a slew of simple clang-cl warnings.
3224         https://bugs.webkit.org/show_bug.cgi?id=195652
3225
3226         Reviewed by Don Olmstead.
3227
3228         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3229         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3230
3231 2019-03-12  Justin Fan  <justin_fan@apple.com>
3232
3233         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3234         https://bugs.webkit.org/show_bug.cgi?id=195518
3235         <rdar://problem/46322356>
3236
3237         Reviewed by Myles C. Maxfield.
3238
3239         * DumpRenderTree/DerivedSources-input.xcfilelist:
3240         * DumpRenderTree/DerivedSources-output.xcfilelist:
3241
3242 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3243
3244         Unreviewed, rolling out r242825.
3245         https://bugs.webkit.org/show_bug.cgi?id=195648
3246
3247         "Broke webkitpy tests with my change to
3248         lldb_dump_class_layout.py" (Requested by rmorisset on
3249         #webkit).
3250
3251         Reverted changeset:
3252
3253         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3254         classes with suspicious padding"
3255         https://bugs.webkit.org/show_bug.cgi?id=195573
3256         https://trac.webkit.org/changeset/242825
3257
3258 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3259
3260         [ews-build] Show status bubbles while the patch is waiting in queue
3261         https://bugs.webkit.org/show_bug.cgi?id=195618
3262
3263         Reviewed by Lucas Forschler.
3264
3265         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3266         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3267         enabled in initial deployment.
3268         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3269         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3270         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3271         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3272         (StatusBubble._build_bubbles_for_patch):
3273
3274 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3275
3276         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3277         https://bugs.webkit.org/show_bug.cgi?id=195573
3278
3279         Reviewed by Simon Fraser.
3280
3281         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3282
3283         * Scripts/dump-class-layout:
3284         (main):
3285         * lldb/lldb_dump_class_layout.py:
3286         (ClassLayout.__init__):
3287         (ClassLayout._compute_padding_recursive):
3288         (LLDBDebuggerInstance.dump_layout_for_classname):
3289         (LLDBDebuggerInstance):
3290         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3291         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3292
3293 2019-03-12  Chris Dumez  <cdumez@apple.com>
3294
3295         Device Orientation access permission should be denied unless explicitly granted by the client
3296         https://bugs.webkit.org/show_bug.cgi?id=195625
3297
3298         Reviewed by Youenn Fablet.
3299
3300         add API test coverage.
3301
3302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3303         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3304         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3305         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3306         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3307         (runDeviceOrientationTest):
3308         (TEST):
3309         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3310         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3311
3312 2019-03-12  Jer Noble  <jer.noble@apple.com>
3313
3314         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3315         https://bugs.webkit.org/show_bug.cgi?id=195137
3316         <rdar://problem/48810307>
3317
3318         Reviewed by Eric Carlson.
3319
3320         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3321         (TestWebKitAPI::TEST):
3322
3323 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3324
3325         [ews-build] Change urls from uat to production
3326         https://bugs.webkit.org/show_bug.cgi?id=195566
3327
3328         Reviewed by Lucas Forschler.
3329
3330         * BuildSlaveSupport/ews-app/ews/config.py:
3331         * BuildSlaveSupport/ews-build/events.py:
3332         * BuildSlaveSupport/ews-build/steps.py:
3333
3334 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3335
3336         [ews-build] change max_builds for local-worker to 1
3337         https://bugs.webkit.org/show_bug.cgi?id=195568
3338
3339         Reviewed by Lucas Forschler.
3340
3341         * BuildSlaveSupport/ews-build/loadConfig.py:
3342
3343 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3344
3345         Fix the build
3346
3347         * TestRunnerShared/spi/PencilKitTestSPI.h:
3348         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3349
3350 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3351
3352         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3353         https://bugs.webkit.org/show_bug.cgi?id=194131
3354
3355         Reviewed by Michael Catanzaro.
3356
3357         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3358         (uriChanged):
3359         (testUnfinishedSubresourceLoad):
3360         (serverCallback):
3361         (beforeAll):
3362
3363 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3364
3365         WTF::Expected should use std::addressof instead of operator&
3366         https://bugs.webkit.org/show_bug.cgi?id=195604
3367
3368         Reviewed by Myles Maxfield.
3369
3370         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3371         (TestWebKitAPI::Unique::Unique):
3372         (TestWebKitAPI::Unique::operator&):
3373         (TestWebKitAPI::TEST):
3374
3375 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3376
3377         Add Optional to Forward.h.
3378         https://bugs.webkit.org/show_bug.cgi?id=195586
3379
3380         Reviewed by Darin Adler.
3381
3382         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3383         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3384         Remove unnecessary includes from headers.
3385
3386 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3387
3388         Add testing API to hit-test and scroll overflow scrollers
3389         https://bugs.webkit.org/show_bug.cgi?id=195278
3390
3391         Reviewed by Antti Koivisto.
3392         
3393         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3394         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3395         
3396         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3397
3398         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3399         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3400         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3401         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3402         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3403         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3404         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3405         (WTR::enclosingScrollViewIncludingSelf):
3406         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3407
3408 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3409
3410         API test WebKit.RequestTextInputContext fails on iOS
3411         https://bugs.webkit.org/show_bug.cgi?id=195585
3412
3413         Reviewed by Wenson Hsieh and Simon Fraser.
3414
3415         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3416         (applyStyle):
3417         (TEST):
3418         Add a viewport, so that the coordinates match up on iOS.
3419         Scroll by moving the UIScrollView's contentOffset.
3420
3421 2019-03-11  Chris Dumez  <cdumez@apple.com>
3422
3423         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3424         https://bugs.webkit.org/show_bug.cgi?id=195506
3425         <rdar://problem/48733477>
3426
3427         Reviewed by Alex Christensen.
3428
3429         Add API test coverage.
3430
3431         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3432
3433 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3434
3435         Adding myself to contributors.json
3436
3437         Unreviewed, addming myself to contributors.json .
3438
3439         * Scripts/webkitpy/common/config/contributors.json:
3440
3441 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3442
3443         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3444         https://bugs.webkit.org/show_bug.cgi?id=195511
3445         <rdar://problem/44873269>
3446
3447         Reviewed by Darin Adler.
3448
3449         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3450         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3451         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3452         (TEST_F):
3453
3454 2019-03-11  Chris Dumez  <cdumez@apple.com>
3455
3456         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3457         https://bugs.webkit.org/show_bug.cgi?id=195561
3458
3459         Reviewed by Youenn Fablet.
3460
3461         Make sure the JS in the test requests for permission to receive device orientation events.
3462
3463         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3464
3465 2019-03-11  Youenn Fablet  <youenn@apple.com>
3466
3467         Allow storage quota increase by default in WTR
3468         https://bugs.webkit.org/show_bug.cgi?id=195541
3469
3470         Reviewed by Geoffrey Garen.
3471
3472         Allow storage quota increase by default in WTR.
3473         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3474         Use this for tests that explicitly need cache increase.
3475
3476         Instead of increasing quota by 2, make sure the next request is
3477         granted by adding all given parameters.
3478
3479         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3480         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3481         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3482         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3483         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3484         * WebKitTestRunner/TestController.cpp:
3485         (WTR::TestController::setAllowStorageQuotaIncrease):
3486         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3487         * WebKitTestRunner/TestController.h:
3488         * WebKitTestRunner/TestInvocation.cpp:
3489         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3490         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3491         (WTR::TestController::cocoaResetStateToConsistentValues):
3492         (WTR::TestController::setAllowStorageQuotaIncrease):
3493         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3494         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3495         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3496
3497 2019-03-11  Xan Lopez  <xan@igalia.com>
3498
3499         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3500         https://bugs.webkit.org/show_bug.cgi?id=194147
3501
3502         Reviewed by Michael Saboff.
3503
3504         To make --32-bit work correctly on Linux/64bit we need to:
3505
3506         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3507         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3508         unfortunately CMake only allows us to do this during
3509         crosscompilation, which is overkill here.
3510         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3511         pkg-config detection module uses the x86 .pc files instead of the
3512         x86_64 ones.
3513         - Set the -m32 flags for the compiler.
3514
3515         * Scripts/webkitdirs.pm:
3516         (generateBuildSystemFromCMakeProject):
3517
3518 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3519
3520         Add MotionMark-1.1 plan file for run-benchmark script.
3521         https://bugs.webkit.org/show_bug.cgi?id=195481
3522
3523         Rubber-stamped by Darin Adler.
3524
3525         Run-benchmark script should support MontionMark-1.1.
3526
3527         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3528
3529 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3530
3531         [ews-app] Add support for submit-to-ews url
3532         https://bugs.webkit.org/show_bug.cgi?id=195477
3533
3534         Reviewed by Lucas Forschler.
3535
3536         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3537         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3538         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3539         * BuildSlaveSupport/ews-app/ews/urls.py:
3540         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3541
3542 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3543
3544         Unreviewed, rolling out r242688, r242643, r242624.
3545
3546         Caused multiple layout test failures and crashes on iOS and macOS.
3547
3548         Reverted changeset:
3549
3550         "requestAnimationFrame should execute before the next frame"
3551         https://bugs.webkit.org/show_bug.cgi?id=177484
3552         https://trac.webkit.org/changeset/242624/webkit
3553
3554         * Tracing/SystemTracePoints.plist:
3555
3556 2019-03-11  John Wilander  <wilander@apple.com>
3557
3558         Resource Load Statistics: Make it possible exclude localhost from classification
3559         https://bugs.webkit.org/show_bug.cgi?id=195474
3560         <rdar://problem/47520577>
3561
3562         Reviewed by Brent Fulgham.
3563
3564         This patch allows for localhost to be excluded from classification and
3565         treatment as a prevalent resource.
3566
3567         The WebKit Tools change adds a new function called
3568         testRunner.setStatisticsIsRunningTest() which can be used to control this
3569         behavior.
3570
3571         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3572         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3573         (WTR::TestRunner::setStatisticsIsRunningTest):
3574         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3575         * WebKitTestRunner/TestController.cpp:
3576         (WTR::TestController::setStatisticsIsRunningTest):
3577         * WebKitTestRunner/TestController.h:
3578         * WebKitTestRunner/TestInvocation.cpp:
3579         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3580
3581 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3582
3583         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3584         https://bugs.webkit.org/show_bug.cgi?id=195560
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * BuildSlaveSupport/ews-build/master.cfg:
3589
3590 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3591
3592         Unreviewed, rolling out r242698.
3593
3594         API test crashes on bots.
3595
3596         Reverted changeset:
3597
3598         "Add a WKContentRuleList variant that uses copied memory
3599         instead of mmap'd shared memory for class A containerized
3600         apps"
3601         https://bugs.webkit.org/show_bug.cgi?id=195511
3602         https://trac.webkit.org/changeset/242698
3603
3604 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3605
3606         [WPE] Enable web process sandbox
3607         https://bugs.webkit.org/show_bug.cgi?id=195169
3608
3609         Reviewed by Daniel Bates.
3610
3611         * wpe/install-dependencies:
3612         * wpe/jhbuild.modules:
3613
3614 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3615
3616         [ews-app] Use port 17000 for worker communication
3617         https://bugs.webkit.org/show_bug.cgi?id=195558
3618
3619         Reviewed by Lucas Forschler.
3620
3621         * BuildSlaveSupport/ews-build/master.cfg:
3622
3623 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3624
3625         [ews-build] unit-tests fail when passwords.json is missing
3626         https://bugs.webkit.org/show_bug.cgi?id=195557
3627
3628         Reviewed by Lucas Forschler.
3629
3630         * BuildSlaveSupport/ews-build/loadConfig.py:
3631         (loadBuilderConfig):
3632         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3633         (ConfigDotJSONTest.test_configuration):
3634         * BuildSlaveSupport/ews-build/master.cfg:
3635
3636 2019-03-11  Truitt Savell  <tsavell@apple.com>
3637
3638         Unreviewed, rolling out r242702.
3639
3640         Broke High Sierra builders.
3641
3642         Reverted changeset:
3643
3644         "Add utility function to allow easy reverse range-based
3645         iteration of a container"
3646         https://bugs.webkit.org/show_bug.cgi?id=195542
3647         https://trac.webkit.org/changeset/242702
3648
3649 2019-03-11  Sam Weinig  <sam@webkit.org>
3650
3651         Add utility function to allow easy reverse range-based iteration of a container
3652         https://bugs.webkit.org/show_bug.cgi?id=195542
3653
3654         Reviewed by Antti Koivisto.
3655
3656         * TestWebKitAPI/CMakeLists.txt:
3657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3658         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3659         (TestWebKitAPI::TEST):
3660         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3661
3662 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3663
3664         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3665         https://bugs.webkit.org/show_bug.cgi?id=195511
3666         <rdar://problem/44873269>
3667
3668         Reviewed by Darin Adler.
3669
3670         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3671         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3672         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3673         (TEST_F):
3674
3675 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3676
3677         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3678         https://bugs.webkit.org/show_bug.cgi?id=195499
3679
3680         Reviewed by Darin Adler.
3681
3682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3683         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3684         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3685         (-[WKWebView synchronouslyFocusTextInputContext:]):
3686         (applyStyle):
3687         (applyIframe):
3688         (TEST):
3689         Add some tests for this SPI.
3690
3691 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3692
3693         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3694         https://bugs.webkit.org/show_bug.cgi?id=181151
3695
3696         Reviewed by Don Olmstead.
3697
3698         * TestWebKitAPI/CMakeLists.txt:
3699         * TestWebKitAPI/PlatformWin.cmake:
3700         Enable TestWTF RunLoop tests in all platforms.