b4660f03c09d9b6d411024a925597ff8fb96fd70
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2
3         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4         https://bugs.webkit.org/show_bug.cgi?id=194998
5
6         Reviewed by Carlos Garcia Campos.
7
8         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
9         to a Git checkout and using the latest commit containing various fixes
10         and improvements.
11
12 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
13
14         [WPE][GTK] Remove user agent quirk for washingtonpost.com
15         https://bugs.webkit.org/show_bug.cgi?id=194981
16
17         Reviewed by Žan Doberšek.
18
19         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
20         (TestWebKitAPI::TEST):
21
22 2019-02-23  Keith Miller  <keith_miller@apple.com>
23
24         Add new mac target numbers
25         https://bugs.webkit.org/show_bug.cgi?id=194955
26
27         Reviewed by Tim Horton.
28
29         * DumpRenderTree/mac/Configurations/Base.xcconfig:
30         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
31         * MiniBrowser/Configurations/Base.xcconfig:
32         * TestWebKitAPI/Configurations/Base.xcconfig:
33         * WebKitTestRunner/Configurations/Base.xcconfig:
34
35 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
36
37         [WinCairo] Enable wk1/wk2 suffix for platform search path.
38         https://bugs.webkit.org/show_bug.cgi?id=194846
39
40         Reviewed by Don Olmstead.
41
42         Added _search_paths() and _port_specific_expectations_files() for
43         WinCairoPort.
44
45         * Scripts/webkitpy/port/win.py:
46         (WinCairoPort.default_baseline_search_path):
47         (WinCairoPort):
48         (WinCairoPort._port_specific_expectations_files):
49         (WinCairoPort._search_paths):
50
51 2019-02-22  Tim Horton  <timothy_horton@apple.com>
52
53         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
54         https://bugs.webkit.org/show_bug.cgi?id=194963
55
56         Reviewed by Dean Jackson.
57
58         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
59         Do a `contains` check instead of `equals`, because in debug builds we
60         put the GraphicsLayer pointer in a prefix.
61
62 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
63
64         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
65         https://bugs.webkit.org/show_bug.cgi?id=194873
66         <rdar://problem/46701974>
67
68         Reviewed by Tim Horton.
69
70         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
71
72         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
73         (WTR::UIScriptController::menuRect const):
74         (WTR::UIScriptController::isShowingMenu const):
75         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
76         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
77         (WTR::UIScriptController::menuRect const):
78
79         Add a function to query the bounds of the callout menu in content coordinates.
80
81         (WTR::UIScriptController::isShowingMenu const):
82
83         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
84
85         * TestRunnerShared/UIScriptContext/UIScriptController.h:
86         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
87         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
88         (WTR::UIScriptController::rectForMenuAction const):
89         (WTR::UIScriptController::menuRect const):
90         (WTR::UIScriptController::isShowingMenu const):
91         (WTR::findViewInHierarchyOfType): Deleted.
92
93 2019-02-22  Chris Dumez  <cdumez@apple.com>
94
95         Regression(PSON) Unable to preview password-protected documents on iCloud.com
96         https://bugs.webkit.org/show_bug.cgi?id=194954
97         <rdar://problem/48127957>
98
99         Reviewed by Alex Christensen.
100
101         Add API test coverage.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
104         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
105         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
106         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
107
108 2019-02-22  Chris Dumez  <cdumez@apple.com>
109
110         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
111         https://bugs.webkit.org/show_bug.cgi?id=194924
112         <rdar://problem/48216125>
113
114         Reviewed by Geoffrey Garen.
115
116         Add API test coverage.
117
118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
119
120 2019-02-22  Chris Dumez  <cdumez@apple.com>
121
122         Unreviewed, disable API test added in r241928 on iOS.
123
124         The cache is not enabled on devices with less than 3GB of RAM.
125
126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
127
128 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
129
130         Hardcode Visual Viewports on everywhere except iOS WK1
131         https://bugs.webkit.org/show_bug.cgi?id=194928
132
133         Reviewed by Zalan Bujtas.
134
135         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
136         change the default value of the Setting to 'true', and hardcode WebView on iOS to
137         set it to false. The setting has shipped for several years and there's no need to turn
138         it off now.
139
140         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
141         Visual Viewports are not enabled.
142         
143         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
144         that only runs in WK2
145
146         * MiniBrowser/mac/SettingsController.h:
147         * MiniBrowser/mac/SettingsController.m:
148         (-[SettingsController init]):
149         (-[SettingsController _populateMenu]):
150         (-[SettingsController validateMenuItem:]):
151         (-[SettingsController visualViewportEnabled]): Deleted.
152         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
153         * MiniBrowser/mac/WK1BrowserWindowController.m:
154         (-[WK1BrowserWindowController didChangeSettings]):
155         * MiniBrowser/mac/WK2BrowserWindowController.m:
156         (-[WK2BrowserWindowController didChangeSettings]):
157
158 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
159
160         Discard cached processes when clearing website data store
161         https://bugs.webkit.org/show_bug.cgi?id=194894
162
163         Reviewed by Chris Dumez.
164
165         Added a test case.
166
167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
168         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
169
170 2019-02-21  Alex Christensen  <achristensen@webkit.org>
171
172         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
173         https://bugs.webkit.org/show_bug.cgi?id=194914
174         <rdar://problem/47586889>
175
176         Reviewed by Geoffrey Garen.
177
178         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
179         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
180         (TEST):
181         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
182
183 2019-02-21  David Kilzer  <ddkilzer@apple.com>
184
185         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
186         <https://webkit.org/b/194761>
187
188         Reviewed by Myles Maxfield.
189
190         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
191         (WTR::activateSystemCoreWebFonts): Log `error` to console if
192         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
193         to use ARC-compliant cast.
194         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
195         ARC-compliant cast.
196         (WTR::installFakeHelvetica): Log `error` to console if
197         CTFontManagerRegisterFontsForURL() fails, but only on supported
198         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
199         Call CFRelease() on `error` to fix the leak.  Update to use
200         ARC-compliant cast.
201         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
202         cast.
203
204 2019-02-21  Chris Dumez  <cdumez@apple.com>
205
206         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
207         https://bugs.webkit.org/show_bug.cgi?id=194481
208
209         Reviewed by Alex Christensen.
210
211         Give the processes a chance to shutdown and wait until we reached the expected number
212         of processes.
213
214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
215
216 2019-02-21  Tim Horton  <timothy_horton@apple.com>
217
218         Fix the macOS build
219
220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
221
222 2019-02-21  Tim Horton  <timothy_horton@apple.com>
223
224         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
225
226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
227         I am a backwards.
228
229 2019-02-21  Tim Horton  <timothy_horton@apple.com>
230
231         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
232
233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
234         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
235         We could force on UI-side compositing, but I feel like the test might be more
236         valuable exercising the normal path on each platform (though the original
237         bug was also UI-side specific). Though we can't validate that the overlay
238         layer was installed successfully, there are layout tests that do that.
239
240 2019-02-21  Tim Horton  <timothy_horton@apple.com>
241
242         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
243         https://bugs.webkit.org/show_bug.cgi?id=194845
244         <rdar://problem/47944579>
245
246         Reviewed by Antti Koivisto.
247
248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
250
251 2019-02-21  Zalan Bujtas  <zalan@apple.com>
252
253         [LFC][Floats] Add support for placing formatting roots in-between floats.
254         https://bugs.webkit.org/show_bug.cgi?id=194902
255
256         Reviewed by Antti Koivisto.
257
258         * LayoutReloaded/misc/LFC-passing-tests.txt:
259
260 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
261
262         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
263         https://bugs.webkit.org/show_bug.cgi?id=194901
264
265         Unreviewed build fix.
266
267         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
268         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
269         WPEBackend-fdo-0.1 as library name.
270
271 2019-02-21  Rob Buis  <rbuis@igalia.com>
272
273         Update MIME type parser
274         https://bugs.webkit.org/show_bug.cgi?id=180526
275
276         Reviewed by Darin Adler.
277
278         Add tests involving leading and trailing whitespace, non-token
279         characters and quoted strings.
280
281         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
282         (TestWebKitAPI::TEST):
283
284 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
285
286         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
287         https://bugs.webkit.org/show_bug.cgi?id=194884
288
289         Reviewed by Michael Catanzaro.
290
291         * PlatformWin.cmake:
292
293 2019-02-20  Chris Dumez  <cdumez@apple.com>
294
295         Add API test for <rdar://problem/47471222>
296         https://bugs.webkit.org/show_bug.cgi?id=194847
297
298         Reviewed by Alex Christensen.
299
300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
301
302 2019-02-20  Chris Dumez  <cdumez@apple.com>
303
304         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
305         https://bugs.webkit.org/show_bug.cgi?id=194872
306         <rdar://problem/47924500>
307
308         Reviewed by Alex Christensen.
309
310         Add API test coverage.
311
312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
313
314 2019-02-20  Jer Noble  <jer.noble@apple.com>
315
316         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
317         https://bugs.webkit.org/show_bug.cgi?id=191332
318
319         Reviewed by Dean Jackson.
320
321         * Scripts/git-is-in-range: Added.
322
323 2019-02-20  Andy Estes  <aestes@apple.com>
324
325         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
326         https://bugs.webkit.org/show_bug.cgi?id=194869
327
328         Rubber-stamped by Jer Noble.
329
330         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
331         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
332         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
333         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
336
337 2019-02-20  Chris Dumez  <cdumez@apple.com>
338
339         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
340         https://bugs.webkit.org/show_bug.cgi?id=194857
341         <rdar://problem/47759323>
342
343         Reviewed by Alex Christensen.
344
345         Add API test coverage.
346
347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
348
349 2019-02-20  Chris Dumez  <cdumez@apple.com>
350
351         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
352         https://bugs.webkit.org/show_bug.cgi?id=194829
353         <rdar://problem/47889906>
354
355         Reviewed by Alexey Proskuryakov.
356
357         Every time the TestOptions were changing we were creating both a new Web view and
358         a new WKContext, which would start a new Network process. In most cases, we only
359         need to contruct a new Web view and we do can keep reusing the same WKContext.
360         This patch implements this optimization and thus avoids spinning a lot of new
361         Network processes while running the layout tests.
362
363         * WebKitTestRunner/TestController.cpp:
364         (WTR::TestController::generateContextConfiguration const):
365         (WTR::TestController::generatePageConfiguration):
366         (WTR::TestController::createWebViewWithOptions):
367         (WTR::TestController::resetPreferencesToConsistentValues):
368         (WTR::updateTestOptionsFromTestHeader):
369         * WebKitTestRunner/TestController.h:
370         * WebKitTestRunner/TestOptions.h:
371         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
372         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
373         (WTR::TestOptions::hasSameInitializationOptions const):
374         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
375         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
376         (WTR::TestController::platformAddTestOptions const):
377
378 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
379
380         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
381         https://bugs.webkit.org/show_bug.cgi?id=167941
382
383         Reviewed by Carlos Garcia Campos.
384
385         * MiniBrowser/gtk/main.c:
386         (filterSavedCallback): Added.
387         (main): Support loading a JSON rule set file for content filtering.
388         * MiniBrowser/wpe/main.cpp:
389         (filterSavedCallback): Added.
390         (main): Support loading a JSON rule set file for content filtering.
391         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
392         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
393         (WTF::derefGPtr): Ditto.
394         (testEmptyStore):
395         (testSaveInvalidFilter):
396         (testSaveLoadFilter):
397         (testSavedFilterIdentifierMatch):
398         (testRemoveFilter):
399         (testSaveMultipleFilters):
400         (testSaveFilterFromFile):
401         (testFilterPersistence):
402         (beforeAll):
403         (afterAll):
404         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
405         (removeOldInjectedContentAndResetLists): Also reset content filters.
406         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
407         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
408         the element affected by the style sheet.
409         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
410         and returns it to be used by tests.
411         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
412         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
413         (serverCallback): Add support for serving a CSS style sheet for testing.
414         (beforeAll): Add call to testUserContentManagerContentFilter().
415         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
416
417 2019-02-19  Keith Rollin  <krollin@apple.com>
418
419         Add timing information to build output
420         https://bugs.webkit.org/show_bug.cgi?id=194839
421         <rdar://problem/48219609>
422
423         Reviewed by Alexey Proskuryakov.
424
425         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
426         emit each project's build time to its output. E.g.,
427
428             ** BUILD SUCCEEDED ** [0.132 sec]
429
430         * Scripts/webkitdirs.pm:
431         (XcodeOptions):
432
433 2019-02-19  Truitt Savell  <tsavell@apple.com>
434
435         Unreviewed, rolling out r241784.
436
437         Broke all OpenSource builds.
438
439         Reverted changeset:
440
441         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
442         instances view"
443         https://bugs.webkit.org/show_bug.cgi?id=172848
444         https://trac.webkit.org/changeset/241784
445
446 2019-02-19  Zalan Bujtas  <zalan@apple.com>
447
448         [LFC][Floats] Remove redundant intersecting logic
449         https://bugs.webkit.org/show_bug.cgi?id=194804
450
451         Reviewed by Antti Koivisto.
452
453         * LayoutReloaded/misc/LFC-passing-tests.txt:
454
455 2019-02-19  Dean Jackson  <dino@apple.com>
456
457         Clean-up output from generate-xcfilelists so it can be filtered
458         https://bugs.webkit.org/show_bug.cgi?id=194795
459
460         Reviewed by Joseph Pecoraro (and Keith Rollin).
461
462         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
463         make a slight tweak to filter-build-webkit so such lines are marked
464         as plain.
465
466         * Scripts/filter-build-webkit:
467         * Scripts/generate-xcfilelists:
468
469 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
470
471         pytest is not correctly auto-installed
472         https://bugs.webkit.org/show_bug.cgi?id=194707
473
474         Reviewed by Carlos Garcia Campos.
475
476         * Scripts/webkitpy/thirdparty/__init__.py:
477         (AutoinstallImportHook._install_pytest):
478
479 2019-02-18  Chris Dumez  <cdumez@apple.com>
480
481         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
482         https://bugs.webkit.org/show_bug.cgi?id=194797
483         <rdar://problem/48055151>
484
485         Reviewed by Geoffrey Garen.
486
487         Add API test coverage.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
490
491 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
492
493         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
494         https://bugs.webkit.org/show_bug.cgi?id=194670
495         <rdar://problem/39066529>
496
497         Reviewed by Tim Horton.
498
499         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
500         pasted in an editable area as attachment elements.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
503         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
504         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
505         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
506         (TestWebKitAPI::TEST):
507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
508         (WTR::InjectedBundlePage::InjectedBundlePage):
509
510 2019-02-18  Alex Christensen  <achristensen@webkit.org>
511
512         Fix API test after r241728
513        ​https://bugs.webkit.org/show_bug.cgi?id=194723
514
515         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
516         (TEST):
517         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
518
519 2019-02-18  Daniel Bates  <dabates@apple.com>
520
521         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
522         https://bugs.webkit.org/show_bug.cgi?id=192824
523         <rdar://problem/47100332>
524
525         Reviewed by Wenson Hsieh.
526
527         Fix a bug where the wrong usage code was used for F13 thru F24.
528
529         * WebKitTestRunner/ios/HIDEventGenerator.mm:
530         (keyCodeForDOMFunctionKey):
531
532 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
533
534         Bytecode cache should a have a boot-specific validation
535         https://bugs.webkit.org/show_bug.cgi?id=194769
536         <rdar://problem/48149509>
537
538         Reviewed by Keith Miller.
539
540         Add test for WTF::bootSessionUUIDString()
541
542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
543         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
544         (TEST):
545
546 2019-02-18  Alex Christensen  <achristensen@webkit.org>
547
548         Disable safe browsing in WKWebView and remove its WKPreferences API
549         https://bugs.webkit.org/show_bug.cgi?id=194723
550         <rdar://problem/48122993>
551
552         Reviewed by Geoffrey Garen.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
555         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
556         (TEST):
557         (safeBrowsingView):
558         Make tests use SPI instead of API.
559
560 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
561
562         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
563         https://bugs.webkit.org/show_bug.cgi?id=194586
564
565         Reviewed by Ross Kirsling.
566
567         * DumpRenderTree/win/DumpRenderTree.cpp:
568         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
569         * Scripts/webkitpy/port/driver.py:
570         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
571
572 2019-02-17  David Kilzer  <ddkilzer@apple.com>
573
574         Unreviewed, rolling out r241620.
575
576         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
577         (Requested by ddkilzer on #webkit.)
578
579         Reverted changeset:
580
581         "[WTF] Add environment variable helpers"
582         https://bugs.webkit.org/show_bug.cgi?id=192405
583         https://trac.webkit.org/changeset/241620
584
585 2019-02-16  Zalan Bujtas  <zalan@apple.com>
586
587         [LFC] RenderImage's default intrinsic size is 0.
588         https://bugs.webkit.org/show_bug.cgi?id=194745
589
590         Reviewed by Antti Koivisto.
591
592         * LayoutReloaded/misc/LFC-passing-tests.txt:
593
594 2019-02-16  Zalan Bujtas  <zalan@apple.com>
595
596         [LFC][BFC] Add support for block replaced intrinsic width.
597         https://bugs.webkit.org/show_bug.cgi?id=194705
598
599         Reviewed by Simon Fraser.
600
601         * LayoutReloaded/misc/LFC-passing-tests.txt:
602
603 2019-02-16  Zalan Bujtas  <zalan@apple.com>
604
605         [LFC] Apply min/max width constraints to preferred width computation
606         https://bugs.webkit.org/show_bug.cgi?id=194739
607
608         Reviewed by Simon Fraser.
609
610         * LayoutReloaded/misc/LFC-passing-tests.txt:
611
612 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
613
614         [WTF] Add environment variable helpers
615         https://bugs.webkit.org/show_bug.cgi?id=192405
616
617         Reviewed by Michael Catanzaro.
618
619         * DumpRenderTree/mac/DumpRenderTree.mm:
620         (libraryPathForDumpRenderTree):
621         * DumpRenderTree/win/DumpRenderTree.cpp:
622         (libraryPathForDumpRenderTree):
623         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
624         (setUpIOSLayoutTestCommunication):
625         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
626         (beforeAll):
627         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
628         (main):
629         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
630         (WebKitTestBus::run):
631         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
632         (WTR::getOutputDir):
633         (WTR::initializeFontConfigSetting):
634         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
635         (WTR::InjectedBundle::platformInitialize):
636         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
637         (WTR::topLevelPath):
638         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
639         (WTR::topLevelPath):
640         (WTR::getOutputDir):
641         (WTR::activateFonts):
642         * WebKitTestRunner/TestController.cpp:
643         (WTR::TestController::libraryPathForTesting):
644         (WTR::TestController::generateContextConfiguration const):
645         (WTR::TestController::generatePageConfiguration):
646         (WTR::TestController::decideDestinationWithSuggestedFilename):
647         (WTR::TestController::platformAdjustContext):
648         * WebKitTestRunner/TestController.h:
649         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
650         (WTR::TestController::cocoaPlatformInitialize):
651         (WTR::TestController::platformAdjustContext):
652         * WebKitTestRunner/gtk/main.cpp:
653         (main):
654         * WebKitTestRunner/mac/TestControllerMac.mm:
655         (WTR::TestController::configureContentExtensionForTest):
656         * WebKitTestRunner/wpe/main.cpp:
657         (main):
658         Utilize WTF::Environment where possible.
659
660 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
661
662         [iOS] WKWebView callout bar is missing Change Writing Direction item
663         https://bugs.webkit.org/show_bug.cgi?id=190015
664         <rdar://problem/44810366>
665
666         Reviewed by Tim Horton.
667
668         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
669         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
672         (TestWebKitAPI::TEST):
673
674 2019-02-15  Chris Dumez  <cdumez@apple.com>
675
676         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
677         https://bugs.webkit.org/show_bug.cgi?id=194717
678         <rdar://problem/47884404>
679
680         Reviewed by Brady Eidson.
681
682         Add API test coverage.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
685
686 2019-02-15  Youenn Fablet  <youenn@apple.com>
687
688         Make navigator.mediaDevices SecureContext
689         https://bugs.webkit.org/show_bug.cgi?id=194666
690
691         Reviewed by Eric Carlson.
692
693         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
694         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
695         (TEST_F):
696
697 2019-02-15  Brian Burg  <bburg@apple.com>
698
699         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
700         https://bugs.webkit.org/show_bug.cgi?id=194411
701         <rdar://problem/47787614>
702
703         Reviewed by Joseph Pecoraro.
704
705         Remove unnecessary soft linking macro usage.
706
707         * DumpRenderTree/mac/TestRunnerMac.mm:
708         (TestRunner::inspectorTestStubURL):
709         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
710         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
711         (WTR::TestRunner::inspectorTestStubURL):
712
713 2019-02-15  Commit Queue  <commit-queue@webkit.org>
714
715         Unreviewed, rolling out r241559 and r241566.
716         https://bugs.webkit.org/show_bug.cgi?id=194710
717
718         Causes layout test crashes under GuardMalloc (Requested by
719         ryanhaddad on #webkit).
720
721         Reverted changesets:
722
723         "[WTF] Add environment variable helpers"
724         https://bugs.webkit.org/show_bug.cgi?id=192405
725         https://trac.webkit.org/changeset/241559
726
727         "Unreviewed build fix for WinCairo Debug after r241559."
728         https://trac.webkit.org/changeset/241566
729
730 2019-02-15  Zalan Bujtas  <zalan@apple.com>
731
732         [LFC] Out-of-flow box is never a float box
733         https://bugs.webkit.org/show_bug.cgi?id=194704
734
735         Reviewed by Antti Koivisto.
736
737         * LayoutReloaded/misc/LFC-passing-tests.txt:
738
739 2019-02-10  Darin Adler  <darin@apple.com>
740
741         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
742         https://bugs.webkit.org/show_bug.cgi?id=194487
743
744         Reviewed by Daniel Bates.
745
746         * DumpRenderTree/win/DumpRenderTree.cpp:
747         (applicationId): Use makeString instead of String::format.
748         (main): Ditto.
749         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
750         (TestWebKitAPI::Util::createURLForResource): Ditto.
751         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
752         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
753
754         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
755         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
756         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
757         (WTR::createStringWithAttributes): Use appendLiteral.
758         (WTR::AccessibilityUIElement::helpText const): Ditto.
759         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
760         directly instead of using String::format.
761         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
762         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
763
764 2019-02-15  Truitt Savell  <tsavell@apple.com>
765
766         Unreviewed, rolling out r241564.
767
768         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
769
770         Reverted changeset:
771
772         "[Mac] WebInspectorUI.framework does not need to be soft-
773         linked anymore"
774         https://bugs.webkit.org/show_bug.cgi?id=194411
775         https://trac.webkit.org/changeset/241564
776
777 2019-02-15  Saam barati  <sbarati@apple.com>
778
779         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
780         https://bugs.webkit.org/show_bug.cgi?id=194036
781
782         Reviewed by Yusuke Suzuki.
783
784         * Scripts/run-jsc-stress-tests:
785
786 2019-02-14  Tim Horton  <timothy_horton@apple.com>
787
788         Fix the build.
789
790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
791         (WTR::UIScriptController::drawSquareInEditableImage):
792         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
793         (TestWebKitAPI::drawSquareInEditableImage):
794
795 2019-02-14  Tim Horton  <timothy_horton@apple.com>
796
797         Fix the build.
798
799         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
800         (WTR::UIScriptController::drawSquareInEditableImage):
801         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
802         (TestWebKitAPI::drawSquareInEditableImage):
803
804 2019-02-14  Brian Burg  <bburg@apple.com>
805
806         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
807         https://bugs.webkit.org/show_bug.cgi?id=194411
808         <rdar://problem/47787614>
809
810         Reviewed by Joseph Pecoraro.
811
812         Remove unnecessary soft linking macro usage.
813
814         * DumpRenderTree/mac/TestRunnerMac.mm:
815         (TestRunner::inspectorTestStubURL):
816         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
817         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
818         (WTR::TestRunner::inspectorTestStubURL):
819
820 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
821
822         [ews-app] status bubble should fetch builder name info from BuilderMapping table
823         https://bugs.webkit.org/show_bug.cgi?id=194599
824
825         Reviewed by Lucas Forschler.
826
827         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
828         (StatusBubble._build_bubble):
829
830 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
831
832         [ews-app] Set Foreign Key in Django build model
833         https://bugs.webkit.org/show_bug.cgi?id=194667
834
835         Reviewed by Lucas Forschler.
836
837         * BuildSlaveSupport/ews-app/ews/models/build.py:
838         (Build):
839
840 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
841
842         [WTF] Add environment variable helpers
843         https://bugs.webkit.org/show_bug.cgi?id=192405
844
845         Reviewed by Michael Catanzaro.
846
847         * DumpRenderTree/mac/DumpRenderTree.mm:
848         (libraryPathForDumpRenderTree):
849         * DumpRenderTree/win/DumpRenderTree.cpp:
850         (libraryPathForDumpRenderTree):
851         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
852         (setUpIOSLayoutTestCommunication):
853         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
854         (TestWebKitAPI::strip):
855         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
856         (beforeAll):
857         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
858         (main):
859         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
860         (WebKitTestBus::run):
861         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
862         (WTR::getOutputDir):
863         (WTR::initializeFontConfigSetting):
864         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
865         (WTR::InjectedBundle::platformInitialize):
866         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
867         (WTR::topLevelPath):
868         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
869         (WTR::topLevelPath):
870         (WTR::getOutputDir):
871         (WTR::activateFonts):
872         * WebKitTestRunner/TestController.cpp:
873         (WTR::TestController::libraryPathForTesting):
874         (WTR::TestController::generateContextConfiguration const):
875         (WTR::TestController::generatePageConfiguration):
876         (WTR::TestController::decideDestinationWithSuggestedFilename):
877         (WTR::TestController::platformAdjustContext):
878         * WebKitTestRunner/TestController.h:
879         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
880         (WTR::TestController::cocoaPlatformInitialize):
881         (WTR::TestController::platformAdjustContext):
882         * WebKitTestRunner/gtk/main.cpp:
883         (main):
884         * WebKitTestRunner/mac/TestControllerMac.mm:
885         (WTR::TestController::configureContentExtensionForTest):
886         * WebKitTestRunner/wpe/main.cpp:
887         (main):
888         Utilize WTF::Environment where possible.
889
890 2019-02-14  Chris Dumez  <cdumez@apple.com>
891
892         [PSON] Introduce a WebContent Process cache
893         https://bugs.webkit.org/show_bug.cgi?id=194594
894         <rdar://problem/46793397>
895
896         Reviewed by Geoff Garen.
897
898         Update API tests to turn on the WebContent Process cache.
899
900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
901
902 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
903
904         Unreviewed, build fix after r241480
905
906         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
907         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
908         (-[DragAndDropSimulator initWithWebView:]):
909
910 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
911
912         AX: ARIA Reflection was disabled in error
913         https://bugs.webkit.org/show_bug.cgi?id=194647
914         <rdar://problem/48068336>
915
916         Reviewed by Ryosuke Niwa.
917
918         Remove test override now that this feature should be enabled by default.
919
920         * WebKitTestRunner/TestController.cpp:
921         (WTR::TestController::resetPreferencesToConsistentValues):
922
923 2019-02-14  Commit Queue  <commit-queue@webkit.org>
924
925         Unreviewed, rolling out r241486.
926         https://bugs.webkit.org/show_bug.cgi?id=194655
927
928         causing API failures in builds (Requested by ShawnRoberts on
929         #webkit).
930
931         Reverted changeset:
932
933         "[Cocoa] Media elements will restart network buffering just
934         before suspending"
935         https://bugs.webkit.org/show_bug.cgi?id=193691
936         https://trac.webkit.org/changeset/241486
937
938 2019-02-14  Zalan Bujtas  <zalan@apple.com>
939
940         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
941         https://bugs.webkit.org/show_bug.cgi?id=194622
942
943         Reviewed by Antti Koivisto.
944
945         * LayoutReloaded/misc/LFC-passing-tests.txt:
946
947 2019-02-14  Zalan Bujtas  <zalan@apple.com>
948
949         [LFC] Shrink-to-fit-width should be constrained by min/max width
950         https://bugs.webkit.org/show_bug.cgi?id=194653
951
952         Reviewed by Antti Koivisto.
953
954         * LayoutReloaded/misc/LFC-passing-tests.txt:
955
956 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
957
958         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
959         https://bugs.webkit.org/show_bug.cgi?id=194641
960
961         Reviewed by Geoffrey Garen.
962
963         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
964         so that the test would fail without this fix.
965
966         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
967         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
968
969 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
970
971         [ews-app] Change log level for a log statement
972
973         Unreviewed minor fix.
974
975         * BuildSlaveSupport/ews-app/ews/models/patch.py:
976         (Patch.save_patch):
977
978 2019-02-13  Jer Noble  <jer.noble@apple.com>
979
980         [Cocoa] Media elements will restart network buffering just before suspending
981         https://bugs.webkit.org/show_bug.cgi?id=193691
982
983         Reviewed by Eric Carlson.
984
985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
987         (TEST):
988
989 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
990
991         [ews-app] Fetch builder id to name mapping
992         https://bugs.webkit.org/show_bug.cgi?id=194355
993
994         Reviewed by Lucas Forschler.
995
996         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
997         (Buildbot.get_builder_id_to_name_mapping):
998         (Buildbot._get_display_name_from_builder_name):
999
1000 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1001
1002         Further restricting webarchive loads
1003         https://bugs.webkit.org/show_bug.cgi?id=194567
1004         <rdar://problem/47610130>
1005
1006         Reviewed by Youenn Fablet.
1007
1008         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1009         navigations on drop.
1010
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1013         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1014         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1015         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1018         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1019         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1020         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1021         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1022         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1023         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1024
1025 2019-02-13  John Wilander  <wilander@apple.com>
1026
1027         Store Ad Click Attribution requests in the network process
1028         https://bugs.webkit.org/show_bug.cgi?id=194510
1029         <rdar://problem/47650118>
1030
1031         Reviewed by Alex Christensen and Daniel Bates.
1032
1033         This patch adds two TestRunner functions:
1034         - dumpAdClickAttribution()
1035         - clearAdClickAttribution()
1036
1037         They call into the network process to dump and clear Ad Click
1038         Attribution state, respectively.
1039
1040         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1041         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1042         (WTR::TestRunner::dumpAdClickAttribution):
1043         (WTR::TestRunner::clearAdClickAttribution):
1044         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::resetStateToConsistentValues):
1047         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1048         (WTR::adClickAttributionStringResultCallback):
1049         (WTR::TestController::dumpAdClickAttribution):
1050         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1051         (WTR::adClickAttributionVoidCallback):
1052         (WTR::TestController::clearAdClickAttribution):
1053         * WebKitTestRunner/TestController.h:
1054         * WebKitTestRunner/TestInvocation.cpp:
1055         (WTR::TestInvocation::dumpResults):
1056         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1057         (WTR::TestInvocation::dumpAdClickAttribution):
1058         * WebKitTestRunner/TestInvocation.h:
1059
1060 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1061
1062         [ews-app] Generate status-bubble
1063         https://bugs.webkit.org/show_bug.cgi?id=194572
1064
1065         Reviewed by Lucas Forschler.
1066
1067         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1068         (StatusBubble._build_bubble):
1069         (StatusBubble._should_show_bubble_for):
1070         (StatusBubble._build_bubbles_for_patch):
1071
1072 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1073
1074         [ews-app] Add status bubble html template
1075         https://bugs.webkit.org/show_bug.cgi?id=194571
1076
1077         Reviewed by Lucas Forschler.
1078
1079         * BuildSlaveSupport/ews-app/ews/templates: Added.
1080         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1081
1082 2019-02-12  Chris Dumez  <cdumez@apple.com>
1083
1084         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1085         https://bugs.webkit.org/show_bug.cgi?id=194568
1086         <rdar://problem/47944490>
1087
1088         Reviewed by Ryosuke Niwa.
1089
1090         Add API test coverage.
1091
1092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1093         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1094
1095 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1096
1097         webkitpy: Remove bug_dummy from parsed test expectations
1098         https://bugs.webkit.org/show_bug.cgi?id=194562
1099         <rdar://problem/47853999>
1100
1101         Reviewed by Lucas Forschler.
1102
1103         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1104         (TestExpectationParser):
1105         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1106         skipped tests.
1107         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1108
1109 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1110
1111         [ews-app] Add method to fetch patch
1112         https://bugs.webkit.org/show_bug.cgi?id=194518
1113
1114         Reviewed by Lucas Forschler.
1115
1116         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1117         (Patch.get_patch):
1118
1119 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1120
1121         [LFC] Expand tests coverage (60 new tests -> 860)
1122
1123         Unreviewed test gardening (run-singly, --child-processes=1).
1124
1125         * LayoutReloaded/misc/LFC-passing-tests.txt:
1126
1127 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         Allow pages to trigger programmatic paste from script on iOS
1130         https://bugs.webkit.org/show_bug.cgi?id=194271
1131         <rdar://problem/47808810>
1132
1133         Reviewed by Tim Horton.
1134
1135         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1136
1137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1138         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1139         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1140         (WTR::UIScriptController::rectForMenuAction const):
1141
1142         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1143         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1144         for when the menu is shown or hidden.
1145
1146         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1147         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1148         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1149         (WTR::UIScriptController::setDidShowMenuCallback):
1150         (WTR::UIScriptController::didShowMenuCallback const):
1151         (WTR::UIScriptController::setDidHideMenuCallback):
1152         (WTR::UIScriptController::didHideMenuCallback const):
1153         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1154         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1155         (WTR::UIScriptController::rectForMenuAction const):
1156         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1157         * WebKitTestRunner/TestController.cpp:
1158         (WTR::TestController::resetPreferencesToConsistentValues):
1159         (WTR::updateTestOptionsFromTestHeader):
1160         * WebKitTestRunner/TestOptions.h:
1161
1162         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1163         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1164
1165         (WTR::TestOptions::hasSameInitializationOptions const):
1166         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1167         (WTR::UIScriptController::calendarType const):
1168         (WTR::UIScriptController::platformUndoManager const):
1169         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1170         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1171         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1172         (-[TestRunnerWKWebView dealloc]):
1173         (-[TestRunnerWKWebView _didShowMenu]):
1174         (-[TestRunnerWKWebView _didHideMenu]):
1175
1176         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1177
1178         * WebKitTestRunner/ios/TestControllerIOS.mm:
1179         (WTR::handleMenuWillHideNotification):
1180         (WTR::handleMenuDidHideNotification):
1181         (WTR::TestController::platformInitialize):
1182         (WTR::TestController::platformDestroy):
1183         (WTR::TestController::platformResetStateToConsistentValues):
1184
1185         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1186         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1187
1188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1189         (WTR::forEachViewInHierarchy):
1190         (WTR::findViewInHierarchyOfType):
1191
1192         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1193         functions that dig through a given view's hierarchy in search of a view of a given class.
1194
1195         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1196         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1197         (WTR::UIScriptController::selectionCaretViewRect const):
1198         (WTR::UIScriptController::selectionRangeViewRects const):
1199         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1200         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1201
1202         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1203
1204         (WTR::UIScriptController::rectForMenuAction const):
1205
1206         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1207         callout bar) whose label matches the given string.
1208
1209         (WTR::UIScriptController::platformContentView const):
1210
1211         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1212         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1213         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1214
1215         (WTR::UIScriptController::platformUndoManager const): Deleted.
1216         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1217         (WTR::UIScriptController::platformContentView const):
1218         (WTR::UIScriptController::platformUndoManager const): Deleted.
1219
1220 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1221
1222         webkitpy: No option to only show unexpected failures in results.html for iPad
1223         https://bugs.webkit.org/show_bug.cgi?id=194554
1224         <rdar://problem/47922442>
1225
1226         Rubber-stamped by Aakash Jain.
1227
1228         Just because a TestExpecations file does not exist for a specific platform does not mean that
1229         TestExpecations are not being used, given that platforms inherit test expectations.
1230
1231         * Scripts/webkitpy/port/base.py:
1232         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1233         * Scripts/webkitpy/port/base_unittest.py:
1234         (PortTest.test_uses_test_expectations_file):
1235
1236 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1237
1238         Remove setDefersLoading infrastructure from WebKit2
1239         https://bugs.webkit.org/show_bug.cgi?id=194506
1240
1241         Reviewed by Brady Eidson.
1242
1243         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1244         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1245         (WTR::TestRunner::setDefersLoading): Deleted.
1246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1247
1248 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1249
1250         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1251         https://bugs.webkit.org/show_bug.cgi?id=194522
1252         <rdar://problem/47789393>
1253
1254         Reviewed by Chris Dumez.
1255
1256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1257         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1258         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1260
1261 2019-02-12  Andy Estes  <aestes@apple.com>
1262
1263         [iOSMac] Enable Parental Controls Content Filtering
1264         https://bugs.webkit.org/show_bug.cgi?id=194521
1265         <rdar://39732376>
1266
1267         Reviewed by Tim Horton.
1268
1269         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1270
1271 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1272
1273         [LFC][IFC] Add intrinsic width support for float boxes.
1274         https://bugs.webkit.org/show_bug.cgi?id=194528
1275
1276         Reviewed by Antti Koivisto.
1277
1278         Expand tests coverage (2 new tests -> 800).
1279         (This is the correct test ordering --runs-singly --child-processes=1)
1280
1281         * LayoutReloaded/misc/LFC-passing-tests.txt:
1282
1283 2019-02-12  Rob Buis  <rbuis@igalia.com>
1284
1285         Implement serializing in MIME type parser
1286         https://bugs.webkit.org/show_bug.cgi?id=193909
1287
1288         Reviewed by Darin Adler.
1289
1290         Add various tests involving upper case, non-ASCII, control/null characters,
1291         various HTTP whitespace, single quotes and an unpaired surrogate.
1292
1293         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1294         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1295         (TestWebKitAPI::serializeIfValid):
1296         (TestWebKitAPI::TEST):
1297
1298 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1299
1300         [Cocoa] Ask platform for generic font family mappings
1301         https://bugs.webkit.org/show_bug.cgi?id=187723
1302         <rdar://problem/41892438>
1303
1304         Reviewed by Brent Fulgham.
1305
1306         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1307
1308         * DumpRenderTree/mac/DumpRenderTree.mm:
1309         (allowedFontFamilySet):
1310         * WebKitTestRunner/mac/TestControllerMac.mm:
1311         (WTR::allowedFontFamilySet):
1312
1313 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1314
1315         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1316         https://bugs.webkit.org/show_bug.cgi?id=193622
1317
1318         Reviewed by Michael Catanzaro.
1319
1320         This adds support for loading content extension rule sets from the JSON files which
1321         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1322         of WKTR for this could be removed, but that is left for a follow-up patch with
1323         cleanups.
1324
1325         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1326         * WebKitTestRunner/TestController.cpp:
1327         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1328         avoid having the null-terminator copied into the result.
1329         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1330         part of the preparations to run a test.
1331         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1332         (WTR::contentExtensionStoreCallback): Added.
1333         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1334         used for content extensions test.
1335         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1336         extensions and compiling the JSON rule set for tests involving content extensions.
1337         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1338         testing and disables content extensions.
1339         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1340         resetContentExtensions().
1341         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1342         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1343         configureContentExtensionForTest(), and userContentController().
1344
1345 2019-02-11  Daniel Bates  <dabates@apple.com>
1346
1347         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1348         https://bugs.webkit.org/show_bug.cgi?id=191446
1349         <rdar://problem/45929460>
1350
1351         Reviewed by Tim Horton.
1352
1353         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1354
1355         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1356         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1357         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1358         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1359         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1360         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1361         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1362         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1363         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1364         (WTR::arrayLength):
1365         (WTR::parseModifierArray):
1366         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1367         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1368         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1369         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1370
1371 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1372
1373         Unreviewed, rolling out r241272 and r241276.
1374         https://bugs.webkit.org/show_bug.cgi?id=194514
1375
1376         Broke the Apple Internal build and the fix requires human
1377         intervention :( (Requested by dydz on #webkit).
1378
1379         Reverted changesets:
1380
1381         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1382         https://bugs.webkit.org/show_bug.cgi?id=191446
1383         https://trac.webkit.org/changeset/241272
1384
1385         "Fix internal iOS build after r241272"
1386         https://bugs.webkit.org/show_bug.cgi?id=191446
1387         https://trac.webkit.org/changeset/241276
1388
1389 2019-02-11  Truitt Savell  <tsavell@apple.com>
1390
1391         Unreviewed, rolling out r241269.
1392
1393         Caused 5 layout tests crashes on Mac WK1
1394
1395         Reverted changeset:
1396
1397         "DumpRenderTree should report unknown options"
1398         https://bugs.webkit.org/show_bug.cgi?id=191303
1399         https://trac.webkit.org/changeset/241269
1400
1401 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1402
1403         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1404         https://bugs.webkit.org/show_bug.cgi?id=194313
1405
1406         Reviewed by Tim Horton.
1407
1408         Add a helper to determine whether the web view is presenting modal UI.
1409
1410         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1411         (WTR::UIScriptController::isPresentingModally const):
1412         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1413         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1414         (WTR::UIScriptController::isPresentingModally const):
1415         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1416         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1417         (WTR::UIScriptController::calendarType const): Deleted.
1418         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1419         (WTR::UIScriptController::isPresentingModally const):
1420         (WTR::UIScriptController::calendarType const):
1421         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1422         (WTR::UIScriptController::calendarType const):
1423
1424 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1425
1426         GCHeapInspector: Show the retained sizes in more places
1427         https://bugs.webkit.org/show_bug.cgi?id=194464
1428
1429         Reviewed by Simon Fraser.
1430
1431         * GCHeapInspector/gc-heap-inspector.html:
1432         * GCHeapInspector/script/interface.js:
1433         (HeapInspectorUtils.humanReadableSize):
1434         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1435         (HeapInspectorUtils.spanForNode.span.span):
1436         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1437         (HeapSnapshotInspector.prototype.buildRoots):
1438
1439 2019-02-11  Daniel Bates  <dabates@apple.com>
1440
1441         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1442         https://bugs.webkit.org/show_bug.cgi?id=191446
1443         <rdar://problem/45929460>
1444
1445         Reviewed by Tim Horton.
1446
1447         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1448
1449         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1450         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1451         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1452         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1453         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1454         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1455         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1456         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1457         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1458         (WTR::arrayLength):
1459         (WTR::parseModifierArray):
1460         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1461         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1462         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1463         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1464
1465 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1466
1467         DumpRenderTree should report unknown options
1468         https://bugs.webkit.org/show_bug.cgi?id=191303
1469
1470         Reviewed by Frédéric Wang.
1471
1472         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1473         to report unknown options.
1474         Added and assigned test options which are currently used in tests.
1475
1476         * DumpRenderTree/TestOptions.cpp:
1477         (TestOptions::TestOptions):
1478
1479 2019-02-11  Truitt Savell  <tsavell@apple.com>
1480
1481         Unreviewed, rolling out r241229.
1482
1483         Revision broke internal builds for watchOS.
1484
1485         Reverted changeset:
1486
1487         "[Cocoa] Ask platform for generic font family mappings"
1488         https://bugs.webkit.org/show_bug.cgi?id=187723
1489         https://trac.webkit.org/changeset/241229
1490
1491 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1492
1493         [WinCairo][MiniBrowser] Basic authentication always fails.
1494         https://bugs.webkit.org/show_bug.cgi?id=194496
1495
1496         Reviewed by Don Olmstead.
1497
1498         * MiniBrowser/win/DialogHelper.h:
1499         (Dialog::getText):
1500
1501 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1502
1503         [GStreamer] GstMappedBuffer testsuite build fails
1504         https://bugs.webkit.org/show_bug.cgi?id=194495
1505
1506         Reviewed by Carlos Garcia Campos.
1507
1508         Fix the build by explicitely adding the gstreamer1.0-audio include
1509         directories to the include path.
1510
1511         * TestWebKitAPI/PlatformGTK.cmake:
1512         * TestWebKitAPI/PlatformWPE.cmake:
1513
1514 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1515
1516         [GTK][WPE] Add enable-javascript-markup setting
1517         https://bugs.webkit.org/show_bug.cgi?id=193439
1518
1519         Reviewed by Michael Catanzaro.
1520
1521         Add test cases to check the new setting.
1522
1523         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1524         (testWebKitSettings):
1525         (testWebKitSettingsJavaScriptMarkup):
1526         (beforeAll):
1527
1528 2019-02-10  Darin Adler  <darin@apple.com>
1529
1530         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1531         https://bugs.webkit.org/show_bug.cgi?id=194485
1532
1533         Reviewed by Daniel Bates.
1534
1535         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1536
1537 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1538
1539         Add more tests for clampTo<>()
1540         https://bugs.webkit.org/show_bug.cgi?id=194462
1541
1542         Reviewed by Geoffrey Garen.
1543
1544         Darin suggested to test the very last floating point number
1545         at the boundaries when truncating to integer.
1546         I added test for max/min and max-1/min-1.
1547
1548         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1549         (TestWebKitAPI::TEST):
1550
1551 2019-02-09  Darin Adler  <darin@apple.com>
1552
1553         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1554         https://bugs.webkit.org/show_bug.cgi?id=194021
1555
1556         Reviewed by Geoffrey Garen.
1557
1558         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1559         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1560         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1561
1562 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1563
1564         [LFC][IFC] Add intrinsic width support for basic inline containers
1565         https://bugs.webkit.org/show_bug.cgi?id=194473
1566
1567         Reviewed by Antti Koivisto.
1568
1569         Expand tests coverage (11 new tests -> 798)
1570
1571         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1572
1573 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1574
1575         Fix MiniBrowser's entitlements
1576         https://bugs.webkit.org/show_bug.cgi?id=192431
1577
1578         Reviewed by Joseph Pecoraro.
1579
1580         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1581         files, making it impossible to load any extension.
1582
1583         * MiniBrowser/MiniBrowser.entitlements:
1584
1585 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1586
1587         [Cocoa] Ask platform for generic font family mappings
1588         https://bugs.webkit.org/show_bug.cgi?id=187723
1589         <rdar://problem/41892438>
1590
1591         Reviewed by Brent Fulgham.
1592
1593         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1594
1595         * DumpRenderTree/mac/DumpRenderTree.mm:
1596         (allowedFontFamilySet):
1597         * WebKitTestRunner/mac/TestControllerMac.mm:
1598         (WTR::allowedFontFamilySet):
1599
1600 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1601
1602         [GTK] Implement back/forward touchpad gesture
1603         https://bugs.webkit.org/show_bug.cgi?id=193919
1604
1605         Reviewed by Michael Catanzaro.
1606
1607         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1608         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1609
1610 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1611
1612         Add SPI to use networking daemon instead of XPC service
1613         https://bugs.webkit.org/show_bug.cgi?id=194427
1614
1615         Reviewed by Geoffrey Garen
1616
1617         * MiniBrowser/MiniBrowser.entitlements:
1618
1619 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1620
1621         [ews-build] Ensure that every builder in config.json has short name
1622         https://bugs.webkit.org/show_bug.cgi?id=194461
1623
1624         Reviewed by Lucas Forschler.
1625
1626         * BuildSlaveSupport/ews-build/loadConfig.py:
1627         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1628
1629 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1630
1631         [ews-build] Add short name to config.json
1632         https://bugs.webkit.org/show_bug.cgi?id=194456
1633
1634         Reviewed by Lucas Forschler.
1635
1636         * BuildSlaveSupport/ews-build/config.json: Added short name.
1637         * BuildSlaveSupport/ews-build/loadConfig.py:
1638         (loadBuilderConfig): Set the short name as the builder description.
1639
1640 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1641
1642         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1643         https://bugs.webkit.org/show_bug.cgi?id=194418
1644
1645         Reviewed by Lucas Forschler.
1646
1647         Do not include errors trying when finding crashlogs at the end of
1648         a run-webkit-tests run since we don't process those errors.
1649
1650         * Scripts/webkitpy/port/darwin.py:
1651         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1652         * Scripts/webkitpy/port/ios_device.py:
1653         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1654         * Scripts/webkitpy/port/watch_device.py:
1655         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1656
1657 2019-02-08  Beth Dakin  <bdakin@apple.com>
1658
1659         Add afterScreenUpdates to WKSnapshotConfiguration
1660         https://bugs.webkit.org/show_bug.cgi?id=194362
1661         -and corresponding-
1662         <rdar://problem/40655528> Please add an "after screen updates" property to 
1663         WKSnapshotConfiguration (to solve blank snapshots)
1664
1665         Reviewed by Tim Horton.
1666
1667         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1668         (TEST):
1669
1670 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1671
1672         clampTo(): do not convert the input to double when dealing with integers
1673         https://bugs.webkit.org/show_bug.cgi?id=194263
1674         <rdar://problem/47692312>
1675
1676         Reviewed by Darin Adler.
1677
1678         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1679         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1680         (TestWebKitAPI::testClampFloatingPointToInteger):
1681         (TestWebKitAPI::testClampSameSignIntegers):
1682         (TestWebKitAPI::testClampUnsignedToSigned):
1683         (TestWebKitAPI::testClampSignedToUnsigned):
1684
1685 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1686
1687         webkitpy: Respect --dedicated-simulators flag
1688         https://bugs.webkit.org/show_bug.cgi?id=194416
1689         <rdar://problem/47894722>
1690
1691         Reviewed by Lucas Forschler.
1692
1693         * Scripts/webkitpy/port/device_port.py:
1694         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1695         available devices can be safely ignored.
1696
1697 2019-02-07  Keith Rollin  <krollin@apple.com>
1698
1699         Remove extra copy of 100x100-red.tga
1700         https://bugs.webkit.org/show_bug.cgi?id=194371
1701         <rdar://problem/47873465>
1702
1703         Reviewed by Said Abou-Hallawa.
1704
1705         In order to help it pass its tests, Bug 194190 added a second copy of
1706         the file 100x100-red.tga. However, it turns out that this additional
1707         file wasn't actually needed, and that that sole previous copy was
1708         sufficient. At the same time, this second copy -- which was copied to
1709         the same location in the build output as the first copy -- now caused
1710         XCBuild to complain because there were two production rules for the
1711         same output file. Address this by removing the newly-added extra copy.
1712
1713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1714         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1715
1716 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1717
1718         Deprecate WKBundlePageSetDefersLoading
1719         https://bugs.webkit.org/show_bug.cgi?id=191394
1720
1721         Reviewed by Dean Jackson.
1722
1723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1724         (WTR::TestRunner::setDefersLoading):
1725
1726 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1727
1728         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1729         https://bugs.webkit.org/show_bug.cgi?id=194391
1730
1731         Reviewed by Antti Koivisto.
1732
1733         * LayoutReloaded/misc/LFC-passing-tests.txt:
1734
1735 2019-02-06  Keith Rollin  <krollin@apple.com>
1736
1737         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1738         https://bugs.webkit.org/show_bug.cgi?id=193975
1739         <rdar://problem/47643306>
1740
1741         Reviewed by Tim Horton.
1742
1743         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1744         the Info.plist file into the bundle. This step is not necessary as the
1745         implicit "bundle up all the build products into a framework" build
1746         phase does this already. Having the Copy Bundle Resources phase do
1747         this causes a conflict under XCBuild, which objects to two build
1748         phases producing the same file (Info.plist). Address this by removing
1749         Info.plist from the Copy Bundle Resources phase.
1750
1751         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1752
1753 2019-02-06  Keith Rollin  <krollin@apple.com>
1754
1755         Really enable the automatic checking and regenerations of .xcfilelists during builds
1756         https://bugs.webkit.org/show_bug.cgi?id=194357
1757         <rdar://problem/47861231>
1758
1759         Reviewed by Chris Dumez.
1760
1761         Bug 194124 was supposed to enable the automatic checking and
1762         regenerating of .xcfilelist files during the build. While related
1763         changes were included in that patch, the change to actually enable the
1764         operation somehow was omitted. This patch actually enables the
1765         operation. The check-xcfilelist.sh scripts now check
1766         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1767         from the checking.
1768
1769         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1770         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1771
1772 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1773
1774         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1775         <https://webkit.org/b/194286>
1776         <rdar://problem/47815558>
1777
1778         Reviewed by Alexey Proskuryakov.
1779
1780         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1781         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1782         WKRetainPtr<> to avoid leaking the WKDataRef.
1783
1784 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1785
1786         Unreviewed, fix a typo
1787
1788         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1789
1790 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1791
1792         [GTK][WPE] force libpsl build to use ICU in jhbuild
1793         https://bugs.webkit.org/show_bug.cgi?id=194288
1794
1795         Reviewed by Carlos Garcia Campos.
1796
1797         * gtk/jhbuild.modules:
1798         Require ICU for libpsl build in jhbuild, like done in WPE.
1799
1800 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1801
1802         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1803         https://bugs.webkit.org/show_bug.cgi?id=194209
1804
1805         Reviewed by Carlos Garcia Campos.
1806
1807         Enhance TestCookieManager to ensure this doesn't happen again.
1808
1809         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1810         (testCookieManagerPersistentStorage):
1811         (beforeAll):
1812
1813 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1814
1815         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1816         https://bugs.webkit.org/show_bug.cgi?id=194324
1817
1818         Reviewed by Andy Estes.
1819
1820         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1821         part of the name is already implicit, since this is in testing code in TestOptions.
1822
1823         * WebKitTestRunner/TestController.cpp:
1824         (WTR::TestController::generateContextConfiguration const):
1825         (WTR::updateTestOptionsFromTestHeader):
1826         * WebKitTestRunner/TestOptions.h:
1827         (WTR::TestOptions::hasSameInitializationOptions const):
1828
1829 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1830
1831         [ews-build] Allow * as platform for builders and workers
1832         https://bugs.webkit.org/show_bug.cgi?id=188533
1833
1834         Reviewed by Lucas Forschler.
1835
1836         * BuildSlaveSupport/ews-build/loadConfig.py:
1837         (checkWorkersAndBuildersForConsistency):
1838
1839 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1840
1841         [ews-build] Add few bots to config.json
1842         https://bugs.webkit.org/show_bug.cgi?id=194304
1843
1844         Reviewed by Lucas Forschler.
1845
1846         * BuildSlaveSupport/ews-build/config.json:
1847
1848 2019-02-05  Keith Rollin  <krollin@apple.com>
1849
1850         Enable the automatic checking and regenerations of .xcfilelists during builds
1851         https://bugs.webkit.org/show_bug.cgi?id=194124
1852         <rdar://problem/47721277>
1853
1854         Reviewed by Tim Horton.
1855
1856         Bug 193790 add a facility for checking -- during build time -- that
1857         any needed .xcfilelist files are up-to-date and for updating them if
1858         they are not. This facility was initially opt-in by setting
1859         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1860         the process seemed robust. Its now time to enable this facility and
1861         make it opt-out. If there is a need to disable this facility, set and
1862         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1863         running `make` or `build-webkit`, or before running Xcode from the
1864         command line.
1865
1866         Additionally, remove the step that generates a list of source files
1867         going into the UnifiedSources build step. It's only necessarily to
1868         specify Sources.txt and SourcesCocoa.txt as inputs.
1869
1870         * Scripts/generate-xcfilelists:
1871
1872 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1873
1874         [GTK][WPE] force libpsl build to use ICU in jhbuild
1875         https://bugs.webkit.org/show_bug.cgi?id=194288
1876
1877         Reviewed by Philippe Normand.
1878
1879         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1880         This can cause build failures if libidn is detected but libunistring is not available.
1881
1882         Make sure that ICU is used for runtime and builtin PSL data.
1883
1884         * gtk/jhbuild.modules:
1885         * wpe/jhbuild.modules:
1886
1887 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1888
1889         [ews-app] Modified timestamp should be updated on updating data
1890         https://bugs.webkit.org/show_bug.cgi?id=194295
1891
1892         Reviewed by Lucas Forschler.
1893
1894         * BuildSlaveSupport/ews-app/ews/models/build.py:
1895         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1896         * BuildSlaveSupport/ews-app/ews/models/step.py:
1897
1898 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1899
1900         Unreviewed, rolling out r240742.
1901
1902         Causes crashes on iOS simulator.
1903
1904         Reverted changeset:
1905
1906         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1907         not focused in a content-editable element"
1908         https://bugs.webkit.org/show_bug.cgi?id=192824
1909         https://trac.webkit.org/changeset/240742
1910
1911 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1912
1913         run-webkit-tests emits message "...running None" when running tests
1914         https://bugs.webkit.org/show_bug.cgi?id=194133
1915         <rdar://problem/47724738>
1916
1917         Reviewed by Lucas Forschler.
1918
1919         * Scripts/webkitpy/xcode/device_type.py:
1920         (DeviceType.__str__): Use both version mapping tables and use just the variant
1921         name if no version name is available.
1922         * Scripts/webkitpy/xcode/device_type_unittest.py:
1923         (DeviceTypeTest):
1924         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1925         an associated named.
1926
1927 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1928
1929         [WPE] require python3-setuptools for meson build in jhbuild
1930         https://bugs.webkit.org/show_bug.cgi?id=194287
1931
1932         Reviewed by Philippe Normand.
1933
1934         python3-setuptools is needed to build meson in jhbuild.
1935         It is already required by the GTK port.
1936
1937         * wpe/install-dependencies:
1938
1939 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1940
1941         [ews-app] Add method to save BuilderMapping to database
1942         https://bugs.webkit.org/show_bug.cgi?id=194264
1943
1944         Reviewed by Lucas Forschler.
1945
1946         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1947         (BuilderMapping.__str__):
1948         (BuilderMapping):
1949         (BuilderMapping.save_mapping):
1950         (BuilderMapping.update_mapping):
1951         (BuilderMapping.get_existing_mapping):
1952         (BuilderMapping.is_valid_mapping):
1953
1954 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1955
1956         [ews-app] Add timestamp fields for BuilderMappings
1957         https://bugs.webkit.org/show_bug.cgi?id=194266
1958
1959         Reviewed by Lucas Forschler.
1960
1961         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1962         (BuilderMapping):
1963
1964 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1965
1966         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1967         https://bugs.webkit.org/show_bug.cgi?id=174816
1968
1969         Reviewed by Michael Catanzaro.
1970
1971         Add tests for webkit_uri_for_display().
1972
1973         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1974         (testURIForDisplayUnaffected):
1975         (testURIForDisplayAffected):
1976         (beforeAll):
1977         (afterAll):
1978         * TestWebKitAPI/glib/CMakeLists.txt:
1979
1980 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1981
1982         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1983         https://bugs.webkit.org/show_bug.cgi?id=194158
1984         <rdar://problem/47737268>
1985
1986         Rubber-stamped by Aakash Jain.
1987
1988         * Scripts/webkitpy/port/device_port.py:
1989         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1990
1991 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1992
1993         [CG] Enable setAdditionalSupportedImageTypes for WK1
1994         https://bugs.webkit.org/show_bug.cgi?id=194190
1995
1996         Reviewed by Tim Horton.
1997
1998         Add a test similar to the one under WebKit Cocoa but make it create a
1999         WebView instead of a WKWebView.
2000
2001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2002         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2003         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2004         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2005         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2006         (TestWebKitAPI::runTest):
2007         (TestWebKitAPI::TEST):
2008
2009 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2010
2011         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2012         https://bugs.webkit.org/show_bug.cgi?id=194168
2013
2014         Reviewed by Simon Fraser.
2015
2016         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2017
2018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2019         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2020         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2021         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2022         (TEST):
2023         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2024         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2025
2026 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2027
2028         REGRESSION (r237269): webkit-patch what-broke is broken 
2029         https://bugs.webkit.org/show_bug.cgi?id=193025
2030
2031         Reviewed by Aakash Jain.
2032
2033         * Scripts/webkitpy/common/host.py:
2034         (Host.buildbot):
2035         (Host.bugzilla): Renamed to 'buildbot'.
2036
2037 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2038
2039         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2040         https://bugs.webkit.org/show_bug.cgi?id=194207
2041
2042         Reviewed by Tim Horton.
2043
2044         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2045         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2046         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2047         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2048         start and delete forwards to remove the original attachment.
2049
2050         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2051         (TestWebKitAPI::TEST):
2052
2053 2019-02-04  Youenn Fablet  <youenn@apple.com>
2054
2055         Capture state should be managed consistently when doing process swapping
2056         https://bugs.webkit.org/show_bug.cgi?id=194122
2057         <rdar://problem/47609293>
2058
2059         Reviewed by Eric Carlson.
2060
2061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2062         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2063         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2064         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2065         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2067         (WTR::TestRunner::isDoingMediaCapture const):
2068         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2069         * WebKitTestRunner/TestController.cpp:
2070         (WTR::TestController::isDoingMediaCapture const):
2071         * WebKitTestRunner/TestController.h:
2072         * WebKitTestRunner/TestInvocation.cpp:
2073         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2074         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2075         (WTR::TestController::isDoingMediaCapture const):
2076
2077 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2078
2079         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2080         https://bugs.webkit.org/show_bug.cgi?id=194142
2081
2082         Reviewed by Ross Kirsling.
2083
2084         There three 'separator' variables in TestController.cpp. Renamed
2085         it 'pathSeparator', and unified them.
2086
2087         * WebKitTestRunner/TestController.cpp:
2088         (WTR::TestController::generateContextConfiguration const):
2089         (WTR::createTestURL):
2090         (WTR::TestController::platformAdjustContext):
2091
2092 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2093
2094         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2095         https://bugs.webkit.org/show_bug.cgi?id=194198
2096
2097         Reviewed by Antti Koivisto.
2098
2099         No need to set the banner heights on navigation now, since Page stores them.
2100
2101         * MiniBrowser/mac/WK2BrowserWindowController.m:
2102         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2103
2104 2019-02-03  John Wilander  <wilander@apple.com>
2105
2106         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2107         https://bugs.webkit.org/show_bug.cgi?id=194104
2108         <rdar://problem/47649991>
2109
2110         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2111
2112         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2113         (TestWebKitAPI::TEST):
2114             Changed numeric types from unsigned short to uint32_t.
2115
2116 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2117
2118         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2119         <https://webkit.org/b/194178>
2120         <rdar://problem/47753473>
2121
2122         Reviewed by Alexey Proskuryakov.
2123
2124         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2125         (WTR::uninstallFakeHelvetica): Pass nullptr into
2126         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2127
2128 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2129
2130         [LFC] Initialize ICB's style with fixed width/height.
2131         https://bugs.webkit.org/show_bug.cgi?id=194188
2132
2133         Reviewed by Antti Koivisto.
2134
2135         * LayoutReloaded/misc/LFC-passing-tests.txt:
2136
2137 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2138
2139         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2140         https://bugs.webkit.org/show_bug.cgi?id=194185
2141
2142         Reviewed by Antti Koivisto.
2143
2144         * LayoutReloaded/misc/LFC-passing-tests.txt:
2145
2146 2018-12-16  Darin Adler  <darin@apple.com>
2147
2148         Convert additional String::format clients to alternative approaches
2149         https://bugs.webkit.org/show_bug.cgi?id=192746
2150
2151         Reviewed by Alexey Proskuryakov.
2152
2153         * WebKitTestRunner/TestController.cpp:
2154         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2155         as an intermediate in code that ultimately constructs a WTF::String.
2156         (WTR::userMediaOriginHash): Use makeString.
2157         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2158         (WTR::TestController::didPerformClientRedirect): Ditto.
2159         (WTR::TestController::didPerformServerRedirect): Ditto.
2160         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2161
2162 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2163
2164         [ews-build] Add unit test to verify builder keys
2165         https://bugs.webkit.org/show_bug.cgi?id=194152
2166
2167         Reviewed by Lucas Forschler.
2168
2169         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2170         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2171
2172 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2173
2174         [LFC] Expand tests coverage (12 new tests -> 787)
2175
2176         Unreviewed test gardening.
2177
2178         * LayoutReloaded/misc/LFC-passing-tests.txt:
2179
2180 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2181
2182         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2183         https://bugs.webkit.org/show_bug.cgi?id=194163
2184
2185         Reviewed by Simon Fraser.
2186
2187         775
2188
2189         * LayoutReloaded/misc/LFC-passing-tests.txt:
2190
2191 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2192
2193         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2194         https://bugs.webkit.org/show_bug.cgi?id=194140
2195         <rdar://problem/47728098>
2196
2197         Reviewed by Tim Horton.
2198
2199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2201         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2202
2203         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2204         test to induce an IPC deadlock when presenting a modal alert during touch start.
2205
2206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2207         * WebKitTestRunner/TestController.cpp:
2208         (WTR::runJavaScriptAlert):
2209
2210         Add a client callback function for running JavaScript alerts.
2211
2212         (WTR::TestController::createOtherPage):
2213         (WTR::TestController::generateContextConfiguration const):
2214
2215         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2216         the fix in this patch.
2217
2218         (WTR::TestController::createWebViewWithOptions):
2219
2220         Plumb TestOptions to generateContextConfiguration.
2221
2222         (WTR::TestController::resetPreferencesToConsistentValues):
2223         (WTR::TestController::resetStateToConsistentValues):
2224         (WTR::updateTestOptionsFromTestHeader):
2225         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2226         (WTR::TestController::handleJavaScriptAlert):
2227         * WebKitTestRunner/TestController.h:
2228         * WebKitTestRunner/TestInvocation.cpp:
2229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2230         * WebKitTestRunner/TestOptions.h:
2231         (WTR::TestOptions::hasSameInitializationOptions const):
2232
2233 2019-02-01  Chris Dumez  <cdumez@apple.com>
2234
2235         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2236         https://bugs.webkit.org/show_bug.cgi?id=193740
2237         <rdar://problem/47527267>
2238
2239         Reviewed by Alex Christensen.
2240
2241         Add API test coverage.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2244
2245 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2246
2247         [ews-app] Add display name field to BuilderMapping model
2248         https://bugs.webkit.org/show_bug.cgi?id=194153
2249
2250         Reviewed by Lucas Forschler.
2251
2252         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2253         (BuilderMapping):
2254
2255 2019-02-01  Youenn Fablet  <youenn@apple.com>
2256
2257         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2258         https://bugs.webkit.org/show_bug.cgi?id=194155
2259
2260         Reviewed by Eric Carlson.
2261
2262         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2263         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2264         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2265
2266 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2267
2268         [LFC] Adjust replaced element's intrinsic ratio
2269         https://bugs.webkit.org/show_bug.cgi?id=194154
2270
2271         Reviewed by Antti Koivisto.
2272
2273         761
2274
2275         * LayoutReloaded/misc/LFC-passing-tests.txt:
2276
2277 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2278
2279         [WPE] Show test results in minibrowser
2280         https://bugs.webkit.org/show_bug.cgi?id=194150
2281
2282         Reviewed by Žan Doberšek.
2283
2284         * Scripts/webkitpy/port/wpe.py:
2285         (WPEPort.show_results_html_file):
2286
2287 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2288
2289         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2290         https://bugs.webkit.org/show_bug.cgi?id=194151
2291
2292         Reviewed by Žan Doberšek.
2293
2294         ALT + <- go back
2295         ALT + -> go forward
2296
2297         * MiniBrowser/wpe/main.cpp:
2298         (main):
2299
2300 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2301
2302         [LFC] Set intrinsic size on Layout::Replaced
2303         https://bugs.webkit.org/show_bug.cgi?id=194139
2304
2305         Reviewed by Antti Koivisto.
2306
2307         744
2308
2309         * LayoutReloaded/misc/LFC-passing-tests.txt:
2310
2311 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2312
2313         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2314         https://bugs.webkit.org/show_bug.cgi?id=194146
2315
2316         Reviewed by Xabier Rodriguez-Calvar.
2317
2318         It allows to open relative paths.
2319
2320         * MiniBrowser/wpe/main.cpp:
2321         (main):
2322
2323 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2324
2325         Update flakiness dashboard configuration after recent queue changes
2326         https://bugs.webkit.org/show_bug.cgi?id=194127
2327
2328         Rubber-stamped by Aakash Jain.
2329
2330         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2331
2332         * TestResultServer/static-dashboards/builders.jsonp:
2333
2334 2019-01-31  Youenn Fablet  <youenn@apple.com>
2335
2336         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2337         https://bugs.webkit.org/show_bug.cgi?id=194106
2338         <rdar://problem/47676333>
2339
2340         Reviewed by Ryosuke Niwa.
2341
2342         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2343         (TestWebKitAPI::didFinishNavigation):
2344         (TestWebKitAPI::TEST):
2345         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2346
2347 2019-01-31  Chris Dumez  <cdumez@apple.com>
2348
2349         Page zoom level is lost after a process swap or a crash
2350         https://bugs.webkit.org/show_bug.cgi?id=194105
2351         <rdar://problem/47610781>
2352
2353         Reviewed by Alex Christensen.
2354
2355         Add API test coverage.
2356
2357         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2358         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2359
2360 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2361
2362         Revert r238819 which is unneeded and caused a performance regression.
2363         https://bugs.webkit.org/show_bug.cgi?id=192272
2364         <rdar://problem/46664625>
2365
2366         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2367         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2368         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2369
2370 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2371
2372         Formalize WebKitAdditions mechanism of LoadOptimizer
2373         https://bugs.webkit.org/show_bug.cgi?id=193886
2374         <rdar://problem/47696809>
2375
2376         Reviewed by Brent Fulgham.
2377
2378         * MiniBrowser/MiniBrowser.entitlements:
2379         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2380
2381 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2382
2383         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2384         https://bugs.webkit.org/show_bug.cgi?id=194090
2385
2386         Reviewed by Antti Koivisto.
2387
2388         * LayoutReloaded/misc/LFC-passing-tests.txt:
2389
2390 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2391
2392         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2393         https://bugs.webkit.org/show_bug.cgi?id=194074
2394
2395         Reviewed by Antti Koivisto.
2396
2397         * LayoutReloaded/misc/LFC-passing-tests.txt:
2398
2399 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2400
2401         [LFC][BFC] Add support for block level replaced box.
2402         https://bugs.webkit.org/show_bug.cgi?id=194071
2403
2404         Reviewed by Antti Koivisto.
2405
2406         * LayoutReloaded/misc/LFC-passing-tests.txt:
2407
2408 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2409
2410         Fix WebKitTestRunner's testPath with Windows full paths
2411         https://bugs.webkit.org/show_bug.cgi?id=194012
2412
2413         Reviewed by Alex Christensen.
2414
2415         updateTestOptionsFromTestHeader failed to open test files because
2416         testPath returned wrong file paths. It returned a path "/C:/..."
2417         if a URL "file:///C:/..." was given.
2418
2419         * WebKitTestRunner/TestController.cpp:
2420         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2421
2422 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2423
2424         [WPE] Bump font related dependencies to match the GTK+ port
2425         https://bugs.webkit.org/show_bug.cgi?id=194017
2426
2427         Reviewed by Žan Doberšek.
2428
2429         * wpe/jhbuild.modules:
2430         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2431         * wpe/patches/icudata-stdlibs.patch: Added.
2432
2433 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2434
2435         Enable swipe tests on iOS
2436         https://bugs.webkit.org/show_bug.cgi?id=194076
2437
2438         Reviewed by Geoffrey Garen.
2439
2440         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2441         it causes a debug assertion failure in runUIScript.
2442
2443         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2444         (WTR::UIScriptController::beginBackSwipe):
2445         (WTR::UIScriptController::completeBackSwipe):
2446
2447 2019-01-30  Keith Rollin  <krollin@apple.com>
2448
2449         Use correct printf format specifier
2450         https://bugs.webkit.org/show_bug.cgi?id=194062
2451         <rdar://problem/47686167>
2452
2453         Reviewed by Alexey Proskuryakov.
2454
2455         LayoutTestSpellChecker.mm is trying to format a variable of type
2456         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2457         actually an unsigned long long. Fix this by formatting with %llu.
2458
2459         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2460         (-[LayoutTestTextCheckingResult description]):
2461
2462 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2463
2464         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2465         https://bugs.webkit.org/show_bug.cgi?id=193979
2466
2467         Reviewed by Wenson Hsieh.
2468
2469         Fix the test for iOS. Make the test work with iOS UA string.
2470
2471         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2472
2473 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2474
2475         Replace High Sierra LLINT CLoop bot due to hardware failure
2476         https://bugs.webkit.org/show_bug.cgi?id=194066
2477
2478         Reviewed by Aakash Jain.
2479
2480         * BuildSlaveSupport/build.webkit.org-config/config.json:
2481
2482 2019-01-30  Keith Rollin  <krollin@apple.com>
2483
2484         [NSDragItem init] is unavailable
2485         https://bugs.webkit.org/show_bug.cgi?id=194059
2486         <rdar://problem/47685715>
2487
2488         Reviewed by Wenson Hsieh.
2489
2490         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2491         DumpRenderTree and TestWebKitAPI, which both try to create an
2492         NSDragItem in a manner that invokes this method. Address this by using
2493         -initWithPasteboardWriter instead.
2494
2495         Note that the parameter passed to initWithPasteboardWriter is likely
2496         incorrect. In both cases, the object passed does not conform to
2497         NSPasteboardWriting. However, with this fix, we're no worse off than
2498         before, and can now perform builds with newer compilers and SDKs until
2499         a real fix can be crafted. That work is tracked in
2500         https://bugs.webkit.org/show_bug.cgi?id=194060
2501
2502         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2503         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2504         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2505         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2506
2507 2019-01-30  Daniel Bates  <dabates@apple.com>
2508
2509         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2510         https://bugs.webkit.org/show_bug.cgi?id=192824
2511         <rdar://problem/47100332>
2512
2513         Reviewed by Wenson Hsieh.
2514
2515         Fix a bug where the wrong usage code was used for F13 thru F24.
2516
2517         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2518         (keyCodeForDOMFunctionKey):
2519
2520 2019-01-30  Chris Dumez  <cdumez@apple.com>
2521
2522         Regression(PSON) Load hang can occur on history navigation
2523         https://bugs.webkit.org/show_bug.cgi?id=194030
2524         <rdar://problem/47656939>
2525
2526         Reviewed by Antti Koivisto.
2527
2528         Add API test coverage.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2531
2532 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2533
2534         [LFC] Expand tests coverage.
2535
2536         Unreviewed test gardening.
2537
2538         * LayoutReloaded/misc/LFC-passing-tests.txt:
2539
2540 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2541
2542         [Flatpak] Add openjpeg support
2543         https://bugs.webkit.org/show_bug.cgi?id=194019
2544
2545         Reviewed by Michael Catanzaro.
2546
2547         * flatpak/org.webkit.CommonModules.yaml:
2548
2549 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2550
2551         Unreviewed, rolling out r240708.
2552         https://bugs.webkit.org/show_bug.cgi?id=194022
2553
2554         It broke WPE build (Requested by KaL on #webkit).
2555
2556         Reverted changeset:
2557
2558         "[WPE] Bump font related dependencies to match the GTK+ port"
2559         https://bugs.webkit.org/show_bug.cgi?id=194017
2560         https://trac.webkit.org/changeset/240708
2561
2562 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2563
2564         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2565         https://bugs.webkit.org/show_bug.cgi?id=194001
2566
2567         Reviewed by Antti Koivisto.
2568
2569         * LayoutReloaded/misc/LFC-passing-tests.txt:
2570
2571 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2572
2573         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2574         https://bugs.webkit.org/show_bug.cgi?id=194020
2575
2576         Reviewed by Antti Koivisto.
2577
2578         * LayoutReloaded/misc/LFC-passing-tests.txt:
2579
2580 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2581
2582         AX: Support color well on iOS
2583         https://bugs.webkit.org/show_bug.cgi?id=194010
2584
2585         Reviewed by Joanmarie Diggs.
2586
2587         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2588         (WTR::AccessibilityUIElement::stringAttributeValue):
2589
2590 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2591
2592         [WPE] Bump font related dependencies to match the GTK+ port
2593         https://bugs.webkit.org/show_bug.cgi?id=194017
2594
2595         Reviewed by Žan Doberšek.
2596
2597         * wpe/jhbuild.modules:
2598         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2599         * wpe/patches/icudata-stdlibs.patch: Added.
2600
2601 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2602
2603         [Mac] Update window scale API usage
2604         https://bugs.webkit.org/show_bug.cgi?id=193991
2605         rdar://problem/47614795
2606
2607         Reviewed by Tim Horton.
2608
2609         * DumpRenderTree/mac/DumpRenderTree.mm:
2610         (changeWindowScaleIfNeeded):
2611         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2612         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2613         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2614
2615 2019-01-29  Chris Dumez  <cdumez@apple.com>
2616
2617         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2618         https://bugs.webkit.org/show_bug.cgi?id=193977
2619         <rdar://problem/47643716>
2620
2621         Reviewed by Geoff Garen.
2622
2623         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2624         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2625         to the previous provisional committing *before* we make the last load. 
2626
2627         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2628
2629 2019-01-29  Youenn Fablet  <youenn@apple.com>
2630
2631         Adopt new SPI to evaluate server certificate trust
2632         https://bugs.webkit.org/show_bug.cgi?id=193355
2633
2634         Reviewed by Alex Christensen.
2635
2636         Add infrastructure to handle HTTPS server trust evaluation testing.
2637
2638         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2639         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2640         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2641         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2642         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2644         * WebKitTestRunner/TestController.cpp:
2645         (WTR::TestController::resetPreferencesToConsistentValues):
2646         (WTR::TestController::didReceiveAuthenticationChallenge):
2647         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2648         * WebKitTestRunner/TestController.h:
2649         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2650         * WebKitTestRunner/TestInvocation.cpp:
2651         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2652         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2653         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2654
2655 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2656
2657         [ews-build] Add build step to print bot Configuration
2658         https://bugs.webkit.org/show_bug.cgi?id=193887
2659
2660         Reviewed by Lucas Forschler.
2661
2662         * BuildSlaveSupport/ews-build/steps.py:
2663         (PrintConfiguration): Build step to print configuration.
2664         * BuildSlaveSupport/ews-build/factories.py:
2665
2666 2019-01-29  Chris Dumez  <cdumez@apple.com>
2667
2668         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2669         https://bugs.webkit.org/show_bug.cgi?id=193967
2670         <rdar://problem/47635348>
2671
2672         Reviewed by Alex Christensen.
2673
2674         Add API test coverage.
2675
2676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2677         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2678
2679 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2680
2681         [ews-app] Handle incoming results data
2682         https://bugs.webkit.org/show_bug.cgi?id=193973
2683
2684         Reviewed by Lucas Forschler.
2685
2686         * BuildSlaveSupport/ews-app/ews/views/results.py:
2687
2688 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2689
2690         [ews-app] Make the results url generic
2691         https://bugs.webkit.org/show_bug.cgi?id=193928
2692
2693         Reviewed by Lucas Forschler.
2694
2695         * BuildSlaveSupport/ews-app/ews/urls.py:
2696
2697 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2698
2699         [ews-build] Configure buildbot to send events to ews-app
2700         https://bugs.webkit.org/show_bug.cgi?id=193968
2701
2702         Reviewed by Lucas Forschler.
2703
2704         * BuildSlaveSupport/ews-build/events.py: Added.
2705         * BuildSlaveSupport/ews-build/master.cfg:
2706
2707 2019-01-29  Keith Rollin  <krollin@apple.com>
2708
2709         Add .xcfilelists to Run Script build phases
2710         https://bugs.webkit.org/show_bug.cgi?id=193792
2711         <rdar://problem/47201785>
2712
2713         Reviewed by Alex Christensen.
2714
2715         As part of supporting XCBuild, update the necessary Run Script build
2716         phases in their Xcode projects to refer to their associated
2717         .xcfilelist files.
2718
2719         Note that the addition of these files bumps the Xcode project version
2720         number to something that's Xcode 10 compatible. This change means that
2721         older versions of the Xcode IDE can't read these projects. Nor can it
2722         fully load workspaces that refer to these projects (the updated
2723         projects are shown as non-expandable placeholders). `xcodebuild` can
2724         still build these projects; it's just that the IDE can't open them.
2725
2726         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2727         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2728
2729 2019-01-29  John Wilander  <wilander@apple.com>
2730
2731         Add data abstraction and validation for Ad Click Attribution
2732         https://bugs.webkit.org/show_bug.cgi?id=193916
2733         <rdar://problem/47603481>
2734
2735         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2736
2737         Ad click attribution has two steps. First, the storage of an ad
2738         campaign ID for a click that takes the user to a destination
2739         site. Second, a conversion on the destination site that can be
2740         attributed to the ad click.
2741
2742         This patch adds a class that represents a request for ad click
2743         attribution. Validation makes sure that the bits of entropy
2744         reported through this mechanism is limited.
2745
2746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2747         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2748         (TestWebKitAPI::TEST):
2749
2750 2019-01-29  Chris Dumez  <cdumez@apple.com>
2751
2752         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2753         https://bugs.webkit.org/show_bug.cgi?id=193932
2754         <rdar://problem/47598947>
2755
2756         Reviewed by Brady Eidson.
2757
2758         Add API test coverage.
2759
2760         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2761
2762 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2763
2764         Adding new passing LFC tests.
2765
2766         Unreviewed test gardening.
2767
2768         * LayoutReloaded/misc/LFC-passing-tests.txt:
2769
2770 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2771
2772         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2773         https://bugs.webkit.org/show_bug.cgi?id=193964
2774
2775         Reviewed by Antti Koivisto.
2776
2777         * LayoutReloaded/misc/LFC-passing-tests.txt:
2778
2779 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2780
2781         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2782         https://bugs.webkit.org/show_bug.cgi?id=193954
2783
2784         Reviewed by Antti Koivisto.
2785
2786         * LayoutReloaded/misc/LFC-passing-tests.txt:
2787
2788 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2789
2790         WebDriver: add support for running subtests
2791         https://bugs.webkit.org/show_bug.cgi?id=193904
2792
2793         Reviewed by Michael Catanzaro.
2794
2795         pytest already supports it by passing test.py::subtest, so we can do the same.
2796
2797         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2798         (get_item_name): Made this global.
2799         (CollectRecorder.__init__): Receive the parameter to ignore.
2800         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2801         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2802         (collect): Add parameter to ignore.
2803         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2804         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2805         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2806         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2807         (WebDriverTestRunnerSelenium.run): Ditto.
2808         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2809         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2810         (WebDriverTestRunnerW3C.run): Ditto.
2811
2812 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2813
2814         User agent string override for navigator.userAgent should be site specific quirks
2815         https://bugs.webkit.org/show_bug.cgi?id=193950
2816
2817         Reviewed by Brent Fulgham.
2818
2819         Updated per the _WKWebsitePolicies rename.
2820
2821         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2822         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2823
2824 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2825
2826         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2827         https://bugs.webkit.org/show_bug.cgi?id=193941
2828
2829         Reviewed by Alex Christensen.
2830
2831         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2832         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2833         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2834         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2835         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2836         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2837         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2838         * TestWebKitAPI/Tests/WTF/Time.cpp:
2839         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2840         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2841         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2842         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2843
2844 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2845
2846         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2847
2848         * Scripts/webkitpy/common/config/contributors.json:
2849
2850 2019-01-28  Andy Estes  <aestes@apple.com>
2851
2852         [watchOS] Enable Parental Controls content filtering
2853         https://bugs.webkit.org/show_bug.cgi?id=193939
2854         <rdar://problem/46641912>
2855
2856         Reviewed by Ryosuke Niwa.
2857
2858         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2859
2860 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2861
2862         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2863         <https://webkit.org/b/193884>
2864
2865         Reviewed by Jiewen Tan.
2866
2867         * Scripts/webkitpy/style/checkers/cpp.py:
2868         (check_language): Add LocalAuthentication to
2869         `frameworks_with_soft_links`.
2870
2871 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2872
2873         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2874         https://bugs.webkit.org/show_bug.cgi?id=193891
2875
2876         Reviewed by Ross Kirsling.
2877
2878         There were three problems in window sizes of WebView and the host window.
2879         1. The sizes of pixel image output were incorrect.
2880         2. The host window is going to appear after window.resize was invoked.
2881         3. window.resize resized only the host window, not WebView.
2882
2883         This change solves them with a following approach.
2884         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2885         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2886            as well as DumpRenderTree in order to match the client area and the window area.
2887         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2888         d. PlatformWebView::setWindowFrame changes both window sizes.
2889         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2890
2891         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2892         (WTR::PlatformWebView::PlatformWebView): Create the host window
2893         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2894         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2895         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2896
2897 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-app] Add method to save Step data to database
2900         https://bugs.webkit.org/show_bug.cgi?id=193890
2901
2902         Reviewed by Lucas Forschler.
2903
2904         * BuildSlaveSupport/ews-app/ews/models/step.py:
2905         (Step.save_step): Method to save step data.
2906         (Step.update_step): Method to update step data.
2907         (Step.get_existing_step): Method to fetch existing step from database.
2908         (Step.is_valid_result): Method to validate valid step result.
2909
2910 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2911
2912         [ews-app] Add method to save Build data to database
2913         https://bugs.webkit.org/show_bug.cgi?id=193735
2914
2915         Reviewed by Lucas Forschler.
2916
2917         * BuildSlaveSupport/ews-app/ews/models/build.py:
2918         (Build.save_build): Method to save build information to database.
2919         (Build.get_existing_build): Method to fetch existing build from database.
2920         (Build.is_valid_result): Method to validate build result.
2921         * BuildSlaveSupport/ews-app/ews/common/util.py:
2922         (is_valid_int_id): Method to validate valid id.
2923
2924 2019-01-28  Chris Dumez  <cdumez@apple.com>
2925
2926         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2927         https://bugs.webkit.org/show_bug.cgi?id=193915
2928         <rdar://problem/47560907>
2929
2930         Reviewed by Alex Christensen.
2931
2932         Add API test coverage.
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2935
2936 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2937
2938         [ews-app] Rename id variables
2939         https://bugs.webkit.org/show_bug.cgi?id=193883
2940
2941         Reviewed by Lucas Forschler.
2942
2943         * BuildSlaveSupport/ews-app/ews/models/build.py:
2944         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2945         * BuildSlaveSupport/ews-app/ews/models/step.py:
2946         * BuildSlaveSupport/ews-app/ews/urls.py:
2947         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2948         * BuildSlaveSupport/ews-app/ews/views/results.py:
2949         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2950
2951 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2952
2953         [ews-app] Allow certain fields to be empty
2954         https://bugs.webkit.org/show_bug.cgi?id=193892
2955
2956         Reviewed by Lucas Forschler.
2957
2958         * BuildSlaveSupport/ews-app/ews/models/build.py:
2959         * BuildSlaveSupport/ews-app/ews/models/step.py:
2960
2961 2019-01-28  Rob Buis  <rbuis@igalia.com>
2962
2963         Update MIME type parser
2964         https://bugs.webkit.org/show_bug.cgi?id=180526
2965
2966         Reviewed by Frédéric Wang.
2967
2968         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2969         (TestWebKitAPI::TEST):
2970
2971 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2972
2973         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2974         https://bugs.webkit.org/show_bug.cgi?id=193896
2975
2976         Reviewed by Antti Koivisto.
2977
2978         * LayoutReloaded/misc/LFC-passing-tests.txt:
2979
2980 2018-12-15  Darin Adler  <darin@apple.com>
2981
2982         Replace many uses of String::format with more type-safe alternatives
2983         https://bugs.webkit.org/show_bug.cgi?id=192742
2984
2985         Reviewed by Mark Lam.
2986
2987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2988         (WTR::cacheTestRunnerCallback): Use makeString.
2989         * WebKitTestRunner/TestController.cpp:
2990         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2991         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2992
2993 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2994
2995         Use a load optimizer for some sites
2996         https://bugs.webkit.org/show_bug.cgi?id=193881
2997         <rdar://problem/46325455>
2998
2999         Reviewed by Brent Fulgham.
3000
3001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3002         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3003
3004 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3005
3006         AX: Introduce a static accessibility tree
3007         https://bugs.webkit.org/show_bug.cgi?id=193348
3008         <rdar://problem/47203295>
3009
3010         Reviewed by Ryosuke Niwa.
3011
3012         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3013
3014 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3015
3016         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3017         https://bugs.webkit.org/show_bug.cgi?id=193867
3018
3019         Reviewed by Antti Koivisto.
3020
3021         * LayoutReloaded/misc/LFC-passing-tests.txt:
3022
3023 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3024
3025         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3026         https://bugs.webkit.org/show_bug.cgi?id=193865
3027
3028         Reviewed by Antti Koivisto.
3029
3030         * LayoutReloaded/misc/LFC-passing-tests.txt:
3031
3032 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3033
3034         Need a mechanism to override navigator.userAgent
3035         https://bugs.webkit.org/show_bug.cgi?id=193762
3036         <rdar://problem/47504939>
3037
3038         Reviewed by Brent Fulgham.
3039
3040         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3041
3042         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3043         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3044         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3045
3046 2019-01-25  Dean Jackson  <dino@apple.com>
3047
3048         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3049         https://bugs.webkit.org/show_bug.cgi?id=193831
3050         <rdar://problem/47399263>
3051
3052         Reviewed by Chris Dumez.
3053
3054         Two new tests that exercise cross-origin and same-origin System
3055         Previews.
3056
3057         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3058
3059 2019-01-25  Keith Rollin  <krollin@apple.com>
3060
3061         Update Xcode projects with "Check .xcfilelists" build phase
3062         https://bugs.webkit.org/show_bug.cgi?id=193790
3063         <rdar://problem/47201374>
3064
3065         Reviewed by Alex Christensen.
3066
3067         Support for XCBuild includes specifying inputs and outputs to various
3068         Run Script build phases. These inputs and outputs are specified as
3069         .xcfilelist files. Once created, these .xcfilelist files need to be
3070         kept up-to-date. In order to check that they are up-to-date or not,
3071         add an Xcode build step that invokes an external script that performs
3072         the checking. If the .xcfilelists are found to be out-of-date, update
3073         them, halt the build, and instruct the developer to restart the build
3074         with up-to-date files.
3075
3076         At this time, the checking and regenerating is performed only if the
3077         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3078         who want to use this facility can set this variable and test out the
3079         checking/regenerating. Once it seems like there are no egregious
3080         issues that upset a developer's workflow, we'll unconditionally enable
3081         this facility.
3082
3083         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3084         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3085         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3086         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3087
3088 2019-01-25  Keith Rollin  <krollin@apple.com>
3089
3090         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3091         https://bugs.webkit.org/show_bug.cgi?id=193781
3092         <rdar://problem/47201153>
3093
3094         Reviewed by Alex Christensen.
3095
3096         Part of generating the .xcfilelists used as part of adopting XCBuild
3097         includes running `make DerivedSources.make` from a standalone script.
3098         It’s important for this invocation to have the same environment as
3099         when the actual build invokes `make DerivedSources.make`. If the
3100         environments are different, then the two invocations will provide
3101         different results. In order to get the same environment in the
3102         standalone script, have the script launch xcodebuild targeting the
3103         "Apply Configuration to XCFileLists" build target, which will then
3104         re-invoke our standalone script. The script is now running again, this
3105         time in an environment with all workspace, project, target, xcconfig
3106         and other environment variables established.
3107
3108         The "Apply Configuration to XCFileLists" build target accomplishes
3109         this task via a small embedded shell script that consists only of:
3110
3111             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3112
3113         The process that invokes "Apply Configuration to XCFileLists" first
3114         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3115         evaluated and exports it into the shell environment. When xcodebuild
3116         is invoked, it inherits the value of this variable and can `eval` the
3117         contents of that variable. Our external standalone script can then set
3118         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3119         of command-line parameters needed to restart itself in the appropriate
3120         state.
3121
3122         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3123         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3124
3125 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3126
3127         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3128         https://bugs.webkit.org/show_bug.cgi?id=193802
3129         <rdar://problem/46010580>
3130
3131         Reviewed by Andy Estes.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3134         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3135         (TEST):
3136
3137 2019-01-25  Daniel Bates  <dabates@apple.com>
3138
3139         [iOS] uiController.keyDown() does not translate Control modified key
3140         https://bugs.webkit.org/show_bug.cgi?id=192898
3141
3142         Reviewed by Wenson Hsieh.
3143
3144         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3145         key translation, as applicable. Among other cases, key translation occurs when performing
3146         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3147         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3148         human pressing down and releasing key(s) using a hardware keyboard.
3149
3150         * WebKitTestRunner/ios/HIDEventGenerator.h:
3151         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3152         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3153
3154         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3155         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3156         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3157         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3158         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3159         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3160         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3161         (-[HIDEventGenerator longPress:completionBlock:]):
3162         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3163         Update code for above renaming.
3164
3165         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3166         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3167
3168         (-[HIDEventGenerator keyDown:]): Added.
3169         (-[HIDEventGenerator keyUp:]): Added.
3170         (-[HIDEventGenerator keyPress:completionBlock:]):
3171         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3172         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3173         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3174         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3175         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3176         (WTR::parseModifier): Deleted.
3177
3178 2019-01-25  Keith Rollin  <krollin@apple.com>
3179
3180         Complete the implementation of generate-xcfilelists
3181         https://bugs.webkit.org/show_bug.cgi?id=193782
3182
3183         Reviewed by Alex Christensen.
3184
3185         A preliminary version of generate-xcfilelists was added in r238008.
3186         This patch updates that script in order to:
3187
3188         - Support checking of .xcfilelists
3189         - Perform better execution of `make DerivedSources.make` by
3190           relaunching generate-xcfilelists under xcodebuild
3191         - Support incremental generation and checking of .xcfilelists
3192         - Support supplementary .xcfilelists files from WebKitAdditions
3193         - Support being wrapped by parallel version of generate-xcfilelists in
3194           Internal that adds support for (re)generating WebKit projects in
3195           that repo.
3196         - Support builds that have been performed in WebKitBuild as well as
3197           ~/Library/Developer/code/DerivedData
3198         - Increase robustness and debugging facilities.
3199
3200         * Scripts/generate-xcfilelists:
3201
3202 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3203
3204         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3205         https://bugs.webkit.org/show_bug.cgi?id=193297
3206         <rdar://problem/47158841>
3207
3208         Unreviewed test case fix.
3209
3210         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3211         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3212
3213         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3214         (TEST):
3215
3216 2019-01-25  Keith Rollin  <krollin@apple.com>
3217
3218         Update existing .xcfilelists
3219         https://bugs.webkit.org/show_bug.cgi?id=193791
3220         <rdar://problem/47201706>
3221
3222         Reviewed by Alex Christensen.
3223
3224         Many .xcfilelist files were added in r238824 in order to support
3225         XCBuild. Update these with recent changes to the set of build files
3226         and with the current generate-xcfilelist script.
3227
3228         * DumpRenderTree/DerivedSources-input.xcfilelist:
3229         * DumpRenderTree/DerivedSources-output.xcfilelist:
3230         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3231         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3232
3233 2019-01-25  Keith Rollin  <krollin@apple.com>
3234
3235         Fix missing dependencies in extract-dependencies-from-makefile
3236         https://bugs.webkit.org/show_bug.cgi?id=193783
3237         <rdar://problem/47201571>
3238
3239         Reviewed by Alex Christensen.
3240
3241         The extract-dependencies-from-makefile script generates .xcfilelists
3242         for XCBuild by invoking a makefile in --debug mode, parsing the
3243         dependency information in the output, and extracting information
3244         regarding targets and dependents. However, the way `make` emits this
3245         dependency information is not rigorous, and so we need to determine
3246         what lines to look for and parse by trial and error. This approach
3247         didn't coriginally atch all the information we needed to collect, so
3248         update the script to look for the additional lines we now know to look
3249         for.
3250
3251         * Scripts/extract-dependencies-from-makefile:
3252         (Parser):
3253         (Parser.addTarget):
3254         (Parser.addPrereq):
3255         (Parser.doParse):
3256
3257 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3258
3259         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3260         https://bugs.webkit.org/show_bug.cgi?id=193297
3261         <rdar://problem/47158841>
3262
3263         Reviewed by Alex Christensen.
3264
3265         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3266             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3267         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3268         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3269         activating the message used to trigger the callback when it is set.
3270
3271 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3272
3273         WKWebView.goBack should reload if there is a safe browsing warning
3274         https://bugs.webkit.org/show_bug.cgi?id=193805
3275         <rdar://problem/46908216>
3276
3277         Reviewed by Geoff Garen.
3278
3279         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3280         (+[Simple3LookupContext sharedLookupContext]):
3281         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3282         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3283         (TEST):
3284
3285 2019-01-25  Chris Dumez  <cdumez@apple.com>
3286
3287         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3288         https://bugs.webkit.org/show_bug.cgi?id=193788
3289         <rdar://problem/47531231>
3290
3291         Reviewed by Alex Christensen.
3292
3293         Add API test coverage.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3296         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3297
3298 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3299
3300         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3301         https://bugs.webkit.org/show_bug.cgi?id=193771
3302
3303         Unreviewed infrastructure fix.
3304
3305         * Scripts/webkitpy/port/darwin.py:
3306         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3307
3308 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3309
3310         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3311
3312 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3313
3314         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3315
3316         * Scripts/webkitpy/common/config/contributors.json:
3317
3318 2019-01-25  Chris Dumez  <cdumez@apple.com>
3319
3320         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3321         https://bugs.webkit.org/show_bug.cgi?id=193779
3322         <rdar://problem/46170903>
3323
3324         Reviewed by Antti Koivisto.
3325
3326         Add API test that quickly navigates forward to a previous process without waiting for it to
3327         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3328         the process' previous page when reconnecting the it for the forward navigation.
3329
3330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3331
3332 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3333
3334         Need a way for JavaScript (or bundle) code to participate in undo
3335         https://bugs.webkit.org/show_bug.cgi?id=190009
3336         <rdar://problem/44807048>
3337
3338         Reviewed by Ryosuke Niwa.
3339
3340         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3341         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3342
3343         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3344         (WTR::UIScriptController::lastUndoLabel const):
3345         (WTR::UIScriptController::firstRedoLabel const):
3346         (WTR::UIScriptController::platformUndoManager const):
3347         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3348         (WTR::UIScriptController::lastUndoLabel const):
3349         (WTR::UIScriptController::firstRedoLabel const):
3350         (WTR::UIScriptController::platformUndoManager const):
3351         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3352         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3353         (WTR::UIScriptController::lastUndoLabel const):
3354         (WTR::UIScriptController::firstRedoLabel const):
3355         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3356         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3357         (WTR::UIScriptController::lastUndoLabel const):
3358         (WTR::UIScriptController::firstRedoLabel const):
3359         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3360         (WTR::UIScriptController::platformUndoManager const):
3361         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3362         (WTR::UIScriptController::platformUndoManager const):
3363
3364 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3365
3366         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3367         https://bugs.webkit.org/show_bug.cgi?id=193824
3368
3369         Reviewed by Antti Koivisto.
3370
3371         * LayoutReloaded/misc/LFC-passing-tests.txt:
3372
3373 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3374
3375         Update macOS JSC bot configurations
3376         https://bugs.webkit.org/show_bug.cgi?id=193739
3377
3378         Reviewed by Alexey Proskuryakov.
3379
3380         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3382         (BubbleQueueServer): Move JSC EWS to Mojave section.
3383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3384         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3385         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3386
3387 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3388
3389         [Win][WebKitTestRunner] Implement EventSenderProxy
3390         https://bugs.webkit.org/show_bug.cgi?id=193755
3391
3392         Reviewed by Don Olmstead.
3393
3394         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3395         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3396         (WTR::EventSenderProxy::dispatchMessage):
3397         (WTR::EventSenderProxy::EventSenderProxy):
3398         (WTR::EventSenderProxy::mouseDown):
3399         (WTR::EventSenderProxy::mouseUp):
3400         (WTR::EventSenderProxy::mouseMoveTo):
3401         (WTR::EventSenderProxy::mouseScrollBy):
3402         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3403
3404 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3405
3406         Unreviewed fix for API test failure after r240437.
3407
3408         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3409
3410         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3411
3412 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3413
3414         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3415         https://bugs.webkit.org/show_bug.cgi?id=193787
3416         <rdar://problem/47497634>
3417
3418         Reviewed by Alexey Proskuryakov.
3419
3420         * Scripts/webkitdirs.pm:
3421         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3422
3423 2019-01-24  Truitt Savell  <tsavell@apple.com>
3424
3425         Unreviewed, rolling out r240446.
3426
3427         Casued 5 API failures
3428
3429         Reverted changeset:
3430
3431         "Activate the WebResourceLoadStatisticsStore in the
3432         NetworkProcess and deactivate it in the UIProcess."
3433         https://bugs.webkit.org/show_bug.cgi?id=193297
3434         https://trac.webkit.org/changeset/240446
3435
3436 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3437
3438         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3439         https://bugs.webkit.org/show_bug.cgi?id=193741
3440         <rdar://problem/47135030>
3441
3442         Reviewed by Antti Koivisto and Simon Fraser.
3443
3444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3445         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3446         (TestWebKitAPI::TEST):
3447
3448 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3449
3450         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3451         https://bugs.webkit.org/show_bug.cgi?id=193297
3452         <rdar://problem/47158841>
3453
3454         Reviewed by Alex Christensen.
3455
3456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3457         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3458         activating the message used to trigger the callback when it is set.
3459
3460 2019-01-24  John Wilander  <wilander@apple.com>
3461
3462         Add Ad Click Attribution as an internal/experimental feature
3463         https://bugs.webkit.org/show_bug.cgi?id=193685
3464         <rdar://problem/47450399>
3465
3466         Reviewed by Brent Fulgham.
3467
3468         Added test option adClickAttributionEnabled.
3469
3470         * DumpRenderTree/TestOptions.cpp:
3471         (TestOptions::TestOptions):
3472         * DumpRenderTree/TestOptions.h:
3473         * DumpRenderTree/mac/DumpRenderTree.mm:
3474         (setWebPreferencesForTestOptions):
3475
3476 2019-01-24  Antti Koivisto  <antti@apple.com>
3477
3478         [PSON] Flash on back navigation on Mac
3479         https://bugs.webkit.org/show_bug.cgi?id=193716
3480         <rdar://problem/47148458>
3481
3482         Reviewed by Chris Dumez.
3483
3484         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3485
3486         Closing of the previous page is delayed so waiting for didFinishNavigation is
3487         not sufficient to guarantee we have received all the messages. Wait for them.
3488
3489 2019-01-24  Chris Dumez  <cdumez@apple.com>
3490
3491         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3492         https://bugs.webkit.org/show_bug.cgi?id=193761
3493         <rdar://problem/47456405>
3494
3495         Reviewed by Alex Christensen.
3496
3497         Add API test coverage.
3498
3499         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3500
3501 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3502
3503         webkitpy: Missing PID in crashlog name should not be fatal
3504         https://bugs.webkit.org/show_bug.cgi?id=193771
3505
3506         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3507         of raising an exception.
3508
3509         Reviewed by Lucas Forschler.
3510
3511         * Scripts/webkitpy/port/darwin.py:
3512         (DarwinPort._merge_crash_logs):
3513
3514 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3515
3516         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3517         https://bugs.webkit.org/show_bug.cgi?id=193746
3518
3519         Reviewed by Youenn Fablet.
3520
3521         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3522         so we'd best just not call it.
3523
3524         * Scripts/webkitpy/w3c/test_exporter.py:
3525         (WebPlatformTestExporter.create_branch_with_patch):
3526
3527 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3528
3529         Move FileSystem to WTF
3530         https://bugs.webkit.org/show_bug.cgi?id=193602
3531
3532         Reviewed by Yusuke Suzuki.
3533
3534         * DumpRenderTree/win/DumpRenderTree.cpp:
3535         * TestWebKitAPI/CMakeLists.txt:
3536         * TestWebKitAPI/PlatformGTK.cmake:
3537         * TestWebKitAPI/PlatformJSCOnly.cmake:
3538         * TestWebKitAPI/PlatformPlayStation.cmake:
3539         * TestWebKitAPI/PlatformWPE.cmake:
3540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3541         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3542         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3543         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3544         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3545         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3546         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3547         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3548         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3549         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3550
3551 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3552
3553         [WPE] Remove hard dependency on subprocess32 for the API tests
3554
3555         Rubber-stamped by Carlos Garcia Campos.
3556
3557         * glib/api_test_runner.py:
3558         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3559         its presence only when running WPEQt tests.
3560
3561 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3562
3563         [GLIB] Expose JavaScriptCore options in GLib public API
3564         https://bugs.webkit.org/show_bug.cgi?id=188742
3565
3566         Reviewed by Michael Catanzaro.
3567
3568         Add a test for the new API.
3569
3570         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3571         (testsJSCOptions):
3572         (main):
3573
3574 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3575
3576         [GTK][WPE] Support JPEG 2000 images
3577         https://bugs.webkit.org/show_bug.cgi?id=186272
3578
3579         Reviewed by Žan Doberšek.
3580
3581         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3582
3583         * gtk/jhbuild.modules:
3584         * wpe/jhbuild.modules:
3585
3586 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3587
3588         check-webkit-style should warn when using soft-linking macros in a header
3589         <https://webkit.org/b/193750>
3590
3591         Reviewed by Darin Adler.
3592
3593         * Scripts/webkitpy/style/checkers/cpp.py:
3594         (check_language): Add softlink/header check by refactoring the
3595         softlink/framework check.
3596         (CppChecker): Enable softlink/header check by default.
3597         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3598         (CppStyleTest.test_softlink_framework): Rename from
3599         CppStyleTest.test_softlink() and change test framework name in
3600         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3601         files. Set file_name for macros that only appear in headers.
3602         (CppStyleTest.test_softlink_header): Add tests for using
3603         soft-link macros in headers.
3604
3605 2019-01-23  Chris Dumez  <cdumez@apple.com>
3606
3607         Deprecate API to limit the maximum number of WebProcesses
3608         https://bugs.webkit.org/show_bug.cgi?id=193725
3609         <rdar://problem/47464879>
3610
3611         Reviewed by Geoff Garen.
3612
3613         Update existing API tests to stop using deprecated API.
3614
3615         * MiniBrowser/mac/AppDelegate.m:
3616         (defaultConfiguration):
3617         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3618         (TestWebKitAPI::TEST):
3619         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3620         (TestWebKitAPI::TEST):
3621         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3622         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3623         (TEST):
3624         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3625         (TEST):
3626
3627 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3628
3629         [ews-app] Rename ews model buildermappings to buildermapping
3630         https://bugs.webkit.org/show_bug.cgi?id=193729
3631
3632         Reviewed by Lucas Forschler.
3633
3634         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3635         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3636         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3637
3638 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3639
3640         [ews-app] Rename ews model steps to step
3641         https://bugs.webkit.org/show_bug.cgi?id=193697
3642
3643         Reviewed by Lucas Forschler.
3644
3645         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3646         (Step): Renamed Steps to Step.
3647
3648 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3649
3650         Clean up IndexedDB files between tests
3651         https://bugs.webkit.org/show_bug.cgi?id=192796
3652         <rdar://problem/46824999>
3653
3654         Reviewed by Geoffrey Garen.
3655
3656         * DumpRenderTree/mac/DumpRenderTree.mm:
3657         (runTest):
3658         * WebKitTestRunner/TestController.cpp:
3659         (WTR::TestController::resetStateToConsistentValues):
3660         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3661         (WTR::RemoveAllIndexedDatabasesCallback):
3662         (WTR::TestController::ClearIndexedDatabases):
3663         * WebKitTestRunner/TestController.h:
3664         * WebKitTestRunner/TestInvocation.cpp:
3665         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3666
3667 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3668
3669         [ews-app] Rename ews model Builds to Build
3670         https://bugs.webkit.org/show_bug.cgi?id=193695
3671
3672         Reviewed by Lucas Forschler.
3673
3674         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3675         (Build): Renamed Builds to Build.
3676
3677 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3678
3679         webkitpy: Wait longer when launching WebKitTestRunner
3680         https://bugs.webkit.org/show_bug.cgi?id=193734
3681
3682         Reviewed by Aakash Jain.
3683
3684         * Scripts/webkitpy/port/simulator_process.py:
3685         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3686
3687 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3688
3689         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3690         https://bugs.webkit.org/show_bug.cgi?id=193182
3691         <rdar://problem/47452154>
3692
3693         Reviewed by Tim Horton.
3694
3695         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3696         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3697         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3698
3699         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3700         preventing later tests from recognizing gestures.
3701
3702         * WebKitTestRunner/ios/TestControllerIOS.mm:
3703         (WTR::TestController::platformResetStateToConsistentValues):
3704