b44341ced57868947f717ce32826293cc6a98736
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-11  Sailesh Agrawal  <sail@chromium.org>
2
3         Reviewed by Kenneth Russell.
4
5         plugins/invalidate_rect.html fails on chromium-mac
6         https://bugs.webkit.org/show_bug.cgi?id=54051
7
8         This change fixes the invalidate_rect.html test failure on Windows.
9
10         There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.
11
12         The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.
13
14         This change also updates the build path in chromium_win.py to use the new Source directory.
15
16         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
17         (invalidateRect):
18         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
19         (NPP_New):
20         (handleEventWin):
21         (NPP_HandleEvent):
22         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
23
24 2011-02-11  Csaba Osztrogonác  <ossy@webkit.org>
25
26         Reviewed by Andreas Kling.
27
28         [Qt] Increase the timeout of Qt API tests to 120 seconds.
29
30         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
31
32 2011-02-10  Zhenyao Mo  <zmo@google.com>
33
34         Unreviewed, build fix.
35
36         * DumpRenderTree/DumpRenderTree.gypi:
37
38 2011-02-10  Dirk Pranke  <dpranke@chromium.org>
39
40         Reviewed by Tony Chang.
41
42         This patch adds the bulk of the remaining functionality for
43         the NRWT message-passing implementation. The patch adds a new
44         Worker class that will eventually replace the TestShellThread
45         class in dump_render_tree_thread.py, and implements enough of
46         TestRunner2 and the inline version of the manager_worker_broker
47         to actually be able to send a full set of messages back and
48         forth. The Worker stubs do not actually run tests, and there's
49         lots of error handling and stats needed, but this is the core
50         logic.
51
52         https://bugs.webkit.org/show_bug.cgi?id=54068
53
54         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
55         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
56         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
57         * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
58         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
59
60 2011-02-10  Zhenyao Mo  <zmo@google.com>
61
62         Unreviewed, build fix.
63
64         * DumpRenderTree/DumpRenderTree.gypi:
65
66 2011-02-10  Zhenyao Mo  <zmo@google.com>
67
68         Unreviewed, build fix.
69
70         * DumpRenderTree/DumpRenderTree.gypi:
71
72 2011-02-10  Zhenyao Mo  <zmo@google.com>
73
74         Unreviewed, attempt to fix crashing plugin tests.
75
76         * DumpRenderTree/DumpRenderTree.gypi:
77
78 2011-02-10  Zhenyao Mo  <zmo@google.com>
79
80         Unreviewed, build fix.
81
82         * DumpRenderTree/DumpRenderTree.gypi:
83
84 2011-02-10  Sam Weinig  <sam@webkit.org>
85
86         Try and fix some crashing tests on the chromium build bot.
87
88         * DumpRenderTree/DumpRenderTree.gypi:
89
90 2011-02-10  Anders Carlsson  <andersca@apple.com>
91
92         Reviewed by Sam Weinig.
93
94         Log an error if a plug-in test can't be found
95         https://bugs.webkit.org/show_bug.cgi?id=54252
96
97         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
98         (PluginTest::create):
99         Return null if the test wasn't found.
100
101         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
102         (NPP_New):
103         Report an error if PluginTest::create returns null.
104
105 2011-02-10  Robert Hogan  <robert@webkit.org>
106
107         Reviewed by Laszlo Gombos.
108
109         [Qt] Return menu items from eventSender.contextMenu()
110         https://bugs.webkit.org/show_bug.cgi?id=53039
111
112         * DumpRenderTree/qt/EventSenderQt.cpp:
113         (EventSender::contextClick):
114         * DumpRenderTree/qt/EventSenderQt.h:
115
116 2011-02-10  Adam Roben  <aroben@apple.com>
117
118         Test showing and hiding the find indicator on Windows
119
120         Test for <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
121         FindIndicator::contentImage when scrolling page
122
123         Reviewed by Steve Falkenburg.
124
125         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.
126         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
127         (TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
128         bitmap.
129         (TestWebKitAPI::initialize): Hook up our callbacks.
130         (TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.
131
132         * TestWebKitAPI/PlatformWebView.h:
133         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
134         (TestWebKitAPI::PlatformWebView::page):
135         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
136         (TestWebKitAPI::PlatformWebView::page):
137         Made page a const member function.
138
139         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
140
141 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
142
143         Reviewed by Martin Robinson.
144
145         [GTK] Log signals from AtkDocument interface also in AccessibilityController
146         https://bugs.webkit.org/show_bug.cgi?id=54198
147
148         Trace AtkDocument's signals emission through AccessibilityController.
149
150         Also, taken the code related to adding and removing global
151         listeners for ATK signals out to a separate file, for the sake of
152         clarity and to ease future additions.
153
154         * DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
155         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added
156         (printAccessibilityEvent): Print information about an event.
157         (axObjectEventListener): Global listener for AtkObject's signals.
158         (axDocumentEventListener): Global listener for AtkDocument's signals.
159         (connectAccessibilityCallbacks): Connect all global listeners.
160         (disconnectAccessibilityCallbacks): Disconnect all global listeners.
161
162         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
163         (AccessibilityController::setLogAccessibilityEvents): Call to
164         connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
165
166         * GNUmakefile.am: Added new files.
167
168 2011-02-09  Martin Robinson  <mrobinson@igalia.com>
169
170         Reviewed by Gustavo Noronha Silva.
171
172         [GTK] Default error page is interfering with tests which require failed loads
173         https://bugs.webkit.org/show_bug.cgi?id=54157
174
175         Disable the default error page during DRT runs. This prevents unexpected loads
176         from interfering with tests that have planned failed loads.
177
178         * DumpRenderTree/gtk/DumpRenderTree.cpp:
179         (webViewLoadError): Added, disable default handler.
180         (createWebView): Connect the new load-error handler.
181
182 2011-02-10  Zoltan Horvath  <zoltan@webkit.org>
183
184         Reviewed by Andreas Kling.
185
186         [Qt] Add UrlLoader and command line argument handling to MiniBrowser
187         https://bugs.webkit.org/show_bug.cgi?id=54192
188  
189         Copy and modify files from QtTestBrowser's implementation.
190
191         * MiniBrowser/qt/BrowserWindow.cpp:
192         (BrowserWindow::BrowserWindow):
193         (BrowserWindow::newWindow):
194         * MiniBrowser/qt/BrowserWindow.h:
195         * MiniBrowser/qt/MiniBrowser.pro:
196         * MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp
197         (MiniBrowserApplication::MiniBrowserApplication):
198         (MiniBrowserApplication::handleUserOptions):
199         * MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h
200         (WindowOptions::WindowOptions):
201         (MiniBrowserApplication::urls):
202         (MiniBrowserApplication::isRobotized):
203         (MiniBrowserApplication::robotTimeout):
204         (MiniBrowserApplication::robotExtraTime):
205         * MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp
206         (UrlLoader::UrlLoader):
207         (UrlLoader::loadNext):
208         (UrlLoader::checkIfFinished):
209         (UrlLoader::frameLoadStarted):
210         (UrlLoader::frameLoadFinished):
211         (UrlLoader::loadUrlList):
212         (UrlLoader::getUrl):
213         * MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h 
214         * MiniBrowser/qt/main.cpp:
215         (main):
216         * MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp 
217         (takeOptionValue):
218         (formatKeys):
219         (enumToKeys):
220         (appQuit):
221         (urlFromUserInput):
222         * MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h
223
224 2011-02-10  Zoltan Horvath  <zoltan@webkit.org>
225
226         Reviewed by Andreas Kling.
227
228         check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
229         https://bugs.webkit.org/show_bug.cgi?id=54200
230
231         * Scripts/webkitpy/style/checker.py:
232         * Scripts/webkitpy/style/checker_unittest.py:
233
234 2011-02-10  Peter Varga  <pvarga@webkit.org>
235
236         Reviewed by Csaba Osztrogonác.
237
238         Remove PCRE source from trunk
239         https://bugs.webkit.org/show_bug.cgi?id=54188
240
241         * wx/build/settings.py:
242
243 2011-02-10  David Levin  <levin@chromium.org>
244
245         Reviewed by Shinichiro Hamaji.
246
247         check-webkit-style should be able to figure out function modifiers and return type.
248         https://bugs.webkit.org/show_bug.cgi?id=54124
249
250         * Scripts/webkitpy/style/checkers/cpp.py:
251         (_rfind_in_lines): A way to search backwards in lines.
252         (_FunctionState.modifiers_and_return_type):
253         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.
254
255 2011-02-09  Adam Roben  <aroben@apple.com>
256
257         Test that WM_PRINT doesn't trigger an assertion
258
259         Test for <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
260         drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)
261
262         Reviewed by Darin Adler.
263
264         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.
265         (TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.
266
267 2011-02-09  Adam Roben  <aroben@apple.com>
268
269         Test that having a WKView paint after being resized while hidden doesn't cause a crash
270
271         Test for <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
272         DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden
273
274         Reviewed by Darin Adler.
275
276         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
277         (TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.
278
279 2011-02-09  Adam Roben  <aroben@apple.com>
280
281         Add a test that resizes a WKView while it's hidden
282
283         Test for <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
284         performs badly if is resized while hidden (assertion fails in
285         BackingStore::incorporateUpdate in Debug builds)
286
287         Reviewed by Darin Adler.
288
289         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.
290         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
291         (TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
292         (TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
293         that all pending messages have been handled by the UI and web process.
294         (TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
295         (TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
296         (TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
297         chance to display, then flush all pending messages.
298         (TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
299         the backing store to update. This triggers the assertion from bug 54141.
300
301         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
302         (TestWebKitAPI::PlatformWebView::resizeTo): Implemented.
303
304         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
305
306 2011-02-10  Philippe Normand  <pnormand@igalia.com>
307
308         Unreviewed, GTK build fix after roll out of r78157...
309
310         * GNUmakefile.am:
311
312 2011-02-10  Eric Seidel  <eric@webkit.org>
313
314         Unreviewed, rolling out r78157.
315         http://trac.webkit.org/changeset/78157
316         https://bugs.webkit.org/show_bug.cgi?id=54150
317
318         Fails on a bunch of bots
319
320         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
321         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
322         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
323         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
324
325 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
326
327         Reviewed by Xan Lopez.
328
329         [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
330         https://bugs.webkit.org/show_bug.cgi?id=54185
331
332         * DumpRenderTree/gtk/DumpRenderTree.cpp:
333         (resetDefaultsToConsistentValues):
334
335 2011-02-10  Philippe Normand  <pnormand@igalia.com>
336
337         Unreviewed GTK build fix.
338
339         Adding
340         Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
341         in the build, fixing the
342         plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
343         test.
344
345         * GNUmakefile.am:
346
347 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
348
349         Reviewed by Chris Fleizach.
350
351         [GTK] Add support in DRT to log "accessibility events"
352         https://bugs.webkit.org/show_bug.cgi?id=54116
353
354         Added a way to log accessibility related events, in a
355         platform-dependant way.
356
357         Add new function to AccessibilityController.
358
359         * DumpRenderTree/AccessibilityController.h:
360         * DumpRenderTree/AccessibilityController.cpp:
361         (logAccessibilityEventsCallback): New callback.
362         (AccessibilityController::getJSClass): Added new function.
363         (AccessibilityController::resetToConsistentState): Initialized
364         calling setLogAccessibilityEvents(false).
365
366         Provided implementation for the GTK port.
367
368         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
369         (accessibility_event_listener): Common listener for logging
370         information about all the signals emitted by any AtkObject.
371         (AccessibilityController::setLogAccessibilityEvents): Add or
372         remove listeners for signals, as specified by the parameter.
373
374         Provide dummy implementations for mac and win ports.
375
376         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
377         (AccessibilityController::setLogAccessibilityEvents):
378         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
379         (AccessibilityController::setLogAccessibilityEvents):
380
381 2011-02-09  Hayato Ito  <hayato@chromium.org>
382
383         Reviewed by Tony Chang.
384
385         [NRWT] Remove encoding parameters where we can assume data can be
386         written in binary mode.
387
388         https://bugs.webkit.org/show_bug.cgi?id=54066
389
390         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
391         * Scripts/webkitpy/layout_tests/port/base.py:
392
393 2011-02-09  Dirk Pranke  <dpranke@chromium.org>
394
395         Reviewed by Tony Chang.
396
397         nrwt multiprocessing: minor cleanup prior to implementing the new worker
398
399         This patch renames AbstractManager to ManagerConnection and
400         changes some argument names to be more consistent between
401         manager_worker_broker and message_broker. It also fixes a couple
402         of typos in message_broker. These changes will be tested by code
403         introduced in the next patch.
404        
405         https://bugs.webkit.org/show_bug.cgi?id=54067
406
407         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
408         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
409
410 2011-02-09  Anders Carlsson  <andersca@apple.com>
411
412         Reviewed by Sam Weinig.
413
414         Repro crash with Sony Google TV ad at Gizmodo
415         https://bugs.webkit.org/show_bug.cgi?id=54150
416         <rdar://problem/8782346>
417
418         Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.
419
420         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
421         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added.
422         (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream):
423         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy):
424         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
425         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
426         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
427
428 2011-02-09  David Levin  <levin@chromium.org>
429
430         Reviewed by Eric Seidel.
431
432         check-webkit-style: The error message about NULL should be more clear for comments.
433         https://bugs.webkit.org/show_bug.cgi?id=53786
434
435         * Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
436         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
437
438 2011-02-09  Nebojsa Ciric  <cira@chromium.org>
439
440         Reviewed by Darin Fisher.
441
442         Implements Locale object of JavaScript internationalization API proposal, as an
443         v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
444         and in this patch we just provide flags, tests and build rules for chromium port.
445         https://bugs.webkit.org/show_bug.cgi?id=49414
446
447         * DumpRenderTree/chromium/TestShell.cpp:
448         (TestShell::TestShell):
449
450 2011-02-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
451
452         Reviewed by Kenneth Rohde Christiansen.
453
454         [Qt] Remove UiTools dependency from MiniBrowser
455         https://bugs.webkit.org/show_bug.cgi?id=54096
456
457         * MiniBrowser/qt/MiniBrowser.pro:
458
459 2011-02-08  Hayato Ito  <hayato@chromium.org>
460
461         Reviewed by Tony Chang.
462
463         [NRWT] Pull up rebaseline code from compare_output() function defined
464         in text_diff.py and image_diff.py into a SingleTestRunner.
465
466         This patch is a first step for eliminating test_type/* classes.
467
468         https://bugs.webkit.org/show_bug.cgi?id=53071
469
470         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
471         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
472         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
473         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
474
475 2011-02-07  Ojan Vafai  <ojan@chromium.org>
476
477         Reviewed by Mihai Parparita.
478
479         stop generating results.json files
480         https://bugs.webkit.org/show_bug.cgi?id=53977
481
482         We've only used incremental_results.json for a while now
483         and there are plans to start generating a results.json file that matches
484         the format of unexpected_results.json.
485
486         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
487         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
488         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
489         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
490         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
491
492 2011-02-08  Sailesh Agrawal  <sail@chromium.org>
493
494         Reviewed by Kenneth Russell.
495
496         Invalidate rect doesn't work for windowless plugins on Chromium
497         https://bugs.webkit.org/show_bug.cgi?id=53117
498
499         Added two new utility methods.
500         - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
501         - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
502         This is used to test that invalidating a rect correctly causes a repaint of the plugin.
503
504         * DumpRenderTree/LayoutTestController.cpp:
505         (displayInvalidatedRegionCallback):
506         (LayoutTestController::staticFunctions):
507         * DumpRenderTree/LayoutTestController.h:
508         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
509         (invalidateRect):
510         (pluginInvoke):
511         * DumpRenderTree/chromium/LayoutTestController.cpp:
512         (LayoutTestController::LayoutTestController):
513         (LayoutTestController::displayInvalidatedRegion):
514         * DumpRenderTree/chromium/LayoutTestController.h:
515         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
516
517 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
518
519         Reviewed by Tony Chang.
520
521         new-run-webkit-tests: move the logic that starts and stops the
522         servers from dump_render_tree_thread into single_test_runner
523         so that we can reuse it in the new multiprocessing worker class
524         as well.
525
526         https://bugs.webkit.org/show_bug.cgi?id=53840
527
528         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
529         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
530  
531 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
532
533         Reviewed by Mihai Parparita.
534
535         new-run-webkit-tests: split out thread stack logging code into a sharable module
536
537         This patch splits out the code used to find and log thread
538         stacks from NRWT-specific packages to something generic and
539         shareable by other python modules. It will be shared in the near
540         future by the manager_worker_broker module, for example.
541
542         https://bugs.webkit.org/show_bug.cgi?id=53656
543
544         * Scripts/webkitpy/common/system/stack_utils.py: Added.
545         * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
546         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
547         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
548
549 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
550
551         Reviewed by Tony Chang.
552
553         new-run-webkit-tests: move a bunch of testing logic out of
554         dump_render_tree_thread and into single_test_runner so that we
555         will be able to reuse it in the new multiprocessing worker class as well.
556
557         https://bugs.webkit.org/show_bug.cgi?id=53838
558
559         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
560         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
561
562         
563 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
564
565         Reviewed by Ojan Vafai.
566
567         new-run-webkit-tests: remove no longer needed WatchableThread
568         class.
569
570         https://bugs.webkit.org/show_bug.cgi?id=53839
571
572         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
573
574 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
575
576         Reviewed by Tony Chang.
577
578         new-run-webkit-tests: add stubs for the Manager objects that
579         will abstract the concurrency implementation (inline / threads /
580         processes). These classes do nothing yet and are not wired up to
581         anything.
582
583         https://bugs.webkit.org/show_bug.cgi?id=53477
584
585         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
586         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
587
588 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
589
590         Reviewed by Tony Chang.
591
592         new-run-webkit-tests: add simplified message broker for new-style
593         messaging. This change adds a very simple message broker that
594         will be used to shuttle messages between the TestRunner2 manager
595         thread and the Worker threads. For now the class is not used by
596         anything, but the eventual usage can be seen in the patches
597         attached to bug 49566.
598
599         https://bugs.webkit.org/show_bug.cgi?id=53158
600
601         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
602         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
603
604 2011-02-08  Adam Barth  <abarth@webkit.org>
605
606         Reviewed by Dimitri Glazkov.
607
608         chromium-win builder shouldn't run python or perl tests
609         https://bugs.webkit.org/show_bug.cgi?id=54032
610
611         These tests don't pass on this builder because the builder isn't
612         running in cygwin.  There isn't really any point in running them and
613         making the bot red forever.
614
615         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
616
617 2011-02-08  Brady Eidson  <beidson@apple.com>
618
619         Reviewed by Darin Adler.
620
621         <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
622         didChangeBackForwardList should include some context about what changed
623
624         * MiniBrowser/mac/BrowserWindowController.m:
625         (didChangeBackForwardList):
626
627 2011-02-08  Sam Weinig  <sam@webkit.org>
628
629         Reviewed by Anders Carlsson.
630
631         WK2: Add ability to pass context to policy delegate methods
632         https://bugs.webkit.org/show_bug.cgi?id=54031
633
634         * MiniBrowser/mac/BrowserWindowController.m:
635         (decidePolicyForNavigationAction):
636         (decidePolicyForNewWindowAction):
637         (decidePolicyForMIMEType):
638         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
639         (TestWebKitAPI::decidePolicyForNavigationAction):
640         (TestWebKitAPI::decidePolicyForNewWindowAction):
641         (TestWebKitAPI::decidePolicyForMIMEType):
642         Update policy client for new API.
643
644 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
645
646         Reviewed by Xan Lopez.
647
648         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
649         https://bugs.webkit.org/show_bug.cgi?id=54033
650
651         Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
652         call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
653
654         * DumpRenderTree/gtk/DumpRenderTree.cpp:
655         (resetDefaultsToConsistentValues): Turn off the icon database.
656         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
657         (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
658         method.
659
660 2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>
661
662         Reviewed by Laszlo Gombos.
663
664         Local Storage settings can be enable/disable from "Develop" menu
665         https://bugs.webkit.org/show_bug.cgi?id=52296
666
667         * QtTestBrowser/launcherwindow.cpp:
668         (LauncherWindow::createChrome):
669         (LauncherWindow::toggleLocalStorage):
670         (LauncherWindow::toggleOfflineStorageDatabase):
671         (LauncherWindow::toggleOfflineWebApplicationCache):
672         (LauncherWindow::setOfflineStorageDefaultQuota):
673         * QtTestBrowser/launcherwindow.h:
674         (WindowOptions::WindowOptions):
675         * QtTestBrowser/main.cpp:
676         (LauncherApplication::handleUserOptions):
677
678 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
679
680         Reviewed by Eric Seidel.
681
682         [GTK] EventSender.keyDown does not support non-array modifier arguments
683         https://bugs.webkit.org/show_bug.cgi?id=53962
684
685         Support handling either an array or a string for the modifier argument
686         to EventSender.keyDown.
687
688         * DumpRenderTree/gtk/EventSender.cpp:
689         (gdkModifierFromJSValue): Added this helper which factors out the
690         string comparison bits.
691         (gdkModifersFromJSValue): Test up front whether the value is a string,
692         to handle it specially.
693
694 2011-02-08  Benjamin Poulain  <ikipou@gmail.com>
695
696         Reviewed by Csaba Osztrogonác.
697
698         openDatabaseSync() stop responding after too many call
699         https://bugs.webkit.org/show_bug.cgi?id=53945
700
701         Reset the database quota to a known state between each test.
702
703         Define a quota for the known origins at each test run and delete
704         all the databases.
705         This way, the database related test do not depend on previous
706         allocations.
707
708         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
709         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
710         (WebCore::DumpRenderTree::dumpDatabaseQuota):
711         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
712         (LayoutTestController::reset):
713
714 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
715
716         Reviewed by Martin Robinson.
717
718         [GTK] DRT's TextInputController is unimplemented on GTK
719         https://bugs.webkit.org/show_bug.cgi?id=52997
720
721         Initial implementation of TextInputController for GTK port.
722
723         * DumpRenderTree/gtk/DumpRenderTree.cpp:
724         (webViewWindowObjectCleared):
725         * DumpRenderTree/gtk/TextInputController.cpp: Added.
726         (setMarkedTextCallback):
727         (insertTextCallback):
728         (unmarkTextCallback):
729         (firstRectForCharacterRangeCallback):
730         (selectedRangeCallback):
731         (getClass):
732         (makeTextInputController):
733         * DumpRenderTree/gtk/TextInputController.h: Added.
734         * GNUmakefile.am:
735
736 2011-02-07  Tony Chang  <tony@chromium.org>
737
738         Reviewed by Adam Barth.
739
740         clean up python imports
741         https://bugs.webkit.org/show_bug.cgi?id=53966
742
743         Convert "import A.B.C.D as D" to "from A.B.C import D" and
744         make some imports absolute as required by PEP-8
745
746         * Scripts/webkitpy/common/checkout/scm.py:
747         * Scripts/webkitpy/common/net/irc/ircbot.py:
748         * Scripts/webkitpy/common/system/logutils.py:
749         * Scripts/webkitpy/common/system/logutils_unittest.py:
750         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
751         * Scripts/webkitpy/layout_tests/port/chromium.py:
752         * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
753         * Scripts/webkitpy/layout_tests/port/webkit.py:
754         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
755         * Scripts/webkitpy/tool/bot/irc_command.py:
756         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
757         * Scripts/webkitpy/tool/commands/download.py:
758         * Scripts/webkitpy/tool/commands/prettydiff.py:
759         * Scripts/webkitpy/tool/commands/queries.py:
760         * Scripts/webkitpy/tool/commands/roll.py:
761         * Scripts/webkitpy/tool/commands/stepsequence.py:
762         * Scripts/webkitpy/tool/commands/upload.py:
763         * Scripts/webkitpy/tool/main.py:
764
765 2011-02-07  James Robinson  <jamesr@chromium.org>
766
767         Reviewed by Adam Barth.
768
769         Teach do-webcore-rename about the WebKit move to Source/
770         https://bugs.webkit.org/show_bug.cgi?id=53967
771
772         * Scripts/do-webcore-rename:
773
774 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
775
776         Reviewed by Dan Bernstein.
777
778         Add resource load client for injected bundle and move willSendRequest there
779         https://bugs.webkit.org/show_bug.cgi?id=53972
780
781         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
782         (didCreatePage):
783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
784         (WTR::InjectedBundlePage::InjectedBundlePage):
785         (WTR::InjectedBundlePage::didInitiateLoadForResource):
786         (WTR::InjectedBundlePage::didReceiveResponseForResource):
787         (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
788         (WTR::InjectedBundlePage::didFinishLoadForResource):
789         (WTR::InjectedBundlePage::didFailLoadForResource):
790         (WTR::InjectedBundlePage::willSendRequestForFrame):
791         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
792
793 2011-02-07  Adam Barth  <abarth@webkit.org>
794
795         Add Leopard Debug back to the core builders.
796
797         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
798         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
799
800 2011-02-07  Adam Klein  <adamk@chromium.org>
801
802         Reviewed by Jian Li.
803
804         [chromium] Remove deprecated method WebNotification::dir
805         https://bugs.webkit.org/show_bug.cgi?id=53735
806
807         * DumpRenderTree/chromium/NotificationPresenter.cpp:
808         (NotificationPresenter::show):
809
810 2011-02-07  Adam Barth  <abarth@webkit.org>
811
812         Reviewed by Eric Seidel.
813
814         Remove Leopard Debug as a core builder
815         https://bugs.webkit.org/show_bug.cgi?id=53971
816
817         The Leopard Debug builder has been failing to compile for several days.
818         My understanding is that folks are working on fixing the build, but for
819         the time being we should probably remove it from the list of core
820         builders so that the core waterfall can be green.  We can certainly add
821         it back once the build is fixed.
822
823         Also, I've removed the Tiger builders because those no longer appear to
824         be attached to the buildbot master.
825
826         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
827         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
828
829 2011-02-01  Ojan Vafai  <ojan@chromium.org>
830
831         Reviewed by Adam Roben.
832
833         include svn revisions in git diffs for the code review tool to use
834         https://bugs.webkit.org/show_bug.cgi?id=53569
835
836         * Scripts/webkitpy/common/checkout/scm.py:
837         * Scripts/webkitpy/common/checkout/scm_unittest.py:
838
839 2011-02-03  MORITA Hajime  <morrita@google.com>
840
841         Reviewed by Darin Fisher.
842
843         [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
844         https://bugs.webkit.org/show_bug.cgi?id=51013
845
846         Gave DRT implementation for requestTextCheck().
847
848         * DumpRenderTree/chromium/LayoutTestController.cpp:
849         (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
850         * DumpRenderTree/chromium/WebViewHost.cpp:
851         (invokeFinishLastTextCheck): Added.
852         (WebViewHost::requestTextCheck): Added.
853         (WebViewHost::finishLastTextCheck): Added.
854         * DumpRenderTree/chromium/WebViewHost.h:
855
856 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
857
858         Reviewed by Martin Robinson.
859
860         [Gtk] Implement layoutTestController.findString
861         https://bugs.webkit.org/show_bug.cgi?id=50237
862
863         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
864         (LayoutTestController::findString):
865
866 2011-02-07  Chang Shu  <chang.shu@nokia.com>
867
868         Reviewed by Darin Adler.
869
870         We should disable spatial navigation explicitly during the initialization
871         of DumpRenderTree.
872         https://bugs.webkit.org/show_bug.cgi?id=53928
873
874         * DumpRenderTree/mac/DumpRenderTree.mm:
875         (resetDefaultsToConsistentValues):
876
877 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
878
879         Not reviewed.
880
881         Fix WebKitTestRunner build on the SL bot.
882
883         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
884         of ICU headers.
885
886 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
887
888         Unreviewed.
889
890         [Qt][WK2] Buildfix after r77794.
891
892        WebKitTestRunner does not block remote resources or complain about them
893        https://bugs.webkit.org/show_bug.cgi?id=42139
894        <rdar://problem/8183942>
895
896         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
897
898 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
899
900         Not reviewed.
901
902         More bot appeasement.
903
904         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
905
906 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
907
908         Not reviewed.
909
910         Remove accidental references to directories on my laptop.
911
912         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
913
914 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
915
916         Reviewed by Antti Koivisto.
917
918         WebKitTestRunner does not block remote resources or complain about them
919         https://bugs.webkit.org/show_bug.cgi?id=42139
920         <rdar://problem/8183942>
921
922         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
923         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
924         checks (using KURL, to avoid need to invent a whole URL API).
925         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
926         directly to get at KURL symbols.
927
928 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
929
930         Reviewed by Daniel Bates.
931
932         Add WebKit2 bot to list of expected builders in Python regression test results.
933         https://bugs.webkit.org/show_bug.cgi?id=53905
934
935         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
936
937 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
938
939         Reviewed by Ryosuke Niwa.
940
941         Update test expectations for new core builder
942         https://bugs.webkit.org/show_bug.cgi?id=53904
943
944         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
945
946 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
947
948         Reviewed by David Levin.
949
950         Add WebKit2 test bot to core builders
951         https://bugs.webkit.org/show_bug.cgi?id=53901
952
953         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
954
955 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
956
957         Another unreviewed Chromium build fix.
958
959         * DumpRenderTree/chromium/LayoutTestController.cpp:
960         (LayoutTestController::pathToLocalResource):
961
962 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
963
964         Unreviewed Chromium build fix.
965
966         * DumpRenderTree/chromium/LayoutTestController.cpp:
967         (LayoutTestController::pathToLocalResource):
968
969 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
970
971         Reviewed by Darin Adler.
972
973         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
974         https://bugs.webkit.org/show_bug.cgi?id=52867
975
976         * DumpRenderTree/chromium/ImageDiff.cpp:
977         (Image::craeteFromStdin): Call adoptArrayPtr.
978
979 2011-02-06  James Kozianski  <koz@chromium.org>
980
981         Reviewed by Ojan Vafai.
982
983         Add classes for representing test outputs.
984         https://bugs.webkit.org/show_bug.cgi?id=52136
985
986         These classes will make it easier to write scripts that deal with test
987         outputs such as rebaselining and deduping scripts. The intent is that
988         eventually we will be have buildbot return TestOutputs for a
989         particular build which can be compared with TestOutputs derived from a
990         local LayoutTests directory.
991
992         * Scripts/webkitpy/common/net/testoutput.py: Added.
993         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
994         * Scripts/webkitpy/common/net/testoutputset.py: Added.
995         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
996         * Scripts/webkitpy/common/system/zip_mock.py: Added.
997
998 2011-02-06  Robert Hogan  <robert@webkit.org>
999
1000         Reviewed by Andreas Kling.
1001
1002         [Qt] Clear page's groupName even when not in DRT
1003         https://bugs.webkit.org/show_bug.cgi?id=53874
1004
1005         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1006         (WebCore::DumpRenderTree::windowCloseRequested):
1007
1008 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
1009
1010         Reviewed by Andreas Kling.
1011
1012         [CMake] Add dependencies for Visual Studio projects
1013         https://bugs.webkit.org/show_bug.cgi?id=53773
1014
1015         Add a WebKit dependecy to WinCELauncher, so CMake can 
1016         generate the correct build order for the solution.
1017
1018         * CMakeListsWinCE.txt:
1019
1020 2011-02-06  Andreas Kling  <kling@webkit.org>
1021
1022         Reviewed by Antonio Gomes.
1023
1024         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
1025         https://bugs.webkit.org/show_bug.cgi?id=53869
1026
1027         * MiniBrowser/qt/BrowserView.cpp:
1028         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
1029         * MiniBrowser/qt/BrowserWindow.cpp:
1030         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
1031         * MiniBrowser/qt/BrowserWindow.h:
1032
1033 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
1034
1035         Reviewed by Dan Bernstein.
1036
1037         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
1038         https://bugs.webkit.org/show_bug.cgi?id=42690
1039         <rdar://problem/8213851>
1040
1041         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1042         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1043         (WTR::InjectedBundlePage::willSendRequestForFrame):
1044         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1045         (WTR::LayoutTestController::LayoutTestController):
1046         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1047         (WTR::LayoutTestController::willSendRequestReturnsNull):
1048         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
1049
1050 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1051
1052         Unreviewed, rolling out r77720.
1053         http://trac.webkit.org/changeset/77720
1054         https://bugs.webkit.org/show_bug.cgi?id=53854
1055
1056         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
1057         #webkit).
1058
1059         * Scripts/webkitpy/common/system/executive.py:
1060
1061 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1062
1063         Unreviewed, rolling out r77725.
1064         http://trac.webkit.org/changeset/77725
1065         https://bugs.webkit.org/show_bug.cgi?id=53844
1066
1067         It broke Qt minimal build (Requested by Ossy_ on #webkit).
1068
1069         * QtTestBrowser/launcherwindow.cpp:
1070         (LauncherWindow::createChrome):
1071         * QtTestBrowser/launcherwindow.h:
1072         (WindowOptions::WindowOptions):
1073         * QtTestBrowser/main.cpp:
1074         (LauncherApplication::handleUserOptions):
1075
1076 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
1077
1078         Reviewed by Adam Barth.
1079
1080         [GTK] plugins/plugin-document-back-forward.html fails
1081         https://bugs.webkit.org/show_bug.cgi?id=53833
1082
1083         Add the new "alert on load" functionality for the Unix version of the
1084         test plugin. This functionality was originally introduced in r77706.
1085
1086         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1087         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
1088
1089 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
1090
1091         Reviewed by Andreas Kling.
1092
1093         Local Storage settings can be enable/disable from "Develop" menu
1094         https://bugs.webkit.org/show_bug.cgi?id=52296
1095
1096         * QtTestBrowser/launcherwindow.cpp:
1097         (LauncherWindow::createChrome):
1098         (LauncherWindow::toggleLocalStorage):
1099         (LauncherWindow::toggleOfflineStorageDatabase):
1100         (LauncherWindow::toggleOfflineWebApplicationCache):
1101         (LauncherWindow::setOfflineStorageDefaultQuota):
1102         * QtTestBrowser/launcherwindow.h:
1103         (WindowOptions::WindowOptions):
1104         * QtTestBrowser/main.cpp:
1105         (LauncherApplication::handleUserOptions):
1106
1107 2011-02-04  Tony Chang  <tony@chromium.org>
1108
1109         Reviewed by Eric Seidel.
1110
1111         get test-webkitpy running on win32 python
1112         https://bugs.webkit.org/show_bug.cgi?id=53822
1113
1114         The test harness crashes with a WindowsError because it can't find
1115         'svn' when using subprocess.Popen.  This gets us past the error
1116         so we can see the failing tests on the Chromium Win Release Tests
1117         bot.
1118
1119         * Scripts/webkitpy/common/system/executive.py:
1120
1121 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
1122
1123         Reviewed by Gustavo Noronha Silva.
1124
1125         [GTK] fast/events/pagehide-timeout.html fails
1126         https://bugs.webkit.org/show_bug.cgi?id=53771
1127
1128         Add knowledge of the document browser cache model the DRT. When resetting
1129         WebKit settings to consistent values between tests, default to the document
1130         browser cache model.
1131
1132         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1133         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
1134         cache model between tests.
1135         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1136         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
1137         document browser cache model.
1138
1139 2011-02-04  Adam Barth  <abarth@webkit.org>
1140
1141         Reviewed by Eric Seidel.
1142
1143         PluginDocuments don't create widgets for plugins on back/forward
1144         https://bugs.webkit.org/show_bug.cgi?id=53474
1145
1146         Teach the test plugin how to call alert on load.
1147
1148         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1149         (NPP_New):
1150
1151 2011-02-04  Adam Roben  <aroben@apple.com>
1152
1153         Add a test case for encode/decode of FormData/FormDataElement
1154
1155         If the fix made in r77401 is broken, this new test will crash.
1156
1157         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
1158
1159         Reviewed by Sam Weinig.
1160
1161         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
1162         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
1163
1164         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
1165         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
1166         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
1167         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
1168         form, an return the session state data.
1169         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
1170         and restore it into another WKPage.
1171
1172         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
1173
1174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1175         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1176         * TestWebKitAPI/win/copy-resources.cmd:
1177         Added new files.
1178
1179 2011-02-04  Adam Roben  <aroben@apple.com>
1180
1181         Move code to run JavaScript tests into its own files
1182
1183         This will allow other tests to use this mechanism.
1184
1185         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
1186         world
1187
1188         Reviewed by Sam Weinig.
1189
1190         * TestWebKitAPI/JavaScriptTest.cpp: Added.
1191         * TestWebKitAPI/JavaScriptTest.h: Added.
1192         Moved code here...
1193
1194         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
1195
1196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1198         Added the new files.
1199
1200 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
1201
1202         Reviewed by Mihai Parparita.
1203
1204         merge test expectations for chromium, chromium-gpu. The
1205         chromium-gpu port will no longer maintain its own
1206         test expectations file.
1207
1208         Also add in a graphics_type() call on the port object to
1209         determine what graphics type to use in the test configuration,
1210         and log the configuration as a config setting.
1211
1212         https://bugs.webkit.org/show_bug.cgi?id=53562
1213
1214         * Scripts/webkitpy/layout_tests/port/base.py:
1215         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1216         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1217         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1218
1219 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
1220
1221         Reviewed by Pavel Feldman.
1222
1223         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
1224         https://bugs.webkit.org/show_bug.cgi?id=53781
1225
1226         * Scripts/check-inspector-strings:
1227
1228 2011-02-04  Adam Roben  <aroben@apple.com>
1229
1230         Include the crashing function in the link to a crash log on Mac
1231
1232         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
1233         function that crashed on Mac
1234
1235         Reviewed by David Kilzer.
1236
1237         * Scripts/old-run-webkit-tests:
1238         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
1239         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
1240         the crash log.
1241
1242 2011-02-04  Adam Roben  <aroben@apple.com>
1243
1244         Link to Mac crash logs from results.html
1245
1246         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
1247         results.html
1248
1249         Reviewed by David Kilzer.
1250
1251         * Scripts/old-run-webkit-tests:
1252         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
1253         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
1254
1255 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
1256
1257         Reviewed by Dan Bernstein.
1258
1259         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
1260         https://bugs.webkit.org/show_bug.cgi?id=52897
1261         <rdar://problem/8898294>
1262
1263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1264         (WTR::InjectedBundlePage::InjectedBundlePage):
1265         (WTR::InjectedBundlePage::willSendRequestForFrame):
1266         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1267
1268 2011-02-03  Ivan Krstić  <ike@apple.com>
1269
1270         Unreviewed.
1271
1272         Adding myself to committers.py.
1273
1274         * Scripts/webkitpy/common/config/committers.py:
1275
1276 2011-02-03  James Kozianski  <koz@chromium.org>
1277
1278         Reviewed by Dimitri Glazkov.
1279
1280         Add navigator.registerProtocolHandler behind a flag.
1281         https://bugs.webkit.org/show_bug.cgi?id=52609
1282
1283         * Scripts/build-webkit:
1284
1285 2011-02-03  Hayato Ito  <hayato@chromium.org>
1286
1287         Reviewed by Eric Seidel.
1288
1289         [NRWT] Remove TestArgs class, which is wrongly used.
1290
1291         https://bugs.webkit.org/show_bug.cgi?id=53063
1292
1293         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1294         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1295         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1296         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1297         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1298         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1299
1300 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
1301
1302         Reviewed by Kenneth Russell.
1303
1304         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
1305         https://bugs.webkit.org/show_bug.cgi?id=53714
1306
1307         * Scripts/build-webkit: change --3d-canvas build option
1308           to set ENABLE_WEBGL
1309
1310 2011-02-03  Hayato Ito  <hayato@chromium.org>
1311
1312         Reviewed by Tony Chang.
1313
1314         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
1315         move _run_single_test() and _process_output() functions from
1316         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
1317
1318         This is clean up and acts as a preparation for elimination of test_types/*
1319         classes. These classes will move to the single_test_runner module introduced
1320         in this patch.
1321
1322         https://bugs.webkit.org/show_bug.cgi?id=53004
1323
1324         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1325         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
1326         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1327         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
1328         * Scripts/webkitpy/layout_tests/port/base.py:
1329         * Scripts/webkitpy/layout_tests/port/chromium.py:
1330         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1331         * Scripts/webkitpy/layout_tests/port/test.py:
1332         * Scripts/webkitpy/layout_tests/port/webkit.py:
1333         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1334         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1335         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1336
1337 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1338
1339         Unreviewed, build fix.
1340
1341         Delete a line that was accidentally missed in r77586; without it
1342         there is still a race between the two threads.
1343
1344         https://bugs.webkit.org/show_bug.cgi?id=51572
1345
1346         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1347
1348 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1349
1350         Reviewed by Tony Chang.
1351
1352         nrwt: handle "broken pipe" notifications from DRT more cleanly.
1353
1354         https://bugs.webkit.org/show_bug.cgi?id=52927
1355
1356         * Scripts/webkitpy/layout_tests/port/server_process.py:
1357         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1358
1359 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1360
1361         Reviewed by Kenneth Russell.
1362
1363         Update, resubmit change to bug 51572. I think the race that was
1364         fixed in r76703 caused the hang that caused us to roll this
1365         patch out before, so I'd like to try again.
1366
1367         https://bugs.webkit.org/show_bug.cgi?id=51572
1368
1369         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1370         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1371
1372 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
1373
1374         Unreviewed.
1375
1376         Adding myself to committers.py.
1377
1378         * Scripts/webkitpy/common/config/committers.py:
1379
1380 2011-02-03  Adam Roben  <aroben@apple.com>
1381
1382         Include the crashing function in the link to a crash log
1383
1384         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
1385         function that crashed
1386
1387         Reviewed by David Kilzer.
1388
1389         * Scripts/old-run-webkit-tests:
1390         (crashLocation): Added. Returns the location of the crash.
1391         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
1392         could be determined.
1393
1394 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1395
1396         Unreviewed, build fix.
1397
1398         Actually make the changes suggested by Mihai in his review
1399         of bug 53720 :(
1400
1401         https://bugs.webkit.org/show_bug.cgi?id=53720
1402
1403         * Scripts/webkitpy/layout_tests/port/test_files.py:
1404         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1405
1406 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1407
1408         Reviewed by Mihai Parparita.
1409
1410         new-run-webkit-tests: Fix bug introduced in r77434 that was
1411         causing us to run the canvas GPU tests on the Mac GPU port. This
1412         bug revealed that we were not setting the port.name() field
1413         properly in many cases, so I've cleaned up all of that code, and
1414         removed a few comments about "version-specific" GPU ports that
1415         don't exist and just confused things.
1416
1417         Testing also revealed that port.abspath_for_test() wasn't
1418         normalizing paths on Windows properly, so I fixed that as well.
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=53719
1421
1422         * Scripts/webkitpy/layout_tests/port/base.py:
1423         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1424         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1425
1426 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1427
1428         Reviewed by Mihai Parparita.
1429
1430         new-run-webkit-tests: fix normalization of paths on windows when gathering files
1431
1432         r77434 introduced a bug that was causing the test expectations
1433         for the GPU ports to not be treated properly. It turns out that
1434         when we gathered the list of test files on Windows, we would
1435         return paths of the form "c:\LayoutTests/fast/canvas", and the
1436         mixture of backslashes and forward slashes was confusing things.
1437
1438         This patch normalizes all of the filenames returned from
1439         test_files.find(), and adds better tests for this (fixing a
1440         couple of other bugs found in the meantime).
1441
1442         https://bugs.webkit.org/show_bug.cgi?id=53720
1443
1444         * Scripts/webkitpy/layout_tests/port/test.py:
1445         * Scripts/webkitpy/layout_tests/port/test_files.py:
1446         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1447
1448 2011-02-03  Adam Roben  <aroben@apple.com>
1449
1450         Add links to Windows crash logs in results.html
1451
1452         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
1453         results.html
1454
1455         Reviewed by David Kilzer.
1456
1457         * Scripts/old-run-webkit-tests:
1458         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
1459         createDebuggerCommandFile).
1460         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
1461         tool has exited.
1462         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
1463         it into the test results directory tree. Only implemented for Cygwin currently.
1464         (findNewestFileMatchingGlob): Added. Does what it says.
1465         (htmlForResultsSection): Only link to files that exist.
1466         (linksForErrorTest): Add a link to the crash log.
1467         (deleteExpectedAndActualResults): Delete any old crash log for this test.
1468         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
1469         hardcoding it here.
1470
1471 2011-02-03  Adam Roben  <aroben@apple.com>
1472
1473         Tell the debugger the path to the WebKit source tree when saving a crash log
1474
1475         This allows the debugger to include the crashing line of code in the log.
1476
1477         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
1478         of code
1479
1480         Reviewed by Sam Weinig.
1481
1482         * Scripts/old-run-webkit-tests:
1483         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
1484         file and returns the path to that file. The commands we pass came from
1485         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
1486         WebKit source code lives.
1487         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
1488         line using -c, save them to a file and specify the path to that file using -cf. This works
1489         around what is presumably a bug in Windows's command line parsing, where having multiple
1490         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
1491         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
1492         together to make them easier to modify in the future.
1493
1494 2011-02-02  Sam Weinig  <sam@webkit.org>
1495
1496         Reviewed by Anders Carlsson.
1497
1498         Add notification of the end of a rubber band.
1499         <rdar://problem/8940648>
1500
1501         * MiniBrowser/mac/BrowserWindowController.m:
1502         (-[BrowserWindowController awakeFromNib]):
1503         * WebKitTestRunner/TestController.cpp:
1504         (WTR::TestController::createOtherPage):
1505         (WTR::TestController::initialize):
1506         Stub out the new WKUIClient function.
1507
1508 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
1509
1510         Unreviewed.
1511
1512         Adding myself to committers.py.
1513
1514         * Scripts/webkitpy/common/config/committers.py:
1515
1516 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
1517
1518         Reviewed by Csaba Osztrogonác.
1519
1520         [Qt][WK2] MiniBrowser's window size should be 800x600
1521         https://bugs.webkit.org/show_bug.cgi?id=53670
1522
1523         Make layout test failure debugging easier.
1524         * MiniBrowser/qt/BrowserWindow.cpp:
1525         (BrowserWindow::BrowserWindow):
1526
1527 2011-02-02  Andy Estes  <aestes@apple.com>
1528
1529         Reviewed by Mark Rowe.
1530
1531         'update-webkit' should handle OpenSource and Internal using different
1532         VCSs.
1533
1534         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
1535         Internal directory.
1536
1537 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1538
1539         Reviewed by Mihai Parparita.
1540
1541         new-run-webkit-tests: hardcode the directories to scan for tests
1542         for GPU bots instead of SKIPping them. See bug 53562 for some
1543         context, but we will now hard-code the list of directories to
1544         use by default instead of skipping over directories in the
1545         expectations file. We do this so that we will be able to merge
1546         the expectations files without getting conflicting SKIP
1547         directives. Note that this change will reduce the # of tests
1548         being run on the Mac GPU bots, because we're accidentally
1549         including some today.
1550
1551         https://bugs.webkit.org/show_bug.cgi?id=53631
1552
1553         * Scripts/webkitpy/layout_tests/port/base.py:
1554         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1555         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1556
1557 2011-02-02  Sam Weinig  <sam@webkit.org>
1558
1559         Reviewed by Beth Dakin.
1560
1561         Add ChromeClient function to paint custom overhang areas.
1562         https://bugs.webkit.org/show_bug.cgi?id=53639
1563
1564         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1565         (WTR::InjectedBundlePage::InjectedBundlePage):
1566         Stub out new callback.
1567
1568 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1569
1570         Reviewed by Tony Chang.
1571
1572         new-run-webkit-tests: support chromium code paths in mock_drt
1573
1574         https://bugs.webkit.org/show_bug.cgi?id=53471
1575
1576         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1577         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1578
1579 2011-02-02  Adam Klein  <adamk@chromium.org>
1580
1581         Reviewed by Tony Chang.
1582
1583         Update new-run-webkit-tests --chromium to put output under Source/...
1584         https://bugs.webkit.org/show_bug.cgi?id=53612
1585
1586         * BuildSlaveSupport/test-result-archive:
1587         * Scripts/webkitpy/layout_tests/port/chromium.py:
1588
1589 2011-01-28  Tony Chang  <tony@chromium.org>
1590
1591         Reviewed by Eric Seidel.
1592
1593         [chromium] remove --use-test-shell from NRWT
1594         https://bugs.webkit.org/show_bug.cgi?id=53346
1595
1596         I've already started removing some of the bindings like eventSender so
1597         this already doesn't work isn't useful.  Also updated some comments to
1598         refer to DRT instead of test_shell.
1599
1600         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1601         * Scripts/webkitpy/layout_tests/port/chromium.py:
1602         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1603         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1604         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1605         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1607         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1608
1609 2011-02-02  Steve Lacey  <sjl@chromium.org>
1610
1611         Reviewed by Eric Carlson.
1612
1613         Implement basic media statistics on media elements.
1614         https://bugs.webkit.org/show_bug.cgi?id=53322
1615
1616         * Scripts/build-webkit:
1617
1618 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1619
1620         [wx] Build fixes for wxWebKit.
1621
1622         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1623         (LayoutTestController::setSerializeHTTPLoads):
1624         * wx/browser/wscript:
1625         * wx/build/build_utils.py:
1626         * wx/build/settings.py:
1627
1628 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1629
1630         Reviewed by Mihai Parparita.
1631
1632         new-run-webkit-tests: stop skipping so many tests
1633
1634         r77163 introduced a regression where we weren't resetting test
1635         expectations properly and were skipping too many tests as a
1636         result. This patch fixes that and adds a test for it.
1637
1638         https://bugs.webkit.org/show_bug.cgi?id=53551
1639
1640         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1641         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1642
1643 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1644
1645         Reviewed by Tony Chang.
1646
1647         new-run-webkit-tests: add first stub of test_runner2. This
1648         will add support for the 'inline', 'threads', and 'processes'
1649         flags to --worker-model, but for now the implementatios just
1650         fall back on the old ones.
1651
1652         https://bugs.webkit.org/show_bug.cgi?id=53157
1653
1654         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1655         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1656
1657 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
1658
1659         Reviewed by James Robinson.
1660
1661         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
1662         https://bugs.webkit.org/show_bug.cgi?id=53522
1663
1664         * Scripts/run-chromium-webkit-unit-tests:
1665
1666 2011-02-01  Adam Barth  <abarth@webkit.org>
1667
1668         Reviewed by Mihai Parparita.
1669
1670         Using Control-C to cancel webkit-patch or other python tools causes
1671         unpleasant traceback console spew
1672         https://bugs.webkit.org/show_bug.cgi?id=53462
1673
1674         Catch the exception and don't print the stack trace.
1675
1676         * Scripts/webkit-patch:
1677
1678 2011-02-01  Scott Cameron  <sccameron@rim.com>
1679
1680         Reviewed by Daniel Bates.
1681
1682         Use Windows format for MinGW HTTPD path.
1683         https://bugs.webkit.org/show_bug.cgi?id=53503
1684
1685         * Scripts/webkitperl/httpd.pm:
1686           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
1687             so that we don't have to escape the space characters in the path. Also,
1688             changed path to Windows-style path and removed FIXME comment.
1689
1690 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
1691
1692         Reviewed by Andreas Kling.
1693
1694         [Qt][WK2] Add a way to use shared process model in MiniBrowser
1695         https://bugs.webkit.org/show_bug.cgi?id=53090
1696
1697         * MiniBrowser/qt/BrowserView.cpp:
1698         (BrowserView::BrowserView): Removed the m_context member.
1699         From now the context is guaranteed to be non-null and we
1700         don't need to store that in the object.
1701         * MiniBrowser/qt/BrowserView.h:
1702         * MiniBrowser/qt/BrowserWindow.cpp:
1703         Added static bool to determine that new windows need to be
1704         created with their own context or not. Use the same context
1705         and web process by default to be inilne with the other ports.
1706         (BrowserWindow::BrowserWindow):
1707         (BrowserWindow::newWindow):
1708         * MiniBrowser/qt/BrowserWindow.h:
1709         * MiniBrowser/qt/main.cpp:
1710         (main): Added command line switch to be able to use the
1711         non-shared process model. Simplify the handling of the command line
1712         switches a little bit.
1713
1714 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1715
1716         Reviewed by Andreas Kling.
1717
1718         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
1719         https://bugs.webkit.org/show_bug.cgi?id=53491
1720
1721         * MiniBrowser/qt/BrowserWindow.cpp:
1722         (BrowserWindow::BrowserWindow):
1723         (BrowserWindow::toggleFullScreenMode):
1724         * MiniBrowser/qt/BrowserWindow.h:
1725
1726 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1727
1728         Reviewed by Andreas Kling.
1729
1730         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
1731         https://bugs.webkit.org/show_bug.cgi?id=53489
1732
1733         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
1734         to Settings menu.
1735
1736         * MiniBrowser/qt/BrowserWindow.cpp:
1737         (BrowserWindow::BrowserWindow):
1738         (BrowserWindow::toggleFrameFlattening):
1739         (BrowserWindow::toggleDisableJavaScript):
1740         (BrowserWindow::toggleAutoLoadImages):
1741         * MiniBrowser/qt/BrowserWindow.h:
1742
1743 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
1744
1745         Reviewed by Tony Chang.
1746
1747         [Chromium] Switch chromium-mac to use ChromiumDriver
1748         https://bugs.webkit.org/show_bug.cgi?id=53461
1749         
1750         For the sake of consistency with the other Chromium platforms (and so
1751         that chromium-mac picks up special flags like --enable-hardware-gpu),
1752         switch chromium-mac from the WebKitDriver to ChromiumDriver.
1753
1754         * Scripts/webkitpy/layout_tests/port/chromium.py:
1755
1756 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
1757
1758         Reviewed by Mihai Parparita.
1759
1760         The current modifier parsing code in test_expectations is
1761         fragile and hard-coded, so it's not easy to understand the logic
1762         or easily add new types of modifiers (like GPU vs. CPU testing
1763         for graphics tests, or 32-bit vs. 64-bit differences).
1764
1765         This is the first of two patches that will add in more generic
1766         support and then eliminate the GPU-specific test expectations
1767         files for Chromium.
1768
1769         This patch adds two standalone objects for handling modifiers. The
1770         rules for interpreting modifiers, precedence, and conflicts are
1771         given in the docstring to the ModifierMatcher class, which
1772         returns ModifierMatchResult objects.
1773         
1774         This patch also adds routines to the Port interface and a
1775         default set of values in the base object, in order to obtain the
1776         values needed on a given test run. These values are then passed
1777         to the expectation parser. This also allows us to clean up the
1778         logic used to lint all of the different configurations in a
1779         single test_expectations.txt file.
1780
1781         The next patch will merge in the separate GPU expectations file.
1782
1783         https://bugs.webkit.org/show_bug.cgi?id=51222
1784
1785         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1786         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1787         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1788         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1789         * Scripts/webkitpy/layout_tests/port/base.py:
1790         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1791         * Scripts/webkitpy/layout_tests/port/chromium.py:
1792         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1793         * Scripts/webkitpy/layout_tests/port/test.py:
1794         * Scripts/webkitpy/layout_tests/port/webkit.py:
1795         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1796         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1797         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1798         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
1799         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1800
1801 2011-01-31  Scott Cameron  <sccameron@rim.com>
1802
1803         Reviewed by Daniel Bates.
1804
1805         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
1806         https://bugs.webkit.org/show_bug.cgi?id=50036
1807
1808         This will add an Apache2.2 configuration file and modifies scripts to allow
1809         running an httpd server in an MSYS environment.
1810
1811         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
1812         in order to allow for simple installation/execution.  Simply install the latest
1813         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
1814         be able to execute run-webkit-httpd.
1815         
1816
1817         * Scripts/run-webkit-httpd:
1818         * Scripts/webkitperl/httpd.pm:
1819
1820 2011-01-31  Tony Chang  <tony@chromium.org>
1821
1822         Reviewed by Eric Seidel.
1823
1824         mac DRT should report RTL scroll offset relative to top right corner
1825         https://bugs.webkit.org/show_bug.cgi?id=53324
1826
1827         * DumpRenderTree/mac/DumpRenderTree.mm:
1828         (dumpFrameScrollPosition):
1829
1830 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
1831
1832         Reviewed by Andreas Kling.
1833
1834         [Qt] Add Take Screen Shot action to MiniBrowser
1835         https://bugs.webkit.org/show_bug.cgi?id=53422
1836
1837         Add Take Screen Shot action to MiniBrowser's view menu.
1838
1839         * MiniBrowser/qt/BrowserWindow.cpp:
1840         (BrowserWindow::BrowserWindow):
1841         (BrowserWindow::screenshot):
1842         * MiniBrowser/qt/BrowserWindow.h:
1843
1844 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1845
1846         Reviewed by Xan Lopez.
1847
1848         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
1849         https://bugs.webkit.org/show_bug.cgi?id=53379
1850
1851         Remove left over #ifdef's. I thought all of the conditional code
1852         had been freed from the condition, but I forgot to check DRT.
1853
1854         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1855         (resetDefaultsToConsistentValues):
1856         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1857         (LayoutTestController::setAlwaysAcceptCookies):
1858
1859 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1860
1861         Unreviewed, build fix.
1862
1863         Fix regression introduced in r77093 - path.rsplit() doesn't
1864         take keyword arguments.
1865
1866         https://bugs.webkit.org/show_bug.cgi?id=53326
1867
1868         * Scripts/webkitpy/common/system/filesystem_mock.py:
1869
1870 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1871
1872         Reviewed by Mihai Parparita.
1873
1874         Add more unit tests for rebaseline-chromium-webkit-tests. This
1875         change involves restructuring a bunch of r-c-w-t code to make it
1876         more testable as well. We also add wrapper classes for handling
1877         testing zip files and fetching URLs.
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=53040
1880
1881         * Scripts/webkitpy/common/system/urlfetcher.py:
1882         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
1883         * Scripts/webkitpy/common/system/zipfileset_mock.py:
1884         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1885         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1886         * Scripts/webkitpy/tool/mocktool.py:
1887
1888 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1889
1890         Reviewed by Eric Seidel.
1891
1892         Clean up of the filesystem-related modules used in webkitpy.
1893         I've added relpath() to the filesystem interface, modified
1894         ospath.relpath() so that it could work with the filesystem
1895         interface, and modified the fileset* routines to use the
1896         filesystem interface consistently.
1897
1898         This patch also adds a close() routine to the fileset routines
1899         to indicate that the caller is done with the fileset. This
1900         allows zipfileset to clean up after itself when it creates
1901         tempfiles to store downloads.
1902
1903         https://bugs.webkit.org/show_bug.cgi?id=53326
1904
1905         * Scripts/webkitpy/common/system/directoryfileset.py:
1906         * Scripts/webkitpy/common/system/fileset.py:
1907         * Scripts/webkitpy/common/system/filesystem.py:
1908         * Scripts/webkitpy/common/system/filesystem_mock.py:
1909         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1910         * Scripts/webkitpy/common/system/ospath.py:
1911         * Scripts/webkitpy/common/system/zipfileset.py:
1912         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1913
1914 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1915
1916         Reviewed by Csaba Osztrogonác.
1917
1918         [Qt][WK2]REGRESSION (r76991): Fix build errors
1919         https://bugs.webkit.org/show_bug.cgi?id=53400
1920
1921         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1922         and remove WebKit2Prefix.h from the build.
1923         * MiniBrowser/qt/MiniBrowser.pro:
1924
1925 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1926
1927         Unreviewed.
1928
1929         [Qt][WK2] Buildfix.
1930
1931         * MiniBrowser/qt/MiniBrowser.pro:
1932
1933 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1934
1935         Reviewed by Adam Roben.
1936         
1937         define NOMINMAX when building ImageDiff, as we do elsewhere.
1938
1939         Add various clampToInt() methods to MathExtras.h
1940         https://bugs.webkit.org/show_bug.cgi?id=52910
1941
1942         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1943
1944 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1945
1946         Reviewed by Darin Adler.
1947
1948         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1949         https://bugs.webkit.org/show_bug.cgi?id=42682
1950
1951         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1952         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1953         (WTR::InjectedBundle::resetLocalSettings):
1954         (WTR::InjectedBundle::didReceiveMessage):
1955         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1956         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1957         (WTR::LayoutTestController::setPOSIXLocale):
1958         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1959
1960 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1961  
1962          Reviewed by Mihai Parparita.
1963  
1964          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1965  
1966          This patch re-enables this test and changes it to
1967          handle all of the mac platform versions, not just the one
1968          it is running on.
1969  
1970          https://bugs.webkit.org/show_bug.cgi?id=53356
1971  
1972          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1973  
1974 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1975
1976         Unreviewed, build fix.
1977
1978         Take two. The fix in 77023 didn't work, because we were
1979         still calling path.abspath_to_uri, which calls _cygpath under
1980         the covers, and it appears the cygpath on the bots does
1981         something different than it does on my machine. This patch
1982         removes the calls to path.abspath_to_uri, so it should be safe.
1983         If it doesn't work, I'll roll it out along with r76982 and 77023.
1984
1985         https://bugs.webkit.org/show_bug.cgi?id=53126
1986
1987         * Scripts/webkitpy/layout_tests/port/test.py:
1988
1989 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1990
1991         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1992         <http://webkit.org/b/53353>
1993
1994         Reviewed by Mark Rowe.
1995
1996         * Scripts/webkitdirs.pm:
1997         (checkRequiredSystemConfig): Check the Xcode marketing version
1998         in addition to the DevCoreTools build version before complaining
1999         about an old version of Xcode.  Also make the Mac OS X version
2000         check use Perl's built-in version string comparitor.
2001
2002 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2003
2004         Unreviewed, build fix.
2005
2006         Work around breakage on Win 7 Release bot caused by r76982
2007         and the fact that windows ports use "file:////" instead of
2008         "file:///". Ideally the test code should be isolated from
2009         this, but it isn't yet. Will fix properly in a bit.
2010
2011         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2012
2013 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2014
2015         Reviewed by Tony Chang.
2016
2017         new-run-webkit-tests: change worker model values to
2018         "old-inline", "old-threads" in preparation for test_runner2 /
2019         multiprocessing changes.
2020
2021         https://bugs.webkit.org/show_bug.cgi?id=53156
2022
2023         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2024         * Scripts/webkitpy/layout_tests/port/base.py:
2025         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2026         * Scripts/webkitpy/layout_tests/port/mac.py:
2027         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2028
2029 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2030
2031         Reviewed by Tony Chang.
2032
2033         committers.py - add an IRC nickname for dpranke
2034         https://bugs.webkit.org/show_bug.cgi?id=53335
2035
2036         * Scripts/webkitpy/common/config/committers.py:
2037
2038 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2039
2040         Reviewed by Tony Chang.
2041
2042         new-run-webkit-tests: add a "mock DRT" port implementation
2043         and a separate class that emulates what we expect the
2044         DumpRenderTree behavior to be.
2045
2046         This will eventually replace port/dryrun.py and allow us to get
2047         better test coverage of the new-run-webkit-tests code as well as
2048         a reference for what new-run-webkit-tests expects from DRT.
2049
2050         This is the first attempt at this, and it is pretty bare-boned. It
2051         really only has been tested on the 'mac' port (and a little on
2052         the 'chromium-mac' port.
2053
2054         https://bugs.webkit.org/show_bug.cgi?id=53126
2055
2056         * Scripts/webkitpy/common/system/filesystem_mock.py:
2057         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2058         * Scripts/webkitpy/layout_tests/port/factory.py:
2059         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
2060         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
2061         * Scripts/webkitpy/layout_tests/port/test.py:
2062
2063 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2064
2065         Unreviewed. Removing .swp file checked in by mistake.
2066
2067         * Scripts/.webkitdirs.pm.swp: Removed.
2068
2069 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2070
2071         Reviewed by David Kilzer.
2072
2073         Space not necessary for undefined feature
2074         https://bugs.webkit.org/show_bug.cgi?id=53317
2075
2076         * Scripts/build-webkit:
2077
2078 2011-01-28  Chang Shu  <chang.shu@nokia.com>
2079
2080         Reviewed by Andreas Kling.
2081
2082         Reset NetworkAccessManager to clean up credentials from previous tests.
2083         This change causes no performance overhead either.
2084         https://bugs.webkit.org/show_bug.cgi?id=36688
2085
2086         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2087         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2088         (WebCore::DumpRenderTree::open):
2089         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2090
2091 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
2092
2093         Reviewed by Andreas Kling.
2094
2095         [Qt] Add Zoom Text Only action to MiniBrowser
2096         https://bugs.webkit.org/show_bug.cgi?id=53297
2097
2098         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
2099
2100         * MiniBrowser/qt/BrowserWindow.cpp:
2101         (BrowserWindow::BrowserWindow):
2102         (BrowserWindow::zoomIn):
2103         (BrowserWindow::zoomOut):
2104         (BrowserWindow::resetZoom):
2105         (BrowserWindow::toggleZoomTextOnly):
2106         (BrowserWindow::applyZoom):
2107         * MiniBrowser/qt/BrowserWindow.h:
2108
2109 2011-01-28  Adam Barth  <abarth@webkit.org>
2110
2111         Reviewed by Eric Seidel.
2112
2113         Add webkit-patch roll-chromium-deps
2114         https://bugs.webkit.org/show_bug.cgi?id=53288
2115
2116         This command updates the Source/WebKit/chromium/DEPS file with the
2117         last-known good revision of Chromium (or a revision specified on the
2118         command line).  I'd eventually like to turn this into a SheriffBot
2119         command, but this is the first step.
2120
2121         This patch somewhat sprawled because I needed to move a bunch of code
2122         out of ChangeLog that should never have been there in the first place.
2123         Also, I had to fix a bug in MockUser in order to test the new command.
2124
2125         * Scripts/webkitpy/common/checkout/api.py:
2126         * Scripts/webkitpy/common/checkout/changelog.py:
2127         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2128         * Scripts/webkitpy/common/checkout/deps.py: Added.
2129         * Scripts/webkitpy/common/config/urls.py:
2130         * Scripts/webkitpy/tool/commands/__init__.py:
2131         * Scripts/webkitpy/tool/commands/download_unittest.py:
2132         * Scripts/webkitpy/tool/commands/roll.py: Added.
2133         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
2134         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2135         * Scripts/webkitpy/tool/mocktool.py:
2136         * Scripts/webkitpy/tool/steps/__init__.py:
2137         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
2138         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2139         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
2140         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2141         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
2142         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2143
2144 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
2145
2146         Reviewed by Laszlo Gombos.
2147
2148         Get rid of prefix header dependency for WebKit2 build system
2149         https://bugs.webkit.org/show_bug.cgi?id=50174
2150
2151         Change the style checker so that it enforces config.h include for
2152         WebKit2.
2153
2154         * Scripts/webkitpy/style/checker.py:
2155
2156 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
2157
2158         Reviewed by Darin Adler.
2159
2160         execCommand("Paste") doesn't work in WebKitTestRunner
2161         https://bugs.webkit.org/show_bug.cgi?id=52785
2162
2163         Enable both of the settings needed to allow paste.
2164         
2165         * WebKitTestRunner/TestController.cpp:
2166         (WTR::TestController::resetStateToConsistentValues):
2167
2168 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
2169
2170         Reviewed by Andreas Kling.
2171
2172         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
2173         https://bugs.webkit.org/show_bug.cgi?id=48440
2174
2175         Preserve user input when toggling use of QGraphicsView
2176
2177         * QtTestBrowser/launcherwindow.cpp:
2178         (LauncherWindow::initializeView):
2179         (LauncherWindow::loadFinished):
2180         * QtTestBrowser/launcherwindow.h:
2181         * QtTestBrowser/mainwindow.cpp:
2182         (MainWindow::addressUrl):
2183         * QtTestBrowser/mainwindow.h:
2184
2185 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
2186
2187         Reviewed by Mihai Parparita.
2188
2189         new-run-webkit-tests: turn off pixel tests correctly by default
2190         for webkit-based ports. r70013 (bug 47510) used
2191         port.set_option_default() to attempt to set default values, but
2192         that didn't work correctly. I have removed set_option_default
2193         for now since it was only being used in two places and in three
2194         useless unit tests. There is a separate bug open to fix the
2195         option parsing (48095), so this workaround is fine for now.
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=53217
2198
2199         * Scripts/webkitpy/layout_tests/port/webkit.py:
2200         * Scripts/webkitpy/layout_tests/port/base.py:
2201         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2202
2203 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
2204
2205         Rubber-stamped by Ariya Hidayat.
2206
2207         Trivial crash fix in WTR.
2208
2209         * WebKitTestRunner/TestController.cpp:
2210         (WTR::TestController::initialize): Increase the size
2211         of the vector by one to be able to store the null character.
2212
2213 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
2214
2215         Reviewed by Csaba Osztrogonác.
2216
2217         [Qt][WK2] WTR should be initialized in the same way as DRT
2218         https://bugs.webkit.org/show_bug.cgi?id=53240
2219
2220         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2221         (WTR::activateFonts): Added missing initialization steps.
2222
2223 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
2224
2225         Unreviewed. 
2226
2227         Adding myself to committers.py.
2228
2229         * Scripts/webkitpy/common/config/committers.py:
2230
2231 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2232
2233         Reviewed by Csaba Osztrogonác.
2234
2235         [Qt] [Symbian] Move project files into Source
2236         https://bugs.webkit.org/show_bug.cgi?id=52891
2237
2238         Fix the Symbian build after the project files
2239         are moved to Source directory. On Symbian qmake
2240         needs to run in the same directory where the main
2241         pro files (WebKit.pro, Tools.pro) are located.
2242
2243         * Scripts/webkitdirs.pm: Change to the directory where the pro file
2244         is located before running qmake for Symbian. Qmake on Symbian
2245         does not properly honor the "-o" option, work it around by setting
2246         the name of the Makefile to bld.inf.
2247
2248 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
2249
2250         Reviewed by Andreas Kling.
2251
2252         [Qt] Add simple zooming features to MiniBrowser
2253         https://bugs.webkit.org/show_bug.cgi?id=53231
2254
2255         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
2256
2257         * MiniBrowser/qt/BrowserWindow.cpp:
2258         (BrowserWindow::BrowserWindow):
2259         (BrowserWindow::zoomIn):
2260         (BrowserWindow::zoomOut):
2261         (BrowserWindow::resetZoom):
2262         (BrowserWindow::updateUserAgentList):
2263         (BrowserWindow::applyZoom):
2264         * MiniBrowser/qt/BrowserWindow.h:
2265
2266 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
2267
2268         Reviewed by Dan Bernstein.
2269
2270         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
2271         https://bugs.webkit.org/show_bug.cgi?id=42319
2272         
2273         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
2274
2275         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2276         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2277         (WTR::LayoutTestController::showWebInspector):
2278         (WTR::LayoutTestController::closeWebInspector):
2279         (WTR::LayoutTestController::evaluateInWebInspector):
2280         (WTR::LayoutTestController::setTimelineProfilingEnabled):
2281         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2282         * WebKitTestRunner/TestInvocation.cpp:
2283         (WTR::shouldOpenWebInspector):
2284         (WTR::TestInvocation::invoke):
2285         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2286
2287 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
2288
2289         Reviewed by Xan Lopez.
2290
2291         [GTK] Pixel dumps do not include scrollbars in output images
2292         https://bugs.webkit.org/show_bug.cgi?id=53216
2293
2294         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
2295         that have scrollbars.
2296
2297         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2298         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
2299         instead of the web view itself.
2300
2301 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2302
2303         Reviewed by Mihai Parparita.
2304
2305         Fix regression introduced in r76322 ... new-run-webkit-tests
2306         was attempting to save the image diff output as a UTF-8-encoded
2307         file.
2308
2309         https://bugs.webkit.org/show_bug.cgi?id=53210
2310
2311         * Scripts/webkitpy/layout_tests/port/webkit.py:
2312
2313 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2314
2315         Unreviewed, rolling out r76709.
2316         http://trac.webkit.org/changeset/76709
2317         https://bugs.webkit.org/show_bug.cgi?id=53194
2318
2319         "broke python tests on non-snowleopard platforms" (Requested
2320         by dpranke on #webkit).
2321
2322         * Scripts/webkitpy/layout_tests/port/factory.py:
2323         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
2324         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
2325
2326 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2327
2328         Reviewed by Tony Chang.
2329
2330         new-run-webkit-tests: add a "mock DRT" port implementation
2331         and a separate class that emulates what we expect the
2332         DumpRenderTree behavior to be.
2333
2334         This will eventually replace port/dryrun.py and allow us to get
2335         better test coverage of the new-run-webkit-tests code as well as
2336         a reference for what new-run-webkit-tests expects from DRT.
2337
2338         This is the first attempt at this, and it is pretty bare-boned. It
2339         really only has been tested on the 'mac' port (and a little on
2340         the 'chromium-mac' port.
2341
2342         https://bugs.webkit.org/show_bug.cgi?id=53126
2343
2344         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
2345         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
2346         * Scripts/webkitpy/layout_tests/port/factory.py:
2347
2348 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
2349
2350         Reviewed by Tony Chang.
2351
2352         Add '--no-timeout' option to Chromium DRT to ease debugging.
2353         https://bugs.webkit.org/show_bug.cgi?id=52873
2354
2355         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2356         (main):
2357
2358 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2359
2360         Reviewed by Andreas Kling.
2361
2362         [Qt] Fix qt_minimal build
2363         https://bugs.webkit.org/show_bug.cgi?id=53172
2364
2365         * QtTestBrowser/locationedit.h:
2366
2367 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
2368
2369         Reviewed by Antonio Gomes.
2370
2371         QtTestBrowser should have a UI Setting to disable plugins
2372         https://bugs.webkit.org/show_bug.cgi?id=52408
2373         
2374         Added a new action item named "Disable Plugins"
2375         under the "Settings" menu. 
2376
2377         * QtTestBrowser/launcherwindow.cpp:
2378         (LauncherWindow::createChrome):
2379         (LauncherWindow::togglePlugins):
2380         * QtTestBrowser/launcherwindow.h:
2381
2382 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2383
2384         Reviewed by Adam Barth.
2385
2386         Move main CMakeLists.txt into Source directory
2387         https://bugs.webkit.org/show_bug.cgi?id=52888
2388
2389         * Scripts/webkitdirs.pm:
2390
2391 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2392
2393         Reviewed by Eric Seidel.
2394
2395         Improve label text in submit-to-ews
2396         https://bugs.webkit.org/show_bug.cgi?id=53130
2397
2398         * QueueStatusServer/templates/submittoews.html:
2399
2400 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
2401
2402         Reviewed by Antonio Gomes.
2403
2404         QtTestBrowser should have a UI Settings to prevent loading images
2405         https://bugs.webkit.org/show_bug.cgi?id=52409
2406         
2407         Added a new action item named "DisableAutoLoadImages"
2408         under the "Settings" menu 
2409
2410         * QtTestBrowser/launcherwindow.cpp:
2411         (LauncherWindow::createChrome):
2412         (LauncherWindow::toggleAutoLoadImages):
2413         * QtTestBrowser/launcherwindow.h:
2414
2415 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
2416
2417         Reviewed by Tony Chang.
2418
2419         Minor bug fixes and cleanup for filesystem wrappers, port/* test
2420         classes, test_expectations.py. This change adds "test-win" and
2421         "test-mac" variants to the test port so that we can better test
2422         rebaselining, and adds a MockUser() object for reuse in testing.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=53036
2425
2426         * Scripts/webkitpy/common/system/filesystem.py:
2427         * Scripts/webkitpy/common/system/filesystem_mock.py:
2428         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2429         * Scripts/webkitpy/layout_tests/port/factory.py:
2430         * Scripts/webkitpy/layout_tests/port/base.py:
2431         * Scripts/webkitpy/layout_tests/port/test.py:
2432         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2433         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2434         * Scripts/webkitpy/tool/mocktool.py:
2435
2436 2011-01-25  Tony Chang  <tony@chromium.org>
2437
2438         Reviewed by Dimitri Glazkov.
2439
2440         [chromium] remove unused layoutTestController callback
2441         https://bugs.webkit.org/show_bug.cgi?id=53103
2442
2443         This method is used by a test_shell_test, but not needed by DRT.
2444
2445         * DumpRenderTree/chromium/LayoutTestController.cpp:
2446         (LayoutTestController::LayoutTestController):
2447         * DumpRenderTree/chromium/LayoutTestController.h:
2448
2449 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2450
2451         Reviewed by Andreas Kling.
2452
2453         [GTK] Remove 64 bits release bot from the buildbot master
2454         https://bugs.webkit.org/show_bug.cgi?id=52899
2455
2456         Removes the 64 bits release slave from the buildbot configuration,
2457         so that we can use it as an EWS.
2458
2459         * BuildSlaveSupport/build.webkit.org-config/config.json:
2460
2461 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2462
2463         Reviewed by Dan Bernstein.
2464
2465         Implement database quota callback to fix storage tests on WebKit2 bot
2466         https://bugs.webkit.org/show_bug.cgi?id=53064
2467
2468         * WebKitTestRunner/TestController.cpp:
2469         (WTR::exceededDatabaseQuota):
2470         (WTR::TestController::createOtherPage):
2471         (WTR::TestController::initialize):
2472
2473 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2474
2475         Reviewed by Anders Carlsson.
2476
2477         Use designated temp directory for the database for WebKit2
2478         https://bugs.webkit.org/show_bug.cgi?id=53052
2479         
2480         Adopt the new WK2 API for this.
2481
2482         * WebKitTestRunner/TestController.cpp:
2483         (WTR::TestController::libraryPathForTesting):
2484         (WTR::TestController::initialize):
2485         * WebKitTestRunner/TestController.h:
2486         * WebKitTestRunner/mac/TestControllerMac.mm:
2487         (WTR::TestController::platformLibraryPathForTesting):
2488         * WebKitTestRunner/qt/TestControllerQt.cpp:
2489         (WTR::TestController::platformLibraryPathForTesting):
2490         * WebKitTestRunner/win/TestControllerWin.cpp:
2491         (WTR::TestController::platformLibraryPathForTesting):
2492
2493 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2494
2495         Reviewed by Stephanie Lewis.
2496
2497         Add a new Leopard test bot.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/config.json:
2500
2501 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2502
2503         Reviewed by Adam Barth.
2504
2505         Add EFL Builder to core waterfall
2506         https://bugs.webkit.org/show_bug.cgi?id=52704
2507
2508         Add EFL Builder to the core waterfall again.
2509
2510         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2511         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2512
2513 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
2514
2515         Reviewed by Tony Chang.
2516
2517         new-run-webkit-tests fails to start HTTP server if there are proxy settings
2518         https://bugs.webkit.org/show_bug.cgi?id=52872
2519
2520         Force disabling proxy to resolve the problem.
2521
2522         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2523         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2524
2525 2011-01-24  Andreas Kling  <kling@webkit.org>
2526
2527         Reviewed by Darin Adler.
2528
2529         check-webkit-style: Update exemptions following Source/ move.
2530         https://bugs.webkit.org/show_bug.cgi?id=53017
2531
2532         * Scripts/webkitpy/style/checker.py:
2533         * Scripts/webkitpy/style/checker_unittest.py:
2534
2535 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2536
2537         Rubber-stamped by Csaba Osztrogonác.
2538
2539         [Qt] Move project files into Source
2540         https://bugs.webkit.org/show_bug.cgi?id=52891
2541
2542         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
2543
2544 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2545
2546         Reviewed by Yury Semikhatsky.
2547
2548         Web Inspector: Find duplicate strings in localizedStrings.js
2549
2550         https://bugs.webkit.org/show_bug.cgi?id=53005
2551
2552         * Scripts/check-inspector-strings:
2553
2554 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
2555
2556         Reviewed by Andreas Kling.
2557
2558         [Qt] Regroup MiniBrowser's menubar and add open file action
2559         https://bugs.webkit.org/show_bug.cgi?id=53000
2560
2561         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
2562
2563         * MiniBrowser/qt/BrowserWindow.cpp:
2564         (BrowserWindow::BrowserWindow):
2565         (BrowserWindow::openFile):
2566         (BrowserWindow::~BrowserWindow):
2567         * MiniBrowser/qt/BrowserWindow.h:
2568
2569 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
2570
2571         Unreviewed fix after r76496
2572
2573         [Qt] Move project files into Source
2574         https://bugs.webkit.org/show_bug.cgi?id=52891
2575
2576         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
2577         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
2578         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2579
2580 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2581
2582         Reviewed by Csaba Osztrogonác.
2583
2584         [Qt] Move project files into Source
2585         https://bugs.webkit.org/show_bug.cgi?id=52891
2586
2587         * DerivedSources.pro: Renamed from DerivedSources.pro.
2588         * DumpRenderTree/qt/DumpRenderTree.pro:
2589         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2590         * MiniBrowser/DerivedSources.pro:
2591         * MiniBrowser/qt/MiniBrowser.pro:
2592         * QtTestBrowser/QtTestBrowser.pro:
2593         * Scripts/webkitdirs.pm:
2594         * Tools.pro: Added.
2595         * WebKitTestRunner/DerivedSources.pro:
2596         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2597         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2598
2599 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2600
2601         Reviewed by Dan Bernstein.
2602
2603         Beefed up --threaded mode to catch even more kinds of errors.
2604         https://bugs.webkit.org/show_bug.cgi?id=52971
2605
2606         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
2607         context group to force JSC to mark multiple threads. (This used to be
2608         the default, but it changed in SnowLeopard.)
2609         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
2610         to give threading mistakes more chances to show themselves.
2611         (startJavaScriptThreads):
2612         (stopJavaScriptThreads):
2613
2614 2011-01-22  Robert Hogan  <robert@webkit.org>
2615
2616         Reviewed by Andreas Kling.
2617
2618         [Qt] Support layoutTestController.addURLToRedirect()
2619         https://bugs.webkit.org/show_bug.cgi?id=52956
2620
2621         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2622         (LayoutTestController::addURLToRedirect):
2623         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2624
2625 2011-01-22  Robert Hogan  <robert@webkit.org>
2626
2627         Reviewed by Kenneth Rohde Christiansen.
2628
2629         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
2630         https://bugs.webkit.org/show_bug.cgi?id=49802
2631
2632         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2633         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2634         (WebCore::DumpRenderTree::open):
2635
2636 2011-01-21  Adam Barth  <abarth@webkit.org>
2637
2638         Reviewed by Maciej Stachowiak.
2639
2640         Disable mac_unittest.py that fails on some of the Mac bots
2641         https://bugs.webkit.org/show_bug.cgi?id=52947
2642
2643         As noted in the comment, this test does not appear to be correct
2644         because the function this test is testing returns different results
2645         depending on which flavor of Mac the test is run on.  This patch
2646         disable the test.  Hopefully we can re-enable the test once we've
2647         probably insulated the test from its environment.
2648
2649         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2650
2651 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2652
2653         Reviewed by Mihai Parparita.
2654
2655         Fix bug introduced in r76322 that caused NRWT to not actually
2656         read the Skipped files properly.
2657
2658         https://bugs.webkit.org/show_bug.cgi?id=52771
2659
2660         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2661         * Scripts/webkitpy/layout_tests/port/webkit.py:
2662         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2663
2664 2011-01-21  Sam Weinig  <sam@webkit.org>
2665
2666         Reviewed by Geoffrey Sean Garen and Mark Rowe.
2667
2668         WebKitTestRunner needs the HOME environment variable to be set.
2669         <rdar://problem/8896573>
2670
2671         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
2672         it exists.
2673
2674 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2675
2676         Reviewed by Eric Seidel.
2677
2678         Suppress a few remaining integration tests so that none of the
2679         layout_test unit tests ever read from the filesystem or launch
2680         subprocesses that aren't part of the unit tests.
2681
2682         Also fix a minor bug in the printing unit tests that was
2683         incorrectly relying on sys.argv.
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=52863
2686
2687         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2688         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2689         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2690
2691 2011-01-21  Darin Adler  <darin@apple.com>
2692
2693        Fix Mac build.
2694
2695         * MiniBrowser/mac/BrowserWindowController.m:
2696         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
2697
2698 2011-01-20  Darin Adler  <darin@apple.com>
2699
2700         Reviewed by Dan Bernstein.
2701
2702         WebKit2: Implement showModalDialog
2703         https://bugs.webkit.org/show_bug.cgi?id=52855
2704
2705         This fixes WebKitTestRunner to compile, but more work is probably
2706         needed to get it to pass the tests.
2707
2708         * WebKitTestRunner/TestController.cpp:
2709         (WTR::TestController::runModal): Added. Calls through to the
2710         platform-specific version of runModal.
2711         (WTR::TestController::createOtherPage): Changed to be a private
2712         static member function so it can refer to runModal, which is
2713         a private static member function.
2714         (WTR::TestController::initialize): Pass 0 for the runModal
2715         function since we don't need to run the main window modal.
2716         I suspect this is wrong and will need to change.
2717         * WebKitTestRunner/TestController.h: Added declarations for
2718         the functions added above.
2719         * WebKitTestRunner/mac/TestControllerMac.mm:
2720         (WTR::TestController::runModal): Added. Untested implementation.
2721         * WebKitTestRunner/qt/TestControllerQt.cpp:
2722         (WTR::TestController::runModal): Added.
2723         * WebKitTestRunner/win/TestControllerWin.cpp:
2724         (WTR::TestController::runModal): Added.
2725
2726 2011-01-21  Eric Seidel  <eric@webkit.org>
2727
2728         Reviewed by Adam Barth.
2729
2730         Split Host object off from WebKitPatch for easier re-use
2731         https://bugs.webkit.org/show_bug.cgi?id=52284
2732
2733         new-run-webkit-tests and other tools are eventually going to want one of these.
2734         Basically you need to inherit from this class if you want to pretend to be a
2735         self.tool object for Steps/Commands.
2736
2737         * Scripts/webkitpy/common/host.py: Added.
2738         * Scripts/webkitpy/tool/main.py:
2739
2740 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2741
2742         Reviewed by Adam Barth.
2743
2744         Disable the tests that start and stop the http server and web
2745         server, so that we don't have to worry about port collisions on
2746         the bots.
2747
2748         https://bugs.webkit.org/show_bug.cgi?id=52861
2749
2750         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2751
2752 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2753
2754         Reviewed by Eric Seidel.
2755
2756         nrwt: rewrite google_chrome_unittest to use mock filesystem.
2757         
2758         https://bugs.webkit.org/show_bug.cgi?id=52772
2759         
2760         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2761
2762 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2763
2764         Reviewed by Eric Siedel.
2765
2766         nrwt: clean up almost all remaining port references, remove
2767         unnecessary import clauses. The only remaining references are
2768         in places where a mock filesystem makes no sense or can't be
2769         used, and in one routine in port/google_chrome_unittest that
2770         I'll rewrite in a separate patch.
2771
2772         https://bugs.webkit.org/show_bug.cgi?id=52771
2773
2774         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2775         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2776         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2777         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2778         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2779         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2780         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2781         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2782         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2783         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2784         * Scripts/webkitpy/layout_tests/port/gtk.py:
2785         * Scripts/webkitpy/layout_tests/port/mac.py:
2786         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2787         * Scripts/webkitpy/layout_tests/port/qt.py:
2788         * Scripts/webkitpy/layout_tests/port/webkit.py:
2789         * Scripts/webkitpy/layout_tests/port/win.py:
2790         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2791
2792 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2793
2794         Reviewed by Mihai Parparita.
2795
2796         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
2797
2798         https://bugs.webkit.org/show_bug.cgi?id=52762
2799
2800         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2801         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2802
2803 2011-01-20  Tony Chang  <tony@chromium.org>
2804
2805         Reviewed by Ojan Vafai.
2806
2807         [chromium] fix the paths used for the rebaseline tool
2808         https://bugs.webkit.org/show_bug.cgi?id=52857
2809
2810         Some of the bots were renamed so the path to grab the results zip
2811         file has changed.
2812
2813         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2814
2815 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2816
2817         Reviewed by Tony Chang.
2818
2819         Fix bug introduced in r72688 / bug 52768 that broke the
2820         generation of the output filename links in the results.html
2821         output. Apparently none of the unit tests actually checked to
2822         make sure the generated links were correct :(
2823
2824         https://bugs.webkit.org/show_bug.cgi?id=52854
2825
2826         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2827         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2828
2829 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
2830
2831         Reviewed by Darin Adler.
2832
2833         https://bugs.webkit.org/show_bug.cgi?id=52849
2834         Make window.print work with WebKit2
2835
2836         * MiniBrowser/mac/BrowserWindowController.m:
2837         (-[BrowserWindowController awakeFromNib]):
2838         * WebKitTestRunner/TestController.cpp:
2839         (WTR::createOtherPage):
2840         (WTR::TestController::initialize):
2841         Added zeroes to WKPageUIClient structures to avoid build failures.
2842
2843 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2844
2845         Reviewed by Eric Seidel.
2846
2847         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
2848
2849         https://bugs.webkit.org/show_bug.cgi?id=52756
2850
2851         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2852         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2853         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2854         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2855         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2856         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2857
2858 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
2859
2860         Reviewed by Antonio Gomes.
2861
2862         QtTestBrowser should have a seperate menu for Settings
2863         https://bugs.webkit.org/show_bug.cgi?id=52817
2864         
2865         Added a new menu item named "Settings"
2866         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
2867
2868         * QtTestBrowser/launcherwindow.cpp:
2869         (LauncherWindow::createChrome):
2870
2871 2011-01-20  Sam Weinig  <sam@webkit.org>
2872
2873         Reviewed by John Sullivan.
2874
2875         Update update-webkit-localizable-strings with new path to WebKit.
2876
2877         * Scripts/update-webkit-localizable-strings:
2878
2879 2011-01-20  James Robinson  <jamesr@chromium.org>
2880
2881         Reviewed by Darin Fisher.
2882
2883         Implement mozilla's requestAnimationFrame API
2884         https://bugs.webkit.org/show_bug.cgi?id=51218
2885
2886         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2887
2888         * DumpRenderTree/chromium/WebViewHost.cpp:
2889         (invokeScheduleComposite):
2890         (WebViewHost::scheduleAnimation):
2891         (WebViewHost::paintInvalidatedRegion):
2892         * DumpRenderTree/chromium/WebViewHost.h:
2893
2894 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
2895
2896         Reviewed by Adam Roben.
2897
2898         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
2899         https://bugs.webkit.org/show_bug.cgi?id=42327
2900
2901         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
2902         for methods that take their normal arguments but also a JSContextRef.
2903         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
2904         for evaluateScriptInIsolatedWorld.
2905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2906         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
2907         this call is for an isolated world.
2908         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2909         (WTR::worldMap): Helper to create a world map.
2910         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
2911         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
2912         added LayoutTestController API.
2913         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2914
2915 2011-01-19  Adam Roben  <aroben@apple.com>
2916
2917         Convert paths in environment variables back to msys-style inside commit-log-editor
2918
2919         When this script gets run from inside git commit, msys-style paths in the environment will
2920         have been turned into Windows-style paths with forward slashes. This screws up functions
2921         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2922         the paths back to msys-style before doing anything else.
2923
2924         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2925         using msysgit's Perl and multiple ChangeLogs have been edited
2926
2927         Reviewed by David Kilzer.
2928
2929         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2930         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2931         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2932
2933 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2934
2935         [Win] Unreviewed build fix after r76248.
2936
2937         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2938
2939 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2940
2941         Reviewed by Csaba Osztrogonác.
2942
2943         Refactoring of the custom allocation framework
2944         https://bugs.webkit.org/show_bug.cgi?id=49897
2945
2946         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2947         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2948         equivalent macro implementation at the necessary places.
2949 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2950
2951         Unreviewed. 
2952
2953         Adding myself to committers.py.
2954
2955         * Scripts/webkitpy/common/config/committers.py:
2956
2957 2011-01-20  Adam Barth  <abarth@webkit.org>
2958
2959         Reviewed by Tony Chang.
2960
2961         Chromium builders don't delete unversioned directories when DEPS change
2962         https://bugs.webkit.org/show_bug.cgi?id=52745
2963
2964         If we pass this option to gclient sync, gclient will delete directories
2965         that are no longer part of DEPS instead of leaving them around to
2966         confuse us later.  Apparently, the downstream buildbots use this option
2967         already.
2968
2969         * Scripts/update-webkit-chromium:
2970
2971 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2972
2973         Unreviewed, build fix - I pulled this patch in to fix an issue
2974         revealed by r76195 running on some new bots). Also fix a couple
2975         of other issues revealed in testing.
2976
2977         nrwt: remove fs refs from layout_package/json*
2978
2979         https://bugs.webkit.org/show_bug.cgi?id=52754
2980
2981         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2982         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2983         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2984         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2985         * Scripts/webkitpy/layout_tests/port/base.py:
2986
2987 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2988
2989         Unreviewed, build fix.
2990
2991         Fix a couple of minor bugs discovered while bringing up new bots
2992         for testing.
2993
2994         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2996
2997 2011-01-19  James Robinson  <jamesr@chromium.org>
2998
2999         Unreviewed, rolling out r76194.
3000         http://trac.webkit.org/changeset/76194
3001         https://bugs.webkit.org/show_bug.cgi?id=51218
3002
3003         Caused mysterious compile failure on the chromium win
3004         build.webkit.org bots
3005
3006         * DumpRenderTree/chromium/WebViewHost.cpp:
3007         (WebViewHost::paintInvalidatedRegion):
3008         * DumpRenderTree/chromium/WebViewHost.h:
3009
3010 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3011
3012         Reviewed by Mihai Parparita.
3013
3014         remove fs refs from test_runner, dump_render_tree_thread
3015
3016         https://bugs.webkit.org/show_bug.cgi?id=52753
3017
3018         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3019         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3020         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3021         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3022
3023 2011-01-19  James Robinson  <jamesr@chromium.org>
3024
3025         Reviewed by Darin Fisher.
3026
3027         Implement mozilla's requestAnimationFrame API
3028         https://bugs.webkit.org/show_bug.cgi?id=51218
3029
3030         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
3031
3032         * DumpRenderTree/chromium/WebViewHost.cpp:
3033         (invokeScheduleComposite):
3034         (WebViewHost::scheduleAnimation):
3035         (WebViewHost::paintInvalidatedRegion):
3036         * DumpRenderTree/chromium/WebViewHost.h:
3037
3038 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3039
3040         Unreviewed, build fix.
3041
3042         Fix a few incorrect "self._filesystem" references introduced in
3043         r76184.
3044
3045         * Scripts/webkitpy/layout_tests/port/chromium.py:
3046         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3047
3048 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3049
3050         Reviewed by Mihai Parparita.
3051
3052         add a .sep property, abspath(), isabs(), mtime(), and
3053         open_text_file_for_writing() to filesystem modules. Some of
3054         these properties are not needed in this patch but will be needed
3055         in subsequent patches (I'm doing this to avoid having to track
3056         multiple versions of a single file).
3057
3058         Also, change most of the port/* modules to use the filesystem
3059         objects instead of referencing the filesystem directly.
3060
3061         https://bugs.webkit.org/show_bug.cgi?id=52748
3062
3063         * Scripts/webkitpy/common/system/filesystem.py:
3064         * Scripts/webkitpy/common/system/filesystem_mock.py:
3065         * Scripts/webkitpy/layout_tests/port/__init__.py:
3066         * Scripts/webkitpy/layout_tests/port/base.py:
3067         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3068         * Scripts/webkitpy/layout_tests/port/chromium.py:
3069         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3070         * Scripts/webkitpy/layout_tests/port/config.py:
3071         * Scripts/webkitpy/layout_tests/port/test.py:
3072         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3073
3074 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
3075
3076         Reviewed by Anders Carlsson.
3077
3078         If resetting between tests times out, treat it as a WebProcess crash
3079         https://bugs.webkit.org/show_bug.cgi?id=52757
3080
3081         * WebKitTestRunner/TestController.cpp:
3082         (WTR::TestController::runTest):
3083
3084 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
3085
3086         Reviewed by Darin Adler.
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=52739
3089         Make it possible for a WebKit2 client to print headers and footers
3090
3091         Added dummy implementations for new printing UIClient calls.
3092
3093         * MiniBrowser/mac/BrowserWindowController.m:
3094         (-[BrowserWindowController awakeFromNib]):
3095         * WebKitTestRunner/TestController.cpp:
3096         (WTR::createOtherPage):
3097         (WTR::TestController::initialize):
3098
3099 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3100
3101         Reviewed by Ojan Vafai.
3102
3103         Change webkitpy/layout_tests/port/test.py to use the
3104         in-memory filesystem for cleaner unit testing. This
3105         change allows us to kill a lot of code that was
3106         specific to the test port, at the cost of being a
3107         little less clear about how things would work if
3108         you didn't have a filesystem.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=52605
3111
3112         * Scripts/webkitpy/layout_tests/port/test.py:
3113
3114 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3115
3116         Unreviewed, build fix.
3117
3118         Fix test failure caused by committing attachment 79368 instead
3119         of attachment 79461 on bug 52604.
3120
3121         * Scripts/webkitpy/common/system/filesystem_mock.py:
3122
3123 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3124
3125         Reviewed by Mihai Parparita.
3126
3127         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
3128         unit testing. os.walk() is too much of a hassle to implement on
3129         top of the in-memory mock filesystem and adding the necessary
3130         interface to files_under() gives clients a cleaner API anyway
3131         (for this particular usage model).
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=52691
3134
3135         * Scripts/webkitpy/common/system/filesystem.py:
3136         * Scripts/webkitpy/common/system/filesystem_mock.py:
3137         * Scripts/webkitpy/layout_tests/port/test_files.py:
3138         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3139
3140 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3141
3142         Reviewed by Tony Chang.
3143
3144         Change more modules in the layout-tests code to use the
3145         filesystem wrapper for cleaner unit testing.
3146
3147         This patch also adds the glob() wrapper to the filesystem
3148         abstraction.
3149         
3150         https://bugs.webkit.org/show_bug.cgi?id=52604
3151
3152         * Scripts/webkitpy/layout_tests/port/test_files.py:
3153         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3154         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3155         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3156         * Scripts/webkitpy/common/system/filesystem.py:
3157         * Scripts/webkitpy/common/system/filesystem_mock.py:
3158
3159 2011-01-19  Levi Weintraub  <leviw@chromium.org>
3160
3161         Unreviewed.
3162
3163         Updating my email addresses and irc nick.
3164
3165         * Scripts/webkitpy/common/config/committers.py:
3166
3167 2011-01-19  Tony Chang  <tony@chromium.org>
3168
3169         Reviewed by Mihai Parparita.
3170
3171         [chromium] [linux] if check-sys-deps fails, output the failure reason
3172         https://bugs.webkit.org/show_bug.cgi?id=52671
3173
3174         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
3175             error handler functions.
3176         * Scripts/webkitpy/layout_tests/port/chromium.py:
3177             output the error text from --check-sys-deps
3178         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3179
3180 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
3181
3182         Reviewed by Andreas Kling.
3183
3184         [Qt] QtTestBrowser crashes when closing if Facebook is opened
3185         https://bugs.webkit.org/show_bug.cgi?id=52554
3186         
3187         QtNetworkAccessManager is created in a thread and set as
3188         member variable in QWebPage. When the thread is destroyed
3189         the object is still used. So fix will set the object to
3190         NULL once the thread is destroyed.
3191
3192         * QtTestBrowser/launcherwindow.cpp:
3193         (LauncherWindow::~LauncherWindow):
3194
3195 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3196
3197         Rubber stamped by Csaba Osztrogonac
3198
3199         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
3200
3201 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3202
3203         Reviewed by Tony Chang.
3204
3205         new-run-webkit-tests: add a --build-directory command line argument
3206
3207         Official Google Chrome builds use a non-standard build directory
3208         location. This patch adds a --build-directory argument that
3209         allows that location to be specified on the command line. Only
3210         Chromium-based builds will use this flag for now, but anyone can
3211         in the future.
3212
3213         There are no unit tests for this since it's difficult to test
3214         until mock filesystems are fully supported in the code. This was
3215         tested by hand for now.
3216
3217         https://bugs.webkit.org/show_bug.cgi?id=52694
3218
3219         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3220         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3221         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3222         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3223
3224 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3225
3226         Not reviewed. Bot fix.
3227
3228         Remove an inadvertently committed debugging print.
3229
3230         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3231         (LayoutTestController::notifyDone):
3232
3233 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3234
3235         Reviewed by Sam Weinig.
3236
3237         WebKitTestRunner should track loading more like DumpRenderTree
3238         https://bugs.webkit.org/show_bug.cgi?id=52692
3239
3240         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
3241         This makes some tests that call notifyDone multiple times pass.
3242         
3243         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3244         (WTR::InjectedBundle::InjectedBundle):
3245         (WTR::InjectedBundle::done):
3246         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3247         (WTR::InjectedBundle::topLoadingFrame):
3248         (WTR::InjectedBundle::setTopLoadingFrame):
3249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3250         (WTR::InjectedBundlePage::InjectedBundlePage):
3251         (WTR::InjectedBundlePage::stopLoading):
3252         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3253         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3254         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3255         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3256         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3257         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3258         (WTR::LayoutTestController::notifyDone):
3259         * WebKitTestRunner/TestController.cpp:
3260         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3261
3262 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
3263
3264         Reviewed by Kent Tamura.
3265
3266         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
3267         https://bugs.webkit.org/show_bug.cgi?id=52678
3268         
3269         Update path now that WebKit is inside Source.
3270
3271         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3272
3273 2011-01-18  Robert Hogan  <robert@webkit.org>
3274
3275         Reviewed by Simon Hausmann.
3276
3277         [Qt] http/tests/incremental/slow-utf8-text.pl fails
3278         https://bugs.webkit.org/show_bug.cgi?id=44282
3279
3280         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3281         (WebCore::DumpRenderTree::dump):
3282
3283 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3284
3285         Reviewed by Mihai Parparita.
3286
3287         Fix a small race condition that could cause the unit tests for
3288         new-run-webkit-tests to fail in a multithreaded environment.
3289         There was a small window in the code where one thread would
3290         check to see if a thread had raised an exception, do something,
3291         and then check to see if the thread was alive. If the other
3292         thread raised an exception and exited in between these two
3293         steps, the exception would be lost. Flipping the order of the
3294         two checks fixes the race, since we will now always check for an
3295         exception on the thread before exiting.
3296
3297         https://bugs.webkit.org/show_bug.cgi?id=51579
3298
3299         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3300
3301 2011-01-18  Eric Seidel  <eric@webkit.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         commit-queue dies when test archiving fails
3306         https://bugs.webkit.org/show_bug.cgi?id=52617
3307
3308         I looked at the machine and it had 10 archives already
3309         thus find_unused_name was returning None.  I've upped
3310         the limit to 100 (per bug) and tested the case where
3311         find_unused_name returns None (making archive return None).
3312
3313         * Scripts/webkitpy/common/system/workspace.py:
3314         * Scripts/webkitpy/common/system/workspace_unittest.py:
3315         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3316         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3317         * Scripts/webkitpy/tool/commands/queues.py:
3318
3319 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3320
3321         Reviewed by Ojan Vafai.
3322
3323         Update rebaseline-chromium-webkit-tests unit tests to use a mock
3324         filesystem. Also fix a couple of "with" statements missed by
3325         r76050.
3326
3327         https://bugs.webkit.org/show_bug.cgi?id=52487
3328
3329         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3330
3331 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
3332
3333         Reviewed by Martin Robinson.
3334
3335         [Gtk] Build fixes for gtk3 build
3336         https://bugs.webkit.org/show_bug.cgi?id=52648
3337
3338         * DumpRenderTree/gtk/EventSender.cpp:
3339         (beginDragWithFilesCallback):
3340
3341 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3342
3343         Reviewed by Mihai Parparita.
3344
3345         Update rebaseline-chromium-webkit-tests to use filesystem objects
3346         instead of direct references to os.path, shutil, tempfile, etc.
3347
3348         This patch doesn't change anything, but will allow subsequent
3349         patches to change the unit tests to no longer use the real
3350         filesystem.
3351
3352         This patch adds a bunch more methods to the filesystem object as
3353         well.
3354
3355         https://bugs.webkit.org/show_bug.cgi?id=52482
3356
3357         * Scripts/webkitpy/common/system/filesystem.py:
3358         * Scripts/webkitpy/common/system/filesystem_mock.py:
3359         * Scripts/webkitpy/tool/commands/queues.py:
3360         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3361         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3362
3363 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3364
3365         Reviewed by Mihai Parparita.
3366
3367         new-run-webkit-tests shouldn't crash when you try to run a
3368         directory containing only skipped files.
3369
3370         https://bugs.webkit.org/show_bug.cgi?id=52478
3371         
3372         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3373         * Scripts/webkitpy/layout_tests/port/test.py:
3374         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3375
3376 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
3377
3378         Reviewed by Gustavo Noronha Silva.
3379
3380         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
3381         https://bugs.webkit.org/show_bug.cgi?id=40833
3382
3383         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
3384         GTK+ event sender.
3385         (dragWithFilesDragDataGetCallback): Added.
3386         (dragWithFilesDragEndCallback): Added.
3387         (beginDragWithFilesCallback): Added.
3388
3389 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3390
3391         Reviewed by Adam Barth.
3392
3393         ews: Add additional watcher to efl ews
3394         https://bugs.webkit.org/show_bug.cgi?id=52613
3395
3396         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
3397
3398         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3399
3400 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
3401
3402         Reviewed by Alexey Proskuryakov.
3403
3404         Fix some headers with missing or misspelled #ifndef guards
3405         https://bugs.webkit.org/show_bug.cgi?id=52545
3406
3407         * DumpRenderTree/chromium/TestEventPrinter.h:
3408         * DumpRenderTree/chromium/WebPreferences.h:
3409
3410 2011-01-17  Jessie Berlin  <jberlin@apple.com>
3411
3412         Reviewed by Anders Carlsson.
3413
3414         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
3415         navigating back to an unreachable URL
3416         https://bugs.webkit.org/show_bug.cgi?id=52388
3417
3418         Add a third parameter (unreachableURL) to queueLoadHTMLString.
3419
3420         * DumpRenderTree/LayoutTestController.cpp:
3421         (queueLoadHTMLStringCallback):
3422         (LayoutTestController::queueLoadHTMLString):
3423         (LayoutTestController::queueLoadAlternateHTMLString):
3424         * DumpRenderTree/LayoutTestController.h:
3425
3426         * DumpRenderTree/WorkQueueItem.h:
3427         (LoadHTMLStringItem::LoadHTMLStringItem):
3428
3429         * DumpRenderTree/chromium/LayoutTestController.cpp:
3430         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3431         (WorkItemLoadHTMLString::run):
3432         (LayoutTestController::queueLoadHTMLString):
3433
3434         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3435         (LoadHTMLStringItem::invoke):
3436         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3437         (LoadHTMLStringItem::invoke):
3438         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3439         (LoadHTMLStringItem::invoke):
3440
3441 2011-01-17  Dan Bernstein  <mitz@apple.com>
3442
3443         Rubber-stamped by Mark Rowe.
3444
3445         Update xcodeproj svn:ignore to include xcuserdata.
3446
3447         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3448         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3450         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3451         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3452
3453 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3454
3455         Unreviewed fix after r75908.
3456
3457         Move WebKit into Source
3458         https://bugs.webkit.org/show_bug.cgi?id=52530
3459
3460         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
3461
3462 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3463
3464         Unreviewed.
3465
3466         Remove accidentally committed debug printing after r75908.
3467
3468         * Scripts/webkitdirs.pm:
3469
3470 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3471
3472         Unreviewed.
3473
3474         Add myself to committers list
3475         https://bugs.webkit.org/show_bug.cgi?id=52566
3476
3477         * Scripts/webkitpy/common/config/committers.py:
3478
3479 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3480
3481         Reviewed by Jeremy Orlow.
3482
3483         GeolocationController should call stopUpdating on destruction
3484         https://bugs.webkit.org/show_bug.cgi?id=52216
3485
3486         fast/dom/Geolocation/window-close-crash.html requires that a
3487         Geolocation watch be started in a secondary window. Consequently,
3488         we need to allow geolocation permission and provide a mock
3489         geolocation position for the secondary window's
3490         GeolocationClientMock.
3491
3492         * DumpRenderTree/chromium/LayoutTestController.cpp:
3493         (LayoutTestController::setGeolocationPermission):
3494         (LayoutTestController::setMockGeolocationPosition):
3495         (LayoutTestController::setMockGeolocationError):
3496         * DumpRenderTree/chromium/TestShell.h:
3497         (TestShell::windowList):
3498
3499 2011-01-16  Adam Barth  <abarth@webkit.org>
3500
3501         Update more include paths to reflect WebKit move.
3502
3503         * DumpRenderTree/chromium/EventSender.cpp:
3504         (EventSender::keyDown):
3505         (EventSender::needsShiftModifier):
3506         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3507         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3508
3509 2011-01-16  Kent Tamura  <tkent@chromium.org>
3510
3511         Unreviewed, Chromium build fix.
3512
3513         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
3514
3515 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
3516
3517         Build fix for GTK+ after source directory movement.
3518
3519         * GNUmakefile.am: Correct include paths.
3520
3521 2011-01-16  Adam Barth  <abarth@webkit.org>
3522
3523         Teach svn-apply about WebKit move.
3524
3525         * Scripts/VCSUtils.pm:
3526
3527 2011-01-16  Adam Barth  <abarth@webkit.org>
3528
3529         Rubber-stamped by Eric Seidel.
3530
3531         Move WebKit into Source
3532         https://bugs.webkit.org/show_bug.cgi?id=52530
3533
3534         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3535         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3536         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3537         * DumpRenderTree/qt/GCControllerQt.cpp:
3538         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3539         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3540         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3541         * DumpRenderTree/wscript:
3542         * QtTestBrowser/launcherwindow.h:
3543         * Scripts/build-webkit:
3544         * Scripts/webkitdirs.pm:
3545
3546 2011-01-15  Adam Barth  <abarth@webkit.org>
3547
3548         Teach svn-apply about WebKit2 move.
3549
3550         * Scripts/VCSUtils.pm:
3551
3552 2011-01-15  Adam Barth  <abarth@webkit.org>
3553
3554         Rubber-stamped by Eric Seidel.
3555
3556         Move WebKit2 into Source
3557         https://bugs.webkit.org/show_bug.cgi?id=52438
3558
3559         * MiniBrowser/qt/MiniBrowser.pro:
3560         * Scripts/build-webkit:
3561         * Scripts/do-file-rename:
3562         * Scripts/do-webcore-rename:
3563         * Scripts/test-webkitpy:
3564         * Scripts/webkitdirs.pm:
3565         * Scripts/webkitpy/style/checker.py:
3566         * WebKitTestRunner/DerivedSources.pro:
3567         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3568         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3569
3570 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
3571
3572         Reviewed by David Levin.
3573
3574         [chromium] remove obsolete createView method
3575         https://bugs.webkit.org/show_bug.cgi?id=52437
3576
3577         * DumpRenderTree/chromium/WebViewHost.cpp:
3578         (WebViewHost::createView):
3579         * DumpRenderTree/chromium/WebViewHost.h:
3580
3581 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
3582
3583         Reviewed by Geoff Garen.
3584
3585         ShouldLoadResourceForFrame should use strings, not URLs.
3586         https://bugs.webkit.org/show_bug.cgi?id=52476
3587
3588         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3589         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
3590         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3591
3592 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
3593
3594         Reviewed by David Levin.
3595
3596         Add Tony Gentilcore as a reviewer
3597         https://bugs.webkit.org/show_bug.cgi?id=52480
3598
3599         * Scripts/webkitpy/common/config/committers.py:
3600
3601 2011-01-14  David Levin  <levin@chromium.org>
3602
3603         Reviewed by Eric Seidel.
3604
3605         check-webkit-style: _FunctionState should keep track of where the function name starts.
3606         https://bugs.webkit.org/show_bug.cgi?id=52454
3607
3608         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
3609         _FunctionState and logic for setting it correctly.
3610         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3611
3612 2011-01-14  Vincent Scheib  <scheib@chromium.org>
3613
3614         Reviewed by David Levin.
3615
3616         Add support to DumpRenderTree to use the GPU rather than software renderer
3617         https://bugs.webkit.org/show_bug.cgi?id=52333
3618
3619         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3620         (main):
3621         * Scripts/webkitpy/layout_tests/port/chromium.py:
3622         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3623
3624 2011-01-14  Tony Chang  <tony@chromium.org>
3625
3626         Reviewed by Kent Tamura.
3627
3628         [chromium] update fonts.conf to fix 6 linux tests in drt
3629         https://bugs.webkit.org/show_bug.cgi?id=52411
3630
3631         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
3632             chromium's src/webkit/tools/test_shell/resources/fonts.conf
3633
3634 2011-01-14  Eric Seidel  <eric@webkit.org>
3635
3636         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
3637
3638         Reviewed by Adam Barth.
3639
3640         Fix when running Tools/Scripts/check-webkit-style without arguments.
3641         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
3642
3643         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
3644         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3645
3646 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
3647
3648         Reviewed by David Levin.
3649
3650         Store the tempdir object in a variable so it doesn't get deleted too early.
3651         https://bugs.webkit.org/show_bug.cgi?id=51875
3652
3653         * Scripts/update-webkit-auxiliary-libs:
3654         * Scripts/update-webkit-support-libs:
3655
3656 2011-01-14  Eric Seidel  <eric@webkit.org>
3657
3658         Unreviewed.  Make it work in python 2.5.
3659
3660         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3661         https://bugs.webkit.org/show_bug.cgi?id=49158
3662
3663         * Scripts/webkitpy/common/checkout/api_unittest.py:
3664
3665 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3666
3667         Unreviewed, rolling out r75774.
3668         http://trac.webkit.org/changeset/75774
3669         https://bugs.webkit.org/show_bug.cgi?id=52431
3670
3671         gtk builds were broken (Requested by loislo2 on #webkit).
3672
3673         * Scripts/webkitpy/common/checkout/scm.py:
3674
3675 2011-01-14  David Levin  <levin@chromium.org>
3676
3677         Reviewed by Shinichiro Hamaji.
3678
3679         check-webkit-style: _FunctionState should detect pure functions.
3680         https://bugs.webkit.org/show_bug.cgi?id=52428
3681
3682         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
3683         is a pure virtual function.
3684         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
3685         virtual functions are correctly detected.
3686
3687 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
3688
3689         Reviewed by Yury Semikhatsky.
3690
3691         Just small fix for problem with check-webkit-style.
3692         It just didn't work for this patch.
3693         Old code can't concatenate a list of strings with None.
3694
3695         * Scripts/webkitpy/common/checkout/scm.py:
3696
3697 2011-01-13  David Levin  <levin@chromium.org>
3698
3699         Reviewed by Shinichiro Hamaji.
3700
3701         check-webkit-style: _FunctionState should use Position to know where items are.
3702         https://bugs.webkit.org/show_bug.cgi?id=52424
3703
3704         * Scripts/webkitpy/style/checkers/cpp.py:
3705         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
3706         (detect_functions): Changed to pass Position's to _FunctionState.begin and
3707         did some minor clean-up.
3708         (*): Other changes are simply about converting to use the Position's in_FunctionState
3709         instead of line numbers.
3710         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
3711         to verify the positions stored in _FunctionState.
3712
3713 2011-01-13  Eric Seidel  <eric@webkit.org>
3714
3715         Reviewed by David Levin.
3716
3717         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3718         https://bugs.webkit.org/show_bug.cgi?id=49158
3719
3720         This is not the most elegant, but it is a very safe fix to this bug.
3721         One advantage of catching ScriptError like this instead of adding a
3722         new added_or_modified_files or fixing all changed_files callers
3723         to use a more specific change_files variant, is that we catch
3724         all kinds of ScriptErrors which might cause our (non-essential)
3725         suggest-reviewers code to fail out.  This should make passing
3726         --suggest-reviewers to webkit-patch upload much more robust
3727         and may even make it possible for us to make it default.
3728
3729         The root of the problem here is that SCM.changed_files includes
3730         deleted ChangeLog paths (from moves, etc) which then when we ask
3731         SVN/Git for the contents of the file at that revision, the command
3732         errors out and Executive.run_command raises a ScriptError.
3733
3734         In the future we might fix this differently by making all current
3735         callers of chagned_files use a more specific method for requesting
3736         what types of changes they're interested in (adds, modifies, deletes, etc.)
3737
3738         * Scripts/webkitpy/common/checkout/api.py:
3739         * Scripts/webkitpy/common/checkout/api_unittest.py:
3740
3741 2011-01-13  Dan Bernstein  <mitz@apple.com>
3742
3743         Reviewed by Alexey Proskuryakov.
3744
3745         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
3746         https://bugs.webkit.org/show_bug.cgi?id=52419
3747
3748         Allow to further control the behavior of the willSendRequest delegate callback by making it
3749         set a different URL in the new request.
3750
3751         * DumpRenderTree/LayoutTestController.cpp:
3752         (addURLToRedirectCallback): Added.
3753         (LayoutTestController::staticFunctions): Added addURLToRedirect.
3754         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
3755         (LayoutTestController::redirectionDestinationForURL): Added this getter.
3756         * DumpRenderTree/LayoutTestController.h:
3757         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3758         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
3759         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
3760         change the URL in the new request to the redirect destination.
3761
3762 2011-01-13  Eric Seidel  <eric@webkit.org>
3763
3764         Reviewed by Mihai Parparita.
3765
3766         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
3767         https://bugs.webkit.org/show_bug.cgi?id=52416
3768
3769         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
3770         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
3771
3772         I also added FIXMEs about the changed_files returning deleted files problem
3773         which is causing the other most common exception for suggest-reviewers
3774         (and is probably breaking sheriff-bots blame detection).
3775
3776         * Scripts/webkitpy/common/checkout/api.py:
3777         * Scripts/webkitpy/common/checkout/api_unittest.py:
3778         * Scripts/webkitpy/common/checkout/scm.py:
3779
3780 2011-01-13  Eric Seidel  <eric@webkit.org>
3781
3782         Reviewed by Adam Barth.
3783
3784         results archives from commit-queue are too large to upload
3785         https://bugs.webkit.org/show_bug.cgi?id=52405
3786
3787         * Scripts/webkitpy/common/system/filesystem.py:
3788         * Scripts/webkitpy/common/system/filesystem_mock.py:
3789         * Scripts/webkitpy/tool/commands/queues.py:
3790
3791 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
3792
3793         Reviewed by Martin Robinson.
3794
3795         [gtk] Zero-sized font does not yet work
3796         https://bugs.webkit.org/show_bug.cgi?id=49793
3797
3798         Set minimum-font-size to 0 for the DRT.
3799
3800         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3801         (resetDefaultsToConsistentValues):
3802
3803 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3804
3805         Reviewed by Darin Adler.
3806
3807         Make old-run-webkit-tests more robust on buildbots
3808         https://bugs.webkit.org/show_bug.cgi?id=52364
3809
3810         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
3811
3812 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3813
3814         Reviewed by Darin Adler.
3815
3816         Make old-run-webkit-tests more robust on buildbots
3817         https://bugs.webkit.org/show_bug.cgi?id=52364
3818
3819         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
3820
3821 2011-01-13  Tony Chang  <tony@chromium.org>
3822
3823         Reviewed by Kent Tamura.
3824
3825         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
3826         https://bugs.webkit.org/show_bug.cgi?id=52332
3827
3828         Forked Info.plist is not longer needed.
3829
3830         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
3831
3832 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
3833
3834         Reviewed by Timothy Hatcher.
3835
3836         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
3837         to be passed directly to WebInspector.UIString
3838
3839         https://bugs.webkit.org/show_bug.cgi?id=52365
3840
3841         * Scripts/check-inspector-strings:
3842
3843 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3844
3845         Unreviewed, rolling out r74881.
3846         http://trac.webkit.org/changeset/74881
3847         https://bugs.webkit.org/show_bug.cgi?id=52357
3848
3849         The EFL builder has been red for days (Requested by abarth on
3850         #webkit).
3851
3852         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3853         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3854
3855 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3856
3857         Reviewed by David Levin.
3858
3859         Add beforeunload support to WebKitTestRunner
3860         https://bugs.webkit.org/show_bug.cgi?id=52353
3861         
3862         This makes a number of currently failing tests pass.
3863
3864         * WebKitTestRunner/TestController.cpp:
3865         (WTR::runBeforeUnloadConfirmPanel):
3866         (WTR::createOtherPage):
3867         (WTR::TestController::initialize):
3868
3869 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3870
3871         Reviewed by Sam Weinig.
3872
3873         Detect, identify and recover from WebProcess crashes in run-webkit-tests
3874         https://bugs.webkit.org/show_bug.cgi?id=52330
3875
3876         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
3877         a web process crash.
3878         * WebKitTestRunner/TestController.cpp:
3879         (WTR::TestController::initialize): Set up a processDidCrash
3880         callback.
3881         (WTR::TestController::processDidCrash): Report that the Web process
3882         crashed.
3883         * WebKitTestRunner/TestController.h:
3884
3885 2011-01-12  David Levin  <levin@chromium.org>
3886
3887         Reviewed by Shinichiro Hamaji.
3888
3889         check-webkit-style -- close_expression function doesn't work correctly.
3890         https://bugs.webkit.org/show_bug.cgi?id=52272
3891
3892         * Scripts/webkitpy/style/checkers/cpp.py:
3893         (Position.__str__): Added a way to convert it to a string which is useful in tests.
3894         (Position.__cmp__): Added a way to compare Position which is useful in tests and
3895         generally useful (for upcoming code changes).
3896         (close_expression): Changed to use Position for input and output.
3897         Also, fixed many bugs such as only working correctly for parenthesis,
3898         not working correctly if given an offset in a line and not finding
3899         the real closing element if there were multiple closing elements in
3900         the same line.
3901         (detect_functions): Adjusted due to the change in arguments for
3902         close_expression.
3903         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3904         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
3905         two positions are the same.
3906         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
3907         (CppStyleTest.test_close_expression): Added tests to catch the issues
3908         that were fixed.
3909
3910 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3911
3912         Unreviewed, rolling out r75576.
3913         http://trac.webkit.org/changeset/75576
3914         https://bugs.webkit.org/show_bug.cgi?id=52304
3915
3916         broke rebaseline-chromium-webkit-test (Requested by thakis on
3917         #webkit).
3918
3919         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3920         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3921         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3922         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3923         * Scripts/webkitpy/layout_tests/port/base.py:
3924         * Scripts/webkitpy/layout_tests/port/chromium.py:
3925         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3926         * Scripts/webkitpy/layout_tests/port/test.py:
3927         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3929         * Scripts/webkitpy/style/checkers/test_expectations.py:
3930         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3931
3932 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3933
3934         Reviewed by Darin Adler.
3935
3936         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3937         https://bugs.webkit.org/show_bug.cgi?id=52307
3938
3939         * Scripts/old-run-webkit-tests:
3940
3941 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3942
3943         Reviewed by Martin Robinson.
3944
3945         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3946         https://bugs.webkit.org/show_bug.cgi?id=50867
3947
3948         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3949         TestNetscapePlugin.cpp 
3950
3951         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3952         * Scripts/webkitdirs.pm:
3953
3954 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3955
3956         Reviewed by Pavel Feldman.
3957
3958         Add check-inspector-strings script.
3959
3960         https://bugs.webkit.org/show_bug.cgi?id=52295
3961
3962         * Scripts/check-inspector-strings: Added.
3963
3964 2011-01-12  Adam Roben  <aroben@apple.com>
3965
3966         Advertise the .testnetscape file extension on Windows
3967
3968         Fixes <http://webkit.org/b/52298>
3969         plugins/no-mime-with-valid-extension.html fails on Windows
3970
3971         Reviewed by Dan Bernstein.
3972
3973         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3974         FileExtents field to map the .testnetscape file extension to the
3975         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3976
3977 2011-01-12  Adam Barth  <abarth@webkit.org>
3978
3979         Reviewed by Eric Seidel.
3980
3981         Make webkit-patch support subdirectories for SVN checkouts
3982         https://bugs.webkit.org/show_bug.cgi?id=52261
3983
3984         os.relpath does not exist on Python 2.5, so we need to call our version
3985         of the API.
3986
3987         * Scripts/webkitpy/common/checkout/scm.py:
3988
3989 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3990
3991         Reviewed by Eric Seidel.
3992
3993         Close additional pages opened during a test once the test completes.
3994         https://bugs.webkit.org/show_bug.cgi?id=52276
3995
3996         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3997         (WTR::InjectedBundle::done):
3998
3999 2011-01-11  David Levin  <levin@chromium.org>
4000
4001         Reviewed by Eric Seidel.
4002
4003         Errors should be separated from the command line in bot messages.
4004         https://bugs.webkit.org/show_bug.cgi?id=52275
4005
4006         * Scripts/webkitpy/common/system/executive.py:
4007         (ScriptError.message_with_output): Added a newline to separate the command
4008         line from the errors.
4009         * Scripts/webkitpy/common/system/executive_unittest.py:
4010         (ScriptErrorTest.test_message_with_output): Added tests for the various code
4011         paths in message_with_output.
4012
4013 2011-01-11  Eric Seidel  <eric@webkit.org>
4014
4015         Unreviewed.
4016
4017         commit-queue should know how to upload archived results (for test flakes or general failures)
4018         https://bugs.webkit.org/show_bug.cgi?id=52048
4019
4020         The zips are mostly empty due to forgetting -r.
4021         Expected diffs were not being pulled from the archive due
4022         to the archive having longer paths than I realized.
4023
4024         * Scripts/webkitpy/common/system/workspace.py:
4025         * Scripts/webkitpy/common/system/workspace_unittest.py:
4026         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4027         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4028
4029 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
4030
4031         Reviewed by Ojan Vafai.
4032
4033         The current modifier parsing code in test_expectations is
4034         fragile and hard-coded, so it's not easy to understand the logic
4035         or easily add new types of modifiers (like GPU vs. CPU testing
4036         for graphics tests, or 32-bit vs. 64-bit differences).
4037
4038         This is the first of two patches that will add in more generic
4039         support and then eliminate the GPU-specific test expectations
4040         files for Chromium.
4041
4042         This patch adds two standalone objects for handling modifiers. The
4043         rules for interpreting modifiers, precedence, and conflicts are
4044         given in the docstring to the ModifierMatcher class, which
4045         returns ModifierMatchResult objects.
4046         
4047         This patch also adds routines to the Port interface and a
4048         default set of values in the base object, in order to obtain the
4049         values needed on a given test run. These values are then passed
4050         to the expectation parser. This also allows us to clean up the
4051         logic used to lint all of the different configurations in a
4052         single test_expectations.txt file.
4053
4054         The next patch will merge in the separate GPU expectations file.
4055
4056         https://bugs.webkit.org/show_bug.cgi?id=51222
4057
4058         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4059         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4060         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4061         * Scripts/webkitpy/layout_tests/port/base.py:
4062         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4063         * Scripts/webkitpy/layout_tests/port/chromium.py:
4064         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4065         * Scripts/webkitpy/layout_tests/port/test.py:
4066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4067         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4068
4069 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
4070
4071         Reviewed by Adam Barth.
4072
4073         Make webkit-patch support subdirectories for SVN checkouts
4074         https://bugs.webkit.org/show_bug.cgi?id=52261
4075
4076         * Scripts/webkitpy/common/checkout/scm.py:
4077         * Scripts/webkitpy/style_references.py:
4078         * Scripts/webkitpy/tool/main.py:
4079         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4080
4081 2011-01-11  Eric Seidel  <eric@webkit.org>
4082
4083         Unreviewed.
4084
4085         commit-queue should know how to upload archived results (for test flakes or general failures)
4086         https://bugs.webkit.org/show_bug.cgi?id=52048
4087
4088         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
4089         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
4090
4091         * Scripts/webkitpy/common/system/workspace.py:
4092         * Scripts/webkitpy/common/system/workspace_unittest.py:
4093         * Scripts/webkitpy/tool/commands/queues.py:
4094
4095 2011-01-11  Sam Weinig  <sam@webkit.org>
4096
4097         Roll r75474 back in.
4098
4099 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4100
4101         Reviewed by Kenneth Rohde Christiansen.
4102
4103         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
4104         https://bugs.webkit.org/show_bug.cgi?id=51204
4105
4106         * QtTestBrowser/webpage.h:
4107         (QtNAMThread::QtNAMThread):
4108         (QtNAMThread::networkAccessManager):
4109         (QtNAMThread::run):
4110
4111 2011-01-11  Peter Varga  <pvarga@webkit.org>
4112
4113         Unreviewed.
4114
4115         Add myself to committers' list.
4116
4117         * Scripts/webkitpy/common/config/committers.py:
4118
4119 2011-01-11  Eric Seidel  <eric@webkit.org>
4120
4121         Reviewed by Adam Barth.
4122
4123         commit-queue should know how to upload archived results (for test flakes or general failures)
4124         https://bugs.webkit.org/show_bug.cgi?id=52048
4125
4126         Now the queue will always upload results.  Either the entire zip, or just
4127         the diffs.txt in the case of text failures.
4128
4129         This should make understanding flakes much easier, and paves the way
4130         for having the EWS run layout tests (and upload failures).
4131
4132         In order to upload .zip files I had to teach bugzilla.py to autodetect
4133         mime types from the filename.  Since mimetypes.py doesn't include a mapping
4134         for .patch files, I have it add one before calling guess_type.
4135
4136         We may find that always uploading the whole zip instead of just the -diffs.txt
4137         file is preferable, but for now I'm keeping the old behavior because it makes
4138         quickly understanding text failures easy.
4139
4140         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4141         * Scripts/webkitpy/common/system/workspace.py: Added.
4142         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
4143         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4144         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4145         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4146         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4147         * Scripts/webkitpy/tool/commands/queues.py:
4148         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4149
4150 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
4151
4152         Unreviewed, rolling out r75464.
4153         http://trac.webkit.org/changeset/75464
4154         https://bugs.webkit.org/show_bug.cgi?id=52193
4155
4156         Followup rollout for 75474 (Requested by Ossy on #webkit).
4157
4158         * MiniBrowser/mac/BrowserWindowController.m:
4159         (-[BrowserWindowController awakeFromNib]):
4160         * MiniBrowser/win/BrowserView.cpp:
4161         (BrowserView::create):
4162         * WebKitTestRunner/TestController.cpp:
4163         (WTR::createOtherPage):
4164         (WTR::TestController::initialize):
4165
4166 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4167
4168         Reviewed by Csaba Osztrogonác.
4169
4170         [Qt] Baseline qt_minimal configuration
4171         https://bugs.webkit.org/show_bug.cgi?id=51313
4172
4173         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4174         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
4175         QT_NO_UNDOSTACK guard.
4176
4177         * QtTestBrowser/launcherwindow.cpp:
4178         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
4179         guards.
4180         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
4181         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
4182         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
4183         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
4184
4185         * QtTestBrowser/launcherwindow.h:
4186         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
4187         * QtTestBrowser/locationedit.h: Ditto.
4188
4189         * QtTestBrowser/mainwindow.cpp:
4190         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
4191         QT_NO_UNDOSTACK guards.
4192         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
4193         (MainWindow::changeLocation): Ditto.
4194         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
4195         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
4196
4197         * QtTestBrowser/webpage.cpp:
4198         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
4199         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
4200
4201         * QtTestBrowser/webview.cpp:
4202         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
4203         (WebViewGraphicsBased::animatedYFlip): Ditto.
4204
4205 2011-01-10  Sam Weinig  <sam@webkit.org>
4206
4207         Fix build.
4208
4209         * MiniBrowser/mac/BrowserWindowController.m:
4210         (-[BrowserWindowController awakeFromNib]):
4211         * MiniBrowser/win/BrowserView.cpp:
4212         (BrowserView::create):
4213         * WebKitTestRunner/TestController.cpp:
4214         (WTR::createOtherPage):
4215         (WTR::TestController::initialize):
4216
4217 2011-01-10  Eric Seidel  <eric@webkit.org>
4218
4219         Reviewed by Ojan Vafai.
4220
4221         style-queue messages are way too long for big patches
4222         https://bugs.webkit.org/show_bug.cgi?id=52161
4223
4224         We definitely could build much fancier list-to-string-with-limit functions
4225         but this should be sufficient for our needs at the moment.
4226
4227         * Scripts/webkitpy/common/system/executive.py:
4228         * Scripts/webkitpy/common/system/executive_unittest.py:
4229
4230 2011-01-10  Tony Chang  <tony@chromium.org>
4231
4232         Unreviewed, rolling out r75398.
4233         http://trac.webkit.org/changeset/75398
4234         https://bugs.webkit.org/show_bug.cgi?id=52008
4235
4236         Some layout tests are crashing on Chromium Win.
4237
4238         * DumpRenderTree/chromium/WebViewHost.cpp:
4239         (WebViewHost::updatePaintRect):
4240         * DumpRenderTree/chromium/WebViewHost.h:
4241
4242 2011-01-10  Adam Roben  <aroben@apple.com>
4243
4244         Roll out r75392
4245
4246         It isn't needed now that r75289 has been rolled out.
4247
4248         * Scripts/run-javascriptcore-tests:
4249
4250 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
4251
4252         Reviewed by Anders Carlsson.
4253
4254         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
4255         https://bugs.webkit.org/show_bug.cgi?id=52160
4256
4257         * WebKitTestRunner/mac/TestControllerMac.mm:
4258         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
4259         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
4260         anyway.
4261
4262 2011-01-10  Tony Chang  <tony@chromium.org>
4263
4264         Reviewed by Mihai Parparita.
4265
4266         [chromium] fix for animated gif layout tests
4267         https://bugs.webkit.org/show_bug.cgi?id=52008
4268
4269         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
4270             to trigger gif animations.
4271         (WebViewHostPaintTask::WebViewHostPaintTask):
4272         (WebViewHostPaintTask::runIfValid):
4273         (WebViewHost::updatePaintRect):
4274         * DumpRenderTree/chromium/WebViewHost.h:
4275         (WebViewHost::taskList):
4276
4277 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
4278
4279         Reviewed by Xan Lopez.
4280
4281         [GTK] Fix gtk2 compilation for master
4282         https://bugs.webkit.org/show_bug.cgi?id=51885
4283
4284         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
4285         (createBitmapContextFromWebView): Replaced the old
4286         gdk_drawable_get_size with gdk_pixmap_get_size.
4287
4288 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
4289
4290         Reviewed by Laszlo Gombos.
4291
4292         [WINCE] Reenable NPAPI after r75203
4293         https://bugs.webkit.org/show_bug.cgi?id=52109
4294
4295         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
4296         it with !isEfl(), because EFL port does not support NPAPI (yet).
4297
4298         * Scripts/build-webkit:
4299
4300 2011-01-10  Adam Roben  <aroben@apple.com>
4301
4302         Skip some asserting JS tests
4303
4304         See <http://webkit.org/b/52156>.
4305
4306         * Scripts/run-javascriptcore-tests:
4307
4308 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
4309
4310         Reviewed by Xan Lopez.
4311
4312         [GTK] build-webkit disable Blob support via arguments passed to automake
4313         https://bugs.webkit.org/show_bug.cgi?id=52097
4314
4315         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
4316         build-webkit.
4317
4318 2011-01-10  Adam Roben  <aroben@apple.com>
4319
4320         Use the same name and description for TestNetscapePlugin on Windows and
4321         Mac
4322
4323         Fixes <http://webkit.org/b/52151>
4324         fast/frames/iframe-reparenting-plugins.html fails on Windows
4325
4326         Reviewed by Steve Falkenburg.
4327
4328         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
4329         the name and description from Mac's Info.plist.
4330
4331 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
4332
4333         Reviewed by Laszlo Gombos.
4334
4335         [Qt][WK2] Guard gcc-specific syntax
4336
4337         Non-gcc based compliers choke on the "-include"
4338         syntax for preinclude, place guard around it.
4339
4340         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4341         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4342
4343 2011-01-10  Andreas Kling  <kling@webkit.org>
4344
4345         Reviewed by Simon Hausmann.
4346
4347         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
4348         https://bugs.webkit.org/show_bug.cgi?id=52111
4349
4350         When getting a createNewPage() callback from QWKPage, create the
4351         new page with the same QWKContext as the page that is passed to
4352         the callback.
4353
4354         * MiniBrowser/qt/BrowserView.h:
4355         * MiniBrowser/qt/BrowserWindow.cpp:
4356         (newPageFunction):
4357         (BrowserWindow::BrowserWindow):
4358         * MiniBrowser/qt/BrowserWindow.h:
4359
4360 2011-01-10  Andreas Kling  <kling@webkit.org>
4361
4362         Reviewed by Kenneth Rohde Christiansen.
4363
4364         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
4365
4366         BrowserView set its own useless createNewPage() callback on QWKPage.
4367         This was immediately overridden by BrowserWindow anyway, so remove
4368         the BrowserView one.
4369
4370         * MiniBrowser/qt/BrowserView.cpp:
4371         (BrowserView::BrowserView):
4372
4373 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
4374
4375         Reviewed by Jeremy Orlow.
4376
4377         [Chromium] Remove non-client-based Geolocation code
4378         https://bugs.webkit.org/show_bug.cgi?id=50921
4379
4380         * DumpRenderTree/chromium/LayoutTestController.cpp:
4381         (LayoutTestController::setGeolocationPermission):
4382         (LayoutTestController::setMockGeolocationPosition):
4383         (LayoutTestController::setMockGeolocationError):
4384         * DumpRenderTree/chromium/WebViewHost.cpp:
4385         (WebViewHost::geolocationClientMock):
4386         (WebViewHost::reset):
4387         * DumpRenderTree/chromium/WebViewHost.h:
4388
4389 2011-01-10  Eric Seidel  <eric@webkit.org>
4390
4391         Reviewed by Adam Barth.
4392
4393         Commit bot tried to land r? cq+ patch
4394         https://bugs.webkit.org/show_bug.cgi?id=36638
4395
4396         It should now be possible to post a patch with r? and cq+ and the
4397         commit-queue will correctly wait for the r+ before attempting to land the patch.
4398         (This was a feature requested by several users.)
4399
4400         One caveat: We don't actually reject r-, cq+ patches from the queue
4401         (we just ignore them), but I think that's OK for now.
4402
4403         I also noticed that setting r- once a commit-queue node had grabbed