[WebAuthn] Move the mock testing entrance to Internals
[WebKit-https.git] / Tools / ChangeLog
1 2019-10-09  Jiewen Tan  <jiewen_tan@apple.com>
2
3         [WebAuthn] Move the mock testing entrance to Internals
4         https://bugs.webkit.org/show_bug.cgi?id=202560
5         <rdar://problem/55973793>
6
7         Reviewed by Chris Dumez.
8
9         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
10         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
11         (WTR::TestRunner::setWebAuthenticationMockConfiguration): Deleted.
12         * WebKitTestRunner/InjectedBundle/TestRunner.h:
13         * WebKitTestRunner/TestController.cpp:
14         (WTR::TestController::setWebAuthenticationMockConfiguration): Deleted.
15         * WebKitTestRunner/TestController.h:
16         * WebKitTestRunner/TestInvocation.cpp:
17         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
18
19 2019-10-09  Daniel Bates  <dabates@apple.com>
20
21         Add support for CompactPointerTuple<..., OptionSet<...>>
22         https://bugs.webkit.org/show_bug.cgi?id=201316
23
24         Reviewed by Yusuke Suzuki.
25
26         Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
27         a OptionSet<> as the byte value portion of the tuple.
28
29         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30         * TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.
31         (TestWebKitAPI::TEST):
32
33 2019-10-09  Jonathan Bedard  <jbedard@apple.com>
34
35         results.webkit.org: Increase default limit for test results
36         https://bugs.webkit.org/show_bug.cgi?id=202757
37
38         Rubber-stamped by Aakash Jain.
39
40         * resultsdbpy/resultsdbpy/controller/suite_controller.py:
41         (SuiteController): Increase DEFAULT_LIMIT.
42         * resultsdbpy/resultsdbpy/controller/test_controller.py:
43         (TestController): Ditto.
44         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
45         (_CommitBank.prototype._load): Make commit shards larger.
46         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
47         * resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
48
49 2019-10-09  Dean Jackson  <dino@apple.com>
50
51         Provide an alternate command-line flag for timeout in run-webkit-tests
52         https://bugs.webkit.org/show_bug.cgi?id=202758
53         <rdar://problem/56124032>
54
55         Reviewed by Tim Horton.
56
57         I always get the flag "--time-out-ms" wrong.
58         Everywhere else we use the single-word version of "timeout", including
59         the documentation for --time-out-ms!
60
61         Add an alternate that is just "--timeout", and update the documentation
62         to mention it is measured in milliseconds.
63
64         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
65         (parse_args):
66
67 2019-10-09  youenn fablet  <youenn@apple.com>
68
69         Remove testRunner.setWebRTCUnifiedPlanEnabled
70         https://bugs.webkit.org/show_bug.cgi?id=202700
71
72         Reviewed by Eric Carlson.
73
74         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
75         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
76         * WebKitTestRunner/InjectedBundle/TestRunner.h:
77
78 2019-10-09  Carlos Garcia Campos  <cgarcia@igalia.com>
79
80         REGRESSION(r250597): [GTK][WPE] 2.27.1 shows HTML content as text/plain in custom protocols when passing a charset in content type
81         https://bugs.webkit.org/show_bug.cgi?id=202633
82
83         Reviewed by Žan Doberšek.
84
85         Add a test case.
86
87         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
88         (testWebContextURIScheme):
89
90 2019-10-08  Jiewen Tan  <jiewen_tan@apple.com>
91
92         Partially undo r250811
93         https://bugs.webkit.org/show_bug.cgi?id=202715
94         <rdar://problem/56084287>
95
96         Reviewed by Chris Dumez.
97
98         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
99         Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.
100
101 2019-10-08  Jonathan Bedard  <jbedard@apple.com>
102
103         REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
104         https://bugs.webkit.org/show_bug.cgi?id=202419
105
106         Rubber-stamped by Aakash Jain.
107
108         * Scripts/webkitpy/common/system/executive.py:
109         (Executive._run_command_with_teed_output): Return exit code.
110         * Scripts/webkitpy/common/system/executive_unittest.py:
111         (ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
112         For non-zero exit codes.
113
114 2019-10-08  Jonathan Bedard  <jbedard@apple.com>
115
116         Python 3: Add support to auto-importer
117         https://bugs.webkit.org/show_bug.cgi?id=201955
118
119         Reviewed by Aakash Jain.
120
121         * Scripts/test-webkitpy-python3: Auto-install everything.
122         * Scripts/webkitpy/common/system/autoinstall.py: Import urlopen and urlparse for Python3.
123         * Scripts/webkitpy/thirdparty/__init__.py:
124         (AutoinstallImportHook.find_module): Update function definition for Python3.
125         (AutoinstallImportHook._install_mechanize): Use Python 2/3 compatible version of mechanize.
126         (AutoinstallImportHook._install_requests): Update urllib3 and requests version.
127         (AutoinstallImportHook._install_coverage): Use Python 2/3 compatible version of coverage.
128         (AutoinstallImportHook.greater_than_equal_to_version): Use range instead of xrange.
129         (AutoinstallImportHook._install_selenium): Update urllib3 version.
130         (AutoinstallImportHook.install_chromedriver): 
131         (AutoinstallImportHook.install_geckodriver):
132         (AutoinstallImportHook.get_latest_pypi_url):
133         (AutoinstallImportHook.install_binary):
134         * Scripts/webkitpy/thirdparty/__init___unittest.py:
135         (ThirdpartyTest):
136         (ThirdpartyTest.test_import_hook): Deleted.
137
138 2019-10-08  Yury Semikhatsky  <yurys@chromium.org>
139
140         Restore my committer status.
141
142         Uneviewed.
143
144         * Scripts/webkitpy/common/config/contributors.json:
145
146 2019-10-08  Kate Cheney  <katherine_cheney@apple.com>
147
148         Implement Telemetry and Dumping Routines for SQLite backend (195088)
149         https://bugs.webkit.org/show_bug.cgi?id=195088
150         <rdar://problem/54213407>
151
152         Reviewed by John Wilander.
153
154         Updated the current testing for telemetry which only tested 3
155         statistics. With this patch it now tests 10 statistics.
156         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
157         (WTR::InjectedBundle::didReceiveMessageToPage):
158         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
159         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
160         * WebKitTestRunner/InjectedBundle/TestRunner.h:
161
162 2019-10-08  Timothy Hatcher  <timothy@apple.com>
163
164         Copying white text from dark mode WebKit apps and pasting in a light mode app results in white (invisible) text.
165         https://bugs.webkit.org/show_bug.cgi?id=202662
166         rdar://problem/48677354
167
168         Reviewed by Megan Gardner.
169
170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
171         * TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm: Added.
172         (readRTFDataFromPasteboard):
173         (copyAttributedStringFromHTML):
174         (checkColor):
175         (TEST):
176
177 2019-10-08  Brady Eidson  <beidson@apple.com>
178
179         Service Worker Fetch events should time out.
180         https://bugs.webkit.org/show_bug.cgi?id=202188
181
182         Reviewed by Alex Christensen.
183
184         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
185         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
186         (WTR::TestRunner::setServiceWorkerFetchTimeout):
187         * WebKitTestRunner/InjectedBundle/TestRunner.h:
188         * WebKitTestRunner/TestController.cpp:
189         (WTR::TestController::resetStateToConsistentValues):
190         (WTR::TestController::setServiceWorkerFetchTimeoutForTesting):
191         * WebKitTestRunner/TestController.h:
192         * WebKitTestRunner/TestInvocation.cpp:
193         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
194
195 2019-10-08  Matt Lewis  <jlewis3@apple.com>
196
197         Unreviewed, rolling out r250784.
198
199         Broke running layout tests.
200
201         Reverted changeset:
202
203         "results.webkit.org: Start reporting results"
204         https://bugs.webkit.org/show_bug.cgi?id=202639
205         https://trac.webkit.org/changeset/250784
206
207 2019-10-08  Matt Lewis  <jlewis3@apple.com>
208
209         Make iPhone simulators pass --iPhone-simulator instead of --iOS
210         https://bugs.webkit.org/show_bug.cgi?id=202701
211
212         Reviewed by Aakash Jain.
213
214         * BuildSlaveSupport/build.webkit.org-config/steps.py:
215         (appendCustomTestingFlags):
216
217 2019-10-08  Aakash Jain  <aakash_jain@apple.com>
218
219         [ews-build] Do not print worker environment variables in each build step [part 3]
220         https://bugs.webkit.org/show_bug.cgi?id=202698
221
222         Reviewed by Jonathan Bedard.
223
224         * BuildSlaveSupport/ews-build/steps.py:
225         (RunJavaScriptCoreTests.__init__): Disabled logging of environment variables.
226         (ExtractTestResults.__init__): Ditto.
227         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
228
229 2019-10-08  Matt Lewis  <jlewis3@apple.com>
230
231         Fixing the triggerable templates in the config for catalina.
232         https://bugs.webkit.org/show_bug.cgi?id=202652
233
234         Reviewed by Jonathan Bedard.
235
236         * BuildSlaveSupport/build.webkit.org-config/config.json:
237
238 2019-10-07  Ryosuke Niwa  <rniwa@webkit.org>
239
240         Add IDL for requestIdleCallback
241         https://bugs.webkit.org/show_bug.cgi?id=202653
242
243         Reviewed by Geoffrey Garen.
244
245         * DumpRenderTree/TestOptions.cpp:
246         (TestOptions::TestOptions):
247         * DumpRenderTree/TestOptions.h:
248         * DumpRenderTree/mac/DumpRenderTree.mm:
249         (setWebPreferencesForTestOptions):
250
251 2019-10-07  Jiewen Tan  <jiewen_tan@apple.com>
252
253         Only wrapping CryptoKeys for IDB during serialization
254         https://bugs.webkit.org/show_bug.cgi?id=202500
255         <rdar://problem/52445927>
256
257         Reviewed by Chris Dumez.
258
259         Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.
260
261         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
262         (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]):
263         (TEST):
264         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
265         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
266         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
267         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
268         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:
269
270 2019-10-07  Dean Jackson  <dino@apple.com>
271
272         Various filter-build-webkit updates
273         https://bugs.webkit.org/show_bug.cgi?id=202558
274
275         Reviewed by Tim Horton.
276
277         Add rules for:
278         - RuleScriptExecution
279         - tapi
280         - plutil
281         - A postprocessing ANGLE script
282         - "Prepare build"
283         - Signing Identity
284
285         * Scripts/filter-build-webkit:
286
287 2019-10-07  Saam Barati  <sbarati@apple.com>
288
289         Allow OSR exit to the LLInt
290         https://bugs.webkit.org/show_bug.cgi?id=197993
291
292         Reviewed by Tadeu Zagallo.
293
294         * Scripts/run-jsc-stress-tests:
295
296 2019-10-07  Kate Cheney  <katherine_cheney@apple.com>
297
298         Domain relationships in the ITP Database should be inserted in a single query and ignore repeat insert attempts. (202604)
299         https://bugs.webkit.org/show_bug.cgi?id=202604
300         <rdar://problem/55995831>
301
302         Reviewed by Chris Dumez. 
303
304         Updates to testing infrastructure to test successful list-merging of
305         top domains into the ITP SQLite database and test against repeat
306         inserts.
307         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
309         (WTR::TestRunner::setStatisticsMergeStatistic):
310         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
311         (WTR::TestRunner::isStatisticsOnlyInDatabaseOnce):
312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
313         * WebKitTestRunner/TestController.cpp:
314         (WTR::TestController::setStatisticsMergeStatistic):
315         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
316         * WebKitTestRunner/TestController.h:
317         * WebKitTestRunner/TestInvocation.cpp:
318         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
319
320 2019-10-07  Matt Lewis  <jlewis3@apple.com>
321
322         Bring up queues for Catalina
323         https://bugs.webkit.org/show_bug.cgi?id=202652
324
325         Reviewed by Jonathan Bedard.
326
327         * BuildSlaveSupport/build.webkit.org-config/config.json:
328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
329         (WebKitBuildbot):
330         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
331
332 2019-10-07  Antoine Quint  <graouts@apple.com>
333
334         Crash in WebKitTestRunnerApp: invocation function for block in WTR::UIScriptControllerIOS::sendEventStream
335         https://bugs.webkit.org/show_bug.cgi?id=202646
336         <rdar://problem/54576522>
337
338         Reviewed by Tim Horton.
339
340         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
341         (WTR::UIScriptControllerIOS::sendEventStream):
342
343 2019-10-07  Jonathan Bedard  <jbedard@apple.com>
344
345         results.webkit.org: Start reporting results
346         https://bugs.webkit.org/show_bug.cgi?id=202639
347
348         Reviewed by Dewei Zhu.
349
350         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
351         (loadBuilderConfig): Load API key for results.webkit.org.
352         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
353         (create_mock_slave_passwords_dict): Add mock for API key.
354         * BuildSlaveSupport/build.webkit.org-config/steps.py:
355         (RunWebKitTests): Start reporting to results.webkit.org.
356         (RunWebKitTests.__init__): Do not print the environment to hide the API key.
357         (RunWebKitTests.start): Add the API key to the environment.
358         (RunAPITests): Start reporting to results.webkit.org.
359         (RunAPITests.__init__): Do not print the environment to hide the API key.
360         (RunAPITests.start): Add the API key to the environment.
361         (RunPythonTests): Start reporting to results.webkit.org.
362         (RunPythonTests.__init__): Do not print the environment to hide the API key.
363         (RunPythonTests.start): Add the API key to the environment.
364         * Scripts/webkitpy/results/upload.py:
365         (Upload):
366         (Upload.upload): Add API_KEY, if it exists, to the request.
367         (Upload.upload_archive): Ditto.
368
369 2019-10-07  Matt Lewis  <jlewis3@apple.com>
370
371         Unreviewed, rolling out r250750.
372
373         Reverting change as this broke interal test over the weekend.
374
375         Reverted changeset:
376
377         "Allow OSR exit to the LLInt"
378         https://bugs.webkit.org/show_bug.cgi?id=197993
379         https://trac.webkit.org/changeset/250750
380
381 2019-10-07  youenn fablet  <youenn@apple.com>
382
383         [iOS] Unmuting capture of a page is not working
384         https://bugs.webkit.org/show_bug.cgi?id=202627
385
386         Reviewed by Eric Carlson.
387
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: Added.
390         (-[GetUserMediaCaptureUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
391         (-[GetUserMediaCaptureUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
392         (-[GetUserMediaTestView haveStream:]):
393         (TestWebKitAPI::waitUntilCaptureState):
394         (TestWebKitAPI::TEST):
395         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
396
397 2019-10-07  Philippe Normand  <pnormand@igalia.com>
398
399         [GStreamer][JHBuild] Update to 1.16.1
400         https://bugs.webkit.org/show_bug.cgi?id=202619
401
402         Reviewed by Žan Doberšek.
403
404         * flatpak/org.webkit.CommonModules.yaml:
405         * gstreamer/jhbuild.modules:
406         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Removed.
407         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Removed.
408         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Removed.
409
410 2019-10-04  Saam Barati  <sbarati@apple.com>
411
412         Allow OSR exit to the LLInt
413         https://bugs.webkit.org/show_bug.cgi?id=197993
414
415         Reviewed by Tadeu Zagallo.
416
417         * Scripts/run-jsc-stress-tests:
418
419 2019-10-04  Matt Lewis  <jlewis3@apple.com>
420
421         Fix iPad testers platform for downloading build product and fixing tests to run
422         https://bugs.webkit.org/show_bug.cgi?id=202365
423
424         Reviewed by Jonathan Bedard.
425
426         * BuildSlaveSupport/build.webkit.org-config/config.json: Added device_model.
427         * BuildSlaveSupport/build.webkit.org-config/factories.py: Added device_model property.
428         (Factory.__init__):
429         (BuildFactory.__init__):
430         (TestFactory.__init__):
431         (BuildAndTestFactory.__init__):
432         (BuildAndTestLLINTCLoopFactory.__init__):
433         (BuildAndTest32bitJSCFactory.__init__):
434         (BuildAndRemoteJSCTestsFactory.__init__):
435         (TestWebKit1LeaksFactory.__init__):
436         (TestJSCFactory.__init__):
437         (Test262Factory.__init__):
438         (BuildAndPerfTestFactory.__init__):
439         (DownloadAndPerfTestFactory.__init__):
440         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Added device_model to loaded properties.
441         (loadBuilderConfig):
442         * BuildSlaveSupport/build.webkit.org-config/steps.py: Added ability to run based on device_model to
443         WebKit Tests and API tests for iPad and iPhone simulators.
444         (ConfigureBuild.__init__):
445         (ConfigureBuild.start):
446         (appendCustomTestingFlags):
447         (RunWebKitTests.start):
448         (RunAPITests.start):
449
450 2019-10-04  Jonathan Bedard  <jbedard@apple.com>
451
452         results.webkit.org: Remove percentages from bubbles
453         https://bugs.webkit.org/show_bug.cgi?id=202591
454
455         Rubber-stamped by Aakash Jain.
456
457         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
458         (inPlaceCombine): Add 'worst' key to combined results.
459         (TimelineFromEndpoint.constructor): Use the 'worst' key to populate the tag
460         instead of a percentage.
461
462 2019-10-04  Aakash Jain  <aakash_jain@apple.com>
463
464         [EWS] Assign webkit-misc to various queues
465         https://bugs.webkit.org/show_bug.cgi?id=202584
466
467         Reviewed by Jonathan Bedard.
468
469         * BuildSlaveSupport/ews-build/config.json:
470
471 2019-10-03  Aakash Jain  <aakash_jain@apple.com>
472
473         [ews] wincairo queue should use del instead of rm command (follow-up fix)
474         https://bugs.webkit.org/show_bug.cgi?id=202477
475
476         Reviewed by Jonathan Bedard.
477
478         * BuildSlaveSupport/ews-build/steps.py:
479         (CleanUpGitIndexLock.start): Use regular 'rm' command on windows as it use cygwin.
480         * BuildSlaveSupport/ews-build/steps_unittest.py:
481         (TestCleanUpGitIndexLock.test_success_windows): Added unit-test for windows.
482
483 2019-10-04  Jiewen Tan  <jiewen_tan@apple.com>
484
485         [WebAuthn] Implement _WKWebAuthenticationPanel SPI
486         https://bugs.webkit.org/show_bug.cgi?id=202559
487         <rdar://problem/55932094>
488
489         Reviewed by Brent Fulgham.
490
491         This patch adds a very limited test case to _WKWebAuthenticationPanel.
492         Bug 202560 and Bug 202565 will follow up to write more tests.
493
494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
495         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: Added.
496         (-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]):
497         (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
498         (TestWebKitAPI::TEST):
499         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html: Added.
500         * WebKitTestRunner/TestController.cpp:
501         (WTR::runWebAuthenticationPanel):
502         (WTR::TestController::createWebViewWithOptions):
503
504 2019-10-04  Alex Christensen  <achristensen@webkit.org>
505
506         Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration
507         https://bugs.webkit.org/show_bug.cgi?id=202553
508
509         Reviewed by Youenn Fablet.
510
511         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
512         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
513
514 2019-10-04  Alex Christensen  <achristensen@webkit.org>
515
516         Simplify sandbox enabling macros
517         https://bugs.webkit.org/show_bug.cgi?id=202536
518
519         Reviewed by Brent Fulgham.
520
521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
522
523 2019-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
524
525         [GTK][WPE] Print the revision number on command "--version" of the MiniBrowser
526         https://bugs.webkit.org/show_bug.cgi?id=202581
527
528         Reviewed by Carlos Garcia Campos.
529
530         When WebKit its build from source repository instead of a tarball
531         we can print the SVN revision to be more precise about the version
532         of WebKit when the option --version is passed to the MiniBrowser.
533
534         * MiniBrowser/gtk/main.c:
535         (main):
536         * MiniBrowser/wpe/main.cpp:
537         (main):
538
539 2019-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
540
541         Unreviewed. Fix GTK distcheck
542
543         * gtk/manifest.txt.in: Add Source/WebKit/Resources/gtk to the tarball.
544
545 2019-10-03  Per Arne Vollan  <pvollan@apple.com>
546
547         REGRESSION(249649): Unable to open local files in MiniBrowser on macOS
548         https://bugs.webkit.org/show_bug.cgi?id=201798
549
550         Reviewed by Brent Fulgham.
551
552         Added API test WKWebView.LoadFileWithLoadRequest.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
555
556 2019-10-03  Jonathan Bedard  <jbedard@apple.com>
557
558         Add myself to various tools watchlists
559         https://bugs.webkit.org/show_bug.cgi?id=202532
560
561         Reviewed by Aakash Jain.
562
563         * Scripts/webkitpy/common/config/watchlist: Add myself to the watchlist of
564         PerformanceTests, SVNScripts, webkitperl and webkitpy.
565
566 2019-10-03  Jiewen Tan  <jiewen_tan@apple.com>
567
568         Support googleLegacyAppidSupport extension
569         https://bugs.webkit.org/show_bug.cgi?id=202427
570         <rdar://problem/55887473>
571
572         Reviewed by Brent Fulgham.
573
574         Adds an API test for googleLegacyAppidSupport extension.
575
576         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
577         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
578         (TestWebKitAPI::constructMakeCredentialRequest):
579         (TestWebKitAPI::constructMakeCredentialRequestWithGoogleLegacyAppidSupport):
580         (TestWebKitAPI::TEST):
581
582 2019-10-03  Thibault Saunier  <tsaunier@igalia.com>
583
584         REGRESSION(r249428): [GStreamer] VP9 video rendered green
585         https://bugs.webkit.org/show_bug.cgi?id=201422
586
587         Adding patches in -base to fix the issue.
588
589         Reviewed by Philippe Normand.
590
591         * gstreamer/jhbuild.modules:
592         * gstreamer/patches/base-0001-glupload-Add-VideoMetas-and-GLSyncMeta-to-the-raw-up.patch: Added.
593
594 2019-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
595
596         [GTK] Make PSON optional
597         https://bugs.webkit.org/show_bug.cgi?id=200967
598
599         Reviewed by Michael Catanzaro.
600
601         Enable PSON in MiniBrowser and unit tests. Also add more tests to page-id to check that we can still talk to the
602         right web process after cross-site history navigation.
603
604         * MiniBrowser/gtk/main.c:
605         (main):
606         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
607         (testWebExtensionPageID):
608         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
609         (Test::Test):
610
611 2019-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
612
613         [GTK][WPE] Add WebKitWebView:page-id property
614         https://bugs.webkit.org/show_bug.cgi?id=201642
615
616         Reviewed by Michael Catanzaro.
617
618         Add a test case to check the new property.
619
620         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
621         (checkTitle):
622         (testWebExtensionGetTitle):
623         (webViewPageIDChanged):
624         (testWebExtensionPageID):
625         (beforeAll):
626
627 2019-10-02  Jonathan Bedard  <jbedard@apple.com>
628
629         results.webkit.org: Only automatically search when multiple lines are pasted
630         https://bugs.webkit.org/show_bug.cgi?id=202496
631
632         Rubber-stamped by Aakash Jain.
633
634         * resultsdbpy/resultsdbpy/view/static/js/search.js:
635         (SearchBar): If only a single line has been pasted, do not automatically dispatch
636         the search.
637
638 2019-10-02  Jonathan Bedard  <jbedard@apple.com>
639
640         Python 3: Add test-webkitpy for Python 3 (Follow-up fix)
641         https://bugs.webkit.org/show_bug.cgi?id=201954
642
643         Unreviewed follow-up fix.
644
645         * Scripts/test-webkitpy-python3: Add copyright.
646
647 2019-10-02  Thibault Saunier  <tsaunier@igalia.com>
648
649         [GSTreamer] Let playbin handle redirects for us when appropriate
650         https://bugs.webkit.org/show_bug.cgi?id=195326
651
652         Added required patche in GStreamer
653
654         Reviewed by Xabier Rodriguez-Calvar.
655
656         * gstreamer/patches/base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
657         * gstreamer/patches/good-0001-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
658
659 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
660
661         [ews] Add API endpoint to retry failed builds for a patch
662         https://bugs.webkit.org/show_bug.cgi?id=202424
663
664         Reviewed by Jonathan Bedard.
665
666         * BuildSlaveSupport/ews-app/ews/urls.py: Added url mapping for /retry.
667         * BuildSlaveSupport/ews-app/ews/views/retrypatch.py: Added.
668         (RetryPatch.get): Display the web-form to retry the patch. Retry button which will be added soon will 
669         use this form.
670         (RetryPatch.post): Handle the post request and retry the patch.
671         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
672         (StatusBubble.find_failed_builds_for_patch): Method to find failed builds for a patch.
673         * BuildSlaveSupport/ews-app/ews/templates/retry.html: Added, similar to submittoews.html. This
674         allows to retry a patch through a web-form as well.
675
676 2019-10-02  Kate Cheney  <katherine_cheney@apple.com>
677
678         Updated resource load statistics are never merged into the SQLite Database backend (202372).
679         https://bugs.webkit.org/show_bug.cgi?id=202372
680         <rdar://problem/55854542>
681
682         Reviewed by Brent Fulgham. 
683
684         Added testing functionality to the mergeStatistics() function of the 
685         SQLite backend.
686
687         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
688         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
689         (WTR::InjectedBundle::didReceiveMessageToPage):
690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
691         (WTR::TestRunner::setStatisticsMergeStatistic):
692         (WTR::TestRunner::statisticsCallDidSetMergeStatisticCallback):
693         * WebKitTestRunner/InjectedBundle/TestRunner.h:
694         * WebKitTestRunner/TestController.cpp:
695         (WTR::TestController::setStatisticsMergeStatistic):
696         * WebKitTestRunner/TestController.h:
697         * WebKitTestRunner/TestInvocation.cpp:
698         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
699         (WTR::TestInvocation::didMergeStatistic):
700         * WebKitTestRunner/TestInvocation.h:
701
702 2019-10-02  Aakash Jain  <aakash_jain@apple.com>
703
704         [ews] windows or wincairo queue should use del instead of rm command
705         https://bugs.webkit.org/show_bug.cgi?id=202477
706
707         Reviewed by Jonathan Bedard.
708
709         * BuildSlaveSupport/ews-build/steps.py:
710         (CleanUpGitIndexLock.start): Use 'del' command instead of rm for windows and wincairo.
711         * BuildSlaveSupport/ews-build/steps_unittest.py:
712         (TestCleanUpGitIndexLock.test_success_wincairo): Added unit-test.
713
714 2019-10-02  youenn fablet  <youenn@apple.com>
715
716         Add a test to check the case of launching two service worker processes shortly one after the other
717         https://bugs.webkit.org/show_bug.cgi?id=202450
718
719         Reviewed by Chris Dumez.
720
721         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
722
723 2019-10-02  Aakash Jain  <aakash_jain@apple.com>
724
725         [ews] Dedicate a bot for macOS-High-Sierra-Debug-Build-EWS queue
726         https://bugs.webkit.org/show_bug.cgi?id=202469
727
728         Reviewed by Jonathan Bedard.
729
730         * BuildSlaveSupport/ews-build/config.json: Dedicate ews112 to macOS debug builder queue.
731
732 2019-10-01  Jonathan Bedard  <jbedard@apple.com>
733
734         Python 3: Add test-webkitpy for Python 3
735         https://bugs.webkit.org/show_bug.cgi?id=201954
736
737         Reviewed by Aakash Jain.
738
739         * Scripts/test-webkitpy-python3: Added.
740
741 2019-10-02  Carlos Garcia Campos  <cgarcia@igalia.com>
742
743         [GTK][WPE] Stop using legacy custom protocol implementation
744         https://bugs.webkit.org/show_bug.cgi?id=202407
745
746         Reviewed by Žan Doberšek.
747
748         Remove the tests to check failure after committed, because it's not possible to test it with current code.
749
750         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
751         (testWebContextURIScheme):
752
753 2019-10-01  Alexey Shvayka  <shvaikalesh@gmail.com>
754
755         [win-ews] No such file or directory: u'/cygdrive/C/cygwin/home/buildbot/WebKit/WebKitBuild/Release/bin32/layout-test-results/pywebsocket.ws.log-out.txt'
756         https://bugs.webkit.org/show_bug.cgi?id=188640
757
758         Reviewed by Alex Christensen.
759
760         1. Properly shutdown WebSocket server so that port 8880 is released.
761         2. Prevent failure of WebSocket tests when launched in freshly cloned repository.
762
763         * Scripts/new-run-webkit-websocketserver:
764         (main): Tweak import and use class constants of PyWebSocket directly.
765         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
766         (PyWebSocket._prepare_config): Create test output directory if it doesn't exist.
767
768 2019-10-01  Alex Christensen  <achristensen@webkit.org>
769
770         Progress towards a functioning CMake build on Mac
771         https://bugs.webkit.org/show_bug.cgi?id=202443
772
773         Rubber-stamped by Tim Horton.
774
775         * DumpRenderTree/PlatformMac.cmake:
776         * MiniBrowser/mac/CMakeLists.txt:
777         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
778         * TestWebKitAPI/CMakeLists.txt:
779         * TestWebKitAPI/PlatformMac.cmake:
780         * WebKitTestRunner/PlatformMac.cmake:
781
782 2019-10-01  John Wilander  <wilander@apple.com>
783
784         Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access
785         https://bugs.webkit.org/show_bug.cgi?id=202435
786         <rdar://problem/55718526>
787
788         Reviewed by Brent Fulgham.
789
790         This change makes sure topPrivatelyControlledDomain() correctly handles domains
791         with leading dots, as often used in cookie domains.
792
793         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
794         (TestWebKitAPI::TEST_F):
795
796 2019-10-01  Jonathan Bedard  <jbedard@apple.com>
797
798         results.webkit.org: Standardize styles in the drawer
799         https://bugs.webkit.org/show_bug.cgi?id=202428
800
801         Rubber-stamped by Aakash Jain.
802
803         * resultsdbpy/resultsdbpy/view/static/css/search.css: Rename boldInverseColor.
804         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Ditto.
805         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Move style specifications into webkit.css.
806         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Ditto.
807         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
808         (.input>label): Use the boldInverseColor instead of grey.
809         (.input>input[type="text"][required], .input>input[type="number"][required],): Darken the border,
810         decrease the font weight.
811         (.input>input[type="text"][required]~label, .input>input[type="number"][required]~label,): Use the inverseColor instead of grey.
812
813 2019-10-01  Antti Koivisto  <antti@apple.com>
814
815         [CSS Shadow Parts] Parse 'part' attribute
816         https://bugs.webkit.org/show_bug.cgi?id=202409
817
818         Reviewed by Ryosuke Niwa.
819
820         * DumpRenderTree/mac/DumpRenderTree.mm:
821         (enableExperimentalFeatures):
822
823 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
824
825         Follow-up fix to r250572 to fix a typo.
826         [ews] Add method to retry a build using Buildbot API
827         https://bugs.webkit.org/show_bug.cgi?id=202408
828
829         Unreviewed follow-up fix.
830
831         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
832
833 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
834
835         [ews] Add method to retry a build using Buildbot API
836         https://bugs.webkit.org/show_bug.cgi?id=202408
837
838         Reviewed by Jonathan Bedard.
839
840         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
841         (Buildbot.retry_build): Method to retry given build using Buildbot API.
842
843 2019-10-01  David Kilzer  <ddkilzer@apple.com>
844
845         clang-tidy: Fix unnecessary copying/ref churn of for loop variables in Tools
846         <https://webkit.org/b/202387>
847
848         Reviewed by Darin Adler.
849
850         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
851         (WTR::TestController::setAllowedMenuActions): Make loop variable
852         a reference to fix unnecessary copying/ref churn.
853
854 2019-10-01  Nikolas Zimmermann  <nzimmermann@igalia.com>
855
856         Update my affiliation - since today I work for Igalia.
857
858         Unreviewed.
859
860         * Scripts/webkitpy/common/config/contributors.json:
861
862 2019-10-01  Keith Miller  <keith_miller@apple.com>
863
864         Add support for the Wasm multi-value proposal
865         https://bugs.webkit.org/show_bug.cgi?id=202250
866
867         Reviewed by Saam Barati.
868
869         * Scripts/run-jsc-stress-tests:
870
871 2019-10-01  youenn fablet  <youenn@apple.com>
872
873         Remove races condition when validating capture sandbox extension revocation
874         https://bugs.webkit.org/show_bug.cgi?id=202133
875         <rdar://problem/55660905>
876
877         Reviewed by Eric Carlson.
878
879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
880         Updated test to not use page cache so that on going back, the page is reloaded and will call getUserMedia again.
881
882 2019-09-30  Alex Christensen  <achristensen@webkit.org>
883
884         Resurrect Mac CMake build
885         https://bugs.webkit.org/show_bug.cgi?id=202384
886
887         Rubber-stamped by Tim Horton.
888
889         * DumpRenderTree/PlatformMac.cmake:
890         * TestWebKitAPI/PlatformMac.cmake:
891
892 2019-09-30  Zhifei Fang  <zhifei_fang@apple.com>
893
894         [results.webkit.org Timeline] New axis style
895         https://bugs.webkit.org/show_bug.cgi?id=202292
896
897         Reviewed by Jonathan Bedard.
898
899         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
900
901 2019-09-30  Alex Christensen  <achristensen@webkit.org>
902
903         Move DownloadMonitor test speed multiplier from WebProcessPool to WebsiteDataStoreConfiguration
904         https://bugs.webkit.org/show_bug.cgi?id=202339
905
906         Reviewed by Youenn Fablet.
907
908         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
909         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
910
911 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
912
913         [GTK] IconDatabase is not thread-safe
914         https://bugs.webkit.org/show_bug.cgi?id=201303
915
916         Reviewed by Žan Doberšek.
917
918         Rewrite the WebKitFaviconDatabase tests, splitting tests cases again and making them independent to each other.
919
920         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
921         (testFaviconDatabaseInitialization):
922         (testFaviconDatabaseGetFavicon):
923         (ephemeralViewFaviconChanged):
924         (testFaviconDatabaseEphemeral):
925         (testFaviconDatabaseClear):
926         (beforeAll):
927         (afterAll):
928         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFaviconDatabase shouls always pass now.
929
930 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
931
932         [GTK][WPE] Add about:gpu
933         https://bugs.webkit.org/show_bug.cgi?id=202305
934
935         Reviewed by Žan Doberšek.
936
937         Allow to use about:gpu in MiniBrowser. Add a script to get the current svn revision.
938
939         * MiniBrowser/gtk/BrowserTab.c:
940         (getInternalURI):
941         * MiniBrowser/gtk/main.c:
942         (argumentToURL):
943         * MiniBrowser/wpe/main.cpp:
944         (main):
945         * glib/svn-revision: Added.
946
947 2019-09-27  Andres Gonzalez  <andresg_22@apple.com>
948
949         Support accessibility for <figure> element on iOS.
950         https://bugs.webkit.org/show_bug.cgi?id=202272
951         <rdar://problem/54789907>
952
953         Reviewed by Chris Fleizach.
954
955         Implemented titleUIElement and roleDescription properties for <figure> elements on iOS.
956         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
957         (WTR::AccessibilityUIElement::titleUIElement):
958         (WTR::AccessibilityUIElement::roleDescription):
959
960 2019-09-27  Alex Christensen  <achristensen@webkit.org>
961
962         Move shouldUseTestingNetworkSession from NetworkProcessCreationParameters to NetworkSessionCreationParameters
963         https://bugs.webkit.org/show_bug.cgi?id=202327
964
965         Reviewed by Tim Horton.
966
967         * WebKitTestRunner/TestController.cpp:
968         (WTR::TestController::websiteDataStore):
969
970 2019-09-27  Alex Christensen  <achristensen@webkit.org>
971
972         Move service worker process termination delay disabling from process pool to website data store
973         https://bugs.webkit.org/show_bug.cgi?id=202308
974
975         Reviewed by Chris Dumez.
976
977         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
978
979 2019-09-27  Alex Christensen  <achristensen@webkit.org>
980
981         Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
982         https://bugs.webkit.org/show_bug.cgi?id=202285
983
984         Reviewed by Youenn Fablet.
985
986         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
987         (-[ServerTrustDelegate webView:didFinishNavigation:]):
988         (-[ServerTrustDelegate webView:didFailProvisionalNavigation:withError:]):
989         (-[ServerTrustDelegate waitForDidFinishNavigation]):
990         (-[ServerTrustDelegate waitForDidFailProvisionalNavigationError]):
991         (-[ServerTrustDelegate authenticationChallengeCount]):
992         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
993         (TestWebKitAPI::TEST):
994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
996         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation): Deleted.
997         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess): Deleted.
998         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount): Deleted.
999         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1000         * WebKitTestRunner/TestController.cpp:
1001         (WTR::TestController::resetStateToConsistentValues):
1002         (WTR::TestController::didReceiveAuthenticationChallenge):
1003         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
1004         * WebKitTestRunner/TestController.h:
1005         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const): Deleted.
1006         * WebKitTestRunner/TestInvocation.cpp:
1007         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1008         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1009         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
1010
1011 2019-09-27  Alex Christensen  <achristensen@webkit.org>
1012
1013         Remove unused APIProcessPoolConfiguration::diskCacheSpeculativeValidationEnabled
1014         https://bugs.webkit.org/show_bug.cgi?id=202290
1015
1016         Reviewed by Carlos Garcia Campos.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1019         (TEST):
1020         * WebKitTestRunner/TestController.cpp:
1021         (WTR::TestController::websiteDataStore):
1022         (WTR::TestController::generatePageConfiguration):
1023
1024 2019-09-27  Youenn Fablet  <youenn@apple.com>
1025
1026         Make IsNSURLSessionWebSocketEnabled an experimental flag
1027         https://bugs.webkit.org/show_bug.cgi?id=202135
1028         <rdar://problem/55694721>
1029
1030         Reviewed by Geoff Garen.
1031
1032         * WebKitTestRunner/TestController.cpp:
1033         (WTR::TestController::resetPreferencesToConsistentValues):
1034         Set preference to false by default.
1035
1036 2019-09-27  Jiewen Tan  <jiewen_tan@apple.com>
1037
1038         SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
1039         https://bugs.webkit.org/show_bug.cgi?id=202061
1040         <rdar://problem/55485666>
1041
1042         Reviewed by Youenn Fablet.
1043
1044         Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1047         (-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1048         (resetState):
1049         (TestWebKitAPI::TEST):
1050
1051 2019-09-26 Kate Cheney <katherine_cheney@apple.com>
1052
1053         Resource Load Statistics: Downgrade all third-party referrer headers
1054         https://bugs.webkit.org/show_bug.cgi?id=201353
1055         <rdar://problem/54895650>
1056
1057         Majority of this patch was written by John Wilander <wilander@apple.com>.
1058
1059         Reviewed by Brent Fulgham. 
1060
1061         The changes to the TestRunner facilitates an opt-out for test cases
1062         that either test the referrer mechanism explicitly or tests that
1063         rely on the full referrer to be sent. 
1064
1065         The new boolean variable and early return in 
1066         TestRunner::setStatisticsShouldDowngradeReferrer() prevent the same
1067         event from trying to set multiple TestRunner callbacks.
1068
1069         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1070         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1071         (WTR::InjectedBundle::didReceiveMessageToPage):
1072         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1073         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
1074         (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback):
1075         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1076         * WebKitTestRunner/TestController.cpp:
1077         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1078         * WebKitTestRunner/TestController.h:
1079         * WebKitTestRunner/TestInvocation.cpp:
1080         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1081         (WTR::TestInvocation::didSetShouldDowngradeReferrer):
1082         * WebKitTestRunner/TestInvocation.h:
1083
1084 2019-09-26  Dean Jackson  <dino@apple.com>
1085
1086         Build fix.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1089         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]): Deleted.
1090         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]): Deleted.
1091         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]): Deleted.
1092         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]): Deleted.
1093
1094 2019-09-26  Dean Jackson  <dino@apple.com>
1095
1096         ContextMenu on a link in an email no longer shows web preview
1097         https://bugs.webkit.org/show_bug.cgi?id=201120
1098         <rdar://54353617>
1099
1100         Reviewed by Wenson Hsieh.
1101
1102         Test context menus on a link that is also an image.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1105         (contextMenuWebViewDriver):
1106         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1107         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]):
1108         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1109         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]):
1110         (TEST):
1111
1112 2019-09-26  Frederic Wang  <fwang@igalia.com>
1113
1114         run-safari --ios-simulator is no longer working with Xcode 11
1115         https://bugs.webkit.org/show_bug.cgi?id=199852
1116
1117         Path of MobileSafari.app has changed in Xcode 11. This patch updates
1118         the run-safari script to use the new path. This removes support for
1119         running Safari on iOS < 13, see discussions on bug 177595.
1120
1121         Reviewed by Jonathan Bedard.
1122
1123         * Scripts/webkitdirs.pm:
1124         (iosSimulatorApplicationsPath):
1125
1126 2019-09-26  Zhifei Fang  <zhifei_fang@apple.com>
1127
1128         [results.webkit.org] Timeline support Image inner label
1129         https://bugs.webkit.org/show_bug.cgi?id=202180
1130
1131         Reviewed by Jonathan Bedard.
1132
1133         * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
1134         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1135         (.lengend>.item .dot img): support img symbol for lengend and dot
1136         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1137         (Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
1138
1139 2019-09-26  Chris Dumez  <cdumez@apple.com>
1140
1141         Stop using testRunner.overridePreference() to turn on Page Cache
1142         https://bugs.webkit.org/show_bug.cgi?id=202274
1143
1144         Reviewed by Alex Christensen.
1145
1146         * DumpRenderTree/TestRunner.cpp:
1147         (overridePreferenceCallback):
1148         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1149         (WTR::TestRunner::overridePreference):
1150
1151 2019-09-26  Jonathan Bedard  <jbedard@apple.com>
1152
1153         results.webkit.org: Use cursor: pointer for clickable elements
1154         https://bugs.webkit.org/show_bug.cgi?id=202268
1155
1156         Rubber-stamped by Aakash Jain.
1157
1158         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Give collapse button a pointer for cursor.
1159         * resultsdbpy/resultsdbpy/view/templates/search.html: Make 'X' to close test timeline a link-button.
1160
1161 2019-09-26  Kate Cheney  <katherine_cheney@apple.com>
1162
1163         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
1164         https://bugs.webkit.org/show_bug.cgi?id=195420                          
1165         <rdar://problem/54213551>                                               
1166
1167         Reviewed by Brent Fulgham.                                             
1168
1169         Added in logic to send a message from the UIProcess to the Network      
1170         Process which will initalize the ITP Database backend to allow for      
1171         layout testing.                                                         
1172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1174         (WTR::TestRunner::setUseITPDatabase):
1175         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1176         * WebKitTestRunner/TestController.cpp:
1177         (WTR::TestController::setUseITPDatabase):
1178         * WebKitTestRunner/TestController.h:
1179         * WebKitTestRunner/TestInvocation.cpp:
1180         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1181
1182 2019-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1183
1184         TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
1185         https://bugs.webkit.org/show_bug.cgi?id=202273
1186
1187         Reviewed by Aakash Jain.
1188
1189         The content width scaling limits added in r250361 prevent this test from scaling down the content width (2000px
1190         wide) to fit the viewport (375px). To avoid this issue, change the content width from 2000px to 1500px, which is
1191         still a very wide content width for a web page.
1192
1193         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm:
1194
1195 2019-09-26  Alexey Shvayka  <shvaikalesh@gmail.com>
1196
1197         toExponential, toFixed, and toPrecision should allow arguments up to 100
1198         https://bugs.webkit.org/show_bug.cgi?id=199163
1199
1200         Reviewed by Ross Kirsling.
1201
1202         Adjust StringNumberFixedWidth test due to lowering kMaxFixedDigitsBeforePoint.
1203
1204         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1205
1206 2019-09-26  Jiewen Tan  <jiewen_tan@apple.com>
1207
1208         TestWebKitAPI.SOAuthorizationSubFrame.AuthorizationOptions is failing consistently on iOS API tests EWS
1209         https://bugs.webkit.org/show_bug.cgi?id=202249
1210
1211         Reviewed by Alex Christensen.
1212
1213         Swizzles +[AKAuthorizationController isURLFromAppleOwnedDomain:] following other tests.
1214
1215         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1216         (TestWebKitAPI::TEST):
1217
1218 2019-09-25  Alex Christensen  <achristensen@webkit.org>
1219
1220         Add replacement SPI on _WKWebsiteDataStoreConfiguration for enabling speculative cache validation and IPC-free server trust evaluation
1221         https://bugs.webkit.org/show_bug.cgi?id=202251
1222
1223         Reviewed by Tim Horton.
1224
1225         Adopt new SPI instead of deprecated SPI.
1226
1227         * MiniBrowser/mac/AppDelegate.m:
1228         (persistentDataStore):
1229         (defaultConfiguration):
1230         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
1231         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
1232         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
1233
1234 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
1235
1236         Python 3: Add support in webkitpy.common.system
1237         https://bugs.webkit.org/show_bug.cgi?id=201826
1238         <rdar://problem/55452671>
1239
1240         Reviewed by Stephanie Lewis.
1241
1242         Tested compatibility by running 'python3 -m unittest webkitpy.common.system.<_unittest>' on
1243         each of the effected files.
1244
1245         * Scripts/webkitpy/common/checkout/changelog.py: Import StringIO from io module.
1246         (set_reviewer):
1247         (set_short_description_and_bug_url):
1248         * Scripts/webkitpy/common/checkout/checkout.py:  Import StringIO from io module.
1249         (Checkout._latest_entry_for_changelog_at_revision):
1250         * Scripts/webkitpy/common/config/committers.py:
1251         (CommitterList.load_json): iteritems -> items.
1252         * Scripts/webkitpy/common/net/networktransaction.py:
1253         (NetworkTransaction.run): urllib2 is urllib in Python3. 
1254         * Scripts/webkitpy/common/system/abstractexecutive.py:
1255         (AbstractExecutive._stringify_args):
1256         (AbstractExecutive.command_for_printing): The str type is unicode in Python3.
1257         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Explicitly encode and decode binary crashlogs.
1258         * Scripts/webkitpy/common/system/environment_unittest.py: Use absolute imports.
1259         * Scripts/webkitpy/common/system/executive.py:
1260         (ScriptError.message_with_output): The str type is unicode in Python3.
1261         (Executive.WrappedPopen): Python3's Popen object is a context manager. To allow us to use it as one,
1262         our Python2 Popen needs to be one as well.
1263         (Executive.WrappedPopen.__init__):
1264         (Executive.WrappedPopen.__enter__):
1265         (Executive.WrappedPopen.__exit__):
1266         (Executive._run_command_with_teed_output): Simplify loop, decode unicode strings.
1267         (Executive.run_and_throw_if_fail): The child output file should not be unicode strings.
1268         (Executive.running_pids): Use the Popen context manager to guarantee clean-up.
1269         (Executive._compute_stdin):
1270         (Executive.run_command): Use the Popen context manager to guarantee clean-up.
1271         (Executive._stringify_args): The str type is unicode in Python3.
1272         (Executive.popen): Return a context manager if the Popen object is not one.
1273         * Scripts/webkitpy/common/system/executive_mock.py:
1274         (MockProcess.__init__): StringIO -> BytesIO.
1275         (MockProcess.__enter__):
1276         (MockProcess):
1277         (MockProcess.__exit__):
1278         * Scripts/webkitpy/common/system/executive_unittest.py:
1279         (ExecutiveTest.test_auto_stringify_args): Use the Popen context manager to guarantee clean-up.
1280         (ExecutiveTest.test_popen_args): Ditto.
1281         (ExecutiveTest.serial_test_kill_process): Ditto.
1282         (ExecutiveTest.serial_test_kill_all): Ditto.
1283         * Scripts/webkitpy/common/system/filesystem.py:
1284         (FileSystem.read_binary_file): Use 'open' instead of 'file'.
1285         (FileSystem.write_binary_file): Ditto.
1286         (FileSystem.write_text_file): The str type is unicode in Python3. 
1287         (FileSystem.relpath):
1288         (FileSystem.remove): The WindowsError is just anther OSError in Python3.
1289         (FileSystem._WindowsError): Deleted.
1290         * Scripts/webkitpy/common/system/filesystem_mock.py:
1291         (MockFileSystem.glob): filter returns a generator instead of a list.
1292         (WritableBinaryFileObject.__init__): Binary files are comprised of bytes, not string in Python3.
1293         (WritableBinaryFileObject.write): Ditto.
1294         (ReadableTextFileObject.__init__): Ditto.
1295         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1296         (MockFileSystemTest.test_normpath):
1297         (MockFileSystemTest.test_dirs_under): assertEquals -> assertEqual.
1298         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1299         (RealFileSystemTest.test_read_and_write_file): Explicitly define byte arrays instead of strings.
1300         (RealFileSystemTest.test_remove_file_with_retry.remove_with_exception): The WindowsError is just
1301         anther OSError in Python3.
1302         * Scripts/webkitpy/common/system/outputcapture.py:
1303         * Scripts/webkitpy/common/system/outputtee_unittest.py:
1304         (SimpleTeeTest.test_simple_tee):
1305         * Scripts/webkitpy/common/system/path.py:
1306         (_escape): urllib library has been broken into parts.
1307         * Scripts/webkitpy/common/system/pemfile.py:
1308         (_parse_pem_format.find_end): Python3 does not define a maxint.
1309         * Scripts/webkitpy/common/system/pemfile_unittest.py:
1310         * Scripts/webkitpy/common/system/platforminfo.py:
1311         (PlatformInfo.total_bytes_memory): Not 'long' type in Python3.
1312         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1313         (TestPlatformInfo.test_real_code): assertNotEquals -> assertNotEqual.
1314         (TestPlatformInfo.test_display_name): Ditto.
1315         * Scripts/webkitpy/common/system/profiler.py:
1316         (ProfilerFactory.create_profiler): Manually implement ifilter.
1317         * Scripts/webkitpy/common/system/profiler_unittest.py: Use absolute imports.
1318         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
1319         (current_thread_id): items() returns a generator in Python3.
1320         * Scripts/webkitpy/common/system/systemhost.py: Use absolute imports.
1321         * Scripts/webkitpy/common/system/urlfetcher.py: Removed.
1322         * Scripts/webkitpy/common/system/urlfetcher_mock.py: Removed.
1323         * Scripts/webkitpy/common/system/user.py:
1324         (User.prompt): Use absolute imports, raw_input -> input.
1325         (User.prompt_with_multiple_lists):
1326         (User.prompt_with_list):
1327         (User.confirm):
1328         * Scripts/webkitpy/common/unicode.py: Tooling to manage compatibility between Python 2
1329         and Python 3 unicode handling.
1330         * Scripts/webkitpy/common/system/user_mock.py:
1331         (MockUser.prompt): raw_input -> input.
1332         (MockUser.prompt_with_list): Ditto.
1333         * Scripts/webkitpy/common/version.py:
1334         (Version.from_iterable): xrange -> range.
1335         (Version.from_name): Use absolute import path.
1336         (Version.__contains__): xrange -> range.
1337         (Version.__str__): xrange -> range.
1338         (Version.__cmp__): amp is no longer an operator in Python3, but versions are comprised
1339         Of integers, so subtraction has the same effect.
1340         (Version):
1341         (Version.__eq__): __cmp__ operator is no longer respected, so we need to implement
1342         each comparison.
1343         (Version.__ne__): Ditto.
1344         (Version.__lt__): Ditto.
1345         (Version.__le__): Ditto.
1346         (Version.__gt__): Ditto.
1347         (Version.__ge__): Ditto.
1348         * Scripts/webkitpy/common/version_name_map.py:
1349         (VersionNameMap._automap_to_major_version):
1350         (VersionNameMap.to_name): xrange -> range.
1351         (VersionNameMap.from_name): iteritems -> items.
1352         * Scripts/webkitpy/common/version_name_map_unittest.py: Use absolute imports.
1353         * Scripts/webkitpy/common/version_unittest.py: Ditto.
1354         * Scripts/webkitpy/common/wavediff.py:
1355         (WaveDiff.__init__): StringIO -> BytesIO.
1356         * Scripts/webkitpy/port/__init__.py:
1357         (outside):
1358
1359 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
1360
1361         [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests
1362         https://bugs.webkit.org/show_bug.cgi?id=202216
1363
1364         Reviewed by Jonathan Bedard.
1365
1366         * BuildSlaveSupport/ews-build/steps.py:
1367         (RunJavaScriptCoreTestsToT): Removed the command so as to use the command from base class.
1368         * BuildSlaveSupport/ews-build/steps_unittest.py: Updatd unit-tests.
1369
1370 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
1371
1372         [ews] JSC queues should run or skip tests based on runTests key from config.json
1373         https://bugs.webkit.org/show_bug.cgi?id=202223
1374
1375         Reviewed by Jonathan Bedard.
1376
1377         * BuildSlaveSupport/ews-build/config.json: Added the runTests key.
1378         * BuildSlaveSupport/ews-build/factories.py:
1379         (JSCTestsFactory.__init__): Add RunJavaScriptCoreTests step based on runTests key.
1380         * BuildSlaveSupport/ews-build/loadConfig.py:
1381         (loadBuilderConfig): Pass the runTests key to the factory.
1382         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1383         (ConfigDotJSONTest.test_builder_keys): Added the runTests key.
1384
1385 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
1386
1387         results.webkit.org: Add investigation drawer
1388         https://bugs.webkit.org/show_bug.cgi?id=202106
1389
1390         Reviewed by Dewei Zhu.
1391
1392         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Support multiple 'main' classes.
1393         * resultsdbpy/resultsdbpy/view/static/js/expectations.js: Added.
1394         (Expectations.colorMap): Return a dictionary mapping type strings to colors.
1395         (Expectations.stringToStateId): Map a string to a state ID for sorting.
1396         (Expectations.typeForId): Return a type string given an ID.
1397         (Expectations.symbolForId): Return a symbol for a type given an ID.
1398         (Expectations.colorForId): Return a color given an ID.
1399         (Expectations.unexpectedResults): Given a list of actual results and expected results,
1400         return a state.
1401         (Expectations):
1402         * resultsdbpy/resultsdbpy/view/static/js/investigate.js: Added.
1403         (commitsForUuid):
1404         (testRunLink):
1405         (elapsed):
1406         (percentage):
1407         (contentForAgregateData):
1408         (contentForData):
1409         (_InvestigateDrawer):
1410         (_InvestigateDrawer.prototype.isRendered):
1411         (_InvestigateDrawer.prototype.expand): Expand the investigation drawer.
1412         (_InvestigateDrawer.prototype.collapse): Collapse the investigation drawer.
1413         (_InvestigateDrawer.prototype.select): Select an element to investigate.
1414         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1415         (statsForSingleResult): Move Expectation constants.
1416         (TimelineFromEndpoint.prototype.render): Investigate specific data points instead
1417         of jumping to the build.
1418         (Expectations.stringToStateId): Deleted.
1419         (Expectations.unexpectedResults): Deleted.
1420         (Expectations): Deleted.
1421         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1422         (.drawer.display): Make minimum height.
1423         (@media screen and (min-width: 600px)): Move main and sidebar so they override drawer.
1424         (@media screen and (min-width: 768px)): Ditto.
1425         * resultsdbpy/resultsdbpy/view/templates/commits.html:
1426         * resultsdbpy/resultsdbpy/view/templates/search.html:
1427         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1428
1429 2019-09-25  Alex Christensen  <achristensen@webkit.org>
1430
1431         Remove duplicate WebsiteDataStoreConfiguration copying code
1432         https://bugs.webkit.org/show_bug.cgi?id=202215
1433
1434         Reviewed by Tim Horton.
1435
1436         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1437         (TEST):
1438
1439 2019-09-25  Alex Christensen  <achristensen@webkit.org>
1440
1441         Replace WebsiteDataStoreParameters::privateSessionParameters with re-initializing all sessions immediately upon NetworkProcess resumption
1442         https://bugs.webkit.org/show_bug.cgi?id=202211
1443
1444         Reviewed by Tim Horton.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
1447         (checkRecoveryAfterCrash):
1448         (TEST):
1449
1450 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
1451
1452         [EWS] JSC queues should dynamically add required build steps for re-testing the patch
1453         https://bugs.webkit.org/show_bug.cgi?id=202170
1454
1455         Reviewed by Jonathan Bedard.
1456
1457         * BuildSlaveSupport/ews-build/factories.py:
1458         (JSCTestsFactory.__init__): Do not add ReRunJavaScriptCoreTests and related steps here, as
1459         these are dynamically added (if required) in steps.py.
1460         * BuildSlaveSupport/ews-build/steps.py:
1461         (CompileJSCToT): Remove doStepIf() and hideStepIf() method, these are no longer required as we add
1462         this step dynamically only if required. We don't need an extra property ('patchFailedToBuild') to be set.
1463         (RunJavaScriptCoreTests.evaluateCommand): Dynamically add ReRunJavaScriptCoreTests step if required.
1464         (ReRunJavaScriptCoreTests): Removed doStepIf() and hideStepIf() method.
1465         (ReRunJavaScriptCoreTests.evaluateCommand): Dynamically add UnApplyPatchIfRequired(), CompileJSCToT() and RunJavaScriptCoreTestsToT steps.
1466         (RunJavaScriptCoreTestsToT.evaluateCommand): Overriden to avoid caling the base-class method which dynamically adds
1467         more steps.
1468         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1469
1470 2019-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1471
1472         [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com
1473         https://bugs.webkit.org/show_bug.cgi?id=202167
1474         <rdar://problem/55185021>
1475
1476         Reviewed by Tim Horton.
1477
1478         Rebaseline an API test.
1479
1480         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1481         (TestWebKitAPI::TEST):
1482
1483 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
1484
1485         Unreviewed, rolling out r250324.
1486
1487         Tools/ChangeLog
1488
1489         Reverted changeset:
1490
1491         "Enable LayoutTests using ResourceLoadStatistics SQLite
1492         backend (195420)"
1493         https://bugs.webkit.org/show_bug.cgi?id=195420
1494         https://trac.webkit.org/changeset/250324
1495
1496 2019-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1497
1498         [Windows][webkitpy] _apache_config_file_name_for_platform should take the system PHP version into account
1499         https://bugs.webkit.org/show_bug.cgi?id=202134
1500
1501         Reviewed by Jonathan Bedard.
1502
1503         _apache_config_file_name_for_platform always returns a config file
1504         name for PHP5 on Cygwin Python, one for PHP7 on Win32 Python. It
1505         should detect the system PHP version as Linux ports do.
1506
1507         Both AppleWin and WinCairo are using XAMPP Apache. Unify the code
1508         paths for them. And, remove a stale conf file.
1509
1510         This change makes it possible to use Cygwin Python with PHP7.
1511
1512         * Scripts/webkitpy/port/base.py:
1513         (Port._win_php_version): Added.
1514         (Port._apache_config_file_name_for_platform): Unified cygwin and
1515         win32 code path by using _win_php_version.
1516         * Scripts/webkitpy/port/port_testcase.py:
1517         (test_apache_config_file_name_for_platform): Updated cygwin and
1518         win32 test cases.
1519
1520 2019-09-24  Matt Lewis  <jlewis3@apple.com>
1521
1522         Bring up queues for iPadOS Simulator Tests
1523         https://bugs.webkit.org/show_bug.cgi?id=202151
1524
1525         Reviewed by Jonathan Bedard.
1526
1527         * BuildSlaveSupport/build.webkit.org-config/config.json:
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1529         (WebKitBuildbot):
1530         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1531
1532 2019-09-24  Kate Cheney  <katherine_cheney@apple.com>
1533
1534         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
1535         https://bugs.webkit.org/show_bug.cgi?id=195420                          
1536         <rdar://problem/54213551>                                               
1537
1538         Reviewed by Brent Fulgham.                                             
1539
1540         Added in logic to send a message from the UIProcess to the Network      
1541         Process which will initalize the ITP Database backend to allow for      
1542         layout testing.                                                         
1543         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1544         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1545         (WTR::TestRunner::setUseITPDatabase):
1546         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1547         * WebKitTestRunner/TestController.cpp:
1548         (WTR::TestController::setUseITPDatabase):
1549         * WebKitTestRunner/TestController.h:
1550         * WebKitTestRunner/TestInvocation.cpp:
1551         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1552
1553 2019-09-24  Patrick Griffis  <pgriffis@igalia.com>
1554
1555         Add Patrick Griffis to contributors.json
1556
1557         Unreviewed.
1558
1559         * Scripts/webkitpy/common/config/contributors.json:
1560
1561 2019-09-24  Aakash Jain  <aakash_jain@apple.com>
1562
1563         [ews-build] Improve summary for Validate Patch step
1564         https://bugs.webkit.org/show_bug.cgi?id=202163
1565
1566         Reviewed by Jonathan Bedard.
1567
1568         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Remove the redundant message saying:
1569         'Some messages were logged while the patch was still eligible'.
1570         * BuildSlaveSupport/ews-build/steps.py:
1571         (ValidatePatch.skip_build): Updated the descritionDone with the reason to skip the patch.
1572         (ValidatePatch.getResultSummary): Overrode this method so as to prevent buildbot from automatically
1573         appending '(failure)' at the end of the summary string.
1574
1575 2019-09-24  Keith Rollin  <krollin@apple.com>
1576
1577         Coalesce or remove PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
1578         https://bugs.webkit.org/show_bug.cgi?id=202119
1579         <rdar://problem/55638792>
1580
1581         Reviewed by Alex Christensen.
1582
1583         After refactoring and other code evolution, some platform checks have
1584         ended up looking like PLATFORM(MAC) || PLATFORM(IOS_FAMILY) (or
1585         vice-versa). These can be converted into the equivalent
1586         PLATFORM(COCOA). Where the instance occurs in a Cocoa-only file, the
1587         check can be removed altogether (along with any "#else" branches).
1588
1589         * DumpRenderTree/AccessibilityTextMarker.h:
1590         * DumpRenderTree/AccessibilityUIElement.cpp:
1591         (AccessibilityUIElement::setValue):
1592
1593 2019-09-24  Zhifei Fang  <zhifei_fang@apple.com>
1594
1595         Add tests for Ref.js.
1596         https://bugs.webkit.org/show_bug.cgi?id=201778.
1597
1598         Reviewed by Jonathan Bedard.
1599
1600         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1601         (applyStateDiff): null, 0, false are all valid state
1602         (Ref.prototype.setState): We should do nothing for undefined stateDiff
1603         * resultsdbpy/resultsdbpy/view/static/library/js/Test.js: Added.
1604         (AssertFailedError):
1605         (Expect): Perform assertions during unit tests.
1606         (Expect.prototype.isType):
1607         (Expect.prototype.equalToValue):
1608         (Expect.prototype.equalToHtmlWithoutRef):
1609         (Expect.prototype.notEqualToValue):
1610         (Expect.prototype.greaterThan):
1611         (Expect.prototype.greaterThanOrEqualTo):
1612         (Expect.prototype.lessThan):
1613         (Expect.prototype.lessThanOrEqualTo):
1614         (TestSuite): Common TestSuite class for user to extend. 
1615         (TestSuite.prototype.expect):
1616         (TestSuite.prototype.sleep): Test will sleep for certain ms
1617         (TestSuite.prototype.waitForSignal): Wait until we receive a certain signal with timeout
1618         (TestSuite.prototype.waitForRefMounted): Wait until we receive ref object's onElementMount signal with timeout
1619         (TestSuite.prototype.waitForRefUnmounted): Wait until we receive ref object's onElementUnmount signal with timeout
1620         (TestSuite.prototype.waitForStateUpdated):Wait until we receive ref object's onStateUpdate signal with timeout
1621         (TestSuite.prototype.async.setup): Common interface for setup a test suite
1622         (TestSuite.prototype.async.clearUp): Common interface for clear up a test suite
1623         (getTestFucntionNames): Collect all the test method of a test instance.
1624         (TestResult):
1625         (TestResult.prototype.catchException):
1626         (async.getTestResult): Run the test and generate a TestResult object
1627         (TestController):
1628         (TestController.prototype.addResultHandler): Test controller will send notification of a test result to result handler
1629         (TestController.prototype.addSetupArgs): This gives some additional args for the common setup method for each test class, 
1630         it is the best place to setup something like a root element, a fake data source, etc
1631         (TestController.prototype.collect): This method used for collect the test classes.
1632         (TestController.prototype.async.collectFile): It will import the file as a module dynamicly and collect all the test classes that module export
1633         (TestController.prototype.async.runTest): It will run a test method of a test class
1634         (TestController.prototype.async.run): It will run all test or a test class or a test method
1635         * resultsdbpy/resultsdbpy/view/static/library/js/components/TestComponents.js: components for test app.
1636         * resultsdbpy/resultsdbpy/view/static/library/js/test/RefTest.js: Ref.js test cases.
1637         * resultsdbpy/resultsdbpy/view/static/library/js/test/index.html: Test app entry.
1638
1639 2019-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1640
1641         FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState triggers a debug assertion
1642         https://bugs.webkit.org/show_bug.cgi?id=202145
1643         <rdar://problem/51273128>
1644
1645         Reviewed by Tim Horton.
1646
1647         Fixes this API test to work on iPad as well as iPhone. Importantly, we show a popover when focusing
1648         select elements on iPad, which means that there is no -inputView present on WKContentView, and upon
1649         dismissing the form accessory view, the select element is still focused.
1650
1651         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1652
1653 2019-09-25  Cathie Chen  <cathiechen@igalia.com>
1654
1655         Add Cathie Chen as WebKit committer
1656
1657         Unreviewed.
1658
1659         * Scripts/webkitpy/common/config/contributors.json:
1660
1661 2019-09-24  Alex Christensen  <achristensen@webkit.org>
1662
1663         Require a WebsiteDataStore when creating or resuming downloads
1664         https://bugs.webkit.org/show_bug.cgi?id=202081
1665
1666         Reviewed by Youenn Fablet.
1667
1668         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1669         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
1670
1671 2019-09-23  Zan Dobersek  <zdobersek@igalia.com>
1672
1673         run-web-platform-tests: remove support for in-repository manifest, expectation management
1674         https://bugs.webkit.org/show_bug.cgi?id=202037
1675
1676         Reviewed by Carlos Alberto Lopez Perez.
1677
1678         Instead of keeping wpt metadata inside the WebKit repository or have it
1679         generated on-the-fly, provide additional option flags for the
1680         run-web-platform-tests script that allows detailed specification of the
1681         metadata, manifest and include manifest locations, if necessary.
1682
1683         If the metadata location is not provided, the wptrunner tool will simply
1684         not rely on any metadata to adjust expected results. With no manifest
1685         path specified, the manifest will be generated inside the wpt checkout.
1686         If no include manifest is specified, all the tests will be initially
1687         selected for running (until they're possibly filtered through additional
1688         command line arguments).
1689
1690         * Scripts/webkitpy/common/config/ports_mock.py:
1691         (MockPort.run_bindings_tests_command):
1692         (MockPort.wpt_metadata_directory): Deleted.
1693         (MockPort.wpt_manifest_file): Deleted.
1694         * Scripts/webkitpy/port/base.py:
1695         (Port.default_results_directory):
1696         (Port.wpt_metadata_directory): Deleted.
1697         (Port.wpt_manifest_file): Deleted.
1698         * Scripts/webkitpy/w3c/wpt_runner.py:
1699         (parse_args):
1700         (WPTRunner.prepare_wpt_checkout):
1701         (WPTRunner.run):
1702         (WPTRunner._generate_metadata_directory): Deleted.
1703         (WPTRunner._wpt_run_paths): Deleted.
1704         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
1705         (WPTRunnerTest.TestInstance.__init__):
1706         (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
1707         (WPTRunnerTest.test_run):
1708         (WPTRunnerTest.test_run_with_specified_options):
1709         (WPTRunnerTest.test_run_with_args):
1710         (WPTRunnerTest.TestInstance.prepare_mock_files_for_run): Deleted.
1711         (WPTRunnerTest.test_generate_metadata_directory): Deleted.
1712
1713 2019-09-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1714
1715         [Win][WebKitTestRunner] Implement EventSenderProxy::keyDown
1716         https://bugs.webkit.org/show_bug.cgi?id=201913
1717
1718         Reviewed by Ross Kirsling.
1719
1720         Implemented eventSender.keyDown for Windows WebKitTestRunner based
1721         on DumpRenderTree implementation.
1722
1723         There is a difference between them. Only WTR truns KF_UP and
1724         KF_REPEAT flags on for WM_KEYUP event.
1725         EventSenderProxy::dispatchMessage is used in WTR. It calls
1726         TranslateMessage, this introduces the difference. If I didn't turn
1727         those bits, TranslateMessage posts WM_CHAR even for WM_KEYUP.
1728         According the spec, WM_KEYUP needs those bits.
1729         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-keyup>
1730         DRT doesn't need the those bits becasuse it doesn't use
1731         TranslateMessage for WM_KEYUP.
1732
1733         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1734         (WTR::makeKeyDataForScanCode): Added.
1735         (WTR::pumpMessageQueue): Added.
1736         (WTR::EventSenderProxy::keyDown): Implemented by using DRT code.
1737
1738 2019-09-23  Aakash Jain  <aakash_jain@apple.com>
1739
1740         [EWS] Rename CompileJSCOnly to CompileJSC
1741         https://bugs.webkit.org/show_bug.cgi?id=202118
1742
1743         Reviewed by Jonathan Bedard.
1744
1745         * BuildSlaveSupport/ews-build/factories.py:
1746         (JSCTestsFactory.__init__): Renamed CompileJSCOnly to CompileJSC.
1747         * BuildSlaveSupport/ews-build/steps.py:
1748         (CompileWebKit.evaluateCommand): Ditto.
1749         (AnalyzeCompileWebKitResults.start): Ditto.
1750         (CompileJSC): Changed step-name to 'compile-jsc' to better match with similar steps like 'compile-webkit'. 
1751         (CompileJSCToT): Ditto for 'compile-jsc-tot'.
1752         * BuildSlaveSupport/ews-build/steps_unittest.py: Renamed CompileJSCOnly to CompileJSC and CompileJSCOnlyToT to CompileJSCToT.
1753
1754 2019-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1755
1756         [iOS] Drop animation when dragging images from Photos to WebKit2 Mail compose is incorrect
1757         https://bugs.webkit.org/show_bug.cgi?id=201674
1758         <rdar://problem/51250952>
1759
1760         Reviewed by Tim Horton.
1761
1762         Add a couple of new API tests to exercise the new image placeholder drop codepath, in addition to testing
1763         infrastructure to simulate the timing of drop animation delegate calls.
1764
1765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1766         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1767         (-[NSArray _attachmentWithName:]):
1768         (-[TestWKWebView allBoundingClientRects:]):
1769
1770         Add some new API testing helper methods.
1771
1772         (TestWebKitAPI::targetedImageDragPreview):
1773         (TestWebKitAPI::TEST):
1774
1775         Add two new tests, to:
1776         (1) verify that images are dropped as attachment-backed placeholder image elements when the web view is editable
1777             and enables attachment elements, and
1778         (2) verify that when dropping an image taller than the web view, the bottom portion of the drop preview is
1779             clipped using the targeted preview parameter's visiblePath.
1780
1781         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1782         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
1783         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1784         * TestWebKitAPI/cocoa/NSItemProviderAdditions.h: Added.
1785         * TestWebKitAPI/cocoa/NSItemProviderAdditions.mm: Added.
1786
1787         Move some common helpers for registering data on a NSItemProvider to a separate file, so that it can be used in
1788         both WKAttachmentTests and DragAndDropTests.
1789
1790         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1791         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:loadingDelay:]):
1792         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1793         (-[DragAndDropSimulator initWithWebView:]):
1794         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
1795         (-[DragAndDropSimulator clearExternalDragInformation]):
1796         (-[DragAndDropSimulator setExternalItemProviders:defaultDropPreviews:]):
1797
1798         Add a new method to allow tests to specify both a list of externally dragged item providers, as well as default
1799         targeted previews for each of the corresponding items. These default previews are used when invoking the drop
1800         interaction delegate's preview generation methods.
1801
1802         (-[DragAndDropSimulator addAnimations:]):
1803
1804         Not implemented yet; for now, this simply asserts.
1805
1806         (-[DragAndDropSimulator addCompletion:]):
1807
1808         Queues a completion handler, which is invoked when the drop animation for each item completes. Depending on the
1809         value of DragAndDropSimulator's -dropAnimationTiming, this may occur either before or after handling the drop.
1810         By default, these will be invoked after the drop completes, which represents the common case where data can be
1811         loaded quickly relative to the drop animation.
1812
1813         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
1814         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1815
1816 2019-09-23  Jonathan Bedard  <jbedard@apple.com>
1817
1818         results.webkit.org: Collapse results with the same version name (Follow-up fix)
1819         https://bugs.webkit.org/show_bug.cgi?id=201779
1820
1821         Rubber-stamped by Aakash Jain.
1822
1823         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1824         (Configuration.prototype.compare): Correctly compare constructed version names.
1825
1826 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
1827
1828         [WebAuthn] LocalAuthenticator tests are failing on internal bots
1829         https://bugs.webkit.org/show_bug.cgi?id=201844
1830         <rdar://problem/54278693>
1831
1832         Reviewed by Brent Fulgham.
1833
1834         LocalAuthenticator tests utilize Keychain for mock testing. Unlike iOS simulator tests which
1835         each test runner is running in different simulator containers, all test runners are running
1836         in the same macOS container in macOS. Therefore, Keychain is shared among all test runners
1837         in macOS while it is not in iOS simulators. And therefore, race conditions would happen in
1838         macOS which make the current tests flaky given they don't consider race conditions.
1839
1840         This patch then makes each test generate a random credential, and thus no other tests would
1841         be able to access it, and therefore eliminate any race condition. To support this, a few new
1842         functionalities are introduced to the mock test infrastructure as well:
1843         1) TestRunner.cleanUpKeychain accepts a new parameter to more precisely identify an item.
1844         2) WebAuthenticationMockConfiguration.Local has a new member to uniquely select a credential
1845         for getAssertion ceremony when multiple presents.
1846
1847         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1848         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1849         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1850         (WTR::TestRunner::cleanUpKeychain):
1851         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1852         * WebKitTestRunner/TestController.h:
1853         * WebKitTestRunner/TestInvocation.cpp:
1854         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1855         * WebKitTestRunner/TestController.cpp:
1856         (WTR::TestController::cleanUpKeychain):
1857         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1858         (WTR::TestController::cleanUpKeychain):
1859
1860 2019-09-20  Aakash Jain  <aakash_jain@apple.com>
1861
1862         [EWS] JSC queues should re-build ToT and compare results on build failure
1863         https://bugs.webkit.org/show_bug.cgi?id=201999
1864
1865         Reviewed by Jonathan Bedard.
1866
1867         * BuildSlaveSupport/ews-build/factories.py:
1868         (JSCTestsFactory.__init__): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
1869         these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
1870         Also setting skipUpload=False since we don't need to upload the archive for this queue. Building and testing is done in same build.
1871         * BuildSlaveSupport/ews-build/steps.py:
1872         (CompileWebKit.evaluateCommand): Add CompileJSCOnlyToT or CompileWebKitToT build-step based on 'group' property.
1873         (AnalyzeCompileWebKitResults.start): Ditto.
1874         (CompileJSCOnly.start): Set the 'group' property to 'jsc'.
1875         (CompileJSCOnlyToT.evaluateCommand): Over-ride evaluateCommand, so that base-class' (CompileWebKit) evaluateCommand is 
1876         not used, base class evaluateCommand adds build-steps dynamically.
1877
1878 2019-09-20  Keith Rollin  <krollin@apple.com>
1879
1880         Remove some support for < iOS 13
1881         https://bugs.webkit.org/show_bug.cgi?id=201967
1882         <rdar://problem/55504738>
1883
1884         Reviewed by Andy Estes.
1885
1886         Remove some support for iOS versions less than 13.0.
1887
1888         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1889         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1890         values >= 130000. This means that expressions like
1891         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
1892         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
1893
1894         After version checks have been removed, there are some cases where the
1895         preprocessor conditional looks like "#if PLATFORM(MAC) ||
1896         PLATFORM(IOS_FAMILY)". These can be collapsed into "#if
1897         PLATFORM(COCOA)". This additional cleanup will be performed in a
1898         subsequent patch.
1899
1900         This removal is part of a series of patches effecting the removal of
1901         dead code for old versions of iOS. This particular pass involves
1902         changes in which Andy Estes was involved. These changes are isolated
1903         from other similar changes in order to facilitate the reviewing
1904         process.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed.
1907
1908 2019-09-20  Alex Christensen  <achristensen@webkit.org>
1909
1910         Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
1911         https://bugs.webkit.org/show_bug.cgi?id=202025
1912
1913         Reviewed by Chris Dumez.
1914
1915         One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
1916         because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.
1917
1918         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
1919         * WebKitTestRunner/TestController.cpp:
1920         (WTR::TestController::websiteDataStore):
1921         (WTR::TestController::generatePageConfiguration):
1922
1923 2019-09-20  Keith Rollin  <krollin@apple.com>
1924
1925         Remove some support for < iOS 13
1926         https://bugs.webkit.org/show_bug.cgi?id=201973
1927         <rdar://problem/55506966>
1928
1929         Reviewed by Alex Christensen.
1930
1931         Remove some support for iOS versions less than 13.0.
1932
1933         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1934         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1935         values >= 130000. This means that expressions like
1936         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
1937         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
1938
1939         This removal is part of a series of patches effecting the removal of
1940         dead code for old versions of iOS. This particular pass involves
1941         changes in which Chris Dumez was involved. These changes are isolated
1942         from other similar changes in order to facilitate the reviewing
1943         process.
1944
1945         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1946
1947 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
1948
1949         [FTW] Enable WebKitTestRunner build
1950         https://bugs.webkit.org/show_bug.cgi?id=201996
1951
1952         Reviewed by Fujii Hironori.
1953
1954         It's time to start getting the test system up and running for FTW.
1955
1956         This patch does the following:
1957
1958         1. Adds relevant CMake changes to get things building.
1959         2. Adds a "--ftw" flag to the build scripts that will trigger a relevant build.
1960         3. Updates 'webkitpy' to recognize the 'ftw' port.
1961
1962         Note: Pixel tests are not yet supported.
1963
1964         * PlatformFTW.cmake: Build the WK2 test runner.
1965         * Scripts/build-webkit: Update to recognize the FTW port.
1966         * Scripts/webkitdirs.pm: Ditto.
1967         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Ditto.
1968         * Scripts/webkitpy/common/config/ports.py: Ditto.
1969         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1970         * Scripts/webkitpy/common/version_name_map.py: Ditto.
1971         * Scripts/webkitpy/port/factory.py: Ditto.
1972         * Scripts/webkitpy/port/win.py: Ditto.
1973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1974         (WTR::InjectedBundlePage::dumpDOMAsWebArchive): Don't build or run this method
1975         on Windows.
1976         * WebKitTestRunner/PlatformFTW.cmake: Added.
1977         * WebKitTestRunner/PlatformWebView.h:
1978         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1979         * WebKitTestRunner/win/TestInvocationDirect2D.cpp: Added.
1980         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add stub implementation.
1981
1982 2019-09-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1983
1984         [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
1985         https://bugs.webkit.org/show_bug.cgi?id=201976
1986
1987         Reviewed by Don Olmstead.
1988
1989         This change consists of three refactorings:
1990         1. Replaced explicit QueryInterface with _com_ptr_t methods
1991         2. Replaced typedef with _COM_SMARTPTR_TYPEDEF macro
1992         3. Replaced WebCore's COMPtr with _com_ptr_t because it is not a public WebKit API
1993
1994         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1995         (MiniBrowserWebHost::didFirstLayoutInFrame): Deleted.
1996         * MiniBrowser/win/MiniBrowserWebHost.h:
1997         (MiniBrowserWebHost::didFirstLayoutInFrame):
1998         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1999         (getHandleFromWebView):
2000         (PrintWebUIDelegate::webViewPrintingMarginRect):
2001         (PrintWebUIDelegate::runModal):
2002         (PrintWebUIDelegate::createModalDialog):
2003         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2004         (WebKitLegacyBrowserWindow::init):
2005         (WebKitLegacyBrowserWindow::setToDefaultPreferences):
2006         (WebKitLegacyBrowserWindow::showLastVisitedSites):
2007         (WebKitLegacyBrowserWindow::reload):
2008         (WebKitLegacyBrowserWindow::resetZoom):
2009         (WebKitLegacyBrowserWindow::zoomIn):
2010         (WebKitLegacyBrowserWindow::zoomOut):
2011         (WebKitLegacyBrowserWindow::showLayerTree):
2012         (WebKitLegacyBrowserWindow::print):
2013         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2014         (WebKitLegacyBrowserWindow::privatePreferences):
2015         * MiniBrowser/win/WinMain.cpp:
2016         (wWinMain):
2017         * MiniBrowser/win/stdafx.h:
2018
2019 2019-09-19  Joanmarie Diggs  <jdiggs@igalia.com>
2020
2021         [GTK] Dependency hunspell-en-gb cannot be found on Fedora 30
2022         https://bugs.webkit.org/show_bug.cgi?id=202009
2023
2024         Update package name to hunspell-en-GB.
2025
2026         Reviewed by Carlos Alberto Lopez Perez.
2027
2028         * gtk/install-dependencies:
2029
2030 2019-09-19  Jonathan Bedard  <jbedard@apple.com>
2031
2032         results.webkit.org: Collapse results with the same version name
2033         https://bugs.webkit.org/show_bug.cgi?id=201779
2034
2035         Rubber-stamped by Aakash Jain.
2036
2037         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2038         (Configuration.prototype.const.ending.this.version_name.substring):
2039         (Configuration.prototype.toKey): Prefer version_name over version number in key.
2040         (Configuration.prototype.compare): version_name comparison should always override version comparison.
2041         (Configuration.prototype.compareSDKs): Make SDK regex global.
2042         (Configuration.prototype.toParams): Remove E tag on version_name.
2043         (Configuration): Append E tag on the version_name based on the SDK.
2044         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2045         (TimelineFromEndpoint.prototype.toString): Print version number with SDK.
2046
2047 2019-09-19  Ryan Haddad  <ryanhaddad@apple.com>
2048
2049         REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing
2050         https://bugs.webkit.org/show_bug.cgi?id=201902
2051
2052         Unreviewed test gardening.
2053
2054         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Disable the test on iOS.
2055
2056 2019-09-19  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews] Fix platform for JSC EWS
2059         https://bugs.webkit.org/show_bug.cgi?id=201997
2060
2061         Reviewed by Jonathan Bedard.
2062
2063         * BuildSlaveSupport/ews-build/config.json:
2064
2065 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
2066
2067         Create InjectedBundle SPI to better support NSSecureCoding
2068         https://bugs.webkit.org/show_bug.cgi?id=201810
2069         <rdar://problem/55265713>
2070
2071         The encoding/decoding routines used by WebKit’s InjectedBundles are based on NSCoding.
2072         While we have changed WebKit internals to use NSSecureCoding, there are a number of
2073         injected bundles that need to serialize custom classes between the InjectedBundle and
2074         the relevant WebKit UIProcess.
2075
2076         We need to lock down this communications channel by enforcing NSSecureCoding.
2077
2078         This patch creates new SPI to allow the UIProcess to specify classes that it will accept
2079         in messages from the WebContet Process (and Injected Bundle).
2080
2081         It adds the following property to the WKProcessPoolConfiguration:
2082
2083             @property (nonatomic, copy) NSSet<Class> *customClassesForParameterCoder;
2084
2085         If no custom classes are specified, the standard serialization primitives are supported:
2086             NSArray, NSData, NSDate, NSDictionary, NSNull, NSNumber, NSSet, NSString,
2087             NSTimeZone, NSURL, and NSUUID.
2088
2089         Reviewed by Brady Eidson.
2090
2091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2092         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegate.mm: Added.
2093         (-[BundleFormDelegateRemoteObject didGetFocus]):
2094         (-[FormInputDelegate _webView:decidePolicyForFocusedElement:]):
2095         (TEST):
2096         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegatePlugIn.mm: Added.
2097         (-[BundleFormDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2098         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:willBeginInputSessionForElement:inFrame:userIsInteracting:]):
2099         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:didFocusTextField:inFrame:]):
2100         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegateProtocol.h: Copied from Tools/TestWebKitAPI/WKWebViewConfigurationExtras.h.
2101         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2102         (TEST):
2103         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2104         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2105         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
2106         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:andCustomParameterClasses:]):
2107
2108 2019-09-18  Zhifei Fang  <zhifei_fang@apple.com>
2109
2110         [results.webkit.org] fix missing col classes
2111         https://bugs.webkit.org/show_bug.cgi?id=201949
2112
2113         Reviewed by Jonathan Bedard.
2114
2115         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2116         (@media screen and (min-width: 768px)):
2117         (.row):
2118         (.col-1):
2119         (.col-2):
2120         (.col-3):
2121         (.col-4):
2122         (.col-5):
2123         (.col-6):
2124         (.col-7):
2125         (.col-8):
2126         (.col-9):
2127         (.col-10):
2128         (.col-11):
2129         (.col-12):
2130         (@media screen and (min-width: 600px)):
2131
2132 2019-09-18  Ryan Haddad  <ryanhaddad@apple.com>
2133
2134         Update flakiness dashboard configuration for iOS 13 queues
2135         https://bugs.webkit.org/show_bug.cgi?id=201711
2136
2137         Reviewed by Jonathan Bedard.
2138
2139         * TestResultServer/static-dashboards/builders.jsonp:
2140
2141 2019-09-18  Adrian Perez de Castro  <aperez@igalia.com>
2142
2143         [WPE][GTK] Update build environments to use libwpe+WPEBackend-fdo 1.4.0
2144         https://bugs.webkit.org/show_bug.cgi?id=201915
2145
2146         Reviewed by Michael Catanzaro.
2147
2148         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.4.0
2149         * gtk/jhbuild.modules: Ditto.
2150         * wpe/jhbuild.modules: Ditto.
2151
2152 2019-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2153
2154         [Win][MiniBrowser] Remove unused DOMDefaultImpl.cpp
2155         https://bugs.webkit.org/show_bug.cgi?id=201867
2156
2157         Reviewed by Darin Adler.
2158
2159         * MiniBrowser/win/CMakeLists.txt: Removed DOMDefaultImpl.cpp.
2160         * MiniBrowser/win/DOMDefaultImpl.cpp: Removed.
2161         * MiniBrowser/win/DOMDefaultImpl.h: Removed.
2162         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2163
2164 2019-09-17  Dean Jackson  <dino@apple.com>
2165
2166         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
2167         https://bugs.webkit.org/show_bug.cgi?id=201864
2168         <rdar://55190038>
2169
2170         Reviewed by Simon Fraser.
2171
2172         Test for the suggested actions.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2175         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
2176         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
2177         (TEST):
2178
2179 2019-09-17  Jonathan Bedard  <jbedard@apple.com>
2180
2181         results.webkit.org results bubbles' tooltips should include SDK information
2182         https://bugs.webkit.org/show_bug.cgi?id=201823
2183
2184         Rubber-stamped by Aakash Jain.
2185
2186         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2187         (Configuration.prototype.compare): Like the Python instance of this class,
2188         support using null as a wildcard.
2189         (Configuration.prototype.compareSDKs): Ditto.
2190         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2191         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Construct a configuration
2192         object from all bits of data used to construct a given bubble.
2193         (TimelineFromEndpoint.prototype.render):
2194
2195 2019-09-17  Keith Rollin  <krollin@apple.com>
2196
2197         Remove some support for < iOS 12
2198         https://bugs.webkit.org/show_bug.cgi?id=201851
2199         <rdar://problem/55422044>
2200
2201         Reviewed by Jiewen Tan and Alexey Proskuryakov.
2202
2203         Remove some support for iOS versions less than 12.0.
2204
2205         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
2206         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
2207         values >= 120000. This means that expressions like
2208         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101200" are always False and
2209         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101200" are always True.
2210
2211         This removal is part of a series of patches effecting such removal.
2212
2213         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2214         (WTR::installFakeHelvetica):
2215
2216 2019-09-17  David Kilzer  <ddkilzer@apple.com>
2217
2218         run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
2219         <https://webkit.org/b/201873>
2220
2221         Reviewed by Jonathan Bedard.
2222
2223         * Scripts/webkitpy/port/driver.py:
2224         (Driver.run_test): Call self.do_post_tests_work() when a test
2225         shard has completed, but didn't crash or time out.
2226
2227 2019-09-17  Chris Dumez  <cdumez@apple.com>
2228
2229         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
2230         https://bugs.webkit.org/show_bug.cgi?id=201859
2231         <rdar://problem/55426742>
2232
2233         Reviewed by Alex Christensen.
2234
2235         Update API test to use WKWebsiteDataStoreRef C API to do private browsing instead of using
2236         the legacy WKPreferencesSetPrivateBrowsingEnabled() C API.
2237
2238         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2239         (TestWebKitAPI::TEST):
2240
2241 2019-09-17  Ryan Haddad  <ryanhaddad@apple.com>
2242
2243         Bring up queues for iOS 13
2244         https://bugs.webkit.org/show_bug.cgi?id=201710
2245
2246         Reviewed by Jonathan Bedard.
2247
2248         * BuildSlaveSupport/build.webkit.org-config/config.json: Move iOS 12 queues to iOS 13.
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Ditto.
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2251         (WebKitBuildbot):
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2253         (table.queue-grid tr.platform.ios-simulator-12 img.logo): Deleted.
2254         (table.queue-grid tr.platform.ios-12 img.logo): Deleted.
2255         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit tests.
2256         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2257         (_should_file_trigger_build):
2258         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2259         (ShouldBuildTest):
2260         (ShouldBuildTest.test_should_build):
2261         * BuildSlaveSupport/ews-build/config.json: Move iOS 12 queues to iOS 13.
2262
2263 2019-09-17  Truitt Savell  <tsavell@apple.com>
2264
2265         Unreviewed, rolling out r249950.
2266
2267         Broke the iOS build.
2268
2269         Reverted changeset:
2270
2271         "Remove the "Show Link Previews" and "Hide Link Previews"
2272         action menus in the preview platter"
2273         https://bugs.webkit.org/show_bug.cgi?id=201864
2274         https://trac.webkit.org/changeset/249950
2275
2276 2019-09-17  Dean Jackson  <dino@apple.com>
2277
2278         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
2279         https://bugs.webkit.org/show_bug.cgi?id=201864
2280         <rdar://55190038>
2281
2282         Reviewed by Simon Fraser.
2283
2284         Test for the suggested actions.
2285
2286         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2287         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
2288         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
2289         (TEST):
2290
2291 2019-09-16  Alex Christensen  <achristensen@webkit.org>
2292
2293         Remove "gopher" from list of special schemes in URLParser
2294         https://bugs.webkit.org/show_bug.cgi?id=201852
2295
2296         Reviewed by Simon Fraser.
2297
2298         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2299         (TestWebKitAPI::TEST_F):
2300         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
2301         (TestWebKitAPI::TEST_F):
2302         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2303
2304 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
2305
2306         results.webkit.org: Shard result archives
2307         https://bugs.webkit.org/show_bug.cgi?id=201734
2308
2309         Reviewed by Dewei Zhu.
2310
2311         Cassandra advertises being able to store up to 2 GB in a single blob-storage row.
2312         In practice, this usually doesn't work according to the Cassandra developers,
2313         large blobs should be broken up into shards of, at most, 10 MB.
2314
2315         * resultsdbpy/resultsdbpy/model/archive_context.py:
2316         (ArchiveContext):
2317         (ArchiveContext.ArchiveMetaDataByCommit): Point to the archive shards by hash.
2318         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
2319         (ArchiveContext.ArchiveChunks): Store archive shards, indexed by hash.
2320         (ArchiveContext.__init__):
2321         (ArchiveContext.register): When saving archives, save a reference hash and then
2322         shard the actual archive data before saving.
2323         (ArchiveContext.find_archive): Search for archive by meta-data, then reconstruct
2324         the archive. Raise an exception if we determine that memory usage is a problem.
2325         (ArchiveContext.ArchivesByCommit): Deleted.
2326         (ArchiveContext.ArchivesByCommit.unpack): Deleted.
2327         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py:
2328         (ArchiveContextTest.init_database): Allow configuration and archive to be specified.
2329         (ArchiveContextTest):
2330         (ArchiveContextTest.test_large_archive): Test archive sharding.
2331
2332 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
2333
2334         [WebAuthn] Support more than two FIDO protocol versions
2335         https://bugs.webkit.org/show_bug.cgi?id=198408
2336         <rdar://problem/51292176>
2337
2338         Reviewed by Chris Dumez.
2339
2340         Adds a new test case that includes a FIDO_2_1_PRE version string.
2341
2342         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2343         (TestWebKitAPI::TEST):
2344         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2345
2346 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
2347
2348         results.webkit.org: Configurations should be branch specific
2349         https://bugs.webkit.org/show_bug.cgi?id=201561
2350
2351         Reviewed by Dewei Zhu.
2352
2353         Partition configurations by branch in both Redis and Cassandra.
2354
2355         * resultsdbpy/resultsdbpy/controller/upload_controller.py:
2356         (UploadController.suites): Allow the user to specify branches while listing suites.
2357         * resultsdbpy/resultsdbpy/model/archive_context.py:
2358         (ArchiveContext.register): Register each configuration with a branch.
2359         * resultsdbpy/resultsdbpy/model/configuration_context.py:
2360         (ConfigurationContext.ByPlatform): Index by branch.
2361         (ConfigurationContext.ByPlatformAndVersion): Ditto.
2362         (ConfigurationContext.ByArchitecture): Ditto.
2363         (ConfigurationContext.ByModel): Ditto.
2364         (ConfigurationContext.__init__): Populate Redis cache with branch.
2365         (ConfigurationContext._convert_to_redis_key): Accept branch in Redis key.
2366         (ConfigurationContext._register_in_redis): Register configuration with branch.
2367         (ConfigurationContext.register_configuration): Ditto.
2368         (ConfigurationContext.search_for_configuration): Search for configuration with branch.
2369         (ConfigurationContext.search_for_recent_configuration): Ditto.
2370         (ConfigurationContext.select_from_table_with_configurations): Ditto.
2371         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
2372         (ConfigurationContextTest.register_configurations): Register with branch.
2373         (ConfigurationContextTest.test_repopulate_recent): Construct ConfigurationContext with
2374         CommitContext object.
2375         * resultsdbpy/resultsdbpy/model/upload_context.py:
2376         (UploadContext.SuitesByConfiguration): Index by branch.
2377         (UploadContext.upload_test_results): Register each configuration with a branch.
2378         (UploadContext.find_suites): Pass branch to search for configurations.
2379         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Check for new configurations when the branch is changed.
2380         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add branch to suites query.
2381
2382 2019-09-16  David Kilzer  <ddkilzer@apple.com>
2383
2384         check-webkit-style: Fix warning message for std::make_unique<typename[]>
2385         <https://webkit.org/b/201818>
2386
2387         Reviewed by Darin Adler.
2388
2389         * Scripts/webkitpy/style/checkers/cpp.py:
2390         (check_wtf_make_unique): Emit different error message when using
2391         std::make_unique<>() to create an array.  Personalize the error
2392         message by including the original type name, which also
2393         demonstrates that WTF::makeUniqueArray<>() does not need square
2394         brackets for its typename.
2395         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2396         (WebKitStyleTest.test_wtf_make_unique): Add test.
2397         (WebKitStyleTest.test_wtf_make_unique_array): Ditto.
2398
2399 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
2400
2401         Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
2402         https://bugs.webkit.org/show_bug.cgi?id=201820
2403
2404         Reviewed by Chris Fleizach.
2405
2406         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2407         (AccessibilityUIElement::insertText):
2408         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2409         (AccessibilityUIElement::insertText):
2410         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2411         (WTR::AccessibilityUIElement::insertText):
2412         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2413         (WTR::AccessibilityUIElement::insertText):
2414
2415 2019-09-16  David Kilzer  <ddkilzer@apple.com>
2416
2417         Fix leaks in DumpRenderTree and WebKitTestRunner
2418         <https://webkit.org/b/201814>
2419
2420         Reviewed by Darin Adler.
2421
2422         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2423         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
2424         Add CF_RETURNS_RETAINED to document behavior.
2425         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2426         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
2427
2428         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2429         (takeWindowSnapshot): Add CF_RETURNS_RETAINED to document
2430         behavior.
2431         (createBitmapContextFromWebView): Fix leak of CGImageRef when
2432         generating a replacement image.
2433
2434         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Add @dynamic
2435         declaration for _stableStateOverride so compiler wouldn't try to
2436         create another instance variable for it.
2437
2438         * WebKitTestRunner/mac/EventSenderProxy.mm:
2439         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2440         Release `cgEvent` to fix leak.
2441
2442 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
2443
2444         Expose misspelling ranges for editable content to accessibility clients.
2445         https://bugs.webkit.org/show_bug.cgi?id=201752
2446         <rdar://problem/49556828>
2447
2448         Reviewed by Chris Fleizach.
2449
2450         Test code needed for LayoutTests/accessibility/misspelling-range.html.
2451         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2452         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2453         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2454         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
2455         (WTR::AccessibilityUIElement::indexForTextMarker):
2456         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2457         (WTR::misspellingSearchParameterizedAttributeForCriteria):
2458         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
2459
2460 2019-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2461
2462         REGRESSION(r249142): [GTK] Epiphany delayed page loads continue indefinitely
2463         https://bugs.webkit.org/show_bug.cgi?id=201544
2464
2465         Reviewed by Michael Catanzaro.
2466
2467         Add new test cases.
2468
2469         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2470         (testWebViewActiveURI):
2471         (testWebViewIsLoading):
2472         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2473         (loadChangedCallback):
2474         (LoadTrackingTest::loadAlternateHTML):
2475         (LoadTrackingTest::reset):
2476         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h:
2477
2478 2019-09-15  David Kilzer  <ddkilzer@apple.com>
2479
2480         block-spammers should obtain credentials the same way as webkit-patch
2481         <https://webkit.org/b/201733>
2482
2483         Reviewed by Lucas Forschler.
2484
2485         * Scripts/block-spammers: Import Credentials from webkitpy.
2486         Remove unused imports.  Enable logging at info level to match
2487         webkit-patch.
2488         (get_bugzilla_token): Use Credentials module to get
2489         bugs.webkit.org credentials.
2490         * Scripts/webkitpy/common/net/credentials.py:
2491         (Credentials._run_security_tool): Change logging level from
2492         error to info since multiple attempts are made at reading the
2493         keychain.  Fix typos in comment.
2494         (Credentials._credentials_from_security_command): Extract common
2495         logic from Credentials._credentials_from_keychain into new
2496         method.
2497         (Credentials._credentials_from_keychain): Make fallback logic
2498         for checking for credentials in the keychain more consistent and
2499         easier to read.  Add error logging if no credentials are found.
2500
2501 2019-09-13  Youenn Fablet  <youenn@apple.com>
2502
2503         WPT importer should check META global tag in .any.js files to generate the valid .html stub files
2504         https://bugs.webkit.org/show_bug.cgi?id=201718
2505
2506         Reviewed by Chris Dumez.
2507
2508         Read meta tag information to select the environments where the any.js template tests will be run.
2509         Added support to run service worker tests from any.js template tests.
2510
2511         Covered by unit test.
2512         Since we import only a single repository nowadays, use a test config file with just one repository
2513         to simplify the new test.
2514
2515         * Scripts/webkitpy/w3c/test_importer.py:
2516         (TestImporter.__init__):
2517         (TestImporter.readEnvironmentsForTemplateTest):
2518         (TestImporter.write_html_files_for_templated_js_tests):
2519         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2520         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
2521         (TestImporterTest.test_import_dir_with_no_tests):
2522         (TestImporterTest.test_import_dir_with_empty_init_py):
2523         (TestImporterTest.test_harnesslinks_conversion):
2524         (TestImporterTest.test_submodules_generation):
2525         (test_checkout_directory):
2526         (test_clean_directory_option):
2527         (test_git_ignore_generation):
2528         (test_initpy_generation):
2529         (test_remove_obsolete_content):
2530         (test_manual_slow_test):
2531         (test_webkit_test_runner_options):
2532         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
2533         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
2534         (test_template_test):
2535
2536 2019-09-13  Dean Jackson  <dino@apple.com>
2537
2538         Provide a prototype for AR QuickLook to trigger processing in the originating page
2539         https://bugs.webkit.org/show_bug.cgi?id=201371
2540         <rdar://54904781>
2541
2542         Disable the test for the moment.
2543
2544         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
2545         (TestWebKitAPI::TEST):
2546
2547 2019-09-11  Dean Jackson  <dino@apple.com>
2548
2549         Provide a prototype for AR QuickLook to trigger processing in the originating page
2550         https://bugs.webkit.org/show_bug.cgi?id=201371
2551         <rdar://54904781>
2552
2553         Reviewed by Simon Fraser.
2554
2555         * TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
2556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2557         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.
2558
2559 2019-09-13  Youenn Fablet  <youenn@apple.com>
2560
2561         Partition processes running service workers by session ID
2562         https://bugs.webkit.org/show_bug.cgi?id=201643
2563
2564         Reviewed by Chris Dumez.
2565
2566         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2567
2568 2019-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
2569
2570         Re-add myself to the list of committers
2571
2572         Unreviewed.
2573
2574         * Scripts/webkitpy/common/config/contributors.json:
2575
2576 2019-09-13  Alex Christensen  <achristensen@webkit.org>
2577
2578         [iOS] TestWebKitAPI.WebKit.TLSVersionWebSocket is a flaky failure
2579         https://bugs.webkit.org/show_bug.cgi?id=201745
2580
2581         Reviewed by Chris Dumez.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2584         (TestWebKitAPI::TEST):
2585         The exact message isn't important.  The fact that the TLS handshake failed is, which is checked by the TCPServer.
2586
2587 2019-09-13  Patrick Griffis  <pgriffis@igalia.com>
2588
2589         [JHBuild] Fix building gst-plugins-good against glibc 2.30
2590         https://bugs.webkit.org/show_bug.cgi?id=201715
2591
2592         Reviewed by Xabier Rodriguez-Calvar.
2593
2594         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Added.
2595
2596 2019-09-12  Chris Dumez  <cdumez@apple.com>
2597
2598         [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
2599         https://bugs.webkit.org/show_bug.cgi?id=201546
2600
2601         Reviewed by Alex Christensen.
2602
2603         Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
2604         the right thing for WebKit2 and tests have been rewritten to not use it.
2605
2606         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2608         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.
2609         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2610
2611 2019-09-12  Brady Eidson  <beidson@apple.com>
2612
2613         PDF exporting on iOS should include URL rects.
2614         <rdar://problem/54900133> and https://bugs.webkit.org/show_bug.cgi?id=201693
2615
2616         Reviewed by Tim Horton.
2617
2618         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2619         (TestWebKitAPI::TEST): Enable on iOS.
2620
2621 2019-09-12  Adrian Perez de Castro  <aperez@igalia.com>
2622
2623         [GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
2624         https://bugs.webkit.org/show_bug.cgi?id=201077
2625
2626         Reviewed by Carlos Garcia Campos.
2627
2628         * TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
2629         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
2630         (TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().
2631
2632 2019-09-12  Mark Lam  <mark.lam@apple.com>
2633
2634         Harden JSC against the abuse of runtime options.
2635         https://bugs.webkit.org/show_bug.cgi?id=201597
2636         <rdar://problem/55167068>
2637
2638         Reviewed by Filip Pizlo.
2639
2640         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
2641         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
2642
2643         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
2644         to disable the hardening on test runs.  Tests rely on setting options to enable
2645         test features.
2646
2647         * DumpRenderTree/mac/DumpRenderTree.mm:
2648         (dumpRenderTree):
2649         * DumpRenderTree/win/DumpRenderTree.cpp:
2650         (initialize):
2651         * TestWebKitAPI/PlatformUtilities.cpp:
2652         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2653         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2654         (main):
2655         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
2656         (TestWebKitAPI::TEST):
2657         (TestWebKitAPI::runActiveSessionTest):
2658         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2659         (TEST):
2660         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2661         (TEST):
2662         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
2663         (TestWebKitAPI::TEST):
2664         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2665         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2666         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
2667         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
2668         * WebKitTestRunner/TestController.cpp:
2669         (WTR::TestController::generateContextConfiguration const):
2670
2671 2019-09-12  Keith Rollin  <krollin@apple.com>
2672
2673         Fix PDFKit references in TestWebKitAPI
2674         https://bugs.webkit.org/show_bug.cgi?id=201700
2675         <rdar://problem/55279539>
2676
2677         Reviewed by Youenn Fablet.
2678
2679         These references fail in watchOS and tvOS, so remove them on those
2680         platforms.
2681
2682         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2684         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2685         * TestWebKitAPI/cocoa/TestPDFDocument.h:
2686         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
2687         * TestWebKitAPI/config.h:
2688
2689 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2690
2691         [Win][MiniBrowser] Select all text in the URL bar by clicking it
2692         https://bugs.webkit.org/show_bug.cgi?id=201677
2693
2694         Reviewed by Don Olmstead.
2695
2696         * MiniBrowser/win/MainWindow.cpp:
2697         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
2698
2699 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2700
2701         [GTK][WPE] Stop using the session bus in the unit tests
2702         https://bugs.webkit.org/show_bug.cgi?id=201636
2703
2704         Reviewed by Žan Doberšek.
2705
2706         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
2707         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
2708         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
2709         test. The server address is passed to the web extension as initialization parameter to connect directly to
2710         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
2711         a WebKitWebView.
2712
2713         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2714         (beforeAll):
2715         (afterAll):
2716         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2717         (testProcessPerWebView):
2718         (beforeAll):
2719         (afterAll):
2720         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2721         (testWebExtensionGetTitle):
2722         (testWebExtensionInputElementIsUserEdited):
2723         (testDocumentLoadedSignal):
2724         (testWebKitWebViewProcessCrashed):
2725         (testWebExtensionIsolatedWorld):
2726         (testInstallMissingPluginsPermissionRequest):
2727         (testWebExtensionFormControlsAssociated):
2728         (FormSubmissionTest::FormSubmissionTest):
2729         (beforeAll):
2730         (afterAll):
2731         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2732         (DelayedSignal::DelayedSignal):
2733         (emitPageCreated):
2734         (pageCreatedCallback):
2735         (webkit_web_extension_initialize_with_user_data):
2736         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2737         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2738         (AccessibilityTest::AccessibilityTest):
2739         (AccessibilityTest::ensureProxy):
2740         (beforeAll):
2741         (afterAll):
2742         * TestWebKitAPI/glib/CMakeLists.txt:
2743         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2744         (dbusConnectionClosed):
2745         (dbusServerConnection):
2746         (startDBusServer):
2747         (stopDBusServer):
2748         (main):
2749         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2750         (Test::initializeWebExtensions):
2751         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
2752         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
2753         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2754         (WebViewTest::~WebViewTest):
2755         (WebViewTest::extensionProxy):
2756         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2757
2758 2019-09-10  Dean Jackson  <dino@apple.com>
2759
2760         setup-git-clone is using http not https
2761         https://bugs.webkit.org/show_bug.cgi?id=201658
2762
2763         Reviewed by Sam Weinig.
2764
2765         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2766         (SetupGitClone.execute):
2767
2768 2019-09-10  Matt Lewis  <jlewis3@apple.com>
2769
2770         run-webkit-test: Allow results to be uploaded without scm checkout
2771         https://bugs.webkit.org/show_bug.cgi?id=200787
2772
2773         Reviewed by Jonathan Bedard.
2774
2775         * Scripts/webkitpy/common/checkout/scm/detection.py:
2776         (SCMDetector.detect_scm_system): Added in detection of stub repository.
2777         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
2778         (StubRepository):
2779         (StubRepository.__init__):
2780         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
2781         find the directory containing the checkout_information.json of the stub repository.
2782         (StubRepository.in_working_directory): Required functions to be implemented.
2783         (StubRepository.svn_revision): Required functions to be implemented.
2784         (StubRepository.native_revision): Required functions to be implemented.
2785         (StubRepository.native_branch): Required functions to be implemented.
2786         (StubRepository._decode_json): Decodes checkout_information.json.
2787         (StubRepository.find_checkout_root): Required functions to be implemented.
2788         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
2789         (StubRepositoryTest): Unit test for stub_repository SCM.
2790         (StubRepositoryTest.mock_host_for_stub_repository):
2791         (StubRepositoryTest.test_in_working_directory):
2792         (StubRepositoryTest.test_native_revision):
2793         (StubRepositoryTest.test_native_branch):
2794         (StubRepositoryTest.test_svn_revision):
2795         (StubRepositoryTest.test_find_checkout_root):
2796         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2797         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
2798         * Scripts/webkitpy/port/base.py:
2799         (Port.commits_for_upload): Removed unnecessary scm initialization.
2800
2801 2019-09-10  Brady Eidson  <beidson@apple.com>
2802
2803         Add SPI to save a PDF from the contents of a WKWebView.
2804         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
2805
2806         Reviewed by Tim Horton.
2807
2808         -Add an "Export to PDF..." menu option to MiniBrowser.
2809         -Add API tests for the API itself.
2810
2811         * MiniBrowser/MiniBrowser.entitlements:
2812
2813         * MiniBrowser/mac/BrowserWindowController.h:
2814         * MiniBrowser/mac/BrowserWindowController.m:
2815         (-[BrowserWindowController forceRepaint:]):
2816         (-[BrowserWindowController saveAsPDF:]):
2817
2818         * MiniBrowser/mac/MainMenu.xib:
2819
2820         * MiniBrowser/mac/WK1BrowserWindowController.m:
2821         (-[WK1BrowserWindowController validateMenuItem:]):
2822         * MiniBrowser/mac/WK2BrowserWindowController.m:
2823         (-[WK2BrowserWindowController validateMenuItem:]):
2824         (-[WK2BrowserWindowController saveAsPDF:]):
2825
2826         * TestWebKitAPI/Configurations/Base.xcconfig:
2827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2828         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
2829         (TestWebKitAPI::TEST):
2830         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
2831         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
2832         (TestWebKitAPI::toCGRect):
2833         (TestWebKitAPI::toPlatformPoint):
2834         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
2835         (TestWebKitAPI::TestPDFAnnotation::isLink const):
2836         (TestWebKitAPI::TestPDFAnnotation::bounds const):
2837         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
2838         (TestWebKitAPI::TestPDFPage::create):
2839         (TestWebKitAPI::TestPDFPage::TestPDFPage):
2840         (TestWebKitAPI::TestPDFPage::annotations):
2841         (TestWebKitAPI::TestPDFPage::characterCount const):
2842         (TestWebKitAPI::TestPDFPage::text const):
2843         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
2844         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
2845         (TestWebKitAPI::TestPDFPage::bounds const):
2846         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
2847         (TestWebKitAPI::TestPDFDocument::createFromData):
2848         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
2849         (TestWebKitAPI::TestPDFDocument::pageCount const):
2850         (TestWebKitAPI::TestPDFDocument::page):
2851
2852 2019-09-10  Keith Rollin  <krollin@apple.com>
2853
2854         Remove SSL-based TLSDeprecation.mm contents
2855         https://bugs.webkit.org/show_bug.cgi?id=201657
2856         <rdar://problem/55237678>
2857
2858         Reviewed by Alex Christensen.
2859
2860         This file does not build on watchOS due to references to SSL
2861         facilities. Conditionalize out the contents on HAVE_SSL.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2864
2865 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2866
2867         Unreviewed, remove myself from watchlists
2868
2869         * Scripts/webkitpy/common/config/watchlist:
2870
2871 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2872
2873         Rebase API test after r249675
2874         https://bugs.webkit.org/show_bug.cgi?id=201596
2875
2876         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2877         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2878         We removed the restriction on WebsitePolicies with non-default persistent sessions.
2879         We needed to change the expectations of the test that exercised that code path.
2880
2881 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2882
2883         Fix iOS API tests after r249684
2884         https://bugs.webkit.org/show_bug.cgi?id=201573
2885
2886         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2887         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
2888         (TestWebKitAPI::TEST):
2889         The web thread still exists :(
2890         That makes iOS immediate failure results more like WK2, which is fine.
2891         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
2892
2893 2019-09-09  Chris Dumez  <cdumez@apple.com>
2894
2895         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
2896         https://bugs.webkit.org/show_bug.cgi?id=201550
2897
2898         Reviewed by Alex Christensen.
2899
2900         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
2901         anything or not.
2902
2903         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2904         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2905         (WTR::InjectedBundle::statisticsNotifyObserver):
2906         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2908         (WTR::TestRunner::statisticsNotifyObserver):
2909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2910
2911 2019-09-09  Timothy Hatcher  <timothy@apple.com>
2912
2913         Tap and hold on Facebook sometimes creates a tall empty selection.
2914         https://bugs.webkit.org/show_bug.cgi?id=201618
2915         rdar://53630145
2916
2917         Reviewed by Megan Gardner.
2918
2919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2920         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
2921
2922 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [EWS] Watchlist doesn't work sometimes
2925         https://bugs.webkit.org/show_bug.cgi?id=201433
2926
2927         Reviewed by Michael Catanzaro.
2928
2929         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
2930         corresponding Bugzilla accounts.
2931
2932 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2933
2934         Disable TLS 1.0 and 1.1 in WebSockets
2935         https://bugs.webkit.org/show_bug.cgi?id=201573
2936
2937         Reviewed by Youenn Fablet.
2938
2939         * TestWebKitAPI/SourcesCocoa.txt:
2940         * TestWebKitAPI/TCPServer.cpp:
2941         (sk_CRYPTO_BUFFER_num):
2942         (sk_CRYPTO_BUFFER_value):
2943         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
2944         (TestWebKitAPI::TCPServer::TCPServer):
2945         (TestWebKitAPI::TCPServer::listenForConnections):
2946         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
2947         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
2948         * TestWebKitAPI/TCPServer.h:
2949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2950         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
2951         (-[WebSocketDelegate waitForMessage]):
2952         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2953         (TestWebKitAPI::TEST):
2954         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2955         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2956         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2957         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
2958
2959 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2960
2961         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
2962         https://bugs.webkit.org/show_bug.cgi?id=201600
2963
2964         Reviewed by Brent Fulgham.
2965
2966         There were some circular references between
2967         WebKitLegacyBrowserWindow and its delegation classes. For
2968         example, WebKitLegacyBrowserWindow has a reference of
2969         WebDownloadDelegate, and WebDownloadDelegate shares the ref
2970         counter with WebKitLegacyBrowserWindow.
2971
2972         WebNotificationObserver was leaked because it wasn't unregistered
2973         from the default notification center by using
2974         IWebNotificationCenter::removeObserver.
2975
2976         If a new legacy window was created by mouse right click a link,
2977         WebView was released twice because
2978         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
2979         WebView.
2980
2981         This change does:
2982         1. Make delegation classes have own ref-counter to avoid circular references
2983         2. Do removeObserver notification observers
2984         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
2985
2986         * MiniBrowser/win/AccessibilityDelegate.cpp:
2987         (AccessibilityDelegate::AddRef):
2988         (AccessibilityDelegate::Release):
2989         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
2990         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2991         (MiniBrowserWebHost::QueryInterface):
2992         (MiniBrowserWebHost::AddRef):
2993         (MiniBrowserWebHost::Release):
2994         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
2995         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2996         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
2997         (PrintWebUIDelegate::AddRef):
2998         (PrintWebUIDelegate::Release):
2999         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
3000         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3001         (ResourceLoadDelegate::AddRef):
3002         (ResourceLoadDelegate::Release):
3003         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
3004         * MiniBrowser/win/WebDownloadDelegate.cpp:
3005         (WebDownloadDelegate::AddRef):
3006         (WebDownloadDelegate::Release):
3007         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
3008         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3009         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
3010         (WebKitLegacyBrowserWindow::init):
3011         (WebKitLegacyBrowserWindow::setUIDelegate):
3012         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
3013         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
3014         (WebKitLegacyBrowserWindow::setDownloadDelegate):
3015         (WebKitLegacyBrowserWindow::AddRef): Deleted.
3016         (WebKitLegacyBrowserWindow::Release): Deleted.
3017         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
3018         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
3019         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3020
3021 2019-09-09  Chris Dumez  <cdumez@apple.com>
3022
3023         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
3024         https://bugs.webkit.org/show_bug.cgi?id=201596
3025
3026         Reviewed by Alex Christensen.
3027
3028         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
3029         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
3030         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
3031         the WebCore::Document think it changed session.
3032
3033         * DumpRenderTree/TestRunner.cpp:
3034         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
3035         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
3036         (TestRunner::staticFunctions):
3037         (TestRunner::willNavigate):
3038         * DumpRenderTree/TestRunner.h:
3039         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
3040         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
3041         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3042         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3043         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3044         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3045         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
3046         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
3047         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3048         * WebKitTestRunner/TestController.cpp:
3049         (WTR::TestController::decidePolicyForNavigationAction):
3050         * WebKitTestRunner/TestController.h:
3051         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
3052         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
3053         * WebKitTestRunner/TestInvocation.cpp:
3054         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3055
3056 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
3057
3058         EWS testtube emoji doesn't exist on macOS Mojave
3059         https://bugs.webkit.org/show_bug.cgi?id=201532
3060
3061         Reviewed by Simon Fraser.
3062
3063         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3064         (StatusBubble): Change the emoji to microscope emoji.
3065
3066 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
3067
3068         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
3069         https://bugs.webkit.org/show_bug.cgi?id=201607
3070
3071         Reviewed by Jonathan Bedard.
3072
3073         * BuildSlaveSupport/ews-build/steps.py:
3074         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
3075         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
3076
3077 2019-09-07  Keith Miller  <keith_miller@apple.com>
3078
3079         OSR entry into wasm misses some contexts
3080         https://bugs.webkit.org/show_bug.cgi?id=201569
3081
3082         Reviewed by Yusuke Suzuki.
3083
3084         Add new test harness mode for tests created from wast files.
3085
3086         * Scripts/run-jsc-stress-tests:
3087
3088 2019-09-09  Daniel Bates  <dabates@apple.com>
3089
3090         Remove all selection view animations before dumping results
3091         https://bugs.webkit.org/show_bug.cgi?id=199241
3092
3093         Reviewed by Wenson Hsieh.
3094
3095         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
3096         historical tests that were written for Mac and expect Mac's lack of animations that we run on
3097         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
3098         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
3099         API for a test to remove selection animations at any time during the run.
3100
3101         * WebKitTestRunner/ios/TestControllerIOS.mm:
3102         (WTR::TestController::notifyDone):
3103
3104 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
3105
3106         run-webkit-tests: Report results archive to results.webkit.org
3107         https://bugs.webkit.org/show_bug.cgi?id=201321
3108
3109         Reviewed by Aakash Jain.
3110
3111         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3112         (Manager.run): After all tests are finish, upload the results archive for each
3113         configuration.
3114         * Scripts/webkitpy/results/upload.py:
3115         (Upload):
3116         (Upload.__init__): Automatically define timestamp.
3117         (Upload.upload_archive): Upload an archive associated with the test run.
3118         * Scripts/webkitpy/results/upload_unittest.py:
3119         (UploadTest.test_buildbot):
3120         (UploadTest):
3121         (UploadTest.test_archive_upload):
3122
3123 2019-09-09  Chris Dumez  <cdumez@apple.com>
3124
3125         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
3126         https://bugs.webkit.org/show_bug.cgi?id=201590
3127
3128         Reviewed by Youenn Fablet.
3129
3130         Add a new API test to check that if the default session registers a service worker, the
3131         hasServiceWorkerRegistration flag is still false in an ephemeral session.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3134
3135 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
3136
3137         results.webkit.org: mobile-sidebar-control should override button
3138         https://bugs.webkit.org/show_bug.cgi?id=201566
3139
3140         Rubber-stamped by Aakash Jain.
3141
3142         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3143         (@media screen and (min-width: 600px)):
3144         (.mobile-sidebar-control):
3145         (.mobile-sidebar-control.display):
3146
3147 2019-09-07  Chris Dumez  <cdumez@apple.com>
3148
3149         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
3150         https://bugs.webkit.org/show_bug.cgi?id=201574
3151
3152         Reviewed by Alex Christensen.
3153
3154         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
3155         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
3156         does not work well for WK2.
3157
3158         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3159
3160 2019-09-07  Chris Dumez  <cdumez@apple.com>
3161
3162         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
3163         https://bugs.webkit.org/show_bug.cgi?id=201547
3164
3165         Reviewed by Alex Christensen.
3166
3167         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
3168         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
3169         hack.
3170
3171         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3172         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3173         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
3174         (TEST):
3175
3176 2019-09-07  Alex Christensen  <achristensen@webkit.org>
3177
3178         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
3179         https://bugs.webkit.org/show_bug.cgi?id=200054
3180
3181         Reviewed by Carlos Garcia Campos.
3182
3183         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3184         This test relied on the default data store having been instantiated.
3185
3186 2019-09-07  Alex Christensen  <achristensen@webkit.org>
3187
3188         Remove calls to WKContextGetWebsiteDataStore missed in r249614
3189         https://bugs.webkit.org/show_bug.cgi?id=200050
3190
3191         * WebKitTestRunner/TestController.cpp:
3192         (WTR::TestController::resetPreferencesToConsistentValues):
3193         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3194         * WebKitTestRunner/TestInvocation.cpp:
3195         (WTR::TestInvocation::invoke):
3196
3197 2019-09-07  Alex Christensen  <achristensen@webkit.org>
3198
3199         Remove invalid assertion added in r249614
3200         https://bugs.webkit.org/show_bug.cgi?id=200050
3201
3202         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3203         (WTR::TestController::cocoaResetStateToConsistentValues):
3204         Something is instantiating the default data store, which is no problem right now.
3205
3206 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
3207
3208         Unreviewed, rolling out r249353.
3209
3210         The test for this change is a flaky failure.
3211
3212         Reverted changeset:
3213
3214         "Add support for postMessage buffering between the service
3215         worker and window"
3216         https://bugs.webkit.org/show_bug.cgi?id=201169
3217         https://trac.webkit.org/changeset/249353
3218
3219 2019-09-07  Alex Christensen  <achristensen@webkit.org>
3220
3221         Deprecate WKContextGetWebsiteDataStore
3222         https://bugs.webkit.org/show_bug.cgi?id=200050
3223
3224         Reviewed by Geoff Garen.
3225
3226         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3227         (WebKitBrowserWindow::updateProxySettings):
3228         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3229         * WebKitTestRunner/TestController.cpp:
3230         (WTR::TestController::generateContextConfiguration const):
3231         (WTR::TestController::websiteDataStore):
3232         (WTR::TestController::generatePageConfiguration):
3233         (WTR::TestController::resetStateToConsistentValues):
3234         (WTR::TestController::platformAdjustContext):
3235         (WTR::TestController::clearServiceWorkerRegistrations):
3236         (WTR::TestController::clearDOMCache):
3237         (WTR::TestController::clearDOMCaches):
3238         (WTR::TestController::ClearIndexedDatabases):
3239         (WTR::TestController::hasDOMCache):
3240         (WTR::TestController::domCacheSize):
3241         (WTR::TestController::setStatisticsDebugMode):
3242         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
3243         (WTR::TestController::setStatisticsLastSeen):
3244         (WTR::TestController::setStatisticsPrevalentResource):
3245         (WTR::TestController::setStatisticsVeryPrevalentResource):
3246         (WTR::TestController::dumpResourceLoadStatistics):
3247         (WTR::TestController::isStatisticsPrevalentResource):
3248         (WTR::TestController::isStatisticsVeryPrevalentResource):
3249         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
3250         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3251         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3252         (WTR::TestController::setStatisticsHasHadUserInteraction):
3253         (WTR::TestController::isStatisticsHasHadUserInteraction):
3254         (WTR::TestController::setStatisticsGrandfathered):
3255         (WTR::TestController::isStatisticsGrandfathered):
3256         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
3257         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
3258         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
3259         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
3260         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
3261         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
3262         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3263         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3264         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3265         (WTR::TestController::statisticsUpdateCookieBlocking):
3266         (WTR::TestController::statisticsSubmitTelemetry):
3267         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3268         (WTR::TestController::setStatisticsIsRunningTest):
3269         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3270         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3271         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3272         (WTR::TestController::setStatisticsGrandfatheringTime):
3273         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3274         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3275         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3276         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3277         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
3278         (WTR::TestController::statisticsDeleteCookiesForHost):
3279         (WTR::TestController::isStatisticsHasLocalStorage):
3280         (WTR::TestController::setStatisticsCacheMaxAgeCap):
3281         (WTR::TestController::statisticsResetToConsistentState):
3282         (WTR::TestController::setWebAuthenticationMockConfiguration):
3283         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3284         * WebKitTestRunner/TestController.h:
3285         * WebKitTestRunner/TestInvocation.cpp:
3286         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3287         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3288         (WTR::initializeWebViewConfiguration):
3289
3290 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3291
3292         Incorrect selection rect revealed after pasting images in a contenteditable element
3293         https://bugs.webkit.org/show_bug.cgi?id=201549
3294         <rdar://problem/50956429>
3295
3296         Reviewed by Simon Fraser.
3297
3298         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
3299         directly written to the pasteboard.
3300
3301         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3302
3303 2019-09-06  Matt Lewis  <jlewis3@apple.com>
3304
3305         Unreviewed, rolling out r249582.
3306
3307         This caused results.html fail to be created on internal
3308         testers.
3309
3310         Reverted changeset:
3311
3312         "run-webkit-test: Allow results to be uploaded without scm
3313         checkout"
3314         https://bugs.webkit.org/show_bug.cgi?id=200787
3315         https://trac.webkit.org/changeset/249582
3316
3317 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-app] Status bubble should only display important messages in pop-over - part 2
3320         https://bugs.webkit.org/show_bug.cgi?id=201557
3321
3322         Reviewed by Jonathan Bedard.
3323
3324         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3325         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
3326
3327 2019-09-06  Alex Christensen  <achristensen@webkit.org>
3328
3329         Deprecate all WKCookieManagerRef functions
3330         https://bugs.webkit.org/show_bug.cgi?id=201473
3331
3332         Reviewed by Chris Dumez.
3333
3334         Adopt replacement C API in WebKitTestRunner.
3335
3336         * TestWebKitAPI/CMakeLists.txt:
3337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3338         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
3339         * WebKitTestRunner/TestController.cpp:
3340         (WTR::TestController::resetPreferencesToConsistentValues):
3341         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3342         * WebKitTestRunner/TestInvocation.cpp:
3343         (WTR::TestInvocation::invoke):
3344         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3345         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3346         (WTR::initializeWebViewConfiguration):
3347
3348 2019-09-06  Tim Horton  <timothy_horton@apple.com>
3349
3350         Marking up a note on iOS results in a PDF with no contents
3351         https://bugs.webkit.org/show_bug.cgi?id=201530
3352         <rdar://problem/53686019>
3353
3354         Reviewed by Andy Estes.
3355
3356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3357         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
3358         Add some tests for WKWebViewPrintFormatter; specifically that it is
3359         possible to _recalcPageCount twice in quick succession, and that
3360         we don't hang if we start painting the printed content immediately
3361         after a Web Content process crash.
3362
3363 2019-09-06  Matt Lewis  <jlewis3@apple.com>
3364
3365         run-webkit-test: Allow results to be uploaded without scm checkout
3366         https://bugs.webkit.org/show_bug.cgi?id=200787
3367
3368         Reviewed by Jonathan Bedard.
3369
3370         * Scripts/webkitpy/common/checkout/scm/detection.py:
3371         (SCMDetector.detect_scm_system): Added in detection of stub repository.
3372         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
3373         (StubRepository):
3374         (StubRepository.__init__):
3375         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
3376         find the directory containing the checkout_information.json of the stub repository.
3377         (StubRepository.in_working_directory): Required functions to be implemented.
3378         (StubRepository.svn_revision): Required functions to be implemented.
3379         (StubRepository.native_revision): Required functions to be implemented.
3380         (StubRepository.native_branch): Required functions to be implemented.
3381         (StubRepository._decode_json): Decodes checkout_information.json.
3382         (StubRepository.find_checkout_root): Required functions to be implemented.
3383         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
3384         (StubRepositoryTest): Unit test for stub_repository SCM.
3385         (StubRepositoryTest.mock_host_for_stub_repository):
3386         (StubRepositoryTest.test_in_working_directory):
3387         (StubRepositoryTest.test_native_revision):
3388         (StubRepositoryTest.test_native_branch):
3389         (StubRepositoryTest.test_svn_revision):
3390         (StubRepositoryTest.test_find_checkout_root):
3391         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3392         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
3393         * Scripts/webkitpy/port/base.py:
3394         (Port.commits_for_upload): Removed unnecessary scm initialization.
3395
3396 2019-09-06  Alex Christensen  <achristensen@webkit.org>
3397
3398         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
3399         https://bugs.webkit.org/show_bug.cgi?id=201480
3400
3401         Reviewed by Youenn Fablet.
3402
3403         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3404         (WTR::InjectedBundle::beginTesting):
3405         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3406         (WTR::TestRunner::setPrivateBrowsingEnabled):
3407
3408 2019-09-06  Rob Buis  <rbuis@igalia.com>
3409
3410         Add runtime flag for lazy image loading
3411         https://bugs.webkit.org/show_bug.cgi?id=199794
3412
3413         Reviewed by Frédéric Wang.
3414
3415         Remove parts of r248409 that were meant for WK1 since
3416         lazy image loading is WK2 only.
3417
3418         * DumpRenderTree/TestOptions.cpp:
3419         (TestOptions::TestOptions):
3420         * DumpRenderTree/TestOptions.h:
3421         * DumpRenderTree/mac/DumpRenderTree.mm:
3422         (enableExperimentalFeatures):
3423         (setWebPreferencesForTestOptions):
3424         * DumpRenderTree/win/DumpRenderTree.cpp:
3425         (enableExperimentalFeatures):
3426
3427 2019-09-05  Chris Dumez  <cdumez@apple.com>
3428
3429         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
3430         https://bugs.webkit.org/show_bug.cgi?id=201519
3431
3432         Reviewed by Alex Christensen.
3433
3434         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
3435         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
3436         TestOption::useEphemeralSession flag based on the test folder.
3437
3438         * DumpRenderTree/mac/DumpRenderTree.mm:
3439         (shouldUseEphemeralSession):
3440         (runTest):
3441         * WebKitTestRunner/TestOptions.cpp:
3442         (WTR::shouldUseEphemeralSession):
3443         (WTR::TestOptions::TestOptions):
3444
3445 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
3446
3447         [Win] Support Per-Monitor (V2) DPI Awareness
3448         https://bugs.webkit.org/show_bug.cgi?id=201450
3449
3450         Reviewed by Don Olmstead.
3451
3452         * MiniBrowser/win/MainWindow.cpp:
3453         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
3454         * MiniBrowser/win/WinMain.cpp:
3455         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
3456
3457 2019-09-05  Chris Dumez  <cdumez@apple.com>
3458
3459         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
3460         https://bugs.webkit.org/show_bug.cgi?id=201440
3461         <rdar://problem/54998427>
3462
3463         Reviewed by Alex Christensen.
3464
3465         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
3466         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
3467         created in the WebContent process is the one that is currently running the test and that we want to talk to.
3468         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
3469
3470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3471         (WTR::InjectedBundle::page const):
3472
3473 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
3474
3475         results.webkit.org: Assign notifyRerender before calling
3476         https://bugs.webkit.org/show_bug.cgi?id=201510
3477
3478         Reviewed by Aakash Jain.
3479
3480         Timelines should define notifyRerender to an empty function,
3481         rename notifiyRerender to notifyRerender.
3482
3483         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3484         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3485         * resultsdbpy/resultsdbpy/view/templates/search.html:
3486         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3487
3488 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
3489
3490         results.webkit.org: Fix prepending search result on empty list 
3491         https://bugs.webkit.org/show_bug.cgi?id=201512
3492
3493         Reviewed by Aakash Jain.
3494
3495         * resultsdbpy/resultsdbpy/view/templates/search.html:
3496
3497 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
3498
3499         results.webkit.org: Retain certain parameters when following menu links
3500         https://bugs.webkit.org/show_bug.cgi?id=201463
3501
3502         Rubber-stamped by Aakash Jain.
3503
3504         * resultsdbpy/resultsdbpy/view/site_menu.py:
3505         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
3506         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
3507         retain the specified parameters
3508         * resultsdbpy/resultsdbpy/view/view_routes.py:
3509         (ViewRoutes.__init__):
3510
3511 2019-09-05  Chris Dumez  <cdumez@apple.com>
3512
3513         [WK2] Add proper layout test support for ephemeral sessions
3514         https://bugs.webkit.org/show_bug.cgi?id=201475
3515
3516         Reviewed by Antti Koivisto.
3517
3518         Add proper layout test support for ephemeral sessions via:
3519         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
3520
3521         This actually creates a new WebView using an ephemeral data store to load the test which
3522         is *true* private browsing.
3523
3524         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
3525         process, which is a hack and does not truly enable private browsing because the UIProcess and
3526         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
3527         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
3528         get rid of it.
3529
3530         Note that WK2 does not support using a WebContent process for different sessions / data stores.
3531         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
3532         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
3533         simply to support testRunner.setPrivateBrowsingEnabled().
3534
3535         * DumpRenderTree/TestOptions.cpp:
3536         (TestOptions::TestOptions):
3537         * DumpRenderTree/TestOptions.h:
3538         * DumpRenderTree/TestRunner.cpp:
3539         (TestRunner::staticFunctions):
3540         * DumpRenderTree/mac/DumpRenderTree.mm:
3541         (setWebPreferencesForTestOptions):
3542         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3544         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
3545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3546         * WebKitTestRunner/TestController.cpp:
3547         (WTR::TestController::generatePageConfiguration):
3548         (WTR::updateTestOptionsFromTestHeader):
3549         * WebKitTestRunner/TestOptions.h:
3550         (WTR::TestOptions::hasSameInitializationOptions const):
3551         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3552         (WTR::TestController::platformCreateWebView):
3553
3554 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
3555
3556         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
3557         https://bugs.webkit.org/show_bug.cgi?id=201490
3558
3559         Reviewed by Daniel Bates.
3560
3561         Added a test.
3562
3563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3564         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3565         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
3566
3567 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
3568
3569         Remove unused SPI that accesses MemoryCache directly
3570         https://bugs.webkit.org/show_bug.cgi?id=201468
3571
3572         Reviewed by Youenn Fablet.
3573
3574         Removed the API test.
3575
3576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3577         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
3578
3579 2019-09-04  Timothy Hatcher  <timothy@apple.com>
3580
3581         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
3582         https://bugs.webkit.org/show_bug.cgi?id=201368
3583         rdar://problem/40529867
3584
3585         Reviewed by Ryosuke Niwa.
3586
3587         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
3588             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
3589
3590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3591         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3592         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
3593         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
3594         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
3595         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
3596         * TestWebKitAPI/cocoa/TestWKWebView.h: