b3a9b64b03fd256b87dee274ad5d98a9f6b086f8
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-22  Zan Dobersek  <zdobersek@igalia.com>
2
3         [GTK] Set up libPlatform.la
4         https://bugs.webkit.org/show_bug.cgi?id=114168
5
6         Reviewed by Martin Robinson.
7
8         * GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
9
10 2013-04-22  Xuefei Ren  <xren@blackberry.com>
11
12         fix build warning(unused parameter)
13         https://bugs.webkit.org/show_bug.cgi?id=114855
14
15         Reviewed by Rob Buis.
16
17         remove warning(unused parameter) in
18         Tools/DumpRenderTree/blackberry/EventSender.cpp
19
20         * DumpRenderTree/blackberry/EventSender.cpp:
21         (getDragModeCallback):
22
23 2013-04-22  Alberto Garcia  <agarcia@igalia.com>
24
25         [BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
26         https://bugs.webkit.org/show_bug.cgi?id=114939
27
28         Reviewed by Carlos Garcia Campos.
29
30         This was added in r129308.
31
32         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
33         (AccessibilityController::accessibleElementById):
34
35 2013-04-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
36
37         Unreviewed EFL build fix after r148855.
38
39         * TestWebKitAPI/PlatformEfl.cmake:
40
41 2013-04-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
42
43         [EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
44         https://bugs.webkit.org/show_bug.cgi?id=114922
45
46         Reviewed by Gyuyoung Kim.
47
48         Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.
49
50         * TestWebKitAPI/PlatformEfl.cmake:
51
52 2013-04-20  Zan Dobersek  <zdobersek@igalia.com>
53
54         [GTK] Fix baseline positioning issue by updating Freetype
55         https://bugs.webkit.org/show_bug.cgi?id=106775
56
57         Reviewed by Martin Robinson.
58
59         * gtk/jhbuild.modules: Bump the Freetype Jhbuild dependency to 2.4.11.
60         * gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added. This is the Freetype
61         patch (committed as e0469372) that fixes rounding issues for smaller fonts. It is bound to be included
62         in the 2.4.12 release of Freetype (not released yet) but is provided here as its effect on baselines is
63         considered positive and will reduce the amout of future rebaselining.
64
65 2013-04-20  Manuel Rego Casasnovas  <rego@igalia.com>
66
67         [GTK] Fix unit test webkit2/WebKitFindController/hide
68         https://bugs.webkit.org/show_bug.cgi?id=89810
69
70         Reviewed by Carlos Garcia Campos.
71
72         * Scripts/run-gtk-tests:
73         (TestRunner): Unskip test webkit2/WebKitFindController/hide.
74
75 2013-04-19  Ryosuke Niwa  <rniwa@webkit.org>
76
77         Build fixes for the flakiness dashboard.
78
79         * TestResultServer/static-dashboards/flakiness_dashboard.js:
80
81 2013-04-17  Gustavo Noronha Silva  <gns@gnome.org>
82
83         [GTK] Make the 32 bits bot only build and run API tests
84         https://bugs.webkit.org/show_bug.cgi?id=113532
85
86         Reviewed by Martin Robinson.
87
88         * BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
89         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
90         (BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
91         moment;
92         (BuildAndAPITestFactory.__init__): add API tests step for platforms that have it.
93
94 2013-04-19  Andras Becsi  <andras.becsi@digia.com>
95
96         [Qt] Only use thin archives on Linux
97
98         Rubber-stamped by Jocelyn Turcotte.
99
100         Since "thin archive" is a feature of GNU's ar
101         we limit the usage to Linux to avoid problems
102         with other configurations (eg. macx-g++).
103
104         * qmake/mkspecs/features/default_pre.prf:
105
106 2013-04-19  Krzysztof Czech  <k.czech@samsung.com>
107
108         [GTK][WK2] accessibility/language-attribute.html is failing
109         https://bugs.webkit.org/show_bug.cgi?id=106342
110
111         Reviewed by Gyuyoung Kim.
112
113         Adds support for getting language information.
114
115         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
116         (WTR::AccessibilityUIElement::language):
117
118 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
119
120         [Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
121         https://bugs.webkit.org/show_bug.cgi?id=114805
122
123         Reviewed by Benjamin Poulain.
124
125         Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
126         builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
127         The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
128
129         * TestResultServer/static-dashboards/builders.js:
130         (BuilderGroup):
131         (loadBuildersList):
132         * TestResultServer/static-dashboards/dashboard_base.js:
133         (isTipOfTreeWebKitBuilder):
134         (expectationsMap):
135         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
136         (test):
137
138 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
139
140         [Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
141         https://bugs.webkit.org/show_bug.cgi?id=114804
142
143         Reviewed by Benjamin Poulain.
144
145         The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
146         just so the unit tests properly functions.
147
148         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
149
150 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
151
152         [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
153         https://bugs.webkit.org/show_bug.cgi?id=114803
154
155         Reviewed by Benjamin Poulain.
156
157         Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
158         test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
159         methods' correct behavior.
160
161         * TestResultServer/static-dashboards/builders.js:
162         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
163
164 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
165
166         [Dashboard] Remove the Chromium-specific builder masters
167         https://bugs.webkit.org/show_bug.cgi?id=114802
168
169         Reviewed by Benjamin Poulain.
170
171         Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
172
173         * TestResultServer/static-dashboards/builders.js:
174
175 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
176
177         [Dashboard] Remove all the Chromium-specific builder groups
178         https://bugs.webkit.org/show_bug.cgi?id=114801
179
180         Reviewed by Benjamin Poulain.
181
182         Remove all the Chromium-specific builder groups, all of these are not supported anymore.
183
184         * TestResultServer/static-dashboards/builders.js:
185
186 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
187
188         [Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
189         https://bugs.webkit.org/show_bug.cgi?id=114799
190
191         Reviewed by Benjamin Poulain.
192
193         The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
194         bound to be removed.
195
196         * TestResultServer/static-dashboards/history.js:
197         (.):
198
199 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
200
201         [Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
202         https://bugs.webkit.org/show_bug.cgi?id=114797
203
204         Reviewed by Benjamin Poulain.
205
206         Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
207         for anything other that the layout-tests type and removing support for loading builder data from builders connected
208         to the Chromium-specific builder groups which are no longer supported.
209
210         * TestResultServer/static-dashboards/builders.js:
211
212 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
213
214         [Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
215         https://bugs.webkit.org/show_bug.cgi?id=114796
216
217         Reviewed by Benjamin Poulain.
218
219         With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
220         WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
221         group category.
222
223         * TestResultServer/static-dashboards/dashboard_base.js:
224         (currentBuilderGroupCategory):
225
226 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
227
228         [Dashboard] Narrow down the test types list to only layout-tests
229         https://bugs.webkit.org/show_bug.cgi?id=114795
230
231         Reviewed by Ryosuke Niwa.
232
233         Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
234         test types were specific to the Chromium builders.
235
236         * TestResultServer/static-dashboards/dashboard_base.js:
237
238 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
239
240         [Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
241         https://bugs.webkit.org/show_bug.cgi?id=114760
242
243         Reviewed by Benjamin Poulain.
244
245         With the Chromium builders no longer present there's no need to display the Chromium revision range under the
246         aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
247         WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
248         htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
249
250         * TestResultServer/static-dashboards/aggregate_results.js:
251         (htmlForSummaryTable):
252         (htmlForTestType):
253
254 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
255
256         [Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
257         https://bugs.webkit.org/show_bug.cgi?id=114759
258
259         Reviewed by Benjamin Poulain.
260
261         Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
262         This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
263         and the revision label to 'WebKit Revision'.
264
265         * TestResultServer/static-dashboards/aggregate_results.js:
266         (chartHTML):
267
268 2013-04-18  Xuefei Ren  <xren@blackberry.com>
269
270         remove build warning(unused parameter)
271         https://bugs.webkit.org/show_bug.cgi?id=114670
272
273         Reviewed by Rob Buis.
274
275         remove builde warning (unused parameter) in
276         Tools/DumpRenderTree/blackberry
277
278         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
279         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
280         (AccessibilityUIElement::scrollToGlobalPoint):
281         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
282         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
283         (BlackBerry::WebKit::DumpRenderTree::didReceiveResponseForFrame):
284         * DumpRenderTree/blackberry/EventSender.cpp:
285         (getDragModeCallback):
286         (setDragModeCallback):
287         (mouseWheelToCallback):
288         (contextClickCallback):
289         (mouseDownCallback):
290         (mouseUpCallback):
291         (mouseMoveToCallback):
292         (beginDragWithFilesCallback):
293         (leapForwardCallback):
294         (keyDownCallback):
295         (textZoomInCallback):
296         (textZoomOutCallback):
297         (zoomPageInCallback):
298         (zoomPageOutCallback):
299         (addTouchPointCallback):
300         (updateTouchPointCallback):
301         (setTouchModifierCallback):
302         (touchStartCallback):
303         (touchCancelCallback):
304         (touchMoveCallback):
305         (touchEndCallback):
306         (clearTouchPointsCallback):
307         (cancelTouchPointCallback):
308         (releaseTouchPointCallback):
309         (scalePageByCallback):
310         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
311         (TestRunner::authenticateSession):
312         (TestRunner::setSpatialNavigationEnabled):
313         (TestRunner::apiTestNewWindowDataLoadBaseURL):
314         (TestRunner::setPluginsEnabled):
315         (TestRunner::setApplicationCacheOriginQuota):
316         (TestRunner::addMockSpeechInputResult):
317         (TestRunner::setViewModeMediaFeature):
318         (TestRunner::deleteLocalStorageForOrigin):
319         (TestRunner::applicationCacheDiskUsageForOrigin):
320         (TestRunner::grantWebNotificationPermission):
321         (TestRunner::denyWebNotificationPermission):
322         (TestRunner::simulateWebNotificationClick):
323         (TestRunner::simulateLegacyWebNotificationClick):
324
325 2013-04-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
326
327         [WK2][EFL] Text Checker's settings refactor
328         https://bugs.webkit.org/show_bug.cgi?id=111713
329
330         Reviewed by Andreas Kling.
331
332         * MiniBrowser/efl/main.c:
333         (window_create):
334         Use a new text checker API to enable spell checking.
335
336 2013-04-18  Seokju Kwon  <seokju.kwon@gmail.com>
337
338         [EFL] Add a newline to the end of log message
339         https://bugs.webkit.org/show_bug.cgi?id=114659
340
341         Reviewed by Gyuyoung Kim.
342
343         Move a newline to info() definition.
344
345         * EWebLauncher/main.c:
346         (on_load_finished):
347         (on_tooltip_text_set):
348         (on_tooltip_text_unset):
349         (on_inputmethod_changed):
350         (on_focus_out):
351         (on_focus_in):
352         (on_key_down):
353         (windowCreate):
354         * MiniBrowser/efl/main.c:
355         (on_key_down):
356         (on_download_request):
357         (on_download_finished):
358         (on_download_failed):
359         (on_refresh_button_clicked):
360         (on_popup_menu_discarded):
361         (on_popup_menu_item_clicked):
362         (popup_menu_populate):
363         (on_popup_menu_show):
364         (on_window_create):
365         (context_popup_item_selected_cb):
366         (on_context_menu_show):
367         (on_context_menu_hide):
368         (window_create):
369
370 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
371
372         [Dashboard] Remove code for showing 'WebKit roll' annotations in timelines for Chromium builders
373         https://bugs.webkit.org/show_bug.cgi?id=114755
374
375         Reviewed by Ryosuke Niwa.
376
377         The Chromium builders are no longer available to inspect so there's no need for the code that used to show
378         the 'WebKit roll' annotations in the Chromium builders' timeline.
379
380         * TestResultServer/static-dashboards/timeline_explorer.js:
381
382 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
383
384         [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
385         https://bugs.webkit.org/show_bug.cgi?id=114756
386
387         Reviewed by Ryosuke Niwa.
388
389         Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
390         constructing the results URL and removing the possible row addition containing the Chromium commit range that
391         only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
392         method.
393
394         * TestResultServer/static-dashboards/timeline_explorer.js:
395
396 2013-04-17  Alberto Garcia  <agarcia@igalia.com>
397
398         media-stream and xslt are no longer configurable options in the GTK+ port
399         https://bugs.webkit.org/show_bug.cgi?id=114736
400
401         Reviewed by Martin Robinson.
402
403         media-stream support was removed in r145199 and XSLT is a hard
404         requirement since r145859. Attempting to pass those options to the
405         configure script, only results in a warning.
406
407         * Scripts/webkitdirs.pm:
408         (buildAutotoolsProject):
409
410 2013-04-17  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
411
412         [EFL][WK2] Implement context menu in MiniBrowser
413         https://bugs.webkit.org/show_bug.cgi?id=102932
414
415         Reviewed by Gyuyoung Kim.
416
417         Added context menu support for EFL port using Elementary context popup.
418
419         * MiniBrowser/efl/main.c:
420         (_Browser_Window):
421         (context_popup_item_selected_cb):
422         (context_popup_populate):
423         (on_context_menu_show):
424         (on_context_menu_hide):
425         (window_create):
426
427 2013-04-17  Csaba Osztrogonác  <ossy@webkit.org>
428
429         REGRESSION(r148588): It broke the Qt WK2 EWS
430         https://bugs.webkit.org/show_bug.cgi?id=114737
431
432         Reviewed by Jocelyn Turcotte.
433
434         * Scripts/webkitpy/common/config/ews.json: "Qt WK2 EWS" should use qt-wk2 port.
435         * Scripts/webkitpy/common/config/ports.py:
436         (DeprecatedPort.port):
437         (QtPort.build_webkit_command): qt port shouldn't build WebKit2.
438         (QtPort.run_webkit_tests_command): qt port runs WK1 tests.
439         (QtWK2Port): Added.
440         (QtWK2Port.build_webkit_command): qt-wk2 port builds WK1 and WK2 too.
441         (QtWK2Port.run_webkit_tests_command): qt-wk2 port runs WK2 tests.
442         * Scripts/webkitpy/common/config/ports_unittest.py:
443         (DeprecatedPortTest.test_qt_port):
444         (DeprecatedPortTest):
445         (DeprecatedPortTest.test_qt_wk2_port):
446
447 2013-04-17  Zan Dobersek  <zdobersek@igalia.com>
448
449         Unreviewed.
450
451         * Scripts/webkitpy/common/config/ports_unittest.py:
452         (DeprecatedPortTest.test_efl_port): Adjusting the expected outcome of the EFL build-webkit command after r148589.
453
454 2013-04-17  Allan Sandfeld Jensen  <allan.jensen@digia.com>
455
456         [Qt] Enable sub-pixel layout.
457         https://bugs.webkit.org/show_bug.cgi?id=113199
458
459         Reviewed by Jocelyn Turcotte.
460
461         * qmake/mkspecs/features/features.pri:
462
463 2013-04-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
464
465         Add Efl WebKit2 EWS bot
466         https://bugs.webkit.org/show_bug.cgi?id=114564
467
468         Reviewed by Ryosuke Niwa.
469
470         Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
471         Also add a deprecated EflWK2Port class.
472
473         Besides clean up eflews watchers.
474
475         * QueueStatusServer/config/queues.py:
476         * Scripts/webkitpy/common/config/ews.json:
477         * Scripts/webkitpy/common/config/ports.py:
478         (DeprecatedPort.port):
479         (EflPort.build_webkit_command):
480         (EflWK2Port):
481         (EflWK2Port.build_webkit_command):
482
483 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
484
485         Isolate Early Warning System definitions into a JSON
486         https://bugs.webkit.org/show_bug.cgi?id=114558
487
488         Reviewed by Benjamin Poulain.
489
490         Added ews.json to common/config, and made tool/commands/__init__.py call
491         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
492
493         Reland the patch since the EWS failure was a false positive.
494
495         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
496         * Scripts/webkitpy/tool/commands/__init__.py:
497         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
498         (AbstractEarlyWarningSystem):
499         (AbstractEarlyWarningSystem.__init__):
500         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
501         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
502         (EarlyWarningSystemTest._default_expected_logs):
503         (_test_ews):
504         (test_ewses):
505
506 2013-04-16  Sam Weinig  <sam@webkit.org>
507
508         Fix fallout after r148545.
509
510         * WebKitTestRunner/TestController.cpp:
511         (WTR::TestController::resetStateToConsistentValues):
512         Remove calls to non-existent API functions.
513
514 2013-04-13  Roger Fong  <roger_fong@apple.com>
515
516         Unreviewed. Disable WinEWS tests, simply not enough bots.
517
518         All bots are running consistently now but the queue still keeps growing.
519         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
520
521         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
522         (WinEWS):
523
524 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
525
526         The list of contributors in committers.py should be a separate JSON
527         https://bugs.webkit.org/show_bug.cgi?id=114673
528
529         Reviewed by Anders Carlsson.
530
531         Added webkitpy/common/config/contributors.json, made CommitterList load it.
532
533         * EWSTools/start-queue-mac.sh:
534         * EWSTools/start-queue.sh:
535         * Scripts/webkitpy/common/checkout/commitinfo.py:
536         (CommitInfo.committer):
537         * Scripts/webkitpy/common/config/contributors.json: Added.
538         * Scripts/webkitpy/common/config/committers.py:
539         (Reviewer.__init__):
540         (CommitterList.__init__):
541         (CommitterList.load_json): Added.
542         (CommitterList.load_json.emails):
543         (CommitterList.load_json.nicks):
544         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
545         (MockCommitInfo.author):
546
547 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
548
549         [EFL] Bump libsoup dependency to 2.42.0
550         https://bugs.webkit.org/show_bug.cgi?id=113927
551
552         Reviewed by Gyuyoung Kim.
553
554         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
555         required by libsoup for EFL port.
556
557         * efl/jhbuild.modules:
558         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
559         included in v2.42.0.
560
561 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
562
563         Remove Account class from committers.py
564         https://bugs.webkit.org/show_bug.cgi?id=114671
565
566         Reviewed by Csaba Osztrogonác.
567
568         Account class was added to support watch list email addresses that are not associated with
569         a particular contributor but nobody uses these email address since Chromium port forked.
570
571         Remove it.
572
573         Also removed account_by_login from CommitterList since it was never called except its unittests.
574
575         * Scripts/webkitpy/common/checkout/changelog.py:
576         * Scripts/webkitpy/common/config/committers.py:
577         (Contributor):
578         (Contributor.matches_glob):
579         (Reviewer.__init__):
580         (CommitterList.__init__):
581         (CommitterList._email_to_account_map):
582         (CommitterList._login_to_account_map):
583         (CommitterList.contributors_by_fuzzy_match):
584         (CommitterList.contributor_by_email):
585         (CommitterList.contributor_by_name):
586         (CommitterList.committer_by_email):
587         (CommitterList.reviewer_by_email):
588         * Scripts/webkitpy/common/config/committers_unittest.py:
589         (CommittersTest.test_committer_lookup):
590         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
591         (Bugzilla._commit_queue_flag):
592         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
593         (test_commit_queue_flag):
594         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
595         (WatchListParser._validate):
596
597 2013-04-16  Mike West  <mkwst@chromium.org>
598
599         Unreviewed update to the watchlist.
600
601         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
602         watchist file; moving to 'mkwst@chromium.org' instead.
603
604         * Scripts/webkitpy/common/config/committers.py:
605         * Scripts/webkitpy/common/config/watchlist:
606
607 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
608
609         Move webkitpy.layout_tests.port to webkitpy.port
610         https://bugs.webkit.org/show_bug.cgi?id=114668
611
612         Reviewed by Maciej Stachowiak.
613
614         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
615
616         * Scripts/webkitpy/common/host.py:
617         * Scripts/webkitpy/common/host_mock.py:
618         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
619         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
620         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
621         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
622         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
623         * Scripts/webkitpy/layout_tests/port: Removed.
624         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
625         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
626         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
627         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
628         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
629         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
630         * Scripts/webkitpy/performance_tests/perftest.py:
631         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
632         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
633         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
634         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
635         * Scripts/webkitpy/port/apple.py:
636         * Scripts/webkitpy/port/base.py:
637         * Scripts/webkitpy/port/base_unittest.py:
638         * Scripts/webkitpy/port/config_unittest.py:
639         (ConfigTest.test_default_configuration__standalone):
640         * Scripts/webkitpy/port/driver_unittest.py:
641         * Scripts/webkitpy/port/efl.py:
642         * Scripts/webkitpy/port/efl_unittest.py:
643         * Scripts/webkitpy/port/factory.py:
644         * Scripts/webkitpy/port/factory_unittest.py:
645         * Scripts/webkitpy/port/gtk.py:
646         * Scripts/webkitpy/port/gtk_unittest.py:
647         * Scripts/webkitpy/port/image_diff.py:
648         * Scripts/webkitpy/port/image_diff_unittest.py:
649         * Scripts/webkitpy/port/leakdetector_unittest.py:
650         * Scripts/webkitpy/port/mac.py:
651         * Scripts/webkitpy/port/mac_unittest.py:
652         * Scripts/webkitpy/port/mock_drt.py:
653         * Scripts/webkitpy/port/mock_drt_unittest.py:
654         * Scripts/webkitpy/port/port_testcase.py:
655         * Scripts/webkitpy/port/qt.py:
656         * Scripts/webkitpy/port/qt_unittest.py:
657         * Scripts/webkitpy/port/server_process_unittest.py:
658         * Scripts/webkitpy/port/test.py:
659         * Scripts/webkitpy/port/win.py:
660         * Scripts/webkitpy/port/win_unittest.py:
661         * Scripts/webkitpy/port/xvfbdriver.py:
662         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
663         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
664         * Scripts/webkitpy/tool/commands/gardenomatic.py:
665         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
666         * Scripts/webkitpy/tool/commands/queries.py:
667         * Scripts/webkitpy/tool/commands/queries_unittest.py:
668         * Scripts/webkitpy/tool/commands/rebaseline.py:
669         * Scripts/webkitpy/tool/servers/gardeningserver.py:
670         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
671         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
672         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
673
674 2013-04-16  Commit Queue  <rniwa@webkit.org>
675
676         Unreviewed, rolling out r148498.
677         http://trac.webkit.org/changeset/148498
678         https://bugs.webkit.org/show_bug.cgi?id=114669
679
680         Appears to have broken EWS (Requested by rniwa on #webkit).
681
682         * Scripts/webkitpy/common/config/ews.json: Removed.
683         * Scripts/webkitpy/tool/commands/__init__.py:
684         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
685         (AbstractEarlyWarningSystem):
686         (AbstractEarlyWarningSystem.__init__):
687         (AbstractEarlyWarningSystem.handle_script_error.does):
688         (GtkEWS):
689         (GtkWK2EWS):
690         (EflEWS):
691         (QtEWS):
692         (QtWK2EWS):
693         (WinEWS):
694         (MacEWS):
695         (MacWK2EWS):
696         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
697         (EarlyWarningSystemTest._default_expected_logs):
698         (_test_ews):
699         (test_ewses):
700
701 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
702
703         Isolate Early Warning System definitions into a JSON
704         https://bugs.webkit.org/show_bug.cgi?id=114558
705
706         Reviewed by Benjamin Poulain.
707
708         Added ews.json to common/config, and made tool/commands/__init__.py call
709         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
710
711         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
712         * Scripts/webkitpy/tool/commands/__init__.py:
713         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
714         (AbstractEarlyWarningSystem):
715         (AbstractEarlyWarningSystem.__init__):
716         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
717         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
718         (EarlyWarningSystemTest._default_expected_logs):
719         (_test_ews):
720         (test_ewses):
721
722 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
723
724         WKR gets stuck when there are many merges
725         https://bugs.webkit.org/show_bug.cgi?id=114632
726
727         Reviewed by Andreas Kling.
728
729         Move the last revision forward when it exists in a branch.
730         Otherwise, we'll be stuck looping over revisions made to merge patches.
731
732         * Scripts/webkitpy/tool/commands/newcommitbot.py:
733         (NewCommitBot.next_work_item):
734
735 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
736
737         [GTK] Missing a few packages for building on stock Fedora
738         https://bugs.webkit.org/show_bug.cgi?id=113916
739
740         Reviewed by Philippe Normand.
741
742         * gtk/install-dependencies: add packages that are missing.
743
744 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
745
746         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
747         https://bugs.webkit.org/show_bug.cgi?id=114602
748
749         Reviewed by Ryosuke Niwa.
750
751         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
752         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
753         interface so its value doesn't leak into the following tests.
754
755 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
756
757         Deprecate land-cowboy in favor of land-cowhand
758         https://bugs.webkit.org/show_bug.cgi?id=104470
759
760         Reviewed by Darin Adler.
761
762         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
763
764         * Scripts/webkitpy/tool/commands/download.py:
765         (LandCowhand):
766         (LandCowboy):
767         (LandCowboy._prepare_state):
768         * Scripts/webkitpy/tool/commands/download_unittest.py:
769         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
770         also checking the deprecation message in the output of the latter.
771
772 2013-04-15  Jonathan Liu  <net147@gmail.com>
773
774         Improve Windows cmd.exe detection
775         https://bugs.webkit.org/show_bug.cgi?id=114620
776
777         Reviewed by Jocelyn Turcotte.
778
779         The current detection code handles Windows cmd.exe and Cygwin shell
780         but not does not handle MSYS shell correctly. Simplify and improve the
781         detection by checking MINGW_IN_SHELL instead as used in other places
782         (e.g. qt_functions.prf).
783
784         * qmake/mkspecs/features/default_pre.prf:
785
786 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
787
788         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
789         https://bugs.webkit.org/show_bug.cgi?id=114506
790
791         Reviewed by Philippe Normand.
792
793         * Scripts/webkitpy/common/system/executive.py:
794         (Executive.cpu_count): Modify function in order to use the environment
795         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
796         greater than 0.
797
798 2013-04-15  Xan Lopez  <xlopez@igalia.com>
799
800         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
801         https://bugs.webkit.org/show_bug.cgi?id=114615
802
803         Reviewed by Carlos Garcia Campos.
804
805         Enable the style scoped feature if we have support for it.
806
807         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
808         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
809
810 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
811
812         [Qt] QtMultimedia not used when GStreamer is not found
813         https://bugs.webkit.org/show_bug.cgi?id=111842
814
815         Reviewed by Philippe Normand.
816
817         Fallback to using QtMultimedia when native libraries are not found.
818
819         * qmake/mkspecs/features/features.prf:
820
821 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
822
823         Build fix attempt for webkitbot. Unicodify everything.
824
825         * Scripts/webkitpy/tool/bot/irc_command.py:
826         (Whois.execute):
827
828 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
829
830         webkitbot should provide full name, email address, and IRC nicknames on whois
831         https://bugs.webkit.org/show_bug.cgi?id=114494
832
833         Reviewed by Benjamin Poulain.
834
835         A response like the one below is useless. Improve it:
836         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
837
838         We now report full name, email address, committer/reviewer status, and IRC nickname.
839
840         Also teach webkitbot how to respond to ping.
841
842         * Scripts/webkitpy/tool/bot/irc_command.py:
843         (PingPong): Moved 
844         (PingPong.execute):
845         (Whois._full_record_and_nick): Renamed and rewritten.
846         (Whois.execute):
847
848         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
849         (IRCCommandTest.test_whois): Updated test cases as needed.
850
851         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
852         (IRCBotTest.test_help): Added ping.
853
854         * Scripts/webkitpy/tool/commands/newcommitbot.py:
855         (NewCommitBot): Teached WKR how to respond to hi.
856
857 2013-04-13  Anders Carlsson  <andersca@apple.com>
858
859         Add form delegate method that's invoked right before sending a submit event to a form element
860         https://bugs.webkit.org/show_bug.cgi?id=114575
861
862         Reviewed by Dan Bernstein.
863
864         Add a test.
865
866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
867         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
868         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
869         (TestWebKitAPI):
870         (TestWebKitAPI::TEST):
871         
872         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
873         (TestWebKitAPI::Util::toSTD):
874         Don't crash when a null NSString is passed to toSTD.
875
876 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
877
878         Python test fix attempt after r148360.
879
880         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
881         (test_command_help):
882
883 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
884
885         Merge AbstractDeclarativeCommand into Command as a comment suggests
886         https://bugs.webkit.org/show_bug.cgi?id=114559
887
888         Reviewed by Antti Koivisto.
889
890         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
891         We need to merge a lot more classes to make webkitpy hackable.
892
893         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
894         (AbstractLocalServerCommand):
895         (AbstractLocalServerCommand.__init__):
896         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
897         (AbstractSequencedCommand):
898         (AbstractSequencedCommand.__init__):
899         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
900         (AddUsersToGroups):
901         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
902         (AnalyzeChangeLog):
903         (AnalyzeChangeLog.__init__):
904         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
905         * Scripts/webkitpy/tool/commands/bugfortest.py:
906         (BugForTest):
907         * Scripts/webkitpy/tool/commands/bugsearch.py:
908         (BugSearch):
909         * Scripts/webkitpy/tool/commands/chromechannels.py:
910         (ChromeChannels):
911         (__init__):
912         * Scripts/webkitpy/tool/commands/download.py:
913         (AbstractPatchProcessingCommand):
914         * Scripts/webkitpy/tool/commands/findusers.py:
915         (FindUsers):
916         * Scripts/webkitpy/tool/commands/openbugs.py:
917         (OpenBugs):
918         * Scripts/webkitpy/tool/commands/queries.py:
919         (BugsToCommit):
920         (PatchesInCommitQueue):
921         (PatchesToCommitQueue):
922         (PatchesToCommitQueue.__init__):
923         (PatchesToReview):
924         (PatchesToReview.__init__):
925         (PatchesToReview.execute):
926         (WhatBroke):
927         (ResultsFor):
928         (FailureReason):
929         (FindFlakyTests):
930         (TreeStatus):
931         (CrashLog):
932         (PrintExpectations):
933         (PrintExpectations.__init__):
934         (PrintBaselines):
935         (PrintBaselines.__init__):
936         * Scripts/webkitpy/tool/commands/queues.py:
937         (AbstractQueue.__init__):
938         * Scripts/webkitpy/tool/commands/rebaseline.py:
939         (AbstractRebaseliningCommand):
940         * Scripts/webkitpy/tool/commands/suggestnominations.py:
941         (SuggestNominations):
942         (SuggestNominations.__init__):
943         * Scripts/webkitpy/tool/commands/upload.py:
944         (CommitMessageForCurrentDiff):
945         (CommitMessageForCurrentDiff.__init__):
946         (CleanPendingCommit):
947         (CleanReviewQueue):
948         (AssignToCommitter):
949         (PostCommits):
950         (PostCommits.__init__):
951         (MarkBugFixed):
952         (MarkBugFixed.__init__):
953         (CreateBug):
954         (CreateBug.__init__):
955         * Scripts/webkitpy/tool/multicommandtool.py:
956         (Command):
957         (Command.__init__):
958         (Command.main):
959         (HelpCommand):
960         (HelpCommand.__init__):
961         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
962         (TrivialCommand):
963         (TrivialCommand.__init__):
964         (LikesToRetry):
965         (LikesToRetry.__init__):
966         (CommandTest.test_name_with_arguments):
967         (CommandTest.test_required_arguments):
968         (test_command_help):
969
970 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
971
972         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
973         https://bugs.webkit.org/show_bug.cgi?id=114048
974
975         Reviewed by Gyuyoung Kim.
976
977         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
978
979         * DumpRenderTree/efl/TestRunnerEfl.cpp:
980         (TestRunner::setViewModeMediaFeature):
981
982 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
983
984         Merge watchlistloader into host since it's an unnecessary indirection
985         https://bugs.webkit.org/show_bug.cgi?id=114555
986
987         Reviewed by Antti Koivisto.
988
989         We don't need a class to load a file.
990
991         * Scripts/webkitpy/common/host.py:
992         (Host.watch_list):
993         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
994         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
995
996 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
997
998         Rename JSONResultsGeneratorBase to JSONResultsGenerator
999         https://bugs.webkit.org/show_bug.cgi?id=114553
1000
1001         Reviewed by Philippe Normand.
1002
1003         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
1004
1005         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1006         (JSONLayoutResultsGenerator):
1007         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1008         (JSONResultsGenerator):
1009         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1010         (JSONGeneratorTest._test_json_generation):
1011         (JSONGeneratorTest._verify_json_results):
1012
1013 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1014
1015         Remove more Chromium specific code from webkitpy
1016         https://bugs.webkit.org/show_bug.cgi?id=114552
1017
1018         Reviewed by Philippe Normand.
1019
1020         * Scripts/webkitpy/common/host.py:
1021         (Host.checkout):
1022         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1023         (JSONResultsGeneratorBase):
1024         (JSONResultsGeneratorBase.__init__):
1025         (JSONResultsGeneratorBase._is_results_all_of_type):
1026         * Scripts/webkitpy/layout_tests/port/base.py:
1027         (Port):
1028         (Port.expected_filename):
1029         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1030         (PerfTestsRunner._parse_args):
1031         * Scripts/webkitpy/tool/commands/queues.py:
1032         (PatchProcessingQueue._new_port_name_from_old):
1033         (CommitQueue.did_pass_testing_ews):
1034         * Scripts/webkitpy/tool/commands/rebaseline.py:
1035         (RebaselineTest._results_url):
1036         (Rebaseline._builder_with_name):
1037         * Scripts/webkitpy/tool/mocktool.py:
1038         (MockTool.irc):
1039
1040 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
1041
1042         Fix flakiness dashboard unit test failures
1043         https://bugs.webkit.org/show_bug.cgi?id=114518
1044
1045         Reviewed by Ryosuke Niwa.
1046
1047         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
1048         test cases to simulate loading the builders list from the webkit.org build master, replacing
1049         the Chromium builders and platforms that are used in tests with builders and platforms for the
1050         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
1051         functionality of the dashboard.
1052
1053         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
1054         code and hopefully general simplification of the dashboard codebase coming in near future.
1055
1056         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1057         (resetGlobals):
1058         (test):
1059         * TestResultServer/static-dashboards/loader_unittests.js:
1060
1061 2013-04-12  David Kilzer  <ddkilzer@apple.com>
1062
1063         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
1064
1065         Reviewed by Chris Fleizach.
1066
1067         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
1068         -_accessibilityPath from the WebAccessibilityObjectWrapper
1069         class.
1070         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
1071
1072 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
1073
1074         Unreviewed, remove an old email address for myself.
1075
1076         * Scripts/webkitpy/common/config/committers.py:
1077
1078 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1079
1080         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
1081         https://bugs.webkit.org/show_bug.cgi?id=110743
1082
1083         Reviewed by Benjamin Poulain.
1084
1085         Adding a new test file to check if loading a page just after WebProcess
1086         has crashed (or was terminated) works. The test executes the
1087         following steps (Load, Crash, Load), thus stressing WebProcess
1088         reattach and process termination code path.
1089
1090         * TestWebKitAPI/GNUmakefile.am:
1091         * TestWebKitAPI/PlatformEfl.cmake:
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1094         (TestWebKitAPI::setPageLoaderClient):
1095         (TestWebKitAPI::TEST):
1096         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
1097         (TestWebKitAPI):
1098         (WebKit2CrashLoader):
1099         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1100         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
1101         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
1102         (TestWebKitAPI::didFinishLoad):
1103         (TestWebKitAPI::TEST):
1104         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1105
1106 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1107
1108         [Mac] REGRESSION: Auto substitution strips new lines
1109         https://bugs.webkit.org/show_bug.cgi?id=114537
1110
1111         Reviewed by Enrica Casucci.
1112
1113         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
1114
1115         * DumpRenderTree/mac/DumpRenderTree.mm:
1116         (resetDefaultsToConsistentValues):
1117
1118 2013-04-09  Roger Fong  <roger_fong@apple.com>
1119
1120         Re-enable WinEWS tests.
1121
1122         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1123         (WinEWS):
1124
1125 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1126
1127         [GTK] Split GtkAuthenticationDialog in two widgets
1128         https://bugs.webkit.org/show_bug.cgi?id=103644
1129
1130         Reviewed by Xan Lopez.
1131
1132         * gtk/generate-gtkdoc:
1133         (get_webkit2_options): Do not generate api docs for
1134         WebKitAuthenticationDialog which is private in WebKit2.
1135         (get_webkit1_options): Do not generate api docs for
1136         webkitauthenticationdialog which is private in WebKit1.
1137
1138 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1139
1140         WebKit Queues should capitalize K in Wk2
1141         https://bugs.webkit.org/show_bug.cgi?id=114524
1142
1143         Reviewed by Philippe Normand.
1144
1145         * QueueStatusServer/model/queues.py:
1146         (Queue.display_name):
1147
1148 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1149
1150         [Mac] Enable spellchecking tests added in r141471
1151         https://bugs.webkit.org/show_bug.cgi?id=108525
1152
1153         Reviewed by Darin Adler.
1154
1155         * DumpRenderTree/mac/DumpRenderTree.mm:
1156         (createWebViewAndOffscreenWindow):
1157         (resetDefaultsToConsistentValues):
1158         * WebKitTestRunner/TestController.cpp:
1159         (WTR::TestController::resetStateToConsistentValues):
1160
1161 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
1162
1163         [GTK] Enable WebKit2 building on GTK EWSs
1164         https://bugs.webkit.org/show_bug.cgi?id=114500
1165
1166         Reviewed by Philippe Normand.
1167
1168         Add configuration in order to be able to setup GTK EWSs building
1169         WebKit2. A new queue gtk-wk2-ews is added.
1170
1171         * QueueStatusServer/config/queues.py:
1172         * Scripts/webkitpy/common/config/ports.py:
1173         (DeprecatedPort.port):
1174         (GtkWK2Port):
1175         (GtkWK2Port.build_webkit_command):
1176         (GtkWK2Port.run_webkit_tests_command):
1177         * Scripts/webkitpy/common/config/ports_unittest.py:
1178         (DeprecatedPortTest.test_gtk_port):
1179         (DeprecatedPortTest):
1180         (DeprecatedPortTest.test_gtk_wk2_port):
1181         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1182         (GtkWK2EWS):
1183
1184 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1185
1186         Remove Chromium scripts
1187         https://bugs.webkit.org/show_bug.cgi?id=114492
1188
1189         Reviewed by Benjamin Poulain.
1190
1191         * Scripts/run-chromium-webkit-unit-tests: Removed.
1192         * Scripts/update-webkit-chromium: Removed.
1193
1194 2013-04-12  Commit Queue  <rniwa@webkit.org>
1195
1196         Unreviewed, rolling out r148262.
1197         http://trac.webkit.org/changeset/148262
1198         https://bugs.webkit.org/show_bug.cgi?id=114493
1199
1200         Cairo dep should now build, rolling r148247 back in (Requested
1201         by zdobersek on #webkit).
1202
1203         * Scripts/webkitdirs.pm:
1204         (buildAutotoolsProject):
1205         * gtk/jhbuild.modules:
1206
1207 2013-04-11  Commit Queue  <rniwa@webkit.org>
1208
1209         Unreviewed, rolling out r148247.
1210         http://trac.webkit.org/changeset/148247
1211         https://bugs.webkit.org/show_bug.cgi?id=114490
1212
1213         Cairo dep fails to build on builders due to missing EGL
1214         headers (Requested by zdobersek on #webkit).
1215
1216         * Scripts/webkitdirs.pm:
1217         (buildAutotoolsProject):
1218         * gtk/jhbuild.modules:
1219
1220 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
1221
1222         [GTK] Add accelerated 2D canvas support using cairo-gl
1223         https://bugs.webkit.org/show_bug.cgi?id=104672
1224
1225         Reviewed by Alejandro G. Castro.
1226
1227         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
1228         dependencies, don't override value of the setting determined by configure.
1229         This will make it easier for people using build-webkit, but not the
1230         WebKit JHBuild.
1231
1232         * Scripts/webkitdirs.pm:
1233         (buildAutotoolsProject): Add a blacklist for settings to never override.
1234         * gtk/jhbuild.modules: Build CairoGL.
1235
1236 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1237
1238         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
1239         https://bugs.webkit.org/show_bug.cgi?id=114477
1240
1241         Reviewed by Benjamin Poulain.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1244
1245 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1246
1247         Leaks builder should not be triggered upon new commits
1248         https://bugs.webkit.org/show_bug.cgi?id=114475
1249
1250         Reviewed by Jessie Berlin.
1251
1252         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
1253         the leak builder when builds are done.
1254
1255         * BuildSlaveSupport/build.webkit.org-config/config.json:
1256
1257 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
1258
1259         [GTK] Windows build failure after r136056
1260         https://bugs.webkit.org/show_bug.cgi?id=114121
1261
1262         Reviewed by Martin Robinson.
1263
1264         * TestWebKitAPI/config.h: Make sure defines are correct for other
1265         Windows ports than apple-win.
1266
1267 2013-04-11  Ojan Vafai  <ojan@chromium.org>
1268
1269         Remove myself from watchlists.
1270         * Scripts/webkitpy/common/config/watchlist:
1271
1272 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1273
1274         Build fix. Don't hard-code queues.webkit.org at least during the transition.
1275
1276         * QueueStatusServer/templates/statusbubble.html:
1277
1278 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1279
1280         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
1281         https://bugs.webkit.org/show_bug.cgi?id=114397
1282
1283         Reviewed by Benjamin Poulain.
1284
1285         Reland the patch since Alan appears to have finished the migration.
1286
1287         * Scripts/webkitpy/common/net/statusserver.py:
1288         (StatusServer):
1289
1290 2013-04-11  Brian Holt  <brian.holt@samsung.com>
1291
1292         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
1293         https://bugs.webkit.org/show_bug.cgi?id=76796
1294
1295         Reviewed by Chris Fleizach.
1296
1297         Make the Gtk window for the DRT a toplevel so that it gets the
1298         focus from the window manager when the test starts.
1299
1300         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1301         (main):
1302
1303 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1304
1305         Use CSS4 image-rendering to determing image scaling quality
1306         https://bugs.webkit.org/show_bug.cgi?id=113405
1307
1308         Reviewed by Simon Fraser.
1309
1310         Introduce new flag to enable experimental support for CSS4 Images.
1311
1312         * Scripts/webkitperl/FeatureList.pm:
1313
1314 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1315
1316         Remove code for Chromium from wkbuild.py
1317         https://bugs.webkit.org/show_bug.cgi?id=114423
1318
1319         Reviewed by Benjamin Poulain.
1320
1321         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1322         (_should_file_trigger_build):
1323         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1324         (ShouldBuildTest):
1325
1326 2013-04-11  Philippe Normand  <pnormand@igalia.com>
1327
1328         Unreviewed, update my IRC nickname.
1329
1330         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
1331
1332 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1333
1334         Remove the rest of Chromium code from webkitpy
1335         https://bugs.webkit.org/show_bug.cgi?id=114420
1336
1337         Reviewed by Benjamin Poulain.
1338
1339         * Scripts/webkitpy/common/config/urls.py:
1340         (view_revision_url):
1341         * Scripts/webkitpy/common/host.py:
1342         (Host._engage_awesome_locale_hacks):
1343         (Host.initialize_scm):
1344         (Host):
1345         * Scripts/webkitpy/common/host_mock.py:
1346         (MockHost.__init__):
1347         (MockHost.checkout):
1348         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
1349         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1350         (JSONResultsGeneratorBase._insert_generic_metadata):
1351         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1352         (TestExpectationParser._tokenize_line):
1353         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1354         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1355         (ExpectationSyntaxTests.test_warnings):
1356         * Scripts/webkitpy/layout_tests/port/base.py:
1357         (Port.skips_perf_test):
1358         (Port.path_to_test_expectations_file):
1359         (Port._port_flag_for_scripts):
1360         * Scripts/webkitpy/style/checkers/cpp.py:
1361         (check_function_definition):
1362         (check_include_line):
1363         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1364         (OrderOfIncludesTest.test_check_wtf_includes):
1365         (WebKitStyleTest.test_webkit_export_check):
1366         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1367         (TestExpectationsTestCase.test_valid_expectations):
1368         * Scripts/webkitpy/tool/bot/irc_command.py:
1369         (Rollout.execute):
1370         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1371         (IRCCommandTest.test_whois):
1372         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1373         (IRCBotTest.test_help):
1374         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1375         (SheriffBotTest.test_command_aliases):
1376
1377 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1378
1379         roll-chromium-deps doesn't roll DEPS
1380         https://bugs.webkit.org/show_bug.cgi?id=114421
1381
1382         Reviewed by Antti Koivisto.
1383
1384         Roll DEPS. Rolling DEPS. Rolled DEPS.
1385
1386         * Scripts/webkitpy/tool/bot/irc_command.py:
1387         (RollChromiumDEPS.execute):
1388
1389 2013-04-11  Glenn Adams  <glenn@skynav.com>
1390
1391         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
1392         https://bugs.webkit.org/show_bug.cgi?id=114418
1393
1394         Reviewed by Ryosuke Niwa.
1395
1396         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1397         (MockSCM.add): Remove optional remove_exit_code argument.
1398         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
1399         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1400         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
1401         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
1402
1403 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1404
1405         Fix roll-chromium-deps and hi.
1406
1407         * Scripts/webkitpy/tool/bot/irc_command.py:
1408         (Hi.execute):
1409         (RollChromiumDEPS.execute):
1410
1411 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1412
1413         Remove webkitpy code to roll Chromium DEPS
1414         https://bugs.webkit.org/show_bug.cgi?id=114415
1415
1416         Reviewed by Benjamin Poulain.
1417
1418         Removed the code to roll Chromium DEPS in WebKit.
1419
1420         * Scripts/webkitpy/common/checkout/checkout.py:
1421         (Checkout.bug_id_for_this_commit):
1422         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1423         (MockCheckout.commit_message_for_this_commit):
1424         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1425         (CheckoutTest.test_suggested_reviewers):
1426         * Scripts/webkitpy/common/checkout/deps.py: Removed.
1427         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
1428         * Scripts/webkitpy/tool/bot/irc_command.py:
1429         (RollChromiumDEPS): Teach webkitbot a sense of humor.
1430         (RollChromiumDEPS.execute):
1431         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1432         (IRCCommandTest.test_create_bug):
1433         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1434         (IRCBotTest.test_revert):
1435         * Scripts/webkitpy/tool/bot/sheriff.py:
1436         (Sheriff.post_rollout_patch):
1437         * Scripts/webkitpy/tool/commands/__init__.py:
1438         * Scripts/webkitpy/tool/commands/roll.py: Removed.
1439         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
1440         * Scripts/webkitpy/tool/steps/__init__.py:
1441         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
1442         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
1443         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
1444
1445 2013-04-11  Glenn Adams  <glenn@skynav.com>
1446
1447         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
1448         https://bugs.webkit.org/show_bug.cgi?id=114386
1449
1450         Reviewed by Benjamin Poulain.
1451
1452         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
1453         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
1454         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
1455         by default and to return exit code 1 if a file/dir had already been added.
1456
1457         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1458         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
1459         * Scripts/webkitpy/common/checkout/scm/svn.py:
1460         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
1461
1462 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1463
1464         Unreviewed.
1465
1466         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
1467
1468 2013-04-10  Glenn Adams  <glenn@skynav.com>
1469
1470         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
1471         https://bugs.webkit.org/show_bug.cgi?id=114410
1472
1473         Reviewed by Ryosuke Niwa.
1474
1475         * Scripts/webkitpy/common/checkout/scm/git.py:
1476         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
1477         * Scripts/webkitpy/common/checkout/scm/scm.py:
1478         (SCM.add): Remove optional return_exit_code argument.
1479         (SCM.add_list): Remove optional return_exit_code argument.
1480         * Scripts/webkitpy/common/checkout/scm/svn.py:
1481         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
1482
1483 2013-04-10  Eric Seidel  <eric@webkit.org>
1484
1485         Remove myself from the watchlists, I'm getting too much bug mail. :)
1486
1487         * Scripts/webkitpy/common/config/watchlist:
1488
1489 2013-04-10  Commit Queue  <rniwa@webkit.org>
1490
1491         Unreviewed, rolling out r148158.
1492         http://trac.webkit.org/changeset/148158
1493         https://bugs.webkit.org/show_bug.cgi?id=114405
1494
1495         We need to migrate status data (Requested by rniwa on
1496         #webkit).
1497
1498         * Scripts/webkitpy/common/net/statusserver.py:
1499         (StatusServer):
1500
1501 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
1502
1503         Mass remove all the empty directories
1504
1505         Rubberstamped by Ryosuke Niwa.
1506
1507         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1508         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1509         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1510         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1511         * MiniBrowser/gtk/WebBundle: Removed.
1512         * MiniBrowser/win: Removed.
1513         * QtTestPlatformPlugin/mac: Removed.
1514         * Scripts/webkitpy/tool/bot/testdata: Removed.
1515         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1516         * efl/ImageDiff: Removed.
1517         * iExploder/htdocs: Removed.
1518         * iExploder/iexploder-1.7.2/output: Removed.
1519         * iExploder/tools: Removed.
1520         * qmake/config.tests/libexecdir: Removed.
1521         * qmake/config.tests/libjpeg: Removed.
1522         * qmake/config.tests/libpng: Removed.
1523
1524 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1525
1526         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1527         https://bugs.webkit.org/show_bug.cgi?id=114397
1528
1529         Reviewed by Benjamin Poulain.
1530
1531         * Scripts/webkitpy/common/net/statusserver.py:
1532         (StatusServer):
1533
1534 2013-04-10  Adam Barth  <abarth@webkit.org>
1535
1536         Remove abarth from watchlists
1537         https://bugs.webkit.org/show_bug.cgi?id=114390
1538
1539         Reviewed by Ryosuke Niwa.
1540
1541         I'm trying to cut down on the amount of bugmail I get so that I'll have
1542         more of a chance to notice a piece of bugmail directed at me.
1543
1544         * Scripts/webkitpy/common/config/watchlist:
1545
1546 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1547
1548         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1549         https://bugs.webkit.org/show_bug.cgi?id=114381
1550
1551         Reviewed by Benjamin Poulain.
1552
1553         Changed the defaults.
1554
1555         * TestResultServer/static-dashboards/builders.js:
1556         * TestResultServer/static-dashboards/dashboard_base.js:
1557         (currentBuilderGroupCategory):
1558
1559 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1560
1561         Remove Chromium EWS bots from the queue status server
1562         https://bugs.webkit.org/show_bug.cgi?id=113988
1563
1564         Reviewed by Benjamin Poulain.
1565
1566         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1567
1568         * QueueStatusServer/app.yaml:
1569         * QueueStatusServer/config/queues.py:
1570         * QueueStatusServer/model/queues.py:
1571         (Queue.short_name):
1572         (Queue.display_name):
1573         * QueueStatusServer/model/queues_unittest.py:
1574         (QueueTest.test_short_name):
1575         (QueueTest.test_display_name):
1576         (QueueTest.test_name_with_underscores):
1577         * QueueStatusServer/templates/activebots.html:
1578
1579 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1580
1581         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1582         https://bugs.webkit.org/show_bug.cgi?id=114370
1583
1584         Reviewed by Ryosuke Niwa.
1585
1586         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1587         Unfortunately, there's no way to test this until this is committed and there is
1588         a master restart.
1589
1590         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1596         * TestResultServer/generate_builders_json.py:
1597         * TestResultServer/static-dashboards/dashboard_base.js:
1598         * TestResultServer/static-dashboards/loader.js:
1599
1600 2013-04-10  Glenn Adams  <glenn@skynav.com>
1601
1602         [Qt] Fix regression to test-webkitpy.
1603         https://bugs.webkit.org/show_bug.cgi?id=114368
1604
1605         Reviewed by Ryosuke Niwa.
1606
1607         * Scripts/webkitpy/layout_tests/port/factory.py:
1608         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1609         (PortFactory.get): Remove obsolete chromium port related code.
1610         * Scripts/webkitpy/layout_tests/port/mac.py:
1611         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1612
1613 2013-04-10  Anders Carlsson  <andersca@apple.com>
1614
1615         Remove unneeded headers from FrameLoader.h
1616         https://bugs.webkit.org/show_bug.cgi?id=114223
1617
1618         Reviewed by Geoffrey Garen.
1619
1620         Add back headers implicitly included by other headers.
1621
1622         * WebKitTestRunner/WorkQueueManager.cpp:
1623
1624 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1625
1626         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1627         https://bugs.webkit.org/show_bug.cgi?id=114365
1628
1629         Reviewed by Martin Robinson.
1630
1631         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1632         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1633         at-spi2-atk source tree and will be available with the next stable release, after which the
1634         patch should be removed and the dependency version bumped.
1635
1636         * gtk/jhbuild.modules:
1637         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1638
1639 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1640
1641         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1642
1643         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1644         match change in DropBox server behavior.
1645
1646 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1647
1648         Removed an annoying message from svn-create-patch
1649         https://bugs.webkit.org/show_bug.cgi?id=114332
1650
1651         Reviewed by Alexey Proskuryakov.
1652
1653         I see this message basically every time I write a patch, so it must not
1654         be true.
1655
1656         * Scripts/svn-create-patch:
1657         (generateDiff):
1658
1659 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1660
1661         [GTK] Add support for Page Visibility
1662         https://bugs.webkit.org/show_bug.cgi?id=97324
1663
1664         Reviewed by Sam Weinig.
1665
1666         Implemented test runner API for page visibility layout tests.
1667
1668         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1669         (TestRunner::resetPageVisibility):
1670         (TestRunner::setPageVisibility):
1671         * Scripts/webkitperl/FeatureList.pm:
1672
1673 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1674
1675         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1676         https://bugs.webkit.org/show_bug.cgi?id=114342
1677
1678         Reviewed by Gyuyoung Kim.
1679
1680         Commit 148033 only added an implementation for the Mac port, which made
1681         other ports fail most tests since loading the injected bundle failed
1682         with a missing symbol.
1683
1684         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1685         (WTR::AccessibilityUIElement::pathDescription):
1686
1687 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1688
1689         [EFL] Add spell checking option to MiniBrowser
1690         https://bugs.webkit.org/show_bug.cgi?id=114282
1691
1692         Reviewed by Ryosuke Niwa.
1693
1694         Spell checking is enabled by adding a flag (t/text-checking)
1695         with launching MiniBrowser.
1696
1697         * MiniBrowser/efl/main.c:
1698         (window_create):
1699         (elm_main):
1700
1701 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1702
1703         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1704         https://bugs.webkit.org/show_bug.cgi?id=113281
1705
1706         Reviewed by Darin Adler.
1707
1708         * Scripts/run-gtk-tests:
1709         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1710
1711 2013-04-09  Glenn Adams  <glenn@skynav.com>
1712
1713         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1714
1715         Unreviewed.
1716
1717         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1718         (RunTest.test_build_check):
1719
1720 2013-04-09  Glenn Adams  <glenn@skynav.com>
1721
1722         [webkitpy] Remove chromium ports.
1723         https://bugs.webkit.org/show_bug.cgi?id=114326
1724
1725         Reviewed by Dirk Pranke.
1726
1727         As a side effect, also:
1728
1729         - remove chromium builders from webkitpy.layout_tests.port.builders
1730         - remove chromium builders from rebaseline
1731         - rewrite chromium dependent tests in rebaseline_unittest
1732         - remove chromium platform from garden-o-matic
1733         - select apple platform as default platform in garden-o-matic
1734         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1735
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1738         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1739         (BaselineOptimizerTest.test_move_baselines):
1740         (BaselineOptimizerTest.test_efl):
1741         (BaselineOptimizerTest.test_no_add_mac_future):
1742         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1743         (BaselineOptimizerTest.test_common_directory_includes_root):
1744         (BaselineOptimizerTest.test_complex_shadowing):
1745         (BaselineOptimizerTest.test_virtual_ports_filtered):
1746         * Scripts/webkitpy/layout_tests/port/builders.py:
1747         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1748         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1749         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1750         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1751         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1752         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1753         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1754         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1755         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1756         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1757         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1758         * Scripts/webkitpy/layout_tests/port/factory.py:
1759         (platform_options):
1760         (PortFactory):
1761         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1762         (FactoryTest.test_qt):
1763         (FactoryTest.test_get_from_builder_name):
1764         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1765         (RunTest.test_build_check):
1766         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1767         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1768         * Scripts/webkitpy/tool/commands/rebaseline.py:
1769         (Rebaseline._builders_to_pull_from):
1770         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1771         (_BaseTestCase):
1772         (_BaseTestCase.setUp):
1773         (TestRebaselineTest.setUp):
1774         (TestRebaselineTest.test_baseline_directory):
1775         (test_rebaseline_updates_expectations_file):
1776         (test_rebaseline_does_not_include_overrides):
1777         (test_rebaseline_test):
1778         (test_rebaseline_test_and_print_scm_changes):
1779         (test_rebaseline_and_copy_test):
1780         (test_rebaseline_and_copy_test_no_existing_result):
1781         (test_rebaseline_and_copy_test_with_lion_result):
1782         (test_rebaseline_and_copy_no_overwrite_test):
1783         (TestRebaselineExpectations.test_rebaseline_expectations):
1784
1785 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1786
1787         newcommitbot (WKR) requires a subversion checkout
1788         https://bugs.webkit.org/show_bug.cgi?id=114309
1789
1790         Reviewed by Benjamin Poulain.
1791
1792         Directly talk to the subversion server instead of relying on a local checkout.
1793         This allows us to run WKR off of a git clone.
1794
1795         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1796         (NewCommitBot.next_work_item):
1797         (NewCommitBot.process_work_item):
1798
1799 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1800
1801         webkitbot refers to sheriffbot in help
1802         https://bugs.webkit.org/show_bug.cgi?id=114307
1803
1804         Reviewed by Benjamin Poulain.
1805
1806         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1807
1808         * Scripts/webkitpy/tool/bot/irc_command.py:
1809         (Help):
1810         (Help.execute):
1811         (RollChromiumDEPS.execute):
1812         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1813         (IRCBotTest.test_help):
1814         * Scripts/webkitpy/tool/bot/sheriff.py:
1815         (Sheriff.name):
1816
1817 2013-04-06  Roger Fong  <roger_fong@apple.com>
1818
1819         Kill old processes between runs on WinEWS bots.
1820         Temporarily disable tests to let bots catch up again.
1821
1822         * EWSTools/start-queue-win.sh:
1823         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1824         (WinEWS):
1825
1826 2013-04-09  Glenn Adams  <glenn@skynav.com>
1827
1828         [webkitpy] Remove chromium deprecated port support.
1829         https://bugs.webkit.org/show_bug.cgi?id=114228
1830
1831         Reviewed by Ryosuke Niwa.
1832
1833         * Scripts/webkitpy/common/config/ports.py:
1834         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1835         (ChromiumPort): Removed.
1836         (ChromiumAndroidPort): Removed.
1837         (ChromiumXVFBPort): Removed.
1838         * Scripts/webkitpy/common/config/ports_unittest.py:
1839         (DeprecatedPortTest.test_chromium_port): Removed.
1840         (DeprecatedPortTest.test_chromium_android_port): Removed.
1841         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1842         * Scripts/webkitpy/tool/steps/update_unittest.py:
1843         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1844         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1845
1846 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1847
1848         AX: The bounding paths should be made available through accessibility
1849         https://bugs.webkit.org/show_bug.cgi?id=113817
1850
1851         Reviewed by David Kilzer.
1852
1853         Add a pathDescription property for testing so that it's possible
1854         to verify that a path is being returned correctly.
1855
1856         * DumpRenderTree/AccessibilityUIElement.cpp:
1857         (getPathDescriptionCallback):
1858         (AccessibilityUIElement::pathDescription):
1859         (AccessibilityUIElement::getJSClass):
1860         * DumpRenderTree/AccessibilityUIElement.h:
1861         (AccessibilityUIElement):
1862         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1863         (_CGPathEnumerationIteration):
1864         (AccessibilityUIElement::pathDescription):
1865         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1866         (AccessibilityUIElement::pathDescription):
1867         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1868         (WTR::AccessibilityUIElement::pathDescription):
1869         (WTR):
1870         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1871         (AccessibilityUIElement):
1872         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1873         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1874         (WTR::AccessibilityUIElement::pathDescription):
1875         (WTR):
1876
1877 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1878
1879         [EFL] Declare TEST_THEME_DIR in a single place.
1880         https://bugs.webkit.org/show_bug.cgi?id=114285
1881
1882         Reviewed by Anders Carlsson.
1883
1884         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1885
1886         * DumpRenderTree/efl/CMakeLists.txt:
1887         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1888         (DumpRenderTreeChrome::createView):
1889         (DumpRenderTreeChrome::createInspectorView):
1890         (DumpRenderTreeChrome::initialize):
1891         (DumpRenderTreeChrome::onDownloadRequest):
1892         * EWebLauncher/CMakeLists.txt:
1893         * EWebLauncher/main.c:
1894         (findThemePath):
1895         * EWebLauncher/url_bar.c:
1896         (url_bar_add):
1897         * MiniBrowser/efl/CMakeLists.txt:
1898         * MiniBrowser/efl/main.c:
1899         (window_create):
1900         * TestWebKitAPI/PlatformEfl.cmake:
1901         * TestWebKitAPI/efl/PlatformWebView.cpp:
1902         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1903         * WebKitTestRunner/PlatformEfl.cmake:
1904         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1905         (WTR::PlatformWebView::PlatformWebView):
1906
1907 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1908
1909         [GTK][AC] upversion of clutter and its dependecy
1910         https://bugs.webkit.org/show_bug.cgi?id=114016
1911
1912         Reviewed by Gustavo Noronha Silva.
1913
1914         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1915
1916         * gtk/jhbuild-optional.modules:
1917
1918 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1919
1920         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1921         https://bugs.webkit.org/show_bug.cgi?id=89875
1922
1923         Reviewed by Maciej Stachowiak.
1924
1925         Add unit tests to verify if the handling of the open, openat, creat syscall
1926         is being done right. We check if the Read/Write/ReadAndWrite permissions
1927         are respected, if the canonical path is being resolved and if
1928         the permissions are falling back to the topmost parent directory with a
1929         policy set when the directory being opened has no policy.
1930
1931         We also test if any attempt of blocking SIGSYS is silently ignored.
1932         SIGSYS cannot be blocked because in it's handler is where we hook
1933         syscalls to the broker process.
1934
1935         Also added libseccomp to EFL's jhbuild to make the life of developers
1936         willing to help easier.
1937
1938         * Scripts/webkitperl/FeatureList.pm:
1939         * TestWebKitAPI/PlatformEfl.cmake:
1940         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1941         (TestWebKitAPI):
1942         (SeccompEnvironment):
1943         (TestWebKitAPI::SeccompEnvironment::SetUp):
1944         (TestWebKitAPI::SeccompEnvironment::TearDown):
1945         (TestWebKitAPI::dummyHandler):
1946         (TestWebKitAPI::TEST):
1947         (TestWebKitAPI::stressTest):
1948         * efl/jhbuild.modules:
1949         * qmake/mkspecs/features/features.pri:
1950
1951 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1952
1953         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1954         https://bugs.webkit.org/show_bug.cgi?id=113846
1955
1956         Reviewed by Alexey Proskuryakov.
1957
1958         The problem was that we were replacing NSSpellCheck's dictionary with our own
1959         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1960
1961         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1962         and "would" respectively in DumpRenderTree.
1963
1964         * DumpRenderTree/mac/DumpRenderTree.mm:
1965         (resetDefaultsToConsistentValues):
1966
1967 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1968
1969         Remove the gyp files for Tools
1970         https://bugs.webkit.org/show_bug.cgi?id=114248
1971
1972         Reviewed by Ryosuke Niwa.
1973
1974         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1975         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1976         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1977         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1978         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1979         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1980         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1981         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1982
1983 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1984
1985         WKR (new-commit-bot) is too slow
1986         https://bugs.webkit.org/show_bug.cgi?id=110087
1987
1988         Reviewed by Geoffrey Garen.
1989
1990         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
1991         Just run "svn log -r <revision>" instead to cut down the delay.
1992
1993         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
1994
1995         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1996         (NewCommitBot):
1997         (NewCommitBot.next_work_item):
1998         (NewCommitBot._is_empty_log):
1999         (NewCommitBot._update_checkout):
2000
2001 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2002
2003         Build fix. Can't remove appendCustomBuildFlags.
2004
2005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2006         (appendCustomBuildFlags):
2007
2008 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2009
2010         Remove Chromium builders from build.webkit.org
2011         https://bugs.webkit.org/show_bug.cgi?id=113990
2012
2013         Reviewed by Benjamin Poulain.
2014
2015         Removed.
2016
2017         * BuildSlaveSupport/build.webkit.org-config/config.json:
2018         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2019         (InstallGtkDependencies):
2020         (RunUnitTests.start):
2021         (RunWebKit2Tests.start):
2022         (Factory.__init__):
2023         (unitTestsSupported):
2024         (TestFactory.__init__):
2025         (BuildAndTestFactory.__init__):
2026         (BuildAndPerfTestFactory.__init__):
2027         (BuildAndPerfTestWebKit2Factory.__init__):
2028         (DownloadAndPerfTestFactory.__init__):
2029         (loadBuilderConfig):
2030         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2031
2032 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
2033
2034         Remove HTML Notification
2035         https://bugs.webkit.org/show_bug.cgi?id=114231
2036
2037         Reviewed by Ryosuke Niwa.
2038
2039         * qmake/mkspecs/features/features.pri:
2040
2041 2013-04-08  Glenn Adams  <glenn@skynav.com>
2042
2043         Remove chromium EWS support, and fix broken test.
2044         https://bugs.webkit.org/show_bug.cgi?id=114221
2045
2046         Reviewed by Ryosuke Niwa.
2047
2048         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2049         (AbstractChromiumEWS): Removed.
2050         (ChromiumLinuxEWS): Removed.
2051         (ChromiumLinuxDebugEWS): Removed.
2052         (ChromiumWindowsEWS): Removed.
2053         (ChromiumAndroidEWS): Removed.
2054         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2055         (EarlyWarningSystemTest): Fix misspelled class name.
2056         (test_ewses): Fix entry point name to ensure test is run.
2057
2058 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
2059
2060         [WIN] Remove WebKit2 source code
2061         https://bugs.webkit.org/show_bug.cgi?id=114096
2062
2063         Reviewed by Anders Carlsson.
2064
2065         Remove the windows specific parts of the MiniBrowser.
2066
2067         * MiniBrowser/MiniBrowser.vcproj: Removed.
2068         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
2069         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
2070         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
2071         * MiniBrowser/win/BrowserView.cpp: Removed.
2072         * MiniBrowser/win/BrowserView.h: Removed.
2073         * MiniBrowser/win/BrowserWindow.cpp: Removed.
2074         * MiniBrowser/win/BrowserWindow.h: Removed.
2075         * MiniBrowser/win/MiniBrowser.cpp: Removed.
2076         * MiniBrowser/win/MiniBrowser.h: Removed.
2077         * MiniBrowser/win/MiniBrowser.rc: Removed.
2078         * MiniBrowser/win/main.cpp: Removed.
2079         * MiniBrowser/win/resource.h: Removed.
2080         * MiniBrowser/win/stdafx.cpp: Removed.
2081         * MiniBrowser/win/stdafx.h: Removed.
2082
2083 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2084
2085         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
2086
2087         * Scripts/webkitpy/common/config/irc.py:
2088
2089 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
2090
2091         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
2092         https://bugs.webkit.org/show_bug.cgi?id=113139
2093
2094         Reviewed by Anders Carlsson.
2095
2096         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2097         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2098         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2099         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
2100         (ToStringAndValueOfObject):
2101         (ToStringAndValueOfObject::ToStringAndValueOfObject):
2102         (ScriptableObject):
2103         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
2104         (ToStringAndValueOfObject::ScriptableObject::invoke):
2105         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
2106         (ToStringAndValueOfObject::NPP_GetValue):
2107         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2108         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2109         * GNUmakefile.am:
2110
2111 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
2112
2113         [GTK] Bump gnome-themes-standard to 3.6.0
2114         https://bugs.webkit.org/show_bug.cgi?id=114155
2115
2116         Reviewed by Martin Robinson.
2117
2118         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
2119         dependency of gnome-themes-standard accordingly.
2120
2121 2013-04-08  David Levin  <levin@chromium.org>
2122
2123         Remove my watchlist entries.
2124         https://bugs.webkit.org/show_bug.cgi?id=114180
2125
2126         Reviewed by Adam Barth.
2127
2128         * Scripts/webkitpy/common/config/committers.py:
2129         * Scripts/webkitpy/common/config/watchlist:
2130
2131 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2132
2133         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
2134         https://bugs.webkit.org/show_bug.cgi?id=114161
2135
2136         Reviewed by Gyuyoung Kim.
2137
2138         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
2139         as it is crashing due to Bug 111074.
2140
2141         * TestWebKitAPI/PlatformEfl.cmake:
2142
2143 2013-04-07  David Kilzer  <ddkilzer@apple.com>
2144
2145         Remove the rest of SVG_DOM_OBJC_BINDINGS
2146         <http://webkit.org/b/114112>
2147
2148         Reviewed by Geoffrey Garen.
2149
2150         * Scripts/webkitperl/FeatureList.pm:
2151         - Remove --svg-dom-objc-bindings switch.
2152         * qmake/mkspecs/features/features.pri:
2153         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
2154
2155 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
2156
2157         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
2158         https://bugs.webkit.org/show_bug.cgi?id=114089
2159
2160         Reviewed by Chris Fleizach.
2161
2162         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
2163         * DumpRenderTree/AccessibilityController.cpp:
2164         * DumpRenderTree/AccessibilityUIElement.cpp:
2165         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2166         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2167         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2168         (DumpRenderTreeChrome):
2169
2170 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
2171
2172         Build fix after r147857, remove remaining USE(JSC) guards.
2173
2174         Unreviewed.
2175
2176         * DumpRenderTree/config.h:
2177         * TestWebKitAPI/config.h:
2178         * WebKitTestRunner/config.h:
2179
2180 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2181
2182         Rename sheriffbot to webkitbot
2183         https://bugs.webkit.org/show_bug.cgi?id=114109
2184
2185         Reviewed by Benjamin Poulain.
2186
2187         Renamed since sheriffbot will be used in Blink.
2188
2189         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2190         (SheriffBot):
2191         (SheriffBot.begin_work_queue):
2192
2193 2013-04-06  Oliver Hunt  <oliver@apple.com>
2194
2195         Unify the many and varied stack trace mechanisms, and make the result sane.
2196         https://bugs.webkit.org/show_bug.cgi?id=114072
2197
2198         Reviewed by Filip Pizlo.
2199
2200         The commandline jsc executable no longer requires arguments, so
2201         I've made run-jsc work without them.
2202
2203         * Scripts/run-jsc:
2204
2205 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
2206
2207         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
2208         https://bugs.webkit.org/show_bug.cgi?id=114086
2209
2210         Reviewed by Tim Horton.
2211
2212         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2213
2214 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
2215
2216         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
2217         https://bugs.webkit.org/show_bug.cgi?id=114083
2218
2219         Reviewed by Ryosuke Niwa.
2220
2221         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
2222         in TestWebKitAPI and WebKitTestRunner.
2223
2224         * TestWebKitAPI/config.h:
2225         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2226         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2227         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2228         (WTR::InjectedBundle::platformInitialize):
2229
2230 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
2231
2232         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
2233         https://bugs.webkit.org/show_bug.cgi?id=114094
2234
2235         Reviewed by Anders Carlsson.
2236
2237         * Scripts/run-jsc:
2238
2239 2013-04-05  Ojan Vafai  <ojan@chromium.org>
2240
2241         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
2242         https://bugs.webkit.org/show_bug.cgi?id=114080
2243
2244         Reviewed by Ryosuke Niwa.
2245
2246         This way, the WebKit and Blink dashboard code can change as appropriate without
2247         needing to consider the other project's needs. This still doesn't update the
2248         buildbots to upload to the new location, or the dashboard code to pull the
2249         results.json files from the new location, but it at least allows for changing the
2250         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
2251
2252         * TestResultServer/app.yaml:
2253
2254 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2255
2256         Re-enable testing on the commit queue
2257         https://bugs.webkit.org/show_bug.cgi?id=114078
2258
2259         Reviewed by Darin Adler.
2260
2261         Re-enabled the feature and the associated tests.
2262
2263         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2264         (CommitQueueTask.run):
2265         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2266         (CommitQueueTaskTest._run_through_task):
2267         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2268         (CommitQueueTest._mock_test_result):
2269
2270 2013-04-05  Oliver Hunt  <oliver@apple.com>
2271
2272         Unify the many and varied stack trace mechanisms, and make the result sane.
2273         https://bugs.webkit.org/show_bug.cgi?id=114072
2274
2275         Reviewed by Filip Pizlo.
2276
2277         The commandline jsc executable no longer requires arguments, so
2278         I've made run-jsc work without them.
2279
2280         * Scripts/run-jsc:
2281
2282 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2283
2284         AX: Make SVG Group containers accessible elements
2285         https://bugs.webkit.org/show_bug.cgi?id=113939
2286
2287         Reviewed by Simon Fraser.
2288
2289         Implement axController.elementAtPoint for iOS.
2290         Implement a correct version of clickPoint for iOS.
2291
2292         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2293         (AccessibilityController::elementAtPoint):
2294         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2295         (AccessibilityUIElement::clickPointX):
2296         (AccessibilityUIElement::clickPointY):
2297
2298 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2299
2300         Unreviewed, rolling out r147773 and r147774.
2301         http://trac.webkit.org/changeset/147773
2302         http://trac.webkit.org/changeset/147774
2303         https://bugs.webkit.org/show_bug.cgi?id=114056
2304
2305         Causing some exceptions on AppEngine I don't understand
2306         (Requested by rniwa on #webkit).
2307
2308         * QueueStatusServer/config/queues.py:
2309         * QueueStatusServer/model/queues.py:
2310         (Queue.short_name):
2311         (Queue.display_name):
2312         * QueueStatusServer/model/queues_unittest.py:
2313         (QueueTest.test_short_name):
2314         (QueueTest.test_display_name):
2315         (QueueTest.test_name_with_underscores):
2316
2317 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
2318
2319         Fixed run-bindings-tests by removing V8
2320         https://bugs.webkit.org/show_bug.cgi?id=114053
2321
2322         Reviewed by Benjamin Poulain.
2323
2324         * Scripts/run-bindings-tests:
2325         (main):
2326
2327 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2328
2329         Build fix.
2330
2331         * QueueStatusServer/model/queues.py:
2332         (Queue.short_name):
2333         (Queue.display_name):
2334
2335 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2336
2337         Remove Chromium EWS bots from the queue status server
2338         https://bugs.webkit.org/show_bug.cgi?id=113988
2339
2340         Reviewed by Benjamin Poulain.
2341
2342         Removed Chromium EWS bots.
2343
2344         * QueueStatusServer/config/queues.py:
2345         * QueueStatusServer/model/queues.py:
2346         (Queue.short_name):
2347         (Queue.display_name):
2348         * QueueStatusServer/model/queues_unittest.py:
2349         (QueueTest.test_short_name):
2350         (QueueTest.test_display_name):
2351         (QueueTest.test_name_with_underscores):
2352
2353 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2354
2355         [EFL] Enable indexed database
2356         https://bugs.webkit.org/show_bug.cgi?id=107248
2357
2358         Reviewed by Alexis Menard.
2359
2360         * Scripts/webkitperl/FeatureList.pm:
2361
2362 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
2363
2364         Remove vestiges of Chromium bits from watchlists.
2365         https://bugs.webkit.org/show_bug.cgi?id=114047
2366
2367         Reviewed by Ryosuke Niwa.
2368
2369         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
2370
2371 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2372
2373         Add James Craig to the contributors list.
2374
2375         * Scripts/webkitpy/common/config/committers.py:
2376
2377 2013-04-04  Kent Tamura  <tkent@chromium.org>
2378
2379         Remove ChromiumPublicApi pattern, and cc/message rules for it.
2380
2381         * Scripts/webkitpy/common/config/watchlist:
2382
2383 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2384
2385         Temporarily disable the Python unittests broken by the commit queue not running layout tests
2386         https://bugs.webkit.org/show_bug.cgi?id=113997
2387
2388         Reviewed by Ryosuke Niwa.
2389
2390         Disable the tests until Ryosuke gets the time and hardware to have
2391         a testing commit-queue.
2392
2393         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2394         (CommitQueueTaskTest):
2395         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2396         (CommitQueueTest):
2397
2398 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2399
2400         Remove Chromium builders from build.webkit.org
2401         https://bugs.webkit.org/show_bug.cgi?id=113990
2402
2403         Reviewed by Benjamin Poulain.
2404
2405         Land the part to disable triggering of Chromium builders first so that we may start
2406         deleting more Chromium code that breaks the update step.
2407
2408         * BuildSlaveSupport/build.webkit.org-config/config.json:
2409
2410 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2411
2412         Remove Chromium's DumpRenderTree
2413         https://bugs.webkit.org/show_bug.cgi?id=113989
2414
2415         Reviewed by Kent Tamura.
2416
2417         On second thought, let's not go to Camelot. It is a silly place.
2418
2419         * DumpRenderTree/mac/DumpRenderTree.mm:
2420         (resetDefaultsToConsistentValues):
2421
2422 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
2423
2424         Nixed the defunct chromium folder from DumpRenderTree
2425         https://bugs.webkit.org/show_bug.cgi?id=113993
2426
2427         Reviewed by Ryosuke Niwa.
2428
2429         * DumpRenderTree/chromium: Removed.
2430         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
2431         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
2432         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
2433         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
2434         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
2435         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
2436         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
2437         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
2438         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
2439         * DumpRenderTree/chromium/MockPlatform.h: Removed.
2440         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
2441         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
2442         * DumpRenderTree/chromium/Task.cpp: Removed.
2443         * DumpRenderTree/chromium/Task.h: Removed.
2444         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
2445         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
2446         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
2447         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
2448         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
2449         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
2450         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
2451         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2452         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2453         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2454         * DumpRenderTree/chromium/TestRunner: Removed.
2455         * DumpRenderTree/chromium/TestRunner/public: Removed.
2456         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
2457         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
2458         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
2459         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
2460         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
2461         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
2462         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
2463         * DumpRenderTree/chromium/TestRunner/src: Removed.
2464         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
2465         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
2466         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
2467         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
2468         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
2469         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
2470         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
2471         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
2472         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
2473         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
2474         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
2475         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
2476         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2477         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2478         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
2479         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
2480         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
2481         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
2482         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
2483         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
2484         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
2485         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
2486         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
2487         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
2488         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
2489         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
2490         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
2491         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
2492         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
2493         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
2494         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
2495         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
2496         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
2497         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
2498         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
2499         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
2500         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
2501         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
2502         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
2503         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
2504         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2505         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2506         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2507         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2508         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2509         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2510         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2511         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2512         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2513         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2514         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2515         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2516         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2517         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2518         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2519         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2520         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2521         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2522         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2523         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2524         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2525         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2526         * DumpRenderTree/chromium/TestShell.h: Removed.
2527         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2528         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2529         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2530         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2531         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2532         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2533         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2534         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2535         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2536         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2537         * DumpRenderTree/chromium/config.h: Removed.
2538         * DumpRenderTree/chromium/fonts.conf: Removed.
2539
2540 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2543
2544         Rubber stamped by Benjamin Poulain.
2545
2546         * RebaselineQueueServer: Removed.
2547         * RebaselineQueueServer/app.yaml: Removed.
2548         * RebaselineQueueServer/handlers: Removed.
2549         * RebaselineQueueServer/handlers/__init__.py: Removed.
2550         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2551         * RebaselineQueueServer/handlers/pages.py: Removed.
2552         * RebaselineQueueServer/index.yaml: Removed.
2553         * RebaselineQueueServer/main.py: Removed.
2554         * RebaselineQueueServer/model: Removed.
2555         * RebaselineQueueServer/model/__init__.py: Removed.
2556         * RebaselineQueueServer/model/queueentry.py: Removed.
2557         * RebaselineQueueServer/static: Removed.
2558         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2559         * RebaselineQueueServer/static/styles.css: Removed.
2560         * RebaselineQueueServer/templates: Removed.
2561         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2562         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2563         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2564         * RebaselineQueueServer/templates/home.html: Removed.
2565
2566 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2567
2568         Fix setup-commit-queue and temporarily disable testing on commit-queue
2569         https://bugs.webkit.org/show_bug.cgi?id=113979
2570
2571         Reviewed by Benjamin Poulain.
2572
2573         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2574         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2575
2576         * EWSTools/setup-commit-queue.sh:
2577         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2578         (CommitQueueTask.run):
2579
2580 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2581
2582         temporarily make flakiness dashboard work again webkit.org bots
2583         https://bugs.webkit.org/show_bug.cgi?id=113972
2584
2585         Reviewed by Ojan Vafai.
2586
2587         This patch disables the chromium.org layout test bots TestExpectations
2588         parsing temporarily until we can work out the right way to split into
2589         two instances for webkit.org and chromium.org and figure out which
2590         code to delete where :).
2591
2592         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2593
2594 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2595
2596         Fix webkitpy tests after r147678.
2597
2598         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2599         (CommitQueueTest.test_commit_queue):
2600         (test_manual_reject_during_processing):
2601
2602 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2603
2604         The commit queue should use Mac MountainLion port
2605         https://bugs.webkit.org/show_bug.cgi?id=113971
2606
2607         Reviewed by Lucas Forschler.
2608
2609         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2610         * Scripts/webkitpy/tool/commands/queues.py:
2611         (CommitQueue):
2612
2613 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2614
2615         turn off running tests on chromium linux EWS bots
2616         https://bugs.webkit.org/show_bug.cgi?id=113959
2617
2618         Reviewed by Geoffrey Garen.
2619
2620         Now that the Chromium port is no longer being maintained
2621         there's little point in running the tests. Soon we should
2622         just shut this bot off altogether.
2623
2624         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2625         (ChromiumLinuxEWS):
2626
2627 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2628
2629         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2630
2631         * Scripts/webkitpy/common/config/watchlist:
2632
2633 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2634
2635         Indentation fix to get webkit-patch working again after r147625
2636
2637         Unreviewed.
2638
2639         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2640         (MacEWS):
2641         (MacWK2EWS):
2642
2643 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2644
2645         Turn tests back on for Mac WK1/WK2 EWS.
2646         
2647         Unreviewed.
2648         
2649         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2650         (MacEWS):
2651         (MacWK2EWS):
2652
2653 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2654
2655         [GTK][WK2] MiniBrowser custom URI scheme support
2656         https://bugs.webkit.org/show_bug.cgi?id=112419
2657
2658         Reviewed by Carlos Garcia Campos.
2659
2660         Add support for about URIs in MiniBrowser. An example about page is show
2661         with URI "about:minibrowser", the rest of the cases it will show a
2662         proper message explaining that the about page didn't exist.
2663
2664         Internally it uses "minibrowser-about" prefix instead of "about", but
2665         from the user point of view it works with "about" prefix.
2666
2667         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2668         (getInternalURI): Method to convert URIs from "about" prefix to
2669         "minibrowser-about".
2670         (getExternalURI): Opposite method.
2671         (webViewURIChanged): Use "about" prefix to show the URI to users.
2672         (webViewEnterFullScreen): Ditto.
2673         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2674         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2675         (aboutURISchemeRequestCallback): Callback to manage about calls.
2676         (main): Register the URI scheme to manage about URIs.
2677
2678 2013-04-03  Roger Fong  <roger_fong@apple.com>
2679
2680         Re-enable WinEWS tests.
2681
2682         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2683         (WinEWS):
2684
2685 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2686
2687         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2688         https://bugs.webkit.org/show_bug.cgi?id=113883
2689
2690         Reviewed by Martin Robinson.
2691
2692         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2693         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2694         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2695
2696 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2697
2698         [GTK] Include Pango in jhbuild-optional.modules
2699         https://bugs.webkit.org/show_bug.cgi?id=113878
2700
2701         Reviewed by Martin Robinson.
2702
2703         Since r147547 Pango 1.32.0 is required. Including the module in the
2704         JHBuild optional moduleset.
2705
2706         * gtk/jhbuild-optional.modules: Add Pango module.
2707
2708 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2709
2710         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2711         https://bugs.webkit.org/show_bug.cgi?id=113864
2712
2713         Moving setDefersLoading from TestRunnerQt to TestRunner
2714         requires access to the non-Qt TestRunner.
2715         As long as we instantiate both TestRunner and TestRunnerQt,
2716         we need a separate getter for the non-Qt TestRunner instance.
2717
2718         Reviewed by Simon Hausmann.
2719
2720         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2721         (WebPage::resetSettings):
2722         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2723         (DumpRenderTree::jscTestRunner):
2724         * DumpRenderTree/qt/TestRunnerQt.cpp:
2725         (TestRunner::setDefersLoading):
2726             Moving setDefersLoading from TestRunnerQt
2727             to TestRunner.
2728         * DumpRenderTree/qt/TestRunnerQt.h:
2729         (TestRunnerQt):
2730
2731 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2732
2733         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2734         https://bugs.webkit.org/show_bug.cgi?id=104779
2735
2736         Reviewed by Carlos Garcia Campos.
2737
2738         * Scripts/run-gtk-tests:
2739         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2740         passing in current trunk.
2741
2742 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2743
2744         Fix HAVE(QTTESTSUPPORT) logic
2745
2746         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2747         resulting in HAVE(QTTESTSUPPORT) never being true.
2748         Move that logic down in sanitizeFeatures.
2749
2750         Rubber-stamped by Tor Arne Vestbø.
2751
2752         * qmake/mkspecs/features/features.prf:
2753
2754 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2755
2756         [GTK] Bump required versions of some dependencies
2757         https://bugs.webkit.org/show_bug.cgi?id=113282
2758
2759         Reviewed by Martin Robinson.
2760
2761         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2762
2763 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2764
2765         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2766         https://bugs.webkit.org/show_bug.cgi?id=113809
2767
2768         Reviewed by Philippe Normand.
2769
2770         Newer Linux kernels have removed some deprecated macros from v4l2
2771         headers, causing gst-plugins-good's build to break. We don't need it
2772         right now, so just disable it.
2773
2774         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2775
2776 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2777
2778         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2779         https://bugs.webkit.org/show_bug.cgi?id=113535
2780
2781         Reviewed by Simon Hausmann.
2782
2783         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2784
2785         * qmake/mkspecs/features/features.prf:
2786
2787 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2788
2789         [Qt] Move logic of simple forwarding functions to TestRunner.
2790         https://bugs.webkit.org/show_bug.cgi?id=113863
2791
2792         Reviewed by Simon Hausmann.
2793
2794         * DumpRenderTree/qt/TestRunnerQt.cpp:
2795         (TestRunner::setTextDirection):
2796         (TestRunner::goBack):
2797         (TestRunner::evaluateScriptInIsolatedWorld):
2798         (TestRunner::addUserStyleSheet):
2799         * DumpRenderTree/qt/TestRunnerQt.h:
2800         (TestRunnerQt):
2801
2802 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2803
2804         [Qt] Disable media support using QuickTime if deployment target != SDK
2805
2806         We link to a single libWebKitSystemInterface static lib, so unless the
2807         deployment target matches the SDK let's not pretend like we'll be able
2808         to run on anything lower than the SDK version.
2809
2810         Reviewed by Simon Hausmann.
2811
2812         * qmake/mkspecs/features/features.prf:
2813
2814 2013-04-02  James Craig  <james@cookiecrook.com>
2815
2816         AXRoleDescripton for DL is "list"; should be "description list"
2817         https://bugs.webkit.org/show_bug.cgi?id=111665
2818
2819         Reviewed by Chris Fleizach.
2820
2821         Defining the role and description strings.
2822
2823         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2824
2825 2013-04-02  Roger Fong  <roger_fong@apple.com>
2826
2827         Unreviewed. Disable running tests on Win EWS queue.
2828
2829         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2830         (WinEWS):
2831
2832 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2833
2834         Disable running tests on the MAC WK2 EWS queue.
2835         
2836         Unreviewed.
2837         
2838         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2839         (MacWK2EWS):
2840
2841 2013-04-02  Julie Parent  <jparent@chromium.org>
2842
2843         Dashboard refactor: Move dashboard specific history related features to History.
2844         https://bugs.webkit.org/show_bug.cgi?id=113717
2845
2846         Reviewed by Ojan Vafai.
2847         
2848         Each dashboard now creates its own History object, with a custom
2849         configuration. This changes from just overriding global functions
2850         to passing in callbacks for generatePage, handleValidHashParameter,
2851         and handleQueryParameterChange. Same with passing in defaultStateValues
2852         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2853         variables.
2854         
2855         All functions related to these features are now (mostly) private
2856         function on History. 
2857         
2858         Loader no longer needs a loadingComplete callback, since it can just
2859         initialize the history object itself.
2860
2861         * TestResultServer/static-dashboards/aggregate_results.js:
2862         (handleValidHashParameter):
2863         * TestResultServer/static-dashboards/dashboard_base.js:
2864         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2865         (generatePage):
2866         (.switch.return):
2867         (handleQueryParameterChange):
2868         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2869         (resetGlobals):
2870         * TestResultServer/static-dashboards/history.js:
2871         (.):
2872         * TestResultServer/static-dashboards/loader.js:
2873         (.):
2874         * TestResultServer/static-dashboards/loader_unittests.js:
2875         * TestResultServer/static-dashboards/timeline_explorer.js:
2876         (generatePage):
2877         (initCurrentBuilderTestResults):
2878         * TestResultServer/static-dashboards/treemap.js:
2879         (generatePage):
2880         (.switch.return):
2881         (handleQueryParameterChange):
2882
2883 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2884
2885         Unreviewed, rolling out r147401.
2886         http://trac.webkit.org/changeset/147401
2887         https://bugs.webkit.org/show_bug.cgi?id=113767
2888
2889         The patch makes it extremely hard to set up the dependencies
2890         properly on the GTK builders (Requested by zdobersek on
2891         #webkit).
2892
2893         * gtk/jhbuild.modules:
2894
2895 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2896
2897         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2898         https://bugs.webkit.org/show_bug.cgi?id=113382
2899
2900         Reviewed by Gyuyoung Kim.
2901
2902         Do not show the empty tooltip box if the text is null.
2903
2904         * MiniBrowser/efl/main.c:
2905         (popup_menu_populate):
2906
2907 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2908
2909         [GTK] Bump required versions of some dependencies
2910         https://bugs.webkit.org/show_bug.cgi?id=113282
2911
2912         Reviewed by Martin Robinson.
2913
2914         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2915
2916 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2917
2918         Unreviewed, rolling out r147319.
2919         http://trac.webkit.org/changeset/147319
2920         https://bugs.webkit.org/show_bug.cgi?id=113707
2921
2922         The unit test is still failing on the buildbot (Requested by
2923         zdobersek on #webkit).
2924
2925         * Scripts/run-gtk-tests:
2926         (TestRunner):
2927
2928 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2929
2930         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2931         https://bugs.webkit.org/show_bug.cgi?id=104779
2932
2933         Reviewed by Carlos Garcia Campos.
2934
2935         * Scripts/run-gtk-tests:
2936         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2937         passing in current trunk.
2938
2939 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2940
2941         Unreviewed, rolling out r147289.
2942         http://trac.webkit.org/changeset/147289
2943         https://bugs.webkit.org/show_bug.cgi?id=113678
2944
2945         broke Win7 (dbg) build (Requested by shinyak|gardener on
2946         #webkit).
2947
2948         * DumpRenderTree/DumpRenderTree.gypi:
2949         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2950         (WebTestRunner):
2951         (WebUserMediaClientMock):
2952         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2953         (WebTestRunner::WebUserMediaClientMock::taskList):
2954         * Scripts/webkitpy/style/checkers/cpp.py:
2955         (check_function_definition):
2956
2957 2013-03-31  Adam Barth  <abarth@webkit.org>
2958
2959         configure-svn-config.sh fails
2960         https://codereview.chromium.org/13392007/
2961
2962         Reviewed by Eric Seidel.
2963
2964         This script was trying to use "svn checkout" to dowload a file from
2965         svn.webkit.org, but "svn checkout" only works with directories.
2966         Instead, we should use "svn export".
2967
2968         * EWSTools/configure-svn-config.sh:
2969
2970 2013-03-31  Wei Jia  <wjia@chromium.org>
2971
2972         Allow WebUserMediaClientMock to be used by client
2973         https://bugs.webkit.org/show_bug.cgi?id=113633
2974
2975         Reviewed by Adam Barth.
2976
2977         Export WebUserMediaClientMock.
2978         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2979
2980         * DumpRenderTree/DumpRenderTree.gypi:
2981         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2982         (WebUserMediaClientMock):
2983         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2984         * Scripts/webkitpy/style/checkers/cpp.py:
2985         (check_function_definition):
2986
2987 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
2988
2989         Expose FeatureObserver data to WebKit clients
2990         https://bugs.webkit.org/show_bug.cgi?id=113613
2991
2992         Reviewed by Sam Weinig.
2993
2994         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2995         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
2996
2997 2013-03-29  Greg Hughes  <ghughes@apple.com>
2998
2999         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
3000         https://bugs.webkit.org/show_bug.cgi?id=112276
3001
3002         Reviewed by Chris Fleizach.
3003
3004         Added support to test accessibility search predicates with multiple keys.  
3005
3006         * DumpRenderTree/AccessibilityUIElement.cpp:
3007         (uiElementForSearchPredicateCallback):
3008         * DumpRenderTree/AccessibilityUIElement.h:
3009         (AccessibilityUIElement):
3010         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3011         (AccessibilityUIElement::uiElementForSearchPredicate):
3012         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3013         (AccessibilityUIElement::uiElementForSearchPredicate):
3014         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3015         (AccessibilityUIElement::uiElementForSearchPredicate):
3016         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3017         (AccessibilityUIElement::uiElementForSearchPredicate):
3018         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3019         (AccessibilityUIElement::uiElementForSearchPredicate):
3020         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3021         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3022         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3023         (AccessibilityUIElement):
3024         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3025         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3026         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3027         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3028         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3029
3030 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
3031
3032         Fix a typo in r147147 to fix Mac EWS.
3033
3034         * Scripts/webkitpy/tool/commands/queues.py:
3035         (PatchProcessingQueue._new_port_name_from_old):
3036
3037 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
3038
3039         [EFL] Build break with latest EFL libraries after r146265
3040         https://bugs.webkit.org/show_bug.cgi?id=113558
3041
3042         Unreviewed build fix.
3043
3044         * TestWebKitAPI/PlatformWebView.h:
3045         * WebKitTestRunner/PlatformWebView.h:
3046
3047 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3048
3049         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
3050
3051         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
3052         in libgcrypt build.
3053
3054 2013-03-28  Lucas Forschler  <lforschler@apple.com>
3055
3056         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
3057
3058         Unreviewed.
3059
3060         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3061         (MacEWS):
3062
3063 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         Use the right OS name on Mac EWS instead of mac-future.
3066
3067         Rubber-stamped by Dirk Pranke.
3068
3069         * Scripts/webkitpy/tool/commands/queues.py:
3070         (PatchProcessingQueue._new_port_name_from_old):
3071         (PatchProcessingQueue.begin_work_queue):
3072         (PatchProcessingQueue._upload_results_archive_for_patch):
3073
3074 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
3075
3076         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
3077         https://bugs.webkit.org/show_bug.cgi?id=112546
3078
3079         Reviewed by Martin Robinson.
3080
3081         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
3082         moved back to Source/WebCore/platform. Fix an indentation issue as well.
3083
3084 2013-03-28  Ming Xie  <mxie@blackberry.com>
3085
3086         [BlackBerry] Committer Email Updates
3087         https://bugs.webkit.org/show_bug.cgi?id=113435
3088
3089         Reviewed by Rob Buis.
3090
3091         Add the @blackberry.com email address for all our BlackBerry
3092         WebKit committers. This is the first step for our email address
3093         migration.
3094
3095         * Scripts/webkitpy/common/config/committers.py:
3096
3097 2013-03-28  Philippe Normand  <pnormand@igalia.com>
3098
3099         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
3100         https://bugs.webkit.org/show_bug.cgi?id=113508
3101
3102         Reviewed by Martin Robinson.
3103
3104         Prevent the GStreamer plugin scanner to load system-wide
3105         plugins. Only the ones built in JHBuild should be loaded and used
3106         at runtime.
3107
3108         * efl/jhbuildrc:
3109         * gtk/jhbuildrc:
3110
3111 2013-03-27  Philippe Normand  <pnormand@igalia.com>
3112
3113         [GTK] run-launcher --gtk -2 fails on a WK2-only build
3114         https://bugs.webkit.org/show_bug.cgi?id=113386
3115
3116         Reviewed by Carlos Garcia Campos.
3117
3118         * Scripts/webkitdirs.pm:
3119         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
3120         version to 3.0. Reflect this change so the builtDylibPathForName
3121         function doesn't fail to report the library as found.
3122
3123 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
3124
3125         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
3126         https://bugs.webkit.org/show_bug.cgi?id=113484
3127
3128         Unreviewed build fix.
3129
3130         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
3131
3132         * TestWebKitAPI/CMakeLists.txt:
3133         * WebKitTestRunner/CMakeLists.txt:
3134
3135 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3136
3137         Revision for the internal jhbuild is too old
3138         https://bugs.webkit.org/show_bug.cgi?id=113324
3139
3140         Reviewed by Martin Robinson.
3141
3142         Update the minimum required version to a point where jhbuild won't
3143         fail installing packages when trying to remove a symlink to a directory.
3144
3145         * jhbuild/jhbuild-wrapper: Updated revision.
3146
3147 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3148
3149         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
3150         https://bugs.webkit.org/show_bug.cgi?id=113203
3151
3152         Reviewed by Philippe Normand.
3153
3154         We build our libsoup without GNOME support. gst-plugins-good does separate
3155         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
3156         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
3157         build failures as the headers of those diverge. We do not use souphttpsrc, so
3158         disable it when building gst-plugins-good.
3159
3160         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
3161
3162 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
3163
3164         Build fix after r146852. Please another reference to the Lion leaks builder.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/config.json:
3167
3168 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
3169
3170         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
3171         https://bugs.webkit.org/show_bug.cgi?id=113421
3172
3173         Reviewed by Dirk Pranke.
3174
3175         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
3176         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
3177         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
3178         in the GTK-specific TestExpectations files.
3179
3180         To avoid this only enable the warnings only when not using WKTR.
3181
3182         * Scripts/webkitpy/layout_tests/port/gtk.py:
3183         (GtkPort.warn_if_bug_missing_in_test_expectations):
3184
3185 2013-03-27  Antti Koivisto  <antti@apple.com>
3186
3187         Fix Zalan's email.
3188
3189         * Scripts/webkitpy/common/config/committers.py:
3190
3191 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3192
3193         master.cfg cleanup
3194         https://bugs.webkit.org/show_bug.cgi?id=113195
3195
3196         Reviewed by Ryosuke Niwa.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/config.json:
3199         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3200
3201 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3202
3203         master.cfg fine-tuning for Qt Mountain Lion Release bot
3204         https://bugs.webkit.org/show_bug.cgi?id=113191
3205
3206         Reviewed by Ryosuke Niwa.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/config.json:
3209           - Rename the slave due to its location change.
3210           - Update the platform of the slave.
3211         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3212         (RunQtAPITests): Enable running WK2 API tests on Qt.
3213         (RunQtAPITests.start):
3214         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
3215         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
3216
3217 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3218
3219         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
3220         https://bugs.webkit.org/show_bug.cgi?id=113403
3221
3222         Reviewed by Kenneth Rohde Christiansen.
3223
3224         As of Evas 1.7.5, when Wayland is detected on the system, support for
3225         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
3226         The code, however, seems to depend on a few other flags which must be
3227         explicitly enabled.
3228
3229         If those additional GL-related options are passed, we end up
3230         having issues on the WebKit side, so disable Wayland support for
3231         now.
3232
3233         * efl/jhbuild.modules:
3234
3235 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3236
3237         Unreviewed, rolling out r146864.
3238         http://trac.webkit.org/changeset/146864
3239         https://bugs.webkit.org/show_bug.cgi?id=113391
3240
3241         causes crashes on Wk2 EFL release bot (Requested by drott on
3242         #webkit).
3243
3244         * Scripts/webkitperl/FeatureList.pm:
3245
3246 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3247
3248         [jhbuild] Correctly specify an alternate number of make jobs.
3249         https://bugs.webkit.org/show_bug.cgi?id=113396
3250
3251         Reviewed by Philippe Normand.
3252
3253         So far, we were using the `MAKEFLAGS' environment variable to pass the
3254         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
3255         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
3256
3257         We now behave more closely to the rest of the WebKit tools by first
3258         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
3259         not set, just letting jhbuild itself figure out how many jobs to use.
3260
3261         * efl/jhbuildrc:
3262         * gtk/jhbuildrc:
3263
3264 2013-03-27  Zeno Albisser  <zeno@webkit.org>
3265
3266         [Qt] Remove Qt specific WorkQueueItem definitions.
3267         https://bugs.webkit.org/show_bug.cgi?id=112891
3268
3269         This patch is preparation work for removing
3270         WorkQueue related code from TestRunnerQt and
3271         replacing it with generic TestRunner code.
3272
3273         Reviewed by Benjamin Poulain.
3274
3275         * DumpRenderTree/qt/TestRunnerQt.cpp:
3276         (TestRunnerQt::queueBackNavigation):
3277         (TestRunnerQt::queueForwardNavigation):
3278         (TestRunnerQt::queueLoadHTMLString):
3279         (TestRunnerQt::queueReload):
3280         (TestRunnerQt::queueLoadingScript):
3281         (TestRunnerQt::queueNonLoadingScript):
3282         (TestRunner::queueLoad):
3283         * DumpRenderTree/qt/TestRunnerQt.h:
3284         (TestRunnerQt):
3285         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3286         (LoadItem::invoke):
3287         (LoadHTMLStringItem::invoke):
3288         (LoadAlternateHTMLStringItem::invoke):
3289         (ReloadItem::invoke):
3290         (ScriptItem::invoke):
3291         (BackForwardItem::invoke):
3292         * DumpRenderTree/qt/WorkQueueItemQt.h:
3293         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3294         (LoadAlternateHTMLStringItem):
3295
3296 2013-03-26  Julie Parent  <jparent@chromium.org>
3297
3298         Flakiness dashboard: simplify logic around which tests to show.
3299         https://bugs.webkit.org/show_bug.cgi?id=113250
3300
3301         Reviewed by Ojan Vafai.
3302         
3303         The different filters for showing results are only used for layout
3304         tests, otherwise, we show everything.
3305         
3306         Change the defaults to false (what layout tests used), and only
3307         look at the values when viewing layout tests.
3308
3309         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3310         (htmlForTestsWithExpectationsButNoFailures):
3311         (shouldHideTest):
3312
3313 2013-03-26  Isaac Levy  <ilevy@google.com>
3314
3315         Update bots on test-results.appspot
3316         https://bugs.webkit.org/show_bug.cgi?id=113333
3317
3318         Reviewed by Ojan Vafai.
3319
3320         * TestResultServer/static-dashboards/builders.jsonp:
3321
3322 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3323
3324         Unreviewed GTK gardening.
3325
3326         * Scripts/run-gtk-tests:
3327         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
3328
3329 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3330
3331         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
3332         https://bugs.webkit.org/show_bug.cgi?id=113287
3333
3334         Reviewed by Jocelyn Turcotte.
3335
3336         * Scripts/run-qtwebkit-tests:
3337         (Options.__init__):
3338
3339 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
3340
3341         [EFL] Enable IndexedDB by default
3342         https://bugs.webkit.org/show_bug.cgi?id=107248
3343
3344         Reviewed by Laszlo Gombos.
3345
3346         * Scripts/webkitperl/FeatureList.pm:
3347         Enable IndexedDB by default on EFL.
3348
3349 2013-03-26  Alan Cutter  <alancutter@chromium.org>
3350
3351         Sheriffbot should explain rollout failures in a human readable form.
3352         https://bugs.webkit.org/show_bug.cgi?id=107092
3353
3354         Reviewed by Ryosuke Niwa.
3355
3356         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
3357
3358         * Scripts/webkitpy/tool/bot/irc_command.py:
3359         (Rollout._check_diff_failure):
3360         (Rollout.execute):
3361         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3362         (IRCCommandTest.test_rollout):
3363
3364 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3365
3366         Unreviewed GTK gardening.
3367
3368         * Scripts/run-gtk-tests:
3369         (TestRunner): Skipping a failing unit test after r146518.
3370
3371 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3372
3373         Remove Lion leaks builder
3374         https://bugs.webkit.org/show_bug.cgi?id=113252
3375
3376         Reviewed by Andreas Kling.
3377
3378         Removed.
3379
3380         * BuildSlaveSupport/build.webkit.org-config/config.json:
3381
3382 2013-03-25  Kent Tamura  <tkent@chromium.org>
3383
3384         Rename ENABLE_INPUT_TYPE_DATETIME
3385         https://bugs.webkit.org/show_bug.cgi?id=113254
3386
3387         Reviewed by Kentaro Hara.
3388
3389         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
3390         Actually I'd like to remove the code, but we shouldn't remove it yet
3391         because we shipped products with it on some platforms.
3392
3393         * Scripts/webkitperl/FeatureList.pm:
3394         * qmake/mkspecs/features/features.pri:
3395
3396 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3397
3398         Remove one more line that was intended to be removed in r146657.
3399
3400         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3401         (summarize_results):
3402
3403 2013-03-25  Roger Fong  <roger_fong@apple.com>
3404
3405         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
3406         Re-enable WinEWS tests.
3407
3408         * Scripts/webkitpy/common/config/ports.py:
3409         (WinPort.run_bindings_tests_command):
3410         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3411         (WinEWS):
3412
3413 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3414
3415         Unreviewed, rolling out r146793.
3416         http://trac.webkit.org/changeset/146793
3417         https://bugs.webkit.org/show_bug.cgi?id=113248
3418
3419         Fix did not work (Requested by rfong on #webkit).
3420
3421         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3422         (WinEWS):
3423
3424 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3425
3426         REGRESSION(r146657): Test failures reported incorrectly
3427         https://bugs.webkit.org/show_bug.cgi?id=113223
3428
3429         Reviewed by Dirk Pranke.
3430
3431         The bug was caused by BuildBotPrinter not taking the new behavior into account.
3432
3433         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
3434         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
3435
3436         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3437         (Manager.run):
3438
3439         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3440         (RunDetails.__init__):
3441         (summarize_results): Remove the line I intended to remove in r146657.
3442
3443         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3444         (logging_run): Return details instead of the exit code.
3445         (run_and_capture): Ditto.
3446
3447         (RunTest.test_full_results_html):
3448         (RunTest.test_hung_thread):
3449         (RunTest.test_no_tests_found):
3450         (RunTest.test_no_tests_found_2):
3451         (RunTest.test_repeat_each_iterations_num_tests):
3452         (RunTest.test_run_singly_actually_runs_tests):
3453         (RunTest.test_test_list):
3454         (RunTest.test_missing_and_unexpected_results):
3455         (RunTest.test_pixel_test_directories):
3456         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
3457         (RunTest.test_crash_with_stderr):
3458         (RunTest.test_no_image_failure_with_image_diff):
3459         (RunTest.test_crash_log):
3460         (RunTest.test_exit_after_n_failures_upload):
3461         (RunTest.test_results_directory_absolute):
3462         (RunTest.test_results_directory_relative):
3463         (RunTest.test_retrying_and_flaky_tests):
3464         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
3465         (RunTest.test_retrying_uses_retries_directory):
3466         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3467         (RunTest.test_output_diffs):
3468         (EndToEndTest.test_reftest_with_two_notrefs):
3469         (RebaselineTest.test_reset_results):
3470         (RebaselineTest.test_missing_results):
3471         (RebaselineTest.test_new_baseline):
3472
3473         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3474         (BuildBotPrinter.print_results):
3475         (BuildBotPrinter.print_unexpected_results):
3476         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
3477         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
3478
3479 2013-03-25  Julie Parent  <jparent@chromium.org>
3480
3481         Dashboard refactor: Move cross dashboard history related code into history.js.
3482         https://bugs.webkit.org/show_bug.cgi?id=113104
3483
3484         Reviewed by Ojan Vafai.
3485
3486         All functions relating to cross dashboard behavior move from being
3487         globals to methods on the history.History object. Names stay the same,
3488         except many are made private, ones that should have been constants now
3489         are, and the long standing TODO to change "currentState" to 
3490         dashboardSpecificState is done.
3491         
3492         We now create a global history object in dashboard_base, as an 
3493         intermediate measure.  Once the dashboard specific code is
3494         added to history, each DB will need to create its own, and this
3495         global will be eliminated.
3496         
3497         * TestResultServer/static-dashboards/aggregate_results.js:
3498         (handleValidHashParameter):
3499         (htmlForBuilder):
3500         (rawValuesHTML):
3501         * TestResultServer/static-dashboards/dashboard_base.js:
3502         (parseDashboardSpecificParameters):
3503         (defaultValue):
3504         (currentBuilderGroupCategory):
3505         (currentBuilderGroupName):
3506         (handleLocationChange):
3507         (expectationsMap):
3508         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3509         (generatePage):
3510         (.switch.return):
3511         (platformAndBuildType):
3512         (individualTests):
3513         (substringList):
3514         (processMissingAndExtraExpectations):
3515         (pathToFailureLog):
3516         (showPopupForBuild):
3517         (htmlForTestsWithExpectationsButNoFailures):
3518         (shouldHideTest):
3519         (isCrossBuilderView):
3520         (tableHeaders):
3521         (htmlForSingleTestRow):
3522         (htmlForTableColumnHeader):
3523         (generatePageForExpectationsUpdate):
3524         (handleUpdate):
3525         (nextUpdate):
3526         (setUpdateIndex):
3527         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3528         (.appendExpectationsItem):
3529         (loadExpectations):
3530         (.dummyNode.onload):
3531         (loadExpectationsLayoutTests):
3532         (appendExpectations):
3533         (htmlForNavBar):
3534         (checkBoxToToggleState):
3535         (linkHTMLToToggleState):
3536         (generatePageForBuilder):
3537         (isInvalidKeyForCrossBuilderView):
3538         (handleQueryParameterChange):
3539         (showLegend):
3540         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3541         (resetGlobals):
3542         (test):
3543         * TestResultServer/static-dashboards/history.js:
3544         (.):
3545         * TestResultServer/static-dashboards/history_unittests.js:
3546         * TestResultServer/static-dashboards/loader.js:
3547         (.):
3548         * TestResultServer/static-dashboards/loader_unittests.js:
3549         * TestResultServer/static-dashboards/timeline_explorer.js:
3550         (generatePage):
3551         (initCurrentBuilderTestResults):
3552         (selectBuild):
3553         (showResultsDelta):
3554         * TestResultServer/static-dashboards/treemap.js:
3555         (generatePage):
3556         (.switch.return):
3557         (handleFocus):
3558         * TestResultServer/static-dashboards/ui.js:
3559
3560 2013-03-25  Roger Fong  <roger_fong@apple.com>
3561
3562         Unreviewed. Enable WinEWS tests again.
3563
3564         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3565         (WinEWS):
3566
3567 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3568
3569         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3570         https://bugs.webkit.org/show_bug.cgi?id=112166
3571
3572         HarfBuzz 0.9.14 merged my patch for icu detection without
3573         pkg-config files, as needed by for example Ubuntu 12.04.
3574         This obsoletes our local workaround. Removed it for GTK and EFL.
3575
3576         Reviewed by Martin Robinson.
3577
3578         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3579         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3580         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3581         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3582
3583 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3584
3585         Unreviewed.  Move self from contributor to committer list.
3586
3587         * Scripts/webkitpy/common/config/committers.py:
3588
3589 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3590
3591         EWS should use a human readable port name when uploading layout test archives
3592         https://bugs.webkit.org/show_bug.cgi?id=113099
3593
3594         Reviewed by Dirk Pranke.
3595
3596         Use new port's object's name() method to report human readable port names.
3597         This will also help us resolving the bug to apply layout test results posted by EWS.
3598
3599         * Scripts/webkitpy/tool/bot/botinfo.py:
3600         (BotInfo.__init__): Take port's name.
3601         (BotInfo.summary_text):
3602
3603         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3604         (BotInfoTest.test_summary_text):
3605
3606         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3607         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3608
3609         * Scripts/webkitpy/tool/commands/queues.py:
3610         (PatchProcessingQueue.__init__): Initialize self._port.
3611         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3612         and use that for the attachment filename and the comment posted.
3613
3614         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3615         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3616         "mac-snowleopard" as expected for TestPort.
3617
3618 2013-03-22  Roger Fong  <roger_fong@apple.com>
3619
3620         Unreviewed. Turn off EWS test on Win again.
3621         The battle continues.
3622
3623         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3624         (WinEWS):
3625
3626 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3627
3628         NRWT: Enable pixel tests when retrying tests
3629         https://bugs.webkit.org/show_bug.cgi?id=112898
3630
3631         Reviewed by Dirk Pranke.
3632
3633         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3634         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3635         if we've forced pixel tests in the retry.
3636         (Manager._run_tests):
3637         (Manager._clean_up_run): Fixed the capitalizations.
3638         (Manager._force_pixel_tests_if_needed): Added.
3639
3640         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3641         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3642         'image_diff_percent' if it doesn't already exist.
3643
3644         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3645         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3646         treat this as a regular regression instead of a flakiness.
3647
3648         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3649         run had image diffs.
3650
3651         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3652         (summarized_results):
3653
3654         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3655         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3656         Also removed some dead code.
3657
3658         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3659         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3660         is set and pixel_tests_enabled is set to false.
3661         (EndToEndTest.test_reftest_with_two_notrefs):
3662
3663 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3664
3665         Make it possible to run layout tests on Retina MBP
3666         https://bugs.webkit.org/show_bug.cgi?id=93673
3667
3668         Reviewed by Ryosuke Niwa.
3669
3670         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3671         windows on 2x machines still run at 1x.
3672
3673         * DumpRenderTree/mac/DumpRenderTree.mm:
3674         (createWebViewAndOffscreenWindow):
3675         Reset the window resolution to 1x on creation.
3676         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
3677         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3678         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
3679         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3680         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
3681         (WTR::PlatformWebView::PlatformWebView):
3682         Add NSWindow details, reset the window resolution to 1x on creation.
3683
3684 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3685
3686         Leak bots shouldn't build
3687         https://bugs.webkit.org/show_bug.cgi?id=112774
3688
3689         Reviewed by Simon Fraser.
3690
3691         Since leak bots use regular debug builds, there is no need to build on these bots.
3692         Simply downloading builds will dramatically improve the cycle time of these bots.
3693
3694         * BuildSlaveSupport/build.webkit.org-config/config.json:
3695         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3696         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
3697         TestFactory instead of BuildAndTestFactory.
3698
3699 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3700
3701         [Qt] Fix the TestWebKitAPI build
3702         https://bugs.webkit.org/show_bug.cgi?id=113044
3703
3704         Reviewed by Tor Arne Vestbø.
3705
3706         The generate-forwarding-headers script would only be run
3707         after the targets in InjectedBundle.pri since the second
3708         addStrictSubdirOrderBetween call in
3709         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
3710         the derived_sources -> injected_bundle order in SUBDIRS.
3711
3712         Fix it by only moving the dependent target at the end of
3713         SUBDIRS, don't touch its dependency.
3714
3715         * qmake/mkspecs/features/functions.prf:
3716
3717 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3718
3719         [EFL][WK2] View is not focused when fullscreen mode toggled
3720         https://bugs.webkit.org/show_bug.cgi?id=113009
3721
3722         Reviewed by Laszlo Gombos.
3723
3724         Set focus on view when fullscreen mode enabled/disabled
3725         by FullScreen API.
3726
3727         * MiniBrowser/efl/main.c:
3728         (on_fullscreen_accept):
3729         (on_fullscreen_deny):
3730
3731 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3732
3733         nrwt is no longer saving retry results in the retries/ subdirectory
3734         https://bugs.webkit.org/show_bug.cgi?id=112995
3735
3736         Reviewed by Ojan Vafai.
3737
3738         I think this has been broken a long time, unfortunately. This
3739         patch should fix that.
3740
3741         In order to do so, I had to pass the directory to use from
3742         the Worker object through the SingleTestWriter to the
3743         TestResultWriter. While I was plumbing that through, I rationalized
3744         the order of the parameter arguments a bit ...
3745
3746         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3747         (Worker._run_single_test):
3748         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3749         (run_single_test):
3750         (SingleTestRunner.__init__):
3751         (SingleTestRunner._run_compare_test):
3752         (SingleTestRunner._run_rebaseline):
3753         (SingleTestRunner._run_reftest):
3754         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3755         (write_test_result):
3756         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3757         (TestResultWriterTest.test_reftest_diff_image):
3758         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3759         (RunTest.test_retrying_uses_retries_directory):
3760
3761 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
3762
3763         JSC profiler should have an at-a-glance report of the success of DFG optimization
3764         https://bugs.webkit.org/show_bug.cgi?id=112988
3765
3766         Reviewed by Geoffrey Garen.
3767
3768         * Scripts/display-profiler-output:
3769
3770 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3771
3772         [chromium] Linux ASAN WebKit canary is running out of memory
3773         https://bugs.webkit.org/show_bug.cgi?id=112978
3774
3775         Reviewed by Tony Chang.
3776
3777         Running the AddressSanitizer on a crash takes a lot of
3778         memory, so we should serialize access to it to avoid running
3779         out of memory on a machine.
3780
3781         * Scripts/webkitpy/layout_tests/port/chromium.py:
3782         (ChromiumPort._get_crash_log):
3783         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3784         (HttpLock.__init__):
3785         (HttpLock.wait_for_httpd_lock):
3786
3787 2013-03-21  Min Qin  <qinmin@chromium.org>
3788
3789         Cleanup android media layout test code
3790         https://bugs.webkit.org/show_bug.cgi?id=112944
3791
3792         Reviewed by Adam Barth.
3793
3794         Chromium change: https://codereview.chromium.org/12892010/
3795         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
3796         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
3797         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
3798         Instead, we should switch to use content shell for layout tests.
3799
3800         * DumpRenderTree/chromium/TestShell.cpp:
3801         (TestShell::resetTestController):
3802
3803 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3804
3805         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
3806         https://bugs.webkit.org/show_bug.cgi?id=112953
3807
3808         Reviewed by Tony Chang.
3809
3810         When I created the DumpRenderTree_resources target in r144863 I
3811         forgot to declare the needed dependencies on the other resource
3812         targets. Due to a quirk of ordering, this appears to have been fine
3813         w/ ninja but not w/ Xcode (which is still being used on the chromium
3814         mac valgrind bots). Declaring the dependencies fixes the build
3815         failures.
3816
3817         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3818
3819 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
3820
3821         [WinCairo] Correct assert in Empty BitmapImage Test.
3822         https://bugs.webkit.org/show_bug.cgi?id=112934
3823
3824         Reviewed by Tim Horton.
3825
3826         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3827         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
3828         to avoid ref counting assertion when leaving test scope.
3829
3830 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
3831
3832         [GTK] generate-feature-defines-files is incompatible with Python3
3833         https://bugs.webkit.org/show_bug.cgi?id=112956
3834
3835         Reviewed by Martin Robinson.
3836
3837         Make the generate-feature-defines-files compatible with Python3 by calling the items()
3838         method on the dictionary objects when iterating through said dictionaries.
3839
3840         * gtk/generate-feature-defines-files:
3841         (write_feature_defines_header):
3842         (write_flattened_feature_defines_file):
3843
3844 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3845
3846         kill-old-processes spits out error messages on Mac
3847         https://bugs.webkit.org/show_bug.cgi?id=112878
3848
3849         Reviewed by Jessie Berlin.
3850
3851         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
3852         included in the list of options grep --help shows.
3853
3854         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
3855
3856         * BuildSlaveSupport/kill-old-processes:
3857         (main):
3858
3859 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
3860
3861         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
3862         https://bugs.webkit.org/show_bug.cgi?id=112597
3863
3864         Reviewed by Xan Lopez.
3865
3866         These were introduced for the Chromium port in r105295. We need
3867         dummy implementations in order to compile the BlackBerry port.
3868
3869         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3870         (AccessibilityUIElement::scrollToMakeVisible):
3871         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3872         (AccessibilityUIElement::scrollToGlobalPoint):
3873
3874 2013-03-21  Roger Fong  <roger_fong@apple.com>
3875
3876         Re-enable WinEWS tests following r146376.
3877
3878         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3879         (WinEWS):
3880
3881 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
3882
3883         Unreviewed. Add Bem Jones-Bey to the list of contributors.
3884
3885         * Scripts/webkitpy/common/config/committers.py:
3886
3887 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3888
3889         [GTK] Missing atk in install-dependencies script
3890         https://bugs.webkit.org/show_bug.cgi?id=112272
3891
3892         Reviewed by Gustavo Noronha Silva.
3893
3894         * gtk/install-dependencies: Add missing atk dependency.
3895
3896 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3897
3898         [GTK] Missing backslash in install-dependencies script
3899         https://bugs.webkit.org/show_bug.cgi?id=112907
3900
3901         Reviewed by Philippe Normand.
3902
3903         * gtk/install-dependencies: Add missing backslash to dependencies
3904         list.
3905
3906 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3907
3908         EWS bots have stopped uploading results to bugzilla
3909         https://bugs.webkit.org/show_bug.cgi?id=101091
3910
3911         Reviewed by Adam Barth.
3912
3913         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
3914         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
3915         this relative file path resoled to a file inside a non-existent directory for "zip".
3916
3917         Fixed the bug by resolving both test results directory and zip archive paths in
3918         LayoutTestResultsReader.archive.
3919
3920         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
3921         in the future.
3922
3923         * Scripts/webkitpy/common/system/filesystem_mock.py:
3924         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
3925
3926         * Scripts/webkitpy/common/system/workspace.py:
3927         (Workspace.create_zip): Log the source path when "zip" failed.
3928
3929         * Scripts/webkitpy/common/system/workspace_mock.py:
3930         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
3931
3932         * Scripts/webkitpy/common/system/workspace_unittest.py:
3933         (WorkspaceTest.test_create_zip_exception): Test that.
3934
3935         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3936         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
3937         This is the actual bug fix.
3938
3939         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3940         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
3941
3942 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
3943
3944         [chromium] move WebThemeEngine implementations to TestRunner library
3945         https://bugs.webkit.org/show_bug.cgi?id=112751
3946
3947         Reviewed by Adam Barth.
3948
3949         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3950         * DumpRenderTree/DumpRenderTree.gypi:
3951         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3952         (WebKit):
3953         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3954         (WebTestRunner::TestInterfaces::themeEngine):
3955         (WebTestRunner):
3956         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3957         (WebKit):
3958         (TestInterfaces):
3959         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3960         (WebTestRunner::WebTestInterfaces::themeEngine):
3961         (WebTestRunner):
3962         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3963         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3964         (WebTestRunner):
3965         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3966         (WebTestRunner::WebTestThemeControlWin::box):
3967         (WebTestRunner::WebTestThemeControlWin::line):
3968         (WebTestRunner::WebTestThemeControlWin::triangle):
3969         (WebTestRunner::WebTestThemeControlWin::roundRect):
3970         (WebTestRunner::WebTestThemeControlWin::oval):
3971         (WebTestRunner::WebTestThemeControlWin::circle):
3972         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3973         (WebTestRunner::WebTestThemeControlWin::markState):
3974         (WebTestRunner::WebTestThemeControlWin::draw):
3975         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3976         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3977         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3978         (WebTestRunner):
3979         (WebTestThemeControlWin):
3980         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3981         (WebTestRunner):
3982         (WebTestThemeEngineMac):
3983         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3984         (+[FakeActiveWindow alwaysActiveWindow]):
3985         (+[FakeActiveWindow alwaysInactiveWindow]):
3986         (-[FakeActiveWindow initWithActiveControls:]):
3987         (-[FakeActiveWindow _hasActiveControls]):
3988         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3989         (WebTestRunner):
3990         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3991         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3992         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3993         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3994         (WebTestRunner):
3995         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3996         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3997         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3998         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3999         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
4000         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
4001         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
4002         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
4003         (WebTestRunner::WebTestThemeEngineWin::getSize):
4004         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
4005         (WebTestRunner):
4006         (WebTestThemeEngineWin):
4007         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
4008         * DumpRenderTree/chromium/TestShell.cpp:
4009         (TestShell::initialize):
4010         * DumpRenderTree/chromium/TestShell.h:
4011         (WebKit):
4012         * DumpRenderTree/chromium/TestShellMac.mm:
4013         (platformInit):
4014         * DumpRenderTree/chromium/TestShellWin.cpp:
4015         (platformInit):
4016         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
4017
4018 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
4019
4020         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
4021
4022         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
4023         New property sheet that does not link against CoreFoundation and
4024         CFNetwork.
4025         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
4026         Use new TestWebKitAPICommonWinCairo property sheet.
4027         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
4028         Ditto.
4029
4030 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
4031
4032         [WinCairo] Unreviewed build fix for VS2010.
4033
4034         Had to add WinCairo-specific property sheets to deal with some
4035         library and path differences with the main Apple port.
4036
4037         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
4038         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
4039         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
4040         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
4041         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
4042         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
4043
4044 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
4045
4046         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
4047         https://bugs.webkit.org/show_bug.cgi?id=112849
4048
4049         Reviewed by Sam Weinig.
4050
4051         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4053         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4054
4055 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
4056
4057         [WinCairo] Build WebKit Tools under VS2010
4058         https://bugs.webkit.org/show_bug.cgi?id=112821
4059
4060         Reviewed by Tim Horton.
4061
4062         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
4063         Add WinCairo-specific build target.
4064         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
4065         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
4066         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
4067         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
4068         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
4069         Add WinCairo-specific build target.
4070         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
4071         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
4072         Add WinCairo-specific build target.
4073         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
4074         WinCairo-specific build target.
4075         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
4076         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
4077         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
4078         specific build target.
4079         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
4080         WinCairo-specific build target.
4081         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
4082         * win/record-memory/record-memoryDebugWinCairo.props: Added.
4083         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
4084
4085 2013-03-20  Roger Fong  <roger_fong@apple.com>
4086
4087         API test gardening AppleWin port.
4088
4089         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
4090
4091         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4092         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4093
4094 2013-03-20  Roger Fong  <roger_fong@apple.com>
4095
4096         Test fix for Win EWS bots, catch various errors and restart script if necessary.
4097
4098         * EWSTools/start-queue-win.sh:
4099
4100 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
4101
4102         Unreviewed, add myself to committers.py.
4103
4104 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4105
4106         Unreviewed. Adding another email for me.
4107
4108         * Scripts/webkitpy/common/config/committers.py:
4109
4110 2013-03-20  Justin Novosad  <junov@google.com>
4111
4112         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
4113         https://bugs.webkit.org/show_bug.cgi?id=112605
4114
4115         Reviewed by James Robinson.
4116
4117         Deleting all the code that was used for propagating and supporting
4118         the Chromium setting for disabling deferred 2d canvas rendering.
4119
4120         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4121         (main):
4122         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
4123         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4124         (WebTestRunner::WebPreferences::reset):
4125         (WebTestRunner::WebPreferences::applyTo):
4126         * DumpRenderTree/chromium/TestShell.cpp:
4127         (TestShell::TestShell):
4128         (TestShell::resetWebSettings):
4129         (TestShell::runFileTest):
4130         * DumpRenderTree/chromium/TestShell.h:
4131         (TestShell):
4132
4133 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
4134
4135         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
4136         https://bugs.webkit.org/show_bug.cgi?id=112699.
4137
4138         Reviewed by Adam Barth.
4139
4140         * Scripts/webkitpy/layout_tests/port/qt.py:
4141         (QtPort._search_paths):
4142         (QtPort._port_specific_expectations_files):
4143         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4144         (QtPortTest):
4145         (QtPortTest._assert_search_path):
4146         (QtPortTest._assert_expectations_files):
4147
4148 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4149
4150         [Qt] Enable kerning by default
4151         https://bugs.webkit.org/show_bug.cgi?id=112704
4152
4153         Reviewed by Jocelyn Turcotte.
4154
4155         Disable kerning by default, since some reference test expectations
4156         expect kerning to be default off.
4157
4158         * DumpRenderTree/qt/TestRunnerQt.cpp:
4159         (TestRunnerQt::reset):
4160         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4161         (WTR::activateFonts):
4162
4163 2013-03-20  Zeno Albisser  <zeno@webkit.org>
4164
4165         [Qt] Remove empty function stubs from TestRunnerQt.
4166         https://bugs.webkit.org/show_bug.cgi?id=112799
4167
4168         We are reducing the code in TestRunnerQt step by step,
4169         in order to finally replace all of it with the generic
4170         TestRunner implementation.
4171         This patch removes several simple function stubs that
4172         currently do not implement any actual functionality.
4173
4174         Reviewed by Kenneth Rohde Christiansen.
4175
4176         * DumpRenderTree/qt/TestRunnerQt.cpp:
4177         * DumpRenderTree/qt/TestRunnerQt.h:
4178         (TestRunnerQt):
4179
4180 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
4181
4182         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
4183         https://bugs.webkit.org/show_bug.cgi?id=112687
4184
4185         Reviewed by Kenneth Rohde Christiansen.
4186
4187         Hide the SearchBar by default on window creation.
4188
4189         * MiniBrowser/efl/main.c:
4190         (window_create):
4191
4192 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
4193
4194         Unreviewed, rolling out r146304.
4195         http://trac.webkit.org/changeset/146304
4196         https://bugs.webkit.org/show_bug.cgi?id=112788
4197
4198         to many expectations to update (Requested by antonm on
4199         #webkit).
4200
4201         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4202         * DumpRenderTree/DumpRenderTree.gypi:
4203         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4204         (WebKit):
4205         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4206         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4207         (TestInterfaces):
4208         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4209         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
4210         * DumpRenderTree/chromium/TestShell.cpp:
4211         (TestShell::initialize):
4212         * DumpRenderTree/chromium/TestShell.h:
4213         (WebKit):
4214         * DumpRenderTree/chromium/TestShellMac.mm:
4215         (platformInit):
4216         * DumpRenderTree/chromium/TestShellWin.cpp:
4217         (platformInit):
4218         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
4219         (WebThemeControlDRTWin::WebThemeControlDRTWin):
4220         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
4221         (WebThemeControlDRTWin::box):
4222         (WebThemeControlDRTWin::line):
4223         (WebThemeControlDRTWin::triangle):
4224         (WebThemeControlDRTWin::roundRect):
4225         (WebThemeControlDRTWin::oval):
4226         (WebThemeControlDRTWin::circle):
4227         (WebThemeControlDRTWin::nestedBoxes):
4228         (WebThemeControlDRTWin::markState):
4229         (WebThemeControlDRTWin::draw):
4230         (WebThemeControlDRTWin::drawTextField):
4231         (WebThemeControlDRTWin::drawProgressBar):
4232         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
4233         (WebThemeControlDRTWin):
4234         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
4235         (WebThemeEngineDRTMac):
4236         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
4237         (+[FakeActiveWindow alwaysActiveWindow]):
4238         (+[FakeActiveWindow alwaysInactiveWindow]):
4239         (-[FakeActiveWindow initWithActiveControls:]):
4240         (-[FakeActiveWindow _hasActiveControls]):
4241         (WebThemeEngineDRTMac::paintScrollbarThumb):
4242         (stateToHIEnableState):
4243         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4244         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4245         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
4246         (webRectToSkIRect):
4247         (drawControl):
4248         (drawTextField):
4249         (drawProgressBar):
4250         (WebThemeEngineDRTWin::paintButton):
4251         (WebThemeEngineDRTWin::paintMenuList):
4252         (WebThemeEngineDRTWin::paintScrollbarArrow):
4253         (WebThemeEngineDRTWin::paintScrollbarThumb):
4254         (WebThemeEngineDRTWin::paintScrollbarTrack):
4255         (WebThemeEngineDRTWin::paintSpinButton):
4256         (WebThemeEngineDRTWin::paintTextField):
4257         (WebThemeEngineDRTWin::paintTrackbar):
4258         (WebThemeEngineDRTWin::paintProgressBar):
4259         (WebThemeEngineDRTWin::getSize):
4260         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
4261         (WebThemeEngineDRTWin):
4262         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
4263
4264 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4265
4266         [Qt] Support -webkit-font-smoothing
4267         https://bugs.webkit.org/show_bug.cgi?id=106009
4268
4269         Reviewed by Jocelyn Turcotte.
4270
4271         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
4272
4273         * DumpRenderTree/qt/TestRunnerQt.cpp:
4274         (TestRunnerQt::reset):
4275
4276 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
4277
4278         [GTK] accessibility/aria-scrollbar-role.html is failing
4279         https://bugs.webkit.org/show_bug.cgi?id=98358
4280
4281         Reviewed by Martin Robinson.
4282
4283         Adds support for checking accessibility object's orientation.
4284         Orientation is checked by retrieving proper state of accessibility object.
4285
4286         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4287         (checkElementState):
4288         (AccessibilityUIElement::orientation):
4289         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4290         (WTR::AccessibilityUIElement::orientation):
4291
4292 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
4293
4294         [chromium] move WebThemeEngine implementations to TestRunner library
4295         https://bugs.webkit.org/show_bug.cgi?id=112751
4296
4297         Reviewed by Adam Barth.
4298
4299         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4300         * DumpRenderTree/DumpRenderTree.gypi:
4301         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4302         (WebKit):
4303         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4304         (WebTestRunner::TestInterfaces::themeEngine):
4305         (WebTestRunner):
4306         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4307         (WebKit):
4308         (TestInterfaces):
4309         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4310         (WebTestRunner::WebTestInterfaces::themeEngine):
4311         (WebTestRunner):
4312         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
4313         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
4314         (WebTestRunner):
4315         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
4316         (WebTestRunner::WebTestThemeControlWin::box):
4317         (WebTestRunner::WebTestThemeControlWin::line):
4318         (WebTestRunner::WebTestThemeControlWin::triangle):
4319         (WebTestRunner::WebTestThemeControlWin::roundRect):
4320         (WebTestRunner::WebTestThemeControlWin::oval):
4321         (WebTestRunner::WebTestThemeControlWin::circle):
4322         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
4323         (WebTestRunner::WebTestThemeControlWin::markState):
4324         (WebTestRunner::WebTestThemeControlWin::draw):
4325         (WebTestRunner::WebTestThemeControlWin::drawTextField):
4326         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
4327         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
4328         (WebTestRunner):
4329         (WebTestThemeControlWin):
4330         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
4331         (WebTestRunner):
4332         (WebTestThemeEngineMac):
4333         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
4334         (+[FakeActiveWindow alwaysActiveWindow]):
4335         (+[FakeActiveWindow alwaysInactiveWindow]):
4336         (-[FakeActiveWindow initWithActiveControls:]):
4337         (-[FakeActiveWindow _hasActiveControls]):
4338         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
4339         (WebTestRunner):
4340         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
4341         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
4342         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
4343         (WebTestRunner::WebTestThemeEngineWin::paintButton):
4344         (WebTestRunner):
4345         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
4346         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
4347         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
4348         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
4349         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
4350         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
4351         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
4352         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
4353         (WebTestRunner::WebTestThemeEngineWin::getSize):
4354         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from