b3856e4e59f7a19992a1b2d4166056a8b0ca18b1
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-26  Roger Fong  <roger_fong@apple.com>
2
3         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
4         Make the DebugSuffix configuration use _debug dependencies.
5
6         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
7         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
8         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
9         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
10         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
11         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
12         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
13         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
14         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
15         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
16         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
17         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
18         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
19         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
20         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
21         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
22         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
23         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
24         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
25         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
26         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
27         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
28         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
29         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
30         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
31         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
32         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
33         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
34         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
35         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
36         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
37         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
38         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
39         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
40         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
41         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
42         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
43         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
44         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
45         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
46         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
47         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
48         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
49         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
50         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
51         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
52         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
53         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
54         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
55         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
56         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
57         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
58         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
59         * win/AssembleBuildLogs/AssembleLogs.cmd:
60         * win/record-memory/record-memory.vcxproj:
61         * win/record-memory/record-memoryDebug.props:
62         * win/record-memory/record-memoryDebugWinCairo.props:
63         * win/record-memory/record-memoryProduction.props:
64         * win/record-memory/record-memoryRelease.props:
65         * win/record-memory/record-memoryReleaseWinCairo.props:
66
67 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
68
69         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
70         https://bugs.webkit.org/show_bug.cgi?id=115233
71
72         Reviewed by Martin Robinson.
73
74         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
75         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
76         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
77         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
78         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
79
80         * TestWebKitAPI/GNUmakefile.am:
81
82 2013-04-25  Andy Estes  <aestes@apple.com>
83
84         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
85         https://bugs.webkit.org/show_bug.cgi?id=115223
86
87         Reviewed by Darin Adler.
88
89         Added an API test.
90
91         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
92         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
93         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
94         when it loads a request with a custom protocol.
95         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
96         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
97         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
98         miscellaneous cleanup.
99         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
100         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
101         (+[TestProtocol canInitWithRequest:]):
102         (+[TestProtocol canonicalRequestForRequest:]):
103         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
104         (+[TestProtocol scheme]):
105         (-[TestProtocol startLoading]):
106         (-[TestProtocol stopLoading]):
107
108 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
109
110         Remove the remaining Skia #ifdefs
111         https://bugs.webkit.org/show_bug.cgi?id=114886
112
113         Reviewed by Benjamin Poulain.
114
115         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
116         (createBitmapContextFromWebView): Remove Skia #ifdef references.
117
118 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
119
120         [BlackBerry] Clean up load interface in WebPage
121         https://bugs.webkit.org/show_bug.cgi?id=113267
122
123         Reviewed by Rob Buis.
124
125         Update DumpRenderTree with change of load() interface in WebPage.
126         RIM Bug# 315535, internally reviewed by Joe Mason.
127
128         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
129         (BlackBerry::WebKit::DumpRenderTree::runTest):
130
131 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
132
133         Remove the HeapGraphSerializer unit test
134         https://bugs.webkit.org/show_bug.cgi?id=115231
135
136         Reviewed by Andreas Kling.
137
138         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
139         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
140
141         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
142
143 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
144
145         Remove support for Chromium from build/update scripts
146         https://bugs.webkit.org/show_bug.cgi?id=115218
147
148         Reviewed by Darin Adler.
149
150         * Scripts/build-webkit:
151         (writeCongrats):
152         * Scripts/update-webkit:
153
154 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
155
156         Remove support for Chromium from api-test
157         https://bugs.webkit.org/show_bug.cgi?id=115211
158
159         Reviewed by Dirk Pranke.
160
161         * Scripts/build-api-tests:
162         * Scripts/run-api-tests:
163         (isSupportedPlatform):
164
165 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
166
167         Get rid of Chromium in build-dumprendertree
168         https://bugs.webkit.org/show_bug.cgi?id=115212
169
170         Reviewed by Dirk Pranke.
171
172         * Scripts/build-dumprendertree:
173
174 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
175
176         Pass relatedPage when creating a page in WebKitTestRunner
177         https://bugs.webkit.org/show_bug.cgi?id=115206
178
179         Reviewed by Geoffrey Garen.
180
181         To make sure that window.open() opens in the same process even when using multiple processes.
182
183         * WebKitTestRunner/PlatformWebView.h:
184         * WebKitTestRunner/TestController.cpp:
185         (WTR::TestController::createOtherPage):
186         (WTR::TestController::createWebViewWithOptions):
187         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
188         (WTR::PlatformWebView::PlatformWebView):
189         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
190         (WTR::PlatformWebView::PlatformWebView):
191         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
192         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
193         (WTR::PlatformWebView::PlatformWebView):
194         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
195         (WTR::PlatformWebView::PlatformWebView):
196         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
197         (WTR::PlatformWebView::PlatformWebView):
198
199 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
200
201         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
202
203         * Scripts/webkitpy/common/config/contributors.json:
204
205 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
206
207         Build fix. Forgot to merge args.
208
209         * Scripts/webkitpy/tool/bot/irc_command.py:
210         (Hi.execute):
211
212 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
213
214         webkitbot should recognize its own nickname in greetings.
215         https://bugs.webkit.org/show_bug.cgi?id=115196
216
217         Reviewed by Andreas Kling.
218
219         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
220
221         * Scripts/webkitpy/tool/bot/irc_command.py:
222         (Hi.execute):
223
224 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
225
226         [GTK] Tools/gtk/install-dependencies added ragel dependency
227         https://bugs.webkit.org/show_bug.cgi?id=115163
228
229         Reviewed by Xan Lopez.
230
231         The install-dependencies script was missing a dependency on ragel
232         which is expected when building HarfBuzz.
233
234         * gtk/install-dependencies: Added a dependency on ragel for both
235         apt and yum.
236
237 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
238
239         [GTK] Remove pango from optional jhbuild dependencies
240         https://bugs.webkit.org/show_bug.cgi?id=115162
241
242         Reviewed by Martin Robinson.
243
244         Pango is not needed since revision r148293 that lowers the pango
245         dependency to 1.30, which is available in most distributions.
246
247         * gtk/jhbuild-optional.modules: Removes description of pango module.
248
249 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
250
251         Remove Chromium-specific cases from FeatureList.pm
252         https://bugs.webkit.org/show_bug.cgi?id=115169
253
254         Reviewed by Andreas Kling.
255
256         * Scripts/webkitperl/FeatureList.pm:
257
258 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
259
260         Remove checking chromium from run-webkit-tests
261         https://bugs.webkit.org/show_bug.cgi?id=115139
262
263         Reviewed by Benjamin Poulain.
264
265         * Scripts/run-webkit-tests:
266         (useNewRunWebKitTests):
267
268 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
269
270         Pixel tests in SVG are all broken in WK2
271         https://bugs.webkit.org/show_bug.cgi?id=114218
272
273         Reviewed by Darin Adler.
274         
275         Window snapshots in WebKitTestRunner on Mac are window-sized
276         (800x600), which is wrong for the W3C SVG tests that require a
277         480x360 snapshot.
278         
279         Fix by resizing the window, as well as the web view in
280         PlatformWebView::resizeTo() so that window snapshots are correctly
281         sized.
282         
283         Also do some drive-by cleanup of the window size constants in both
284         DRT and WTR to remove magic numbers, and make the code more similar.
285         
286         * DumpRenderTree/TestRunner.cpp:
287         (TestRunner::setShouldPaintBrokenImage):
288         * DumpRenderTree/TestRunner.h:
289         * DumpRenderTree/efl/DumpRenderTree.cpp:
290         * DumpRenderTree/gtk/DumpRenderTree.cpp:
291         (webInspectorShowWindow):
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         (createWebViewAndOffscreenWindow):
294         (sizeWebViewForCurrentTest):
295         * DumpRenderTree/mac/DumpRenderTreeMac.h:
296         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
297         (createPagedBitmapContext):
298         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
299         (DumpRenderTree::DumpRenderTree):
300         (DumpRenderTree::open):
301         * DumpRenderTree/qt/TestRunnerQt.cpp:
302         * DumpRenderTree/qt/TestRunnerQt.h:
303         * DumpRenderTree/win/DumpRenderTree.cpp:
304         (sizeWebViewForCurrentTest):
305         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
306         * WebKitTestRunner/TestController.cpp:
307         (WTR::TestController::resetStateToConsistentValues):
308         * WebKitTestRunner/TestController.h:
309         * WebKitTestRunner/TestInvocation.cpp:
310         (WTR::sizeWebViewForCurrentTest):
311         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
312         (WTR::PlatformWebView::PlatformWebView):
313         (WTR::PlatformWebView::resizeTo):
314
315 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
316
317         [EFL] Fix build error after r148963.
318         https://bugs.webkit.org/show_bug.cgi?id=115126
319
320         Reviewed by Laszlo Gombos.
321
322         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
323
324         * TestWebKitAPI/PlatformEfl.cmake:
325
326 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
327
328         [GTK] Use stamp files for generate-forwarding-headers makefile rules
329         https://bugs.webkit.org/show_bug.cgi?id=115118
330
331         Reviewed by Martin Robinson.
332
333         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
334         forwarding generator rules and don't call it for soup since there
335         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
336
337         * TestWebKitAPI/GNUmakefile.am:
338         * WebKitTestRunner/GNUmakefile.am:
339
340 2013-04-24  Simon Pena  <simon.pena@samsung.com>
341
342         [GTK] Update build dependencies
343         https://bugs.webkit.org/show_bug.cgi?id=115111
344
345         Reviewed by Martin Robinson.
346
347         The install-dependencies script was missing a dependency on EGL,
348         which is expected when building Cairo.
349
350         * gtk/install-dependencies: Added a dependency on libegl1-mesa
351         for both apt and yum.
352
353 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
354
355         Remove the Chromium-specific helper from run_webkit_tests.py
356         https://bugs.webkit.org/show_bug.cgi?id=114996
357
358         Reviewed by Dirk Pranke.
359
360         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
361         (parse_args):
362
363 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
364
365         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
366         https://bugs.webkit.org/show_bug.cgi?id=114850
367
368         Reviewed by Andreas Kling.
369
370         Revision r148312 fixed WebPageProxy cleanup and also changed the process
371         termination semantics when requested by the user so that a client is not
372         notified of a crash anymore, since there was no crash anyway.
373
374         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
375         relied on being notified of a crash after calling WKPageTerminate(). As
376         a result of not being notified of such non-existent crash, the test would
377         timeout right after making the terminate call.
378
379         This patch adds an InjectedBundle to be used for simulating a crash, by
380         calling abort() upon receiving a "Crash" message, and thus we are able to
381         keep testing the crash callback.
382
383         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
384         had been disabled in revisions r148858 and r148855, since it was failing.
385
386         * TestWebKitAPI/PlatformEfl.cmake:
387         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
388         (TestWebKitAPI::TEST):
389         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
390         (TestWebKitAPI):
391         (WKViewClientWebProcessCallbacksTest):
392         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
393         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
394
395 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
396
397         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
398         https://bugs.webkit.org/show_bug.cgi?id=115095
399
400         Reviewed by Antonio Gomes.
401
402         Use different subfolders under DumpRenderTree Temp folder for every
403         functionality (icon database, cache, localstorage, ...). This makes
404         sure there is no conflict between the functionalities.
405
406         In EFL's case, libsoup cache was causing problems for the icon
407         database if sharing the same folder.
408
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::TestController::initialize):
411
412 == Rolled over to ChangeLog-2013-04-24 ==