delete-stale-build-files is too aggressive
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2
3         delete-stale-build-files is too aggressive
4         https://bugs.webkit.org/show_bug.cgi?id=112595
5
6         Reviewed by Tim Horton.
7
8         It appears that whitelisting file extensions to keep is not a good idea.
9         Blacklist files to delete instead, and only delete .o files for now.
10         We can add more file extensions as needed.
11
12         * BuildSlaveSupport/delete-stale-build-files:
13
14 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
15
16         Disable accessibility notifications after each test
17         https://bugs.webkit.org/show_bug.cgi?id=112579
18
19         Reviewed by Tim Horton.
20         
21         In WebKitTestRunner, if any tests triggered accessibility notifications,
22         the global notification handler would thereafter be active, and fire
23         notifications for all subsequent tests.
24         
25         Fix by implementing AccessibilityController::resetToConsistentState() for
26         Mac, and using it to clear the global notification handler.
27
28         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
29         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
30         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
31         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
32         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
33         (e.g. because of -autorelease).
34         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
35         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
36         if there is one.
37         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
38         Add -stopObserving
39         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
40         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
41         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
42         center.
43
44 2013-03-18  Dana Jansens  <danakj@chromium.org>
45
46         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
47         https://bugs.webkit.org/show_bug.cgi?id=112392
48
49         Reviewed by James Robinson.
50
51         Removes the command line flag option from DRT.
52
53         * DumpRenderTree/chromium/DumpRenderTree.cpp:
54         (main):
55
56 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
57
58         [GTK] plugins/plugin-clip-subframe.html is failing
59         https://bugs.webkit.org/show_bug.cgi?id=112570
60
61         Reviewed by Martin Robinson.
62
63         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
64
65 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
66
67         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
68         https://bugs.webkit.org/show_bug.cgi?id=112442
69
70         Reviewed by Gustavo Noronha Silva.
71
72         * GtkLauncher/main.c:
73         (reloadCb):
74         (createToolbar):
75         (createWindow):
76
77 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
78
79         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
80         https://bugs.webkit.org/show_bug.cgi?id=112205
81
82         Disable this API test until Geoff can fix it.
83
84         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
85         (TestWebKitAPI::TEST):
86
87 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
88
89         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
90         https://bugs.webkit.org/show_bug.cgi?id=112478
91
92         Reviewed by Tony Chang.
93
94         There is nothing that ensures that the log messages from the plugin
95         come in before the layout test finished loading.
96
97         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
98         (PassDifferentNPPStruct::NPP_SetWindow):
99         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
100         (NPP_SetWindow):
101
102 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
103
104         Have the mac port support per_test_timeout in webkitpy
105         https://bugs.webkit.org/show_bug.cgi?id=112466
106
107         Reviewed by Dirk Pranke.
108         
109         Both WTR and DRT handle --timeout arguments, so we can
110         have the scripts pass the timeout values down to the tools.
111
112         * Scripts/webkitpy/layout_tests/port/mac.py:
113         (MacPort.supports_per_test_timeout):
114
115 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
116
117         Remove setAsynchronousSpellCheckingEnabled from test runners
118         https://bugs.webkit.org/show_bug.cgi?id=112362
119
120         Reviewed by Tony Chang.
121
122         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
123         in internals.settings, so all ports can share it.
124
125         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
126         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
127         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
128         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
129         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
130         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
131         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
132         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
133         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
134         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
135         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
136         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
137
138 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
139
140         Fix the stupid unit tests.
141
142         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
143         (test_sample_process):
144
145 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
146
147         Collect samples for unresponsive web processes
148         https://bugs.webkit.org/show_bug.cgi?id=112409
149
150         Reviewed by Tim Horton.
151         
152         When we detect that a subprocess was unresponsive, run the 'sample'
153         tool on that process, for the Mac port.
154         
155         The sample will be linked to from the results.html page, next
156         to the crash log link.
157
158         * Scripts/webkitpy/layout_tests/controllers/manager.py:
159         (Manager._look_for_new_crash_logs): Before looking for crash logs,
160         look for samples on disk.
161         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
162         (TestResultWriter):
163         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
164         -sample.txt files, and have it copy their contents to a new file
165         next to the test that spawned them (as we do for crash logs).
166         * Scripts/webkitpy/layout_tests/port/base.py:
167         (Port.look_for_new_samples): Base class does nothing for sampling.
168         * Scripts/webkitpy/layout_tests/port/driver.py:
169         (Driver._check_for_driver_crash): Kick off a sample if we detected
170         that the subprocess was unresponsive.
171         * Scripts/webkitpy/layout_tests/port/mac.py:
172         (MacPort.sample_file_path): Utility to generate the file path
173         to the generated sample files at the top level of layout-test-results.
174         (MacPort.look_for_new_crash_logs): Fix typo
175         (MacPort.look_for_new_samples): New function to find sample files.
176         (MacPort.sample_process): Use the utility function to get the file path.
177
178 2013-03-15  Zeno Albisser  <zeno@webkit.org>
179
180         [Qt] Remove simple getters and setters from TestRunnerQt
181         https://bugs.webkit.org/show_bug.cgi?id=112343
182
183         Reviewed by Benjamin Poulain.
184
185         The removed functions and boolean members
186         are being replaced by the implementations in the
187         generic TestRunner.h.
188
189         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
190         (DumpRenderTree::dumpFrameScrollPosition):
191         (DumpRenderTree::dumpFramesAsText):
192         (DumpRenderTree::dump):
193         (DumpRenderTree::titleChanged):
194         (DumpRenderTree::dumpDatabaseQuota):
195         (DumpRenderTree::dumpApplicationCacheQuota):
196         (DumpRenderTree::statusBarMessage):
197         (DumpRenderTree::createWindow):
198         * DumpRenderTree/qt/TestRunnerQt.cpp:
199         (TestRunnerQt::reset):
200         * DumpRenderTree/qt/TestRunnerQt.h:
201         (TestRunnerQt):
202
203 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
204
205         Update the link on build.webkit.org to refer to perf.webkit.org
206         https://bugs.webkit.org/show_bug.cgi?id=112416
207
208         Reviewed by Philip Rogers.
209
210         Updated the link. Also updated the template to use HTML5 DOCTYPE.
211
212         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
213
214 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
215
216         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
217         https://bugs.webkit.org/show_bug.cgi?id=112394
218
219         Reviewed by Philippe Normand.
220
221         * GtkLauncher/main.c:
222         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
223
224 2013-03-14  Andreas Kling  <akling@apple.com>
225
226         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
227         <http://webkit.org/b/111815>
228         <rdar://problem/13380145>
229
230         Reviewed by Anders Carlsson.
231
232         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
233         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
234         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
235
236         * WebKitTestRunner/PlatformWebView.h:
237         (PlatformWebView):
238         * WebKitTestRunner/TestController.cpp:
239         (WTR::TestController::createOtherPage):
240         (WTR::TestController::createWebViewWithOptions):
241         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
242         (WTR::PlatformWebView::didInitializeClients):
243
244 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
245
246         [EFL][MiniBrowser] Add a search field to the MiniBrowser
247         https://bugs.webkit.org/show_bug.cgi?id=112122
248
249         Reviewed by Kenneth Rohde Christiansen.
250
251         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
252
253         * MiniBrowser/efl/main.c:
254         (_Browser_Window):
255         (search_box_show):
256         (search_box_hide):
257         (on_key_down):
258         (on_url_changed):
259         (on_search_field_aborted):
260         (on_search_field_activated):
261         (on_search_field_clicked):
262         (on_search_backward_button_clicked):
263         (on_search_forward_button_clicked):
264         (window_create):
265
266 2013-03-14  Julie Parent  <jparent@chromium.org>
267
268         Cleanup: Remove g_resourceLoader.
269         https://bugs.webkit.org/show_bug.cgi?id=112305
270
271         Reviewed by Dirk Pranke.
272         
273         Removing another global.
274         
275         Now, each dashboard creates its own loader, rather than having
276         a general global one.
277         
278         Remove usage of g_resourceLoader.isLoadingComplete from 
279         handleLocationChange by ensuring that handleLocationChange is
280         never called before the loader is done.  It was called in two
281         places before: 1 was from the callback when the loader is done,
282         so that was obviously true, and the other was from onhashchange,
283         where it would just return rather than running.  Instead, lets
284         only register the onhashchange handler once the loader is
285         setup, so the check is no longer necessary.
286         
287         Remove isLoadingComplete since it is now unused.
288         
289         Callback for loader is now initializeHistory, rather than just
290         handleLocationChange which will set up the hashchange handler now.
291         This will all eventually be moving to a new History object.
292
293         * TestResultServer/static-dashboards/aggregate_results.html:
294         * TestResultServer/static-dashboards/dashboard_base.js:
295         (handleLocationChange):
296         (intializeHistory):
297         (decompressResults):
298         * TestResultServer/static-dashboards/flakiness_dashboard.js:
299         (generatePage):
300         * TestResultServer/static-dashboards/loader.js:
301         (.):
302         * TestResultServer/static-dashboards/loader_unittests.js:
303         * TestResultServer/static-dashboards/timeline_explorer.html:
304         * TestResultServer/static-dashboards/treemap.html:
305
306 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
307
308         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
309         https://bugs.webkit.org/show_bug.cgi?id=109404
310
311         Reviewed by Tony Chang.
312
313         Removes all the code related to smartInsertDeleteEnabled and
314         selectTrailingWhitespaceEnabled settings as they will be managed from
315         internals from now on.
316
317         * DumpRenderTree/TestRunner.cpp:
318         (TestRunner::staticFunctions):
319         * DumpRenderTree/TestRunner.h:
320         (TestRunner):
321         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
322         (WebKit):
323         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
324         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
325         (DumpRenderTree):
326         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
327         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
328         (WebTestRunner::WebTestProxy::didStopLoading):
329         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
330         (WebTestRunner::TestRunner::TestRunner):
331         (WebTestRunner::TestRunner::reset):
332         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
333         (TestRunner):
334         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
335         (WebTestRunner::WebPreferences::applyTo): Set default values for
336         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
337         Chromium DRT default values are different from Chromium browser.
338         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
339         * DumpRenderTree/chromium/WebViewHost.cpp:
340         * DumpRenderTree/chromium/WebViewHost.h:
341         (WebViewHost):
342         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
343         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
344         * DumpRenderTree/efl/TestRunnerEfl.cpp:
345         * DumpRenderTree/gtk/DumpRenderTree.cpp:
346         (resetDefaultsToConsistentValues):
347         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
348         * DumpRenderTree/mac/DumpRenderTree.mm:
349         (resetWebViewToConsistentStateBeforeTesting):
350         * DumpRenderTree/mac/TestRunnerMac.mm:
351         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
352         (WebCore::WebPage::resetSettings):
353         * DumpRenderTree/qt/TestRunnerQt.cpp:
354         * DumpRenderTree/qt/TestRunnerQt.h:
355         (TestRunnerQt):
356         * DumpRenderTree/win/DumpRenderTree.cpp:
357         (resetWebViewToConsistentStateBeforeTesting):
358         * DumpRenderTree/win/TestRunnerWin.cpp:
359         * DumpRenderTree/wx/TestRunnerWx.cpp:
360
361 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
362
363         [Qt] Disable DRT on Windows
364
365         Reviewed by Jocelyn Turcotte.
366
367         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
368
369         * qmake/mkspecs/features/configure.prf:
370
371 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
372
373         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
374         https://bugs.webkit.org/show_bug.cgi?id=110728
375
376         Reviewed by Gyuyoung Kim.
377
378         Use the page group to create the view object.
379
380         * MiniBrowser/efl/main.c:
381         (window_create):
382
383 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
384
385         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
386
387         Reviewed by Tor Arne Vestbø.
388
389         The mock versions of these web facing features should be instantiated when
390         running in DumpRenderTree only. In order for them to work, no extra Qt modules
391         such as QtLocation are actually needed.
392
393         This patch decouples enabling device orientation/motion and geolocation from
394         the underlying Qt modules and makes them available in developer builds
395         (!production_build) and backed by mock backends when running in drt.
396
397         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
398         developers the web facing features are always enabled (although requests will
399         time out) and the mock backends are enabled inside DRT, allowing for the layout
400         tests to run with less dependencies.
401
402         In addition this also enables the mock device motion client, which was
403         previously never instantiated.
404
405         * qmake/mkspecs/features/features.prf:
406
407 2013-03-14  Zeno Albisser  <zeno@webkit.org>
408
409         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
410         https://bugs.webkit.org/show_bug.cgi?id=112340
411
412         Reviewed by Simon Hausmann.
413
414         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
415         (DumpRenderTree::dump):
416             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
417         (DumpRenderTree::dumpApplicationCacheQuota):
418         * DumpRenderTree/qt/TestRunnerQt.cpp:
419         (TestRunnerQt::reset):
420         * DumpRenderTree/qt/TestRunnerQt.h:
421         (TestRunnerQt):
422
423 2013-03-14  Zeno Albisser  <zeno@webkit.org>
424
425         [Qt] Port DRT to use TestRunner::dumpAsText()
426         https://bugs.webkit.org/show_bug.cgi?id=112260
427
428         Reviewed by Benjamin Poulain.
429
430         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
431         (WebCore::DumpRenderTree::open):
432         (WebCore::methodNameStringForFailedTest):
433             Change parameter from type TestRunnerQt* to TestRunner*.
434         (WebCore::DumpRenderTree::dump):
435             TestRunnerQt::shouldDumpPixels() always returned true in our case.
436             Instead we should rely on TestRunner::generatePixelResults().
437         * DumpRenderTree/qt/TestRunnerQt.cpp:
438         (TestRunnerQt::reset):
439         * DumpRenderTree/qt/TestRunnerQt.h:
440         (TestRunnerQt):
441
442 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
443
444         Implement FontLoader interface
445         https://bugs.webkit.org/show_bug.cgi?id=98395
446
447         Reviewed by Eric Seidel.
448
449         Enable FontLoadEvents runtime flag for TestShell.
450
451         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
452         (WebTestRunner::TestInterfaces::TestInterfaces):
453
454 2013-03-13  Julie Parent  <jparent@chromium.org>
455
456         CLeanup: remove unnecessary call to parseParameters.
457         https://bugs.webkit.org/show_bug.cgi?id=112309
458
459         Reviewed by Ojan Vafai.
460         
461         We call parseCrossDashboardParameters when the dashboard initially
462         loads to set the state required for loadBuildersList, and then we
463         call it again once we are fully done with loading, so there is no
464         reason to call it in the middle of the loading process here.
465
466         * TestResultServer/static-dashboards/loader.js:
467         (.):
468
469 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
470
471         Unreviewed. Now I'm a reviewer :)
472
473         * Scripts/webkitpy/common/config/committers.py:
474
475 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
476
477         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
478         https://bugs.webkit.org/show_bug.cgi?id=112277
479
480         Reviewed by Adam Barth.
481
482         * Scripts/webkitperl/FeatureList.pm:
483         * qmake/mkspecs/features/features.pri:
484
485 2013-03-13  Adam Barth  <abarth@webkit.org>
486
487         run-perf-tests should support content_shell
488         https://bugs.webkit.org/show_bug.cgi?id=112291
489
490         Reviewed by Eric Seidel.
491
492         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
493         (PerfTestsRunner._parse_args):
494
495 2013-03-13  Oliver Hunt  <oliver@apple.com>
496
497         Simplify Checked<> multiplication
498         https://bugs.webkit.org/show_bug.cgi?id=112286
499
500         Reviewed by James Robinson.
501
502         Add tests for multiplication by zero and max to ensure we don't
503         mess them up should we ever make changes to Checked<> in future.
504
505         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
506         (TestWebKitAPI):
507
508 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
509
510         [Qt] Unreviewed prospective Windows build fix
511
512         Do the usual thing, include the moc generated code in the .cpp file instead
513         of compiling it standalone, to ensure that config.h is included, too, and
514         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
515
516         * DumpRenderTree/qt/EventSenderQt.cpp:
517
518 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
519
520         [Qt] Port TestRunner::findString to shared interface
521         https://bugs.webkit.org/show_bug.cgi?id=112147
522
523         Reviewed by Jocelyn Turcotte.
524
525         This patch also removes DumpRenderTree and some other helper classes from
526         the WebCore namespace, to which they do not really belong.
527
528         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
529         (main):
530         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
531         (DumpRenderTree::DumpRenderTree):
532         (DumpRenderTree::~DumpRenderTree):
533         (DumpRenderTree::instance):
534         (DumpRenderTree::setShouldTimeout):
535         * DumpRenderTree/qt/DumpRenderTreeQt.h:
536         (DumpRenderTree):
537         * DumpRenderTree/qt/EventSenderQt.cpp:
538         (EventSender::contextClick):
539         (EventSender::sendEvent):
540         (EventSender::postEvent):
541         * DumpRenderTree/qt/EventSenderQt.h:
542         (EventSender::isGraphicsBased):
543         * DumpRenderTree/qt/TestRunnerQt.cpp:
544         (TestRunnerQt::TestRunnerQt):
545         (TestRunner::findString):
546         (TestRunnerQt::setMockDeviceOrientation):
547         (TestRunnerQt::setGeolocationPermission):
548         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
549         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
550         (TestRunnerQt::setMockGeolocationPosition):
551         * DumpRenderTree/qt/TestRunnerQt.h:
552         (TestRunnerQt):
553
554 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
555
556         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
557         https://bugs.webkit.org/show_bug.cgi?id=112129
558
559         Reviewed by Adam Barth.
560
561         Following Chromium
562         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
563         this is being renamed to better explain what it does.
564
565         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
566
567 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
568
569         [Qt] Unreviewed trivial typo fix
570
571         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
572         TextRunner.h. Thanks Zeno :)
573
574 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
575
576         [Qt] Prepare DRT for transition to shared TestRunner interface
577         https://bugs.webkit.org/show_bug.cgi?id=112144
578
579         Reviewed by Benjamin Poulain.
580
581         Prepare Qt's DRT for a transition from the QObject based TestRunner to
582         the JSC C API based one.
583
584         This is impplemented by instantiating the QObject based testRunner in
585         the global object, then instantiating the JSC C based TestRunner
586         separately and placing it "behind" the QObject based testRunner through
587         injection of the individual functions through proxies. (prototype
588         chaining doesn't work due to the this object and Function.prototype.bind
589         doesn't work due to the native function)
590
591         This allows for porting over method by method by removing the method
592         from the QObject TestRunnerQt and implementing it in the JSC C based
593         TestRunner.
594
595         In order for this to link and run dummy implementations of all the
596         necessary TestRunner functions are provided.
597
598         * DumpRenderTree/qt/DumpRenderTree.pro:
599         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
600         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
601         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
602         (WebCore::DumpRenderTree::initJSObjects):
603         * DumpRenderTree/qt/DumpRenderTreeQt.h:
604         (DumpRenderTree):
605         * DumpRenderTree/qt/TestRunnerQt.cpp:
606         (TestRunner::~TestRunner):
607         (TestRunner::addDisallowedURL):
608         (TestRunner::queueLoad):
609         (TestRunner::removeAllVisitedLinks):
610         (TestRunner::setAcceptsEditing):
611         (TestRunner::simulateLegacyWebNotificationClick):
612         (TestRunner::setWindowIsKey):
613         (TestRunner::setAlwaysAcceptCookies):
614         (TestRunner::addOriginAccessWhitelistEntry):
615         (TestRunner::setWebViewEditable):
616         (TestRunner::clearAllApplicationCaches):
617         (TestRunner::setTextDirection):
618         (TestRunner::notifyDone):
619         (TestRunner::numberOfPendingGeolocationPermissionRequests):
620         (TestRunner::overridePreference):
621         (TestRunner::pathToLocalResource):
622         (TestRunner::removeAllWebNotificationPermissions):
623         (TestRunner::simulateWebNotificationClick):
624         (TestRunner::closeIdleLocalStorageDatabases):
625         (TestRunner::focusWebView):
626         (TestRunner::setBackingScaleFactor):
627         (TestRunner::removeChromeInputField):
628         (TestRunner::addChromeInputField):
629         (TestRunner::originsWithLocalStorage):
630         (TestRunner::deleteAllLocalStorage):
631         (TestRunner::deleteLocalStorageForOrigin):
632         (TestRunner::observeStorageTrackerNotifications):
633         (TestRunner::syncLocalStorage):
634         (TestRunner::windowCount):
635         (TestRunner::setWaitToDump):
636         (TestRunner::waitForPolicyDelegate):
637         (TestRunner::webHistoryItemCount):
638         (TestRunner::showWebInspector):
639         (TestRunner::closeWebInspector):
640         (TestRunner::evaluateInWebInspector):
641         (TestRunner::setSerializeHTTPLoads):
642         (TestRunner::apiTestNewWindowDataLoadBaseURL):
643         (TestRunner::setCustomPolicyDelegate):
644         (TestRunner::setDatabaseQuota):
645         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
646         (TestRunner::resetPageVisibility):
647         (TestRunner::keepWebHistory):
648         (TestRunner::goBack):
649         (TestRunner::originsWithApplicationCache):
650         (TestRunner::applicationCacheDiskUsageForOrigin):
651         (TestRunner::display):
652         (TestRunner::dispatchPendingLoadRequests):
653         (TestRunner::clearPersistentUserStyleSheet):
654         (TestRunner::callShouldCloseOnWebView):
655         (TestRunner::copyDecodedHostName):
656         (TestRunner::clearBackForwardList):
657         (TestRunner::clearAllDatabases):
658         (TestRunner::clearApplicationCacheForOrigin):
659         (TestRunner::apiTestGoToCurrentBackForwardItem):
660         (TestRunner::authenticateSession):
661         (TestRunner::abortModal):
662         (TestRunner::setStorageDatabaseIdleInterval):
663         (TestRunner::setAsynchronousSpellCheckingEnabled):
664         (TestRunner::setXSSAuditorEnabled):
665         (TestRunner::setSpatialNavigationEnabled):
666         (TestRunner::setScrollbarPolicy):
667         (TestRunner::setJavaScriptCanAccessClipboard):
668         (TestRunner::setAutomaticLinkDetectionEnabled):
669         (TestRunner::setUserStyleSheetEnabled):
670         (TestRunner::setUserStyleSheetLocation):
671         (TestRunner::setUseDashboardCompatibilityMode):
672         (TestRunner::setTabKeyCyclesThroughElements):
673         (TestRunner::setSmartInsertDeleteEnabled):
674         (TestRunner::setSelectTrailingWhitespaceEnabled):
675         (TestRunner::setPrivateBrowsingEnabled):
676         (TestRunner::setPluginsEnabled):
677         (TestRunner::setPopupBlockingEnabled):
678         (TestRunner::setMockSpeechInputDumpRect):
679         (TestRunner::setPersistentUserStyleSheetLocation):
680         (TestRunner::setMockGeolocationPosition):
681         (TestRunner::setMockGeolocationPositionUnavailableError):
682         (TestRunner::setMockDeviceOrientation):
683         (TestRunner::setMainFrameIsFirstResponder):
684         (TestRunner::setIconDatabaseEnabled):
685         (TestRunner::setGeolocationPermission):
686         (TestRunner::setDefersLoading):
687         (TestRunner::setCacheModel):
688         (TestRunner::setAuthorAndUserStylesEnabled):
689         (TestRunner::setAllowFileAccessFromFileURLs):
690         (TestRunner::setAppCacheMaximumSize):
691         (TestRunner::setAllowUniversalAccessFromFileURLs):
692         (TestRunner::setApplicationCacheOriginQuota):
693         (TestRunner::denyWebNotificationPermission):
694         (TestRunner::grantWebNotificationPermission):
695         (TestRunner::setValueForUser):
696         (TestRunner::setViewModeMediaFeature):
697         (TestRunner::setPageVisibility):
698         (TestRunner::addMockSpeechInputResult):
699         (TestRunner::removeOriginAccessWhitelistEntry):
700         (TestRunner::addUserScript):
701         (TestRunner::isCommandEnabled):
702         (TestRunner::evaluateScriptInIsolatedWorld):
703         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
704         (TestRunner::copyEncodedHostName):
705         (TestRunner::addUserStyleSheet):
706         (TestRunner::findString):
707         (TestRunner::execCommand):
708         (TestRunner::localStorageDiskUsageForOrigin):
709
710 2013-03-12  Julie Parent  <jparent@chromium.org>
711
712         Cleanup: Move flatten-trie to loader.
713         https://bugs.webkit.org/show_bug.cgi?id=112196
714
715         Reviewed by Dirk Pranke.
716
717         flatten-trie is used only by the loader, so move it there and make it
718         private, rather than global in dashbaord_base. Moved the corresponding
719         unit test from flakiness_dashboard_unittests to loader_unittests.
720         
721         * TestResultServer/static-dashboards/dashboard_base.js:
722         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
723         * TestResultServer/static-dashboards/loader.js:
724         (.):
725         * TestResultServer/static-dashboards/loader_unittests.js:
726
727 2013-03-12  Oliver Hunt  <oliver@apple.com>
728
729         Unbreak api tests
730
731         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
732         (TestWebKitAPI):
733
734 2013-03-12  Tim Horton  <timothy_horton@apple.com>
735
736         Unreviewed, disabling tests for Win EWS.
737
738         win-ews obviously cannot keep up with running tests, it's >300 behind.
739         Probably doesn't help that its (likely) running tests serially.
740
741         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
742         (WinEWS):
743
744 2013-03-12  Tim Horton  <timothy_horton@apple.com>
745
746         Add a --build-directory argument to delete-stale-build-files
747         https://bugs.webkit.org/show_bug.cgi?id=112198
748
749         Reviewed by Ryosuke Niwa.
750
751         * BuildSlaveSupport/delete-stale-build-files:
752         (main): Add --build-directory argument.
753
754 2013-03-12  Oliver Hunt  <oliver@apple.com>
755
756         Appease MSVC
757
758         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
759         (TestWebKitAPI):
760
761 2013-03-12  Oliver Hunt  <oliver@apple.com>
762
763         Add more Checked<> tests
764         https://bugs.webkit.org/show_bug.cgi?id=112190
765
766         Reviewed by Geoffrey Garen.
767
768         Tests!
769
770         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
771         (TestWebKitAPI):
772
773 2013-03-12  Julie Parent  <jparent@chromium.org>
774
775         Cleanup: Move loading complete function into callback, rather than global.
776         https://bugs.webkit.org/show_bug.cgi?id=112167
777
778         Reviewed by Dirk Pranke.
779         
780         Stop calling global functions, pass in proper handler to Loader
781         constructor. Note that the callback is optional, as tests, and
782         some potential dashboards, do not need one.
783
784         * TestResultServer/static-dashboards/dashboard_base.js:
785         * TestResultServer/static-dashboards/loader.js:
786         (.):
787         * TestResultServer/static-dashboards/loader_unittests.js:
788
789 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
790
791         [EFL][WK2] Add popup menu support to MiniBrowser
792         https://bugs.webkit.org/show_bug.cgi?id=108934
793
794         Reviewed by Kenneth Rohde Christiansen.
795
796         Implement popup menu support in MiniBrowser by handling popup_menu_show
797         and popup_menu_hide smart functions on the view and using the Ewk popup
798         menu API.
799
800         * MiniBrowser/efl/main.c:
801         (_Browser_Window):
802         (on_popup_menu_discarded):
803         (on_popup_menu_item_clicked):
804         (popup_menu_populate):
805         (on_popup_menu_show):
806         (on_popup_menu_hide):
807         (window_create): Use calloc() instead of malloc() to allocate memory for
808         Browser_Window. This makes sure all the structs members are initialized
809         to 0 (such as the new elm_popup_menu pointer).
810
811 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
812
813         [GTK] Set up the libPlatformGtk.la library
814         https://bugs.webkit.org/show_bug.cgi?id=111738
815
816         Reviewed by Martin Robinson.
817
818         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
819         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
820         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
821
822 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
823
824         [GTK] Enable Web Audio in development builds
825         https://bugs.webkit.org/show_bug.cgi?id=111831
826
827         Reviewed by Philippe Normand.
828
829         Web Audio is already quite well supported on the GTK port but still has a few issues
830         that must be addressed before it is enabled by default. Despite that it should be enabled
831         in development builds just so we are up-to-date with future feature infrastructure changes.
832         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
833         that's an obvious goal before enabling the feature in release builds.
834
835         * Scripts/webkitperl/FeatureList.pm:
836
837 2013-03-11  Andreas Kling  <akling@apple.com>
838
839         [Mac][WK1] Add support for alert() in MiniBrowser.
840         <http://webkit.org/b/112090>
841
842         Reviewed by Anders Carlsson.
843
844         * MiniBrowser/mac/WK1BrowserWindowController.m:
845         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
846
847 2013-03-11  Julie Parent  <jparent@chromium.org>
848
849         Dashboard cleanup: Create ui.Errors
850         https://bugs.webkit.org/show_bug.cgi?id=111785
851
852         Reviewed by Ojan Vafai.
853         
854         Create ui.Errors for handling errors the dashboards
855         encounter. Loader now has a Error object that it can add to,
856         and individual dashboards can show errors when desired.
857         Currently, only flakiness_db shows errors, but this is 
858         generic and there is no reason why other dbs wouldn't want to
859         show errors.
860
861         * TestResultServer/static-dashboards/dashboard_base.js:
862         (resourceLoadingComplete):
863         * TestResultServer/static-dashboards/flakiness_dashboard.js:
864         (generatePage):
865         * TestResultServer/static-dashboards/loader.js:
866         (.):
867         * TestResultServer/static-dashboards/ui.js:
868         (.):
869
870 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
871
872         Some StringHasher tests are broken because of missing null termination
873         https://bugs.webkit.org/show_bug.cgi?id=111284
874
875         Reviewed by Darin Adler.
876
877         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
878         (TestWebKitAPI): Added null termination since C strings are null-terminated.
879         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
880         the bug caught by it is now fixed.
881
882 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
883
884         Unreviewed, rolling out r145200.
885         http://trac.webkit.org/changeset/145200
886         https://bugs.webkit.org/show_bug.cgi?id=112063
887
888         Broke a couple of unit tests (Requested by zdobersek on
889         #webkit).
890
891         * Scripts/webkitperl/FeatureList.pm:
892
893 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
894
895         [GTK] WebKit2-only build fails
896         https://bugs.webkit.org/show_bug.cgi?id=112033
897
898         Reviewed by Gustavo Noronha Silva.
899
900         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
901         generic part, WebKit1-specific part and WebKit2-specific part.
902         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
903         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
904         directly.
905
906 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
907
908         Adding myself to the committers list.
909
910         Unreviewed.
911
912         * Scripts/webkitpy/common/config/committers.py:
913
914 2013-03-11  Jeff Rogers  <jrogers@rim.com>
915
916         [BlackBerry] Disable MathML support
917         https://bugs.webkit.org/show_bug.cgi?id=111929
918
919         Reviewed by Rob Buis.
920
921         * Scripts/webkitperl/FeatureList.pm:
922
923 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
924
925         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
926         https://bugs.webkit.org/show_bug.cgi?id=111970
927
928         Reviewed by Chris Fleizach.
929
930         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
931         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
932         undefined symbol.
933
934         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
935         (WTR::AccessibilityUIElement::supportedActions):
936         (WTR):
937
938 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
939
940         [chromium] Android apk targets should depend directly on Java library targets
941         https://bugs.webkit.org/show_bug.cgi?id=111746
942
943         Reviewed by Eric Seidel.
944
945         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
946         Make DumpRenderTree_apk depend directly on base_java and net_java.
947         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
948         Make TestWebKitAPI_apk depend directly on base_java.
949
950 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
951
952         [chromium] remove obsolete user gesture methods from WebFrame
953         https://bugs.webkit.org/show_bug.cgi?id=111696
954
955         Reviewed by Adam Barth.
956
957         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
958         (WebTestRunner::TestPlugin::handleInputEvent):
959         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
960
961 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
962
963         Unreviewed, add myself to commiters.py.
964
965         * Scripts/webkitpy/common/config/committers.py:
966
967 2013-03-08  Julie Parent  <jparent@chromium.org>
968
969         Cleanup: Remove dead code.
970         https://bugs.webkit.org/show_bug.cgi?id=111900
971
972         Reviewed by Dirk Pranke.
973         
974         Treemap overrides a global function that used to be in 
975         dashboard_base, but was removed months ago in
976         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
977         no caller. 
978
979         * TestResultServer/static-dashboards/treemap.html:
980
981 2013-03-08  Harald Alvestrand  <hta@chromium.org>
982
983         Implemented new API for RTCStatsReport object.
984         https://bugs.webkit.org/show_bug.cgi?id=110333
985
986         Reviewed by Adam Barth.
987
988         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
989         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
990
991 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
992
993         [chromium] use custom freetype on linux asan builds again
994         https://bugs.webkit.org/show_bug.cgi?id=111884
995
996         Reviewed by Tony Chang.
997
998         We no longer need the workaround after chromium r186540.
999
1000         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1001
1002 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
1003
1004         Warning about the user not having edit rights on Bugzilla is confusing new contributors
1005         https://bugs.webkit.org/show_bug.cgi?id=111798
1006
1007         Reviewed by Dirk Pranke.
1008
1009         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
1010
1011         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1012
1013 2013-03-08  James Robinson  <jamesr@chromium.org>
1014
1015         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
1016         https://bugs.webkit.org/show_bug.cgi?id=111632
1017
1018         Reviewed by Adrienne Walker.
1019
1020         * DumpRenderTree/chromium/WebViewHost.cpp:
1021         (WebViewHost::initializeLayerTreeView):
1022         * DumpRenderTree/chromium/WebViewHost.h:
1023         (WebViewHost):
1024
1025 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
1026
1027         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
1028         https://bugs.webkit.org/show_bug.cgi?id=111297
1029
1030         Reviewed by Kenneth Rohde Christiansen.
1031
1032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1033         (WTR::TestRunner::setViewModeMediaFeature):
1034
1035 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
1036
1037         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
1038         https://bugs.webkit.org/show_bug.cgi?id=111814
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         Add the needed supportedActions() attribute to WKTestRunner.
1043
1044         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1045         (WTR::AccessibilityUIElement::supportedActions):
1046         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1047         (AccessibilityUIElement):
1048         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1049         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1050         (WTR::AccessibilityUIElement::supportedActions):
1051
1052 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1053
1054         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
1055         https://bugs.webkit.org/show_bug.cgi?id=111851
1056
1057         Reviewed by Kenneth Rohde Christiansen.
1058
1059         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1060         (TestWebKitAPI::TEST):
1061
1062             Fixed WKURLRef instance leaking.
1063
1064 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1065
1066         [EFL] [WK2] Some authentication tests fail in WebKit2
1067         https://bugs.webkit.org/show_bug.cgi?id=106407
1068
1069         Reviewed by Kenneth Rohde Christiansen.
1070
1071         Add patch from upstream for libsoup 2.40 to fix several authentication
1072         test cases.
1073
1074         * efl/jhbuild.modules:
1075         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
1076
1077 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
1078
1079         [GTK] Enable Web Audio in development builds
1080         https://bugs.webkit.org/show_bug.cgi?id=111831
1081
1082         Reviewed by Philippe Normand.
1083
1084         Web Audio is already quite well supported on the GTK port but still has a few issues
1085         that must be addressed before it is enabled by default. Despite that it should be enabled
1086         in development builds just so we are up-to-date with future feature infrastructure changes.
1087         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
1088         that's an obvious goal before enabling the feature in release builds.
1089
1090         * Scripts/webkitperl/FeatureList.pm:
1091
1092 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1093
1094         [chromium] delay clearing the TestRunners until the main view was deleted
1095         https://bugs.webkit.org/show_bug.cgi?id=111823
1096
1097         Reviewed by Eric Seidel.
1098
1099         During WebViewHost::shutdown, we navigate the WebView to about:blank.
1100         This may call into the test runners which assume that the delegate is
1101         always non-NULL.
1102
1103         * DumpRenderTree/chromium/TestShell.cpp:
1104         (TestShell::~TestShell):
1105
1106 2013-03-07  Alan Cutter  <alancutter@chromium.org>
1107
1108         Sheriffbot whois command can't search by full name
1109         https://bugs.webkit.org/show_bug.cgi?id=111825
1110
1111         Reviewed by Eric Seidel.
1112
1113         Allowed multiple arguments to Sheriffbot's whois command.
1114         Updated test expectations.
1115
1116         * Scripts/webkitpy/tool/bot/irc_command.py:
1117         (Whois.execute):
1118         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1119         (IRCCommandTest.test_whois):
1120
1121 2013-03-07  Nils Barth  <nbarth@chromium.org>
1122
1123         Add Nils Barth and Koji Hara to committers.py
1124         https://bugs.webkit.org/show_bug.cgi?id=111806
1125
1126         Reviewed by Eric Seidel.
1127
1128         * Scripts/webkitpy/common/config/committers.py:
1129
1130 2013-03-07  Glenn Adams  <glenn@skynav.com>
1131
1132         run-pert-tests should have a --test-runner-count option
1133         https://bugs.webkit.org/show_bug.cgi?id=111726
1134
1135         Reviewed by Ryosuke Niwa.
1136
1137         Add --test-runner-count option to run-perf-tests, with default value of 4.
1138         This option allows command line configuration of the number of times to invoke
1139         the test runner (serially, not in parallel) when running a specific test in
1140         a test set.
1141
1142         * Scripts/webkitpy/performance_tests/perftest.py:
1143         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
1144         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
1145         (PerfTest.run): Rename process_run_count to test_runner_count.
1146         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
1147         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
1148         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
1149         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
1150         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1151         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
1152         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
1153         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1154         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
1155         (MainTest.test_run_with_repeat):
1156         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
1157         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1158         (MainTest.test_default_args): Add test for default option argument values.
1159         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
1160
1161 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
1162
1163         Add myself to reviewers.py
1164         https://bugs.webkit.org/show_bug.cgi?id=111757
1165
1166         Reviewed by Eric Seidel.
1167
1168         * Scripts/webkitpy/common/config/committers.py:
1169
1170 2013-03-07  Glenn Adams  <glenn@skynav.com>
1171
1172         run-perf-tests should have a --repeat option
1173         https://bugs.webkit.org/show_bug.cgi?id=100030
1174
1175         Reviewed by Ryosuke Niwa.
1176
1177         Add --repeat option to run-perf-tests, with default value of 1. When greater
1178         than 1, runs test set specified number of times. Note that multiple runs are
1179         not aggregated for statistical purposes.
1180
1181         Incidentally fixed typo: s/suceeds/succeeds/.
1182
1183         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1184         (PerfTestsRunner._parse_args): Add repeat option.
1185         (PerfTestsRunner.run): Add outer repeat loop.
1186         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
1187         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
1188         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1189         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
1190         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
1191         (MainTest.test_run_with_json_output): Fix typo.
1192         (MainTest.test_run_with_description): Fix typo.
1193         (MainTest.test_run_respects_no_results): Fix typo.
1194         (MainTest.test_run_with_slave_config_json): Fix typo.
1195         (MainTest.test_run_with_multiple_repositories): Fix typo.
1196         (MainTest.test_run_with_upload_json): Fix typo.
1197         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
1198         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
1199         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1200         (MainTest.test_parse_args): Add test for repeat option parsing.
1201
1202 2013-03-07  Julie Parent  <jparent@chromium.org>
1203
1204         showAllRuns checkbox no longer works on the stats dashboard
1205         https://bugs.webkit.org/show_bug.cgi?id=111673
1206
1207         Reviewed by Ojan Vafai.
1208
1209         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
1210         so we were trying to index into an undefined object.
1211         
1212         * TestResultServer/static-dashboards/dashboard_base.js:
1213         (invalidateQueryParameters):
1214
1215 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
1216
1217         [Chromium] Update #include for WebStorageNamespace.h
1218         https://bugs.webkit.org/show_bug.cgi?id=111748
1219
1220         Reviewed by Adam Barth.
1221
1222         In anticipation of removing
1223         WK/chromium/public/WebStorageNamespace.h (once downstream
1224         references have been updated)
1225
1226         * DumpRenderTree/chromium/WebViewHost.cpp:
1227
1228 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1229
1230         run-perf-tests fails due to svn_revision not working on a pure git clone
1231         https://bugs.webkit.org/show_bug.cgi?id=110839
1232
1233         Reviewed by Ryosuke Niwa.
1234
1235         Previously we would call git svn find-rev to look up the commit for
1236         a given revision, and that'll hang in a pure git checkout.
1237
1238         This patch changes the way we look up svn revisions in a git
1239         repository to use git log --grep 'git-svn-id', which is much faster
1240         than grepping ourselves. It also renames timestamp_of_latest_commit()
1241         to timestamp_of_revision() in order to accurately reflect what
1242         the method is doing. Note that this patch only changes the logic
1243         inside latest_revision() and svn_revision(). I'll file a separate
1244         bug to change git_commit_from_svn_revision().
1245
1246         This patch also contains some fixes to unit tests that had bit-rotted
1247         or were otherwise fragile, so that test-webkitpy --all would pass
1248         cleanly, and a fix to outputcapture so that
1249         test-webkitpy -p would work correctly again.
1250
1251         * Scripts/webkitpy/common/checkout/scm/git.py:
1252         (Git.svn_revision):
1253         (Git.timestamp_of_revision):
1254         * Scripts/webkitpy/common/checkout/scm/scm.py:
1255         (SCM.svn_revision):
1256         (SCM.timestamp_of_revision):
1257         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1258         (MockSCM.timestamp_of_revision):
1259         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1260         (_shared_test_commit_with_message):
1261         (test_commit_without_authorization):
1262         (test_timestamp_of_revision):
1263         * Scripts/webkitpy/common/checkout/scm/svn.py:
1264         (SVN.timestamp_of_revision):
1265         * Scripts/webkitpy/common/system/outputcapture.py:
1266           Importing unittest2 directly may not be safe if this module is
1267           imported before the autoinstaller gets a chance to set things up
1268           properly. We don't actually need unittest2 here.
1269         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1270         (PerfTestsRunner._generate_results_dict):
1271
1272 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1273
1274         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
1275         https://bugs.webkit.org/show_bug.cgi?id=111756
1276
1277         Reviewed by Kenneth Rohde Christiansen.
1278
1279         Bump libsoup to v2.40.3 to fix the regressions introduced by
1280         previous v2.40.0 bump.
1281
1282         * efl/jhbuild.modules:
1283
1284 2013-03-07  Roger Fong  <roger_fong@apple.com>
1285
1286         Re-enable Win EWS tests.
1287
1288         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1289         (WinEWS):
1290
1291 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1292
1293         [nrwt] handle corrupt http server pid files cleanly
1294         https://bugs.webkit.org/show_bug.cgi?id=111628
1295
1296         Reviewed by Eric Seidel.
1297
1298         If the pid file from a previous http server is corrupt for some
1299         reason, NRWT will just raise errors and not clean it up or recover.
1300         This patch fixes that to at least delete the pid file and
1301         not throw; not that we may still have stale http servers left on
1302         the system, since there's no way to know which pid to kill if
1303         the file was corrupted.
1304
1305         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1306         (HttpServerBase.start):
1307         (HttpServerBase.stop):
1308         (HttpServerBase._remove_pid_file):
1309         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
1310         (TestHttpServerBase):
1311         (TestHttpServerBase.test_corrupt_pid_file):
1312
1313 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
1314
1315         AX: Can't activate links with VoiceOver in Safari
1316         https://bugs.webkit.org/show_bug.cgi?id=111755
1317
1318         Reviewed by Tim Horton.
1319
1320         * DumpRenderTree/AccessibilityUIElement.cpp:
1321         (supportedActionsCallback):
1322         (AccessibilityUIElement::getJSClass):
1323         * DumpRenderTree/AccessibilityUIElement.h:
1324         (AccessibilityUIElement):
1325         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1326         (AccessibilityUIElement::supportedActions):
1327
1328 2013-03-07  Roger Fong  <roger_fong@apple.com>
1329
1330         Windows debug layout tests are crashing like crazy again.
1331         Disable tests on Win EWS bots temporarily.
1332
1333         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1334         (WinEWS):
1335
1336 2013-03-07  Roger Fong  <roger_fong@apple.com>
1337
1338         Make EWS bots build and test in release.
1339
1340         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1341         (WinEWS):
1342         * Scripts/webkitpy/tool/steps/runtests.py:
1343         (RunTests.run):
1344
1345 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1346
1347         [chromium] don't track the top loading frame if no layout test is currently running
1348         https://bugs.webkit.org/show_bug.cgi?id=111716
1349
1350         Reviewed by Kentaro Hara.
1351
1352         In DRT, we synchronously stop the test and start loading the next test
1353         URL. However, in content_shell, this happens asynchronously. It's
1354         important that the top loading frame is not changed due to stray
1355         navigation events before the next test starts.
1356
1357         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1358         (WebTestRunner::TestRunner::setTopLoadingFrame):
1359
1360 2013-03-06  Julie Parent  <jparent@chromium.org>
1361
1362         Dashboard cleanup: Move all dashboard ui related code into ui.js.
1363         https://bugs.webkit.org/show_bug.cgi?id=111621
1364
1365         Reviewed by Ojan Vafai.
1366         
1367         Creates ui.js, a package for the common UI code the various
1368         dashboards use. HTML generation is now in the ui.html namespace
1369         and popup handling is in ui.popup.
1370         Also moves the event listening for popups to ui.popup.show and
1371         removes it on ui.popup.hid rather than having listener always
1372         around.
1373
1374         * TestResultServer/static-dashboards/aggregate_results.html:
1375         * TestResultServer/static-dashboards/dashboard_base.js:
1376         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1377         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1378         (showPopupForBuild):
1379         (htmlForNavBar):
1380         (generatePageForIndividualTests.if):
1381         (generatePageForIndividualTests):
1382         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
1383         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1384         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1385         * TestResultServer/static-dashboards/run-unittests.html:
1386         * TestResultServer/static-dashboards/timeline_explorer.html:
1387         * TestResultServer/static-dashboards/treemap.html:
1388         * TestResultServer/static-dashboards/ui.js: Added.
1389         (.):
1390
1391 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
1392
1393         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
1394         https://bugs.webkit.org/show_bug.cgi?id=110584
1395
1396         Reviewed by Gyuyoung Kim.
1397
1398         Adds missing implementation of AccessibilityControllerEfl
1399         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
1400         so that it can make accessibilityController as a js object.
1401
1402         * DumpRenderTree/AccessibilityController.h:
1403         (AccessibilityController):
1404         * DumpRenderTree/AccessibilityUIElement.h:
1405         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1406         (AccessibilityController::childElementById): Moved declaration to base class.
1407         Implementation can be shared among other ports.
1408         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
1409         (AccessibilityController::focusedElement):
1410         (AccessibilityController::rootElement):
1411         (AccessibilityController::accessibleElementById):
1412         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
1413         (AccessibilityUIElement::helpText):
1414         * DumpRenderTree/efl/CMakeLists.txt:
1415         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1416         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1417         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1418         (DumpRenderTreeChrome::onWindowObjectCleared):
1419         (DumpRenderTreeChrome::accessibilityController):
1420         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1421         (DumpRenderTreeChrome):
1422         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1423
1424 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
1425
1426         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
1427         https://bugs.webkit.org/show_bug.cgi?id=42696
1428
1429         Reviewed by Andreas Kling.
1430
1431         * DumpRenderTree/TestRunner.cpp:
1432         (TestRunner::staticFunctions):
1433         * DumpRenderTree/TestRunner.h:
1434         (TestRunner):
1435         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1436         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1437         (WebTestRunner::TestRunner::TestRunner):
1438         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1439         (TestRunner):
1440         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1441         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1442         * DumpRenderTree/mac/TestRunnerMac.mm:
1443         * DumpRenderTree/qt/TestRunnerQt.cpp:
1444         * DumpRenderTree/qt/TestRunnerQt.h:
1445         (TestRunnerQt):
1446         * DumpRenderTree/win/TestRunnerWin.cpp:
1447         * DumpRenderTree/wx/TestRunnerWx.cpp:
1448
1449 2013-03-06  Roger Fong  <roger_fong@apple.com>
1450
1451         Re-enable WinEWS test and decrease iterations before clean build back to 10.
1452
1453         * EWSTools/start-queue-win.sh:
1454         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1455         (WinEWS):
1456
1457 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
1458
1459         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
1460         https://bugs.webkit.org/show_bug.cgi?id=82866
1461
1462         Reviewed by Martin Robinson.
1463
1464         * Scripts/run-gtk-tests:
1465         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
1466         it is passing now.
1467
1468 2013-03-06  Julie Parent  <jparent@chromium.org>
1469
1470         Dashboard cleanup: remove dashboard time logging.
1471         https://bugs.webkit.org/show_bug.cgi?id=111608
1472
1473         Reviewed by Dirk Pranke.
1474
1475         Remove logTime.  It was never accurate, and the dev tools
1476         have better ways to measure this if anyone cares to look
1477         into dashboard perf.
1478         
1479         * TestResultServer/static-dashboards/dashboard_base.js:
1480         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1481         (processTestRunsForBuilder):
1482         (appendHTML):
1483
1484 2013-03-06  Tony Chang  <tony@chromium.org>
1485
1486         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1487         https://bugs.webkit.org/show_bug.cgi?id=111509
1488
1489         Reviewed by Dirk Pranke.
1490
1491         Add DumpRenderTree.pak to DumpRenderTree.app again.
1492
1493         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1494
1495 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
1496
1497         [chromium] introduce WebUserGestureIndicator
1498         https://bugs.webkit.org/show_bug.cgi?id=111531
1499
1500         Reviewed by Adam Barth.
1501
1502         * DumpRenderTree/chromium/WebViewHost.cpp:
1503         (WebViewHost::createView):
1504
1505 2013-03-06  Alan Cutter  <alancutter@chromium.org>
1506
1507         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
1508         https://bugs.webkit.org/show_bug.cgi?id=73482
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         Added input checking to the UpdateChromiumDEPS step.
1513         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
1514
1515         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
1516         (RollChromiumDEPS):
1517         (RollChromiumDEPS._parse_args):
1518         (RollChromiumDEPS.execute):
1519         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
1520         (IRCCommandTest.test_roll_chromium_deps):
1521         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
1522         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
1523         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
1524         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
1525         (UpdateChromiumDEPS._fetch_last_known_good_revision):
1526         (UpdateChromiumDEPS):
1527         (UpdateChromiumDEPS._parse_revision_number):
1528         (UpdateChromiumDEPS._validate_revisions):
1529         (UpdateChromiumDEPS.run):
1530         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
1531         (UpdateChromiumDEPSTest):
1532         (UpdateChromiumDEPSTest.test_parse_revision_number):
1533         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
1534         (RollChromiumDEPS):
1535         (PostChromiumDEPSRoll):
1536
1537 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
1538
1539         [Qt][MiniBrowser] Touch mocking broken for chained getures
1540         https://bugs.webkit.org/show_bug.cgi?id=111430
1541
1542         Reviewed by Jocelyn Turcotte.
1543
1544         Make it possible again to use touch mocking to test gesture chains
1545         like pan->pinch->pan->pinch without lifting the primary "finger".
1546         For this to work we need to track the pressed mouse buttons and
1547         only synthesize touch release events when the ctrl key is released
1548         if no mouse button is pressed. Else the pressed mouse button(s)
1549         should result in a stationary touch point in a touch update event.
1550         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
1551         to check for the state of the ctrl key modifier instead of getting
1552         it from the mouse events.
1553
1554         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1555         (MiniBrowserApplication::MiniBrowserApplication):
1556         (MiniBrowserApplication::notify):
1557
1558 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1559
1560         [chromium] don't use custom freetype on linux asan for now
1561         https://bugs.webkit.org/show_bug.cgi?id=111516
1562
1563         Unreviewed, build fix.
1564
1565         Turns out the custom lib is getting picked up by other binaries
1566         on our bot, which is bad.
1567
1568         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1569
1570 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1571
1572         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1573         https://bugs.webkit.org/show_bug.cgi?id=111509
1574
1575         Unreviewed, build fix.
1576
1577         Actually comment out the flag :(.
1578
1579         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1580
1581 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1582
1583         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1584         https://bugs.webkit.org/show_bug.cgi?id=111509
1585
1586         Unreviewed, build fix.
1587
1588         r144863 appears to have broken the xcode build; I'm temporarily
1589         trying this instead, and if this doesn't work, I'll revert the
1590         other changes.
1591
1592         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1593
1594 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1595
1596         [chromium] build a DumpRenderTree.pak even on windows
1597         https://bugs.webkit.org/show_bug.cgi?id=111504
1598
1599         Reviewed by Tony Chang.
1600
1601         The Chromium Aura build uses the default theme to draw
1602         controls, and that theme requires the ui ResourceBundle
1603         to be initialized. On every other platform, we build
1604         a DumpRenderTree.pak that works for this, but on Windows we
1605         still compile the resources directly into DRT. As a first step,
1606         let's build the pak file. I will then need to land a patch
1607         in Chromium to actually load it. Then I can go back and move
1608         the resources over to just use the .pak file and no longer need
1609         the .rc's.
1610
1611         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1612
1613 2013-03-05  Julie Parent  <jparent@chromium.org>
1614         Dashboard cleanup: move string utilities into their own namespace.
1615         
1616         https://bugs.webkit.org/show_bug.cgi?id=111485
1617
1618         Reviewed by Ojan Vafai.
1619         
1620         One of many pieces to clean up dashboard_base.
1621         
1622         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
1623
1624         * TestResultServer/static-dashboards/aggregate_results.html:
1625         * TestResultServer/static-dashboards/dashboard_base.js:
1626         (isTreeMap):
1627         (isFlakinessDashboard):
1628         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1629         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1630         (determineWKPlatform):
1631         (chromiumPlatform):
1632         (platformAndBuildType):
1633         (substringList):
1634         (individualTestsForSubstringList):
1635         (filterBugs):
1636         (populateExpectationsData):
1637         (processMissingTestsWithExpectations):
1638         (processMissingAndExtraExpectations):
1639         (htmlForSingleTestRow):
1640         (.dummyNode.onload):
1641         (expectationsTitle):
1642         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1643         * TestResultServer/static-dashboards/run-unittests.html:
1644         * TestResultServer/static-dashboards/string.js: Added.
1645         * TestResultServer/static-dashboards/timeline_explorer.html:
1646         * TestResultServer/static-dashboards/treemap.html:
1647
1648 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
1649
1650         [EFL] Build break with latest EFL libraries
1651         https://bugs.webkit.org/show_bug.cgi?id=111028
1652
1653         Reviewed by Dirk Pranke.
1654
1655         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
1656         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1657         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1658
1659 2013-03-05  Roger Fong  <roger_fong@apple.com>
1660
1661         Increase number of WinEWS iterations to 20.
1662         Don't reboot after each iteration set.
1663         Make EWS bots just build temporarily so that the queue catches up again.
1664
1665         * EWSTools/start-queue-win.sh:
1666         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1667         (WinEWS):
1668
1669 2013-03-04  James Robinson  <jamesr@chromium.org>
1670
1671         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
1672         https://bugs.webkit.org/show_bug.cgi?id=111386
1673
1674         Reviewed by Adrienne Walker.
1675
1676         * DumpRenderTree/chromium/TestShell.cpp:
1677         (TestShell::initialize):
1678
1679 2013-03-05  Min Qin  <qinmin@chromium.org>
1680
1681         Copy dictionary to the external storage before running layout test on android
1682         https://bugs.webkit.org/show_bug.cgi?id=111480
1683
1684         Reviewed by Adam Barth.
1685
1686         TestWebKitPlatformSupport now needs to read an external dictionary file.
1687         This file does not exist on the device. We need to copy it before running layout tests.
1688
1689         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1690         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1691         (ChromiumAndroidDriver._push_platform_resources):
1692
1693 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1694
1695         [chromium] DRT crashes in an Aura/Win build
1696         https://bugs.webkit.org/show_bug.cgi?id=111394
1697
1698         Reviewed by Tony Chang.
1699
1700         When building (and running) with use_aura=1, we assume that
1701         we're using the default theme engine, but DRT creates the
1702         DRTWin theme engine and overwrites the default, leading to crashes
1703         in basically every test from the mismatch.
1704
1705         This fix gets us down to at least "lots of crashes" :).
1706
1707         * DumpRenderTree/chromium/TestShellWin.cpp:
1708         (platformInit):
1709
1710 2013-03-05  Eric Seidel  <eric@webkit.org>
1711
1712         Add html-parser-threaded perf test now that the threaded parser is enabled by default
1713         https://bugs.webkit.org/show_bug.cgi?id=111200
1714
1715         Reviewed by Ryosuke Niwa.
1716
1717         Had to teach run-perf-tests to ignore one more warning.
1718
1719         * Scripts/webkitpy/performance_tests/perftest.py:
1720         (PerfTest):
1721
1722 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1723
1724         Update list of builders for test results server
1725         https://bugs.webkit.org/show_bug.cgi?id=111166
1726
1727         Reviewed by Ojan Vafai.
1728
1729         * TestResultServer/static-dashboards/builders.jsonp:
1730
1731 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
1732
1733         [GTK] Move basic dependency installation to a script
1734         https://bugs.webkit.org/show_bug.cgi?id=110692
1735
1736         Reviewed by Gustavo Noronha Silva.
1737
1738         * gtk/install-dependencies: Added. A Script which installs all dependencies
1739         necessary for building for Debian-based distributions and Fedora.
1740
1741 2013-03-05  James Robinson  <jamesr@chromium.org>
1742
1743         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
1744         https://bugs.webkit.org/show_bug.cgi?id=111440
1745
1746         Reviewed by Adrienne Walker.
1747
1748         Remove unnecessary WebCompositorSupport::shutdown call
1749
1750         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1751         (main):
1752
1753 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1754
1755         Unreviewed build fix.
1756
1757         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1758
1759 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1760
1761         [Qt][MiniBrowser] Improve the update of touch indicators
1762         https://bugs.webkit.org/show_bug.cgi?id=111429
1763
1764         Reviewed by Jocelyn Turcotte.
1765
1766         MiniBrowserApplication::sendTouchEvent sends an empty list
1767         to BrowserWindow::updateVisualMockTouchPoints if the control
1768         button is released, in which case the touch indicators should
1769         be hidden so that we never end up with a leftover indicator
1770         sticking on the screen.
1771         This patch also simplifies the lookup of the indicator items by
1772         replacing the findChild search in the item tree with a QHash
1773         that stores the touch ID's and the pointers to the corresponding
1774         indicator items.
1775
1776         * MiniBrowser/qt/BrowserWindow.cpp:
1777         (BrowserWindow::updateVisualMockTouchPoints):
1778         * MiniBrowser/qt/BrowserWindow.h:
1779         (BrowserWindow):
1780
1781 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1782
1783         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1784         https://bugs.webkit.org/show_bug.cgi?id=81042
1785
1786         Reviewed by Enrica Casucci.
1787
1788         Add setAsynchronousSpellCheckingEnabled implementation for
1789         WebKitTestRunner to have the possibility to test asynchronous
1790         spell checking implementation from bug 109577.
1791
1792         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1793         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1794         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1795         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1796         * WebKitTestRunner/TestController.cpp:
1797         (WTR::TestController::resetStateToConsistentValues):
1798
1799 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1800
1801         MediaStream API: Add the getStreamById method on RTCPeerConnection
1802         https://bugs.webkit.org/show_bug.cgi?id=111311
1803
1804         Reviewed by Adam Barth.
1805
1806         Changing mocks to be more realistic.
1807
1808         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1809         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1810         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1811         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1812         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1813
1814 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1815
1816         Add content shell bots to garden-o-matic for general failurse
1817         https://bugs.webkit.org/show_bug.cgi?id=111168
1818
1819         Reviewed by Adam Barth.
1820
1821         All but the WebKit (Content Shell) Android bot is stable enough. While
1822         they're not green yet, there must not be any non-layout test failures on
1823         them.
1824
1825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1826         (.):
1827
1828 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1829
1830         [chromium] remove deprecated WebTestRunner::setFocus API
1831         https://bugs.webkit.org/show_bug.cgi?id=111354
1832
1833         Reviewed by James Robinson.
1834
1835         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1836         (WebTestDelegate):
1837
1838 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1839
1840         Run the bindings generation tests on EWS and CQ bots
1841         https://bugs.webkit.org/show_bug.cgi?id=111358
1842
1843         Reviewed by Adam Barth.
1844
1845         The tests are super fast and not flaky.
1846
1847         * Scripts/webkitpy/common/config/ports.py:
1848         (DeprecatedPort.run_bindings_tests_command):
1849         * Scripts/webkitpy/common/config/ports_mock.py:
1850         (MockPort.run_webkit_tests_command):
1851         (MockPort):
1852         (MockPort.run_bindings_tests_command):
1853         * Scripts/webkitpy/tool/commands/download_unittest.py:
1854         * Scripts/webkitpy/tool/steps/runtests.py:
1855         (RunTests.run):
1856         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1857         (RunTestsTest.test_webkit_run_unit_tests):
1858         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1859
1860 2013-03-04  Eric Seidel  <eric@webkit.org>
1861
1862         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1863         https://bugs.webkit.org/show_bug.cgi?id=111384
1864
1865         Reviewed by Ryosuke Niwa.
1866
1867         Sometimes I want to know why various LayoutTests are slow
1868         without having to convert them into PerformanceTests in order
1869         to use our fancy profiling.  The Driver already knows how to
1870         do the right thing, we just need to expose the options to the user.
1871
1872         Handling of these options is already unittested in the perftests_unittest.
1873
1874         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1875         (parse_args):
1876
1877 2013-03-04  Alan Cutter  <alancutter@chromium.org>
1878
1879         check-webkit-style says "Have to enable auto props in the subversion config file"
1880         https://bugs.webkit.org/show_bug.cgi?id=107724
1881
1882         Reviewed by Tony Chang.
1883
1884         Added a standard svn config file for WebKit developers to use.
1885         Updated the style and commit queue bot build scripts to load this file.
1886
1887         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1888         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1889         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1890         * svn-config: Added.
1891
1892 2013-03-04  James Robinson  <jamesr@chromium.org>
1893
1894         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
1895         https://bugs.webkit.org/show_bug.cgi?id=111285
1896
1897         Reviewed by Adrienne Walker.
1898
1899         This removes the need for WebCompositorSupport::initialize and exposes
1900         slightly fewer entry points across the repository boundary.
1901
1902         * DumpRenderTree/chromium/TestShell.cpp:
1903         (TestShell::initialize):
1904         * DumpRenderTree/chromium/TestShell.h:
1905         (TestShell::webCompositorThread):
1906         (TestShell):
1907         * DumpRenderTree/chromium/WebViewHost.cpp:
1908         (WebViewHost::initializeLayerTreeView):
1909
1910 2013-03-04  Roger Fong  <roger_fong@apple.com>
1911
1912         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
1913
1914         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1915
1916 2013-03-04  David Kilzer  <ddkilzer@apple.com>
1917
1918         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
1919
1920             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
1921                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
1922                                         ^         ~~~~~~~~~~~~~~~~~~~~~
1923             1 error generated.
1924
1925         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
1926         AccessibilityCommonMac.h.
1927
1928 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1929
1930         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
1931         https://bugs.webkit.org/show_bug.cgi?id=109828
1932
1933         Reviewed by Kenneth Rohde Christiansen.
1934
1935         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
1936         callbacks.
1937
1938         * TestWebKitAPI/CMakeLists.txt:
1939
1940             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
1941             considered.
1942
1943         * TestWebKitAPI/PlatformEfl.cmake:
1944         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
1945         (TestWebKitAPI):
1946         (TestWebKitAPI::didFinishLoadForFrame):
1947         (TestWebKitAPI::setPageLoaderClient):
1948         (TestWebKitAPI::webProcessCrashed):
1949         (TestWebKitAPI::webProcessDidRelaunch):
1950         (TestWebKitAPI::setViewClient):
1951         (TestWebKitAPI::TEST):
1952
1953 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
1954
1955         AX: Upstream iOS Accessibility DumpRenderTree changes
1956         https://bugs.webkit.org/show_bug.cgi?id=111220
1957
1958         Reviewed by David Kilzer.
1959
1960         Upstream the iOS changes for accessibility in DumpRenderTree.
1961
1962         * DumpRenderTree/AccessibilityUIElement.cpp:
1963         (headerElementAtIndexCallback):
1964         (linkedElementCallback):
1965         (elementsForRangeCallback):
1966         (increaseTextSelectionCallback):
1967         (decreaseTextSelectionCallback):
1968         (assistiveTechnologySimulatedFocusCallback):
1969         (stringForSelectionCallback):
1970         (getIPhoneLabelCallback):
1971         (getIPhoneHintCallback):
1972         (getIPhoneValueCallback):
1973         (getIPhoneIdentifierCallback):
1974         (getIPhoneTraitsCallback):
1975         (getIPhoneIsElementCallback):
1976         (getIPhoneElementTextPositionCallback):
1977         (getIPhoneElementTextLengthCallback):
1978         (AccessibilityUIElement::getJSClass):
1979         * DumpRenderTree/AccessibilityUIElement.h:
1980         (AccessibilityUIElement):
1981         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1982         * DumpRenderTree/ios: Added.
1983         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
1984         (AccessibilityController::AccessibilityController):
1985         (AccessibilityController::~AccessibilityController):
1986         (AccessibilityController::elementAtPoint):
1987         (AccessibilityController::focusedElement):
1988         (AccessibilityController::rootElement):
1989         (findAccessibleObjectById):
1990         (AccessibilityController::accessibleElementById):
1991         (AccessibilityController::setLogFocusEvents):
1992         (AccessibilityController::setLogScrollingStartEvents):
1993         (AccessibilityController::setLogValueChangeEvents):
1994         (AccessibilityController::setLogAccessibilityEvents):
1995         (AccessibilityController::addNotificationListener):
1996         (AccessibilityController::removeNotificationListener):
1997         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
1998         (AccessibilityUIElement::AccessibilityUIElement):
1999         (AccessibilityUIElement::~AccessibilityUIElement):
2000         (concatenateAttributeAndValue):
2001         (AccessibilityUIElement::iphoneLabel):
2002         (AccessibilityUIElement::iphoneHint):
2003         (AccessibilityUIElement::iphoneValue):
2004         (AccessibilityUIElement::iphoneIdentifier):
2005         (AccessibilityUIElement::iphoneTraits):
2006         (AccessibilityUIElement::iphoneIsElement):
2007         (AccessibilityUIElement::iphoneElementTextPosition):
2008         (AccessibilityUIElement::iphoneElementTextLength):
2009         (AccessibilityUIElement::url):
2010         (AccessibilityUIElement::x):
2011         (AccessibilityUIElement::y):
2012         (AccessibilityUIElement::width):
2013         (AccessibilityUIElement::height):
2014         (AccessibilityUIElement::clickPointX):
2015         (AccessibilityUIElement::clickPointY):
2016         (AccessibilityUIElement::getChildren):
2017         (AccessibilityUIElement::getChildrenWithRange):
2018         (AccessibilityUIElement::childrenCount):
2019         (AccessibilityUIElement::elementAtPoint):
2020         (AccessibilityUIElement::indexOfChild):
2021         (AccessibilityUIElement::getChildAtIndex):
2022         (AccessibilityUIElement::headerElementAtIndex):
2023         (AccessibilityUIElement::linkedElement):
2024         (AccessibilityUIElement::linkedUIElementAtIndex):
2025         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2026         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2027         (AccessibilityUIElement::disclosedRowAtIndex):
2028         (AccessibilityUIElement::selectedRowAtIndex):
2029         (AccessibilityUIElement::rowAtIndex):
2030         (AccessibilityUIElement::titleUIElement):
2031         (AccessibilityUIElement::parentElement):
2032         (AccessibilityUIElement::disclosedByRow):
2033         (AccessibilityUIElement::increaseTextSelection):
2034         (AccessibilityUIElement::decreaseTextSelection):
2035         (AccessibilityUIElement::stringForSelection):
2036         (AccessibilityUIElement::stringForRange):
2037         (AccessibilityUIElement::attributedStringForRange):
2038         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2039         (AccessibilityUIElement::elementsForRange):
2040         (AccessibilityUIElement::getLinkedUIElements):
2041         (AccessibilityUIElement::getDocumentLinks):
2042         (AccessibilityUIElement::attributesOfLinkedUIElements):
2043         (AccessibilityUIElement::attributesOfDocumentLinks):
2044         (AccessibilityUIElement::attributesOfChildren):
2045         (AccessibilityUIElement::allAttributes):
2046         (AccessibilityUIElement::stringAttributeValue):
2047         (AccessibilityUIElement::isPressActionSupported):
2048         (AccessibilityUIElement::isIncrementActionSupported):
2049         (AccessibilityUIElement::isDecrementActionSupported):
2050         (AccessibilityUIElement::boolAttributeValue):
2051         (AccessibilityUIElement::isAttributeSettable):
2052         (AccessibilityUIElement::isAttributeSupported):
2053         (AccessibilityUIElement::parameterizedAttributeNames):
2054         (AccessibilityUIElement::role):
2055         (AccessibilityUIElement::subrole):
2056         (AccessibilityUIElement::roleDescription):
2057         (AccessibilityUIElement::title):
2058         (AccessibilityUIElement::description):
2059         (AccessibilityUIElement::orientation):
2060         (AccessibilityUIElement::stringValue):
2061         (AccessibilityUIElement::language):
2062         (AccessibilityUIElement::helpText):
2063         (AccessibilityUIElement::intValue):
2064         (AccessibilityUIElement::minValue):
2065         (AccessibilityUIElement::maxValue):
2066         (AccessibilityUIElement::valueDescription):
2067         (AccessibilityUIElement::insertionPointLineNumber):
2068         (AccessibilityUIElement::isEnabled):
2069         (AccessibilityUIElement::isRequired):
2070         (AccessibilityUIElement::isFocused):
2071         (AccessibilityUIElement::isSelected):
2072         (AccessibilityUIElement::isExpanded):
2073         (AccessibilityUIElement::isChecked):
2074         (AccessibilityUIElement::hierarchicalLevel):
2075         (AccessibilityUIElement::ariaIsGrabbed):
2076         (AccessibilityUIElement::ariaDropEffects):
2077         (AccessibilityUIElement::lineForIndex):
2078         (AccessibilityUIElement::boundsForRange):
2079         (AccessibilityUIElement::attributesOfColumnHeaders):
2080         (AccessibilityUIElement::attributesOfRowHeaders):
2081         (AccessibilityUIElement::attributesOfColumns):
2082         (AccessibilityUIElement::attributesOfRows):
2083         (AccessibilityUIElement::attributesOfVisibleCells):
2084         (AccessibilityUIElement::attributesOfHeader):
2085         (AccessibilityUIElement::rowCount):
2086         (AccessibilityUIElement::columnCount):
2087         (AccessibilityUIElement::indexInTable):
2088         (AccessibilityUIElement::rowIndexRange):
2089         (AccessibilityUIElement::columnIndexRange):
2090         (AccessibilityUIElement::cellForColumnAndRow):
2091         (AccessibilityUIElement::selectedTextRange):
2092         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2093         (AccessibilityUIElement::setSelectedTextRange):
2094         (AccessibilityUIElement::increment):
2095         (AccessibilityUIElement::decrement):
2096         (AccessibilityUIElement::showMenu):
2097         (AccessibilityUIElement::press):
2098         (AccessibilityUIElement::accessibilityValue):
2099         (AccessibilityUIElement::documentEncoding):
2100         (AccessibilityUIElement::documentURI):
2101         (_accessibilityNotificationCallback):
2102         (AccessibilityUIElement::addNotificationListener):
2103         (AccessibilityUIElement::removeNotificationListener):
2104         (AccessibilityUIElement::isFocusable):
2105         (AccessibilityUIElement::isSelectable):
2106         (AccessibilityUIElement::isMultiSelectable):
2107         (AccessibilityUIElement::isSelectedOptionActive):
2108         (AccessibilityUIElement::isVisible):
2109         (AccessibilityUIElement::isOffScreen):
2110         (AccessibilityUIElement::isCollapsed):
2111         (AccessibilityUIElement::isIgnored):
2112         (AccessibilityUIElement::hasPopup):
2113         (AccessibilityUIElement::takeFocus):
2114         (AccessibilityUIElement::takeSelection):
2115         (AccessibilityUIElement::addSelection):
2116         (AccessibilityUIElement::removeSelection):
2117         (AccessibilityUIElement::uiElementForSearchPredicate):
2118         (AccessibilityUIElement::numberAttributeValue):
2119
2120 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
2121
2122         [chromium] pass all focus handling methods through the WebTestDelegate
2123         https://bugs.webkit.org/show_bug.cgi?id=111328
2124
2125         Reviewed by Nico Weber.
2126
2127         In content_shell, the focus handling is asynchronous. To allow for
2128         switching the focus synchronously between WebViews, we need to intercept
2129         didFocus and didBlur and forward it to the WebTestDelegate.
2130
2131         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2132         (WebTestDelegate):
2133         (WebTestRunner::WebTestDelegate::setFocus):
2134         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2135         (WebTestRunner::WebTestProxy::didFocus):
2136         (WebTestRunner::WebTestProxy::didBlur):
2137         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2138         (WebTestRunner::TestRunner::setWindowIsKey):
2139         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2140         (WebTestRunner::WebTestProxyBase::didFocus):
2141         (WebTestRunner):
2142         (WebTestRunner::WebTestProxyBase::didBlur):
2143         * DumpRenderTree/chromium/WebViewHost.cpp:
2144         (WebViewHost::didFocus):
2145         (WebViewHost::didBlur):
2146         (WebViewHost::setFocus):
2147         * DumpRenderTree/chromium/WebViewHost.h:
2148         (WebViewHost):
2149
2150 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
2151
2152         [GTK] No need to manually add system paths to jhbuildrc
2153         https://bugs.webkit.org/show_bug.cgi?id=110850
2154
2155         Reviewed by Gustavo Noronha Silva.
2156
2157         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
2158         already takes care of.
2159
2160 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
2161
2162         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
2163         https://bugs.webkit.org/show_bug.cgi?id=111284
2164
2165         Disabling the failing two tests on Android.
2166
2167         Reviewed by Jochen Eisinger.
2168
2169         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2170         (TestWebKitAPI):
2171         (TestWebKitAPI::TEST):
2172
2173 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2174
2175         Add build flag for FontLoader
2176         https://bugs.webkit.org/show_bug.cgi?id=111289
2177
2178         Reviewed by Benjamin Poulain.
2179
2180         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
2181
2182         * Scripts/webkitperl/FeatureList.pm:
2183         * qmake/mkspecs/features/features.pri:
2184
2185 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
2186
2187         [Mac] Get rid of a useless method from DOMHTMLInputElement
2188         https://bugs.webkit.org/show_bug.cgi?id=111279
2189
2190         Reviewed by Sam Weinig.
2191
2192         * DumpRenderTree/mac/TestRunnerMac.mm:
2193         (TestRunner::setValueForUser):
2194         The method _setValueForUser: was added for testing. This feature is already
2195         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
2196         in real use cases. Get rid of the method created for testing, use the real thing
2197         instead.
2198
2199 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2200
2201         Some perf. tests have variances that differ greatly between runs
2202         https://bugs.webkit.org/show_bug.cgi?id=97510
2203
2204         Reviewed by Benjamin Poulain.
2205
2206         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
2207         environment on test results (we run each instance after one another, not in parallel).
2208
2209         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
2210         iterations as it was done previously in single process. These values are hard-coded in perftest.py
2211         and runner.js but they are to be configurable in the future.
2212
2213         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
2214         metric now reports an array of the length 4 with each element containing an array of 5 iteration
2215         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
2216
2217         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
2218         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
2219         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
2220
2221         * Scripts/webkitpy/performance_tests/perftest.py:
2222         (PerfTestMetric.append_group): Renamed from append.
2223         (PerfTestMetric.grouped_iteration_values): Added.
2224         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
2225
2226         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
2227         This parameter is only used by SingleProcessPerfTest.
2228
2229         (PerfTest.run): Repeat tests using different driver processes.
2230         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
2231         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
2232         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
2233         (PerfTest._ensure_metrics): Added.
2234
2235         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
2236         instances of DumpRenderTree/WebKitTestRunner takes too long.
2237         (SingleProcessPerfTest.__init__):
2238
2239         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
2240
2241         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
2242
2243         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
2244         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
2245         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
2246
2247         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
2248         grouped_iteration_values.
2249
2250         (TestPerfTest._assert_results_are_correct):
2251
2252         (TestSingleProcessPerfTest): Added.
2253         (TestSingleProcessPerfTest.test_use_only_one_process):
2254         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
2255
2256         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2257         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2258
2259         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
2260         sample standard deviations since we're now running tests 4 times.
2261         (MainTest._test_run_with_json_output.mock_upload_json):
2262         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2263
2264 2013-03-03  Alexandre Elias  <aelias@chromium.org>
2265
2266         [chromium] Remove WebLayerTreeView::setViewportSize call
2267         https://bugs.webkit.org/show_bug.cgi?id=110727
2268
2269         Reviewed by James Robinson.
2270
2271         After https://codereview.chromium.org/12328080 lands,
2272         setViewportSize is called from the Chromium side. The multiplication
2273         by deviceScaleFactor here was prone to off-by-one errors.
2274         The layoutSize() function was only used here so delete it as well.
2275
2276         DumpRenderTree WebViewHost must now call this method as well.
2277
2278         * DumpRenderTree/chromium/WebViewHost.cpp:
2279         (WebViewHost::initializeLayerTreeView):
2280         (WebViewHost::setWindowRect):
2281         (WebViewHost::setDeviceScaleFactor):
2282         (WebViewHost::updateViewportSize):
2283         * DumpRenderTree/chromium/WebViewHost.h:
2284         (WebViewHost):
2285
2286 2013-02-27  Darin Adler  <darin@apple.com>
2287
2288         StringHasher functions require alignment that call sites do not all guarantee
2289         https://bugs.webkit.org/show_bug.cgi?id=110171
2290
2291         Reviewed by Benjamin Poulain.
2292
2293         * TestWebKitAPI/CMakeLists.txt:
2294         * TestWebKitAPI/GNUmakefile.am:
2295         * TestWebKitAPI/TestWebKitAPI.gypi:
2296         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2297         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2299         * TestWebKitAPI/Tests/WTF/WTF.pro:
2300         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2301         Added the StringHasher.cpp file.
2302
2303         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
2304         for the functions in the StringHasher class.
2305
2306 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
2307
2308         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
2309         https://bugs.webkit.org/show_bug.cgi?id=109772
2310
2311         Reviewed by Andreas Kling.
2312
2313         * DumpRenderTree/TestRunner.cpp:
2314         (TestRunner::staticFunctions):
2315         * DumpRenderTree/TestRunner.h:
2316         (TestRunner):
2317         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2318         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2319         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2320         * DumpRenderTree/mac/TestRunnerMac.mm:
2321         * DumpRenderTree/qt/TestRunnerQt.cpp:
2322         * DumpRenderTree/qt/TestRunnerQt.h:
2323         (TestRunner):
2324         * DumpRenderTree/win/TestRunnerWin.cpp:
2325         * DumpRenderTree/wx/TestRunnerWx.cpp:
2326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2327         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2328         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2329         (TestRunner):
2330
2331 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2332
2333         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
2334         https://bugs.webkit.org/show_bug.cgi?id=110943
2335
2336         Reviewed by Yury Semikhatsky.
2337
2338         Unfortunately in many cases raw pointer may point to an object that has been deleted.
2339         There is no working solution to solve this problem in general.
2340         It could be solved only on case by case basis.
2341
2342         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2343         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2344         (TestWebKitAPI::TEST):
2345
2346 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
2347
2348         Move markerTextForListItem from TestRunner to Internals
2349         https://bugs.webkit.org/show_bug.cgi?id=110939
2350
2351         Reviewed by Benjamin Poulain.
2352
2353         * DumpRenderTree/TestRunner.cpp:
2354         (TestRunner::staticFunctions):
2355         * DumpRenderTree/TestRunner.h:
2356         (TestRunner):
2357         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2358         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2359         (WebTestRunner::TestRunner::TestRunner):
2360         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2361         (TestRunner):
2362         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2363         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2364         * DumpRenderTree/mac/TestRunnerMac.mm:
2365         * DumpRenderTree/qt/TestRunnerQt.cpp:
2366         * DumpRenderTree/qt/TestRunnerQt.h:
2367         (TestRunnerQt):
2368         * DumpRenderTree/win/TestRunnerWin.cpp:
2369         * DumpRenderTree/wx/TestRunnerWx.cpp:
2370         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2371         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2372         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2373         (TestRunner):
2374
2375 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2376
2377         Don't use legacy test names when returning results from PerfTest.run
2378         https://bugs.webkit.org/show_bug.cgi?id=111148
2379
2380         Reviewed by Dirk Pranke.
2381
2382         * Scripts/webkitpy/performance_tests/perftest.py:
2383         (PerfTestMetric.name): Renamed from metric.
2384         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
2385         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
2386         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
2387
2388         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2389         (TestPerfTestMetric.test_init_set_time_metric):
2390         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
2391         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2392         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2393
2394         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2395         (PerfTestsRunner.__init__):
2396         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
2397         to obtain the trac URL instead of hard coding it.
2398         (PerfTestsRunner._run_tests_set):
2399
2400 2013-03-01  Roger Fong  <roger_fong@apple.com>
2401
2402         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
2403         https://bugs.webkit.org/show_bug.cgi?id=111202
2404
2405         This is useful for running VCExpress builds from command line because there is
2406         no unified solution output, only per project build logs.
2407         The project will be run as the last project in the solution.
2408
2409         * win/AssembleBuildLogs: Added.
2410         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
2411         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
2412         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
2413         * win/AssembleBuildLogs/README: Added.
2414
2415 2013-03-01  Roger Fong  <roger_fong@apple.com>
2416
2417         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
2418
2419         * EWSTools/start-queue-win.sh:
2420
2421 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2422
2423         Don't return statistics in PerfTest.run
2424         https://bugs.webkit.org/show_bug.cgi?id=111145
2425
2426         Reviewed by Dirk Pranke.
2427
2428         Simply return a list of values obtained in each iteration from PerfTest.run.
2429         Also simplify various methods as needed.
2430
2431         * Scripts/webkitpy/performance_tests/perftest.py:
2432         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
2433         as needed from PerfTestsRunner._generate_results_dict.
2434
2435         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
2436         that we don't have to worry about the backward compatibility here.
2437
2438         (PerfTestMetric.iteration_values): Added.
2439         (PerfTestMetric.unit): Added.
2440         (PerfTestMetric.metric_to_unit):
2441         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
2442
2443         (PerfTest.run):
2444         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
2445
2446         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2447         (TestPerfTestMetric.test_init_set_missing_unit):
2448         (TestPerfTestMetric.test_init_set_time_metric): Added.
2449         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
2450         (TestPerfTestMetric.test_append):
2451         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
2452         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
2453         (TestPerfTest._assert_results_are_correct):
2454         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2455         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2456
2457         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2458         (PerfTestsRunner._generate_results_dict):
2459
2460         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2461         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
2462         (SomeParserTestData): Ditto.
2463         (MemoryTestData): Ditto.
2464
2465 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2466
2467         [Qt] Enable LINK_PREFETCH
2468         https://bugs.webkit.org/show_bug.cgi?id=111158
2469
2470         Reviewed by Simon Hausmann.
2471
2472         * qmake/mkspecs/features/features.pri:
2473
2474 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2475
2476         [Qt] Update features.pri with new features
2477         https://bugs.webkit.org/show_bug.cgi?id=111157
2478
2479         Reviewed by Jocelyn Turcotte.
2480
2481         * qmake/mkspecs/features/features.pri:
2482
2483 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
2484
2485         [chromium] put WebTestProxy::scheduleComposite back in place
2486         https://bugs.webkit.org/show_bug.cgi?id=111146
2487
2488         Reviewed by Nico Weber.
2489
2490         The call was removed in http://trac.webkit.org/changeset/144398 because
2491         DRT doesn't need it. However, content shell depends on this call.
2492
2493         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2494         (WebTestRunner::WebTestProxy::scheduleComposite):
2495
2496 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2497
2498         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
2499         https://bugs.webkit.org/show_bug.cgi?id=111142
2500
2501         Reviewed by Adam Barth.
2502
2503         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
2504
2505         Also removed _print_status since it's never used anywhere.
2506
2507         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2508         (PerfTestsRunner.run):
2509         (PerfTestsRunner._run_tests_set):
2510         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2511         (MainTest.run_test):
2512         (MainTest.test_run_test_set):
2513         (MainTest.test_run_test_set_kills_drt_per_run):
2514         (MainTest.test_run_test_set_for_parser_tests):
2515
2516 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
2517
2518         Disable window occlusion detection for WebKitTestRunner Web View on Mac
2519         https://bugs.webkit.org/show_bug.cgi?id=111116
2520
2521         Reviewed by Simon Fraser.
2522
2523         Window occlusion notifications were causing WebKitTestRunner's Web View
2524         to be detected as occluded and causing a few JavaScript timer layout
2525         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
2526         by initializing the page visibility to "visible" after creating the view.
2527         But a better solution is to disable window occlusion detection, so that
2528         not only the page but also the view is treated as visible.
2529
2530         * WebKitTestRunner/TestController.cpp:
2531         (WTR::TestController::createWebViewWithOptions): Remove call to
2532         setVisibilityState, since it is no longer necessary.
2533         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2534         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
2535         detection for the created WKView.
2536
2537 2013-02-28  Li Yin  <li.yin@intel.com>
2538
2539         [chromium] Events can't be triggered on MediaStreamTrack
2540         https://bugs.webkit.org/show_bug.cgi?id=110930
2541
2542         Reviewed by Kentaro Hara.
2543
2544         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
2545
2546         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
2547         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
2548
2549 2013-02-27  James Robinson  <jamesr@chromium.org>
2550
2551         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
2552         https://bugs.webkit.org/show_bug.cgi?id=111017
2553
2554         Reviewed by Adam Barth.
2555
2556         This decouples DumpRenderTree from WebLayerTreeViewClient.
2557
2558         * DumpRenderTree/chromium/WebViewHost.cpp:
2559         (WebViewHostDRTLayerTreeViewClient):
2560         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
2561         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
2562         (WebViewHostDRTLayerTreeViewClient::Layout):
2563         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
2564         (WebViewHost::initializeLayerTreeView):
2565         * DumpRenderTree/chromium/WebViewHost.h:
2566         (webkit_support):
2567         (WebViewHost):
2568
2569 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
2570
2571         Unreviewed, add my secondary email address to the list.
2572
2573         * Scripts/webkitpy/common/config/committers.py:
2574
2575 2013-02-28  Philip Rogers  <pdr@google.com>
2576
2577         Add Philip Rogers as a reviewer.
2578
2579         Unreviewed update of committers.py.
2580
2581         * Scripts/webkitpy/common/config/committers.py:
2582
2583 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2584
2585         Merge more methods on PerfTest
2586         https://bugs.webkit.org/show_bug.cgi?id=111030
2587
2588         Reviewed by Dirk Pranke.
2589
2590         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
2591         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
2592
2593         This makes the control flow a lot more comprehensible.
2594
2595         * Scripts/webkitpy/performance_tests/perftest.py:
2596         (PerfTest._run_with_driver):
2597         (PerfTest._should_ignore_line):
2598         (PerfTest._filter_output):
2599
2600         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2601         (TestPerfTest._assert_results_are_correct):
2602         (test_ignored_stderr_lines):
2603
2604 2013-02-28  Robert Hogan  <robert@webkit.org>
2605
2606         Update my IRC nick
2607
2608         Unreviewed.
2609
2610         * Scripts/webkitpy/common/config/committers.py:
2611
2612 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2613
2614         [Qt] Enable thin archives before parsing the project files
2615
2616         Rubber-stamped by Simon Hausmann.
2617
2618         The targetSubDir() function can be called before default_post.prf has been
2619         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
2620         which is parsed before the main project file.
2621         This issue was revealed by r144299 and fixes the clean build.
2622
2623         * qmake/mkspecs/features/default_post.prf:
2624         * qmake/mkspecs/features/default_pre.prf:
2625
2626 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2627
2628         [Qt] Enable CANVAS_PATH flag
2629         https://bugs.webkit.org/show_bug.cgi?id=108508
2630
2631         Reviewed by Simon Hausmann.
2632
2633         Also enable CANVAS_PATH flag for Qt.
2634
2635         * qmake/mkspecs/features/features.pri:
2636
2637 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2638
2639         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
2640
2641         Rubber-stamped by Csaba Osztrogonác.
2642
2643         Besides suppressing a warning about the non-existing function this
2644         fixes the build if there is a subdirectory (eg. debug-and-release).
2645
2646         * TestWebKitAPI/InjectedBundle.pri:
2647         * TestWebKitAPI/TestWebKitAPI.pri:
2648
2649 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2650
2651         [EFL][WTR] WTR cannot load injected bundle
2652         https://bugs.webkit.org/show_bug.cgi?id=111063
2653
2654         Reviewed by Csaba Osztrogonác.
2655
2656         WTR was not able to load injected bundle because of undefined 
2657         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
2658         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
2659         solves the problem.
2660
2661         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2662         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2663
2664 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
2665
2666         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
2667         https://bugs.webkit.org/show_bug.cgi?id=110464
2668
2669         Reviewed by Rob Buis.
2670
2671         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2672
2673 2013-02-28  Xan Lopez  <xlopez@rim.com>
2674
2675         [BlackBerry] DumpRenderTreeSupport: update the set position methods
2676         https://bugs.webkit.org/show_bug.cgi?id=110578
2677
2678         Reviewed by Rob Buis.
2679
2680         TestRunner::setMockGeolocationPosition() changed in r130416:
2681         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
2682
2683         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
2684         setMockGeolocationPositionUnavailableError() in r129444:
2685         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
2686
2687         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2688         (TestRunner::setMockGeolocationPosition):
2689         (TestRunner::setMockGeolocationPositionUnavailableError):
2690
2691 2013-02-28  Xan Lopez  <xlopez@rim.com>
2692
2693         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
2694         https://bugs.webkit.org/show_bug.cgi?id=110465
2695
2696         Reviewed by Rob Buis.
2697
2698         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2699         (LoadItem::invoke):
2700
2701 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2702
2703         PerfTestRunner doesn't need _needs_http and _has_http_lock
2704         https://bugs.webkit.org/show_bug.cgi?id=111037
2705
2706         Reviewed by Adam Barth.
2707
2708         Delete these variables in favor of using a local variable.
2709
2710         Member variables are like global variables. They introduce implicit dependencies
2711         between member functions.
2712
2713         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2714         (PerfTestsRunner.__init__):
2715         (PerfTestsRunner._start_http_servers):
2716         (PerfTestsRunner):
2717         (PerfTestsRunner._stop_http_servers):
2718         (PerfTestsRunner.run):
2719
2720 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2721
2722         Unreviewed, rolling out r144224.
2723         http://trac.webkit.org/changeset/144224
2724         https://bugs.webkit.org/show_bug.cgi?id=111045
2725
2726         Caused plugins/pass-different-npp-struct.html to time out
2727         (Requested by abarth on #webkit).
2728
2729         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2730         (PassDifferentNPPStruct::NPP_SetWindow):
2731         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2732         (NPP_SetWindow):
2733
2734 2013-02-27  Adam Barth  <abarth@webkit.org>
2735
2736         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2737         https://bugs.webkit.org/show_bug.cgi?id=110907
2738
2739         Reviewed by Eric Seidel.
2740
2741         This patch changes --enable-threaded-html-parser into
2742         --disable-threaded-html-parser and thereby enables the threaded HTML
2743         parser by default for the Chromium port.
2744
2745         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2746         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2747         (WebTestRunner::WebPreferences::reset):
2748         * DumpRenderTree/chromium/TestShell.cpp:
2749         (TestShell::TestShell):
2750
2751 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
2752
2753         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2754         https://bugs.webkit.org/show_bug.cgi?id=111025
2755
2756         Reviewed by Simon Fraser.
2757
2758         Set page visibility to "visible" after creating WebView to override
2759         visibility state inferred from window occlusion notifications on Mac.
2760
2761         * WebKitTestRunner/TestController.cpp:
2762         (WTR::TestController::createWebViewWithOptions): Add call to
2763         setVisibilityState.
2764
2765 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2766
2767         Merge PageLoadingPerfTest into ReplayPerfTest
2768         https://bugs.webkit.org/show_bug.cgi?id=111027
2769
2770         Reviewed by Dirk Pranke.
2771
2772         Merged two classes.
2773
2774         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2775         part of ReplayPerfTest.
2776
2777         * Scripts/webkitpy/performance_tests/perftest.py:
2778         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2779         (ReplayPerfTest.__init__):
2780         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2781         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2782         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2783         (TestReplayPerfTest):
2784         (TestReplayPerfTest.test_run_single.run_test):
2785         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2786         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2787         TestPageLoadingPerfTest.test_run.
2788         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2789         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2790         TestPageLoadingPerfTest.test_run_with_memory_output
2791         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2792         (TestReplayPerfTest.test_prepare_calls_run_single):
2793
2794 2013-02-27  Eric Seidel  <eric@webkit.org>
2795
2796         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2797         https://bugs.webkit.org/show_bug.cgi?id=111021
2798
2799         Reviewed by Dirk Pranke.
2800
2801         The underlying code (which is shared with run-webkit-tests)
2802         already knew how to support this option, it just wasn't exposed
2803         via the run-perf-tests front-end.  This patch fixes that.
2804
2805         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2806         (PerfTestsRunner._parse_args):
2807
2808 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2809
2810         Stop uploading results to webkit-perf.appspot.com
2811         https://bugs.webkit.org/show_bug.cgi?id=110954
2812
2813         Reviewed by Benjamin Poulain.
2814
2815         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2816
2817         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2818         (RunAndUploadPerfTests):
2819
2820 2013-02-27  James Simonsen  <simonjam@chromium.org>
2821
2822         [chromium] Lower priority of preloaded images
2823         https://bugs.webkit.org/show_bug.cgi?id=110527
2824
2825         Plumb the didChangePriority signal into DRT so it can be tested.
2826
2827         Reviewed by Nate Chapin.
2828
2829         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2830         (WebKit):
2831         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2832         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2833         (WebTestRunner::TestRunner::TestRunner):
2834         (WebTestRunner::TestRunner::reset):
2835         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2836         (WebTestRunner):
2837         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2838         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2839         (TestRunner):
2840         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2841         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2842         (WebTestRunner::WebTestProxyBase::willSendRequest):
2843         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2844         (WebTestRunner):
2845
2846 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2847
2848         AX: Mac platform should support ability to scroll an element into visible
2849         https://bugs.webkit.org/show_bug.cgi?id=109860
2850
2851         Reviewed by Beth Dakin.
2852
2853         * DumpRenderTree/AccessibilityUIElement.cpp:
2854         (scrollToMakeVisibleCallback):
2855         (AccessibilityUIElement::getJSClass):
2856         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2857         (AccessibilityUIElement::scrollToMakeVisible):
2858         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2859         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2860         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2861         (AccessibilityUIElement):
2862         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2863         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2864         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2865         (WTR):
2866
2867 2013-02-27  John Bauman  <jbauman@chromium.org>
2868
2869         Plugin in iframe may not display
2870         https://bugs.webkit.org/show_bug.cgi?id=109879
2871
2872         Reviewed by Simon Fraser.
2873
2874         LogNPPSetWindow will be used with other ports as well.
2875
2876         * DumpRenderTree/DumpRenderTree.gypi:
2877         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2878
2879 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
2880
2881         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2882         https://bugs.webkit.org/show_bug.cgi?id=110973
2883
2884         Reviewed by Adam Barth.
2885
2886         There is nothing that ensures that the log messages from the plugin
2887         come in before the layout test finished loading.
2888
2889         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2890         (PassDifferentNPPStruct::NPP_SetWindow):
2891         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2892         (NPP_SetWindow):
2893
2894 2013-02-27  Glenn Adams  <glenn@skynav.com>
2895
2896         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
2897         https://bugs.webkit.org/show_bug.cgi?id=110944
2898
2899         Reviewed by Dean Jackson.
2900
2901         * Scripts/webkitperl/FeatureList.pm:
2902         * qmake/mkspecs/features/features.pri:
2903
2904 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
2905
2906         Unreviewed. Remove myself from watchlist.
2907
2908         * Scripts/webkitpy/common/config/watchlist:
2909
2910 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2911
2912         Switch QtWebKit to GStreamer 1.0.
2913         https://bugs.webkit.org/show_bug.cgi?id=106669.
2914
2915         Original patch by Sebastian Dröge.
2916         Reviewed by Csaba Osztrogonác.
2917
2918         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
2919         temporarily to make upgrading easy and the patch suitable for Qt5.
2920
2921         * qmake/mkspecs/features/features.prf:
2922
2923 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2924
2925         Unreviewed. Added myself to committers.py
2926
2927         * Scripts/webkitpy/common/config/committers.py:
2928
2929 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2930
2931         Unreviewed, rolling out r144192.
2932         http://trac.webkit.org/changeset/144192
2933         https://bugs.webkit.org/show_bug.cgi?id=110984
2934
2935         Stored svn password on wrong computer (Requested by kkristof
2936         on #webkit).
2937
2938         * Scripts/webkitpy/common/config/committers.py:
2939
2940 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2941
2942         Unreviewed. Added myself to committers.py
2943
2944         * Scripts/webkitpy/common/config/committers.py:
2945
2946 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2947
2948         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
2949
2950         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2951         (PerfTestsRunner._upload_json):
2952
2953 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2954
2955         Stop uploading results to webkit-perf.appspot.com
2956         https://bugs.webkit.org/show_bug.cgi?id=110954
2957
2958         Reviewed by Benjamin Poulain.
2959
2960         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
2961         Also, always use the new JSON format. Removed the code to generate the old format.
2962
2963         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2964         (PerfTestsRunner._generate_and_show_results):
2965         (PerfTestsRunner._generate_results_dict):
2966         (PerfTestsRunner._merge_slave_config_json):
2967         (PerfTestsRunner._generate_output_files):
2968
2969 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2970
2971         Unreviewed, rolling out r144136, r144143, and r144147.
2972         http://trac.webkit.org/changeset/144136
2973         http://trac.webkit.org/changeset/144143
2974         http://trac.webkit.org/changeset/144147
2975         https://bugs.webkit.org/show_bug.cgi?id=110950
2976
2977         Caused some timeouts and flaky crashes (Requested by abarth on
2978         #webkit).
2979
2980         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2981         (main):
2982         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2983         (WebTestRunner::WebPreferences::reset):
2984         * DumpRenderTree/chromium/TestShell.cpp:
2985         (TestShell::TestShell):
2986
2987 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2988
2989         Use perf.webkit.org JSON format in results page
2990         https://bugs.webkit.org/show_bug.cgi?id=110842
2991
2992         Reviewed by Benjamin Poulain.
2993
2994         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
2995
2996         A whole bunch of integration tests have been updated to use the new JSON format.
2997
2998         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2999         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
3000         and legacy_output_json_path respectively.
3001         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
3002         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
3003         JSON file and the results page out of perf_webkit_output instead of legacy_output.
3004
3005         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3006         (MainTest.test_run_memory_test):
3007         (MainTest._test_run_with_json_output.mock_upload_json):
3008         (MainTest):
3009         (MainTest.test_run_with_json_output):
3010         (MainTest.test_run_with_description):
3011         (MainTest.test_run_generates_json_by_default):
3012         (MainTest.test_run_merges_output_by_default):
3013         (MainTest.test_run_respects_reset_results):
3014         (MainTest.test_run_generates_and_show_results_page):
3015         (MainTest.test_run_with_slave_config_json):
3016         (MainTest.test_run_with_multiple_repositories):
3017         (MainTest.test_run_with_upload_json):
3018         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3019
3020 2013-02-26  Adam Barth  <abarth@webkit.org>
3021
3022         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
3023         https://bugs.webkit.org/show_bug.cgi?id=110907
3024
3025         Reviewed by Eric Seidel.
3026
3027         This patch changes --enable-threaded-html-parser into
3028         --disable-threaded-html-parser and thereby enables the threaded HTML
3029         parser by default for the Chromium port.
3030
3031         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3032         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3033         (WebTestRunner::WebPreferences::reset):
3034         * DumpRenderTree/chromium/TestShell.cpp:
3035         (TestShell::TestShell):
3036
3037 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
3038
3039         [chromium] Re-enable the fixed version of freetype on linux
3040         https://bugs.webkit.org/show_bug.cgi?id=110542
3041
3042         Reviewed by Tony Chang.
3043
3044         Re-land the change in r143794 to switch to building with a fixed
3045         version of FreeType for just DumpRenderTree. This allows us to share
3046         one version of pixel baselines for both Lucid and Precise, and run the
3047         layout tests in a stock Precise install (instead of a Lucid chroot).
3048         Going forward, this approach isolates us from os-level changes to the
3049         version of FreeType. Note that Chromium itself still uses the system
3050         FreeType and is unaffected by this change.
3051         
3052         This setting can still be turned off (at compile/gyp-time) by
3053         manually setting use_custom_freetype=0.
3054
3055         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3056
3057 2013-02-26  Nico Weber  <thakis@chromium.org>
3058
3059         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
3060         https://bugs.webkit.org/show_bug.cgi?id=110890
3061
3062         Reviewed by Jochen Eisinger.
3063
3064         Several functions in webkit check that bit to change rendering
3065         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
3066         disables font smoothing in this mode. TestShell and DRT both set
3067         this flag, so content shell drt should set it too.
3068
3069         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3070         (WebTestRunner::TestInterfaces::TestInterfaces):
3071
3072 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3073
3074         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
3075         https://bugs.webkit.org/show_bug.cgi?id=110884
3076
3077         Reviewed by Csaba Osztrogonác.
3078
3079         Adding the missing spaces before ':' in the unit test.
3080
3081         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3082
3083 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3084
3085         new-commit-bot: Some IRC clients doesn't linkify rollout messages
3086         https://bugs.webkit.org/show_bug.cgi?id=110861
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         Adding the space before ':' in order to fix the links shown for the rollout message.
3091
3092         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3093         (NewCommitBot._summarize_commit_log):
3094
3095 2013-02-26  Joone Hur  <joone.hur@intel.com>
3096
3097         [GTK] Add Clutter to jhbuild
3098         https://bugs.webkit.org/show_bug.cgi?id=110245
3099
3100         Reviewed by Martin Robinson.
3101
3102         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
3103         This allows to build WebKitGtk+ with clutter as an acceleration backend
3104         within the jhbuild environment. 
3105
3106         * gtk/jhbuild-optional.modules:
3107
3108 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3109
3110         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
3111
3112         * Scripts/webkitpy/common/checkout/scm/svn.py:
3113         (SVN.value_from_svn_info):
3114
3115 2013-02-25  Alan Cutter  <alancutter@chromium.org>
3116
3117         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
3118         https://bugs.webkit.org/show_bug.cgi?id=110845
3119
3120         Unreviewed EWS bot fix.
3121
3122         Switch the Queue Status Server address the EWS bots use to a more direct URL that
3123         doesn't seem to be having problems from GCE like queues.webkit.org.
3124
3125         * Scripts/webkitpy/common/net/statusserver.py:
3126         (StatusServer):
3127
3128 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3129
3130         Forgot to delete a no-longer-needed unit test after r143980.
3131
3132         Unreviewed, build fix.
3133
3134         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3135         (ChromiumWinTest.test_path_to_image_diff):
3136
3137 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3138
3139         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
3140         Don't include \r at the end of svn info lines on Windows.
3141
3142         This is similar to r143839.
3143
3144         * Scripts/webkitpy/common/checkout/scm/svn.py:
3145         (SVN.value_from_svn_info):
3146
3147 2013-02-25  James Simonsen  <simonjam@chromium.org>
3148
3149         [Resource Timing] Update test suite so it can be exported to the W3C
3150         https://bugs.webkit.org/show_bug.cgi?id=107343
3151
3152         Reviewed by Tony Gentilcore.
3153
3154         * Scripts/export-w3c-performance-wg-tests: Clean up output.
3155         * Scripts/import-w3c-performance-wg-tests:
3156
3157 2013-02-25  Anders Carlsson  <andersca@apple.com>
3158
3159         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
3160         https://bugs.webkit.org/show_bug.cgi?id=110821
3161         <rdar://problem/13265303>
3162
3163         Reviewed by Beth Dakin.
3164
3165         Update for WebKit2 changes.
3166
3167         * MiniBrowser/mac/WK2BrowserWindowController.m:
3168         (-[WK2BrowserWindowController awakeFromNib]):
3169         * WebKitTestRunner/TestController.cpp:
3170         (WTR::TestController::createOtherPage):
3171         (WTR::TestController::createWebViewWithOptions):
3172         (WTR::TestController::unavailablePluginButtonClicked):
3173         * WebKitTestRunner/TestController.h:
3174         (TestController):
3175
3176 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
3177
3178         Optionally partition cache to prevent using cache for tracking
3179         https://bugs.webkit.org/show_bug.cgi?id=110269
3180
3181         Reviewed by Maciej Stachowiak.
3182
3183         Add test suite for public suffix functions on Mac.
3184
3185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3186         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
3187         (TestWebKitAPI):
3188         (TestWebKitAPI::TEST_F):
3189
3190 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3191
3192         nrwt: reenable multiple http shards on chromium win
3193         https://bugs.webkit.org/show_bug.cgi?id=110814
3194
3195         Reviewed by Tony Chang.
3196
3197         The underlying bug in DumpRenderTree that was causing us to look for a
3198         pac file and timeout under load was fixed a while ago.
3199
3200         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3201         (ChromiumWinPort.relative_test_filename):
3202
3203 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3204
3205         Make ninja the default w/ build-webkit --chromium on windows.
3206         https://bugs.webkit.org/show_bug.cgi?id=110731
3207
3208         Unreviewed - TBR'ing thakis :).
3209
3210         * Scripts/update-webkit-chromium:
3211
3212 2013-02-25  Anders Carlsson  <andersca@apple.com>
3213
3214         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
3215         https://bugs.webkit.org/show_bug.cgi?id=110793
3216         <rdar://problem/13265303>
3217
3218         Reviewed by Sam Weinig.
3219
3220         Update for WebKit2 API changes.
3221
3222         * MiniBrowser/mac/WK2BrowserWindowController.m:
3223         (-[WK2BrowserWindowController awakeFromNib]):
3224         * WebKitTestRunner/TestController.cpp:
3225         (WTR::TestController::createWebViewWithOptions):
3226
3227 2013-02-25  Nico Weber  <thakis@chromium.org>
3228
3229         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
3230         https://bugs.webkit.org/show_bug.cgi?id=110775
3231
3232         Unreviewed, basically a rebaseline.
3233
3234         * Scripts/webkitpy/common/config/watchlist:
3235
3236 2013-02-25  Nico Weber  <thakis@chromium.org>
3237
3238         [chromium] Try to get the webkit builder to use msvs again
3239         https://bugs.webkit.org/show_bug.cgi?id=110771
3240
3241         Reviewed by Eric Seidel.
3242
3243         The msvs gyp generator apparently doesn't write the sln file on every
3244         run, so check the vcxproj file instead.
3245
3246         * Scripts/webkitdirs.pm:
3247         (determineIsChromiumNinja):
3248
3249 2013-02-25  Nico Weber  <thakis@chromium.org>
3250
3251         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
3252         https://bugs.webkit.org/show_bug.cgi?id=110767
3253
3254         Reviewed by Eric Seidel.
3255
3256         The tester runs gyp, which generates out/Release/build.ninja. The bot
3257         scripts use existence (and timestamp) of that file to decide if the
3258         current build is supposed to be ninja or xcodebuild. The file exists,
3259         so the snapshot is extracted to out/Release. The snapshot doesn't
3260         contain build.ninja however due to
3261         http://trac.webkit.org/changeset/140375 , so after extracting the
3262         snapshot the scripts think that this is an xcodebuild build. So remove
3263         the part of that revision that removed ninja files from the archive,
3264         and the bots should be happy again.
3265
3266         * BuildSlaveSupport/built-product-archive:
3267         (archiveBuiltProduct):
3268
3269 2013-02-25  Nico Weber  <thakis@chromium.org>
3270
3271         Fix tests after r143910
3272         https://bugs.webkit.org/show_bug.cgi?id=110757
3273
3274         Reviewed by Andreas Kling.
3275
3276         While here, also add a test for the bug r143910 fixed.
3277
3278         * Scripts/webkitpy/common/system/executive_unittest.py:
3279         (ScriptErrorTest.test_message_with_output):
3280         (ScriptErrorTest):
3281         (ScriptErrorTest.test_message_with_tuple):
3282
3283 2013-02-25  Nico Weber  <thakis@chromium.org>
3284
3285         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
3286         https://bugs.webkit.org/show_bug.cgi?id=110755
3287
3288         Reviewed by Jochen Eisinger.
3289
3290         * BuildSlaveSupport/built-product-archive:
3291         (archiveBuiltProduct):
3292         (extractBuiltProduct):
3293
3294 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3295
3296         Unreviewed, rolling out r143895.
3297         http://trac.webkit.org/changeset/143895
3298         https://bugs.webkit.org/show_bug.cgi?id=110758
3299
3300         broke a bunch of tests (Requested by thakis__ on #webkit).
3301
3302         * Scripts/update-webkit-chromium:
3303
3304 2013-02-25  Andreas Kling  <akling@apple.com>
3305
3306         Unreviewed, fix simple mistake in r143903.
3307         <http://webkit.org/b/110746>
3308
3309         Reviewed by Andreas Kling.
3310
3311         Pass git revision, not svn revision, to git shell command.
3312
3313         * Scripts/webkitpy/common/checkout/scm/git.py:
3314         (Git.timestamp_of_latest_commit):
3315
3316 2013-02-25  Nico Weber  <thakis@chromium.org>
3317
3318         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
3319         https://bugs.webkit.org/show_bug.cgi?id=110748
3320
3321         Reviewed by Jochen Eisinger.
3322
3323         One of the mac testers runs DRT from out/ but WebKitUnitTests from
3324         xcodebuild. I'm trying to understand what's going on.
3325
3326         * BuildSlaveSupport/built-product-archive:
3327         (archiveBuiltProduct):
3328         (extractBuiltProduct):
3329
3330 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
3331
3332         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
3333         https://bugs.webkit.org/show_bug.cgi?id=110599
3334
3335         Reviewed by Yury Semikhatsky.
3336
3337         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
3338         that were given us via MemoryInstrumentation calls.
3339         So I extended client api with registerString method that pushes the strings
3340         down to the serializer.
3341
3342         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3343         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3344         (TestWebKitAPI::Helper::Helper):
3345         (Helper):
3346         (TestWebKitAPI::Helper::addNode):
3347         (TestWebKitAPI::TEST):
3348
3349 2013-02-25  Nico Weber  <thakis@chromium.org>
3350
3351         Make ScriptError not crash when args is a tuple
3352         https://bugs.webkit.org/show_bug.cgi?id=110747
3353
3354         Reviewed by Jochen Eisinger.
3355
3356         I'm trying to understand the error on
3357         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
3358         better. I'll likely have to revert the ninja switch on windows, but
3359         having error reporting code that doesn't itself crash sounds like a
3360         good thing to have anyways.
3361
3362         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
3363         tuple not a list.
3364
3365         * Scripts/run-chromium-webkit-unit-tests:
3366         * Scripts/webkitpy/common/system/executive.py:
3367         (ScriptError.__init__):
3368
3369 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
3370
3371         [EFL] Align feature defaults
3372         https://bugs.webkit.org/show_bug.cgi?id=110715
3373
3374         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
3375         OptionsEfl.cmake.
3376
3377         Reviewed by Gyuyoung Kim.
3378
3379         * Scripts/webkitperl/FeatureList.pm:
3380
3381 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3382
3383         run-perf-tests reports wrong commit time
3384         https://bugs.webkit.org/show_bug.cgi?id=110746
3385
3386         Reviewed by Andreas Kling.
3387
3388         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
3389         of when the subdirectory was last modified.
3390
3391         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
3392         insufficient since running "svn log -r <revision>" on a partial checkout only returns
3393         an empty result if the revision didn't modify the subdirectory.
3394
3395         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
3396         the interface compatible with svn.
3397
3398         * Scripts/webkitpy/common/checkout/scm/git.py:
3399         (Git.timestamp_of_latest_commit):
3400         * Scripts/webkitpy/common/checkout/scm/scm.py:
3401         (SCM.timestamp_of_latest_commit):
3402         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3403         (MockSCM.timestamp_of_latest_commit):
3404         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3405         (test_timestamp_of_latest_commit):
3406         * Scripts/webkitpy/common/checkout/scm/svn.py:
3407         (SVN.timestamp_of_latest_commit):
3408         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3409         (PerfTestsRunner._generate_results_dict):
3410
3411 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
3412
3413         [chromium] move WebRuntimeFeatures configuration to TestRunner library
3414         https://bugs.webkit.org/show_bug.cgi?id=110712
3415
3416         Reviewed by Nico Weber.
3417
3418         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3419         (WebTestRunner::TestInterfaces::TestInterfaces):
3420         * DumpRenderTree/chromium/TestShell.cpp:
3421         (TestShell::TestShell):
3422
3423 2013-02-25  Nico Weber  <thakis@chromium.org>
3424
3425         Make ninja the default build system for build-webkit --chromium on windows
3426         https://bugs.webkit.org/show_bug.cgi?id=110731
3427
3428         Reviewed by Jochen Eisinger.
3429
3430         With http://crbug.com/169945 fixed, this should now work.
3431
3432         * Scripts/update-webkit-chromium:
3433
3434 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
3435
3436         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
3437         https://bugs.webkit.org/show_bug.cgi?id=110702
3438
3439         Reviewed by Martin Robinson.
3440
3441         * GtkLauncher/main.c: include autotoolsconfig.h.
3442         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
3443         the include ordering check, since it uses autotoolsconfig.h which needs to
3444         come first.
3445
3446 2013-02-24  Hajime Morrita  <morrita@google.com>
3447
3448         [Custom Elements] Implement bare-bone document.register()
3449         https://bugs.webkit.org/show_bug.cgi?id=100229
3450
3451         Reviewed by Adam Barth.
3452
3453         Added enableCustomDOMElements flag.
3454
3455         * DumpRenderTree/chromium/TestShell.cpp:
3456         (TestShell::TestShell):
3457
3458 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
3459
3460         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
3461         https://bugs.webkit.org/show_bug.cgi?id=110606
3462
3463         Reviewed by Adam Barth.
3464
3465         Part of a larger refactoring series; see tracking bug 82948.
3466
3467         * DumpRenderTree/DumpRenderTree.gypi:
3468         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3469         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
3470         (WebKitSupportTestEnvironment::mockPlatform):
3471         (WebKitSupportTestEnvironment):
3472         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
3473         (MockPlatform::create):
3474         (MockPlatform::MockPlatform):
3475         (MockPlatform::~MockPlatform):
3476         (MockPlatform::setInterfaces):
3477         (MockPlatform::cryptographicallyRandomValues):
3478         (MockPlatform::createMediaStreamCenter):
3479         (MockPlatform::createRTCPeerConnectionHandler):
3480         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
3481         (MockPlatform):
3482         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
3483         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
3484         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3485         (WebTestDelegate):
3486         * DumpRenderTree/chromium/TestShell.cpp:
3487         (TestShell::initialize):
3488         * DumpRenderTree/chromium/TestShell.h:
3489         (TestShell):
3490
3491 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3492
3493         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
3494
3495         * Scripts/webkitpy/common/checkout/scm/svn.py:
3496         (SVN.timestamp_of_latest_commit):
3497
3498 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
3499
3500         Move setAutofilled from TestRunner to WebCore
3501         https://bugs.webkit.org/show_bug.cgi?id=110521
3502
3503         Reviewed by Benjamin Poulain.
3504
3505         * DumpRenderTree/TestRunner.cpp:
3506         (TestRunner::staticFunctions):
3507         * DumpRenderTree/TestRunner.h:
3508         (TestRunner):
3509         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3510         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3511         (WebTestRunner::TestRunner::TestRunner):
3512         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3513         (TestRunner):
3514         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3515         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3516         * DumpRenderTree/mac/TestRunnerMac.mm:
3517         * DumpRenderTree/qt/TestRunnerQt.cpp:
3518         * DumpRenderTree/qt/TestRunnerQt.h:
3519         (TestRunnerQt):
3520         * DumpRenderTree/win/TestRunnerWin.cpp:
3521         * DumpRenderTree/wx/TestRunnerWx.cpp:
3522
3523 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
3524
3525         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
3526         https://bugs.webkit.org/show_bug.cgi?id=108577
3527
3528         Reviewed by Dirk Pranke.
3529
3530         Upload results to perf.webkit.org using new JSON format as well as the host specified by
3531         --test-results-server. The new format is needed to provide extra information perf.webkit.org
3532         need such as the subversion commit time and test URLs. This is a temporarily measure until
3533         we complete the transition and the old JSON format and the code to upload results to
3534         webkit-perf.appspot.com can be deleted.
3535
3536         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
3537         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
3538         so that the app can sort performance test results based on the timestamp of the last commit.
3539
3540         It also changes the repository names returned by port objects to be properly capitalized
3541         human readable names such as WebKit instead of lowercased names such as webkit since these names
3542         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
3543         to explicitly lowercase the names.
3544
3545
3546         * Scripts/webkitpy/common/checkout/scm/git.py:
3547         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
3548         git's timestamp granularity is seconds so we're losing some information compared to using a regular
3549         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
3550         UTC so we're going to manually fiddle with timezone.
3551
3552         * Scripts/webkitpy/common/checkout/scm/scm.py:
3553         (SCM.timestamp_of_latest_commit): Added.
3554
3555         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3556         (MockSCM.timestamp_of_latest_commit): Added.
3557
3558         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3559         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
3560
3561         * Scripts/webkitpy/common/checkout/scm/svn.py:
3562         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
3563         the timestamp which is always in UTC.
3564
3565         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3566         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
3567         'chromium' needs to be substituted by 'chrome' for historical reasons.
3568
3569         * Scripts/webkitpy/layout_tests/port/base.py:
3570         (Port.repository_paths): Return WebKit instead of webkit as noted above.
3571
3572         * Scripts/webkitpy/layout_tests/port/chromium.py:
3573         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
3574
3575         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3576         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
3577         (PerfTestsRunner._collect_tests):
3578
3579         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
3580         and upload them appropriately.
3581
3582         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
3583         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
3584
3585         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
3586
3587         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
3588         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
3589         e.g. "processor" would be renamed to "builderProcessor".
3590
3591         (PerfTestsRunner._generate_output_files):
3592
3593         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
3594         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
3595         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
3596         webkit-perf.appspot.com which spits out a plaintext response.
3597
3598         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3599         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
3600         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
3601         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
3602
3603         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3604         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
3605         cases to parse JSON responses.
3606         (MainTest.test_upload_json.MockFileUploader): Refactored.
3607         (MainTest.test_upload_json.MockFileUploader.reset): Added.
3608         (MainTest.test_upload_json.MockFileUploader.__init__):
3609         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
3610
3611 2013-02-22  Roger Fong  <roger_fong@apple.com>
3612
3613         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
3614
3615         * BuildSlaveSupport/build.webkit.org-config/config.json:
3616
3617 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
3618
3619         Unreviewed, rolling out r143794.
3620         http://trac.webkit.org/changeset/143794
3621         https://bugs.webkit.org/show_bug.cgi?id=110542
3622
3623         debug linux builds broken?
3624
3625         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3626
3627 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
3628
3629         [chromium] enable the fixed version of freetype on linux
3630         https://bugs.webkit.org/show_bug.cgi?id=110542
3631
3632         Reviewed by Tony Chang.
3633
3634         Switch to building with a fixed version of FreeType for
3635         just DumpRenderTree. This allows us to share one version
3636         of pixel baselines for both Lucid and Precise, and run
3637         the layout tests in a stock Precise install (instead of a Lucid
3638         chroot). Going forward, this approach isolates us from os-level
3639         changes to the version of FreeType. Note that Chromium itself
3640         still uses the system FreeType and is unaffected by this change.
3641         
3642         This setting can still be turned off (at compile/gyp-time) by
3643         manually setting use_custom_freetype=0.
3644
3645         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3646
3647 2013-02-22  Anders Carlsson  <andersca@apple.com>
3648
3649         Move pluginLoadPolicy to the page loader client
3650         https://bugs.webkit.org/show_bug.cgi?id=110635
3651
3652         Reviewed by Sam Weinig.
3653
3654         *&