b2e5150c9017e4db8ccdb7cdd45ef4a566158dab
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2
3         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
4
5         * Scripts/build-webkit:
6         * Scripts/copy-webkitlibraries-to-product-directory:
7
8 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
9
10         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
11         https://bugs.webkit.org/show_bug.cgi?id=130867
12         <rdar://problem/16432456> 
13
14         Reviewed by Mark Hahnenberg.
15
16         * Scripts/build-webkit:
17         * Scripts/copy-webkitlibraries-to-product-directory:
18
19 2014-03-26  Andy Estes  <aestes@apple.com>
20
21         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
22         https://bugs.webkit.org/show_bug.cgi?id=130805
23
24         Reviewed by Dan Bernstein.
25
26         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
27         (-[DownloadDelegate _download:didReceiveResponse:]):
28         (-[DownloadDelegate _downloadDidFinish:]):
29         (runTest):
30         (TEST):
31         (-[FailingDownloadDelegate _downloadDidFinish:]):
32         (-[FailingDownloadDelegate _download:didFailWithError:]):
33         (-[FailingDownloadDelegate _downloadDidCancel:]):
34         (-[CancelledDownloadDelegate _downloadDidStart:]):
35         (-[CancelledDownloadDelegate _downloadDidFinish:]):
36         (-[CancelledDownloadDelegate _download:didFailWithError:]):
37         (-[CancelledDownloadDelegate _downloadDidCancel:]):
38         (-[DownloadDelegate initWithSourceURL:]): Deleted.
39         (-[DownloadDelegate sourceURL]): Deleted.
40         (runTestWithNavigationDelegate): Deleted.
41
42 2014-03-26  Anders Carlsson  <andersca@apple.com>
43
44         Change MiniBrowser to hold on to window controllers instead of windows
45         https://bugs.webkit.org/show_bug.cgi?id=130797
46
47         Reviewed by Oliver Hunt.
48
49         * MiniBrowser/mac/AppDelegate.h:
50         * MiniBrowser/mac/AppDelegate.m:
51         (-[BrowserAppDelegate init]):
52         (-[BrowserAppDelegate newWindow:]):
53         (-[BrowserAppDelegate browserWindowWillClose:]):
54         (-[BrowserAppDelegate applicationWillTerminate:]):
55         (-[BrowserAppDelegate frontmostBrowserWindowController]):
56
57 2014-03-26  Commit Queue  <commit-queue@webkit.org>
58
59         Unreviewed, rolling out r166264.
60         https://bugs.webkit.org/show_bug.cgi?id=130785
61
62         Broke some window.opener tests for WK2 Mavericks (Requested by
63         brrian__ on #webkit).
64
65         Reverted changeset:
66
67         "Web Replay: resource unique identifiers should be unique-per-
68         frame, not globally"
69         https://bugs.webkit.org/show_bug.cgi?id=130632
70         http://trac.webkit.org/changeset/166264
71
72 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
73
74         [CSS Shapes] Remove shape-inside support
75         https://bugs.webkit.org/show_bug.cgi?id=130698
76
77         Reviewed by David Hyatt.
78
79         * Scripts/webkitperl/FeatureList.pm:
80
81 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
82
83         Unreviewed. Add myself as a committer.
84
85         * Scripts/webkitpy/common/config/contributors.json:
86
87 2014-03-26  Tomas Popela  <tpopela@redhat.com>
88
89         run-launcher is Perl script so use elsif and not elif
90         https://bugs.webkit.org/show_bug.cgi?id=130771
91
92         Reviewed by Carlos Garcia Campos.
93
94         * Scripts/run-launcher:
95
96 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
97
98         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
99         https://bugs.webkit.org/show_bug.cgi?id=130575
100
101         Reviewed by Mario Sanchez Prada.
102
103         Change ATK version to 2.11.92. Adjust current implementation.
104
105         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
106         (AccessibilityUIElement::intValue):
107         (AccessibilityUIElement::minValue):
108         (AccessibilityUIElement::maxValue):
109         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
110         (WTR::AccessibilityUIElement::intValue):
111         (WTR::AccessibilityUIElement::minValue):
112         (WTR::AccessibilityUIElement::maxValue):
113         * efl/jhbuild.modules:
114         * gtk/jhbuild.modules:
115
116 2014-03-12  Philippe Normand  <pnormand@igalia.com>
117
118         [GTK] The gnumake package is no longer needed in jhbuild
119         https://bugs.webkit.org/show_bug.cgi?id=130121
120
121         Reviewed by Martin Robinson.
122
123         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
124         for a debug build cmake/system-gnumake worked just fine for me.
125
126         * gtk/jhbuild.modules: Removed gnumake.
127         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
128         * gtk/patches/make-3.82-parallel-build.patch: Removed.
129
130 2014-03-25  Andy Estes  <aestes@apple.com>
131
132         Fix a failing API test on Mountain Lion and remove temporary debug logging.
133
134         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
135         (-[DownloadDelegate _download:didReceiveData:]):
136         (-[DownloadDelegate _downloadDidFinish:]):
137
138 2014-03-25  Brian Burg  <bburg@apple.com>
139
140         Web Replay: resource unique identifiers should be unique-per-frame, not globally
141         https://bugs.webkit.org/show_bug.cgi?id=130623
142
143         Reviewed by Timothy Hatcher.
144
145         The resource loader callback dumping routines assumed that resource identifiers
146         were globally unique. Its map of resource identifiers to URLs must also track the
147         frame associated with the resource.
148
149         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
150         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
151         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
152         stable as long as the frame is valid.
153         (WTR::InjectedBundlePage::didInitiateLoadForResource):
154         (WTR::InjectedBundlePage::willSendRequestForFrame):
155         (WTR::InjectedBundlePage::didReceiveResponseForResource):
156         (WTR::InjectedBundlePage::didFinishLoadForResource):
157         (WTR::InjectedBundlePage::didFailLoadForResource):
158
159 2014-03-25  Andy Estes  <aestes@apple.com>
160
161         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
162
163         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
164         (-[DownloadDelegate _download:didReceiveResponse:]):
165         (-[DownloadDelegate _download:didReceiveData:]):
166
167 2014-03-25  Andy Estes  <aestes@apple.com>
168
169         Add some debug logging to an API test that's failing on Mountain Lion.
170
171         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
172         (-[DownloadDelegate _download:didReceiveResponse:]):
173         (-[DownloadDelegate _downloadDidFinish:]):
174
175 2014-03-25  Anders Carlsson  <andersca@apple.com>
176
177         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
178         https://bugs.webkit.org/show_bug.cgi?id=130732
179
180         Reviewed by Tim Horton.
181
182         * MiniBrowser/mac/WK2BrowserWindowController.m:
183         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
184
185 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
186
187         [GTK] Remove the autotools build
188         https://bugs.webkit.org/show_bug.cgi?id=130717
189
190         Reviewed by Anders Carlsson.
191
192         * DumpRenderTree/config.h: Remove references to the autotools configure file.
193         * GNUmakefile.am: Removed.
194         * GtkLauncher/GNUmakefile.am: Removed.
195         * GtkLauncher/main.c: Remove references to the autotools configure file.
196         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
197         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
198         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
199         * MiniBrowser/gtk/GNUmakefile.am: Removed.
200         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
201         * Scripts/build-webkit: No longer handle autotools.
202         * Scripts/run-gtk-tests: Ditto.
203         (TestRunner._setup_testing_environment):
204         * Scripts/run-launcher: Ditto.
205         * Scripts/webkitdirs.pm: Ditto.
206         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
207         * Scripts/webkitpy/common/config/contributors.json: Ditto.
208         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
209         * Scripts/webkitpy/style/checker.py:
210         * TestWebKitAPI/GNUmakefile.am: Removed.
211         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
212         * WebKitTestRunner/GNUmakefile.am: Removed.
213         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
214         * gtk/GNUmakefile.am: Removed.
215         * gtk/common.py: Remove checks for the autotools build.
216         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
217
218 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
219
220         prepare-ChangeLog throws false positive warnings for modified files.
221         https://bugs.webkit.org/show_bug.cgi?id=130687
222
223         Reviewed by Darin Adler.
224
225         * Scripts/prepare-ChangeLog:
226         (originalFile): Ignore git commit paremeter.
227         We don't need this to get the unmodified file.
228         (extractLineRangeBeforeChange):
229         Simplify the if statement. Follow-up after r166189.
230
231 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
232
233         [EFL] Add ARM64 build support
234         https://bugs.webkit.org/show_bug.cgi?id=130506
235
236         Rubber stamped by Gyuyoung Kim.
237
238         * Scripts/webkitdirs.pm:
239         (isARM): Detect aarch64 as ARM.
240
241 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
242
243         [webkitpy] Improve _parse_bug_description to recognize more descriptions
244         https://bugs.webkit.org/show_bug.cgi?id=130137
245
246         Reviewed by Csaba Osztrogonác.
247
248         * Scripts/webkitpy/common/checkout/changelog.py:
249         (ChangeLogEntry._parse_bug_description):
250         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
251         (test_parse_log_entries_from_changelog):
252         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
253         (CheckoutTest.test_commit_info_for_revision):
254
255 2014-03-24  Andy Estes  <aestes@apple.com>
256
257         Fix the iOS build of TestWebKitAPI.
258
259         * TestWebKitAPI/Configurations/Base.xcconfig:
260         * TestWebKitAPI/PlatformUtilities.h:
261
262 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
263
264         Fix prepare-ChangeLog after r166156.
265         https://bugs.webkit.org/show_bug.cgi?id=130674
266
267         Reviewed by Darin Adler.
268
269         * Scripts/prepare-ChangeLog:
270         (generateFunctionLists):
271         (extractLineRangeBeforeChange):
272
273 2014-03-24  Andy Estes  <aestes@apple.com>
274
275         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
276         https://bugs.webkit.org/show_bug.cgi?id=129322
277
278         Reviewed by Anders Carlsson.
279
280         Add an API test suite for _WKDownload.
281
282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
283         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
284         (-[DownloadDelegate initWithSourceURL:]):
285         (-[DownloadDelegate sourceURL]):
286         (-[DownloadDelegate _downloadDidStart:]):
287         (-[DownloadDelegate _download:didReceiveResponse:]):
288         (-[DownloadDelegate _download:didReceiveData:]):
289         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
290         (-[DownloadDelegate _downloadDidFinish:]):
291         (TEST):
292         (runTestWithNavigationDelegate):
293         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
294         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
295
296 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
297
298         filter-build-webkit: reduce unfiltered output
299         https://bugs.webkit.org/show_bug.cgi?id=130485
300
301         Reviewed by Brent Fulgham.
302
303         * Scripts/filter-build-webkit:
304         (shouldIgnoreLine):
305
306 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
307
308         prepare-ChangeLog should list functions that have been removed too.
309         https://bugs.webkit.org/show_bug.cgi?id=130508
310
311         Reviewed by Darin Adler.
312
313         The prepare-ChangeLog does not list the deleted functions in the Changelog.
314         We have to read the functions and the line ranges of them from the source
315         before the change, then search for overlaps between them and the changed
316         line ranges from diff.
317
318         * Scripts/prepare-ChangeLog:
319         (originalFile): Get original source command.
320         (generateFunctionLists): Collect deleted functions too.
321         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
322         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
323         deleted functions ranges too.
324         (extractLineRange): Renamed to extractLineRangeAfterChange.
325
326 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
327
328         Move all EFL typedefs into EflTypedefs.h.
329         https://bugs.webkit.org/show_bug.cgi?id=130511
330
331         Reviewed by Gyuyoung Kim.
332
333         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
334         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
335         * WebKitTestRunner/PlatformWebView.h: Ditto.
336
337 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
338
339         Don't flush compositing layers within FrameView::willPaintContents()
340         https://bugs.webkit.org/show_bug.cgi?id=130627
341         <rdar://problem/16368869>
342
343         Reviewed by Sam Weinig.
344         
345         Fix DRT to correctly render tests with layers now that FrameView::paintContents
346         does not flush.
347         
348         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
349         into an explicit function called before dumping. 
350         
351         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
352         are flushed to CA. They will be pushed to the window by snapshotting.
353
354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
355         Fix weird path to IOKit.framework.
356         * DumpRenderTree/mac/DumpRenderTree.mm:
357         (updateDisplay):
358         (dump):
359         * DumpRenderTree/mac/FrameLoadDelegate.mm:
360         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
361         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
362
363 2014-03-21  David Kilzer  <ddkilzer@apple.com>
364
365         fix-blink-patch: tool to fix up renamed directory paths in Blink
366         <http://webkit.org/b/130609>
367
368         Reviewed by Ryosuke Niwa.
369
370         Usage: cat blink.patch | fix-blink-patch | svn-apply
371
372         * Scripts/fix-blink-patch: Added.
373
374 2014-03-21  Darin Adler  <darin@apple.com>
375
376         Remove use of deprecatedCharacters in WebKit API tests
377         https://bugs.webkit.org/show_bug.cgi?id=130602
378
379         Reviewed by Antti Koivisto.
380
381         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
382         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
383         (TestWebKitAPI::expectEmpty): Use characters8.
384         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
385
386         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
387         Removed the test that is entirely about 16-bit conversion since that's basically a test of
388         the deprecatedCharacters function itself, which we are about to delete.
389
390 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
391
392         [webkitpy] Fix has_valid_reviewer()
393         https://bugs.webkit.org/show_bug.cgi?id=130589
394
395         Reviewed by Csaba Osztrogonác.
396
397         * Scripts/webkitpy/common/checkout/changelog.py:
398         (ChangeLogEntry.has_valid_reviewer):
399         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
400         (test_has_valid_reviewer):
401         * Scripts/webkitpy/common/config/committers.py:
402         (CommitterList._reviewer_only):
403         (CommitterList.committer_by_name):
404         (CommitterList.reviewer_by_email):
405         (CommitterList):
406         (CommitterList.reviewer_by_name):
407
408 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
409
410         Add cache support for jhbuild
411         https://bugs.webkit.org/show_bug.cgi?id=130588
412
413         Reviewed by Csaba Osztrogonác.
414
415         * jhbuild/jhbuildrc_common.py:
416         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
417
418 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
419
420         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
421         https://bugs.webkit.org/show_bug.cgi?id=130504
422
423         Reviewed by Martin Robinson.
424
425         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
426         CMake if not specified.
427         * Scripts/webkitdirs.pm:
428         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
429         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
430
431 2014-03-21  Andreas Kling  <akling@apple.com>
432
433         RetainPtr API test should use CFArray instead of CFString for testing.
434         <rdar://problem/16384899>
435
436         Unreviewed bot fix.
437
438         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
441         (TestWebKitAPI::TEST):
442
443 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
444
445         Move to using std::unique_ptr for EFL objects.
446         https://bugs.webkit.org/show_bug.cgi?id=129853
447
448         Reviewed by Gyuyoung Kim.
449
450         EflUniquePtr is a template alias of std::unique_ptr
451         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
452         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
453
454         * DumpRenderTree/efl/DumpRenderTree.cpp:
455         (main):
456         * ImageDiff/efl/ImageDiff.cpp:
457         (initEfl):
458         (main):
459
460 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
461
462         Unreviewed buildfix after r165983 for non Cocoa platforms
463
464         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
465
466         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
467         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
468         * WebKitTestRunner/TestController.cpp:
469
470 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
471
472         [GTK][CMake] Add support for building with Clang
473         https://bugs.webkit.org/show_bug.cgi?id=130260
474
475         Reviewed by Martin Robinson.
476
477         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
478         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
479         included GTest framework headers.
480         * gtk/generate-gtkdoc:
481         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
482         in case of using Clang since that is now set by the CMake rule.
483
484 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
485
486         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
487         https://bugs.webkit.org/show_bug.cgi?id=130476
488
489         Reviewed by Anders Carlsson.
490         
491         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
492
493         * MiniBrowser/mac/WK1BrowserWindowController.m:
494         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
495         Remove log.
496         * MiniBrowser/mac/WK2BrowserWindowController.m:
497         (-[WK2BrowserWindowController awakeFromNib]):
498         (-[WK2BrowserWindowController validateMenuItem:]):
499         (-[WK2BrowserWindowController reload:]):
500         Hook up reload.
501         (-[WK2BrowserWindowController toggleZoomMode:]):
502         (-[WK2BrowserWindowController resetZoom:]):
503         (-[WK2BrowserWindowController canResetZoom]):
504         (-[WK2BrowserWindowController currentZoomFactor]):
505         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
506         (-[WK2BrowserWindowController canZoomIn]):
507         (-[WK2BrowserWindowController canZoomOut]):
508
509 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
510
511         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
512         https://bugs.webkit.org/show_bug.cgi?id=130463
513
514         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
515
516 2014-03-18  Samuel White  <samuel_white@apple.com>
517
518         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
519         https://bugs.webkit.org/show_bug.cgi?id=130250
520
521         Reviewed by Chris Fleizach.
522
523         Added ability to toggle enhanced accessibility on and off to support tests that require it.
524
525         * DumpRenderTree/AccessibilityController.cpp:
526         (enableEnhancedAccessibilityCallback):
527         (getEnhancedAccessibilityEnabledCallback):
528         (AccessibilityController::getJSClass):
529         * DumpRenderTree/AccessibilityController.h:
530         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
531         (AccessibilityController::enableEnhancedAccessibility):
532         (AccessibilityController::enhancedAccessibilityEnabled):
533         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
534         (AccessibilityController::enableEnhancedAccessibility):
535         (AccessibilityController::enhancedAccessibilityEnabled):
536         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
537         (AccessibilityController::enableEnhancedAccessibility):
538         (AccessibilityController::enhancedAccessibilityEnabled):
539         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
540         (AccessibilityController::enableEnhancedAccessibility):
541         (AccessibilityController::enhancedAccessibilityEnabled):
542         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
543         (WTR::AccessibilityController::enableEnhancedAccessibility):
544         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
545         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
546         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
547
548 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
549
550         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
551         yet).
552
553         * Scripts/webkitpy/common/config/contributors.json:
554
555 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
556
557         Web Inspector: Remove stale ReportMemoryUsagePlugin
558         https://bugs.webkit.org/show_bug.cgi?id=130405
559
560         Reviewed by Andreas Kling.
561
562         This clang plugin looks like it was used for the old Inspector memory
563         instrumentation that was removed. So the tool can be removed.
564
565         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
566         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
567         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
568         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
569
570 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
571
572         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
573         https://bugs.webkit.org/show_bug.cgi?id=130220
574
575         Reviewed by Csaba Osztrogonác.
576
577         * Scripts/webkitpy/common/checkout/changelog.py:
578         (ChangeLog.set_reviewer):
579         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
580         (test_set_reviewer):
581
582 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
583
584         More FTL enabling.
585
586         Rubber stamped by Dan Bernstein.
587
588         * Tools/Scripts/build-webkit:
589
590 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
591
592         Renable pagination mode in WK2 MiniBrowser
593         https://bugs.webkit.org/show_bug.cgi?id=130374
594
595         Reviewed by Anders Carlsson.
596         
597         Put the implementation of togglePaginationMode: back, and correctly
598         enable the menu item.
599
600         * MiniBrowser/mac/WK2BrowserWindowController.m:
601         (-[WK2BrowserWindowController validateMenuItem:]):
602         (-[WK2BrowserWindowController isPaginated]):
603         (-[WK2BrowserWindowController togglePaginationMode:]):
604
605 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
606
607         Add --reset option to Tools/Scripts/set-webkit-configuration script
608         https://bugs.webkit.org/show_bug.cgi?id=130401
609
610         Reviewed by Csaba Osztrogonác.
611
612         * Scripts/set-webkit-configuration:
613
614 2014-03-18  Alberto Garcia  <berto@igalia.com>
615
616         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
617         https://bugs.webkit.org/show_bug.cgi?id=130388
618
619         Reviewed by Sergio Villar Senin.
620
621         * Scripts/webkitdirs.pm:
622         (shouldRemoveCMakeCache): make sure that the build directory
623         exists before attempting to create a file in it.
624
625 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
626
627         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
628         https://bugs.webkit.org/show_bug.cgi?id=130336
629
630         Reviewed by Gyuyoung Kim.
631
632         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
633         requires a space between literal and string macro [-Wliteral-suffix]'
634         warning treated as error.
635
636         This patch applies a solution from r162448 to the EFL port.
637
638         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
639         * efl/jhbuild.modules: Added appropriate patch section.
640
641 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
642
643         webkitpy test rebaseline.
644
645         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
646         (MainTest.test_default_args):
647
648 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
649
650         --profile should imply --test-runner-count=1 in run-perf-tests
651         https://bugs.webkit.org/show_bug.cgi?id=130375
652
653         Reviewed by Benjamin Poulain.
654
655         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
656
657         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
658         (PerfTestsRunner._parse_args): Use -1 as the default value.
659         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
660         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
661         should be 1.
662
663 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
664
665         Address some style nits.
666
667         * MiniBrowser/mac/WK2BrowserWindowController.m:
668
669 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
670
671         Add transparent window support back into MiniBrowser
672         https://bugs.webkit.org/show_bug.cgi?id=130363
673
674         Reviewed by Anders Carlsson.
675         
676         Re-enable transparent window support for WK2.
677
678         * MiniBrowser/mac/WK2BrowserWindowController.m:
679         (-[WK2BrowserWindowController validateMenuItem:]):
680         (-[WK2BrowserWindowController toggleTransparentWindow:]):
681
682 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
683
684         Fix the 32-bit build; make the open panel make a WK1 window.
685
686         * MiniBrowser/mac/AppDelegate.m:
687         (-[BrowserAppDelegate openDocument:]):
688
689 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
690
691         Convert MiniBrowser to use WKWebView API
692         https://bugs.webkit.org/show_bug.cgi?id=130061
693
694         Reviewed by Anders Carlsson.
695         
696         Convert the MiniBrowser WK2 window to use WebKit2 API as much
697         as possible.
698         
699         Some functionality was removed temporarily:
700             - text zoom, page zoom
701             - reload
702             - pagination mode
703             - transparent window
704             - dumping source
705             - window.open support
706             - beforeUnload panel
707             - find in page
708
709         * MiniBrowser/mac/AppDelegate.h:
710         * MiniBrowser/mac/AppDelegate.m:
711         (-[BrowserAppDelegate init]):
712         (-[BrowserAppDelegate newWindow:]):
713         (-[BrowserAppDelegate applicationWillTerminate:]):
714         (-[BrowserAppDelegate openDocument:]):
715         * MiniBrowser/mac/WK2BrowserWindowController.h:
716         * MiniBrowser/mac/WK2BrowserWindowController.m:
717         (-[WK2BrowserWindowController awakeFromNib]):
718         (-[WK2BrowserWindowController dealloc]):
719         (-[WK2BrowserWindowController fetch:]):
720         (-[WK2BrowserWindowController validateMenuItem:]):
721         (-[WK2BrowserWindowController reload:]):
722         (-[WK2BrowserWindowController goBack:]):
723         (-[WK2BrowserWindowController goForward:]):
724         (-[WK2BrowserWindowController toggleZoomMode:]):
725         (-[WK2BrowserWindowController resetZoom:]):
726         (-[WK2BrowserWindowController canResetZoom]):
727         (-[WK2BrowserWindowController dumpSourceToConsole:]):
728         (-[WK2BrowserWindowController togglePaginationMode:]):
729         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
730         (-[WK2BrowserWindowController windowShouldClose:]):
731         (-[WK2BrowserWindowController applicationTerminating]):
732         (-[WK2BrowserWindowController currentZoomFactor]):
733         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
734         (-[WK2BrowserWindowController toggleTransparentWindow:]):
735         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
736         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
737         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
738         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
739         (-[WK2BrowserWindowController find:]):
740         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
741         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
742         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
743         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
744         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
745         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
746         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
747         * WebKitTestRunner/PlatformWebView.h:
748         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
749         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
750
751 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
752
753         Use RunLoop objects through references instead of pointers
754         https://bugs.webkit.org/show_bug.cgi?id=130313
755
756         Reviewed by Andreas Kling.
757
758         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
759         return RunLoop reference instead of a pointer.
760
761         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
762         (loadedCallback):
763         (clickedCallback):
764
765 2014-03-17  Tim Horton  <timothy_horton@apple.com>
766
767         sort-export-file --help doesn't work (missing 'use')
768         https://bugs.webkit.org/show_bug.cgi?id=130338
769
770         Reviewed by Anders Carlsson.
771
772         * Scripts/sort-export-file:
773         Add a missing 'use', and fix a typo in an error message.
774
775 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
776
777         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
778         https://bugs.webkit.org/show_bug.cgi?id=130155
779
780         Reviewed by Philippe Normand.
781
782         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
783
784 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
785
786         [GTK] MiniBrowser fails to load injected bundle lib
787         https://bugs.webkit.org/show_bug.cgi?id=130332
788
789         Reviewed by Anders Carlsson.
790
791         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
792
793         * MiniBrowser/gtk/main.c:
794         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
795         process is spawn.
796
797 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
798
799         [EFL] Enable TOUCH_SLIDER macro
800         https://bugs.webkit.org/show_bug.cgi?id=130185
801
802         Reviewed by Gyuyoung Kim.
803
804         * Scripts/webkitperl/FeatureList.pm:
805
806 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
807
808         [GTK][CMake] Build with -fno-rtti
809         https://bugs.webkit.org/show_bug.cgi?id=130261
810
811         Reviewed by Martin Robinson.
812
813         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
814         defined to 0 to prevent typeid use in included GTest headers.
815
816 2014-03-16  Brian Burg  <bburg@apple.com>
817
818         Web Inspector: vended backend commands file should be generated as part of the build
819         https://bugs.webkit.org/show_bug.cgi?id=130110
820
821         Reviewed by Timothy Hatcher.
822
823         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
824
825 2014-03-16  Diego Pino García  <dpino@igalia.com>
826
827         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
828         https://bugs.webkit.org/show_bug.cgi?id=128999
829
830         Reviewed by Philippe Normand.
831
832         * MiniBrowser/gtk/BrowserWindow.c:
833         (reloadPage):
834         (reloadPageIgnoringCache):
835         (browser_window_init):
836
837 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
838
839         [GTK] Improve ninja detection in webkitdirs.pm
840         https://bugs.webkit.org/show_bug.cgi?id=129902
841
842         Reviewed by Daniel Bates.
843
844         * Scripts/webkitdirs.pm:
845         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
846         us to look for ninja-build as well.
847
848 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
849
850         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
851         https://bugs.webkit.org/show_bug.cgi?id=130276
852         <rdar://problem/16266927>
853         
854         Reviewed by Simon Fraser.
855
856         * BuildSlaveSupport/build-launcher-app:
857         * BuildSlaveSupport/build-launcher-dmg:
858         * DumpRenderTree/DumpRenderTree.h:
859         * DumpRenderTree/DumpRenderTreePrefix.h:
860         * DumpRenderTree/GCController.cpp:
861         * DumpRenderTree/GCController.h:
862         * DumpRenderTree/JavaScriptThreading.cpp:
863         * DumpRenderTree/JavaScriptThreading.h:
864         * DumpRenderTree/PixelDumpSupport.cpp:
865         * DumpRenderTree/PixelDumpSupport.h:
866         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
867         * DumpRenderTree/TestRunner.cpp:
868         * DumpRenderTree/TestRunner.h:
869         * DumpRenderTree/WorkQueue.cpp:
870         * DumpRenderTree/WorkQueue.h:
871         * DumpRenderTree/WorkQueueItem.h:
872         * DumpRenderTree/atk/AccessibilityCallbacks.h:
873         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
874         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
875         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
876         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
877         * DumpRenderTree/cg/PixelDumpSupportCG.h:
878         * DumpRenderTree/efl/EditingCallbacks.cpp:
879         * DumpRenderTree/efl/EditingCallbacks.h:
880         * DumpRenderTree/efl/EventSender.cpp:
881         * DumpRenderTree/efl/EventSender.h:
882         * DumpRenderTree/efl/GCControllerEfl.cpp:
883         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
884         * DumpRenderTree/efl/TestRunnerEfl.cpp:
885         * DumpRenderTree/gtk/DumpRenderTree.cpp:
886         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
887         * DumpRenderTree/gtk/EditingCallbacks.cpp:
888         * DumpRenderTree/gtk/EditingCallbacks.h:
889         * DumpRenderTree/gtk/EventSender.cpp:
890         * DumpRenderTree/gtk/EventSender.h:
891         * DumpRenderTree/gtk/GCControllerGtk.cpp:
892         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
893         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
894         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
895         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
896         * DumpRenderTree/gtk/TextInputController.cpp:
897         * DumpRenderTree/gtk/TextInputController.h:
898         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
899         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
900         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
901         * DumpRenderTree/mac/AppleScriptController.h:
902         * DumpRenderTree/mac/AppleScriptController.m:
903         * DumpRenderTree/mac/CheckedMalloc.cpp:
904         * DumpRenderTree/mac/CheckedMalloc.h:
905         * DumpRenderTree/mac/DumpRenderTree.mm:
906         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
907         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
908         * DumpRenderTree/mac/DumpRenderTreeMac.h:
909         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
910         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
911         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
912         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
913         * DumpRenderTree/mac/EditingDelegate.h:
914         * DumpRenderTree/mac/EditingDelegate.mm:
915         * DumpRenderTree/mac/EventSendingController.h:
916         * DumpRenderTree/mac/EventSendingController.mm:
917         * DumpRenderTree/mac/FrameLoadDelegate.h:
918         * DumpRenderTree/mac/FrameLoadDelegate.mm:
919         * DumpRenderTree/mac/GCControllerMac.mm:
920         * DumpRenderTree/mac/MockWebNotificationProvider.h:
921         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
922         * DumpRenderTree/mac/NavigationController.h:
923         * DumpRenderTree/mac/NavigationController.m:
924         * DumpRenderTree/mac/ObjCController.h:
925         * DumpRenderTree/mac/ObjCController.m:
926         * DumpRenderTree/mac/ObjCPlugin.h:
927         * DumpRenderTree/mac/ObjCPlugin.m:
928         * DumpRenderTree/mac/ObjCPluginFunction.h:
929         * DumpRenderTree/mac/ObjCPluginFunction.m:
930         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
931         * DumpRenderTree/mac/PolicyDelegate.h:
932         * DumpRenderTree/mac/PolicyDelegate.mm:
933         * DumpRenderTree/mac/ResourceLoadDelegate.h:
934         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
935         * DumpRenderTree/mac/TestRunnerMac.mm:
936         * DumpRenderTree/mac/TextInputController.h:
937         * DumpRenderTree/mac/TextInputController.m:
938         * DumpRenderTree/mac/UIDelegate.h:
939         * DumpRenderTree/mac/UIDelegate.mm:
940         * DumpRenderTree/mac/WorkQueueItemMac.mm:
941         * DumpRenderTree/win/DRTDataObject.cpp:
942         * DumpRenderTree/win/DRTDataObject.h:
943         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
944         * DumpRenderTree/win/DRTDropSource.cpp:
945         * DumpRenderTree/win/DRTDropSource.h:
946         * DumpRenderTree/win/DraggingInfo.h:
947         * DumpRenderTree/win/DumpRenderTree.cpp:
948         * DumpRenderTree/win/DumpRenderTreeWin.h:
949         * DumpRenderTree/win/EditingDelegate.cpp:
950         * DumpRenderTree/win/EditingDelegate.h:
951         * DumpRenderTree/win/EventSender.cpp:
952         * DumpRenderTree/win/EventSender.h:
953         * DumpRenderTree/win/FrameLoadDelegate.cpp:
954         * DumpRenderTree/win/FrameLoadDelegate.h:
955         * DumpRenderTree/win/GCControllerWin.cpp:
956         * DumpRenderTree/win/HistoryDelegate.cpp:
957         * DumpRenderTree/win/HistoryDelegate.h:
958         * DumpRenderTree/win/MD5.cpp:
959         * DumpRenderTree/win/MD5.h:
960         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
961         * DumpRenderTree/win/PolicyDelegate.cpp:
962         * DumpRenderTree/win/PolicyDelegate.h:
963         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
964         * DumpRenderTree/win/ResourceLoadDelegate.h:
965         * DumpRenderTree/win/TestRunnerWin.cpp:
966         * DumpRenderTree/win/TextInputController.cpp:
967         * DumpRenderTree/win/TextInputController.h:
968         * DumpRenderTree/win/TextInputControllerWin.cpp:
969         * DumpRenderTree/win/UIDelegate.cpp:
970         * DumpRenderTree/win/UIDelegate.h:
971         * DumpRenderTree/win/WorkQueueItemWin.cpp:
972         * EWebLauncher/main.c:
973         * GtkLauncher/main.c:
974         * ImageDiff/efl/ImageDiff.cpp:
975         * ImageDiff/gtk/ImageDiff.cpp:
976         * MiniBrowser/gtk/main.c:
977         * Scripts/SpacingHeuristics.pm:
978         * Scripts/VCSUtils.pm:
979         * Scripts/bisect-builds:
980         * Scripts/build-dumprendertree:
981         * Scripts/build-jsc:
982         * Scripts/build-webkit:
983         * Scripts/check-dom-results:
984         * Scripts/check-for-exit-time-destructors:
985         * Scripts/check-for-global-initializers:
986         * Scripts/commit-log-editor:
987         * Scripts/compare-timing-files:
988         * Scripts/debug-minibrowser:
989         * Scripts/debug-safari:
990         * Scripts/do-file-rename:
991         * Scripts/find-extra-includes:
992         * Scripts/generate-coverage-data:
993         * Scripts/make-script-test-wrappers:
994         * Scripts/malloc-tree:
995         * Scripts/old-run-webkit-tests:
996         * Scripts/parse-malloc-history:
997         * Scripts/report-include-statistics:
998         * Scripts/resolve-ChangeLogs:
999         * Scripts/run-bindings-tests:
1000         * Scripts/run-iexploder-tests:
1001         * Scripts/run-javascriptcore-tests:
1002         * Scripts/run-jsc:
1003         * Scripts/run-launcher:
1004         * Scripts/run-leaks:
1005         * Scripts/run-mangleme-tests:
1006         * Scripts/run-minibrowser:
1007         * Scripts/run-pageloadtest:
1008         * Scripts/run-regexp-tests:
1009         * Scripts/run-safari:
1010         * Scripts/run-sunspider:
1011         * Scripts/run-webkit-app:
1012         * Scripts/sampstat:
1013         * Scripts/set-webkit-configuration:
1014         * Scripts/sort-Xcode-project-file:
1015         * Scripts/sort-export-file:
1016         * Scripts/split-file-by-class:
1017         * Scripts/sunspider-compare-results:
1018         * Scripts/svn-apply:
1019         * Scripts/svn-create-patch:
1020         * Scripts/svn-unapply:
1021         * Scripts/test-webkit-scripts:
1022         * Scripts/update-javascriptcore-test-results:
1023         * Scripts/update-webkit:
1024         * Scripts/update-webkit-auxiliary-libs:
1025         * Scripts/update-webkit-dependency:
1026         * Scripts/update-webkit-localizable-strings:
1027         * Scripts/update-webkit-support-libs:
1028         * Scripts/update-webkit-wincairo-libs:
1029         * Scripts/webkit-build-directory:
1030         * Scripts/webkitdirs.pm:
1031         (installedSafariPath):
1032         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1033         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1034         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1035         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1036         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1037         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1038         * Scripts/webkitperl/features.pm:
1039         * Scripts/webkitperl/httpd.pm:
1040         * Scripts/webkitpy/bindings/main.py:
1041         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1042         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1043         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1044         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1045         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1046         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1047         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1048         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1049         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1050         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1051         * WebKitTestRunner/PixelDumpSupport.cpp:
1052         * WebKitTestRunner/PixelDumpSupport.h:
1053         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1054         * WinLauncher/WinLauncher.cpp:
1055         * WinLauncher/WinLauncher.h:
1056         * WinLauncher/stdafx.cpp:
1057         * WinLauncher/stdafx.h:
1058
1059 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1060
1061         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1062         https://bugs.webkit.org/show_bug.cgi?id=130265
1063
1064         Reviewed by Michael Saboff.
1065
1066         * Scripts/build-webkit:
1067         * Scripts/copy-webkitlibraries-to-product-directory:
1068
1069 2014-03-14  Landry Breuil  <landry@openbsd.org>
1070
1071         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1072         Also allow to set MAKE in the environment.
1073         https://bugs.webkit.org/show_bug.cgi?id=129991
1074
1075         Reviewed by Andreas Kling.
1076
1077         * Scripts/webkitdirs.pm:
1078         (determineArchitecture):
1079         (determineNumberOfCPUs):
1080         (isBSD):
1081         (buildAutotoolsProject):
1082         * Scripts/webkitpy/common/system/platforminfo.py:
1083         (PlatformInfo.__init__):
1084         (PlatformInfo.is_openbsd):
1085         (PlatformInfo):
1086         (PlatformInfo.is_netbsd):
1087         (PlatformInfo._determine_os_name):
1088
1089 2014-03-14  Dean Jackson  <dino@apple.com>
1090
1091         Remove libWebKitSystemInterfaceLion.a
1092         https://bugs.webkit.org/show_bug.cgi?id=130254
1093
1094         Reviewed by Geoffrey Garen and Andreas Kling.
1095
1096         No need to copy the Lion libraries into the build.
1097
1098         * Scripts/copy-webkitlibraries-to-product-directory:
1099
1100 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1101
1102         [EFL][MiniBrowser] Revise help messages of command line parameters
1103         https://bugs.webkit.org/show_bug.cgi?id=130222
1104
1105         Reviewed by Csaba Osztrogonác.
1106
1107         Correct the default value description and make help messages to be consistent.
1108
1109         * MiniBrowser/efl/main.c:
1110
1111 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1112
1113         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1114         https://bugs.webkit.org/show_bug.cgi?id=129612
1115
1116         Reviewed by Darin Adler.
1117
1118         For new code use static NeverDestroyed<T> instead.
1119
1120         * DumpRenderTree/JavaScriptThreading.cpp:
1121         (javaScriptThreadsMutex):
1122         (javaScriptThreads):
1123         * DumpRenderTree/efl/EventSender.cpp:
1124         (touchPointList):
1125         (delayedEventQueue):
1126         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1127         (delegatesWithDelayedWork):
1128         * Scripts/check-for-exit-time-destructors:
1129         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1130         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1131         (testsMap):
1132
1133 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1134
1135         [EFL][WK2] Fix compilation warning in Minibrowser
1136         https://bugs.webkit.org/show_bug.cgi?id=130132
1137
1138         Reviewed by Csaba Osztrogonác.
1139
1140         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1141
1142         * MiniBrowser/efl/main.c:
1143         (on_download_request):
1144
1145 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1146
1147         FTL should support IsBlah
1148         https://bugs.webkit.org/show_bug.cgi?id=130202
1149
1150         Reviewed by Geoffrey Garen.
1151         
1152         Running existing JSRegress tests with noInline gives us coverage for these
1153         changes. Chances are, this will also give coverage for other interesting things
1154         as well.
1155
1156         * Scripts/run-jsc-stress-tests:
1157
1158 2014-03-12  Brian Burg  <bburg@apple.com>
1159
1160         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1161         https://bugs.webkit.org/show_bug.cgi?id=129744
1162
1163         Reviewed by Timothy Hatcher.
1164
1165         * DumpRenderTree/TestRunner.cpp:
1166         (evaluateInWebInspectorCallback):
1167         * DumpRenderTree/TestRunner.h:
1168         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1169         (TestRunner::evaluateInWebInspector):
1170         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1171         (TestRunner::evaluateInWebInspector):
1172         * DumpRenderTree/mac/TestRunnerMac.mm:
1173         (TestRunner::evaluateInWebInspector):
1174         * DumpRenderTree/win/TestRunnerWin.cpp:
1175         (TestRunner::evaluateInWebInspector):
1176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1178         (WTR::TestRunner::evaluateInWebInspector):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1180
1181 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1182
1183         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1184         https://bugs.webkit.org/show_bug.cgi?id=130129
1185
1186         Reviewed by Csaba Osztrogonác.
1187
1188         * Scripts/webkitdirs.pm:
1189         (canUseNinja): Redirecting stderr to /dev/null
1190
1191 2014-03-13  Andres Gomez  <agomez@igalia.com>
1192
1193         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1194         https://bugs.webkit.org/show_bug.cgi?id=130092
1195
1196         Reviewed by Csaba Osztrogonác.
1197
1198         Added "python-dev" as dependency for deb based distros. It is
1199         already present for rpm based distros. This dependency will allow
1200         libxml2 to generate its python bindings, needed by gtk-doc.
1201
1202         * gtk/install-dependencies:
1203
1204 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1205
1206         Unreviewed. Fix GTK+ cmake build after r165488.
1207
1208         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1209
1210 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1211
1212         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1213         https://bugs.webkit.org/show_bug.cgi?id=130014
1214
1215         Reviewed by Martin Robinson.
1216
1217         Include cmake or autotools config header.
1218
1219         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1220         * MiniBrowser/gtk/BrowserSearchBar.c:
1221         * MiniBrowser/gtk/BrowserWindow.c:
1222         * MiniBrowser/gtk/main.c:
1223
1224 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1225
1226         Unreviewed, rolling out r165471.
1227         https://bugs.webkit.org/show_bug.cgi?id=130139
1228
1229         Didn't really fix the issue and broke another bot (Requested
1230         by mrobinson on #webkit).
1231
1232         Reverted changeset:
1233
1234         "[CMake] Newer versions of CMake cannot find older versions of
1235         Freetype"
1236         https://bugs.webkit.org/show_bug.cgi?id=130107
1237         http://trac.webkit.org/changeset/165471
1238
1239 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1240
1241         It should be possible to build WebKit with FTL on iOS
1242         https://bugs.webkit.org/show_bug.cgi?id=130116
1243
1244         Reviewed by Dan Bernstein.
1245
1246         * Scripts/build-webkit:
1247         * Scripts/copy-webkitlibraries-to-product-directory:
1248
1249 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1250
1251         [Win] Remove use of QTSDK
1252         https://bugs.webkit.org/show_bug.cgi?id=130049
1253
1254         Reviewed by Darin Adler.
1255
1256         * DumpRenderTree/win/DumpRenderTree.cpp:
1257         (initialize): Remove QuickTime code.
1258         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1259         building QTMovieWin.
1260
1261 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1262
1263         [GTK][CMAKE] Too verbose build output
1264         https://bugs.webkit.org/show_bug.cgi?id=130076
1265
1266         Reviewed by Carlos Garcia Campos.
1267
1268         Instead of building with cmake --build which isn't smart about pretty printing and
1269         colors, we build with a script which calls the proper build command.
1270
1271         * Scripts/webkitdirs.pm:
1272         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1273         the CMake configuration pass.
1274
1275 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1276
1277         [CMake] Newer versions of CMake cannot find older versions of Freetype
1278         https://bugs.webkit.org/show_bug.cgi?id=130107
1279
1280         Reviewed by Gustavo Noronha Silva.
1281
1282         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1283         to CMake during jhbuild initialization.
1284
1285 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1286
1287         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1288         https://bugs.webkit.org/show_bug.cgi?id=129961
1289
1290         Reviewed by Simon Fraser.
1291
1292         Now scaled content can go through the window capturing mechanism too for compositing content.
1293         AppleMagnifiedMode is redundant.
1294
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (setDefaultsToConsistentValuesForTesting):
1297         (runTest):
1298         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1299         (createBitmapContextFromWebView):
1300         * WebKitTestRunner/PlatformWebView.h:
1301         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1302         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1303         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1304         (WTR::PlatformWebView::didInitializeClients):
1305         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1306         (WTR::PlatformWebView::forceWindowFramesChanged):
1307         * WebKitTestRunner/mac/main.mm:
1308         (setDefaultsToConsistentValuesForTesting):
1309
1310 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1311
1312         Unreviewed. Add myself as a committer.
1313
1314         * Scripts/webkitpy/common/config/contributors.json:
1315
1316 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1317
1318         Unreviewed build fix on the EFL port when used lower version of ATK
1319
1320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1321         (WTR::AccessibilityUIElement::y): Fixed typo.
1322
1323 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1324
1325         Some images are blank in the rebaseline server UI
1326         https://bugs.webkit.org/show_bug.cgi?id=130104
1327
1328         Reviewed by Tim Horton.
1329
1330         Let the server check for images in the 'retries' directory
1331         if it can't find an image otherwise.
1332
1333         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1334         (RebaselineHTTPRequestHandler.test_result):
1335
1336 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1337
1338         [GTK][CMake] --update-gtk has no effect
1339         https://bugs.webkit.org/show_bug.cgi?id=130088
1340
1341         Reviewed by Philippe Normand.
1342
1343         * Scripts/webkitdirs.pm:
1344         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1345         as an argument.
1346
1347 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1348
1349         Add "System Font" to the list of whitelisted DRT fonts
1350         https://bugs.webkit.org/show_bug.cgi?id=130046
1351
1352         Reviewed by Darin Adler.
1353
1354         * DumpRenderTree/mac/DumpRenderTree.mm:
1355         (allowedFontFamilySet):
1356         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1357
1358 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1359
1360         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1361         https://bugs.webkit.org/show_bug.cgi?id=130064
1362
1363         Reviewed by Philippe Normand.
1364
1365         * efl/jhbuildrc: Remove duplicated code.
1366         * gtk/jhbuildrc: Remove duplicated code.
1367         * jhbuild/jhbuildrc_common.py:
1368         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1369         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1370         and is apparently necessary for GTK+.
1371
1372 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1373
1374         check-webkit-style failed to complain about missing braces
1375         https://bugs.webkit.org/show_bug.cgi?id=34189
1376
1377         Reviewed by Ryosuke Niwa.
1378
1379         * Scripts/webkitpy/style/checkers/cpp.py:
1380         (check_braces):
1381         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1382         (WebKitStyleTest.test_braces):
1383
1384 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1385
1386         Remove Qt cruft from style checker.
1387         https://bugs.webkit.org/show_bug.cgi?id=130085
1388
1389         Reviewed by Csaba Osztrogonác.
1390
1391         There is no 'foreach' keyword in c++. That was a Qt feature
1392         added in: http://trac.webkit.org/changeset/46113
1393         Qt was removed from WebKit, so we should remove the checks
1394         of this keyword from check-webkit-style scripts.
1395
1396         * Scripts/webkitpy/style/checkers/cpp.py:
1397         (check_spacing_for_function_call):
1398         (check_spacing):
1399         (check_braces):
1400         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1401         (CppStyleTest.test_mismatching_spaces_in_parens):
1402         (CppStyleTest.test_spacing_for_fncall):
1403         (WebKitStyleTest.test_braces):
1404
1405 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1406
1407         [GTK] update-webkitgtk-libs needs itstool
1408         https://bugs.webkit.org/show_bug.cgi?id=130082
1409
1410         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1411         itstool is a dependency of building gtk-doc from version 1.19, so it should
1412         be added to Tools/gtk/install-dependencies script, too.
1413
1414         Reviewed by Philippe Normand.
1415
1416         * gtk/install-dependencies:
1417
1418 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1419
1420         webkitbot rollout ChangeLogs should be nicer
1421         https://bugs.webkit.org/show_bug.cgi?id=122654
1422
1423         Reviewed by Csaba Osztrogonác.
1424
1425         Added bug urls and descriptions of rolled out patches to the rollout changelog
1426         if they are present in the original changelog. Additionally removed the list of
1427         changed files and functions.
1428
1429         * Scripts/webkitpy/common/checkout/changelog.py:
1430         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1431         * Scripts/webkitpy/common/checkout/checkout.py:
1432         (Checkout._changelog_data_for_revision): Store bug description.
1433         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1434         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1435         (CheckoutTest.test_commit_info_for_revision):
1436         * Scripts/webkitpy/common/checkout/commitinfo.py:
1437         (CommitInfo.bug_description): Added.
1438         (CommitInfo.to_json):
1439         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1440         (CommitInfoTest.test_commit_info_creation):
1441         * Scripts/webkitpy/tool/commands/download.py:
1442         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1443         out patches for creating rollout changelog.
1444         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1445         caused the regression is stored in state["bug_blocked"] now.
1446         * Scripts/webkitpy/tool/commands/download_unittest.py:
1447         (test_prepare_rollout):
1448         (test_create_rollout_multiple_revision):
1449         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1450         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1451         rolled out patches to the changelog.
1452         (PrepareChangeLogForRevert.run):
1453         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1454         (UpdateChangeLogsForRevertTest):
1455         (test_message_for_revert):
1456         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1457         (ReopenBugAfterRollout.run):
1458
1459 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1460
1461         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1462         https://bugs.webkit.org/show_bug.cgi?id=130021
1463
1464         Reviewed by Mario Sanchez Prada.
1465
1466         Replace deprecated functions to use new API from ATK 2.11.90.
1467
1468         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1469         (AccessibilityUIElement::x):
1470         (AccessibilityUIElement::y):
1471         (AccessibilityUIElement::width):
1472         (AccessibilityUIElement::height):
1473         (AccessibilityUIElement::clickPointX):
1474         (AccessibilityUIElement::clickPointY):
1475         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1476         (WTR::AccessibilityUIElement::x):
1477         (WTR::AccessibilityUIElement::y):
1478         (WTR::AccessibilityUIElement::width):
1479         (WTR::AccessibilityUIElement::height):
1480         (WTR::AccessibilityUIElement::clickPointX):
1481         (WTR::AccessibilityUIElement::clickPointY):
1482
1483 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1484
1485         [ATK] Expose aria-posinset and aria-setsize through object attributes
1486         https://bugs.webkit.org/show_bug.cgi?id=130011
1487
1488         Reviewed by Chris Fleizach.
1489
1490         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1491
1492         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1493         (AccessibilityUIElement::numberAttributeValue):
1494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1495         (WTR::AccessibilityUIElement::numberAttributeValue):
1496
1497 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1498
1499         [Win] Unreviewed build fix.
1500
1501         Some bad Windows code was committed at some point that prevents the Apple Windows port
1502         from finding its runtime dependencies reliably.
1503
1504         * win/DLLLauncher/DLLLauncherMain.cpp:
1505         (appleApplicationSupportDirectory): Restored this function.
1506         (modifyPath): Update to use appleApplicationSupportDirectory function.
1507
1508 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1509
1510         Let the user define the full address of the performance-site-server for uploading results
1511         https://bugs.webkit.org/show_bug.cgi?id=129819
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1516         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1517         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1518         protocol for now, in order to avoid breaking the perf bots.
1519
1520         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1521         (_upload_json):
1522         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1523         (MainTest.test_upload_json):
1524
1525 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1526
1527         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1528         https://bugs.webkit.org/show_bug.cgi?id=130023
1529
1530         Reviewed by Dean Jackson.
1531
1532         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1533         /SAFESEH flag to DLL launcher process.
1534
1535 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1536
1537         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1538         https://bugs.webkit.org/show_bug.cgi?id=129980
1539
1540         Reviewed by Carlos Garcia Campos.
1541
1542         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1543
1544 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1545
1546         [GTK] Remove the WebView source-mode WebKit1 test
1547         https://bugs.webkit.org/show_bug.cgi?id=129976
1548
1549         Reviewed by Carlos Garcia Campos.
1550
1551         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1552
1553 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1554
1555         Unreviewed build fix for GTKbuild after the switch to CMake
1556
1557         * gtk/common.py:
1558         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1559         test-only bot doesn't have any build files.
1560
1561 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1562
1563         [GTK] built-product-archive does not handle GTK+ CMake build
1564         https://bugs.webkit.org/show_bug.cgi?id=129941
1565
1566         * BuildSlaveSupport/built-product-archive:
1567         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1568         the CMake build.
1569
1570 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1571
1572         [GTK] Include CMake into install-dependencies script
1573         https://bugs.webkit.org/show_bug.cgi?id=129909
1574
1575         Reviewed by Martin Robinson.
1576
1577         As since r165267 buid-webkit uses CMake by default, the dependency
1578         with 'cmake' package should be introduced.
1579
1580         * gtk/install-dependencies: Ditto.
1581
1582 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1583
1584         REGRESSION(165267): Broke a webkitpy unit tests
1585         https://bugs.webkit.org/show_bug.cgi?id=129904
1586
1587         Reviewed by Jon Honeycutt.
1588
1589         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1590         (GtkPort._is_cmake_build):
1591
1592 2014-03-07  Andres Gomez  <agomez@igalia.com>
1593
1594         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1595         https://bugs.webkit.org/show_bug.cgi?id=129893
1596
1597         Reviewed by Martin Robinson.
1598
1599         Added "git-svn" as dependency for deb based distros and,
1600         additionally, "subversion" for rpm based distros.
1601
1602         * gtk/install-dependencies:
1603
1604 2014-03-07  Roger Fong  <roger_fong@apple.com>
1605
1606         Remove dummy setSystemWebGLLoadPolicy client method.
1607         https://bugs.webkit.org/show_bug.cgi?id=129873.
1608
1609         Reviewed by Dean Jackson.
1610
1611         * WebKitTestRunner/TestController.cpp:
1612         (WTR::TestController::createWebViewWithOptions):
1613
1614 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1615
1616         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1617         https://bugs.webkit.org/show_bug.cgi?id=129886
1618
1619         Reviewed by Mark Lam.
1620
1621         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1622         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1623         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1624         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1625         make it through when in non-verbose mode.
1626
1627 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1628
1629         [GTK] buid-webkit should use CMake by default
1630         https://bugs.webkit.org/show_bug.cgi?id=129855
1631
1632         Reviewed by Carlos Garcia Campos.
1633
1634         Make the CMake build the default GTK+ build when using build-webkit. This will
1635         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1636         so that we have --gtk and --gtkautotools.
1637
1638         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1639         * Scripts/webkitpy/port/gtk.py: Ditto.
1640
1641 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1642
1643         [CMake] [GTK] Build with ninja when it is available
1644         https://bugs.webkit.org/show_bug.cgi?id=129805
1645
1646         Reviewed by Philippe Normand.
1647
1648         * Scripts/webkitdirs.pm:
1649         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1650         if it's available on the system.
1651         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1652         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1653
1654 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1655
1656         If the FTL is build-time enabled then it should be run-time enabled.
1657
1658         Rubber stamped by Geoffrey Garen.
1659
1660         * Scripts/run-jsc-stress-tests:
1661
1662 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1663
1664         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1665         https://bugs.webkit.org/show_bug.cgi?id=129837
1666
1667         Reviewed by Michael Saboff.
1668
1669         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1670         The fix is to use find instead of ls like we do in shell-runner.sh.
1671
1672         * Scripts/run-jsc-stress-tests:
1673
1674 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1675
1676         filter-build-webkit should not strip .o
1677         https://bugs.webkit.org/show_bug.cgi?id=129614
1678
1679         Reviewed by Dean Jackson.
1680
1681         This makes it much easier to jump from the failing output at
1682         the end back up to the compile errors earlier in the output.
1683
1684         * Scripts/filter-build-webkit:
1685
1686 2014-03-06  Anders Carlsson  <andersca@apple.com>
1687
1688         Build WebKit2 before building WebKit
1689         https://bugs.webkit.org/show_bug.cgi?id=129831
1690         <rdar://problem/15920020>
1691
1692         Reviewed by Dan Bernstein.
1693
1694         * Scripts/build-webkit:
1695         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1696
1697 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1698
1699         make-3.82 fails to build on ARM/Linux
1700         https://bugs.webkit.org/show_bug.cgi?id=107926
1701
1702         Reviewed by Martin Robinson.
1703
1704         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1705         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1706         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1707         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1708
1709         * gtk/patches/make-3.82-arg-list-length.patch:
1710
1711 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1712
1713         [GTK] Close the page when the view is disposed instead of when finalized
1714         https://bugs.webkit.org/show_bug.cgi?id=129783
1715
1716         Reviewed by Sergio Villar Senin.
1717
1718         Add test case but disabled for now because it's affetected by bug #129684.
1719
1720         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1721         (testProcessPerWebView):
1722
1723 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1724
1725         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1726         https://bugs.webkit.org/show_bug.cgi?id=129738
1727
1728         Reviewed by Sergio Villar Senin.
1729
1730         The problem is that we are calling g_object_unref() for the
1731         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1732         view only increases the reference counter when the settings is not
1733         the same it currently has. We should release our reference once.
1734
1735         * MiniBrowser/gtk/main.c:
1736         (createBrowserWindow):
1737         (main):
1738
1739 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1740
1741         [GTK][CMake] Tarball is created with wrong tarball paths
1742         https://bugs.webkit.org/show_bug.cgi?id=129496
1743
1744         Reviewed by Daniel Bates.
1745
1746         * gtk/make-dist.py:
1747         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1748         landing the original patch with some suggestions from the reviewer. With the
1749         checks corrected, the tarball path is constructed properly.
1750
1751 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1752
1753         Unreviewed. Update my email in contributors.json
1754
1755         * Scripts/webkitpy/common/config/contributors.json:
1756
1757 2014-03-05  Dean Jackson  <dino@apple.com>
1758
1759         [WebGL] Use WKSI to see what the system policy for WebGL is
1760         https://bugs.webkit.org/show_bug.cgi?id=129722
1761         <rdar://problem/15790542>
1762
1763         Reviewed by Tim Horton.
1764
1765         Dummy entry for setSystemWebGLLoadPolicy.
1766
1767         * WebKitTestRunner/TestController.cpp:
1768         (WTR::TestController::createWebViewWithOptions):
1769
1770 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1771
1772         [GTK][CMake] Generate documentation for the DOM bindings
1773         https://bugs.webkit.org/show_bug.cgi?id=126211
1774
1775         Reviewed by Carlos Garcia Campos.
1776
1777         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1778         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1779         * gtk/generate-webkitdom-doc-files: Removed.
1780         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1781         that it can be called by generate-gtkdoc.
1782
1783 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1784
1785         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1786         https://bugs.webkit.org/show_bug.cgi?id=129380
1787
1788         Reviewed by Philippe Normand.
1789
1790         * Scripts/webkitdirs.pm:
1791         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1792         skipping CMake execution.
1793
1794 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1795
1796         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1797         https://bugs.webkit.org/show_bug.cgi?id=129651
1798
1799         Reviewed by Philippe Normand.
1800
1801         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1802
1803 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1804
1805         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1806         https://bugs.webkit.org/show_bug.cgi?id=129637
1807
1808         Reviewed by Carlos Garcia Campos.
1809
1810         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1811         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1812         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1813         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1814         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1815         (TestFactory.__init__): Add the test for GTK+.
1816         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1817
1818 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1819
1820         [ATK] Expose missing functionalities of AtkTableCell to AT
1821         https://bugs.webkit.org/show_bug.cgi?id=129492
1822
1823         Reviewed by Mario Sanchez Prada.
1824
1825         Reducing some code by using new API of AtkTableCell.
1826
1827         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1828         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1829
1830 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1831
1832         Preparing to run layout tests on Wincairo.
1833         https://bugs.webkit.org/show_bug.cgi?id=129709
1834
1835         Reviewed by Brent Fulgham.
1836
1837         * Scripts/webkitdirs.pm:
1838         (setPathForRunningWebKitApp):
1839         Add GStreamer directory for WinCairo running layout tests.
1840         * win/DLLLauncher/DLLLauncherMain.cpp:
1841         (modifyPath):
1842         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1843
1844 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1845
1846         [GTK] Simplify the GObject DOM bindings API break check into one step
1847         https://bugs.webkit.org/show_bug.cgi?id=129571
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         * GNUmakefile.am: Add the API break check to 'make check.'
1852         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1853         * gtk/check-gdom-symbols: Removed.
1854         * gtk/webkitdom.py: Added.
1855         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1856         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1857
1858 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1859
1860         Add Jeremy Jones to the contributors list as a contributor.
1861
1862         * Scripts/webkitpy/common/config/contributors.json:
1863
1864 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1865
1866         Unreviewed. Update contact email.
1867         https://bugs.webkit.org/show_bug.cgi?id=129610
1868
1869         * Scripts/webkitpy/common/config/contributors.json:
1870
1871 2014-03-02  Brian Burg  <bburg@apple.com>
1872
1873         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1874         https://bugs.webkit.org/show_bug.cgi?id=129460
1875
1876         Reviewed by Dan Bernstein.
1877
1878         Don't unconditionally open the inspector before running an inspector test.
1879         Instead, the test should request that the inspector open when it's ready.
1880
1881         This change was lost during a rebase, but is the same change made to
1882         DumpRenderTree.
1883
1884         * WebKitTestRunner/TestInvocation.cpp:
1885         (WTR::TestInvocation::invoke): 
1886
1887 2014-03-02  Darin Adler  <darin@apple.com>
1888
1889         Split TextIteratorBehavior into a separate header
1890         https://bugs.webkit.org/show_bug.cgi?id=129578
1891
1892         Reviewed by Sam Weinig.
1893
1894         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1895         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1896         task easy, but the remove is still a bit of a pain.
1897
1898 2014-03-02  Darin Adler  <darin@apple.com>
1899
1900         Sort Mac platform export files so they merge better
1901         https://bugs.webkit.org/show_bug.cgi?id=129581
1902
1903         Reviewed by Sam Weinig.
1904
1905         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1906         Mac export files in a "canonical" order for this project.
1907
1908 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1909
1910         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1911         https://bugs.webkit.org/show_bug.cgi?id=129438
1912
1913         Reviewed by Simon Fraser.
1914
1915         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1916         offscreen window. It makes testing subpixel rendering and positioning possible.
1917
1918         Both the offscreen window's and WebKit's scaling are set accordingly.
1919
1920         * DumpRenderTree/mac/DumpRenderTree.mm:
1921         (createWebViewAndOffscreenWindow): cleanup
1922         (destroyWebViewAndOffscreenWindow): cleanup
1923         (dumpRenderTree):
1924         (changeWindowScaleIfNeeded):
1925         (runTest):
1926         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1927         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1928         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1929         * WebKitTestRunner/PlatformWebView.h:
1930         * WebKitTestRunner/TestInvocation.cpp:
1931         (WTR::changeWindowScaleIfNeeded):
1932         (WTR::TestInvocation::invoke):
1933         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1934         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1935         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1936         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1937         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1938         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1939         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1940         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1941
1942 2014-02-28  Anders Carlsson  <andersca@apple.com>
1943
1944         Remove logging.
1945
1946         Reviewed by Dan Bernstein.
1947
1948         * MiniBrowser/mac/WK2BrowserWindowController.m:
1949         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1950
1951 2014-02-28  Daniel Bates  <dabates@apple.com>
1952
1953         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1954         https://bugs.webkit.org/show_bug.cgi?id=129163
1955
1956         Reviewed by David Kilzer.
1957
1958         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1959         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1960         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1961         bundle.
1962
1963         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1964         which is specified either explicitly when building with MAKE(1) or implicitly by
1965         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1966         the OS X SDK and toolchain since the built products are only applicable to OS X.
1967
1968         * DumpRenderTree/ios/PerlSupport/Makefile:
1969
1970 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1971
1972         Unreviewed, rolling out r164859.
1973         http://trac.webkit.org/changeset/164859
1974         https://bugs.webkit.org/show_bug.cgi?id=129483
1975
1976         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1977         #webkit).
1978
1979         * DumpRenderTree/mac/DumpRenderTree.mm:
1980         (createWebViewAndOffscreenWindow):
1981         (dumpRenderTree):
1982         (runTest):
1983         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1984         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1985         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1986         * WebKitTestRunner/PlatformWebView.h:
1987         * WebKitTestRunner/TestInvocation.cpp:
1988         (WTR::TestInvocation::invoke):
1989         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1990         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1991         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1992         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1993         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1994
1995 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1996
1997         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1998         https://bugs.webkit.org/show_bug.cgi?id=129438
1999
2000         Reviewed by Simon Fraser.
2001
2002         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2003         offscreen window. It makes testing subpixel rendering and positioning possible.
2004
2005         Both the offscreen window's and WebKit's scaling are set accordingly.
2006
2007         * DumpRenderTree/mac/DumpRenderTree.mm:
2008         (createWebViewAndOffscreenWindow): unrelated cleanup.
2009         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2010         (dumpRenderTree):
2011         (changeOffscreenWindowScaleIfNeeded):
2012         (runTest):
2013         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2014         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2015         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2016         * WebKitTestRunner/PlatformWebView.h:
2017         * WebKitTestRunner/TestInvocation.cpp:
2018         (WTR::changeOffscreenWindowScaleIfNeeded):
2019         (WTR::TestInvocation::invoke):
2020         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2021         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2022
2023 2014-02-27  Brian Burg  <bburg@apple.com>
2024
2025         Web Inspector: model tests should use a special Test.html inspector page
2026         https://bugs.webkit.org/show_bug.cgi?id=129190
2027
2028         Reviewed by Timothy Hatcher.
2029
2030         Remove code that immediately opens the Web Inspector based on the file path of the test.
2031         Instead, the test page should request that the inspector open inside its `test()` method.
2032
2033         This change is necessary because otherwise, the inspector would be opened too early for
2034         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2035         will get loaded instead of the minimal test page.
2036
2037         * DumpRenderTree/efl/DumpRenderTree.cpp:
2038         (createTestRunner):
2039         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2040         (runTest):
2041         * DumpRenderTree/mac/DumpRenderTree.mm:
2042         (runTest):
2043         * DumpRenderTree/win/DumpRenderTree.cpp:
2044         (runTest):
2045
2046 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2047
2048         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2049         https://bugs.webkit.org/show_bug.cgi?id=127076
2050
2051         Reviewed by Anders Carlsson.
2052
2053         Avoid match for :: as start of a member initialization list. Modify expression to match
2054         after a colon either non-colon character or end of line.
2055
2056         * Scripts/webkitpy/style/checkers/cpp.py:
2057         (check_member_initialization_list):
2058         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2059         (WebKitStyleTest.test_member_initialization_list):
2060
2061 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2062
2063         Unreviewed. Update my email addresses in contributors.json.
2064
2065         * Scripts/webkitpy/common/config/contributors.json:
2066
2067 2014-02-27  Alberto Garcia  <berto@igalia.com>
2068
2069         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2070         https://bugs.webkit.org/show_bug.cgi?id=128927
2071
2072         Reviewed by Philippe Normand.
2073
2074         Encode manually the data for sys.{stdout,stderr}.write.
2075
2076         * gtk/gtkdoc.py:
2077         (GTKDoc._run_command):
2078
2079 2014-02-27  Andres Gomez  <agomez@igalia.com>
2080
2081         Unreviewed. Add myself to watchlists
2082
2083         * Scripts/webkitpy/common/config/watchlist: Add myself to
2084         watchlists.
2085
2086 2014-02-27  Andres Gomez  <agomez@igalia.com>
2087
2088         Unreviewed, rolling out r164790.
2089         http://trac.webkit.org/changeset/164790
2090
2091         Revert r164790 because of erroneous commit log
2092
2093         * Scripts/webkitpy/common/config/watchlist:
2094
2095 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2096
2097         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2098         https://bugs.webkit.org/show_bug.cgi?id=129250
2099
2100         Reviewed by Mario Sanchez Prada.
2101
2102         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2103         Implementing methods so that we could test column/row headers represented as an array of cells.
2104
2105         * DumpRenderTree/AccessibilityUIElement.cpp:
2106         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2107         (AccessibilityUIElement::columnHeaders):
2108         (AccessibilityUIElement::rowHeaders):
2109         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2110         (AccessibilityUIElement::columnHeaders):
2111         (AccessibilityUIElement::rowHeaders):
2112         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2113         (WTR::AccessibilityUIElement::rowHeaders):
2114         (WTR::AccessibilityUIElement::columnHeaders):
2115         * efl/jhbuild.modules:
2116         * gtk/jhbuild.modules:
2117
2118 2014-02-27  Andres Gomez  <agomez@igalia.com>
2119
2120         Unreviewed. Add myself to watchlists
2121
2122         * Scripts/webkitpy/common/config/watchlist: Add myself to
2123         watchlists.
2124
2125 2014-02-27  Andres Gomez  <agomez@igalia.com>
2126
2127         Unreviewed. Add myself as a committer.
2128
2129         * Scripts/webkitpy/common/config/contributors.json:
2130
2131 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2132
2133         Unreviewed. Add Víctor Jáquez and myself to watchlists
2134
2135         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2136         myself to watchlists.
2137
2138 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2139
2140         Unreviewed. Add myself as a committer.
2141
2142         * Scripts/webkitpy/common/config/contributors.json:
2143
2144 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2145
2146         Unreviewed. Moved myself to the list of committers.
2147
2148         * Scripts/webkitpy/common/config/contributors.json:
2149
2150 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2151
2152         [GTK] Reduplicate common.top_level_path in scripts
2153         https://bugs.webkit.org/show_bug.cgi?id=129291
2154
2155         Reviewed by Philippe Normand.
2156
2157         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2158         path manipulation and weird dependencies on the jhbuild infrastructure.
2159
2160         * Scripts/run-gtk-tests: Use common again.
2161         (TestRunner._setup_testing_environment): Ditto.
2162         * gtk/check-gdom-symbols: Ditto.
2163         * gtk/common.py:
2164         (top_level_path): Re-add top_level_path..
2165         (get_build_path): Use the builtin top_level_path again.
2166         * gtk/find-make-dist-errors: Use common again.
2167         (get_missing_headers): Ditto.
2168         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2169
2170 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2171
2172         runscript: line 42: /bin/ls: Argument list too long
2173         https://bugs.webkit.org/show_bug.cgi?id=129376
2174
2175         Reviewed by Michael Saboff.
2176
2177         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
2178         We should use find instead, which generates the list of files rather than expanding them all on 
2179         the command line and spitting them back out.
2180
2181         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
2182
2183 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2184
2185         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2186         https://bugs.webkit.org/show_bug.cgi?id=129377
2187
2188         Reviewed by Csaba Osztrogonác.
2189
2190         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2191
2192 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2193
2194         [GTK] Re-enable gtk-doc in EWS
2195         https://bugs.webkit.org/show_bug.cgi?id=128369
2196
2197         Reviewed by Carlos Garcia Campos.
2198
2199         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2200
2201         * Scripts/webkitpy/common/config/ports.py:
2202         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2203         (GtkWK2Port.build_webkit_command): Ditto.
2204         * Scripts/webkitpy/common/config/ports_unittest.py:
2205         (DeprecatedPortTest.test_gtk_port): Ditto.
2206         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2207
2208 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2209
2210         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2211         https://bugs.webkit.org/show_bug.cgi?id=129319
2212
2213         Reviewed by Carlos Garcia Campos.
2214
2215         * gtk/generate-gtkdoc:
2216         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2217
2218 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2219
2220         Unreviewed. Add myself as a committer.
2221
2222         * Scripts/webkitpy/common/config/contributors.json:
2223
2224 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2225
2226         [CSS Grid Layout] Add ENABLE flag
2227         https://bugs.webkit.org/show_bug.cgi?id=129153
2228
2229         Reviewed by Simon Fraser.
2230
2231         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2232         all ports for developer builds.
2233
2234         * Scripts/webkitperl/FeatureList.pm:
2235
2236 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2237
2238         Added myself as a committer.
2239
2240         Unreviewed.
2241
2242         * Scripts/webkitpy/common/config/contributors.json:
2243
2244 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2245
2246         Unreviewed. Moved myself to the list of committers.
2247
2248         * Scripts/webkitpy/common/config/contributors.json:
2249
2250 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2251
2252         Move myself to the committers list.
2253
2254         Unreviewed.
2255
2256         * Scripts/webkitpy/common/config/contributors.json:
2257
2258 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2259
2260         Unreviewed. Add myself as a committer.
2261
2262         * Scripts/webkitpy/common/config/contributors.json:
2263
2264 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2265
2266         Unreviewed, rolling out r164639.
2267         http://trac.webkit.org/changeset/164639
2268         https://bugs.webkit.org/show_bug.cgi?id=129302
2269
2270         gtk-doc still have problems in EWS (Requested by rego on
2271         #webkit).
2272
2273         * Scripts/webkitpy/common/config/ports.py:
2274         (GtkPort.build_webkit_command):
2275         (GtkWK2Port.build_webkit_command):
2276         * Scripts/webkitpy/common/config/ports_unittest.py:
2277         (DeprecatedPortTest.test_gtk_port):
2278         (DeprecatedPortTest.test_gtk_wk2_port):
2279
2280 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2281
2282         [GTK] Re-enable gtk-doc in EWS
2283         https://bugs.webkit.org/show_bug.cgi?id=128369
2284
2285         Reviewed by Carlos Garcia Campos.
2286
2287         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2288
2289         * Scripts/webkitpy/common/config/ports.py:
2290         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2291         (GtkWK2Port.build_webkit_command): Ditto.
2292         * Scripts/webkitpy/common/config/ports_unittest.py:
2293         (DeprecatedPortTest.test_gtk_port): Ditto.
2294         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2295
2296 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2297
2298         [GTK] Mark view source mode methods as deprecated
2299         https://bugs.webkit.org/show_bug.cgi?id=128920
2300
2301         Reviewed by Martin Robinson.
2302
2303         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2304         (beforeAll): Remove view mode test.
2305
2306 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2307
2308         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2309         https://bugs.webkit.org/show_bug.cgi?id=128417
2310
2311         Reviewed by Carlos Garcia Campos.
2312
2313         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2314         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2315         a makefile. This allows accepting a header list from the build system, which can be used
2316         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2317         have a corresponding header file on the header list. 
2318         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2319         source directories to gtkdoc-scan.
2320
2321 2014-02-24  Anders Carlsson  <andersca@apple.com>
2322
2323         Add a DefaultVisitedLinkProvider and route visited link actions through it
2324         https://bugs.webkit.org/show_bug.cgi?id=129285
2325
2326         Reviewed by Dan Bernstein.
2327
2328         * MiniBrowser/mac/AppDelegate.m:
2329         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2330         Set a shared history so we'll get visited link tracking.
2331
2332         * MiniBrowser/mac/WK1BrowserWindowController.m:
2333         (-[WK1BrowserWindowController awakeFromNib]):
2334         Set a group name.
2335
2336 2014-02-24  Dan Bernstein  <mitz@apple.com>
2337
2338         iOS build fix after r164577.
2339
2340         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2341         (AccessibilityUIElement::selectedChildrenCount):
2342         (AccessibilityUIElement::selectedChildAtIndex):
2343
2344 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2345
2346         [ASan] Remove methods from ignore list that no longer cause crashes
2347         <http://webkit.org/b/129257>
2348
2349         Reviewed by Anders Carlsson.
2350
2351         * asan/webkit-asan-ignore.txt: Remove old methods.
2352
2353 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2354
2355         Extract common parts from jhbuildrc files.
2356         https://bugs.webkit.org/show_bug.cgi?id=125986
2357
2358         Reviewed by Csaba Osztrogonác.
2359
2360         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2361
2362         * Scripts/run-gtk-tests:
2363         (TestRunner._setup_testing_environment):
2364         * efl/common.py: Removed.
2365         * efl/jhbuildrc:
2366         * gtk/check-gdom-symbols:
2367         * gtk/common.py:
2368         (binary_build_path):
2369         (get_build_path):
2370         * gtk/find-make-dist-errors:
2371         (get_missing_headers):
2372         * gtk/generate-gtkdoc:
2373         (get_webkit2_options):
2374         (get_webkit1_options.src_path):
2375         (get_webkit1_options):
2376         (get_webkitdom_options.src_path):
2377         (get_webkitdom_options):
2378         * gtk/generate-inspector-gresource-manifest.py:
2379         * gtk/jhbuildrc:
2380         * jhbuild/jhbuildrc_common.py: Added.
2381         (script_path):
2382         (top_level_path):
2383         (init):
2384
2385 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2386
2387         Unreviewed. Fix code indentation and spacing.
2388
2389         * Scripts/webkitpy/style/checkers/js.py:
2390         (SingleQuoteChecker.check):
2391
2392 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2393
2394         [ATK] Wrong selected element at a given index in a list box.
2395         https://bugs.webkit.org/show_bug.cgi?id=129039
2396
2397         Reviewed by Chris Fleizach.
2398
2399         Added missing implementation and proposed some new function for testing selection
2400         in a list boxes.
2401
2402         * DumpRenderTree/AccessibilityUIElement.cpp:
2403         (setSelectedChildAtIndexCallback):
2404         (removeSelectionAtIndexCallback):
2405         (AccessibilityUIElement::getJSClass):
2406         * DumpRenderTree/AccessibilityUIElement.h:
2407         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2408         (AccessibilityUIElement::selectedChildrenCount):
2409         (AccessibilityUIElement::selectedChildAtIndex):
2410         (AccessibilityUIElement::setSelectedChildAtIndex):
2411         (AccessibilityUIElement::removeSelectionAtIndex):
2412         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2413         (AccessibilityUIElement::selectedChildrenCount):
2414         (AccessibilityUIElement::selectedChildAtIndex):
2415         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2416         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2417         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2418         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2419         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2420         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2421         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2422         (WTR::AccessibilityUIElement::selectedChildrenCount):
2423         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2424         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2425
2426 2014-02-23  Diego Pino García  <dpino@igalia.com>
2427
2428         [GTK] Fix build after Web Inspector code reorganization (r164543)
2429         https://bugs.webkit.org/show_bug.cgi?id=129231
2430
2431         Reviewed by Dean Jackson.
2432
2433         * gtk/generate-inspector-gresource-manifest.py:
2434         Modify paths to Web Inspector code.
2435
2436 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2437
2438         [GTK] generate-gtkdoc should use argparse
2439         https://bugs.webkit.org/show_bug.cgi?id=128418
2440
2441         Reviewed by Carlos Garcia Campos.
2442
2443         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2444         to all functions, and guard the main routine with a __name__ == __main__ check.
2445
2446 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2447
2448         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2449         https://bugs.webkit.org/show_bug.cgi?id=129191
2450
2451         Reviewed by Anders Carlsson.
2452
2453         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2454         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2455         name of the directory is "lib" and not "libs". Instead we should use the CMake
2456         variable specifically assigned to this task.
2457
2458 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2459
2460         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2461         <http://webkit.org/b/129209>
2462
2463         Reviewed by Geoffrey Garen.
2464
2465         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2466         ignore list to make ASan builds usable again.  Follow-up
2467         investigation is tracked by <rdar://problem/16055903>.
2468
2469 2014-02-20  David Farler  <dfarler@apple.com>
2470
2471         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2472         https://bugs.webkit.org/show_bug.cgi?id=128622
2473
2474         Reviewed by Simon Fraser.
2475
2476         With this change, we now have layout tests running in both DumpRenderTree
2477         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2478         simulator.
2479
2480         * Scripts/old-run-webkit-tests:
2481         In general, make any specific reference to DumpRenderTree
2482         able to refer to WebKitTestRunner wherever possible:
2483         - Rename functions to remove DRT-specific naming.
2484         - Name FIFOs after the tool that is being used.
2485         -- Clean up FIFO creation code
2486         Other necessary changes:
2487         - Allow use of an ios-sim-wk2 platform.
2488         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2489         * WebKitTestRunner/TestController.cpp:
2490         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2491         (WTR::TestController::TestController):
2492         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2493         Copy the injected bundle into the app bundle.
2494
2495 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2496
2497         run-webkit-httpd fails to find httpd configuation file.
2498
2499         Reviewed by Ryosuke Niwa.
2500
2501         * Scripts/webkitperl/httpd.pm:
2502         (getHTTPDConfigPathForTestDirectory):
2503
2504 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2505
2506         Fix TimeRanges layering violations
2507         https://bugs.webkit.org/show_bug.cgi?id=128717
2508
2509         Reviewed by Jer Noble.
2510
2511         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2512         (TestWebKitAPI::TEST):
2513
2514 2014-02-21  Diego Pino García  <dpino@igalia.com>
2515
2516         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2517         https://bugs.webkit.org/show_bug.cgi?id=128422
2518
2519         Reviewed by Joseph Pecoraro.
2520
2521         * Scripts/webkitpy/style/checkers/js.py:
2522         (JSChecker.__init__):
2523         (JSChecker.check):
2524         (SingleQuoteChecker):
2525         (SingleQuoteChecker.__init__):
2526         (SingleQuoteChecker.check):
2527         * Scripts/webkitpy/style/checkers/js_unittest.py:
2528         (JSTestCase.assertError.error_for_test):
2529         (JSTestCase.assertError):
2530         (JSTestCase.test_no_error):
2531         (JSTestCase.test_error):
2532
2533 == Rolled over to ChangeLog-2014-02-20 ==