[PerformanceTests] tests have dependencies
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2
3         [PerformanceTests] tests have dependencies
4         https://bugs.webkit.org/show_bug.cgi?id=77506
5
6         Reviewed by Hajime Morita.
7
8         Load an initialization page before each test after starting a DRT so that
9         warming up DRT won't affect the performance test results.
10
11         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
12         (PerfTestsRunner):
13         (PerfTestsRunner.__init__):
14         (PerfTestsRunner._run_tests_set):
15         (PerfTestsRunner._run_single_test):
16         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
17         (MainTest.TestDriver.run_test):
18         (test_initial_page_loaded):
19         (test_initial_page_loaded.run_test):
20
21 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
22
23         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
24
25         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
26         (PerfTestsRunner._run_tests_set):
27         (PerfTestsRunner._run_single_test):
28         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
29         (create_runner):
30         (test_run_passing_test):
31         (test_run_silent_test):
32         (test_run_failed_test):
33         (test_run_tonguey_test):
34         (test_run_timeout_test):
35         (test_run_crash_test):
36         (test_run_test_set_kills_drt_per_run):
37         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
38         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
39         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
40
41 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
42
43         Webkit generate-coverage-data script needs update to use new test script
44         https://bugs.webkit.org/show_bug.cgi?id=77597
45
46         Reviewed by Dirk Schulze.
47
48         * Scripts/generate-coverage-data:
49
50 2012-02-01  Adam Barth  <abarth@webkit.org>
51
52         Update the tests to show that the mac-ews processes patches from
53         non-committers.
54
55         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
56         (EarlyWarningSytemTest.test_committer_only_ewses):
57         (EarlyWarningSytemTest.test_builder_ewses):
58
59 2012-02-01  Adam Barth  <abarth@webkit.org>
60
61         Mac-ews logs are huge
62         https://bugs.webkit.org/show_bug.cgi?id=77045
63
64         Reviewed by Eric Seidel.
65
66         In order to get the cr-linux-ews bot to run tests on EC2, we created
67         the chromium-xvfb port, which contained a number of tweaks to the
68         Chromium port's behavior.  This patch refactors those tweaks so they
69         can be shared with the mac-ews, mostly by moving them into the
70         non-interactive mode of RunTests.
71
72         * Scripts/webkitpy/common/config/ports.py:
73         (WebKitPort):
74         (WebKitPort.layout_tests_results_path):
75         (ChromiumPort.run_javascriptcore_tests_command):
76         (ChromiumXVFBPort):
77         (ChromiumXVFBPort.run_webkit_tests_command):
78         * Scripts/webkitpy/common/config/ports_mock.py:
79         (MockPort):
80         (MockPort.layout_tests_results_path):
81         * Scripts/webkitpy/common/config/ports_unittest.py:
82         (WebKitPortTest.test_chromium_xvfb_port):
83         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
84         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
85         * Scripts/webkitpy/tool/commands/queues_unittest.py:
86         (CommitQueueTest.test_commit_queue):
87         (test_rollout):
88         (test_manual_reject_during_processing):
89         * Scripts/webkitpy/tool/steps/runtests.py:
90         (RunTests.run):
91         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
92         (RunTestsTest.test_no_unit_tests):
93         * Scripts/webkitpy/tool/steps/steps_unittest.py:
94         (StepsTest.test_runtests_args):
95
96 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
97
98         Roll out r106442. It made some tests more stable but others less stable.
99
100         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
101         (PerfTestsRunner._run_tests_set):
102         (PerfTestsRunner._run_single_test):
103         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
104         (create_runner):
105         (test_run_passing_test):
106         (test_run_silent_test):
107         (test_run_failed_test):
108         (test_run_tonguey_test):
109         (test_run_timeout_test):
110         (test_run_crash_test):
111         (test_run_test_set):
112
113 2012-02-01  Lucas Forschler  <lforschler@apple.com>
114
115         Enable EWS for non-contributers.
116         https://bugs.webkit.org/show_bug.cgi?id=77576
117         
118         Reviewed by Adam Barth.
119
120         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
121         (MacEWS):
122
123 2012-02-01  Beth Dakin  <bdakin@apple.com>
124
125         https://bugs.webkit.org/show_bug.cgi?id=77383
126         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
127         -and corresponding-
128         <rdar://problem/10709560>
129
130         Reviewed by Sam Weinig.
131
132         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
133         for.
134         * MiniBrowser/mac/BrowserWindowController.m:
135         (-[BrowserWindowController awakeFromNib]):
136         * WebKitTestRunner/TestController.cpp:
137         (WTR::TestController::initialize):
138
139 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
140
141         TestWebKitAPI isn't being built on chromium bots any more
142         https://bugs.webkit.org/show_bug.cgi?id=77563
143
144         Reviewed by Dimitri Glazkov.
145
146         I accidentally dropped it in the refactoring in r105449.
147
148         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
149
150 2012-02-01  Hans Wennborg  <hans@chromium.org>
151
152         Rename WebSpeechInputResult::set() to assign()
153         https://bugs.webkit.org/show_bug.cgi?id=77540
154
155         Reviewed by Darin Fisher.
156
157         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
158         (MockWebSpeechInputController::addMockRecognitionResult):
159         (MockWebSpeechInputController::speechTaskFired):
160
161 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
162
163         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
164         https://bugs.webkit.org/show_bug.cgi?id=77542
165
166         Reviewed by Martin Robinson.
167
168         * gtk/generate-gtkdoc: Check first whether there's
169         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
170         instead.
171         (get_webkit2_options): Return just the options since the
172         pkg_config_path doesn't depend on options
173         (get_webkit1_options): Ditto.
174         (generate_doc): Helper function to create a generator and generate
175         documentation for the given pkg-config file with the given options.
176         * gtk/gtkdoc.py:
177         (GTKDoc.__init__): Don't use ** for args parameter, since it's
178         used as a dict and never expanded.
179         (PkgConfigGTKDoc.__init__): Ditto.
180
181 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
182
183         [GTK] API documentation is not installed even when building with --enable-gtk-doc
184         https://bugs.webkit.org/show_bug.cgi?id=77094
185
186         Reviewed by Martin Robinson.
187
188         * GNUmakefile.am: Add install-data-local and uninstall-local rules
189         to install/uninstall WebKit1 and WebKit2 API documentation.
190
191 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
192
193         Unreviewed, rolling out r106460.
194         http://trac.webkit.org/changeset/106460
195         https://bugs.webkit.org/show_bug.cgi?id=77552
196
197         It break unit tests if WEBKIT_TESTFONTS isn't defined.
198         (Requested by Ossy on #webkit).
199
200         * Scripts/webkitpy/layout_tests/port/qt.py:
201
202 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
203
204         [Qt] Automatic clean build feature always do clean build with --no-webkit2
205         https://bugs.webkit.org/show_bug.cgi?id=74519
206
207         Reviewed by Tor Arne Vestbø.
208
209         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
210
211         * qmake/mkspecs/features/features.prf:
212
213 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
214
215         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
216         https://bugs.webkit.org/show_bug.cgi?id=77466
217
218         Reviewed by Kenneth Rohde Christiansen.
219
220         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
221         is set or if we should raise an error.
222
223         * Scripts/webkitpy/layout_tests/port/qt.py:
224         (QtPort.setup_environ_for_server):
225
226 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
227
228         Reviewed by Martin Robinson.
229
230         [GTK] Improve FrameLoader signals. Resource loading
231         https://bugs.webkit.org/show_bug.cgi?id=49543
232
233         Support for the new loader signals in DRT.
234
235         * DumpRenderTree/gtk/DumpRenderTree.cpp:
236         (urlPath):
237         (willSendRequestCallback):
238         (urlSuitableForTestResult):
239         (descriptionSuitableForTestResult):
240         (didReceiveResponse):
241         (didFinishLoading):
242         (didFailLoadingWithError):
243         (createWebView):
244
245 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
246
247         run-perf-tests should restart DRT for each test
248         https://bugs.webkit.org/show_bug.cgi?id=77506
249
250         Reviewed by Adam Barth.
251
252         Always restart DRT when running performance tests in order to minimize the dependency between tests.
253
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255         (ChromiumDriver.stop):
256         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
257         (PerfTestsRunner._run_tests_set):
258         (PerfTestsRunner._run_single_test):
259         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
260         (create_runner):
261         (test_run_passing_test):
262         (test_run_silent_test):
263         (test_run_failed_test):
264         (test_run_tonguey_test):
265         (test_run_timeout_test):
266         (test_run_crash_test):
267         (test_run_test_set_kills_drt_per_run):
268         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
269         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
270         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
271
272 2012-01-31  Hans Wennborg  <hans@chromium.org>
273
274         Speech Input: Report speech element rect relative to window rather than frame
275         https://bugs.webkit.org/show_bug.cgi?id=76443
276
277         Reviewed by Darin Fisher.
278
279         Update LayoutTestController to allow for retrieving the speech
280         element's position used in a request.
281
282         In Chromium this is handled by the MockWebSpeechInputController;
283         adding stubs for the other implementations.
284
285         * DumpRenderTree/LayoutTestController.cpp:
286         (setMockSpeechInputDumpRectCallback):
287         (LayoutTestController::staticFunctions):
288         * DumpRenderTree/LayoutTestController.h:
289         (LayoutTestController):
290         * DumpRenderTree/chromium/LayoutTestController.cpp:
291         (LayoutTestController::LayoutTestController):
292         (LayoutTestController::setMockSpeechInputDumpRect):
293         * DumpRenderTree/chromium/LayoutTestController.h:
294         (LayoutTestController):
295         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
296         (MockWebSpeechInputController::setDumpRect):
297         (MockWebSpeechInputController::clearResults):
298         (MockWebSpeechInputController::startRecognition):
299         (MockWebSpeechInputController::MockWebSpeechInputController):
300         (makeRectResult):
301         (MockWebSpeechInputController::speechTaskFired):
302         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
303         (MockWebSpeechInputController):
304         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
305         (LayoutTestController::setMockSpeechInputDumpRect):
306         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
307         (LayoutTestController::setMockSpeechInputDumpRect):
308         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
309         (LayoutTestController::setMockSpeechInputDumpRect):
310         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
311         (LayoutTestController::setMockSpeechInputDumpRect):
312         * DumpRenderTree/qt/LayoutTestControllerQt.h:
313         (LayoutTestController):
314         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
315         (LayoutTestController::setMockSpeechInputDumpRect):
316         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
317         (LayoutTestController::setMockSpeechInputDumpRect):
318
319 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
320
321         [EFL] Add basic DRT/Efl implementation to support viewport test.
322         https://bugs.webkit.org/show_bug.cgi?id=77320
323
324         Reviewed by Andreas Kling.
325
326         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
327         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
328
329 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
330
331         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
332         https://bugs.webkit.org/show_bug.cgi?id=77473
333         <rdar://problem/10751357>
334
335         Reviewed by Darin Adler.
336
337         * DumpRenderTree/mac/EventSendingController.mm:
338         (-[EventSendingController keyDown:withModifiers:withLocation:]):
339         * WebKitTestRunner/mac/EventSenderProxy.mm:
340         (WTR::EventSenderProxy::keyDown):
341         Added a new special keyDown value to test this.
342
343 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
344
345         nrwt: fix the mock port to work with DriverProxy, reftests
346         https://bugs.webkit.org/show_bug.cgi?id=77170
347
348         Reviewed by Eric Seidel.
349
350         The DryrunPort used for benchmarking and testing NRWT has been
351         broken since we added the DriverProxy code. It isn't really
352         needed any more, so I've removed it.
353
354         The MockDRT port was also broken by DriverProxy, and moreover,
355         never worked w/ reftests. Since we don't exercise this module in
356         the unit tests, the code had also bitrotted some. I have cleaned
357         it up and made it use DriverInput and DriverOutput for
358         consistency.
359
360         * Scripts/webkitpy/layout_tests/port/dryrun.py:
361         (DryRunPort.__init__):
362         (DryRunPort):
363         (DryRunPort.real_name):
364         (DryRunPort.create_driver):
365         (DryRunPort.driver_cmd_line):
366         (DryRunPort._driver_class):
367         (DryrunDriver):
368         (DryrunDriver.run_test):
369         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
370         (MockDRTPort.create_driver):
371         (MockChromiumDRT.run_one_test):
372
373 2012-01-31  Ojan Vafai  <ojan@chromium.org>
374
375         run-webkit-tests calls out to webkit-build-directory twice
376         https://bugs.webkit.org/show_bug.cgi?id=77248
377
378         Reviewed by Dirk Pranke.
379
380         * Scripts/webkit-build-directory:
381         If called with no arguments, print out both the top-level directory and the 
382         configuration directory
383
384         * Scripts/webkitpy/layout_tests/port/config.py:
385         (Config.build_directory):
386         When called with no arguments, get and cache both the top-level and configuration directories.
387
388         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
389         (main):
390         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
391         (ConfigTest.assert_configuration):
392         (ConfigTest.test_build_directory.mock_webkit_build_directory):
393         (ConfigTest.test_build_directory):
394         (ConfigTest.test_default_configuration__notfound):
395         * Scripts/webkitpy/layout_tests/port/webkit.py:
396         (WebKitPort._build_path):
397         Cache the build directory in the options object so that other users
398         of the options object don't need to call out to webkit-build-directory.
399         Also, properly support the existing --build-directory argument.
400
401 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
402
403         Bump up the timeout for performance tests since DOM/DOMTable.html
404         and Parser/html5-full-render.html are timing out on the bot.
405
406         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
407         (PerfTestsRunner._parse_args):
408
409 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
410
411         Fix the update_webgl_conformance_tests.py script in order to enable it
412         to detect the SCM being used correctly.
413         https://bugs.webkit.org/show_bug.cgi?id=77462
414
415         Reviewed by Kenneth Russell.
416
417         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
418         (default_out_dir):
419
420 2012-01-31  Eric Seidel  <eric@webkit.org>
421
422         webkit-patch apply-from-bug should work regardless of your CWD
423         https://bugs.webkit.org/show_bug.cgi?id=77482
424
425         Reviewed by Adam Barth.
426
427         webkit-patch only ever works with patches made from the root
428         directory.  We should pass the CWD to svn-apply in the case
429         where we're running not from the webkit root.  I believe
430         this used to work in the past and regressed.
431
432         * Scripts/webkitpy/common/checkout/checkout.py:
433         (Checkout.apply_patch):
434         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
435         (CheckoutTest.test_apply_patch):
436
437 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
438
439         Unreviewed, rolling out r106302.
440         http://trac.webkit.org/changeset/106302
441         https://bugs.webkit.org/show_bug.cgi?id=77472
442
443         Broke building DRT before running the tests (Requested by ojan
444         on #webkit).
445
446         * Scripts/webkit-build-directory:
447         * Scripts/webkitpy/layout_tests/port/config.py:
448         (Config.build_directory):
449         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
450         (main):
451         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
452         (ConfigTest.assert_configuration):
453         (ConfigTest.test_build_directory.mock_webkit_build_directory):
454         (ConfigTest.test_build_directory):
455         (ConfigTest.test_default_configuration__notfound):
456         * Scripts/webkitpy/layout_tests/port/webkit.py:
457         (WebKitPort._build_path):
458
459 2012-01-31  Antoine Labour  <piman@chromium.org>
460
461         Merge WebGraphicsContext3D creation and initialization, and move it to
462         WebViewClient.
463         https://bugs.webkit.org/show_bug.cgi?id=76593
464
465         Reviewed by Darin Fisher.
466
467         * DumpRenderTree/chromium/TestWebPlugin.cpp:
468         (TestWebPlugin::TestWebPlugin):
469         (TestWebPlugin::initialize):
470         * DumpRenderTree/chromium/TestWebPlugin.h:
471         * DumpRenderTree/chromium/WebViewHost.cpp:
472         (WebViewHost::createGraphicsContext3D):
473         (WebViewHost::createPlugin):
474         * DumpRenderTree/chromium/WebViewHost.h:
475
476 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
477
478         [GTK] build-webkit warning.
479         https://bugs.webkit.org/show_bug.cgi?id=77411
480
481         Reviewed by Philippe Normand.
482
483         * Scripts/webkitdirs.pm:
484         (isCrossCompilation):
485
486 2012-01-31  Dan Bernstein  <mitz@apple.com>
487
488         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
489
490         Reviewed by Anders Carlsson.
491
492         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
493
494 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
495
496         If the QTDIR environment variable is set, the build system fails to compile WinCairo
497         https://bugs.webkit.org/show_bug.cgi?id=77112
498
499         Reviewed by Daniel Bates.
500
501         * Scripts/webkitdirs.pm:
502         (determineIsQt):
503
504 2012-01-31  Adam Roben  <aroben@apple.com>
505
506         Only call -typingAttributes on WebViews, not WebHTMLViews
507
508         Looks like this case was just missed in r105908.
509
510         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
511
512         Reviewed by Antti Koivisto.
513
514         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
515         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
516         earlier.
517
518 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
519
520         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
521         https://bugs.webkit.org/show_bug.cgi?id=77221
522
523         Reviewed by Kenneth Rohde Christiansen.
524
525         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
526
527         * MiniBrowser/qt/MiniBrowserApplication.cpp:
528         (MiniBrowserApplication::sendTouchEvent):
529
530 2012-01-26  Hans Wennborg  <hans@chromium.org>
531
532         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
533         https://bugs.webkit.org/show_bug.cgi?id=77083
534
535         Reviewed by Darin Fisher.
536
537         Add MockWebSpeechInputController which provides a mock implementation
538         of the WebSpeechInputController interface, and use that in
539         DumpRenderTree.
540
541         * DumpRenderTree/DumpRenderTree.gypi:
542         * DumpRenderTree/chromium/LayoutTestController.cpp:
543         (LayoutTestController::addMockSpeechInputResult):
544         * DumpRenderTree/chromium/LayoutTestController.h:
545         ():
546         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
547         (MockWebSpeechInputController::create):
548         (MockWebSpeechInputController::addMockRecognitionResult):
549         (MockWebSpeechInputController::clearResults):
550         (MockWebSpeechInputController::startRecognition):
551         (MockWebSpeechInputController::cancelRecognition):
552         (MockWebSpeechInputController::stopRecording):
553         (MockWebSpeechInputController::MockWebSpeechInputController):
554         (MockWebSpeechInputController::speechTaskFired):
555         (MockWebSpeechInputController::SpeechTask::SpeechTask):
556         (MockWebSpeechInputController::SpeechTask::stop):
557         (MockWebSpeechInputController::SpeechTask::runIfValid):
558         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
559         (WebKit):
560         (MockWebSpeechInputController):
561         (MockWebSpeechInputController::taskList):
562         (SpeechTask):
563         * DumpRenderTree/chromium/TestShell.cpp:
564         * DumpRenderTree/chromium/WebViewHost.cpp:
565         (WebViewHost::speechInputController):
566         * DumpRenderTree/chromium/WebViewHost.h:
567         (WebKit):
568         (WebViewHost::speechInputControllerMock):
569         (WebViewHost):
570         ():
571
572 2012-01-31  Hajime Morrita  <morrita@chromium.org>
573
574         [PerformanceTests] Add landing html for Dromaeo dom-query test
575         https://bugs.webkit.org/show_bug.cgi?id=77329
576
577         Reviewed by Ryosuke Niwa.
578
579         Added some more ignorable output patterns to allow warnings
580         from a third party test suite.
581
582         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
583         (PerfTestsRunner):
584         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
585
586 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
587
588         [wx] Unreviewed. Update download URLs to new domain.
589         
590         * waf/build/build_utils.py:
591         (update_wx_deps):
592
593 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
594
595         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
596         to the list of build directories.
597         
598         * waf/build/settings.py:
599
600 2012-01-30  Kentaro Hara  <haraken@chromium.org>
601
602         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
603         output an empty method name (i.e. "()")
604         https://bugs.webkit.org/show_bug.cgi?id=77336
605
606         Reviewed by Darin Adler.
607
608         r105797 tried to detect a change outside methods, but it causes a bug that
609         prepare-ChangeLog can output an empty method name, like this:
610
611             * foo/bar/baz.cpp:
612             (method1):
613             ():
614             (method2):
615
616         This is because the cpp parser in prepare-ChangeLog cannot distinguish
617         '{' as the beginning of a method with '{' as the beginning of an array definition
618         at the top level.
619
620             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
621
622             void func() { // This '{' is the beginning of a method.
623                 ...;
624             }
625
626         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
627
628         * Scripts/prepare-ChangeLog:
629         (get_function_line_ranges_for_cpp): Modified as described above.
630         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
631         an empty method name. Ideally this should not happen but may happen, since the
632         parsers are not perfect.
633         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
634         (NameSpace7):
635         (NameSpace8):
636         (Class109):
637         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
638
639 2012-01-30  Ojan Vafai  <ojan@chromium.org>
640
641         run-webkit-tests calls out to webkit-build-directory twice
642         https://bugs.webkit.org/show_bug.cgi?id=77248
643
644         Reviewed by Dirk Pranke.
645
646         This reduces to calls to webkit-build-directory to one call and
647         saves 500ms for run-webkit-tests over a single file.
648
649         * Scripts/webkit-build-directory:
650         If called with no arguments, print out both the top-level directory and the 
651         configuration directory.
652
653         * Scripts/webkit-build-directory:
654         * Scripts/webkitpy/layout_tests/port/config.py:
655         (Config.build_directory):
656         When called with no arguments, get and cache both the top-level and configuration directories.
657
658         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
659         (main):
660         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
661         (ConfigTest.assert_configuration):
662         (ConfigTest.test_build_directory.mock_webkit_build_directory):
663         (ConfigTest.test_build_directory):
664         (ConfigTest.test_default_configuration__notfound):
665         * Scripts/webkitpy/layout_tests/port/webkit.py:
666         (WebKitPort._build_path):
667         Cache the root directory in the options object so that other users
668         of the options object don't need to call out to webkit-build-directory.
669
670 2012-01-30  Ojan Vafai  <ojan@chromium.org>
671
672         Parsing test_expecations.txt + Skipped lists takes too long
673         https://bugs.webkit.org/show_bug.cgi?id=77059
674
675         Reviewed by Dirk Pranke.
676
677         This saves ~100ms on the Apple Mac port.
678         -memoize a bunch of path methods.
679         -Avoid doing multiple disk accesses per line.
680         -Parse the skipped list directly instead of turning it into a test_expecations.txt
681         formatting string and parsing that.
682
683         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
684         (TestExpectationParser):
685         (TestExpectationParser.expectation_for_skipped_test):
686         (TestExpectationParser._parse_line):
687         (TestExpectationParser._collect_matching_tests):
688         (TestExpectations.__init__):
689         (TestExpectations._add_skipped_tests):
690         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
691         (test_add_skipped_tests):
692         (test_add_skipped_tests_duplicate):
693         * Scripts/webkitpy/layout_tests/port/base.py:
694         (Port):
695         (Port.test_isfile):
696         (Port.normalize_test_name):
697         (Port.layout_tests_dir):
698         (Port.abspath_for_test):
699         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
700
701 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
702
703         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
704         
705         * Scripts/webkitpy/common/config/watchlist:
706
707 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
708
709         Unreviewed build fix following bug#76855
710
711         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
712         ():
713         (TestWebKitAPI::TEST_F):
714
715 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
716
717         [Qt] WKTR: Use a software rendering pipiline when running tests.
718         https://bugs.webkit.org/show_bug.cgi?id=76708
719
720         Reviewed by Kenneth Rohde Christiansen.
721
722         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
723         (WTR::WrapperWindow::WrapperWindow):
724         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
725
726 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
727
728         [Qt] Store build config immediately instead of waiting for a successfull build
729
730         Otherwise we will not pick up changes to the config if the build is aborted,
731         for example due to build errors or if the user pressed Ctrl+Z. We now write
732         the new config before starting a build, but still defer to write the SVN
733         revision once the build completes successfully.
734
735         Reviewed by Ossy.
736
737         * Scripts/webkitdirs.pm:
738         (buildQMakeProjects):
739
740 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
741
742         [Qt] Add "New Window" button to the Qt MiniBrowser
743         https://bugs.webkit.org/show_bug.cgi?id=77281
744
745         Reviewed by Tor Arne Vestbø.
746
747         * MiniBrowser/qt/BrowserWindow.cpp:
748         (BrowserWindow::BrowserWindow):
749         * MiniBrowser/qt/MiniBrowser.qrc:
750         * MiniBrowser/qt/icons/plus.png: Added.
751         * MiniBrowser/qt/qml/BrowserWindow.qml:
752
753 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
754
755         Unreviewed rolling out r106222.
756
757         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
758         (SingleTestRunner.__init__):
759         * Scripts/webkitpy/layout_tests/controllers/worker.py:
760         (Worker.handle_test_list):
761         * Scripts/webkitpy/layout_tests/models/test_input.py:
762         (TestInput.__init__):
763         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
764         (_set_up_derived_options):
765         (parse_args):
766         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
767         (MainTest.test_repeat_each):
768         * WebKitTestRunner/TestInvocation.cpp:
769         (WTR::TestInvocation::setIsPixelTest):
770
771 2012-01-30  Hans Wennborg  <hans@chromium.org>
772
773         Unreviewed, rolling out r106219.
774         http://trac.webkit.org/changeset/106219
775         https://bugs.webkit.org/show_bug.cgi?id=77083
776
777         This broke Chromium's test_shell.
778
779         * DumpRenderTree/DumpRenderTree.gypi:
780         * DumpRenderTree/chromium/LayoutTestController.cpp:
781         (LayoutTestController::addMockSpeechInputResult):
782         * DumpRenderTree/chromium/LayoutTestController.h:
783         (WebKit):
784         (LayoutTestController):
785         ():
786         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
787         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
788         * DumpRenderTree/chromium/TestShell.cpp:
789         * DumpRenderTree/chromium/WebViewHost.cpp:
790         (WebViewHost::speechInputController):
791         * DumpRenderTree/chromium/WebViewHost.h:
792         (WebKit):
793         (WebViewHost::speechInputControllerMock):
794         (WebViewHost):
795         ():
796
797 2012-01-26  Hans Wennborg  <hans@chromium.org>
798
799         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
800         https://bugs.webkit.org/show_bug.cgi?id=77083
801
802         Reviewed by Darin Fisher.
803
804         Add MockWebSpeechInputController which provides a mock implementation
805         of the WebSpeechInputController interface, and use that in
806         DumpRenderTree.
807
808         * DumpRenderTree/DumpRenderTree.gypi:
809         * DumpRenderTree/chromium/LayoutTestController.cpp:
810         (LayoutTestController::addMockSpeechInputResult):
811         * DumpRenderTree/chromium/LayoutTestController.h:
812         ():
813         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
814         (MockWebSpeechInputController::create):
815         (MockWebSpeechInputController::addMockRecognitionResult):
816         (MockWebSpeechInputController::clearResults):
817         (MockWebSpeechInputController::startRecognition):
818         (MockWebSpeechInputController::cancelRecognition):
819         (MockWebSpeechInputController::stopRecording):
820         (MockWebSpeechInputController::MockWebSpeechInputController):
821         (MockWebSpeechInputController::speechTaskFired):
822         (MockWebSpeechInputController::SpeechTask::SpeechTask):
823         (MockWebSpeechInputController::SpeechTask::stop):
824         (MockWebSpeechInputController::SpeechTask::runIfValid):
825         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
826         (WebKit):
827         (MockWebSpeechInputController):
828         (MockWebSpeechInputController::taskList):
829         (SpeechTask):
830         * DumpRenderTree/chromium/TestShell.cpp:
831         * DumpRenderTree/chromium/WebViewHost.cpp:
832         (WebViewHost::speechInputController):
833         * DumpRenderTree/chromium/WebViewHost.h:
834         (WebKit):
835         (WebViewHost::speechInputControllerMock):
836         (WebViewHost):
837         ():
838
839 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
840
841         Unreviewed, rolling out r106109.
842         http://trac.webkit.org/changeset/106109
843         https://bugs.webkit.org/show_bug.cgi?id=77302
844
845         It made tests crash (Requested by Ossy_weekend on #webkit).
846
847         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
848         (WTR::WrapperWindow::WrapperWindow):
849         (WTR::PlatformWebView::PlatformWebView):
850
851 2012-01-28  Nico Weber  <thakis@chromium.org>
852
853         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
854         https://bugs.webkit.org/show_bug.cgi?id=77243
855
856         Reviewed by Adam Barth.
857
858         * Scripts/update-webkit:
859         * Scripts/webkitdirs.pm:
860         (isChromiumNinja):
861         (determineIsChromiumNinja):
862         (buildChromiumNinja):
863         (buildChromium):
864
865 2012-01-27  Kentaro Hara  <haraken@chromium.org>
866
867         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
868         https://bugs.webkit.org/show_bug.cgi?id=77241
869
870         Reviewed by Ryosuke Niwa.
871
872         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
873         in a method in some namespace or class is treated as a method.
874         This patch fixes the bug.
875
876             class C {
877                 void func()
878                 {
879                     if (1) {    // This should not be treated as a method.
880                     }
881                 }
882             };
883
884         * Scripts/prepare-ChangeLog:
885         (get_function_line_ranges_for_cpp):
886         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
887         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
888         (Class108):
889         (Class108::func35):
890
891 2012-01-27  Enrica Casucci  <enrica@apple.com>
892
893         Followup to http://trac.webkit.org/changeset/106171.
894         Dan Bernstein pointed out correctly that I should
895         have used copy instead of initWithString.
896
897         Reviewed by Dan Bernstein.
898
899         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
900         (-[LocalPasteboard initWithName:]):
901
902 2012-01-27  Enrica Casucci  <enrica@apple.com>
903
904         DRT pasteboard object should return the correct pasteboard name.
905         https://bugs.webkit.org/show_bug.cgi?id=77260
906         
907         Currently the name property always returns nil.
908         Adding a memeber variable to store the pasteboard name and return its
909         value from the name method instead of returning nil always.
910
911         Reviewed by Dan Bernstein.
912
913         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
914         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
915         (-[LocalPasteboard initWithName:]):
916         (-[LocalPasteboard name]):
917
918 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
919
920         [GTK] [WK2] Implement the policy client
921         https://bugs.webkit.org/show_bug.cgi?id=76343
922
923         Reviewed by Gustavo Noronha Silva.
924
925         * gtk/generate-gtkdoc:
926         (get_webkit2_options): Update the list of skipped source files to include all clients.
927
928 2012-01-27  Ada Chan  <adachan@apple.com>
929
930         Add test for WKBundleFrameGetParentFrame().
931         https://bugs.webkit.org/show_bug.cgi?id=77161
932
933         Reviewed by Anders Carlsson.
934
935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
936         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
937         (TestWebKitAPI):
938         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
939         (TestWebKitAPI::setInjectedBundleClient):
940         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
941         Make sure the check is successful.
942         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
943         (TestWebKitAPI):
944         (ParentFrameTest):
945         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
946         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
947         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
948         to the test controller.
949         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
950
951 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
952
953         [Gtk] DumpRenderTree lacks --no-timeout command line option
954         https://bugs.webkit.org/show_bug.cgi?id=77196
955
956         Reviewed by Martin Robinson.
957
958         Add the --no-timeout command line option and reorganize
959         watchdog code to make running DumpRenderTree without
960         timeout possible.
961
962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
963         (setWaitToDumpWatchdog):
964         (shouldSetWaitToDumpWatchdog):
965         (initializeGlobalsFromCommandLineOptions):
966         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
967         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
968         (waitToDumpWatchdogFired):
969         (LayoutTestController::setWaitToDump):
970
971 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
972
973         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
974         https://bugs.webkit.org/show_bug.cgi?id=77122
975
976         Reviewed by Kenneth Rohde Christiansen.
977
978         * MiniBrowser/qt/MiniBrowserApplication.cpp:
979         (MiniBrowserApplication::MiniBrowserApplication):
980
981 2012-01-27  Zeno Albisser  <zeno@webkit.org>
982
983         [Qt][Mac] Build fails after adding ICU support (r105997).
984         https://bugs.webkit.org/show_bug.cgi?id=77118
985
986         Define WTF_USE_ICU_UNICODE if we are on mac.
987
988         Reviewed by Tor Arne Vestbø.
989
990         * qmake/mkspecs/features/features.prf:
991
992 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
993
994         Update committers.py with new contributors.
995         https://bugs.webkit.org/show_bug.cgi?id=77207
996
997         I added six new contributors into committers.py:
998
999         - Adam Kallai
1000         - Balazs Ankes
1001         - Janos Badics
1002         - Nandor Huszka
1003         - Roland Takacs
1004         - Szilard Ledan-Muntean
1005
1006         * Scripts/webkitpy/common/config/committers.py:
1007
1008 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1009
1010         Add Vsevolod Vlasov to reviewers list.
1011
1012         Reviewed by Pavel Feldman.
1013
1014         * Scripts/webkitpy/common/config/committers.py:
1015
1016 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1017
1018         [Qt] WKTR: Use a software rendering pipiline when running tests.
1019         https://bugs.webkit.org/show_bug.cgi?id=76708
1020
1021         Reviewed by Kenneth Rohde Christiansen.
1022
1023         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1024         (WTR::WrapperWindow::WrapperWindow):
1025         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1026
1027 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1028
1029         [wx] Unreviewed. Build fix, add WebCore/testing/js
1030         to the list of source directories we build.
1031
1032         * waf/build/settings.py:
1033
1034 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1035
1036         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1037         https://bugs.webkit.org/show_bug.cgi?id=77177
1038
1039         Reviewed by Jon Honeycutt.
1040
1041         * Scripts/commit-log-editor:
1042
1043 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1044
1045         Decrease sleep time when killing server_process on Mac.
1046         https://bugs.webkit.org/show_bug.cgi?id=77169
1047
1048         Reviewed by Eric Seidel.
1049
1050         This shaves another ~70ms off single test runtime.
1051
1052         * Scripts/webkitpy/layout_tests/port/server_process.py:
1053         (ServerProcess.stop):
1054
1055 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1056
1057         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1058         https://bugs.webkit.org/show_bug.cgi?id=77164
1059
1060         Reviewed by Dirk Pranke.
1061
1062         http://trac.webkit.org/changeset/106035 depends on builder_name being
1063         falsey by default. There's other code that requires it to be iterable
1064         by default. So, make it be the empty string.
1065
1066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1067         (parse_args):
1068
1069 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1070
1071         run-perf-test should include relative file paths in test names
1072         https://bugs.webkit.org/show_bug.cgi?id=77144
1073
1074         Reviewed by Adam Birth.
1075
1076         Include all directory names in the test name separated by "/".
1077         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1078
1079         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1080         (PerfTestsRunner):
1081         (PerfTestsRunner._process_parser_test_result):
1082         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1083         (test_run_test_set_with_json_output):
1084         (test_run_test_set_with_json_source):
1085
1086 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1087
1088         webkitpy: re-land cleanup of test scaffolding
1089         https://bugs.webkit.org/show_bug.cgi?id=77153
1090
1091         Reviewed by Eric Seidel.
1092
1093         This is an attempt to reland the change in bug 76973 / 
1094         r105935. My earlier attempt to manipulate PYTHONPATH
1095         seems to only work some of the time, for reasons that
1096         elude me. Directly adding Tools/Scripts to sys.path from
1097         inside the test script appears to work (more?) reliably.
1098
1099         Also, it seemed like the files didn't actually get deleted
1100         the last time; I don't know why.
1101
1102         * Scripts/test-webkitpy:
1103         * Scripts/webkitpy/common/system/executive_unittest.py:
1104         (command_line):
1105         (ExecutiveTest):
1106         (ExecutiveTest.test_run_command_args_type):
1107         (ExecutiveTest.test_run_command_with_unicode):
1108         (ExecutiveTest.test_running_pids):
1109         (main):
1110         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1111         * Scripts/webkitpy/test/cat.py: Removed.
1112         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1113         * Scripts/webkitpy/test/echo.py: Removed.
1114         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1115
1116 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1117
1118         run-webkit-tests calls "nm" when it doesn't need to
1119         https://bugs.webkit.org/show_bug.cgi?id=77143
1120
1121         Reviewed by Dirk Pranke.
1122
1123         If we are not running any test that can be skipped by checking
1124         the DRT feature list or looking at the list of symbols, avoid calling
1125         out to DRT or calling "nm".
1126
1127         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1128         to "nm" it's only a couple ms slower.
1129
1130         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1131         (TestExpectations.__init__):
1132         * Scripts/webkitpy/layout_tests/port/base.py:
1133         (Port.skipped_tests):
1134         * Scripts/webkitpy/layout_tests/port/webkit.py:
1135         (WebKitPort._should_check_for_missing_features):
1136         (WebKitPort):
1137         (WebKitPort._should_check_for_missing_symbols):
1138         (WebKitPort._skipped_tests_for_unsupported_features):
1139         (WebKitPort.skipped_layout_tests):
1140         (WebKitPort.skipped_tests):
1141         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1142         (WebKitPortTest.test_skipped_directories_for_symbols):
1143         (test_skipped_directories_for_features):
1144         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1145         (test_skipped_layout_tests):
1146
1147 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1148
1149         Support a suffix on ChangeLog filenames based on a configuration file
1150         https://bugs.webkit.org/show_bug.cgi?id=76956
1151
1152         Reviewed by Kentaro Hara.
1153
1154         Modify the tools used to generate, edit and resolve ChangeLogs to support
1155         the addition of a suffix to the ChangeLog filename.
1156
1157         This patch makes it easier to support alternate ChangeLog files in branches.
1158
1159         * Scripts/VCSUtils.pm:
1160         (changeLogSuffix):
1161         (changeLogFileName):
1162         * Scripts/commit-log-editor:
1163         * Scripts/prepare-ChangeLog:
1164         (getLatestChangeLogs):
1165         (generateNewChangeLogs):
1166         (generateFileList):
1167         * Scripts/resolve-ChangeLogs:
1168         (findChangeLog):
1169
1170 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1171
1172         Unreviewed, rolling out r106038.
1173         http://trac.webkit.org/changeset/106038
1174         https://bugs.webkit.org/show_bug.cgi?id=77142
1175
1176         Caused a bunch of skipped tests to not be skipped. (Requested
1177         by ojan on #webkit).
1178
1179         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1180         (TestExpectationParser):
1181         (TestExpectationParser.parse):
1182         (TestExpectationParser._parse_line):
1183         (TestExpectationParser._collect_matching_tests):
1184         (TestExpectations.__init__):
1185         (TestExpectations._add_skipped_tests):
1186         * Scripts/webkitpy/layout_tests/port/base.py:
1187         (Port.test_dirs):
1188         (Port.normalize_test_name):
1189         (Port.update_baseline):
1190         (Port.layout_tests_dir):
1191         (Port.relative_perf_test_filename):
1192         (Port.abspath_for_test):
1193
1194 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1195
1196         Parsing test_expecations.txt + Skipped lists takes too long
1197         https://bugs.webkit.org/show_bug.cgi?id=77059
1198
1199         Reviewed by Dirk Pranke.
1200
1201         This saves ~100ms on the Apple Mac port.
1202         -memoize a bunch of path methods.
1203         -Avoid doing multiple disk accesses per line.
1204         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1205         formatting string and parsing that.
1206
1207         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1208         (TestExpectationParser):
1209         (TestExpectationParser.parse_skipped_tests):
1210         (TestExpectationParser._parse_line):
1211         (TestExpectationParser._collect_matching_tests):
1212         (TestExpectations.__init__):
1213         (TestExpectations._add_skipped_tests):
1214         * Scripts/webkitpy/layout_tests/port/base.py:
1215         (Port):
1216         (Port.test_isfile):
1217         (Port.normalize_test_name):
1218         (Port.layout_tests_dir):
1219         (Port.abspath_for_test):
1220
1221 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1222
1223         Only store the SVN revision in the summarized results if we're on a builder
1224         https://bugs.webkit.org/show_bug.cgi?id=76976
1225
1226         Reviewed by Dirk Pranke.
1227
1228         This shaves another ~130ms off the single test run-webkit-tests runtime.
1229
1230         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1231         (summarize_results):
1232         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1233         (ResultSummaryTest.get_result):
1234         (ResultSummaryTest):
1235         (ResultSummaryTest.get_result_summary):
1236         (ResultSummaryTest.get_unexpected_results):
1237         (ResultSummaryTest.test_no_svn_revision):
1238         (ResultSummaryTest.test_svn_revision):
1239         * Scripts/webkitpy/layout_tests/port/base.py:
1240         (Port.use_trac_links_in_results_html):
1241
1242 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1243
1244         [Qt][WK2] fast/loader tests failed after r94178
1245         https://bugs.webkit.org/show_bug.cgi?id=67388
1246
1247         Reviewed by Simon Hausmann.
1248
1249         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1250         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1251         https://bugs.webkit.org/show_bug.cgi?id=67254
1252         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1253         derived from the running location of DumpRenderTree binary.
1254
1255         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1256         (WTR::LayoutTestController::pathToLocalResource):
1257
1258 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1259
1260         Implement overridePreference for boolean preferences in WebKitTestRunner
1261         https://bugs.webkit.org/show_bug.cgi?id=77033
1262
1263         Reviewed by Alexey Proskuryakov.
1264
1265         For now overridePreference supports boolean values.
1266
1267         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1268         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1269         (WTR::LayoutTestController::setXSSAuditorEnabled):
1270         (WTR::LayoutTestController::overridePreference):
1271         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1272         * WebKitTestRunner/TestController.cpp:
1273         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1274         explicitly and properly disable the use of PageCache when resetting the
1275         state. Tests that use PageCache can now enable it via overridePreference.
1276
1277 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1278
1279         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1280         https://bugs.webkit.org/show_bug.cgi?id=77100
1281
1282         Reviewed by Simon Hausmann.
1283
1284         This patch makes the MiniBrowser read multiple URL's from the command
1285         line such that there will be one browser window opened for each URL.
1286
1287         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1288         (MiniBrowserApplication::handleUserOptions):
1289
1290 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1291
1292         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1293         https://bugs.webkit.org/show_bug.cgi?id=77009
1294
1295         Reviewed by Simon Hausmann.
1296
1297         This patch fixes a crash in BrowserWindow::newWindow() where a
1298         BrowserWindow-object is constructed with a 0 pointer as the
1299         WindowOptions parameter which leads to a crash.
1300
1301         * MiniBrowser/qt/BrowserWindow.cpp:
1302         (BrowserWindow::BrowserWindow):
1303         (BrowserWindow::newWindow):
1304         * MiniBrowser/qt/BrowserWindow.h:
1305
1306 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1307
1308         [Qt] Use ICU if available
1309         https://bugs.webkit.org/show_bug.cgi?id=76821
1310
1311         Reviewed by Simon Hausmann.
1312
1313         Adding unicode defines for a Qt 5 based build.
1314
1315         * qmake/mkspecs/features/features.prf:
1316
1317 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1318
1319         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1320         https://bugs.webkit.org/show_bug.cgi?id=42545
1321
1322         Reviewed by Zoltan Herczeg.
1323
1324         Implement the setGeolocationPermission method.
1325
1326         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1327         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1328         (WTR::LayoutTestController::setGeolocationPermission):
1329         (WTR):
1330         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1331         (LayoutTestController):
1332
1333 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1334
1335         [NRWT] Support --ignore-metrics
1336         https://bugs.webkit.org/show_bug.cgi?id=76278
1337
1338         Reviewed by Tony Chang.
1339
1340         Port the feature from ORWT.
1341
1342         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1343         (SingleTestRunner._run_compare_test):
1344         * Scripts/webkitpy/layout_tests/port/driver.py:
1345         (DriverOutput):
1346         (DriverOutput.strip_metrics):
1347         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1348         (DriverOutputTest):
1349         (DriverOutputTest.test_strip_metrics):
1350         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1351         (_set_up_derived_options):
1352         (parse_args):
1353
1354 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1355
1356         Unreviewed, rolling out r105935 and r105954.
1357         http://trac.webkit.org/changeset/105935
1358         http://trac.webkit.org/changeset/105954
1359         https://bugs.webkit.org/show_bug.cgi?id=77080
1360
1361         test-webkitpy is still broken (Requested by abarth on
1362         #webkit).
1363
1364         * Scripts/test-webkitpy:
1365         * Scripts/webkitpy/common/system/executive_unittest.py:
1366         (never_ending_command):
1367         (ExecutiveTest.test_run_command_args_type):
1368         (ExecutiveTest.test_run_command_with_unicode):
1369         (ExecutiveTest.test_running_pids):
1370         * Scripts/webkitpy/common/system/fileutils.py:
1371         (make_stdout_binary):
1372         * Scripts/webkitpy/test/cat.py:
1373         (command_arguments):
1374         (main):
1375         * Scripts/webkitpy/test/cat_unittest.py:
1376         (CatTest):
1377         (CatTest.assert_cat):
1378         (CatTest.test_basic):
1379         (CatTest.test_no_newline):
1380         (CatTest.test_unicode):
1381         (CatTest.test_as_command):
1382         * Scripts/webkitpy/test/echo.py:
1383         (command_arguments):
1384         (main):
1385         * Scripts/webkitpy/test/echo_unittest.py:
1386         (EchoTest):
1387         (EchoTest.test_basic):
1388         (EchoTest.test_no_newline):
1389         (EchoTest.test_unicode):
1390         (EchoTest.test_argument_order):
1391         (EchoTest.test_empty_arguments):
1392         (EchoTest.test_no_arguments):
1393         (EchoTest.test_as_command):
1394
1395 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1396
1397         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1398         https://bugs.webkit.org/show_bug.cgi?id=76138
1399
1400         Reviewed by Martin Robinson.
1401
1402         * Scripts/webkitdirs.pm:
1403         (isCrossCompilation):
1404         (buildAutotoolsProject):
1405
1406 2012-01-25  Adam Barth  <abarth@webkit.org>
1407
1408         Kentaro is a reviewer now.  Yay!
1409
1410         * Scripts/webkitpy/common/config/committers.py:
1411
1412 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1413
1414         nrwt: running w/ no arguments fails
1415         https://bugs.webkit.org/show_bug.cgi?id=77064
1416
1417         Unreviewed, build fix.
1418
1419         This change fixes a regression introduced in r105944
1420         where running without --platform <foo> or one of the other
1421         platform switches would cause a null deref :(.
1422
1423         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1424         (main):
1425
1426 2012-01-25  Eric Seidel  <eric@webkit.org>
1427
1428         Automatically CC someone from Apple on any changes to Obj-C public API
1429         https://bugs.webkit.org/show_bug.cgi?id=77053
1430
1431         Reviewed by Timothy Hatcher.
1432
1433         This has long been de-facto practice, seems now that we have
1434         fancy watchlist support, we should just make the tools
1435         do this automatically.
1436
1437         * Scripts/webkitpy/common/config/watchlist:
1438
1439 2012-01-25  Antoine Labour  <piman@chromium.org>
1440
1441         Updating status in committers.py.
1442
1443         Unreviewed.
1444
1445         * Scripts/webkitpy/common/config/committers.py:
1446
1447 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1448
1449         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1450         https://bugs.webkit.org/show_bug.cgi?id=77058
1451
1452         Reviewed by Eric Seidel.
1453
1454         r105935 broke executive_unittest by changing which script we
1455         were running and not ensuring that the PYTHONPATH was set up
1456         properly.
1457
1458         This change also fixes a regression introduced recently where
1459         test-webkitpy wasn't figuring out the path to Tools/Scripts
1460         right, either (so running ./test-webkitpy would fail).
1461
1462         * Scripts/test-webkitpy:
1463         * Scripts/webkitpy/common/system/executive_unittest.py:
1464         (script_dir):
1465         (ExecutiveTest.setUp):
1466         (ExecutiveTest):
1467         (ExecutiveTest.tearDown):
1468
1469 2012-01-25  Adam Barth  <abarth@webkit.org>
1470
1471         Disable tests on the mac-ews while we sort out hte stability issues.
1472
1473         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1474         (MacEWS):
1475
1476 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1477
1478         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1479         https://bugs.webkit.org/show_bug.cgi?id=76475
1480
1481         Reviewed by Eric Seidel.
1482
1483         This patch cleans up the internal usage of port names for the
1484         Apple mac and Apple win ports so that 'mac' and 'win are never
1485         considered "fully specified" port names: they are still legal
1486         input to the PortFactory.get() routine, but only if run on the given
1487         platform (i.e. trying to PortFactory.get('mac') on windows or
1488         linux will return an error, since we don't know which version of
1489         the port is desired.
1490
1491         This also cleans up handling of the webkit2 variants, so that
1492         the full port names consistently follow the
1493         <operating_system>-<version>[-<wk2>] convention.
1494
1495         Lastly this patch adds some assertions and removes some
1496         try/catch logic to catch more programming and usage errors;
1497         previously mac-tiger might've been allowed -- and it would've
1498         translated into using just the baselines in platform/mac -- but
1499         now it should fail.
1500
1501         * Scripts/webkitpy/layout_tests/port/apple.py:
1502         (ApplePort.determine_full_port_name):
1503         (ApplePort.__init__):
1504         (ApplePort):
1505         (ApplePort._port_name_with_version):
1506         * Scripts/webkitpy/layout_tests/port/builders.py:
1507         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1508         (FactoryTest.test_mac):
1509         (FactoryTest.test_win):
1510         * Scripts/webkitpy/layout_tests/port/mac.py:
1511         (MacPort.baseline_search_path):
1512         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1513         (MacTest.test_versions):
1514         * Scripts/webkitpy/layout_tests/port/win.py:
1515         (WinPort.baseline_search_path):
1516         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1517         (WinTest.test_versions):
1518
1519 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1520
1521         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1522         https://bugs.webkit.org/show_bug.cgi?id=76955
1523
1524         Reviewed by Adam Barth.
1525
1526         This change cleans up the errors that are printed so that the
1527         are more "quickfix" compatible (path:lineno).
1528
1529         Also, there were a bunch of redundant tests between
1530         layout_tests.models.test_expectations_unittest and
1531         style.checkers.test_expectations_unittest. The latter should
1532         just expect the former to do most of the testing.
1533
1534         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1535         (TestExpectationParser._parse_modifiers):
1536         (TestExpectations._report_errors):
1537         (TestExpectations._add_skipped_tests):
1538         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1539         (test_parse_error_nonfatal):
1540         (SemanticTests.test_bad_bugid):
1541         * Scripts/webkitpy/style/checkers/test_expectations.py:
1542         (TestExpectationsChecker.__init__):
1543         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1544         (TestExpectationsTestCase.assert_lines_lint):
1545         (TestExpectationsTestCase.test_valid_expectations):
1546         (TestExpectationsTestCase.test_invalid_expectations):
1547         (TestExpectationsTestCase.test_tab):
1548
1549 2012-01-25  Eric Seidel  <eric@webkit.org>
1550
1551         webkit-patch apply-* should always continue after failures
1552         https://bugs.webkit.org/show_bug.cgi?id=77057
1553
1554         Reviewed by Adam Barth.
1555
1556         As far as I can tell there is only one potential drawback to always
1557         forcing: that if you're somehow in the wrong directory it will create new
1558         directories for new files.  Since webkit-patch always cd's to the root
1559         it seems that's not a drawback.  The drawback of not using --force for
1560         svn-apply, is that it will stop after the first failure, which is rarely
1561         (if ever) the desired behavior.  This just removes the force option
1562         (which was strangely hidden behind --non-interactive).  This should
1563         make for a better user experiance.
1564
1565         * Scripts/webkitpy/common/checkout/checkout.py:
1566         (Checkout.apply_patch):
1567         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1568         (MockCheckout.apply_patch):
1569         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1570         (CheckoutTest.test_chromium_deps):
1571         (CheckoutTest):
1572         (CheckoutTest.test_apply_patch):
1573         * Scripts/webkitpy/tool/commands/download_unittest.py:
1574         (DownloadCommandsTest._default_options):
1575         * Scripts/webkitpy/tool/steps/applypatch.py:
1576         (ApplyPatch.options):
1577         (ApplyPatch.run):
1578         * Scripts/webkitpy/tool/steps/options.py:
1579         (Options):
1580
1581 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1582
1583         nrwt: should be able to run --platform test interactively
1584         https://bugs.webkit.org/show_bug.cgi?id=76959
1585
1586         Reviewed by Adam Barth.
1587
1588         As part of refactoring the Port interfaces, in r103254 I made
1589         passing a Host object to the Port mandatory; previously TestPort
1590         objects would create their own (mock) hosts. However,
1591         new-run-webkit-tests always passed a real Host, not a MockHost,
1592         and so you couldn't run new-run-webkit-tests --platform test
1593         interactively to debug test failures.
1594
1595         This change fixes that by creating a MockHost instead of a real
1596         host if you say --platform test*.
1597
1598         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1599         (main):
1600
1601 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1602
1603         run-webkit-tests --lint-test-files should lint all the ports by default
1604         https://bugs.webkit.org/show_bug.cgi?id=76749
1605
1606         Reviewed by Ojan Vafai.
1607
1608         Currently run-webkit-tests --lint-test-files will only lint the
1609         test_expectations for the single port determined by the command
1610         line options. This is not obvious and can produce unintended results
1611         if you want to lint the chromium port (probably the normal case
1612         for using --lint-test-files) but don't specify a port name or
1613         --chromium.
1614
1615         I think we should probably lint *all* of the ports if no port
1616         name is supplied. This change implements that, and also moves
1617         the linting logic out of the Manager class, since this really
1618         has nothing to do with Managers. It has little to do with
1619         run-webkit-tests, but splitting it into a different script would
1620         introduce compatibility issues. It might make sense to do that
1621         anyway, in a separate patch and combining that with cleaning up
1622         the style checker to share more code.
1623
1624         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1625         (Manager._strip_test_dir_prefix):
1626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1627         (lint):
1628         (run):
1629         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1630         (LintTest.test_all_configurations): added.
1631         (LintTest.test_lint_test_files): added.
1632         (LintTest.test_lint_test_files__errors): added.
1633         (MainTest.test_lint_test_files): removed.
1634         (MainTest.test_lint_test_files__errors): removed.
1635
1636 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1637
1638         webkitpy: clean up a bunch of test scaffolding
1639         https://bugs.webkit.org/show_bug.cgi?id=76973
1640
1641         Reviewed by Eric Seidel.
1642
1643         There were several helper modules in the webkitpy.test package
1644         that appear to only be used by executive_unittest.py. I am
1645         rolling them all into that file to make that clearer.
1646
1647         * Scripts/webkitpy/common/system/executive_unittest.py:
1648         (ExecutiveTest.test_run_command_args_type):
1649         (ExecutiveTest.test_run_command_with_unicode):
1650         (ExecutiveTest.test_running_pids):
1651         (command_line):
1652         (main):
1653         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1654         * Scripts/webkitpy/test/cat.py: Removed.
1655         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1656         * Scripts/webkitpy/test/echo.py: Removed.
1657         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1658
1659 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1660
1661         webkitpy: clean up a bunch of test scaffolding
1662         https://bugs.webkit.org/show_bug.cgi?id=76973
1663
1664         Reviewed by Eric Seidel.
1665
1666         There were several helper modules in the webkitpy.test package
1667         that appear to only be used by executive_unittest.py. I am
1668         rolling them all into that file to make that clearer.
1669
1670         * Scripts/webkitpy/common/system/executive_unittest.py:
1671         (ExecutiveTest.test_run_command_args_type):
1672         (ExecutiveTest.test_run_command_with_unicode):
1673         (ExecutiveTest.test_running_pids):
1674         (command_line):
1675         (main):
1676         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1677         * Scripts/webkitpy/test/cat.py: Removed.
1678         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1679         * Scripts/webkitpy/test/echo.py: Removed.
1680         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1681
1682 2012-01-25  Eric Seidel  <eric@webkit.org>
1683
1684         Remove Python 2.5 support from WebKit
1685         https://bugs.webkit.org/show_bug.cgi?id=71593
1686
1687         Reviewed by Adam Barth.
1688
1689         Just removing support from this one core file.
1690         I'll commit the rest of the (large) change once we've
1691         gone 24 hours and seen that no bots have exploded.
1692         We can roll out this one change if we break bots
1693         and then roll in the rest once those bots are fixed.
1694
1695         * Scripts/webkitpy/common/system/executive.py:
1696         (Executive.cpu_count):
1697
1698 2012-01-25  Hajime Morita  <morrita@google.com>
1699
1700         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1701         https://bugs.webkit.org/show_bug.cgi?id=76863
1702
1703         Reviewed by Dimitri Glazkov.
1704
1705         Added a feature flag.
1706
1707         * Scripts/build-webkit:
1708         * qmake/mkspecs/features/features.prf:
1709
1710 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1711
1712         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1713         https://bugs.webkit.org/show_bug.cgi?id=76344
1714
1715         Reviewed by Sam Weinig.
1716
1717         Add a test verifying that the mouse button during policy decisions for
1718         events not triggered by mouse events is NoButton.
1719
1720         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1721         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1722         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1723
1724 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1725
1726         run-perf-tests should timeout sooner
1727         https://bugs.webkit.org/show_bug.cgi?id=77026
1728
1729         Reviewed by Adam Barth.
1730
1731         Bump off the timeout from 10 minutes to 4 minutes.
1732
1733         Also use float instead of str in test result values to compress the size of json files bots upload.
1734
1735         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1736         (PerfTestsRunner._parse_args):
1737         (PerfTestsRunner._process_chromium_style_test_result):
1738         (PerfTestsRunner._process_parser_test_result):
1739         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1740         (test_run_test_set_for_parser_tests):
1741         (test_run_test_set_with_json_output):
1742         (test_run_test_set_with_json_source):
1743
1744 2012-01-25  Enrica Casucci  <enrica@apple.com>
1745
1746         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1747         https://bugs.webkit.org/show_bug.cgi?id=76951
1748         <rdar://problem/9325158>
1749
1750         Reviewed by Alexey Proskuryakov.
1751
1752         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
1753         and WebHTMLView.
1754         (TestWebKitAPI::TEST):
1755
1756 2012-01-23  MORITA Hajime  <morrita@google.com>
1757
1758         [Refactoring][Internals] Should have InternalSettings
1759         https://bugs.webkit.org/show_bug.cgi?id=76424
1760
1761         Reviewed by Kent Tamura.
1762
1763         * GNUmakefile.am: Added so new files.
1764
1765 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
1766
1767         webkitpy: new-run-webkit-websocket is broken
1768         https://bugs.webkit.org/show_bug.cgi?id=76999
1769
1770         Reviewed by Dirk Pranke.
1771
1772         r105674 broke new-run-webkit-websocket, since options.chromium
1773         doesn't exist any more. new-run-webkit-httpd was also broken
1774         and already fixed at r105835.
1775         * Scripts/new-run-webkit-websocketserver:
1776         (main):
1777
1778 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1779
1780         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
1781         https://bugs.webkit.org/show_bug.cgi?id=63458
1782
1783         Reviewed by Adam Roben.
1784
1785         Implement the setPopupBlockingEnabled method.
1786
1787         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1788         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1789         (WTR::LayoutTestController::setPopupBlockingEnabled):
1790         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1791
1792 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
1793
1794         [Qt] Cleanup testfonts handling
1795         https://bugs.webkit.org/show_bug.cgi?id=76068
1796
1797         Reviewed by Simon Hausmann.
1798
1799         Factor test font initialization into it's own file  so test
1800         font users can share the implementation by adding the file
1801         to their build.
1802         Use fonts.conf from the test font directory to not require the
1803         current directory to be the WebKit root.
1804         Fix the -use-test-fonts option of QtTestBrowser by initializing
1805         the fonts earlier, before it is too late (namely before calling
1806         show on the main window).
1807
1808         * DumpRenderTree/qt/DumpRenderTree.pro:
1809         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1810         (WebCore::DumpRenderTree::open):
1811         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1812         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
1813         (WebKit::initializeTestFonts):
1814         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
1815         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
1816         we will use the one from the test fonts directory.
1817         * DumpRenderTree/qt/main.cpp:
1818         (main): Fix the ifdefs to make it clear that the code to
1819         set up the Dpi has not been ported to Qt5 yet.
1820         * QtTestBrowser/QtTestBrowser.pro:
1821         * QtTestBrowser/launcherwindow.h:
1822         (WindowOptions::WindowOptions):
1823         * QtTestBrowser/main.cpp:
1824         (launcherMain):
1825         (LauncherApplication::handleUserOptions):
1826         * WebKitTestRunner/InjectedBundle/Target.pri:
1827         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1828         (WTR::activateFonts): Remove the code to set up the Dpi
1829         because it does not work with Qt5.
1830
1831 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
1832
1833         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
1834
1835         Reviewed by Tor Arne Vestø.
1836
1837         Don't require it by making svnRevisionForDirectory return "unknown"
1838         instead of bailing out with an error.
1839
1840         * Scripts/VCSUtils.pm:
1841         (svnRevisionForDirectory):
1842
1843 2012-01-25  Adam Barth  <abarth@webkit.org>
1844
1845         Temporarily disable running the unit tests on the Chromium EWS.  These
1846         tests don't work properly (see
1847         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
1848         blocking the EWS.
1849
1850         * Scripts/webkitpy/common/config/ports.py:
1851         (ChromiumPort):
1852
1853 2012-01-25  Adam Barth  <abarth@webkit.org>
1854
1855         Update results.html version of PixelZoomer
1856         https://bugs.webkit.org/show_bug.cgi?id=76965
1857
1858         Reviewed by Ojan Vafai.
1859
1860         Improve readability as suggested by Ojan.
1861
1862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1863
1864 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1865
1866         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
1867         https://bugs.webkit.org/show_bug.cgi?id=76899
1868
1869         Reviewed by Martin Robinson.
1870
1871         * gtk/generate-gtkdoc:
1872         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
1873         WebKitLoaderClient.
1874
1875 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1876
1877         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
1878
1879         * BuildSlaveSupport/build.webkit.org-config/config.json:
1880
1881 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1882
1883         WebKit needs public performance tests running on public bots
1884         https://bugs.webkit.org/show_bug.cgi?id=10266
1885
1886         Reviewed by Adam Barth.
1887
1888         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
1889         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
1890
1891         * BuildSlaveSupport/build.webkit.org-config/config.json:
1892         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1893         (RunAndUploadPerfTests):
1894         (RunAndUploadPerfTests.start):
1895         (UploadPerfTestResults):
1896         (BuildAndPerfTestFactory):
1897         (BuildAndPerfTestFactory.__init__):
1898
1899 2012-01-24  Ojan Vafai  <ojan@chromium.org>
1900
1901         Initializing the browser property of the Bugzilla class takes too long
1902         https://bugs.webkit.org/show_bug.cgi?id=76960
1903
1904         Reviewed by Adam Barth.
1905
1906         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
1907         on my Mac Pro.
1908
1909         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1910         (Bugzilla.__init__):
1911         (Bugzilla._get_browser):
1912         (Bugzilla):
1913         (Bugzilla._set_browser):
1914
1915 2012-01-24  Mark Rowe  <mrowe@apple.com>
1916
1917         Death to JavaScriptGlue.
1918
1919         Rubber-stamped by Geoffrey Garen.
1920
1921         * BuildSlaveSupport/build-launcher-app:
1922         (copyNightlyLauncher):
1923         * Scripts/build-webkit:
1924         * Scripts/do-file-rename:
1925         * Scripts/do-webcore-rename:
1926         * Scripts/webkitpy/common/config/build.py:
1927         (_should_file_trigger_build):
1928         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
1929         path in conjunction with a cross-platform path.
1930         (ShouldBuildTest):
1931
1932 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1933
1934         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
1935         https://bugs.webkit.org/show_bug.cgi?id=75836
1936
1937         Reviewed by David Kilzer.
1938
1939         Previously parser_unittests.pl can just test the returned value of
1940         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
1941         parser_unittests.pl so that it also tests the stdout and stderr of
1942         get_function_line_ranges().
1943
1944         This patch adds css_unittests_warning.css, which contains test cases
1945         for warning messages of the CSS parser of prepare-ChangeLog.
1946
1947         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1948         (captureOutput): Captures the stdout and stderr of a given method.
1949         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
1950         string to relative paths.
1951
1952         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
1953         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
1954         (element1):
1955         (element2):
1956         (element3):
1957         (element4):
1958         ():
1959         (element5):
1960         (element6):
1961
1962         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1963         Just updated the test results, i.e. added stdout and stderr results.
1964         No essential changes in the test results.
1965         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
1966         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
1967         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
1968         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
1969         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
1970
1971 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
1972
1973         webkitpy: new-run-webkit-httpd is broken
1974         https://bugs.webkit.org/show_bug.cgi?id=76963
1975
1976         Reviewed by Adam Barth.
1977
1978         r105674 broke new-run-webkit-httpd, since options.chromium
1979         doesn't exist any more. We didn't catch this because we don't
1980         run the integration tests by default anywhere :(.
1981
1982         * Scripts/new-run-webkit-httpd:
1983         (run):
1984         (main):
1985
1986 2012-01-24  Adam Barth  <abarth@webkit.org>
1987
1988         garden-o-matic pixel zoomer should let you look at every pixel of the image
1989         https://bugs.webkit.org/show_bug.cgi?id=76962
1990
1991         Reviewed by Ojan Vafai.
1992
1993         Previously, you couldn't get up to the right and bottom pixels.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1996
1997 2012-01-24  Enrica Casucci  <enrica@apple.com>
1998
1999         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2000         https://bugs.webkit.org/show_bug.cgi?id=76951
2001         <rdar://problem/9325158>
2002
2003         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2004         works as expected.
2005         
2006         Reviewed by Alexey Proskuryakov.
2007
2008         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2009         (TestWebKitAPI::TEST):
2010
2011 2012-01-24  James Robinson  <jamesr@chromium.org>
2012
2013         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2014         https://bugs.webkit.org/show_bug.cgi?id=76884
2015
2016         Reviewed by Adam Barth.
2017
2018         * Scripts/webkitpy/tool/bot/irc_command.py:
2019         (Rollout.execute):
2020         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2021         (SheriffIRCBotTest.test_rollout):
2022         (SheriffIRCBotTest.test_revert):
2023         (SheriffIRCBotTest.test_multi_rollout):
2024         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2025         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2026         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2027         (test_multi_rollout_invalidate_reason):
2028
2029 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2030
2031         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2032         https://bugs.webkit.org/show_bug.cgi?id=75531
2033
2034         Reviewed by David Kilzer.
2035
2036         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2037         outside methods. Consider the following cpp file.
2038
2039             namespace N {
2040             int a;     // this change does not appear on ChangeLog.
2041             class C {
2042                 int b;     // this change does not appear on ChangeLog.
2043                 void f()
2044                 {
2045                     int c;     // this change appears on ChangeLog.
2046                 }
2047                 int d;     // this change does not appear on ChangeLog.
2048             };
2049             int e;     // this change does not appear on ChangeLog.
2050             };
2051
2052         The previous prepare-ChangeLog outputs just methods in which a change is found:
2053             (N::C::f):
2054
2055         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2056         and methods in which a change is found:
2057             (N):
2058             (N::C):
2059             (N::C::f):
2060
2061         * Scripts/prepare-ChangeLog:
2062         (get_function_line_ranges_for_cpp): Modified as described above.
2063
2064         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2065         (Class104):
2066         (Class105):
2067         (Class106):
2068         (Class106::func32):
2069         (Class106::func33):
2070         (NameSpace3):
2071         (NameSpace4):
2072         (NameSpace5):
2073         (NameSpace6):
2074         (Class107):
2075         (NameSpace5::NameSpace6::Class107::func34):
2076         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2077
2078 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2079
2080         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2081         https://bugs.webkit.org/show_bug.cgi?id=75943
2082
2083         Reviewed by David Kilzer.
2084
2085         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2086         because it does not distinguish '}' at the end of a subroutine
2087         with '}' at the end of a if or for statement.
2088
2089         foo.pl:
2090             if (1) {
2091             }
2092             for (@v) {
2093             }
2094
2095         output:
2096             nested functions found at top-level at foo.pl:2
2097             nested functions found at top-level at foo.pl:4
2098
2099         This patch fixes the bug.
2100
2101         * Scripts/prepare-ChangeLog:
2102         (get_function_line_ranges_for_perl):
2103         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2104         Added test cases. No change in the test results.
2105
2106 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2107
2108         r105674 broke check-webkit-style for chromium's test_expectations.
2109
2110         Unreviewed, build fix.
2111         
2112         We now need to pass in a platform name of 'chromium' if we want
2113         the chromium port; options.chromium is no longer recognized. I
2114         will follow this patch up with a separate patch that has a test,
2115         but this at least fixes the build.
2116
2117         * Scripts/webkitpy/style/checkers/test_expectations.py:
2118         (TestExpectationsChecker._determine_port_from_exepectations_path):
2119
2120 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2121
2122         check-webkit-style of the chromium test_expectations.txt file takes too long
2123         https://bugs.webkit.org/show_bug.cgi?id=76745
2124
2125         Reviewed by Dimitri Glazkov.
2126
2127         When in lint mode, have TestExpectations test all configurations instead
2128         of looping over each configuration. This also has the benefit of making
2129         the error output considerably more concise.
2130
2131         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2132
2133         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2134         (Manager.lint):
2135         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2136         (TestExpectations._report_errors):
2137         (TestExpectations._add_expectations):
2138         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2139         (test_parse_error_nonfatal):
2140         (test_error_on_different_platform):
2141         * Scripts/webkitpy/style/checkers/test_expectations.py:
2142         (TestExpectationsChecker.check_test_expectations):
2143         (TestExpectationsChecker.check):
2144         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2145         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2146         (TestExpectationsTestCase.assert_lines_lint):
2147
2148 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2149
2150         Another build fix attempt after r105543.
2151
2152         * Scripts/webkitpy/common/net/file_uploader.py:
2153         (FileUploader.upload_as_multipart_form_data):
2154
2155 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2156
2157         Build fix attempt after r105543.
2158
2159         * Scripts/webkitpy/common/net/file_uploader.py:
2160         (FileUploader.upload_as_multipart_form_data):
2161
2162 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2163
2164         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2165         https://bugs.webkit.org/show_bug.cgi?id=76411
2166
2167         Reviewed by Adam Barth.
2168
2169         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2170         into a series of patches, this change adds a trivial
2171         pointer lock implementation to the Chromium port's DumpRenderTree
2172         and exposes LayoutTestController hooks to force failure conditions.
2173
2174         * DumpRenderTree/chromium/LayoutTestController.cpp:
2175         (LayoutTestController::LayoutTestController):
2176         (LayoutTestController::didLosePointerLock):
2177         (LayoutTestController::setPointerLockWillFailAsynchronously):
2178         (LayoutTestController::setPointerLockWillFailSynchronously):
2179         * DumpRenderTree/chromium/LayoutTestController.h:
2180         * DumpRenderTree/chromium/WebViewHost.cpp:
2181         (WebViewHost::requestPointerLock):
2182         (WebViewHost::requestPointerUnlock):
2183         (WebViewHost::isPointerLocked):
2184         (WebViewHost::didCompletePointerLock):
2185         (WebViewHost::didNotCompletePointerLock):
2186         (WebViewHost::didLosePointerLock):
2187         (WebViewHost::reset):
2188         * DumpRenderTree/chromium/WebViewHost.h:
2189         (WebViewHost::setPointerLockWillFailAsynchronously):
2190         (WebViewHost::setPointerLockWillFailSynchronously):
2191
2192 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2193
2194         Unreviewed, skip WK2 API test timing out on some GTK bots.
2195
2196         WebKit2APITests/TestDownloads is consistently timing out on the
2197         32bit release and 64bit debug bots.
2198
2199         * Scripts/run-gtk-tests:
2200         (TestRunner): Skip WebKit2APITests/TestDownloads.
2201
2202 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2203
2204         [Qt] Fix the build with the newes Qt5 hashes
2205         https://bugs.webkit.org/show_bug.cgi?id=76657
2206
2207         Reviewed by Simon Hausmann.
2208
2209         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2210         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2211         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2212
2213 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2214
2215         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2216
2217         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2218         building with MinGW inside cmd.exe will require the same construct. Instead
2219         we assume that when the first character in PWD is a '/' we're running under
2220         Cygwin, and use the normal unix way of setting environment variables.
2221
2222         Reviewed by Simon Hausmann.
2223
2224         * qmake/mkspecs/features/default_pre.prf:
2225
2226 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2227
2228         Some qmake build files must include Qt5's "quick" module.
2229         https://bugs.webkit.org/show_bug.cgi?id=76671
2230
2231         Unreviewed build fix.
2232
2233         * MiniBrowser/qt/MiniBrowser.pro:
2234         * WebKitTestRunner/Target.pri:
2235
2236 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2237
2238         [Qt] Fix the event timestamps for touch mocking
2239
2240         Reviewed by Simon Hausmann.
2241
2242         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2243         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2244         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2245
2246 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2249         https://bugs.webkit.org/show_bug.cgi?id=72952
2250
2251         Reviewed by Martin Robinson.
2252
2253         * gtk/generate-gtkdoc:
2254         (get_webkit2_options): Ignore WebKitDownloadClient.
2255
2256 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2257
2258         [GTK] editing/deleting/5408255.html results are incorrect
2259         https://bugs.webkit.org/show_bug.cgi?id=53644
2260
2261         Reviewed by Martin Robinson.
2262
2263         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2264         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2265         macro. This way both tools can be run outside the test harness without
2266         the need to manually set the environment variable.
2267
2268         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2269         (getTopLevelPath):
2270         * GNUmakefile.am:
2271         * Scripts/webkitpy/layout_tests/port/gtk.py:
2272         (GtkPort.setup_environ_for_server):
2273         * WebKitTestRunner/GNUmakefile.am:
2274         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2275         (WTR::InjectedBundle::platformInitialize):
2276
2277 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2278
2279         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2280         https://bugs.webkit.org/show_bug.cgi?id=74653.
2281
2282         Reviewed by Darin Fisher.
2283
2284         * DumpRenderTree/chromium/LayoutTestController.cpp:
2285         (LayoutTestController::LayoutTestController):
2286         (LayoutTestController::workerThreadCount):
2287         * DumpRenderTree/chromium/LayoutTestController.h:
2288
2289 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2290
2291         nrwt: make --chromium work like --qt
2292         https://bugs.webkit.org/show_bug.cgi?id=76875
2293
2294         Reviewed by Adam Barth.
2295
2296         --chromium used to have to be handled differently from --qt
2297         due to the way the PortFactory was implemented; there's not
2298         really a good reason for that any more so this patch makes
2299         things slightly more consistent and eliminates the
2300         options.chromium flag (--chromium is now truly a synonym for
2301         --platform chromium).
2302
2303         * Scripts/webkitpy/layout_tests/port/factory.py:
2304         (PortFactory._default_port):
2305         (PortFactory.get):
2306         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2307         (FactoryTest.setUp):
2308         (FactoryTest.test_chromium_mac):
2309         (FactoryTest.test_chromium_linux):
2310         (FactoryTest.test_chromium_win):
2311         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2312         (parse_args):
2313
2314 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2315
2316         run-webkit-tests needs to propagate --chromium
2317         https://bugs.webkit.org/show_bug.cgi?id=76870
2318
2319         Reviewed by Eric Seidel.
2320
2321         run-webkit-tests removes '--chromium' argument from @ARGV when
2322         determining which port to run, which means that that doesn't
2323         propagate to new-run-webkit-tests. That's bad (and is handled
2324         for the other ports by re-adding the flag, but apparently we're
2325         just now noticing for Chromium).
2326
2327         * Scripts/run-webkit-tests:
2328
2329 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2330
2331         More build fixing after r105646.
2332
2333         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2334         (TestWebKitAPI::TestNode::key):
2335
2336 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2337
2338         Unreviewed build fix - r105646 broke this.
2339
2340         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2341         (TestWebKitAPI::TestNode::TestNode):
2342         (TestWebKitAPI::TestNode::key):
2343         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2344         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2345         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2346
2347 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2348
2349         Unreviewed, rolling out r105658.
2350         http://trac.webkit.org/changeset/105658
2351         https://bugs.webkit.org/show_bug.cgi?id=76883
2352
2353         We want this eventually, but not right at this moment
2354         (Requested by abarth on #webkit).
2355
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2357
2358 2012-01-23  Adam Barth  <abarth@webkit.org>
2359
2360         garden-o-matic should support Chromium Mac Lion
2361         https://bugs.webkit.org/show_bug.cgi?id=76880
2362
2363         Reviewed by Eric Seidel.
2364
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2366
2367 2012-01-23  Emil A Eklund  <eae@chromium.org>
2368
2369         check-webkit-style whitespace/operators triggers on overloaded division operator
2370         https://bugs.webkit.org/show_bug.cgi?id=76650
2371
2372         Reviewed by Darin Adler.
2373
2374         * Scripts/webkitpy/style/checkers/cpp.py:
2375         (check_spacing):
2376         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2377         (CppStyleTest.test_operator_methods):
2378
2379 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2380
2381         run-perf-tests should report server-side errors
2382         https://bugs.webkit.org/show_bug.cgi?id=76802
2383
2384         Reviewed by Tony Chang.
2385
2386         Report errors whenever server's response doesn't match "OK".
2387
2388         * Scripts/webkitpy/common/net/file_uploader.py:
2389         (FileUploader.upload_single_text_file):
2390         (FileUploader.upload_as_multipart_form_data):
2391         (FileUploader._upload_data.callback):
2392         (FileUploader):
2393         (FileUploader._upload_data):
2394         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2395         (PerfTestsRunner._upload_json):
2396         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2397         (test_upload_json):
2398         (test_upload_json.MockFileUploader.upload_single_text_file):
2399
2400 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2401
2402         run-perf-tests ignore Skipped list on chromium
2403         https://bugs.webkit.org/show_bug.cgi?id=76764
2404
2405         Reviewed by Dirk Pranke.
2406
2407         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2408         can also find skipped list. Chromium port only uses test_expectations.txt for
2409         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2410         also needs to use Skipped list.
2411
2412         * Scripts/webkitpy/layout_tests/port/base.py:
2413         (Port._tests_from_skipped_file_contents):
2414         (Port):
2415         (Port._expectations_from_skipped_files):
2416         (Port.skipped_perf_tests):
2417         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2418         (PortTest.test_skipped_perf_tests):
2419         (PortTest.test_skipped_perf_tests.add_text_file):
2420         * Scripts/webkitpy/layout_tests/port/webkit.py:
2421         (WebKitPort._skipped_tests_for_unsupported_features):
2422         (WebKitPort._skipped_file_search_paths):
2423         (WebKitPort.skipped_layout_tests):
2424
2425 2012-01-23  Andy Estes  <aestes@apple.com>
2426
2427         Fix the build after r105635.
2428
2429         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2430         (TestWebKitAPI::TEST):
2431
2432 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2433
2434         Basic enhancements to StringBuilder
2435         https://bugs.webkit.org/show_bug.cgi?id=67081
2436
2437         Reviewed by Darin Adler.
2438
2439         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2440         (TestWebKitAPI::TEST):
2441
2442 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2443
2444         [GTK] run-gtk-tests randomly fails while running the xprop comand
2445         https://bugs.webkit.org/show_bug.cgi?id=76817
2446
2447         Reviewed by Gustavo Noronha Silva.
2448
2449         No need to use xprop to remove the AT_SPI_BUS property since
2450         run-gtk-tests will always run new instances of Xvfb.
2451
2452         * Scripts/run-gtk-tests:
2453         (TestRunner): Unskip TestWebKitAccessibility.
2454         (TestRunner.run): Uncomment lines for launching the accessibility
2455         bus and registry daemon, and remove lines for running xprop.
2456
2457 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2458
2459         [Qt] Don't warn about override and final being C++11 extensions
2460
2461         Clang will emit a warning when these extensions are used without passing
2462         --std=c++11, but we use feature checking to decide if we have the right
2463         extensions, so we can safely ignore these warnings. The XCode and Windows
2464         project files have the same workaround.
2465
2466         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2467         we only have one extra compiler for Objective-C, which is also used for
2468         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2469         make sense for Objective-C.
2470
2471         Reviewed by Simon Hausmann.
2472
2473         * qmake/mkspecs/features/unix/default_post.prf:
2474
2475 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2476
2477         [Qt] Change how build-webkit decides when to do full incremental builds
2478
2479         Instead of relying on update-webkit (which isn't run on the bots) to
2480         decide when to do a full incremental build (make qmake), we let the
2481         build-webkit script itself check the current SVN revision against the
2482         previous build (by storing it in .webkit.config).
2483
2484         If the two differ we assume a full incremental build is needed, since
2485         the new revisions might have introduced problematic things like new
2486         Q_OBJECT macros. If not, we assume the developer is doing changes
2487         locally, and revert to doing a plain 'make'.
2488
2489         In addition, when the build fails in the latter case, we inform the
2490         developer of possible pitfalls and how to manually run 'make qmake'.
2491
2492         Reviewed by Ossy.
2493
2494         * Scripts/update-webkit:
2495         * Scripts/webkitdirs.pm:
2496         (buildQMakeProjects):
2497
2498 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2499
2500         [GTK] run-gtk-tests randomly fails while running the xprop comand
2501         https://bugs.webkit.org/show_bug.cgi?id=76817
2502
2503         Reviewed by Philippe Normand.
2504
2505         Temporarily comment the lines related to launching the ATSPI bus
2506         and registry daemon, which are making the bots to fail randomly.
2507
2508         * Scripts/run-gtk-tests:
2509         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2510         properly if the ATSPI infrastructure is not properly initialized.
2511         (TestRunner.run): Comment lines related to initialization of ATSPI.
2512
2513 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2514
2515         Windows python test build fix.
2516
2517         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2518         (PerfTestsRunner.__init__):
2519
2520 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2521
2522         [GTK] DumpRenderTree converts "file:///" to a path differently
2523         https://bugs.webkit.org/show_bug.cgi?id=76631
2524
2525         Reviewed by Martin Robinson.
2526
2527         DumpRenderTree should print "/" as the last path component if the
2528         path is a lone slash instead of empty output.
2529
2530         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2531         (webViewConsoleMessage):
2532
2533 2012-01-20  David Levin  <levin@chromium.org>
2534
2535         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2536         https://bugs.webkit.org/show_bug.cgi?id=76752
2537
2538         Reviewed by Eric Seidel.
2539
2540         * Scripts/webkitpy/style/checkers/cpp.py:
2541         (check_for_leaky_patterns):
2542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2543         (LeakyPatternTest.test_create_dc):
2544         (LeakyPatternTest.test_create_compatible_dc):
2545
2546 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2547
2548         Changed my status in commiters.py
2549
2550         Unreviewed.
2551
2552         * Scripts/webkitpy/common/config/committers.py:
2553
2554 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2555
2556         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2557         https://bugs.webkit.org/show_bug.cgi?id=76748
2558
2559         Reviewed by Ryosuke Niwa.
2560
2561         It crawls the whole subtree and then doesn't use the data. Cutting this out
2562         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2563
2564         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2565         (run):
2566
2567 2012-01-20  Adam Barth  <abarth@webkit.org>
2568
2569         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2570         up slightly nicer when there aren't any failures.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2573         (#summary):
2574
2575 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2576
2577         run-perf-tests should support --test-results-server option
2578         https://bugs.webkit.org/show_bug.cgi?id=76680
2579
2580         Reviewed by Adam Barth.
2581
2582         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2583         to be used by perf bots. Also refactor file_uploader as needed.
2584
2585         * Scripts/webkitpy/common/net/file_uploader.py:
2586         (FileUploader.__init__):
2587         (FileUploader.upload_single_file):
2588         (FileUploader.upload_as_multipart_form_data):
2589         (FileUploader):
2590         (FileUploader._upload_data):
2591         (FileUploader._upload_data.callback):
2592         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2593         (JSONResultsGeneratorBase.upload_json_files):
2594         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2595         (PerfTestsRunner):
2596         (PerfTestsRunner._parse_args):
2597         (PerfTestsRunner.run):
2598         (PerfTestsRunner._generate_json):
2599         (PerfTestsRunner._upload_json):
2600         (PerfTestsRunner._run_tests_set):
2601         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2602         (create_runner):
2603         (test_run_with_upload_json):
2604         (test_run_with_upload_json.mock_upload_json):
2605         (test_upload_json):
2606         (test_upload_json.MockFileUploader):
2607         (test_upload_json.MockFileUploader.__init__):
2608         (test_upload_json.MockFileUploader.upload_single_file):
2609         (test_parse_args):
2610
2611 2012-01-20  Adam Barth  <abarth@webkit.org>
2612
2613         The party time image overlaps real content!  This patch makes the
2614         image centered vertically.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2617         (#onebar.partytime #summary):
2618
2619 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2620
2621         Refactor TestExpectationsParser in preparation for caching the results
2622         https://bugs.webkit.org/show_bug.cgi?id=76669
2623
2624         Reviewed by Dimitri Glazkov.
2625
2626         Make everything private expect for the parse method. 
2627         Eventually, we'll need the expectations lines to not be modified
2628         outside of TestExpectationsParser so we can cache the results.
2629         This makes check-webkit-style of the chromium test_expectations.txt file
2630         go from ~17 seconds to ~12 seconds on my Mac Pro.
2631
2632         This patch is just a refactor in preparation, so no new tests.
2633
2634         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2635         (TestExpectationEditorTests.make_parsed_expectation_lines):
2636         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2637         (TestExpectationParser.parse):
2638         (TestExpectationParser):
2639         (TestExpectationParser._parse_line):
2640         (TestExpectationParser._tokenize):
2641         (TestExpectationParser._tokenize_list):
2642         (TestExpectationsModel._clear_expectations_for_test):
2643         (TestExpectations.__init__):
2644         (TestExpectations._add_expectations):
2645         (TestExpectations._add_skipped_tests):
2646         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2647         (TestExpectationParserTests.test_tokenize_blank):
2648         (TestExpectationParserTests.test_tokenize_missing_colon):
2649         (TestExpectationParserTests.test_tokenize_extra_colon):
2650         (TestExpectationParserTests.test_tokenize_empty_comment):
2651         (TestExpectationParserTests.test_tokenize_comment):
2652         (TestExpectationParserTests.test_tokenize_missing_equal):
2653         (TestExpectationParserTests.test_tokenize_extra_equal):
2654         (TestExpectationParserTests.test_tokenize_valid):
2655         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2656         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2657         (TestExpectationParserTests.test_parse_empty_string):
2658         (TestExpectationSerializerTests.assert_round_trip):
2659         (TestExpectationSerializerTests.assert_list_round_trip):
2660         * Scripts/webkitpy/tool/commands/expectations.py:
2661         (OptimizeExpectations.execute):
2662         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2663         (GardeningExpectationsUpdater.update_expectations):
2664
2665 2012-01-20  Adam Barth  <abarth@webkit.org>
2666
2667         Follow-up to previous patch: don't produce NaN when the revision number
2668         is missing.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2672
2673 2012-01-20  Adam Barth  <abarth@webkit.org>
2674
2675         Garden-o-matic should tell me which revisions have been checked by all the bots
2676         https://bugs.webkit.org/show_bug.cgi?id=76722
2677
2678         Reviewed by Dimitri Glazkov.
2679
2680         This information helps me know when it's safe for me to roll a
2681         candidate revision.
2682
2683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2686
2687 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2688
2689         build-webkit: Don't spit out congratulations message on Ctrl+C
2690
2691         Reviewed by Andreas Kling.
2692
2693         * Scripts/build-webkit:
2694
2695 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2696
2697         [GTK] Allow extra jhbuild modulesets
2698         https://bugs.webkit.org/show_bug.cgi?id=76691
2699
2700         Reviewed by Gustavo Noronha Silva.
2701
2702         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2703         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2704         env variables respectively. Use comma-separated values. Example:
2705         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2706
2707 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2708
2709         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2710         https://bugs.webkit.org/show_bug.cgi?id=72589
2711
2712         Reviewed by Martin Robinson.
2713
2714         Ensure the accessibility infrastructure is available when running
2715         the unit tests, otherwise WK2's accessibility tests won't work.
2716
2717         * Scripts/run-gtk-tests:
2718         (TestRunner):
2719         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2720         where at-spi2's stuff is located (like at-spi-bus-launcher and
2721         at-spi2-registryd).
2722         (TestRunner.run): Initialize the accessibility infrastructure.
2723
2724         * gtk/generate-gtkdoc:
2725         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
2726
2727         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
2728
2729 2012-01-20  Hayato Ito  <hayato@chromium.org>
2730
2731         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
2732         https://bugs.webkit.org/show_bug.cgi?id=76353
2733
2734         Reviewed by Hajime Morita.
2735
2736         Add ShadowRoot.idl, which is enabled only on chromium port since this is
2737         under development feature.
2738         ShadowRoot.idl contains minimum API so that we can test it.
2739         Other APIs should be added on other changes so that we can isolate issues.
2740
2741         * DumpRenderTree/chromium/TestShell.cpp:
2742         (TestShell::TestShell):
2743
2744 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2745
2746         [GTK] GTK's DRT not to log events for already defunct objects
2747         https://bugs.webkit.org/show_bug.cgi?id=76620
2748
2749         Reviewed by Martin Robinson.
2750
2751         Do not log 'state-change:defunct' events.
2752
2753         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2754         (printAccessibilityEvent): Early return if a
2755         'state-change:defunct' signal is passed.
2756         (axObjectEventListener): Pass the signal name and value in
2757         separate parameters to printAccessibilityEvent.
2758
2759 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2760
2761         Unreviewed build fix. Wrong variable being used as the cwd for git
2762         remote update command.
2763
2764         * gtk/run-with-jhbuild:
2765         (update_jhbuild):
2766
2767 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2768
2769         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
2770         https://bugs.webkit.org/show_bug.cgi?id=76585
2771
2772         Reviewed by Martin Robinson.
2773
2774         This allows us to specify a minimum version of jhbuild required,
2775         while also providing stability against changes done to the master
2776         branch, by letting us choose what is the exact version that will
2777         be used.
2778
2779         * gtk/run-with-jhbuild: refactored for more hackability and easier
2780         reading
2781         (jhbuild_installed): checks whether jhbuild is installed
2782         (jhbuild_cloned): checks whether jhbuild has been cloned
2783         (jhbuild_at_expected_revision): checks whether jhbuild is at the
2784         expected revision
2785         (update_jhbuild): brings jhbuild to the expected revision
2786         (clone_jhbuild): clones jhbuild
2787         (install_jhbuild): build and installs jhbuild
2788         (update_webkitgtk_libs): runs update-webkitgtk-libs
2789         (ensure_jhbuild): high-level logic to decide whether and which of
2790         the steps above are executed
2791
2792 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2793
2794         [WK2] DumpRenderTree converts "file:///" to a path differently
2795         https://bugs.webkit.org/show_bug.cgi?id=76653
2796
2797         Reviewed by John Sullivan.
2798
2799         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
2800         Do print a slash if there are no path components.
2801
2802 2012-01-19  Eric Seidel  <eric@webkit.org>
2803
2804         webkit-patch cannot rollout patches without changelog/bug number
2805         https://bugs.webkit.org/show_bug.cgi?id=75962
2806
2807         Reviewed by Adam Barth.
2808
2809         * Scripts/webkitpy/tool/commands/download.py:
2810         (AbstractRolloutPrepCommand._prepare_state):
2811         * Scripts/webkitpy/tool/commands/download_unittest.py:
2812         (AbstractRolloutPrepCommandTest.test_prepare_state):
2813
2814 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2815
2816         [WK2] fast/url/degenerate-file-base.html fails
2817         https://bugs.webkit.org/show_bug.cgi?id=76619
2818
2819         Reviewed by Adam Roben.
2820
2821         A URL generated form local path for loading had an extra slash, making document.URL
2822         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
2823
2824         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
2825
2826 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2827
2828         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
2829         https://bugs.webkit.org/show_bug.cgi?id=76510
2830
2831         Reviewed by Adam Barth.
2832
2833         Unlike other style rules, if you get the syntax of the test_expectations.txt
2834         file wrong, the layout tests won't run. Also, this check is simple and only
2835         slows down committing if you actually modify one of the test_expectations.txt files.
2836
2837         * Scripts/webkitpy/style/checkers/test_expectations.py:
2838         (TestExpectationsChecker.check_test_expectations):
2839         (TestExpectationsChecker.check):
2840         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2841         (TestExpectationsTestCase.test_check_covers_all_configurations):
2842         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
2843         (TestExpectationsTestCase):
2844         (assert_lines_lint):
2845
2846 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2847
2848         Build fix. Revert an unintentional change to WebKitDriver in r105443.
2849
2850         * Scripts/webkitpy/layout_tests/port/driver.py:
2851         (DriverProxy.__init__):
2852
2853 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
2854
2855         remove the duplicated build rules from WebKit.gyp, Tools.gyp
2856         https://bugs.webkit.org/show_bug.cgi?id=73384
2857
2858         Reviewed by Tony Chang.
2859
2860         This patch removes the no-longer-necessary conditional logic for
2861         build_webkit_exes_from_webkit_gyp; we now always build the exes
2862         from their own dedicated gyp files.
2863
2864         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2865
2866 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2867
2868         make-new-script-test should work with HTTP tests
2869         https://bugs.webkit.org/show_bug.cgi?id=76603
2870
2871         Reviewed by Adam Roben.
2872
2873         * Scripts/make-new-script-test:
2874         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
2875         now also creates absolute paths for HTTP.
2876
2877 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2878
2879         Some perf tests time out when ran by run-perf-tests
2880         https://bugs.webkit.org/show_bug.cgi?id=76612
2881
2882         Reviewed by Dirk Pranke and Eric Seidel.
2883
2884         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
2885         Otherwise some tests such as Parser/xml-parser.html will timeout.
2886
2887         --no-timeout option is currently supported by Chromium and Mac ports.
2888
2889         * Scripts/webkitpy/layout_tests/port/base.py:
2890         (Port.to.create_driver):
2891         * Scripts/webkitpy/layout_tests/port/chromium.py:
2892         (ChromiumDriver.__init__):
2893         (ChromiumDriver._wrapper_options):
2894         * Scripts/webkitpy/layout_tests/port/driver.py:
2895         (Driver.__init__):
2896         (DriverProxy.__init__):
2897         * Scripts/webkitpy/layout_tests/port/webkit.py:
2898         (WebKitDriver.__init__):
2899         (WebKitDriver.cmd_line):
2900         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2901         (WebKitDriverTest.test_read_binary_block):
2902         (WebKitDriverTest):
2903         (WebKitDriverTest.test_no_timeout):
2904         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2905         (get_tests_run.RecordingTestDriver.__init__):
2906         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2907         (PerfTestsRunner._parse_args):
2908         (PerfTestsRunner._run_tests_set):
2909         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2910         (create_runner):
2911
2912 2012-01-19  Ben Wells  <benwells@chromium.org>
2913
2914         Add support for window.print to chromium DRT
2915         https://bugs.webkit.org/show_bug.cgi?id=76479
2916
2917         When used in a test window.print goes into print mode and then
2918         straight out again. This will allow the afterprint event to be
2919         tested by having the afterprint event happen before the dump
2920         happens.
2921
2922         Reviewed by Mihai Parparita.
2923
2924         * DumpRenderTree/chromium/WebViewHost.cpp:
2925         (WebViewHost::printPage):
2926         * DumpRenderTree/chromium/WebViewHost.h:
2927
2928 2012-01-18  Enrica Casucci  <enrica@apple.com>
2929
2930         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
2931         https://bugs.webkit.org/show_bug.cgi?id=76588
2932         <rdar://problem/9325183>
2933
2934         Added test.
2935         
2936         Reviewed by Dan Bernstein.
2937
2938         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2939         (TestWebKitAPI::TEST):
2940
2941 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2942
2943         [Qt] Do full incremental builds until bots use update-webkit
2944
2945         Rubber-stamped by Simon Hausmann.
2946
2947         * Scripts/webkitdirs.pm:
2948         (buildQMakeProjects):
2949
2950 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2951
2952         Fix the Qt build
2953
2954         Unreviewed build fix.
2955
2956         * Scripts/webkitdirs.pm:
2957         (buildQMakeProjects):
2958
2959 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2960
2961         [Qt] Make build-webkit always do safe incremental builds after update-webkit
2962
2963         When building against Qt5 with GCC we would just run 'make' in the build dir,
2964         and rely on the dependency files output by GCC (-MD) to handle dependency
2965         tracking, but that fails for special-cases like adding a Q_OBJECT macro
2966         to a header.
2967
2968         To guarantee that an incrmental build will work, we have to run 'make qmake',
2969         which we now do on every build-webkit that's followed by a successful run
2970         of update-webkit. The reasoning is that update-webkit can result in such
2971         potential corner-cases being applied, and since we can't know for sure
2972         unless we inspect the diff and account for all the corner cases we assume
2973         the worst and always run 'make qmake'.
2974
2975         After a succesful run of build-webkit we proceed to do just 'make' for any
2976         subsequent runs, since we assume that the developer knows what kind of
2977         changes he/she is doing, and when a 'make qmake' is needed.
2978
2979         Reviewed by Simon Hausmann.
2980
2981         * Scripts/update-webkit:
2982         * Scripts/webkitdirs.pm:
2983         (determineCurrentSVNRevision):
2984         (currentSVNRevision):
2985         (buildQMakeProjects):
2986         * qmake/mkspecs/features/default_post.prf:
2987
2988 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
2989
2990         run-perf-tests should support Skipped list
2991         https://bugs.webkit.org/show_bug.cgi?id=76594
2992
2993         Reviewed by Adam Barth.
2994
2995         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
2996
2997         * Scripts/webkitpy/layout_tests/port/base.py:
2998         (Port.perf_tests_dir):
2999         (Port.skipped_perf_tests):
3000         (Port.skips_perf_test):
3001         (Port.relative_perf_test_filename):
3002         * Scripts/webkitpy/layout_tests/port/test.py:
3003         (TestPort.perf_tests_dir):
3004         * Scripts/webkitpy/layout_tests/port/webkit.py:
3005         (WebKitPort._expectations_from_skipped_files):
3006         (WebKitPort):
3007         (WebKitPort.skipped_layout_tests):
3008         (WebKitPort.skipped_perf_tests):
3009         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3010         (PerfTestsRunner._collect_tests):
3011         (PerfTestsRunner.run):
3012         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3013         (test_run_test_set_with_json_output):
3014         (test_run_test_set_with_json_source):
3015         (test_collect_tests_with_skipped_list):
3016         (test_collect_tests_with_skipped_list.add_file):
3017
3018 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3019
3020         Fix path to chromium_src_dir introduced in previous change.
3021
3022         Unreviewed, build fix.
3023
3024         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3025
3026 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3027
3028         Need infrastructure to test Content-Disposition filename encoding support
3029         https://bugs.webkit.org/show_bug.cgi?id=76572
3030         <rdar://problem/6421825>
3031
3032         Reviewed by Sam Weinig.
3033
3034         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3035
3036         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3037
3038         * DumpRenderTree/mac/PolicyDelegate.mm:
3039         (dispositionTypeFromContentDispositionHeader):
3040         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3041
3042 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3043
3044         Fix tests from http://trac.webkit.org/changeset/105332.
3045
3046         The code assumed that if you passed an options object with a configuration
3047         attribute that it would have a valid value. A bunch of the testing mocks
3048         do things like having a configuration value of None.
3049
3050         * Scripts/webkitpy/layout_tests/port/base.py:
3051         (Port.__init__):
3052
3053 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3054
3055         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3056         https://bugs.webkit.org/show_bug.cgi?id=76576
3057
3058         Reviewed by Adam Barth.
3059
3060         Avoid calling default_configuration in base.py. We don't need it for
3061         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3062         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3063         from common.executive.
3064
3065         At some point someone should probably look into why that call is so slow
3066         since it's on the critical path for run-webkit-tests and build-webkit startup.
3067
3068         * Scripts/webkitpy/layout_tests/port/base.py:
3069         (Port.__init__):
3070         * Scripts/webkitpy/style/checkers/test_expectations.py:
3071         (TestExpectationsChecker._determine_port_from_exepectations_path):
3072
3073 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3074
3075         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3076         https://bugs.webkit.org/show_bug.cgi?id=76505
3077
3078         Reviewed by Tony Chang.
3079
3080         Update chromium build script to use All.gyp instead of WebKit.gyp
3081
3082         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3083         * Scripts/webkitdirs.pm:
3084
3085 2012-01-18  Sam Weinig  <sam@webkit.org>
3086
3087         Don’t hardcode the path to ‘make‘.
3088
3089         Reviewed by Dan Bernstein.
3090
3091         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3092
3093 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3094
3095         Adding myself to committers.py
3096         https://bugs.webkit.org/show_bug.cgi?id=76569
3097
3098         Unreviewed.
3099
3100         * Scripts/webkitpy/common/config/committers.py:
3101
3102 2012-01-18  Adam Barth  <abarth@webkit.org>
3103
3104         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3105         https://bugs.webkit.org/show_bug.cgi?id=76567
3106
3107         Reviewed by Eric Seidel.
3108
3109         Current the AppleMac port has slightly more failures than we allow on
3110         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3111         which should hopefully let the mac-ews run to completion.  Once
3112         AppleMac has fewer failures, we can lower the cap again.
3113
3114         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3115         (LayoutTestResultsReaderTest.test_layout_test_results):
3116         * Scripts/webkitpy/tool/steps/runtests.py:
3117         (RunTests):
3118         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3119
3120 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3121
3122         Provide access to user's list of preferred languages
3123         https://bugs.webkit.org/show_bug.cgi?id=76138
3124
3125         Reviewed by Alexey Proskuryakov.
3126
3127         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3128
3129 2012-01-18  Adam Barth  <abarth@webkit.org>
3130
3131         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3132         configurations.
3133
3134         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3135         (ChromiumLinuxPort.__init__):
3136
3137 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3138
3139         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3140         https://bugs.webkit.org/show_bug.cgi?id=73460
3141
3142         Reviewed by Chris Fleizach.
3143
3144         * DumpRenderTree/AccessibilityUIElement.h:
3145         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3146         (AccessibilityUIElement::AccessibilityUIElement):
3147         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3148         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3149         (AccessibilityUIElement::scrollToGlobalPointCallback):
3150         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3151         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3152         (AccessibilityUIElement::scrollToMakeVisible):
3153         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3154         (AccessibilityUIElement::scrollToGlobalPoint):
3155         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3156         (AccessibilityUIElement::scrollToMakeVisible):
3157         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3158         (AccessibilityUIElement::scrollToGlobalPoint):
3159         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3160         (AccessibilityUIElement::scrollToMakeVisible):
3161         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3162         (AccessibilityUIElement::scrollToGlobalPoint):
3163
3164 2012-01-17  Enrica Casucci  <enrica@apple.com>
3165
3166         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3167         https://bugs.webkit.org/show_bug.cgi?id=76490
3168         <rdar://problem/9460733>
3169
3170         Added TestWebKitAPI test.
3171         
3172         Reviewed by Dan Bernstein.
3173
3174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3175         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3176         changeAttributes to the WebView.
3177         
3178 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3179
3180         [Qt] Consolidate layout test crash logging
3181         https://bugs.webkit.org/show_bug.cgi?id=75088
3182
3183         Reviewed by Simon Hausmann.
3184
3185         Move backtrace generating logic into WTFReportBacktrace
3186         and add a way to deinstall signal handlers if we know
3187         that we have already printed the backtrace.
3188
3189         * DumpRenderTree/qt/main.cpp:
3190         (crashHandler):
3191         (setupSignalHandlers):
3192         (WTFCrashHook):
3193         (main):
3194         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3195         (WTR::crashHandler):
3196         (WTR::setupSignalHandlers):
3197         (WTR::crashHook):
3198         (WTR::InjectedBundle::platformInitialize):
3199
3200 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3201
3202         Unreviewed build fix after r105256.
3203
3204         There was a cyclic dependency between self._port and self._host assigments.
3205
3206         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3207         (PerfTestsRunner.__init__):
3208
3209 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3210
3211         Add new watchlist rule for the Qt build system
3212
3213         Reviewed by Simon Hausmann.
3214
3215         * Scripts/webkitpy/common/config/watchlist:
3216
3217 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3218
3219         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3220
3221         Reviewed by Simon Hausmann.
3222
3223         * Tools.pro:
3224
3225 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3226
3227         [Qt] Allow building only a subset of the WebKit sub-projects
3228
3229         Fixes build-jsc, broken in r104825.
3230
3231         We no longer need the intermediate buildQMakeQtProject(), as we're the
3232         only port using qmake, and buildQMakeProject is now highly Qt specific.
3233
3234         <http://webkit.org/b/76179>
3235
3236         Reviewed by Simon Hausmann.
3237
3238         * Scripts/build-jsc:
3239         * Scripts/build-webkit:
3240         * Scripts/webkitdirs.pm:
3241         (buildQMakeProjects):
3242
3243 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3244
3245         run-perf-tests should generate a json file that summaries the result
3246         https://bugs.webkit.org/show_bug.cgi?id=76504
3247
3248         Reviewed by Adam Barth.
3249
3250         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
3251         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
3252         another json file to be merged into the generated json file.
3253
3254         Also fixed a bug that --build wasn't set by default.
3255
3256         * Scripts/webkitpy/layout_tests/port/test.py:
3257         (TestPort.webkit_base):
3258         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3259         (PerfTestsRunner.__init__):
3260         (PerfTestsRunner):
3261         (PerfTestsRunner._parse_args):
3262         (PerfTestsRunner.run):
3263         (PerfTestsRunner._generate_json_if_specified):
3264         (PerfTestsRunner._process_chromium_style_test_result):
3265         (PerfTestsRunner._process_parser_test_result):
3266         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3267         (MainTest):
3268         (create_runner):
3269         (test_run_test_set):
3270         (test_run_test_set_for_parser_tests):
3271         (test_run_test_set_with_summary_json):
3272         (test_collect_tests):
3273         (test_parse_args):
3274
3275 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3276
3277         Unreviewed, rolling out r105244.
3278         http://trac.webkit.org/changeset/105244
3279         https://bugs.webkit.org/show_bug.cgi?id=76518
3280
3281         broke Chromium Mac (Requested by rolandsteiner on #webkit).
3282
3283         * DumpRenderTree/AccessibilityUIElement.h:
3284         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3285         (AccessibilityUIElement::AccessibilityUIElement):
3286         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3287         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3288         (AccessibilityUIElement::removeSelection):
3289         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3290         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3291         (AccessibilityUIElement::removeSelection):
3292
3293 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
3294
3295         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3296         https://bugs.webkit.org/show_bug.cgi?id=73460
3297
3298         Reviewed by Chris Fleizach.
3299
3300         * DumpRenderTree/AccessibilityUIElement.h:
3301         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3302         (AccessibilityUIElement::AccessibilityUIElement):
3303         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3304         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3305         (AccessibilityUIElement::scrollToGlobalPointCallback):
3306         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3307         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3308         (AccessibilityUIElement::scrollToMakeVisible):
3309         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3310         (AccessibilityUIElement::scrollToGlobalPoint):
3311         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3312         (AccessibilityUIElement::scrollToMakeVisible):
3313         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3314         (AccessibilityUIElement::scrollToGlobalPoint):
3315         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3316         (AccessibilityUIElement::scrollToMakeVisible):
3317         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3318         (AccessibilityUIElement::scrollToGlobalPoint):
3319
3320 2012-01-17  Adam Barth  <abarth@webkit.org>
3321
3322         Enable tests on the mac-ews
3323         https://bugs.webkit.org/show_bug.cgi?id=76502
3324
3325         Reviewed by Simon Fraser.
3326
3327         Apple now has five machines running the mac-ews.  Lucas Forschler has
3328         asked that we try enabling tests to see if we have enough bandwidth.
3329
3330         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3331         (MacEWS):
3332
3333 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
3334
3335         Add a check-webkit-style exception for GDBInterface.cpp
3336         https://bugs.webkit.org/show_bug.cgi?id=76187
3337
3338         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
3339         that it does not fail the style check.
3340
3341         Reviewed by Martin Robinson.
3342
3343         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
3344         readability/naming tests on
3345         Source/JavaScriptCore/jit/GDBInterface.cpp.
3346         * Scripts/webkitpy/style/checker_unittest.py:
3347         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
3348         the above exception.
3349
3350 2012-01-17  Hajime Morrita  <morrita@chromium.org>
3351
3352         https://bugs.webkit.org/show_bug.cgi?id=76245
3353         [Mac][DRT] should allow query string for the file URL.
3354
3355         Reviewed by Tony Chang.
3356
3357         Taught DRT about file:// as a url instead of a file path.
3358         We are now able to use a path file:///foo/bar.html?baz as a url
3359         with which DRT opens "/foo/bar.html" with "baz" as a query string.
3360
3361         * DumpRenderTree/mac/DumpRenderTree.mm:
3362         (runTest):
3363
3364 2012-01-17  Ojan Vafai  <ojan@chromium.org>
3365
3366         Check style on test_expectations.txt files before commit
3367         https://bugs.webkit.org/show_bug.cgi?id=76484
3368
3369         Reviewed by Adam Barth.
3370
3371         Unlike other style rules, if you get the syntax of the test_expectations.txt
3372         file wrong, the layout tests won't run. Also, this check is simple and only
3373         slows down committing if you actually modify one of the test_expectations.txt files.
3374
3375         * Scripts/webkitpy/tool/steps/commit.py:
3376         (Commit._check_test_expectations):
3377         (Commit.run):
3378         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
3379         (CommitTest):
3380         (CommitTest.test_check_test_expectations):
3381
3382 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3383
3384         [Qt] Debug build fails with debug qt5
3385         https://bugs.webkit.org/show_bug.cgi?id=76463
3386
3387         Reviewed by Simon Hausmann.
3388
3389         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
3390
3391         * QtTestBrowser/cookiejar.h:
3392
3393 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3394
3395         webkitpy: fix json import on linux
3396         https://bugs.webkit.org/show_bug.cgi?id=76481
3397
3398         Reviewed by Adam Barth.
3399
3400         For some reason, the version of simplejson autoinstalled on my linux
3401         box seems to be broken. We should really only be using
3402         simplejson if json isn't available anyway, so this change looks
3403         for json first.
3404
3405         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3406         (JSONGeneratorTest.test_test_timings_trie):
3407
3408 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3409
3410         Fix failures in test-webkitpy caused by r105177.
3411
3412         Unreviewed, build fix.
3413
3414         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3415         (ChromiumLinuxPort._determine_driver_path_statically):
3416         (ChromiumLinuxPort._static_build_path):
3417
3418 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3419
3420         webkitpy: make PortFactory.get() be fully data-driven
3421         https://bugs.webkit.org/show_bug.cgi?id=76360
3422
3423         Reviewed by Eric Seidel.
3424
3425         Refactor PortFactory.get() to be fully data-driven.
3426
3427         * Scripts/webkitpy/layout_tests/port/factory.py:
3428         (PortFactory):
3429         (PortFactory._default_port):
3430         (PortFactory.get):
3431         (PortFactory.get.in):
3432         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3433         (FactoryTest.assert_port):
3434
3435 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3436
3437         webkitpy: add determine_full_port_name(), clean up port.__init__()
3438         https://bugs.webkit.org/show_bug.cgi?id=76357
3439
3440         Reviewed by Adam Barth.
3441
3442         Each Port class is now required to implement a 'port_name' field
3443         that will match the start of all ports constructed by this class and
3444         a 'determine_full_port_name' field that will make the port
3445         fully-qualified.
3446
3447         * Scripts/webkitpy/layout_tests/port/apple.py:
3448         (ApplePort.__init__):
3449         * Scripts/webkitpy/layout_tests/port/base.py:
3450         (Port):
3451         (Port.determine_port_name):
3452         (Port.__init__):
3453         * Scripts/webkitpy/layout_tests/port/chromium.py:
3454         (ChromiumPort.for):
3455         (ChromiumPort.__init__):
3456         (ChromiumPort):
3457         (ChromiumPort._chromium_base_dir):
3458         (ChromiumPort.path_from_chromium_base):
3459         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3460         (ChromiumGpuLinuxPort):
3461         (ChromiumGpuLinuxPort.__init__):
3462         (ChromiumGpuMacPort):
3463         (ChromiumGpuMacPort.__init__):
3464         (ChromiumGpuWinPort):
3465         (ChromiumGpuWinPort.__init__):
3466         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3467         (ChromiumLinuxPort):
3468         (ChromiumLinuxPort.determine_port_name):
3469         (ChromiumLinuxPort.__init__):
3470         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3471         (ChromiumMacPort):
3472         (ChromiumMacPort.determine_port_name):
3473         (ChromiumMacPort.__init__):
3474         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3475         (ChromiumWinPort):
3476         (ChromiumWinPort.determine_port_name):
3477         (ChromiumWinPort.__init__):
3478         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3479         (DryRunPort):
3480         (DryRunPort.determine_port_name):
3481         (DryRunPort.__init__):
3482         * Scripts/webkitpy/layout_tests/port/efl.py:
3483         (EflPort):
3484         * Scripts/webkitpy/layout_tests/port/factory.py:
3485         (PortFactory):
3486         (PortFactory._default_port):
3487         (PortFactory.get):
3488         (PortFactory.get.in):
3489         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3490         (FactoryTest.assert_port):
3491         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3492         (GoogleChromeLinux32Port):
3493         (GoogleChromeLinux32Port.determine_port_name):
3494         (GoogleChromeLinux64Port):
3495         (GoogleChromeLinux64Port.determine_port_name):
3496         (GoogleChromeMacPort):
3497         (GoogleChromeMacPort.determine_port_name):
3498         (GoogleChromeWinPort):
3499         (GoogleChromeWinPort.determine_port_name):
3500         * Scripts/webkitpy/layout_tests/port/gtk.py:
3501         (GtkPort):
3502         * Scripts/webkitpy/layout_tests/port/mac.py:
3503         (MacPort):
3504         (MacPort.determine_port_name):
3505         (MacPort.__init__):
3506         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3507         (test_versions):
3508         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3509         (MockDRTPort):
3510         (MockDRTPort.determine_port_name):
3511         (MockDRTPort.__init__):
3512         (MockDRT):
3513         (MockDRT.determine_port_name):
3514         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3515         (PortTestCase.make_port):
3516         * Scripts/webkitpy/layout_tests/port/qt.py:
3517         (QtPort):
3518         (QtPort.determine_port_name):
3519         (QtPort.__init__):
3520         * Scripts/webkitpy/layout_tests/port/test.py:
3521         (TestPort):
3522         (TestPort.determine_port_name):
3523         (TestPort.__init__):
3524         * Scripts/webkitpy/layout_tests/port/webkit.py:
3525         (WebKitPort.__init__):
3526         * Scripts/webkitpy/layout_tests/port/win.py:
3527         (WinPort):
3528         (WinPort.determine_port_name):
3529         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3530         (get_test_baselines.AllPlatformsPort.__init__):
3531         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3532         (get_test_config.TestMacPort):
3533         (get_test_config):
3534
3535 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3536
3537         webkitpy: clean up port code in preparation for static port names
3538         https://bugs.webkit.org/show_bug.cgi?id=76356
3539
3540         Reviewed by Adam Barth.
3541
3542         To fix bug 76215 and be able to determine appropriate port names
3543         in webkitpy without actually constructing Port objects, we need
3544         to shuffle some logic in the chromium ports to be able to figure
3545         out whether we built DRT in 32 or 64-bit mode.
3546
3547         * Scripts/webkitpy/layout_tests/port/chromium.py:
3548         (ChromiumPort):
3549         (ChromiumPort._chromium_base_dir):
3550         (ChromiumPort.__init__):
3551         (ChromiumPort.path_from_chromium_base):
3552         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3553         (ChromiumLinuxPort):
3554         (ChromiumLinuxPort._determine_driver_path_statically):
3555         (ChromiumLinuxPort._static_build_path):
3556         (ChromiumLinuxPort._determine_architecture):
3557         (ChromiumLinuxPort.__init__):
3558         (ChromiumLinuxPort._build_path):
3559
3560 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
3561
3562         Do not remove pixel failures for ref tests.
3563         https://bugs.webkit.org/show_bug.cgi?id=76243
3564
3565         Reviewed by Tony Chang.
3566
3567         'NRWT --no-pixel-tests' complains when reftests are expected to
3568         be image mismatch.
3569
3570         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3571         (Manager._update_summary_with_result):
3572         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3573         (is_reftest_failure):
3574         (determine_result_type):
3575
3576 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3577
3578         REGRESSION(r81225): ORWT should ignore reftests
3579         https://bugs.webkit.org/show_bug.cgi?id=67936
3580
3581         Reviewed by Csaba Osztrogonác.
3582
3583         * Scripts/old-run-webkit-tests:
3584         (isUsedInReftest): $filename should be the first parameter
3585         (findTestsToRun): run test if it isn't reftest
3586
3587 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
3588
3589         Unreviewed. Fix python unit test I broke with r105142
3590
3591         * Scripts/webkitpy/common/config/ports_unittest.py:
3592         (WebKitPortTest.test_gtk_port):
3593
3594 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3595
3596         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
3597
3598         Qt 5 no longer has that flag.
3599
3600         Reviewed by Simon Hausmann.
3601
3602         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3603         (MiniBrowserApplication::notify):
3604
3605 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3606
3607         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
3608         https://bugs.webkit.org/show_bug.cgi?id=75857
3609
3610         Reviewed by Adam Barth.
3611
3612         * Scripts/webkitdirs.pm:
3613         (buildAutotoolsProject): move cleaning the build to happen early,
3614         and handle --update-gtk right after that
3615         * Scripts/webkitpy/common/config/ports.py:
3616         (GtkPort.build_webkit_command): pass --update-gtk as an option to
3617         build-webkit, so that it is used in the EWS
3618
3619 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3620
3621         [Qt] Don't add _debug postfix to targets when building debug only
3622
3623         Reviewed by Simon Hausmann.
3624
3625         * qmake/mkspecs/features/default_post.prf:
3626         * qmake/mkspecs/features/functions.prf:
3627
3628 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3629
3630         [Qt] Add more files to project-files for easier navigation in Qt Creator
3631
3632         Reviewed by Simon Hausmann.
3633
3634         * Tools.pro:
3635         * qmake/config.tests/README: Added.
3636
3637 2012-01-17  Philippe Normand  <pnormand@igalia.com>
3638
3639         [GTK] fast/dom/constructed-objects-prototypes.html fails
3640         https://bugs.webkit.org/show_bug.cgi?id=75432
3641
3642         Reviewed by Martin Robinson.
3643
3644         * Scripts/build-webkit: Enable video-track in GTK.
3645
3646 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
3647
3648         Add toyoshim as a committer.
3649         https://bugs.webkit.org/show_bug.cgi?id=76390
3650
3651         Reviewed by Hajime Morita.
3652
3653         * Scripts/webkitpy/common/config/committers.py:
3654
3655 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
3656
3657         [WinCairo] Build fix after r104155. Several debug targets were not
3658         properly including the '*Common' property sheets.
3659
3660         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
3661         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
3662         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
3663         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
3664         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
3665
3666 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
3667
3668         REGRESSION(r105072): It broke committers_unittest.py
3669         https://bugs.webkit.org/show_bug.cgi?id=76396
3670
3671         Reviewed by Adam Barth.
3672
3673         * Scripts/webkitpy/common/config/committers_unittest.py:
3674         (CommittersTest._assert_fuzz_match): It should handle more names.
3675         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
3676
3677 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
3678
3679         [GTK] Include gtk+3 in the jhbuild modules
3680         https://bugs.webkit.org/show_bug.cgi?id=76284
3681
3682         Reviewed by Philippe Normand.
3683
3684         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3685
3686 2012-01-16  Dan Winship  <danw@gnome.org>
3687